_ _ ____ _
___| | | | _ \| |
/ __| | | | |_) | |
| (__| |_| | _ <| |___
\___|\___/|_| \_\_____|
Changelog
Version 7.49.1 (30 May 2016)
Daniel Stenberg (30 May 2016)
- RELEASE-NOTES: 7.49.1
- [Steve Holme brought this change]
loadlibrary: Only load system DLLs from the system directory
Inspiration provided by: Daniel Stenberg and Ray Satiro
Bug: https://curl.haxx.se/docs/adv_20160530.html
Ref: Windows DLL hijacking with curl, CVE-2016-4802
- ssh: fix version number check typo
Jay Satiro (29 May 2016)
- curl_share_setopt.3: Add min ver needed for ssl session lock
Bug: https://github.com/curl/curl/issues/826
Reported-by: Michael Wallner
Daniel Stenberg (29 May 2016)
- ssh: fix build for libssh2 before 1.2.6
The statvfs functionality was added to libssh2 in that version, so we
switch off that functionality when built with older libraries.
Fixes #831
- mbedtls: fix includes so snprintf() works
Regression from the previous *printf() rearrangements, this file missed to
include the correct header to make sure snprintf() works universally.
Reported-by: Moti Avrahami
Bug: https://curl.haxx.se/mail/lib-2016-05/0196.html
Steve Holme (23 May 2016)
- checksrc.pl: Added variants of strcat() & strncat() to banned function list
Added support for checking the tchar, unicode and mbcs variants of
strcat() and strncat() in the banned function list.
Daniel Stenberg (23 May 2016)
- smtp: minor ident (white space) fixes
- THANKS: updated after script fixes
Now giving credit properly to github user names, fixed some UTF-8 issues
and added names discovered when contrithanks was improved.
- THANKS-filter: more name cleanups
- contrithanks.sh: exclude existing names case insensitively
- contrithanks.sh: use same grep pattern and -a flag as contributors.sh
- contributors.sh: better grep pattern, use grep -a
- THANKS-filter: fix more names
- contrithanks.sh: do the same github fix as contributors.sh
from 1577bfa35ba
Jay Satiro (23 May 2016)
- contributors: Show GitHub username if real name unknown
Prior to this change if a GitHub contributor's real name was unknown
they would be omitted from the list.
Bug: https://github.com/curl/curl/issues/824
Daniel Stenberg (21 May 2016)
- RELEASE-NOTES: synced with 3caaeffbe8ded4
Jay Satiro (20 May 2016)
- openssl: cleanup must free compression methods
- Free compression methods if OpenSSL 1.0.2 to avoid a memory leak.
Bug: https://github.com/curl/curl/issues/817
Reported-by: jveazey@users.noreply.github.com
Daniel Stenberg (20 May 2016)
- [Gisle Vanem brought this change]
curl_multibyte: fix compiler error
While compiling lib/curl_multibyte.c with '-DUSE_WIN32_IDN' etc. I was
getting:
f:\mingw32\src\inet\curl\lib\memdebug.h(38): error C2054: expected '('
to follow 'CURL_EXTERN'
f:\mingw32\src\inet\curl\lib\memdebug.h(38): error C2085:
'curl_domalloc': not in formal parameter list
- THANKS-filter: make Jan-E get proper credit
- [Jan-E brought this change]
winbuild/Makefile.vc: Fix check on SSL, MBEDTLS, WINSSL exclusivity
Closes #818
- [Alexander Traud brought this change]
libcurl.m4: Avoid obsolete warning
Closes #821
Jay Satiro (20 May 2016)
- [Michael Kaufmann brought this change]
CURLOPT_CONNECT_TO.3: user must not free the list prematurely
The connect-to list isn't copied so as long as the handle may be used
for a transfer the list must be valid.
Bug: https://github.com/curl/curl/pull/819
Reported-by: Michael Kaufmann
Daniel Stenberg (19 May 2016)
- RELEASE-NOTES: synced with 48114a8634242c
- openssl: ERR_remove_thread_state() is deprecated in latest 1.1.0
See OpenSSL commit 21e001747d4a
- http2: use HTTP/2 in the HTTP/1.1-alike header
... when generating them, not "2.0" as the protocol is called just
HTTP/2 and nothing else.
Jay Satiro (19 May 2016)
- dist: include curl_multi_socket_all.3
Closes https://github.com/curl/curl/pull/816
Steve Holme (18 May 2016)
- bump: Start work on 7.49.1
Daniel Stenberg (18 May 2016)
- curlbuild.h.dist: check __LP64__ as well to fix MIPS build
The preprocessor check that sets up the 32bit defines for non-configure
builds didn't work properly for MIPS systems as __mips__ is defined for
both 32bit and 64bit. Now __LP64__ is also checked and indicates 64bit.
Reported-by: Tomas Jakobsson
Fixes #813
- [Marcel Raad brought this change]
schannel: fix compile break with MSVC XP toolset
For the Windows XP toolset of Visual C++ 2013/2015, the old Windows SDK
7.1 is used. In this case, _USING_V110_SDK71_ is defined.
Closes #812
- dist: include CHECKSRC.md
Reported-by: Paul Howarth
Bug: https://curl.haxx.se/mail/lib-2016-05/0116.html
- test/Makefile.am: include manpage-scan.pl and nroff-scan.pl in dist
Reported-by: Ray Satiro
Bug: https://curl.haxx.se/mail/lib-2016-05/0113.html
Version 7.49.0 (17 May 2016)
Daniel Stenberg (17 May 2016)
- THANKS: 24 new names from 7.49.0 release notes
- RELEASE-NOTES: 7.49.0
- mbedtls/polarssl: set "hostname" unconditionally
...as otherwise the TLS libs will skip the CN/SAN check and just allow
connection to any server. curl previously skipped this function when SNI
wasn't used or when connecting to an IP address specified host.
CVE-2016-3739
Bug: https://curl.haxx.se/docs/adv_20160518A.html
Reported-by: Moti Avrahami
- [Frank Gevaerts brought this change]
CURLOPT_RESOLVE.3: fix typo
Closes #811
- docs: CURLOPT_RESOLVE overrides CURLOPT_IPRESOLVE
- KNOWN_BUGS: GnuTLS backend skips really long certificate fields
Closes #762
- CURLOPT_HTTPPOST.3: the data needs to be around while in use
- openssl: get_cert_chain: fix NULL dereference
CID 1361815: Explicit null dereferenced (FORWARD_NULL)
- openssl: get_cert_chain: avoid NULL dereference
CID 1361811: Explicit null dereferenced (FORWARD_NULL)
- dprintf_formatf: fix (false?) Coverity warning
CID 1024412: Memory - illegal accesses (OVERRUN). Claimed to happen when
we run over 'workend' but the condition says <= workend and for all I
can see it should be safe. Compensating for the warning by adding a byte
margin in the buffer.
Also, removed the extra brace level indentation in the code and made it
so that 'workend' is only assigned once within the function.
- RELEASE-NOTES: synced with 2dcb5adc72d6
- THANKS-filter: fixed Jonathan Cardoso
Jay Satiro (15 May 2016)
- ftp: fix incorrect out-of-memory code in Curl_pretransfer
- Return value type must match function type.
s/CURLM_OUT_OF_MEMORY/CURLE_OUT_OF_MEMORY/
Caught by Travis CI
Daniel Stenberg (15 May 2016)
- ftp wildcard: segfault due to init only in multi_perform
The proper FTP wildcard init is now more properly done in Curl_pretransfer()
and the corresponding cleanup in Curl_close().
The previous place of init/cleanup code made the internal pointer to be NULL
when this feature was used with the multi_socket() API, as it was made within
the curl_multi_perform() function.
Reported-by: Jonathan Cardoso Machado
Fixes #800
Jay Satiro (13 May 2016)
- libcurl-tlibcurl-thread: Update OpenSSL links
Because the old OpenSSL link now redirects to their master documentation
(currently 1.1.0), which does not document the required actions for
OpenSSL <= 1.0.2.
Daniel Stenberg (13 May 2016)
- [Viktor Szakats brought this change]
darwinssl.c: fix OS X codename typo in comment
- RELEASE-NOTES: synced with 68701e51c1f7
Added 8 bug fixes and 5 more contrbutors
- [Jay Satiro brought this change]
mprintf: Fix processing of width and prec args
Prior to this change a width arg could be erroneously output, and also
width and precision args could not be used together without crashing.
"%0*d%s", 2, 9, "foo"
Before: "092"
After: "09foo"
"%*.*s", 5, 2, "foo"
Before: crash
After: " fo"
Test 557 is updated to verify this and more
- [Michael Kaufmann brought this change]
ConnectionExists: follow-up fix for proxy re-use
Follow-up commit to 5823179
Closes #648
- [Per Malmberg brought this change]
darwinssl: fix certificate verification disable on OS X 10.8
The new way of disabling certificate verification doesn't work on
Mountain Lion (OS X 10.8) so we need to use the old way in that version
too. I've tested this solution on versions 10.7.5, 10.8, 10.9, 10.10.2
and 10.11.
Closes #802
- [Cory Benfield brought this change]
http2: Add space between colon and header value
curl's representation of HTTP/2 responses involves transforming the
response to a format that is similar to HTTP/1.1. Prior to this change,
curl would do this by separating header names and values with only a
colon, without introducing a space after the colon.
While this is technically a valid way to represent a HTTP/1.1 header
block, it is much more common to see a space following the colon. This
change introduces that space, to ensure that incautious tools are safely
able to parse the header block.
This also ensures that the difference between the HTTP/1.1 and HTTP/2
response layout is as minimal as possible.
Bug: https://github.com/curl/curl/issues/797
Closes #798
Fixes #797
Kamil Dudka (12 May 2016)
- openssl: fix compile-time warning in Curl_ossl_check_cxn()
... introduced in curl-7_48_0-293-g2968c83:
Error: COMPILER_WARNING:
lib/vtls/openssl.c: scope_hint: In function ‘Curl_ossl_check_cxn’
lib/vtls/openssl.c:767:15: warning: conversion to ‘int’ from ‘ssize_t’
may alter its value [-Wconversion]
Jay Satiro (11 May 2016)
- openssl: stricter connection check function
- In the case of recv error, limit returning 'connection still in place'
to EINPROGRESS, EAGAIN and EWOULDBLOCK.
This is an improvement on the parent commit which changed the openssl
connection check to use recv MSG_PEEK instead of SSL_peek.
Ref: https://github.com/curl/curl/commit/856baf5#comments
Daniel Stenberg (11 May 2016)
- [Anders Bakken brought this change]
TLS: SSL_peek is not a const operation
Calling SSL_peek can cause bytes to be read from the raw socket which in
turn can upset the select machinery that determines whether there's data
available on the socket.
Since Curl_ossl_check_cxn only tries to determine whether the socket is
alive and doesn't actually need to see the bytes SSL_peek seems like
the wrong function to call.
We're able to occasionally reproduce a connect timeout due to this
bug. What happens is that Curl doesn't know to call SSL_connect again
after the peek happens since data is buffered in the SSL buffer and thus
select won't fire for this socket.
Closes #795
Jay Satiro (9 May 2016)
- [Daniel Stenberg brought this change]
TLS: move the ALPN/NPN enable bits to the connection
Only protocols that actually have a protocol registered for ALPN and NPN
should try to get that negotiated in the TLS handshake. That is only
HTTPS (well, http/1.1 and http/2) right now. Previously ALPN and NPN
would wrongly be used in all handshakes if libcurl was built with it
enabled.
Reported-by: Jay Satiro
Fixes #789
Daniel Stenberg (8 May 2016)
- libcurl-thread.3: openssl 1.1.0 is safe, and so is boringssl
- [Antonio Larrosa brought this change]
connect: fix invalid "Network is unreachable" errors
Sometimes, in systems with both ipv4 and ipv6 addresses but where the
network doesn't support ipv6, Curl_is_connected returns an error
(intermittently) even if the ipv4 socket connects successfully.
This happens because there's a for-loop that iterates on the sockets but
the error variable is not resetted when the ipv4 is checked and is ok.
This patch fixes this problem by setting error to 0 when checking the
second socket and not having a result yet.
Fixes #794
Jay Satiro (5 May 2016)
- FAQ: refer to thread safety guidelines
Daniel Stenberg (3 May 2016)
- connections: non-HTTP proxies on different ports aren't reused either
Reported-by: Oleg Pudeyev and fuchaoqun
Fixes #648
- http: make sure a blank header overrides accept_decoding
Reported-by: rcanavan
Assisted-by: Isaac Boukris
Closes #785
- CHECKSRC.md: clarified, explained the whitelist file
- nroff-scan.pl: verify that references are made with \fI
- docs: unified man page references to use \fI
- TODO: 17.14 --fail without --location should treat 3xx as a failure
Closes #727
- RELEASE-NOTES: synced with 7987f5cb14d
- [Isaac Boukris brought this change]
CURLOPT_ACCEPT_ENCODING.3: Follow-up clarification
Mention possible content-length mismatch with sum of bytes reported
by write callbacks when auto decoding is enabled.
See #785
- test1140: run nroff-scan to verify man pages
- nroff-scan.pl: verify the .BR references as well
- CURLOPT_CONV_TO_NETWORK_FUNCTION.3: fix bad man page reference
- CURLOPT_BUFFERSIZE.3: fix reference to CURLOPT_MAX_RECV_SPEED_LARGE
- curl_easy_pause.3: fix man page reference
Jay Satiro (1 May 2016)
- tool_cb_hdr: Fix --remote-header-name with schemeless URL
- Move the existing scheme check from tool_operate.
In the case of --remote-header-name we want to parse Content-disposition
for a filename, but only if the scheme is http or https. A recent
adjustment 0dc4d8e was made to account for schemeless URLs however it's
not 100% accurate. To remedy that I've moved the scheme check to the
header callback, since at that point the library has already determined
the scheme.
Bug: https://github.com/curl/curl/issues/760
Reported-by: Kai Noda
Daniel Stenberg (1 May 2016)
- tls: make setting pinnedkey option fail if not supported
to make it obvious to users trying to use the feature with TLS backends
not supporting it.
Discussed in #781
Reported-by: Travis Burtrum
- nroff-scan.pl: verifies nroff pages
... not used by any test yet but can be used stand-alone.
- opts: fix broken/bad references
- [Michael Kaufmann brought this change]
docs: fix bugs in CURLOPT_HTTP_VERSION.3 and CURLOPT_PIPEWAIT.3
Closes #786
- CURLOPT_ACCEPT_ENCODING.3: clarified
As discussed in #785
- curl.1: --mail-rcpt can be used multiple times
Reported-by: mgendre
Closes #784
- [Karlson2k brought this change]
tests: Use 'pathhelp' for paths conversions in secureserver.pl
Closes #675
- [Karlson2k brought this change]
tests: Use 'pathhelp' for paths conversions in sshserver.pl
- [Karlson2k brought this change]
tests: Use 'pathhelp' for current path in runtests.pl
- [Karlson2k brought this change]
tests: pathhelp.pm to process paths on Msys/Cygwin
- lib: include curl_printf.h as one of the last headers
curl_printf.h defines printf to curl_mprintf, etc. This can cause
problems with external headers which may use
__attribute__((format(printf, ...))) markers etc.
To avoid that they cause problems with system includes, we include
curl_printf.h after any system headers. That makes the three last
headers to always be, and we keep them in this order:
curl_printf.h
curl_memory.h
memdebug.h
None of them include system headers, they all do funny #defines.
Reported-by: David Benjamin
Fixes #743
- memdebug.h: remove inclusion of other headers
Mostly because they're not needed, because memdebug.h is always included
last of all headers so the others already included the correct ones.
But also, starting now we don't want this to accidentally include any
system headers, as the header included _before_ this header may add
defines and other fun stuff that we won't want used in system includes.
- [Jay Satiro brought this change]
curl -J: make it work even without http:// scheme on URL
It does open up a miniscule risk that one of the other protocols that
libcurl could use would send back a Content-Disposition header and then
curl would act on it even if not HTTP.
A future mitigation for this risk would be to allow the callback to ask
libcurl which protocol is being used.
Verified with test 1312
Closes #760
- manpage-scan.pl: also verify the command line option docs
This script now also scans src/tool_getparam.c, docs/curl.1 and
src/tool_help.c and will warn if any of them lists a command line option
not mentioned in one of the other places.
- curl: show the long option version of -q in the -h list
- curl: remove "--socks" as "--socks5" turned 8
In commit 2e42b0a2524 (Jan 2008) we made the option "--socks" deprecated
and it has not been documented since. The more explicit socks options
(like --socks4 or --socks5) should be used.
- curl.1: document the deprecated --ftp-ssl option
- curl: remove --http-request
It was mentioned as deprecated already in commit ae1912cb0d4 from
1999. It has not been documented in this millennium.
- curl: mention --ntlm-wb in -h list
- curl: -h output lacked --proxy-header
- curl.1: document --ntlm-wb
- curl.1: document the long format of -q: --disable
- curl.1: mention the deprecated --krb4 option
- curl.1: document --ftp-ssl-reqd
Even if deprecated, document it so that people will find it as old
scripts may still use it.
- curl: use --telnet-option as documented
The code said "telnet-options" but no documentation ever said so. It
worked fine since the code is fine with a unique match of the first
part.
- getparam: remove support for --ftpport
It has been deprecated and undocumented since commit ad5ead8bed7 (Dec
2003). --ftp-port is the proper long option name.
- curl: make --disable work as long form of -q
To make the aliases list reflect reality.
- aliases: remove trailing space from capath string
- cmdline parse: only single letter options have single-letter strings
... moved around options so that parsing the code to find all
single-letter options easier.
Jay Satiro (28 Apr 2016)
- CURLINFO_TLS_SSL_PTR.3: Clarify SSL pointer availability
Bug: https://curl.haxx.se/mail/lib-2016-04/0126.html
Reported-by: Bru Rom
Daniel Stenberg (28 Apr 2016)
- curl_easy_getinfo.3: remove superfluous blank lines
- test1139: verifies libcurl option man page presence
- checks that each option has its own man page present
- checks that each option is mentioned in its corresponding index man
page
- curl_easy_getinfo.3: added missing mention of CURLINFO_TLS_SESSION
... although it is deprecated.
Jay Satiro (28 Apr 2016)
- mbedtls: Fix session resume
This also fixes PolarSSL session resume.
Prior to this change the TLS session information wasn't properly
saved and restored for PolarSSL and mbedTLS.
Bug: https://curl.haxx.se/mail/lib-2016-01/0070.html
Reported-by: Thomas Glanzmann
Bug: https://curl.haxx.se/mail/lib-2016-04/0095.html
Reported-by: Moti Avrahami
Daniel Stenberg (27 Apr 2016)
- RELEASE-NOTES: synced with f4298fcc6d2
- [Michael Kaufmann brought this change]
opts: Fix some syntax errors in example code fragments
Fixes #779
- openssl: avoid BN_print a NULL bignum
OpenSSL 1.1.0-pre seems to return NULL(?) for a whole lot of those
numbers so make sure the function handles this.
Reported-by: Linus Nordberg
- [Marcel Raad brought this change]
CONNECT_ONLY: don't close connection on GSS 401/407 reponses
Previously, connections were closed immediately before the user had a
chance to extract the socket when the proxy required Negotiate
authentication.
This regression was brought in with the security fix in commit
79b9d5f1a42578f
Closes #655
- CURLINFO_TLS_SESSION.3: clarify TLS library support before 7.48.0
- mbedtls.c: silly spellfix of a comment
- KNOWN_BUGS: 1.10 Strips trailing dot from host name
Closes #716
- test1322: verify stripping of trailing dot from host name
While being debated (in #716) and a violation of RFC 7230 section 5.4,
this test verifies that the existing functionality works as intended. It
strips the dot from the host name and uses the host without dot
throughout the internals.
- multi: accidentally used resolved host name instead of proxy
Regression introduced in 09b5a998
Bug: https://curl.haxx.se/mail/lib-2016-04/0084.html
Reported-by: BoBo
- symbols-in-versions: added new CURLSSLBACKEND_ symbols
- test148: fixed after the --ftp-create-dirs retry change
follow-up commit to 3c1e84f569 as it made curl try a little harder
- curl.h: clarify curl_sslbackend for openssl clones and renames
- [Karlson2k brought this change]
url.c: fixed DEBUGASSERT() for WinSock workaround
If buffer is allocated, but nothing is received during prereceive
stage, than number of processed bytes must be zero.
Closes #778
- KNOWN_BUGS: --interface for ipv6 binds to unusable IP address
Closes #686 for now.
- TODO: 1.17 Add support for IRIs
Adding support for IRIs is a mouthful, but is probably interesting at
least for areas and countries where the use of such "URLs" are growing
popularity.
Closes #776
- THANKS-filter: Travis Burtrum
- lib1517: checksrc compliance
- [moparisthebest brought this change]
PolarSSL: Implement public key pinning
Patrick Monnerat (22 Apr 2016)
- os400: upgrade ILE/RPG binding
- curl.h: CURLOPT_CONNECT_TO sets a struct slist *, not a string
Daniel Stenberg (22 Apr 2016)
- contributors.sh: make --releasenotes implied
It got too annoying to type =)
- RELEASE-NOTES: synced with 3c1e84f5693d8093
- curl: make --ftp-create-dirs retry on failure
The underlying libcurl option used for this feature is
CURLOPT_FTP_CREATE_MISSING_DIRS which has the ability to retry the dir
creation, but it was never set to do that by the command line tool.
Now it does.
Bug: https://curl.haxx.se/mail/archive-2016-04/0021.html
Reported-by: John Wanghui
Help-by: Leif W
- [Henrik Gaßmann brought this change]
winbuild: add mbedtls support
Add WITH_MBEDTLS option. Make WITH_SSL, WITH_MBEDTLS and ENABLE_WINSSL
options mutual exclusive.
Closes #606
- KNOWN_BUGS: fixed "5.6 Improper use of Autoconf cache variables"
As of commit d9f3b365a3
- [Irfan Adilovic brought this change]
configure: ac_cv_ -> curl_cv_ for write-only vars
These configure vars are modified in a curl-specific way but never
evaluated or loaded from cache, even though they are designated as
_cv_. We could either implement proper AC_CACHE_CHECKs for them, or
remove them completely.
Fixes #603 as ac_cv_func_gethostbyname is no longer clobbered, and
AC_CHECK_FUNC(gethostbyname...) will no longer spuriously succeed after
the first configure run with caching.
`ac_cv_func_strcasecmp` is curious, see #770.
`eval "ac_cv_func_$func=yes"` can still cause problems as it works in
tandem with AC_CHECK_FUNCS and then potentially modifies its result. It
would be best to rewrite this test to use a new CURL_CHECK_FUNCS macro,
which works the same as AC_CHECK_FUNCS but relies on caching the values
of curl_cv_func_* variables, without modifiying ac_cv_func_*.
- [Irfan Adilovic brought this change]
configure: ac_cv_ -> curl_cv_ for r/w vars
These configure vars are modified in a curl-specific way and modified by
the configure process, but are never loaded from cache, even though they
are designated as _cv_. We should implement proper AC_CACHE_CHECKs for
them eventually.
- [Irfan Adilovic brought this change]
configure: ac_cv_func_clock_gettime -> curl_...
This variable must not be cached in its current form, as any cached
information will prevent the next configure run from determining the
correct LIBS needed for the function. Thus, rename prefix `ac_cv_` to
just `curl_`.
- [Irfan Adilovic brought this change]
configure: ac_cv_ -> curl_cv_ for all cached vars
This was automated by:
sed -b -i -f <(ack -A1 AC_CACHE_CHECK | \
ack -o 'ac_cv_.*?\b' | \
sort -u | xargs -n1 bash -c \
'echo "s/$0/curl_cv_${0#ac_cv_}/g"') \
$(git ls-files)
This only changed the prefix for 16 variables actually checked with
AC_CACHE_CHECK.
- openssl: builds with OpenSSL 1.1.0-pre5
The RSA, DSA and DH structs are now opaque and require use of new APIs
Fixes #763
Steve Holme (20 Apr 2016)
- url.c: Prefer we don't use explicit NULLs in conditions
Fixed commit fa5fa65a30 to not use NULLs in if condition.
Daniel Stenberg (20 Apr 2016)
- [Isaac Boukris brought this change]
NTLM: check for NULL pointer before deferencing
At ConnectionExists, both check->proxyuser and check->proxypasswd
could be NULL, so make sure to check first.
Fixes #765
- [Karlson2k brought this change]
tests: added test1517
... for checking ability to receive full HTTP response when POST request
is used with slow read callback function.
This test checks for bug #657 and verifies the work-around from
72d5e144fbc6.
Closes #720
- [Karlson2k brought this change]
sendf.c: added ability to call recv() before send() as workaround
WinSock destroys recv() buffer if send() is failed. As result - server
response may be lost if server sent it while curl is still sending
request. This behavior noticeable on HTTP server short replies if
libcurl use several send() for request (usually for POST request).
To workaround this problem, libcurl use recv() before every send() and
keeps received data in intermediate buffer for further processing.
Fixes: #657
Closes: #668
Kamil Dudka (19 Apr 2016)
- connect: make sure that rc is initialized in singleipconnect()
This commit fixes a Clang warning introduced in curl-7_48_0-190-g8f72b13:
Error: CLANG_WARNING:
lib/connect.c:1120:11: warning: The right operand of '==' is a garbage value
1118| }
1119|
1120|-> if(-1 == rc)
1121| error = SOCKERRNO;
1122| }
Daniel Stenberg (19 Apr 2016)
- make/checksrc: use $srcdir, not $top_srcdir
- src/checksrc.whitelist: removed
- tool_operate: switch to inline checksrc ignore
- lib/checksrc.whitelist: not needed anymore
... as checksrc now skips comments
- vtls.h: remove a space before semicolon
... that the new checksrc detected
- darwinssl: removed commented out code
- http_chunks: removed checksrc disable
... since checksrc now skips comments
- imap: inlined checksrc disable instead of whitelist edit
- checksrc: taught to skip comments
... but output non-stripped version of the line, even if that then can
make the script identify the wrong position in the line at
times. Showing the line stripped (ie without comments) is just too
surprising.
- opts/Makefile.am: list all docs file one by one
... to make it easier to add lines in patches that won't just break all
other patches trying to add lines too.
- curl_easy_setopt.3: mention CURLOPT_TCP_FASTOPEN
- RELEASE-NOTES: synced with 03de4e4b219
(since we just merged two major features)
- [Alessandro Ghedini brought this change]
connect: implement TCP Fast Open for Linux
Closes #660
- [Alessandro Ghedini brought this change]
tool: add --tcp-fastopen option
- [Alessandro Ghedini brought this change]
connect: implement TCP Fast Open for OS X
- [Alessandro Ghedini brought this change]
url: add CURLOPT_TCP_FASTOPEN option
- checksrc: pass on -D so the whitelists are found correctly
- configure: remove check for libresolve
'strncasecmp' was once provided by libresolv (no trailing e) for SunOS,
but this check is broken and most likely adds nothing useful. Removing
now.
Reported-by: Irfan Adilovic
Discussed in #770
- scripts/make: use $(EXEEXT) for executables
Reported-by: bodop
Fixes #771
- includes: avoid duplicate memory callback typdefs even harder
- checksrc/makefile.am: use $top_srcdir to find source files
... to properly support out of source tree builds.
- RELEASE-NOTES: synced with 26ec93dd6aeba8dfb5
- opts: fix option references missing (section)
- [Michael Kaufmann brought this change]
news: CURLOPT_CONNECT_TO and --connect-to
Makes curl connect to the given host+port instead of the host+port found
in the URL.
- makefile.vc6: use d suffix on debug object
To allow both release and debug builds in parallel.
Reported-by: Rod Widdowson
Fixes #769
Jay Satiro (12 Apr 2016)
- http2: Use size_t type for data drain count
Ref: https://github.com/curl/curl/issues/659
Ref: https://github.com/curl/curl/pull/663
- http2: Improve header parsing
- Error if a header line is larger than supported.
- Warn if cumulative header line length may be larger than supported.
- Allow spaces when parsing the path component.
- Make sure each header line ends in \r\n. This fixes an out of bounds.
- Disallow header continuation lines until we decide what to do.
Ref: https://github.com/curl/curl/issues/659
Ref: https://github.com/curl/curl/pull/663
- http2: Add Curl_http2_strerror for HTTP/2 error codes
Ref: https://github.com/curl/curl/issues/659
Ref: https://github.com/curl/curl/pull/663
- [Tatsuhiro Tsujikawa brought this change]
http2: Don't increment drain when one header field is received
Sicne we write header field in temporary location, not in the memory
that upper layer provides, incrementing drain should not happen.
Ref: https://github.com/curl/curl/issues/659
Ref: https://github.com/curl/curl/pull/663
- [Tatsuhiro Tsujikawa brought this change]
http2: Ensure that http2_handle_stream_close is called
This commit ensures that streams which was closed in on_stream_close
callback gets passed to http2_handle_stream_close. Previously, this
might not happen. To achieve this, we increment drain property to
forcibly call recv function for that stream.
To more accurately check that we have no pending event before shutting
down HTTP/2 session, we sum up drain property into
http_conn.drain_total. We only shutdown session if that value is 0.
With this commit, when stream was closed before reading response
header fields, error code CURLE_HTTP2_STREAM is returned even if
HTTP/2 level error is NO_ERROR. This signals the upper layer that
stream was closed by error just like TCP connection close in HTTP/1.
Ref: https://github.com/curl/curl/issues/659
Ref: https://github.com/curl/curl/pull/663
- [Tatsuhiro Tsujikawa brought this change]
http2: Process paused data first before tear down http2 session
This commit ensures that data from network are processed before HTTP/2
session is terminated. This is achieved by pausing nghttp2 whenever
different stream than current easy handle receives data.
This commit also fixes the bug that sometimes processing hangs when
multiple HTTP/2 streams are multiplexed.
Ref: https://github.com/curl/curl/issues/659
Ref: https://github.com/curl/curl/pull/663
- [Tatsuhiro Tsujikawa brought this change]
http2: Check session closure early in http2_recv
Ref: https://github.com/curl/curl/issues/659
Ref: https://github.com/curl/curl/pull/663
- [Tatsuhiro Tsujikawa brought this change]
http2: Add handling stream level error
Previously, when a stream was closed with other than NGHTTP2_NO_ERROR
by RST_STREAM, underlying TCP connection was dropped. This is
undesirable since there may be other streams multiplexed and they are
very much fine. This change introduce new error code
CURLE_HTTP2_STREAM, which indicates stream error that only affects the
relevant stream, and connection should be kept open. The existing
CURLE_HTTP2 means connection error in general.
Ref: https://github.com/curl/curl/issues/659
Ref: https://github.com/curl/curl/pull/663
Daniel Stenberg (11 Apr 2016)
- http2: drain the socket better...
... but ignore EAGAIN if the stream has ended so that we don't end up in
a loop. This is a follow-up to c8ab613 in order to avoid the problem
d261652 was made to fix.
Reported-by: Jay Satiro
Clues-provided-by: Tatsuhiro Tsujikawa
Discussed in #750
- KNOWN_BUGS: added info for "Hangs with PolarSSL"
- KNOWN_BUGS: 1.9 HTTP/2 frames while in the connection pool kill reuse
Closes #750
- build: include scripts/ in the dist
Steve Holme (9 Apr 2016)
- CURLOPT_SOCKS5_GSSAPI_SERVICE: Merged with CURLOPT_PROXY_SERVICE_NAME
As these two options provide identical functionality, the former for
SOCK5 proxies and the latter for HTTP proxies, merged the two options
together.
As such CURLOPT_SOCKS5_GSSAPI_SERVICE is marked as deprecated as of
7.49.0.
- urldata: Use bool for socks5_gssapi_nec as it is a flag
This value is set to TRUE or FALSE so should be a bool and not a long.
- url: Ternary operator code style changes
- CODE_STYLE: Added ternary operator example to 'Space around operators'
Following conversation on the libcurl mailing list.
- sasl: Fixed compilation errors from commit 9d89a0387
...when GSS-API or Windows SSPI are not used.
- url: Corrected comments following 9d89a0387
- docs: Added clarification following commit 9d89a0387
- Makefile: Fixed echo of checksrc check
- checksrc: Fix issue with the autobuilds not picking up the whitelist
- checksrc: Added missing vauth and vtls directories
- ftp/imap/pop3/smtp: Allow the service name to be overridden
Allow the service name to be overridden for DIGIST-MD5 and Kerberos 5
authentication in FTP, IMAP, POP3 and SMTP.
- http_negotiate: Calculate service name and proxy service name locally
Calculate the service name and proxy service names locally, rather than
in url.c which will allow for us to support overriding the service name
for other protocols such as FTP, IMAP, POP3 and SMTP.
- ROADMAP: Updated following the move of the authentication code
Patrick Monnerat (8 Apr 2016)
- KNOWN_BUGS: openldap hangs. TODO: binary SASL.
Daniel Stenberg (8 Apr 2016)
- KNOWN_BUGS: 5.6 Improper use of Autoconf cache variables
Closes #603
- KNOWN_BUGS: 11.2 error buffer not set...
Closes #544
- KNOWN_BUGS: 11.1 Curl leaks .onion hostnames in DNS
Closes #543
- KNOWN_BUGS: 1.8 DNS timing is wrong for HTTP redirects
Closes #522
- TODO: HTTP/2 "prior knowledge" is implemented!
- [Damien Vielpeau brought this change]
mbedtls: fix MBEDTLS_DEBUG builds
- mbedtls: implement and provide *_data_pending()
... as otherwise we might get stuck thinking there's no more data to
handle.
Reported-by: Damien Vielpeau
Fixes #737
- mbedtls: follow-up for the previous commit
- mbedtls.c: name space pollution fix, Use 'Curl_'
- mbedtls.c: changed private prefix to mbed_
mbedtls_ is the prefix used by the mbedTLS library itself so we should
avoid using that for our private functions.
- mbedtls.h: fix compiler warnings
- Revert "winbuild: trying to set some files eol=crlf for git"
This reverts commit 9c08b4f1e7eced5a4d3782a3e0daa484c9d77d21.
Didn't help. Caused problems.
Fixes #756
- curl.1: use example.com more
Make (most) example snippets use the example.com domain instead of the
random ones picked and used before. Some of those were probably
legitimate sites and some not. example.com is designed for this purpose.
- [Michael Kaufmann brought this change]
HTTP2: Add a space character after the status code
The space character after the status code is mandatory, even if the
reason phrase is empty (see RFC 7230 section 3.1.2)
Closes #755
- [Viktor Szakats brought this change]
URLs: change http to https in many places
Closes #754
- winbuild: trying to set some files eol=crlf for git
Thinking it might help to apply patches etc with git.
- [Theodore Dubois brought this change]
curl.1: change example for -F
It's a bad idea to send your passwords anywhere, especially over HTTP.
Modified example to send a picture instead.
Fixes #752
- KNOWN_BUGS: reorganized and cleaned up
Now sorted into categories and organized in the same style we do the
TODO document. It will make each issue linked properly on the
https://curl.haxx.se/docs/knownbugs.html web page.
The sections should make it easier to find issues and issues related to
areas of the reader's specific interest.
Jay Satiro (6 Apr 2016)
- KNOWN_BUGS: #95 curl in Windows can't handle Unicode arguments
Steve Holme (6 Apr 2016)
- KNOWN_BUGS: Use https://curl.haxx.se URL for github based issues
- CHECKSRC.md: Corrected some typos
- RELEASE-NOTES: Corrected last updated
Included a summary of the checksrc.bat updates and combined two krb5
changes as they should have been implemented at the same time.
- vauth: Corrected a number of typos in comments
Reported-by: Michael Osipov
Jay Satiro (5 Apr 2016)
- KNOWN_BUGS: #94 IMAP custom requests use the LIST handler
Bug: https://github.com/curl/curl/issues/536
Reported-by: eXeC64@users.noreply.github.com
Daniel Stenberg (5 Apr 2016)
- KNOWN_BUGS: remove 68, 70 and 72.
Due to their age (we don't fully know if they actually remain) and lack
of detail - very few people will bother to find out what they're about
or work on them. If people truly still suffer from any of these, I
assume they will be reported again and then we'll deal with them.
72. "Pausing pipeline problems."
https://curl.haxx.se/mail/lib-2009-07/0214.html
70. Problem re-using easy handle after call to curl_multi_remove_handle
https://curl.haxx.se/mail/lib-2009-07/0249.html
68. "More questions about ares behavior".
https://curl.haxx.se/mail/lib-2009-08/0012.html
- KNOWN_BUGS: remove 92 and 88, fixed
- http2: fix connection reuse when PING comes after last DATA
It turns out the google GFE HTTP/2 servers send a PING frame immediately
after a stream ends and its last DATA has been received by curl. So if
we don't drain that from the socket, it makes the socket readable in
subsequent checks and libcurl then (wrongly) assumes the connection is
dead when trying to reuse the connection.
Reported-by: Joonas Kuorilehto
Discussed in #750
- multi: remove trailing space in debug output
- RELEASE-NOTES: synced with 86e97b642fb
- CHECKSRC.md: mention cmdline options, fix the bullet list
- docs/CHECKSRC.md: initial version
Steve Holme (3 Apr 2016)
- checksrc.bat: Added support for the examples
Daniel Stenberg (3 Apr 2016)
- lib/src: fix the checksrc invoke
... now works correctly when invoke from the root makefile
- nw: please the stricter checksrc
Steve Holme (3 Apr 2016)
- checksrc.bat: Re-enabled the tests directory by default
Following the recent changes to the source in the tests directory,
re-enabled tests for the default scan.
- checksrc.bat: Added tests/server directory support
In addition to commit 83b174b3f0 and following the recent changes.
- tests: Fixed header files to comply with our code style
Daniel Stenberg (3 Apr 2016)
- make checksrc: run it in docs/examples too by default
- docs/examples: remove spurious white spaces all over
... to please the new, slightly picker, checksrc.pl
- tests: fix make checksrc in servers/
- tests: 'make checksrc' now checks server/ too
- root/make: have checksrc run in include/curl too
- tests/server: comply with our code style
- code: style updates
- checksrc: check for more malplaced spaces
- unit: make unit test source code checksrc compliant
- checksrc: run checksrc in tests when 'make checksrc' in root
- checksrc: remove debug crap
- lib557: allow too long lines
- checksrc: allow ignore of specific warnings within a file (section)
- checksrc: add warning names, explain on help output
Steve Holme (3 Apr 2016)
- checksrc.bat: Disable tests by default until warnings are fixed
- checksrc.bat: Added support for the tests directory
- vauth: Removed the need for a separate GSS-API based SPN function
- curl_sasl: Fixed potential null pointer utilisation
Although this should never happen due to the relationship between the
'mech' and 'resp' variables, and the way they are allocated together,
it does cause problems for code analysis tools:
V595 The 'mech' pointer was utilized before it was verified against
nullptr. Check lines: 376, 381. curl_sasl.c 376
Bug: https://github.com/curl/curl/issues/745
Reported-by: Alexis La Goutte
- spnego: Small code tidy up
* Prefer dereference of string pointer rather than strlen()
* Free challenge pointer in one place
* Additional comments
- krb5: Small code tidy up
* Prefer dereference of string pointer rather than strlen()
* Free challenge pointer in one place
* Additional comments
- krb5_gssapi: Only process challenge when present
This wouldn't cause a problem because of the way the function is called,
but prior to this change, we were processing the challenge message when
the credentials were NULL rather than when the challenge message was
populated.
This also brings this part of the Kerberos 5 code in line with the
Negotiate code.
- krb5: Fixed missing client response when mutual authentication enabled
Although mutual authentication is currently turned off and can only be
enabled by changing libcurl source code, authentication using Kerberos
5 has been broken since commit 79543caf90 in this use case.
- krb5_sspi: Only process challenge when present
This wouldn't cause a problem because of the way the function is called,
but prior to this change, we were processing the challenge message when
the credentials were NULL rather than when the challenge message was
populated.
This also brings this part of the Kerberos 5 code in line with the
Negotiate code.
- krb5_sspi: Only generate the output token when its not allocated
Prior to this change, we were generating the output token when the
credentials were NULL rather than when the output token was NULL.
This also brings this part of the Kerberos 5 code in line with the
Negotiate code.
- krb5: Only generate a SPN when its not known
Prior to this change, we were generating the SPN in the SSPI code when
the credentials were NULL and in the GSS-API code when the context was
empty. It is better to decouple the SPN generation from these checks
and only generate it when the SPN itself is NULL.
This also brings this part of the Kerberos 5 code in line with the
Negotiate code.
Daniel Stenberg (3 Apr 2016)
- tests/libtest: follow our code style guidelines better
... checksrc of all test code is pending.
- checksrc.whitelist: remove fopen() uses
- formdata: use appropriate fopen() macros
- checksrc: improve the fopen() parser somewhat
The quote scanner was too fragile, now look for a comma instead to find
the mode argument.
- unit1604: fix snprintf
follow-up to 0326b06
sizeof(pointer) is no good for the buffer size!
Reported-by: Viktor Szakats
Steve Holme (3 Apr 2016)
- unittests: Fixed compilation warnings
warning: implicit declaration of function 'sprintf_was_used'
[-Wimplicit-function-declaration]
Follow up to the modications made to tests/libtest in commit 55452ebdff
as we prefer not to use sprintf() now.
Daniel Stenberg (2 Apr 2016)
- curl.1: -w filename_effective was introduced in 7.26.0
We never made a 7.25.1 release
- 7.49.0: next release version
- http2: make use of the nghttp2 error callback
It offers extra info from nghttp2 in certain error cases. Like for
example when trying prior-knowledge http2 on a server that doesn't speak
http2 at all. The error message is passed on as a verbose message to
libcurl.
Discussed in #722
The error callback was added in nghttp2 1.9.0
Steve Holme (2 Apr 2016)
- spnego: Renamed the context's SPN variable
To be consistent with the Kerberos 5 context and other authentication
code.
- krb5_gssapi: Renamed the status variables
For consistency with the spnego code.
- krb5: Moved host from Curl_auth_create_gssapi_user_message() to be argument
For consistency with the spnego and oauth2 code moved the setting of
the host name outside of the Curl_auth_create_gssapi_user_messag()
function.
This will allow us to more easily override it in the future.
- test1119: Fixed missing CURL_DID_MEMORY_FUNC_TYPEDEFS symbol
- RELEASE-NOTES: Removed "http_negotiate: Corrected host and proxy host name"
As this was introduced in the recent vauth changes and not a prior
release.
Daniel Stenberg (1 Apr 2016)
- RELEASE-NOTES: synced with 0aa8da10bbdafa
Steve Holme (1 Apr 2016)
- http_negotiate: Corrected host and proxy host name being wrong way round
I had accidentally used the proxy server name for the host and the host
server name for the proxy in commit ad5e9bfd5d and 6d6f9ca1d9. Whilst
Windows SSPI was quite happy with this, GSS-API wasn't.
Thanks-to: Michael Osipov
- build: Changed the Visual Studio projects warning level from 3 to 4
After squashing most of our compiler warnings, up'ed the default
warning level from 3 to 4 in order to increase the likelyhood of
catching future warnings.
Daniel Stenberg (1 Apr 2016)
- [ehlertjd@gmail.com brought this change]
IMAP: check pointer before dereferencing it
may be null in the CURLOPT_CONNECT_ONLY case
Fixes #747
Steve Holme (1 Apr 2016)
- .gitignore: Added new VC14 SQLite based program database files
- curl_memory.h: Fixed typo in comment
From commit 7218b52c49.
- spnego: Corrected some typos in comments
Corrected typos from commit ad5e9bfd5d and 6d6f9ca1d9.
- memdebug: Ensure curl/curl.h is included before curl_memory.h
Follow up to commit 7db9782dd6.
Daniel Stenberg (1 Apr 2016)
- upload: missing rewind call could make libcurl hang
When an upload is done, there are two places where that can be detected
and only one of them would rewind the input stream - which sometimes is
necessary for example when doing NTLM HTTP POSTs and more.
This could then end up libcurl hanging.
Figured-out-by: Isaac Boukris
Reported-by: Anatol Belski
Fixes #741
- curl.h: define CURL_DID_MEMORY_FUNC_TYPEDEFS
So that we only do the extra typedefs in curl_memory.h when we really
need to and avoid double typedefs.
follow-up commit to 7218b52c49aeb1
Thanks-to: Steve Holme
- curl/mprintf.h: remove support for _MPRINTF_REPLACE
The define is not in our name space and is therefore not protected by
our API promises.
It was only really used by libcurl internals but was mostly erased from
there already in 8aabbf5 (March 2015). This is supposedly the final
death blow to that define from everywhere.
As a side-effect, making sure _MPRINTF_REPLACE is gone and not used, I
made the lib tests in tests/libtest/ use curl_printf.h for its redefine
magic and then subsequently the use of sprintf() got banned in the tests
as well (as it is in libcurl internals) and I then replaced them all
with snprintf().
In the unlikely event that any users is actually using this define and
gets sad by this change, it is very easily copied to the user's own
code.
- curl_memory.h: avoid the curl/curl.h include
Discussed in #743
Steve Holme (1 Apr 2016)
- url: Corrected get protocol family for FTP and LDAP
Fixed copy/paste error from commit a5aec58726.
Jay Satiro (31 Mar 2016)
- strerror: don't bit shift a signed integer
Bug: https://github.com/curl/curl/issues/744
Reported-by: Alexis La Goutte
Daniel Stenberg (31 Mar 2016)
- http2: more documentation for prior knowledge
- [Diego Bes brought this change]
http2: support "prior knowledge", no upgrade from HTTP/1.1
Supports HTTP/2 over clear TCP
- Optimize switching to HTTP/2 by removing calls to init and setup
before switching. Switching will eventually call setup and setup calls
init.
- Supports new version to “force” the use of HTTP/2 over clean TCP
- Add common line parameter “--http2-prior-knowledge” to the Curl
command line tool.
- imap: remove duplicated function
The list and search response functions were identical! Merged into one
now. Detected by PVS Studio.
Reported-by: Alexis La Goutte
- SOCKS5_gssapi_negotiate: don't assume little-endian ints
The code copied one byte from a 32bit integer, which works fine as long
as the byte order is the same. Not a fine assumption. Reported by PVS
Studio.
Reported-by: Alexis La Goutte
- http: remove ((expression)) double parentheses
- Curl_add_buffer_send: avoid possible NULL dereference
... as we check for a NULL pointer below, we move the derefence to after
the check. Detected by PVS Studio.
Reported-by: Alexis La Goutte
- file: remove duplicate checks of the same variable
... as it doesn't change in between. Deteced by PVS Studio.
Reported-by: Alexis La Goutte
Steve Holme (30 Mar 2016)
- [Marcel Raad brought this change]
openssl: Fix compilation warnings
When compiling with OpenSSL 1.1.0 (so that the HAVE_X509_GET0_SIGNATURE
&& HAVE_X509_GET0_EXTENSIONS pre-processor block is active), Visual C++
14 complains:
warning C4701: potentially uninitialized local variable 'palg' used
warning C4701: potentially uninitialized local variable 'psig' used
Daniel Stenberg (30 Mar 2016)
- multi: turn Curl_done into file local multi_done
... as it now is used by multi.c only.
- multi: multi_reconnect_request is the former Curl_reconnect_request
now a file local function in multi.c
- multi: move Curl_do and Curl_do_done to multi.c and make static
... called multi_do and multi_do_done as they're file local now.
Jay Satiro (29 Mar 2016)
- wolfssl: Use ECC supported curves extension
https://github.com/wolfSSL/wolfssl/issues/366
- build-wolfssl: Allow a broader range of ciphers (Visual Studio)
This is an update to the build-time options used to build wolfSSL in
Visual Studio for greater compatibility, and make it behave similar to
the way OpenSSL 1.0.2 behaves. Starting in wolfSSL v3.6.6 static ciphers
and SSLv3 are disabled by default at build time, but we can use both.
- Enable static cipher suites TLS_ECDH_ and TLS_RSA_.
- Enable SSLv3 hello. Though in libcurl we disable it by default at
runtime, we make it available so the user can manually select it if
necessary.
Daniel Stenberg (29 Mar 2016)
- [Isaac Boukris brought this change]
GSS: make Curl_gss_log_error more verbose
Also display the GSS_C_GSS_CODE (major code) when specified instead of
only GSS_C_MECH_CODE (minor code).
In addition, the old code was printing a colon twice after the prefix
and also miscalculated the length of the buffer in between calls to
gss_display_status (the length of ": " was missing).
Also, gss_buffer is not guaranteed to be NULL terminated and thus need
to restrict reading by its length.
Closes #738
- build: use roffit 0.11 feature
... load file specified as argument.
- http2: set correct scheme in handler structs [regression]
Since commit a5aec58 the handler schemes need to match for the
connections to be reused and for HTTP/2 multiplexing to work, reusing
connections is very important!
Closes #736
- hostip.c: minor white space edit for style
- [Viktor Szakats brought this change]
TODO: use secure protocol in recently added URL
Closes #733
- HTTP2.md: mention libressl and boringssl too
- docs/HTTP-COOKIES: converted to markdown
- HTTP2: s/polarssl/mbedtls
Jay Satiro (28 Mar 2016)
- wolfssl: Add ALPN support
- tool_operate: remove mixed declaration
This is a follow up to the previous commit.
Daniel Stenberg (28 Mar 2016)
- curl: warn for --capath use if not supported by libcurl
Closes #492
- TODO: 2.5 Edge-triggered sockets should work
- Makefile.am: skip the scripts dir
Skipping the scripts dir is primarily done for 'make install' so that it
does not attempt to install the zsh completion script as we've not yet
found a proper way to do/run that at install time.
By leaving the script dir's Makefile in place, a user can still opt to
run make install manually in there.
Closes #620
- CURLMOPT_SOCKETFUNCTION.3: describe the 'what' argument
- curl_multi_socket_action.3: mark the options properly
... to make them appear as links on the html version.
Steve Holme (27 Mar 2016)
- RELEASE-NOTES: Synced with f0bdd72c10
- http_ntlm: Renamed from curl_ntlm.[c|h]
Renamed the header and source files for this module as they are HTTP
specific and as such, they should use the naming convention as other
HTTP authentication source files do - this revert commit 260ee6b7bf.
Note: We could also rename curl_ntlm_wb.[c|h], however, the Winbind
code needs separating from the HTTP protocol and migrating into the
vauth directory, thus adding support for Winbind to the SASL based
protocols such as IMAP, POP3 and SMTP.
Daniel Stenberg (27 Mar 2016)
- [marquis-de-muesli brought this change]
docs: curlinfo_filetime sftp support, new curlopt_quote "statvfs"
Closes #677
- [marquis-de-muesli brought this change]
SSH: new CURLOPT_QUOTE command "statvfs"
usage: "statvfs path"
returns remote file system statistics
- [marquis-de-muesli brought this change]
SSH: support CURLINFO_FILETIME
- [Karlson2k brought this change]
sshserver.pl: use quotes for given options
Fixed failed redirection of stderr with some options. At least on Msys2,
perl fails to redirect stderr if $value contains newline or other weird
characters.
Jay Satiro (26 Mar 2016)
- url: don't use bad offset in tld_check_name to show error
libidn's tld_check_lz returns an error offset of the first character
that it failed to process, however that offset is not a byte offset and
may not even be in the locale encoding therefore we can't use it to show
the user the character that failed to process.
Bug: https://github.com/curl/curl/issues/731
Reported-by: Karlson2k
Steve Holme (26 Mar 2016)
- http_negotiate: Combine GSS-API and SSPI source files
As the GSS-API and SSPI based source files are no longer library/API
specific, following the extraction of that authentication code to the
vauth directory, combine these files rather than maintain two separate
versions.
- vauth: Moved the Negotiate authentication code to the new vauth directory
Part 2 of 2 - Moved the GSS-API based Negotiate authentication code.
- vauth: Moved the Negotiate authentication code to the new vauth directory
Part 1 of 2 - Moved the SSPI based Negotiate authentication code.
- warnless.h: Removed spurious character from commit 696bc6b9c9
Not picked up by checksrc or Visual Studio but my own code review, this
would haven broken Intel based Unix builds - Perhaps I should learn to
type on my laptop's keyboard before committing!
- schannel: Fixed compilation warning from commit f8d88a4913
warning C4244: '=': conversion from 'int' to 'unsigned short', possible
loss of data
- warnless?: Added some integer based conversion functions
Daniel Stenberg (25 Mar 2016)
- [Dusty Mabe brought this change]
docs/TODO: Add feature request for metalink in HTTP headers
Closes #729
Closes #728
Steve Holme (25 Mar 2016)
- build: Corrected typos from commit 70e56939aa
- vauth: Refactored function names after move to new vauth directory
Renamed all the SASL functions that moved to the new vauth directory to
include the correct module name.
- vauth: Updated the copyright year after recent changes
As most of this work was performed in 2015 but not pushed until 2016
updated the copyright year to reflect the public facing changes.
- vauth: Moved the OAuth 2.0 authentication code to the new vauth directory
- vauth: Moved the NTLM authentication code to the new vauth directory
- vauth: Moved the Kerberos V5 authentication code to the new vauth directory
- digest.c: Fixed checksrc warnings
- vauth: Moved the DIGEST authentication code to the new vauth directory
- vauth: Moved the CRAM-MD5 authentication code to the new vauth directory
- vauth: Moved the ClearText authentication code to the new vauth directory
- vauth: Moved Curl_sasl_build_spn() to create the initial vauth source files
- checksrc.bat: Added support for checking the new vauth directory
- build: Updated all makefiles and project files for the new vauth directory
Updated the makefiles and Visual Studio project files to support moving
the authentication code to the new lib/vauth directory that was started
in commit 0d04e859e1.
Daniel Stenberg (24 Mar 2016)
- [JDepooter brought this change]
schannel: Add ALPN support
Add ALPN support for schannel. This allows cURL to negotiate
HTTP/2.0 connections when built with schannel.
Closes #724
Steve Holme (24 Mar 2016)
- http: Minor update based on CODE_STYLE guidelines
Daniel Stenberg (23 Mar 2016)
- multi: fix "Operation timed out after" timer
Use the local, reasonably updated, 'now' value when creating the message
string to output for the timeout condition.
Fixes #619
- openssl: boringssl provides the same numbering as openssl
... so we don't need extra boringssl precautions for for
HAVE_ERR_REMOVE_THREAD_STATE_NOARG.
Pointed-out-by: David Benjamin
- openssl: fix ERR_remove_thread_state() for boringssl/libressl
The removed arg is only done in OpenSSL
Bug: https://twitter.com/xtraemeat/status/712564874098917376
- bump: work on 7.48.1
- RELEASE-PROCEDURE: mention the github release tag edit
... and update the coming release dates a bit
Steve Holme (23 Mar 2016)
- checksrc.bat: Updated the help to be consistent with generate.bat
Follow up to commit a8c7f0fcbf prior to release.
Version 7.48.0 (23 Mar 2016)
Daniel Stenberg (23 Mar 2016)
- RELEASE-NOTES: curl 7.48.0
- THANKS: 15 new contributors from 7.48.0 release
Jay Satiro (23 Mar 2016)
- CURLINFO_TLS_SSL_PTR.3: Warn about limitations
Bug: https://github.com/curl/curl/issues/685
Daniel Stenberg (22 Mar 2016)
- Revert "sshserver: remove use of AuthorizedKeysFile2"
It seems we may have some autobuild problems after this commit went
in. Trying to see if a revert helps to get them back.
This reverts commit 2716350d1f3edc8e929f6ceeee05051090f6d642.
- maketgz: add -j to make dist
... makes it a lot faster
- libcurl-thread.3: minor nroff format fix
- CURLINFO_TLS_SSL_PTR.3: minor nroff format fix
- CODE_STYLE: indend example code
... to make it look nicer in markdown outputa
Jay Satiro (22 Mar 2016)
- build-wolfssl: Update VS properties for wolfSSL v3.9.0
- Do not use wolfSSL's sample user-setting files.
wolfSSL starting in v3.9.0 has added their own sample user settings that
are applied by default, but we don't use them because we have our own
settings.
- Do not use wolfSSL's Visual Studio Unicode character setting.
wolfSSL Visual Studio projects use the Unicode character set however our
settings and options imitate mingw build which does not use the Unicode
character set. This does not appear to have any effect at the moment but
better safe than sorry.
These changes are backwards compatible with earlier versions.
Steve Holme (22 Mar 2016)
- hostip6: Fixed compilation warnings when verbose strings disabled
warning C4189: 'data': local variable is initialized but not referenced
...and some minor formatting/spacing changes.
Daniel Stenberg (21 Mar 2016)
- sshserver: remove use of AuthorizedKeysFile2
Support for the (undocumented) AuthorizedKeysFile2 was removed in
OpenSSH 5.9, released in September 2011
Closes #715
Steve Holme (20 Mar 2016)
- connect/ntlm/http: Fixed compilation warnings when verbose strings disabled
warning C4189: 'data': local variable is initialized but not referenced
- openssl: Fixed compilation warning when /Wall enabled
warning C4706: assignment within conditional expression
- CODE_STYLE: Use boolean conditions
Rather than use TRUE, FALSE, NULL, 0 or != 0 in if/while conditions.
Additionally, corrected some example code to adhere to the recommended
coding style.
- inet_pton.c: Fixed compilation warnings
warning: conversion to 'unsigned char' from 'int' may alter its value
Daniel Stenberg (19 Mar 2016)
- RELEASE-NOTES: synced with 80851028efc2fa9
- mbedtls: fix compiler warning
vtls/mbedtls.h:67:36: warning: implicit declaration of function
‘mbedtls_sha256’ [-Wimplicit-function-declaration]
Steve Holme (19 Mar 2016)
- easy: Minor coding standard and style updates
Following commit c5744340db. Additionally removes the need for a second
'result code' variable as well.
Jay Satiro (19 Mar 2016)
- easy: Remove poll failure check in easy_transfer
.. because curl_multi_wait can no longer signal poll failure.
follow-up to 77e1726
Bug: https://github.com/curl/curl/issues/707
Steve Holme (19 Mar 2016)
- build: Added missing Visual Studio filter files for VC10 onwards
As these files don't need to contain references to the source files,
although typically do, added basic files which only include three
filters and don't require the project file generator to be modified.
These files allow the source code to be viewed in the Solution Explorer
in versions of Visual Studio from 2010 onwards in the same manner as
previous versions did rather than one large view of files.
- ftp/imap/pop3/smtp: Fixed compilation warning when /Wall enabled
warning C4706: assignment within conditional expression
- config-w32.h: Fixed compilation warning when /Wall enabled
warning C4668: 'USE_IPV6' is not defined as a preprocessor macro,
replacing with '0' for '#if/#elif'
- imap.c: Fixed compilation warning with /Wall enabled
warning C4701: potentially uninitialized local variable 'size' used
Technically this can't happen, as the usage of 'size' is protected by
'if(parsed)' and 'parsed' is only set after 'size' has been parsed.
Anyway, lets keep the compiler happy.
- KNOWN_BUGS: #93 Issue with CURLFORM_CONTENTLEN in arrays on 32-bit platforms
Daniel Stenberg (18 Mar 2016)
- bump: the coming release is 7.48.0
- configure: use cpp -P when needed
Since gcc 5, the processor output can get split up on multiple lines
that made the configure script fail to figure out values from
definitions. The fix is to use cpp -P, and this fix now first checks if
cpp -P is necessary and then if cpp -P works before it uses that to
extract defined values.
Fixes #719
Steve Holme (18 Mar 2016)
- formdata.c: Fixed compilation warning
formdata.c:390: warning: cast from pointer to integer of different size
Introduced in commit ca5f9341ef this happens because a char*, which is
32-bits wide in 32-bit land, is being cast to a curl_off_t which is
64-bits wide where 64-bit integers are supported by the compiler.
This doesn't happen in 64-bit land as a pointer is the same size as a
curl_off_t.
This fix doesn't address the fact that a 64-bit value cannot be used
for CURLFORM_CONTENTLEN when set in a form array and compiled on a
32-bit platforms, it does at least suppress the compilation warning.
Daniel Stenberg (18 Mar 2016)
- FAQ: 2.5 Install libcurl for both 32bit and 64bit?
- [Gisle Vanem brought this change]
openssl: adapt to API breakage in ERR_remove_thread_state()
The OpenSSL API change that broke this is "Convert ERR_STATE to new
multi-threading API": openssl commit 8509dcc.
Closes #713
- version: init moved to private name space, added protos
follow-up to 80015cdd52145
- openssl: verbose: show matching SAN pattern
... to allow users to see which specfic wildcard that matched when such
is used.
Also minor logic cleanup to simplify the code, and I removed all tabs
from verbose strings.
Jay Satiro (16 Mar 2016)
- version: thread safety
Steve Holme (16 Mar 2016)
- transfer: Removed redundant HTTP authentication include files
It would also seem that share.h is not required here either as there
are no references to the Curl_share structure or functions.
- easy: Removed redundant HTTP authentication include files
Jay Satiro (15 Mar 2016)
- CURLOPT_SSLENGINE.3: Only for OpenSSL built with engine support
Bug: https://curl.haxx.se/mail/lib-2016-03/0150.html
Reported-by: Oliver Graute
Steve Holme (15 Mar 2016)
- curl_sasl: Minor code indent fixes
Daniel Stenberg (14 Mar 2016)
- runtests: mention when run event-based
- easy: add check to malloc() when running event-based
... to allow torture tests then too.
- memdebug: skip logging the limit countdown, fflush when reached
- CODE_STYLE: Space around operators
As just discussed on the mailing list, also document how we prefer
spacing in expressions.
- curl: glob_range: no need to check unsigned variable for negative
cppcheck warned:
[src/tool_urlglob.c:283]: (style) Checking if unsigned variable 'step_n'
is less than zero.
- CODE_STYLE: add example for indent style as well
- CODE_STYLE: mention braces for functions too
- docs/Makefile.am: include CODE_STYLE in tarball too
- CONTRIBUTE: moved out code style to a separate document
- CODE_STYLE: initial version
Ripped out from CONTRIBUTE into its own document, but also extended from
there.
- curl_sasl.c: minor code indent fixes
- multi: simplified singlesocket
Since sh_getentry() now checks for invalid sockets itself and by
narrowing the scope of the remove_sock_from_hash variable.
- multi: introduce sh_getentry() for looking up sockets in the sockhash
Simplify the code by using a single entry that looks for a socket in the
socket hash. As indicated in #712, the code looked for CURL_SOCKET_BAD
at some point and that is ineffective/wrong and this makes it easier to
avoid that.
- [Jaime Fullaondo brought this change]
multi hash: ensure modulo performed on curl_socket_t
Closes #712
Steve Holme (13 Mar 2016)
- base64: Minor coding standard and style updates
- base64: Use 'CURLcode result' for curl result codes
- negotiate: Use 'CURLcode result' for curl result codes
Daniel Stenberg (13 Mar 2016)
- [Maksim Kuzevanov brought this change]
multi_runsingle: avoid loop in CURLM_STATE_WAITPROXYCONNECT
Closes #703
- TODO: Use the RFC6265 test suite
Steve Holme (13 Mar 2016)
- checksrc.bat: Added the ability to scan src and lib source independently
- digest: Use boolean based success code for Curl_sasl_digest_get_pair()
Rather than use a 0 and 1 integer base result code use a TRUE / FALSE
based success code.
- digest: Corrected some typos in comments
- krb5: Corrected some typos in function descriptions
- ntlm: Corrected some typos in function descriptions
- url: Corrected indentation when calling idna_to_ascii_lz()
- idn_win32: Use boolean based success codes
Rather than use 0 and 1 integer base result codes use a FALSE / TRUE
based success code.
Daniel Stenberg (10 Mar 2016)
- idn_win32.c: warning: Trailing whitespace
Steve Holme (10 Mar 2016)
- idn_win32.c: Fixed compilation warning from commit 9e7fcd4291
warning C4267: 'function': conversion from 'size_t' to 'int',
possible loss of data
Daniel Stenberg (10 Mar 2016)
- THANKS-filter: unify Michael König
- RELEASE-NOTES: synced with 863c5766dd
- ftp: remove a check for NULL(!)
... as it implies we need to check for that on all the other variable
references as well (as Coverity otherwise warns us for missing NULL
checks), and we're alredy making sure that the pointer is never NULL.
- cookies: first n/v pair in Set-Cookie: is the cookie, then parameters
RFC 6265 section 4.1.1 spells out that the first name/value pair in the
header is the actual cookie name and content, while the following are
the parameters.
libcurl previously had a more liberal approach which causes significant
problems when introducing new cookie parameters, like the suggested new
cookie priority draft.
The previous logic read all n/v pairs from left-to-right and the first
name used that wassn't a known parameter name would be used as the
cookie name, thus accepting "Set-Cookie: Max-Age=2; person=daniel" to be
a cookie named 'person' while an RFC 6265 compliant parser should
consider that to be a cookie named 'Max-Age' with an (unknown) parameter
'person'.
Fixes #709
- krb5: improved type handling to avoid clang compiler warnings
- url.c: fix clang warning: no newline at end of file
- curl_multi_wait: never return -1 in 'numfds'
Such a return value isn't documented but could still happen, and the
curl tool code checks for it. It would happen when the underlying
Curl_poll() function returns an error. Starting now we mask that error
as a user of curl_multi_wait() would have no way to handle it anyway.
Reported-by: Jay Satiro
Closes #707
- HTTP2.md: add CURL_HTTP_VERSION_2TLS and updated alt-svc link
- curl_multi_wait.3: add example
Steve Holme (8 Mar 2016)
- imap/pop3/smtp: Fixed connections upgraded with TLS are not reused
Regression since commit 710f14edba.
Bug: https://github.com/curl/curl/issues/422
Reported-by: Justin Ehlert
Jay Satiro (8 Mar 2016)
- opt-docs: fix heading macros
..SH should be .SH
Bug: https://github.com/curl/curl/issues/705
Reported-by: Eric S. Raymond
Kamil Dudka (8 Mar 2016)
- [Tim Rühsen brought this change]
cookie: do not refuse cookies for localhost
Closes #658
Daniel Stenberg (8 Mar 2016)
- ftp_done: clear tunnel_state when secondary socket closes
Introducing a function for closing the secondary connection to make this
bug less likely to happen again.
Reported-by: daboul
Closes #701
- [Gisle Vanem brought this change]
openssl: use the correct OpenSSL/BoringSSL/LibreSSL in messages
- HTTP2.md: HTTP/2 by default for curl's HTTPS connections
- [Anders Bakken brought this change]
pipeline: Sanity check pipeline pointer before accessing it.
I got a crash with this stack:
curl/lib/url.c:2873 (Curl_removeHandleFromPipeline)
curl/lib/url.c:2919 (Curl_getoff_all_pipelines)
curl/lib/multi.c:561 (curl_multi_remove_handle)
curl/lib/url.c:415 (Curl_close)
curl/lib/easy.c:859 (curl_easy_cleanup)
Closes #704
- HTTP2.md: mention the disable ALPN and NPN options
- TODO: 17.12 keep running, read instructions from pipe/socket
And delete trailing whitespace
And rename section 17 to "command line tool" from "client"
Closes #702
- README.md: linkified
It also makes it less readable as plain text, so let's keep this
primarily for github use.
Removed the top ascii art logo, as it looks weird when markdownified.
- README.md: markdown version of README
Attempt to make it look more appealing on github
Jay Satiro (6 Mar 2016)
- mprintf: update trio project link
Daniel Stenberg (6 Mar 2016)
- CURLOPT_ACCEPTTIMEOUT_MS.3: added example
- CURLOPT_ACCEPT_ENCODING.3: added example
- CURLOPT_APPEND.3: added example
- CURLOPT_NOPROGRESS.3: added example, conform to stardard style
Steve Holme (6 Mar 2016)
- build-openssl/checksrc.bat: Fixed prepend vs append of Perl path
Fixed inconsistency from commit 1eae114065 and 0ad6c72227 of the order
in which Perl was added to the PATH.
Daniel Stenberg (6 Mar 2016)
- opts: added two examples
- CURLOPT_SSL_CTX_FUNCTION.3: use .NF for example
- CURLOPT_SSL_CTX_FUNCTION.3: added example
and removed erroneous reference to test case lib509
- curlx.c: use more curl style code
- test46: change cookie expiry date
Since two of the cookies would now otherwise expire and cause the test
to fail after commit 20de9b4f09
Discussed in #697
Jay Satiro (5 Mar 2016)
- [Viktor Szakats brought this change]
makefile.m32: add missing libs for static -winssl-ssh2 builds
Bug: https://github.com/curl/curl/pull/693
- mbedtls: fix user-specified SSL protocol version
Prior to this change when a single protocol CURL_SSLVERSION_ was
specified by the user that version was set only as the minimum version
but not as the maximum version as well.
Steve Holme (5 Mar 2016)
- .gitignore: Added *.VC.opendb and *.vcxproj.user files for VC14
- build-openssl.bat: Fixed cannot find perl if installed but not in path
- checksrc.bat: Fixed cannot find perl if installed but not in path
Jay Satiro (5 Mar 2016)
- [Viktor Szakats brought this change]
makefile.m32: fix to allow -ssh2-winssl combination
In makefile.m32, option -ssh2 (libssh2) automatically implied -ssl
(OpenSSL) option, with no way to override it with -winssl. Since both
libssh2 and curl support using Windows's built-in SSL backend, modify
the logic to allow that combination.
- cookie: Don't expire session cookies in remove_expired
Prior to this change cookies with an expiry date that failed parsing
and were converted to session cookies could be purged in remove_expired.
Bug: https://github.com/curl/curl/issues/697
Reported-by: Seth Mos
Daniel Stenberg (3 Mar 2016)
- cookie: remove redundant check
... as it was already checked previously within the function.
Reported-by: Dmitry-Me
Closes #695
Jay Satiro (1 Mar 2016)
- [Anders Bakken brought this change]
url: if Curl_done is premature then pipeline not in use
Prevent a crash if 2 (or more) requests are made to the same host and
pipelining is enabled and the connection does not complete.
Bug: https://github.com/curl/curl/pull/690
- [Viktor Szakats brought this change]
makefile.m32: allow to pass .dll/.exe-specific LDFLAGS
using envvars `CURL_LDFLAG_EXTRAS_DLL` and
`CURL_LDFLAG_EXTRAS_EXE` respectively. This
is useful f.e. to pass ASLR-related extra
options, that are required to make this
feature work when using the mingw toolchain.
Ref: https://github.com/curl/curl/pull/670#issuecomment-190863985
Closes https://github.com/curl/curl/pull/689
Daniel Stenberg (29 Feb 2016)
- formpost: fix memory leaks in AddFormData error branches
Reported-by: Dmitry-Me
Fixes #688
Jay Satiro (28 Feb 2016)
- getinfo: Fix syntax error when mbedTLS
The assignment of the mbedTLS TLS session info in the parent commit was
incorrect. Change the assignment to a pointer to the session structure.
- getinfo: Add support for mbedTLS TLS session info
.. and preprocessor check TLS session info is defined for all backends.
Daniel Stenberg (26 Feb 2016)
- ROADMAP: clarify on the TLS proxy, mention HTTP cookies to work on
- file: try reading from files with no size
Some systems have special files that report as 0 bytes big, but still
contain data that can be read (for example /proc/cpuinfo on
Linux). Starting now, a zero byte size is considered "unknown" size and
will be read as far as possible anyway.
Reported-by: Jesse Tan
Closes #681
Jay Satiro (25 Feb 2016)
- configure: warn on invalid ca bundle or path
- Warn if --with-ca-bundle file does not exist.
- Warn if --with-ca-path directory does not contain certificates.
- Improve help messages for both.
Example configure output:
ca cert bundle: /some/file (warning: certs not found)
ca cert path: /some/dir (warning: certs not found)
Bug: https://github.com/curl/curl/issues/404
Reported-by: Jeffrey Walton
Daniel Stenberg (24 Feb 2016)
- Curl_read: check for activated HTTP/1 pipelining, not only requested
... as when pipelining is used, we read things into a unified buffer and
we don't do that with HTTP/2. This could then easily make programs that
set CURLMOPT_PIPELINING = CURLPIPE_HTTP1|CURLPIPE_MULTIPLEX to get data
intermixed or plain broken between HTTP/2 streams.
Reported-by: Anders Bakken
Patrick Monnerat (24 Feb 2016)
- os400: Fix ILE/RPG definition of CURLOPT_TFTP_NO_OPTIONS
Jay Satiro (23 Feb 2016)
- getinfo: CURLINFO_TLS_SSL_PTR supersedes CURLINFO_TLS_SESSION
The two options are almost the same, except in the case of OpenSSL:
CURLINFO_TLS_SESSION OpenSSL session internals is SSL_CTX *.
CURLINFO_TLS_SSL_PTR OpenSSL session internals is SSL *.
For backwards compatibility we couldn't modify CURLINFO_TLS_SESSION to
return an SSL pointer for OpenSSL.
Also, add support for the 'internals' member to point to SSL object for
the other backends axTLS, PolarSSL, Secure Channel, Secure Transport and
wolfSSL.
Bug: https://github.com/curl/curl/issues/234
Reported-by: dkjjr89@users.noreply.github.com
Bug: https://curl.haxx.se/mail/lib-2015-09/0127.html
Reported-by: Michael König
Daniel Stenberg (23 Feb 2016)
- multi_remove_handle: keep the timeout list until after disconnect
The internal Curl_done() function uses Curl_expire() at times and that
uses the timeout list. Better clean up the list once we're done using
it. This caused a segfault.
Reported-by: 蔡文凱
Bug: https://curl.haxx.se/mail/lib-2016-02/0097.html
Kamil Dudka (23 Feb 2016)
- tests/sshserver.pl: use RSA instead of DSA for host auth
DSA is no longer supported by OpenSSH 7.0, which causes all SCP/SFTP
test cases to be skipped. Using RSA for host authentication works with
both old and new versions of OpenSSH.
Reported-by: Karlson2k
Closes #676
Jay Satiro (23 Feb 2016)
- TFTP: add option to suppress TFTP option requests (Part 2)
- Add tests.
- Add an example to CURLOPT_TFTP_NO_OPTIONS.3.
- Add --tftp-no-options to expose CURLOPT_TFTP_NO_OPTIONS.
Bug: https://github.com/curl/curl/issues/481
- [Michael Koenig brought this change]
TFTP: add option to suppress TFTP option requests (Part 1)
Some TFTP server implementations ignore the "TFTP Option extension"
(RFC 1782-1784, 2347-2349), or implement it in a flawed way, causing
problems with libcurl. Another switch for curl_easy_setopt
"CURLOPT_TFTP_NO_OPTIONS" is introduced which prevents libcurl from
sending TFTP option requests to a server, avoiding many problems caused
by faulty implementations.
Bug: https://github.com/curl/curl/issues/481
Daniel Stenberg (22 Feb 2016)
- [Karlson2k brought this change]
runtests: Fixed usage of %PWD on MinGW64
Closes #672
Jay Satiro (20 Feb 2016)
- CURLOPT_DEBUGFUNCTION.3: Fix example
- [Viktor Szakats brought this change]
src/Makefile.m32: add CURL_{LD,C}FLAGS_EXTRAS support
Sync with lib/Makefile.m32 which already uses those variables.
Bug: https://github.com/curl/curl/pull/670
Dan Fandrich (20 Feb 2016)
- Enabled test 1437 after the bug fix in commit 3fa220a6
Jay Satiro (19 Feb 2016)
- [Emil Lerner brought this change]
curl_sasl: Fix memory leak in digest parser
If any parameter in a HTTP DIGEST challenge message is present multiple
times, memory allocated for all but the last entry should be freed.
Bug: https://github.com/curl/curl/pull/667
Dan Fandrich (19 Feb 2016)
- Added test 1437 to verify a memory leak
Reported-by: neex@users.noreply.github.com
Jay Satiro (18 Feb 2016)
- CURLOPT_COOKIEFILE.3: HTTP headers must be Set-Cookie style
Bug: https://github.com/curl/curl/issues/666
Reported-by: baumanj@users.noreply.github.com
- curl.1: HTTP headers for --cookie must be Set-Cookie style
Bug: https://github.com/curl/curl/issues/666
Reported-by: baumanj@users.noreply.github.com
Daniel Stenberg (18 Feb 2016)
- curl.1: add a missing dash
- CONTRIBUTING.md: fix links
- ISSUE_TEMPLATE: github issue template
First version, try this out!
- CONTRIBUTING.md: move into .github
To hide github specific files somewhat from the rest.
- opts: add references
- examples/make: add 'checksrc' target
- 10-at-a-time: typecast the argument passed to sleep()
- externalsocket.c: fix compiler warning for fwrite return type
- anyauthput.c: fix compiler warnings
- simplessl.c: warning: while with space
- curlx.c: i2s_ASN1_IA5STRING() clashes with an openssl function
Reported-By: Gisle Vanem
- http2: don't decompress gzip decoding automatically
At one point during the development of HTTP/2, the commit 133cdd29ea0
introduced automatic decompression of Content-Encoding as that was what
the spec said then. Now however, HTTP/2 should work the same way as
HTTP/1 in this regard.
Reported-by: Kazuho Oku
Closes #661
Jay Satiro (16 Feb 2016)
- [Tatsuhiro Tsujikawa brought this change]
http: Don't break the header into chunks if HTTP/2
nghttp2 callback deals with TLS layer and therefore the header does not
need to be broken into chunks.
Bug: https://github.com/curl/curl/issues/659
Reported-by: Kazuho Oku
Daniel Stenberg (16 Feb 2016)
- [Viktor Szakats brought this change]
openssl: use macro to guard the opaque EVP_PKEY branch
- [Viktor Szakats brought this change]
openssl: avoid direct PKEY access with OpenSSL 1.1.0
by using API instead of accessing an internal structure.
This is required starting OpenSSL 1.1.0-pre3.
Closes #650
- RELEASE-NOTES: synced with ede0bfc079da
- [Clint Clayton brought this change]
CURLOPT_CONNECTTIMEOUT_MS.3: Fix example to use milliseconds option
Change the example in the docs for CURLOPT_CONNECTTIMEOUT_MS to use
CURLOPT_CONNECTTIMEOUT_MS instead of CURLOPT_CONNECTTIMEOUT.
Closes #653
- opt-docs: add more references
- [David Byron brought this change]
SCP: use libssh2_scp_recv2 to support > 2GB files on windows
libssh2_scp_recv2 is introduced in libssh2 1.7.0 - to be released "any
day now.
Closes #451
Jay Satiro (13 Feb 2016)
- [Shine Fan brought this change]
gtls: fix for builds lacking encrypted key file support
Bug: https://github.com/curl/curl/pull/651
Dan Fandrich (13 Feb 2016)
- test1604: Add to Makefile.inc so it gets run
Jay Satiro (12 Feb 2016)
- generate.bat: Fix comment bug by removing old comments
Remove NOTES section, it's no longer needed since we aren't setting the
errorlevel and more importantly the recently updated URL in the comments
is causing some unusual behavior that breaks the script.
Closes https://github.com/curl/curl/issues/649
Kamil Dudka (12 Feb 2016)
- curl.1: --disable-{eprt,epsv} are ignored for IPv6 hosts
The behavior has been clarified in CURLOPT_FTP_USE_{EPRT,EPSV}.3 man
pages since curl-7_12_3~131. This patch makes it clear in the curl.1
man page, too.
Bug: https://bugzilla.redhat.com/1305970
Daniel Stenberg (12 Feb 2016)
- dist: ship buildconf.bat too
As the winbuild/* stuff uses it!
- curlx_tvdiff: handle 32bit time_t overflows
On 32bit systems, make sure we don't overflow and return funky values
for very large time differences.
Reported-by: Anders Bakken
Closes #646
- examples: fix some compiler warnings
- simplessl.c: fix my breakage
- examples: adhere to curl code style
All plain C examples now (mostly) adhere to the curl code style. While
they are only examples, they had diverted so much and contained all
sorts of different mixed code styles by now. Having them use a unified
style helps users and readability. Also, as they get copy-and-pasted
widely by users, making sure they're clean and nice is a good idea.
573 checksrc warnings were addressed.
- examples/cookie_interface.c: add cleanup call
cleaning up handles is a good idea as we leak memory otherwise
Also, line wrapped before 80 columns.
Kamil Dudka (10 Feb 2016)
- nss: search slash in forward direction in dup_nickname()
It is wasteful to search it backwards if we look for _any_ slash.
- nss: do not count enabled cipher-suites
We only care if at least one cipher-suite is enabled, so it does
not make any sense to iterate till the end and count all enabled
cipher-suites.
Daniel Stenberg (10 Feb 2016)
- contributors.sh: make 79 the max column width (from 80)
- RELEASE-NOTES: synced with c276aefee3995
- mbedtls.c: re-indent to better match curl standards
- [Rafael Antonio brought this change]
mbedtls: fix memory leak when destroying SSL connection data
Closes #626
- mbedtls: fix ALPN usage segfault
Since we didn't keep the input argument around after having called
mbedtls, it could end up accessing the wrong memory when figuring out
the ALPN protocols.
Closes #642
Jay Satiro (9 Feb 2016)
- [Timotej Lazar brought this change]
opts: update references to renamed options
- KNOWN_BUGS: Update #92 - Windows device prefix
- tool_doswin: Support for literal path prefix \\?\
For example something like --output \\?\C:\foo
Daniel Stenberg (9 Feb 2016)
- configure: state "BoringSSL" in summary when that was detected
- [David Benjamin brought this change]
openssl: remove most BoringSSL #ifdefs.
As of https://boringssl-review.googlesource.com/#/c/6980/, almost all of
BoringSSL #ifdefs in cURL should be unnecessary:
- BoringSSL provides no-op stubs for compatibility which replaces most
#ifdefs.
- DES_set_odd_parity has been in BoringSSL for nearly a year now. Remove
the compatibility codepath.
- With a small tweak to an extend_key_56_to_64 call, the NTLM code
builds fine.
- Switch OCSP-related #ifdefs to the more generally useful
OPENSSL_NO_OCSP.
The only #ifdefs which remain are Curl_ossl_version and the #undefs to
work around OpenSSL and wincrypt.h name conflicts. (BoringSSL leaves
that to the consumer. The in-header workaround makes things sensitive to
include order.)
This change errs on the side of removing conditionals despite many of
the restored codepaths being no-ops. (BoringSSL generally adds no-op
compatibility stubs when possible. OPENSSL_VERSION_NUMBER #ifdefs are
bad enough!)
Closes #640
Jay Satiro (8 Feb 2016)
- KNOWN_BUGS: Windows device prefix is required for devices
- tool_urlglob: Allow reserved dos device names (Windows)
Allow --output to reserved dos device names without the device prefix
for backwards compatibility.
Example: --output NUL can be used instead of --output \\.\NUL
Bug: https://github.com/curl/curl/commit/4520534#commitcomment-15954863
Reported-by: Gisle Vanem
Daniel Stenberg (8 Feb 2016)
- cookies: allow spaces in cookie names, cut of trailing spaces
It turns out Firefox and Chrome both allow spaces in cookie names and
there are sites out there using that.
Turned out the code meant to strip off trailing space from cookie names
didn't work. Fixed now.
Test case 8 modified to verify both these changes.
Closes #639
Patrick Monnerat (8 Feb 2016)
- Merge branch 'master' of github.com:curl/curl
- os400: sync ILE/RPG definitions with latest public header files.
Daniel Stenberg (8 Feb 2016)
- [Ludwig Nussel brought this change]
SSLCERTS: update wrt SSL CA certificate store
- [Ludwig Nussel brought this change]
configure: --with-ca-fallback: use built-in TLS CA fallback
When trying to verify a peer without having any root CA certificates
set, this makes libcurl use the TLS library's built in default as
fallback.
Closes #569
- Proxy-Connection: stop sending this header by default
RFC 7230 says we should stop. Firefox already stopped.
Bug: https://github.com/curl/curl/issues/633
Reported-By: Brad Fitzpatrick
Closes #633
- bump: work toward the next release
- THANKS: 2 contributors from the 7.47.1 release
- RELEASE-PROCEDURE: remove the github upload part
... as we're HTTPS on the main site now, there's no point in that
extra step
Version 7.47.1 (8 Feb 2016)
Daniel Stenberg (8 Feb 2016)
- RELEASE-NOTES: curl 7.47.1 time!
Jay Satiro (8 Feb 2016)
- tool_operhlp: Check for backslashes in get_url_file_name
Extract the filename from the last slash or backslash. Prior to this
change backslashes could be part of the filename.
This change needed for the curl tool built for Cygwin. Refer to the
CYGWIN addendum in advisory 20160127B.
Bug: https://curl.haxx.se/docs/adv_20160127B.html
Daniel Stenberg (7 Feb 2016)
- RELEASE-NOTES: synced with d6a8869ea34
Jay Satiro (6 Feb 2016)
- openssl: Fix signed/unsigned mismatch warning in X509V3_ext
sk_X509_EXTENSION_num may return an unsigned integer, however the value
will fit in an int.
Bug: https://github.com/curl/curl/commit/dd1b44c#commitcomment-15913896
Reported-by: Gisle Vanem
Daniel Stenberg (7 Feb 2016)
- TODO: 17.11 -w output to stderr
Jay Satiro (6 Feb 2016)
- [Michael Kaufmann brought this change]
idn_win32: Better error checking
.. also fix a conversion bug in the unused function
curl_win32_ascii_to_idn().
And remove wprintfs on error (Jay).
Bug: https://github.com/curl/curl/pull/637
- [Gisle Vanem brought this change]
examples/asiohiper: Avoid function name collision on Windows
closesocket => close_socket
Winsock already has the former.
Bug: https://curl.haxx.se/mail/lib-2016-02/0016.html
- [Gisle Vanem brought this change]
examples/htmltitle: Use _stricmp on Windows
Bug: https://curl.haxx.se/mail/lib-2016-02/0017.html
Daniel Stenberg (6 Feb 2016)
- COPYING: clarify that Daniel is not the sole author
... done on request and as it is a fair point.
Jay Satiro (5 Feb 2016)
- unit1604: Fix unit setup return code
- tool_doswin: Use type SANITIZEcode in sanitize_file_name
- tool_doswin: Improve sanitization processing
- Add unit test 1604 to test the sanitize_file_name function.
- Use -DCURL_STATICLIB when building libcurltool for unit testing.
- Better detection of reserved DOS device names.
- New flags to modify sanitize behavior:
SANITIZE_ALLOW_COLONS: Allow colons
SANITIZE_ALLOW_PATH: Allow path separators and colons
SANITIZE_ALLOW_RESERVED: Allow reserved device names
SANITIZE_ALLOW_TRUNCATE: Allow truncating a long filename
- Restore sanitization of banned characters from user-specified outfile.
Prior to this commit sanitization of a user-specified outfile was
temporarily disabled in 2b6dadc because there was no way to allow path
separators and colons through while replacing other banned characters.
Now in such a case we call the sanitize function with
SANITIZE_ALLOW_PATH which allows path separators and colons to pass
through.
Closes https://github.com/curl/curl/issues/624
Reported-by: Octavio Schroeder
- [Viktor Szakats brought this change]
URLs: change more http to https
- sasl_sspi: Fix memory leak in domain populate
Free an existing domain before replacing it.
Bug: https://github.com/curl/curl/issues/635
Reported-by: silveja1@users.noreply.github.com
Daniel Stenberg (4 Feb 2016)
- [Viktor Szakats brought this change]
URLs: follow GitHub project rename (also Travis CI)
Closes #632
- CHANGES.o: fix references to curl.haxx.nu
I removed the scheme prefix from the URLs references this host name, as
we don't own/run that anymore but the name is kept for historic reasons.
- HISTORY: add some info about when we used which host names
Jay Satiro (2 Feb 2016)
- [Viktor Szakats brought this change]
URLs: change more http to https
Dan Fandrich (3 Feb 2016)
- URLs: Change more haxx.se URLs from http: to https:
Daniel Stenberg (3 Feb 2016)
- RELEASE-NOTES: synced with 4af40b364
- URLs: change all http:// URLs to https://
- configure: update the copyright year range in output
- dotdot: allow an empty input string too
It isn't used by the code in current conditions but for safety it seems
sensible to at least not crash on such input.
Extended unit test 1395 to verify this too as well as a plain "/" input.
- HTTPS: update a bunch of URLs from HTTP to HTTPS
- [Sergei Nikulov brought this change]
AppVeyor: updated to handle OpenSSL/WinSSL builds
Closes #621
Jay Satiro (1 Feb 2016)
- tool_operate: Don't sanitize --output path (Windows)
Due to path separators being incorrectly sanitized in --output
pathnames, eg -o c:\foo => c__foo
This is a partial revert of 3017d8a until I write a proper fix. The
remote-name will continue to be sanitized, but if the user specified an
--output with string replacement (#1, #2, etc) that data is unsanitized
until I finish a fix.
Bug: https://github.com/bagder/curl/issues/624
Reported-by: Octavio Schroeder
- curl.1: Explain remote-name behavior if file already exists
.. also warn about letting the server pick the filename.
- [Gisle Vanem brought this change]
urldata: Error on missing SSL backend-specific connect info
Daniel Stenberg (28 Jan 2016)
- bump: towards the next (7.47.1 ?)
- [Sergei Nikulov brought this change]
cmake: fixed when OpenSSL enabled on Windows and schannel detected
Closes #617
Jay Satiro (28 Jan 2016)
- [Sergei Nikulov brought this change]
urldata: moved common variable out of ifdef
Closes https://github.com/bagder/curl/pull/618
- [Viktor Szakats brought this change]
tool_doswin: silence unused function warning
tool_doswin.c:185:14: warning: 'msdosify' defined but not used
[-Wunused-function]
Closes https://github.com/bagder/curl/pull/616
Daniel Stenberg (27 Jan 2016)
- getredirect.c: fix variable name
Reported-by: Bernard Spil
Version 7.47.0 (27 Jan 2016)
Daniel Stenberg (27 Jan 2016)
- examples/Makefile.inc: specify programs without .c!
- THANKS: 6 new contributors from 7.47.0 release notes
- [Isaac Boukris brought this change]
NTLM: Fix ConnectionExists to compare Proxy credentials
Proxy NTLM authentication should compare credentials when
re-using a connection similar to host authentication, as it
authenticate the connection.
Example:
curl -v -x http://proxy:port http://host/ -U good_user:good_pwd
--proxy-ntlm --next -x http://proxy:port http://host/
[-U fake_user:fake_pwd --proxy-ntlm]
CVE-2016-0755
Bug: http://curl.haxx.se/docs/adv_20160127A.html
- [Ray Satiro brought this change]
curl: avoid local drive traversal when saving file (Windows)
curl does not sanitize colons in a remote file name that is used as the
local file name. This may lead to a vulnerability on systems where the
colon is a special path character. Currently Windows/DOS is the only OS
where this vulnerability applies.
CVE-2016-0754
Bug: http://curl.haxx.se/docs/adv_20160127B.html
- RELEASE-NOTES: 7.47.0
- FAQ: language fix in 4.19
- [paulehoffman brought this change]
FAQ: Update to point to GitHub
Current FAQ didn't make it clear where the main repo is.
Closes #612
- maketgz: generate date stamp with LC_TIME=C
bug: http://curl.haxx.se/mail/lib-2016-01/0123.html
- curl_multi_socket_action.3: line wrap
- RELEASE-NOTES: synced with d58ba66eeceb
Steve Holme (21 Jan 2016)
- TODO: "Create remote directories" for SMB
Jay Satiro (18 Jan 2016)
- mbedtls: Fix pinned key return value on fail
- Switch from verifying a pinned public key in a callback during the
certificate verification to inline after the certificate verification.
The callback method had three problems:
1. If a pinned public key didn't match, CURLE_SSL_PINNEDPUBKEYNOTMATCH
was not returned.
2. If peer certificate verification was disabled the pinned key
verification did not take place as it should.
3. (related to #2) If there was no certificate of depth 0 the callback
would not have checked the pinned public key.
Though all those problems could have been fixed it would have made the
code more complex. Instead we now verify inline after the certificate
verification in mbedtls_connect_step2.
Ref: http://curl.haxx.se/mail/lib-2016-01/0047.html
Ref: https://github.com/bagder/curl/pull/601
- tests: Add a test for pinnedpubkey fail even when insecure
Because disabling the peer verification (--insecure) must not disable
the public key pinning check (--pinnedpubkey).
- [Daniel Schauenberg brought this change]
CURLINFO_RESPONSE_CODE.3: add example
Kamil Dudka (15 Jan 2016)
- ssh: make CURLOPT_SSH_PUBLIC_KEYFILE treat "" as NULL
The CURLOPT_SSH_PUBLIC_KEYFILE option has been documented to handle
empty strings specially since curl-7_25_0-31-g05a443a but the behavior
was unintentionally removed in curl-7_38_0-47-gfa7d04f.
This commit restores the original behavior and clarifies it in the
documentation that NULL and "" have both the same meaning when passed
to CURLOPT_SSH_PUBLIC_KEYFILE.
Bug: http://curl.haxx.se/mail/lib-2016-01/0072.html
Daniel Stenberg (14 Jan 2016)
- RELEASE-NOTES: synced with 35083ca60ed035a
- openssl: improved error detection/reporting
... by extracting the LIB + REASON from the OpenSSL error code. OpenSSL
1.1.0+ returned a new func number of another cerfificate fail so this
required a fix and this is the better way to catch this error anyway.
- openssl: for 1.1.0+ they now provide a SSLeay() macro of their own
- CURLOPT_RESOLVE.3: minor language polish
- configure: assume IPv6 works when cross-compiled
The configure test uses AC_TRY_RUN to figure out if an ipv6 socket
works, and testing like that doesn't work for cross-compiles. These days
IPv6 support is widespread so a blind guess is probably more likely to
be 'yes' than 'no' now.
Further: anyone who cross-compiles can use configure's --disable-ipv6 to
explicitly disable IPv6 and that also works for cross-compiles.
Made happen after discussions in issue #594
- TODO: "Try to URL encode given URL"
Closes #514
- ConnectionExists: only do pipelining/multiplexing when asked
When an HTTP/2 upgrade request fails (no protocol switch), it would
previously detect that as still possible to pipeline on (which is
acorrect) and do that when PIPEWAIT was enabled even if pipelining was
not explictily enabled.
It should only pipelined if explicitly asked to.
Closes #584
- [Mohammad AlSaleh brought this change]
lib: Prefix URLs with lower-case protocol names/schemes
Before this patch, if a URL does not start with the protocol
name/scheme, effective URLs would be prefixed with upper-case protocol
names/schemes. This behavior might not be expected by library users or
end users.
For example, if `CURLOPT_DEFAULT_PROTOCOL` is set to "https". And the
URL is "hostname/path". The effective URL would be
"HTTPS://hostname/path" instead of "https://hostname/path".
After this patch, effective URLs would be prefixed with a lower-case
protocol name/scheme.
Closes #597
Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
- [Alessandro Ghedini brought this change]
scripts: don't generate and install zsh completion when cross-compiling
- [Alessandro Ghedini brought this change]
scripts: fix zsh completion generation
The script should use the just-built curl, not the system one. This fixes
zsh completion generation when no system curl is installed.
- [Alessandro Ghedini brought this change]
zsh.pl: fail if no curl is found
Instead of generation a broken completion file.
- [Michael Kaufmann brought this change]
IDN host names: Remove the port number before converting to ACE
Closes #596
Jay Satiro (10 Jan 2016)
- runtests: Add mbedTLS to the SSL backends
.. and enable SSLpinning tests for mbedTLS, BoringSSL and LibreSSL.
Daniel Stenberg (10 Jan 2016)
- [Thomas Glanzmann brought this change]
mbedtls: implement CURLOPT_PINNEDPUBLICKEY
Jay Satiro (9 Jan 2016)
- [Tatsuhiro Tsujikawa brought this change]
url: Fix compile error with --enable-werror
- [Tatsuhiro Tsujikawa brought this change]
http2: Ensure that http2_handle_stream_close is called
Previously, when HTTP/2 is enabled and used, and stream has content
length known, Curl_read was not called when there was no bytes left to
read. Because of this, we could not make sure that
http2_handle_stream_close was called for every stream. Since we use
http2_handle_stream_close to emit trailer fields, they were
effectively ignored. This commit changes the code so that Curl_read is
called even if no bytes left to read, to ensure that
http2_handle_stream_close is called for every stream.
Discussed in https://github.com/bagder/curl/pull/564
Daniel Stenberg (8 Jan 2016)
- http2: handle the received SETTINGS frame
This regression landed in 5778e6f5 and made libcurl not act on received
settings and instead stayed with its internal defaults.
Bug: http://curl.haxx.se/mail/lib-2016-01/0031.html
Reported-by: Bankde
- Revert "multiplex: allow only once HTTP/2 is actually used"
This reverts commit 46cb70e9fa81c9a56de484cdd7c5d9d0d9fbec36.
Bug: http://curl.haxx.se/mail/lib-2016-01/0031.html
Jay Satiro (8 Jan 2016)
- [Tatsuhiro Tsujikawa brought this change]
http2: Fix PUSH_PROMISE headers being treated as trailers
Discussed in https://github.com/bagder/curl/pull/564
Daniel Stenberg (8 Jan 2016)
- [Michael Kaufmann brought this change]
connection reuse: IDN host names fixed
Use the ACE form of IDN hostnames as key in the connection cache. Add
new tests.
Closes #592
- tests: mark IPv6 FTP and FTPS tests with the FTP keyword
Jay Satiro (7 Jan 2016)
- mbedtls: Fix ALPN support
- Fix ALPN reply detection.
- Wrap nghttp2 code in ifdef USE_NGHTTP2.
Prior to this change ALPN and HTTP/2 did not work properly in mbedTLS.
- http2: Fix client write for trailers on stream close
Check that the trailer buffer exists before attempting a client write
for trailers on stream close.
Refer to comments in https://github.com/bagder/curl/pull/564
Daniel Stenberg (7 Jan 2016)
- COPYING: update general copyright year range
- ConnectionExists: add missing newline in infof() call
Mistake from commit a464f33843ee1
- multiplex: allow only once HTTP/2 is actually used
To make sure curl doesn't allow multiplexing before a connection is
upgraded to HTTP/2 (like when Upgrade: h2c fails), we must make sure the
connection uses HTTP/2 as well and not only check what's wanted.
Closes #584
Patch-by: c0ff
Jay Satiro (4 Jan 2016)
- curl_global_init.3: Add Windows-specific info for init via DLL
- Add to both curl_global_init.3 and libcurl.3 the caveat for Windows
that initializing libcurl via a DLL's DllMain or static initializer
could cause a deadlock.
Bug: https://github.com/bagder/curl/issues/586
Reported-by: marc-groundctl@users.noreply.github.com
Daniel Stenberg (4 Jan 2016)
- FAQ: clarify who to mail about ECCN clarifications
- progressfunc.c: spellfix description
- docs/examples/multi-app.c: fix bad desc formatting
- examples: added descriptions
- example/simple.c: add description
- getredirect.c: a new example
Marc Hoersken (27 Dec 2015)
- RELEASE-NOTES: add 5e0e81a9c4e35f04ca
Daniel Stenberg (26 Dec 2015)
- RELEASE-NOTES: synced with 2aec4359db1088b10d
Marc Hoersken (26 Dec 2015)
- test 1515: add data check
- test 1515: add MSYS support by passing a relative path
MSYS would otherwise turn a /-style path into a C:\-style path.
- test 539: use datacheck mode text for ASCII-mode LISTings
While still using datacheck mode binary for the inline reply data.
- runtests.pl: check up to 5 data parts with different text modes
Move the text-mode conversion for reply/replycheck from the verify
section into the load section and add support for 4 more check parts.
Daniel Stenberg (24 Dec 2015)
- CURLOPT_RANGE: for HTTP servers, range support is optional
Marc Hoersken (24 Dec 2015)
- tests 1048 and 1050: use datacheck mode text for ASCII-mode LISTings
- tests 706 and 707: use datacheck mode text for ASCII-mode LISTings
- tests 400,403,406: use datacheck mode text for ASCII-mode LISTings
- sockfilt.c: fix calculation of sleep timeout on Windows
Not converting to double caused small timeouts to be skipped.
- tests first.c: fix calculation of sleep timeout on Windows
Not converting to double caused small timeouts to be skipped.
- test 573: add more debug output
- ftplistparser.c: fix handling of file LISTings using Windows EOL
Previously file.txt[CR][LF] would have been returned as file.tx
(without the last t) if filetype is symlink. Now the t is
included and the internal item_length includes the zero byte.
Spotted using test 576 on Windows.
- test 16: fix on Linux (and Windows) by using plain ASCII characters
Follow up on b064ff0c351bb287557228575ef4c1d079b866fb, thanks Daniel.
- tftpd server: add Windows support by writing files in binary mode
- tests 252-255: use datacheck mode text for ASCII-mode LISTings
- test 16: fix on Windows by converting data file from ANSI to UTF-8
Daniel Stenberg (23 Dec 2015)
- Makefile.inc: s/curl_SOURCES/CURL_FILES
This allows the root Makefile.am to include the Makefile.inc without
causing automake to warn on it (variables named *_SOURCES are
magic). curl_SOURCES is then instead assigned properly in
src/Makefile.am only.
Closes #577
- [Anders Bakken brought this change]
ConnectionExists: with *PIPEWAIT, wait for connections
Try harder to prevent libcurl from opening up an additional socket when
CURLOPT_PIPEWAIT is set. Accomplished by letting ongoing TCP and TLS
handshakes complete first before the decision is made.
Closes #575
- [Anders Bakken brought this change]
Add .dir-locals and set c-basic-offset to 2.
This makes it easier for emacs users to automatically get the right
2-space indentation when they edit curl source files.
c++-mode is in there as well because Emacs can't easily know if
something is a C or C++ header.
Closes #574
- [Johannes Schindelin brought this change]
configure: detect IPv6 support on Windows
This patch was "nicked" from the MINGW-packages project by Daniel.
https://github.com/Alexpux/MINGW-packages/commit/9253d0bf58a1486e91f7efb5316e7fdb48fa4007
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
- configure: allow static builds on mingw
This patch is adopted from the MINGW-packages project. It makes it
possible to build curl both shared and static again.
URL: https://github.com/Alexpux/MINGW-packages/tree/master/mingw-w64-curl
Marc Hoersken (17 Dec 2015)
- test 1326: fix file check since curl is outputting binary data
- test 1326: fix getting stuck on Windows due to incomplete request
The request needs to be read and send in binary mode in order to use
CRLF instead of LF. Adding --upload-file - causes curl to read stdin
in binary mode.
Daniel Stenberg (17 Dec 2015)
- RELEASE-NOTES: command line option recount
Dan Fandrich (16 Dec 2015)
- scripts/Makefile: build zsh script even in an out-of-tree build
Marc Hoersken (16 Dec 2015)
- sockfilt.c: added some debug output to select_ws
- sockfilt.c: keep lines shorter than 80 chars
- sockfilt.c: do not wait on unreliable file or pipe handle
The previous implementation caused issues on modern MSYS2 runtimes.
Daniel Stenberg (16 Dec 2015)
- cyassl: deal with lack of *get_peer_certificate
The function is only present in wolfssl/cyassl if it was built with
--enable-opensslextra. With these checks added, pinning support is disabled
unless the TLS lib has that function available.
Also fix the mistake in configure that checks for the wrong lib name.
Closes #566
- wolfssl: handle builds without SSLv3 support
- [Tatsuhiro Tsujikawa brought this change]
http2: Support trailer fields
This commit adds trailer support in HTTP/2. In HTTP/1.1, chunked
encoding must be used to send trialer fields. HTTP/2 deprecated any
trandfer-encoding, including chunked. But trailer fields are now
always available.
Since trailer fields are relatively rare these days (gRPC uses them
extensively though), allocating buffer for trailer fields is done when
we detect that HEADERS frame containing trailer fields is started. We
use Curl_add_buffer_* functions to buffer all trailers, just like we
do for regular header fields. And then deliver them when stream is
closed. We have to be careful here so that all data are delivered to
upper layer before sending trailers to the application.
We can deliver trailer field one by one using NGHTTP2_ERR_PAUSE
mechanism, but current method is far more simple.
Another possibility is use chunked encoding internally for HTTP/2
traffic. I have not tested it, but it could add another overhead.
Closes #564
- RELEASE-NOTES: synced with 6c2c019654e658a
Jay Satiro (15 Dec 2015)
- x509asn1: Fix host altname verification
- In Curl_verifyhost check all altnames in the certificate.
Prior to this change only the first altname was checked. Only the GSKit
SSL backend was affected by this bug.
Bug: http://curl.haxx.se/mail/lib-2015-12/0062.html
Reported-by: John Kohl
Daniel Stenberg (15 Dec 2015)
- curl --expect100-timeout: added
This is the new command line option to set the value for the existing
libcurl option CURLOPT_EXPECT_100_TIMEOUT_MS
- cyassl: fix compiler warning on type conversion
- curlver: the pending release will become 7.47.0
- [Anders Bakken brought this change]
setstropt: const-correctness
Closes #565
- ROADMAP: implemented HTTP2 for HTTPS-only
- HTTP2.md: spell fix and remove TODO now implemented
- libressl: the latest openssl x509 funcs are not in libressl
- curl: use 2TLS by default
Make this the default for the curl tool (if built with HTTP/2 powers
enabled) unless a specific HTTP version is requested on the command
line.
This should allow more users to get HTTP/2 powers without having to
change anything.
- http: add libcurl option to allow HTTP/2 for HTTPS only
... and stick to 1.1 for HTTP. This is in line with what browsers do and
should have very little risk.
- openssl: adapt to openssl >= 1.1.0 X509 opaque structs
Closes #491
- openssl: avoid BIO_reset() warnings since it returns a value
- openssl: adapt to 1.1.0+ name changes
- scripts/makefile: add standard header
- scripts/Makefile: fix GNUism and survive no perl
Closes #555
Reported-by: Thomas Klausner
- fix b6d5cb40d7038fe
- [Tatsuhiro Tsujikawa brought this change]
http2: Fix hanging paused stream
When NGHTTP2_ERR_PAUSE is returned from data_source_read_callback, we
might not process DATA frame fully. Calling nghttp2_session_mem_recv()
again will continue to process DATA frame, but if there is no incoming
frames, then we have to call it again with 0-length data. Without this,
on_stream_close callback will not be called, and stream could be hanged.
Bug: http://curl.haxx.se/mail/lib-2015-11/0103.html
Reported-by: Francisco Moraes
- [Christian Stewart brought this change]
build: fix compilation error with CURL_DISABLE_VERBOSE_STRINGS
With curl disable verbose strings in http.c the compilation fails due to
the data variable being undefined later on in the function.
Closes #558
Jay Satiro (7 Dec 2015)
- [Gisle Vanem brought this change]
config-win32: Fix warning HAVE_WINSOCK2_H undefined
- [Gisle Vanem brought this change]
openssl: BoringSSL doesn't have CONF_modules_free
- [Gisle Vanem brought this change]
lwip: Fix compatibility issues with later versions
The name of the header guard in lwIP's <lwip/opt.h> has changed from
'__LWIP_OPT_H__' to 'LWIP_HDR_OPT_H' (bug #35874 in May 2015).
Other fixes:
- In curl_setup.h, the problem with an old PSDK doesn't apply if lwIP is
used.
- In memdebug.h, the 'socket' should be undefined first due to lwIP's
lwip_socket() macro.
- In curl_addrinfo.c lwIP's getaddrinfo() + freeaddrinfo() macros need
special handling because they were undef'ed in memdebug.h.
- In select.c we can't use preprocessor conditionals inside select if
MSVC and select is a macro, as it is with lwIP.
http://curl.haxx.se/mail/lib-2015-12/0023.html
http://curl.haxx.se/mail/lib-2015-12/0024.html
Patrick Monnerat (7 Dec 2015)
- os400: define CURL_VERSION_PSL in ILE/RPG binding
Jay Satiro (7 Dec 2015)
- [Gisle Vanem brought this change]
version: Add flag CURL_VERSION_PSL for libpsl
- formdata: Check if length is too large for memory
- If the size of the length type (curl_off_t) is greater than the size
of the size_t type then check before allocating memory to make sure the
value of length will fit in a size_t without overflow. If it doesn't
then return CURLE_BAD_FUNCTION_ARGUMENT.
Bug: https://github.com/bagder/curl/issues/425#issuecomment-154518679
Reported-by: Steve Holme
Steve Holme (3 Dec 2015)
- tests: Corrected copy and pasted comments from commit e643c5c908
Daniel Stenberg (3 Dec 2015)
- curl: remove keepalive #ifdef checks done on libcurl's behalf
They didn't match the ifdef logic used within libcurl anyway so they
could indeed warn for the wrong case - plus the tool cannot know how the
lib actually performs at that level.
Steve Holme (2 Dec 2015)
- test947: Corrected typo in test name
- tests: Disable the OAUTHBEARER tests when using a non-default port number
Tests 842, 843, 844, 845, 887, 888, 889, 890, 946, 947, 948 and 949 fail
if a custom port number is specified via the -b option of runtests.pl.
Suggested by: Kamil Dudka
Bug: http://curl.haxx.se/mail/lib-2015-12/0003.html
Daniel Stenberg (2 Dec 2015)
- bump: towards next release
for all we know now, it might be called 7.46.1
Version 7.46.0 (1 Dec 2015)
Daniel Stenberg (1 Dec 2015)
- RELEASE-NOTES: updated contributor count for 7.46.0
- THANKS: new contributors from the 7.46.0 release
- THANKS-filter: single Tim Rühsen spelling
- docs/examples: gitignore some more built examples
- RELEASE-NOTES; this bug was never released
- RELEASE-NOTES: synced with e55f15454efacb0
- [Flavio Medeiros brought this change]
Curl_read_plain: clean up ifdefs that break statements
Closes #546
- http2: convert some verbose output into debug-only output
- http2 push: add missing inits of new stream
- set the correct stream_id for pushed streams
- init maxdownload and size properly
- http2 push: set weight for new stream
give the new stream the old one's stream_weight internally to avoid
sending a PRIORITY frame unless asked for it
- curl_setup.h: undef freeaddrinfo in c-ares block to fix build
Fixes warnings 78c25c854a added.
- nonblock: fix setting non-blocking mode for Amiga
IoctlSocket() apparently wants a pointer to a long, passed as a char *
in its third parameter. This bug was introduced already back in commit
c5fdeef41d from October 1 2001!
Bug: http://curl.haxx.se/mail/lib-2015-11/0088.html
Reported-by: Norbert Kett
- zsh install: fix DESTDIR support
Reported-by: Mohammad AlSaleh
Dan Fandrich (27 Nov 2015)
- lib: Only define curl_dofreeaddrinfo if struct addrinfo is available
Steve Holme (27 Nov 2015)
- tool_paramhlp: Fixed display of URL index in password prompt for --next
Commit f3bae6ed73 added the URL index to the password prompt when using
--next. Unfortunately, because the size_t specifier (%zu) is not
supported by all sprintf() implementations we use the curl_off_t format
specifier instead. The display of an incorrect value arises on platforms
where size_t and curl_off_t are of a different size.
Daniel Stenberg (25 Nov 2015)
- timecond: do not add if-modified-since without timecondition
The RTSP code path didn't skip adding the if-modified-since for certain
RTSP code paths, even if CURLOPT_TIMECONDITION was set to
CURL_TIMECOND_NONE.
Also, an unknown non-zero CURLOPT_TIMECONDITION value no longer equals
CURL_TIMECOND_IFMODSINCE.
Bug: http://stackoverflow.com/questions/33903982/curl-timecond-none-doesnt-work-how-to-remove-if-modified-since-header
- RELEASE-NOTES: synced with 99d17a5e2ba77e58
- examples/README: cut out the incomplete list
... and add a generic explanation for them instead. Each example file
should contain its own description these days.
- test1513: make sure the callback is only called once
- [Daniel Shahaf brought this change]
build: Install zsh completion
Fixes #534
Closes #537
- done: make sure the final progress update is made
It would previously be skipped if an existing error was returned, but
would lead to a previous value being left there and later used.
CURLINFO_TOTAL_TIME for example.
Still it avoids that final progress update if we reached DONE as the
result of a callback abort to avoid another callback to be called after
an abort-by-callback.
Reported-by: Lukas Ruzicka
Closes #538
- curl: expanded the -XHEAD warning text
... to also mention the specific options used.
- Revert "cleanup: general removal of TODO (and similar) comments"
This reverts commit 64e959ffe37c436503f9fed1ce2d6ee6ae50bd9a.
Feedback-by: Dan Fandrich
URL: http://curl.haxx.se/mail/lib-2015-11/0062.html
- CURLOPT_HEADERFUNCTION.3: fix typo
Refer to _HEADERDATA not _WRITEDATA.
Reported-by: Michał Piechowski
- TODO: TCP Fast Open
Steve Holme (22 Nov 2015)
- examples: Added website parse-able descriptions to the e-mail examples
- TODO: Added another 'multi-interface' idea
- smb.c: Fixed compilation warnings
smb.c:134:3: warning: conversion to 'short unsigned int' from 'int' may
alter its value
smb.c:146:42: warning: conversion to 'unsigned int' from 'long long
unsigned int' may alter its value
smb.c:146:65: warning: conversion to 'unsigned int' from 'long long
unsigned int' may alter its value
- schannel: Corrected copy/paste error in commit 8d17117683
- schannel: Use GetVersionEx() when VerifyVersionInfo() isn't available
Regression from commit 7a8e861a5 as highlighted in the msys autobuilds.
- examples: Fixed compilation warnings
pop3-multi.c:96:5: warning: implicit declaration of function 'memset'
imap-multi.c:96:5: warning: implicit declaration of function 'memset'
http2-download.c:226:5: warning: implicit declaration of function 'memset'
http2-upload.c:290:5: warning: implicit declaration of function 'memset'
http2-upload.c:290:5: warning: implicit declaration of function 'memset'
- Makefile.inc: Fixed test run error
test845 not present in tests/data/Makefile.inc
Daniel Stenberg (20 Nov 2015)
- TODO: remove duplicated title
- TODO: added two more libcurl ideas
Moved some ideas from "next major" to just ordinary ideas since we can
always add new things while keeping the old without doing a "next
major".
Steve Holme (20 Nov 2015)
- tests: Re-enabled tests 889 and 890 following POP3 fix
- pop3: Differentiate between success and continuation responses
- pop3: Added clarity on some server response codes
Daniel Stenberg (20 Nov 2015)
- [Daniel Shahaf brought this change]
build: Fix theoretical infinite loops
Add error-checking to 'cd' in a few cases where omitting the checks
might result in an infinite loop.
Closes #535
Patrick Monnerat (19 Nov 2015)
- curl.h: s/#defien/#define/
- os400: synchronize ILE/RPG header file
- os400: Provide options for libssh2 use in compile scripts. Adjust README.
Daniel Stenberg (19 Nov 2015)
- [danielsh@apache.org brought this change]
zsh completion: Preserve single quotes in output
When an option's help string contains literal single quotes, those
single quotes would be stripped from the option's description in the
completion output (unless the zsh RC_QUOTES option were set while the
completion function was being sourced, which is not the default). This
patch makes the completion output contain single quotes where the --help
output does.
Closes #532
Jay Satiro (18 Nov 2015)
- [MaxGiting brought this change]
FAQ: Grammar changes
Closes https://github.com/bagder/curl/pull/533
Daniel Stenberg (17 Nov 2015)
- http2: http_done: don't free already-freed push headers
The push headers are freed after the push callback has been invoked,
meaning this code should only free the headers if the callback was never
invoked and thus the headers weren't freed at that time.
Reported-by: Davey Shafik
- [Anders Bakken brought this change]
getconnectinfo: Don't call recv(2) if socket == -1
Closes #528
- CURLMOPT_PUSHFUNCTION.3: *_byname() returns only the first header
... if there are more than one using the same name
- http2: minor comment typo
- sasl; fix checksrc warnings
Steve Holme (15 Nov 2015)
- RELEASE-NOTES: Adjusted for the recent OAuth 2.0 activity
- tests: Disabled 889 and 890 until we support POP3 continuation responses
As POP3 final and continuation responses both begin with a + character,
and both the finalcode and contcode variables in SASLprotoc are set as
such, we cannot tell the difference between them when we are expecting
an optional continuation from the server such as the following:
+ something else from the server
+OK final response
Disabled these tests until such a time we can tell the responses apart.
- tests: Corrected typos from commit ba4d8f7eba
- tests: Added OAUTHBEARER failure response tests
- oauth2: Support OAUTHBEARER failures sent as continuation responses
According to RFC7628 a failure message may be sent by the server in a
base64 encoded JSON string as a continuation response.
Currently only implemented for OAUTHBEARER and not XAUTH2.
Daniel Stenberg (15 Nov 2015)
- RELEASE-NOTES: synced with 808a17ee675
Steve Holme (14 Nov 2015)
- tests: Renamed existing OAuth 2.0 (XOAUTH) tests
- tests: Added OAuth 2.0 (OAUTHBEARER) tests
- oauth2: Added support for OAUTHBEARER SASL mechanism to IMAP, POP3 and SNMP
OAUTHBEARER is now the official "registered" SASL mechanism name for
OAuth 2.0. However, we don't want to drop support for XOAUTH2 as some
servers won't support the new mechanism yet.
Daniel Stenberg (13 Nov 2015)
- RELEASE-NOTES: recounted curl_easy_setopt() options
- typecheck-gcc.h: add missing slist-using options
CURLOPT_RESOLVE and CURLOPT_PROXYHEADER were missing
Also sorted the list.
- typecheck-gcc.h: added CURLOPT_CLOSESOCKETDATA
... and sorted curl_is_cb_data_option alphabetically
Jay Satiro (13 Nov 2015)
- [Sebastian Pohlschmidt brought this change]
openssl: Free modules on cleanup
Curl_ossl_init calls OPENSSL_load_builtin_modules() but
Curl_ossl_cleanup doesn't make a call to free these modules.
Bug: https://github.com/bagder/curl/issues/526
Steve Holme (13 Nov 2015)
- symbols-in-versions: Added new CURLOPTTYPE_STRINGPOINT alias
...following commit aba281e762 to fix test 1119.
Daniel Stenberg (13 Nov 2015)
- curl: mark two more options strings for --libcurl output
- typecheck-gcc.h: add some missing string types
Also sorted that list alphabetically
- curl.h: introducing the STRINGPOINT alias
As an alias for OBJECTPOINT. Provided to allow us to grep for all string
options easier.
- cleanup: general removal of TODO (and similar) comments
They tend to never get updated anyway so they're frequently inaccurate
and we never go back to revisit them anyway. We document issues to work
on properly in KNOWN_BUGS and TODO instead.
- ftplistparser: remove empty function
- openssl: remove #if check for 0.9.7 for ENGINE_load_private_key
- openssl: all supported versions have X509_STORE_set_flags
Simplify by removing #ifdefs and macros
- openssl: remove 0.9.3 check
- openssl: remove #ifdefs for < 0.9.5 support
We only support >= 0.9.7
- lib/vtls/openssl: remove unused traces of yassl ifdefs
Dan Fandrich (12 Nov 2015)
- [dfandrich brought this change]
unit1603: Demote hash mismatch failure to a warning
The hashes can vary between architectures (e.g. Sparc differs from x86_64).
This is not a fatal problem but just reduces the coverage of these white-box
tests, as the assumptions about into which hash bucket each key falls are no
longer valid.
- [dfandrich brought this change]
unit1603: Added unit tests for hash functions
- [dfandrich brought this change]
unit1602: Fixed failure in torture test
Steve Holme (12 Nov 2015)
- sasl: Re-introduced XOAUTH2 in the default enabled authentication mechanism
Following the fix in commit d6d58dd558 it is necessary to re-introduce
XOAUTH2 in the default enabled authentication mechanism, which was
removed in commit 7b2012f262, otherwise users will have to specify
AUTH=XOAUTH2 in the URL.
Note: OAuth 2.0 will only be used when the bearer is specified.
- [Stefan Bühler brought this change]
sasl_sspi: fix identity memory leak in digest authentication
- [Stefan Bühler brought this change]
sasl_sspi: fixed unicode build for digest authentication
Closes #525
- oauth2: Re-factored OAuth 2.0 state variable
- sasl: Don't choose OAuth 2.0 if mechanism not advertised
Regression from commit 9e8ced9890 which meant if --oauth2-bearer was
specified but the SASL mechanism wasn't supported by the server then
the mechanism would be chosen.
Daniel Stenberg (12 Nov 2015)
- runtests: more compact "System characteristics" output
- no point in repeating curl features that is already listed as features
from the curl -V output
- remove the port numbers/unix domain path from the output unless
verbose is used, as that is rarely interesting to users.
- runtests: rename conditional curl-features to $has_[name]
Steve Holme (11 Nov 2015)
- oauth2: Introduced support for host and port details
Added support to the OAuth 2.0 message function for host and port, in
order to accommodate the official OAUTHBEARER SASL mechanism which is
to be added shortly.
- curl_setup.h: Removed duplicate CURL_DISABLE_RTSP when HTTP_ONLY defined
- cmake: Add missing feature macros in config header (Part 2)
In addition to commit a215381c94 added the RTSP, RTMP and SMB protocols.
Daniel Stenberg (10 Nov 2015)
- [Douglas Creager brought this change]
cmake: Add missing feature macros in config header
The curl_config.h file can be generated either from curl_config.h.cmake
or curl_config.h.in, depending on whether you're building using CMake or
the autotools. The CMake template header doesn't include entries for
all of the protocols that you can disable, which (I think) means that
you can't actually disable those protocols when building via CMake.
Closes #523
- [Douglas Creager brought this change]
BoringSSL: Work with stricter BIO_get_mem_data()
BoringSSL implements `BIO_get_mem_data` as a function, instead of a
macro, and expects the output pointer to be a `char **`. We have to add
an explicit cast to grab the pointer as a `const char **`.
Closes #524
- http2: rectify the http2 version #if check
We need 1.0.0 or later. Also verified by configure.
Steve Holme (9 Nov 2015)
- oauth2: Don't use XAUTH2 in OAuth 2.0 function name
- oauth2: Don't use XOAUTH2 in OAuth 2.0 variables
- oauth2: Use OAuth 2.0 rather than XOAUTH2 in comments
When referring to OAuth 2.0 we should use the official name rather the
SASL mechanism name.
Daniel Stenberg (9 Nov 2015)
- imap: avoid freeing constant string
The fix in 1a614c6c3 was wrong and would leed to free() of a fixed
string.
Pointed-out-by: Kamil Dudka
- ROADMAP: remove two items already done
- RELEASE-NOTES: synced with 2200bf62054
Jay Satiro (9 Nov 2015)
- acinclude: Remove check for 16-bit curl_off_t
Because it's illogical to check for a 16-bit curl_off_t.
Ref: https://github.com/bagder/curl/issues/425#issuecomment-154964205
Dan Fandrich (8 Nov 2015)
- tool: Fixed a memory leak on OOM introduced in 19cb0c4a
Steve Holme (8 Nov 2015)
- [Justin Ehlert brought this change]
imap: Don't check for continuation when executing a CUSTOMREQUEST
Bug: https://github.com/bagder/curl/issues/486
Closes https://github.com/bagder/curl/pull/487
Daniel Stenberg (7 Nov 2015)
- imap: checksrc: remove space after while before paren
- checksrc.whitelist: "missing space after close paren"
... when it was within a string!
Steve Holme (7 Nov 2015)
- opts: Corrected TLS protocols list to include POP3S rather than POP3
- imap: Quote other 'atom-specials' and not just the space character
Closes #517
- imap: Fixed double quote in LIST command when mailbox contains spaces
Daniel Stenberg (6 Nov 2015)
- imap: fix compiler warning
imap.c:657:13: error: assignment discards 'const' qualifier from pointer
target type [-Werror=discarded-qualifiers]
Steve Holme (6 Nov 2015)
- imap: Don't call imap_atom() when no mailbox specified in LIST command
Daniel Stenberg (6 Nov 2015)
- curl.1: remove the overlap --range example
... it is just weird to include by default even if it still works.
- tftp tests: verify sent options too
The tftpd test server now logs all received options and thus all TFTP
test cases need to match them exactly.
Extended test 283 to use and verify --tftp-blksize.
Jay Satiro (6 Nov 2015)
- getinfo: CURLINFO_ACTIVESOCKET: fix bad socket value
- Set user info param to the socket returned by Curl_getconnectinfo,
regardless of if the socket is bad. Effectively this means the user info
param now will receive CURL_SOCKET_BAD instead of -1 on bad socket.
- Remove incorrect comments.
CURLINFO_ACTIVESOCKET is documented to write CURL_SOCKET_BAD to user
info param but prior to this change it wrote -1.
Bug: https://github.com/bagder/curl/pull/518
Reported-by: Marcel Raad
Patrick Monnerat (5 Nov 2015)
- curl_ntlm_core: fix 2 curl_off_t constant overflows.
- os400: adjust specific code to support new options.
Daniel Stenberg (2 Nov 2015)
- [Lauri Kasanen brought this change]
rawstr: Speed up Curl_raw_toupper by 40%
Rationale: when starting up a curl-using app, all cookies from the jar
are checked against each other. This was causing a startup delay in the
Fifth browser.
All tests pass.
Signed-off-by: Lauri Kasanen <cand@gmx.com>
- http redirects: %-encode bytes outside of ascii range
Apparently there are sites out there that do redirects to URLs they
provide in plain UTF-8 or similar. Browsers and wget %-encode such
headers when doing a subsequent request. Now libcurl does too.
Added test 1138 to verify.
Closes #473
- RELEASE-NOTES: synced with cba5bc585410
- symbols-in-version: add all CURL_HTTPPOST_* symbols
- formadd: support >2GB files on windows
Closes #425
- curl.h: s/HTTPPOST_/CURL_HTTPOST_
Fixes a name space pollution at the cost of programs using one of these
defines will no longer compile. However, the vast majority of libcurl
programs that do multipart formposts use curl_formadd() to build this
list.
Closes #506
- mbedtls: fix "Structurally dead code"
CID 1332129
- mbedtls: fix "Logically dead code"
CID 1332128
- Revert "openssl: engine: remove double-free"
This reverts commit 370ee919b37cc9a46c36428b2bb1527eae5db2bd.
Issue #509 has all the details but it was confirmed that the crash was
not due to this, so the previous commit was wrong.
- curl.1: -E: s/private certificate/client certificate
... as the certificate is strictly speaking not private.
Reported-by: John Levon
- openssl: engine: remove double-free
After a successful call to SSL_CTX_use_PrivateKey(), we must not call
EVP_PKEY_free() on the key.
Reported-by: nased0
Closes #509
Jay Satiro (27 Oct 2015)
- socks: Fix incorrect port numbers in failed connect messages
Daniel Stenberg (26 Oct 2015)
- DISTRO-DILEMMA: removed
Out of date and not kept accurate. It was sort of a problem of the past
anyway.
- [xiangbin li brought this change]
MacOSX-Framework: sdk regex fix for sdk 10.10 and later
closes #507
Jay Satiro (24 Oct 2015)
- build: Fix support for PKG_CONFIG
- Allow the user to use PKG_CONFIG but not PKGCONFIG.
Background:
Last week in 14d5a86 a change was made to allow the user to set the
PKGCONFIG variable. Today in 72d99f2 I supplemented that to allow the
more common PKG_CONFIG as an alternative if PKGCONFIG is not set.
Neither of those changes worked as expected because PKGCONFIG is
occasionally reset in configure and by the CURL_CHECK_PKGCONFIG macro.
Instead in this commit I take the approach that the user may set
PKG_CONFIG only.
- build: Fix mingw ssl gdi32 order
- If mingw ssl make sure -lgdi32 comes after ssl libs
- Allow PKG_CONFIG to set pkg-config location and options
Bug: https://github.com/bagder/curl/pull/501
Reported-by: Kang Lin
Daniel Stenberg (23 Oct 2015)
- RELEASE-NOTES: synced with 03b6e078163f
- polarssl/mbedtls: fix name space pollution
Global private symbols MUST start with Curl_!
- [Dmitry S. Baikov brought this change]
mbedTLS: THREADING_SUPPORT compilation fix
Closes #505
- test1137: verify --ignore-content-length for FTP
- curl.1: --ignore-content-length now works for FTP too
- [Kurt Fankhauser brought this change]
ftp: allow CURLOPT_IGNORE_CONTENT_LENGTH to ignore size
This allows FTP transfers with growing (or shrinking) files without
causing a transfer error.
Closes #480
- CURLOPT_STREAM_WEIGHT.3: call argument 'weight' too
... and add a little example of what the weight actually means. "Relative
proportion of bandwidth".
- http2: add stream options to dist and curl_easy_setopt.3
- http2: s/priority/weight
- http2: on_frame_recv: trust the conn/data input
Removed wrong assert()s
The 'conn' passed in as userdata can be used and there can be other
sessionhandles ('data') than the single one this checked for.
- http2: added three stream prio/deps options
CURLOPT_STREAM_DEPENDS
CURLOPT_STREAM_DEPENDS_E
CURLOPT_STREAM_PRIORITY
- RELEASE-NOTES: synced with ace68fdc0cfed83d
- [m-gardet brought this change]
mbedtls:new profile with RSA min key len = 1024.
Closes #502
- checksrc: add crude // detection
Jay Satiro (21 Oct 2015)
- [Gisle Vanem brought this change]
build: fix for MSDOS/djgpp
- Add a VPATH-statement for the vtls/*.c files.
- Due to 'vtls/*.c', remove that subdir part from $(OBJECTS).
Daniel Stenberg (20 Oct 2015)
- copyrights: update Gisle Vanem's email
- vtls: fix compiler warning for TLS backends without sha256
... noticed with mbedTLS.
- [Jonas Minnberg brought this change]
vtls: added support for mbedTLS
closes #496
Jay Satiro (19 Oct 2015)
- [Javier G. Sogo brought this change]
cmake: Fix for add_subdirectory(curl) use-case
- Use CURL_BINARY_DIR instead of CMAKE_BINARY_DIR.
When including CURL using add_subdirectory the variables
CMAKE_BINARY_DIR and CURL_BINARY_DIR hold different paths.
Closes https://github.com/bagder/curl/pull/488
Closes https://github.com/bagder/curl/pull/498
Daniel Stenberg (18 Oct 2015)
- RELEASE-NOTES: synced with 4c773bcb474e
- tests/FILEFORMAT: mention PSL as a valid feture to check for
For example in test 1136
- teste1136: only run when PSL is enabled
- curl: slist_wc: remove curl_memory.h inclusion
... that's for the library only.
- configure: add PSL to the list of features
... to make test 1014 work again after e77b5b7453.
- [Daniel Hwang brought this change]
tool: Generate easysrc with last cache linked-list
Using a last cache linked-list improves the performance of easysrc
generation.
Bug: https://github.com/bagder/curl/issues/444
Ref: https://github.com/bagder/curl/issues/429
Closes #452
- [Tim Rühsen brought this change]
cookies: Add support for Mozilla's Publix Suffix List
Use libpsl to check the domain value of Set-Cookie headers (and cookie
jar entries) for not being a Publix Suffix.
The configure script checks for "libpsl" by default. Disable the check
with --without-libpsl.
Ref: https://publicsuffix.org/
Ref: https://github.com/publicsuffix/list
Ref: https://github.com/rockdaboot/libpsl
- [Richard Hosking brought this change]
curlbuild.h: Fix non-configure compiling to mips and sh4 targets
- [Anders Bakken brought this change]
http2: Don't pass unitialized name+len pairs to nghttp2_submit_request
bug introduced by 18691642931e5c7ac8af83ac3a84fbcb36000f96.
Closes #493
Dan Fandrich (16 Oct 2015)
- test1601: fix compilation with --enable-debug and --disable-crypto-auth
Daniel Stenberg (16 Oct 2015)
- multi: fix off-by-one finit[] array size
introduced in c6aedf680f6. It needs to be CURLM_STATE_LAST big since it
must hande the range 0 .. CURLM_STATE_MSGSENT (18) and CURLM_STATE_LAST
is 19 right now.
Reported-by: Dan Fandrich
Bug: http://curl.haxx.se/mail/lib-2015-10/0069.html
- fread_func: move callback pointer from set to state struct
... and assign it from the set.fread_func_set pointer in the
Curl_init_CONNECT function. This A) avoids that we have code that
assigns fields in the 'set' struct (which we always knew was bad) and
more importantly B) it makes it impossibly to accidentally leave the
wrong value for when the handle is re-used etc.
Introducing a state-init functionality in multi.c, so that we can set a
specific function to get called when we enter a state. The
Curl_init_CONNECT is thus called when switching to the CONNECT state.
Bug: https://github.com/bagder/curl/issues/346
Closes #346
Dan Fandrich (14 Oct 2015)
- test1531: case the size to fix the test on non-largefile builds
Daniel Stenberg (13 Oct 2015)
- acinclude: remove PKGCONFIG override
... and allow it to get set by a caller easier.
Reported-by: Rainer Jung
Bug: http://curl.haxx.se/mail/lib-2015-10/0035.html
Dan Fandrich (12 Oct 2015)
- docs/INSTALL: Updated example minimal binary sizes
Daniel Stenberg (11 Oct 2015)
- [Erik Johansson brought this change]
openssl: Fix set up of pkcs12 certificate verification chain
sk_X509_pop will decrease the size of the stack which means that the loop would
end after having added only half of the certificates.
Also make sure that the X509 certificate is freed in case
SSL_CTX_add_extra_chain_cert fails.
- ntlm: error out without 64bit support as the code needs it
It makes it a clearer message for developers reaching that point without
the necessary support.
Thanks-by: Jay Satiro
Closes #78
- curl_global_init: set the memory function pointers correct
follow-up from 6f8ecea0
- curl_global_init_mem: set function pointers before doing init
... as in the polarssl TLS backend for example it uses memory functions.
Jay Satiro (9 Oct 2015)
- http2: Fix http2_recv to return -1 if recv returned -1
If the underlying recv called by http2_recv returns -1 then that is the
value http2_recv returns to the caller.
Daniel Stenberg (8 Oct 2015)
- [Svyatoslav Mishyn brought this change]
curl_easy_recv.3: CURLINFO_LASTSOCKET => CURLINFO_ACTIVESOCKET
Closes #479
- [Svyatoslav Mishyn brought this change]
curl_easy_send.3: CURLINFO_LASTSOCKET => CURLINFO_ACTIVESOCKET
- [Svyatoslav Mishyn brought this change]
CURLOPT_CONNECT_ONLY.3: CURLINFO_LASTSOCKET => CURLINFO_ACTIVESOCKET
- CURLOPT_CERTINFO.3: fix reference to CURLINFO_CERTINFO
- ntlm: get rid of unconditional use of long long
... since some compilers don't have it and instead use other types, such
as __int64.
Reported by: gkinseyhpw
Closes #478
Jay Satiro (8 Oct 2015)
- [Anders Bakken brought this change]
des: Fix header conditional for Curl_des_set_odd_parity
Follow up to 613e502.
Daniel Stenberg (7 Oct 2015)
- configure: build silently by default
'make V=1' will make the build verbose like before
- bump: start climbing toward 7.46.0
- RELEASE-PROCEDURE: add the github HTTPS download step
Version 7.45.0 (7 Oct 2015)
Daniel Stenberg (7 Oct 2015)
- THANKS: 19 new contributors from the 7.45.0 announcement
- RELEASE-NOTES: synced with 69ea57970080
Jay Satiro (4 Oct 2015)
- getinfo: Fix return code for unknown CURLINFO options
- If a CURLINFO option is unknown return CURLE_UNKNOWN_OPTION.
Prior to this change CURLE_BAD_FUNCTION_ARGUMENT was returned on
unknown. That return value is contradicted by the CURLINFO option
documentation which specifies a return of CURLE_UNKNOWN_OPTION on
unknown.
- [rouzier brought this change]
hiperfifo: fix the pointer passed to WRITEDATA
Closes https://github.com/bagder/curl/pull/471
- [Maksim Stsepanenka brought this change]
tool_setopt: fix c_escape truncated octal
Closes https://github.com/bagder/curl/pull/469
Daniel Stenberg (1 Oct 2015)
- [Orange Tsai brought this change]
gopher: don't send NUL byte
Closes #466
Jay Satiro (29 Sep 2015)
- runtests: Fix pid check in checkdied
Because the 'not' operator has a very low precedence and as a result the
entire statement was erroneously negated and could never be true.
Daniel Stenberg (30 Sep 2015)
- [Thorsten Schöning brought this change]
win32: make recent Borland compilers use long long
- RELEASE-NOTES: synced with 69b89050d4
Jay Satiro (28 Sep 2015)
- [Michael Kalinin brought this change]
openssl: Fix algorithm init
- Change algorithm init to happen after OpenSSL config load.
Additional algorithms may be available due to the user's config so we
initialize the algorithms after the user's config is loaded.
Bug: https://github.com/bagder/curl/issues/447
Reported-by: Denis Feklushkin
- [Svyatoslav Mishyn brought this change]
docs: fix unescaped '\n' in man pages
Closes https://github.com/bagder/curl/pull/459
Daniel Stenberg (27 Sep 2015)
- http2: set TCP_NODELAY unconditionally
For a single-stream download from localhost, we managed to increase
transfer speed from 1.6MB/sec to around 400MB/sec, mostly because of
this single fix.
- http2: avoid superfluous Curl_expire() calls
... only call it when there is data arriving for another handle than the
one that is currently driving it.
Improves single-stream download performance quite a lot.
Thanks-to: Tatsuhiro Tsujikawa
Bug: http://curl.haxx.se/mail/lib-2015-09/0097.html
- readwrite_data: set a max number of loops
... as otherwise a really fast pipe can "lock" one transfer for some
protocols, like with HTTP/2.
- [Sergei Nikulov brought this change]
CI: Added AppVeyor-CI for curl
Closes #439
- FTP: fix uploading ASCII with unknown size
... don't try to increase the supposed file size on newlines if we don't
know what file size it is!
Patch-by: lzsiga
- [Tatsuhiro Tsujikawa brought this change]
build: fix failures with -Wcast-align and -Werror
Closes #457
- [Tatsuhiro Tsujikawa brought this change]
curl-confopts.m4: Add missing ')'
... for CURL_CHECK_OPTION_RT
Closes #456
Jay Satiro (25 Sep 2015)
- curl_easy_getinfo.3: Add brief description for each CURLINFO
Daniel Stenberg (23 Sep 2015)
- [Jakub Zakrzewski brought this change]
CMake: Ensure discovered include dirs are considered
...during header checks. Otherwise some following header tests
(incorrectly) fail.
Closes #436
- [Jakub Zakrzewski brought this change]
CMake: Put "winsock2.h" before "windows.h" during configure checks
"windows.h" includes "winsock.h" what causes many redefinition errors
if "winsock2.h" is included afterwards and can cause build to fail.
- tests: disable 1510 due to CI-problems on github
- [Mike Crowe brought this change]
gnutls: Report actual GnuTLS error message for certificate errors
If GnuTLS fails to read the certificate then include whatever reason it
provides in the failure message reported to the client.
Signed-off-by: Mike Crowe <mac@mcrowe.com>
- RELEASE-NOTES: synced with 6b56901b56e
- [Mike Crowe brought this change]
gnutls: Support CURLOPT_KEYPASSWD
The gnutls vtls back-end was previously ignoring any password set via
CURLOPT_KEYPASSWD. Presumably this was because
gnutls_certificate_set_x509_key_file did not support encrypted keys.
gnutls now has a gnutls_certificate_set_x509_key_file2 function that
does support encrypted keys. Let's determine at compile time whether the
available gnutls supports this new function. If it does then use it to
pass the password. If it does not then emit a helpful diagnostic if a
password is set. This is preferable to the previous behaviour of just
failing to read the certificate without giving a reason in that case.
Signed-off-by: Mike Crowe <mac@mcrowe.com>
- CURLINFO_TLS_SESSION: always return backend info
... even for those that don't support providing anything in the
'internals' struct member since it offers a convenient way for
applications to figure this out.
- [Daniel Hwang brought this change]
tool: remove redundant libcurl check
The easysrc generation is run only when --libcurl is initialized.
Ref: https://github.com/bagder/curl/issues/429
Closes #448
- [Richard van den Berg brought this change]
CURLOPT_PROXY.3: A proxy given as env variable gets no special treatment
Closes #449
- TODO: 5.7 More compressions
Like for example brotli, as being implemented in Firefox now.
Jay Satiro (21 Sep 2015)
- tool_operate: Don't call easysrc cleanup unless --libcurl
- Review of 4d95491.
The author changed it so easysrc only initializes when --libcurl but did
not do the same for the call to easysrc cleanup.
Ref: https://github.com/bagder/curl/issues/429
Daniel Stenberg (20 Sep 2015)
- [Viktor Szakats brought this change]
CURLOPT_PINNEDPUBLICKEY.3: replace test.com with example.com
closes #443
- KNOWN_BUGS: 91 "curl_easy_perform hangs with imap and PolarSSL"
Closes #334
- KNOWN_BUGS: add link to #85
- tests: disable 1801 until fixed
It is unreliable and causes CI problems on github
Closes #380
- RELEASE-NOTES: synced with 4d95491636ee
- [Daniel Lee Hwang brought this change]
tool: generate easysrc only on --libcurl
Code should only be generated when --libcurl is used.
Bug: https://github.com/bagder/curl/issues/429
Reported-by: @greafhe, Jay Satiro
Closes #429
Closes #442
Jay Satiro (19 Sep 2015)
- vtls: Change designator name for server's pubkey hash
- Change the designator name we use to show the base64 encoded sha256
hash of the server's public key from 'pinnedpubkey' to
'public key hash'.
Though the server's public key hash is only shown when comparing pinned
public key hashes, the server's hash may not match one of the pinned.
Daniel Stenberg (19 Sep 2015)
- [Isaac Boukris brought this change]
NTLM: Reset auth-done when using a fresh connection
With NTLM a new connection will always require authentication.
Fixes #435
- [Daniel Hwang brought this change]
ssl: add server cert's "sha256//" hash to verbose
Add a "pinnedpubkey" section to the "Server Certificate" verbose
Bug: https://github.com/bagder/curl/issues/410
Reported-by: W. Mark Kubacki
Closes #430
Closes #410
- [Jakub Zakrzewski brought this change]
openldap: only part of LDAP query results received
Introduced with commit 65d141e6da5c6003a1592bbc87ee550b0ad75c2f
Closes #440
- [Alessandro Ghedini brought this change]
openssl: don't output certinfo data
- [Alessandro Ghedini brought this change]
openssl: refactor certificate parsing to use OpenSSL memory BIO
Fixes #427
Kamil Dudka (18 Sep 2015)
- nss: prevent NSS from incorrectly re-using a session
Without this workaround, NSS re-uses a session cache entry despite the
server name does not match. This causes SNI host name to differ from
the actual host name. Consequently, certain servers (e.g. github.com)
respond by 400 to such requests.
Bug: https://bugzilla.mozilla.org/1202264
- nss: check return values of NSS functions
Daniel Stenberg (17 Sep 2015)
- CURLOPT_PINNEDPUBLICKEY.3: mention error code
- openssl: build with < 0.9.8
... without sha256 support and no define saying so.
Reported-by: Rajkumar Mandal
- libcurl-errors.3: add two missing error codes
CURLE_SSL_PINNEDPUBKEYNOTMATCH and CURLE_SSL_INVALIDCERTSTATUS
Jay Satiro (14 Sep 2015)
- CURLOPT_PINNEDPUBLICKEY.3: Improve pubkey extraction example
- Show how a certificate can be obtained using OpenSSL.
Bug: https://github.com/bagder/curl/pull/430
Reported-by: Daniel Hwang
Daniel Stenberg (13 Sep 2015)
- http2: removed unused function
- CURLINFO_ACTIVESOCKET.3: mention it replaces *LASTSOCKET
- opts: add CURLINFO_* man pages to dist
- opts: 19 more CURLINFO_* options made into stand-alone man pages
- RELEASE-NOTES: synced with fad9604613
- curl: customrequest_helper: deal with NULL custom method
- [Svyatoslav Mishyn brought this change]
CURLOPT_FNMATCH_FUNCTION.3: fix typo
s => is
Closes #428
- curl: point out unnecessary uses of -X in verbose mode
It uses 'Note:' as a prefix as opposed to the common 'Warning:' to take
down the tone a bit.
It adds a warning for using -XHEAD on other methods becasue that may
lead to a hanging connection.
Jay Satiro (10 Sep 2015)
- curl_sspi: fix possibly undefined CRYPT_E_REVOKED
Bug: https://github.com/bagder/curl/pull/411
Reported-by: Viktor Szakats
- buildconf.bat: fix syntax error
- [Benjamin Kircher brought this change]
winbuild: run buildconf.bat if necessary
- [Svyatoslav Mishyn brought this change]
docs: fix argument type for CURLINFO_SPEED_*, CURLINFO_SIZE_*
long => double
Daniel Stenberg (8 Sep 2015)
- [Sergei Nikulov brought this change]
cmake: IPv6 : disable Unix header check on Windows platform
Closes #409
- parse_proxy: reject illegal port numbers
If the port number in the proxy string ended weirdly or the number is
too large, skip it. Mostly as a means to bail out early if a "bare" IPv6
numerical address is used without enclosing brackets.
Also mention the bracket requirement for IPv6 numerical addresses to the
man page for CURLOPT_PROXY.
Closes #415
Reported-by: Marcel Raad
- FTP: do_more: add check for wait_data_conn in upload case
In some timing-dependnt cases when a 4xx response immediately followed
after a 150 when a STOR was issued, this function would wrongly return
'complete == true' while 'wait_data_conn' was still set.
Closes #405
Reported-by: Patricia Muscalu
- [Svyatoslav Mishyn brought this change]
CURLOPT_TLSAUTH_TYPE.3: update description
Closes #414
Closes #413
- [Svyatoslav Mishyn brought this change]
CURLOPT_PATH_AS_IS.3: fix typo
leavit => leaveit
closes #412
- [Svyatoslav Mishyn brought this change]
CURLINFO_SSL_VERIFYRESULT.3: add short description
- [Svyatoslav Mishyn brought this change]
CURLINFO_SSL_ENGINES.3: add short description
- [Svyatoslav Mishyn brought this change]
CURLINFO_CONTENT_LENGTH_UPLOAD.3: replace "receive" with "get" for consistency
- [Svyatoslav Mishyn brought this change]
CURLINFO_REDIRECT_TIME.3: remove redundant '!'
Kamil Dudka (4 Sep 2015)
- Revert "has: generate the curl/has.h header"
This reverts commit a60bde79f9adeb135d5c642a07f0d783fbfbbc25 I have
pushed by mistake. Apologies for my incompetent use of the git repo!
- nss: do not directly access SSL_ImplementedCiphers[]
It causes dynamic linking issues at run-time after an update of NSS.
Bug: https://lists.fedoraproject.org/pipermail/devel/2015-September/214117.html
- [Daniel Stenberg brought this change]
has: generate the curl/has.h header
changed macro name, moved and renamed script to become docs/libcurl/has.pl,
generate code that is checksrc compliant
Daniel Stenberg (3 Sep 2015)
- gitignore: ignore more generated VC Makefiles
- projects/Windows/.gitignore: ignore generated files for release
- http2: don't pass on Connection: headers
RFC 7540 section 8.1.2.2 states: "An endpoint MUST NOT generate an
HTTP/2 message containing connection-specific header fields; any message
containing connection-specific header fields MUST be treated as
malformed"
Closes #401
- curl.1: update RFC references
- CURLOPT_POSTREDIR.3: update RFC number and section
- CURLOPT_FOLLOWLOCATION.3: mention methods for redirects
and some general cleaning up
- [Marcel Raad brought this change]
inet_pton.c: Fix MSVC run-time check failure (2)
This fixes another run-time check failure because of a narrowing cast on
Visual C++.
Closes #408
Jay Satiro (3 Sep 2015)
- docs: Warn about any-domain cookies and multiple transfers
- Warn that cookies without a domain are sent to any domain:
CURLOPT_COOKIELIST, CURLOPT_COOKIEFILE, --cookie
- Note that imported Set-Cookie cookies without a domain are no longer
exported:
CURLINFO_COOKIELIST, CURLOPT_COOKIEJAR, --cookie-jar
Steve Holme (2 Sep 2015)
- tool_sdecls.h: Fixed compilation warning from commit 4a889441d3
tool_sdecls.h:139 warning: comma at end of enumerator list
Daniel Stenberg (2 Sep 2015)
- opts: 8 more CURLINFO* options as stand-alone man pages
- RELEASE-NOTES: synced with c764cb4add1a8
- man-pages: more SEE ALSO links
- opts: more CURLINFO_* options as stand-alone man pages
Steve Holme (31 Aug 2015)
- sasl: Only define Curl_sasl_digest_get_pair() when CRYPTO_AUTH enabled
Introduced in commit 59f3f92ba6 this function is only implemented when
CURL_DISABLE_CRYPTO_AUTH is not defined. As such we shouldn't define
the function in the header file either.
- sasl: Updated SPN variables and comments for consistency
In places the "host name" and "realm" variable was referred to as
"instance" whilst in others it was referred to as "host".
Daniel Stenberg (30 Aug 2015)
- configure: check for HMAC_Update in openssl
Turns out HMAC_Init is now deprecated in openssl master (and I spelled
HMAC_Init_ex wrong in previous commit)
Steve Holme (30 Aug 2015)
- win32: Use DES_set_odd_parity() from OpenSSL/BoringSSL by default
Set HAVE_DES_SET_ODD_PARITY when using OpenSSL/BoringSSL as native
Windows builds don't use the autoconf tools.
- des: Fixed compilation warning from commit 613e5022fe
curl_ntlm_core.c:150: warning 'Curl_des_set_odd_parity' undefined;
assuming extern returning int
- buildconf.bat: Fixed double blank line in 'curl manual' warning output
- makefiles: Added our standard copyright header
But kept the original author, when they were specified in a comment, as
the initial copyright holder.
Jay Satiro (29 Aug 2015)
- CURLOPT_FILETIME.3: CURLINFO_FILETIME has its own manpage now
Daniel Stenberg (29 Aug 2015)
- CURLINFO_RESPONSE_CODE.3: added short description
- opts: 7 initial CURLINFO_* options as stand-alone man pages
- [Nikolai Kondrashov brought this change]
libcurl.m4: Put braces around empty if body
Put braces around empty "if" body in libcurl.m4 check to avoid warning:
suggest braces around empty body in an 'if' statement
and make it work with -Werror builds.
Closes #402
- [Svyatoslav Mishyn brought this change]
curl_easy_escape.3: escape '\n'
Closes #398
- [Svyatoslav Mishyn brought this change]
curl_easy_{escape,setopt}.3: fix example
remove redundant '}'
- [Sergei Nikulov brought this change]
cmake: added Windows SSL support
Closes #399
- curl: point out the conflicting HTTP methods if used
It isn't always clear to the user which options that cause the HTTP
methods to conflict so by spelling them out it should hopefully be
easier to understand why curl complains.
- curl: clarify that users can only specify one _METHOD_
- [Svyatoslav Mishyn brought this change]
curl_easy_{escape,unescape}.3: "char *" vs. "const char *"
Closes #395
Patrick Monnerat (24 Aug 2015)
- os400: include new options in wrappers and update ILE/RPG binding.
Daniel Stenberg (24 Aug 2015)
- KNOWN_BUGS: #2, not reading a HEAD response-body is not a bug
... since HTTP is forbidden to return any such.
- KNOWN_BUGS: #78 zero-length files is already fixed!
- [Razvan Cojocaru brought this change]
getinfo: added CURLINFO_ACTIVESOCKET
This patch addresses known bug #76, where on 64-bit Windows SOCKET is 64
bits wide, but long is only 32, making CURLINFO_LASTSOCKET unreliable.
Signed-off-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
- http2: remove dead code
Leftovers from when we removed the private socket hash.
Coverity CID 1317365, "Logically dead code"
- ntlm: mark deliberate switch case fall-through
Coverity CID 1317367, "Missing break in switch"
- http2: on_frame_recv: get a proper 'conn' for the debug logging
"Explicit null dereferenced (FORWARD_NULL)"
Coverity CID 1317366
- RELEASE-NOTES: synced with 2acaf3c804
Dan Fandrich (23 Aug 2015)
- tool: fix memory leak with --proto-default option
Jay Satiro (22 Aug 2015)
- [Nathaniel Waisbrot brought this change]
CURLOPT_DEFAULT_PROTOCOL: added
- Add new option CURLOPT_DEFAULT_PROTOCOL to allow specifying a default
protocol for schemeless URLs.
- Add new tool option --proto-default to expose
CURLOPT_DEFAULT_PROTOCOL.
In the case of schemeless URLs libcurl will behave in this way:
When the option is used libcurl will use the supplied default.
When the option is not used, libcurl will follow its usual plan of
guessing from the hostname and falling back to 'http'.
- runtests: Allow for spaces in server-verify curl custom path
Daniel Stenberg (22 Aug 2015)
- NTLM: recent boringssl brought DES_set_odd_parity back
... so improve the #ifdefs for using our local implementation.
- configure: detect latest boringssl
Since boringssl brought back DES_set_odd_parity again, it cannot be used
to differentiate from boringssl. Using the OPENSSL_IS_BORINGSSL define
seems better anyway.
URL: https://android.googlesource.com/platform/external/curl/+/f551028d5caab29d4b4a4ae8c159c76c3cfd4887%5E!/
Original-patch-by: Bertrand Simonnet
Closes #393
- configure: change functions to detect openssl (clones)
... since boringssl moved the former ones and the check started to fail.
URL: https://android.googlesource.com/platform/external/curl/+/f551028d5caab29d4b4a4ae8c159c76c3cfd4887%5E!/
Original-patch-by: Bertrand Simonnet
- [Alessandro Ghedini brought this change]
openssl: handle lack of server cert when strict checking disabled
If strict certificate checking is disabled (CURLOPT_SSL_VERIFYPEER
and CURLOPT_SSL_VERIFYHOST are disabled) do not fail if the server
doesn't present a certificate at all.
Closes #392
- ftp: clear the do_more bit when the server has connected
The multi state machine would otherwise go into the DO_MORE state after
DO, even for the case when the FTP state machine had already performed
those duties, which caused libcurl to get stuck in that state and fail
miserably. This occured for for active ftp uploads.
Reported-by: Patricia Muscalu
- [Jactry Zeng brought this change]
travis.yml: Add OS X testbot.
- [Rémy Léone brought this change]
travis: Upgrading to container based build
http://docs.travis-ci.com/user/migrating-from-legacy
Closes #388
- RELEASE-NOTES: synced with 14ff86256b13e
- [Erik Janssen brought this change]
rtsp: stop reading empty DESCRIBE responses
Based-on-patch-by: Jim Hollinger
- [Erik Janssen brought this change]
rtsp: support basic/digest authentication
- [Sam Roth brought this change]
CURLMOPT_PUSHFUNCTION.3: fix argument types
Closes #389
Closes #386
- [Marcel Raad brought this change]
inet_pton.c: Fix MSVC run-time check failure
Visual Studio complains with a message box:
"Run-Time Check Failure #1 - A cast to a smaller data type has caused a
loss of data. If this was intentional, you should mask the source of
the cast with the appropriate bitmask.
For example:
char c = (i & 0xFF);
Changing the code in this way will not affect the quality of the
resulting optimized code."
This is because only 'val' is cast to unsigned char, so the "& 0xff" has
no effect.
Closes #387
Jay Satiro (18 Aug 2015)
- docs: Update the redirect protocols disabled by default
- Clarify that FILE and SCP are disabled by default since 7.19.4
- Add that SMB and SMBS are disabled by default since 7.40.0
- Add CURLPROTO_SMBS to the list of protocols
- gitignore: Sort for readability
find . -name .gitignore -print0 | xargs -i -0 sort -o '{}' '{}'
Daniel Stenberg (15 Aug 2015)
- curl_easy_getinfo.3: fix superfluous space
... and changed "oriented" to "related"
Closes #378
- CURLOPT_HTTP_VERSION.3: connection re-use goes before version
- [Daniel Kahn Gillmor brought this change]
curl.1: Document weaknesses in SSLv2 and SSLv3
Acknowledge that SSLv3 is also widely considered to be insecure.
Also, provide references for people who want to know more about why it's
insecure.
Steve Holme (14 Aug 2015)
- generate.bat: Added support for generating only the prerequisite files
- generate.bat: Only call buildconf.bat if it exists
- generate.bat: Fixed issues when ran in directories with special chars
Daniel Stenberg (14 Aug 2015)
- [Brad King brought this change]
cmake: Fix CurlTests check for gethostbyname_r with 5 arguments
Fix the check code to pass 5 arguments instead of 6. This typo was
introduced by commit aebfd4cfbf (cmake: fix gethostby{addr,name}_r in
CurlTests, 2014-10-31).
Steve Holme (14 Aug 2015)
- * buildconf.bat: Fixed issues when ran in directories with special chars
Bug: https://github.com/bagder/curl/pull/379
Reported-by: Daniel Seither
Jay Satiro (13 Aug 2015)
- curl_global_init_mem.3: Stronger thread safety warning
Bug: http://curl.haxx.se/mail/lib-2015-08/0016.html
Reported-by: Eric Ridge
Daniel Stenberg (12 Aug 2015)
- [Svyatoslav Mishyn brought this change]
curl_multi_add_handle.3: fix a typo
"can not" => "cannot"
closes #377
- [Alessandro Ghedini brought this change]
docs: fix typos
closes #376
- bump: start working toward 7.45.0
- THANKS: remove duplicate name
- THANKS-filter: merge Todd's names
- THANKS: 13 new contributors from the 7.44.0 RELEASE-NOTES
Version 7.44.0 (11 Aug 2015)
Daniel Stenberg (11 Aug 2015)
- RELEASE-NOTES: synced with c75a1e775061
- [Svyatoslav Mishyn brought this change]
curl_formget.3: correct return code
Closes #375
- [Svyatoslav Mishyn brought this change]
libcurl-tutorial.3: fix formatting
Closes #374
- [Svyatoslav Mishyn brought this change]
curl_easy_recv.3: fix formatting
- [Anders Bakken brought this change]
http2: discard frames with no SessionHandle
Return 0 instead of NGHTTP2_ERR_CALLBACK_FAILURE if we can't locate the
SessionHandle. Apparently mod_h2 will sometimes send a frame for a
stream_id we're finished with.
Use nghttp2_session_get_stream_user_data and
nghttp2_session_set_stream_user_data to identify SessionHandles instead
of a hash.
Closes #372
- RELEASE-NOTES: synced with 9ee40ce2aba
- [Viktor Szakats brought this change]
build: refer to fixed libidn versions
closes #371
- Revert "configure: disable libidn by default"
This reverts commit e6749055d65398315fd77f5b5b8234c5552ac2d3.
... since libidn has since been fixed.
- [Jakub Zakrzewski brought this change]
CMake: s/HAVE_GSS_API/HAVE_GSSAPI/ to match header define
Otherwise the build only pretended to use GSS-API
Closes #370
- SFTP: fix range request off-by-one in size check
Reported-by: Tim Stack
Closes #359
- test46: update cookie expire time
... since it went old and thus was expired and caused the test to fail!
Steve Holme (9 Aug 2015)
- generate.bat: Use buildconf.bat for prerequisite file generation
- buildconf.bat: Tidy up of comments after recent commits
- buildconf.bat: Added full generation of src\tool_hugehelp.c
Added support for generating the full man page based on code from
generate.bat.
- buildconf.bat: Added detection of groff, nroff, perl and gzip
To allow for the full generation of tool_hugehelp.c added detection of
the required programs - based on code from generate.bat.
- buildconf.bat: Move DOS variable clean-up code to separate function
Rather than duplicate future variables, during clean-up of both success
and error conditions, use a common function that can be called by both.