2016-02-03 Jeff Miller Update WebKit2.framework copyright string to include 2016. This framework no longer exists on trunk, so we missed this as part of the merge of r194479. * mac/Info-WebKit2.plist: 2016-01-29 Babak Shafiei Merge r194479. 2016-01-01 Jeff Miller Update user-visible copyright strings to include 2016 https://bugs.webkit.org/show_bug.cgi?id=152531 Reviewed by Alexey Proskuryakov. * DatabaseProcess/EntryPoint/mac/LegacyProcess/Info.plist: * DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Development/Info.plist: * DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist: * Info.plist: * NetworkProcess/EntryPoint/mac/LegacyProcess/Info.plist: * NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-OSX.plist: * NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-iOS.plist: * NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX-10.9-10.10.plist: * NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist: * NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist: * PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist: * PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64-10.9-10.10.Info.plist: * PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist: * PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist: * WebProcess/EntryPoint/mac/LegacyProcess/Info.plist: * WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-OSX.plist: * WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-iOS.plist: * WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX-10.9-10.10.plist: * WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist: * WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist: 2016-01-27 Matthew Hanson Merge r194559. rdar://problem/24269083 2016-01-04 Tim Horton Turn on gesture events when building for Yosemite https://bugs.webkit.org/show_bug.cgi?id=152704 rdar://problem/24042472 Reviewed by Anders Carlsson. * Configurations/FeatureDefines.xcconfig: 2016-01-20 Matthew Hanson Roll out r189135 via r195066. rdar://problem/24154288 2016-01-20 Matthew Hanson Roll out r192200 via r195067. rdar://problem/24154288 2016-01-20 Matthew Hanson Merge r195067. rdar://problem/24154288 2016-01-14 Matthew Hanson Merge r189135. rdar://problem/24154288 2015-08-28 Eric Carlson [Mac] Restructure WebMediaSessionManager for testing https://bugs.webkit.org/show_bug.cgi?id=148593 Reviewed by Jer Noble. * UIProcess/mac/PageClientImpl.mm: (WebKit::PageClientImpl::mediaSessionManager): Call WebMediaSessionManager::singleton, not WebMediaSessionManagerMac::singleton. 2015-12-18 Matthew Hanson Merge r188606. rdar://problem/23905024 2015-08-18 Anders Carlsson Fix build, and fix the version check. * UIProcess/API/C/WKPage.cpp: (WKPageSetPageUIClient): 2015-12-18 Matthew Hanson Merge r188602. rdar://problem/23905024 2015-08-18 Anders Carlsson REGRESSION: Playing audio causes near-instant crash https://bugs.webkit.org/show_bug.cgi?id=148059 rdar://problem/22282680 Reviewed by Sam Weinig. The version of WebKit that Safari 6.2.8, 7.1.8 and 8.0.8 built against had an ABI incompatible WKPageUIClientV4 struct. Thankfully we're not going to ship any versions of Safari that use the "normal" WKPageUIClientV4 struct so just assume that it's always the broken one and fix it up by converting it to a WKPageUIClientV5 struct and setting that as the page UI client. * UIProcess/API/C/WKPage.cpp: (fixUpBotchedPageUIClient): (WKPageSetPageUIClient): 2015-12-17 Babak Shafiei Merge r191343. 2015-10-20 Tim Horton Try to fix the build by disabling MAC_GESTURE_EVENTS on 10.9 and 10.10 * Configurations/FeatureDefines.xcconfig: 2015-12-17 Babak Shafiei Merge r191305. 2015-10-19 Tim Horton Try to fix the iOS build * Configurations/FeatureDefines.xcconfig: 2015-12-16 Babak Shafiei Merge r194205. 2015-12-16 Tim Horton REGRESSION (r191299): Zoom gestures are enabled even if allowsMagnification=NO https://bugs.webkit.org/show_bug.cgi?id=152373 Reviewed by Simon Fraser. * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::gestureEventWasNotHandledByWebCoreFromViewOnly): Don't pass the event on to ViewGestureController if we shouldn't handle it, just like we would have done in magnifyWithEvent before. 2015-12-16 Babak Shafiei Merge r194186. 2015-12-16 Tim Horton REGRESSION (r194125): Crashes in touchesEndedWithEvent on occasion when interacting with the page https://bugs.webkit.org/show_bug.cgi?id=152366 Reviewed by Beth Dakin. * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::touchesEndedWithEvent): (WebKit::WebViewImpl::touchesCancelledWithEvent): NSTouch identifiers aren't pointer-comparable. We need to use isEqual to compare them and find the ones to remove. 2015-12-16 Babak Shafiei Merge r194125. 2015-12-15 Tim Horton [Mac] Gesture Events should not have negative scale https://bugs.webkit.org/show_bug.cgi?id=151065 Reviewed by Anders Carlsson. * Shared/NativeWebGestureEvent.h: * Shared/mac/NativeWebGestureEventMac.mm: (WebKit::distanceForTouches): (WebKit::NativeWebGestureEvent::NativeWebGestureEvent): Compute the distance between the two oldest touches, and use that as the scale (really the gesture diameter) on the event, instead of passing through AppKit's magnification (which is computed differently). This matches the documented behavior of the existing gesture events on iOS. * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView touchesBeganWithEvent:]): (-[WKWebView touchesMovedWithEvent:]): (-[WKWebView touchesEndedWithEvent:]): (-[WKWebView touchesCancelledWithEvent:]): * UIProcess/API/mac/WKView.mm: (-[WKView touchesBeganWithEvent:]): (-[WKView touchesMovedWithEvent:]): (-[WKView touchesEndedWithEvent:]): (-[WKView touchesCancelledWithEvent:]): Plumb touch events through to WebViewImpl. * UIProcess/Cocoa/WebViewImpl.h: * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::magnifyWithEvent): (WebKit::WebViewImpl::touchesOrderedByAge): (WebKit::WebViewImpl::touchesBeganWithEvent): (WebKit::WebViewImpl::touchesMovedWithEvent): (WebKit::WebViewImpl::touchesEndedWithEvent): (WebKit::WebViewImpl::touchesCancelledWithEvent): (WebKit::WebViewImpl::rotateWithEvent): Keep track of the most recent incoming touches, by identifier, in age order. Pass them through to NativeWebGestureEvent so it can determine the gesture diameter. 2015-12-16 Babak Shafiei Merge r191299. 2015-10-19 Tim Horton Add magnify and rotate gesture event support for Mac https://bugs.webkit.org/show_bug.cgi?id=150179 Reviewed by Darin Adler. * Configurations/FeatureDefines.xcconfig: New feature flag. * Shared/NativeWebGestureEvent.h: Added. (WebKit::NativeWebGestureEvent::nativeEvent): * Shared/WebEvent.h: * Shared/WebEventConversion.cpp: (WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent): (WebKit::platform): * Shared/WebEventConversion.h: * Shared/mac/NativeWebGestureEventMac.mm: Added. (WebKit::webEventTypeForNSEvent): (WebKit::pointForEvent): (WebKit::NativeWebGestureEvent::NativeWebGestureEvent): Add and plumb a new native event that wraps a NSEvent of type NSEventTypeMagnify or NSEventTypeRotate (gesture events). * Shared/mac/WebGestureEvent.cpp: Added. (WebKit::WebGestureEvent::encode): (WebKit::WebGestureEvent::decode): (WebKit::WebGestureEvent::isGestureEventType): * Shared/mac/WebGestureEvent.h: Added. (WebKit::WebGestureEvent::WebGestureEvent): (WebKit::WebGestureEvent::position): (WebKit::WebGestureEvent::gestureScale): (WebKit::WebGestureEvent::gestureRotation): Add IPC plumbing for WebGestureEvent, which becomes a WebCore::PlatformGestureEvent. * UIProcess/API/Cocoa/WKViewPrivate.h: Remove unnecessary iPhone-only WKView code. Add _gestureEventWasNotHandledByWebCore, SPI which can be overridden to react when WebCore decides not to handle a gesture event. * UIProcess/API/mac/WKView.mm: (-[WKView magnifyWithEvent:]): Route magnification gesture events to the page, unless we're already in an active view zoom gesture, in which case we'll bypass the page and send the event straight to ViewGestureController. (-[WKView rotateWithEvent:]): Route rotation gesture events to the page. (-[WKView _gestureEventWasNotHandledByWebCore:]): Let ViewGestureController know that WebCore didn't handle a gesture event. We always give WebCore the first crack at the event if we're not in a zoom, because it could preventDefault() on the Begin phase event, and that should prevent pinch-zoom from starting. * UIProcess/PageClient.h: * UIProcess/mac/PageClientImpl.h: * UIProcess/mac/PageClientImpl.mm: (WebKit::PageClientImpl::gestureEventWasNotHandledByWebCore): Plumb gestureEventWasNotHandledByWebCore back from WebPageProxy to WKView. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleGestureEvent): (WebKit::WebPageProxy::didReceiveEvent): * UIProcess/WebPageProxy.h: Forward gesture events to EventDispatcher, and let WKView know when WebCore passes on handling them. * UIProcess/mac/ViewGestureController.h: (WebKit::ViewGestureController::hasActiveMagnificationGesture): * UIProcess/mac/ViewGestureControllerMac.mm: (WebKit::ViewGestureController::gestureEventWasNotHandledByWebCore): (WebKit::ViewGestureController::handleMagnificationGestureEvent): Don't try to start a zoom with anything other than a Begin phase event. Try to start a zoom with any events that WebCore doesn't handle. Move dispatch of endMagnificationGesture into ViewGestureController; there is no reason for that to be in WKView anymore. * WebKit2.xcodeproj/project.pbxproj: * WebProcess/WebPage/EventDispatcher.cpp: (WebKit::EventDispatcher::gestureEvent): (WebKit::EventDispatcher::dispatchGestureEvent): * WebProcess/WebPage/EventDispatcher.h: * WebProcess/WebPage/EventDispatcher.messages.in: * WebProcess/WebPage/WebPage.cpp: (WebKit::handleGestureEvent): (WebKit::WebPage::gestureEvent): * WebProcess/WebPage/WebPage.h: Dispatch to the main thread and hand off the gesture event to WebCore, asynchronously informing the UI process of whether the event was handled or not. 2015-12-08 Harris Papadopoulos Merge r193380. rdar://problem/23816165 2015-12-03 Sam Weinig It should be possible to use version 6 of the WKPageUIClient without adopting the new createNewPage https://bugs.webkit.org/show_bug.cgi?id=151826 Reviewed by Anders Carlsson. * UIProcess/API/C/WKPage.cpp: (WKPageSetPageUIClient): Pick which variant of createNewPage to use based on which function pointer is available, not the version number. 2015-12-08 Harris Papadopoulos Merge r193367. rdar://problem/23816165 2015-12-03 Sam Weinig Need completionHandler-based WebKit C SPI for alert, confirm, and prompt https://bugs.webkit.org/show_bug.cgi?id=151708 (Add missing function definitions) * UIProcess/API/C/WKPage.cpp: (WKPageRunJavaScriptAlertResultListenerGetTypeID): (WKPageRunJavaScriptAlertResultListenerCall): (WKPageRunJavaScriptConfirmResultListenerGetTypeID): (WKPageRunJavaScriptConfirmResultListenerCall): (WKPageRunJavaScriptPromptResultListenerGetTypeID): (WKPageRunJavaScriptPromptResultListenerCall): 2015-12-08 Harris Papadopoulos Merge r192911. rdar://problem/23816165 2015-12-01 Sam Weinig Need completionHandler-based WebKit C SPI for alert, confirm, and prompt https://bugs.webkit.org/show_bug.cgi?id=151708 Reviewed by Anders Carlsson. Add listener based versions of alert, confirm and prompt. * Shared/API/APIObject.h: * Shared/API/c/WKBase.h: * UIProcess/API/C/WKPage.cpp: (WebKit::RunJavaScriptAlertResultListener::create): (WebKit::RunJavaScriptAlertResultListener::~RunJavaScriptAlertResultListener): (WebKit::RunJavaScriptAlertResultListener::call): (WebKit::RunJavaScriptAlertResultListener::RunJavaScriptAlertResultListener): (WebKit::RunJavaScriptConfirmResultListener::create): (WebKit::RunJavaScriptConfirmResultListener::~RunJavaScriptConfirmResultListener): (WebKit::RunJavaScriptConfirmResultListener::call): (WebKit::RunJavaScriptConfirmResultListener::RunJavaScriptConfirmResultListener): (WebKit::RunJavaScriptPromptResultListener::create): (WebKit::RunJavaScriptPromptResultListener::~RunJavaScriptPromptResultListener): (WebKit::RunJavaScriptPromptResultListener::call): (WebKit::RunJavaScriptPromptResultListener::RunJavaScriptPromptResultListener): (WKPageSetPageUIClient): * UIProcess/API/C/WKPageUIClient.h: 2015-12-08 Harris Papadopoulos Merge r188553. rdar://problem/23816165 2015-08-13 Anders Carlsson Add WKWindowFeaturesRef and a new modern createNewPage UI client callback https://bugs.webkit.org/show_bug.cgi?id=147989 Reviewed by Tim Horton. Re-land this and make sure we actually allocate a WKWindowFeatures object. * Platform/IPC/mac/ConnectionMac.mm: * Shared/API/APIObject.h: * Shared/API/c/WKBase.h: * UIProcess/API/APIWindowFeatures.cpp: Added. * UIProcess/API/APIWindowFeatures.h: Added. * UIProcess/API/C/WKAPICast.h: * UIProcess/API/C/WKPage.cpp: (WKPageSetPageUIClient): * UIProcess/API/C/WKPageUIClient.h: * UIProcess/API/C/WKWindowFeaturesRef.cpp: Added. (WKWindowFeaturesGetTypeID): * UIProcess/API/C/WKWindowFeaturesRef.h: Added. * UIProcess/API/Cocoa/WKWindowFeatures.mm: (-[WKWindowFeatures dealloc]): (-[WKWindowFeatures menuBarVisibility]): (-[WKWindowFeatures statusBarVisibility]): (-[WKWindowFeatures toolbarsVisibility]): (-[WKWindowFeatures allowsResizing]): (-[WKWindowFeatures x]): (-[WKWindowFeatures y]): (-[WKWindowFeatures width]): (-[WKWindowFeatures height]): (-[WKWindowFeatures _apiObject]): (-[WKWindowFeatures _initWithWindowFeatures:]): Deleted. * UIProcess/API/Cocoa/WKWindowFeaturesInternal.h: (WebKit::wrapper): * UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::UIClient::createNewPage): * WebKit2.xcodeproj/project.pbxproj: 2015-12-08 Harris Papadopoulos Merge r188386. rdar://problem/23816165 2015-08-12 Anders Carlsson Use WTF::Optional in WindowFeatures https://bugs.webkit.org/show_bug.cgi?id=147956 Reviewed by Sam Weinig. * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder::decode): Deleted. * UIProcess/API/C/WKPage.cpp: (WKPageSetPageUIClient): * UIProcess/API/Cocoa/WKWindowFeatures.mm: (-[WKWindowFeatures _initWithWindowFeatures:]): 2015-12-08 Harris Papadopoulos Merge r188228. rdar://problem/23816165 2015-08-08 Sam Weinig Replace WebPageConfiguration with API::PageConfiguration and expose a C-SPI accessor for it https://bugs.webkit.org/show_bug.cgi?id=147811 Reviewed by Darin Adler. - Adds the missing pieces from WebPageConfiguration into API::PageConfiguration. - Adds C-SPI to set and get the WebsiteDataStore on the WKPageConfigurationRef. - Uses API::PageConfiguration to pass configuration information from WKWebView/WKView to WebPageProxy. - Stores the API::PageConfiguration on the WebPageProxy and exposes a new C-SPI function, WKPageCopyPageConfiguration, to get a copy of it. * UIProcess/API/APIPageConfiguration.cpp: (API::PageConfiguration::create): (API::PageConfiguration::PageConfiguration): (API::PageConfiguration::~PageConfiguration): (API::PageConfiguration::copy): (API::PageConfiguration::processPool): (API::PageConfiguration::setRelatedPage): (API::PageConfiguration::visitedLinkProvider): (API::PageConfiguration::setVisitedLinkProvider): (API::PageConfiguration::websiteDataStore): (API::PageConfiguration::setWebsiteDataStore): (API::PageConfiguration::sessionID): (API::PageConfiguration::setSessionID): (API::PageConfiguration::webPageConfiguration): Deleted. * UIProcess/API/APIPageConfiguration.h: (API::PageConfiguration::preferenceValues): (API::PageConfiguration::treatsSHA1SignedCertificatesAsInsecure): (API::PageConfiguration::setTreatsSHA1SignedCertificatesAsInsecure): (API::PageConfiguration::alwaysRunsAtForegroundPriority): (API::PageConfiguration::setAlwaysRunsAtForegroundPriority): (API::PageConfiguration::create): Deleted. * UIProcess/API/C/WKPage.cpp: (WKPageGetPageGroup): (WKPageCopyPageConfiguration): (WKPageLoadURL): * UIProcess/API/C/WKPage.h: * UIProcess/API/C/WKPageConfigurationRef.cpp: (WKPageConfigurationSetRelatedPage): (WKPageConfigurationGetWebsiteDataStore): (WKPageConfigurationSetWebsiteDataStore): * UIProcess/API/C/WKPageConfigurationRef.h: * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView initWithFrame:configuration:]): * UIProcess/API/ios/WKViewIOS.mm: (-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]): * UIProcess/API/mac/WKView.mm: (-[WKView _setPrimaryTrackingArea:]): (-[WKView initWithFrame:processPool:configuration:webView:]): (-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]): (-[WKView initWithFrame:configurationRef:]): (-[WKView wantsUpdateLayer]): * UIProcess/API/mac/WKViewInternal.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::create): (WebKit::WebPageProxy::WebPageProxy): (WebKit::WebPageProxy::~WebPageProxy): (WebKit::WebPageProxy::configuration): (WebKit::WebPageProxy::processIdentifier): * UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::pageID): (WebKit::WebPageProxy::sessionID): * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::createNewWebProcessRespectingProcessCountLimit): (WebKit::WebProcessPool::createWebPage): (WebKit::WebProcessPool::download): * UIProcess/WebProcessPool.h: * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::webPage): (WebKit::WebProcessProxy::createWebPage): * UIProcess/WebProcessProxy.h: (WebKit::WebProcessProxy::processPool): * UIProcess/ios/WKContentView.h: * UIProcess/ios/WKContentView.mm: (-[WKContentView _commonInitializationWithProcessPool:configuration:]): (-[WKContentView initWithFrame:processPool:configuration:webView:]): (-[WKContentView initWithFrame:processPool:configuration:wkView:]): (-[WKContentView dealloc]): 2015-12-11 Matthew Hanson Merge r191628. rdar://problem/23715623 2015-10-27 Zhuo Li Add WebKit API to clear data type Search Field Recent Searches. https://bugs.webkit.org/show_bug.cgi?id=150019. Reviewed by Anders Carlsson. * Shared/WebsiteData/WebsiteDataTypes.h: Add data type Search Field Recent Searches. * UIProcess/API/Cocoa/WKWebsiteDataRecord.mm: (dataTypesToString): Ditto. * UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h: (WebKit::toWebsiteDataTypes): Ditto. (WebKit::toWKWebsiteDataTypes): Ditto. * UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h: Ditto. * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::removeData): Handle the case when data type is Search Field Recent Searches. * UIProcess/WebsiteData/WebsiteDataStore.h: Add a private function for removing recent searches based on time. * UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStoreCocoa::platformRemoveRecentSearches): Call the removing recent searches logic in WebCore. * UIProcess/efl/WebPageProxyEfl.cpp: (WebKit::WebsiteDataStore::platformRemoveRecentSearches): Not implemented. * UIProcess/gtk/WebPageProxyGtk.cpp: (WebKit::WebsiteDataStore::platformRemoveRecentSearches): Not implemented. 2015-12-11 Matthew Hanson Merge r191084. rdar://problem/23715623 2015-10-14 Zhuo Li Augment ’s recent search history with the time each entry was added, in order to allow time-based clearing of search history. https://bugs.webkit.org/show_bug.cgi?id=148388. Reviewed by Darin Adler. Replace Vector with Vector, where RecentSearch is a struct that consists search string and time, for recent searches in order to store additional time information. All these new RecentSearches are stored in a plist in which the structure looks like: Root { "items": { autosave name: { "searches": [ { "searchString": searchString, "date": date }, ... ] } } } * Scripts/webkit/messages.py: (headers_for_type): * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::encode): Encode the new struct RecentSearch (IPC::ArgumentCoder::decode): Decode the new struct RecentSearch * Shared/WebCoreArgumentCoders.h: * UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::saveRecentSearches): Call saveRecentSearches in WebCore::SearchPopupMenuCocoa. (WebKit::WebPageProxy::loadRecentSearches): Call loadRecentSearches in WebCore::SearchPopupMenuCocoa. * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * UIProcess/efl/WebPageProxyEfl.cpp: (WebKit::WebPageProxy::saveRecentSearches): (WebKit::WebPageProxy::loadRecentSearches): * UIProcess/gtk/WebPageProxyGtk.cpp: (WebKit::WebPageProxy::saveRecentSearches): (WebKit::WebPageProxy::loadRecentSearches): * WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp: (WebKit::WebSearchPopupMenu::saveRecentSearches): (WebKit::WebSearchPopupMenu::loadRecentSearches): * WebProcess/WebCoreSupport/WebSearchPopupMenu.h: 2015-12-09 Babak Shafiei Merge r190505. 2015-10-02 Antoine Quint popstate is fired at the wrong time on load https://bugs.webkit.org/show_bug.cgi?id=94265 Reviewed by Darin Adler. Ensure we have a valid page before trying to get to its drawingArea as this could lead to a crash as observed with fast/loader/stateobjects/pushstate-object-types.html. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::restoreViewState): 2015-10-18 Myles C. Maxfield Stop honoring the user default "WebKitKerningAndLigaturesEnabledByDefault" https://bugs.webkit.org/show_bug.cgi?id=150287 Reviewed by Simon Fraser. * Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::WebProcessCreationParameters): Deleted. (WebKit::WebProcessCreationParameters::encode): Deleted. (WebKit::WebProcessCreationParameters::decode): Deleted. * Shared/WebProcessCreationParameters.h: * UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::registerUserDefaultsIfNeeded): Deleted. (WebKit::WebProcessPool::platformInitializeWebProcess): Deleted. * WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess): Deleted. 2015-10-13 Myles C. Maxfield Split TypesettingFeatures into kerning and ligatures bools https://bugs.webkit.org/show_bug.cgi?id=150074 Reviewed by Simon Fraser. * Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::WebProcessCreationParameters): (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode): * Shared/WebProcessCreationParameters.h: * UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess): * WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess): 2015-12-05 Matthew Hanson Rollout r193474. rdar://problem/23732400 2015-12-05 Matthew Hanson Rollout r193475. rdar://problem/23732400 2015-12-05 Matthew Hanson Rollout r193476. rdar://problem/23732400 2015-12-05 Matthew Hanson Rollout r193478. rdar://problem/23732400 2015-12-04 Matthew Hanson Merge r191452. rdar://problem/23732400 2015-10-22 Wenson Hsieh Implement touch-action: manipulation; for iOS https://bugs.webkit.org/show_bug.cgi?id=149854 Reviewed by Benjamin Poulain. Implements the manipulation value for the CSS property touch-action. Performs hit-testing upon receiving a potential tap to determine whether to disable double-tap gesture recognition over the duration of the tap. If so, sends a message from the web process to the UI process indicating that double-tapping should be disabled, allowing single taps to avoid the delay. * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::potentialTapAtPosition): 2015-12-04 Matthew Hanson Merge r191409. rdar://problem/23732400 2015-10-21 Wenson Hsieh Single tapping clickable elements in unscalable pages should show a tap highlight https://bugs.webkit.org/show_bug.cgi?id=150382 Reviewed by Simon Fraser. When the double tap gesture recognizer is disabled ahead of time (as in the case of unscalable pages) the tap is committed before the geometries come in. To fix this, we introduce a flag that allows the single tap to be committed before the tap highlight arrives. This allows the tap highlight to be immediately animated when receiving the tap highlight geometries only in the case where double tapping is disabled when recognizing the single tap. * UIProcess/ios/WKContentViewInteraction.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView setupInteraction]): (-[WKContentView cleanupInteraction]): (-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]): (-[WKContentView _singleTapRecognized:]): (-[WKContentView _singleTapCommited:]): 2015-12-04 Matthew Hanson Merge r191309. rdar://problem/23732400 2015-10-17 Wenson Hsieh Extend fast-clicking behavior to trigger on elements that have negligible zoom https://bugs.webkit.org/show_bug.cgi?id=150248 Reviewed by Simon Fraser. Currently, fast-clicking only triggers on pages that have unscalable viewports. To allow more websites to benefit from fast-clicking behavior, we generalize fast-clicking to also occur when tapping on elements for which double-tap-to-zoom would zoom the element in or out by an insignificant amount. We define an insignificant amount of zoom to mean that zooming would increase the viewport scale by less than a configurable threshold, or decrease the viewport scale by more than a configurable threshold. We accomplish this by temporarily disabling the double tap gesture recognizer for the duration of the tap. This patch refactors some logic used to compute zoomed viewports to make it possible to predict the change in viewport scale when double tapping to zoom. See the changes in SmartMagnificationController and ViewGestureGeometryCollector for more details. There are no new tests, since this patch does not change existing behavior. Instead, this patch adds the machinery needed for zoom- dependent fast-clicking: by setting the preferences WebKitFastClickingEnabled and WebKitFastClickZoomThreshold, we will be able to tweak the behavior dynamically. * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _didCommitLayerTree:]): (-[WKWebView _contentZoomScale]): (-[WKWebView _targetContentZoomScaleForRect:currentScale:fitEntireRect:minimumScale:maximumScale:]): (-[WKWebView _zoomToRect:withOrigin:fitEntireRect:minimumScale:maximumScale:minimumScrollDistance:]): (-[WKWebView _viewportIsUserScalable]): * UIProcess/API/Cocoa/WKWebViewInternal.h: * UIProcess/API/Cocoa/WKWebViewPrivate.h: * UIProcess/PageClient.h: * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * UIProcess/ios/PageClientImplIOS.h: * UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::disableDoubleTapGesturesUntilTapIsFinishedIfNecessary): * UIProcess/ios/SmartMagnificationController.h: * UIProcess/ios/SmartMagnificationController.mm: (WebKit::SmartMagnificationController::adjustSmartMagnificationTargetRectAndZoomScales): (WebKit::SmartMagnificationController::didCollectGeometryForSmartMagnificationGesture): (WebKit::SmartMagnificationController::magnify): * UIProcess/ios/WKContentViewInteraction.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]): (-[WKContentView _fastClickZoomThreshold]): (-[WKContentView _allowDoubleTapToZoomForCurrentZoomScale:andTargetZoomScale:]): (-[WKContentView _disableDoubleTapGesturesUntilTapIsFinishedIfNecessary:allowsDoubleTapZoom:targetRect:isReplaced:minimumScale:maximumScale:]): (-[WKContentView _highlightLongPressRecognized:]): (-[WKContentView _endPotentialTapAndEnableDoubleTapGesturesIfNecessary]): (-[WKContentView _singleTapRecognized:]): (cancelPotentialTapIfNecessary): (-[WKContentView _singleTapCommited:]): (-[WKContentView webSelectionRects]): Deleted. * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::disableDoubleTapGesturesUntilTapIsFinishedIfNecessary): * WebProcess/WebPage/ViewGestureGeometryCollector.cpp: (WebKit::ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture): (WebKit::ViewGestureGeometryCollector::computeZoomInformationForNode): * WebProcess/WebPage/ViewGestureGeometryCollector.h: * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::potentialTapAtPosition): 2015-12-04 Matthew Hanson Merge r191072. rdar://problem/23732400 2015-10-14 Wenson Hsieh Web pages with unscalable viewports shouldn't have a single tap delay https://bugs.webkit.org/show_bug.cgi?id=149968 Reviewed by Simon Fraser. When a viewport is unscalable (specified through the meta viewport tag) we do not add a delay to our single tap gesture recognizer. We do this by disabling or reinitializing the WKContentView's double tap gesture recognizer when the viewport becomes unscalable or scalable, respectively. A viewport is deemed unscalable when it has user-scalable = no, or when the minimum scale is greater than or equal to the maximum scale. * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _didCommitLayerTree:]): * UIProcess/ios/WKContentViewInteraction.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _createAndConfigureDoubleTapGestureRecognizer]): Pulled logic for initializing a double tap gesture recognizer out into a helper function. (-[WKContentView setupInteraction]): (-[WKContentView _setDoubleTapGesturesEnabled:]): Turns gesture recognition for double taps on or off. 2015-12-03 Matthew Hanson Merge r188647. rdar://problem/23732386 2015-08-18 Dean Jackson Support CSS filters without webkit prefix https://bugs.webkit.org/show_bug.cgi?id=148138 Reviewed by Sam Weinig. Rename WebkitFilter to Filter. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::decode): 2015-12-03 Timothy Hatcher Merge r192745. rdar://problem/23221163 2015-11-23 Brian Burg Web Inspector: when inspecting the inspector, add the inspection level to the title bar https://bugs.webkit.org/show_bug.cgi?id=151555 Reviewed by Timothy Hatcher. If the inspection level says we are inspecting an inspector, include the level in the title bar to easily disambiguate it from the base level inspector. * UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::updateInspectorWindowTitle): 2015-12-02 Timothy Hatcher Merge r189883. rdar://problem/23221163 2015-09-16 Joseph Pecoraro Web Inspector: Fix common typo "supress" => "suppress" https://bugs.webkit.org/show_bug.cgi?id=149199 Reviewed by Gyuyoung Kim. * PluginProcess/mac/PluginProcessMac.mm: (WebKit::PluginProcess::platformInitializeProcess): 2015-12-02 Timothy Hatcher Merge r188353. rdar://problem/23221163 2015-08-12 Joseph Pecoraro Web Inspector: Not receiving responses for async request IndexedDB.requestDatabaseNames https://bugs.webkit.org/show_bug.cgi?id=147844 Reviewed by Brian Burg. * WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp: (WebKit::WebIDBFactoryBackend::getDatabaseNames): This method should not return without calling either the success or error callbacks. In this case, it can succeed with an empty list. 2015-12-01 Timothy Hatcher Merge r186724. rdar://problem/23221163 2015-07-11 Nikita Vasilyev Web Inspector: Inspector should be able to be docked to the bottom of a narrow window https://bugs.webkit.org/show_bug.cgi?id=146871 Reviewed by Timothy Hatcher. * UIProcess/WebInspectorProxy.cpp: * UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCanAttach): * WebProcess/WebPage/WebInspector.cpp: 2015-10-13 Matthew Hanson Merge r190141. rdar://problem/23075536 2015-09-22 Anders Carlsson URL of page visited in private browsing still appears in Activity Monitor after page is closed https://bugs.webkit.org/show_bug.cgi?id=149475 rdar://problem/22684521 Reviewed by Dan Bernstein. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): Make sure to call updateActivePages after removing the page from the page map. * WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::updateActivePages): Don't include pages that have private browsing enabled. 2015-10-13 Matthew Hanson Merge r188443. rdar://problem/22801969 2015-08-13 Tim Horton Performing a Lookup on wrapped text puts the popover arrow in the wrong place (off to the right) https://bugs.webkit.org/show_bug.cgi?id=148012 Reviewed by Simon Fraser. * UIProcess/mac/PageClientImpl.mm: (WebKit::PageClientImpl::didPerformDictionaryLookup): * UIProcess/mac/WKImmediateActionController.mm: (-[WKImmediateActionController _animationControllerForText]): Adopt the new SPI, handing it the first text rect, instead of having it guess where to put the popover. 2015-10-08 Andy Estes Merge r188150, r188517, r188844, r188845, r188851, r188852, r188880, r188881, r188988, r189193, r189289, and r190133. rdar://problem/22847063 2015-08-26 Andy Estes [Content Filtering] Determine navigation and content policy before continuing to filter a load https://bugs.webkit.org/show_bug.cgi?id=148506 Reviewed by Brady Eidson. Deleted parts of r188486 and r188851. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): * WebProcess/WebCoreSupport/WebFrameLoaderClient.h: * WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::convertMainResourceLoadToDownload): 2015-08-11 Andy Estes [Cocoa] Add redirect support to CustomProtocolManager https://bugs.webkit.org/show_bug.cgi?id=147871 Reviewed by Dan Bernstein. NSURLProtocols have the ability to generate redirect responses. This change teaches CustomProtocolManager how to handle them. * Shared/Network/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm: (WebKit::CustomProtocolManager::wasRedirectedToRequest): Called -URLProtocol:wasRedirectedToRequest:redirectResponse: on the NSURLProtocolClient. * Shared/Network/CustomProtocols/CustomProtocolManager.h: * Shared/Network/CustomProtocols/CustomProtocolManager.messages.in: Defined WasRedirectedToRequest. * Shared/Network/CustomProtocols/soup/CustomProtocolManagerSoup.cpp: (WebKit::CustomProtocolManager::wasRedirectedToRequest): Defined empty function. * UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm: (-[WKCustomProtocolLoader connection:willSendRequest:redirectResponse:]): If a redirect response is received, send WasRedirectedToRequest and return nil to ignore the redirect. 2015-10-08 Lucas Forschler Rollout r190745 2015-10-08 Lucas Forschler Merge r188443. rdar://problem/22801969 2015-08-13 Tim Horton Performing a Lookup on wrapped text puts the popover arrow in the wrong place (off to the right) https://bugs.webkit.org/show_bug.cgi?id=148012 Reviewed by Simon Fraser. * UIProcess/mac/PageClientImpl.mm: (WebKit::PageClientImpl::didPerformDictionaryLookup): * UIProcess/mac/WKImmediateActionController.mm: (-[WKImmediateActionController _animationControllerForText]): Adopt the new SPI, handing it the first text rect, instead of having it guess where to put the popover. 2015-10-02 Babak Shafiei Merge r190418. 2015-10-01 Antti Koivisto Network cache: Subresource referer header wrong after cached redirect https://bugs.webkit.org/show_bug.cgi?id=149709 rdar://problem/22917174 Reviewed by Chris Dumez. If a main resource is loaded from a cache entry that involved redirects the document will end up setting the Referer-headers of the subresources to the request URL not the redirected URL * NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::didRetrieveCacheEntry): If a cache entry involved a redirect synthesize a minimal willSendRequest message so that WebCore side runs through the same code paths as when receiving a redirect from network. 2015-10-02 Matthew Hanson Merge r190252. rdar://problem/22867962 2015-09-25 Beth Dakin Clicking on a data detected item inside a form control always pops up a map on force touch trackpad https://bugs.webkit.org/show_bug.cgi?id=149559 -and corresponding- rdar://problem/22826796 Reviewed by Tim Horton. Look for Data Detected text for text nodes and HitTestResults that are over text inside form controls. * WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::performImmediateActionHitTestAtLocation): 2015-10-02 Matthew Hanson Merge r188990. rdar://problem/22802029 2015-08-26 Beth Dakin REGRESSION: Safari navigates after a cancelled force click https://bugs.webkit.org/show_bug.cgi?id=148491 -and corresponding- rdar://problem/22394323 Reviewed by Tim Horton. Use the current stage to determine which type of cancel this is. * WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::immediateActionDidCancel): 2015-10-02 Matthew Hanson Merge r188755. rdar://problem/22802005 2015-08-21 Chris Dumez Regression(r188698): http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html is very flaky https://bugs.webkit.org/show_bug.cgi?id=148205 Reviewed by Antti Koivisto. After r188640, successful revalidation of resources in the memory cache would cause us to drop the corresponding resource in the disk cache. This patch addresses the issue by not removing the cache entry if the response is a successful revalidation (i.e. status code == 304). Longer term, we should probably update the entry in the disk cache (if it exists) when it is revalidated by the memory cache. Currently, revalidation by the memory cache bypasses the disk cache and goes straight to the network. Then, when the response comes back as a 304, we try and store the response in the cache. However, a 304 status code is not cacheable so the cache rejects it. * NetworkProcess/cache/NetworkCache.cpp: (WebKit::NetworkCache::Cache::store): 2015-10-02 Matthew Hanson Merge r189102. rdar://problem/22802034 2015-08-28 Timothy Horton [Mac] Right-clicking on GIFs spins the UI process for a while https://bugs.webkit.org/show_bug.cgi?id=148566 Reviewed by Brady Eidson. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::internalShowContextMenu): (WebKit::WebPageProxy::platformInitializeShareMenuItem): * UIProcess/WebPageProxy.h: * UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::platformInitializeShareMenuItem): Move all of the code to make a Share menuitem into platformInitializeShareMenuItem. Make an NSImage directly from the image data if possible. 2015-10-02 Matthew Hanson Merge r188640. rdar://problem/22802005 2015-08-19 Chris Dumez WebKit may keep outdated entry in the disk cache after a reload https://bugs.webkit.org/show_bug.cgi?id=148137 Reviewed by Antti Koivisto. WebKit would keep outdated entry in the disk cache after a reload in the following scenario: 1. We have an entry in the cache 2. The user reloads 3. We get a fresh resource from the network but this one is not cacheable In this case, we now remove the stale entry from the cache to make sure it is not served to following requests (e.g. history navigations). * NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::didFinishLoading): Remove the entry from the cache if its redirection is no longer cacheable. * NetworkProcess/cache/NetworkCache.cpp: (WebKit::NetworkCache::Cache::store): If we make the decision not to store the response, then remove the entry in the cache for this resource if it exists. (WebKit::NetworkCache::Cache::remove): * NetworkProcess/cache/NetworkCache.h: Add new remove() overload taking a ResourceRequest argument so the call site does not have the compute the key. * NetworkProcess/cache/NetworkCacheStorage.cpp: (WebKit::NetworkCache::Storage::removeFromPendingWriteOperations): (WebKit::NetworkCache::Storage::remove): * NetworkProcess/cache/NetworkCacheStorage.h: When we're asked to remove an entry with a given key, also remove it from the pending write operations. This pre-existing bug would prevent the new layout test from passing. 2015-08-17 Matthew Hanson Merge r188365. rdar://problem/22254920 2015-08-12 Alexey Proskuryakov [Mac] WebKit processes should have access to com.apple.nesessionmanager.flow-divert-token https://bugs.webkit.org/show_bug.cgi?id=147949 rdar://problem/22254920 Reviewed by Anders Carlsson. * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: * WebProcess/com.apple.WebProcess.sb.in: 2015-08-14 Babak Shafiei Merge r188486. 2015-08-13 Andy Estes [Cocoa] Downloads do not start if policy decision is made asynchronously https://bugs.webkit.org/show_bug.cgi?id=147985 Reviewed by Brady Eidson. * WebProcess/Network/WebResourceLoader.cpp: Updated to include SubresourceLoader.h. * WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::convertMainResourceLoadToDownload): Started a new download if the main resource loader is not calling didReceiveResponse. 2015-08-06 Dana Burkart Merge r188011. rdar://problem/22055130 2015-08-05 Tim Horton PDFPlugins are clipped in link previews (and remain so when opened) https://bugs.webkit.org/show_bug.cgi?id=147708 Reviewed by Simon Fraser. * UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:processPool:configuration:webView:]): (-[WKView _supportsArbitraryLayoutModes]): (-[WKView _didCommitLoadForMainFrame]): (-[WKView _setLayoutMode:]): (-[WKView _setViewScale:]): Avoid using any layout mode other than "ViewSize" for main frame PluginDocuments, because they will often end up behaving incorrectly (especially with PDFPlugin, which is even more special in that it takes over application of page scale). Save any incoming changes to the viewScale and layoutMode, and re-apply them once we load something in the main frame that is *not* a PluginDocument. * UIProcess/API/mac/WKViewInternal.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scalePage): Make sure to reset WebCore's page scale if the main frame contains a PluginDocument that takes care of page scale itself. (WebKit::WebPage::didCommitLoad): Do the same thing as what we do in WKView _didCommitLoadForMainFrame, but without the UI process round-trip, to avoid an ugly flash. * UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::didCommitLoad): * UIProcess/WebFrameProxy.h: (WebKit::WebFrameProxy::containsPluginDocument): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didCommitLoadForFrame): * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * UIProcess/mac/PageClientImpl.mm: (WebKit::PageClientImpl::didCommitLoadForMainFrame): * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidCommitLoad): Plumb and keep track of whether the main frame contains a PluginDocument or not. 2015-08-06 Dana Burkart Merge r187962. rdar://problem/21827815 2015-08-05 Daniel Bates REGRESSION (r185111): Clicking phone numbers doesn't prompt to call sometimes https://bugs.webkit.org/show_bug.cgi?id=147678 Reviewed by Brady Eidson. Teach WebKit to save and restore the "should open external URLs" policy. * Shared/SessionState.cpp: (WebKit::isValidEnum): Added. (WebKit::PageState::encode): Modified to encode the "should open external URLs" policy. (WebKit::PageState::decode): Modified to decode the "should open external URLs" policy. * Shared/SessionState.h: Added ShouldOpenExternalURLsPolicy to PageState (defaults to WebCore::ShouldOpenExternalURLsPolicy::ShouldNotAllow). * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _killWebContentProcessAndResetState]): Added; used in the unit test TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm. * UIProcess/API/Cocoa/WKWebViewPrivate.h: Declare -[WKWebView _killWebContentProcessAndResetState]. * UIProcess/mac/LegacySessionStateCoding.cpp: Defined constant sessionHistoryEntryShouldOpenExternalURLsPolicyKey. (WebKit::encodeSessionHistory): Modified to encode the "should open external URLs" policy. (WebKit::decodeSessionHistoryEntry): Modified to decode the "should open external URLs" policy. * WebProcess/WebCoreSupport/SessionStateConversion.cpp: (WebKit::toPageState): Copy "should open external URLs" policy from specified history item. (WebKit::toHistoryItem): Apply "should open external URLs" policy from PageState to HistoryItem. 2015-08-06 Dana Burkart Merge r187764. rdar://problem/22077836 2015-08-03 Beth Dakin Need WKWebView API to enable/disable link preview https://bugs.webkit.org/show_bug.cgi?id=147573 -and corresponding- rdar://problem/22077836 Reviewed by Dan Bernstein. WKView implementation. * UIProcess/API/Cocoa/WKViewPrivate.h: New API. Call into WKView to handle Mac. * UIProcess/API/Cocoa/WKWebView.h: * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView initWithFrame:configuration:]): (-[WKWebView allowsLinkPreview]): (-[WKWebView setAllowsLinkPreview:]): Remove the SPI declaration from WKWebViewPrivate in order to make this API. * UIProcess/API/Cocoa/WKWebViewPrivate.h: Handle the Mac side. * UIProcess/API/mac/WKView.mm: (-[WKView viewDidMoveToWindow]): (-[WKView initWithFrame:processPool:configuration:webView:]): (-[WKView allowsBackForwardNavigationGestures]): (-[WKView allowsLinkPreview]): (-[WKView setAllowsLinkPreview:]): Don’t register previews when link preview is prevented. * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _registerPreview]): 2015-08-06 Dana Burkart Merge r187886. rdar://problem/15779101 2015-08-04 Alexey Proskuryakov Implement NPAPI redirect handling https://bugs.webkit.org/show_bug.cgi?id=138675 rdar://problem/15779101 Patch by Jeffrey Pfau, updated and tweaked by me. Reviewed by Anders Carlsson. * PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::loadURL): (WebKit::PluginControllerProxy::continueStreamLoad): (WebKit::PluginControllerProxy::cancelStreamLoad): (WebKit::PluginControllerProxy::didEvaluateJavaScript): (WebKit::PluginControllerProxy::streamWillSendRequest): (WebKit::PluginControllerProxy::streamDidReceiveResponse): * PluginProcess/PluginControllerProxy.h: * PluginProcess/PluginControllerProxy.messages.in: * WebProcess/Network/WebResourceLoader.cpp: (WebKit::WebResourceLoader::willSendRequest): * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_ConvertPoint): (WebKit::NPN_URLRedirectResponse): (WebKit::initializeBrowserFuncs): (WebKit::netscapeBrowserFuncs): * WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::getAuthenticationInfo): (WebKit::NetscapePlugin::registerRedirect): (WebKit::NetscapePlugin::urlRedirectResponse): (WebKit::NetscapePlugin::setIsPlayingAudio): (WebKit::NetscapePlugin::NPP_URLNotify): (WebKit::NetscapePlugin::NPP_URLRedirectNotify): (WebKit::NetscapePlugin::NPP_GetValue): (WebKit::NetscapePlugin::didEvaluateJavaScript): (WebKit::NetscapePlugin::streamWillSendRequest): (WebKit::NetscapePlugin::streamDidReceiveResponse): * WebProcess/Plugins/Netscape/NetscapePlugin.h: * WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::~NetscapePluginStream): (WebKit::NetscapePluginStream::willSendRequest): (WebKit::NetscapePluginStream::didReceiveResponse): (WebKit::NetscapePluginStream::stop): (WebKit::NetscapePluginStream::setURL): (WebKit::NetscapePluginStream::cancel): * WebProcess/Plugins/Netscape/NetscapePluginStream.h: (WebKit::NetscapePluginStream::streamID): (WebKit::NetscapePluginStream::npStream): * WebProcess/Plugins/PDF/PDFPlugin.h: * WebProcess/Plugins/Plugin.h: * WebProcess/Plugins/PluginController.h: * WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::didEvaluateJavaScript): (WebKit::PluginProxy::streamWillSendRequest): (WebKit::PluginProxy::streamDidReceiveResponse): (WebKit::PluginProxy::setPluginIsPlayingAudio): (WebKit::PluginProxy::continueStreamLoad): (WebKit::PluginProxy::cancelStreamLoad): * WebProcess/Plugins/PluginProxy.h: * WebProcess/Plugins/PluginProxy.messages.in: * WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::Stream::streamID): (WebKit::PluginView::Stream::Stream): (WebKit::PluginView::Stream::cancel): (WebKit::PluginView::Stream::continueLoad): (WebKit::buildHTTPHeaders): (WebKit::lastModifiedDateMS): (WebKit::PluginView::Stream::willSendRequest): (WebKit::PluginView::Stream::didReceiveResponse): (WebKit::PluginView::cancelStreamLoad): (WebKit::PluginView::continueStreamLoad): (WebKit::PluginView::cancelManualStreamLoad): * WebProcess/Plugins/PluginView.h: 2015-08-03 Matthew Hanson Merge r187691. rdar://problem/22060183 2015-07-31 Chris Dumez Coalesce concurrent authentication challenges for the same ProtectionSpace https://bugs.webkit.org/show_bug.cgi?id=147496 Reviewed by Alexey Proskuryakov. Coalesce concurrent authentication challenges for the same ProtectionSpace. Ideally, this would be done in the network layer but short term, this will make sure the user no longer gets repeating authentication dialogs for the same protection space. This gets rid of a long-standing bug in WebKit / Safari where visiting a site using HTTP authentication would pop up one authentication dialog for each subresource being loaded from the network (especially when the main resource is loaded from the cache). * Shared/Authentication/AuthenticationManager.cpp: (WebKit::canCoalesceChallenge): (WebKit::AuthenticationManager::addChallengeToChallengeMap): (WebKit::AuthenticationManager::shouldCoalesceChallenge): (WebKit::AuthenticationManager::coalesceChallengesMatching): (WebKit::AuthenticationManager::didReceiveAuthenticationChallenge): (WebKit::AuthenticationManager::useCredentialForChallenge): (WebKit::AuthenticationManager::useCredentialForSingleChallenge): (WebKit::AuthenticationManager::continueWithoutCredentialForChallenge): (WebKit::AuthenticationManager::continueWithoutCredentialForSingleChallenge): (WebKit::AuthenticationManager::cancelChallenge): (WebKit::AuthenticationManager::cancelSingleChallenge): (WebKit::AuthenticationManager::performDefaultHandling): (WebKit::AuthenticationManager::performDefaultHandlingForSingleChallenge): (WebKit::AuthenticationManager::rejectProtectionSpaceAndContinue): (WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge): (WebKit::AuthenticationManager::AuthenticationManager): Deleted. * Shared/Authentication/AuthenticationManager.h: 2015-08-03 Matthew Hanson Merge r187751. rdar://problem/22018044 2015-08-03 Wenson Hsieh Inputs with the autofocus attribute cause the keyboard to not deploy https://bugs.webkit.org/show_bug.cgi?id=147555 Reviewed by Andreas Kling. Upon submitting a form by pressing "Go" on the keyboard, an on the next page with the autofocus attribute may become non-interactible. When attempting to tap on the input, nothing seems to happen. This is because the state of WebPage upon invoking WebPage::elementDidFocus indicates (incorrectly) that the input element is already focused, and therefore hits an early return. To solve this, we explicitly reset m_hasFocusedDueToUserInteraction upon transitioning to a new page. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didStartPageTransition): On iOS, resets m_hasFocusedDueToUserInteraction as well. It was previously thought that this would be handled by blur() called on the assisted element when submitting a form. However, pressing "Go" on the iOS keyboard is an implicit submission and does not trigger a blur event. 2015-07-31 Matthew Hanson Merge r187614. rdar://problem/22064327 2015-07-30 Eric Carlson [iOS] Set AirPlay discovery mode to disabled when page is hidden https://bugs.webkit.org/show_bug.cgi?id=147455 Reviewed by Enrica Casucci. * UIProcess/ios/forms/WKAirPlayRoutePicker.mm: (-[WKAirPlayRoutePicker _dismissAirPlayRoutePickerIPad]): Set discovery mode to disabled after the picker has been closed. (-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]): Ditto. 2015-07-31 Lucas Forschler Merge r187530 2015-07-28 Chris Fleizach AX: iOS: VoiceOver hangs indefinitely when an JS alert appears https://bugs.webkit.org/show_bug.cgi?id=147386 Reviewed by Anders Carlsson. Support the iOS platform API to notify accessibility clients when the WebProcess is about to suspend (because of some modal dialog). Luckily, we did all the hardwork for OSX a few years ago to support this paradigm. * Platform/IPC/mac/ConnectionMac.mm: (IPC::AccessibilityProcessSuspendedNotification): (IPC::Connection::willSendSyncMessage): (IPC::Connection::didReceiveSyncReply): 2015-07-31 Lucas Forschler Merge r187522 2015-07-28 Said Abou-Hallawa [iOS] REGRESSION(r168075): Fullscreen web video doesn't pause on screen lock https://bugs.webkit.org/show_bug.cgi?id=147269 Reviewed by Andreas Kling. Media elements should pause when the application is going to EnterBackground under lock regardless whether it is in full screen or not. * Platform/spi/ios/UIKitSPI.h: Forward declare [UIApplication isSuspendedUnderLock]. * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::applicationDidEnterBackground): [UIApp isSuspendedUnderLock] can only be called in the UIProcess. We need to call it here and pass it to the WebPage in the WebProcess as part of the ApplicationDidEnterBackground message. * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: Add the new parameter: 'isSuspendedUnderLock' to the ApplicationDidEnterBackground message. * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::applicationDidEnterBackground): On iOS, the WebPage needs to notify the MediaSessionManagerIOS that it received the message ApplicationDidEnterBackground. 2015-07-31 Lucas Forschler Merge r187491 2015-07-28 Jer Noble [iOS] Notify fullscreen controller in UIProcess whether external playback is allowed https://bugs.webkit.org/show_bug.cgi?id=147343 Reviewed by Brady Eidson. Pass the boolean property wirelessVideoPlaybackDisabled across the UIProcess/WebProcess boundary. * UIProcess/ios/WebVideoFullscreenManagerProxy.mm: (WebKit::WebVideoFullscreenManagerProxy::setWirelessVideoPlaybackDisabled): * WebProcess/ios/WebVideoFullscreenManager.mm: (WebKit::WebVideoFullscreenInterfaceContext::setWirelessVideoPlaybackDisabled): (WebKit::WebVideoFullscreenManager::WebVideoFullscreenManager): (WebKit::WebVideoFullscreenManager::setWirelessVideoPlaybackDisabled): 2015-07-31 Lucas Forschler Merge r187471 2015-07-27 Tim Horton First in-window viewStateChange synchronously blocks despite not previously being in-window https://bugs.webkit.org/show_bug.cgi?id=147344 Reviewed by Simon Fraser. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::updateViewState): (WebKit::WebPageProxy::dispatchViewStateChange): The whole point of m_viewWasEverInWindow was so that we would not synchronously wait when a view was added to a window for the first time, only all subsequent times. However, since m_viewWasEverInWindow was being set *before* being checked in dispatchViewStateChange, we were always blocking. This is a huge waste of main-thread time, because there's no reason to wait for the first paint if you've never seen the view before (and shouldn't expect it to have content). Instead, set the flag after dispatching a view state change, so it becomes "have we ever sent a view state with IsInWindow set" instead. 2015-07-31 Lucas Forschler Merge r187462 2015-07-27 Tim Horton [iOS] Long press or link click can sometimes trigger during/after a preview https://bugs.webkit.org/show_bug.cgi?id=147338 Reviewed by Enrica Casucci. * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _longPressRecognized:]): Bail if we're previewing. (-[WKContentView _dataForPreviewItemController:atPosition:type:]): (-[WKContentView _presentedViewControllerForPreviewItemController:]): Always avoid allowing clicks and start interaction when previewing a link. 2015-07-31 Lucas Forschler Merge r187459 2015-07-27 Andreas Kling [iOS] Occasional crashes in WebPage::elementDidBlur()'s async block. Reviewed by Anders Carlsson. Protect the WebPage object until the dispatch_async block has finished. I have no way to repro this, but there's evidence of some crashing here. * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::elementDidBlur): 2015-07-31 Lucas Forschler Merge r187375 2015-07-24 Anders Carlsson WKWebsiteDataStore remove methods don't properly delete cookies https://bugs.webkit.org/show_bug.cgi?id=147282 rdar://problem/21948230 Reviewed by Sam Weinig. * NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::deleteWebsiteDataForOrigins): Call deleteCookiesForHostnames instead of iterating over each hostname. * WebProcess/Cookies/WebCookieManager.cpp: (WebKit::WebCookieManager::deleteCookiesForHostname): Call deleteCookiesForHostnames. 2015-07-30 Matthew Hanson Merge r187565. rdar://problem/22061043 2015-07-29 Enrica Casucci Preview should not start if touch handler prevents default. https://bugs.webkit.org/show_bug.cgi?id=147423 rdar://problem/22061043 Reviewed by Tim Horton. We need to check if _highlightLongPressCanClick has not been reset before we allow the preview. It can be reset by a touch handler preventing default. * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]): 2015-07-30 Matthew Hanson Merge r187517. rdar://problem/21645007 2015-07-28 Yongjun Zhang Bounds in InteractionInformationAtPosition should be always in main frame coordinate space. https://bugs.webkit.org/show_bug.cgi?id=147372 When we prepare the bounds for InteractionInformationAtPosition, we should convert the rect to main frame space since WKContent in UIProcess expects it to be in the web view space. Reviewed by Tim Horton. * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::getPositionInformation): Convert the bounding rect to main frame space if the element is inside a sub-frame. 2015-07-30 Matthew Hanson Merge r187478. rdar://problem/21838764 2015-07-27 Andreas Kling WebsiteDataStore should clean up its storage in the network process when destroyed. Reviewed by Darin Adler. Have ~WebsiteDataStore() send a DestroyPrivateBrowsingSession message to all networking processes for ephemeral sessions. This plugs a NetworkStorageSession leak that could retain a large CFNetwork object graph. This complements r187115 which did the same for network process storage owned by API::Session objects. * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::~WebsiteDataStore): 2015-07-27 Babak Shafiei Roll out r187376. 2015-07-27 Matthew Hanson Merge r187412. rdar://problem/22003112 2015-07-26 Chris Dumez [WK2][iOS] WebContent process main thread should have fixed priority https://bugs.webkit.org/show_bug.cgi?id=147313 Reviewed by Darin Adler. WebContent process main thread should have fixed priority on iOS 9. Priority decay regresses PLT and fixing the main thread's priority gives up a ~3% progression on warm PLT (tested on iPhone 5s). * WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess): 2015-07-27 Matthew Hanson Merge r187376. rdar://problem/22000647 2015-07-24 Yongjun Zhang Don't create UIWebFormAccessory if we don't require accessory view. https://bugs.webkit.org/show_bug.cgi?id=147283 Don't try to intialize _formAccessoryView if requiresAccessoryView returns false since we don't need it yet. Reviewed by Dan Bernstein. * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView inputAccessoryView]): 2015-07-27 Babak Shafiei Merge r187364. 2015-07-24 Anders Carlsson Networking process crash in NetworkConnectionToWebProcess::convertMainResourceLoadToDownload while attempting to download a blob https://bugs.webkit.org/show_bug.cgi?id=147276 rdar://problem/21423353 Reviewed by Andreas Kling. We currently don't support downloading blobs, so for now just bail if we encounter a null loader inside convertMainResourceLoadToDownload (which happens when trying to download a blob URL). * NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::didCleanupResourceLoader): Rewrite the assertion to be more clear - it's fine to do an extra hash lookup in debug builds. (WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload): Bail if loader is null. 2015-07-26 Babak Shafiei Merge r187345. 2015-07-24 Simon Fraser Recode.net gets into a continual resize loop in split fullscreen https://bugs.webkit.org/show_bug.cgi?id=147266 rdar://problem/21409047 Reviewed by Tim Horton. In split fullscreen, we use fixed layout and scale to shrink pages down to fit a given width. This is re-evaluated every time the document width changes. However some pages, like recode.net, end up continually resizing because when laid out unconstrained they use a narrower width than when laid out with a fixed layout size. In fixed layout, they actually use more width than the fixed layout size. Detect and break this cycle by just not re-scaling when we've done one fixed layout, and the document is now taking more width than the fixed layout width. * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded): 2015-07-26 Babak Shafiei Merge r187178. 2015-07-21 Simon Fraser Add logging for TiledCoreAnimationDrawingArea resizing https://bugs.webkit.org/show_bug.cgi?id=147180 Reviewed by Tim Horton. Add a "Resize" log channel for WebKit2, and use it to log data in scaleViewToFitDocumentIfNeeded(). * Platform/Logging.h: * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded): 2015-07-24 Jer Noble Merge r187251, r187252, r187262, r187263, r187272, r187289. rdar://problem/20689512 2015-07-23 Alex Christensen Fix 32-bit build after r187272. * UIProcess/mac/PageClientImpl.mm: (WebKit::PageClientImpl::mediaDocumentNaturalSizeChanged): Added some WK_API_ENABLED. 2015-07-23 Alex Christensen [iOS] Unreviewed build fix after r187251. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setAllowsMediaDocumentInlinePlayback): Use the correct name for the boolean to pass along to SetAllowsMediaDocumentInlinePlayback. 2015-07-21 Jer Noble Notify the UI delegate when a MediaDocument's natural size changes https://bugs.webkit.org/show_bug.cgi?id=147182 Reviewed by Simon Fraser. Pipe notifications of media document natural size changes up from the chrome client, through to the UIProcess, through the page client, through the WKWebView, to the UIDelegate. * UIProcess/API/APIUIClient.h: (API::UIClient::mediaDocumentNaturalSizeChanged): * UIProcess/API/Cocoa/WKUIDelegatePrivate.h: * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _mediaDocumentNaturalSizeChanged:]): * UIProcess/API/Cocoa/WKWebViewInternal.h: * UIProcess/Cocoa/UIDelegate.h: * UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::setDelegate): (WebKit::UIDelegate::UIClient::mediaDocumentNaturalSizeChanged): * UIProcess/PageClient.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::mediaDocumentNaturalSizeChanged): * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * UIProcess/ios/PageClientImplIOS.h: * UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::mediaDocumentNaturalSizeChanged): * UIProcess/mac/PageClientImpl.h: * UIProcess/mac/PageClientImpl.mm: (WebKit::PageClientImpl::mediaDocumentNaturalSizeChanged): * WebProcess/WebCoreSupport/WebChromeClient.h: * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::mediaDocumentNaturalSizeChanged): * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::mediaDocumentNaturalSizeChanged): * WebProcess/WebPage/WebPage.h: * UIProcess/API/gtk/PageClientImpl.h: Add default, empty implementation of new pure-virtual method. * UIProcess/efl/WebViewEfl.h: Ditto. 2015-07-23 Jer Noble Unreviewed build fix after r187251; rename flag -> allows. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setAllowsMediaDocumentInlinePlayback): 2015-07-23 Jer Noble [WK2] Add a WKWebView property for whether the view is displaying a media document https://bugs.webkit.org/show_bug.cgi?id=147233 Reviewed by Beth Dakin. Add a _isDisplayingStandaloneMediaDocument property, which queries the frame for whether the current MIME type is one which our media engines support. * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _isDisplayingStandaloneMediaDocument]): * UIProcess/API/Cocoa/WKWebViewPrivate.h: * UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::isDisplayingStandaloneMediaDocument): * UIProcess/WebFrameProxy.h: 2015-07-21 Jer Noble [iOS] Add an explicit API to allow media documents to (temporarily) play inline https://bugs.webkit.org/show_bug.cgi?id=147181 Reviewed by Beth Dakin. Add a WKWebView(Private) API which allows MediaDocuments loaded by the view to play their contents inline, regardless of whether inline playback is restricted on the current device. * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _setRequiresUserActionForMediaPlayback:]): Added. Pass through to WebPageProxy. (-[WKWebView _allowsMediaDocumentInlinePlayback]): Ditto. * UIProcess/API/Cocoa/WKWebViewPrivate.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::allowsMediaDocumentInlinePlayback): Simple getter. (WebKit::WebPageProxy::setAllowsMediaDocumentInlinePlayback): Set, and conditionally pass the new value to WebPage. * UIProcess/WebPageProxy.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setAllowsMediaDocumentInlinePlayback): Set, and conditionally notify WebCore page of the change. * WebProcess/WebPage/WebPage.h: (WebKit::WebPage::allowsMediaDocumentInlinePlayback): Simple getter. * WebProcess/WebPage/WebPage.messages.in: Add new messages. 2015-07-24 Matthew Hanson Merge r187268. rdar://problem/21664211 2015-07-23 Enrica Casucci Removing one incorrect annotation from the previous change. Unreviewed. * UIProcess/API/Cocoa/WKUIDelegatePrivate.h: 2015-07-24 Matthew Hanson Merge r187288. rdar://problem/21929532 2015-07-23 Dan Bernstein REGRESSION (r184026): Safari AutoFill with Contact info for phone number is broken https://bugs.webkit.org/show_bug.cgi?id=147249 Reviewed by Sam Weinig. * Shared/API/Cocoa/WKRemoteObjectCoder.mm: (encodeObject): Use encodeString only for strings that encode as NSString or NSMutableString. It can’t encode arbitrary NSString subclasses. (decodeObject): Use decodeString for NSMutableString as well. 2015-07-24 Matthew Hanson Merge r187286. rdar://problem/21953359 2015-07-23 Zalan Bujtas [iOS] REGRESSION (187131): Loading CuteOverload zooms in to the top left corner. https://bugs.webkit.org/show_bug.cgi?id=147251 rdar://problem/21953359 Calling zoomToRect() should result in essentially the same zoom scale as if we called setZoomScale with the new page scale factor. Reviewed by Benjamin Poulain. * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _didCommitLayerTree:]): 2015-07-24 Matthew Hanson Merge r187267. rdar://problem/21664211 2015-07-23 Enrica Casucci [iOS] Add another preview delegate for didDismissPreview. https://bugs.webkit.org/show_bug.cgi?id=147241 rdar://problem/21664211 Reviewed by Tim Horton and Yongjun Zhang. * UIProcess/API/Cocoa/WKUIDelegatePrivate.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _previewItemController:didDismissPreview:committing:]): 2015-07-24 Matthew Hanson Merge r187266. rdar://problem/21910578 2015-07-23 Dan Bernstein Second pass at [iOS] Keyboard shortcuts that take focus away from the web view end up typing a letter into the newly focused field https://bugs.webkit.org/show_bug.cgi?id=146732 Reviewed by Darin Adler. * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _interpretKeyEvent:isCharEvent:]): Rather than checking if the view is first responder, which it might still be when the Web Content processes invokes this callback, check if we are in editable content before forwarding the event to the keyboard. 2015-07-24 Matthew Hanson Merge r187255. rdar://problem/21875510 2015-07-23 Yongjun Zhang Adopt the new _previewItemControllerDidCancelPreview delegate method. https://bugs.webkit.org/show_bug.cgi?id=147238 Don't allow hightlight long press to trigger tap if the link preview is cancelled because the link is not preview-able. Reviewed by Beth Dakin. * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _previewItemControllerDidCancelPreview:]): 2015-07-24 Matthew Hanson Merge r187250. rdar://problem/21968460 2015-07-23 Beth Dakin Should not allow previews of 1x1 images https://bugs.webkit.org/show_bug.cgi?id=147237 -and corresponding- rdar://problem/21968460 Reviewed by Tim Horton. 1x1 images are used on some sites to cover actual images, which leads to a misleading preview experience. There is not any reason why you would really want to preview an image this small nor any reason to believe that the preview would result in anything useful. * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::getPositionInformation): 2015-07-24 Matthew Hanson Merge r187248. rdar://problem/21949735 2015-07-23 Brady Eidson Crash in WebPlatformStrategies::createPingHandle - Deref a null NetworkingContext. and https://bugs.webkit.org/show_bug.cgi?id=147227 Reviewed by Alexey Proskuryakov. * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::createPingHandle): Skip it if there's a null NetworkingContext. 2015-07-24 Matthew Hanson Merge r187215. rdar://problem/21032083 2015-07-22 James Savage Use updated CoreAnimation snapshot SPI. https://bugs.webkit.org/show_bug.cgi?id=147197 Reviewed by Tim Horton. Patch by James Savage. * Platform/spi/ios/UIKitSPI.h: * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]): 2015-07-24 Matthew Hanson Merge r187212. rdar://problem/21945775 2015-07-22 Timothy Horton Fix the build * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView setupInteraction]): (-[WKContentView cleanupInteraction]): 2015-07-24 Matthew Hanson Merge r187199. rdar://problem/21945775 2015-07-22 Tim Horton Fix the build * UIProcess/ios/WKContentViewInteraction.h: 2015-07-24 Matthew Hanson Merge r187198. rdar://problem/21945775 2015-07-22 Tim Horton [iOS] Adjust the preview architecture https://bugs.webkit.org/show_bug.cgi?id=147203 Reviewed by Simon Fraser. * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _dataForPreviewItemController:atPosition:type:]): Link previews should win over image previews if both are possible. 2015-07-24 Matthew Hanson Merge r187193. rdar://problem/21945775 2015-07-22 Tim Horton [iOS] Adjust the preview architecture https://bugs.webkit.org/show_bug.cgi?id=147203 Reviewed by Beth Dakin. * Platform/spi/ios/UIKitSPI.h: * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _setAllowsLinkPreview:]): Deleted. * UIProcess/ios/WKContentView.mm: (-[WKContentView willMoveToWindow:]): Deleted. * UIProcess/ios/WKContentViewInteraction.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView setupInteraction]): (-[WKContentView cleanupInteraction]): (-[WKContentView _registerPreview]): (-[WKContentView _unregisterPreview]): (-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]): (-[WKContentView _dataForPreviewItemController:atPosition:type:]): (-[WKContentView _presentationRectForPreviewItemController:]): (-[WKContentView _presentedViewControllerForPreviewItemController:]): (-[WKContentView _previewItemController:commitPreview:]): (-[WKContentView _previewItemController:willPresentPreview:forPosition:inSourceView:]): (-[WKContentView _previewItemController:didDismissPreview:committing:]): (-[WKContentView _presentationSnapshotForPreviewItemController:]): (-[WKContentView _presentationRectsForPreviewItemController:]): (-[WKContentView gestureRecognizerShouldBegin:]): Deleted. (-[WKContentView _registerPreviewInWindow:]): Deleted. (-[WKContentView _unregisterPreviewInWindow:]): Deleted. (-[WKContentView previewViewControllerForPosition:inSourceView:]): Deleted. (-[WKContentView commitPreviewViewController:]): Deleted. (-[WKContentView willPresentPreviewViewController:forPosition:inSourceView:]): Deleted. (-[WKContentView didDismissPreviewViewController:committing:]): Deleted. Register and unregister in setup/cleanupInteraction instead of when moving between windows. Implement 'shouldBegin' instead of interacting directly with the recognizer. Make use of system enums instead of our own. Let UIPreviewItemController handle shrink-wrapping and the indicator view. 2015-07-24 Matthew Hanson Merge r187174. rdar://problem/21818117 2015-07-22 Sam Weinig Encode/Decode underlying errors when serializing NSErrors https://bugs.webkit.org/show_bug.cgi?id=147199 Reviewed by Anders Carlsson. * Shared/mac/WebCoreArgumentCodersMac.mm: (IPC::ArgumentCoder::decode): (IPC::encodeNSError): (IPC::ArgumentCoder::encodePlatformData): (IPC::decodeNSError): (IPC::ArgumentCoder::decodePlatformData): Break out encoding/decoding of the NSErrors into a helpers so they can be called for the underlying error. 2015-07-24 Matthew Hanson Merge r187173. rdar://problem/21637698 2015-07-22 Beth Dakin Animated images should animate in previews https://bugs.webkit.org/show_bug.cgi?id=147173 -and corresponding- rdar://problem/21637698 Reviewed by Dan Bernstein. InteractionInformationAtPosition needs to know if it’s an animated image. * Shared/InteractionInformationAtPosition.cpp: (WebKit::InteractionInformationAtPosition::encode): (WebKit::InteractionInformationAtPosition::decode): * Shared/InteractionInformationAtPosition.h: New delegate method to create a link preview view controller for animated images. * UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Treat animated images more like link previews. * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView previewViewControllerForPosition:inSourceView:]): Set info.isAnimatedImage * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::getPositionInformation): 2015-07-24 Lucas Forschler Merge r187131 2015-07-21 Zalan Bujtas [iOS] Menu drop down such as on nike.com does not stay https://bugs.webkit.org/show_bug.cgi?id=147047 rdar://problem/21046961 Reviewed by Benjamin Poulain. This is a workaround for unintended scrolling while scaling. (Based on Benjamin Poulain's WIP patch for webkit.org/b/136904) In certain cases when scaling would result in moving the scrollview (which would trigger a scroll event on WebCore side), zoomRect is called instead of setZoomScale to ensure that the scroll position stays intact. * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _didCommitLayerTree:]): 2015-07-24 Lucas Forschler Merge r187136 2015-07-21 Daniel Bates Fix the build following (https://bugs.webkit.org/show_bug.cgi?id=147112) * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::reinstateNetworkProcessAssertionState): Guard implementation with PLATFORM(IOS) since this logic is specific to the iOS port. 2015-07-23 Lucas Forschler Merge r187129 2015-07-21 Daniel Bates WTFCrash() in WebKit::WebProcess::networkConnection() https://bugs.webkit.org/show_bug.cgi?id=147112 Reviewed by Gavin Barraclough. Fixes an issue where a newly launched network process may be jetsam'd because it has not taken a process assertion between the time it was launched and the time when a web process makes use of it. Initially a network process does not have a process assertion. A process assertion is taken (if one has not been taken) for the network process when a process assertion is taken for at least one web process. When the network process crashes a WebProcess may ultimately launch a new network process in WebProcess::networkConnection(). The new network process may be jetsam'd immediately when the system is under some measure pressure because it has a low jetsam priority, 0 (since it does not have a process assertion and higher priority implies that a process is less likely to be jetsam'd). And the logic in WebProcess::networkConnection() explicitly calls CRASH() if the newly launched network process crashes immediately. Towards preventing the newly launched network process from being jetsam'd we should obtain a process assertion for it. * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::WebProcessPool): Initialize m_didNetworkProcessCrash to false. (WebKit::WebProcessPool::ensureNetworkProcess): If the network process crashed (m_didNetworkProcessCrash == true) then tell each process in the pool to reinstate their network activity token for the new network process. (WebKit::WebProcessPool::networkProcessCrashed): Set m_didNetworkProcessCrash to true when the network process crashed. * UIProcess/WebProcessPool.h: * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::reinstateNetworkProcessAssertionState): Added. (WebKit::WebProcessProxy::didSetAssertionState): Add assert to ensure we never have both a background- and foreground- activity token for the network process. * UIProcess/WebProcessProxy.h: 2015-07-23 Lucas Forschler Merge r187117 2015-07-21 Tim Horton [iOS] Avoid using a TextIndicator if there are non-text things to indicate https://bugs.webkit.org/show_bug.cgi?id=147152 Reviewed by Beth Dakin. * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView willPresentPreviewViewController:forPosition:inSourceView:]): * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::shouldUseTextIndicatorForLink): (WebKit::WebPage::getPositionInformation): Fall back to a rectangular area instead of a TextIndicator if there are any non-inline elements inside the link. 2015-07-23 Lucas Forschler Merge r187115 2015-07-21 Andreas Kling API::Session should clean up its storage in the network process when destroyed. Reviewed by Anders Carlsson. Have ~Session() send a DestroyPrivateBrowsingSession message to all networking processes for ephemeral sessions. This plugs a NetworkStorageSession leak that could retain a large CFNetwork object graph. * UIProcess/API/APISession.cpp: (API::Session::~Session): 2015-07-23 Lucas Forschler Merge r187045 2015-07-20 Antti Koivisto NSURLCache fallback does not work on iOS due to sandboxing https://bugs.webkit.org/show_bug.cgi?id=146314 Reviewed by Anders Carlsson. This broke with earlier cache path computation changes. * NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa): NSURLCache path is relative to the container cache path so "." is sufficient. This puts the cache files under /Library/Caches/com.apple.WebKit.Networking/ == Rolled over to ChangeLog-2015-07-23 ==