2015-11-18 Alex Christensen Progress towards implementing Downloads with NETWORK_SESSION https://bugs.webkit.org/show_bug.cgi?id=151414 Reviewed begrudgingly by Brady Eidson. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::detachedFromParent3): (WebFrameLoaderClient::convertMainResourceLoadToDownload): 2015-11-18 Jer Noble Expose WebCore's AudioPlaybackRequiresUserGesture setting to WebKit & WebKit2 https://bugs.webkit.org/show_bug.cgi?id=151274 Reviewed by Anders Carlsson. Add a WebKit preference key, WebKitAudioPlaybackRequiresUserGesture, and a matching WebPreference property, and transfer those preferences to WebCore's settings when they change. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences audioPlaybackRequiresUserGesture]): (-[WebPreferences setAudioPlaybackRequiresUserGesture:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2015-11-12 Anders Carlsson ContextMenuAction and WebMenuItemTag shouldn't have to be in sync https://bugs.webkit.org/show_bug.cgi?id=151226 Reviewed by Tim Horton. * WebView/WebHTMLView.mm: (toAction): (toTag): Add conversion functions. (-[WebMenuTarget forwardContextMenuAction:]): Use toAction. (createMenuItem): Use toTag. (setMenuItemTarget): Deleted. (setMenuTargets): Deleted. (-[WebHTMLView menuForEvent:]): Don't call setMenuTargets, that's already done when we create the menu items. * WebView/WebUIDelegatePrivate.h: Add missing menu item tags. This does break ABI, but the menu item tags were already out of sync so it's very likely that nobody is relying on this. 2015-11-12 Anders Carlsson Fix build. * WebView/WebHTMLView.mm: (fixMenusReceivedFromOldClients): 2015-11-12 Anders Carlsson Remove a couple of unused menu item tag enums https://bugs.webkit.org/show_bug.cgi?id=151220 Reviewed by Sam Weinig. Also, move the old internal tags away from the SPI header. * WebView/WebHTMLView.mm: (fixMenusReceivedFromOldClients): * WebView/WebUIDelegatePrivate.h: 2015-11-12 Anders Carlsson ContextMenuController::contextMenuItemSelected only needs the action and title, not the full item https://bugs.webkit.org/show_bug.cgi?id=151217 Reviewed by Joseph Pecoraro. * WebView/WebHTMLView.mm: (-[WebMenuTarget forwardContextMenuAction:]): 2015-11-12 Anders Carlsson Remove an unused function https://bugs.webkit.org/show_bug.cgi?id=151215 Reviewed by Joseph Pecoraro. * WebCoreSupport/WebContextMenuClient.h: * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuItemSelected): Deleted. 2015-11-11 Anders Carlsson Enable cross-platform context menus by default https://bugs.webkit.org/show_bug.cgi?id=151173 Reviewed by Tim Horton. * WebView/WebHTMLView.mm: (createMenuItem): (customMenuFromDefaultItems): 2015-11-12 Csaba Osztrogonác Remove ENABLE(SATURATED_LAYOUT_ARITHMETIC) guards https://bugs.webkit.org/show_bug.cgi?id=150972 Reviewed by Darin Adler. * Configurations/FeatureDefines.xcconfig: 2015-11-11 Anders Carlsson Get rid of -[WebMenuTarget validateMenuItem:] https://bugs.webkit.org/show_bug.cgi?id=151172 Reviewed by Beth Dakin. We don't need the menu items to be validated since we handle enabling/disabling them ourselves (as well as setting their checked state). * WebView/WebHTMLView.mm: (-[WebMenuTarget validateMenuItem:]): Deleted. 2015-11-11 Geoffrey Garen Rename handle.*Event to dispatch.*Event https://bugs.webkit.org/show_bug.cgi?id=151168 Reviewed by Chris Dumez. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidDispatchOnloadEvents): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): Deleted. 2015-11-11 Anders Carlsson Remove more dead context menu code https://bugs.webkit.org/show_bug.cgi?id=151163 Reviewed by Tim Horton. * WebCoreSupport/WebContextMenuClient.h: * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::shareMenuItem): Deleted. 2015-11-10 Tim Horton Adopt formal protocols for CA delegates https://bugs.webkit.org/show_bug.cgi?id=151121 Reviewed by Anders Carlsson. * WebView/WebHTMLView.mm: 2015-11-09 Eric Carlson [Mac] Add a mock AppleTV device for testing https://bugs.webkit.org/show_bug.cgi?id=148912 Reviewed by Tim Horton. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::setMockMediaPlaybackTargetPickerEnabled): New. (WebChromeClient::setMockMediaPlaybackTargetPickerState): Ditto. * WebView/WebMediaPlaybackTargetPicker.h: * WebView/WebMediaPlaybackTargetPicker.mm: (WebMediaPlaybackTargetPicker::setMockMediaPlaybackTargetPickerEnabled): New. (WebMediaPlaybackTargetPicker::setMockMediaPlaybackTargetPickerState): Ditto. * WebView/WebView.mm: (-[WebView _setMockMediaPlaybackTargetPickerEnabled:]): New. (-[WebView _setMockMediaPlaybackTargetPickerName:state:]): Ditto. * WebView/WebViewInternal.h: 2015-11-07 Simon Fraser Remove ColorSpace argument to all the drawing calls https://bugs.webkit.org/show_bug.cgi?id=150967 Reviewed by Darin Adler. Since the -webkit-color-correction CSS property was removed in r188202, and ColorSpaceDeviceRGB and ColorSpaceSRGB are functionally equivalent, we can remove all the ColorSpace arguments passed to drawing functions, and remove RenderStyle::colorSpace(), which was hardcoded to return ColorSpaceSRGB. * Misc/WebKitNSStringExtras.mm: (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): * WebInspector/WebNodeHighlightView.mm: (-[WebNodeHighlightView _layoutForNodeHighlight:parent:]): (-[WebNodeHighlightView _layoutForRectsHighlight:parent:]): * WebView/WebFrame.mm: (-[WebFrame _bodyBackgroundColor]): * WebView/WebFrameView.mm: (-[WebFrameView drawRect:]): * WebView/WebIndicateLayer.mm: 2015-11-05 Nikos Andronikos Add runtime and compile time flags for enabling Web Animations API and model. https://bugs.webkit.org/show_bug.cgi?id=150914 Reviewed by Benjamin Poulain. Add ENABLE_WEB_ANIMATIONS compile time flag, runtime flag webAnimationsEnabled and Expose WK2 preference for runtime flag. * Configurations/FeatureDefines.xcconfig: 2015-11-03 Jiewen Tan [WK1] Null dereference loading Blink layout test editing/input/text-input-controller-no-editable-no-crash.html https://bugs.webkit.org/show_bug.cgi?id=149484 Reviewed by Darin Adler. firstRectForCharacterRange(): don't fall over in an editable-less frame. * WebView/WebFrame.mm: (-[WebFrame _convertToDOMRange:]): 2015-11-02 Andy Estes [Cocoa] Add tvOS and watchOS to SUPPORTED_PLATFORMS https://bugs.webkit.org/show_bug.cgi?id=150819 Reviewed by Dan Bernstein. This tells Xcode to include these platforms in its Devices dropdown, making it possible to build in the IDE. * Configurations/Base.xcconfig: 2015-10-31 Andy Estes Replace iOS-only WebKitSystemInterface calls with SPI https://bugs.webkit.org/show_bug.cgi?id=150763 Reviewed by Darin Adler. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Deleted. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Used deviceClass() and Settings::defaultMinimumZoomFontSize() instead of WKGetDeviceClass() and WKGetMinimumZoomFontSize(). * WebView/WebView.mm: (shouldAllowPictureInPictureMediaPlayback): Used dyld_get_program_sdk_version() instead of iosExecutableWasLinkedOnOrAfterVersion(). (-[WebView _updateScreenScaleFromWindow]): Used screenScaleFactor() instead of WKGetScreenScaleFactor(). 2015-11-02 Commit Queue Unreviewed, rolling out r191902. https://bugs.webkit.org/show_bug.cgi?id=150811 This change broke iOS builders (Requested by ryanhaddad on #webkit). Reverted changeset: "Replace iOS-only WebKitSystemInterface calls with SPI" https://bugs.webkit.org/show_bug.cgi?id=150763 http://trac.webkit.org/changeset/191902 2015-10-31 Andy Estes Replace iOS-only WebKitSystemInterface calls with SPI https://bugs.webkit.org/show_bug.cgi?id=150763 Reviewed by Darin Adler. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Deleted. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Used deviceClass() and Settings::defaultMinimumZoomFontSize() instead of WKGetDeviceClass() and WKGetMinimumZoomFontSize(). * WebView/WebView.mm: (shouldAllowPictureInPictureMediaPlayback): Used dyld_get_program_sdk_version() instead of iosExecutableWasLinkedOnOrAfterVersion(). (-[WebView _updateScreenScaleFromWindow]): Used screenScaleFactor() instead of WKGetScreenScaleFactor(). 2015-11-02 Youenn Fablet Rename JSDOMWrapper.impl to JSDOMWrapper.wrapped https://bugs.webkit.org/show_bug.cgi?id=150613 Reviewed by Darin Adler. * WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): * WebView/WebScriptDebugger.mm: (toWebFrame): 2015-11-01 Yusuke Suzuki [ES6] Support Generator Syntax https://bugs.webkit.org/show_bug.cgi?id=150769 Reviewed by Geoffrey Garen. Added ENABLE_ES6_GENERATORS flag. * Configurations/FeatureDefines.xcconfig: 2015-10-30 Dan Bernstein Fixed the build. * Plugins/WebPluginController.mm: (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_): (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_): 2015-10-29 Anders Carlsson Remove a never used SPI delegate method https://bugs.webkit.org/show_bug.cgi?id=150680 Reviewed by Beth Dakin. The webView:contextMenuItemSelected:forElement: method was added 9 years ago, seemingly for feature parity with the Windows port. The delegate method will never be called unless a menu item has the internal WebKit action/target pair, and a tag that is set to >= ContextMenuItemBaseApplicationTag. Because of this, we can safely remove it. * DefaultDelegates/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:willPopupMenu:]): (-[WebDefaultUIDelegate webView:didDrawRect:]): (-[WebDefaultUIDelegate webView:didScrollDocumentInFrameView:]): (-[WebDefaultUIDelegate webView:contextMenuItemSelected:forElement:]): Deleted. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuItemSelected): Deleted. * WebView/WebUIDelegatePrivate.h: 2015-10-28 Anders Carlsson WebKit, not WebCore, should do context menu conversion https://bugs.webkit.org/show_bug.cgi?id=150640 Reviewed by Tim Horton. * WebView/WebHTMLView.mm: (createShareMenuItem): (createMenuItem): (createMenuItems): (customMenuFromDefaultItems): 2015-10-26 Anders Carlsson Remove dead context menu code https://bugs.webkit.org/show_bug.cgi?id=150567 Reviewed by Tim Horton. * WebCoreSupport/WebContextMenuClient.h: * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::getCustomMenuFromDefaultItems): Deleted. 2015-10-23 Anders Carlsson Invoke the context menu delegate callback right before we return the menu https://bugs.webkit.org/show_bug.cgi?id=150521 Reviewed by Tim Horton. Move the getCustomMenuFromDefaultItems to WebHTMLView wholesale. This will allow us to get rid of the ContextMenuClient function from WebCore. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::getCustomMenuFromDefaultItems): (isPreVersion3Client): Deleted. (isPreInspectElementTagClient): Deleted. (fixMenusToSendToOldClients): Deleted. (fixMenusReceivedFromOldClients): Deleted. * WebView/WebHTMLView.mm: (isPreVersion3Client): (isPreInspectElementTagClient): (fixMenusToSendToOldClients): (fixMenusReceivedFromOldClients): (customMenuFromDefaultItems): (-[WebHTMLView menuForEvent:]): 2015-10-23 Anders Carlsson More context menu simplification https://bugs.webkit.org/show_bug.cgi?id=150519 Reviewed by Tim Horton. There's no need to convert the menu items back to ContextMenuItems just so we can check whether its represented object is the sharing service picker. Also, move the check to the second loop. * WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): 2015-10-23 Anders Carlsson Simplify the WebKitLegacy menu conversion code https://bugs.webkit.org/show_bug.cgi?id=150509 Reviewed by Andreas Kling. * WebCoreSupport/WebContextMenuClient.mm: (fixMenusToSendToOldClients): (fixMenusReceivedFromOldClients): (WebContextMenuClient::getCustomMenuFromDefaultItems): 2015-10-23 Anders Carlsson Don't override already existing represented objects on menu items https://bugs.webkit.org/show_bug.cgi?id=150508 Reviewed by Tim Horton. This fixes a crash/exception when a client implements webView:contextMenuItemsForElement:defaultMenuItems: and the default menu has a share menu item. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::getCustomMenuFromDefaultItems): 2015-10-22 Sam Weinig Navigations on the same host (but with different schemes and ports) should not trigger universal links https://bugs.webkit.org/show_bug.cgi?id=150481 Reviewed by Dan Bernstein. * WebCoreSupport/WebFrameLoaderClient.mm: (shouldTryAppLink): Update the policy for following universal links to only take host into consideration. 2015-10-22 Gordon Sheridan Fix build for clang-700.0.59.5 by replacing deprecated calls to convert points between screen and window coordinates for Mac. https://bugs.webkit.org/show_bug.cgi?id=150379 Reviewed by Andy Estes. * WebView/WebHTMLView.mm: (-[WebHTMLView characterIndexForPoint:]): Convert point to rect, and replace call to deprecated convertScreenToBase: with convertRectFromScreen:. (-[WebHTMLView firstRectForCharacterRange:]): Replace call to deprecated convertBaseToScreen: with convertRectToScreen:. 2015-10-22 Myles C. Maxfield [Cocoa] Migrate WKSetPatternPhaseInUserSpace() and WKGetUserToBaseCTM() from WKSI https://bugs.webkit.org/show_bug.cgi?id=150460 Reviewed by Tim Horton. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Deleted. 2015-10-21 Carlos Garcia Campos NetworkProcess: DNS prefetch happens in the Web Process https://bugs.webkit.org/show_bug.cgi?id=147824 Reviewed by Chris Dumez. Implement FrameLoaderClient::prefetchDNS(). * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: 2015-10-20 Commit Queue Unreviewed, rolling out r191370. https://bugs.webkit.org/show_bug.cgi?id=150384 Broke iOS 9 build (Requested by ap on #webkit). Reverted changeset: "Fix build for clang-700.0.59.5 by replacing deprecated calls to convertScreenToBase: with convertRectFromScreen:." https://bugs.webkit.org/show_bug.cgi?id=150379 http://trac.webkit.org/changeset/191370 2015-10-20 Gordon Sheridan Fix build for clang-700.0.59.5 by replacing deprecated calls to convertScreenToBase: with convertRectFromScreen:. https://bugs.webkit.org/show_bug.cgi?id=150379 Reviewed by Simon Fraser. * WebView/WebHTMLView.mm: (-[WebHTMLView characterIndexForPoint:]): Convert point to rect, and call convertRectFromScreen:. (-[WebHTMLView firstRectForCharacterRange:]): Replace convertBaseToScreen: with convertRectToScreen:. 2015-10-20 Tim Horton Try to fix the build by disabling MAC_GESTURE_EVENTS on 10.9 and 10.10 * Configurations/FeatureDefines.xcconfig: 2015-10-20 Yoav Weiss Rename the PICTURE_SIZES flag to CURRENTSRC https://bugs.webkit.org/show_bug.cgi?id=150275 Reviewed by Dean Jackson. * Configurations/FeatureDefines.xcconfig: 2015-10-19 Tim Horton Try to fix the iOS build * Configurations/FeatureDefines.xcconfig: 2015-10-19 Tim Horton Add magnify and rotate gesture event support for Mac https://bugs.webkit.org/show_bug.cgi?id=150179 Reviewed by Darin Adler. * Configurations/FeatureDefines.xcconfig: New feature flag. 2015-10-17 Myles C. Maxfield Build fix after r191260 Unreviewed. * WebView/WebView.mm: (+[WebView initialize]): 2015-10-18 Myles C. Maxfield Stop honoring the user default "WebKitKerningAndLigaturesEnabledByDefault" https://bugs.webkit.org/show_bug.cgi?id=150287 Reviewed by Simon Fraser. * WebView/WebView.mm: (+[WebView initialize]): Deleted. 2015-10-18 Commit Queue Unreviewed, rolling out r191250 and r191253. https://bugs.webkit.org/show_bug.cgi?id=150296 Broke all the tests on Windows (Requested by ap on #webkit). Reverted changesets: "Stop honoring the user default "WebKitKerningAndLigaturesEnabledByDefault"" https://bugs.webkit.org/show_bug.cgi?id=150287 http://trac.webkit.org/changeset/191250 "Build fix after r191250" http://trac.webkit.org/changeset/191253 2015-10-17 Myles C. Maxfield Build fix after r191250 Unreviewed. * WebView/WebView.mm: (+[WebView initialize]): 2015-10-17 Myles C. Maxfield Stop honoring the user default "WebKitKerningAndLigaturesEnabledByDefault" https://bugs.webkit.org/show_bug.cgi?id=150287 Reviewed by Simon Fraser. * WebView/WebView.mm: (+[WebView initialize]): Deleted. 2015-10-16 Anders Carlsson WebEditingDelegate should be a formal protocol https://bugs.webkit.org/show_bug.cgi?id=150254 Reviewed by Dan Bernstein. * WebView/WebEditingDelegate.h: Move all the delegate methods inside the protocol declaration. Also make the header self-contained. * WebView/WebView.h: Change the type of the editing delegate and make it assign. 2015-10-15 Myles C. Maxfield Migrate to CGContextSetBaseCTM() and CGContextResetClip() from WKSI https://bugs.webkit.org/show_bug.cgi?id=150155 Reviewed by Tim Horton. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Deleted. * WebView/WebView.mm: (-[WebView _setBaseCTM:forContext:]): 2015-10-15 Dan Bernstein [Cocoa] Stop using WKSetNSURLConnectionDefersCallbacks https://bugs.webkit.org/show_bug.cgi?id=150189 Reviewed by Anders Carlsson. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Removed initialization. 2015-10-14 Zhuo Li Augment ’s recent search history with the time each entry was added, in order to allow time-based clearing of search history. https://bugs.webkit.org/show_bug.cgi?id=148388. Reviewed by Darin Adler. Replace Vector with Vector, where RecentSearch is a struct that consists search string and time, for recent searches in order to store additional time information. All these new RecentSearches are stored in a plist in which the structure looks like: Root { "items": { autosave name: { "searches": [ { "searchString": searchString, "date": date }, ... ] } } } * WebCoreSupport/SearchPopupMenuMac.h: * WebCoreSupport/SearchPopupMenuMac.mm: (SearchPopupMenuMac::saveRecentSearches): Call saveRecentSearches in WebCore::SearchPopupMenuCocoa. (SearchPopupMenuMac::loadRecentSearches): Call loadRecentSearches in WebCore::SearchPopupMenuCocoa. (autosaveKey): Deleted. 2015-10-13 Myles C. Maxfield Split TypesettingFeatures into kerning and ligatures bools https://bugs.webkit.org/show_bug.cgi?id=150074 Reviewed by Simon Fraser. * WebView/WebView.mm: (+[WebView initialize]): 2015-10-13 Chris Dumez Avoid useless copies in range-loops that are using 'auto' https://bugs.webkit.org/show_bug.cgi?id=150091 Reviewed by Sam Weinig. Avoid useless copies in range-loops that are using 'auto'. Also use 'auto*' instead of 'auto' when range values are pointers for clarity. * WebView/WebFrame.mm: (-[WebFrame getDictationResultRanges:andMetadatas:]): 2015-10-09 Anders Carlsson Don't allow plug-ins to override image types for elements https://bugs.webkit.org/show_bug.cgi?id=149979 Reviewed by Tim Horton. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::objectContentType): 2015-10-10 Dan Bernstein [iOS] Remove unnecessary iOS version checks https://bugs.webkit.org/show_bug.cgi?id=150002 Reviewed by Alexey Proskuryakov. * Plugins/WebPluginController.h: * Plugins/WebPluginController.mm: (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]): (+[WebPluginController addPlugInView:]): (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]): Deleted. * WebCoreSupport/WebFrameLoaderClient.mm: (pluginView): * WebView/WebPreferences.mm: (-[WebPreferences isDNSPrefetchingEnabled]): (-[WebPreferences setWebInspectorServerEnabled:]): Deleted. (-[WebPreferences _setAllowCompositingLayerVisualDegradation:]): Deleted. * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (shouldAllowPictureInPictureMediaPlayback): 2015-10-10 Dan Bernstein [iOS] Remove project support for iOS 8 https://bugs.webkit.org/show_bug.cgi?id=149993 Reviewed by Alexey Proskuryakov. * Configurations/WebKitLegacy.xcconfig: 2015-10-06 Daniel Bates Enable XSLT when building WebKit for iOS using the public iOS SDK https://bugs.webkit.org/show_bug.cgi?id=149827 Reviewed by Alexey Proskuryakov. * Configurations/FeatureDefines.xcconfig: 2015-10-06 Alex Christensen Report error when main resource is blocked by content blocker https://bugs.webkit.org/show_bug.cgi?id=149719 rdar://problem/21970595 Reviewed by Brady Eidson. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::blockedError): (WebFrameLoaderClient::blockedByContentBlockerError): (WebFrameLoaderClient::cannotShowURLError): Add blockedByContentBlockerError so WebFrameLoaderClient is not an abstract class, but it should be unused because content blockers are not enabled on WK1. 2015-10-05 Daniel Bates DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:] https://bugs.webkit.org/show_bug.cgi?id=149766 Reviewed by Alexey Proskuryakov. Assert that we have a non-null pointer to a cookie storage. * WebView/WebPreferences.mm: (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]): 2015-10-05 Andreas Kling Remove unused HistoryItem::targetItem() Reviewed by Anders Carlsson. Remove the only (unused) client of HistoryItem::targetItem(). * History/WebHistoryItem.mm: * History/WebHistoryItemPrivate.h: 2015-10-05 Andreas Kling Remove unused HistoryItem::parent Reviewed by Anders Carlsson. Remove the only (unused) client of HistoryItem's with-parent constructor. * History/WebHistoryItem.mm: (-[WebHistoryItem initWithURL:target:parent:title:]): Deleted. * History/WebHistoryItemInternal.h: 2015-09-30 Timothy Horton Compute document marker rects at use time instead of paint time https://bugs.webkit.org/show_bug.cgi?id=149643 Reviewed by Darin Adler. * WebView/WebHTMLView.mm: (-[WebHTMLView rectsForTextMatches]): 2015-09-16 Carlos Garcia Campos printing does not use minimum page zoom factor https://bugs.webkit.org/show_bug.cgi?id=108507 Reviewed by Darin Adler. Pass a the frame as a reference instead of using pointers. * Misc/WebCoreStatistics.mm: (-[WebFrame numberOfPagesWithPageWidth:pageHeight:]): (-[WebFrame printToCGContext:pageWidth:pageHeight:]): 2015-09-25 Eric Carlson Clean up user media request internal API https://bugs.webkit.org/show_bug.cgi?id=149527 Reviewed by Tim Horton. * WebCoreSupport/WebUserMediaClient.mm: (WebUserMediaClient::cancelRequest): Put UserMediaRequestsMap in a local instead or calling userMediaRequestsMap() three times. (-[WebUserMediaPolicyListener allow]): Get rid of unneeded local variables. (-[WebUserMediaPolicyListener allowDeviceWithVideoUID]): Deleted, unused. 2015-09-22 Andy Estes Disable QuickLook on tvOS https://bugs.webkit.org/show_bug.cgi?id=149492 Reviewed by Dan Bernstein. We can't use USE(QUICK_LOOK) in a Private header, and postprocess-headers.sh doesn't know how to strip things that aren't feature flags. So, if QuickLook is disabled, we'll just always define WebQuickLookFileNameKey and WebQuickLookUTIKey, and we'll also define -quickLookContentForURL: but have it return nil. * WebView/WebView.mm: (-[WebView quickLookContentForURL:]): 2015-09-22 Tim Horton Make it more obvious when using an unaccelerated image buffer, and fix a few callers who do https://bugs.webkit.org/show_bug.cgi?id=149428 Reviewed by Simon Fraser and Darin Adler. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::imageForCurrentSharingServicePickerItem): 2015-09-21 Alexey Proskuryakov REGRESSION (r182648): UIWebView does not set location.hash synchronously https://bugs.webkit.org/show_bug.cgi?id=149415 Reviewed by Darin Adler. The problem was that the delegate in UI thread became asynchronous due to calling into LaunchServices. * WebCoreSupport/WebFrameLoaderClient.mm: (shouldTryAppLink): Don't attempt app links for same domain navigations. This check is part of substantially more complicated logic in WebKit2 that I don't understand, but that should be enough to demonstrate that this fix is an improvement at least. 2015-09-20 Youenn Fablet Remove XHR_TIMEOUT compilation guard https://bugs.webkit.org/show_bug.cgi?id=149260 Reviewed by Benjamin Poulain. * Configurations/FeatureDefines.xcconfig: 2015-09-18 Commit Queue Unreviewed, rolling out r189908. https://bugs.webkit.org/show_bug.cgi?id=149368 Broke run-webkit-tests --pixel (Requested by ap on #webkit). Reverted changeset: "printing does not use minimum page zoom factor" https://bugs.webkit.org/show_bug.cgi?id=108507 http://trac.webkit.org/changeset/189908 2015-09-17 Brian Burg ASSERT(!m_frontendRouter->hasLocalFrontend()) when running Web Inspector tests https://bugs.webkit.org/show_bug.cgi?id=149006 Reviewed by Joseph Pecoraro. WK1 WebInspectorClient was connecting to the wrong controllers. Fix this, and remove extra code paths for closing the frontend. * WebCoreSupport/WebInspectorClient.h: * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController destroyInspectorView]): Disconnect the FrontendClient from the frontend page's inspector controller. Do this teardown before releasing the frontend, otherwise we can't use it. (WebInspectorClient::inspectedPageDestroyed): Deleted. (WebInspectorClient::closeLocalFrontend): Deleted. (WebInspectorFrontendClient::disconnectFromBackend): Deleted. * WebInspector/WebInspector.mm: (-[WebInspector inspectedWebViewClosed]): Make sure to close ourself if the inspected page closes. (-[WebInspector close:]): Go through the frontend instead of InspectorController. * WebInspector/WebInspectorFrontend.h: * WebInspector/WebInspectorFrontend.mm: (-[WebInspectorFrontend close]): 2015-09-16 Carlos Garcia Campos printing does not use minimum page zoom factor https://bugs.webkit.org/show_bug.cgi?id=108507 Reviewed by Darin Adler. Pass a the frame as a reference instead of using pointers. * Misc/WebCoreStatistics.mm: (-[WebFrame numberOfPagesWithPageWidth:pageHeight:]): (-[WebFrame printToCGContext:pageWidth:pageHeight:]): 2015-09-16 Brady Eidson Have window.indexedDB.deleteDatabase return an IDBOpenDBRequest. https://bugs.webkit.org/show_bug.cgi?id=149229 Reviewed by Alex Christensen. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Enable IDB in WK1. 2015-09-15 Ryosuke Niwa Add ShadowRoot interface and Element.prototype.attachShadow https://bugs.webkit.org/show_bug.cgi?id=149187 Reviewed by Antti Koivisto. * Configurations/FeatureDefines.xcconfig: 2015-09-14 Alex Christensen Progress towards CMake on Mac. https://bugs.webkit.org/show_bug.cgi?id=149123 Reviewed by Chris Dumez. * WebView/WebPDFDocumentExtras.mm: (appendValuesInPDFNameSubtreeToVector): * WebView/WebPDFView.mm: Removed cmake include quirks that are not needed when we include things correctly from Quartz.framework/Frameworks. 2015-09-12 Brian Burg Web Inspector: disambiguate inspected/frontend controllers and pages in backend code https://bugs.webkit.org/show_bug.cgi?id=149071 Reviewed by Joseph Pecoraro. Be consistent about prefixing pages, inspector controllers, and window controllers with either "frontend" or "inspected", as appropriate. This change makes obvious some bugs in the frontend connection code, which are tracked by https://webkit.org/b/149006. * WebCoreSupport/WebInspectorClient.h: * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::WebInspectorClient): Renamed. (WebInspectorClient::inspectedPageDestroyed): Renamed. (WebInspectorClient::openLocalFrontend): Renamed. (WebInspectorClient::closeLocalFrontend): Renamed. (WebInspectorClient::didSetSearchingForNode): (WebInspectorFrontendClient::WebInspectorFrontendClient): (WebInspectorFrontendClient::attachAvailabilityChanged): (WebInspectorFrontendClient::canAttach): (WebInspectorFrontendClient::frontendLoaded): (WebInspectorFrontendClient::startWindowDrag): (WebInspectorFrontendClient::bringToFront): (WebInspectorFrontendClient::closeWindow): (WebInspectorFrontendClient::disconnectFromBackend): (WebInspectorFrontendClient::attachWindow): (WebInspectorFrontendClient::detachWindow): (WebInspectorFrontendClient::setAttachedWindowHeight): (WebInspectorFrontendClient::setToolbarHeight): (WebInspectorFrontendClient::updateWindowTitle): (WebInspectorFrontendClient::save): (WebInspectorFrontendClient::append): (-[WebInspectorWindowController init]): (-[WebInspectorWindowController initWithInspectedWebView:isUnderTest:]): (-[WebInspectorWindowController dealloc]): (-[WebInspectorWindowController frontendWebView]): (-[WebInspectorWindowController close]): (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController setAttachedWindowHeight:]): (-[WebInspectorWindowController destroyInspectorView]): (-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]): (WebInspectorClient::inspectorDestroyed): Deleted. (WebInspectorClient::openInspectorFrontend): Deleted. (WebInspectorClient::closeInspectorFrontend): Deleted. (-[WebInspectorWindowController webView]): Deleted. * WebInspector/WebInspector.h: * WebInspector/WebInspector.mm: (-[WebInspector initWithInspectedWebView:]): Renamed. (-[WebInspector inspectedWebViewClosed]): Renamed. (-[WebInspector showWindow]): (-[WebInspector close:]): (-[WebInspector evaluateInFrontend:script:]): (-[WebInspector releaseFrontend]): (-[WebInspector initWithWebView:]): Deleted. (-[WebInspector webViewClosed]): Deleted. * WebView/WebView.mm: (-[WebView _close]): (-[WebView inspector]): 2015-09-10 Chris Dumez Node.appendChild(null) / replaceChild(null, null) / removeChild(null) / insertBefore(null, ref) should throw a TypeError https://bugs.webkit.org/show_bug.cgi?id=148971 Reviewed by Ryosuke Niwa. ContainerNode::appendChild() now takes a Ref&& parameter so we need to update the call site. * WebView/WebFrame.mm: (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): 2015-09-07 Andy Estes [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11 https://bugs.webkit.org/show_bug.cgi?id=148946 Reviewed by Dan Bernstein. * Configurations/DebugRelease.xcconfig: 2015-09-04 Brian Burg Web Inspector: agents should send messages through FrontendRouter instead of FrontendChannel https://bugs.webkit.org/show_bug.cgi?id=148492 Reviewed by Joseph Pecoraro. * WebCoreSupport/WebInspectorClient.h: Clean up the forward declarations, don't use InspectorForwarding.h. * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::openInspectorFrontend): 2015-09-04 Csaba Osztrogonác Remove unnecessary compiler guards from mm files https://bugs.webkit.org/show_bug.cgi?id=148797 Reviewed by Dan Bernstein. * Plugins/WebBasePluginPackage.mm: * Plugins/WebNetscapePluginPackage.mm: 2015-09-04 Brian Burg Web Inspector: InspectorController should support multiple frontend channels https://bugs.webkit.org/show_bug.cgi?id=148538 Reviewed by Joseph Pecoraro. Remove the notifyInspectorController flag from closeWindow. Since InspectorClients must now manually disconnect their FrontendChannel(s), we should always perform the teardown that was guarded by this flag. * WebCoreSupport/WebInspectorClient.h: * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::bringFrontendToFront): Add a missing assertion. (WebInspectorFrontendClient::closeWindow): (WebInspectorFrontendClient::disconnectFromBackend): (-[WebInspectorWindowController windowShouldClose:]): (-[WebInspectorWindowController destroyInspectorView]): Always clear the frontend client. (-[WebInspectorWindowController destroyInspectorView:]): Renamed to above. 2015-09-03 Commit Queue Unreviewed, rolling out r189338. https://bugs.webkit.org/show_bug.cgi?id=148785 Caused tons of crashes (Requested by cdumez on #webkit). Reverted changeset: "Web Inspector: InspectorController should support multiple frontend channels" https://bugs.webkit.org/show_bug.cgi?id=148538 http://trac.webkit.org/changeset/189338 2015-09-03 Brian Burg Web Inspector: InspectorController should support multiple frontend channels https://bugs.webkit.org/show_bug.cgi?id=148538 Reviewed by Joseph Pecoraro. Remove the notifyInspectorController flag from closeWindow. Since InspectorClients must now manually disconnect their FrontendChannel(s), we should always perform the teardown that was guarded by this flag. * WebCoreSupport/WebInspectorClient.h: * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::bringFrontendToFront): Add a missing assertion. (WebInspectorFrontendClient::closeWindow): (WebInspectorFrontendClient::disconnectFromBackend): (-[WebInspectorWindowController windowShouldClose:]): (-[WebInspectorWindowController destroyInspectorView]): Always clear the frontend client. (-[WebInspectorWindowController destroyInspectorView:]): Renamed to above. 2015-08-26 Andy Estes [Content Filtering] Determine navigation and content policy before continuing to filter a load https://bugs.webkit.org/show_bug.cgi?id=148506 Reviewed by Brady Eidson. Deleted parts of r188486 and r188851. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::convertMainResourceLoadToDownload): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): 2015-08-31 Chris Dumez Range.detach() / NodeIterator.detach() should be no-ops as per the latest DOM specification https://bugs.webkit.org/show_bug.cgi?id=148454 Reviewed by Ryosuke Niwa. Update Range API call sites to reflect changes. * WebView/WebImmediateActionController.mm: (dictionaryPopupInfoForRange): 2015-08-28 Myles C. Maxfield Migrate GraphicsContexts from pointers to references https://bugs.webkit.org/show_bug.cgi?id=148561 Reviewed by Tim Horton. * Misc/WebKitNSStringExtras.mm: (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::imageForCurrentSharingServicePickerItem): * WebView/WebFrame.mm: (-[WebFrame _drawRect:contentsOnly:]): 2015-08-28 Eric Carlson [Mac] Restructure WebMediaSessionManager for testing https://bugs.webkit.org/show_bug.cgi?id=148593 Reviewed by Jer Noble. * WebView/WebMediaPlaybackTargetPicker.mm: (WebMediaPlaybackTargetPicker::addPlaybackTargetPickerClient): Call WebMediaSessionManager::singleton, not WebMediaSessionManagerMac::singleton. (WebMediaPlaybackTargetPicker::removePlaybackTargetPickerClient): Ditto. (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Ditto. (WebMediaPlaybackTargetPicker::playbackTargetPickerClientStateDidChange): Ditto. (WebMediaPlaybackTargetPicker::setPlaybackTarget): Ditto. (WebMediaPlaybackTargetPicker::invalidate): Ditto. 2015-08-28 Jer Noble [iOS] Add WebKit/WebKit2 settings to control automatic data loading https://bugs.webkit.org/show_bug.cgi?id=148579 Reviewed by Anders Carlsson. Add a WebPreference to allow clients to control whether media is allowed to load automatically. Remove the (now unnecessary) WebFrame property to do the same. * WebView/WebFrame.mm: (-[WebFrame mediaDataLoadsAutomatically]): Deleted. (-[WebFrame setMediaDataLoadsAutomatically:]): Deleted. * WebView/WebFramePrivate.h: * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences mediaDataLoadsAutomatically]): (-[WebPreferences setMediaDataLoadsAutomatically:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2015-08-28 Beth Dakin Crash in WK1 when clicking on a PDF inside an iframe https://bugs.webkit.org/show_bug.cgi?id=148585 -and corresponding- rdar://problem/22165194 Reviewed by Tim Horton. Only handle WebHTMLViews. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]): (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): 2015-08-28 Jer Noble [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2. https://bugs.webkit.org/show_bug.cgi?id=147512 Reviewed by Anders Carlsson. Add a new preference, inlineMediaPlaybackRequiresPlaysInlineAttribute, which defaults to NO on iPad and YES on iPhone and iPod. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Default the value of WebKitAllowsInlineMediaPlaybackPreferenceKey to YES on iPad and NO on iPhone and iPod. (-[WebPreferences inlineMediaPlaybackRequiresPlaysInlineAttribute]): (-[WebPreferences setInlineMediaPlaybackRequiresPlaysInlineAttribute:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2015-08-28 Timothy Horton [Mac] Right-clicking on GIFs spins the UI process for a while https://bugs.webkit.org/show_bug.cgi?id=148566 Reviewed by Brady Eidson. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::shareMenuItem): Make an NSImage directly from the hit image if possible. 2015-08-27 Timothy Horton Factor out Lookup invocation https://bugs.webkit.org/show_bug.cgi?id=148509 Reviewed by Anders Carlsson. * WebView/DictionaryPopupInfo.h: Removed. Move to WebCore. * WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): DictionaryPopupInfo keeps a TextIndicatorData, not a TextIndicator. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _animationControllerForDataDetectedLink]): (dictionaryPopupInfoForRange): (-[WebImmediateActionController _animationControllerForText]): * WebView/WebView.mm: (-[WebView _prepareForDictionaryLookup]): (-[WebView _animationControllerForDictionaryLookupPopupInfo:]): (-[WebView _setTextIndicator:withLifetime:]): (-[WebView _showDictionaryLookupPopup:]): * WebView/WebViewInternal.h: Move a bunch of code to WebCore. Factor some that has to stay out into _prepareForDictionaryLookup. 2015-08-27 Brian Burg Web Inspector: FrontendChannel should know its own connection type https://bugs.webkit.org/show_bug.cgi?id=148482 Reviewed by Joseph Pecoraro. * WebCoreSupport/WebInspectorClient.h: add connectionType(). 2015-08-26 Beth Dakin REGRESSION: Safari navigates after a cancelled force click https://bugs.webkit.org/show_bug.cgi?id=148491 -and corresponding- rdar://problem/22394323 Reviewed by Tim Horton. Use the current stage to determine which type of cancel this is. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): 2015-08-26 Tim Horton Layout Test platform/mac/fast/events/content-inset-hit-testing-in-frame.html is flaky https://bugs.webkit.org/show_bug.cgi?id=148409 Reviewed by Beth Dakin. * WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView setContentInsets:]): Explicitly force our NSScrollView to lay out after updating content insets. We depend on this happening synchronously (specifically, we need our frame/bounds change callbacks to fire), because the layout which will happen subsequently needs up-to-date information in order to correctly a) enable scrollbars and then b) update the scroll position. 2015-08-23 Andy Estes [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled https://bugs.webkit.org/show_bug.cgi?id=147872 rdar://problem/22044000 Reviewed by Dan Bernstein. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): Set provisionalURL using the URL argument. 2015-08-23 Geoffrey Garen Unreviewed, rolling back in r188803. "Debugger's VM should never be null" https://bugs.webkit.org/show_bug.cgi?id=148341 http://trac.webkit.org/changeset/188803 * WebView/WebScriptDebugger.mm: (toWebFrame): (WebScriptDebugger::WebScriptDebugger): 2015-08-21 Commit Queue Unreviewed, rolling out r188792 and r188803. https://bugs.webkit.org/show_bug.cgi?id=148347 broke lots of tests, ggaren is going to investigate and reland (Requested by thorton on #webkit). Reverted changesets: "Unify code paths for manually deleting all code" https://bugs.webkit.org/show_bug.cgi?id=148280 http://trac.webkit.org/changeset/188792 "Debugger's VM should never be null" https://bugs.webkit.org/show_bug.cgi?id=148341 http://trac.webkit.org/changeset/188803 2015-08-21 Chris Dumez document.getElementsByTagName should return an HTMLCollection https://bugs.webkit.org/show_bug.cgi?id=110611 Reviewed by Darin Adler. * WebView/WebFrame.mm: (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Use .ptr() as createFragmentFromMarkup() now returns a Ref<> instead of a RefPtr<>. 2015-08-21 Anders Carlsson Get rid of uses of the old callOnMainThread function that takes a function ptr + context https://bugs.webkit.org/show_bug.cgi?id=148324 Reviewed by Tim Horton. * Storage/WebDatabaseManagerClient.mm: (DidModifyOriginData::dispatchToMainThread): (DidModifyOriginData::dispatchDidModifyOriginOnMainThread): Deleted. * Storage/WebStorageTrackerClient.h: * Storage/WebStorageTrackerClient.mm: (WebStorageTrackerClient::dispatchDidModifyOrigin): (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Deleted. 2015-08-19 Eric Carlson Remove ENABLE_WEBVTT_REGIONS https://bugs.webkit.org/show_bug.cgi?id=148184 Reviewed by Jer Noble. * Configurations/FeatureDefines.xcconfig: Remove ENABLE_WEBVTT_REGIONS. 2015-08-17 Filip Pizlo Replace all remaining uses of WTF::Mutex with WTF::Lock https://bugs.webkit.org/show_bug.cgi?id=148089 Reviewed by Geoffrey Garen. * Storage/WebDatabaseManager.mm: (transactionBackgroundTaskIdentifierLock): (+[WebDatabaseManager startBackgroundTask]): (+[WebDatabaseManager endBackgroundTask]): * WebView/WebView.mm: (-[WebView _synchronizeCustomFixedPositionLayoutRect]): (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]): (-[WebView _setCustomFixedPositionLayoutRect:]): (-[WebView _fetchCustomFixedPositionLayoutRect:]): * WebView/WebViewData.h: 2015-08-17 Jeff Miller Add a method to WebInspector to indicate whether the inspector is open https://bugs.webkit.org/show_bug.cgi?id=148087 Reviewed by Joseph Pecoraro. * WebInspector/WebInspector.h: Added open property. * WebInspector/WebInspector.mm: (-[WebInspector isOpen]): Added, returns YES if we have a frontend. 2015-08-13 Andy Estes [Cocoa] Downloads do not start if policy decision is made asynchronously https://bugs.webkit.org/show_bug.cgi?id=147985 Reviewed by Brady Eidson. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::convertMainResourceLoadToDownload): Started a new download if the main resource loader is not calling didReceiveResponse. 2015-08-13 Tim Horton Performing a Lookup on wrapped text puts the popover arrow in the wrong place (off to the right) https://bugs.webkit.org/show_bug.cgi?id=148012 Reviewed by Simon Fraser. * WebView/WebView.mm: (-[WebView _animationControllerForDictionaryLookupPopupInfo:]): (-[WebView _showDictionaryLookupPopup:]): Adopt the new SPI, handing it the first text rect, instead of having it guess where to put the popover. Also, null-check the TextIndicator. 2015-08-13 Tim Horton Refactor and improve TextIndicator to prepare for tests https://bugs.webkit.org/show_bug.cgi?id=147622 Reviewed by Simon Fraser. * WebView/WebFrame.mm: (-[WebFrame _rectsForRange:]): * WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[WebHTMLView quickLookWithEvent:]): * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController webView:didHandleScrollWheel:]): (-[WebImmediateActionController _cancelImmediateAction]): (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): (-[WebImmediateActionController _defaultAnimationController]): (-[WebImmediateActionController menuItemDidClose:]): (-[WebImmediateActionController _animationControllerForDataDetectedText]): (-[WebImmediateActionController _animationControllerForDataDetectedLink]): (dictionaryPopupInfoForRange): * WebView/WebView.mm: (-[WebView _animationControllerForDictionaryLookupPopupInfo:]): (-[WebView _setTextIndicator:]): (-[WebView _setTextIndicator:withLifetime:]): (-[WebView _clearTextIndicatorWithAnimation:]): (-[WebView _showDictionaryLookupPopup:]): (-[WebView _dictionaryLookupPopoverWillClose:]): * WebView/WebViewInternal.h: Adopt TextIndicatorOptions. Adjust to Range method renames. 2015-08-13 Geoffrey Garen Standardize on the phrase "delete code" https://bugs.webkit.org/show_bug.cgi?id=147984 Reviewed by Mark Lam. * WebView/WebView.mm: (+[WebView discardAllCompiledCode]): (+[WebView isCharacterSmartReplaceExempt:isPreviousCharacter:]): 2015-08-12 Anders Carlsson Use WTF::Optional in WindowFeatures https://bugs.webkit.org/show_bug.cgi?id=147956 Reviewed by Sam Weinig. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): 2015-08-13 Matthew Daiter Linking device query ability from WebKit2 to clients https://bugs.webkit.org/show_bug.cgi?id=147263 Reviewed by Jer Noble. * WebCoreSupport/WebUserMediaClient.mm: (-[WebUserMediaPolicyListener allow]): (-[WebUserMediaPolicyListener allowDeviceWithVideoUID:andAudioUID:]): 2015-08-10 Chris Dumez Align WebKit1's PageCache size with WebKit2's https://bugs.webkit.org/show_bug.cgi?id=147831 Reviewed by Sam Weinig. Align WebKit1's PageCache size with WebKit2's for consistency. Also, we have data showing that keeping more than 3 pages in the PageCache is not really useful. * WebView/WebView.mm: (+[WebView _setCacheModel:]): 2015-08-06 Anders Carlsson Crashes when calling swizzled setNeedsDisplayInRect: on heartbeat thread https://bugs.webkit.org/show_bug.cgi?id=147746 rdar://problem/18698271 Reviewed by Dan Bernstein. Back off if someone is calling our swizzled setNeedsDisplayInRect on a non-main thread. * WebView/WebHTMLView.mm: (setNeedsDisplayInRect): 2015-08-05 Filip Pizlo Unreviewed, roll out http://trac.webkit.org/changeset/187972. * Storage/WebDatabaseManager.mm: (transactionBackgroundTaskIdentifierLock): (+[WebDatabaseManager startBackgroundTask]): (+[WebDatabaseManager endBackgroundTask]): * WebView/WebView.mm: (-[WebView _synchronizeCustomFixedPositionLayoutRect]): (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]): (-[WebView _setCustomFixedPositionLayoutRect:]): (-[WebView _fetchCustomFixedPositionLayoutRect:]): * WebView/WebViewData.h: 2015-08-04 Filip Pizlo Rename Mutex to DeprecatedMutex https://bugs.webkit.org/show_bug.cgi?id=147675 Reviewed by Geoffrey Garen. * Storage/WebDatabaseManager.mm: (transactionBackgroundTaskIdentifierLock): (+[WebDatabaseManager startBackgroundTask]): (+[WebDatabaseManager endBackgroundTask]): * WebView/WebView.mm: (-[WebView _synchronizeCustomFixedPositionLayoutRect]): (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]): (-[WebView _setCustomFixedPositionLayoutRect:]): (-[WebView _fetchCustomFixedPositionLayoutRect:]): * WebView/WebViewData.h: 2015-08-04 Anders Carlsson Remove database thread pause code https://bugs.webkit.org/show_bug.cgi?id=147669 Reviewed by Daniel Bates. * Storage/WebDatabaseManager.mm: (WebKitSetWebDatabasePaused): Deleted. * Storage/WebDatabaseManagerInternal.h: 2015-08-04 Simon Fraser Fix the build. * Plugins/WebNetscapePluginStream.h: 2015-08-04 Anders Carlsson Get rid of ReasonForCallingAllowPlugins since it's not used anywhere https://bugs.webkit.org/show_bug.cgi?id=147648 Reviewed by Andreas Kling. * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getPluginInfo): * WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): 2015-08-04 Alexey Proskuryakov Implement NPAPI redirect handling https://bugs.webkit.org/show_bug.cgi?id=138675 rdar://problem/15779101 Patch by Jeffrey Pfau, updated and tweaked by me. Reviewed by Anders Carlsson. * Plugins/Hosted/HostedNetscapePluginStream.h: (WebKit::HostedNetscapePluginStream::streamID): * Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::didFinishLoading): (WebKit::HostedNetscapePluginStream::willSendRequest): (WebKit::HostedNetscapePluginStream::didReceiveResponse): * Plugins/WebNetscapePluginStream.h: * Plugins/WebNetscapePluginStream.mm: (WebNetscapePluginStream::stop): (WebNetscapePluginStream::willSendRequest): (WebNetscapePluginStream::didReceiveResponse): 2015-08-03 Myles C. Maxfield Unreviewed post-review feedback on r187797 The correct terminology is "registered" instead of "activated." * WebView/WebHTMLView.mm: (-[WebHTMLView _updateFontPanel]): 2015-08-03 Myles C. Maxfield Clean up casts between NSFont*s and CTFontRefs https://bugs.webkit.org/show_bug.cgi?id=147618 Reviewed by Mitz Pettel For toll free bridged types, it makes more sense to do a C-style cast, than jump through hoops for older compilers. * WebView/WebHTMLView.mm: (-[WebHTMLView _updateFontPanel]): 2015-08-03 Myles C. Maxfield Fix the Yosemite build after r187797 Unreviewed. * WebView/WebHTMLView.mm: (-[WebHTMLView _updateFontPanel]): 2015-08-03 Myles C. Maxfield REGRESSION(r184899): Crash when focusing an input element styled with a web font https://bugs.webkit.org/show_bug.cgi?id=147616 Reviewed by Dean Jackson. NSFontManager can't handle web fonts. We used to pass null to NSFontManager in this case, but r184899 changed that. * WebView/WebHTMLView.mm: (-[WebHTMLView _updateFontPanel]): 2015-07-31 Chris Dumez Drop dummy Timer callbacks https://bugs.webkit.org/show_bug.cgi?id=147516 Reviewed by Alexey Proskuryakov. Drop dummy Timer callbacks in the code base. A lot of Timer callbacks do nothing else beside calling a particular method. In such case, we can use the called method as Timer callback instead. * Plugins/WebNetscapePluginStream.h: * Plugins/WebNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream): (WebNetscapePluginStream::deliverDataTimerFired): Deleted. 2015-07-31 Brady Eidson REGRESSION (r174791): Returning a zombie NSImage from sharingService:transitionImageForShareItem:contentRect: and https://bugs.webkit.org/show_bug.cgi?id=147497 Reviewed by Tim Horton. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Don't return what is basically a temporary NSImage. Instead do a [[retain] autorelease] on it while still valid. 2015-07-29 Dean Jackson Don't use (Details) when exposing SPI https://bugs.webkit.org/show_bug.cgi?id=147426 Reviewed by Dan Bernstein. If we are declaring the interface without any implementation, we should use class extensions. * WebView/WebFrameView.mm: * WebView/WebPDFView.mm: 2015-07-29 Andy VanWagoner Implement basic types for ECMAScript Internationalization API https://bugs.webkit.org/show_bug.cgi?id=146926 Reviewed by Benjamin Poulain. * Configurations/FeatureDefines.xcconfig: Enabled INTL. 2015-07-28 Yusuke Suzuki [ES6] Add ENABLE_ES6_MODULES compile time flag with the default value "false" https://bugs.webkit.org/show_bug.cgi?id=147350 Reviewed by Sam Weinig. * Configurations/FeatureDefines.xcconfig: 2015-07-24 Yusuke Suzuki Remove runtime flags for symbols https://bugs.webkit.org/show_bug.cgi?id=147246 Reviewed by Alex Christensen. * WebView/WebPreferencesPrivate.h: 2015-07-24 Yusuke Suzuki Object.getOwnPropertySymbols on large list takes very long https://bugs.webkit.org/show_bug.cgi?id=146137 Reviewed by Mark Lam. * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::enumerate): 2015-07-23 Alex Christensen Remove compile and runtime flags for promises. https://bugs.webkit.org/show_bug.cgi?id=147244 Reviewed by Yusuke Suzuki. * Configurations/FeatureDefines.xcconfig: * WebView/WebPreferencesPrivate.h: 2015-07-22 Sukolsak Sakshuwong Add ENABLE_WEBASSEMBLY feature flag for WebAssembly https://bugs.webkit.org/show_bug.cgi?id=147212 Reviewed by Filip Pizlo. * Configurations/FeatureDefines.xcconfig: 2015-07-21 Joseph Pecoraro Web Inspector: [Mac] "Open Image In New Window" context menu item does nothing on an image https://bugs.webkit.org/show_bug.cgi?id=147175 Reviewed by Timothy Hatcher. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController webView:contextMenuItemsForElement:defaultMenuItems:]): Remove default context menus that won't work in the inspector page. 2015-07-21 Simon Fraser Add a logging channel for Layout, remove the LiveConnect channel https://bugs.webkit.org/show_bug.cgi?id=147170 Reviewed by Zalan Bujtas. Add a layout logging channel to WebCore, and remove the LiveConnect channel. * Misc/WebKitLogging.h: * Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _tryLoad]): Deleted. 2015-07-21 Brady Eidson Fix WebPreferences infinite recursion introduced in r186232. and https://bugs.webkit.org/show_bug.cgi?id=147149 Reviewed by Tim Horton. * WebView/WebPreferences.mm: (-[WebPreferences metaRefreshEnabled]): 2015-07-18 Gyuyoung Kim Reduce PassRefPtr in WebKit2 - 3 https://bugs.webkit.org/show_bug.cgi?id=146995 Reviewed by Daniel Bates. To remove PassRefPtr, this patch reduces use of PassRefPtr in WebKit2. Because some uses depend on WebCore, WebCore, WK1 ports are modified as well. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createDocumentLoader): 2015-07-17 Andy Estes [iOS] Further tighten the sandbox around pages fetched with Content-Disposition: attachment https://bugs.webkit.org/show_bug.cgi?id=147044 rdar://problem/21567820 Reviewed by Brady Eidson. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Enabled Content-Disposition: attachment sandbox on iOS. 2015-07-16 Joseph Pecoraro Web Inspector: [Mac] Save dialog not working when inspector is docked https://bugs.webkit.org/show_bug.cgi?id=146991 Reviewed by Sam Weinig. * WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::save): (-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]): When the window is nil (docked) use a non-window version of running the dialog. 2015-07-13 Simon Fraser [iOS] Expose contentsSizeRespectingOverflow() via WebView so UIWebView can use it https://bugs.webkit.org/show_bug.cgi?id=146924 WebKit part of rdar://problem/21802456 Reviewed by Tim Horton. Expose the FrameView's contentsSizeRespectingOverflow() via WebView, for use by UIKit. * WebView/WebView.mm: (-[WebView _contentsSizeRespectingOverflow]): * WebView/WebViewPrivate.h: 2015-07-14 Anders Carlsson Remove wkPopupMenu from WebCoreSystemInterface; it's not called from WebCore https://bugs.webkit.org/show_bug.cgi?id=146945 Reviewed by Tim Horton. * WebCoreSupport/PopupMenuMac.mm: (PopupMenuMac::show): * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Deleted. 2015-07-11 Nikita Vasilyev Web Inspector: Inspector should be able to be docked to the bottom of a narrow window https://bugs.webkit.org/show_bug.cgi?id=146871 Reviewed by Timothy Hatcher. * WebCoreSupport/WebInspectorClient.mm: 2015-07-07 Brady Eidson HTTP Auth cached after disabling private browsing/reset. and https://bugs.webkit.org/show_bug.cgi?id=146654 Reviewed by Tim Horton. * Misc/WebCache.h: * Misc/WebCache.mm: (+[WebCache clearCachedCredentials]): Clear the global CredentialStorage as well as the storages belonging to each main frame of each WebView. This method is for DRT. * Misc/WebDownload.mm: (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): * Plugins/WebBaseNetscapePluginView.mm: (WebKit::getAuthenticationInfo): * WebView/WebView.mm: (-[WebView _clearCredentials]): Clear the storage belonging to the current networking session of the main frame of this WebView. * WebView/WebViewInternal.h: 2015-07-04 Chris Dumez Drop RefPtr::clear() method https://bugs.webkit.org/show_bug.cgi?id=146556 Reviewed by Brady Eidson. Drop RefPtr::clear() method in favor of "= nullptr;" pattern. 2015-07-03 Dan Bernstein [Xcode] Update some build settings as recommended by Xcode 7 https://bugs.webkit.org/show_bug.cgi?id=146597 Reviewed by Sam Weinig. * Configurations/Base.xcconfig: Enabled CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_UNDECLARED_SELECTOR and GCC_NO_COMMON_BLOCKS. Removed GCC_MODEL_TUNING. 2015-07-02 Timothy Horton Fix the build. Rubber-stamped by Brady Eidson. * WebView/WebView.mm: (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Http, not HTTP, for settings generator reasons. 2015-07-02 Brady Eidson Add preference to disable all http-equiv. and https://bugs.webkit.org/show_bug.cgi?id=146553 Reviewed by Sam Weinig. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setMetaRefreshEnabled:]): Still expose this SPI, but have it affect the "httpEquivEnabled" setting. (-[WebPreferences metaRefreshEnabled]): Ditto. (-[WebPreferences setHTTPEquivEnabled:]): (-[WebPreferences httpEquivEnabled]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): (-[WebView _preferencesChanged:]): 2015-07-02 Timothy Horton iOS WebKitLegacy should match WebKit2's viewport behavior https://bugs.webkit.org/show_bug.cgi?id=146540 Reviewed by Dan Bernstein. A number of changes have been made to WebKit2's viewport behavior to make it possible to scale "responsive" sites that misbehave (lay out in a non-responsive way). * History/WebHistoryItem.mm: * History/WebHistoryItemPrivate.h: Add the plumbing required to implement these new behaviors in WebKit1. 2015-07-01 Dean Jackson Disable the experimental WebGL2 implementation https://bugs.webkit.org/show_bug.cgi?id=146526 Reviewed by Myles Maxfield. Add (and disable) an ENABLE_WEBGL2 flag. * Configurations/FeatureDefines.xcconfig: 2015-07-01 Simon Fraser Fix the iOS build. * WebCoreSupport/WebUserMediaClient.mm: (-[WebUserMediaPolicyListener denyOnlyThisRequest]): Remove ASSERT_NOT_REACHED, because it caused the compiler to warn about noreturn. 2015-07-01 Matthew Daiter Enable MEDIA_STREAM flag https://bugs.webkit.org/show_bug.cgi?id=145947 Reviewed by Eric Carlson. * Configurations/FeatureDefines.xcconfig: Added MEDIA_STREAM flag * WebCoreSupport/WebUserMediaClient.h: Changed signatures * WebCoreSupport/WebUserMediaClient.mm: Changed signatures (WebUserMediaClient::requestPermission): (WebUserMediaClient::cancelRequest): (-[WebUserMediaPolicyListener denyOnlyThisRequest]): (-[WebUserMediaPolicyListener shouldClearCache]): 2015-07-01 Brady Eidson REGRESSION (185319): Reproducible crash in WebHistoryItem launching FluidApp. and https://bugs.webkit.org/show_bug.cgi?id=146494 Reviewed by Darin Adler. * History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): Don’t reference members of a Vector that don’t exist. 2015-06-30 Andy VanWagoner Implement ECMAScript Internationalization API https://bugs.webkit.org/show_bug.cgi?id=90906 Reviewed by Benjamin Poulain. * Configurations/FeatureDefines.xcconfig: add ENABLE_INTL flag 2015-06-30 Simon Fraser Crash under _layoutForNodeHighlight: when inspecting espn.com https://bugs.webkit.org/show_bug.cgi?id=146422 Reviewed by Joseph Pecoraro. When inspecting espn.com, MobileSafari sometimes crashes, because highlight.quads is empty. I was not able to quickly determine why. Fix by bailing in this case. * WebInspector/WebNodeHighlightView.mm: (-[WebNodeHighlightView _layoutForNodeHighlight:parent:]): 2015-06-30 Anders Carlsson Remove the WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS ifdefs now that this is always true https://bugs.webkit.org/show_bug.cgi?id=146462 Reviewed by Dan Bernstein. * Misc/WebDownload.h: * WebView/WebFrameLoadDelegate.h: * WebView/WebPolicyDelegate.h: * WebView/WebResourceLoadDelegate.h: * WebView/WebUIDelegate.h: * WebView/WebView.h: * postprocess-headers.sh: 2015-06-29 Anders Carlsson Get rid of unused WKSI functions https://bugs.webkit.org/show_bug.cgi?id=146443 Reviewed by Tim Horton. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Deleted. 2015-06-29 Dean Jackson Temporarily disable PICTURE_SIZES https://bugs.webkit.org/show_bug.cgi?id=146435 Reviewed by Tim Horton. Temporarily disable PICTURE_SIZES because it causes problems with out of date polyfills. * Configurations/FeatureDefines.xcconfig: 2015-06-27 Ryosuke Niwa Font panel doesn't get updated when bolding text via cmd+b in Mail on OS X https://bugs.webkit.org/show_bug.cgi?id=146379 Reviewed by Darin Adler. Update the font panel when newly added EditorClient::didApplyStyle is called. Also set the font attributes in _updateFontPanel so that underline and strike through states will be reflected. * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldApplyStyle): (updateFontPanelIfNeeded): Extracted from respondToChangedContents. (WebEditorClient::didApplyStyle): Added. (WebEditorClient::respondToChangedContents): * WebView/WebHTMLView.mm: (-[WebHTMLView _updateFontPanel]): Sets font attributes as well as font. 2015-06-29 Dean Jackson Setting to enable/disable media controls sizing on page zoom https://bugs.webkit.org/show_bug.cgi?id=146423 Reviewed by Eric Carlson. Add a new setting "MediaControlsScaleWithPageZoom" that can disable the behaviour we currently implement on iOS, where the media controls attempt to remain at a fixed size independent of page zoom. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Initialize to false on iOS, true otherwise. (-[WebPreferences mediaControlsScaleWithPageZoom]): (-[WebPreferences setMediaControlsScaleWithPageZoom:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2015-06-29 Anders Carlsson Use DISPATCH_SOURCE_TYPE_MEMORYPRESSURE instead of DISPATCH_SOURCE_TYPE_MEMORYSTATUS https://bugs.webkit.org/show_bug.cgi?id=146413 Reviewed by Andreas Kling. Replace SPI with API. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Deleted. * WebView/WebView.mm: (+[WebView registerForMemoryNotifications]): 2015-06-28 Darin Adler [Mac] Remove redundant call to colorUsingColorSpaceName: https://bugs.webkit.org/show_bug.cgi?id=146397 Reviewed by Alexey Proskuryakov. * WebView/WebHTMLView.mm: (extractUnderlines): Remove call to the colorUsingColorSpaceName: method, since colorFromNSColor already calls it. No need to do it twice. 2015-06-26 Hyungwook Lee [Win] Implement WebViewGroup to support WebView::addxxxToGroup(). https://bugs.webkit.org/show_bug.cgi?id=145908 Reviewed by Brent Fulgham. Make WebViewGroup class sharing on Mac and Win port. * WebCoreSupport/WebViewGroup.h: Removed. * WebCoreSupport/WebViewGroup.mm: Removed. 2015-06-25 Joseph Pecoraro Web Inspector: Add Support for OS X Full Screen Mode https://bugs.webkit.org/show_bug.cgi?id=123510 Reviewed by Timothy Hatcher. * WebCoreSupport/WebInspectorClient.h: * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::didResizeMainFrame): (WebInspectorClient::windowFullScreenDidChange): (WebInspectorClient::canAttach): (WebInspectorFrontendClient::canAttach): (-[WebInspectorWindowController showWindow:]): Consolidate canAttach logic into canAttach functions. (-[WebInspectorWindowController window:]): Share the same full screen behavior as WebKit2. (-[WebInspectorWindowController windowDidEnterFullScreen:]): (-[WebInspectorWindowController windowDidExitFullScreen:]): Attach availability may have changed. 2015-06-25 Joseph Pecoraro [Mac] Web Inspector: Window dragging on toolbar should behave more like native window dragging https://bugs.webkit.org/show_bug.cgi?id=146324 Reviewed by Timothy Hatcher. * WebCoreSupport/WebInspectorClient.h: * WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::startWindowDrag): Start performing a window drag. 2015-06-23 Anders Carlsson Remove windowResizerRect code, nobody is using it anymore https://bugs.webkit.org/show_bug.cgi?id=146265 Reviewed by Beth Dakin. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::windowResizerRect): Deleted. 2015-06-22 Chris Dumez [WK1] WebAllowDenyPolicyListener.denyOnlyThisRequest() should not start a new permission request https://bugs.webkit.org/show_bug.cgi?id=146228 Reviewed by Daniel Bates. Call the new Geolocation::resetIsAllowed() API after denying the current request, instead of calling Geolocation::resetAllGeolocationPermission(). In addition to resetting m_allowGeolocation to Unknown, the latter would also start a new permission request. However, for WebAllowDenyPolicyListener.denyOnlyThisRequest(), we really only want to deny the current request and then reset m_allowGeolocation to Unknown so that permission is requested again later if the app requests a position again. The previous implementation meant that if the client application keeps calling WebAllowDenyPolicyListener.denyOnlyThisRequest(), we would end up in an infinite loop (requesting for permission), even though the application did not make any new geolocation requests. * WebCoreSupport/WebGeolocationClient.mm: (-[WebGeolocationPolicyListener denyOnlyThisRequest]): 2015-06-22 Anders Carlsson Delegates should be formal protocols https://bugs.webkit.org/show_bug.cgi?id=146222 rdar://problem/17380856 Reviewed by Dan Bernstein. Flip the switch on OS X and make delegates formal protocols. * postprocess-headers.sh: 2015-06-20 Tim Horton Deselection of text causes a noticeable jump on force touch machines https://bugs.webkit.org/show_bug.cgi?id=146173 Reviewed by Sam Weinig. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _animationControllerForText]): Get rid of TextIndicatorPresentationTransition::Crossfade. 2015-06-19 Brent Fulgham All calls of ImageBuffer::create should null check the return value https://bugs.webkit.org/show_bug.cgi?id=22132 Reviewed by Zalan Bujtas. ImageBuffer::create returns nullptr for a number of reasons, and should be expected to do so. We missed this check in a few places, resulting in crashes on some systems. Likewise, ImageBuffer::copyImage may return nullptr in normal use and should be checked. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Add nullptr check for copyImage. 2015-06-18 Jon Lee Update AVKit usage of pip https://bugs.webkit.org/show_bug.cgi?id=146095 Reviewed by Eric Carlson. - Rename preference key - Rename shouldAllowAlternateFullscreen to shouldAllowPictureInPictureMediaPlayback * WebCoreSupport/WebSystemInterface.mm: * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (-[WebPreferences allowsAlternateFullscreen]): Call allowsPictureInPictureMediaPlayback. (-[WebPreferences setAllowsAlternateFullscreen:]): (-[WebPreferences allowsPictureInPictureMediaPlayback]): Added. (-[WebPreferences setAllowsPictureInPictureMediaPlayback:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: 2015-06-18 Anders Carlsson Remove shouldInterruptJavaScript https://bugs.webkit.org/show_bug.cgi?id=146118 Reviewed by Antti Koivisto. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldInterruptJavaScript): Deleted. * WebView/WebUIDelegatePrivate.h: 2015-06-17 Alex Christensen [Content Extensions] Log blocked loads to the WebInspector console https://bugs.webkit.org/show_bug.cgi?id=146089 Reviewed by Joseph Pecoraro. * WebCoreSupport/WebChromeClient.mm: (stringForMessageSource): Added content blocker message source. 2015-06-17 Dan Bernstein Cleaned up the WebDownload.h framework header. Reviewed by Anders Carlsson. * Misc/WebDownload.h: Changed to use USE_APPLE_INTERNAL_SDK instead of __has_include. * postprocess-headers.sh: Define USE_APPLE_INTERNAL_SDK when postprocessing framework headers. 2015-06-17 Commit Queue Unreviewed, rolling out r185636. https://bugs.webkit.org/show_bug.cgi?id=146068 Caused many crashes on Windows (Requested by ap on #webkit). Reverted changeset: "[Win] Implement WebViewGroup to support WebView::addxxxToGroup()." https://bugs.webkit.org/show_bug.cgi?id=145908 http://trac.webkit.org/changeset/185636 2015-06-16 Hyungwook Lee [Win] Implement WebViewGroup to support WebView::addxxxToGroup(). https://bugs.webkit.org/show_bug.cgi?id=145908 Reviewed by Brent Fulgham. Make WebViewGroup class sharing on Mac and Win port. * WebCoreSupport/WebViewGroup.h: Removed. * WebCoreSupport/WebViewGroup.mm: Removed. 2015-06-13 Chris Dumez [WK2] API::Navigation objects are leaked on history navigation to HistoryItems in PageCache https://bugs.webkit.org/show_bug.cgi?id=145948 Reviewed by Darin Adler. Add empty implementation for new FrameLoaderClient::updatedCachedDocumentLoader(). * WebCoreSupport/WebFrameLoaderClient.h: 2015-06-11 Mark Lam WebCore::reportException() needs to be able to accept a raw thrown value in addition to Exception objects. https://bugs.webkit.org/show_bug.cgi?id=145872 Reviewed by Michael Saboff. * WebView/WebView.mm: (+[WebView _reportException:inContext:]): - Don't assume we have an Exception object. Let WebCore::reportException() take care of it. 2015-06-11 Jon Lee Update media controls JS and CSS to use picture-in-picture https://bugs.webkit.org/show_bug.cgi?id=145827 Reviewed by Dean Jackson. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Deleted GetMediaUIImageData. 2015-06-10 Jon Honeycutt Meta refresh preference is not respected on fast path WebView initialization Reviewed by Brady Eidson. * WebView/WebView.mm: (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Set the WebCore setting from the WebPreferences preference. 2015-06-09 Anders Carlsson Remove more unused SPI methods https://bugs.webkit.org/show_bug.cgi?id=145804 Reviewed by Simon Fraser. * Misc/WebNSURLRequestExtras.h: * Misc/WebNSURLRequestExtras.m: (-[NSURLRequest _web_HTTPReferrer]): Deleted. (-[NSURLRequest _web_HTTPContentType]): Deleted. (-[NSURLRequest _web_isConditionalRequest]): Deleted. 2015-06-08 Dan Bernstein Removed WebDragSourceActionAttachment from the WebDragSourceAction enum. Rubber-stamped by Anders Carlsson. * WebView/WebUIDelegate.h: Removed the value. It was added in r181760 and never used. 2015-06-08 Chris Dumez Access GCController instance via GCController::singleton() instead of a free function https://bugs.webkit.org/show_bug.cgi?id=145776 Reviewed by Darin Adler. Access GCController instance via GCController::singleton() instead of a free function as per coding style and for consistency with other singleton classes in the codebase. * Misc/WebCoreStatistics.mm: (+[WebCoreStatistics garbageCollectJavaScriptObjects]): (+[WebCoreStatistics garbageCollectJavaScriptObjectsOnAlternateThreadForDebugging:]): (+[WebCoreStatistics setJavaScriptGarbageCollectorTimerEnabled:]): * WebView/WebView.mm: (+[WebView garbageCollectNow]): (+[WebView discardAllCompiledCode]): (-[WebView _close]): 2015-06-08 Anders Carlsson Remove more unused Objective-C methods https://bugs.webkit.org/show_bug.cgi?id=145761 Reviewed by Geoffrey Garen. * Misc/WebNSImageExtras.h: * Misc/WebNSImageExtras.m: (-[NSImage _web_saveAndOpen]): Deleted. * Misc/WebNSViewExtras.h: * Misc/WebNSViewExtras.m: (-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]): Deleted. (-[NSView _web_convertRect:toView:]): Deleted. 2015-06-08 Anders Carlsson Try to fix the Mavericks build. * WebView/WebPDFView.mm: (removeUselessMenuItemSeparators): 2015-06-07 Anders Carlsson Remove WebNSArrayExtras https://bugs.webkit.org/show_bug.cgi?id=145747 Reviewed by Darin Adler. * History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): * Misc/WebNSArrayExtras.h: Removed. * Misc/WebNSArrayExtras.m: Removed. (-[NSArray _webkit_numberAtIndex:]): Deleted. (-[NSArray _webkit_stringAtIndex:]): Deleted. (-[NSMutableArray _webkit_removeUselessMenuItemSeparators]): Deleted. * WebView/WebPDFView.mm: (removeUselessMenuItemSeparators): (-[WebPDFView _menuItemsFromPDFKitForEvent:]): 2015-06-08 Dan Bernstein Fixed the build. * WebView/WebView.mm: (+[WebView _setCacheModel:]): 2015-06-07 Anders Carlsson Remove WebKitSystemBits https://bugs.webkit.org/show_bug.cgi?id=145746 Reviewed by Dan Bernstein. Fold WebVolumeFreeSize into its only caller and get rid of WebKitSystemBits. * Misc/WebKitSystemBits.h: Removed. * Misc/WebKitSystemBits.m: Removed. * WebView/WebPreferences.mm: * WebView/WebView.mm: (+[WebView _setCacheModel:]): 2015-06-07 Anders Carlsson Remove another SPI method that hasn't been used since Tiger https://bugs.webkit.org/show_bug.cgi?id=145745 Reviewed by Dan Bernstein. * WebView/WebView.mm: (-[WebView handleAuthenticationForResource:challenge:fromDataSource:]): Deleted. * WebView/WebViewPrivate.h: 2015-06-07 Anders Carlsson Remove another unused SPI method https://bugs.webkit.org/show_bug.cgi?id=145743 Reviewed by Dan Bernstein. * WebView/WebView.mm: (+[WebView _pointingHandCursor]): Deleted. * WebView/WebViewPrivate.h: 2015-06-07 Anders Carlsson Remove unused SPI https://bugs.webkit.org/show_bug.cgi?id=145742 Reviewed by Dan Bernstein. * WebCoreSupport/WebFrameNetworkingContext.h: * WebCoreSupport/WebFrameNetworkingContext.mm: (WebFrameNetworkingContext::clearPrivateBrowsingSessionCookieStorage): Deleted. * WebView/WebView.mm: (+[WebView _clearPrivateBrowsingSessionCookieStorage]): Deleted. * WebView/WebViewPrivate.h: 2015-06-06 Dan Bernstein Restored binary compatibility with shipping Safari. Suggested by Anders Carlsson. * Misc/WebKitNSStringExtras.mm: (-[NSString _webkit_fixedCarbonPOSIXPath]): Added an implementation that returns self, so that Safari doesn’t crash when trying to call this method. 2015-06-06 Dan Bernstein Fixed the build. * Plugins/WebBasePluginPackage.mm: 2015-06-06 Anders Carlsson Remove support from getting plug-in information from Carbon resources https://bugs.webkit.org/show_bug.cgi?id=145730 Reviewed by Dan Bernstein. No current plug-in versions use this feature, and both Chrome and Mozilla for Mac stopped looking at Carbon resources years ago. * Misc/WebKitNSStringExtras.h: * Misc/WebKitNSStringExtras.mm: (+[NSString _web_encodingForResource:]): Deleted. * Plugins/WebBasePluginPackage.mm: * Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _initWithPath:]): (-[WebNetscapePluginPackage stringForStringListID:andIndex:]): Deleted. (-[WebNetscapePluginPackage getPluginInfoFromResources]): Deleted. 2015-06-06 Anders Carlsson Remove now unused category methods https://bugs.webkit.org/show_bug.cgi?id=145729 Reviewed by Dan Bernstein. * Configurations/WebKitLegacy.xcconfig: * Misc/WebKitNSStringExtras.h: * Misc/WebKitNSStringExtras.mm: (-[NSString _webkit_fixedCarbonPOSIXPath]): Deleted. * Misc/WebNSFileManagerExtras.h: * Misc/WebNSFileManagerExtras.mm: (-[NSFileManager _webkit_startupVolumeName]): Deleted. 2015-06-06 Anders Carlsson Fix build. * WebKit.mac.exp: 2015-06-06 Anders Carlsson Stop using _webkit_fixedCarbonPOSIXPath in plug-in code https://bugs.webkit.org/show_bug.cgi?id=145728 Reviewed by Dan Bernstein. This code was put in place to support old plug-ins that would pass Carbon paths to NPAPI functions. WebKit2 never supported this and we've never had any problems so let's just get rid of it. * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::loadURL): * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]): 2015-06-06 Anders Carlsson Remove SPI that's no longer used https://bugs.webkit.org/show_bug.cgi?id=145727 Reviewed by Dan Bernstein. * Plugins/WebPluginsPrivate.h: Removed. * Plugins/WebPluginsPrivate.m: Removed. 2015-06-06 Anders Carlsson Only allow plug-ins to create custom MIME property lists on older versions of OS X https://bugs.webkit.org/show_bug.cgi?id=145726 Reviewed by Dan Bernstein. * Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage getPluginInfoFromPLists]): 2015-06-05 Mark Lam finally blocks should not set the exception stack trace when re-throwing the exception. https://bugs.webkit.org/show_bug.cgi?id=145525 Reviewed by Geoffrey Garen. * WebView/WebView.mm: (+[WebView _reportException:inContext:]): (WebKitInitializeApplicationCachePathIfNecessary): - Changed to use the new Exception object. 2015-06-03 Anders Carlsson Define WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS on iOS https://bugs.webkit.org/show_bug.cgi?id=145615 Part of rdar://problem/17380856. Reviewed by Dan Bernstein. * postprocess-headers.sh: 2015-06-02 Brady Eidson WebKit policy delegate should suggest if a navigation should be allowed to open URLs externally. rdar://problem/21025301 and https://bugs.webkit.org/show_bug.cgi?id=145280 Reviewed by Alex Christensen. * Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): * WebView/WebFrame.mm: (-[WebFrame loadRequest:]): (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): * WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): 2015-06-01 Anders Carlsson WAKScrollView.h cannot be imported standalone https://bugs.webkit.org/show_bug.cgi?id=145529 Reviewed by Dan Bernstein. Don't migrate WAKScrollView.h, it's not used outside of WebKit. * MigrateHeaders.make: 2015-05-29 Anders Carlsson Make the header replace rule more restrictive and get rid of a special case https://bugs.webkit.org/show_bug.cgi?id=145486 Reviewed by Ryosuke Niwa. We used to not run the header migration script on WAKScrollView.h since we had a rule that would transform "" which would get transformed to "WAKView ". Instead, check for the trailing slash as well and stop special-casing WAKScrollView.h. * MigrateHeaders.make: 2015-05-29 Anders Carlsson Get rid of WAKViewPrivate.h https://bugs.webkit.org/show_bug.cgi?id=145482 rdar://problem/21162149 Reviewed by Dan Bernstein. Remove WAKViewPrivate.h imports. * DefaultDelegates/WebDefaultUIDelegate.m: * MigrateHeaders.make: * Misc/WebKitNSStringExtras.mm: * Misc/WebNSViewExtras.m: * WebCoreSupport/WebFrameLoaderClient.mm: * WebView/WebFrame.mm: * WebView/WebFrameView.mm: * WebView/WebHTMLView.mm: 2015-05-29 Anders Carlsson WebResourceLoadDelegatePrivate.h cannot be imported standalone (missing WebNSInteger type) https://bugs.webkit.org/show_bug.cgi?id=145476 rdar://problem/21162400 Reviewed by Dan Bernstein. Change WebNSInteger to NSInteger. * WebView/WebResourceLoadDelegatePrivate.h: 2015-05-29 Anders Carlsson WebKit.framework installs or references Mac-only headers on iOS https://bugs.webkit.org/show_bug.cgi?id=145471 rdar://problem/21161459 Reviewed by Dan Bernstein. * History/WebURLsWithTitles.h: Add an #if !TARGET_OS_IPHONE guard around the entire header. * MigrateHeaders.make: Don't migrate the NPAPI headers on iOS. 2015-05-28 Matt Rajca Add ENABLE_MEDIA_SESSION feature flag (which is off by default). https://bugs.webkit.org/show_bug.cgi?id=145415 Reviewed by Eric Carlson. * Configurations/FeatureDefines.xcconfig: 2015-05-28 Jon Lee Build fix after r184946. * WebView/WebPreferences.mm: (-[WebPreferences allowsAirPlayForMediaPlayback]): (-[WebPreferences setAllowsAirPlayForMediaPlayback:]): 2015-05-19 Jon Honeycutt [iOS] When viewing an MJPEG stream as the main resource, only the first frame paints Reviewed by Darin Adler. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didReplaceMultipartContent): Call the FrameView's didReplaceMultipartContent(). 2015-05-22 Jon Lee Fix macros for wireless playback https://bugs.webkit.org/show_bug.cgi?id=145239 rdar://problem/21049541 Reviewed by Anders Carlsson. Encompass the logic within ENABLE(WIRELESS_TARGET_PLAYBACK). Update property name. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Wrap in ENABLE. (-[WebPreferences allowsAirPlayForMediaPlayback]): Ditto. (-[WebPreferences setAllowsAirPlayForMediaPlayback:]): Ditto. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Ditto. 2015-05-27 Dean Jackson img.currentSrc problem in strict mode with old picturefill https://bugs.webkit.org/show_bug.cgi?id=144095 Reviewed by Simon Fraser. Add a PICTURE_SIZES flag. * Configurations/FeatureDefines.xcconfig: 2015-05-26 Dan Bernstein Update build settings Reviewed by Anders Carlsson. * Configurations/DebugRelease.xcconfig: * Configurations/FeatureDefines.xcconfig: * Configurations/Version.xcconfig: 2015-05-25 Dan Bernstein ASSERT_MAIN_THREAD and DOM_ASSERT_MAIN_THREAD are unnecessary no-ops https://bugs.webkit.org/show_bug.cgi?id=145372 Reviewed by Sam Weinig. * Carbon/CarbonWindowAdapter.mm: (-[CarbonWindowAdapter finalize]): Removed use of ASSERT_MAIN_THREAD. * Configurations/Base.xcconfig: Removed DISABLE_THREAD_CHECK from DEBUG_DEFINES. * History/WebHistoryItem.mm: (-[WebHistoryItem URLString]): Removed use of ASSERT_MAIN_THREAD. (-[WebHistoryItem originalURLString]): Ditto. (-[WebHistoryItem title]): Ditto. (-[WebHistoryItem lastVisitedTimeInterval]): Ditto. (-[WebHistoryItem isEqual:]): Ditto. (-[WebHistoryItem description]): Ditto. (-[WebHistoryItem initFromDictionaryRepresentation:]): Ditto. (-[WebHistoryItem scrollPoint]): Ditto. * Misc/WebElementDictionary.mm: (-[WebElementDictionary finalize]): Ditto. * Misc/WebIconDatabase.mm: (-[WebIconDatabase iconForURL:withSize:cache:]): Ditto. (-[WebIconDatabase iconURLForURL:]): Ditto. (-[WebIconDatabase defaultIconWithSize:]): Ditto. (-[WebIconDatabase retainIconForURL:]): Ditto. (-[WebIconDatabase releaseIconForURL:]): Ditto. (+[WebIconDatabase delayDatabaseCleanup]): Ditto. (+[WebIconDatabase allowDatabaseCleanup]): Ditto. (-[WebIconDatabase removeAllIcons]): Ditto. (-[WebIconDatabase _iconForFileURL:withSize:]): Ditto. (webGetNSImage): Ditto. * Misc/WebKitLogging.h: Removed definition of ASSERT_MAIN_THREAD. * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView finalize]): Removed use of ASSERT_MAIN_THREAD. * Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage finalize]): Ditto. * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView finalize]): Ditto. * WebCoreSupport/WebEditorClient.mm: (-[WebUndoStep finalize]): Ditto. * WebView/WebDataSource.mm: (-[WebDataSource finalize]): Ditto. * WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate finalize]): Ditto. (-[WebHTMLView finalize]): Ditto. (-[WebHTMLView drawRect:]): Ditto. * WebView/WebViewData.mm: (-[WebViewPrivate finalize]): Ditto. 2015-05-23 Dan Bernstein Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED https://bugs.webkit.org/show_bug.cgi?id=145345 Reviewed by Sam Weinig. * Configurations/WebKitLegacy.xcconfig: Also changed to use $(inherited). 2015-05-24 Jeremy Jones Register media MIME types as supported by HTML view in WebKit1. https://bugs.webkit.org/show_bug.cgi?id=145356 Reviewed by Eric Carlson. WebDataSource and WebFrame view knew about suppotedImageMIMETypes and supportedNonImageMIMETypes, but not a third category supportedMediaMIMETypes. These are now included along-side supportedNonImageMIMETypes. * WebView/WebDataSource.mm: (+[WebDataSource _repTypesAllowImageTypeOmission:]): use supportedMediaMIMETypes. * WebView/WebFrameView.mm: (+[WebFrameView _viewTypesAllowImageTypeOmission:]): use supportedMediaMIMETypes. * WebView/WebHTMLRepresentation.h: declare -supportedMediaMIMETypes * WebView/WebHTMLRepresentation.mm: (+[WebHTMLRepresentation supportedMIMETypes]): include supportedMediaMIMETypes (+[WebHTMLRepresentation supportedMediaMIMETypes]): added * WebView/WebHTMLView.mm: (+[WebHTMLView supportedMediaMIMETypes]): added * WebView/WebHTMLViewPrivate.h: declare -supportedMediaMIMETypes 2015-05-22 Jon Lee Rename MediaPlaybackAllowsInline https://bugs.webkit.org/show_bug.cgi?id=145315 Reviewed by Eric Carlson. Our API uses allowsInlineMediaPlayback. Our symbols should reflect the same. * WebView/WebPreferenceKeysPrivate.h: Update the name of the key, but not its value, for backwards compatibility. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Update the symbol. (-[WebPreferences mediaPlaybackAllowsInline]): Ditto. This setting will not be renamed in a future patch. (-[WebPreferences setMediaPlaybackAllowsInline:]): Ditto. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Update the call to settings. 2015-05-22 Jon Lee Rename MediaPlaybackAllowsAirPlay https://bugs.webkit.org/show_bug.cgi?id=145316 Reviewed by Eric Carlson. In preparation for an API rename, update internal symbols from mediaPlaybackAllowsAirPlay to allowsAirPlayForMediaPlayback. * WebView/WebPreferenceKeysPrivate.h: Update the name but keep its value, for backwards compatibility. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Update to reference the new key name. (-[WebPreferences mediaPlaybackAllowsAirPlay]): Ditto. This API will not change in a future patch. (-[WebPreferences setMediaPlaybackAllowsAirPlay:]): Ditto. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Update the call to settings. 2015-05-22 Jon Lee Rename MediaPlaybackRequiresUserGesture https://bugs.webkit.org/show_bug.cgi?id=145314 Reviewed by Anders Carlsson. In preparation for an API rename, update internal symbols from mediaPlaybackRequiresUserGesture to requiresUserGestureForMediaPlayback. No changes are being made to the API in this patch. * WebView/WebPreferenceKeysPrivate.h: Update the name of the key, but not its value, for backwards compatibility. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Update the symbol. (-[WebPreferences mediaPlaybackRequiresUserGesture]): Ditto. This setting will not be renamed in a future patch. (-[WebPreferences setMediaPlaybackRequiresUserGesture:]): Ditto. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Update the call to settings. 2015-05-22 Tim Horton Remove action menu support https://bugs.webkit.org/show_bug.cgi?id=145305 Reviewed by Anders Carlsson. * Configurations/WebKitLegacy.xcconfig: * WebView/WebActionMenuController.h: Removed. * WebView/WebActionMenuController.mm: Removed. * WebView/WebHTMLView.mm: (-[WebHTMLView otherMouseDown:]): (-[WebHTMLView scrollWheel:scrollWheel:]): Deleted. (-[WebHTMLView mouseDown:mouseDown:]): Deleted. * WebView/WebUIDelegatePrivate.h: * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Deleted. (-[WebView _close]): Deleted. (-[WebView prepareForMenu:withEvent:]): Deleted. (-[WebView willOpenMenu:withEvent:]): Deleted. (-[WebView didCloseMenu:withEvent:]): Deleted. (-[WebView _actionMenuController]): Deleted. * WebView/WebViewData.h: * WebView/WebViewData.mm: (-[WebViewPrivate dealloc]): Deleted. * WebView/WebViewInternal.h: Remove everything, except some enums that clients still refer to. 2015-05-22 Brady Eidson Rework how the ResourceRequest user initiated property key is used. Followup to https://bugs.webkit.org/show_bug.cgi?id=145281 Reviewed by Dan Bernstein. * WebCoreSupport/WebSystemInterface.mm: (WKResourceRequestIsUserInitiatedKey): Deleted. (InitWebCoreSystemInterface): Deleted. 2015-05-21 Brady Eidson Add an "initiated by user gesture" flag to ResourceRequest. https://bugs.webkit.org/show_bug.cgi?id=145281 Reviewed by Alex Christensen. * WebCoreSupport/WebSystemInterface.mm: (WKResourceRequestIsUserInitiatedKey): (InitWebCoreSystemInterface): 2015-05-20 Anders Carlsson Fix build. * WebView/WebViewInternal.h: 2015-05-20 Alex Christensen Unreviewed build fix; LocalizedStrings.h is in WebCore. * WebView/WebActionMenuController.mm: 2015-05-20 Jer Noble Unreviewed build fix; WebActionMenuController.mm should directly include LocalizedStrings.h * WebView/WebActionMenuController.mm: 2015-05-19 Jer Noble Touching HTMLMediaElement.h or MediaPlayer.h causes a world rebuild. https://bugs.webkit.org/show_bug.cgi?id=145193 Reviewed by Eric Carlson. Use HTMLMediaElementEnums instead of HTMLMediaElement. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::enterVideoFullscreenForVideoElement): HTMLMediaElement -> HTMLMediaElementEnums. * WebView/WebView.mm: (-[WebView _enterVideoFullscreenForVideoElement:mode:]): Ditto. * WebView/WebViewInternal.h: 2015-05-19 Michael Saboff REGRESSION(183787): JIT is enabled for all builds https://bugs.webkit.org/show_bug.cgi?id=145179 Reviewed by Geoffrey Garen. Eliminated the setting of ENABLE_JIT, as wtf/Platform.h has appropriate logic to set it depending on OS and CPU type. * Configurations/FeatureDefines.xcconfig: 2015-05-19 Brady Eidson X-Frame-Options headers not respected when loading from application cache. and https://bugs.webkit.org/show_bug.cgi?id=131800 Reviewed by Alexey Proskuryakov. * WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): 2015-05-18 Skachkov Alexandr [ES6] Arrow function syntax. Feature flag for arrow function https://bugs.webkit.org/show_bug.cgi?id=145108 Reviewed by Ryosuke Niwa. Added feature flag ENABLE_ES6_ARROWFUNCTION_SYNTAX for arrow function * Configurations/FeatureDefines.xcconfig: 2015-05-15 Jeremy Jones Limit alternate fullscreen with linked on or after. https://bugs.webkit.org/show_bug.cgi?id=144894 Reviewed by Dean Jackson. * WebView/WebView.mm: (shouldAllowAlternateFullscreen): Added. (-[WebView _preferencesChanged:]): 2015-05-12 Simon Fraser Turn antialiased font dilation off by default https://bugs.webkit.org/show_bug.cgi?id=144940 rdar://problem/20923031 Reviewed by Sam Weinig. Turn antialised font dilation off by default. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): 2015-05-11 Daniel Bates [iOS] Close all open databases in expiration handler of process assertion https://bugs.webkit.org/show_bug.cgi?id=144661 Reviewed by Darin Adler. For Legacy WebKit, close all open databases when the process assertion expiration handler is called. * Storage/WebDatabaseManager.mm: (+[WebDatabaseManager startBackgroundTask]): Call DatabaseTracker::tracker().closeAllDatabases() in the expiration handler to close all open databases. As a side effect of closing a database all in-progress database transactions are interrupted. 2015-05-10 Sungmann Cho Get rid of the public item accessors in BackForwardClient https://bugs.webkit.org/show_bug.cgi?id=144827 Reviewed by Darin Adler. Remove backItem(), currentItem(), and forwardItem() from BackForwardClient. We can still use these functionalities through BackForwardController. No new tests, no behavior change. * WebView/WebView.mm: (-[WebView _loadBackForwardListFromOtherView:]): 2015-05-09 Yoav Weiss Remove the PICTURE_SIZES build flag https://bugs.webkit.org/show_bug.cgi?id=144679 Reviewed by Benjamin Poulain. Removed the PICTURE_SIZES build time flag. * Configurations/FeatureDefines.xcconfig: 2015-05-08 Myles C. Maxfield Remove convenience constructors for TextRun https://bugs.webkit.org/show_bug.cgi?id=144752 These convenience constructors are unnecessary. Moving the code that makes the StringView back to the call site will also help us make things more elegant in future refactoring. Reviewed by Darin Adler. No new tests because there is no behavior change. * Misc/WebKitNSStringExtras.mm: (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): (-[NSString _web_widthWithFont:]): 2015-05-08 Commit Queue Unreviewed, rolling out r183996. https://bugs.webkit.org/show_bug.cgi?id=144806 ASan detected use-after free (Requested by ap on #webkit). Reverted changeset: "Remove convenience constructors for TextRun" https://bugs.webkit.org/show_bug.cgi?id=144752 http://trac.webkit.org/changeset/183996 2015-05-08 Myles C. Maxfield Remove convenience constructors for TextRun https://bugs.webkit.org/show_bug.cgi?id=144752 These convenience constructors are unnecessary. Moving the code that makes the StringView back to the call site will also help us make things more elegant in future refactoring. Reviewed by Darin Adler. No new tests because there is no behavior change. * Misc/WebKitNSStringExtras.mm: (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): (-[NSString _web_widthWithFont:]): 2015-05-07 Anders Carlsson Build fixes. * Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]): * WebView/WebHTMLView.mm: (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]): (-[WebHTMLView _selectionStartFontAttributesAsRTF]): * WebView/WebPDFView.mm: (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]): Pass empty arrays and dictionaries instead of nil. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Use the regular init method. 2015-05-07 Said Abou-Hallawa Fix iPhone 6 iOS simulator Build. following http://trac.webkit.org/changeset/183954. Reviewed by Daniel Bates. * WebView/WebHTMLView.mm: (-[WebHTMLView pressureChangeWithEvent:]): 2015-05-07 Timothy Horton Occasional null deref in WebImmediateActionController https://bugs.webkit.org/show_bug.cgi?id=144772 Reviewed by Beth Dakin. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _defaultAnimationController]): (-[WebImmediateActionController _animationControllerForDataDetectedText]): (-[WebImmediateActionController _animationControllerForDataDetectedLink]): Null-check TextIndicators before dereferencing. 2015-05-07 Beth Dakin New force-related DOM events should fire in WK1 views https://bugs.webkit.org/show_bug.cgi?id=144663 -and corresponding- rdar://problem/20281886 Reviewed by Sam Weinig. Pass the lastPressureEvent to WebCore. * WebView/WebHTMLView.mm: (-[WebHTMLView _updateMouseoverWithEvent:]): (-[WebHTMLView rightMouseUp:]): (-[WebHTMLView menuForEvent:]): (-[WebHTMLView acceptsFirstMouse:]): (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): (-[WebHTMLView mouseDown:mouseDown:]): (-[WebHTMLView mouseDragged:]): (-[WebHTMLView mouseUp:mouseUp:]): New NSRespnder method for pressure changes. (-[WebHTMLView pressureChangeWithEvent:]): New BOOL _contentPreventsDefault tracks whether the HitTestResult prevented the default action. Get rid of willHandleMouseDown; now that the gesture recognizer sets delaysPrimaryMouseButtonEvents to NO, we don’t need this. * WebView/WebImmediateActionController.h: * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _clearImmediateActionState]): Set all of the immediateActionStages on EventHandler. This is critical to keep link navigation happening at the right time now that delaysPrimaryMouseButtonEvents is set to NO. (-[WebImmediateActionController performHitTestAtPoint:]): (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Use a dummy animation controller if the content prevents default. (-[WebImmediateActionController _defaultAnimationController]): (-[WebImmediateActionController _updateImmediateActionItem]): (-[WebImmediateActionController webView:willHandleMouseDown:]): Deleted. Set delaysPrimaryMouseButtonEvents to NO so that we get existing mouse events when we expect to. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Cache the most recent pressure event so that we can send it to WebCore for all of the mouse events. (-[WebView _pressureEvent]): (-[WebView _setPressureEvent:]): * WebView/WebViewData.h: * WebView/WebViewData.mm: (-[WebViewPrivate dealloc]): * WebView/WebViewInternal.h: 2015-05-05 Myles C. Maxfield Revert "Introducing the Platform Abstraction Layer (PAL)" https://bugs.webkit.org/show_bug.cgi?id=144751 Unreviewed. PAL should be a new target inside WebCore, rather than a top-level folder. * Configurations/FeatureDefines.xcconfig: Updated 2015-05-07 Dan Bernstein [Xcode] Remove usage of AspenFamily.xcconfig in Source/ https://bugs.webkit.org/show_bug.cgi?id=144727 Reviewed by Darin Adler. * Configurations/Base.xcconfig: Don’t include AspenFamily.xcconfig. * Configurations/WebKitLegacy.xcconfig: Define INSTALL_PATH in terms of INSTALL_PATH_PREFIX and INSTALL_PATH_ACTUAL, and define INSTALL_PATH_PREFIX for the iOS 8.x Simulator. 2015-04-02 Myles C. Maxfield Introducing the Platform Abstraction Layer (PAL) https://bugs.webkit.org/show_bug.cgi?id=143358 Reviewed by Simon Fraser. * Configurations/FeatureDefines.xcconfig: Updated 2015-05-06 Antti Koivisto REGRESSION (r183467): Unable to start downloads in private browsing mode https://bugs.webkit.org/show_bug.cgi?id=144533 Reviewed by Darin Adler. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillSendRequest): Use updateFromDelegatePreservingOldProperties (like WK2) instead of doing the same thing manually. 2015-05-06 Ryosuke Niwa Toggling underline on font panel removes strike through https://bugs.webkit.org/show_bug.cgi?id=144670 Reviewed by Darin Adler. Use setStrikeThroughChange and setUnderlineChange added in r183770 to toggle underline and strike through. * WebView/WebHTMLView.mm: (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]): (-[WebHTMLView _styleForAttributeChange:]): (-[WebHTMLView changeAttributes:]): 2015-05-04 Ryosuke Niwa Toggling underline or strike through affects each other https://bugs.webkit.org/show_bug.cgi?id=27818 Reviewed by Darin Adler. * WebView/WebFrame.mm: (-[WebFrame _setTypingStyle:withUndoAction:]): 2015-05-01 Martin Robinson USE(...) macro should expect unprefixed variables https://bugs.webkit.org/show_bug.cgi?id=144454 Reviewed by Daniel Bates. * Misc/WebDownload.h: Replace all occurrences WTF_USE with USE. 2015-05-01 Brady Eidson Add API to disable meta refreshes. and https://bugs.webkit.org/show_bug.cgi?id=144269 Reviewed by Alexey Proskuryakov. Add a preference to enable/disable meta refreshes, enabled by default. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setMetaRefreshEnabled:]): (-[WebPreferences metaRefreshEnabled]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2015-04-30 Jon Davis Web Inspector: console should show an icon for console.info() messages https://bugs.webkit.org/show_bug.cgi?id=18530 Reviewed by Timothy Hatcher. * WebCoreSupport/WebChromeClient.mm: (stringForMessageLevel): * WebView/WebUIDelegatePrivate.h: 2015-04-29 Myles C. Maxfield [OS X] Use CTFontCreateForCSS instead of doing font search ourselves https://bugs.webkit.org/show_bug.cgi?id=132159 Reviewed by Darin Adler. Add SPI to set the font whitelist. * WebView/WebView.mm: (+[WebView _setFontWhitelist:]): * WebView/WebViewPrivate.h: 2015-04-28 Timothy Horton [TextIndicator] Yellow highlight takes too long to fade out on scroll https://bugs.webkit.org/show_bug.cgi?id=144358 Reviewed by Beth Dakin. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _showTextIndicator]): * WebView/WebHTMLView.mm: (-[WebHTMLView quickLookWithEvent:]): * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _defaultAnimationController]): (-[WebImmediateActionController _animationControllerForDataDetectedText]): (-[WebImmediateActionController _animationControllerForDataDetectedLink]): Pull _clearTextIndicatorWithAnimation out, make it avoid using a dismissal animation if we're called from didHandleScrollWheel. * WebView/WebView.mm: (-[WebView _animationControllerForDictionaryLookupPopupInfo:]): (-[WebView _setTextIndicator:]): (-[WebView _setTextIndicator:withLifetime:]): (-[WebView _clearTextIndicator]): (-[WebView _showDictionaryLookupPopup:]): (-[WebView _dictionaryLookupPopoverWillClose:]): (-[WebView _setTextIndicator:fadeOut:]): Deleted. * WebView/WebViewInternal.h: Make _setTextIndicator take a reference. Add a variant of _setTextIndicator that takes a Lifetime. Make _clearTextIndicatorWithAnimation take a DismissalAnimation. 2015-04-28 Michael Catanzaro Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT https://bugs.webkit.org/show_bug.cgi?id=144304 Reviewed by Geoffrey Garen. Define ENABLE_JIT, enabled by default, instead of ENABLE_LLINT_C_LOOP, disabled by default. * Configurations/FeatureDefines.xcconfig: 2015-04-28 Commit Queue Unreviewed, rolling out r183514. https://bugs.webkit.org/show_bug.cgi?id=144359 It broke cloop test bots (Requested by mcatanzaro on #webkit). Reverted changeset: "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT" https://bugs.webkit.org/show_bug.cgi?id=144304 http://trac.webkit.org/changeset/183514 2015-04-28 Michael Catanzaro Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT https://bugs.webkit.org/show_bug.cgi?id=144304 Reviewed by Geoffrey Garen. Define ENABLE_JIT, enabled by default, instead of ENABLE_LLINT_C_LOOP, disabled by default. * Configurations/FeatureDefines.xcconfig: 2015-04-28 Joseph Pecoraro Fix common typo "targetting" => "targeting" https://bugs.webkit.org/show_bug.cgi?id=144349 Reviewed by Daniel Bates. * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::loadRequest): * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): * WebView/WebPolicyDelegate.h: 2015-04-28 Brady Eidson Consolidate most "frame load" arguments into FrameLoadRequest. https://bugs.webkit.org/show_bug.cgi?id=144276 Reviewed by Alexey Proskuryakov. * WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): 2015-04-27 Dan Bernstein REGRESSION (r178753): All legacy framework headers are missing availability annotations https://bugs.webkit.org/show_bug.cgi?id=144311 Reviewed by Adele Peterson. * postprocess-headers.sh: Changed “macsox” to “macosx”. 2015-04-27 Brady Eidson Make 'enum NavigationType' be an enum class https://bugs.webkit.org/show_bug.cgi?id=144270 Reviewed by Alex Christensen. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary): 2015-04-27 Brent Fulgham REGRESSION(r182879): Images and video can no longer be downloaded https://bugs.webkit.org/show_bug.cgi?id=144267 Reviewed by Simon Fraser. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _createActionMenuItemForTag:]): Check for "!WebCore::protocolIs(..., "file")" for image and media downloads. 2015-04-26 Yusuke Suzuki [ES6] Implement ES6 template literals https://bugs.webkit.org/show_bug.cgi?id=142691 Reviewed by Darin Adler. Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag. * Configurations/FeatureDefines.xcconfig: 2015-04-26 Doug Russell AX: richer text change notifications (142719) https://bugs.webkit.org/show_bug.cgi?id=142719 Reviewed by Darin Adler. Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes. Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields. * WebCoreSupport/WebEditorClient.mm: (undoNameForEditAction): 2015-04-24 Timothy Hatcher Web Inspector: Remove native window dock controls https://bugs.webkit.org/show_bug.cgi?id=144184 Reviewed by Joseph Pecoraro. * Resources/Dock.pdf: Removed. * Resources/DockLegacy.pdf: Removed. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController window]): (-[WebInspectorWindowController setDockingUnavailable:]): 2015-04-25 Martin Robinson Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS https://bugs.webkit.org/show_bug.cgi?id=144182 Reviewed by Simon Fraser. * Configurations/FeatureDefines.xcconfig: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS. 2015-04-24 Commit Queue Unreviewed, rolling out r183266. https://bugs.webkit.org/show_bug.cgi?id=144164 Broke 32-bit build and a test. (Requested by ap on #webkit). Reverted changeset: "AX: richer text change notifications (142719)" https://bugs.webkit.org/show_bug.cgi?id=142719 http://trac.webkit.org/changeset/183266 2015-04-24 Myles C. Maxfield [Cocoa] Start cleaning up FontPlatformData https://bugs.webkit.org/show_bug.cgi?id=144133 Reviewed by Enrica Casucci. Receive casts which have been hoisted from the deleted FontPlatformData constructor. * Misc/WebKitNSStringExtras.mm: (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Receive cast which has been hoisted from the deleted FontPlatformData constructor. (-[NSString _web_widthWithFont:]): Ditto. * Misc/WebStringTruncator.mm: (fontFromNSFont): Ditto. 2015-04-24 Doug Russell AX: richer text change notifications (142719) https://bugs.webkit.org/show_bug.cgi?id=142719 Reviewed by Darin Adler. Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes. Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields. * WebCoreSupport/WebEditorClient.mm: (undoNameForEditAction): 2015-04-23 Jer Noble [Mac] Disable QTKit by default on future OS X. https://bugs.webkit.org/show_bug.cgi?id=144082 Reviewed by Darin Adler. Default WebKitQTKitEnabledPreferenceKey to NO. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): 2015-04-23 Andreas Kling There should only be one way to get the system memory size. Reviewed by Antti Koivisto. * Misc/WebKitSystemBits.h: * Misc/WebKitSystemBits.m: (WebMemorySize): Deleted. * WebView/WebView.mm: (+[WebView _setCacheModel:]): (roundUpToPowerOf2): Deleted. 2015-04-22 Darin Adler Remove OwnPtr and PassOwnPtr use from WebKit/cf, WebKit/mac, and WebKit2 https://bugs.webkit.org/show_bug.cgi?id=143943 Reviewed by Anders Carlsson. * Plugins/Hosted/ProxyInstance.h: Removed unneeded include. * Plugins/WebBaseNetscapePluginView.h: Ditto. * Plugins/WebNetscapePluginEventHandler.h: Use unique_ptr instead of PassOwnPtr for the create function. Also tweaked formatting and removed unneeded forward declaration of CGRect. * Plugins/WebNetscapePluginEventHandler.mm: (WebNetscapePluginEventHandler::create): Changed to use unique_ptr and make_unique. * Plugins/WebNetscapePluginView.h: Use unique_ptr instead of OwnPtr for the _eventHandler field. * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView destroyPlugin]): Changed code to work with unique_ptr. * WebCoreSupport/WebUserMediaClient.mm: Removed unneeded include. * WebView/WebDeviceOrientationProviderMock.mm: Changed to use make_unique. * WebView/WebDeviceOrientationProviderMockInternal.h: Changed to use unique_ptr. * WebView/WebFrame.mm: (vectorForDictationPhrasesArray): Changed to return Vector> and not a PassOwnPtr. Also rewrote to be much simpler, although there is still a pre-existing problem here where this could put empty vectors into the result, and I'm pretty sure the client never expects any of the Vector to be empty. (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Rewrote logic to involve WebCore types a bit less; old code was round tripping things through WebCore::URL for no obvious reason. * WebView/WebFrameInternal.h: Changed vectorForDictationPhrasesArray to return a Vector> and not a PassOwnPtr. * WebView/WebFullScreenController.h: Removed unneeded include. * WebView/WebViewData.h: Changed m_alternativeTextUIController to be a m_alternativeTextUIController. * WebView/WebViewData.mm: (-[WebViewPrivate init]): Use make_unique to initialize m_alternativeTextUIController. 2015-04-22 Brent Fulgham VisibleSelection should only accept Range by reference https://bugs.webkit.org/show_bug.cgi?id=144047 Reviewed by Tim Horton. Update all uses of VisibleSelection to pass a Range reference instead of a Range pointer. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::imageForCurrentSharingServicePickerItem): * WebView/WebFrame.mm: (-[WebFrame _selectNSRange:]): 2015-04-22 Eric Carlson [Mac] Device picker menu is positioned incorrectly in WK1 https://bugs.webkit.org/show_bug.cgi?id=144049 Reviewed by Dean Jackson. * WebView/WebView.mm: (-[WebView _showPlaybackTargetPicker:location:hasVideo:]): Mouse location is already in window coordinates so don't call convertRect:toView:nil. 2015-04-21 Brent Fulgham Extend action menus to support PDF https://bugs.webkit.org/show_bug.cgi?id=143895 Reviewed by Tim Horton. Prevent a crash when someone attempts to invoke an action menu on a PDF hosted in a WK1 view. * WebView/WebActionMenuController.mm: (-[WebActionMenuController performHitTestAtPoint:]): Handle WebPDFView as well as the WebHTMLView case. * WebView/WebDocument.h: * WebView/WebHTMLView.h: * WebView/WebHTMLView.mm: (-[WebHTMLView _frame]): * WebView/WebHTMLViewInternal.h: * WebView/WebPDFView.h: * WebView/WebPDFView.mm: (-[WebPDFView _frame]): Added. 2015-04-22 Eric Carlson Unreviewed post-review clean up after r183096. * WebView/WebMediaPlaybackTargetPicker.h: 2015-04-21 Eric Carlson [Mac] Use one playback target for all web processes https://bugs.webkit.org/show_bug.cgi?id=144009 Reviewed by Tim Horton. Update to use WebMediaSessionManager for playback target management. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::addPlaybackTargetPickerClient): (WebChromeClient::removePlaybackTargetPickerClient): (WebChromeClient::showPlaybackTargetPicker): (WebChromeClient::playbackTargetPickerClientStateDidChange): (WebChromeClient::startingMonitoringPlaybackTargets): Deleted. (WebChromeClient::stopMonitoringPlaybackTargets): Deleted. * WebView/WebMediaPlaybackTargetPicker.h: * WebView/WebMediaPlaybackTargetPicker.mm: (WebMediaPlaybackTargetPicker::addPlaybackTargetPickerClient): (WebMediaPlaybackTargetPicker::removePlaybackTargetPickerClient): (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): (WebMediaPlaybackTargetPicker::playbackTargetPickerClientStateDidChange): (WebMediaPlaybackTargetPicker::setPlaybackTarget): (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange): (WebMediaPlaybackTargetPicker::setShouldPlayToPlaybackTarget): (WebMediaPlaybackTargetPicker::invalidate): (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): Deleted. (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): Deleted. (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): Deleted. (WebMediaPlaybackTargetPicker::targetPicker): Deleted. * WebView/WebView.mm: (-[WebView _addPlaybackTargetPickerClient:]): (-[WebView _removePlaybackTargetPickerClient:]): (-[WebView _showPlaybackTargetPicker:location:hasVideo:]): (-[WebView _playbackTargetPickerClientStateDidChange:state:]): (-[WebView _showPlaybackTargetPicker:hasVideo:]): Deleted. (-[WebView _startingMonitoringPlaybackTargets]): Deleted. (-[WebView _stopMonitoringPlaybackTargets]): Deleted. * WebView/WebViewInternal.h: 2015-04-20 Alexey Proskuryakov Disable mixed content blocking for existing WebKit1 clients https://bugs.webkit.org/show_bug.cgi?id=143955 rdar://problem/20177186 Reviewed by Oliver Hunt. * Misc/WebKitVersionChecks.h: * WebView/WebView.mm: (shouldAllowInsecureContent): (-[WebView _preferencesChanged:]): 2015-04-20 Tim Horton Implement immediate action support for tel: and mailto: URLs https://bugs.webkit.org/show_bug.cgi?id=143916 Reviewed by Darin Adler. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _defaultAnimationController]): (-[WebImmediateActionController _animationControllerForDataDetectedText]): (-[WebImmediateActionController _animationControllerForDataDetectedLink]): (-[WebImmediateActionController _menuItemForDataDetectedText]): Deleted. * WebView/WebUIDelegatePrivate.h: Add _animationControllerForDataDetectedLink and use it when building immediate actions for tel: and mailto: links. 2015-04-17 Daniel Bates REGRESSION: SVG does not support link dragging https://bugs.webkit.org/show_bug.cgi?id=141597 Reviewed by Darin Adler. Write -[WebElementDictionary _isLiveLink] in terms of WebCore::isDraggableLink(). * Misc/WebElementDictionary.mm: (-[WebElementDictionary _isLiveLink]): 2015-04-16 Sam Weinig Expose JavaScriptMarkupEnabled preference for WebKit1 https://bugs.webkit.org/show_bug.cgi?id=143855 Reviewed by Dan Bernstein. * WebView/WebPreferenceKeysPrivate.h: Add new key, WebKitJavaScriptMarkupEnabledPreferenceKey * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Initialize WebKitJavaScriptMarkupEnabledPreferenceKey to YES. (-[WebPreferences isJavaScriptMarkupEnabled]): (-[WebPreferences setJavaScriptMarkupEnabled:]): Implement getter/setter. * WebView/WebPreferencesPrivate.h: Add new property, javaScriptMarkupEnabled. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Map the new preference to WebCore's scriptMarkupEnabled setting. 2015-04-15 Brent Fulgham [Mac] Disable "Save to Downloads" option for local files https://bugs.webkit.org/show_bug.cgi?id=143794 Reviewed by Tim Horton. Disable the Image and Media download options if the download target is a local file. We can only download web resources; anything else is actually a no-op. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _defaultMenuItemsForImage]): (-[WebActionMenuController _defaultMenuItemsForVideo]): 2015-04-15 Alex Christensen Progress towards CMake on Mac. https://bugs.webkit.org/show_bug.cgi?id=143785 Reviewed by Csaba Osztrogonác. * WebView/WebPDFDocumentExtras.mm: * WebView/WebPDFView.mm: 2015-04-13 Jer Noble [Fullscreen] ChromeClient::exitVideoFullscreen() should take a pointer to a HTMLVideoElement. https://bugs.webkit.org/show_bug.cgi?id=143674 Reviewed by Darin Adler. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::enterVideoFullscreenForVideoElement): Takes a reference. (WebChromeClient::exitVideoFullscreenForVideoElement): Renamed from exitVideoFullscreen(). (WebChromeClient::exitVideoFullscreen): Deleted. 2015-04-14 Simon Fraser Re-enable custom dilation for antialiased fonts https://bugs.webkit.org/show_bug.cgi?id=143738 Reviewed by Tim Horton. Enabling custom dilation for antialised fonts broke layout tests, so re-land it, but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding a private WebKit pref. This pref defaults to YES, enabling the feature by default in WK1 as we do for WK2. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setAntialiasedFontDilationEnabled:]): (-[WebPreferences antialiasedFontDilationEnabled]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2015-04-13 Brady Eidson Share sheets from Share menus appear outside the browser window. and https://bugs.webkit.org/show_bug.cgi?id=143620 Reviewed by Darin Adler. Refactor existing Sharing Service Picker code to also be used for the Share menu NSMenuItem. * Misc/WebSharingServicePickerController.h: (WebSharingServicePickerClient::webView): * Misc/WebSharingServicePickerController.mm: (WebSharingServicePickerClient::WebSharingServicePickerClient): (WebSharingServicePickerClient::sharingServicePickerWillBeDestroyed): (WebSharingServicePickerClient::pageForSharingServicePicker): (WebSharingServicePickerClient::windowForSharingServicePicker): (WebSharingServicePickerClient::screenRectForCurrentSharingServicePickerItem): (WebSharingServicePickerClient::imageForCurrentSharingServicePickerItem): (-[WebSharingServicePickerController initWithItems:includeEditorServices:client:style:]): (-[WebSharingServicePickerController initWithSharingServicePicker:client:]): (-[WebSharingServicePickerController sharingService:didShareItems:]): * WebCoreSupport/WebContextMenuClient.h: (WebContextMenuClient::webView): Deleted. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::WebContextMenuClient): (WebContextMenuClient::pageForSharingServicePicker): Deleted. (WebContextMenuClient::windowForSharingServicePicker): Deleted. * WebCoreSupport/WebSelectionServiceController.h: * WebCoreSupport/WebSelectionServiceController.mm: (WebSelectionServiceController::WebSelectionServiceController): (WebSelectionServiceController::handleSelectionServiceClick): (WebSelectionServiceController::pageForSharingServicePicker): Deleted. (WebSelectionServiceController::windowForSharingServicePicker): Deleted. (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem): Deleted. (WebSelectionServiceController::imageForCurrentSharingServicePickerItem): Deleted. * WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): * WebView/WebViewData.h: 2015-04-13 Beth Dakin Add force property to MouseEvents https://bugs.webkit.org/show_bug.cgi?id=143569 -and corresponding- rdar://problem/20472954 Reviewed by Darin Adler. PlatformMouseEvent and MouseEvent now take force parameters. * WebView/WebFrame.mm: (-[WebFrame _dragSourceEndedAt:operation:]): * WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): 2015-04-12 Darin Adler [Cocoa] Localizable strings are inconsistent and need to be regenerated https://bugs.webkit.org/show_bug.cgi?id=143661 rdar://problem/19634388 Reviewed by Dan Bernstein. * Misc/WebLocalizableStrings.mm: (LoadWebLocalizedStringsTimerCallback): Moved the comment, useful for programmers but not for localization, into a C++ source code comment, and made the localizer comment consistent with the place this localizable string is used for actual localization. * WebCoreSupport/WebEditorClient.mm: (undoNameForEditAction): Changed the localizer comments for Delete and Dictation to match the ones in WebKit2; no need to specify that these are iOS only, and if we do want to specify that, we should not be using the term PLATFORM(IOS) since there is no reason for us to expect localizers to understand that terminology. Also added a comment about the fact that we have two copies of all the localizable strings. 2015-04-11 Yusuke Suzuki [ES6] Enable Symbol in web pages https://bugs.webkit.org/show_bug.cgi?id=143375 Reviewed by Ryosuke Niwa. * WebView/WebPreferencesPrivate.h: 2015-04-08 Sam Weinig Allow LaunchServices to handle URLs on link navigations https://bugs.webkit.org/show_bug.cgi?id=143544 Reviewed by Anders Carlsson. * Configurations/WebKitLegacy.xcconfig: Link MobileCoreServices. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (shouldTryAppLink): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::setUpPolicyListener): Only let LaunchServices have a crack at the URL if the navigation is: 1) a main frame navigation 2) a result of a user gesture 2015-04-10 Alexey Proskuryakov Build fix. * Misc/WebNSURLExtras.mm: (-[NSString _webkit_unescapedQueryValue]): Ignore a deprecation. 2015-04-10 Eric Carlson [Mac] Refactor MediaPlaybackTarget https://bugs.webkit.org/show_bug.cgi?id=143571 Reviewed by Jer Noble. * WebView/WebMediaPlaybackTargetPicker.h: * WebView/WebMediaPlaybackTargetPicker.mm: (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): Take a Ref&&. 2015-04-09 Andy Estes [Cocoa] Add a HAVE(AVKIT) and use it https://bugs.webkit.org/show_bug.cgi?id=143593 Reviewed by David Kilzer. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Only set WebKitAVKitEnabled to YES if HAVE(AVKIT). (-[WebPreferences setAVKitEnabled:]): Only set value for WebKitAVKitEnabled if HAVE(AVKIT). * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Only called Settings::setAVKitEnabled() if HAVE(AVKIT). 2015-04-09 Chris Dumez [WK2][iOS] editorState() should not cause a synchronous layout https://bugs.webkit.org/show_bug.cgi?id=142536 Reviewed by Enrica Casucci. Provide implementation for EditorClient::didChangeSelectionAndUpdateLayout(). * WebCoreSupport/WebEditorClient.h: 2015-04-08 Brent Fulgham [Mac] WebKit is not honoring OS preferences for secondary click behaviors https://bugs.webkit.org/show_bug.cgi?id=143452 Reviewed by Tim Horton. We were improperly intercepting contextual menu clicks and passing them through the mouseDown handler, rather than processing via NSView's menu handling code. * WebView/WebHTMLView.mm: (-[WebHTMLView otherMouseDown:]): Treat context menu events the same as the action menu case, and pass it to AppKit for normal menu processing. 2015-04-08 Brady Eidson Expose the "Share" menu for links, images, and media. and https://bugs.webkit.org/show_bug.cgi?id=143502 Reviewed by Tim Horton. * WebCoreSupport/WebContextMenuClient.h: * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::shareMenuItem): 2015-04-08 Anders Carlsson Move some ApplicationCache static member functions to ApplicationCacheStorage https://bugs.webkit.org/show_bug.cgi?id=143524 Reviewed by Antti Koivisto. * WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache diskUsageForOrigin:]): (+[WebApplicationCache deleteAllApplicationCaches]): (+[WebApplicationCache deleteCacheForOrigin:]): 2015-04-08 Chris Dumez Rename ActiveDOMObject::canSuspend() to canSuspendForPageCache() for clarity https://bugs.webkit.org/show_bug.cgi?id=143513 Reviewed by Andreas Kling. Update ScriptExecutionContext::canSuspendActiveDOMObjects() to canSuspendActiveDOMObjectsForPageCache() as the method was renamed. * WebView/WebFrame.mm: (-[WebFrame _cacheabilityDictionary]): 2015-04-07 Anders Carlsson Get rid of uses of ApplicationCacheStorage::singleton() from WebKitLegacy https://bugs.webkit.org/show_bug.cgi?id=143504 Reviewed by Sam Weinig. Add a webApplicationCacheStorage() function and use it throughout WebKitLegacy. In the future, webApplicationCacheStorage will return a custom singleton, but for now it just returns ApplicationCacheStorage::singleton(). * Misc/WebCache.mm: (+[WebCache empty]): * WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache maximumSize]): (+[WebApplicationCache setMaximumSize:]): (+[WebApplicationCache defaultOriginQuota]): (+[WebApplicationCache setDefaultOriginQuota:]): (+[WebApplicationCache originsWithCache]): (webApplicationCacheStorage): * WebCoreSupport/WebApplicationCacheInternal.h: Added. * WebCoreSupport/WebApplicationCacheQuotaManager.mm: (-[WebApplicationCacheQuotaManager usage]): (-[WebApplicationCacheQuotaManager quota]): (-[WebApplicationCacheQuotaManager setQuota:]): * WebView/WebView.mm: (WebKitInitializeApplicationCachePathIfNecessary): 2015-04-07 Brady Eidson ContextMenuItem refactoring https://bugs.webkit.org/show_bug.cgi?id=143485 Reviewed by Beth Dakin. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuItemSelected): 2015-04-06 Chris Dumez Bing video search result pages are not PageCacheable https://bugs.webkit.org/show_bug.cgi?id=143463 Reviewed by Alexey Proskuryakov. Fix the iOS / WK1 build by using MemoryCache::resourceForRequest() instead of resourceForUrl(). * Misc/WebCache.mm: (+[WebCache imageForURL:]): 2015-04-05 Simon Fraser Remove "go ahead and" from comments https://bugs.webkit.org/show_bug.cgi?id=143421 Reviewed by Darin Adler, Benjamin Poulain. Remove the phrase "go ahead and" from comments where it doesn't add anything (which is almost all of them). * WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView updateScrollers]): * WebView/WebHTMLView.mm: (-[WebHTMLView insertText:]): 2015-04-02 Brady Eidson Unreviewed: Reland change after rollout. Expose the "Share" menu for text selections on platforms where it's available. rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318 * WebView/WebImmediateActionController.mm: Update for required #include 2015-04-02 Commit Queue Unreviewed, rolling out r182293. https://bugs.webkit.org/show_bug.cgi?id=143355 Broke GTK and EFL builds. (Requested by bfulgham on #webkit). Reverted changeset: "Expose the "Share" menu for text selections on platforms where it's available." https://bugs.webkit.org/show_bug.cgi?id=143318 http://trac.webkit.org/changeset/182293 2015-04-02 Brady Eidson Expose the "Share" menu for text selections on platforms where it's available. rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318 Reviewed by Sam Weinig. * WebView/WebImmediateActionController.mm: Update for required #include 2015-04-02 Yusuke Suzuki Clean up EnumerationMode to easily extend https://bugs.webkit.org/show_bug.cgi?id=143276 Reviewed by Geoffrey Garen. Use default EnumerationMode(). * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::enumerate): 2015-03-31 Simon Fraser Remove scrolling tree dependency on wheel event handler counts, and use fast scrolling even when there are wheel handlers https://bugs.webkit.org/show_bug.cgi?id=143288 Reviewed by Beth Dakin. Remove the wheel event counting that Document does, and passes into the scrolling tree. The ScrollingTree now just uses the non-fast scrollable region to determine when to fast scroll on pages with wheel event handlers. * WebCoreSupport/WebChromeClient.h: 2015-03-31 Timothy Horton TextIndicator for inside an only highlights the , should highlight the whole https://bugs.webkit.org/show_bug.cgi?id=143287 Reviewed by Beth Dakin. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _defaultAnimationController]): Instead of just highlighting the hit element, highlight the whole element that the link URL comes from. 2015-03-31 Yusuke Suzuki Clean up Identifier factories to clarify the meaning of StringImpl* https://bugs.webkit.org/show_bug.cgi?id=143146 Reviewed by Filip Pizlo. Just change to Identifier::fromString. * Plugins/Hosted/NetscapePluginHostProxy.mm: (identifierFromIdentifierRep): * Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::getPropertyNames): 2015-03-28 Anders Carlsson Remove an unused SPI method from WebKitLegacy https://bugs.webkit.org/show_bug.cgi?id=143185 Reviewed by Sam Weinig. * WebView/WebDataSource.mm: (-[WebDataSource _transferApplicationCache:]): Deleted. * WebView/WebDataSourcePrivate.h: 2015-03-26 Alex Christensen Progress towards CMake on Mac. https://bugs.webkit.org/show_bug.cgi?id=143112 Reviewed by Chris Dumez. * WebCoreSupport/WebFrameLoaderClient.h: 2015-03-26 Ryosuke Niwa Cursor doesn't change back to pointer when leaving Mail https://bugs.webkit.org/show_bug.cgi?id=132038 Reviewed by Anders Carlsson. Fixed the bug by adding a cursor rect and making the primary tracking area update the cursor so that AppKit will reset the cursor as it leaves the WebView. We use nil cursor here since we manually update the cursor by calling [NSCursor set]. * WebView/WebHTMLView.mm: (-[WebHTMLView setDataSource:]): Use NSTrackingCursorUpdate option in creating the primary tracking area. 2015-03-24 Anders Carlsson Fix designated initializer violations https://bugs.webkit.org/show_bug.cgi?id=143016 rdar://problem/20268858 Reviewed by Dan Bernstein. Move -[WebBackForwardList initWithBackForwardList:] to the implementation instead of a category since nobody calls it outside of WebBackForwardList.mm. * History/WebBackForwardList.mm: * History/WebBackForwardListInternal.h: 2015-03-23 Alexey Proskuryakov REGRESSION (Yosemite): WKView visibility notifications are messed up https://bugs.webkit.org/show_bug.cgi?id=142945 Reviewed by Tim Horton. As these notifications cannot be used by NSView subclasses, create a separate object for observing them. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): (-[WebView addWindowObserversForWindow:]): (-[WebView removeWindowObservers]): (-[WebView viewWillMoveToWindow:]): Make sure that observers are removed even if -[WebView close] is called manually. * WebView/WebViewData.h: * WebView/WebViewData.mm: (-[WebWindowVisibilityObserver initWithView:]): (-[WebWindowVisibilityObserver startObserving:]): (-[WebWindowVisibilityObserver stopObserving:]): (-[WebWindowVisibilityObserver _windowVisibilityChanged:]): 2015-03-23 Tim Horton Add a share item to the link action menu https://bugs.webkit.org/show_bug.cgi?id=142961 Reviewed by Beth Dakin. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _defaultMenuItemsForImage]): (-[WebActionMenuController _defaultMenuItemsForVideo]): (-[WebActionMenuController _createActionMenuItemForTag:]): (-[WebActionMenuController _createShareActionMenuItemForTag:withItems:]): Adopt -[NSMenuItem standardShareMenuItemWithItems]. All of the null-checking is unnecessary as it's impossible to enter these functions with a null image/etc. Also, remove a duplicate isDownloadableMedia check for the 'save to downloads' item. (-[WebActionMenuController _defaultMenuItemsForLink]): * WebView/WebUIDelegatePrivate.h: Add a 'Share' item to the link menu. 2015-03-22 Alexey Proskuryakov Build fix. * WebView/WebView.mm: (-[WebView _showPlaybackTargetPicker:hasVideo:]): 2015-03-22 Eric Carlson [Mac] Enable WIRELESS_PLAYBACK_TARGET for WK1 https://bugs.webkit.org/show_bug.cgi?id=142940 Reviewed by Sam Weinig. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::showPlaybackTargetPicker): New. (WebChromeClient::startingMonitoringPlaybackTargets): New. (WebChromeClient::stopMonitoringPlaybackTargets): New. * WebView/WebView.mm: (-[WebView _close]): Invalidate and free the target picker. (-[WebView _devicePicker]): New. (-[WebView _showPlaybackTargetPicker:hasVideo:]): New. (-[WebView _startingMonitoringPlaybackTargets]): New. (-[WebView _stopMonitoringPlaybackTargets]): New. * WebView/WebMediaPlaybackTargetPicker.h: * WebView/WebMediaPlaybackTargetPicker.mm: (WebMediaPlaybackTargetPicker::create): New. (WebMediaPlaybackTargetPicker::WebMediaPlaybackTargetPicker): New. (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): New. (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): New. (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): New. (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): New. (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange): New. (WebMediaPlaybackTargetPicker::invalidate): New. (WebMediaPlaybackTargetPicker::targetPicker): New. * WebView/WebViewData.h: (WebMediaPlaybackTargetPicker::~WebMediaPlaybackTargetPicker): * WebView/WebViewData.mm: * WebView/WebViewInternal.h: 2015-03-19 Andy Estes [Content Filtering] Add tests for unblock requests https://bugs.webkit.org/show_bug.cgi?id=142900 Reviewed by Andreas Kling. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): This now happens in PolicyChecker. (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto. * WebView/WebFrame.mm: (-[WebFrame _contentFilterDidHandleNavigationAction:]): Deleted. * WebView/WebFrameInternal.h: Removed contentFilterUnblockHandler from WebFramePrivate. 2015-03-19 Enrica Casucci should put URLs on the pasteboard so that Finder can accept drops. https://bugs.webkit.org/show_bug.cgi?id=142801 rdar://problem/19982527 Reviewed by Tim Horton. This patch adds all the necessary support to write attachment elements into the pasteboard, including the promised type in WK1. * Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]): * WebCoreSupport/WebDragClient.h: * WebCoreSupport/WebDragClient.mm: (WebDragClient::declareAndWriteAttachment): * WebView/WebHTMLView.mm: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): * WebView/WebUIDelegate.h: 2015-03-19 Chris Dumez Clean up DOMTimer related settings https://bugs.webkit.org/show_bug.cgi?id=142837 Reviewed by Darin Adler. Stop setting the DOMTimers' default minimum interval to 4ms as this is now the default. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): 2015-03-17 Conrad Shultz Ignore some deprecation warnings https://bugs.webkit.org/show_bug.cgi?id=142813 Reviewed by Mark Rowe. Fixing the deprecations is tracked by: * WebCoreSupport/PopupMenuMac.mm: (PopupMenuMac::populate): 2015-03-17 Tim Horton Cannot invoke action menus anymore https://bugs.webkit.org/show_bug.cgi?id=142797 * WebView/WebHTMLView.mm: (-[WebHTMLView otherMouseDown:]): Need a respondsToSelector check. 2015-03-17 Tim Horton Fix the iOS build * WebView/WebHTMLView.mm: 2015-03-17 Tim Horton Cannot invoke action menus anymore https://bugs.webkit.org/show_bug.cgi?id=142797 Reviewed by Beth Dakin. * WebView/WebHTMLView.mm: (-[WebHTMLView otherMouseDown:]): Don't override otherMouseDown: if the event would make an action menu. 2015-03-16 Ryosuke Niwa Enable ES6 classes by default https://bugs.webkit.org/show_bug.cgi?id=142774 Reviewed by Gavin Barraclough. * Configurations/FeatureDefines.xcconfig: 2015-03-16 Brent Fulgham WebKit1 Clients Are Not Reliably Repainted https://bugs.webkit.org/show_bug.cgi?id=142750 Reviewed by Simon Fraser. Check with the FrameView to see if we are in an immediately paintable state. If we are not, mark the view as dirty once the _immediateScrollToPoint operation is complete so that the region will be painted properly. * WebView/WebClipView.mm: (-[WebClipView _immediateScrollToPoint:]): 2015-03-16 Conrad Shultz Allow clients to selectively disable plug-ins https://bugs.webkit.org/show_bug.cgi?id=142506 Reviewed by Anders Carlsson. Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them from the page). As part of this: 1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying set of plug-ins. 2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper down the stack. 3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce a concrete implementation thereof in WebPlatformStrategies in WebKit2. 4) Add messaging infrastructure to allow clients to set and clear plug-in policies. While currently only used in a very limited manner, the new declarative plug-in policies are written generically so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins. * Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage getPluginInfoFromPLists]): Set new members in PluginInfo. * Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]): Set new members in PluginInfo. * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getWebVisiblePluginInfo): Override to wrap getPluginInfo(). (WebPlatformStrategies::setPluginLoadClientPolicy): Override to do nothing. (WebPlatformStrategies::clearPluginClientPolicies): Ditto. * WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): Update to reflect function rename. 2015-03-14 Dean Jackson Feature flag for Animations Level 2 https://bugs.webkit.org/show_bug.cgi?id=142699 Reviewed by Brent Fulgham. Add ENABLE_CSS_ANIMATIONS_LEVEL_2 and a runtime flag animationTriggersEnabled. * Configurations/FeatureDefines.xcconfig: 2015-03-13 Commit Queue Unreviewed, rolling out r181483. https://bugs.webkit.org/show_bug.cgi?id=142688 Caused use-after-free on many tests (Requested by ap on #webkit). Reverted changeset: "Allow clients to selectively disable plug-ins" https://bugs.webkit.org/show_bug.cgi?id=142506 http://trac.webkit.org/changeset/181483 2015-03-13 Eric Carlson [Mac] Enable WIRELESS_PLAYBACK_TARGET https://bugs.webkit.org/show_bug.cgi?id=142635 Reviewed by Darin Adler. * Configurations/FeatureDefines.xcconfig: 2015-03-10 Conrad Shultz Allow clients to selectively disable plug-ins https://bugs.webkit.org/show_bug.cgi?id=142506 Reviewed by Anders Carlsson. Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them from the page). As part of this: 1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying set of plug-ins. 2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper down the stack. 3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce a concrete implementation thereof in WebPlatformStrategies in WebKit2. 4) Add messaging infrastructure to allow clients to set and clear plug-in policies. While currently only used in a very limited manner, the new declarative plug-in policies are written generically so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins. * Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage getPluginInfoFromPLists]): Set new members in PluginInfo. * Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]): Set new members in PluginInfo. * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getWebVisiblePluginInfo): Override to wrap getPluginInfo(). (WebPlatformStrategies::setPluginLoadClientPolicy): Override to do nothing. (WebPlatformStrategies::clearPluginClientPolicies): Ditto. * WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): Update to reflect function rename. 2015-03-10 Sam Weinig Allow adding a button in input elements for auto fill related functionality https://bugs.webkit.org/show_bug.cgi?id=142564 Reviewed by Anders Carlsson. * DOM/WebDOMOperations.mm: (-[DOMHTMLInputElement _setAutofilled:]): Update for consistent spelling of AutoFill. 2015-03-10 Timothy Horton Fix the build * History/WebHistory.mm: (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]): * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::convertMainResourceLoadToDownload): 2015-03-10 Tim Horton Fix the Mac build with a newer compiler * Plugins/WebPluginController.mm: (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_): (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_): 2015-03-09 David Kilzer [iOS] Fix build when compiling with dead code stripping disabled Reviewed by Simon Fraser. * Configurations/WebKitLegacy.xcconfig: (EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*]): Disable mig code generation and compilation for out-of-process plugin support. This was never used on iOS. 2015-03-06 Myles C. Maxfield [iOS] SVG fonts are garbled https://bugs.webkit.org/show_bug.cgi?id=142377 Reviewed by Simon Fraser. * Configurations/FeatureDefines.xcconfig: 2015-03-04 Yusuke Suzuki Hide Promise with runtime flags under Cocoa JSContext API https://bugs.webkit.org/show_bug.cgi?id=141965 Reviewed by Filip Pizlo. Add new JSC runtime flag, PromiseDisabled. * WebView/WebPreferencesPrivate.h: 2015-03-03 Andy Estes [Content Filtering] Separate unblock handling into its own class https://bugs.webkit.org/show_bug.cgi?id=142251 Reviewed by Andreas Kling. Adopted ContentFilterUnblockHandler. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): * WebView/WebFrame.mm: (-[WebFrame _contentFilterDidHandleNavigationAction:]): * WebView/WebFrameInternal.h: 2015-03-03 Chris Dumez Access ApplicationCacheStorage global instance via singleton() static member function https://bugs.webkit.org/show_bug.cgi?id=142239 Reviewed by Anders Carlsson. Access ApplicationCacheStorage global instance via singleton() static member function as per WebKit coding style. 2015-03-02 Jer Noble [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled. https://bugs.webkit.org/show_bug.cgi?id=142121 Reviewed by Simon Fraser. Fullscreening a page with a non-1 scale would result in that scale being applied to the fullscreen content, breaking fullscreen mode. Set the page scale to 1 when entering fullscreen and reset it to the original value when exiting fullscreen. * WebView/WebFullScreenController.h: * WebView/WebFullScreenController.mm: (-[WebFullScreenController enterFullScreen:]): Set the page scale to 1. (-[WebFullScreenController finishedExitFullScreenAnimation:]): Reset the page scale to the original value. * WebView/WebView.mm: (-[WebView _supportsFullScreenForElement:withKeyboard:]): Drive-by fix. Check the WebView's own preferences to see if fullscreen mode is enabled, rather than the global object's. 2015-03-01 Chris Dumez Make NotificationCenter / Notification suspendable https://bugs.webkit.org/show_bug.cgi?id=142117 Reviewed by Andreas Kling. Provide implementation for NotificationClient::hasPendingPermissionRequests(). The implementation is very simplistic. it will only return false if no request for permission for ever made. This is because there is currently no easy way to figure out if a permission request is pending or not. * WebCoreSupport/WebNotificationClient.h: * WebCoreSupport/WebNotificationClient.mm: (WebNotificationClient::requestPermission): (WebNotificationClient::hasPendingPermissionRequests): 2015-02-28 Simon Fraser Viewport units should not dirty style just before we do layout https://bugs.webkit.org/show_bug.cgi?id=141682 Reviewed by Zalan Bujtas. * WebView/WebFrameView.mm: (-[WebFrameView _frameSizeChanged]): 2015-02-26 Chris Dumez Rename DatabaseManager::manager() to DatabaseManager::singleton() https://bugs.webkit.org/show_bug.cgi?id=142054 Reviewed by Ryosuke Niwa. Rename DatabaseManager::manager() to DatabaseManager::singleton() as per coding style and use WTF::NeverDestroyed. * Storage/WebDatabaseManager.mm: (-[WebDatabaseManager init]): (-[WebDatabaseManager origins]): (-[WebDatabaseManager databasesWithOrigin:]): (-[WebDatabaseManager detailsForDatabase:withOrigin:]): (-[WebDatabaseManager deleteAllDatabases]): (-[WebDatabaseManager deleteOrigin:]): (-[WebDatabaseManager deleteDatabase:withOrigin:]): * Storage/WebDatabaseQuotaManager.mm: (-[WebDatabaseQuotaManager usage]): (-[WebDatabaseQuotaManager quota]): (-[WebDatabaseQuotaManager setQuota:]): * WebCoreSupport/WebSecurityOrigin.mm: (-[WebSecurityOrigin usage]): (-[WebSecurityOrigin quota]): (-[WebSecurityOrigin setQuota:]): * WebView/WebFrame.mm: (-[WebFrame _cacheabilityDictionary]): * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2015-02-26 Myles C. Maxfield [Mac] [iOS] Parsing support for -apple-trailing-word https://bugs.webkit.org/show_bug.cgi?id=141939 Reviewed by Andreas Kling. * Configurations/FeatureDefines.xcconfig: 2015-02-24 Commit Queue Unreviewed, rolling out r180599. https://bugs.webkit.org/show_bug.cgi?id=141998 Lots of new test failures (Requested by smfr on #webkit). Reverted changeset: "Parsing support for -webkit-trailing-word" https://bugs.webkit.org/show_bug.cgi?id=141939 http://trac.webkit.org/changeset/180599 2015-02-24 Myles C. Maxfield [Mac] [iOS] Parsing support for -apple-trailing-word https://bugs.webkit.org/show_bug.cgi?id=141939 Reviewed by Andreas Kling. * Configurations/FeatureDefines.xcconfig: 2015-02-24 Yusuke Suzuki REGRESSION(r179429): Can't type comments in Facebook https://bugs.webkit.org/show_bug.cgi?id=141859 Reviewed by Brent Fulgham. Introduce SymbolEnabled and drop javaScriptExperimentsEnabled. Private API, javaScriptExperimentsEnabled is dropped. * Misc/WebNSDictionaryExtras.h: * Misc/WebNSDictionaryExtras.m: (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): * WebKit.order: * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences _setUnsignedIntValue:forKey:]): (-[WebPreferences javaScriptRuntimeFlags]): (-[WebPreferences setJavaScriptRuntimeFlags:]): (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted. (-[WebPreferences javaScriptExperimentsEnabled]): Deleted. * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2015-02-23 Commit Queue Unreviewed, rolling out r180547 and r180550. https://bugs.webkit.org/show_bug.cgi?id=141957 Broke 10 Windows tests. (Requested by bfulgham_ on #webkit). Reverted changesets: "REGRESSION(r179429): Can't type comments in Facebook" https://bugs.webkit.org/show_bug.cgi?id=141859 http://trac.webkit.org/changeset/180547 "Constructor returning null should construct an object instead of null" https://bugs.webkit.org/show_bug.cgi?id=141640 http://trac.webkit.org/changeset/180550 2015-02-23 Ryosuke Niwa Disable font loading events until our implementation gets updated to match the latest spec https://bugs.webkit.org/show_bug.cgi?id=141938 Reviewed by Andreas Kling. * Configurations/FeatureDefines.xcconfig: 2015-02-23 Yusuke Suzuki REGRESSION(r179429): Can't type comments in Facebook https://bugs.webkit.org/show_bug.cgi?id=141859 Reviewed by Geoffrey Garen. Introduce SymbolEnabled and drop javaScriptExperimentsEnabled. Private API, javaScriptExperimentsEnabled is dropped. * Misc/WebNSDictionaryExtras.h: * Misc/WebNSDictionaryExtras.m: (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): * WebKit.order: * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences _setUnsignedIntValue:forKey:]): (-[WebPreferences javaScriptRuntimeFlags]): (-[WebPreferences setJavaScriptRuntimeFlags:]): (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted. (-[WebPreferences javaScriptExperimentsEnabled]): Deleted. * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2015-02-20 Eric Carlson [iOS] cleanup AirPlay code https://bugs.webkit.org/show_bug.cgi?id=141811 Reviewed by Jer Noble. * Configurations/FeatureDefines.xcconfig: IOS_AIRPLAY -> WIRELESS_PLAYBACK_TARGET. 2015-02-18 Timothy Horton Adopt WebCore::IOSurface in ImageBuffer https://bugs.webkit.org/show_bug.cgi?id=141751 Reviewed by Simon Fraser. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Remove old WKSI IOSurface-related functions. 2015-02-18 Commit Queue Unreviewed, rolling out r180286. https://bugs.webkit.org/show_bug.cgi?id=141766 Caused >50 crashed LayoutTests (Requested by jernoble on #webkit). Reverted changeset: "Page::userContentController() should return a reference, not a pointer" https://bugs.webkit.org/show_bug.cgi?id=141764 http://trac.webkit.org/changeset/180286 2015-02-18 Brady Eidson Page::userContentController() should return a reference, not a pointer https://bugs.webkit.org/show_bug.cgi?id=141764 Reviewed by Jer Noble. * WebView/WebView.mm: (-[WebView setGroupName:]): 2015-02-18 Chris Dumez Access FontCache global instance via singleton() static member function https://bugs.webkit.org/show_bug.cgi?id=141726 Reviewed by Daniel Bates. Access FontCache global instance via singleton() static member function, as per coding style. 2015-02-17 Chris Dumez Access MemoryPressureHandler global instance via a singleton() static member function https://bugs.webkit.org/show_bug.cgi?id=141691 Reviewed by Andreas Kling. Access MemoryPressureHandler global instance via a singleton() static member function. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (+[WebView registerForMemoryNotifications]): (+[WebView _isUnderMemoryPressure]): (+[WebView _clearMemoryPressure]): (+[WebView _shouldWaitForMemoryClearMessage]): (WebInstallMemoryPressureHandler): 2015-02-15 Sam Weinig Add experimental element support https://bugs.webkit.org/show_bug.cgi?id=141626 Reviewed by Tim Horton. * Configurations/FeatureDefines.xcconfig: 2015-02-14 Joseph Pecoraro [Mac] Possible DDActionContext leaks, RetainPtr cleanup https://bugs.webkit.org/show_bug.cgi?id=141613 Reviewed by Tim Horton. * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): Avoid unnecessary retain/autorelease by adopting. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]): Adopt the allocated object. 2015-02-09 Brian J. Burg Web Inspector: remove some unnecessary Inspector prefixes from class names in Inspector namespace https://bugs.webkit.org/show_bug.cgi?id=141372 Reviewed by Joseph Pecoraro. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController destroyInspectorView:]): 2015-02-14 Alexey Proskuryakov rel="noreferrer" should make window.opener null https://bugs.webkit.org/show_bug.cgi?id=141579 Reviewed by Darin Adler. * WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Updated for a new WebCore function signature. There is no rel="noreferrer" in PDF, so we can just always allow. 2015-02-05 Youenn Fablet and Xabier Rodriguez Calvar [Streams API] Implement a barebone ReadableStream interface https://bugs.webkit.org/show_bug.cgi?id=141045 Reviewed by Benjamin Poulain. * Configurations/FeatureDefines.xcconfig: 2015-02-03 Enrica Casucci [iOS] Add support for deleteFromInputWithFlags. https://bugs.webkit.org/show_bug.cgi?id=141216 rdar://problem/19130081 Reviewed by Benjamin Poulain. Adopts the new method as soon as it is available. The patch also removes some obsolete code used for staging. * WebView/WebHTMLView.mm: (-[WebHTMLView _handleEditingKeyEvent:]): 2015-02-02 Chris Dumez Access MemoryCache singleton using MemoryCache::singleton() https://bugs.webkit.org/show_bug.cgi?id=141104 Reviewed by Andreas Kling. Access MemoryCache singleton using MemoryCache::singleton() static member function, instead of a free function, as per the recent coding style discussion on WebKit-dev. 2015-02-01 Chris Dumez Use more references in HistoryItem https://bugs.webkit.org/show_bug.cgi?id=141133 Reviewed by Andreas Kling. Use more references in HistoryItem instead of pointers. 2015-01-31 Sam Weinig Remove even more Mountain Lion support https://bugs.webkit.org/show_bug.cgi?id=141124 Reviewed by Alexey Proskuryakov. * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: * Configurations/FeatureDefines.xcconfig: * Configurations/Version.xcconfig: * Configurations/WebKitLegacy.xcconfig: 2015-01-30 Eric Carlson Remove MediaPlayerProxy.h https://bugs.webkit.org/show_bug.cgi?id=141087 Reviewed by Sam Weinig. * MigrateHeaders.make: Don't need to copy MediaPlayerProxy.h. * Plugins/WebPluginController.mm: Don't include MediaPlayerProxy.h. 2015-01-30 Chris Dumez Rename shared() static member functions to singleton() for singleton classes. https://bugs.webkit.org/show_bug.cgi?id=141088 Reviewed by Ryosuke Niwa and Benjamin Poulain. Rename shared() static member functions to singleton() for singleton classes as per the recent coding style change. 2015-01-29 Beth Dakin Remove more Mountain Lion code from WebKit https://bugs.webkit.org/show_bug.cgi?id=141050 Reviewed by Anders Carlsson. * History/WebHistory.mm: (getDayBoundaries): * Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel cancel:]): (-[WebAuthenticationPanel logIn:]): (-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]): * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): * WebView/WebFrameView.mm: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (needsScreenFontsEnabledQuirk): * WebView/WebView.mm: (+[WebView registerForMemoryNotifications]): (-[WebView _preferencesChanged:]): (+[WebView initialize]): (+[WebView _shouldAutomaticQuoteSubstitutionBeEnabled]): (+[WebView _shouldAutomaticDashSubstitutionBeEnabled]): (+[WebView _didChangeAutomaticDashSubstitutionEnabled:]): 2015-01-29 Sam Weinig Remove support for screen font substitution https://bugs.webkit.org/show_bug.cgi?id=141038 Reviewed by Tim Horton. * Misc/WebKitNSStringExtras.mm: (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): (-[NSString _web_widthWithFont:]): * Misc/WebStringTruncator.mm: (fontFromNSFont): Update for new signature of the FontPlatformData constructor, which no longer cares about whether to use printer fonts. * WebView/WebPreferenceKeysPrivate.h: Remove the WebKitScreenFontSubstitutionEnabledKey key. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Remove support for WebKitScreenFontSubstitutionEnabledKey. (needsScreenFontsEnabledQuirk): Deleted. Remove support for the Mountain Lion era 1-Password quirk. (-[WebPreferences screenFontSubstitutionEnabled]): Deleted. (-[WebPreferences setScreenFontSubstitutionEnabled:]): Deleted. * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): (-[WebView _preferencesChanged:]): Remove support for the screen font substitution setting. 2015-01-29 Chris Dumez Clean up / modernize PageCache class https://bugs.webkit.org/show_bug.cgi?id=141009 Reviewed by Darin Adler. Clean up / modernize PageCache class. * History/WebBackForwardList.mm: (-[WebBackForwardList pageCacheSize]): * WebView/WebView.mm: (-[WebView _loadBackForwardListFromOtherView:]): (-[WebView goToBackForwardItem:]): (+[WebView _setCacheModel:]): 2015-01-28 Beth Dakin Remove Mountain Lion code from WebKit and WebKit2 https://bugs.webkit.org/show_bug.cgi?id=141010 Reviewed by Sam Weinig. * DOM/WebDOMOperations.mm: (toNSEventPhase): * WebView/WebHTMLView.mm: (isQuickLookEvent): 2015-01-28 Dana Burkart Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig https://bugs.webkit.org/show_bug.cgi?id=136765 Reviewed by Alexey Proskuryakov. * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: 2015-01-28 Chris Dumez Fix typo in markPagesForVistedLinkStyleRecalc() https://bugs.webkit.org/show_bug.cgi?id=140977 Reviewed by Darin Adler. * WebCoreSupport/WebVisitedLinkStore.mm: (WebVisitedLinkStore::removeAllVisitedLinks): (WebVisitedLinkStore::removeVisitedLink): (WebVisitedLinkStore::addVisitedLinkHash): 2015-01-28 Chris Dumez Rename pageCache() to PageCache::shared() and return a reference https://bugs.webkit.org/show_bug.cgi?id=140983 Reviewed by Andreas Kling. Rename pageCache() to PageCache::shared() as this is a singleton class and have it return a reference instead of a pointer. * History/WebBackForwardList.mm: (-[WebBackForwardList pageCacheSize]): * Misc/WebCoreStatistics.mm: (+[WebCoreStatistics cachedPageCount]): (+[WebCoreStatistics cachedFrameCount]): * WebCoreSupport/WebVisitedLinkStore.mm: (WebVisitedLinkStore::removeAllVisitedLinks): (WebVisitedLinkStore::removeVisitedLink): (WebVisitedLinkStore::addVisitedLinkHash): * WebView/WebView.mm: (+[WebView _setCacheModel:]): 2015-01-27 Alexey Proskuryakov More build fixes for newer clang. Rubber-stamped by Anders Carlsson. Marked a deprecated accessibility method as such. * WebView/WebFrame.mm: (-[WebFrame accessibilityRoot]): 2015-01-27 Beth Dakin Immediate action gesture recognizer still doesn't work well with IB https://bugs.webkit.org/show_bug.cgi?id=140967 -and corresponding- rdar://problem/19621509 Reviewed by Tim Horton. We should add (or remove) the gesture recognizer in viewDidMoveToWindow because initWithFrame it too early and IB might mess with it. * WebView/WebImmediateActionController.h: * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController immediateActionRecognizer]): * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView viewDidMoveToWindow]): 2015-01-27 Dan Bernstein Fixed building projects that import WebView.h with WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS. Rubber-stamped by Anders Carlsson. * WebView/WebView.h: Added forward declarations of the protocols. 2015-01-26 Anders Carlsson Make it easy to test enabling formal delegate protocols https://bugs.webkit.org/show_bug.cgi?id=140892 Reviewed by Dan Bernstein. Add an WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS define that controls whether delegates should be formal protocols. * Misc/WebDownload.h: * WebView/WebFrameLoadDelegate.h: * WebView/WebPolicyDelegate.h: * WebView/WebResourceLoadDelegate.h: * WebView/WebUIDelegate.h: * WebView/WebView.h: 2015-01-26 Chris Dumez Rename Document::body() to Document::bodyOrFrameset() for clarity https://bugs.webkit.org/show_bug.cgi?id=140902 Reviewed by Andreas Kling. Rename Document::body() to Document::bodyOrFrameset() for clarity. This method does not necessarily return an HTMLBodyElement, it can also return a frameset as per the specification: http://www.w3.org/TR/html5/dom.html#dom-tree-accessors This method is often misused internally (the caller is only interested in the element). I will fix these instances in a follow-up patch, this patch is only renaming mechanically. 2015-01-26 Chris Dumez First argument to DOM traversal functions should be a reference https://bugs.webkit.org/show_bug.cgi?id=140895 Reviewed by Antti Koivisto. First argument to DOM traversal functions should be a reference instead of a pointer as it is dereferenced without null-check. 2015-01-26 Myles C. Maxfield [iOS] [SVG -> OTF Converter] Flip the switch off on iOS https://bugs.webkit.org/show_bug.cgi?id=140860 Reviewed by Darin Adler. The fonts it makes are grotesque. (See what I did there? Typographic humor is the best humor.) * Configurations/FeatureDefines.xcconfig: 2015-01-23 Timothy Horton QLPreviewMenuItem popovers don't close when the page scrolls https://bugs.webkit.org/show_bug.cgi?id=140806 Reviewed by Beth Dakin. Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls. * WebView/WebHTMLView.mm: (-[WebHTMLView scrollWheel:scrollWheel:]): Send scrollWheel along to WebImmediateActionController. * WebView/WebImmediateActionController.h: * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController webView:didHandleScrollWheel:]): (-[WebImmediateActionController _clearImmediateActionState]): (-[WebImmediateActionController _defaultAnimationController]): Keep track of the active QLPreviewMenuItem, and close it upon scroll. 2015-01-23 Timothy Horton Infinite recursion in _clearImmediateActionState https://bugs.webkit.org/show_bug.cgi?id=140807 Reviewed by Anders Carlsson. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _clearImmediateActionState]): Use this opportunity to bring identical code to WebKit1, to avoid getting DataDetectors stuck when an immediate action is canceled. 2015-01-22 Ryosuke Niwa Add a build flag for ES6 class syntax https://bugs.webkit.org/show_bug.cgi?id=140760 Reviewed by Michael Saboff. * Configurations/FeatureDefines.xcconfig: 2015-01-22 Beth Dakin ibtoold crash below -[WebView close] https://bugs.webkit.org/show_bug.cgi?id=140782 -and corresponding- rdar://problem/19558472 Reviewed by Tim Horton. Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but it is because interface builder is messing with our views. * WebView/WebImmediateActionController.h: * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController webViewClosed]): (-[WebImmediateActionController _cancelImmediateAction]): (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]): (-[WebImmediateActionController _updateImmediateActionItem]): 2015-01-21 Beth Dakin Crash in QuickLook preview delegate method https://bugs.webkit.org/show_bug.cgi?id=140740 -and corresponding- rdar://problem/19540806 Reviewed by Tim Horton. Clear out the delegate. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController webViewClosed]): 2015-01-21 Csaba Osztrogonác Remove ENABLE(INSPECTOR) ifdef guards https://bugs.webkit.org/show_bug.cgi?id=140668 Reviewed by Darin Adler. * Configurations/FeatureDefines.xcconfig: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillSendRequest): 2015-01-20 Anders Carlsson Remove USE(GLIB) code from WebKit1 https://bugs.webkit.org/show_bug.cgi?id=140714 Reviewed by Andreas Kling. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _close]): (-[WebView _clearGlibLoopObserver]): Deleted. (glibContextIterationCallback): Deleted. (-[WebView _scheduleGlibContextIterations]): Deleted. * WebView/WebViewData.h: * WebView/WebViewInternal.h: 2015-01-20 David Kilzer Switch to comparing PLATFORM_NAME in terms of macosx Reviewed by Timothy Hatcher. * MigrateHeaders.make: * postprocess-headers.sh: 2015-01-19 Myles C. Maxfield [SVG -> OTF Converter] Flip the switch on https://bugs.webkit.org/show_bug.cgi?id=140592 Reviewed by Antti Koivisto. * Configurations/FeatureDefines.xcconfig: 2015-01-19 Beth Dakin Speculative build fix. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): 2015-01-19 Beth Dakin Speculative build fix. * WebView/WebView.mm: (-[WebView _convertRectFromRootView:]): 2015-01-19 Timothy Horton Adjust naming of action menu SPI https://bugs.webkit.org/show_bug.cgi?id=140644 Reviewed by Brian Weinstein. * WebView/WebActionMenuController.mm: (-[WebActionMenuController prepareForMenu:withEvent:]): (-[WebActionMenuController willOpenMenu:withEvent:]): (-[WebActionMenuController didCloseMenu:withEvent:]): * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView prepareForMenu:withEvent:]): (-[WebView willOpenMenu:withEvent:]): (-[WebView didCloseMenu:withEvent:]): 2015-01-19 Beth Dakin REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is offset by flipped-ness https://bugs.webkit.org/show_bug.cgi?id=140643 -and corresponding- rdar://problem/19489593 Reviewed by Tim Horton. We universally flipped because we assumed that the root view was flipped and the WebView was not. However, in Dictionary, the WebView is flipped! So this patch fixes that assumption by checking the WebView’s flipped-ness. * WebView/WebView.mm: (-[WebView _convertRectFromRootView:]): 2015-01-19 Commit Queue Unreviewed, rolling out r178653. https://bugs.webkit.org/show_bug.cgi?id=140634 Broke multiple SVG tests on Mountain Lion (Requested by ap on #webkit). Reverted changeset: "[SVG -> OTF Converter] Flip the switch on" https://bugs.webkit.org/show_bug.cgi?id=140592 http://trac.webkit.org/changeset/178653 2015-01-19 Myles C. Maxfield [SVG -> OTF Converter] Flip the switch on https://bugs.webkit.org/show_bug.cgi?id=140592 Reviewed by Antti Koivisto. * Configurations/FeatureDefines.xcconfig: 2015-01-18 Daniel Bates Attempt to fix the iOS build after (https://bugs.webkit.org/show_bug.cgi?id=129441) Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight(). Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively. * WebInspector/WebNodeHighlightView.mm: (-[WebNodeHighlightView layoutSublayers:]): 2015-01-16 Beth Dakin Make sure early cancellation of immediate action actually does that in WK1 https://bugs.webkit.org/show_bug.cgi?id=140566 -and corresponding- rdar://problem/19490114 Reviewed by Tim Horton. Work around an AppKit bug by dispatching the call to _cancelImmediateAction asynchronously. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]): 2015-01-16 Daniel Bates Fix the public iOS SDK build after (https://bugs.webkit.org/show_bug.cgi?id=140360) Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS. * Misc/WebDownload.h: 2015-01-15 Csaba Osztrogonác Remove ENABLE(SQL_DATABASE) guards https://bugs.webkit.org/show_bug.cgi?id=140434 Reviewed by Darin Adler. * Configurations/FeatureDefines.xcconfig: * Storage/WebDatabaseManager.mm: (databasesDirectoryPath): * Storage/WebDatabaseManagerClient.h: * Storage/WebDatabaseManagerClient.mm: * Storage/WebDatabaseManagerInternal.h: * Storage/WebDatabaseManagerPrivate.h: * Storage/WebDatabaseQuotaManager.mm: (-[WebDatabaseQuotaManager usage]): (-[WebDatabaseQuotaManager quota]): (-[WebDatabaseQuotaManager setQuota:]): * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: * WebCoreSupport/WebSecurityOrigin.mm: (-[WebSecurityOrigin usage]): (-[WebSecurityOrigin quota]): (-[WebSecurityOrigin setQuota:]): * WebView/WebFrame.mm: (-[WebFrame _cacheabilityDictionary]): * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _preferencesChanged:]): 2015-01-14 Chris Dumez Make 'TypeName' parameter unnecessary in CSSPropertyNames.in https://bugs.webkit.org/show_bug.cgi?id=140347 Reviewed by Darin Adler. Call FontDescription::setIsItalic() instead of setItalic() as the call site passes a boolean. * WebView/WebHTMLView.mm: (fontNameForDescription): 2015-01-13 Anders Carlsson Temporarily reintroduce the informal delegate protocols https://bugs.webkit.org/show_bug.cgi?id=140416 Reviewed by Dan Bernstein. * WebView/WebEditingDelegate.h: * WebView/WebFrameLoadDelegate.h: * WebView/WebPolicyDelegate.h: * WebView/WebResourceLoadDelegate.h: * WebView/WebUIDelegate.h: 2015-01-13 Beth Dakin Should disable immediate actions for iTunes https://bugs.webkit.org/show_bug.cgi?id=140405 -and corresponding- rdar://problem/19461358 Reviewed by Tim Horton. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _updateImmediateActionItem]): 2015-01-11 Sam Weinig Remove support for SharedWorkers https://bugs.webkit.org/show_bug.cgi?id=140344 Reviewed by Anders Carlsson. * Configurations/FeatureDefines.xcconfig: * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::createSharedWorkerStrategy): Deleted. 2015-01-12 Timothy Horton Get rid of unnecessary reimplementations of CGFloor/Ceiling https://bugs.webkit.org/show_bug.cgi?id=140375 Reviewed by Simon Fraser. * Misc/WebKitNSStringExtras.mm: (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): (webkit_CGCeiling): Deleted. Delete unnecessary code, use the real CGFloor/Ceiling instead. 2015-01-12 Anders Carlsson Make delegates conform to formal delegate protocols https://bugs.webkit.org/show_bug.cgi?id=140370 Reviewed by Dan Bernstein. * DefaultDelegates/WebDefaultPolicyDelegate.h: * WebCoreSupport/WebInspectorClient.mm: Add protocols to the interface declarations. * WebView/WebActionMenuController.mm: (-[WebActionMenuController prepareForMenu:withEvent:]): (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]): * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _updateImmediateActionItem]): (-[WebImmediateActionController _menuItemForDataDetectedText]): Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate. 2015-01-12 Myles C. Maxfield Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER) https://bugs.webkit.org/show_bug.cgi?id=136769 Reviewed by Antti Koivisto. * Configurations/FeatureDefines.xcconfig: 2015-01-12 Timothy Horton Multi-rect TextIndicators are vertically flipped in WebKit1 https://bugs.webkit.org/show_bug.cgi?id=140350 Reviewed by Beth Dakin. * WebView/WebView.mm: (-[WebView _setTextIndicator:fadeOut:]): Convert the textBoundingRect from root view to screen coordinates. 2015-01-12 Anders Carlsson Make WebResourceDelegate a formal protocol as well https://bugs.webkit.org/show_bug.cgi?id=140364 Reviewed by Dan Bernstein. * WebView/WebResourceLoadDelegate.h: 2015-01-12 Anders Carlsson Delegates should be formal protocols https://bugs.webkit.org/show_bug.cgi?id=140360 rdar://problem/17380856 Reviewed by Dan Bernstein. This is the first half of this change. The second half involves actually changing the delegate properties to be protocols. * DefaultDelegates/WebDefaultUIDelegate.h: * Misc/WebDownload.h: * WebView/WebEditingDelegate.h: * WebView/WebFrameLoadDelegate.h: * WebView/WebPolicyDelegate.h: * WebView/WebUIDelegate.h: 2015-01-09 Anders Carlsson Get rid of the database strategy https://bugs.webkit.org/show_bug.cgi?id=140322 Reviewed by Sam Weinig. * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::createDatabaseStrategy): Deleted. 2015-01-08 Timothy Horton Can't use DataDetectors after immediate action preparation https://bugs.webkit.org/show_bug.cgi?id=140263 Reviewed by Beth Dakin. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]): (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]): To match WebKit2, only call shouldUseActions if the animation is actually going to begin, not when preparing for it. This way, we're guaranteed to get a didCancel or didComplete. 2015-01-08 Dean Jackson Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page https://bugs.webkit.org/show_bug.cgi?id=140232 Reviewed by Anders Carlsson. Remove the applicationChromeMode setting, but leave stubs in to make sure existing binaries don't break. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences applicationChromeModeEnabled]): (-[WebPreferences setApplicationChromeModeEnabled:]): * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2015-01-07 Daniel Bates [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT https://bugs.webkit.org/show_bug.cgi?id=137371 Reviewed by David Kilzer. Use SPI wrapper headers instead of directly references private SPI headers. * Plugins/Hosted/NetscapePluginHostManager.mm: 2015-01-07 Commit Queue Unreviewed, rolling out r178068. https://bugs.webkit.org/show_bug.cgi?id=140235 Breaks the iOS build (Requested by enrica on #webkit). Reverted changeset: "[iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT" https://bugs.webkit.org/show_bug.cgi?id=137371 http://trac.webkit.org/changeset/178068 2015-01-07 Daniel Bates [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT https://bugs.webkit.org/show_bug.cgi?id=137371 Reviewed by David Kilzer. Use SPI wrapper headers instead of directly references private SPI headers. * Plugins/Hosted/NetscapePluginHostManager.mm: 2015-01-07 Beth Dakin Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the link https://bugs.webkit.org/show_bug.cgi?id=140206 -and corresponding- rdar://problem/19300492 Reviewed by Tim Horton. Providing and item frame will ensure that the original link is not obscured. * WebView/WebImmediateActionController.mm: (elementBoundingBoxInWindowCoordinatesFromNode): (-[WebImmediateActionController menuItem:itemFrameForPoint:]): For now use a max size that is smaller than the WebView, with the screen’s aspect ratio, and scaled down. (-[WebImmediateActionController menuItem:maxSizeForPoint:]): 2015-01-07 Anders Carlsson Give simple HTML documents a database provider https://bugs.webkit.org/show_bug.cgi?id=140192 rdar://problem/19398825 Reviewed by Tim Horton. * WebView/WebView.mm: (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): 2015-01-06 Anders Carlsson Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler https://bugs.webkit.org/show_bug.cgi?id=140140 Reviewed by Andreas Kling. Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler out of WebCore since nobody else is using it. * Plugins/WebNetscapePluginView.h: * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView _createPlugin]): (-[WebNetscapePluginView _destroyPlugin]): * Plugins/npapi.mm: (NPN_PluginThreadAsyncCall): 2015-01-06 Anders Carlsson Add a WebKit1 database provider https://bugs.webkit.org/show_bug.cgi?id=140126 Reviewed by Sam Weinig. Set the database provider. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): 2015-01-06 Commit Queue Unreviewed, rolling out r177963. https://bugs.webkit.org/show_bug.cgi?id=140136 Caused lots of crashes (Requested by smfr on #webkit). Reverted changeset: "Add a WebKit1 database provider" https://bugs.webkit.org/show_bug.cgi?id=140126 http://trac.webkit.org/changeset/177963 2015-01-06 Anders Carlsson Add a WebKit1 database provider https://bugs.webkit.org/show_bug.cgi?id=140126 Reviewed by Sam Weinig. Set the database provider. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): 2015-01-01 Jeff Miller Update user-visible copyright strings to include 2015 https://bugs.webkit.org/show_bug.cgi?id=139880 Reviewed by Darin Adler. * Info.plist: 2014-12-30 Dan Bernstein [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY https://bugs.webkit.org/show_bug.cgi?id=140003 Reviewed by Darin Adler. * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function that takes their "string" parameter as a "value" "parameter and has an attribute telling the compiler that if the "value" parameter is a format string then the function returns a modified version of it. The result is that if UI_STRING is used as a format string parameter to some function or method, the compiler will check the format specifiers in the string against the other parameters. 2014-12-29 Dan Bernstein Fixed the iOS build. * Configurations/WebKitLegacy.xcconfig: 2014-12-29 Anders Carlsson Get rid of some PageGroup storage functions https://bugs.webkit.org/show_bug.cgi?id=139996 Reviewed by Sam Weinig. Call WebStorageNamespaceProvider directly instead. * Storage/WebStorageManager.mm: (-[WebStorageManager syncLocalStorage]): (+[WebStorageManager closeIdleLocalStorageDatabases]): * WebView/WebView.mm: (+[WebView _applicationWillTerminate]): 2014-12-29 Anders Carlsson Move storage code from WebCore to WebKit https://bugs.webkit.org/show_bug.cgi?id=139558 Reviewed by Darin Adler. * Storage/WebStorageManager.mm: * Storage/WebStorageTrackerClient.h: * WebView/WebView.mm: 2014-12-26 Dan Bernstein REGRESSION (r177027): iOS builds use the wrong toolchain https://bugs.webkit.org/show_bug.cgi?id=139950 Reviewed by David Kilzer. * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so in a manner that works with Xcode 5.1.1. 2014-12-23 Timothy Horton Install a TextIndicator for link immediate actions https://bugs.webkit.org/show_bug.cgi?id=139897 Reviewed by Anders Carlsson. * WebView/WebImmediateActionController.h: * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _clearImmediateActionState]): Tear down the TextIndicator, just like WebKit2. (-[WebImmediateActionController _defaultAnimationController]): Install a TextIndicator for links. (-[WebImmediateActionController menuItemDidClose:]): Tear down the TextIndicator when the QL preview closes. (-[WebImmediateActionController _menuItemForDataDetectedText]): Directly install and uninstall the TextIndicator for DataDetectors. (-[WebImmediateActionController _showTextIndicator]): Deleted. (-[WebImmediateActionController _hideTextIndicator]): Deleted. Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2. 2014-12-20 Eric Carlson [iOS] add optimized fullscreen API https://bugs.webkit.org/show_bug.cgi?id=139833 Reviewed by Simon Fraser. * Configurations/FeatureDefines.xcconfig: Add ENABLE_VIDEO_PRESENTATION_MODE. 2014-12-20 David Kilzer Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2 Reviewed by Mark Rowe. * Configurations/Base.xcconfig: - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS on OS X. - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK. * Configurations/DebugRelease.xcconfig: - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X. - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK. * Configurations/Version.xcconfig: - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X. * Configurations/WebKitLegacy.xcconfig: - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64, FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH, DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS, NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR, WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT, WEBCORE_PRIVATE_HEADERS_DIR_Production and WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering based on SDK. - Fix PRODUCTION_ROOT to actually be set properly. - Simplify EXPORTED_SYMBOLS_FILE_i386. * migrate-headers.sh: - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable. - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to WebKitLegacy.xcconfig. 2014-12-19 Simon Fraser Fix pink background on CoreAnimation plug-ins in WebKit1 https://bugs.webkit.org/show_bug.cgi?id=139845 rdar://problem/19313075 Reviewed by Tim Horton. r154078 left in some debugging code that set a pink background on plug-in hosting layers. Remove it. * Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView createPluginLayer]): 2014-12-19 Andreas Kling Ref-ify TextIterator API. Reviewed by Antti Koivisto. * WebView/WebTextIterator.mm: (-[WebTextIterator currentRange]): 2014-12-19 Joseph Pecoraro Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html https://bugs.webkit.org/show_bug.cgi?id=139797 Reviewed by Mark Lam. * WebView/WebScriptDebugger.h: * WebView/WebScriptDebugger.mm: (WebScriptDebugger::handlePause): Standardize on passing JSGlobalObject parameter first. 2014-12-19 Commit Queue Unreviewed, rolling out r177574. https://bugs.webkit.org/show_bug.cgi?id=139821 "Broke Production builds by installing libWebCoreTestSupport.dylib in the wrong directory" (Requested by ddkilzer on #webkit). Reverted changeset: "Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2" https://bugs.webkit.org/show_bug.cgi?id=139463 http://trac.webkit.org/changeset/177574 2014-12-19 David Kilzer Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2 Reviewed by Mark Rowe. * Configurations/Base.xcconfig: - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS on OS X. - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK. * Configurations/DebugRelease.xcconfig: - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X. - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK. * Configurations/Version.xcconfig: - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X. * Configurations/WebKitLegacy.xcconfig: - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64, FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH, DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS, NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR, WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT, WEBCORE_PRIVATE_HEADERS_DIR_Production and WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering based on SDK. - Fix PRODUCTION_ROOT to actually be set properly. - Simplify EXPORTED_SYMBOLS_FILE_i386. * migrate-headers.sh: - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable. - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to WebKitLegacy.xcconfig. 2014-12-18 Andreas Kling Ref-ify various Document-related things. Reviewed by Anders Carlsson. * WebView/WebFrame.mm: (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): 2014-12-18 Beth Dakin Need to re-enable action menus https://bugs.webkit.org/show_bug.cgi?id=139795 -and corresponding- rdar://problem/19299367 Reviewed by Tim Horton. Re-enable the menus by un-commenting the code to create the menu and controller. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): 2014-12-16 Sam Weinig Unify the Mac and iOS implementations of FontPlatformData a bit https://bugs.webkit.org/show_bug.cgi?id=139721 Reviewed by Anders Carlsson. * WebView/WebHTMLView.mm: (fontNameForDescription): Update for new function name. 2014-12-18 Antti Koivisto Remove alwaysUseBaselineOfPrimaryFont setting https://bugs.webkit.org/show_bug.cgi?id=139770 Reviewed by Anders Carlsson. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted. (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted. * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): (-[WebView _preferencesChanged:]): 2014-12-17 Andreas Kling Ref-ify Range::create(). Reviewed by Anders Carlsson. * WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]): * WebView/WebHTMLView.mm: (-[WebHTMLView attributedString]): 2014-12-17 Anders Carlsson Unify -[WebResource description] https://bugs.webkit.org/show_bug.cgi?id=139762 Reviewed by Dan Bernstein. * WebView/WebResource.mm: (-[WebResource description]): 2014-12-17 Anders Carlsson Get rid of an ugly #define hack in WebFrameLoaderClient https://bugs.webkit.org/show_bug.cgi?id=139761 Reviewed by Dan Bernstein. Also replace @private with @package in all public headers, for consistency. * History/WebBackForwardList.h: * History/WebHistory.h: * Misc/WebDownload.h: * WebCoreSupport/WebFrameLoaderClient.mm: * WebView/WebArchive.h: * WebView/WebDataSource.h: * WebView/WebFrame.h: * WebView/WebFrameView.h: * WebView/WebPreferences.h: * WebView/WebResource.h: 2014-12-17 Dan Bernstein WebKitLegacy is unusable due to bad dylib identifier https://bugs.webkit.org/show_bug.cgi?id=139760 Reviewed by Anders Carlsson. * Configurations/WebKitLegacy.xcconfig: 2014-12-17 Andreas Kling Purge PassRefPtr from Frame. Reviewed by Anders Carlsson. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): * WebView/WebFrame.mm: (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]): * WebView/WebFrameInternal.h: 2014-12-16 Timothy Horton Implement and adopt two new TextIndicator presentation animations https://bugs.webkit.org/show_bug.cgi?id=139715 Reviewed by Anders Carlsson. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _showTextIndicator]): * WebView/WebHTMLView.mm: (-[WebHTMLView quickLookWithEvent:]): Remove the completionHandler from text indicator presentation. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]): (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): (-[WebImmediateActionController _menuItemForDataDetectedText]): (-[WebImmediateActionController _animationControllerForText]): (-[WebImmediateActionController _showTextIndicator]): Forward immediate action gesture recognizer animation progress to TextIndicator. Force us to keep the selection when immediate action popovers steal first responder status from the WebView. If the Lookup range is equal to the selection range, use a Crossfade animation; otherwise, use a FadeIn animation. * WebView/WebView.mm: (-[WebView _setMaintainsInactiveSelection:]): (-[WebView maintainsInactiveSelection]): (-[WebView _animationControllerForDictionaryLookupPopupInfo:]): (-[WebView _setTextIndicator:fadeOut:]): (-[WebView _clearTextIndicator]): (-[WebView _setTextIndicatorAnimationProgress:]): (-[WebView _showDictionaryLookupPopup:]): (-[WebView _dictionaryLookupPopoverWillClose:]): (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]): Remove the completionHandler from text indicator presentation. Add a _setMaintainsInactiveSelection, which allows WebKit internals to change the return value of -maintainsInactiveSelection, allowing us to keep the selection alive when the WebView loses first responder status. * WebView/WebViewData.h: * WebView/WebViewInternal.h: 2014-12-16 Andreas Kling Use Ref for SecurityOrigin. Reviewed by Anders Carlsson. * Storage/WebStorageTrackerClient.mm: (WebStorageTrackerClient::dispatchDidModifyOrigin): * WebView/WebView.mm: (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]): (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]): 2014-12-16 Beth Dakin Crash getting default animation controller for some text https://bugs.webkit.org/show_bug.cgi?id=139712 -and corresponding- rdar://problem/19271707 Reviewed by Tim Horton. Must null-check the range. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _animationControllerForText]): 2014-12-16 Timothy Horton Immediate action popovers can get stuck open https://bugs.webkit.org/show_bug.cgi?id=139709 Reviewed by Beth Dakin. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _clearImmediateActionState]): Don't clear the animation controller; it breaks things and was unnecessary. 2014-12-16 Tim Horton Disable TextIndication for Lookup immediate actions https://bugs.webkit.org/show_bug.cgi?id=139684 Reviewed by Anders Carlsson. * WebView/WebView.mm: (-[WebView _animationControllerForDictionaryLookupPopupInfo:]): 2014-12-15 Beth Dakin Build fix. * WebView/WebImmediateActionController.mm: 2014-12-15 Beth Dakin Speculative build fix. * WebView/WebView.mm: (-[WebView _animationControllerForDictionaryLookupPopupInfo:]): * WebView/WebViewInternal.h: 2014-12-15 Beth Dakin Make lookup an immediate action instead of an action menu item https://bugs.webkit.org/show_bug.cgi?id=139661 -and corresponding- rdar://problem/19198414 Reviewed by Tim Horton. Remove the lookup menu items and non-unused static function associated with lookup. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _defaultMenuItemsForText]): (-[WebActionMenuController _defaultMenuItemsForEditableText]): (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]): (-[WebActionMenuController _createActionMenuItemForTag:]): (-[WebActionMenuController _lookupText:]): Deleted. (performDictionaryLookupForSelection): Deleted. (performDictionaryLookupForRange): Deleted. Set the defaultAnimationController to the lookup-provided animation controller when appropriate. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _defaultAnimationController]): (dictionaryPopupInfoForRange): (-[WebImmediateActionController _animationControllerForText]): New type. * WebView/WebUIDelegatePrivate.h: New function to get the lookup animation controller. * WebView/WebView.mm: (-[WebView _animationControllerForDictionaryLookupPopupInfo:]): * WebView/WebViewInternal.h: 2014-12-15 Timothy Horton Implement Data Detectors immediate actions for Legacy WebKit https://bugs.webkit.org/show_bug.cgi?id=139619 Reviewed by Beth Dakin. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _menuItemForDataDetectedText]): Note that this action context is only for immediate actions. 2014-12-15 Myles C. Maxfield Addressing post-review comments in r177035 https://bugs.webkit.org/show_bug.cgi?id=139557 Reviewed by Darin Adler. * WebView/WebActionMenuController.mm: (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox(). 2014-12-15 Timothy Horton Implement Data Detectors immediate actions for Legacy WebKit https://bugs.webkit.org/show_bug.cgi?id=139619 Reviewed by Eric Carlson. * WebView/WebHTMLView.mm: (-[WebHTMLView mouseDown:mouseDown:]): Send mouseDown along to the WebImmediateActionController too. * WebView/WebImmediateActionController.h: * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController webViewClosed]): (-[WebImmediateActionController webView:willHandleMouseDown:]): (-[WebImmediateActionController _cancelImmediateAction]): (-[WebImmediateActionController _clearImmediateActionState]): (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]): (-[WebImmediateActionController _defaultAnimationController]): (-[WebImmediateActionController _updateImmediateActionItem]): (-[WebImmediateActionController _menuItemForDataDetectedText]): (-[WebImmediateActionController _showTextIndicator]): (-[WebImmediateActionController _hideTextIndicator]): Copy most of the DataDetectors implementation into WebImmediateActionController. * WebView/WebUIDelegatePrivate.h: Add a new type. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Temporarily disable action menus. (-[WebView _immediateActionController]): * WebView/WebViewInternal.h: 2014-12-15 Myles C. Maxfield Delete Notation because we don't use it https://bugs.webkit.org/show_bug.cgi?id=139171 Reviewed by Kent Tamura. * MigrateHeaders.make: 2014-12-14 Andreas Kling Replace PassRef with Ref/Ref&& across the board. Reviewed by Darin Adler. * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldApplyStyle): * WebCoreSupport/WebVisitedLinkStore.h: * WebCoreSupport/WebVisitedLinkStore.mm: (WebVisitedLinkStore::create): 2014-12-11 Dan Bernstein Fix a leak introduced in r177199. Reviewed by Anders Carlsson. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _updateImmediateActionItem]): 2014-12-11 Beth Dakin WK1: Need new SPI for Webkit clients to override default immediate action https://bugs.webkit.org/show_bug.cgi?id=139568 -and corresponding- rdar://problem/19225448 Reviewed by Dan Bernstein. Call SPI giving clients a chance to override the default behavior. * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController _updateImmediateActionItem]): New SPI. * WebView/WebUIDelegatePrivate.h: 2014-12-11 Timothy Horton Move the preview popover to WebImmediateActionController https://bugs.webkit.org/show_bug.cgi?id=139563 Reviewed by Beth Dakin. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _defaultMenuItemsForLink]): (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted. (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted. (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted. * WebView/WebImmediateActionController.h: * WebView/WebImmediateActionController.mm: (-[WebImmediateActionController webViewClosed]): (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]): (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]): (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): (-[WebImmediateActionController _updateImmediateActionItem]): (-[WebImmediateActionController menuItem:viewAtScreenPoint:]): (-[WebImmediateActionController menuItem:previewItemAtPoint:]): (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]): Move page preview popover related code to WebImmediateActionController. * WebView/WebUIDelegatePrivate.h: Add a link preview type. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Pass the gesture recognizer to the WebImmediateActionController. 2014-12-11 Timothy Horton Fix the build. * WebView/WebImmediateActionController.h: * WebView/WebImmediateActionController.mm: 2014-12-11 Anders Carlsson Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit https://bugs.webkit.org/show_bug.cgi?id=139547 Reviewed by Sam Weinig. * WebView/WebView.mm: (+[WebView _handleMemoryWarning]): 2014-12-11 Alexey Proskuryakov REGRESSION (Async Text Input): Text input method state is not reset when reloading a page https://bugs.webkit.org/show_bug.cgi?id=139504 rdar://problem/19034674 Reviewed by Enrica Casucci. Stub out new client calls, this patch does not attempt to make any changes on WebKit1. * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::discardedComposition): 2014-12-10 Anders Carlsson Get rid of the storage strategy https://bugs.webkit.org/show_bug.cgi?id=139519 Reviewed by Antti Koivisto. * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::createStorageStrategy): Deleted. 2014-12-10 Timothy Horton Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1 https://bugs.webkit.org/show_bug.cgi?id=139529 Reviewed by Beth Dakin. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _copySelection:]): (-[WebActionMenuController _paste:]): Use the copy: and paste: methods on WebView so that we traverse subviews when trying to respond, otherwise these actions don't work in subframes. 2014-12-10 Beth Dakin WK1: Add initial support for immediate actions https://bugs.webkit.org/show_bug.cgi?id=139522 Reviewed by Dan Bernstein. This basic implementation of the controller will use the delegate methods to perform and cache a HitTest when relevant. Future patches will patch _updateImmediateActionItem to use the HitTestResult to determine if there is any immediate action that should be taken. * WebView/WebImmediateActionController.h: Added. * WebView/WebImmediateActionController.mm: Added. (-[WebImmediateActionController webViewClosed]): (-[WebImmediateActionController _clearImmediateActionState]): (-[WebImmediateActionController performHitTestAtPoint:]): (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]): (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]): (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): (-[WebImmediateActionController _updateImmediateActionItem]): New enum for immediate action types. * WebView/WebUIDelegatePrivate.h: Create an NSImmediateActionGestureRecognizer if possible and a controller. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _close]): * WebView/WebViewData.h: * WebView/WebViewData.mm: (-[WebViewPrivate dealloc]): 2014-12-08 Anders Carlsson Use the new storage namespace provider in WebKit1 https://bugs.webkit.org/show_bug.cgi?id=139425 Reviewed by Tim Horton. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Set the storage namespace provider from the web page group. 2014-12-10 Timothy Horton Should have copy and paste items in all text menus https://bugs.webkit.org/show_bug.cgi?id=139510 Reviewed by Beth Dakin. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _defaultMenuItemsForText]): Add a disabled paste menu item into the read-only text menu. (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]): Add a disabled copy menu item into the editable whitespace text menu. 2014-12-10 Anders Carlsson Add WebStorageNamespaceProvider::closeLocalStorage https://bugs.webkit.org/show_bug.cgi?id=139502 Reviewed by Tim Horton. * WebView/WebView.mm: (+[WebView _applicationWillTerminate]): Call WebStorageNamespaceProvider::closeLocalStorage. 2014-12-09 Commit Queue Unreviewed, rolling out r177037. https://bugs.webkit.org/show_bug.cgi?id=139464 broke ~50 API tests (Requested by thorton on #webkit). Reverted changeset: "Use the new storage namespace provider in WebKit1" https://bugs.webkit.org/show_bug.cgi?id=139425 http://trac.webkit.org/changeset/177037 2014-12-08 Anders Carlsson Use the new storage namespace provider in WebKit1 https://bugs.webkit.org/show_bug.cgi?id=139425 Reviewed by Tim Horton. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Set the storage namespace provider from the web page group. 2014-12-09 Myles C. Maxfield Delete Node::boundingBox() https://bugs.webkit.org/show_bug.cgi?id=139333 Reviewed by Zalan Bujtas. * WebView/WebActionMenuController.mm: (elementBoundingBoxInWindowCoordinatesFromNode): Use RenderObject::absoluteBoundingBoxRect(). 2014-12-08 Alexey Proskuryakov REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge https://bugs.webkit.org/show_bug.cgi?id=138843 rdar://problem/18793695 Reviewed by Dan Bernstein. * Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel cancel:]): (-[WebAuthenticationPanel logIn:]): Don't close the panel before using panel.sheetParent, because the parent becomes nil. In fact, we don't need to close it at all, it's enough to call orderOut:, and even that only when using an old NSWindow API. 2014-12-08 Beth Dakin Copy and Lookup menu items should be disabled when something is not copyable https://bugs.webkit.org/show_bug.cgi?id=139423 Reviewed by Tim Horton. Disable both lookup and copy when a HitTestResult does not allow copy. * WebView/WebActionMenuController.mm: Set autoenablesItems to NO. It’s messing with our ability to control the enable/ disable state otherwise. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): 2014-12-08 Anders Carlsson Adding user content to a group should force that group to be created https://bugs.webkit.org/show_bug.cgi?id=139421 rdar://problem/19180108 Reviewed by Sam Weinig. * WebCoreSupport/WebViewGroup.h: Store the local storage database path in the group. * WebCoreSupport/WebViewGroup.mm: (WebViewGroup::getOrCreate): If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty, set it. This will ensure that getOrCreate will still work when creating a storage namspace provider. (WebViewGroup::WebViewGroup): Initialize the new member variable. (WebViewGroup::storageNamespaceProvider): Create the namespace provider lazily. * WebView/WebView.mm: (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]): (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]): Use getOrCreate instead of get. 2014-12-08 Anders Carlsson WebStorageNamespaceProvider should know about its local storage database path https://bugs.webkit.org/show_bug.cgi?id=139413 Reviewed by Andreas Kling. * WebCoreSupport/WebViewGroup.h: * WebCoreSupport/WebViewGroup.mm: (WebViewGroup::getOrCreate): (WebViewGroup::WebViewGroup): * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): (-[WebView setGroupName:]): (-[WebView groupName]): Deleted. 2014-12-08 Daniel Bates [iOS] Fix the WebKit build with the public SDK Include header NSURLDownloadSPI.h. * WebCoreSupport/WebFrameLoaderClient.mm: 2014-12-07 Dan Bernstein Introduce and deploy a function that allocates and returns an instance of a soft-linked class https://bugs.webkit.org/show_bug.cgi?id=139348 Reviewed by Anders Carlsson. In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus avoiding the ambiguity. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]): 2014-12-06 Anders Carlsson Add a stubbed out version of WebStorageNamespaceProvider https://bugs.webkit.org/show_bug.cgi?id=139213 Reviewed by Sam Weinig. * WebCoreSupport/WebViewGroup.h: (WebViewGroup::storageNamespaceProvider): * WebCoreSupport/WebViewGroup.mm: (WebViewGroup::getOrCreate): (WebViewGroup::WebViewGroup): Give WebViewGroup a storage namespace provider. 2014-12-06 Anders Carlsson Fix build with newer versions of clang. rdar://problem/18978687 Add missing overrides and missing casts. * Storage/WebDatabaseManagerClient.h: * Storage/WebStorageTrackerClient.h: * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebInspectorClient.h: * WebView/WebDataSource.mm: (-[WebDataSource _makeRepresentation]): * WebView/WebFrameView.mm: (-[WebFrameView _makeDocumentViewForDataSource:]): 2014-12-05 Tim Horton Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame https://bugs.webkit.org/show_bug.cgi?id=139306 Reviewed by Beth Dakin. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _initWithFrame:frameName:groupName:]): Move setDeviceScaleFactor to the initialization path that is guaranteed to happen. 2014-12-05 David Kilzer FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY Reviewed by Daniel Bates. * Configurations/FeatureDefines.xcconfig: Switch back to using PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8. 2014-12-04 Timothy Horton Fix the 32-bit build. * WebView/WebView.mm: (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]): 2014-12-04 Tim Horton TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2 https://bugs.webkit.org/show_bug.cgi?id=139252 Reviewed by Anders Carlsson. * WebView/WebView.mm: (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]): Adjust to the WebCore changes. 2014-12-03 Timothy Horton Implement action menus for tel: URLs https://bugs.webkit.org/show_bug.cgi?id=139240 Reviewed by Anders Carlsson. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]): Make sure to use the newly created currentActionContext... everywhere. 2014-12-03 Timothy Horton Implement action menus for tel: URLs https://bugs.webkit.org/show_bug.cgi?id=139240 Reviewed by Anders Carlsson. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]): Make sure to use the newly created currentActionContext. 2014-12-03 Beth Dakin elements get whitespace action menu instead of editable text menu https://bugs.webkit.org/show_bug.cgi?id=139241 -and corresponding- rdar://problem/19072083 Reviewed by Sam Weinig. We should disallow shadow content in the hit test. This is the default and it is how context menus behave. We originally wanted to text inside shadow content so that we could find the text, but the new function I added to HitTestResult will allow that. * WebView/WebActionMenuController.mm: (-[WebActionMenuController performHitTestAtPoint:]): Adjust to the fact that we don’t hit test shadow content any more. (-[WebActionMenuController focusAndSelectHitTestResult]): Offer the text menus for text inside form controls. (-[WebActionMenuController _defaultMenuItems]): 2014-12-03 Tim Horton Implement action menus for tel: URLs https://bugs.webkit.org/show_bug.cgi?id=139240 Reviewed by Anders Carlsson. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]): Rename this function as it will work for both mailto and tel URLs. Adjust it to use contextForView:. (-[WebActionMenuController webView:willHandleMouseDown:]): (-[WebActionMenuController prepareForMenu:withEvent:]): (-[WebActionMenuController didCloseMenu:withEvent:]): (-[WebActionMenuController _defaultMenuItems]): Don't check the menu type when going to interact with _currentActionContext. We'll only have a _currentActionContext if we have a data detected item, and there are multiple menu types that end up using DDActionContext. * WebView/WebUIDelegatePrivate.h: Add a new type. 2014-12-03 Anders Carlsson Set a visited link store when creating a simple WebView https://bugs.webkit.org/show_bug.cgi?id=139234 Reviewed by Sam Weinig. * WebView/WebView.mm: (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): 2014-12-02 Timothy Horton Fix the build. * WebCoreSupport/WebFrameLoaderClient.mm: 2014-12-02 Alexey Proskuryakov http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests https://bugs.webkit.org/show_bug.cgi?id=139149 Reviewed by Anders Carlsson. This changes API behavior. I think that it's OK, because existing behavior made no sense. We used to delete caches from disk, but they were still active in memory. Now we also obsolete them in memory, so documents that use a cache still work, but new ones don't pick one up. * WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't need to delete in-momry caches too. Keep existing behavior. (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function that properly deletes caches. 2014-12-02 Tim Horton Remove a SnowLeopard-era quirk for QuickLook https://bugs.webkit.org/show_bug.cgi?id=139208 Reviewed by Alexey Proskuryakov. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: 2014-12-02 Tim Horton Loading Lookup causes http/tests/cache/post-redirect-get.php to fail https://bugs.webkit.org/show_bug.cgi?id=139204 Reviewed by Anders Carlsson. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _showDictionaryLookupPopup:]): * WebView/WebViewData.h: Work around this by delaying the softlinking (and setting up the notification observer) until we actually need it. There's still an underlying bug, but this will fix the test. 2014-12-02 Beth Dakin Yet another build fix. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _defaultMenuItemsForLink]): 2014-12-02 Beth Dakin Build fix. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _defaultMenuItemsForLink]): 2014-12-02 Beth Dakin More build fixing. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _defaultMenuItemsForLink]): 2014-12-02 Beth Dakin Should use standardQuickLookMenuItem for apps that don't implement customizations https://bugs.webkit.org/show_bug.cgi?id=139193 -and corresponding- rdar://problem/18944696 Reviewed by Anders Carlsson. Use [NSMenuItem standardQuickLookMenuItem]. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _defaultMenuItemsForLink]): Delegate methods to set up the standardQuickLookMenuItem. (-[WebActionMenuController menuItem:viewAtScreenPoint:]): (-[WebActionMenuController menuItem:previewItemAtPoint:]): (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Remove all of the old QLPreviewBubble code. (-[WebActionMenuController _createActionMenuItemForTag:]): (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted. 2014-12-02 Timothy Horton Fix the build. * WebView/WebViewData.h: 2014-12-02 Tim Horton Implement Lookup transition from selection for Legacy WebKit https://bugs.webkit.org/show_bug.cgi?id=139180 Reviewed by Beth Dakin. * WebView/DictionaryPopupInfo.h: Added. Split DictionaryPopupInfo out into its own file. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _lookupText:]): Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup. (performDictionaryLookupForSelection): (performDictionaryLookupForRange): Plumb the transition style through these helpers. Create a TextIndicator from the selection range. * WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Make use of TextIndicator (and DictionaryPopupInfo, and the new _showDictionaryLookupPopup on WebView) to add a transition from blue when performing Lookup from the context menu. (-[WebHTMLView quickLookWithEvent:]): Remove our TextIndicator whenever a normal three-finger-tap event comes through, as it will have its own indication. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _dictionaryLookupPopoverWillClose:]): Register for the LUNotificationPopoverWillClose notification and remove our TextIndicator when it is called, just like in WebKit2. Deregistration is already handled in _close. (-[WebView _showDictionaryLookupPopup:]): Just like WebKit2, show our TextIndicator and tell Lookup not to show its own, if the relevant API is available. * WebView/WebViewInternal.h: 2014-12-02 Anders Carlsson Remove visited link handling from PageGroup https://bugs.webkit.org/show_bug.cgi?id=139185 Reviewed by Sam Weinig. * History/WebHistory.mm: (-[WebHistoryPrivate removeItemForURLString:]): (-[WebHistoryPrivate removeAllItems]): (+[WebHistory setOptionalSharedHistory:]): (+[WebHistory _setVisitedLinkTrackingEnabled:]): (+[WebHistory _removeAllVisitedLinks]): (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted. (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted. * History/WebHistoryInternal.h: * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::populateVisitedLinks): Deleted. * WebView/WebView.mm: (-[WebView addVisitedLinks:]): (-[WebView removeVisitedLink:]): 2014-12-01 Timothy Horton Try to fix the Mac build. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _close]): 2014-12-01 Timothy Horton Fix the iOS build. * WebView/WebActionMenuController.h: * WebView/WebActionMenuController.mm: * WebView/WebHTMLView.mm: (-[WebHTMLView scrollWheel:scrollWheel:]): (-[WebHTMLView mouseDown:mouseDown:]): * WebView/WebView.mm: * WebView/WebViewData.h: * WebView/WebViewData.mm: (-[WebViewPrivate dealloc]): * WebView/WebViewInternal.h: 2014-12-01 Tim Horton Implement yellow highlight for WebKit1 data detectors https://bugs.webkit.org/show_bug.cgi?id=138956 Reviewed by Beth Dakin. * WebView/WebActionMenuController.h: * WebView/WebActionMenuController.mm: (-[WebActionMenuController webView:willHandleMouseDown:]): (-[WebActionMenuController webView:didHandleScrollWheel:]): (-[WebActionMenuController prepareForMenu:withEvent:]): (-[WebActionMenuController didCloseMenu:withEvent:]): (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]): (-[WebActionMenuController _showTextIndicator]): (-[WebActionMenuController _hideTextIndicator]): (-[WebActionMenuController _dismissActionMenuPopovers]): Copy the WebKit2 WKActionMenuController TextIndicator implementation into WebActionMenuController. The only significant difference is that we build the TextIndicator right at menu construction time instead of in the Web process. * WebView/WebHTMLView.mm: (-[WebHTMLView scrollWheel:]): Let the WebActionMenuController know that we're handling a scroll. (-[WebHTMLView mouseDown:]): Let the WebActionMenuController know that we're handling a mouseDown. * WebView/WebView.mm: (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]): (-[WebView _clearTextIndicator]): (-[WebView _actionMenuController]): (-[WebView _convertRectFromRootView:]): Deleted. * WebView/WebViewData.h: * WebView/WebViewData.mm: * WebView/WebViewInternal.h: Keep a TextIndicatorWindow on WebView, just like WKView does. Expose the WebActionMenuController on WebView (internally). 2014-12-01 Anders Carlsson Remove old site specific quirks code that was added in 2009 https://bugs.webkit.org/show_bug.cgi?id=139141 Reviewed by Antti Koivisto. * WebCoreSupport/WebFrameNetworkingContext.h: * WebCoreSupport/WebFrameNetworkingContext.mm: (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted. 2014-11-30 Anders Carlsson Fix a test failure. * History/WebHistory.mm: (+[WebHistory _setVisitedLinkTrackingEnabled:]): Call through to the visited link store. (+[WebHistory _removeAllVisitedLinks]): Ditto. * WebCoreSupport/WebVisitedLinkStore.mm: (WebVisitedLinkStore::isLinkVisited): Make sure to populate visited links. 2014-11-30 Anders Carlsson Switch over to the visited link store from the WebViewGroup https://bugs.webkit.org/show_bug.cgi?id=139112 Reviewed by Sam Weinig. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView setGroupName:]): 2014-11-30 Anders Carlsson Add WebVisitedLinkStore::removeVisitedLink and use it on iOS https://bugs.webkit.org/show_bug.cgi?id=139111 Reviewed by Sam Weinig. * WebCoreSupport/WebVisitedLinkStore.h: * WebCoreSupport/WebVisitedLinkStore.mm: (WebVisitedLinkStore::removeVisitedLink): * WebView/WebView.mm: (-[WebView removeVisitedLink:]): 2014-11-29 Anders Carlsson Populate visited links https://bugs.webkit.org/show_bug.cgi?id=139101 Reviewed by Sam Weinig. * History/WebHistory.mm: (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]): Helper function that adds all visited link to the given store. (-[WebHistory _addVisitedLinksToVisitedLinkStore:]): Call the private method. * History/WebHistoryInternal.h: * WebCoreSupport/WebVisitedLinkStore.h: Add new members. * WebCoreSupport/WebVisitedLinkStore.mm: (WebVisitedLinkStore::addVisitedLink): Get the characters from the URL string and hash them, then call addVisitedLinkHash. (WebVisitedLinkStore::populateVisitedLinksIfNeeded): Implement this. First try the delegate, then try the shared history. (WebVisitedLinkStore::addVisitedLinkHash): Factor code that adds the link to the hash table into a separate function. * WebView/WebView.mm: (-[WebView addVisitedLinks:]): Add the visited links to the store. 2014-11-29 Anders Carlsson More work on the legacy WebKit visited link store https://bugs.webkit.org/show_bug.cgi?id=139100 Reviewed by Sam Weinig. * History/WebHistory.mm: (+[WebHistory setOptionalSharedHistory:]): Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks. * WebCoreSupport/WebVisitedLinkStore.h: * WebCoreSupport/WebVisitedLinkStore.mm: (visitedLinkStores): (WebVisitedLinkStore::WebVisitedLinkStore): (WebVisitedLinkStore::~WebVisitedLinkStore): Keep track of live visited link stores. (WebVisitedLinkStore::setShouldTrackVisitedLinks): Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary. (WebVisitedLinkStore::removeAllVisitedLinks): Iterate over all live link stores and remove their links. (WebVisitedLinkStore::isLinkVisited): Populate visited links and check if our hash table contains the link. (WebVisitedLinkStore::addVisitedLink): Add the link hash to the table. (WebVisitedLinkStore::populateVisitedLinksIfNeeded): Add stub. (WebVisitedLinkStore::removeVisitedLinkHashes): Clear out the hash table. 2014-11-27 Anders Carlsson Add a stubbed out WebVisitedLinkStore to WebViewGroup https://bugs.webkit.org/show_bug.cgi?id=139066 Reviewed by Antti Koivisto. * WebCoreSupport/WebViewGroup.h: (WebViewGroup::visitedLinkStore): * WebCoreSupport/WebViewGroup.mm: (WebViewGroup::WebViewGroup): * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h. * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h. (WebVisitedLinkStore::create): (WebVisitedLinkStore::WebVisitedLinkStore): (WebVisitedLinkStore::~WebVisitedLinkStore): (WebVisitedLinkStore::isLinkVisited): (WebVisitedLinkStore::addVisitedLink): 2014-11-25 Anders Carlsson Remove user content handling from PageGroup https://bugs.webkit.org/show_bug.cgi?id=139051 Reviewed by Antti Koivisto. Use the user content controller in the web view group. * WebView/WebView.mm: (-[WebView _injectOutlookQuirksScript]): 2014-11-25 Anders Carlsson Add a user content controller to WebViewGroup and use it for user content https://bugs.webkit.org/show_bug.cgi?id=139043 Reviewed by Antti Koivisto. This is another tiny step towards getting rid of user content handling inside PageGroup. * WebCoreSupport/WebViewGroup.h: (WebViewGroup::userContentController): Add a UserContentController member and getter. * WebCoreSupport/WebViewGroup.mm: (WebViewGroup::get): Helper function that returns a WebViewGroup by its name (or null if it doesn't exist). (WebViewGroup::WebViewGroup): Create a user content controller. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can set its user content controller in the PageConfiguration. (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Ditto. (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]): (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]): (+[WebView _removeUserScriptFromGroup:world:url:]): (+[WebView _removeUserStyleSheetFromGroup:world:url:]): (+[WebView _removeUserScriptsFromGroup:world:]): (+[WebView _removeUserStyleSheetsFromGroup:world:]): (+[WebView _removeAllUserContentFromGroup:]): Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that. (-[WebView setGroupName:]): Set the user content controller to the new WebViewGroup's user content controller. 2014-11-21 Jer Noble Support multiple signatures of diagnostic logging. https://bugs.webkit.org/show_bug.cgi?id=138690 Reviewed by Anders Carlsson. Page::PageClients has been renamed PageConfiguration. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): 2014-11-21 Zalan Bujtas Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser. https://bugs.webkit.org/show_bug.cgi?id=138981 Reviewed by Simon Fraser. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences simpleLineLayoutDebugBordersEnabled]): (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2014-11-21 Tim Horton REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able ​https://bugs.webkit.org/show_bug.cgi?id=138960 Reviewed by Anders Carlsson. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _defaultMenuItemsForMailtoLink]): (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]): Use DataDetectors SPI instead of an explicit blacklist. 2014-11-21 Tim Horton REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able https://bugs.webkit.org/show_bug.cgi?id=138960 Reviewed by Beth Dakin. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]): Blacklist contact results, because they don't have useful menus. If we bail before setting up _currentActionContext, we'll still allow fallthrough to ordinary text actions, avoiding mysterious failure when a contact is detected. This doesn't break the case that r176351 was intended to fix, because in that case we were detecting e.g. addresses. 2014-11-21 Anders Carlsson Remove the Timer parameters from timer callbacks https://bugs.webkit.org/show_bug.cgi?id=138974 Reviewed by Antti Koivisto. * Plugins/Hosted/NetscapePluginInstanceProxy.h: * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): (WebKit::NetscapePluginInstanceProxy::requestTimerFired): * Plugins/WebNetscapePluginStream.h: * Plugins/WebNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream): (WebNetscapePluginStream::deliverDataTimerFired): 2014-11-21 Anders Carlsson Make memoryCache() return a reference https://bugs.webkit.org/show_bug.cgi?id=138939 Reviewed by Antti Koivisto. * Misc/WebCache.mm: (+[WebCache statistics]): (+[WebCache emptyInMemoryResources]): (+[WebCache sizeOfDeadResources:]): (+[WebCache addImageToCache:forURL:forFrame:]): (+[WebCache removeImageFromCacheForURL:forFrame:]): (+[WebCache imageForURL:]): (+[WebCache setDisabled:]): (+[WebCache isDisabled]): * WebView/WebView.mm: (+[WebView _setCacheModel:]): 2014-11-20 Benjamin Poulain Remove the remaining vestiges of minimal-ui https://bugs.webkit.org/show_bug.cgi?id=138890 Reviewed by Sam Weinig. * History/WebHistoryItem.mm: * History/WebHistoryItemPrivate.h: 2014-11-20 Tim Horton Cancel DataDetectors menu earlier if we know it can't be presented https://bugs.webkit.org/show_bug.cgi?id=138922 Reviewed by Beth Dakin. * WebView/WebActionMenuController.mm: (-[WebActionMenuController prepareForMenu:withEvent:]): Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate, and use a bigger hammer (removeAllItems). (-[WebActionMenuController willOpenMenu:withEvent:]): If we end up with a menu with no items, don't change selection or anything. 2014-11-20 Beth Dakin Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result https://bugs.webkit.org/show_bug.cgi?id=138568 -and corresponding- rdar://problem/18904600 Reviewed by Tim Horton. Skip images for lookup. * WebView/WebActionMenuController.mm: (performDictionaryLookupForRange): 2014-11-19 Beth Dakin Invoking an action menu on a selection should result in the text menu https://bugs.webkit.org/show_bug.cgi?id=138892 -and corresponding- rdar://problem/18996776 Reviewed by Tim Horton. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _defaultMenuItems]): 2014-11-19 Beth Dakin Data detected results with no menu items should not fall through to regular text action menus https://bugs.webkit.org/show_bug.cgi?id=138887 -and corresponding- rdar://problem/18971616 Reviewed by Tim Horton. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _defaultMenuItems]): 2014-11-19 Daniel Bates [iOS] Make WebKit build with public iOS SDK https://bugs.webkit.org/show_bug.cgi?id=136863 Reviewed by David Kilzer. * History/WebHistory.mm: Include header NSCalendarDateSPI.h. * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h. * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h. We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header may be used by Apple internal clients that do not include wtf/Platform.h. * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including private Foundation headers directly. * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header. * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h instead of including private CFNetwork headers directly. Also fixed up style and ordering of header include directives. * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private CFNetwork headers directly. Also sort the #import directives. * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions. 2014-11-18 David Kilzer FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors Reviewed by Mark Rowe. * Configurations/FeatureDefines.xcconfig: Switch to using SDK selectors. 2014-11-18 Chris Dumez Add a setting to toggle DOMTimer throttling support https://bugs.webkit.org/show_bug.cgi?id=138844 Reviewed by Andreas Kling. Add a setting to disable DOM timers throttling, in order to help developers determine if a specific issue is caused by timer throttling. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences domTimersThrottlingEnabled]): (-[WebPreferences setDOMTimersThrottlingEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2014-11-18 Tim Horton Avoid re-encoding action menu image data https://bugs.webkit.org/show_bug.cgi?id=138817 Reviewed by Anders Carlsson. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _defaultMenuItemsForImage:]): (-[WebActionMenuController _addImageToPhotos:]): Build a temporary filename from a UUID and the image's desired extension. Use the Image's encoded data instead of re-encoding it with CGImageDestination. Build an image menu only if we have an image, URL, data, and extension. 2014-11-18 Daniel Bates [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt SPI are not available in public SDK https://bugs.webkit.org/show_bug.cgi?id=138802 Reviewed by David Kilzer. Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including libdispatch and MobileGestalt headers directly. * WebView/WebView.mm: 2014-11-17 Brian Weinstein Remove calls to deprecated NSMenu methods https://bugs.webkit.org/show_bug.cgi?id=138808. Reviewed by Anders Carlsson. -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6. * WebCoreSupport/PopupMenuMac.mm: (PopupMenuMac::populate): 2014-11-17 Daniel Bates Unreviewed, rolling out r176232. Broke the Mac build. Will investigate offline. Reverted changeset: "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt" https://bugs.webkit.org/show_bug.cgi?id=138802 http://trac.webkit.org/changeset/176232 2014-11-17 Daniel Bates [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt SPI are not available in public SDK https://bugs.webkit.org/show_bug.cgi?id=138802 Reviewed by David Kilzer. Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including libdispatch and MobileGestalt headers directly. * WebView/WebView.mm: 2014-11-17 Beth Dakin Whitespace action menus should focus the HitTestResult and create an insertion point https://bugs.webkit.org/show_bug.cgi?id=138786 -and corresponding- rdar://problem/18944893 Reviewed by Tim Horton. Whitespace menus should cause the HitTestResult to be focused, and they should set the selection based on the HitTest location. * WebView/WebActionMenuController.mm: (-[WebActionMenuController isMenuForTextContent]): (-[WebActionMenuController focusAndSelectHitTestResult]): (-[WebActionMenuController willOpenMenu:withEvent:]): 2014-11-17 Daniel Bates [iOS] QuartzCore SPI not available in public SDK https://bugs.webkit.org/show_bug.cgi?id=138751 Reviewed by David Kilzer. Include header QuartzCoreSPI.h instead of including QuartzCore headers directly. * WebInspector/WebNodeHighlight.mm: * WebView/WebIndicateLayer.mm: 2014-11-17 Eric Carlson [iOS] allow host application to opt-out of alternate fullscreen https://bugs.webkit.org/show_bug.cgi?id=138787 Reviewed by Darin Adler. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences allowsAlternateFullscreen]): (-[WebPreferences setAllowsAlternateFullscreen:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2014-11-16 Tim Horton Use TextIndicator instead of the built in Lookup highlight https://bugs.webkit.org/show_bug.cgi?id=138775 Reviewed by Anders Carlsson. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Remove a WKSI import. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _lookupText:]): (-[WebActionMenuController _createActionMenuItemForTag:]): Make use of the new Lookup SPI header. Disable the Lookup item if lookup is not available. 2014-11-15 Tim Horton Implement data detectors and mailto action menus for WebKit1 https://bugs.webkit.org/show_bug.cgi?id=138765 Reviewed by Beth Dakin. * WebView/WebActionMenuController.h: * WebView/WebActionMenuController.mm: (-[WebActionMenuController willOpenMenu:withEvent:]): Tell DataDetectors that the menu is going to open. Select the text (or not) based on the number of items in the menu, just like WebKit2. (-[WebActionMenuController didCloseMenu:withEvent:]): Tell DataDetectors that the menu closed. (-[WebActionMenuController _defaultMenuItemsForLink]): Move these checks out of _defaultMenuItemsForLink, because we expect this to always return a complete link menu. (-[WebActionMenuController _defaultMenuItemsForMailtoLink]): Implement. More or less copied from WebKit2. (-[WebActionMenuController _selectDataDetectedText]): Select the stashed range. (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]): Implement. More or less copied from WebKit2. The yellow highlight isn't hooked up yet. Give the client a chance to override via _webView:actionContextForHitTestResult:range:. (-[WebActionMenuController _selectLookupText]): Remove an unnecessary return. (-[WebActionMenuController _defaultMenuItems]): Call into the two new menu types. * WebView/WebUIDelegatePrivate.h: 2014-11-14 Myles C. Maxfield Get rid of WebFontCache https://bugs.webkit.org/show_bug.cgi?id=134752 Reviewed by Dave Hyatt. * WebView/WebHTMLView.mm: 2014-11-14 Timothy Horton Update some artwork for the legacy WebKit action menu https://bugs.webkit.org/show_bug.cgi?id=138758 * WebView/WebActionMenuController.mm: (webKitBundleImageNamed): Deleted. Fix the build. 2014-11-14 Tim Horton Update some artwork for the legacy WebKit action menu https://bugs.webkit.org/show_bug.cgi?id=138758 Reviewed by Simon Fraser. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _createActionMenuItemForTag:]): 2014-11-14 Daniel Bates [iOS] NSFileManager and QuickLook SPI not available in public SDK https://bugs.webkit.org/show_bug.cgi?id=138742 Reviewed by Pratik Solanki. Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h. * WebCoreSupport/WebFrameLoaderClient.mm: 2014-11-14 Beth Dakin WK1: Webpage preview can come up in wrong location https://bugs.webkit.org/show_bug.cgi?id=138747 -and corresponding- rdar://problem/18979004 Reviewed by Tim Horton. Converting to window twice is bad. * WebView/WebActionMenuController.mm: (elementBoundingBoxInWindowCoordinatesFromNode): (-[WebActionMenuController _quickLookURLFromActionMenu:]): (elementBoundingBoxFromNode): Deleted. 2014-11-13 Myles C. Maxfield Move FontMac and FontCacheMac off of WKSI https://bugs.webkit.org/show_bug.cgi?id=138633 Reviewed by Simon Fraser. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): * WebKit.order: 2014-11-13 Beth Dakin WK1: Clean up WebActionMenuController to use the _hitTestResult ivar https://bugs.webkit.org/show_bug.cgi?id=138716 -and corresponding- rdar://problem/18977222 Reviewed by Tim Horton. It’s not necessary to use the WebElementDictionary for so many things now that we are caching the HitTestResult. We should just use the HitTestResult. * WebView/WebActionMenuController.mm: (-[WebActionMenuController prepareForMenu:withEvent:]): (-[WebActionMenuController _openURLFromActionMenu:]): (-[WebActionMenuController _addToReadingListFromActionMenu:]): (elementBoundingBoxFromNode): (-[WebActionMenuController _quickLookURLFromActionMenu:]): (-[WebActionMenuController _defaultMenuItemsForLink]): (-[WebActionMenuController _defaultMenuItemsForImage]): (-[WebActionMenuController _defaultMenuItemsForVideo]): (-[WebActionMenuController _defaultMenuItemsForText]): (-[WebActionMenuController _defaultMenuItemsForEditableText]): (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]): (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]): (-[WebActionMenuController _createActionMenuItemForTag:]): (-[WebActionMenuController _defaultMenuItems]): (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted. (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted. (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted. (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted. (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted. (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted. (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted. (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted. (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted. (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted. 2014-11-13 Daniel Bates [iOS] NSGeometry data types are not available in the public SDK https://bugs.webkit.org/show_bug.cgi?id=137536 Reviewed by David Kilzer. Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a private header. * DOM/WebDOMOperationsPrivate.h: 2014-11-13 Beth Dakin WK1: Support default actions for video https://bugs.webkit.org/show_bug.cgi?id=138713 -and corresponding- rdar://problem/18877520 Reviewed by Tim Horton. Call setToNonShadowAncestor() for media HitTestResults. * WebView/WebActionMenuController.mm: (-[WebActionMenuController performHitTestAtPoint:]): Default items and actions. (-[WebActionMenuController _defaultMenuItemsForVideo:]): (-[WebActionMenuController _copyVideoURL:]): (-[WebActionMenuController _saveVideoToDownloads:]): (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): * WebView/WebUIDelegatePrivate.h: 2014-11-13 Tim Horton WK1: Update icon for Add to Reading List https://bugs.webkit.org/show_bug.cgi?id=138710 Reviewed by Beth Dakin. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Use the right icon, matching WebKit2. 2014-11-12 Beth Dakin WK1: Support default actions for images https://bugs.webkit.org/show_bug.cgi?id=138668 -and corresponding- rdar://problem/18785434 Reviewed by Tim Horton. * WebView/WebActionMenuController.h: * WebView/WebActionMenuController.mm: (-[WebActionMenuController didCloseMenu:withEvent:]): (-[WebActionMenuController _defaultMenuItemsForImage:]): (-[WebActionMenuController _copyImage:]): (temporaryPhotosDirectoryPath): (pathToPhotoOnDisk): (-[WebActionMenuController _canAddMediaToPhotos]): (-[WebActionMenuController _addImageToPhotos:]): (-[WebActionMenuController _saveImageToDownloads:]): (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]): (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]): (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]): (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): * WebView/WebUIDelegatePrivate.h: 2014-11-11 Beth Dakin Action menu hit testing is not working properly with all WK1 apps https://bugs.webkit.org/show_bug.cgi?id=138643 -and corresponding- rdar://problem/18949376 Reviewed by Tim Horton. * WebView/WebActionMenuController.mm: (-[WebActionMenuController prepareForMenu:withEvent:]): (-[WebActionMenuController _lookupText:]): 2014-11-11 Myles C. Maxfield Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI https://bugs.webkit.org/show_bug.cgi?id=138623 Reviewed by Geoff Garen. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): * WebKit.order: 2014-11-11 Tim Horton Localize strings for action menus https://bugs.webkit.org/show_bug.cgi?id=138591 Reviewed by Dan Bates. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Make use of the new strings. 2014-11-11 Myles C. Maxfield Cleanup from r175379 https://bugs.webkit.org/show_bug.cgi?id=138616 Reviewed by Simon Fraser. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): * WebKit.order: 2014-11-11 Myles C. Maxfield Move CTFontTransformGlyphs out from WKSI https://bugs.webkit.org/show_bug.cgi?id=138599 Reviewed by Simon Fraser. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): * WebKit.order: 2014-11-11 Dan Bernstein More iOS build fix. * WebView/WebHTMLViewInternal.h: 2014-11-11 Dan Bernstein iOS build fix. * WebView/WebHTMLView.mm: 2014-11-10 Beth Dakin WK1: Support default actions for editable text with misspelled word https://bugs.webkit.org/show_bug.cgi?id=138590 -and corresponding- rdar://problem/18877506 Reviewed by Tim Horton. If there are misspelled word suggestions for editable text, create a new type of menu with a spelling suggestion sub-menu. * WebView/WebActionMenuController.mm: (-[WebActionMenuController isMenuForTextContent]): (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): (-[WebActionMenuController _changeSelectionToSuggestion:]): (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): * WebView/WebHTMLView.mm: (-[WebHTMLView _changeSpellingToWord:]): * WebView/WebHTMLViewInternal.h: * WebView/WebUIDelegatePrivate.h: 2014-11-10 Beth Dakin WK1: Support default actions for editable whitespace https://bugs.webkit.org/show_bug.cgi?id=138586 -and corresponding- rdar://problem/18932048 Reviewed by Tim Horton. New menu type. Just wants paste. * WebView/WebActionMenuController.mm: (-[WebActionMenuController isMenuForTextContent]): (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): * WebView/WebUIDelegatePrivate.h: 2014-11-10 Beth Dakin WK1: Support default actions for editable text https://bugs.webkit.org/show_bug.cgi?id=138580 -and corresponding- rdar://problem/18877497 Reviewed by Tim Horton. New menu type, and new action type for paste. * WebView/WebActionMenuController.mm: (-[WebActionMenuController isMenuForTextContent]): (-[WebActionMenuController willOpenMenu:withEvent:]): (-[WebActionMenuController _defaultMenuItemsForEditableText:]): (-[WebActionMenuController _paste:]): (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): * WebView/WebUIDelegatePrivate.h: 2014-11-10 Beth Dakin WK1: Text is getting selected even when an action menu fails to invoke https://bugs.webkit.org/show_bug.cgi?id=138576 -and corresponding- rdar://problem/18931330 Reviewed by Tim Horton. Selection changes should happen in willOpenMenu: instead of prepareForMenu: * WebView/WebActionMenuController.h: * WebView/WebActionMenuController.mm: (-[WebActionMenuController prepareForMenu:withEvent:]): (-[WebActionMenuController willOpenMenu:withEvent:]): _selectLookupText no longer needs to return a BOOL indicating success or failure. (-[WebActionMenuController _selectLookupText]): (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Pass willOpenMenu: on to the controller. * WebView/WebView.mm: (-[WebView willOpenMenu:withEvent:]): 2014-11-10 Beth Dakin Speculative build fix. * WebView/WebActionMenuController.mm: 2014-11-10 Beth Dakin Action menu initialization should be moved to _commonInitializationWithFrameName https://bugs.webkit.org/show_bug.cgi?id=138572 -and corresponding- rdar://problem/18929733 Reviewed by Tim Horton. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _initWithFrame:frameName:groupName:]): 2014-11-10 Beth Dakin WK1: Support default actions for read-only text https://bugs.webkit.org/show_bug.cgi?id=138552 -and corresponding- rdar://problem/18877483 Reviewed by Tim Horton. New WKSystemInterface functions that WebCore needs to use. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This makes a lot of things easier. * WebView/WebActionMenuController.h: * WebView/WebActionMenuController.mm: Perform the hit test ourselves instead of calling into WebView so that we can more easily save the WebCore::HitTestResult for ourselves. (-[WebActionMenuController performHitTestAtPoint:]): Clear selection for non-text menus. (-[WebActionMenuController prepareForMenu:withEvent:]): Re-set the _type here just to be safe. (-[WebActionMenuController didCloseMenu:withEvent:]): Moving this method to be next to the link actions so they can be within a pragma mark. (-[WebActionMenuController _defaultMenuItemsForLink:]): New method for default text actions — lookup and copy. (-[WebActionMenuController _defaultMenuItemsForText:]): (-[WebActionMenuController _copySelection:]): (-[WebActionMenuController _lookupText:]): If there is not already a selection, invoking the action menu on text should select the lookup text. (-[WebActionMenuController _selectLookupText]): (performDictionaryLookupForSelection): (performDictionaryLookupForRange): Handle text now. (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): New enum values. * WebView/WebUIDelegatePrivate.h: Pass didCloseMenu on to the controller. * WebView/WebView.mm: (-[WebView didCloseMenu:withEvent:]): 2014-11-09 Chris Dumez Add a more correct way to compare floating point numbers and use it https://bugs.webkit.org/show_bug.cgi?id=138527 Reviewed by Darin Adler. Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h to compare floating-point numbers. * WebView/WebHTMLView.mm: (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]): 2014-11-08 Alexey Proskuryakov Delete cookies between tests https://bugs.webkit.org/show_bug.cgi?id=138528 Reviewed by Sam Weinig. * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]): * WebView/WebPreferencesPrivate.h: Added an SPI for DumpRenderTree. 2014-11-07 Eric Carlson [iOS] Update optimized fullscreen media controls https://bugs.webkit.org/show_bug.cgi?id=138493 Reviewed by Brent Fulgham. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize GetMediaUIImageData. 2014-11-06 Daniel Jalkut Wrap the bulk of -[WebView dealloc] with an autorelease pool. https://bugs.webkit.org/show_bug.cgi?id=138443 Reviewed by Anders Carlsson. Wrapping the dealloc method in its own autorelease pool avoids the problem of complex tear-downs leading to the WebView itself being added to an autorelease pool that is not drained until after the instance has been dealloc'd. * WebView/WebView.mm: (-[WebView dealloc]): 2014-11-05 Jer Noble De-templatize Timer https://bugs.webkit.org/show_bug.cgi?id=138450 Reviewed by Anders Carlsson. Remove template specifiers from Timer. * Plugins/Hosted/NetscapePluginInstanceProxy.h: * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::requestTimerFired): * Plugins/WebNetscapePluginStream.h: * Plugins/WebNetscapePluginStream.mm: (WebNetscapePluginStream::deliverDataTimerFired): 2014-11-05 Dan Bernstein Remove the unused deletion UI feature https://bugs.webkit.org/show_bug.cgi?id=138442 Rubber-stamped by Alexey Proskuryakov. * DefaultDelegates/WebDefaultEditingDelegate.m: (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted. * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldShowDeleteInterface): Deleted. * WebView/WebEditingDelegatePrivate.h: Removed declaration of -webView:shouldShowDeleteInterfaceForElement:. 2014-11-03 Dean Jackson Add ENABLE_FILTERS_LEVEL_2 feature guard. https://bugs.webkit.org/show_bug.cgi?id=138362 Reviewed by Tim Horton. Add a new feature define for Level 2 of CSS Filters. http://dev.w3.org/fxtf/filters-2/ * Configurations/FeatureDefines.xcconfig: 2014-11-03 Jeremy Jones Add button and enable optimized fullscreen. https://bugs.webkit.org/show_bug.cgi?id=138351 Reviewed by Eric Carlson. Add IsOptimizedFullscreenSupported to enable the feature only where appropriate. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): added 2014-11-04 Chris Dumez Add ptr() method to Ref class https://bugs.webkit.org/show_bug.cgi?id=138361 Reviewed by Darin Adler. Use the new Ref::ptr() method. * WebView/WebFrame.mm: (-[WebFrame _setTypingStyle:withUndoAction:]): * WebView/WebHTMLView.mm: (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]): * WebView/WebView.mm: (-[WebView applyStyle:]): 2014-11-04 Darin Adler Eliminate ResourceBuffer and use SharedBuffer directly instead https://bugs.webkit.org/show_bug.cgi?id=138174 Reviewed by Antti Koivisto. * WebView/WebDataSource.mm: (-[WebDataSource data]): Use SharedBuffer directly. * WebView/WebHTMLView.mm: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto. 2014-11-03 Commit Queue Unreviewed, rolling out r175406, r175413, and r175423. https://bugs.webkit.org/show_bug.cgi?id=138327 Multipart tests are still broken (Requested by ap on #webkit). Reverted changesets: "Eliminate ResourceBuffer and use SharedBuffer directly instead" https://bugs.webkit.org/show_bug.cgi?id=138174 http://trac.webkit.org/changeset/175406 "Unreviewed, iOS build fix since 175406." http://trac.webkit.org/changeset/175413 "Fix assertion in CachedResource::addDataBuffer" http://trac.webkit.org/changeset/175423 2014-10-31 Gyuyoung Kim Use std::unique_ptr for TypeCountSet https://bugs.webkit.org/show_bug.cgi?id=138242 Reviewed by Andreas Kling. * Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr. (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto. 2014-10-31 Beth Dakin Use system art for action menus when possible https://bugs.webkit.org/show_bug.cgi?id=138260 Reviewed by Tim Horton. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): 2014-10-30 Darin Adler Eliminate ResourceBuffer and use SharedBuffer directly instead https://bugs.webkit.org/show_bug.cgi?id=138174 Reviewed by Antti Koivisto. * WebView/WebDataSource.mm: (-[WebDataSource data]): Use SharedBuffer directly. * WebView/WebHTMLView.mm: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto. 2014-10-30 Jer Noble [EME] Add Setting for accessing storage location for MediaKeys data https://bugs.webkit.org/show_bug.cgi?id=138147 Reviewed by Brady Eidson. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Set default location. (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor. (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter. * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings. 2014-10-30 Dana Burkart Prepare for the mysterious future Reviewed by Lucas Forschler. * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: * Configurations/FeatureDefines.xcconfig: * Configurations/Version.xcconfig: 2014-10-28 Jeremy Jones Add optimized fullscreen mode. https://bugs.webkit.org/show_bug.cgi?id=138044 Reviewed by Jer Noble. Enable different types of fullscreen video behavior. Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen. * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::enterVideoFullscreenForVideoElement): ditto * WebView/WebView.mm: (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted. * WebView/WebViewInternal.h: ditto 2014-10-27 Beth Dakin Provide a way for WebKit1 clients to override default action menu items https://bugs.webkit.org/show_bug.cgi?id=138066 -and corresponding- rdar://problem/18451638 Reviewed by Anders Carlsson. WebActionMenuController now has an ivar for the WebActionMenuType so that it can send that along to clients customizing the menu. * WebView/WebActionMenuController.h: * WebView/WebActionMenuController.mm: (-[WebActionMenuController prepareForMenu:withEvent:]): (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): New enum and new SPI to customize menus. * WebView/WebUIDelegatePrivate.h: 2014-10-24 Benjamin Poulain Fix the iOS build * Configurations/WebKitLegacy.xcconfig: * WebView/WebView.mm: 2014-10-24 Beth Dakin Build fix. * WebView/WebActionMenuController.mm: (-[WebActionMenuController _openURLFromActionMenu:]): (-[WebActionMenuController _addToReadingListFromActionMenu:]): (-[WebActionMenuController _quickLookURLFromActionMenu:]): 2014-10-24 Beth Dakin WebKit1 should support action menus https://bugs.webkit.org/show_bug.cgi?id=138032 Reviewed by Tim Horton. This patch adds basic support for action menus and adds actions for links. Helper class takes care of all of the action menu work. WebView will forward the prepareForMenu: message, and then the helper class takes it from there. * WebView/WebActionMenuController.h: Added. * WebView/WebActionMenuController.mm: Added. (-[WebActionMenuController webViewClosed]): (-[WebActionMenuController prepareForMenu:withEvent:]): Selectors for link actions. (-[WebActionMenuController _openURLFromActionMenu:]): (-[WebActionMenuController _addToReadingListFromActionMenu:]): (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): (-[WebActionMenuController _quickLookURLFromActionMenu:]): (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): (webKitBundleImageNamed): (-[WebActionMenuController _defaultMenuItemsForLink:]): (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Tags for the action menu items. * WebView/WebUIDelegatePrivate.h: * WebView/WebView.mm: Set the action menu if possible and create the controller. (-[WebView _initWithFrame:frameName:groupName:]): (-[WebView _close]): (-[WebView prepareForMenu:withEvent:]): WebViewData stores the WebActionMenuHelper * WebView/WebViewData.h: * WebView/WebViewData.mm: (-[WebViewPrivate dealloc]): 2014-10-23 Joseph Pecoraro Web Inspector: Provide a way to have alternate inspector agents https://bugs.webkit.org/show_bug.cgi?id=137901 Reviewed by Brian Burg. * Configurations/FeatureDefines.xcconfig: 2014-10-23 Tim Horton Add some SPI headers for NSExtension and NSSharingService{Picker} https://bugs.webkit.org/show_bug.cgi?id=138027 Reviewed by Anders Carlsson. * Misc/WebSharingServicePickerController.h: * Misc/WebSharingServicePickerController.mm: * WebCoreSupport/WebSelectionServiceController.mm: * WebCoreSupport/WebContextMenuClient.mm: Fix a sorting issue. Replace redefinitions with SPI header #imports. 2014-10-23 Tim Horton Crashes under WebSelectionServiceController::hasRelevantSelectionServices https://bugs.webkit.org/show_bug.cgi?id=138013 Reviewed by Dan Bernstein. * WebCoreSupport/WebSelectionServiceController.mm: (WebSelectionServiceController::hasRelevantSelectionServices): Don't adopt this autoreleased object. 2014-10-22 Chris Dumez [Mac][WK2] Fix applicationIsSafari() detection https://bugs.webkit.org/show_bug.cgi?id=137893 Reviewed by Alexey Proskuryakov. Provide an implementation for FrameLoaderClient's new needsQuickLookResourceCachingQuirks() that returns a static flag initialized using QuickLookMac::computeNeedsQuickLookResourceCachingQuirks(). * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: 2014-10-20 Chris Dumez ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition https://bugs.webkit.org/show_bug.cgi?id=137797 Reviewed by Darin Adler. Call ResourceRequest::setDomainForPartitionName() instead of setPartitionName() as the argument is a domain, not a valid partition name. * Misc/WebCache.mm: (+[WebCache addImageToCache:forURL:forFrame:]): (+[WebCache removeImageFromCacheForURL:forFrame:]): 2014-10-20 Andy Estes Fix the iOS build. * WebView/WebFrame.mm: (-[WebFrame getDictationResultRanges:andMetadatas:]): (-[WebFrame dictationResultMetadataForRange:]): 2014-10-19 Chris Dumez Use is<>() / downcast<>() for all remaining RenderObject subclasses https://bugs.webkit.org/show_bug.cgi?id=137845 Reviewed by Darin Adler. Use is<>() / downcast<>() for all remaining RenderObject subclasses and clean up the surrounding code. * Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView pluginHostDied]): * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView _windowClipRect]): (-[WebBaseNetscapePluginView actualVisibleRectInWindow]): * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): (WebFrameLoaderClient::createJavaAppletWidget): 2014-10-17 Tim Horton Build fix for 32-bit Yosemite * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuForEvent): Avoid using NSItemProvider in 32-bit, because it doesn't exist. 2014-10-17 Chris Dumez Use is<>() / downcast<>() for RenderBox https://bugs.webkit.org/show_bug.cgi?id=137804 Reviewed by Andreas Kling. Use is<>() / downcast<>() for RenderBox and clean up the surrounding code. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::clientFloatRectForNode): * WebView/WebFrame.mm: (-[WebFrame renderedSizeOfNode:constrainedToWidth:]): 2014-10-17 Tim Horton Fix the build with the public SDK. * WebCoreSupport/WebSelectionServiceController.mm: We should transition all this SPI to real SPI headers as soon as possible. 2014-10-16 Tim Horton Implement selection services menu for Legacy WebKit https://bugs.webkit.org/show_bug.cgi?id=137582 Reviewed by Brady Eidson. * Misc/WebSharingServicePickerController.h: Move SPI into the header (in the near future it will be moved to a modern-style SPI header). Add WebSharingServicePickerClient, which other classes can implement instead of tying WebSharingServicePickerController strongly to WebContextMenuClient. Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders. * Misc/WebSharingServicePickerController.mm: Pass in NSSharingServicePickerStyle, so that clients can specify the style. (-[WebSharingServicePickerController clear]): (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]): (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]): (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]): (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]): (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]): Make use of WebSharingServicePickerClient. (-[WebSharingServicePickerController sharingService:didShareItems:]): If we're returned a NSAttributedString, paste it on top of the current selection, similar to what the WebKit2 implementation currently does. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::handleTelephoneNumberClick): (WebChromeClient::handleSelectionServiceClick): (WebChromeClient::hasRelevantSelectionServices): Override the services-related ChromeClient functions, forward them to WebSelectionServiceController. * WebCoreSupport/WebContextMenuClient.h: * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::sharingServicePickerWillBeDestroyed): (WebContextMenuClient::pageForSharingServicePicker): (WebContextMenuClient::windowForSharingServicePicker): (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem): (WebContextMenuClient::imageForCurrentSharingServicePickerItem): (WebContextMenuClient::contextMenuForEvent): (WebContextMenuClient::screenRectForHitTestNode): Deleted. (WebContextMenuClient::renderedImageForControlledImage): Deleted. (WebContextMenuClient::clearSharingServicePickerController): Deleted. Have WebContextMenuClient implement WebSharingServicePickerClient to avoid having WebSharingServicePickerController tightly bound to it. Make an NSItemProvider array when instantiating WebSharingServicePickerController instead of handing it data directly. * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h. * WebCoreSupport/WebSelectionServiceController.mm: Added. (WebSelectionServiceController::WebSelectionServiceController): Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient for selection services. (WebSelectionServiceController::handleSelectionServiceClick): Create a WebSharingSericePickerController with the selection's attributed string, and show its menu. (hasCompatibleServicesForItems): (WebSelectionServiceController::hasRelevantSelectionServices): Determine whether or not services are available. (WebSelectionServiceController::sharingServicePickerWillBeDestroyed): (WebSelectionServiceController::pageForSharingServicePicker): (WebSelectionServiceController::windowForSharingServicePicker): Implement the rest of the WebSharingServicePickerClient overrides. (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem): (WebSelectionServiceController::imageForCurrentSharingServicePickerItem): These are only useful for image sharing services, so we don't need to implement them (WebContextMenuClient does, on the other hand). * WebView/WebView.mm: (-[WebView _selectionServiceController]): * WebView/WebViewData.h: * WebView/WebViewData.mm: * WebView/WebViewInternal.h: Keep a WebSelectionServiceController. 2014-10-14 Myles C. Maxfield Improve debug description of WAKViews https://bugs.webkit.org/show_bug.cgi?id=137716 Reviewed by Simon Fraser. * WebView/WebView.mm: (-[WebView _touchEventRegions]): Adding a comment. 2014-10-14 Myles C. Maxfield Addressing post-review comment. https://bugs.webkit.org/show_bug.cgi?id=137550 Unreviewed. * WebView/WebHTMLView.mm: (fontNameForDescription): (-[WebHTMLView _addToStyle:fontA:fontB:]): 2014-10-14 Chris Dumez Use is<>() / downcast<>() for RenderImage https://bugs.webkit.org/show_bug.cgi?id=137683 Reviewed by Mihnea Ovidenie. Use is<>() / downcast<>() for RenderImage. * Misc/WebNSPasteboardExtras.mm: (imageFromElement): (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]): 2014-10-10 Daniel Bates Remove unused classes WebRender{Node, Layer} https://bugs.webkit.org/show_bug.cgi?id=137628 Reviewed by Simon Fraser. We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer. For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name. * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list of excluded source files when building for iOS. * WebKit.exp: Remove symbol for WebRenderLayer. * WebKit.mac.exp: Remove symbol for WebRenderNode. * WebView/WebRenderLayer.h: Removed. * WebView/WebRenderLayer.mm: Removed. * WebView/WebRenderNode.h: Removed. * WebView/WebRenderNode.mm: Removed. 2014-10-10 Chris Dumez Use is<>() / downcast<>() for RenderBoxModelObject https://bugs.webkit.org/show_bug.cgi?id=137587 Reviewed by Mihnea Ovidenie. Use is<>() / downcast<>() for RenderBoxModelObject and clean up the surrounding code. * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView invalidatePluginContentRect:]): * WebView/WebRenderLayer.mm: (-[WebRenderLayer initWithWebFrame:]): 2014-10-09 Dean Jackson Remove ENABLE_CSS3_CONDITIONAL_RULES https://bugs.webkit.org/show_bug.cgi?id=137571 Reviewed by Simon Fraser. * Configurations/FeatureDefines.xcconfig: 2014-10-09 Tim Horton Add a WebKit1 preference for selection services https://bugs.webkit.org/show_bug.cgi?id=137498 Reviewed by Simon Fraser. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences serviceControlsEnabled]): (-[WebPreferences setServiceControlsEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Add and plumb the preference. 2014-10-09 Myles C. Maxfield Remove second-to-last client of WebFontCache https://bugs.webkit.org/show_bug.cgi?id=137550 Reviewed by Darin Adler. Use FontCache::getCachedFontData() instead of WebFontCache. * WebView/WebHTMLView.mm: (-[WebHTMLView _addToStyle:fontA:fontB:]): 2014-10-09 Chris Dumez Use is<>() / downcast<>() for Widget subclasses https://bugs.webkit.org/show_bug.cgi?id=137549 Reviewed by Darin Adler. Use is<>() / downcast<>() for Widget subclasses and clean up the surrounding code. * WebView/WebRenderNode.mm: (copyRenderNode): * WebView/WebView.mm: (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]): 2014-10-07 Christophe Dumez Use is<>() / downcast<>() for RenderText / RenderTextFragment https://bugs.webkit.org/show_bug.cgi?id=137476 Reviewed by Darin Adler. * WebView/WebRenderNode.mm: (copyRenderNode): 2014-10-06 Dan Bernstein Build fix. * Misc/WebCache.mm: (+[WebCache imageForURL:]): 2014-10-06 Chris Dumez Unreviewed build fix after r174333. Forgot explicit WebCore:: namespace. * Misc/WebCache.mm: (+[WebCache imageForURL:]): 2014-10-05 Christophe Dumez Use is<>() / downcast<>() for CachedResource subclasses https://bugs.webkit.org/show_bug.cgi?id=137431 Reviewed by Benjamin Poulain. Use is<>() / downcast<>() for CachedResource subclasses. * Misc/WebCache.mm: (+[WebCache imageForURL:]): 2014-10-02 Daniel Bates Use version number 101000 instead of 10100 for OS X Yosemite https://bugs.webkit.org/show_bug.cgi?id=137372 Reviewed by Mark Rowe. The version number for OS X Yosemite is 101000. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2014-10-02 Tim Horton Move PageOverlay[Controller] to WebCore https://bugs.webkit.org/show_bug.cgi?id=137164 Reviewed by Anders Carlsson. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::attachViewOverlayGraphicsLayer): Add an empty ChromeClient override. 2014-10-01 Christophe Dumez Have is<>(T*) function do a null check on the pointer argument https://bugs.webkit.org/show_bug.cgi?id=137333 Reviewed by Gavin Barraclough. Have is<>(T*) function do a null check on the argument instead of a simple assertion. This makes sense for 2 reasons: 1. It is more consistent with downcast<>(T*), which will succeed even if the argument is a nullptr. 2. It simplifies the code a bit as it gets rid of a lot of explicit null checks. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::focusedElementChanged): * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::textFieldDidBeginEditing): (WebEditorClient::textFieldDidEndEditing): (WebEditorClient::textDidChangeInTextField): (WebEditorClient::doTextFieldCommandFromEvent): (WebEditorClient::textWillBeDeletedInTextField): (WebEditorClient::textDidChangeInTextArea): * WebView/WebHTMLRepresentation.mm: (inputElementFromDOMElement): (searchForLabelsBeforeElement): * WebView/WebRenderLayer.mm: (+[WebRenderLayer nameForLayer:]): 2014-10-01 Mark Rowe WebKit should build on OS X Yosemite for external users Reviewed by Dan Bernstein. * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite. 2014-09-30 Chris Dumez Use is<>() / downcast<>() for Element https://bugs.webkit.org/show_bug.cgi?id=137241 Reviewed by Andreas Kling. Use is<>() / downcast<>() for Element instead of isElementNode() / toElement(). * WebView/WebRenderLayer.mm: (+[WebRenderLayer nameForLayer:]): 2014-09-28 Gyuyoung Kim Move ColorInputType class to std::unique_ptr https://bugs.webkit.org/show_bug.cgi?id=137173 Reviewed by Darin Adler. Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr. Child classes follow this change as well. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createColorChooser): 2014-09-24 Christophe Dumez Add initial is<>() / downcast<>() support for any type of Nodes https://bugs.webkit.org/show_bug.cgi?id=137056 Reviewed by Benjamin Poulain. Use is() / downcast() instead of isFormControlElement() / toHTMLFormControlElement(). * WebView/WebHTMLRepresentation.mm: (searchForLabelsBeforeElement): 2014-09-24 Christophe Dumez Use is() instead of isHTML*Element() - Part 1 https://bugs.webkit.org/show_bug.cgi?id=137068 Reviewed by Ryosuke Niwa. Start using is() instead of isHTML*Element(). Remaining usages will be updated in a follow-up patch to reduce the size of the change. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::focusedElementChanged): * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::textFieldDidBeginEditing): (WebEditorClient::textFieldDidEndEditing): (WebEditorClient::textDidChangeInTextField): (WebEditorClient::doTextFieldCommandFromEvent): (WebEditorClient::textWillBeDeletedInTextField): (WebEditorClient::textDidChangeInTextArea): * WebView/WebHTMLRepresentation.mm: (inputElementFromDOMElement): 2014-09-21 Timothy Hatcher Make the Web Inspector use a separate web process. https://bugs.webkit.org/show_bug.cgi?id=135120 Reviewed by Anders Carlsson. * WebCoreSupport/WebInspectorClient.h: * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::WebInspectorClient): (WebInspectorClient::openInspectorFrontend): (WebInspectorClient::releaseFrontend): Own WebInspectorFrontendClient instead of moving it. 2014-09-23 Chris Dumez Use downcast() instead of toHTML*Element() https://bugs.webkit.org/show_bug.cgi?id=137007 Reviewed by Benjamin Poulain. Use downcast() instead of toHTML*Element(). * DOM/WebDOMOperations.mm: (-[DOMHTMLInputElement _setAutofilled:]): * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::focusedElementChanged): * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::textFieldDidBeginEditing): (WebEditorClient::textFieldDidEndEditing): (WebEditorClient::textDidChangeInTextField): (WebEditorClient::doTextFieldCommandFromEvent): (WebEditorClient::textWillBeDeletedInTextField): (WebEditorClient::textDidChangeInTextArea): * WebView/WebHTMLRepresentation.mm: (inputElementFromDOMElement): 2014-09-21 Chris Dumez Generate Element casting helper functions https://bugs.webkit.org/show_bug.cgi?id=136839 Reviewed by Darin Adler. Use JSXXX::toWrapped() instead of toXXX() function. * DOM/WebDOMOperations.mm: * WebView/WebView.mm: (-[WebView _notificationIDForTesting:]): 2014-09-21 Joseph Pecoraro Leak: WebNotificationPrivate ObjC leaks seen on leaks bot https://bugs.webkit.org/show_bug.cgi?id=136972 Reviewed by Darin Adler. * WebView/WebNotification.h: * WebView/WebNotification.mm: (-[WebNotification initWithCoreNotification:notificationID:]): Switch to RetainPtr and adopt into _private to ensure when we are deallocated that _private will get deallocated. 2014-09-19 Dean Jackson Multithreaded WebGL is a bad idea - remove it https://bugs.webkit.org/show_bug.cgi?id=136964 Reviewed by Brent Fulgham. Remove the setting to allow multithreaded WebGL. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences multithreadedWebGLEnabled]): Deleted. (-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted. * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2014-09-19 Daniel Bates Always assume internal SDK when building configuration Production https://bugs.webkit.org/show_bug.cgi?id=136925 Reviewed by Dan Bernstein. As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, and ENABLE_XSLT when either building configuration Production or building with the Internal SDK. * Configurations/Base.xcconfig: 2014-09-17 Daniel Bates Unreviewed, rolling out r173695. Broke building third-party Legacy WebKit apps; will investigate offline Reverted changeset: "[iOS] Make WebCore build with public iOS SDK" https://bugs.webkit.org/show_bug.cgi?id=136487 http://trac.webkit.org/changeset/173695 2014-09-17 Daniel Bates [iOS] Make WebCore build with public iOS SDK https://bugs.webkit.org/show_bug.cgi?id=136487 Reviewed by David Kilzer. Update WebKit1 source files to include the wrapper SPI headers instead of the corresponding actual SPI header(s). * DOM/WebDOMOperationsPrivate.h: * MigrateHeaders.make: Modified to only modify the include path of a " [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name https://bugs.webkit.org/show_bug.cgi?id=136862 Reviewed by David Kilzer. * Configurations/DebugRelease.xcconfig: 2014-09-16 Enrica Casucci Remove PLATFORM(IOS) from WebCore/editing (Part 3). https://bugs.webkit.org/show_bug.cgi?id=136474 Reviewed by Benjamin Poulain. This is the updated version of the patch that was landed in r173340. This patch removes the use of PLATFORM(IOS) from TextAffinity.h and removes the assumption that EAffinity values match NSSelectionAffinity values. It also removes the includes in TextAffinity.h, creating the need to include explicitly the files when necessary. * WebCoreSupport/WebEditorClient.h: (kit): (core): 2014-09-14 Daniel Bates [iOS] Attempt to fix the iOS build after (https://bugs.webkit.org/show_bug.cgi?id=136789) Substitute Node::countChildNodes() for Node::childNodeCount() in more places. * WebView/WebFrame.mm: (-[WebFrame focusedNodeHasContent]): 2014-09-14 Chris Dumez Rename Node::childNodeCount() to countChildNodes() and avoid inefficient uses https://bugs.webkit.org/show_bug.cgi?id=136789 Reviewed by Darin Adler. Rename childNodeCount() to countChildNodes(). * WebView/WebHTMLView.mm: (-[WebHTMLView attributedString]): 2014-09-10 Jon Honeycutt Re-add the request autocomplete feature This feature was rolled out in r148731 because it was only used by Chromium. As we consider supporting this feature, roll it back in, but leave it disabled. This rolls out r148731 (which removed the feature) with small changes needed to make the code build in ToT, to match modern style, to make the tests run, and to remove unused code. Reviewed by Andy Estes. * Configurations/FeatureDefines.xcconfig: * WebCoreSupport/WebFrameLoaderClient.h: 2014-09-12 Commit Queue Unreviewed, rolling out r173575. https://bugs.webkit.org/show_bug.cgi?id=136790 Failing tests (Requested by enrica on #webkit). Reverted changeset: "Remove PLATFORM(IOS) from WebCore/editing (Part 3)." https://bugs.webkit.org/show_bug.cgi?id=136474 http://trac.webkit.org/changeset/173575 2014-09-12 Enrica Casucci Remove PLATFORM(IOS) from WebCore/editing (Part 3). https://bugs.webkit.org/show_bug.cgi?id=136474 Reviewed by Benjamin Poulain. This is the updated version of the patch that was landed in r173340. I changed the use of IntPoint to FloatPoint since it was causing tests to fail. This patch removes the use of PLATFORM(IOS) from TextAffinity.h and removes the assumption that EAffinity values match NSSelectionAffinity values. It also removes the includes in TextAffinity.h, creating the need to include explicitly the files when necessary. It also removes the unnecessary use of platform specific types, replacing them with WebCore types. * WebCoreSupport/WebEditorClient.h: (kit): (core): * WebView/WebFrameView.mm: (-[WebFrameView _scrollToBeginningOfDocument]): (-[WebFrameView _scrollToEndOfDocument]): 2014-09-11 Bear Travis [CSS Font Loading] Enable CSS Font Loading on Mac https://bugs.webkit.org/show_bug.cgi?id=135473 Reviewed by Antti Koivisto. Enable CSS Font Loading in FeatureDefines. * Configurations/FeatureDefines.xcconfig: 2014-09-11 Beth Dakin Support rubber-banding in sub-frames https://bugs.webkit.org/show_bug.cgi?id=136726 -and corresponding- rdar://problem/10011924 Reviewed by Tim Horton. rubberBandingForOverflowScrollEnabled is re-named to rubberBandingForSubScrollableRegionsEnabled * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2014-09-09 Benjamin Poulain Disable the "unreachable-code" warning https://bugs.webkit.org/show_bug.cgi?id=136677 Reviewed by Darin Adler. * Configurations/Base.xcconfig: 2014-09-08 Maciej Stachowiak Fix 32-bit Mac build for new warnings https://bugs.webkit.org/show_bug.cgi?id=136624 Reviewed by Darin Adler. (Jessie already fixed this but my version with typedefs seems a tiny bit cleaner.) * Carbon/HIViewAdapter.m: (+[HIViewAdapter bindHIViewToNSView:nsView:]): Need to use explicit casting now. 2014-09-08 Eva Balazsfalvi Remove FILTERS flag https://bugs.webkit.org/show_bug.cgi?id=136571 Reviewed by Darin Adler. * Configurations/FeatureDefines.xcconfig: 2014-09-08 Jessie Berlin 32-bit build fix after r173364. * Carbon/HIViewAdapter.m: (+[HIViewAdapter bindHIViewToNSView:nsView:]): 2014-09-08 Dan Bernstein Build fix. Added back SPI that is still in use. * Misc/WebNSURLExtras.h: * Misc/WebNSURLExtras.mm: (-[NSURL _webkit_URLByRemovingFragment]): 2014-09-08 Dan Bernstein iOS Simulator build fix. * Misc/WebKitSystemBits.m: (WebMemorySize): 2014-09-07 Darin Adler Fix build failure seen on Mountain Lion buildbot. * Misc/WebNSDataExtras.h: Make WEB_GUESS_MIME_TYPE_PEEK_LENGTH an unsigned instead of an int, to avoid warning about mixing signs. 2014-09-06 Darin Adler Make updates suggested by new version of Xcode https://bugs.webkit.org/show_bug.cgi?id=136603 Reviewed by Mark Rowe. * Configurations/Base.xcconfig: Added CLANG_WARN_UNREACHABLE_CODE, COMBINE_HIDPI_IMAGES, and ENABLE_STRICT_OBJC_MSGSEND as suggested by Xcode upgrade check. * History/WebURLsWithTitles.m: (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use NSUInteger instead of unsigned for correctness, and to quiet the 32-to-64-bit compiler warning (which is not turned on because it gives us too many false positives). * Misc/WebElementDictionary.mm: (-[WebElementDictionary objectForKey:]): Ditto. * Misc/WebNSDataExtras.m: (-[NSData _webkit_guessedMIMETypeForXML]): Ditto. (-[NSData _webkit_guessedMIMEType]): Ditto. (-[NSData _webkit_parseRFC822HeaderFields]): Ditto. (-[NSData _web_locationAfterFirstBlankLine]): Ditto. * Misc/WebNSURLExtras.h: Removed unused _web_URLWithLowercasedScheme, _web_hostData, _webkit_URLByRemovingFragment, _webkit_URLByRemovingResourceSpecifier, _webkit_isFTPDirectoryURL, _webkit_shouldLoadAsEmptyDocument, _web_hostNameNeedsDecodingWithRange:, _web_hostNameNeedsEncodingWithRange:, _web_decodeHostNameWithRange:, _web_encodeHostNameWithRange:, and _webkit_URLFragment methods. * Misc/WebNSURLExtras.mm: (-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Deleted. (-[NSURL _webkit_URLByRemovingFragment]): Deleted. (-[NSURL _webkit_URLByRemovingResourceSpecifier]): Deleted. (-[NSURL _webkit_isFTPDirectoryURL]): Deleted. (-[NSURL _webkit_shouldLoadAsEmptyDocument]): Deleted. (-[NSURL _web_URLWithLowercasedScheme]): Deleted. (-[NSString _webkit_isFTPDirectoryURL]): Deleted. (-[NSString _web_hostNameNeedsDecodingWithRange:]): Deleted. (-[NSString _web_hostNameNeedsEncodingWithRange:]): Deleted. (-[NSString _web_decodeHostNameWithRange:]): Deleted. (-[NSString _web_encodeHostNameWithRange:]): Deleted. (-[NSString _webkit_URLFragment]): Deleted. * Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase removePluginInstanceViewsFor:]): Use a modern for loop to iterate an array instead of a loop using the type "unsigned int". * WebCoreSupport/WebOpenPanelResultListener.mm: (-[WebOpenPanelResultListener chooseFilenames:]): Use NSUInteger instead of int. * WebView/WebDelegateImplementationCaching.mm: (CallDelegate): Use wtfCallIMP in one overload that was instead just calling the directly without a proper type for the function pointer. This might have been causing an actual problem on 64-bit systems, and it was different from all the other CallDelegate functions that were already doing this correctly. * WebView/WebTextCompletionController.mm: (-[WebTextCompletionController _placePopupWindow:]): Use NSUInteger instead of int. 2014-09-06 Brian J. Burg Web Inspector: convert DockSide to an enum class https://bugs.webkit.org/show_bug.cgi?id=136601 Reviewed by Timothy Hatcher. * WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::frontendLoaded): (-[WebInspectorWindowController attachWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]): * WebInspector/WebInspectorFrontend.mm: (-[WebInspectorFrontend attach]): 2014-09-05 Commit Queue Unreviewed, rolling out r173340 and r173342. https://bugs.webkit.org/show_bug.cgi?id=136596 Broke many tests (Requested by ap on #webkit). Reverted changesets: "Remove PLATFORM(IOS) from WebCore/editing (Part 3)." https://bugs.webkit.org/show_bug.cgi?id=136474 http://trac.webkit.org/changeset/173340 "Build fix after r173340." http://trac.webkit.org/changeset/173342 2014-09-05 Enrica Casucci Build fix after r173340. * WebCoreSupport/WebEditorClient.h: (kit): (core): 2014-09-05 Enrica Casucci Remove PLATFORM(IOS) from WebCore/editing (Part 3). https://bugs.webkit.org/show_bug.cgi?id=136474 Reviewed by Benjamin Poulain. This patch removes the use of PLATFORM(IOS) from TextAffinity.h and removes the assumption that EAffinity values match NSSelectionAffinity values. It also removes the includes in TextAffinity.h, creating the need to include explicitly the files when necessary. It also removes the unnecessary use of platform specific types, replacing them with WebCore types. * WebCoreSupport/WebEditorClient.h: Added kit and core for EAffinity. * WebView/WebFrameView.mm: (-[WebFrameView _scrollToBeginningOfDocument]): (-[WebFrameView _scrollToEndOfDocument]): 2014-09-05 Daniel Bates [iOS] Another attempt to fix the iOS build after (https://bugs.webkit.org/show_bug.cgi?id=136564) Move #endif inside -viewDidMoveToWindow up one line such that the closing brace ('}') is after it. * WebView/WebHTMLView.mm: (-[WebHTMLView viewDidMoveToWindow]): 2014-09-05 Daniel Bates [iOS] Another attempt to fix the iOS build after (https://bugs.webkit.org/show_bug.cgi?id=136564) Add !PLATFORM(IOS)-guard in -viewDidMoveToWindow around code that references WebHTMLViewPrivate.flagsChangedEventMonitor. The instance variable WebHTMLViewPrivate.flagsChangedEventMonitor is guarded by !PLATFORM(IOS). * WebView/WebHTMLView.mm: (-[WebHTMLView viewDidMoveToWindow]): 2014-09-05 Daniel Bates [iOS] Fix the iOS build after (https://bugs.webkit.org/show_bug.cgi?id=136564) Include more code inside the !PLATFORM(IOS)-guarded section in -setDataSource:. * WebView/WebHTMLView.mm: (-[WebHTMLView setDataSource:]): 2014-09-04 Maciej Stachowiak Use tracking areas instead of (SPI) mouse moved notifications, and follow flags changes with an event monitor https://bugs.webkit.org/show_bug.cgi?id=136564 Reviewed by Dan Bernstein. WebKit1 depended on mouse moved event notifications to track mouse moves, and on being specially called by Safari to track flags changes. WebKit2 does both these things better - it uses a tracking area and event monitors. Copy those approaches. * WebKit.order: Remove reference to obsolete call. * WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): No need to deallocate tracking area, since we now just always have one. (-[WebHTMLViewPrivate clear]): ditto (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]): New method that posts a fake mouse move event in response to a flags change event, for use by the event monitor. (+[WebHTMLView _postFlagsChangedEvent:]): Empty this old call, still kept around for benefit of older Safari. (-[WebHTMLView _updateMouseoverWithEvent:]): Handle Dashboard's special mouseover mode (previously handled in a weird way). (-[WebHTMLView close]): No more need to mess with mouse moved observer. (-[WebHTMLView viewWillMoveToWindow:]): ditto (-[WebHTMLView viewDidMoveToWindow]): ditto; but now hook up a flags changed monitor. (-[WebHTMLView windowDidBecomeKey:]): No need to handle non-key window tracking area or mouse moved observer. (-[WebHTMLView windowDidResignKey:]): ditto (-[WebHTMLView windowWillOrderOnScreen:]): No need to mess with mouse moved observer. (-[WebHTMLView windowWillOrderOffScreen:]): ditto (-[WebHTMLView mouseMoved:]): Converted from the old mouseMovedNotification: (-[WebHTMLView setDataSource:]): Change if around body to early return. Hook up tracking area - we have to do it here, because before this point, the WebHTMLView does not know its WebView, which is where dashboard settings live. (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): Deleted. (-[WebHTMLView addMouseMovedObserver]): Deleted. (-[WebHTMLView removeMouseMovedObserver]): Deleted. 2014-09-04 Pratik Solanki Bring back [WebPreferences setDiskImageCacheEnabled:] for backwards compatibility https://bugs.webkit.org/show_bug.cgi?id=136560 Reviewed by Joseph Pecoraro. I removed the disk image caching code in r173265. However, we still have clients that call setDiskImageCacheEnabled. Add in a stub method until we can wean the clients off this call. * WebView/WebPreferences.mm: (-[WebPreferences setDiskImageCacheEnabled:]): * WebView/WebPreferencesPrivate.h: 2014-09-03 Andy Estes [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT https://bugs.webkit.org/show_bug.cgi?id=136521 Reviewed by Anders Carlsson. Taught MigrateHeaders.make to remove WEBCORE_EXPORT from headers using this sed expression: s/(^ *)WEBCORE_EXPORT /\1/g This removes WEBCORE_EXPORT and a single following space character but preserves preceeding spaces. * MigrateHeaders.make: 2014-09-04 Maciej Stachowiak Remove WebCoreSystemInterface glue for otherwise unused WKSI calls https://bugs.webkit.org/show_bug.cgi?id=136527 Reviewed by Alexey Proskuryakov. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2014-09-04 Eva Balazsfalvi Remove CSS_FILTERS flag https://bugs.webkit.org/show_bug.cgi?id=136529 Reviewed by Dirk Schulze. * Configurations/FeatureDefines.xcconfig: 2014-09-04 Pratik Solanki Remove iOS specific disk image cache https://bugs.webkit.org/show_bug.cgi?id=136517 Reviewed by Antti Koivisto. Disk image cache code unnecessarily complicates SharedBuffer implementation. We can remove this now since we don't enable it in WebKit2 on iOS. * Misc/WebCache.mm: (+[WebCache statistics]): * WebView/WebDataSource.mm: (-[WebDataSource _setAllowToBeMemoryMapped]): (-[WebDataSource setDataSourceDelegate:]): (-[WebDataSource dataSourceDelegate]): (-[WebDataSource dealloc]): (BufferMemoryMapped): Deleted. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences diskImageCacheEnabled]): Deleted. (-[WebPreferences setDiskImageCacheEnabled:]): Deleted. (-[WebPreferences diskImageCacheMinimumImageSize]): Deleted. (-[WebPreferences setDiskImageCacheMinimumImageSize:]): Deleted. (-[WebPreferences diskImageCacheMaximumCacheSize]): Deleted. (-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Deleted. (-[WebPreferences _diskImageCacheSavedCacheDirectory]): Deleted. (-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Deleted. * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (+[WebView _handleMemoryWarning]): (-[WebView _preferencesChanged:]): 2014-09-04 Daniel Bates [iOS] Make iOS build when ENABLE_TOUCH_EVENT and ENABLE_IOS_TOUCH_EVENTS disabled https://bugs.webkit.org/show_bug.cgi?id=136494 Reviewed by Andy Estes. * MigrateHeaders.make: Migrate header WebEventRegion.h only when ENABLE_IOS_TOUCH_EVENTS is defined. * WebView/WebView.mm: Substitute ENABLE(IOS_TOUCH_EVENTS) for ENABLE(TOUCH_EVENTS). 2014-09-02 Brian J. Burg Web Inspector: fix prefixes for subclasses of JSC::ConsoleClient https://bugs.webkit.org/show_bug.cgi?id=136476 Reviewed by Timothy Hatcher. * Misc/WebCoreStatistics.mm: (+[WebCoreStatistics shouldPrintExceptions]): (+[WebCoreStatistics setShouldPrintExceptions:]): 2014-09-03 Enrica Casucci Remove PLATFORM(IOS) from WebCore/editing (Part 1). https://bugs.webkit.org/show_bug.cgi?id=136474 Reviewed by Tim Horton. * WebCoreSupport/WebEditorClient.mm: (undoNameForEditAction): 2014-09-02 Maciej Stachowiak Clean up naming for and slightly refactor legacy video fullscreen support https://bugs.webkit.org/show_bug.cgi?id=136446 Reviewed by Jer Noble. Key changes: supportsFullscreenForNode(Node*) --> supportsVideoFullscreen() enterFullscreenForNode(Node*) --> enterVideoFullscreenForVideoElement(HTMLVideoElement*) exitFullscreenForNode(Node*) --> exitVideoFullscreen() The old versions had unnecessary parameters, did not clearly distinguish their purpose from enterFullscreenForElement and friends, and wrongly claimed generality to all Nodes. Also changed many other places to use HTMLVideoElement* instead of Node* or HTMLMediaElement* when they were in fact only used for video elements and would only work for such. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::supportsVideoFullscreen): Adjust for main refactoring. Also no more need to check for video elementness. (WebChromeClient::enterVideoFullscreenForVideoElement): Adjust for main refactoring. (WebChromeClient::exitVideoFullscreen): ditto * WebView/WebView.mm: (-[WebView _enterVideoFullscreenForVideoElement:]): Adjust for main refactoring. (-[WebView _exitVideoFullscreen]): ditto (-[WebView _close]): ditto * WebView/WebViewInternal.h: 2014-09-03 Dan Bernstein Get rid of HIGH_DPI_CANVAS leftovers https://bugs.webkit.org/show_bug.cgi?id=136491 Reviewed by Benjamin Poulain. * Configurations/FeatureDefines.xcconfig: Removed definition of ENABLE_HIGH_DPI_CANVAS and removed it from FEATURE_DEFINES. 2014-08-31 Tim Horton Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor https://bugs.webkit.org/show_bug.cgi?id=136416 Reviewed by Dan Bernstein. * WebView/WebFrameView.mm: (-[WebFrameView drawRect:]): We only end up filling, so only set the fill color. 2014-08-26 Maciej Stachowiak Use RetainPtr::autorelease in some places where it seems appropriate https://bugs.webkit.org/show_bug.cgi?id=136280 Reviewed by Darin Adler. * WebView/WebHTMLView.mm: (imageFromRect): Use RetainPtr in this function. * WebView/WebPDFRepresentation.mm: (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use RetainPtr in this method. 2014-08-29 Csaba Osztrogonác Unreviwed, remove empty directories. * ForwardingHeaders/wtf: Removed. 2014-08-27 Zalan Bujtas Subpixel layout: Rename LayoutRect's device pixel snapping functions. https://bugs.webkit.org/show_bug.cgi?id=136319 Reviewed by Simon Fraser. From pixelSnappedForPainting() to snapRectToDevicePixels() and pixelSnappedIntRect*() to snappedIntRect*(). No change in functionality. * WebView/WebView.mm: (-[WebView _dashboardRegions]): (-[WebView trackedRepaintRects]): 2014-08-25 Maciej Stachowiak Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API https://bugs.webkit.org/show_bug.cgi?id=136082 Reviewed by Alexey Proskuryakov. * Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current localization name using WebCore helper instead of SPI. * Plugins/WebBasePluginPackage.mm: Fixed the include style for this file. (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current localization name using WebCore helper instead of SPI. (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This helper no longer pulls its weight. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Remove mention of WKCopyCFLocalizationPreferredName. * WebKit.order: ditto 2014-08-25 Daniel Bates Attempt to fix the iOS build after (https://bugs.webkit.org/show_bug.cgi?id=109658) Substitute GraphicsLayer::setContentsToPlatformLayer(..., GraphicsLayer::ContentsLayerForMedia) for GraphicsLayer::setContentsToMedia(...) because the latter was removed in . * WebView/WebView.mm: (-[WebView _setMediaLayer:forPluginView:]): 2014-08-22 Commit Queue Unreviewed, rolling out r172866. https://bugs.webkit.org/show_bug.cgi?id=136177 Broke iOS build (Requested by othermaciej on #webkit). Reverted changeset: "Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API" https://bugs.webkit.org/show_bug.cgi?id=136082 http://trac.webkit.org/changeset/172866 2014-08-22 Simon Fraser Implement paint flashing in the WK1 InspectorOverlay page https://bugs.webkit.org/show_bug.cgi?id=136138 Reviewed by Sam Weinig, Joseph Pecoraro. Implement paint flashing for the WebKit1 InspectorOverlay via a second canvas in the overlay page. We avoid allocating backing store for this canvas until we have paint rects. Because this overlay page is weird and doesn't know how to paint itself, InspectorOverlay manages an array of rects, and pushes them to the page when they change, before forcing a paint. Because iOS doesn't use the InspectorOverlay page, stub out setShowPaintRects on its WebKit WebInspectorClient, but don't yet implement paint flashing there. * WebCoreSupport/WebInspectorClient.h: * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::WebInspectorClient): 2014-08-20 Maciej Stachowiak Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API https://bugs.webkit.org/show_bug.cgi?id=136082 Reviewed by Alexey Proskuryakov. * Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current localization name using WebCore helper instead of SPI. * Plugins/WebBasePluginPackage.mm: Fixed the include style for this file. (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current localization name using WebCore helper instead of SPI. (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This helper no longer pulls its weight. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Remove mention of WKCopyCFLocalizationPreferredName. * WebKit.order: ditto 2014-08-22 Daniel Bates [iOS] Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, and temporarily disable ENABLE_TOUCH_EVENTS and ENABLE_XSLT when building with the iOS public SDK https://bugs.webkit.org/show_bug.cgi?id=135945 Reviewed by Andy Estes. * Configurations/FeatureDefines.xcconfig: Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, ENABLE_TOUCH_EVENTS and ENABLE_XSLT when building with the public SDK. * MigrateHeaders.make: Conditionally migrate headers for touch and gesture events. 2014-08-22 Jon Lee Fix iOS build due to r172832 and move RUBBER_BANDING out of FeatureDefines.h https://bugs.webkit.org/show_bug.cgi?id=136157 Reviewed by Simon Fraser. * Configurations/FeatureDefines.xcconfig: Add ENABLE(RUBBER_BANDING). * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Wrap in ENABLE(RUBBER_BANDING). 2014-08-21 Zalan Bujtas Enable SATURATED_LAYOUT_ARITHMETIC. https://bugs.webkit.org/show_bug.cgi?id=136106 Reviewed by Simon Fraser. SATURATED_LAYOUT_ARITHMETIC protects LayoutUnit against arithmetic overflow. (No measurable performance regression on Mac.) * Configurations/FeatureDefines.xcconfig: 2014-08-21 Beth Dakin overflow:scroll elements should support rubber-banding https://bugs.webkit.org/show_bug.cgi?id=91655 Reviewed by Sam Weinig and Darin Adler. Disable rubber-banding in overflow areas for now. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2014-08-19 Pratik Solanki Remove PurgeableBuffer since it is not very useful any more https://bugs.webkit.org/show_bug.cgi?id=135939 Reviewed by Andreas Kling. * Misc/WebCache.mm: (+[WebCache statistics]): 2014-08-19 Zalan Bujtas Remove ENABLE(SUBPIXEL_LAYOUT). https://bugs.webkit.org/show_bug.cgi?id=136077 Reviewed by Simon Fraser. Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now. * Configurations/FeatureDefines.xcconfig: 2014-08-18 Maciej Stachowiak Use NSURLFileTypeMappings directly instead of depending on WebKitSystemInterface wrappers for it https://bugs.webkit.org/show_bug.cgi?id=136035 Reviewed by Dan Bernstein. * Misc/WebNSViewExtras.m: (-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]): Remove comment reference to obsolete WKSI function. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Don't initialize the no-longer-used WKGetExtensionsForMIMEType, WKGetPreferredExtensionForMIMEType, or WKGetMIMETypeForExtension * Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase pluginForExtension:]): Include SPI header from WebCore; use NSURLFileTypeMappings directly instead of via WKSI wrapper. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::objectContentType): ditto * WebView/WebHTMLView.mm: (-[WebHTMLView _imageExistsAtPaths:]): ditto * WebView/WebView.mm: (+[WebView _supportedFileExtensions]): ditto (+[WebView suggestedFileExtensionForMIMEType:]): ditto (+[WebView _MIMETypeForFile:]): ditto 2014-08-18 Commit Queue Unreviewed, rolling out r172736. https://bugs.webkit.org/show_bug.cgi?id=136060 Caused 14% PLT regressions (Requested by rniwa on #webkit). Reverted changeset: "Remove PurgeableBuffer since it is not very useful any more" https://bugs.webkit.org/show_bug.cgi?id=135939 http://trac.webkit.org/changeset/172736 2014-08-18 Pratik Solanki Remove PurgeableBuffer since it is not very useful any more https://bugs.webkit.org/show_bug.cgi?id=135939 Reviewed by Geoffrey Garen. * Misc/WebCache.mm: (+[WebCache statistics]): 2014-08-18 Andy Estes REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme https://bugs.webkit.org/show_bug.cgi?id=136010 Reviewed by Darin Adler. * Misc/WebKitVersionChecks.h: Removed WEBKIT_FIRST_VERSION_WITH_NAVIGATION_URL_VALIDATION. * WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Passed AllowNavigationToInvalidURL::Yes to FrameLoader::loadFrameRequest. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Reverted the linked-on-or-after check added in r170120 since it's no longer necessary. 2014-08-18 Andy Estes Revert r172697. It made several webarchive layout tests flaky and didn't have the correct behavior for non-quick redirects. * Misc/WebKitVersionChecks.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2014-08-15 Andy Estes REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme https://bugs.webkit.org/show_bug.cgi?id=136010 Reviewed by Darin Adler. Reverted the linked-on-or-after check added in r170120 since it is no longer necessary. * Misc/WebKitVersionChecks.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2014-08-16 Maciej Stachowiak Remove the obsolete WebKitEnableCoalescedUpdatesPreferenceKey https://bugs.webkit.org/show_bug.cgi?id=136024 Reviewed by Filip Pizlo. * WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): Remove code that respects this key. It was SPI and is no longer used; also it was only relevant for versions of OS X that WebKit no longer supports. * WebView/WebPreferenceKeysPrivate.h: Remove declaration. 2014-08-15 Daniel Bates [iOS] Teach postprocess-headers.sh to remove code guarded by ENABLE_IOS_GESTURE_EVENTS and ENABLE_TOUCH_EVENTS if applicable https://bugs.webkit.org/show_bug.cgi?id=135993 Reviewed by Andy Estes. Add support infrastructure to remove code from public and private API headers that is guarded by macro define ENABLE_{IOS_GESTURE, TOUCH}_EVENTS when these features are disabled. We aren't using this functionality yet, but we will soon. * postprocess-headers.sh: 2014-08-13 Wenson Hsieh Enable CSS_SCROLL_SNAP for iOS https://bugs.webkit.org/show_bug.cgi?id=135915 Turn on CSS_SCROLL_SNAP for iOS and the iOS simulator. Reviewed by Tim Horton. * Configurations/FeatureDefines.xcconfig: 2014-08-13 Mark Rowe WebKit should build on Yosemite with the public SDK. Reviewed by Darin Adler. * Misc/WebSharingServicePickerController.mm: Forward-declare some details related to NSSharingServicePicker. 2014-08-13 Timothy Hatcher Web Inspector: Workaround a NSWindow change to the title bar. https://bugs.webkit.org/show_bug.cgi?id=135880 Reviewed by Joseph Pecoraro. * WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::setToolbarHeight): Only call setContentBorderThickness: on 10.9 and earlier. (-[WebInspectorWindowController init]): Only call setDrawsBackground: on 10.9 and earlier. (-[WebInspectorWindowController window]): Set titlebarAppearsTransparent on 10.10. Only call border thickness APIs on 10.9 and earlier. 2014-08-12 Peyton Randolph Runtime switch for long mouse press gesture. Part of 135257 - Add long mouse press gesture. https://bugs.webkit.org/show_bug.cgi?id=135682 Reviewed by Tim Horton. * Configurations/FeatureDefines.xcconfig: Remove LONG_MOUSE_PRESS feature flag. 2014-08-11 Andy Estes [iOS] Get rid of iOS.xcconfig https://bugs.webkit.org/show_bug.cgi?id=135809 Reviewed by Joseph Pecoraro. All iOS.xcconfig did was include AspenFamily.xcconfig, so there's no need for the indirection. * Configurations/Base.xcconfig: * Configurations/iOS.xcconfig: Removed. 2014-08-10 Timothy Hatcher Web Inspector: new glyphs are visible on OS X 10.9 builds https://bugs.webkit.org/show_bug.cgi?id=135743 Reviewed by Joseph Pecoraro. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController window]): Use 10100 instead of 1090 for the version. 2014-08-07 Benjamin Poulain Get rid of SCRIPTED_SPEECH https://bugs.webkit.org/show_bug.cgi?id=135729 Reviewed by Brent Fulgham. * Configurations/FeatureDefines.xcconfig: 2014-08-07 Benjamin Poulain Get rid of INPUT_SPEECH https://bugs.webkit.org/show_bug.cgi?id=135672 Reviewed by Andreas Kling. * Configurations/FeatureDefines.xcconfig: 2014-08-07 Timothy Hatcher Web Inspector: Update glyphs to be more like Xcode 6 https://bugs.webkit.org/show_bug.cgi?id=135705 Reviewed by Joseph Pecoraro. * Resources/Dock.pdf: Added. * Resources/DockLegacy.pdf: Copied from Source/WebKit/mac/Resources/Dock.pdf. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController window]): Use new images. 2014-08-06 Dean Jackson ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED is not used anywhere. Remove it. https://bugs.webkit.org/show_bug.cgi?id=135675 Reviewed by Sam Weinig. * Configurations/FeatureDefines.xcconfig: 2014-08-06 Wenson Hsieh Implement parsing for CSS scroll snap points https://bugs.webkit.org/show_bug.cgi?id=134301 Reviewed by Dean Jackson. * Configurations/FeatureDefines.xcconfig: Added ENABLE_CSS_SCROLL_SNAP 2014-08-06 Alexey Proskuryakov REGRESSION (WebKit2): iOS Safari default encoding doesn't follow system language https://bugs.webkit.org/show_bug.cgi?id=135667 Reviewed by Anders Carlsson. * WebView/WebPreferences.mm: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Moved implementation to WebCore, so that it can be shared with WebKit2. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): We now use WKGetWebDefaultCFStringEncoding in WebCore, so it needs to be initialized. 2014-08-05 Peyton Randolph Rename MAC_LONG_PRESS feature flag to LONG_MOUSE_PRESS. https://bugs.webkit.org/show_bug.cgi?id=135276 Reviewed by Beth Dakin. * Configurations/FeatureDefines.xcconfig: 2014-08-04 Benjamin Poulain Add a flag for the CSS Selectors level 4 implementation https://bugs.webkit.org/show_bug.cgi?id=135535 Reviewed by Andreas Kling. * Configurations/FeatureDefines.xcconfig: 2014-08-04 Benjamin Poulain Check for null frame when processing geolocation authorization request https://bugs.webkit.org/show_bug.cgi?id=135577 Reviewed by Geoffrey Garen. * WebCoreSupport/WebGeolocationClient.mm: (WebGeolocationClient::requestPermission): 2014-08-02 Jeremy Jones Support both window and view based video fullscreen. https://bugs.webkit.org/show_bug.cgi?id=135525 Reviewed by Simon Fraser. Parenting in the view instead of the window gives the fullscreen implementation more latitude in how it implements the animation. * WebView/WebView.mm: (-[WebView _enterFullscreenForNode:]): Use view instead of window. 2014-08-01 Dan Bernstein [iOS] WebKit links against libraries it doesn’t use https://bugs.webkit.org/show_bug.cgi?id=135536 Reviewed by Tim Horton. * Configurations/WebKitLegacy.xcconfig: Removed -framework MobileAsset from OTHER_LDFLAGS_iphoneos. 2014-07-30 Andy Estes USE(CONTENT_FILTERING) should be ENABLE(CONTENT_FILTERING) https://bugs.webkit.org/show_bug.cgi?id=135439 Reviewed by Tim Horton. We now support two different platform content filters, and will soon support a mock content filter (as part of webkit.org/b/128858). This makes content filtering a feature of WebKit, not just an adoption of a third-party library. ENABLE() is the correct macro to use for such a feature. * Configurations/FeatureDefines.xcconfig: 2014-07-30 Andreas Kling Static hash tables no longer need to be coupled with a VM. Reviewed by Geoffrey Garen. * Plugins/Hosted/ProxyInstance.mm: * Plugins/Hosted/ProxyRuntimeObject.mm: 2014-07-30 Dan Bernstein Updated for changes to the WebCore::Credential API. Work towards fixing https://bugs.webkit.org/show_bug.cgi?id=135327 Reviewed by Alexey Proskuryakov. * Misc/WebDownload.mm: (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Use new nsCredential getter. * Plugins/WebBaseNetscapePluginView.mm: (WebKit::getAuthenticationInfo): Ditto. 2014-07-27 Pratik Solanki Remove unused preference keys https://bugs.webkit.org/show_bug.cgi?id=135280 Reviewed by Darin Adler. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences _setPageCacheSize:]): Deleted. (-[WebPreferences _pageCacheSize]): Deleted. (-[WebPreferences _setObjectCacheSize:]): Deleted. (-[WebPreferences _objectCacheSize]): Deleted. * WebView/WebPreferencesPrivate.h: 2014-07-27 Filip Pizlo Merge r170090, r170092, r170129, r170141, r170161, r170215, r170275, r170375, r170376, r170382, r170383, r170399, r170436, r170489, r170490, r170556 from ftlopt. 2014-07-25 Mark Lam [ftlopt] Renamed DebuggerActivation to DebuggerScope. Reviewed by Michael Saboff. * WebView/WebScriptDebugDelegate.mm: - Removed unneeded #include. 2014-07-26 Filip Pizlo Unreviewed, roll out r171641-r171644. It broke some tests; will investigate and reland later. * WebView/WebScriptDebugDelegate.mm: 2014-07-25 Filip Pizlo Merge r170090, r170092, r170129, r170141, r170161, r170215, r170275, r170375, r170376, r170382, r170383, r170399, r170436, r170489, r170490, r170556 from ftlopt. 2014-07-25 Mark Lam [ftlopt] Renamed DebuggerActivation to DebuggerScope. Reviewed by Michael Saboff. * WebView/WebScriptDebugDelegate.mm: - Removed unneeded #include. 2014-07-25 Jeremy Jones Parent fullscreen from window instead of view https://bugs.webkit.org/show_bug.cgi?id=135310 Reviewed by Jer Noble. Parenting in the view causes an incorrect animation to fullscreen, and can cause fullscreen to only expand to the size of the view instead of the whole window. * WebView/WebView.mm: (-[WebView _enterFullscreenForNode:]): Pass window instead of view. 2014-07-24 Pratik Solanki [iOS] Remove prefs to tweak cache values https://bugs.webkit.org/show_bug.cgi?id=135274 Reviewed by Alexey Proskuryakov. Remove iOS specific code that used to look up user defaults to see if any cache values were overridden. This was added for testing, is not used any more and is actually harmful now. It can cause unnecessary memory churn when under memory pressure since we call [WebView _setCacheModel] as a means to clear out memory cache. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences _setNSURLMemoryCacheSize:]): Deleted. (-[WebPreferences _NSURLMemoryCacheSize]): Deleted. (-[WebPreferences _setNSURLDiskCacheSize:]): Deleted. (-[WebPreferences _NSURLDiskCacheSize]): Deleted. * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (+[WebView _setCacheModel:]): 2014-07-24 Peyton Randolph Rename feature flag for long-press gesture on Mac. https://bugs.webkit.org/show_bug.cgi?id=135259 Reviewed by Beth Dakin. * Configurations/FeatureDefines.xcconfig: Rename LINK_LONG_PRESS to MAC_LONG_PRESS. 2014-07-24 Dan Bernstein WebKit part of [Cocoa] WebCore::ProtectionSpace doesn’t preserve all NSURLProtectionSpace properties, such as the distinguishedNames array https://bugs.webkit.org/show_bug.cgi?id=135229 Reviewed by Alexey Proskuryakov. * Misc/WebDownload.mm: (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Chanegd to use the ProtectionSpace constructor that takes an NSURLProtectionSpace. * Plugins/WebBaseNetscapePluginView.mm: (WebKit::getAuthenticationInfo): Ditto. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace): Changed to use ProtectionSpace::nsSpace. 2014-07-23 Bem Jones-Bey Remove CSS_EXCLUSIONS compile flag and leftover code https://bugs.webkit.org/show_bug.cgi?id=135175 Reviewed by Zoltan Horvath. At this point, the CSS_EXCLUSIONS flag guards nothing but some useless stubs. This removes the flag and the useless code. * Configurations/FeatureDefines.xcconfig: 2014-07-22 Enrica Casucci REGRESSION (WebKit2): Selection inside accelerated overflow:scroll doesn't track scrolling. https://bugs.webkit.org/show_bug.cgi?id=135180 Reviewed by Simon Fraser. * WebCoreSupport/WebEditorClient.h: 2014-07-22 Jeremy Jones Don't create new UIWindow for video fullscreen. https://bugs.webkit.org/show_bug.cgi?id=135038 Reviewed by Darin Adler. Provide UIView to WebVideoFullscreenController * WebView/WebView.mm: (-[WebView _enterFullscreenForNode:]): pass UIView instead of nil 2014-07-21 Pratik Solanki Unreviewed iOS build fix after r171321. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2014-07-21 Beth Dakin WK1 should always setAcceleratedCompositingForFixedPositionEnabled(true) on Yosemite https://bugs.webkit.org/show_bug.cgi?id=135135 Reviewed by Darin Adler. Get rid of the ChromeClient function, and enable the Setting instead. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition): Deleted. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2014-07-21 Beth Dakin Build fix. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition): 2014-07-21 Beth Dakin Put position:fixed elements into layers when a WK1 view is layer-backed https://bugs.webkit.org/show_bug.cgi?id=135075 Reviewed by Darin Adler. Returns true when the WebHTMLView has a layer. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition): 2014-07-18 Andy Estes [iOS] Tapping "Allow Website" on a restricted page does not bring up the keypad https://bugs.webkit.org/show_bug.cgi?id=135072 Reviewed by David Kilzer. * WebCoreSupport/WebFrameLoaderClient.h: Override contentFilterDidBlockLoad(). * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): Reset contentFilterForBlockedLoad to nullptr. (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Check if this is navigation represents an unblock request and ignore if so. * WebView/WebFrame.mm: (-[WebFrame _contentFilterDidHandleNavigationAction:]): Called ContentFilter::handleUnblockRequestAndDispatchIfSuccessful(). If the unblock is successful, reload the main frame. * WebView/WebFrameInternal.h: 2014-07-17 David Kilzer SECTORDER_FLAGS should be defined in target's xcconfig file, not Base.xcconfig Reviewed by Darin Adler. * Configurations/Base.xcconfig: Move SECTORDER_FLAGS to WebKitLegacy.xcconfig. * Configurations/DebugRelease.xcconfig: Remove empty SECTORDER_FLAGS definition. * Configurations/WebKit.xcconfig: Removed. Unused. * Configurations/WebKitLegacy.xcconfig: Use $(CONFIGURATION) so SECTORDER_FLAGS is only set on Production builds. 2014-07-17 Timothy Hatcher Make console.profile record to the Timeline. https://bugs.webkit.org/show_bug.cgi?id=134643 Reviewed by Joseph Pecoraro. * WebInspector/WebInspector.mm: (-[WebInspector isProfilingJavaScript]): (-[WebInspector toggleProfilingJavaScript:]): (-[WebInspector startProfilingJavaScript:]): (-[WebInspector stopProfilingJavaScript:]): (-[WebInspector isJavaScriptProfilingEnabled]): (-[WebInspector setJavaScriptProfilingEnabled:]): 2014-07-16 David Kilzer [iOS] Update order file paths for WebKit and WebKit2 Reviewed by Darin Adler. * Configurations/Base.xcconfig: Rename WebKit.order to WebKitLegacy.order. 2014-07-16 Brady Eidson Add WebSecurityOrigin "webSecurityOriginFromDatabaseIdentifier" SPI and change _websiteDataURLForContainerWithURL: SPI and https://bugs.webkit.org/show_bug.cgi?id=134984 Reviewed by Dan Bernstein. * WebCoreSupport/WebSecurityOrigin.mm: (+[WebSecurityOrigin webSecurityOriginFromDatabaseIdentifier:]): Added. (-[WebSecurityOrigin initWithURL:]): Update using RefPtr API to avoid a ref(). 2014-07-15 Myles C. Maxfield [OSX] [WK1] Crash when exiting fullscreen https://bugs.webkit.org/show_bug.cgi?id=134943 Reviewed by Dean Jackson. AppKit doesn't remove a view from the Key View Loop when removing it from its superview. This codepath is already "tested" in fullscreen/full-screen-cancel.html, but because of our testing infrastructure, the broken codepath doesn't actually get hit in DRT. Therefore, there is no test. * WebView/WebFullScreenController.mm: (-[WebFullScreenController enterFullScreen:]): * WebCoreSupport/WebSecurityOriginPrivate.h: 2014-07-14 Bear Travis [Feature Queries] Enable Feature Queries on Mac https://bugs.webkit.org/show_bug.cgi?id=134404 Reviewed by Antti Koivisto. Enable Feature Queries on Mac and resume running the feature tests. * Configurations/FeatureDefines.xcconfig: Turn on ENABLE_CSS3_CONDITIONAL_RULES. 2014-07-11 Zalan Bujtas Subpixel layout: return integral results for offset*, client*, scroll* by default. https://bugs.webkit.org/show_bug.cgi?id=134651 Reviewed by Simon Fraser. Revert to returning integral values for Element.offset* client* scroll* by default. Fractional values break number of sites(tight design) and JS frameworks(fail to handle fractional values). Since snapped dimension depends on both the original point and the width/height of the box, we need to call RenderBoxModelObject::pixelSnapped*() helpers, instead of round(). Covered by existing tests * WebView/WebPreferences.mm: (+[WebPreferences initialize]): 2014-07-10 Joseph Pecoraro [Mac] NSWindow warning: adding an unknown subview opening detached Inspector https://bugs.webkit.org/show_bug.cgi?id=134813 Reviewed by Timothy Hatcher. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController window]): Use a selector that will avoid the warning message. 2014-07-09 Ryosuke Niwa REGRESSION(r167770): Cannot login in Evernote Safari extension https://bugs.webkit.org/show_bug.cgi?id=134776 Reviewed by Enrica Casucci. Unfortunately, NSWindowDidBecomeKeyNotification does not notify us when a popover becomes key so we need to keep using the SPI (_windowChangedKeyState) I removed in r167770. * WebView/WebView.mm: (-[WebView _windowChangedKeyState]): 2014-07-09 Enrica Casucci Implement Editor::fontAttributesForSelectionStart() or iOS. https://bugs.webkit.org/show_bug.cgi?id=134771 Reviewed by Ryosuke Niwa. * WebView/WebViewPrivate.h: 2014-07-08 Tim Horton [WK2] Expose a few drawing/compositing settings on WKPreferences(Private) https://bugs.webkit.org/show_bug.cgi?id=134645 Reviewed by Dan Bernstein. * WebView/WebPreferences.mm: (-[WebPreferences setSubpixelCSSOMElementMetricsEnabled:]): Remove an extra unnecessary space. 2014-07-03 Daniel Bates Add WTF::move() https://bugs.webkit.org/show_bug.cgi?id=134500 Rubber-stamped by Anders Carlsson. Substitute WTF::move() for std::move(). * History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): * Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::setCurrentReply): * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]): * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDecidePolicyForResponse): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::dispatchWillSubmitForm): * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::openInspectorFrontend): (WebInspectorFrontendClient::WebInspectorFrontendClient): * WebView/WebArchive.mm: (-[WebArchive initWithMainResource:subresources:subframeArchives:]): 2014-07-01 Mark Rowe Remove duplication in code that prepares the user agent string on Mac and iOS Reviewed by Simon Fraser. * WebView/WebView.mm: (webKitBundleVersionString): Return the entire CFBundleVersion now that WebCore handles formatting it. (+[WebView _standardUserAgentWithApplicationName:]): 2014-07-02 Dan Bernstein Remove some code only needed for versions of Safari that are no longer supported https://bugs.webkit.org/show_bug.cgi?id=134537 Reviewed by Anders Carlsson. * History/WebHistoryItem.mm: * Misc/WebKitVersionChecks.h: * WebCoreSupport/WebSecurityOrigin.mm: (-[WebSecurityOrigin domain]): Deleted. * WebInspector/WebInspector.mm: (-[WebInspector showTimeline:]): Deleted. (+[WebInspector webInspector]): Deleted. (-[WebInspector setWebFrame:]): Deleted. (-[WebInspector window]): Deleted. (-[WebInspector showWindow:]): Deleted. * WebView/WebFrame.mm: (-[WebFrame reload]): * WebView/WebPDFView.mm: (-[WebPDFView menuForEvent:]): (-[WebPDFView _anyPDFTagsFoundInMenu:]): Deleted. * WebView/WebView.mm: (-[WebView _initWithFrame:frameName:groupName:]): (-[WebView _preferencesChanged:]): (-[WebView initWithFrame:frameName:groupName:]): (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]): Deleted. (+[WebView _setAlwaysUseATSU:]): Deleted. (-[WebView _needsUnrestrictedGetMatchedCSSRules]): Deleted. * WebView/WebViewPrivate.h: 2014-07-01 Dan Bernstein Remove WebChromeClient code that was only needed for Safari versions earlier than 3.1 https://bugs.webkit.org/show_bug.cgi?id=134531 Reviewed by Daniel Bates. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::exceededDatabaseQuota): 2014-06-29 Yoav Weiss Add support for HTMLImageElement's sizes attribute https://bugs.webkit.org/show_bug.cgi?id=133620 Reviewed by Dean Jackson. Added an ENABLE_PICTURE_SIZES compile flag. * Configurations/FeatureDefines.xcconfig: 2014-06-27 Sam Weinig InfoClick (from Nisus Software) dies on viewing found items https://bugs.webkit.org/show_bug.cgi?id=134410 Reviewed by Andy Estes. InfoClick was calling -[WebPreferences setPrivateBrowsingEnabled:] before setting up a WebView (or anything else that would have set up WebKitSystemInterface), which now requires a set up WebKitSystemInterface. We can fix this by initializing it from +[WebPreferences initialize]. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Add call to InitWebCoreSystemInterface(). (+[WebPreferences _switchNetworkLoaderToNewTestingSession]): Remove now unnecessary call to InitWebCoreSystemInterface(). 2014-06-27 Peyton Randolph Add feature flag for link long-press gesture. https://bugs.webkit.org/show_bug.cgi?id=134262 Reviewed by Enrica Casucci. * Configurations/FeatureDefines.xcconfig: Add ENABLE_LINK_LONG_PRESS. 2014-06-26 Brady Eidson Remove use of PlatformStrategies for Gamepad API. https://bugs.webkit.org/show_bug.cgi?id=134348 Reviewed by Dean Jackson. Remove all the GamepadStrategy gunk: * WebCoreSupport/WebHIDGamepadController.mm: Removed. * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::createGamepadStrategy): Deleted. (WebPlatformStrategies::startMonitoringGamepads): Deleted. (WebPlatformStrategies::stopMonitoringGamepads): Deleted. (WebPlatformStrategies::platformGamepads): Deleted. Instead, install the HIDGamepadProvider as the shared GamepadProvider: * WebView/WebView.mm: (WebKitInitializeGamepadProviderIfNecessary): (-[WebView _commonInitializationWithFrameName:groupName:]): 2014-06-26 Joseph Pecoraro [iOS] Remove User Default for iOS TextField Debugging https://bugs.webkit.org/show_bug.cgi?id=134356 Reviewed by Timothy Hatcher. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebView.mm: (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): 2014-06-25 Brady Eidson Add HID-based gamepad implementation for Mac https://bugs.webkit.org/show_bug.cgi?id=134324 Reviewed by Dean Jackson. Add a class that acts as an intermediary between the GamepadStrategyClient and the HIDGamepadListener: * WebCoreSupport/WebHIDGamepadController.h: * WebCoreSupport/WebHIDGamepadController.mm: (WebHIDGamepadController::shared): (WebHIDGamepadController::WebHIDGamepadController): (WebHIDGamepadController::gamepadConnected): (WebHIDGamepadController::gamepadDisconnected): (WebHIDGamepadController::registerGamepadStrategyClient): (WebHIDGamepadController::unregisterGamepadStrategyClient): Implement the strategies by using the HIDGamepadListener: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::startMonitoringGamepads): (WebPlatformStrategies::stopMonitoringGamepads): (WebPlatformStrategies::platformGamepads): 2014-06-25 Brady Eidson Add new platform gamepad abstractions https://bugs.webkit.org/show_bug.cgi?id=134325 Reviewed by Dean Jackson. * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::createGamepadStrategy): (WebPlatformStrategies::startMonitoringGamepads): (WebPlatformStrategies::stopMonitoringGamepads): (WebPlatformStrategies::platformGamepads): 2014-06-25 Gavin Barraclough Should _updateVisibilityState on view hide/unhide. https://bugs.webkit.org/show_bug.cgi?id=134314 rdar://17171803 Reviewed by Sam Weinig. * WebView/WebView.mm: (-[WebView viewDidHide]): (-[WebView viewDidUnhide]): 2014-06-25 Chris Fleizach Add an undo group for each dictated utterance in WebKit https://bugs.webkit.org/show_bug.cgi?id=134086 Reviewed by Enrica Casucci. * WebView/WebHTMLView.mm: (-[WebHTMLView validAttributesForMarkedText]): (-[WebHTMLView insertText:]): 2014-06-25 Dana Burkart Add support for 5-tuple versioning. Reviewed by David Farler. * Configurations/Version.xcconfig: 2014-06-25 Laszlo Gombos Remove build guard for progress element https://bugs.webkit.org/show_bug.cgi?id=134292 Reviewed by Benjamin Poulain. * Configurations/FeatureDefines.xcconfig: 2014-06-24 Benjamin Poulain WK1 WebFrameNetworkingContext cleanup: do not instanciate an empty NSString to create an empty WTF::String https://bugs.webkit.org/show_bug.cgi?id=134222 Reviewed by Andreas Kling. * WebCoreSupport/WebFrameNetworkingContext.mm: (WebFrameNetworkingContext::sourceApplicationIdentifier): 2014-06-24 Joseph Pecoraro [iOS]: WK2 Inspector Node Highlighting https://bugs.webkit.org/show_bug.cgi?id=134257 Reviewed by Timothy Hatcher. * WebInspector/WebNodeHighlightView.mm: (-[WebNodeHighlightView layoutSublayers:]): 2014-06-24 Brady Eidson Enable GAMEPAD in the Mac build, but disabled at runtime. https://bugs.webkit.org/show_bug.cgi?id=134255 Reviewed by Dean Jackson. * Configurations/FeatureDefines.xcconfig: * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (-[WebPreferences gamepadsEnabled]): (-[WebPreferences setGamepadsEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2014-06-24 Dan Bernstein Fixed the iOS build after r170358. * WebView/WebView.mm: (kit): 2014-06-23 Anders Carlsson Remove unused history visit code from WebHistoryItem https://bugs.webkit.org/show_bug.cgi?id=134201 Reviewed by Sam Weinig. * History/HistoryPropertyList.h: * History/HistoryPropertyList.mm: (HistoryPropertyListWriter::HistoryPropertyListWriter): (HistoryPropertyListWriter::writeHistoryItem): * History/WebHistory.mm: (-[WebHistoryPrivate visitedURL:withTitle:]): (-[WebHistoryPrivate addItem:discardDuplicate:]): (-[WebHistory _visitedURL:withTitle:method:wasFailure:]): (-[WebHistoryPrivate visitedURL:withTitle:increaseVisitCount:]): Deleted. (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]): Deleted. * History/WebHistoryInternal.h: * History/WebHistoryItem.mm: (-[WebHistoryItem copyWithZone:]): (-[WebHistoryItem initFromDictionaryRepresentation:]): (-[WebHistoryItem _visitedWithTitle:]): (-[WebHistoryItem setVisitCount:]): Deleted. (-[WebHistoryItem _mergeAutoCompleteHints:]): Deleted. (-[WebHistoryItem _visitedWithTitle:increaseVisitCount:]): Deleted. (-[WebHistoryItem _recordInitialVisit]): Deleted. (timeToDay): Deleted. (-[WebHistoryItem _padDailyCountsForNewVisit:]): Deleted. (-[WebHistoryItem _collapseDailyVisitsToWeekly]): Deleted. (-[WebHistoryItem _recordVisitAtTime:increaseVisitCount:]): Deleted. (-[WebHistoryItem _setLastVisitedTimeInterval:]): Deleted. * History/WebHistoryItemInternal.h: * History/WebHistoryItemPrivate.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): 2014-06-24 Eva Balazsfalvi REGRESSION(r170235): Remove incorrect ifdef guard https://bugs.webkit.org/show_bug.cgi?id=134246 Reviewed by Csaba Osztrogonác. * WebView/WebView.mm: (-[WebView _visibilityState]): 2014-06-23 Anders Carlsson Fix build. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2014-06-21 Dan Bernstein Tried to fix the iOS build after r170235. * WebView/WebView.mm: 2014-06-21 Brady Eidson Gamepad API - Deprecate the existing implementation https://bugs.webkit.org/show_bug.cgi?id=134108 Reviewed by Timothy Hatcher. -Add new "GAMEPAD_DEPRECATED" build flag, moving the existing implementation to use it -Move some implementation files into a "deprecated" subdirectory. * Configurations/FeatureDefines.xcconfig: 2014-06-21 Commit Queue Unreviewed, rolling out r170244. https://bugs.webkit.org/show_bug.cgi?id=134157 GTK/EFL bindings generator works differently, making this patch not work there. Will fix entire patch after a rollout. (Requested by bradee-oh on #webkit). Reverted changeset: "Gamepad API - Deprecate the existing implementation" https://bugs.webkit.org/show_bug.cgi?id=134108 http://trac.webkit.org/changeset/170244 2014-06-21 Brady Eidson Gamepad API - Deprecate the existing implementation https://bugs.webkit.org/show_bug.cgi?id=134108 Reviewed by Timothy Hatcher. -Add new "GAMEPAD_DEPRECATED" build flag, moving the existing implementation to use it -Add the "Deprecated" suffix to some implementation files * Configurations/FeatureDefines.xcconfig: 2014-06-21 Eva Balazsfalvi Removing PAGE_VISIBILITY_API compile guard. https://bugs.webkit.org/show_bug.cgi?id=133844 Reviewed by Gavin Barraclough. * Configurations/FeatureDefines.xcconfig: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): (-[WebView _visibilityState]): 2014-06-18 Anders Carlsson Make FrameLoadType a strongly typed enum https://bugs.webkit.org/show_bug.cgi?id=134047 Reviewed by Andreas Kling. * WebView/WebFrame.mm: (toWebFrameLoadType): (-[WebFrame _loadType]): * WebView/WebView.mm: (-[WebView _loadBackForwardListFromOtherView:]): (-[WebView goToBackForwardItem:]): 2014-06-18 Daniel Bates REGRESSION (r167856): Unable to log into HSBC app https://bugs.webkit.org/show_bug.cgi?id=133991 Reviewed by David Kilzer. Only enable the setting allowNavigationToInvalidURL for iOS app linked against WebKit/UIKit before iOS 8. * Misc/WebKitVersionChecks.h: Added macro constant WEBKIT_FIRST_VERSION_WITH_NAVIGATION_URL_VALIDATION. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Enable or disable the setting allowNavigationToInvalidURL as appropriate. 2014-06-18 Anders Carlsson Adopt modern C++11 loops and fix WebArchive creation functions https://bugs.webkit.org/show_bug.cgi?id=134032 Reviewed by Andreas Kling. * WebView/WebArchive.mm: (-[WebArchive initWithMainResource:subresources:subframeArchives:]): * WebView/WebDataSource.mm: (-[WebDataSource subresources]): 2014-06-15 Anders Carlsson Add an autorelease() member function to RetainPtr https://bugs.webkit.org/show_bug.cgi?id=133929 Reviewed by Dan Bernstein. * WebView/WebDataSource.mm: (-[WebDataSource data]): * WebView/WebHTMLView.mm: (-[WebHTMLView _selectionDraggingImage]): (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]): * WebView/WebResource.mm: (-[WebResource data]): 2014-06-11 Jeremy Jones WebFrameNetworkContext should not have a sourceApplicationIdentifier in WK1. https://bugs.webkit.org/show_bug.cgi?id=133772 Reviewed by Jer Noble. Return empty string from sourceApplicationIdentifier for WK1. * WebCoreSupport/WebFrameNetworkingContext.mm: (WebFrameNetworkingContext::sourceApplicationIdentifier): 2014-06-10 Timothy Horton Factor repeated CFRunLoopObserver code out https://bugs.webkit.org/show_bug.cgi?id=133690 Reviewed by Simon Fraser. * WebView/WebViewData.h: 2014-06-05 Pratik Solanki Remove unsused method _setAcceleratedImageDecoding https://bugs.webkit.org/show_bug.cgi?id=133554 Reviewed by Jon Honeycutt. * WebView/WebView.mm: (+[WebView _setAcceleratedImageDecoding:]): Deleted. * WebView/WebViewPrivate.h: 2014-06-05 Benjamin Poulain [iOS][WK2] Add device orientation https://bugs.webkit.org/show_bug.cgi?id=133530 Reviewed by Tim Horton. * WebView/WebFrame.mm: (-[WebFrame deviceOrientationChanged]): (-[WebFrame sendOrientationChangeEvent:]): * WebView/WebFramePrivate.h: 2014-05-31 Anders Carlsson Change DeferrableOneShotTimer to use std::function instead of being a class template https://bugs.webkit.org/show_bug.cgi?id=133423 Reviewed by Antti Koivisto. * WebView/WebView.mm: (+[WebView _setCacheModel:]): 2014-05-27 Jon Lee Update ENABLE(MEDIA_SOURCE) on Mac https://bugs.webkit.org/show_bug.cgi?id=133141 Reviewed by Darin Adler. * Configurations/FeatureDefines.xcconfig: 2014-05-27 Tibor Meszaros Remove BLOB guards https://bugs.webkit.org/show_bug.cgi?id=132863 Reviewed by Csaba Osztrogonác. * Configurations/FeatureDefines.xcconfig: * WebView/WebView.mm: (+[WebView _canHandleRequest:forMainFrame:]): 2014-05-24 Chris Fleizach AX: fix coordinate mapping for iOS accessibility https://bugs.webkit.org/show_bug.cgi?id=133188 Reviewed by Sam Weinig. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::accessibilityScreenToRootView): (WebChromeClient::rootViewToAccessibilityScreen): 2014-05-23 Jeremy Jones Hide fullscreen immediately when switching tabs. https://bugs.webkit.org/show_bug.cgi?id=133239 Reviewed by Eric Carlson. Renamed a function to better describe it's new functionality. * WebView/WebView.mm: (-[WebView viewDidMoveToWindow]): now calls: requestHideAndExitFullscreen 2014-05-20 Dean Jackson [Mac] Allow popup menus to override default appearance https://bugs.webkit.org/show_bug.cgi?id=133129 Reviewed by Tim Horton. Replace the call to wkPopupMenuWithSize with wkPopupMenu, now with extra parameters to indicate the control size and whether or not to draw the arrows at the end. * WebCoreSupport/PopupMenuMac.mm: (PopupMenuMac::show): 2014-05-20 Eric Carlson [Mac] do not deactivate an audio session that has running I/O https://bugs.webkit.org/show_bug.cgi?id=133127 Reviewed by Jer Noble. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Settings::setShouldManageAudioSession renamed to setShouldManageAudioSessionCategory, deal with it. 2014-05-19 Brady Eidson Use different AppKit API for image control menus. and https://bugs.webkit.org/show_bug.cgi?id=133087 Reviewed by Tim Horton. For image control menus, use popUpMenuPositioningItem: instead of popUpContextMenu: * WebCoreSupport/WebContextMenuClient.h: * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuForEvent): (WebContextMenuClient::showContextMenu): 2014-05-19 Andy Estes Set WebKitSuppressesIncrementalRenderingKey to NO by default on both Mac and iOS https://bugs.webkit.org/show_bug.cgi?id=133073 Reviewed by Simon Fraser. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): 2014-05-18 Anders Carlsson Bring back two NSString category methods on iOS https://bugs.webkit.org/show_bug.cgi?id=133055 Reviewed by Adele Peterson. * Misc/WebNSURLExtras.h: * Misc/WebNSURLExtras.mm: (-[NSString _webkit_unescapedQueryValue]): (-[NSString _webkit_queryKeysAndValues]): 2014-05-18 Rik Cabanier support for navigator.hardwareConcurrency https://bugs.webkit.org/show_bug.cgi?id=132588 Reviewed by Filip Pizlo. * Configurations/FeatureDefines.xcconfig: 2014-05-17 Zalan Bujtas Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences. https://bugs.webkit.org/show_bug.cgi?id=133029 Reviewed by Simon Fraser. To match the WK2 preferences API. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences subpixelCSSOMElementMetricsEnabled]): (-[WebPreferences setSubpixelCSSOMElementMetricsEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2014-05-16 Simon Fraser Remove "region-based columns" prefs https://bugs.webkit.org/show_bug.cgi?id=133006 Reviewed by Dave Hyatt. Remove "region-based columns" prefs and related code, since this is only way to render columns now. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setRegionBasedColumnsEnabled:]): Deleted. (-[WebPreferences regionBasedColumnsEnabled]): Deleted. * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2014-05-15 Brady Eidson Crash in [WebSharingServicePickerController clear] and https://bugs.webkit.org/show_bug.cgi?id=132968 Reviewed by Tim Horton. * Misc/WebSharingServicePickerController.mm: (-[WebSharingServicePickerController clear]): Add a RetainPtr protector so this object isn’t dealloc’ed partway through. 2014-05-15 Simon Fraser Initialize the WebKitRegionBasedColumnsEnabled pref on iOS WK1 https://bugs.webkit.org/show_bug.cgi?id=132969 Reviewed by Dan Bernstein. Move this outside the #if !PLATFORM(IOS) block. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): 2014-05-15 Simon Fraser Clean up -[WebView _preferencesChanged] https://bugs.webkit.org/show_bug.cgi?id=132967 Reviewed by Sam Weinig. -[WebView _preferencesChanged] was a horrible mess of #ifdefs. Clean this up by moving all the #if PLATFORM() code together, and moving all the feature-define related settings to the end. No behavior changes, checked by diffing the resulting Settings with and without the patch, on OS X and iOS. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2014-05-15 Alex Christensen Add pointer lock to features without enabling it. https://bugs.webkit.org/show_bug.cgi?id=132961 Reviewed by Sam Weinig. * Configurations/FeatureDefines.xcconfig: Added ENABLE_POINTER_LOCK to list of features. * WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Added extra parameters needed when pointer lock is enabled. 2014-05-14 Brady Eidson Implement NSSharingServiceDelegate method "transitionImageForShareItem" and https://bugs.webkit.org/show_bug.cgi?id=132911 Reviewed by Tim Horton. * Misc/WebSharingServicePickerController.mm: (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]): * WebCoreSupport/WebContextMenuClient.h: * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::renderedImageForControlledImage): Paint the entire content rect for the controlled image into an ImageBuffer, then return the resulting NSImage. This only paints the image itself and not any overlapping content by setting the selection and appropriate painting mode. 2014-05-14 Brady Eidson sourceFrameOnScreenForShareItem: can be off by a pixel and https://bugs.webkit.org/show_bug.cgi?id=132911 Reviewed by Simon Fraser. In a land of LayoutUnits and sub-pixel rendering, converting between IntRects and FloatRects can be error prone. So we now try to minimize such conversions. * Misc/WebSharingServicePickerController.mm: (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]): * WebCoreSupport/WebContextMenuClient.h: * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::clientFloatRectForNode): Split this into a separate utility method as it will be shared with other code very soon. Instead of using absoluteBoundingBoxRect() which does lossy float->int conversions, try to keep things in terms of FloatRects as much as possible. (WebContextMenuClient::screenRectForHitTestNode): Call clientFloatRectForNode to get the FloatRect, then perform the lossy rounding conversion to an IntRect only once. 2014-05-14 Tibor Meszaros Remove CSS_STICKY_POSITION guards https://bugs.webkit.org/show_bug.cgi?id=132676 Reviewed by Simon Fraser. * Configurations/FeatureDefines.xcconfig: 2014-05-14 Antti Koivisto GIF animations don't restart after scrolling with iOS WebKit1 https://bugs.webkit.org/show_bug.cgi?id=132900 Reviewed by Andreas Kling. * WebView/WebView.mm: (-[WebView _didFinishScrollingOrZooming]): Check if the animations need to be restarted after scrolling finishes. 2014-05-09 Joseph Pecoraro Web Inspector: Allow Remote Inspector to entitlement check UIProcess through WebProcess https://bugs.webkit.org/show_bug.cgi?id=132409 Reviewed by Timothy Hatcher. Simplify the legacy iOS UIWebViewController case by passing on the host process pid and audit_token. * WebView/WebView.mm: (-[WebView _setHostApplicationProcessIdentifier:auditToken:]): (-[WebView setHostApplicationBundleId:name:]): Deleted. (-[WebView hostApplicationBundleId]): Deleted. (-[WebView hostApplicationName]): Deleted. * WebView/WebViewData.h: * WebView/WebViewData.mm: (-[WebViewPrivate dealloc]): * WebView/WebViewPrivate.h: 2014-05-09 Benjamin Poulain [iOS] Switch geolocation to an explicit authorization query model https://bugs.webkit.org/show_bug.cgi?id=132717 Reviewed by Sam Weinig. Since there is no warmup code, WebGeolocationPolicyListener no longer need to know about the provider, which is awesome :) * WebCoreSupport/WebGeolocationClient.mm: (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]): (-[WebGeolocationPolicyListener deny]): (-[WebGeolocationProviderInitializationListener initializationAllowedWebView:]): (-[WebGeolocationProviderInitializationListener initializationDeniedWebView:]): (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:provider:]): Deleted. (-[WebGeolocationProviderInitializationListener initializationAllowedWebView:provider:]): Deleted. (-[WebGeolocationProviderInitializationListener initializationDeniedWebView:provider:]): Deleted. * WebView/WebViewPrivate.h: 2014-05-08 Jer Noble [Mac, iOS] Add source application accounting to AVURLAsset. https://bugs.webkit.org/show_bug.cgi?id=132637 Reviewed by Eric Carlson. Add accessor for sourceApplicationIdentifier. * WebCoreSupport/WebFrameNetworkingContext.h: * WebCoreSupport/WebFrameNetworkingContext.mm: (WebFrameNetworkingContext::sourceApplicationIdentifier): 2014-05-08 Anders Carlsson Use a different install name for WebKitLegacy.framework for staged framework builds https://bugs.webkit.org/show_bug.cgi?id=132711 Reviewed by Dan Bernstein. * Configurations/WebKitLegacy.xcconfig: 2014-05-08 Brady Eidson Wrap a new class definition with __has_include() and https://bugs.webkit.org/show_bug.cgi?id=132694 Reviewed by Tim Horton. * Misc/WebSharingServicePickerController.mm: 2014-05-07 Pratik Solanki Use system defaults for hardware jpeg decoding https://bugs.webkit.org/show_bug.cgi?id=132661 Reviewed by Tim Horton. Remove code that explicitly disabled hardware image decoding. Let the system decide what to do. * WebView/WebView.mm: (+[WebView _setAcceleratedImageDecoding:]): (+[WebView _acceleratedImageDecoding]): Deleted. * WebView/WebViewPrivate.h: 2014-05-07 Brent Fulgham [Mac, iOS] REGRESSION: WK2 YouTube support https://bugs.webkit.org/show_bug.cgi?id=132568 Reviewed by Darin Adler. * Misc/WebNSURLExtras.h: * Misc/WebNSURLExtras.mm: Remove code that has been converted to C++ and added to YouTubePluginReplacement.cpp. (-[NSURL _webkit_youTubeURL]): (-[NSString _webkit_queryKeysAndValues]): (createYouTubeURL): Deleted. (-[NSString _webkit_unescapedQueryValue]): Deleted. 2014-05-07 Jeremy Jones HTMLMediaElement should exitFullscreen when view is removed from the window. https://bugs.webkit.org/show_bug.cgi?id=132506 Reviewed by Tim Horton. * WebView/WebView.mm: (-[WebView viewDidMoveToWindow]): Request WebVideoFullscreenController to exitFullscreen when view is removed from the window. 2014-05-07 Brady Eidson Image menu is offset by the amount the view is scrolled and https://bugs.webkit.org/show_bug.cgi?id=132663 Reviewed by Tim Horton. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::showContextMenu): Use FrameView::contentsToWindow instead of contentsToRoot, and skip the [NSView convertPoint:toView:] step. 2014-05-07 Simon Fraser WebKit1 is flashy when compositing layers come and go https://bugs.webkit.org/show_bug.cgi?id=132655 Reviewed by Sam Weinig. In r166117 I removed code to flush compositing layers in FrameView::paintContents(), which caused problems when painting iframes. However, this removed a flush that WebKit1 relied on to flush compositing layers when painting, which caused flashing when compositing layers come and go, and broke WebView snapshotting in some cases. Fix by adding back compositing layer flushing, but this time in WebKit1's -viewWillDraw code path. This allows removal of some flushing in DumpRenderTree. * WebView/WebHTMLView.mm: (-[WebHTMLView viewWillDraw]): * WebView/WebView.mm: (-[WebView _flushCompositingChanges]): * WebView/WebViewInternal.h: * WebView/WebViewPrivate.h: 2014-05-07 Manuel Rego Casasnovas [CSS Grid Layout] Remove runtime feature https://bugs.webkit.org/show_bug.cgi?id=132382 Reviewed by Benjamin Poulain. Remove cssGridLayoutEnabled setting usage. * WebKit.order: * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences cssGridLayoutEnabled]): Deleted. (-[WebPreferences setCSSGridLayoutEnabled:]): Deleted. * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2014-05-06 Dean Jackson [Mac] Allow focus rings to redraw themselves if necessary https://bugs.webkit.org/show_bug.cgi?id=132593 Reviewed by Simon Fraser. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Add DrawFocusRingAtTime and DrawCellFocusRingWithFrameAtTime. 2014-05-06 Brady Eidson Don't select an image that is about to have its menu shown. and https://bugs.webkit.org/show_bug.cgi?id=132579 Reviewed by Tim Horton. * Misc/WebSharingServicePickerController.mm: (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]): Call the new replaceNodeFromPasteboard API instead of readSelectionFromPasteboard. 2014-05-06 Anders Carlsson Move the WebKitLegacy header check to the right file https://bugs.webkit.org/show_bug.cgi?id=132620 Reviewed by Dan Bernstein. * WebKitLegacy/MigrateHeadersFromWebKitLegacy.make: * WebKitLegacy/WebKit.h: 2014-05-06 Anders Carlsson Put WebKitPluginHost.app in WebKitLegacy.framework https://bugs.webkit.org/show_bug.cgi?id=132592 Reviewed by Dan Bernstein. * Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost): 2014-05-06 Darin Adler [iOS] Fix two more AdoptCF I missed in my last patch. * WebView/WebHTMLView.mm: (imageFromRect): Use adoptCF instead of AdoptCF. 2014-05-05 Andreas Kling Unreviewed, rolling out r168334. Broke builds. Reverted changeset: "Put WebKitPluginHost.app in WebKitLegacy.framework" https://bugs.webkit.org/show_bug.cgi?id=132592 http://trac.webkit.org/changeset/168334 2014-05-05 Anders Carlsson Put WebKitPluginHost.app in WebKitLegacy.framework https://bugs.webkit.org/show_bug.cgi?id=132592 Reviewed by Dan Bernstein. * Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost): 2014-05-02 Brady Eidson Implement new delegate method -sharingService:sourceFrameOnScreenForShareItem:. and https://bugs.webkit.org/show_bug.cgi?id=132484 Reviewed by Tim Horton. * Misc/WebSharingServicePickerController.mm: (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]): * WebCoreSupport/WebContextMenuClient.h: * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::screenRectForHitTestNode): 2014-05-02 Brady Eidson Crash inside [WebSharingServicePickerController clear] and https://bugs.webkit.org/show_bug.cgi?id=132477 Reviewed by Tim Horton. * Misc/WebSharingServicePickerController.h: * Misc/WebSharingServicePickerController.mm: (-[WebSharingServicePickerController clear]): clear can be called twice, so null check _menuClient. * WebCoreSupport/WebContextMenuClient.h: * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::~WebContextMenuClient): For a sanity check, call clear on the picker here. 2014-05-01 Tim Horton More 32-bit build fixes. * Misc/WebSharingServicePickerController.mm: (-[WebSharingServicePickerController sharingService:didShareItems:]): 2014-05-01 Tim Horton Temporarily "fix" the 32-bit build. * Misc/WebSharingServicePickerController.mm: This will fail miserably at runtime, but we shouldn't ever get here in a 32-bit process. 2014-05-01 Brady Eidson Update service picker API usage. and https://bugs.webkit.org/show_bug.cgi?id=132452 Reviewed by Tim Horton. * Misc/WebSharingServicePickerController.h: * Misc/WebSharingServicePickerController.mm: (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]): Factor out a common "didShare" handler that optionally validates whether the data represents an image. (-[WebSharingServicePickerController sharingService:didShareItems:]): Update API usage, including marshalling on off-main thread call back to the main thread. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuForEvent): Update API usage. 2014-05-01 Anders Carlsson Support OS-version-specific install paths for WebKit.framework https://bugs.webkit.org/show_bug.cgi?id=132448 Reviewed by Dan Bernstein. * WebKitLegacy/WebKit.m: Add version specific install names. 2014-04-30 Alexey Proskuryakov Roll out fix for https://bugs.webkit.org/show_bug.cgi?id=131637: Clean up unnecessary methods in the BackForwardClient interface It broke a regression test and an API test. * History/WebBackForwardList.mm: (-[WebBackForwardList initWithBackForwardList:]): (-[WebBackForwardList init]): (-[WebBackForwardList dealloc]): (-[WebBackForwardList finalize]): (-[WebBackForwardList setPageCacheSize:]): (-[WebBackForwardList pageCacheSize]): * History/WebBackForwardListInternal.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::canCachePage): * WebView/WebFrameView.mm: (-[WebFrameView keyDown:keyDown:]): * WebView/WebView.mm: (-[WebView _loadBackForwardListFromOtherView:]): (-[WebView initWithCoder:]): (-[WebView encodeWithCoder:]): (-[WebView backForwardList]): (-[WebView setMaintainsBackForwardList:]): 2014-04-30 Simon Fraser Remove ENABLE_PLUGIN_PROXY_FOR_VIDEO https://bugs.webkit.org/show_bug.cgi?id=132396 Reviewed by Eric Carlson. Remove ENABLE_PLUGIN_PROXY_FOR_VIDEO and related code. * Configurations/FeatureDefines.xcconfig: * Plugins/WebPluginContainerPrivate.h: * Plugins/WebPluginController.h: * Plugins/WebPluginController.mm: (-[WebPluginController dealloc]): (-[WebPluginController plugInsAreRunning]): (-[WebPluginController stopAllPlugins]): (-[WebPluginController stopPluginsForPageCache]): (-[WebPluginController restorePluginsFromCache]): (-[WebPluginController addPlugin:]): (-[WebPluginController destroyPlugin:]): (-[WebPluginController destroyAllPlugins]): (-[NSView isMediaPlugInProxyView]): Deleted. (-[NSView setIsMediaPlugInProxyView:]): Deleted. (-[WebPluginController mediaPlugInProxyViewCreated:]): Deleted. (+[WebPluginController pluginViewHidden:]): Deleted. (mediaProxyClient): Deleted. (-[WebPluginController _webPluginContainerSetMediaPlayerProxy:forElement:]): Deleted. (-[WebPluginController _webPluginContainerPostMediaPlayerNotification:forElement:]): Deleted. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (pluginView): * WebView/WebView.mm: (-[WebView _preferencesChanged:]): (-[WebView _videoProxyPluginForMIMEType:]): Deleted. * WebView/WebViewInternal.h: 2014-04-30 Anders Carlsson Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework https://bugs.webkit.org/show_bug.cgi?id=132399 Reviewed by Dan Bernstein. * Carbon/CarbonUtils.h: * Carbon/HIViewAdapter.h: * Carbon/HIWebView.h: Import WebKitLegacy headers instead of WebKit headers. * Configurations/WebKit.xcconfig: Move the definitions needed for building WebKitLegacy.framework to WebKitLegacy.xcconfig and add the relevant definitions needed for re-exporting WebKitLegacy.framework. * Configurations/WebKitLegacy.xcconfig: Add definitions needed for building the "old" WebKit API as WebKitLegacy.framework. * DOM/WebDOMOperations.h: * DOM/WebDOMOperations.mm: * DOM/WebDOMOperationsInternal.h: * DOM/WebDOMOperationsPrivate.h: * DefaultDelegates/WebDefaultContextMenuDelegate.h: * DefaultDelegates/WebDefaultContextMenuDelegate.mm: * DefaultDelegates/WebDefaultEditingDelegate.m: * History/WebBackForwardListInternal.h: * History/WebBackForwardListPrivate.h: * History/WebHistoryItemPrivate.h: * History/WebHistoryPrivate.h: * History/WebURLsWithTitles.m: Import WebKitLegacy headers instead of WebKit headers. * MigrateHeaders.make: Update header paths now that all WebKitLegacy headers are private. Remove migration of WebKit2 headers, that is done by MigrateHeadersFromWebKitLegacy.make now. * Misc/WebCoreStatistics.h: * Misc/WebDownload.h: * Misc/WebDownload.mm: * Misc/WebDownloadInternal.h: * Misc/WebElementDictionary.mm: * Misc/WebIconDatabasePrivate.h: * Misc/WebKit.h: * Misc/WebKitErrors.m: * Misc/WebKitErrorsPrivate.h: * Misc/WebKitNSStringExtras.mm: * Misc/WebLocalizableStrings.mm: * Misc/WebNSDataExtras.m: * Misc/WebNSDictionaryExtras.m: * Misc/WebNSEventExtras.m: * Misc/WebNSFileManagerExtras.mm: * Misc/WebNSImageExtras.m: * Misc/WebNSPasteboardExtras.mm: * Misc/WebNSViewExtras.h: * Misc/WebNSViewExtras.m: * Panels/WebAuthenticationPanel.m: * Panels/WebPanelAuthenticationHandler.m: * Plugins/Hosted/HostedNetscapePluginStream.h: * Plugins/Hosted/NetscapePluginInstanceProxy.h: * Plugins/Hosted/WebKitPluginAgent.defs: * Plugins/Hosted/WebKitPluginAgentReply.defs: * Plugins/Hosted/WebKitPluginClient.defs: * Plugins/Hosted/WebKitPluginHost.defs: * Plugins/Hosted/WebKitPluginHostTypes.defs: * Plugins/WebBaseNetscapePluginView.mm: * Plugins/WebBasePluginPackage.h: * Plugins/WebBasePluginPackage.mm: * Plugins/WebNetscapeContainerCheckPrivate.h: * Plugins/WebNetscapePluginEventHandlerCocoa.h: * Plugins/WebNetscapePluginStream.h: * Plugins/WebNetscapePluginView.h: * Plugins/WebNetscapePluginView.mm: * Plugins/WebPlugin.h: * Plugins/WebPluginController.h: * Plugins/WebPluginDatabase.h: * Plugins/WebPluginPackage.h: * Plugins/WebPluginPackage.mm: * Plugins/WebPluginViewFactory.h: * Plugins/WebPluginViewFactoryPrivate.h: * Plugins/npapi.mm: * Storage/WebDatabaseManagerPrivate.h: * WebCoreSupport/WebContextMenuClient.mm: * WebCoreSupport/WebFrameLoaderClient.mm: * WebCoreSupport/WebFrameNetworkingContext.mm: * WebCoreSupport/WebGeolocationClient.mm: * WebCoreSupport/WebInspectorClient.mm: * WebCoreSupport/WebJavaScriptTextInputPanel.m: * WebCoreSupport/WebKeyGenerator.mm: * WebInspector/WebInspectorPrivate.h: * WebInspector/WebNodeHighlight.h: * WebInspector/WebNodeHighlightView.h: Import WebKitLegacy headers instead of WebKit headers. * WebKitLegacy/MigrateHeadersFromWebKitLegacy.make: Added. New makefile that handles copying WebKitLegacy headers to the WebKit framework, rewriting WebKitLegacy imports to WebKit imports. (On iOS the WebKit headers just forward to the relevant WebKitLegacy headers). On OS X, this also handles copying WebKit2 headers to the WebKit framework, rewriting WebKit2 imports to WebKit imports and getting rid of C SPI imports. * WebKitLegacy/MigrateHeadersToLegacy.make: Removed. This is no longer needed. * WebKitLegacy/WebKit.h: Added. New umbrella header that imports the modern API if available, as well as the legacy API (using WebKit/WebKitLegacy.h). * WebKitLegacy/WebKit.m: This is an empty file so we'll have something to link. * WebKitLegacy/WebKitPrivate.h: New SPI header that imports the private headers of the modern API. * WebView/WebDataSource.h: * WebView/WebDataSource.mm: * WebView/WebDataSourcePrivate.h: * WebView/WebDelegateImplementationCaching.h: * WebView/WebDocument.h: * WebView/WebDocumentInternal.h: * WebView/WebDocumentPrivate.h: * WebView/WebEditingDelegate.h: * WebView/WebEditingDelegatePrivate.h: * WebView/WebFrameLoadDelegate.h: * WebView/WebFrameLoadDelegatePrivate.h: * WebView/WebFramePrivate.h: * WebView/WebFrameView.h: * WebView/WebFrameViewInternal.h: * WebView/WebFrameViewPrivate.h: * WebView/WebHTMLRepresentation.h: * WebView/WebHTMLRepresentation.mm: * WebView/WebHTMLRepresentationPrivate.h: * WebView/WebHTMLView.h: * WebView/WebHTMLView.mm: * WebView/WebHTMLViewPrivate.h: * WebView/WebPDFView.h: * WebView/WebPolicyDelegatePrivate.h: * WebView/WebPreferencesPrivate.h: * WebView/WebResourcePrivate.h: * WebView/WebUIDelegate.h: * WebView/WebUIDelegatePrivate.h: * WebView/WebView.h: * WebView/WebView.mm: * WebView/WebViewPrivate.h: Import WebKitLegacy headers instead of WebKit headers. * migrate-headers.sh: Derived sources are put in DerivedSources/WebKitLegacy now. 2014-04-30 David Hyatt [New Multicolumn] Enable new multi-column mode https://bugs.webkit.org/show_bug.cgi?id=131825 Reviewed by Simon Fraser. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): 2014-04-30 Brian J. Burg Clean up unnecessary methods in the BackForwardClient interface https://bugs.webkit.org/show_bug.cgi?id=131637 Reviewed by Andreas Kling. BackForwardClient instances now have ownership lifetime semantics, so WebBackForwardList now explicitly deletes its inner BackForwardList. Convert uses of WebCore::BackForwardList through backForward().client() to accept references instead of pointers. Use BackForwardController methods rather than directly operating with the BackForwardClient where possible. Remove page cache-related methods that are not used anywhere and that call BackForwardClient::page(), which is removed by this change. * History/WebBackForwardList.mm: (-[WebBackForwardList initWithBackForwardList:]): (-[WebBackForwardList init]): (-[WebBackForwardList dealloc]): (-[WebBackForwardList finalize]): (-[WebBackForwardList setPageCacheSize]): Deleted. (-[WebBackForwardList pageCacheSize]): Deleted. (-[WebBackForwardList itemAtIndex:]): Deleted. * History/WebBackForwardListInternal.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::canCachePage): * WebView/WebFrameView.mm: (-[WebFrameView keyDown:keyDown:]): * WebView/WebView.mm: (-[WebView _loadBackForwardListFromOtherView:]): (-[WebView initWithCoder:]): (-[WebView encodeWithCoder:]): (-[WebView backForwardList]): (-[WebView setMaintainsBackForwardList:]): 2014-04-29 Sam Weinig [iOS] -[WebHTMLView selectionImageForcingBlackText:] returns blank image on iOS https://bugs.webkit.org/show_bug.cgi?id=132359 Reviewed by Darin Adler. * WebView/WebHTMLView.mm: (imageFromRect): (selectionImage): (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]): Bring back the old FrameSnapshottingMac code for drawing the selection image as drag code for this is still unimplemented on iOS. * WebView/WebView.mm: (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Set the page scale for "simple HTML documents" (this is already done for the all other documents), to ensure that the snapshot is the correct size. 2014-04-30 Manuel Rego Casasnovas [CSS Grid Layout] Enable runtime feature by default https://bugs.webkit.org/show_bug.cgi?id=132189 Reviewed by Benjamin Poulain. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Remove unneeded changes that enable/disable the runtime feature depending on the compilation flag. And set it to true by default. 2014-04-29 Filip Pizlo Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT) https://bugs.webkit.org/show_bug.cgi?id=112840 Rubber stamped by Geoffrey Garen. * Configurations/FeatureDefines.xcconfig: 2014-04-29 Brady Eidson Change Image Controls replacement to use selection and paste and https://bugs.webkit.org/show_bug.cgi?id=131992 Reviewed by Tim Horton. * Misc/WebSharingServicePickerController.mm: (-[WebSharingServicePickerController sharingService:didShareItems:]): Write the replacement data to a special pasteboard, then replace the current selection from that pasteboard. 2014-04-27 Sam Weinig [iOS WebKit2] Add support for text autosizing https://bugs.webkit.org/show_bug.cgi?id=132237 Reviewed by Tim Horton. * WebView/WebFrame.mm: (-[WebFrame _setTextAutosizingWidth:]): Forward setting of the text autosizing width to the Page. 2014-04-25 Dean Jackson Allow a platform-specific size enumeration to be passed into popup-menu display https://bugs.webkit.org/show_bug.cgi?id=132195 Reviewed by Brent Fulgham. With some in-person review comments from Sam Weinig. Platforms like OS X use a set of predefined sizes for built-in controls used for popover color well implementation and https://bugs.webkit.org/show_bug.cgi?id=119356 Reviewed by Benjamin Poulain. * Configurations/FeatureDefines.xcconfig: Added and enabled INPUT_TYPE_COLOR_POPOVER. 2013-07-31 Tim Horton Remove didFinishLoad order quirk https://bugs.webkit.org/show_bug.cgi?id=119354 Reviewed by Alexey Proskuryakov. * Misc/WebKitVersionChecks.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Don't set the now-removed preference. 2013-07-31 Kwang Yul Seo Use emptyString instead of String("") https://bugs.webkit.org/show_bug.cgi?id=119335 Reviewed by Darin Adler. Use emptyString() instead of String("") because it is better style and faster. This is a followup to r116908, removing all occurrences of String("") from WebKit. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::userAgent): 2013-07-31 Ruth Fong Mac UI behaviour and https://bugs.webkit.org/show_bug.cgi?id=61276 Reviewed by Brady Eidson. * Configurations/FeatureDefines.xcconfig: Enabled INPUT_TYPE_COLOR. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createColorPicker): Added stub implementation. 2013-07-26 Dean Jackson Allow new transitions to run even when controller is suspended https://bugs.webkit.org/show_bug.cgi?id=119171 Reviewed by Simon Fraser. Expose a new SPI on WebView that triggers the (buggy) old behaviour for animations, such that any newly created animations will start even when the document is supposedly suspended. It turns out that client content was unknowingly relying on this behaviour - e.g. suspending a view, loading a bunch of new content, bringing the view on screen and then unsuspending. In this situation, we were not running CSS transitions, because the page was suspended. However, JS was still triggering them, and content was expecting a transitionEnd event. * WebView/WebView.mm: (-[WebView allowsNewCSSAnimationsWhileSuspended]): Calls into AnimationController. (-[WebView setAllowsNewCSSAnimationsWhileSuspended:]): Ditto. * WebView/WebViewPrivate.h: New methods listed above. 2013-07-26 Anders Carlsson Add another method that we need to set aside subviews for https://bugs.webkit.org/show_bug.cgi?id=119157 Reviewed by Beth Dakin. * WebView/WebHTMLView.mm: (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): 2013-07-25 Andreas Kling ChromeClient::focusedNodeChanged() should be focusedElementChanged(). Reviewed by Anders Carlsson. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::focusedElementChanged): 2013-05-05 Geoffrey Garen Rolled back in r149527 with crash fixed. Reviewed by Oliver Hunt. Rationalized 'this' value conversion https://bugs.webkit.org/show_bug.cgi?id=115542 2013-07-17 Commit Queue Unreviewed, rolling out r152701, r152703, r152739, r152754, and r152756. http://trac.webkit.org/changeset/152701 http://trac.webkit.org/changeset/152703 http://trac.webkit.org/changeset/152739 http://trac.webkit.org/changeset/152754 http://trac.webkit.org/changeset/152756 https://bugs.webkit.org/show_bug.cgi?id=118821 this was a buggy fix and we're going to try something different (Requested by thorton on #webkit). * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldUnavailablePluginMessageBeButton): 2013-07-17 Kangil Han Use toHTMLMediaElement https://bugs.webkit.org/show_bug.cgi?id=118727 Reviewed by Ryosuke Niwa. To avoid direct use of static_cast, this patch uses toHTMLMediaElement for code cleanup. * WebView/WebView.mm: (-[WebView _enterFullscreenForNode:WebCore::]): 2013-07-16 Simon Fraser Protect against the LayerFlushController being deleted inside its flushLayers() callback https://bugs.webkit.org/show_bug.cgi?id=118741 Reviewed by Tim Horton. It's possible (especially on iOS) for the LayerFlushController to be destroyed inside its callback, via -[WebView _close]. Protect against this by making it refcounted, and holding a ref across the callback. Due to the odd relationship in which LayerFlushController owns its LayerFlushScheduler by value, we achieve this by allowing subclasses of LayerFlushScheduler to override runLoopObserverCallback(). WebViewLayerFlushScheduler uses the override to protect the owner of the LayerFlushScheduler, which is the LayerFlushController, when the callback is firing. * WebView/WebView.mm: (-[WebView _close]): * WebView/WebViewData.h: (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): (LayerFlushController::create): * WebView/WebViewData.mm: (LayerFlushController::invalidate): (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler): 2013-07-16 Jessie Berlin Fix some NSDictionary misuse pointed out by the clang static analyzer https://bugs.webkit.org/show_bug.cgi?id=118736 Reviewed by Anders Carlsson. * Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost): Explicitly cast the CFStringRef to an NSString *. * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::documentFragmentFromAttributedString): Do not put a key with a nil value pair into the NSDictionary. 2013-07-15 Tim Horton Update blocked/missing plug-in UI https://bugs.webkit.org/show_bug.cgi?id=118347 Reviewed by Sam Weinig. Patch by Antoine Quint, Anders Carlsson, Sam Weinig, and myself. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldUnavailablePluginMessageIncludeButton): Rename from shouldUnavailablePluginMessageBeButton to shouldUnavailablePluginMessageIncludeButton for accuracy. 2013-07-14 Jon Lee [WK2] Calling Notification.requestPermission() without a callback crashes https://bugs.webkit.org/show_bug.cgi?id=118654 Reviewed by Alexey Proskuryakov. * WebCoreSupport/WebNotificationClient.mm: (-[WebNotificationPolicyListener initWithCallback:]): The callback can be NULL, so remove the ASSERT. (-[WebNotificationPolicyListener allow]): Check for the callback before asking it to handle the event. (-[WebNotificationPolicyListener deny]): Ditto. 2013-07-12 Jessie Berlin Remove some dead stores pointed out by the clang static analyzer. https://bugs.webkit.org/show_bug.cgi?id=118608 Reviewed by Anders Carlsson. * Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): kr is never read after this point, so there is no reason to assign to it. * Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage getPluginInfoFromPLists]): The extensions array is only used in the while loop. Move the declaration to the first place it is used in the while loop. Since it is always reassigned at that location, and since it is never read after the subsequent for loop, the assignment to an array containing the empty string is never used. Remove it. Similarly, the value of the description is always overwritten before used to assign to mimeClassInfo.desc or to pluginInfo.desc, so the code to assign it to the empty string is never used. Remove it. * WebView/WebTextCompletionController.mm: (-[WebTextCompletionController _placePopupWindow:]): maxWidth is never read (and never was since it was added in r7311) after it is used on the line above to set windowFrame.size.width. 2013-07-11 Dan Bernstein [mac] No API for getting the page visibility state of a WebView https://bugs.webkit.org/show_bug.cgi?id=118578 Reviewed by Simon Fraser. * WebView/WebView.mm: (kit): Added. Converts from WebCore::PageVisibilityState to WebPageVisibilityState. (-[WebView _visibilityState]): Added. * WebView/WebViewPrivate.h: Declared -_visibilityState. 2013-07-11 Timothy Hatcher Revert r152267 and soft link WebInspectorUI.framework again. https://bugs.webkit.org/show_bug.cgi?id=118544 Reviewed by David Kilzer. * Configurations/WebKit.xcconfig: * WebCoreSupport/WebInspectorClient.mm: (useWebKitWebInspector): 2013-07-10 Jessie Berlin Remove some dead code from WebNSURLExtras _web_hostString https://bugs.webkit.org/show_bug.cgi?id=118519 Reviewed by Anders Carlsson. * Misc/WebNSURLExtras.mm: (-[NSURL _web_hostString]): NSString initWithData:encoding: does not throw an exception when passing nil for the data, so just delete the code that wasn't being run. 2013-07-09 Jeremy Noble Reviewed by Simon Fraser. Remember the scroll position and restore after exiting full-screen mode. https://bugs.webkit.org/show_bug.cgi?id=61956 Call into the main FrameView to save the scroll position before swapping the WebView into the full-screen window, and restore the scroll position after swapping the WebView back into the browser window. * WebView/WebFullScreenController.h: * WebView/WebFullScreenController.mm: (-[WebFullScreenController windowDidEnterFullscreen:]): Save the scroll position. (-[WebFullScreenController exitFullscreen]): Restore the scroll position. 2013-07-04 Yongjun Zhang Add a method to get unreachable URL from WebFrame. https://bugs.webkit.org/show_bug.cgi?id=118399 Normally we could use [[WebFrame dataSource] unreachableURL] to get the failed URL. However, if the frame has not loaded (FrameLoader::frameHasLoaded() is false), we will get a nil dataSource and we won't be able to get unreachableURL. We can add a method to always return the unreachableURL regardless if the frame has loaded or not. Reviewed by Dan Bernstein. * WebView/WebFrame.mm: (-[WebFrame _unreachableURL]): * WebView/WebFramePrivate.h: 2013-07-03 Zalan Bujtas H&R Block 2010 Help window can not be reopened. https://bugs.webkit.org/show_bug.cgi?id=118342 Reviewed by Antti Koivisto. http://trac.webkit.org/changeset/118916 changed the window.focus() behaviour so that only the opener can (re)focus() a particular window. H&R Block app relies on the relaxed window.focus() rules. * WebView/WebView.mm: (shouldRestrictWindowFocus): (-[WebView _preferencesChanged:]): 2013-07-01 Timothy Hatcher Link to WebInspectorUI.framework at build time instead of soft linking. https://bugs.webkit.org/show_bug.cgi?id=118261 Reviewed by Joseph Pecoraro. * Configurations/WebKit.xcconfig: * WebCoreSupport/WebInspectorClient.mm: (useWebKitWebInspector): 2013-07-01 Jochen Eisinger Remove support for consumable user gestures https://bugs.webkit.org/show_bug.cgi?id=118247 Reviewed by Geoffrey Garen. * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate): * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]): 2013-06-27 Jer Noble Audio in apps which embed WebViews is corrupted. https://bugs.webkit.org/show_bug.cgi?id=118163 Reviewed by Maciej Stachowiak. Expose the WebCore lowPowerVideoAudioBufferSizeEnabled setting to WebKit clients. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences lowPowerVideoAudioBufferSizeEnabled]): (-[WebPreferences setLowPowerVideoAudioBufferSizeEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2013-07-01 Kangil Han Adopt toHTMLTextAreaElement for code cleanup https://bugs.webkit.org/show_bug.cgi?id=118226 Reviewed by Andreas Kling. To enhance readability, this patch adopts toHTMLTextAreaElement. This also helps out to reduce duplicated use of static_cast. * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::textDidChangeInTextArea): 2013-06-27 Kangil Han Adopt is/toHTMLInputElement for code cleanup https://bugs.webkit.org/show_bug.cgi?id=118130 Reviewed by Antti Koivisto. To enhance readability, this patch adopts is/toHTMLInputElement. This also helps out to reduce duplicated use of static_cast. * DOM/WebDOMOperations.mm: (-[DOMHTMLInputElement _setAutofilled:]): * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::focusedNodeChanged): * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::textFieldDidBeginEditing): (WebEditorClient::textFieldDidEndEditing): (WebEditorClient::textDidChangeInTextField): (WebEditorClient::doTextFieldCommandFromEvent): (WebEditorClient::textWillBeDeletedInTextField): * WebView/WebHTMLRepresentation.mm: (inputElementFromDOMElement): 2013-06-26 Kangil Han Adopt is/toHTMLAudioElement for code cleanup https://bugs.webkit.org/show_bug.cgi?id=117985 Reviewed by Jer Noble. To enhance readibility, this patch adopts is/toHTMLAudioElement. This also helps out to reduce duplicated use of static_cast. * Plugins/WebPluginController.mm: 2013-06-24 Simon Fraser Move displayID stuff from Widget to Chrome https://bugs.webkit.org/show_bug.cgi?id=117944 Reviewed by Anders Carlsson. In r151877 I polluted Widget with displayID-related stuff. This would be better on HostWindow, so move it there. This is a net code reduction, and eliminates PlatformScreenMac.h, and the NSScreen category. * WebView/WebView.mm: (-[WebView doWindowDidChangeScreen]): Go via chrome(). 2013-06-21 Christophe Dumez REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere https://bugs.webkit.org/show_bug.cgi?id=117825 Reviewed by Kentaro Hara. Use Settings to enable Web Audio instead of RuntimeEnabledFeatures. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2013-06-20 Simon Fraser FrameView needs to initialize paintsEntireContents on creation https://bugs.webkit.org/show_bug.cgi?id=117844 Reviewed by Anders Carlsson. In WebKit1, if the WebView is layer-backed, WebHTMLView gets a layer. In this mode, FrameView::paintsEntireContents() is true. However, we would only call setPaintsEntireContents(true) on the FrameView when the view's layer-backed status changes. FrameView also needs to fetch this state when it is initialized, because we may be creating a new FrameView for an already layer-backed WebHTMLView. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldPaintEntireContents): 2013-06-19 Benjamin Poulain Use the PlatformEvent timestamp when creating a DOM Event https://bugs.webkit.org/show_bug.cgi?id=117179 Reviewed by Darin Adler. * WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): 2013-06-18 Roger Fong Unreviewed. Build fix for Mac. * WebCoreSupport/WebFrameNetworkingContext.h: (WebFrameNetworkingContext::create): (WebFrameNetworkingContext::WebFrameNetworkingContext): 2013-06-18 Roger Fong Re-implement WebFrameNetworkingContext. . Reviewed by Alexey Proskuryakov. * WebCoreSupport/WebFrameNetworkingContext.h: Added. (WebFrameNetworkingContext::create): (WebFrameNetworkingContext::WebFrameNetworkingContext): (WebFrameNetworkingContext::userAgent): * WebCoreSupport/WebFrameNetworkingContext.mm: Added. (WebFrameNetworkingContext::ensurePrivateBrowsingSession): (WebFrameNetworkingContext::destroyPrivateBrowsingSession): (WebFrameNetworkingContext::needsSiteSpecificQuirks): (WebFrameNetworkingContext::localFileContentSniffingEnabled): (WebFrameNetworkingContext::scheduledRunLoopPairs): (WebFrameNetworkingContext::sourceApplicationAuditData): (WebFrameNetworkingContext::blockedError): (WebFrameNetworkingContext::storageSession): 2013-06-18 Alexey Proskuryakov Remove files with an incorrect license. Rubber-stamped by Maciej Stachowiak. This will break the build, stay tuned for a fix coming soon. * WebCoreSupport/WebFrameNetworkingContext.h: Removed. * WebCoreSupport/WebFrameNetworkingContext.mm: Removed. 2013-06-17 Michael Brüning [Qt] Remove Qt specific QTKIT flagged code. https://bugs.webkit.org/show_bug.cgi?id=117635 Reviewed by Simon Hausmann. Due to disabling QTKIT for Qt in r151546, the code the flags that are not taken into account anymore and the code that has been rendered unreachable by this are removed. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2013-06-17 Grzegorz Czajkowski Unreviewed, rolling out r151632. http://trac.webkit.org/changeset/151632 https://bugs.webkit.org/show_bug.cgi?id=117585 Debug build error ASSERT(WTF_USE_GRAMMAR_CHECKING) for non MAC platforms * WebCoreSupport/WebContextMenuClient.mm: (fixMenusReceivedFromOldClients): 2013-06-14 Grzegorz Czajkowski Context menu grammar checking items are available when GRAMMAR_CHECKING macro is off https://bugs.webkit.org/show_bug.cgi?id=117585 Reviewed by Anders Carlsson. Add GRAMMAR_CHECKING guard to the context menu grammar items. * WebCoreSupport/WebContextMenuClient.mm: (fixMenusReceivedFromOldClients): 2013-06-13 Jer Noble Add support for AVFoundation-backed HTMLMediaElements in the WebVideoFullScreenController. https://bugs.webkit.org/show_bug.cgi?id=117597 Reviewed by Eric Carlson. Allow AVFoundation to be enabled even when the FullScreen API is disabled. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2013-06-12 Anders Carlsson Remove the notion of inactive plug-ins https://bugs.webkit.org/show_bug.cgi?id=117570 Reviewed by Tim Horton. Remove code that deals with inactive plug-ins. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldUnavailablePluginMessageBeButton): (WebChromeClient::unavailablePluginButtonClicked): * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): 2013-06-12 Zan Dobersek Remove memoryInfoEnabled, quantizedMemoryInfoEnabled settings https://bugs.webkit.org/show_bug.cgi?id=117512 Reviewed by Darin Adler. * WebKit.order: Remove the memoryInfoEnabled entry. * WebView/WebPreferenceKeysPrivate.h: Remove WebKitMemoryInfoEnabledPreferenceKey. * WebView/WebPreferences.mm: Remove memoryInfoEnabled, setMemoryInfoEnabled methods. (+[WebPreferences initialize]): Don't set the default value for the WebKitMemoryInfoEnabledPreferenceKey, the preference is being removed. * WebView/WebPreferencesPrivate.h: Remove memoryInfoEnabled, setMemoryInfoEnabled method declarations. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Remove the call to Settings::setMemoryInfoEnabled, the setting is being removed. 2013-06-06 Timothy Hatcher Update the framework bundle identifier for the Web Inspector. Reviewed by Mark Rowe. * WebCoreSupport/WebInspectorClient.mm: (useWebKitWebInspector): (WebInspectorFrontendClient::localizedStringsURL): (-[WebInspectorWindowController inspectorPagePath]): 2013-06-05 Bear Travis [CSS Exclusions][CSS Shapes] Split CSS Exclusions & Shapes compile & runtime flags https://bugs.webkit.org/show_bug.cgi?id=117172 Reviewed by Alexandru Chiculita. Adding the CSS_SHAPES compile flag. * Configurations/FeatureDefines.xcconfig: 2013-06-01 Andreas Kling Remove unnused WebDOMNodeOperationsInternal category. Reviewed by Ryosuke Niwa. _subresourceURLs had no clients. * DOM/WebDOMOperations.mm: 2013-06-01 Andreas Kling Move Node::hasID() and hasClass() to Element. Reviewed by Ryosuke Niwa. * WebView/WebRenderLayer.mm: (+[WebRenderLayer nameForLayer:]): 2013-05-31 Stephanie Lewis Update low memory handler to use new memory pressure notifications on new OS versions. Reviewed by Mark Rowe. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2013-05-29 Jeffrey Pfau [Mac] Enable cache partitioning and the public suffix list on 10.8 Rubber-stamped by David Kilzer. * Configurations/FeatureDefines.xcconfig: 2013-05-29 Joseph Pecoraro Web Inspector: get rid of obsolete InspectorFrontendHost.hiddenPanels() https://bugs.webkit.org/show_bug.cgi?id=60152 Reviewed by Andreas Kling. * WebCoreSupport/WebInspectorClient.mm: 2013-05-28 Joseph Pecoraro Drag to move DOM nodes does not work https://bugs.webkit.org/show_bug.cgi?id=116865 Do not block drag events on the WebKit 1 Web Inspector WebView. Reviewed by Timothy Hatcher. * WebCoreSupport/WebInspectorClient.mm: 2013-05-28 Andreas Kling Document::setFocusedNode() should be setFocusedElement(). Reviewed by Antti Koivisto. * WebView/WebHTMLView.mm: (-[WebHTMLView clearFocus]): (-[WebHTMLView becomeFirstResponder]): 2013-05-25 Andreas Kling Remove Document::getFocusableNodes(). Reviewed by Joseph Pecoraro. Remove the private _focusableNodes API on DOMDocument, it has no clients. * DOM/WebDOMOperations.mm: * DOM/WebDOMOperationsPrivate.h: 2013-05-25 Simon Fraser Unprefix Page Visibility API https://bugs.webkit.org/show_bug.cgi?id=102340 Reviewed by Tim Horton. Renaming of the "preview" state to "unloaded". * WebView/WebView.mm: * WebView/WebViewPrivate.h: 2013-05-25 Dan Bernstein -webView:didPerformClientRedirectFromURL:toURL:inFrame: should be given the redirecting URL as the “from” URL https://bugs.webkit.org/show_bug.cgi?id=116733 Reviewed by Adele Peterson. By the time the history controller calls updateGlobalHistoryRedirectLinks(), the document loader already reflects the destination URL. In order to be able to provide the immediate source URL to the delegate, we make WebFrame track a URL and provisional URL, updating them in response to FrameLoader callbacks in exactly the same way WebFrameProxy maintains its m_url and m_provisionalURL member variables. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): Update provisionalURL. (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): Update url. (WebFrameLoaderClient::dispatchDidPushStateWithinPage): Ditto. (WebFrameLoaderClient::dispatchDidReplaceStateWithinPage): Ditto. (WebFrameLoaderClient::dispatchDidPopStateWithinPage): Ditto. (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): Update provisionalURL. (WebFrameLoaderClient::dispatchDidCommitLoad): Update URL and provisionalURL. (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): Clear provisionalURL. (WebFrameLoaderClient::dispatchDidFailLoad): Added an assertion. (WebFrameLoaderClient::dispatchDidFinishLoad): Ditto. (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Pass the last committed URL as the source, rather than clientRedirectSourceForHistory(). * WebView/WebFrameInternal.h: Added url and provisionalURL ivars to WebFramePrivate. 2013-05-24 Anders Carlsson Remove using namespace std from Mac WebKit1 https://bugs.webkit.org/show_bug.cgi?id=116747 Reviewed by Sam Weinig. Use explicit std:: qualifiers instead. * History/BinaryPropertyList.cpp: (IntegerArray::deletedValueSize): (BinaryPropertyListPlan::invalidObjectReference): (bytesNeeded): * History/WebHistory.mm: (-[WebHistoryPrivate orderedLastVisitedDays]): (WebHistoryWriter::WebHistoryWriter): * History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): * Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): * Plugins/Hosted/NetscapePluginHostProxy.mm: * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): (WebKit::NetscapePluginInstanceProxy::wheelEvent): (WebKit::NetscapePluginInstanceProxy::print): (WebKit::NetscapePluginInstanceProxy::snapshot): (WebKit::NetscapePluginInstanceProxy::loadURL): (WebKit::NetscapePluginInstanceProxy::createBindingsInstance): * Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): (WebKit::ProxyInstance::supportsInvokeDefaultMethod): (WebKit::ProxyInstance::supportsConstruct): (WebKit::ProxyInstance::getPropertyNames): (WebKit::ProxyInstance::methodNamed): (WebKit::ProxyInstance::fieldNamed): (WebKit::ProxyInstance::fieldValue): (WebKit::ProxyInstance::setFieldValue): * Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage MIMETypeForExtension:]): * Plugins/WebNetscapePluginStream.mm: (WebNetscapePluginStream::deliverData): * Plugins/WebNetscapePluginView.mm: (PluginTimer::start): (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]): * WebCoreSupport/WebFrameLoaderClient.mm: * WebView/WebFrame.mm: * WebView/WebHTMLView.mm: (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]): * WebView/WebTextCompletionController.mm: (-[WebTextCompletionController _placePopupWindow:]): 2013-05-24 Anders Carlsson Move history property list writer to WebKit https://bugs.webkit.org/show_bug.cgi?id=116746 Reviewed by Tim Horton. Move WebCore history files to WebKit since they're only used by WebKit now. * History/BinaryPropertyList.cpp: Renamed from Source/WebCore/platform/cf/BinaryPropertyList.cpp. * History/BinaryPropertyList.h: Renamed from Source/WebCore/platform/cf/BinaryPropertyList.h. * History/HistoryPropertyList.cpp: Renamed from Source/WebCore/history/cf/HistoryPropertyList.cpp. * History/HistoryPropertyList.h: Renamed from Source/WebCore/history/cf/HistoryPropertyList.h. * History/WebHistory.mm: 2013-05-24 Christophe Dumez Remove custom code for webkitAudioContext global constructor getter https://bugs.webkit.org/show_bug.cgi?id=116530 Reviewed by Geoffrey Garen. Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2013-05-23 Anders Carlsson Crash in convertMainResourceLoadToDownload when downloading file by option-return https://bugs.webkit.org/show_bug.cgi?id=116451 Reviewed by Andreas Kling. If the main resource loader is null, create a new download instead since there's no existing loader to convert. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::convertMainResourceLoadToDownload): 2013-05-22 Simon Fraser Fix issues with focus rings on search fields https://bugs.webkit.org/show_bug.cgi?id=116591 Reviewed by Darin Adler. In WebKit1, focus rings didn't render correctly on some OSes until some other control drew a focus ring, which changes internal AppKit state on the focused view. Fix by overriding an internal AppKit method to always disable AppKit's "automatic" focus ring drawing. * WebView/WebHTMLView.mm: (-[WebHTMLView _automaticFocusRingDisabled]): 2013-05-20 David Kilzer Synchronize FeatureDefines.xcconfig * Configurations/FeatureDefines.xcconfig: Add a newline to the end of the file. 2013-05-19 Anders Carlsson Remove link prerendering code https://bugs.webkit.org/show_bug.cgi?id=116415 Reviewed by Darin Adler. This code was only used by Chromium and is dead now. * Configurations/FeatureDefines.xcconfig: 2013-05-19 Anders Carlsson Remove ChromeClient::webView() https://bugs.webkit.org/show_bug.cgi?id=116054 Reviewed by Darin Adler. This blatantly horrible layer violation was only used to know if a ChromeClient is an empty client or not. We already have a (slightly less horrible) way to do that. * WebCoreSupport/WebChromeClient.h: (WebChromeClient): 2013-05-17 Anders Carlsson Accessing null function pointers is bad. * WebCoreSupport/WebFrameLoaderClient.mm: 2013-05-17 Anders Carlsson Make kit(Frame*) more robust https://bugs.webkit.org/show_bug.cgi?id=116324 Reviewed by Darin Adler. Check that the frame loader's client isn't the EmptyFrameLoaderClient (or a subclass thereof) before casting to WebFrameLoaderClient. * WebView/WebFrame.mm: (kit): 2013-05-17 Anders Carlsson Move the policy function to WebFramePolicyListener https://bugs.webkit.org/show_bug.cgi?id=116323 Reviewed by Darin Adler. There's no need for the WebFrameLoaaderClient to hold on to the policy function, so move it to WebFramePolicyListener. This gets rid of another WebFrameLoaderClient cast. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setUpPolicyListener): Pass the policy function when creating the WebFramePolicyListener object. 2013-05-17 Anders Carlsson WebFramePolicyListener should keep its Frame in a RefPtr https://bugs.webkit.org/show_bug.cgi?id=116322 Reviewed by Darin Adler. * WebCoreSupport/WebFrameLoaderClient.mm: (-[WebFramePolicyListener initWithWebCoreFrame:]): No need to ref the frame, the RefPtr does that for us. (-[WebFramePolicyListener invalidate]): Just set the frame to null. (-[WebFramePolicyListener dealloc]): Remove call to deref, that's done automatically now. (-[WebFramePolicyListener finalize]): Remove this method. (We could have kept it just for the assertion but I didn't think that was necessary). (-[WebFramePolicyListener receivedPolicyDecision:): Use release() to transfer ownership. 2013-05-17 Anders Carlsson Reduce number of WebFrameLoaderClient static casts in WebKit https://bugs.webkit.org/show_bug.cgi?id=116320 Reviewed by Antti Koivisto. We already have a function to return a WebFrame from a WebCore::Frame, use it. * DOM/WebDOMOperations.mm: (WebFrameFilter::shouldIncludeSubframe): * WebView/WebDataSource.mm: (-[WebDataSource webFrame]): 2013-05-16 Commit Queue Unreviewed, rolling out r150034. http://trac.webkit.org/changeset/150034 https://bugs.webkit.org/show_bug.cgi?id=116257 This work around doesn't work due to another bug NSUndoManager has (Requested by rniwa on #webkit). * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::registerUndoOrRedoStep): 2013-05-16 Tim Horton PDFPlugins don't load when plugins are disabled, but they should https://bugs.webkit.org/show_bug.cgi?id=75790 Reviewed by Anders Carlsson. * Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage getPluginInfoFromPLists]): * Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]): Nothing loaded via WebBasePluginPackage or WebNetscapePluginPackage is an application plugin. * WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): Previously, this caller depended on pluginData() returning null if plug-ins were disabled. Since that is no longer the case, we have to check if we can use plug-ins, and otherwise ignore non-application-plug-ins. 2013-05-16 Andreas Kling Page::chrome() should return a reference. Reviewed by Anders Carlsson. 2013-05-16 Dan Bernstein -webView:updateHistoryTitle:forURL: does not pass a frame to the delegate https://bugs.webkit.org/show_bug.cgi?id=116243 Reviewed by Anders Carlsson. Added a WebFrame parameter to the delegate method. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setTitle): Pass the frame to the delegate. Maintain compatibility with clients that implement the old delegate method that doesn’t take a frame. * WebView/WebDelegateImplementationCaching.h: (WebHistoryDelegateImplementationCache): Added a field to cache the implementation of the old delegate method. * WebView/WebHistoryDelegate.h: Changed the signature of the delegate method. * WebView/WebView.mm: (-[WebView _cacheHistoryDelegateImplementations]): Cache the implementation of the new delegate method, but also check for the old one. 2013-05-16 Simon Fraser Re-land r150168 with some OS version guards. * WebView/WebFrameView.mm: (-[WebFrameView drawRect:]): (-[WebFrameView wantsUpdateLayer]): (-[WebFrameView updateLayer]): 2013-05-16 Commit Queue Unreviewed, rolling out r150168. http://trac.webkit.org/changeset/150168 https://bugs.webkit.org/show_bug.cgi?id=116214 broke the world on Mountain Lion (Requested by thorton on #webkit). * WebView/WebFrameView.mm: (-[WebFrameView drawRect:]): 2013-05-15 Simon Fraser Avoid backing store for the WebFrameView's layer when the WebView is layer-backed https://bugs.webkit.org/show_bug.cgi?id=116172 Reviewed by Tim Horton. When the WebView is layer-backed, AppKit will create a layer with backing store for the WebFrameView because it implements drawRect:. However, this method only paints when there is no documentView, so this layer’s backing store is wasteful. We can avoid allocation of this backing store by implementing -wantsUpdateLayer and -updateLayer, and setting the view’s backgroundColor. * WebView/WebFrameView.mm: (-[WebFrameView wantsUpdateLayer]): (-[WebFrameView updateLayer]): 2013-05-13 Anders Carlsson Frame::editor() should return a reference https://bugs.webkit.org/show_bug.cgi?id=116037 Reviewed by Darin Adler. * WebView/WebFrame.mm: (-[WebFrame _selectedString]): (-[WebFrame _firstRectForDOMRange:]): (-[WebFrame _markDOMRange]): (-[WebFrame _insertParagraphSeparatorInQuotedContent]): (-[WebFrame _setTypingStyle:withUndoAction:]): (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): * WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): * WebView/WebHTMLView.mm: (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): (-[WebHTMLView _shouldDeleteRange:]): (-[WebHTMLView _canEdit]): (-[WebHTMLView _canEditRichly]): (-[WebHTMLView _insertOrderedList]): (-[WebHTMLView _insertUnorderedList]): (-[WebHTMLView _canIncreaseSelectionListLevel]): (-[WebHTMLView _canDecreaseSelectionListLevel]): (-[WebHTMLView _increaseSelectionListLevel]): (-[WebHTMLView _increaseSelectionListLevelOrdered]): (-[WebHTMLView _increaseSelectionListLevelUnordered]): (-[WebHTMLView _decreaseSelectionListLevel]): (-[WebHTMLView Editor::coreCommandBySelector:]): (-[WebHTMLView Editor::coreCommandByName:]): (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView becomeFirstResponder]): (-[WebHTMLView _selectionStartFontAttributesAsRTF]): (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]): (-[WebHTMLView checkSpelling:]): (-[WebHTMLView showGuessPanel:]): (-[WebHTMLView toggleBaseWritingDirection:]): (-[WebHTMLView changeBaseWritingDirection:]): (-[WebHTMLView _changeBaseWritingDirectionTo:]): (-[WebHTMLView _updateFontPanel]): (-[WebHTMLView markedRange]): (-[WebHTMLView hasMarkedText]): (-[WebHTMLView unmarkText]): (-[WebHTMLView setMarkedText:selectedRange:]): (-[WebHTMLView doCommandBySelector:]): (-[WebHTMLView insertText:]): (-[WebHTMLView _updateSelectionForInputManager]): (-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]): (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): (-[WebHTMLView markedTextMatchesAreHighlighted]): (-[WebHTMLView _findString:options:]): * WebView/WebView.mm: (-[WebView _executeCoreCommandByName:value:]): (-[WebView editableDOMRangeForPoint:]): (-[WebView setEditable:]): (-[WebView deleteSelection]): (-[WebView applyStyle:]): (-[WebView typingAttributes]): (-[WebView _simplifyMarkup:endNode:]): (-[WebView handleAcceptedAlternativeText:]): 2013-05-15 Darin Adler [Mac] Remove the ClipboardMac class and header file https://bugs.webkit.org/show_bug.cgi?id=116165 Reviewed by Anders Carlsson. * WebCoreSupport/WebDragClient.mm: Import Clipboard.h instead of ClipboardMac.h. 2013-05-15 Darin Adler [Mac] Thin out the ClipboardMac class and header file to prepare for deleting them https://bugs.webkit.org/show_bug.cgi?id=116159 Reviewed by Andreas Kling. * WebCoreSupport/WebDragClient.mm: (WebDragClient::willPerformDragSourceAction): Changed to get the pasteboard name without going through the ClipboardMac class. (WebDragClient::startDrag): Ditto. 2013-05-14 Beth Dakin Printing in 1Password app is broken with screen fonts disabled https://bugs.webkit.org/show_bug.cgi?id=116133 -and corresponding- Reviewed by Anders Carlsson. Return YES from [WebPreferences screenFontSubstitutionEnabled] for versions of the 1Password app that were linked on or before MountainLion. * WebView/WebPreferences.mm: (needsScreenFontsEnabledQuirk): (-[WebPreferences screenFontSubstitutionEnabled]): 2013-05-13 Dan Bernstein Make -[WebNavigationData url] the destination of the navigation https://bugs.webkit.org/show_bug.cgi?id=114904 Reviewed by Dave Kilzer. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Initialize the WebNavigationData with the current URL, not the original request URL. 2013-05-13 Anders Carlsson Remove ChromeClient::willPopupMenu https://bugs.webkit.org/show_bug.cgi?id=116063 Reviewed by Andreas Kling. ChromeClient::willPopupMenu is only called in one place from WebKit, so just move the function to the call site. * WebCoreSupport/PopupMenuMac.mm: (PopupMenuMac::show): * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: 2013-05-12 Timothy Hatcher Add support for updating the Web Inspector toolbar height. https://bugs.webkit.org/show_bug.cgi?id=115996 Reviewed by Joseph Pecoraro and Benjamin Poulain. * WebCoreSupport/WebInspectorClient.h: * WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::setToolbarHeight): 2013-05-13 Ryosuke Niwa Sometimes NSUndoManager can get into an inconsistent state https://bugs.webkit.org/show_bug.cgi?id=116050 Reviewed by Enrica Casucci. Always group undo items to work around a bug in NSUndoManager that manifests when we call removeAllActionsWithTarget. * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::registerUndoOrRedoStep): 2013-05-13 Zalan Bujtas WebProcess consuming very high CPU on linkedin.com https://bugs.webkit.org/show_bug.cgi?id=115601 Reviewed by Andreas Kling. Disable WEB_TIMING_MINIMAL. Turn off window.performance and performance.now(). Some JS frameworks expect additional Web Timing APIs, when performance.now() is available. * Configurations/FeatureDefines.xcconfig: 2013-05-13 Darin Adler [Mac] Layer-backed WebViews draw their background color even when setDrawsBackground:NO was called https://bugs.webkit.org/show_bug.cgi?id=116014 Reviewed by Dan Bernstein. * WebView/WebFrame.mm: (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): Remove calls to setBackgroundColor: and setDrawsBackground: on the document view. These were added to support a hypothetical document view that wanted to draw its background like WebHTMLView does, but this was never communicated as a document view protocol, formal or informal, and it's unlikely that it was ever used. The bug was caused because there is an -[NSView setDrawsBackground:] method, probably an internal one, and we were calling it unintentionally on a WebHTMLView. 2013-05-12 Anders Carlsson Stop including UnusedParam.h https://bugs.webkit.org/show_bug.cgi?id=116003 Reviewed by Sam Weinig. UnusedParam.h is empty now so there's no need to include it anymore. * Plugins/WebNetscapePluginEventHandlerCocoa.mm: * WebView/WebDashboardRegion.mm: * WebView/WebFullScreenController.mm: 2013-05-12 Andreas Kling Unload event listeners should prevent Safari from insta-killing the web process on last tab close. Reviewed by Anders Carlsson. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::enableSuddenTermination): (WebChromeClient::disableSuddenTermination): 2013-05-10 Brian J. Burg Web Inspector: Implement WK2 version of WebInspectorFrontendClient::save https://bugs.webkit.org/show_bug.cgi?id=115564 Reviewed by Benjamin Poulain. Clean up save() and append() implementations. * WebCoreSupport/WebInspectorClient.h: * WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::save): (WebInspectorFrontendClient::append): 2013-05-10 Laszlo Gombos Remove Mac OS X Leopard (10.5) support https://bugs.webkit.org/show_bug.cgi?id=107964 Reviewed by Ryosuke Niwa. Removed the code for 10.5 and removed if-def for 10.6. * DefaultDelegates/WebDefaultContextMenuDelegate.mm: * Misc/WebKitErrors.m: (-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]): * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): * WebView/WebClipView.mm: (-[WebClipView _immediateScrollToPoint:]): * WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): * WebView/WebView.mm: 2013-05-07 Mark Rowe WebKit and others fail to build headers due to build root dependency Reviewed by Sam Weinig. * Configurations/WebKit.xcconfig: Look for WebCore's headers within the SDK if we're building against one. 2013-05-07 Mikhail Pozdnyakov HashTraits >::PeekType should be raw pointer for better performance https://bugs.webkit.org/show_bug.cgi?id=115646 Reviewed by Darin Adler. * Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::pluginInstance): * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::cancelStreamLoad): Updated accordingly to new HashMap<.., RefPtr>::get() semantics. 2013-05-04 Dean Jackson Animations and Transitions should not start when globally suspended https://bugs.webkit.org/show_bug.cgi?id=114915 Reviewed by Sam Weinig. The WebView private API cssAnimationsSuspended did not necessarily reflect the reality of the Frame's AnimationController value because it was caching rather than asking directly. While the WebCore part of this patch ensured loading the Document wouldn't resume all animations, it is still better to ask directly. * WebView/WebView.mm: (-[WebView cssAnimationsSuspended]): Call into AnimationController. (-[WebView setCSSAnimationsSuspended:]): Ditto. * WebView/WebViewData.h: Remove cssAnimationsSuspended boolean. * WebView/WebViewData.mm: Ditto. (-[WebViewPrivate init]): 2013-05-04 Sam Weinig Move PopupMenuMac and SearchPopupMenuMac to Source/WebKit/mac matching where they are in WebKit2. Reviewed by Anders Carlsson. * WebCoreSupport/PopupMenuMac.h: Copied from WebCore/platform/mac/PopupMenuMac.h. * WebCoreSupport/PopupMenuMac.mm: Copied from WebCore/platform/mac/PopupMenuMac.mm. * WebCoreSupport/SearchPopupMenuMac.h: Copied from WebCore/platform/mac/SearchPopupMenuMac.h. * WebCoreSupport/SearchPopupMenuMac.mm: Copied from WebCore/platform/mac/SearchPopupMenuMac.mm. * WebCoreSupport/WebChromeClient.mm: 2013-05-04 Anders Carlsson Get rid of -[NSMutableDictionary _webkit_setObject:forUncopiedKey:] https://bugs.webkit.org/show_bug.cgi?id=115592 Reviewed by Beth Dakin. Using CFDictionarySetValue to set a key without having to copy it is not supported. Use NSMapTable with strong pointers instead. * Misc/WebNSDictionaryExtras.h: * Misc/WebNSDictionaryExtras.m: * Panels/WebPanelAuthenticationHandler.h: (NSURLAuthenticationChallenge): * Panels/WebPanelAuthenticationHandler.m: (-[WebPanelAuthenticationHandler init]): (-[WebPanelAuthenticationHandler enqueueChallenge:forWindow:]): (-[WebPanelAuthenticationHandler tryNextChallengeForWindow:]): (-[WebPanelAuthenticationHandler startAuthentication:window:]): (-[WebPanelAuthenticationHandler cancelAuthentication:]): * Plugins/WebNetscapePluginView.h: * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView destroyPlugin]): (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]): (-[WebNetscapePluginView loadPluginRequest:]): 2011-05-01 Ryosuke Niwa [Mac] WebKit doesn't enable or disable autocorrections when system preferences are changed https://bugs.webkit.org/show_bug.cgi?id=115463 Reviewed by Darin Adler. Observe the default notification center for changes to autocorrection preferences. Note system preferences may also update WebAutomatic* defaults. * WebView/WebView.mm: (+[WebView initialize]): (+[WebView _shouldAutomaticTextReplacementBeEnabled]): (+[WebView _didChangeAutomaticTextReplacementEnabled:]): (+[WebView _shouldAutomaticSpellingCorrectionBeEnabled]): (+[WebView _didChangeAutomaticSpellingCorrectionEnabled:]): (+[WebView _shouldAutomaticQuoteSubstitutionBeEnabled]): (+[WebView _shouldAutomaticDashSubstitutionBeEnabled]): (+[WebView _didChangeAutomaticQuoteSubstitutionEnabled:]): (+[WebView _didChangeAutomaticDashSubstitutionEnabled:]): 2013-05-01 Benjamin Poulain Fix the function names of r149453 Unreviewed. I forgot to follow one of Darin's review comment. This patch fixes the function names to follow CF naming conventions. * WebView/WebHTMLRepresentation.mm: (newArrayWithStrings): (newArrayByConcatenatingArrays): (+[WebHTMLRepresentation supportedMIMETypes]): (+[WebHTMLRepresentation supportedNonImageMIMETypes]): (+[WebHTMLRepresentation supportedImageMIMETypes]): (+[WebHTMLRepresentation unsupportedTextMIMETypes]): 2013-05-01 Benjamin Poulain Simplify WebHTMLRepresentation supportedMIMETypes methods https://bugs.webkit.org/show_bug.cgi?id=115314 Reviewed by Darin Adler. The initialization was surprisingly complex because of DEFINE_STATIC_LOCAL. First, a new pointer was allocated on the heap with fast malloc (for RetainPtr). Then a new NSMutableArray was allocated but immediately put on the autorelease pool. Finally, that array was retained by the RetainPtr. This patch changes the code to only leak the NSMutableArray memory. There is no fastMalloc, nor any use of the autorelease pool. * WebView/WebHTMLRepresentation.mm: (createArrayWithStrings): (createArrayByConcatenatingArrays): (+[WebHTMLRepresentation supportedMIMETypes]): (+[WebHTMLRepresentation supportedNonImageMIMETypes]): (+[WebHTMLRepresentation supportedImageMIMETypes]): (+[WebHTMLRepresentation unsupportedTextMIMETypes]): 2013-04-30 Darin Adler [Mac] Remove adoptNS/retain pairs, since the two cancel each other out https://bugs.webkit.org/show_bug.cgi?id=115426 Reviewed by Anders Carlsson. * Plugins/WebNetscapePluginStream.mm: (WebNetscapePluginStream::deliverDataToFile): Remove adoptNS and release. 2013-04-30 Geoffrey Garen Objective-C JavaScriptCore API should publicly support bridging to C https://bugs.webkit.org/show_bug.cgi?id=115447 Reviewed by Mark Hahnenberg. * WebView/WebFrame.mm: (-[WebFrame _javaScriptContextForScriptWorld:]): * WebView/WebScriptWorld.mm: (+[WebScriptWorld scriptWorldForJavaScriptContext:]): 2013-04-30 Anders Carlsson More StorageTracker cleanup https://bugs.webkit.org/show_bug.cgi?id=115429 Reviewed by Andreas Kling. Call PageGroup::syncLocalStorage directly. * Storage/WebStorageManager.mm: (-[WebStorageManager syncLocalStorage]): 2013-04-30 Zalan Bujtas Animations fail to start on http://www.google.com/insidesearch/howsearchworks/thestory/ https://bugs.webkit.org/show_bug.cgi?id=111244 Reviewed by David Kilzer. Enable performance.now() as a minimal subset of Web Timing API. It returns DOMHighResTimeStamp, a monotonically increasing value representing the number of milliseconds from the start of the navigation of the current document. JS libraries use this API to check against the requestAnimationFrame() timestamp. * Configurations/FeatureDefines.xcconfig: 2013-04-29 Chris Fleizach WEB SPEECH: need to identify the default voice per language https://bugs.webkit.org/show_bug.cgi?id=115366 Reviewed by Tim Horton. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2013-04-28 Dean Jackson [Mac] Disable canvas backing store scaling (HIGH_DPI_CANVAS) https://bugs.webkit.org/show_bug.cgi?id=115310 Reviewed by Simon Fraser. Remove ENABLE_HIGH_DPI_CANVAS_macosx. * Configurations/FeatureDefines.xcconfig: 2013-04-27 Darin Adler Move from constructor and member function adoptCF/NS to free function adoptCF/NS. https://bugs.webkit.org/show_bug.cgi?id=115307 Reviewed by Geoffrey Garen. This change was done by a global replace followed by compiling and inspecting for cases that needed to be tweaked by hand. * DefaultDelegates/WebDefaultContextMenuDelegate.mm: (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): * Misc/WebNSFileManagerExtras.mm: (-[NSFileManager _webkit_startupVolumeName]): * Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream): * Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost): (WebKit::NetscapePluginHostManager::instantiatePlugin): * Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): (WebKit::NetscapePluginHostProxy::beginModal): (WKPCBooleanAndDataReply): * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::print): (WebKit::NetscapePluginInstanceProxy::snapshot): (WebKit::NetscapePluginInstanceProxy::status): (WebKit::NetscapePluginInstanceProxy::loadURL): (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): (WebKit::NetscapePluginInstanceProxy::enumerate): (WebKit::NetscapePluginInstanceProxy::marshalValue): (WebKit::NetscapePluginInstanceProxy::marshalValues): (WebKit::NetscapePluginInstanceProxy::demarshalValue): (WebKit::NetscapePluginInstanceProxy::demarshalValues): * Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView setAttributeKeys:andValues:]): (-[WebHostedNetscapePluginView createPlugin]): * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): (-[WebBaseNetscapePluginView cacheSnapshot]): (WebKit::getAuthenticationInfo): * Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): * Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::startTimers): * Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier): (WebNetscapePluginEventHandlerCocoa::handleTSMEvent): * Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _initWithPath:]): * Plugins/WebNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream): (WebNetscapePluginStream::deliverData): (WebNetscapePluginStream::deliverDataToFile): (WebNetscapePluginStream::didReceiveData): * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView createPlugin]): (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]): * Storage/WebDatabaseManagerClient.mm: (WebDatabaseManagerClient::dispatchDidModifyOrigin): (WebDatabaseManagerClient::dispatchDidModifyDatabase): * Storage/WebStorageTrackerClient.mm: (WebStorageTrackerClient::dispatchDidModifyOrigin): * WebCoreSupport/CorrectionPanel.mm: (CorrectionPanel::handleAcceptedReplacement): * WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache originsWithCache]): * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didRunInsecureContent): * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::WebInspectorClient): (WebInspectorClient::openInspectorFrontend): * WebView/WebFullScreenController.mm: (-[WebFullScreenController enterFullScreen:]): * WebView/WebPDFDocumentExtras.mm: (allScriptsInPDFDocument): * WebView/WebPreferences.mm: (-[WebPreferences initWithIdentifier:]): (-[WebPreferences initWithCoder:]): * WebView/WebScriptDebugger.mm: (WebScriptDebugger::initGlobalCallFrame): (WebScriptDebugger::callEvent): * WebView/WebView.mm: (-[WebView previousValidKeyView]): Use adoptNS and adoptCF free functions. 2013-04-25 Roger Fong Disable sub-pixel layout on mac. https://bugs.webkit.org/show_bug.cgi?id=114999. Reviewed by Simon Fraser. * Configurations/FeatureDefines.xcconfig: 2013-04-26 Simon Fraser Layer-backed WebViews don't repaint content outside the visible area https://bugs.webkit.org/show_bug.cgi?id=115275 Reviewed by Beth Dakin. When a client of WebView makes the WebView be layer-backed, then AppKit propagaes the layer-backing down to the WebHTMLView (but no further). In this situation, we had a bug where content that was not in the visible content rect would not get repainted, because WebCore clips repaints to the visible rect. Fix by calling ScrollView::setPaintsEntireContents(bool) from -[WebHTMLView setLayer:], saying that we need to paint the entire contents if we have a layer. * WebView/WebHTMLView.mm: (-[WebHTMLView setLayer:]): 2013-04-25 Chris Fleizach WEB SPEECH: language support does not work as expected https://bugs.webkit.org/show_bug.cgi?id=115119 Reviewed by Alexey Proskuryakov. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2013-04-25 Simon Fraser Build fix for smart compliers. Reviewed by Tim Horton. [NSDictionary dictionaryWithObjectsAndKeys:] returns an NSDictionary, not a NSMutableDictionary. * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::updateSpellingUIWithGrammarString): 2013-04-25 Joseph Pecoraro Web Inspector: ConsoleMessage should include line and column number where possible https://bugs.webkit.org/show_bug.cgi?id=114929 Reviewed by Timothy Hatcher. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::addMessageToConsole): 2013-04-24 Jessie Berlin Assertion failure (crash in release) attempting to delete database storage in WK1 without creating a WebView first https://bugs.webkit.org/show_bug.cgi?id=115065 Reviewed by Brady Eidson. Make sure the WebPlatformStrategies is initialized before using the WebDatabaseManager. * Storage/WebDatabaseManager.mm: (-[WebDatabaseManager init]): Move the logic from WebKitInitializeDatabasesIfNecessary here, and add a call to WebPlatformStrategies::initializeIfNecessary. * Storage/WebDatabaseManagerInternal.h: Removed. * WebCoreSupport/WebPlatformStrategies.h: (WebPlatformStrategies): Change "initialize" to "initalizeIfNecessary". * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::initializeIfNecessary): Only call setPlatformStrategies once. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Updated for the name change from initialize to initializeIfNecessary. Instead of calling WebKitInitializeDatabasesIfNecessary, call [WebDatabaseManager sharedWebDatabaseManager]. (+[WebView _setLoadResourcesSerially:]): Updated for the name change from initialize to initializeIfNecessary. 2013-04-23 Antoine Quint Initial advance of text runs should be taken into account https://bugs.webkit.org/show_bug.cgi?id=114949 Reviewed by Darin Adler. Adding support for new method CTRunGetInitialAdvance in WebKitSystemInterface. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2013-04-22 Benjamin Poulain Remove the memory instrumentation code https://bugs.webkit.org/show_bug.cgi?id=114931 Reviewed by Andreas Kling. * WebView/WebRenderLayer.mm: 2013-04-18 Andy Estes REGRESSION (r116645): Versions app's UI is munged in HiDPI due to background-size being reset to 'auto' when background short-hand is also specified https://bugs.webkit.org/show_bug.cgi?id=114833 Reviewed by David Kilzer. The Versions app specifies both a background-size and a background shorthand CSS property, and its UI is broken after r116645 which resets background-size to 'auto' if the background shorthand property is specified. This patch enables the useLegacyBackgroundSizeShorthandBehavior setting added in r147034 to restore the expected behavior if the embedder is Versions.app and it was linked against a version of WebKit that had the legacy behavior. * Misc/WebKitVersionChecks.h: * WebView/WebView.mm: (shouldUseLegacyBackgroundSizeShorthandBehavior): (-[WebView _commonInitializationWithFrameName:groupName:]): 2013-04-18 Sam Weinig Network Process crashing trying to read in IDNScriptWhiteList.txt https://bugs.webkit.org/show_bug.cgi?id=114827 Reviewed by Anders Carlsson. Move IDNScriptWhiteList.txt from WebKit to WebCore, so that the NetworkProcess does not have to link against WebKit. It was a layering violation for WebCore to be trying to access WebKit resources anyway. * Resources/IDNScriptWhiteList.txt: Removed. 2013-04-17 Geoffrey Garen Renamed JSGlobalData to VM https://bugs.webkit.org/show_bug.cgi?id=114777 Reviewed by Phil Pizlo. * Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptObjectsCount]): (+[WebCoreStatistics javaScriptGlobalObjectsCount]): (+[WebCoreStatistics javaScriptProtectedObjectsCount]): (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]): (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): (+[WebCoreStatistics javaScriptObjectTypeCounts]): (+[WebCoreStatistics shouldPrintExceptions]): (+[WebCoreStatistics setShouldPrintExceptions:]): (+[WebCoreStatistics memoryStatistics]): (+[WebCoreStatistics javaScriptReferencedObjectsCount]): * Plugins/Hosted/NetscapePluginHostProxy.mm: (identifierFromIdentifierRep): * Plugins/Hosted/NetscapePluginInstanceProxy.h: (LocalObjectMap): * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): (WebKit::NetscapePluginInstanceProxy::getWindowNPObject): (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject): (WebKit::NetscapePluginInstanceProxy::evaluate): (WebKit::NetscapePluginInstanceProxy::addValueToArray): * Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyRuntimeMethod::create): (WebKit::ProxyRuntimeMethod::createStructure): (WebKit::ProxyRuntimeMethod::finishCreation): (WebKit::ProxyInstance::getPropertyNames): * Plugins/Hosted/ProxyRuntimeObject.h: (WebKit::ProxyRuntimeObject::create): (WebKit::ProxyRuntimeObject::createStructure): * Plugins/WebNetscapePluginStream.mm: (WebNetscapePluginStream::wantsAllStreams): * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]): (-[WebNetscapePluginView privateBrowsingModeDidChange]): (-[WebNetscapePluginView setWindowIfNecessary]): (-[WebNetscapePluginView createPluginScriptableObject]): (-[WebNetscapePluginView getFormValue:]): (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]): (-[WebNetscapePluginView loadPluginRequest:]): (-[WebNetscapePluginView _printedPluginBitmap]): * Plugins/WebPluginController.mm: (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]): (-[WebPluginController stopOnePlugin:]): (-[WebPluginController destroyOnePlugin:]): (-[WebPluginController startAllPlugins]): (-[WebPluginController addPlugin:]): * WebKit.order: * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]): (-[WebScriptCallFrame evaluateWebScript:]): * WebView/WebScriptDebugger.mm: (WebScriptDebugger::WebScriptDebugger): 2013-04-16 Beth Dakin Re-name Page::layoutMilestones() to Page::requestedLayoutMilestones() https://bugs.webkit.org/show_bug.cgi?id=114713 Reviewed by Simon Fraser. * WebView/WebView.mm: (-[WebView _layoutMilestones]): 2013-04-15 Sam Weinig Remove more #includes from Frame.h https://bugs.webkit.org/show_bug.cgi?id=114642 Reviewed by Anders Carlsson. * WebView/WebFrame.mm: * WebView/WebHTMLRepresentation.mm: * WebView/WebView.mm: 2013-04-16 Alexey Proskuryakov Remove unused AlternativeTextClient::dismissDictationAlternativeUI https://bugs.webkit.org/show_bug.cgi?id=114598 Reviewed by Ryosuke Niwa. * WebCoreSupport/WebAlternativeTextClient.h: * WebCoreSupport/WebAlternativeTextClient.mm: * WebView/WebView.mm: * WebView/WebViewInternal.h: 2013-04-15 Ryosuke Niwa REGRESSION(r146025): WebKit applications can't apply underline or strike through https://bugs.webkit.org/show_bug.cgi?id=114662 Reviewed by Enrica Casucci. Use -webkit- prefixes to apply underline. There should be no further compatibility issues since -khtml- was used only internally to pass the information down to WebCore. Unfortunately, we can't test this code like any other font panel bug. In the long run, we need to add some abstraction layer around font panel to make this testable or else we'll keep regressing this feature. * WebView/WebHTMLView.mm: (-[WebHTMLView _styleFromFontAttributes:]): (-[WebHTMLView _styleForAttributeChange:]): 2013-04-15 Anders Carlsson plugins/get-url-beforeunload-destroys-plugin.html crashes in WebKit1 https://bugs.webkit.org/show_bug.cgi?id=114653 Reviewed by Sam Weinig. Protect the NetscapePluginInstanceProxy since it can otherwise go away. * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::performRequest): 2013-04-14 Sam Weinig Move Mac specific snapshotting code into its own file https://bugs.webkit.org/show_bug.cgi?id=114597 Reviewed by Andreas Kling. * WebView/WebHTMLView.mm: (-[WebHTMLView _selectionDraggingImage]): (-[WebHTMLView selectionImageForcingBlackText:]): 2013-04-14 Andreas Kling Move CSSOM classes to using MutableStylePropertySet over StylePropertySet. Reviewed by Anders Carlsson. * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldApplyStyle): * WebView/WebFrame.mm: (-[WebFrame _typingStyle]): 2013-04-10 Sam Weinig Make Frame's ScriptController an OwnPtr and remove the #include https://bugs.webkit.org/show_bug.cgi?id=114105 Reviewed by Dean Jackson. * Plugins/Hosted/HostedNetscapePluginStream.mm: * Plugins/WebNetscapePluginStream.mm: * Plugins/WebPluginContainerCheck.mm: * WebCoreSupport/WebGeolocationClient.mm: * WebCoreSupport/WebInspectorClient.mm: * WebView/WebFrame.mm: 2013-04-13 Anders Carlsson Add form delegate method that's invoked right before sending a submit event to a form element https://bugs.webkit.org/show_bug.cgi?id=114575 Reviewed by Dan Bernstein. * MigrateHeaders.make: Copy DOMHTMLFormElementInternal.h over to WebKit. * WebCoreSupport/WebFrameLoaderClient.mm: (makeFormFieldValuesDictionary): New helper function that returns the values of a form in dictionary form. (WebFrameLoaderClient::dispatchWillSendSubmitEvent): Call the right delegate method. (WebFrameLoaderClient::dispatchWillSubmitForm): Use the helper function. * WebView/WebDelegateImplementationCaching.h: * WebView/WebDelegateImplementationCaching.mm: (CallFormDelegate): Add another overload. * WebView/WebFormDelegate.h: * WebView/WebFormDelegate.m: (-[WebFormDelegate willSendSubmitEventToForm:inFrame:withValues:]): Add a default implementation. 2013-04-10 Benjamin Poulain Mass remove all the empty directories Rubberstamped by Ryosuke Niwa. * ForwardingHeaders/wtf/unicode/icu: Removed. 2013-04-08 Anders Carlsson Remove unneeded headers from FrameLoader.h https://bugs.webkit.org/show_bug.cgi?id=114223 Reviewed by Geoffrey Garen. Include HistoryController.h from WebCore. * WebCoreSupport/WebFrameLoaderClient.mm: * WebView/WebView.mm: 2013-04-09 Geoffrey Garen Removed bitrotted TimeoutChecker code https://bugs.webkit.org/show_bug.cgi?id=114336 Reviewed by Alexey Proskuryakov. This mechanism hasn't worked for a while. MarkL is working on a new version of this feature with a distinct implementation. * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate): 2013-04-08 Benjamin Poulain Remove HTML Notification https://bugs.webkit.org/show_bug.cgi?id=114231 Reviewed by Ryosuke Niwa. * Configurations/FeatureDefines.xcconfig: 2013-04-05 Anders Carlsson Stop building Objective-C bindings for the SVG DOM https://bugs.webkit.org/show_bug.cgi?id=114076 Reviewed by Geoffrey Garen. The DOM SVG Objective-C bindings have never been exposed as API, and not building them cuts WebCore build by 10%. * Configurations/FeatureDefines.xcconfig: * MigrateHeaders.make: 2013-04-05 Timothy Hatcher Allow the Web Inspector to use WebSQL. This fixes an exception on load in the Safari Web Inspector. https://webkit.org/b/114040 rdar://problem/13581422 Reviewed by Anders Carlsson. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Added. 2013-04-02 Timothy Hatcher Provide a user default that can be used to disable docking of the Web Inspector. The user default is "WebKit Web Inspector Setting - inspectorAttachDisabled". https://webkit.org/b/113779 rdar://problem/13446021 Reviewed by Joseph Pecoraro. * WebCoreSupport/WebInspectorClient.h: (WebInspectorClient::inspectorAttachDisabled): Added. (WebInspectorClient::setInspectorAttachDisabled): Added. * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::didResizeMainFrame): (-[WebInspectorWindowController window]): (-[WebInspectorWindowController showWindow:]): Check inspectorAttachDisabled() in places where we attach or update the dock button. 2013-04-02 Alexey Proskuryakov [Mac] Remove WKCreateNSURLConnectionDelegateProxy https://bugs.webkit.org/show_bug.cgi?id=113810 Reviewed by Anders Carlsson. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2013-04-02 Alexey Proskuryakov [WK2] Crashes in NetworkProcess when canceling loads https://bugs.webkit.org/show_bug.cgi?id=113803 Reviewed by Darin Adler. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::convertMainResourceLoadToDownload): Just pass nil instead of proxy. 2013-04-01 Ryosuke Niwa WebKit/mac shouldn't have code for Mac 10.5 and earlier https://bugs.webkit.org/show_bug.cgi?id=113746 Reviewed by Darin Adler. Deleted the code for 10.5 and removed if-defs for 10.6. * Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView createPlugin]): * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView createPlugin]): (-[WebNetscapePluginView getVariable:forURL:value:length:]): (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]): * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::selectItemWritingDirectionIsNatural): (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): * WebCoreSupport/WebEditorClient.mm: (core): (WebEditorClient::checkTextOfParagraph): (WebEditorClient::requestCheckingOfString): * WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView reflectScrolledClipView:]): * WebView/WebFullScreenController.mm: (-[WebFullScreenController _updateMenuAndDockForFullScreen]): * WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]): (-[WebHTMLView _frameOrBoundsChanged]): (+[WebHTMLView _insertablePasteboardTypes]): (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (writingDirectionKeyBindingsEnabled): (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[WebHTMLView attachRootLayer:]): * WebView/WebHTMLViewInternal.h: * WebView/WebPDFDocumentExtras.mm: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): * WebView/WebResourceInternal.h: * WebView/WebScriptDebugDelegate.h: * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _preferencesChanged:]): (+[WebView initialize]): (clientNeedsWebViewInitThreadWorkaround): (-[WebView validateUserInterfaceItemWithoutDelegate:]): (-[WebView setGrammarCheckingEnabled:]): (-[WebView isAutomaticQuoteSubstitutionEnabled]): (-[WebView isAutomaticLinkDetectionEnabled]): (-[WebView isAutomaticDashSubstitutionEnabled]): (-[WebView isAutomaticTextReplacementEnabled]): (-[WebView isAutomaticSpellingCorrectionEnabled]): (-[WebView _searchWithSpotlightFromMenu:]): (WebInstallMemoryPressureHandler): * WebView/WebViewPrivate.h: 2013-04-01 Tim Horton WebCache should do the normal initialization dance https://bugs.webkit.org/show_bug.cgi?id=113722 Reviewed by Anders Carlsson. In case a WebKit1 client uses WebCache before creating a WebView (or any of the other initialization-ready classes), we should do the initialization work in WebCache as well. * Misc/WebCache.mm: (+[WebCache initialize]): 2013-03-26 Timothy Hatcher Add support for dock-to-right of the Web Inspector in the Mac port. Unfortunately this requires Safari changes, so it is disabled in the nightly builds. https://webkit.org/b/113341 rdar://problem/10368152 Reviewed by Joseph Pecoraro. * Resources/Dock.pdf: Updated. * WebCoreSupport/WebInspectorClient.h: (WebInspectorFrontendClient): * WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::frontendLoaded): (WebInspectorFrontendClient::attachWindow): (WebInspectorFrontendClient::setAttachedWindowWidth): (-[WebInspectorWindowController attachWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]): * WebInspector/WebInspectorFrontend.mm: (-[WebInspectorFrontend attach]): 2013-03-26 Tim Horton Unreviewed attempted cr-mac build fix. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2013-03-26 Hayato Ito Allow ShadowContents in HitTests by default. https://bugs.webkit.org/show_bug.cgi?id=113171 Reviewed by Dimitri Glazkov. * WebView/WebFrame.mm: (-[WebFrame elementAtPoint:]): * WebView/WebHTMLView.mm: (-[WebHTMLView elementAtPoint:allowShadowContent:]): 2013-03-26 Tim Horton [ca] Tell CA to clean up unused resources if a given WebProcess won't be drawing https://bugs.webkit.org/show_bug.cgi?id=107539 Reviewed by Simon Fraser. Update WebSystemInterface. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2013-03-26 Sergio Villar Senin Implement overtype mode for editable content https://bugs.webkit.org/show_bug.cgi?id=112126 Reviewed by Ryosuke Niwa. Added the OverWrite editing command to the WebCore editing commands lists. * WebView/WebHTMLView.mm: * WebView/WebView.h: * WebView/WebView.mm: 2013-03-25 Kent Tamura Rename ENABLE_INPUT_TYPE_DATETIME https://bugs.webkit.org/show_bug.cgi?id=113254 Reviewed by Kentaro Hara. Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE. Actually I'd like to remove the code, but we shouldn't remove it yet because we shipped products with it on some platforms. * Configurations/FeatureDefines.xcconfig: 2013-03-21 Kiran Muppala Add runtime setting for hidden page DOM timer throttling and CSS animation suspension https://bugs.webkit.org/show_bug.cgi?id=112308 Reviewed by Gavin Barraclough. Add private preference for enabling/disabling hidden page DOM timer throttling and CSS animation suspension. The preference should be disabled by default to avoid compatibility issues. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences hiddenPageDOMTimerThrottlingEnabled]): (-[WebPreferences setHiddenPageDOMTimerThrottlingEnabled:]): (-[WebPreferences hiddenPageCSSAnimationSuspensionEnabled]): (-[WebPreferences setHiddenPageCSSAnimationSuspensionEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2013-03-19 Ryosuke Niwa Another Mac build fix attempt after r146239. * WebCoreSupport/WebFrameNetworkingContext.h: (WebFrameNetworkingContext): 2013-03-19 Ryosuke Niwa Mac build fix attempt after r146239. * WebCoreSupport/WebFrameNetworkingContext.h: 2013-03-19 Sergey Ryazanov Web Inspector: split Console into two entities, a web-facing bound object and page console. https://bugs.webkit.org/show_bug.cgi?id=111578 Reviewed by Vsevolod Vlasov. Otherwise, a lot of logging in WebCore needs to go through the DOMWindow which is unnecessary. * Misc/WebCoreStatistics.mm: (+[WebCoreStatistics shouldPrintExceptions]): (+[WebCoreStatistics setShouldPrintExceptions:]): 2013-03-17 Adam Barth Legacy CSS vendor prefixes should only work for Dashboard https://bugs.webkit.org/show_bug.cgi?id=111890 Reviewed by Eric Seidel. Enable legacy CSS vendor prefixes when we've been asked to turn on Dashboard compatibility mode. * WebView/WebView.mm: (-[WebView _setDashboardBehavior:to:]): 2013-03-16 Pratik Solanki Disable High DPI Canvas on iOS https://bugs.webkit.org/show_bug.cgi?id=112511 Reviewed by Joseph Pecoraro. * Configurations/FeatureDefines.xcconfig: 2013-03-15 Timothy Hatcher Disable suppressesIncrementalRendering for the Web Inspector. This ends up causing the Inspector to show blank for a couple seconds before it does its first paint. During that time the bare window chrome is showing when the Inspector's background and other simple elements count be painting. This causes the Inspector to look like it is loading slower than reality. https://bugs.webkit.org/show_bug.cgi?id=112300 rdar://problem/13412219 Reviewed by Geoff Garen. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): Disable suppressesIncrementalRendering. 2013-03-15 Nate Chapin Hide MainResourceLoader from the outside world https://bugs.webkit.org/show_bug.cgi?id=109971 Reviewed by Adam Barth. * WebCoreSupport/WebFrameLoaderClient.h: (WebFrameLoaderClient): * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::convertMainResourceLoadToDownload): 2013-03-15 Abhishek Arya Replace static_casts with to* helper functions. https://bugs.webkit.org/show_bug.cgi?id=112401 Reviewed by Stephen Chenney. to* helper functions are preferred over static_cast calls since they help to catch bad casts easily on the testing infrastructure. * WebView/WebRenderNode.mm: (copyRenderNode): * WebView/WebView.mm: (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]): 2013-03-14 Manuel Rego Casasnovas Add selectTrailingWhitespaceEnabled setting to WebCore::Page https://bugs.webkit.org/show_bug.cgi?id=109404 Reviewed by Tony Chang. Use new settings for smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled. * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::smartInsertDeleteEnabled): (WebEditorClient::isSelectTrailingWhitespaceEnabled): * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Initialize settings from NSUserDefaults. (-[WebView setSelectTrailingWhitespaceEnabled:]): (-[WebView isSelectTrailingWhitespaceEnabled]): (-[WebView setSmartInsertDeleteEnabled:]): (-[WebView smartInsertDeleteEnabled]): * WebView/WebViewData.h: * WebView/WebViewData.mm: (-[WebViewPrivate init]): 2013-03-14 Abhishek Arya Replace static_casts with to* helper functions. https://bugs.webkit.org/show_bug.cgi?id=112296 Reviewed by Kentaro Hara. to* helper functions are preferred over static_cast calls since they help to catch bad casts easily on the testing infrastructure. * WebCoreSupport/WebFrameLoaderClient.mm: (applyAppleDictionaryApplicationQuirkNonInlinePart): * WebView/WebHTMLRepresentation.mm: (searchForLabelsBeforeElement): 2013-03-14 Alice Liu Add to HistoryItem a way to know if its underlying CachedPage has expired. https://bugs.webkit.org/show_bug.cgi?id=110652 Reviewed by Brady Eidson. * History/WebHistoryItem.mm: (-[WebHistoryItem _isInPageCache]): Added. Just calls and returns core imple's function. (-[WebHistoryItem _hasCachedPageExpired]): Same thing. * History/WebHistoryItemPrivate.h: * WebView/WebPreferences.mm: (-[WebPreferences _backForwardCacheExpirationInterval]): Address fixme, now that WebCore::Settings has getters and setters with default value. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): call setBackForwardCacheExpirationInterval similar to other settings. 2013-03-13 Rik Cabanier create runtime flags for CSS Compositing https://bugs.webkit.org/show_bug.cgi?id=111818 Reviewed by Ryosuke Niwa. Added a preference to enable CSS compositing. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences cssCompositingEnabled]): (-[WebPreferences setCSSCompositingEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2013-03-13 Ryosuke Niwa Threaded HTML Parser is missing feature define flags in all but Chromium port's build files https://bugs.webkit.org/show_bug.cgi?id=112277 Reviewed by Adam Barth. * Configurations/FeatureDefines.xcconfig: 2013-03-13 Pavel Feldman Web Inspector: get rid of hiddenPanels filter https://bugs.webkit.org/show_bug.cgi?id=112252 Reviewed by Vsevolod Vlasov. * WebCoreSupport/WebInspectorClient.h: (WebInspectorFrontendClient): * WebCoreSupport/WebInspectorClient.mm: * WebKit.order: 2013-03-12 Geoffrey Garen Moved RunLoopTimer and SchedulePair to WTF https://bugs.webkit.org/show_bug.cgi?id=112171 Reviewed by Oliver Hunt. This will allow us to use timers in lower level primitives without duplicating all the code. * WebCoreSupport/WebFrameNetworkingContext.h: (WebFrameNetworkingContext): 2013-03-12 Abhishek Arya Replace static_casts with to* functions. https://bugs.webkit.org/show_bug.cgi?id=112072 Reviewed by Philip Rogers. to* functions are preferred over static_cast calls since they help to catch bad casts easily on the testing infrastructure. * WebView/WebView.mm: (-[WebView _enterFullscreenForNode:WebCore::]): 2013-03-11 Sheriff Bot Unreviewed, rolling out r145462. http://trac.webkit.org/changeset/145462 https://bugs.webkit.org/show_bug.cgi?id=112097 Compilation failure in PluginView.cpp (Requested by jamesr_ on #webkit). * WebView/WebView.mm: (-[WebView _enterFullscreenForNode:WebCore::]): 2013-03-11 Abhishek Arya Replace static_casts with to* functions. https://bugs.webkit.org/show_bug.cgi?id=112072 Reviewed by Philip Rogers. to* functions are preferred over static_cast calls since they help to catch bad casts easily on the testing infrastructure. * WebView/WebView.mm: (-[WebView _enterFullscreenForNode:WebCore::]): 2013-03-11 Jochen Eisinger Rename DefinitelyProcessingUserGesture to DefinitelyProcessingNewUserGesture https://bugs.webkit.org/show_bug.cgi?id=111959 Reviewed by Alexey Proskuryakov. * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate): * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]): 2013-03-11 Abhishek Arya Replace static_cast with to* helper functions. https://bugs.webkit.org/show_bug.cgi?id=112045 Reviewed by Eric Seidel. * WebView/WebRenderLayer.mm: (+[WebRenderLayer nameForLayer:]): 2013-03-11 Jer Noble Unreviewed build fix. Remove stray brace which crept into r145409. * WebView/WebFullScreenController.mm: (-[WebFullScreenController performClose:]): 2013-01-30 Jer Noble Mac: Cmd-w should close full screen window. https://bugs.webkit.org/show_bug.cgi?id=108406 Reviewed by Darin Adler. Allow the user to close the full screen window with Cmd-w by making the full screen window closable, and by intercepting performClose:. * WebView/WebFullScreenController.mm: (-[WebFullScreenController init]): Create a closable full screen window. (-[WebFullScreenController performClose:]): When we receive a close request in full screen mode, animate out of full screen. 2013-03-07 Anders Carlsson Add didFocusTextField:inFrame to WebFormDelegate https://bugs.webkit.org/show_bug.cgi?id=111804 Reviewed by Dan Bernstein. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::focusedNodeChanged): * WebView/WebFormDelegate.h: * WebView/WebFormDelegate.m: (-[WebFormDelegate didFocusTextField:inFrame:]): 2013-03-04 Jer Noble Default mouse cursor behavior should be auto-hide for full screen video with custom controls https://bugs.webkit.org/show_bug.cgi?id=107601 Reviewed by Beth Dakin. Enable the CURSOR_VISIBILITY feature. * Configurations/FeatureDefines.xcconfig: 2013-03-05 Geoffrey Garen Removed some dead code in the page cache https://bugs.webkit.org/show_bug.cgi?id=111525 Reviewed by Alexey Proskuryakov. Page cache autorelease doesn't exist anymore, so there's no need to keep around these olds hacks. This fixes Fix bizarre WebWindowWatcher policy in WebHistoryItem. * History/WebHistoryItem.mm: (+[WebHistoryItem _releaseAllPendingPageCaches]): * History/WebHistoryItemInternal.h: * Misc/WebCoreStatistics.mm: (+[WebCoreStatistics autoreleasedPageCount]): * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): 2013-03-06 Dmitry Zvorygin Introduce new message sources for logging. https://bugs.webkit.org/show_bug.cgi?id=110968 Reviewed by Pavel Feldman. * WebCoreSupport/WebChromeClient.mm: * WebView/WebUIDelegatePrivate.h: 2013-03-05 Kent Tamura Rename WebCore/editing/visible_units.* to VisibleUnits.* https://bugs.webkit.org/show_bug.cgi?id=111426 Reviewed by Alexey Proskuryakov. * WebView/WebFrame.mm: 2013-03-05 James Robinson ContainerNode::setActive should not sleep for 100ms on platforms that do not implement synchronous repaint(true) semantics https://bugs.webkit.org/show_bug.cgi?id=87054 Reviewed by Darin Adler. The Mac WebKit1 port supports immediate invalidations. * WebCoreSupport/WebChromeClient.h: (WebChromeClient): * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::supportsImmediateInvalidation): 2013-03-05 David Kilzer BUILD FIX (r144698): Only enable SPEECH_SYNTHESIS for Mac Fixes the following build failures: Undefined symbols for architecture i386: "__ZTVN7WebCore25PlatformSpeechSynthesizerE", referenced from: __ZN7WebCore25PlatformSpeechSynthesizerC2EPNS_31PlatformSpeechSynthesizerClientE in PlatformSpeechSynthesizer.o NOTE: a missing vtable usually means the first non-inline virtual member function has no definition. "__ZN7WebCore25PlatformSpeechSynthesizer19initializeVoiceListEv", referenced from: __ZN7WebCore25PlatformSpeechSynthesizerC2EPNS_31PlatformSpeechSynthesizerClientE in PlatformSpeechSynthesizer.o ld: symbol(s) not found for architecture i386 * Configurations/FeatureDefines.xcconfig: - Only set ENABLE_SPEECH_SYNTHESIS for the macosx platform. 2013-03-04 David Kilzer BUILD FIX (r144662): Import JSBase.h in WebFrameLoadDelegate.h Fixes the following build failure: In file included from Source/WebKit/ios/DefaultDelegates/WebDefaultFrameLoadDelegate.m:11: In file included from Source/WebKit/mac/WebView/WebFrameLoadDelegatePrivate.h:29: Source/WebKit/mac/WebView/WebFrameLoadDelegate.h:41:5: error: 'JSC_OBJC_API_ENABLED' is not defined, evaluates to 0 [-Werror,-Wundef] #if JSC_OBJC_API_ENABLED ^ Source/WebKit/mac/WebView/WebFrameLoadDelegate.h:207:5: error: 'JSC_OBJC_API_ENABLED' is not defined, evaluates to 0 [-Werror,-Wundef] #if JSC_OBJC_API_ENABLED ^ 2 errors generated. * WebView/WebFrameLoadDelegate.h: Include JSBase.h. 2013-03-04 Chris Fleizach Support WebSpeech - Speech Synthesis https://bugs.webkit.org/show_bug.cgi?id=106742 Reviewed by Simon Fraser. Enable speech synthesis for the Mac. * Configurations/FeatureDefines.xcconfig: 2013-03-04 Mark Hahnenberg Remove contextInternalContext from JSContextInternal.h https://bugs.webkit.org/show_bug.cgi?id=111356 Reviewed by Geoffrey Garen. We don't need it any more since we have globalContextRef in JSContext. * WebView/WebScriptWorld.mm: (+[WebScriptWorld scriptWorldForJavaScriptContext:]): 2013-03-04 Laszlo Gombos JSC_OBJC_API_ENABLED should be removed from FeatureDefines.h https://bugs.webkit.org/show_bug.cgi?id=111269 Reviewed by Mark Hahnenberg. Include JavaScriptCore/JSBase.h for the definition of JSC_OBJC_API_ENABLED. * WebView/WebDelegateImplementationCaching.h: 2013-03-04 Kunihiko Sakamoto Add build flag for FontLoader https://bugs.webkit.org/show_bug.cgi?id=111289 Reviewed by Benjamin Poulain. Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default). * Configurations/FeatureDefines.xcconfig: 2013-03-03 Benjamin Poulain [Mac] Get rid of a useless method from DOMHTMLInputElement https://bugs.webkit.org/show_bug.cgi?id=111279 Reviewed by Sam Weinig. * DOM/WebDOMOperations.mm: * DOM/WebDOMOperationsPrivate.h: setValueForUser: is already privately exposed by DOMHTMLInputElement, no need to have it twice. 2013-03-03 Adam Barth Unreviewed attempted build fix. Adds back some includes removed in http://trac.webkit.org/changeset/144565. * DOM/WebDOMOperations.mm: * Misc/WebNSPasteboardExtras.mm: * WebCoreSupport/WebFrameNetworkingContext.mm: * WebView/WebRenderLayer.mm: * WebView/WebRenderNode.mm: 2013-03-03 Adam Barth Unreviewed rollout of http://trac.webkit.org/r144530 As described in https://bugs.webkit.org/show_bug.cgi?id=111167 and https://bugs.webkit.org/show_bug.cgi?id=111035, this patch caused a large number of ASSERTs in chromium-win. * DOM/WebDOMOperations.mm: * Misc/WebNSPasteboardExtras.mm: * WebCoreSupport/WebFrameNetworkingContext.mm: * WebView/WebRenderLayer.mm: * WebView/WebRenderNode.mm: 2013-02-18 Darin Adler Cut down the number of source files that depend on Clipboard.h https://bugs.webkit.org/show_bug.cgi?id=110030 Reviewed by Ryosuke Niwa. * WebView/WebPDFView.mm: Add include of Clipboard.h since we use it here and the world no longer includes it everywhere. 2013-03-02 Benjamin Poulain Move computedStyleIncludingVisitedInfo from TestRunner to Internals https://bugs.webkit.org/show_bug.cgi?id=109772 Reviewed by Andreas Kling. * WebView/WebView.mm: * WebView/WebViewPrivate.h: 2013-03-02 David Kilzer BUILD FIX (r143637): Predeclare JSContext as an Objective-C class Fixes the following build failure: In file included from Source/WebKit/ios/DefaultDelegates/WebDefaultFrameLoadDelegate.m:11: In file included from Source/WebKit/mac/WebView/WebFrameLoadDelegatePrivate.h:29: Source/WebKit/mac/WebView/WebFrameLoadDelegate.h:215:64: error: expected a type - (void)webView:(WebView *)webView didCreateJavaScriptContext:(JSContext *)context forFrame:(WebFrame *)frame; ^ 1 error generated. * WebView/WebFrameLoadDelegate.h: Add @class JSContext declaration. 2013-02-28 Alexey Proskuryakov Reduce amount of rebuilding when touching networking headers https://bugs.webkit.org/show_bug.cgi?id=111035 Reviewed by Eric Seidel. Adding includes that are now necessary because WebCore headers don't have them any more. * DOM/WebDOMOperations.mm: * Misc/WebNSPasteboardExtras.mm: * WebCoreSupport/WebFrameNetworkingContext.mm: * WebView/WebRenderLayer.mm: * WebView/WebRenderNode.mm: 2013-03-01 Jason Anderssen Move markerTextForListItem from TestRunner to Internals https://bugs.webkit.org/show_bug.cgi?id=110939 Reviewed by Benjamin Poulain. * DOM/WebDOMOperations.mm: * DOM/WebDOMOperationsPrivate.h: 2013-02-28 Sam Weinig Add SPI for marking a WebView as doing things on behalf of another process https://bugs.webkit.org/show_bug.cgi?id=111125 Reviewed by Alexey Proskuryakov. * WebCoreSupport/WebFrameNetworkingContext.h: (WebFrameNetworkingContext): * WebCoreSupport/WebFrameNetworkingContext.mm: (WebFrameNetworkingContext::sourceApplicationAuditData): * WebView/WebView.mm: (-[WebView _setSourceApplicationAuditData:]): (-[WebView _sourceApplicationAuditData]): * WebView/WebViewData.h: * WebView/WebViewData.mm: (-[WebViewPrivate dealloc]): * WebView/WebViewPrivate.h: Add SPI for setting a source application for a WebView. 2013-03-01 Sheriff Bot Unreviewed, rolling out r144422 and r144424. http://trac.webkit.org/changeset/144422 http://trac.webkit.org/changeset/144424 https://bugs.webkit.org/show_bug.cgi?id=111167 Caused over 20 tests to fail assertion on Chromium Win port as ASSERTION FAILED: m_platformRequestUpdated (Requested by toyoshim on #webkit). * DOM/WebDOMOperations.mm: * Misc/WebNSPasteboardExtras.mm: * WebCoreSupport/WebFrameNetworkingContext.mm: * WebView/WebRenderLayer.mm: * WebView/WebRenderNode.mm: 2013-02-28 Alexey Proskuryakov Reduce amount of rebuilding when touching networking headers https://bugs.webkit.org/show_bug.cgi?id=111035 Reviewed by Eric Seidel. Adding includes that are now necessary because WebCore headers don't have them any more. * DOM/WebDOMOperations.mm: * Misc/WebNSPasteboardExtras.mm: * WebCoreSupport/WebFrameNetworkingContext.mm: * WebView/WebRenderLayer.mm: * WebView/WebRenderNode.mm: 2013-02-27 John Bauman Plugin in iframe may not display https://bugs.webkit.org/show_bug.cgi?id=109879 Reviewed by Simon Fraser. Ensure NetscapePluginWidget informs the plugin view of the cliprect change directly. * Plugins/WebBaseNetscapePluginView.h: * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::clipRectChanged): 2013-02-26 Alexey Proskuryakov Don't add a body to platform request until necessary https://bugs.webkit.org/show_bug.cgi?id=110900 Reviewed by Brady Eidson. WebKit1 behavior is unchanged, body is added on every conversion. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::convertMainResourceLoadToDownload): (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDecidePolicyForResponse): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::canHandleRequest): * WebView/WebDataSource.mm: (-[WebDataSource initialRequest]): (-[WebDataSource request]): * WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): 2013-02-27 Glenn Adams Add ENABLE_CSS3_TEXT_LINE_BREAK flag. https://bugs.webkit.org/show_bug.cgi?id=110944 Reviewed by Dean Jackson. * Configurations/FeatureDefines.xcconfig: 2013-02-26 Jer Noble Unreviewed build fix; use correct macro for platform name in FeatureDefines.xcconfig. * Configurations/FeatureDefines.xcconfig: 2013-02-26 Dmitry Zvorygin Merged Tip and Debug log levels for web console. https://bugs.webkit.org/show_bug.cgi?id=109919 Reviewed by Pavel Feldman. In every component either TIP or DEBUG level was used for reporting, but not both. This patch is prerequisite for Web Inspector console log filtering. * WebCoreSupport/WebChromeClient.mm: (stringForMessageLevel): * WebView/WebUIDelegatePrivate.h: 2013-02-21 Jeffrey Pfau Optionally partition cache to prevent using cache for tracking https://bugs.webkit.org/show_bug.cgi?id=110269 Reviewed by Maciej Stachowiak. Update WKSI bindings and add feature defines. * Configurations/FeatureDefines.xcconfig: Add defines for cache partitioning and public suffix list usage * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2013-02-25 Jer Noble Normalize ENABLE_ENCRYPTED_MEDIA definitions across all FeatureDefines files. https://bugs.webkit.org/show_bug.cgi?id=110806 Reviewed by Alexey Proskuryakov. Ensure both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 are enabled on macosx_1090. * Configurations/FeatureDefines.xcconfig: 2013-02-25 Andreas Kling Reduce amount of code that includes StylePropertySet.h Reviewed by Antti Koivisto. * WebCoreSupport/WebEditorClient.mm: * WebView/WebFrame.mm: * WebView/WebView.mm: 2013-02-24 Andreas Kling Reduce include graph of JSDOMBinding.h Reviewed by Antti Koivisto. * WebView/WebHTMLView.mm: 2013-02-21 Grzegorz Czajkowski Allow to retrieve the request data from abstract TextCheckingRequest to be accessible for WK2 https://bugs.webkit.org/show_bug.cgi?id=110208 Reviewed by Hajime Morrita. * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::didCheckSucceed): (WebEditorClient::requestCheckingOfString): Extract the request data as it is the member of 'TextCheckingRequest'. 2013-02-19 Mark Hahnenberg Objective-C API: Need a way to use the Objective-C JavaScript API with WebKit https://bugs.webkit.org/show_bug.cgi?id=106059 Reviewed by Geoffrey Garen. Addition of appropriate delegate callbacks and support to the WebKit API. * WebCoreSupport/WebFrameLoaderClient.mm: * WebView/WebDelegateImplementationCaching.h: (WebFrameLoadDelegateImplementationCache): * WebView/WebFrame.h: * WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): (-[WebFrame _javaScriptContextForScriptWorld:]): (-[WebFrame javaScriptContext]): * WebView/WebFrameLoadDelegate.h: * WebView/WebFramePrivate.h: * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame _convertValueToObjcValue:JSC::]): (-[WebScriptCallFrame exception]): (-[WebScriptCallFrame evaluateWebScript:]): * WebView/WebScriptWorld.h: * WebView/WebScriptWorld.mm: (+[WebScriptWorld scriptWorldForJavaScriptContext:]): * WebView/WebView.mm: (-[WebView _cacheFrameLoadDelegateImplementations]): (aeDescFromJSValue): (-[WebView aeDescByEvaluatingJavaScriptFromString:]): (-[WebView _computedStyleIncludingVisitedInfo:forElement:]): 2013-02-20 Dirk Schulze Enable CANVAS_PATH flag https://bugs.webkit.org/show_bug.cgi?id=108508 Reviewed by Simon Fraser. Enable CANVAS_PATH flag on trunk. * Configurations/FeatureDefines.xcconfig: 2013-02-19 Tim Horton Clarify isInWindow vs. isVisible path through to RenderLayerCompositor https://bugs.webkit.org/show_bug.cgi?id=110261 Reviewed by Simon Fraser. * WebView/WebView.mm: (-[WebView viewWillMoveToWindow:]): (-[WebView viewDidMoveToWindow]): Use Page::setIsInWindow in addition to willMoveOffscreen/didMoveOnscreen. 2013-02-18 Anders Carlsson Add a DefaultHash for RefPtr https://bugs.webkit.org/show_bug.cgi?id=110170 Reviewed by Andreas Kling. Remove all explicit uses of SecurityOriginHash. * WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache originsWithCache]): 2013-02-15 Eric Carlson [Mac] remove wkCaptionAppearance from WebKitSystemInterface https://bugs.webkit.org/show_bug.cgi?id=109996 Reviewed by Simon Fraser. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2013-02-15 Sheriff Bot Unreviewed, rolling out r143088. http://trac.webkit.org/changeset/143088 https://bugs.webkit.org/show_bug.cgi?id=110000 Breaks the build (Requested by dgorbik on #webkit). * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2013-02-15 Eric Carlson [Mac] remove wkCaptionAppearance from WebKitSystemInterface https://bugs.webkit.org/show_bug.cgi?id=109996 Reviewed by Simon Fraser. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2013-02-15 Allan Sandfeld Jensen Simplify hitTestResultAtPoint and nodesFromRect APIs https://bugs.webkit.org/show_bug.cgi?id=95720 Reviewed by Julien Chaffraix. Update calls to new API. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary): * WebView/WebFrame.mm: (-[WebFrame elementAtPoint:]): * WebView/WebHTMLView.mm: (-[WebHTMLView elementAtPoint:allowShadowContent:]): 2013-02-14 David Kilzer [Mac] Clean up WARNING_CFLAGS Reviewed by Mark Rowe. * Configurations/Base.xcconfig: Use GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable -Wshorten-64-to-32 rather than WARNING_CFLAGS. 2013-02-13 Zan Dobersek The 'global isinf/isnan' compiler quirk required when using clang with libstdc++ https://bugs.webkit.org/show_bug.cgi?id=109325 Reviewed by Anders Carlsson. Prefix calls to the isinf and isnan methods with std::, declaring we want to use the two methods as they're provided by the C++ standard library being used. * tests/DecimalTest.cpp: (TEST_F): 2013-02-12 Joseph Pecoraro [iOS] Enable PAGE_VISIBILITY_API https://bugs.webkit.org/show_bug.cgi?id=109399 Reviewed by David Kilzer. * Configurations/FeatureDefines.xcconfig: 2013-02-12 David Kilzer BUILD FIX (r142576): WK1 build fails when ENABLE(DELETION_UI) is off Fixes the following build failure: WebEditorClient.mm:243:23: error: out-of-line definition of 'shouldShowDeleteInterface' does not match any declaration in 'WebEditorClient' bool WebEditorClient::shouldShowDeleteInterface(HTMLElement* element) ^~~~~~~~~~~~~~~~~~~~~~~~~ * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldShowDeleteInterface): Protect with ENABLE(DELETION_UI) macro. 2013-02-11 Ryosuke Niwa Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface https://bugs.webkit.org/show_bug.cgi?id=109534 Reviewed by Anders Carlsson. * WebCoreSupport/WebEditorClient.h: 2013-02-11 Benjamin Poulain Kill TestRunner::setMinimumTimerInterval; implement the feature with InternalSettings https://bugs.webkit.org/show_bug.cgi?id=109349 Reviewed by Sam Weinig. * WebView/WebView.mm: * WebView/WebViewPrivate.h: 2013-02-10 Dan Bernstein Added *.pdf to EXCLUDED_SOURCE_FILE_NAMES_iphoneos. Rubber-stamped by Anders Carlsson. * Configurations/WebKit.xcconfig: 2013-02-10 Jae Hyun Park Rename ENABLE(GLIB_SUPPORT) to USE(GLIB) https://bugs.webkit.org/show_bug.cgi?id=104266 Reviewed by Philippe Normand. Using USE(GLIB) instead of ENABLE(GLIB_SUPPORT) is more consistent with the existing macro naming conventions. From Platform.h USE() - use a particular third-party library or optional OS service ENABLE() - turn on a specific feature of WebKit * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _close]): * WebView/WebViewData.h: * WebView/WebViewInternal.h: 2013-02-08 Benjamin Poulain Move workerThreadCount from TestRunner to WebCore Internals https://bugs.webkit.org/show_bug.cgi?id=109239 Reviewed by Darin Adler. Get rid of WebWorkersPrivate, which was only needed for DRT. * WebKit.exp: * Workers/WebWorkersPrivate.h: Removed. * Workers/WebWorkersPrivate.mm: Removed. 2013-02-07 Sheriff Bot Unreviewed, rolling out r142212. http://trac.webkit.org/changeset/142212 https://bugs.webkit.org/show_bug.cgi?id=109255 Causes ASSERT(!m_installed) on launch (Requested by smfr on #webkit). * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (WebInstallMemoryPressureHandler): 2013-02-06 Gavin Barraclough PluginProcess should quit immediately if idle in response to low-memory notifications https://bugs.webkit.org/show_bug.cgi?id=109103 Reviewed by Darin Adler. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): - MemoryPressureHandler::install is now called via MemoryPressureHandler::initialize. (WebInstallMemoryPressureHandler): - MemoryPressureHandler::install is now called via MemoryPressureHandler::initialize. 2013-02-07 Benjamin Poulain Move pauseAnimation/pauseTransition from TestRunner to Internals https://bugs.webkit.org/show_bug.cgi?id=109107 Reviewed by Anders Carlsson. * WebView/WebFrame.mm: * WebView/WebFramePrivate.h: 2013-02-06 Mike West Add an ENABLE_NOSNIFF feature flag. https://bugs.webkit.org/show_bug.cgi?id=109029 Reviewed by Jochen Eisinger. This new flag will control the behavior of 'X-Content-Type-Options: nosniff' when processing script and other resource types. * Configurations/FeatureDefines.xcconfig: 2013-02-04 Benjamin Poulain Kill suspendAnimation(), resumeAnimation() and numberOfActiveAnimations() from DRT/WTR; use Internals https://bugs.webkit.org/show_bug.cgi?id=108741 Reviewed by Tony Chang. * WebView/WebFrame.mm: * WebView/WebFramePrivate.h: 2013-02-04 Enrica Casucci Add specific EditActions for Bold and Italic commands. https://bugs.webkit.org/show_bug.cgi?id=108842. Reviewed by Ryosuke Niwa. * WebCoreSupport/WebEditorClient.mm: (undoNameForEditAction): 2013-02-03 David Kilzer Upstream ENABLE_PDFKIT_PLUGIN settting Reviewed by Tim Horton. * Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN on iOS since PDFKit is a Mac-only framework. 2013-02-02 David Kilzer Upstream iOS FeatureDefines Reviewed by Anders Carlsson. * Configurations/FeatureDefines.xcconfig: - ENABLE_DEVICE_ORIENTATION: Add iOS configurations. - ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto. - FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO. Add PLATFORM_NAME variant to reduce future merge conflicts. 2013-02-01 Alexis Menard Enable unprefixed CSS transitions by default. https://bugs.webkit.org/show_bug.cgi?id=108216 Reviewed by Dean Jackson. Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to guard the unprefixing work for CSS Transforms and animations. * Configurations/FeatureDefines.xcconfig: 2013-01-31 Aurimas Liutikas Editor::m_compositionNode not updated on HTMLInputElement::setValue() https://bugs.webkit.org/show_bug.cgi?id=107737 Reviewed by Ryosuke Niwa. * WebView/WebHTMLView.mm: (-[WebHTMLView _updateSelectionForInputManager]): 2013-01-31 Sheriff Bot Unreviewed, rolling out r141479. http://trac.webkit.org/changeset/141479 https://bugs.webkit.org/show_bug.cgi?id=108564 breaks chromium test (Requested by morrita on #webkit). * WebView/WebHTMLView.mm: (-[WebHTMLView _updateSelectionForInputManager]): 2013-01-31 Enrica Casucci Mac: Editor::baseWritingDirectionForSelectionStart should return WritingDirection instead of NSWritingDirection. https://bugs.webkit.org/show_bug.cgi?id=108519. Reviewed by Sam Weinig. There is no need to use AppKit types here. baseWritingDirectionForSelectionStart now returns WritingDirection and WebHTMLView toggleWritingDirection has been modified accordingly. * WebView/WebHTMLView.mm: (-[WebHTMLView toggleBaseWritingDirection:]): 2013-01-31 Aurimas Liutikas Editor::m_compositionNode not updated on HTMLInputElement::setValue() https://bugs.webkit.org/show_bug.cgi?id=107737 Reviewed by Ryosuke Niwa. * WebView/WebHTMLView.mm: (-[WebHTMLView _updateSelectionForInputManager]): 2013-01-31 Joseph Pecoraro Disable ENABLE_FULLSCREEN_API on iOS https://bugs.webkit.org/show_bug.cgi?id=108250 Reviewed by Benjamin Poulain. * Configurations/FeatureDefines.xcconfig: 2013-01-31 Enrica Casucci WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access. https://bugs.webkit.org/show_bug.cgi?id=108396. Reviewed by Alexey Proskuryakov. Adds stub implementation for WebKit of the new EditorClient methods. * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::willWriteSelectionToPasteboard): (WebEditorClient::getClientPasteboardDataForRange): 2013-01-31 Brady Eidson Lack of a log level string should not obliterate compiled in logging channel state. https://bugs.webkit.org/show_bug.cgi?id=108502 Reviewed by Alexey Proskuryakov and Sam Weinig. * Misc/WebKitLogging.m: If there's no log level string, leave the channel state alone. 2013-01-29 Sheriff Bot Unreviewed, rolling out r140983. http://trac.webkit.org/changeset/140983 https://bugs.webkit.org/show_bug.cgi?id=108277 Unfortunately, this API has one last client (Requested by abarth on #webkit). * Configurations/FeatureDefines.xcconfig: 2012-11-28 Jer Noble Allow clients to ask for the WebView/WKView placeholder view when in full screen mode. https://bugs.webkit.org/show_bug.cgi?id=103558 Reviewed by Benjamin Poulain. Clients may want to behave differently when their WebView/WKView has been swapped out by a placeholder view when in full screen mode. Add a simple accessor for the existing placeholder view to WebFullScreenController and WebView. * WebView/WebFullScreenController.h: * WebView/WebFullScreenController.mm: (-[WebFullScreenController webViewPlaceholder]): Added simple accessor. * WebView/WebView.mm: (-[WebView fullScreenPlaceholderView]): Added simple accessor. 2013-01-28 Pratik Solanki PLATFORM(IOS) should come before __MAC_OS_X_VERSION_MIN_REQUIRED https://bugs.webkit.org/show_bug.cgi?id=108101 Reviewed by Benjamin Poulain. Since iOS does not define __MAC_OS_X_VERSION_MIN_REQUIRED, any usage of __MAC_OS_X_VERSION_MIN_REQUIRED should be after a PLATFORM(IOS) check. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2013-01-28 Joseph Pecoraro [Mac] Update PageVisibilityState when WebView is hidden / visible https://bugs.webkit.org/show_bug.cgi?id=107509 Reviewed by Sam Weinig. * WebView/WebView.mm: * WebView/WebViewPrivate.h: (-[WebView _commonInitializationWithFrameName:groupName:]): Set the initial visibility of the page. (-[WebView addWindowObserversForWindow:]): (-[WebView removeWindowObservers]): (-[WebView _isViewVisible]): (-[WebView _updateVisibilityState]): (-[WebView viewDidMoveToWindow]): (-[WebView _windowVisibilityChanged:]): Update visibility state in the same ways WK2 does. This involves listening for some new NSWindow delegates. 2013-01-28 Joseph Pecoraro Improve PageVisibility API with enums https://bugs.webkit.org/show_bug.cgi?id=107364 Reviewed by Sam Weinig. * WebView/WebView.mm: * WebView/WebViewPrivate.h: (core): (-[WebView _setVisibilityState:isInitialState:]): Switch the private API form int to a WebPageVisibilityState enum. 2013-01-28 Adam Barth Remove webkitNotifications.createHTMLNotification https://bugs.webkit.org/show_bug.cgi?id=107598 Reviewed by Benjamin Poulain. * Configurations/FeatureDefines.xcconfig: 2013-01-25 Andy Estes Wrap content filtering code in an object https://bugs.webkit.org/show_bug.cgi?id=107914 Reviewed by Alexey Proskuryakov. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Updated to reflect changes in WKSI. 2013-01-24 Dan Bernstein WebNavigationData does not distinguish between an empty title and a missing title https://bugs.webkit.org/show_bug.cgi?id=107917 Reviewed by Andy Estes. * WebCoreSupport/WebFrameLoaderClient.mm: (nilOrNSString): Added this helper function. (WebFrameLoaderClient::updateGlobalHistory): Initialize the WebNavigationData with a nil title, rather than the empty string, if the document does not have a title. 2013-01-24 Mark Hahnenberg Objective-C API: Rename JSValue.h/APIJSValue.h to JSCJSValue.h/JSValue.h https://bugs.webkit.org/show_bug.cgi?id=107327 Reviewed by Filip Pizlo. We're renaming these two files, so we have to replace the names everywhere. * DOM/WebDOMOperations.mm: * ForwardingHeaders/runtime/JSCJSValue.h: Copied from Source/WebKit/mac/ForwardingHeaders/runtime/JSValue.h. * ForwardingHeaders/runtime/JSValue.h: Removed. * WebView/WebFrame.mm: * WebView/WebView.mm: 2013-01-22 Anders Carlsson Use a platforom strategy for local storage https://bugs.webkit.org/show_bug.cgi?id=107600 Reviewed by Andreas Kling. Update for new storage strategy. * WebCoreSupport/WebPlatformStrategies.h: (WebPlatformStrategies): * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::createStorageStrategy): 2013-01-21 Kentaro Hara Implement UIEvent constructor https://bugs.webkit.org/show_bug.cgi?id=107430 Reviewed by Adam Barth. Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm UIEvent constructor is implemented under a DOM4_EVENTS_CONSTRUCTOR flag, which is enabled on Safari and Chromium for now. * Configurations/FeatureDefines.xcconfig: 2013-01-22 Joseph Pecoraro [Mac] Enable Page Visibility (PAGE_VISIBILITY_API) https://bugs.webkit.org/show_bug.cgi?id=107230 Reviewed by David Kilzer. * Configurations/FeatureDefines.xcconfig: 2013-01-22 Tim Horton PDFPlugin: Build PDFPlugin everywhere, enable at runtime https://bugs.webkit.org/show_bug.cgi?id=107117 Reviewed by Alexey Proskuryakov. Since PDFLayerController SPI is all forward-declared, the plugin should build on all Mac platforms, and can be enabled at runtime. * Configurations/FeatureDefines.xcconfig: 2013-01-21 Dirk Schulze Add build flag for Canvas's Path object (disabled by default) https://bugs.webkit.org/show_bug.cgi?id=107473 Reviewed by Dean Jackson. * Configurations/FeatureDefines.xcconfig: 2013-01-17 Andy Estes Add a USE() macro for content filtering code https://bugs.webkit.org/show_bug.cgi?id=107098 Reviewed by Mark Rowe. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Use USE(CONTENT_FILTERING). 2013-01-19 Philip Rogers Merge SVGStylable into SVGStyledElement https://bugs.webkit.org/show_bug.cgi?id=106877 SVG2 changes element inheritance so all SVGElements are stylable. As a first-step towards a cleaner class hierarchy, this patch moves SVGStylable into SVGStyledElement. Reviewed by Dirk Schulze. * MigrateHeaders.make: 2013-01-18 Seokju Kwon Add explicit keyword to constructors in platform-specific InspectorClient https://bugs.webkit.org/show_bug.cgi?id=107255 Reviewed by Kentaro Hara. Add explicit keyword to constructors that take one argument in platform-specific implementation of InspectorClient. * WebCoreSupport/WebInspectorClient.h: (WebInspectorClient): 2013-01-15 Jer Noble Add a Setting to disable QTKit media engine. https://bugs.webkit.org/show_bug.cgi?id=106972 Reviewed by Eric Carlson. Add WebKit API to set QTKit enabled setting from user defaults. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Set WebCore settings based on user defaults. (-[WebPreferences setQTKitEnabled:]): Pass through to WebCore. (-[WebPreferences isQTKitEnabled]): Ditto. * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Synchronize WebKit/WebCore settings. 2013-01-15 Enrica Casucci Add a new set of WebKit2 APIs for text search and search results management. https://bugs.webkit.org/show_bug.cgi?id=106834. Reviewed by Simon Fraser. Adding new API to perform text search in WebKit2 without using the stock UI. The new interface provides all the information necessary to write a custom UI for search. Added new TextWebKitAPI test. * WebView/WebHTMLView.mm: (-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]): Modified to reflect the changes to Editor::countMatchesForText interface. 2013-01-10 Zan Dobersek Remove the ENABLE_ANIMATION_API feature define occurences https://bugs.webkit.org/show_bug.cgi?id=106544 Reviewed by Simon Fraser. The Animation API code was removed in r137243. The ENABLE_ANIMATION_API feature define handling still lingers in various build systems and configurations but is of no use, so it should be removed. * Configurations/FeatureDefines.xcconfig: 2013-01-08 Mark Lam Removed the need for the ProposedDatabase mechanism. https://bugs.webkit.org/show_bug.cgi?id=106292. Reviewed by Sam Weinig. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::exceededDatabaseQuota): 2013-01-07 Dan Bernstein [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy https://bugs.webkit.org/show_bug.cgi?id=106261 Reviewed by Simon Fraser. Test: TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm. Added -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::detachedFromParent2): Added a call to the new frame load delegate method. * WebView/WebDelegateImplementationCaching.h: (WebFrameLoadDelegateImplementationCache): Added the new method to the cache. * WebView/WebFrameLoadDelegatePrivate.h: Declared the new delegate method. * WebView/WebView.mm: (-[WebView _cacheFrameLoadDelegateImplementations]): Added the new method to the cache. 2013-01-07 Mike West Make the IFRAME_SEAMLESS flag runtime-enabled. https://bugs.webkit.org/show_bug.cgi?id=106213 Reviewed by Ojan Vafai. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (-[WebPreferences seamlessIFramesEnabled]): (-[WebPreferences setSeamlessIFramesEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Add a seamless IFrame preference to WebPreferences, and use it to toggle the runtime state of the feature as appropriate. 2013-01-04 Adam Klein Remove ENABLE_MUTATION_OBSERVERS #define https://bugs.webkit.org/show_bug.cgi?id=105459 Reviewed by Ryosuke Niwa. * Configurations/FeatureDefines.xcconfig: 2013-01-01 Dan Bernstein Update copyright strings Reviewed by Sam Weinig. * Info.plist: 2012-12-29 Adam Roben Web Inspector: Mac WK1 Inspector can't save/load timeline data https://bugs.webkit.org/show_bug.cgi?id=105547 Reviewed by Pavel Feldman. * WebCoreSupport/WebInspectorClient.h: Declared new overrides and member variables necessary for save support. * WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::save): (WebInspectorFrontendClient::append): Implemented these to make saving timeline data work. (It seems to me the InspectorFrontendClient API could be cleaned up a bit. I had to look at Chromium source code to determine that I needed to call back into the InspectorFrontendAPI JS object after saving/appending, and that I needed to keep a map of passed URLs -> chosen URLs.) (-[WebInspectorWindowController window:willPositionSheet:usingRect:]): Tweaked the position of the sheet so that open/save sheets look a little bette.r (-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]): Implemented to make loading timeline data work. 2012-12-28 Mark Rowe Move logic for extracting the OS X marketing version in to WebCore / Reviewed by Dan Bernstein. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Remove the code related to the WKSI symbol. * WebView/WebView.mm: (systemMarketingVersionForUserAgentString): Call the WebCore function instead of the WKSI function. (+[WebView _standardUserAgentWithApplicationName:]): Retain the result now that our helper doesn't do that for us. 2012-12-27 Sam Weinig Attempt to fix the tests. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): 2012-12-23 Alexey Proskuryakov Network process should respect cookie accept policy https://bugs.webkit.org/show_bug.cgi?id=105684 Reviewed by Sam Weinig. * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: CookiesStrategy no longer has notifyCookiesChanged(). 2012-12-22 Alexey Proskuryakov Add a separate class for networking related storage https://bugs.webkit.org/show_bug.cgi?id=105676 Reviewed by Sam Weinig. * WebCoreSupport/WebFrameLoaderClient.mm: Updated for ResourceHandle include changes. * WebCoreSupport/WebFrameNetworkingContext.h: * WebCoreSupport/WebFrameNetworkingContext.mm: This class is now simpler, with more session tracking being in WebCore now. * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::cookiesForDOM): (WebPlatformStrategies::setCookiesFromDOM): (WebPlatformStrategies::cookiesEnabled): (WebPlatformStrategies::cookieRequestHeaderFieldValue): (WebPlatformStrategies::getRawCookies): (WebPlatformStrategies::deleteCookie): We no longer need a function for default cookie storage! Other cookie functions now take a session. * WebView/WebPreferences.mm: (+[WebPreferences _switchNetworkLoaderToNewTestingSession]): Initialize WCSI before calling a WebCore that uses it. (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]): Use NetworkStorageSession for session tracking. * WebView/WebView.mm: (-[WebView _cachedResponseForURL:]): Updated for networking context now returning a class for session. 2012-12-20 Ilya Tikhonovsky Unreviewed build fix for chromium mac after r138206. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2012-12-19 Alexey Proskuryakov [WK2 NetworkProcess] Client doesn't receive SSL certificates https://bugs.webkit.org/show_bug.cgi?id=105467 Reviewed by Brady Eidson. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize a WKSI function we've been missing. 2012-12-19 Alexis Menard Implement CSS parsing for CSS transitions unprefixed. https://bugs.webkit.org/show_bug.cgi?id=104804 Reviewed by Dean Jackson. Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to cover the work of unprefixing Transforms, Animations and Transitions. It will let the possibility of each ports to turn it off in their release branches until we're confident that these CSS properties are ready to be unprefixed. * Configurations/FeatureDefines.xcconfig: 2012-12-18 Alexey Proskuryakov Remove unnecessary functions from CookiesStrategy https://bugs.webkit.org/show_bug.cgi?id=105369 Reviewed by Brady Eidson. * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: 2012-12-18 Alice Liu Add SPI to WebKit1 WebFrame for hit testing https://bugs.webkit.org/show_bug.cgi?id=105106 Reviewed by Dan Bernstein. * WebView/WebFrame.mm: (-[WebFrame elementAtPoint:]): Added. Takes an NSPoint to feed to the WebCore::Frame for hit-testing. Creates a WebElementDictionary from that WebCore::HitTestResult, and returns the element dictionary. * WebView/WebFramePrivate.h: 2012-12-18 Alice Liu Add SPI to WebKit1 WebFrame for node conversion to JSValueRef https://bugs.webkit.org/show_bug.cgi?id=105262 Reviewed by Anders Carlsson. * WebView/WebFrame.mm: (-[WebFrame jsWrapper:forWorld:]): Added. Takes a DOMNode and WebScriptWorld and provides a JSValueRef for the WebCore::Node in that particular WebScriptWorld. * WebView/WebFramePrivate.h: 2012-12-18 Beth Dakin https://bugs.webkit.org/show_bug.cgi?id=102579 [mac] Enable scaled cursors Reviewed by Dean Jackson. * Configurations/FeatureDefines.xcconfig: 2012-12-16 Levi Weintraub Push pixel snapping logic into TransformState https://bugs.webkit.org/show_bug.cgi?id=101779 Reviewed by Simon Fraser. * WebView/WebFullScreenController.mm: (screenRectOfContents): Removed SnapOffsetForTransforms as it's no longer needed. 2012-12-15 Anders Carlsson Rename FrameLoaderClient::download to convertMainResourceLoadToDownload https://bugs.webkit.org/show_bug.cgi?id=105122 Reviewed by Andreas Kling. Update for WebCore changes. * WebCoreSupport/WebFrameLoaderClient.h: (WebFrameLoaderClient): * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::convertMainResourceLoadToDownload): 2012-12-15 Mark Lam Re-landing patch for "Introducing the DatabaseStrategy and database servers". https://bugs.webkit.org/show_bug.cgi?id=104934. Not reviewed. Merged from r137767. Previously reviewed by Sam Weinig. * WebCoreSupport/WebPlatformStrategies.h: (WebPlatformStrategies): * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::createDatabaseStrategy): 2012-12-14 Mark Lam The WebView should initialize the platform strategies before initializing other sub-systems. https://bugs.webkit.org/show_bug.cgi?id=105083. Reviewed by Alexey Proskuryakov. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): 2012-12-14 Sheriff Bot Unreviewed, rolling out r137767. http://trac.webkit.org/changeset/137767 https://bugs.webkit.org/show_bug.cgi?id=105062 Broke Mac builds. (Requested by mlam on #webkit). * WebCoreSupport/WebPlatformStrategies.h: (WebPlatformStrategies): * WebCoreSupport/WebPlatformStrategies.mm: 2012-12-14 Mark Lam Introducing the DatabaseStrategy and database servers. https://bugs.webkit.org/show_bug.cgi?id=104934. Reviewed by Sam Weinig. The database server is currently a placeholder that does nothing. * WebCoreSupport/WebPlatformStrategies.h: (WebPlatformStrategies): * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::createDatabaseStrategy): 2012-12-13 Alexey Proskuryakov Per-Tab WebProcess: DOM cookie access functions should respect private browsing https://bugs.webkit.org/show_bug.cgi?id=104691 Reviewed by Sam Weinig. * WebCoreSupport/WebFrameNetworkingContext.h: * WebCoreSupport/WebFrameNetworkingContext.mm: (WebFrameNetworkingContext::inPrivateBrowsingMode): (WebFrameNetworkingContext::storageSession): Implemented inPrivateBrowsingMode(). 2012-12-12 Mark Lam Encapsulate externally used webdatabase APIs in DatabaseManager. https://bugs.webkit.org/show_bug.cgi?id=104741. Reviewed by Sam Weinig. Use DatabaseManager instead of accessing DatabaseTracker, AbstractDatabase, and DatabaseContext directly. This is to prepare for upcoming webkit2 refactoring. * Storage/WebDatabaseManager.mm: (-[WebDatabaseManager origins]): (-[WebDatabaseManager databasesWithOrigin:]): (-[WebDatabaseManager detailsForDatabase:withOrigin:]): (-[WebDatabaseManager deleteAllDatabases]): (-[WebDatabaseManager deleteOrigin:]): (-[WebDatabaseManager deleteDatabase:withOrigin:]): (WebKitInitializeDatabasesIfNecessary): * Storage/WebDatabaseManagerClient.h: Copied from Source/WebKit/mac/Storage/WebDatabaseTrackerClient.h. (WebDatabaseManagerClient): * Storage/WebDatabaseManagerClient.mm: Copied from Source/WebKit/mac/Storage/WebDatabaseTrackerClient.mm. (WebDatabaseManagerClient::sharedWebDatabaseManagerClient): (WebDatabaseManagerClient::WebDatabaseManagerClient): (WebDatabaseManagerClient::~WebDatabaseManagerClient): (DidModifyOriginData::dispatchToMainThread): (DidModifyOriginData::DidModifyOriginData): (DidModifyOriginData): (WebDatabaseManagerClient::dispatchDidModifyOrigin): (WebDatabaseManagerClient::dispatchDidModifyDatabase): * Storage/WebDatabaseQuotaManager.mm: (-[WebDatabaseQuotaManager usage]): (-[WebDatabaseQuotaManager quota]): (-[WebDatabaseQuotaManager setQuota:]): * Storage/WebDatabaseTrackerClient.h: Removed. * Storage/WebDatabaseTrackerClient.mm: Removed. * WebCoreSupport/WebSecurityOrigin.mm: (-[WebSecurityOrigin usage]): (-[WebSecurityOrigin quota]): (-[WebSecurityOrigin setQuota:]): * WebKit.order: * WebView/WebFrame.mm: (-[WebFrame _cacheabilityDictionary]): * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2012-12-12 Alexey Proskuryakov Make LOG() work in WebProcess and NetworkProcess https://bugs.webkit.org/show_bug.cgi?id=104718 Reviewed by Tim Horton. * WebView/WebView.mm: Use WebCore/InitializeLogging.h to avoid conflicts between WebCore and WebKit versions of this file. 2012-12-11 Mike West Web Inspector: ConsoleTypes should not expose MessageType - it should be private to inspector. https://bugs.webkit.org/show_bug.cgi?id=66371 Reviewed by Pavel Feldman. Drops WebCore::MessageType from the addMessageToConsole method. * WebCoreSupport/WebChromeClient.h: (WebChromeClient): * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::addMessageToConsole): 2012-12-09 Antti Koivisto Factor node traversal into standalone functions https://bugs.webkit.org/show_bug.cgi?id=104507 Reviewed by Eric Seidel. * WebView/WebHTMLRepresentation.mm: (searchForLabelsBeforeElement): 2012-12-10 Alexis Menard [CSS3 Backgrounds and Borders] Remove CSS3_BACKGROUND feature flag. https://bugs.webkit.org/show_bug.cgi?id=104539 Reviewed by Antonio Gomes. As discussed on webkit-dev it is not needed to keep this feature flag as support for type is a small feature that is already implemented by three other UAs. It was useful while landing this feature as partial bits were landed one after one. * Configurations/FeatureDefines.xcconfig: 2012-12-06 Rick Byers CSS cursor property should support webkit-image-set https://bugs.webkit.org/show_bug.cgi?id=99493 Reviewed by Beth Dakin. Add ENABLE_MOUSE_CURSOR_SCALE - disabled by default. * Configurations/FeatureDefines.xcconfig: 2012-12-03 Yury Semikhatsky Unreviewed. Fix Mac compilation after r136448. * WebCoreSupport/WebChromeClient.mm: (stringForMessageType): 2012-12-03 Alexis Menard [Mac] Enable CSS3 background-position offset by default. https://bugs.webkit.org/show_bug.cgi?id=103905 Reviewed by Simon Fraser. Turn the flag on by default. * Configurations/FeatureDefines.xcconfig: 2012-12-02 Yongjun Zhang Need a method to close all idle localstorage databases immediately. https://bugs.webkit.org/show_bug.cgi?id=103469 Reviewed by David Kilzer. Add a new method to WebStorageManager that we can call to close all idle local storage databases. * Storage/WebStorageManager.mm: (+[WebStorageManager closeIdleLocalStorageDatabases]): * Storage/WebStorageManagerPrivate.h: 2012-11-30 Mihai Maerean [CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled https://bugs.webkit.org/show_bug.cgi?id=101192 Reviewed by Hajime Morita. Removed the CSS Regions flag in Settings and switched to using the new flag I have added in RuntimeEnabledFeatures. Tests: No new tests because there is no functional change. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2012-11-29 Rafael Weinstein [HTMLTemplateElement] Add feature flag https://bugs.webkit.org/show_bug.cgi?id=103694 Reviewed by Adam Barth. This flag will guard the implementation of the HTMLTemplateElement. http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html * Configurations/FeatureDefines.xcconfig: 2012-11-29 Alexey Proskuryakov [WK2] Forward cookie jar calls to NetworkProcess https://bugs.webkit.org/show_bug.cgi?id=103457 Reviewed by Darin Adler. * WebCoreSupport/WebPlatformStrategies.h: (WebPlatformStrategies): * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::cookiesForDOM): (WebPlatformStrategies::setCookiesFromDOM): (WebPlatformStrategies::cookiesEnabled): (WebPlatformStrategies::cookieRequestHeaderFieldValue): (WebPlatformStrategies::getRawCookies): (WebPlatformStrategies::deleteCookie): (WebPlatformStrategies::getHostnamesWithCookies): (WebPlatformStrategies::deleteCookiesForHostname): (WebPlatformStrategies::deleteAllCookies): (WebPlatformStrategies::getPluginInfo): (WebPlatformStrategies::bufferForType): WebKit1 strategy just uses PlatformCookieJar. 2012-11-28 Beth Dakin https://bugs.webkit.org/show_bug.cgi?id=102970 [WK1] REGRESSION (r129545): Main frame doesn't rubberband unless WebFrameLoadDelegate implements -webView:didFirstLayoutInFrame: Reviewed by Sam Weinig. We should always register for DidFirstLayout in WK1 since we do work at that time besides just calling the delegate function. * WebView/WebView.mm: (-[WebView _cacheFrameLoadDelegateImplementations]): 2012-11-27 Michael Saboff TextIterator unnecessarily converts 8 bit strings to 16 bits https://bugs.webkit.org/show_bug.cgi?id=103295 Reviewed by Brent Fulgham. Updated _stringForRange to use plainText() instead of removed plainTextToMallocAllocatedBuffer(). * WebView/WebFrame.mm: (-[WebFrame _stringForRange:]): 2012-11-27 James Simonsen Consolidate FrameLoader::load() into one function taking a FrameLoadRequest https://bugs.webkit.org/show_bug.cgi?id=102151 Reviewed by Adam Barth. * Plugins/WebPluginController.mm: * WebView/WebFrame.mm: (-[WebFrame loadRequest:]): (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): 2012-11-27 Pratik Solanki objc/objc-runtime.h does not exist on all PLATFORM(MAC) https://bugs.webkit.org/show_bug.cgi?id=101780 Reviewed by Brent Fulgham. Clean up header includes so we don't include objc/objc-runtime.h. * Carbon/HIWebView.mm: (UpdateCommandStatus): Use wtfObjcMsgSend template instead of objc_msgSend. * Plugins/WebNetscapePluginView.mm: * Plugins/WebPluginContainerCheck.mm: (-[WebPluginContainerCheck _continueWithPolicy:]): Use wtfObjcMsgSend template instead of objc_msgSend. * Plugins/WebPluginController.mm: * WebCoreSupport/WebCachedFramePlatformData.h: * WebCoreSupport/WebDeviceOrientationClient.mm: * WebView/WebDelegateImplementationCaching.mm: * WebView/WebHTMLView.mm: * WebView/WebPDFDocumentExtras.mm: * WebView/WebPolicyDelegate.mm: (-[WebPolicyDecisionListener _usePolicy:]): Use wtfObjcMsgSend template instead of objc_msgSend. * WebView/WebView.mm: 2012-11-27 Sheriff Bot Unreviewed, rolling out r135786. http://trac.webkit.org/changeset/135786 https://bugs.webkit.org/show_bug.cgi?id=103379 It made 3 plugin tests timeout on several platforms (Requested by Ossy on #webkit). * Plugins/WebPluginController.mm: * WebView/WebFrame.mm: (-[WebFrame loadRequest:]): (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): 2012-11-26 James Simonsen Consolidate FrameLoader::load() into one function taking a FrameLoadRequest https://bugs.webkit.org/show_bug.cgi?id=102151 Reviewed by Adam Barth. * Plugins/WebPluginController.mm: * WebView/WebFrame.mm: (-[WebFrame loadRequest:]): (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): 2012-11-23 Alexis Menard [CSS3 Backgrounds and Borders] Implement new CSS3 background-position parsing. https://bugs.webkit.org/show_bug.cgi?id=102104 Reviewed by Julien Chaffraix. Protect the new feature behind a feature flag. * Configurations/FeatureDefines.xcconfig: 2012-11-21 Allan Sandfeld Jensen Disambiguate innerNodeFramePoint and mainFramePoint https://bugs.webkit.org/show_bug.cgi?id=98139 Reviewed by Julien Chaffraix. Switch to using HitTestResult::innerNodeFrame and HitTestResult::innerNodeFramePoint. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::showContextMenu): 2012-11-20 Sheriff Bot Unreviewed, rolling out r135295. http://trac.webkit.org/changeset/135295 https://bugs.webkit.org/show_bug.cgi?id=102834 This patch causes assertion to some layout tests on chromium (Requested by jianli on #webkit). * Plugins/WebPluginController.mm: * WebView/WebFrame.mm: (-[WebFrame loadRequest:]): (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): 2012-11-20 James Simonsen Consolidate FrameLoader::load() into one function taking a FrameLoadRequest https://bugs.webkit.org/show_bug.cgi?id=102151 Reviewed by Adam Barth. * Plugins/WebPluginController.mm: * WebView/WebFrame.mm: (-[WebFrame loadRequest:]): (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): 2012-11-19 Kihong Kwon Add PROXIMITY_EVENTS feature https://bugs.webkit.org/show_bug.cgi?id=102658 Reviewed by Kentaro Hara. Add PROXIMITY_EVENTS feature to xcode project for WebKit. * Configurations/FeatureDefines.xcconfig: 2012-11-16 Tony Chang Remove ENABLE_CSS_HIERARCHIES since it's no longer in use https://bugs.webkit.org/show_bug.cgi?id=102554 Reviewed by Andreas Kling. As mentioned in https://bugs.webkit.org/show_bug.cgi?id=79939#c41 , we're going to revist this feature once additional vendor support is achieved. * Configurations/FeatureDefines.xcconfig: 2012-11-15 Alexey Proskuryakov Private Browsing is a per-page setting that sets a global value https://bugs.webkit.org/show_bug.cgi?id=67870 Reviewed by Sam Weinig. * WebCoreSupport/WebFrameNetworkingContext.h: * WebCoreSupport/WebFrameNetworkingContext.mm: Moved functions for managing global sessions from WebCore. * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::defaultCookieStorage): Added. Uses WebFrameNetworkingContext to reach the storage. * WebView/WebPreferences.mm: (+[WebPreferences _switchNetworkLoaderToNewTestingSession]): Ditto. (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]): Ditto. * WebView/WebPreferencesPrivate.h: Added a comment explaining that two functions are not generic enough for use outside DRT (one of them had "testing" in name, but another did not). * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Create a global private browsing session when the first view with private browsing is created, delete it when any window with it disabled is created (since this comes from preferences, it applies to all views equally, even though we are dealing with a single one here). (-[WebView _cachedResponseForURL:]): Use main frame's networking context instead of a global one. 2012-11-13 Timothy Hatcher Adjust the Web Inspector window title frame if needed to prevent it from intersecting the dock button. https://bugs.webkit.org/show_bug.cgi?id=102073 Reviewed by Joseph Pecoraro. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindow _customTitleFrame]): Added. Adjust the title frame. 2012-11-12 Simon Fraser Build fix after r134346 and 134347. Use frameView.isFlipped, not frameView.flipped in the assertion. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController window]): 2012-11-12 Timothy Hatcher Add a dock button to the top right corner of the Web Inspector window (similar to the full screen button). https://bugs.webkit.org/show_bug.cgi?id=102025 Reviewed by Joseph Pecoraro. * Resources/Dock.pdf: Added. * WebCoreSupport/WebInspectorClient.h: * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindow _cursorForResizeDirection:]): Added. (WebInspectorClient::didResizeMainFrame): Call attachAvailabilityChanged instead. (WebInspectorFrontendClient::attachAvailabilityChanged): Added. (-[WebInspectorWindowController window]): Create the dock button and add it. (-[WebInspectorWindowController attachWindow:]): Added. (-[WebInspectorWindowController attach]): Call setAttachedWindow. (-[WebInspectorWindowController detach]): Ditto. (-[WebInspectorWindowController setDockingUnavailable:]): Added. Update hidden state of the dock button. 2012-11-08 Timothy Hatcher Always use a textured window for the Web Inspector. https://bugs.webkit.org/show_bug.cgi?id=101693 Reviewed by Joseph Pecoraro. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController window]): Removed the conditional for a textured window. 2012-11-08 Roger Fong Null check URL key entries into WebHistory hash table. https://bugs.webkit.org/show_bug.cgi?id=101664 Reviewed by Brady Eidson. Sometimes the _entriesByURL hash table used to keep track of web history is erroneously passed in null key entries, which causes an exception to fire. This prevents the desired page navigation from taking effect. This is a workaround for the problem. Ideally we would figure out where the null values for the key are coming from but for now we'll just set it to "" to prevent the exception from being thrown so that navigation can continue as expected. * History/WebHistory.mm: (-[WebHistoryPrivate visitedURL:withTitle:increaseVisitCount:]): 2012-11-07 Andreas Kling Remove build-webkit dependency on Java SDK for Apple Mac WebKit. Reviewed by Anders Carlsson. * Plugins/WebJavaPlugIn.h: Removed. 2012-11-06 Adam Barth Unreviewed attempt to fix the chromium-mac build. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2012-11-06 Anders Carlsson Update Java related WKSI function names https://bugs.webkit.org/show_bug.cgi?id=101414 Reviewed by Sam Weinig. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::unavailablePluginButtonClicked): * WebCoreSupport/WebFrameLoaderClient.mm: (isPlugInInactive): 2012-11-06 Alexey Proskuryakov Clean up which storage cookie jar functions use https://bugs.webkit.org/show_bug.cgi?id=101395 Reviewed by Brady Eidson. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Updated for two new functions. 2012-11-06 Andrey Lushnikov Added console.clear() method Web Inspector: add console.clear() https://bugs.webkit.org/show_bug.cgi?id=101021 Reviewed by Vsevolod Vlasov. * WebCoreSupport/WebChromeClient.mm: (stringForMessageType): Added ClearMessageType case to switch 2012-11-05 Alexey Proskuryakov Get rid of setCookieStoragePrivateBrowsingEnabled. https://bugs.webkit.org/show_bug.cgi?id=101247 Reviewed by Brady Eidson. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): We no longer have this function. 2012-11-03 Alexey Proskuryakov Get rid of USE(CFURLSTORAGESESSIONS) https://bugs.webkit.org/show_bug.cgi?id=101131 Reviewed by Sam Weinig. * WebView/WebPreferences.mm: (+[WebPreferences _switchNetworkLoaderToNewTestingSession]): (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]): * WebView/WebView.mm: (-[WebView _cachedResponseForURL:]): 2012-11-02 Anders Carlsson Don't instantiate the Java plug-in if it's inactive https://bugs.webkit.org/show_bug.cgi?id=101102 Reviewed by Andreas Kling. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldUnavailablePluginMessageBeButton): The RenderEmbeddedObject::PluginInactive reason should always result in a button being shown. (WebChromeClient::unavailablePluginButtonClicked): If the Java plug-in is inactive, call WKJLReportWebComponentsUsed() to reactivate the plug-in and then reload the page. * WebCoreSupport/WebFrameLoaderClient.mm: (isOracleJavaPlugIn): (isPlugInInactive): Helper functions. (WebFrameLoaderClient::createPlugin): If the plug-in is inactive, set the appropriate unavailability reason on the renderer. 2012-11-02 Simon Fraser Enable SUBPIXEL_LAYOUT on Mac https://bugs.webkit.org/show_bug.cgi?id=101076 Reviewed by Dave Hyatt. Define ENABLE_SUBPIXEL_LAYOUT and include it in FEATURE_DEFINES. * Configurations/FeatureDefines.xcconfig: 2012-11-02 Adam Barth ENABLE(UNDO_MANAGER) is disabled everywhere and is not under active development https://bugs.webkit.org/show_bug.cgi?id=100711 Reviewed by Eric Seidel. * Configurations/FeatureDefines.xcconfig: 2012-11-01 Adam Roben [WK1] Fixed-position elements jiggle up and down slightly during scrolling on a Retina display https://bugs.webkit.org/show_bug.cgi?id=100957 Reviewed by Simon Fraser. WebCore doesn't yet support subpixel scrolling. WebKit2 forces scrolling to always be integral. Now WebKit1 forces this as well. I'm not sure how to write a test for this. * WebView/WebDynamicScrollBarsView.mm: (shouldRoundScrollOrigin): Returns YES if there are any position:fixed or position:sticky elements in the page. (-[WebDynamicScrollBarsView scrollClipView:toPoint:]): Round the scroll origin to the nearest pixel if needed. 2012-10-31 Anders Carlsson Fix build. . Reviewed by Sam Weinig. * Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel loadNib]): 2012-10-30 Joseph Pecoraro [Mac] Sync up FeatureDefine Configuration Files https://bugs.webkit.org/show_bug.cgi?id=100171 Reviewed by David Kilzer. Follow up to better coordinate with iOS feature defines. Make: - ENABLE_FILTERS always on - ENABLE_INPUT_* iphonesimulator values point to the iphoneos values * Configurations/FeatureDefines.xcconfig: 2012-10-30 Joseph Pecoraro [Mac] Sync up FeatureDefine Configuration Files https://bugs.webkit.org/show_bug.cgi?id=100171 Reviewed by David Kilzer. Ensure an identical FeatureDefine files across all projects. Changes: - ENABLE_CSS_BOX_DECORATION_BREAK should be in all - ENABLE_PDFKIT_PLUGIN should be in all - ENABLE_RESOLUTION_MEDIA_QUERY should be in all - ENABLE_ENCRYPTED_MEDIA should be in all - ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING with corrected value - Some alphabetical ordering cleanup * Configurations/FeatureDefines.xcconfig: 2012-10-29 Anders Carlsson Build WebKit as C++11 on Mac https://bugs.webkit.org/show_bug.cgi?id=100720 Reviewed by Daniel Bates. * Configurations/Base.xcconfig: Add CLANG_CXX_LANGUAGE_STANDARD=gnu++0x. * History/WebBackForwardList.mm: (-[WebBackForwardList description]): * History/WebHistoryItem.mm: (-[WebHistoryItem description]): Add static_casts to prevent implicit type conversions in non-constant initializer lists. 2012-10-28 Mark Rowe Simplify Xcode configuration settings that used to vary between OS versions. Reviewed by Dan Bernstein. * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: * Configurations/WebKit.xcconfig: 2012-10-28 Mark Rowe Remove references to unsupported OS and Xcode versions. Reviewed by Anders Carlsson. * Configurations/Base.xcconfig: * Configurations/CompilerVersion.xcconfig: Removed. * Configurations/DebugRelease.xcconfig: * Configurations/Version.xcconfig: 2012-10-29 Enrica Casucci Add ENABLE_USERSELECT_ALL feature flag. https://bugs.webkit.org/show_bug.cgi?id=100559 Reviewed by Eric Seidel. * Configurations/FeatureDefines.xcconfig: 2012-10-27 Alexey Proskuryakov All tests crash in WebKit1 mode https://bugs.webkit.org/show_bug.cgi?id=100602 Reviewed by Sam Weinig. * WebView/WebView.mm: (+[WebView _setLoadResourcesSerially:]): Resource load scheduler is created via a strategy, so strategies need to be initialized before using it. 2012-10-27 Dan Bernstein REAL_PLATFORM_NAME build setting is no longer needed https://bugs.webkit.org/show_bug.cgi?id=100587 Reviewed by Mark Rowe. Removed the definition of REAL_PLATFORM_NAME and replaced references to it with references to PLATFORM_NAME. * Configurations/Base.xcconfig: * Configurations/CompilerVersion.xcconfig: * Configurations/DebugRelease.xcconfig: * Configurations/FeatureDefines.xcconfig: * Configurations/Version.xcconfig: * Configurations/WebKit.xcconfig: 2012-10-26 Thiago Marcos P. Santos Add feature flags for CSS Device Adaptation https://bugs.webkit.org/show_bug.cgi?id=95960 Reviewed by Kenneth Rohde Christiansen. * Configurations/FeatureDefines.xcconfig: 2012-10-25 Dominik Röttsches Conditionalize XHR timeout support https://bugs.webkit.org/show_bug.cgi?id=100356 Reviewed by Adam Barth. Adding XHR_TIMEOUT feature to conditionalize this on ports without network backend support. Defaults to ON on Mac since the Mac NSUrlConnection based backend has setTimeoutInterval support. * Configurations/FeatureDefines.xcconfig: 2012-10-24 Timothy Hatcher Fix a crash seen during the Inspector tests on the WebKit1 bots. Reviewed by Filip Pizlo. * WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::bringToFront): Use the window from the WebView since m_windowController's window is not the same when the Inspector is docked. 2012-10-24 Brady Eidson Add a strategy for loader customization. https://bugs.webkit.org/show_bug.cgi?id=100278 Reviewed by Alexey Proskuryakov. * WebCoreSupport/WebPlatformStrategies.h: (WebPlatformStrategies): * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::createLoaderStrategy): 2012-10-24 Timothy Hatcher Make the Inspector WKView/WebView become the first responder when bringToFront is called. https://bugs.webkit.org/show_bug.cgi?id=100209 Reviewed by Joseph Pecoraro. * WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::bringToFront): Make the Inspector WebView become the first responder. 2012-10-23 Alexey Proskuryakov Add a strategy for shared workers https://bugs.webkit.org/show_bug.cgi?id=100165 Reviewed by Brady Eidson. * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::createPasteboardStrategy): (WebPlatformStrategies::createSharedWorkerStrategy): (WebPlatformStrategies::createVisitedLinkStrategy): 2012-10-24 Eric Carlson Allow ports to override text track rendering style https://bugs.webkit.org/show_bug.cgi?id=97800 Reviewed by Maciej Stachowiak. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize new WKSI function pointers. 2012-10-23 Dan Bernstein WebKit/mac part of [mac] Kerning and ligatures are not enabled by default https://bugs.webkit.org/show_bug.cgi?id=100188 Reviewed by Sam Weinig. * WebView/WebView.mm: (+[WebView initialize]): Added a local variable to hold the standard user defaults. Added code to register a value of YES for the WebKitKerningAndLigaturesEnabledByDefault user default. Changed to refer to that default key by name. 2012-10-23 Kenneth Rohde Christiansen Add support for resolution media query https://bugs.webkit.org/show_bug.cgi?id=99077 Reviewed by Antti Koivisto. Add support for the RESOLUTION_MEDIA_QUERY feature flag. * Configurations/FeatureDefines.xcconfig: 2012-10-21 Andreas Kling Remove Page::javaScriptURLsAreAllowed setting. Reviewed by Anders Carlsson. * WebKit.order: * WebView/WebView.mm: * WebView/WebViewPrivate.h: 2012-10-19 Dongwoo Joshua Im Rename ENABLE_CSS3_TEXT_DECORATION to ENABLE_CSS3_TEXT https://bugs.webkit.org/show_bug.cgi?id=99804 Reviewed by Julien Chaffraix. CSS3 text related properties will be implemented under this flag, including text decoration, text-align-last, and text-justify. * Configurations/FeatureDefines.xcconfig: 2012-10-18 Pablo Flouret Implement css3-conditional's @supports rule https://bugs.webkit.org/show_bug.cgi?id=86146 Reviewed by Antti Koivisto. * Configurations/FeatureDefines.xcconfig: Add an ENABLE_CSS3_CONDITIONAL_RULES flag. 2012-10-17 Joseph Pecoraro [Mac] Uninitialized Members in WebDataSourcePrivate https://bugs.webkit.org/show_bug.cgi?id=99617 Reviewed by David Kilzer. Initialize BOOL member variables. * WebView/WebDataSource.mm: (WebDataSourcePrivate::WebDataSourcePrivate): 2012-10-17 Mark Rowe Fix the build with a newer version of clang. Reviewed by Dan Bernstein. Some of the methods in WebCoreStatistics appear to have been added by someone not familiar with Objective-C. While it's technically valid to have empty components in a selector, it's rarely done and is not consistent with our style guidelines. In this particular case it's also done in such a manner that it's ambiguous and therefore generates a warning in newer versions of the compiler. Fixes . * Misc/WebCoreStatistics.h: Remove unused methods and rename the two poorly-named methods that remain. * Misc/WebCoreStatistics.mm: Ditto. (-[WebFrame numberOfPagesWithPageWidth:pageHeight:]): (-[WebFrame printToCGContext:pageWidth:pageHeight:]): 2012-10-16 Jian Li Rename feature define ENABLE_WIDGET_REGION to ENABLE_DRAGGBALE_REGION https://bugs.webkit.org/show_bug.cgi?id=98975 Reviewed by Adam Barth. Renaming is needed to better match with the draggable region code. * Configurations/FeatureDefines.xcconfig: 2012-10-15 Dan Bernstein WebKit/mac part of Font’s fast code path doesn’t support kerning and ligatures https://bugs.webkit.org/show_bug.cgi?id=99113 Reviewed by Tim Horton. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Added wkCTFontTransformGlyphs. 2012-10-15 David Kilzer Move framework and library linking into WebKit.xcconfig Reviewed by Mark Rowe. * Configurations/WebKit.xcconfig: Move frameworks and libraries link flags to OTHER_LDFLAGS so that they work for iOS and OS X. 2012-10-14 Jon Lee Allow notification origin permission request when no js callback is provided https://bugs.webkit.org/show_bug.cgi?id=63615 Reviewed by Sam Weinig. Introduce a boolean to determine whether the request was using the legacy or standard API. This way, we do not fall through to calling the standard API's callback if the legacy API's callback is null. * WebCoreSupport/WebNotificationClient.mm: (WebCore): (-[WebNotificationPolicyListener initWithVoidCallback:]): (-[WebNotificationPolicyListener allow]): (-[WebNotificationPolicyListener deny]): 2012-10-14 Sam Weinig Make UserScript and UserStyleSheet value objects that are copyable https://bugs.webkit.org/show_bug.cgi?id=99275 Reviewed by Tim Horton. * WebView/WebView.mm: (-[WebView _injectMailQuirksScript]): (-[WebView _injectOutlookQuirksScript]): Update for new PageGroup function signatures. 2012-10-10 Brady Eidson Switch ResourceLoader::resourceData() from SharedBuffer to ResourceBuffer https://bugs.webkit.org/show_bug.cgi?id=98976 Reviewed by Anders Carlsson. * WebView/WebDataSource.mm: (-[WebDataSource data]): 2012-10-10 Jer Noble Disallow full screen mode keyboard access by default. https://bugs.webkit.org/show_bug.cgi?id=98971 Reviewed by Sam Weinig. Only support full screen if keyboard access is not requested. * WebView/WebView.mm: (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]): 2012-10-10 Jon Lee [WK2] Activate plugins when user clicks on snapshot https://bugs.webkit.org/show_bug.cgi?id=98328 Reviewed by Brady Eidson. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::recreatePlugin): Stub implementation of recreatePlugin(). 2012-10-10 Brady Eidson Switch CachedResource over from SharedBuffer to a new ResourceBuffer https://bugs.webkit.org/show_bug.cgi?id=98541 Reviewed by Anders Carlsson. * WebView/WebHTMLView.mm: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): 2012-10-10 Simon Fraser Store a visible rect in GraphicsLayers, and optionally dump it in layerTreeAsText https://bugs.webkit.org/show_bug.cgi?id=98839 Reviewed by Sam Weinig. To replace CATiledLayer with TileCaches, we need to be able to compute the visible part of a GraphicsLayer, in order to limit the extent of TileCache tiles. Reuse the existing code in GraphicsLayerCA for this, but store the computed rect in m_visibleRect. Add a flag to layerTreeAsText() so that tests can optionally include this visible rect in layer tree dumps. This output will be platform-specific, so we don't want to do it unconditionally. * WebView/WebFrame.mm: (-[WebFrame _layerTreeAsText]): 2012-10-09 Jian Li Update the CSS property used to support draggable regions. https://bugs.webkit.org/show_bug.cgi?id=97156 Reviewed by Adam Barth. The CSS property to support draggable regions, guarded under WIDGET_REGION is now disabled from Mac WebKit, in order not to cause confusion with DASHBOARD_SUPPORT feature. Also update the code to use the new name annotatedRegions to work for both features. * Configurations/FeatureDefines.xcconfig: Disable WIDGET_REGION feature. * WebCoreSupport/WebChromeClient.h: Rename dashboardRegions to annotatedRegions. * WebCoreSupport/WebChromeClient.mm: Rename dashboardRegions to annotatedRegions. (WebChromeClient::annotatedRegionsChanged): * WebView/WebView.mm: Rename dashboardRegions to annotatedRegions. (-[WebView _dashboardRegions]): 2012-10-09 Sheriff Bot Unreviewed, rolling out r130811 and r130821. http://trac.webkit.org/changeset/130811 http://trac.webkit.org/changeset/130821 https://bugs.webkit.org/show_bug.cgi?id=98831 Broke date-suggestion-picker-appearance-with-scroll-bar.html (Requested by abarth|gardening on #webkit). * WebView/WebFullScreenController.mm: (screenRectOfContents): * WebView/WebRenderNode.mm: (copyRenderNode): 2012-10-08 Kiran Muppala Throttle DOM timers on hidden pages. https://bugs.webkit.org/show_bug.cgi?id=98474 Reviewed by Maciej Stachowiak. Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define and provide a SPI for DumpRenderTree to modify the visibility state of a page. The latter is needed to test throttling of timers on hidden pages through DumpRenderTree. * Configurations/FeatureDefines.xcconfig: * WebView/WebView.mm: (-[WebView _setVisibilityState:isInitialState:]): * WebView/WebViewPrivate.h: 2012-10-07 Caio Marcelo de Oliveira Filho Rename first/second to key/value in HashMap iterators https://bugs.webkit.org/show_bug.cgi?id=82784 Reviewed by Eric Seidel. * History/WebHistory.mm: (-[WebHistoryPrivate removeItemFromDateCaches:]): (-[WebHistoryPrivate orderedLastVisitedDays]): (WebHistoryWriter::WebHistoryWriter): * Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): (+[WebCoreStatistics javaScriptObjectTypeCounts]): * Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPlugin): (WebKit::NetscapePluginHostManager::pluginHostDied): (WebKit::NetscapePluginHostManager::didCreateWindow): * Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::pluginHostDied): * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain): (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release): (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): (WebKit::NetscapePluginInstanceProxy::destroy): (WebKit::NetscapePluginInstanceProxy::webFrameDidFinishLoadWithReason): (WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL): * Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::methodNamed): (WebKit::ProxyInstance::fieldNamed): * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView stopTimers]): (-[WebNetscapePluginView startTimers]): * WebCoreSupport/WebNotificationClient.mm: (WebNotificationClient::show): (WebNotificationClient::clearNotifications): (WebNotificationClient::notificationObjectDestroyed): * WebView/WebHTMLView.mm: (commandNameForSelector): 2012-10-06 Dan Bernstein WebKit/mac part of [mac] WebKit clients cannot change the behavior of text-rendering: auto https://bugs.webkit.org/show_bug.cgi?id=98601 Reviewed by Darin Adler. * WebView/WebView.mm: (+[WebView initialize]): Added a call to Font::setDefaultTypesettingFeatures() to enable kerning and ligatures if the WebKitKerningAndLigaturesEnabledByDefault user default key has the value YES. 2012-10-05 Sheriff Bot Unreviewed, rolling out r130556 and r130564. http://trac.webkit.org/changeset/130556 http://trac.webkit.org/changeset/130564 https://bugs.webkit.org/show_bug.cgi?id=98572 The patch wasn't reviewed by a reviewer and it is breaking Chromium Windows (Requested by jchaffraix on #webkit). * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2012-10-05 Tim Horton [cg] GraphicsContextCG should ask CG whether the shadow offset workaround is required https://bugs.webkit.org/show_bug.cgi?id=98565 Reviewed by Simon Fraser. Add wkCGContextDrawsWithCorrectShadowOffsets. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2012-10-04 Eric Carlson Allow ports to override text track rendering style https://bugs.webkit.org/show_bug.cgi?id=97800 Reviewed by Silvia Pfeiffer. Add WCSI support for new WKSI caption functions. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize new WKSI function pointers. 2012-10-04 Jon Lee Add a setting to enable plugin snapshotting https://bugs.webkit.org/show_bug.cgi?id=98319 Reviewed by Brady Eidson. Expose plugInSnapshottingEnabled preference to WebKit clients. * WebView/WebPreferenceKeysPrivate.h: Add WebKitPlugInSnapshottingEnabled key. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Setting is turned off by default. (-[WebPreferences plugInSnapshottingEnabled]): (-[WebPreferences setPlugInSnapshottingEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Update settings based on preference. 2012-10-04 Rik Cabanier Turn Compositing on by default in WebKit build https://bugs.webkit.org/show_bug.cgi?id=98315 Reviewed by Simon Fraser. enable -webkit-blend-mode on trunk. * Configurations/FeatureDefines.xcconfig: 2012-10-04 Simon Fraser Final part of "sync" to "flush" renaming https://bugs.webkit.org/show_bug.cgi?id=98430 Reviewed by Tim Horton. Change method names on GraphicsLayer and GraphicsLayerClient that refer to "sync" to use the term "flush" instead, to be consistent with the rest of the code. * WebView/WebView.mm: 2012-10-03 Benjamin Poulain [WK2] Support all attributes of GeolocationPosition https://bugs.webkit.org/show_bug.cgi?id=98212 Reviewed by Sam Weinig. Add an internal constructor for the sake of testing. A similar API is used on iOS. * WebView/WebGeolocationPosition.mm: (-[WebGeolocationPosition initWithGeolocationPosition:]): 2012-10-04 Simon Fraser Standardize on "flush" terminology for compositing layer flushing/syncing https://bugs.webkit.org/show_bug.cgi?id=98321 Reviewed by Simon Fraser. Rename compositing-related methods that refer to "syncing" to instead refer to "flushing". * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::scheduleCompositingLayerFlush): * WebView/WebView.mm: (-[WebView _flushCompositingChanges]): (LayerFlushController::flushLayers): (-[WebView _scheduleCompositingLayerFlush]): * WebView/WebViewInternal.h: == Rolled over to ChangeLog-2012-10-02 ==