2016-07-11 Enrica Casucci Add synthetic click origin to WKNavigationAction. https://bugs.webkit.org/show_bug.cgi?id=159584 rdar://problem/25610422 Reviewed by Tim Horton. * WebView/WebPDFViewPlaceholder.mm: (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]): 2016-06-23 Alex Christensen Remove unused didCancelAuthenticationChallenge https://bugs.webkit.org/show_bug.cgi?id=158819 Reviewed by David Kilzer. * DefaultDelegates/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:canAuthenticateAgainstProtectionSpace:forDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]): Deleted. 2016-06-02 David Kilzer Fix typo in -[WebDefaultUIKitDelegate deleteFromInputwithFlags:] Reviewed by Andy Estes. * DefaultDelegates/WebDefaultUIKitDelegate.m: (-[WebDefaultUIKitDelegate deleteFromInputwithFlags:]): Rename... (-[WebDefaultUIKitDelegate deleteFromInputWithFlags:]): ...to this. 2016-05-15 Darin Adler More CTTE and other cleanups for HTML editing header https://bugs.webkit.org/show_bug.cgi?id=157722 Reviewed by Chris Dumez. * WebCoreSupport/WebFrameIOS.mm: (-[WebFrame previousUnperturbedDictationResultBoundaryFromPosition:]): auto (-[WebFrame nextUnperturbedDictationResultBoundaryFromPosition:]): auto 2016-05-14 Darin Adler CTTE for the HTML editing header https://bugs.webkit.org/show_bug.cgi?id=157676 Reviewed by Chris Dumez. * WebCoreSupport/WebFrameIOS.mm: (-[WebFrame previousUnperturbedDictationResultBoundaryFromPosition:]): Update since lastOffsetForEditing takes a reference now. Seems like this code should be in WebCore. (-[WebFrame nextUnperturbedDictationResultBoundaryFromPosition:]): Ditto. 2016-05-13 Beth Dakin Add dyldSPI.h for linked on or after checks, and add one for link preview https://bugs.webkit.org/show_bug.cgi?id=157401 -and corresponding- rdar://problem/26253396 Reviewed by Darin Adler. This patch removes DynamicLinkerSPI.h and replaces it with wtf/spi/darwin/dyldSPI.h * Misc/WebUIKitSupport.mm: 2016-05-06 Simon Fraser Enable IOS_TEXT_AUTOSIZING on Mac and make it testable https://bugs.webkit.org/show_bug.cgi?id=157432 rdar://problem/16406720 Reviewed by Dean Jackson. Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested. Make the setTextAutosizingEnabled() Setting work, and plumb it through WK1 and WK2 preferences for WTR and DRT. Make textAutosizingWindowSizeOverride() work, for layout tests. These two settings are shared with TEXT_AUTOSIZING. Add a TextAutosizing log channel, which is useful for generated -expected.html results. Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement without changes. An implication of this set of changes is that the way clients enable text autosizing has changed. Previously, they set the "MinimumZoomFontSize" preference to 0. Settings::defaultMinimumZoomFontSize() used to do this in order to enable text autosizing on iPhone only, not iPad. Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled() instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone. UIWebView calls WebKitGetMinimumZoomFontSize() to setup the default minimum font zoom size, which will now always return 15, but had no other code that toggled this. So it's safe to just rely on Settings::defaultTextAutosizingEnabled() doing the right thing for iPhone/iPad. * Misc/WebUIKitSupport.mm: (WebKitGetMinimumZoomFontSize): 2016-03-16 Jiewen Tan URL Parsing should signal failure for illegal IDN https://bugs.webkit.org/show_bug.cgi?id=154945 Reviewed by Brent Fulgham. * Misc/WebNSStringExtrasIOS.m: (-[NSString _web_possibleURLsForForUserTypedString:]): * WebView/WebPDFViewPlaceholder.mm: (-[WebPDFViewPlaceholder _updateTitleForURL:]): 2016-03-15 Chris Dumez Unreviewed, rolling out r198203. Favorites view is no longer loading on iOS Reverted changeset: "URL Parsing should signal failure for illegal IDN" https://bugs.webkit.org/show_bug.cgi?id=154945 http://trac.webkit.org/changeset/198203 2016-03-15 Jiewen Tan URL Parsing should signal failure for illegal IDN https://bugs.webkit.org/show_bug.cgi?id=154945 Reviewed by Brent Fulgham. * Misc/WebNSStringExtrasIOS.m: (-[NSString _web_possibleURLsForForUserTypedString:]): * WebView/WebPDFViewPlaceholder.mm: (-[WebPDFViewPlaceholder _updateTitleForURL:]): 2016-03-05 Chris Dumez Consolidate RuntimeApplicationChecks and RuntimeApplicationChecksIOS https://bugs.webkit.org/show_bug.cgi?id=155035 Reviewed by Darin Adler. Update runtime application checks. * WebCoreSupport/WebChromeClientIOS.mm: 2016-02-17 David Kilzer [iOS WK1] NSTimer in WebGeolocationProviderIOS.mm fires on the main thread without the WebThreadLock Reviewed by Andy Estes. This isn't testable because the GeolocationClientMock in WebCore bypasses this code in WebKit1. * Misc/WebGeolocationProviderIOS.mm: (-[WebGeolocationProviderIOS _handlePendingInitialPosition:]): Assert that this is always called on the WebThread. (-[WebGeolocationProviderIOS registerWebView:]): Register the NSTimer on the WebThread NSRunLoop. 2016-01-16 Myles C. Maxfield Remove TextRun::allowsRoundingHacks() https://bugs.webkit.org/show_bug.cgi?id=153185 Reviewed by Simon Fraser. * Misc/WebUIKitSupport.mm: (WebKitInitialize): Deleted. 2016-01-13 Chris Dumez Unreviewed, rolling out r194900. Roll back in as this did not actually regress PLT Reverted changeset: "Unreviewed, rolling out r194826." https://bugs.webkit.org/show_bug.cgi?id=153020 http://trac.webkit.org/changeset/194900 2016-01-12 Commit Queue Unreviewed, rolling out r194826. https://bugs.webkit.org/show_bug.cgi?id=153020 Appears to have regressed PLT (Requested by kling on #webkit). Reverted changeset: "Use NeverDestroyed instead of DEPRECATED_DEFINE_STATIC_LOCAL cont'd" https://bugs.webkit.org/show_bug.cgi?id=152902 http://trac.webkit.org/changeset/194826 2016-01-10 Andreas Kling Use NeverDestroyed instead of DEPRECATED_DEFINE_STATIC_LOCAL cont'd Reviewed by Andy Estes. * WebCoreSupport/WebFixedPositionContent.mm: (WebFixedPositionContentDataLock): 2015-12-31 Andy Estes Replace WTF::move with WTFMove https://bugs.webkit.org/show_bug.cgi?id=152601 Reviewed by Brady Eidson. * WebCoreSupport/WebFixedPositionContent.mm: (-[WebFixedPositionContent setViewportConstrainedLayers:stickyContainerMap:]): * WebCoreSupport/WebInspectorClientIOS.mm: (WebInspectorFrontendClient::WebInspectorFrontendClient): 2015-12-20 Dan Bernstein Remove unused setToolbarHeight https://bugs.webkit.org/show_bug.cgi?id=152466 Reviewed by Darin Adler. * WebCoreSupport/WebInspectorClientIOS.mm: (WebInspectorFrontendClient::setToolbarHeight): Deleted. 2015-12-18 Simon Fraser Turn off "shrink-to-fit" viewport scaling in UIWebViews https://bugs.webkit.org/show_bug.cgi?id=152451 rdar://problem/23960882 Reviewed by Tim Horton. Disable the "shrink to fit" behavior in UIWebViews. This disables it entirely, even when the page has "shrink-to-fit=yes" in the viewport meta tag. Not testable because we can't test actual UIWebView scaling behavior. * WebCoreSupport/WebChromeClientIOS.mm: (dictionaryForViewportArguments): 2015-11-07 Simon Fraser Remove ColorSpace argument to all the drawing calls https://bugs.webkit.org/show_bug.cgi?id=150967 Reviewed by Darin Adler. Since the -webkit-color-correction CSS property was removed in r188202, and ColorSpaceDeviceRGB and ColorSpaceSRGB are functionally equivalent, we can remove all the ColorSpace arguments passed to drawing functions, and remove RenderStyle::colorSpace(), which was hardcoded to return ColorSpaceSRGB. * WebView/WebPDFViewIOS.mm: (-[WebPDFView drawPage:]): * WebView/WebPlainWhiteView.mm: 2015-11-02 Andy Estes Fixed the iOS build after r191904. * WebCoreSupport/WebChromeClientIOS.mm: (WebChromeClientIOS::screenSize): 2015-10-31 Andy Estes Replace iOS-only WebKitSystemInterface calls with SPI https://bugs.webkit.org/show_bug.cgi?id=150763 Reviewed by Darin Adler. * Misc/WebUIKitSupport.mm: (linkedOnOrAfterIOS5): Used dyld_get_program_sdk_version() instead of iosExecutableWasLinkedOnOrAfterVersion(). (WebKitGetMinimumZoomFontSize): Used Settings::defaultMinimumZoomFontSize() instead of WKGetMinimumZoomFontSize(). * WebCoreSupport/WebChromeClientIOS.mm: (WebChromeClientIOS::screenSize): Used screenSize() instead of WKGetScreenSize(). 2015-11-02 Commit Queue Unreviewed, rolling out r191902. https://bugs.webkit.org/show_bug.cgi?id=150811 This change broke iOS builders (Requested by ryanhaddad on #webkit). Reverted changeset: "Replace iOS-only WebKitSystemInterface calls with SPI" https://bugs.webkit.org/show_bug.cgi?id=150763 http://trac.webkit.org/changeset/191902 2015-10-31 Andy Estes Replace iOS-only WebKitSystemInterface calls with SPI https://bugs.webkit.org/show_bug.cgi?id=150763 Reviewed by Darin Adler. * Misc/WebUIKitSupport.mm: (linkedOnOrAfterIOS5): Used dyld_get_program_sdk_version() instead of iosExecutableWasLinkedOnOrAfterVersion(). (WebKitGetMinimumZoomFontSize): Used Settings::defaultMinimumZoomFontSize() instead of WKGetMinimumZoomFontSize(). * WebCoreSupport/WebChromeClientIOS.mm: (WebChromeClientIOS::screenSize): Used screenSize() instead of WKGetScreenSize(). 2015-10-14 Zhuo Li Augment ’s recent search history with the time each entry was added, in order to allow time-based clearing of search history. https://bugs.webkit.org/show_bug.cgi?id=148388. Reviewed by Darin Adler. Replace Vector with Vector, where RecentSearch is a struct that consists search string and time, for recent searches in order to store additional time information. * WebCoreSupport/SearchPopupMenuIOS.cpp: (SearchPopupMenuIOS::saveRecentSearches): (SearchPopupMenuIOS::loadRecentSearches): * WebCoreSupport/SearchPopupMenuIOS.h: 2015-09-17 Brian Burg ASSERT(!m_frontendRouter->hasLocalFrontend()) when running Web Inspector tests https://bugs.webkit.org/show_bug.cgi?id=149006 Reviewed by Joseph Pecoraro. * WebCoreSupport/WebInspectorClientIOS.mm: (WebInspectorClient::closeLocalFrontend): Deleted. (WebInspectorFrontendClient::disconnectFromBackend): Deleted. 2015-09-12 Brian Burg Web Inspector: disambiguate inspected/frontend controllers and pages in backend code https://bugs.webkit.org/show_bug.cgi?id=149071 Reviewed by Joseph Pecoraro. * WebCoreSupport/WebInspectorClientIOS.mm: (WebInspectorClient::WebInspectorClient): (WebInspectorClient::inspectedPageDestroyed): Renamed. (WebInspectorClient::openLocalFrontend): Renamed. (WebInspectorClient::closeLocalFrontend): Renamed. (WebInspectorClient::inspectorDestroyed): Deleted. (WebInspectorClient::openInspectorFrontend): Deleted. (WebInspectorClient::closeInspectorFrontend): Deleted. (WebInspectorClient::showInspectorIndication): (WebInspectorClient::hideInspectorIndication): (WebInspectorClient::didSetSearchingForNode): (WebInspectorFrontendClient::WebInspectorFrontendClient): 2015-08-17 Filip Pizlo Replace all remaining uses of WTF::Mutex with WTF::Lock https://bugs.webkit.org/show_bug.cgi?id=148089 Reviewed by Geoffrey Garen. * WebCoreSupport/WebFixedPositionContent.mm: (WebFixedPositionContentDataLock): (-[WebFixedPositionContent scrollOrZoomChanged:]): (-[WebFixedPositionContent overflowScrollPositionForLayer:changedTo:]): (-[WebFixedPositionContent setViewportConstrainedLayers:stickyContainerMap:]): (-[WebFixedPositionContent hasFixedOrStickyPositionLayers]): (-[WebFixedPositionContent minimumOffsetFromFixedPositionLayersToAnchorEdge:ofRect:inLayer:]): 2015-08-13 Tim Horton Refactor and improve TextIndicator to prepare for tests https://bugs.webkit.org/show_bug.cgi?id=147622 Reviewed by Simon Fraser. * WebCoreSupport/WebFrameIOS.mm: (-[WebFrame closestCaretRectInMarkedTextRangeForPoint:]): Adjust to Range method renames. 2015-08-05 Filip Pizlo Unreviewed, roll out http://trac.webkit.org/changeset/187972. * WebCoreSupport/WebFixedPositionContent.mm: (WebFixedPositionContentDataLock): (-[WebFixedPositionContent scrollOrZoomChanged:]): (-[WebFixedPositionContent overflowScrollPositionForLayer:changedTo:]): (-[WebFixedPositionContent setViewportConstrainedLayers:stickyContainerMap:]): (-[WebFixedPositionContent hasFixedOrStickyPositionLayers]): (-[WebFixedPositionContent minimumOffsetFromFixedPositionLayersToAnchorEdge:ofRect:inLayer:]): 2015-08-04 Filip Pizlo Rename Mutex to DeprecatedMutex https://bugs.webkit.org/show_bug.cgi?id=147675 Reviewed by Geoffrey Garen. * WebCoreSupport/WebFixedPositionContent.mm: (WebFixedPositionContentDataLock): (-[WebFixedPositionContent scrollOrZoomChanged:]): (-[WebFixedPositionContent overflowScrollPositionForLayer:changedTo:]): (-[WebFixedPositionContent setViewportConstrainedLayers:stickyContainerMap:]): (-[WebFixedPositionContent hasFixedOrStickyPositionLayers]): (-[WebFixedPositionContent minimumOffsetFromFixedPositionLayersToAnchorEdge:ofRect:inLayer:]): 2015-08-04 Anders Carlsson Remove database thread pause code https://bugs.webkit.org/show_bug.cgi?id=147669 Reviewed by Daniel Bates. * Misc/WebUIKitSupport.mm: (WebKitSetBackgroundAndForegroundNotificationNames): (applicationDidEnterBackground): Deleted. (applicationWillEnterForeground): Deleted. 2015-07-21 Tim Horton Expose shrink-wrapping as UIKit support SPI https://bugs.webkit.org/show_bug.cgi?id=147148 * WebKit.iOS.exp: Also export. 2015-07-21 Tim Horton Expose shrink-wrapping as UIKit support SPI https://bugs.webkit.org/show_bug.cgi?id=147148 Reviewed by Simon Fraser. * Misc/WebUIKitSupport.h: * Misc/WebUIKitSupport.mm: (WebKitCreatePathWithShrinkWrappedRects): 2015-07-02 Timothy Horton iOS WebKitLegacy should match WebKit2's viewport behavior https://bugs.webkit.org/show_bug.cgi?id=146564 Reviewed by Brent Fulgham. * WebCoreSupport/WebChromeClientIOS.mm: (dictionaryForViewportArguments): 2015-07-02 Timothy Horton iOS WebKitLegacy should match WebKit2's viewport behavior https://bugs.webkit.org/show_bug.cgi?id=146540 Reviewed by Dan Bernstein. * WebKit.iOS.exp: 2015-06-25 Joseph Pecoraro Unreviewed, attempt to fix the iOS build after r185968. * WebCoreSupport/WebInspectorClientIOS.mm: (WebInspectorFrontendClient::startWindowDrag): 2015-06-02 Brady Eidson WebKit policy delegate should suggest if a navigation should be allowed to open URLs externally. rdar://problem/21025301 and https://bugs.webkit.org/show_bug.cgi?id=145280 Reviewed by Alex Christensen. * WebView/WebPDFViewPlaceholder.mm: (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]): 2015-05-25 Dan Bernstein ASSERT_MAIN_THREAD and DOM_ASSERT_MAIN_THREAD are unnecessary no-ops https://bugs.webkit.org/show_bug.cgi?id=145372 Reviewed by Sam Weinig. * Misc/WebGeolocationCoreLocationProvider.mm: (-[WebGeolocationCoreLocationProvider initWithListener:]): Removed use of ASSERT_MAIN_THREAD. (-[WebGeolocationCoreLocationProvider dealloc]): Ditto. (-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]): Ditto. (-[WebGeolocationCoreLocationProvider start]): Ditto. (-[WebGeolocationCoreLocationProvider stop]): Ditto. (-[WebGeolocationCoreLocationProvider setEnableHighAccuracy:]): Ditto. 2015-04-28 Brady Eidson Consolidate most "frame load" arguments into FrameLoadRequest. https://bugs.webkit.org/show_bug.cgi?id=144276 Reviewed by Alexey Proskuryakov. * WebView/WebPDFViewPlaceholder.mm: (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]): 2015-04-13 Beth Dakin Add force property to MouseEvents https://bugs.webkit.org/show_bug.cgi?id=143569 -and corresponding- rdar://problem/20472954 Reviewed by Darin Adler. Send the appropriate force with this simulated click event. * WebView/WebPDFViewPlaceholder.mm: (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]): 2015-03-31 Myles C. Maxfield Move ExpansionBehaviorFlags and TextDirection to their own file https://bugs.webkit.org/show_bug.cgi?id=143273 Reviewed by Simon Fraser. This is a mechanical change. It just moves code around. This is getting ready for https://bugs.webkit.org/show_bug.cgi?id=142608 * WebCoreSupport/WebFrameIOS.mm: * WebCoreSupport/WebVisiblePosition.mm: 2015-03-09 David Kilzer [iOS] Fix build when compiling with dead code stripping disabled Reviewed by Simon Fraser. * WebCoreSupport/WebInspectorClientIOS.mm: (WebInspectorFrontendClient::save): Add missing method. 2015-02-14 Alexey Proskuryakov rel="noreferrer" should make window.opener null https://bugs.webkit.org/show_bug.cgi?id=141579 Reviewed by Darin Adler. * WebView/WebPDFViewPlaceholder.mm: (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]): Updated for a new WebCore function signature. There is no rel="noreferrer" in PDF, so we can just always allow. 2015-02-03 Enrica Casucci [iOS] Add support for deleteFromInputWithFlags. https://bugs.webkit.org/show_bug.cgi?id=141216 rdar://problem/19130081 Reviewed by Benjamin Poulain. Adopts the new method as soon as it is available. The patch also removes some obsolete code used for staging. * DefaultDelegates/WebDefaultUIKitDelegate.m: (-[WebDefaultUIKitDelegate addInputString:withFlags:]): (-[WebDefaultUIKitDelegate deleteFromInput]): (-[WebDefaultUIKitDelegate deleteFromInputwithFlags:]): (-[WebDefaultUIKitDelegate addInputString:fromVariantKey:]): Deleted. * WebView/WebUIKitDelegate.h: 2015-01-22 Andreas Kling Remove unused class EmojiFallbackFontSelector. Reviewed by Antti Koivisto. This class no longer has any clients. * Misc/EmojiFallbackFontSelector.cpp: Removed. * Misc/EmojiFallbackFontSelector.h: Removed. 2015-01-13 Chris Dumez Unreviewed iOS build fix after r178375 Match FontSelector API changes. * Misc/EmojiFallbackFontSelector.cpp: (EmojiFallbackFontSelector::fallbackFontDataAt): (EmojiFallbackFontSelector::getFallbackFontData): Deleted. * Misc/EmojiFallbackFontSelector.h: 2014-12-07 Dan Bernstein Introduce and deploy a function that allocates and returns an instance of a soft-linked class https://bugs.webkit.org/show_bug.cgi?id=139348 Reviewed by Anders Carlsson. In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus avoiding the ambiguity. * Misc/WebGeolocationCoreLocationProvider.mm: (-[WebGeolocationCoreLocationProvider createLocationManager]): 2014-12-06 Anders Carlsson Fix build with newer versions of clang. rdar://problem/18978687 Cast the result of +alloc to the right type. * Misc/WebGeolocationCoreLocationProvider.mm: (-[WebGeolocationCoreLocationProvider createLocationManager]): * WebCoreSupport/WebSelectionRect.m: (+[WebSelectionRect selectionRect]): 2014-11-20 Benjamin Poulain Remove the remaining vestiges of minimal-ui https://bugs.webkit.org/show_bug.cgi?id=138890 Reviewed by Sam Weinig. * WebCoreSupport/WebChromeClientIOS.mm: (dictionaryForViewportArguments): * WebKit.iOS.exp: 2014-11-19 Daniel Bates [iOS] Make WebKit build with public iOS SDK https://bugs.webkit.org/show_bug.cgi?id=136863 Reviewed by David Kilzer. * Misc/WebGeolocationCoreLocationProvider.mm: Remove unnecessary include of header . * Misc/WebNSStringExtrasIOS.m: Substitute header for . * Misc/WebUIKitSupport.mm: Remove unnecessary include of header CoreFoundation/CFPriv.h. 2014-11-14 Daniel Bates [iOS] CoreGraphics SPI not available in public SDK https://bugs.webkit.org/show_bug.cgi?id=138709 Reviewed by David Kilzer. Include header CoreGraphicsSPI.h instead of the private header CGFloat.h. * WebCoreSupport/WebFixedPositionContent.mm: 2014-10-20 Andy Estes Fix the iOS build. * WebCoreSupport/WebFrameIOS.mm: (-[WebFrame previousUnperturbedDictationResultBoundaryFromPosition:]): (-[WebFrame nextUnperturbedDictationResultBoundaryFromPosition:]): * WebCoreSupport/WebVisiblePosition.mm: (-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]): (-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]): 2014-10-15 Chris Dumez Use is<>() / downcast<>() for RenderTextControl / RenderTextControlSingleLine https://bugs.webkit.org/show_bug.cgi?id=137727 Reviewed by Darin Adler. Use is<>() / downcast<>() for RenderTextControl / RenderTextControlSingleLine. * WebCoreSupport/WebVisiblePosition.mm: (-[DOMHTMLInputElement startPosition]): (-[DOMHTMLInputElement endPosition]): (-[DOMHTMLTextAreaElement startPosition]): (-[DOMHTMLTextAreaElement endPosition]): 2014-10-03 Tim Horton REGRESSION (r165896): UIWebView PDFs have a forced black background https://bugs.webkit.org/show_bug.cgi?id=137387 Reviewed by David Kilzer. * WebView/WebPDFViewPlaceholder.h: * WebView/WebPDFViewPlaceholder.mm: (-[WebPDFViewPlaceholder layout]): Remove an ill-advised attempt to force the PDF background color from WebKit. The idea was that we would maintain Safari's black background except if there were no pages in the PDF, in which case we would use white instead to avoid having an all-black view. However, this broke clients who didn't want a black background, because we were now forcing it to black. Also, we don't need to maintain the black color in Safari because it doesn't use WebPDFViewPlaceholder anymore. This wasn't an important part of the patch, in any case. 2014-10-03 Tim Horton REGRESSION (r173265): UIWebView PDF loading is completely broken https://bugs.webkit.org/show_bug.cgi?id=137386 Reviewed by David Kilzer. * WebView/WebPDFViewPlaceholder.h: * WebView/WebPDFViewPlaceholder.mm: (-[WebPDFViewPlaceholder layout]): (-[WebPDFViewPlaceholder finishedLoadingWithDataSource:]): Restore important code that creates the CGDataProvider and sets _didFinishLoad and calls _doPostLoadOrUnlockTasks after finishing a load, which was haphazardly removed in the aforementioned revision. 2014-10-01 Christophe Dumez Have is<>(T*) function do a null check on the pointer argument https://bugs.webkit.org/show_bug.cgi?id=137333 Reviewed by Gavin Barraclough. Have is<>(T*) function do a null check on the argument instead of a simple assertion. This makes sense for 2 reasons: 1. It is more consistent with downcast<>(T*), which will succeed even if the argument is a nullptr. 2. It simplifies the code a bit as it gets rid of a lot of explicit null checks. * WebCoreSupport/WebChromeClientIOS.mm: (WebChromeClientIOS::focusedElementChanged): 2014-09-29 Daniel Bates [iOS] Remove CoreLocation workaround https://bugs.webkit.org/show_bug.cgi?id=137198 Reviewed by Dan Bernstein. Following the fix for , we can revert the CoreLocation workaround committed in and (in order). * Misc/WebGeolocationCoreLocationProvider.mm: (-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]): (-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]): 2014-09-24 Daniel Bates [iOS] Another iOS build fix; workaround for CoreLocation https://bugs.webkit.org/show_bug.cgi?id=137104 Rubber-stamped by Benjamin Poulain. Workaround CoreLocation issue by adding a default statement in -[WebGeolocationCoreLocationProvider requestGeolocationAuthorization] and -[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]. We'll remove these default statements once we have the fix for . * Misc/WebGeolocationCoreLocationProvider.mm: (-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]): (-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]): 2014-09-24 Daniel Bates [iOS] Fix the iOS build; add case statements for kCLAuthorizationStatusAuthorized https://bugs.webkit.org/show_bug.cgi?id=137101 Reviewed by Mark Lam. * Misc/WebGeolocationCoreLocationProvider.mm: (-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]): (-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]): 2014-09-24 Christophe Dumez Use is() instead of isHTML*Element() - Part 1 https://bugs.webkit.org/show_bug.cgi?id=137068 Reviewed by Ryosuke Niwa. Start using is() instead of isHTML*Element(). Remaining usages will be updated in a follow-up patch to reduce the size of the change. * WebCoreSupport/WebChromeClientIOS.mm: (WebChromeClientIOS::focusedElementChanged): 2014-09-21 Timothy Hatcher Make the Web Inspector use a separate web process. https://bugs.webkit.org/show_bug.cgi?id=135120 Reviewed by Anders Carlsson. * WebCoreSupport/WebInspectorClientIOS.mm: (WebInspectorClient::WebInspectorClient): Removed m_frontendClient initialization since it is now a std::unique_ptr that defaults to nullptr. 2014-09-23 Chris Dumez Use downcast() instead of toHTML*Element() https://bugs.webkit.org/show_bug.cgi?id=137007 Reviewed by Benjamin Poulain. Use downcast() instead of toHTML*Element(). * WebCoreSupport/WebChromeClientIOS.mm: (WebChromeClientIOS::focusedElementChanged): 2014-09-17 Daniel Bates Unreviewed, rolling out r173695. Broke building third-party Legacy WebKit apps; will investigate offline Reverted changeset: "[iOS] Make WebCore build with public iOS SDK" https://bugs.webkit.org/show_bug.cgi?id=136487 http://trac.webkit.org/changeset/173695 2014-09-17 Daniel Bates [iOS] Make WebCore build with public iOS SDK https://bugs.webkit.org/show_bug.cgi?id=136487 Reviewed by David Kilzer. Substitute for . * WebCoreSupport/WebFixedPositionContent.mm: 2014-09-05 Simon Fraser Remove some PLATFORM(IOS) code in Color.h/cpp https://bugs.webkit.org/show_bug.cgi?id=136582 Reviewed by Dan Bates. createCGColorWithDeviceWhite() is only used here so make it a local static function. * WebView/WebPDFViewIOS.mm: (createCGColorWithDeviceWhite): 2014-09-04 Pratik Solanki Remove iOS specific disk image cache https://bugs.webkit.org/show_bug.cgi?id=136517 Reviewed by Antti Koivisto. Disk image cache code unnecessarily complicates SharedBuffer implementation. We can remove this now since we don't enable it in WebKit2 on iOS. * WebCoreSupport/WebDiskImageCacheClientIOS.h: Removed. * WebCoreSupport/WebDiskImageCacheClientIOS.mm: Removed. * WebView/WebPDFViewPlaceholder.mm: (-[WebPDFViewPlaceholder finishedLoadingWithDataSource:]): (-[WebPDFViewPlaceholder dataSourceMemoryMapped]): Deleted. (-[WebPDFViewPlaceholder dataSourceMemoryMapFailed]): Deleted. 2014-08-31 Tim Horton Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor https://bugs.webkit.org/show_bug.cgi?id=136416 Reviewed by Dan Bernstein. * WebView/WebPDFViewIOS.mm: (-[WebPDFView drawPage:]): (-[WebPDFView drawRect:]): * WebView/WebPlainWhiteView.mm: We only end up filling, so only set the fill color. 2014-08-22 Simon Fraser Implement paint flashing in the WK1 InspectorOverlay page https://bugs.webkit.org/show_bug.cgi?id=136138 Reviewed by Sam Weinig, Joseph Pecoraro. Implement paint flashing for the WebKit1 InspectorOverlay via a second canvas in the overlay page. We avoid allocating backing store for this canvas until we have paint rects. Because this overlay page is weird and doesn't know how to paint itself, InspectorOverlay manages an array of rects, and pushes them to the page when they change, before forcing a paint. Because iOS doesn't use the InspectorOverlay page, stub out setShowPaintRects on its WebKit WebInspectorClient, but don't yet implement paint flashing there. * WebCoreSupport/WebInspectorClientIOS.mm: (WebInspectorClient::setShowPaintRects): (WebInspectorClient::showPaintRect): 2014-08-18 Andy Estes Fix the iOS build after r172709. * WebView/WebPDFViewPlaceholder.mm: (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]): 2014-07-03 Daniel Bates Add WTF::move() https://bugs.webkit.org/show_bug.cgi?id=134500 Rubber-stamped by Anders Carlsson. Substitute WTF::move() for std::move(). * WebCoreSupport/WebFixedPositionContent.mm: (-[WebFixedPositionContent setViewportConstrainedLayers:stickyContainerMap:]): * WebCoreSupport/WebInspectorClientIOS.mm: (WebInspectorFrontendClient::WebInspectorFrontendClient): 2014-07-01 Alex Christensen [iOS] Compile fix with pointer lock enabled. https://bugs.webkit.org/show_bug.cgi?id=134472 Reviewed by Pratik Solanki. * WebView/WebPDFViewPlaceholder.mm: (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]): Add parameters required for pointer lock. 2014-06-05 Benjamin Poulain [iOS][WK2] Add device orientation https://bugs.webkit.org/show_bug.cgi?id=133530 Reviewed by Tim Horton. Change WebKit1 to provide the deviceOrientation as pull instead of push. * DefaultDelegates/WebDefaultUIKitDelegate.m: (-[WebDefaultUIKitDelegate deviceOrientation]): * WebCoreSupport/WebChromeClientIOS.h: * WebCoreSupport/WebChromeClientIOS.mm: (WebChromeClientIOS::deviceOrientation): * WebView/WebUIKitDelegate.h: 2014-05-09 Benjamin Poulain [iOS] Switch geolocation to an explicit authorization query model https://bugs.webkit.org/show_bug.cgi?id=132717 Reviewed by Sam Weinig. WebGeolocationCoreLocationProvider is the general WebKit wrapper for CoreLocation. The old model was to start WebGeolocationCoreLocationProvider and have the start fail or succeed. The new model is to explicitely ask for authorization through "requestGeolocationAuthorization", and listen to "geolocationAuthorizationGranted" and "geolocationAuthorizationDenied". We assume the client of WebGeolocationCoreLocationProvider is well behaved and ask for authorization before invoking "start". If "start" is called and the authorization is not granted, we assume geolocation was reset since the last time authorization was requested, and we reset the client. WebGeolocationProviderIOS has been adapted to that model. Instead of doing the "warmup" sequence to get the authorization, it queries WebGeolocationCoreLocationProvider explicitly. * Misc/WebGeolocationCoreLocationProvider.h: * Misc/WebGeolocationCoreLocationProvider.mm: (-[WebGeolocationCoreLocationProvider createLocationManager]): (-[WebGeolocationCoreLocationProvider dealloc]): (-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]): (isAuthorizationGranted): (-[WebGeolocationCoreLocationProvider start]): (-[WebGeolocationCoreLocationProvider stop]): (-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]): (-[WebGeolocationCoreLocationProvider setEnableHighAccuracy:]): (-[WebGeolocationCoreLocationProvider handleExternalAuthorizationStatusChange:]): Deleted. * Misc/WebGeolocationProviderIOS.mm: (-[WebGeolocationProviderIOS suspend]): (-[WebGeolocationProviderIOS resume]): (-[WebGeolocationProviderIOS registerWebView:]): (-[WebGeolocationProviderIOS unregisterWebView:]): (-[WebGeolocationProviderIOS setEnableHighAccuracy:]): (-[WebGeolocationProviderIOS initializeGeolocationForWebView:listener:]): (-[WebGeolocationProviderIOS geolocationAuthorizationGranted]): (-[WebGeolocationProviderIOS geolocationAuthorizationDenied]): (-[WebGeolocationProviderIOS stopTrackingWebView:]): (-[WebGeolocationProviderIOS resetGeolocation]): (-[_WebCoreLocationUpdateThreadingProxy geolocationAuthorizationGranted]): (-[_WebCoreLocationUpdateThreadingProxy geolocationAuthorizationDenied]): (-[_WebCoreLocationUpdateThreadingProxy positionChanged:WebCore::]): (-[_WebCoreLocationUpdateThreadingProxy errorOccurred:]): (-[_WebCoreLocationUpdateThreadingProxy resetGeolocation]): (-[WebGeolocationProviderIOS _startCoreLocationDelegate]): Deleted. (-[WebGeolocationProviderIOS _stopCoreLocationDelegateIfNeeded]): Deleted. (-[WebGeolocationProviderIOS cancelWarmUpForWebView:]): Deleted. (-[WebGeolocationProviderIOS geolocationDelegateStarted]): Deleted. (-[WebGeolocationProviderIOS geolocationDelegateUnableToStart]): Deleted. (-[_WebCoreLocationUpdateThreadingProxy geolocationDelegateStarted]): Deleted. (-[_WebCoreLocationUpdateThreadingProxy geolocationDelegateUnableToStart]): Deleted. 2014-04-30 Anders Carlsson Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework https://bugs.webkit.org/show_bug.cgi?id=132399 Reviewed by Dan Bernstein. Import WebKitLegacy headers instead of WebKit headers. * DefaultDelegates/WebDefaultFormDelegate.h: * DefaultDelegates/WebDefaultFrameLoadDelegate.m: * DefaultDelegates/WebDefaultResourceLoadDelegate.m: * DefaultDelegates/WebDefaultUIKitDelegate.h: * Misc/WebGeolocationProviderIOS.h: * Misc/WebNSStringExtrasIPhone.h: * WebCoreSupport/WebFrameIOS.h: * WebCoreSupport/WebFrameIOS.mm: * WebCoreSupport/WebFrameIPhone.h: * WebCoreSupport/WebSelectionRect.h: * WebCoreSupport/WebVisiblePosition.h: * WebView/WebPDFViewIOS.h: * WebView/WebPDFViewIOS.mm: * WebView/WebPDFViewIPhone.h: * WebView/WebPDFViewPlaceholder.h: * WebView/WebPDFViewPlaceholder.mm: * WebView/WebPlainWhiteView.h: * WebView/WebUIKitDelegate.h: 2014-04-24 Myles C. Maxfield FontCache::fontCache() never returns nullptr so it can be made to return a reference instead https://bugs.webkit.org/show_bug.cgi?id=132110 Reviewed by Tim Horton. Updates callers to use '.' instead of '->'. No new tests are necessary because there should be no behavior change. * Misc/EmojiFallbackFontSelector.cpp: (EmojiFallbackFontSelector::getFallbackFontData): 2014-04-17 Daniel Bates [iOS] Hook up screen.{availHeight, availWidth, height, width} https://bugs.webkit.org/show_bug.cgi?id=131821 Reviewed by Benjamin Poulain and Tim Horton. Provide iOS-specific WebKit1 implementation for ChromeClient::availableScreenSize(). Additionally substitute "screenSize" for "viewporScreenSize" to make the code more understandable. * WebCoreSupport/WebChromeClientIOS.h: * WebCoreSupport/WebChromeClientIOS.mm: (WebChromeClientIOS::screenSize): Renamed; formerly named viewportScreenSize. (WebChromeClientIOS::availableScreenSize): Added; ASSERT_NOT_REACHED() as a widget should consult it's associated WAKWindow for the available screen size. 2014-04-08 Alexey Proskuryakov Rename Clipboard to DataTransfer https://bugs.webkit.org/show_bug.cgi?id=131371 Reviewed by Anders Carlsson. * WebView/WebPDFViewPlaceholder.mm: 2014-04-02 Benjamin Poulain [iOS] Remove the legacy string drawing code https://bugs.webkit.org/show_bug.cgi?id=131088 Reviewed by Sam Weinig. * Misc/WebNSStringDrawing.h: Removed. * Misc/WebNSStringDrawing.mm: Removed. * Misc/WebUIKitSupport.h: 2014-04-02 Mark Rowe Build fix after r166684. * WebView/WebPDFViewPlaceholder.mm: (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]): 2014-03-31 Anders Carlsson Fix iOS build. * WebCoreSupport/WebChromeClientIOS.h: * WebCoreSupport/WebChromeClientIOS.mm: * WebCoreSupport/WebFixedPositionContent.mm: * WebCoreSupport/WebFixedPositionContentInternal.h: 2014-03-30 Dan Bernstein Tried to fix the iOS build. * Misc/WebGeolocationCoreLocationProvider.mm: (-[WebGeolocationCoreLocationProvider start]): (-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]): 2014-03-27 Enrica Casucci Add support for AirPlay picker for iOS. https://bugs.webkit.org/show_bug.cgi?id=130876 Reviewed by Benjamin Poulain. Adds support for the AirPlay picker for WebKit. The actual picker is implemented in UIKit. * DefaultDelegates/WebDefaultUIKitDelegate.m: (-[WebDefaultUIKitDelegate interactionLocation]): (-[WebDefaultUIKitDelegate showPlaybackTargetPicker:fromRect:]): * WebCoreSupport/WebChromeClientIOS.mm: (WebChromeClientIOS::showPlaybackTargetPicker): * WebCoreSupport/WebFrameIOS.h: * WebCoreSupport/WebFrameIOS.mm: (-[WebFrame elementRectAtPoint:]): * WebView/WebUIKitDelegate.h: 2014-03-27 Enrica Casucci Add support for AirPlay picker in WK2 for iOS. https://bugs.webkit.org/show_bug.cgi?id=130855 Reviewed by Eric Carlson, Joseph Pecoraro and Benjamin Poulain. Adds stub for new WebKit chrome client method. * WebCoreSupport/WebChromeClientIOS.h: * WebCoreSupport/WebChromeClientIOS.mm: (WebChromeClientIOS::showAirPlayRoutePicker): 2014-03-25 Joseph Pecoraro [iOS] Inspector View Indication Support https://bugs.webkit.org/show_bug.cgi?id=130709 Reviewed by Simon Fraser. * WebCoreSupport/WebInspectorClientIOS.mm: (WebInspectorClient::showInspectorIndication): (WebInspectorClient::hideInspectorIndication): Renamed methods. 2014-03-22 Darin Adler Remove String::deprecatedCharacters https://bugs.webkit.org/show_bug.cgi?id=126854 Reviewed by Sam Weinig. * Misc/WebNSStringDrawing.h: Added a FIXME about deleting this file; we can probably do it soon. * Misc/WebNSStringDrawing.mm: (+[NSString _web_setWordRoundingEnabled:]): (+[NSString _web_wordRoundingEnabled]): (+[NSString _web_setWordRoundingAllowed:]): (+[NSString _web_wordRoundingAllowed]): (+[NSString _web_setAscentRoundingEnabled:]): (+[NSString _web_ascentRoundingEnabled]): (-[NSString _web_drawAtPoint:withFont:]): (-[NSString _web_sizeWithFont:]): (-[NSString _web_sizeWithFont:forWidth:ellipsis:]): (-[NSString _web_sizeWithFont:forWidth:ellipsis:letterSpacing:]): (-[NSString _web_sizeWithFont:forWidth:ellipsis:letterSpacing:resultRange:]): (-[NSString _web_drawAtPoint:forWidth:withFont:ellipsis:]): (-[NSString _web_drawAtPoint:forWidth:withFont:ellipsis:letterSpacing:]): (-[NSString _web_drawAtPoint:forWidth:withFont:ellipsis:letterSpacing:includeEmoji:]): (-[NSString _web_drawInRect:withFont:ellipsis:alignment:lineSpacing:includeEmoji:truncationRect:measureOnly:]): (-[NSString _web_drawInRect:withFont:ellipsis:alignment:lineSpacing:includeEmoji:truncationRect:]): (-[NSString _web_drawInRect:withFont:ellipsis:alignment:lineSpacing:]): (-[NSString _web_drawInRect:withFont:ellipsis:alignment:]): (-[NSString _web_sizeInRect:withFont:ellipsis:lineSpacing:]): (-[NSString _web_sizeInRect:withFont:ellipsis:]): (-[NSString _web_stringForWidth:withFont:ellipsis:letterSpacing:includeEmoji:]): (-[NSString _web_sizeForWidth:withAttributes:]): (-[NSString _web_drawAtPoint:forWidth:withAttributes:]): (-[NSString _web_sizeInRect:withAttributes:]): (-[NSString _web_drawInRect:withAttributes:]): Emptied out all these functions since callers aren't really using them any more. 2014-03-21 Tim Horton Always retrieve the screen scale factor from WKSI Reviewed by Sam Weinig. * Misc/WebUIKitSupport.mm: (WebKitSetIsClassic): Empty this out; it's no longer needed, but will still be called. 2014-03-19 Tim Horton [iOS] WebPDFViewPlaceholder divides-by-zero with an empty document https://bugs.webkit.org/show_bug.cgi?id=130444 Reviewed by Sam Weinig. * WebView/WebPDFViewPlaceholder.h: * WebView/WebPDFViewPlaceholder.mm: (-[WebPDFViewPlaceholder layout]): Get rid of boundingSize, it's never assigned to anything but CGSizeZero, which is confusing. Don't divide by zero if we have no pages, instead return an empty bounding size. (-[WebPDFViewPlaceholder _computePageRects:]): If we have an empty document, set the background color to white. Otherwise, set it to black. It's not clear that black is the ideal background color, but this retains existing behavior. 2014-03-14 Maciej Stachowiak Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers https://bugs.webkit.org/show_bug.cgi?id=130276 Reviewed by Simon Fraser. * WebCoreSupport/WebCaretChangeListener.h: * WebCoreSupport/WebInspectorClientIOS.mm: * WebView/WebPlainWhiteView.h: * WebView/WebPlainWhiteView.mm: 2014-03-12 Sergio Villar Senin Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL https://bugs.webkit.org/show_bug.cgi?id=129612 Reviewed by Darin Adler. For new code use static NeverDestroyed instead. * Misc/EmojiFallbackFontSelector.cpp: (EmojiFallbackFontSelector::getFallbackFontData): * WebCoreSupport/WebFixedPositionContent.mm: (WebFixedPositionContentDataLock): 2014-03-13 Benjamin Poulain The viewport code should not depend on WebKitSystemInterface https://bugs.webkit.org/show_bug.cgi?id=130218 Reviewed by Tim Horton. * WebCoreSupport/WebChromeClientIOS.h: * WebCoreSupport/WebChromeClientIOS.mm: (WebChromeClientIOS::viewportScreenSize): Get the viewport size from WebKitSystemInterface. 2014-03-12 Enrica Casucci Incorrect reference counting of Range in WebFrame. https://bugs.webkit.org/show_bug.cgi?id=130160 Reviewed by Anders Carlsson. * WebCoreSupport/WebFrameIOS.mm: (-[WebFrame selectionRects]): 2014-03-12 Simon Fraser Spelling is hard https://bugs.webkit.org/show_bug.cgi?id=130146 Reviewed by Beth Dakin. Fix spelling (constained -> constrained). * WebCoreSupport/WebFixedPositionContent.mm: (-[WebFixedPositionContent scrollOrZoomChanged:]): (-[WebFixedPositionContent overflowScrollPositionForLayer:changedTo:]): (-[WebFixedPositionContent setViewportConstrainedLayers:WTF::WebCore::stickyContainerMap:WTF::]): (-[WebFixedPositionContent hasFixedOrStickyPositionLayers]): (-[WebFixedPositionContent minimumOffsetFromFixedPositionLayersToAnchorEdge:ofRect:inLayer:]): 2014-02-17 Sergio Correia Replace uses of PassOwnPtr/OwnPtr with std::unique_ptr in WebCore/inspector https://bugs.webkit.org/show_bug.cgi?id=128681 Reviewed by Timothy Hatcher. Another step towards getting rid of PassOwnPtr/OwnPtr, now targeting WebCore/inspector/*. Besides files in there, a few other files in JavaScriptCore/inspector, WebKit/, WebKit2/WebProcess/WebCoreSupport/ and WebCore/testing were touched. * WebCoreSupport/WebInspectorClientIOS.mm: 2014-02-12 Benjamin Poulain [WK2][iOS] Add back the special viewport for the old xhtml mobile doctype https://bugs.webkit.org/show_bug.cgi?id=128639 Reviewed by Andreas Kling. * WebCoreSupport/WebChromeClientIOS.h: * WebCoreSupport/WebChromeClientIOS.mm: (WebChromeClientIOS::didReceiveMobileDocType): 2014-02-08 Ryosuke Niwa Build fix after r163739. * WebCoreSupport/WebFrameIOS.mm: (-[WebFrame collapseSelection]): (-[WebFrame aggressivelyExpandSelectionToWordContainingCaretSelection]): 2014-02-03 Dan Bernstein More iOS build fixing. * Misc/WebNSStringDrawing.mm: (-[NSString __web_drawAtPoint:forWidth:withFont:ellipsis:letterSpacing:includeEmoji:measureOnly:renderedStringOut:drawUnderline:]): (-[NSString __web_drawInRect:withFont:ellipsis:alignment:letterSpacing:lineSpacing:includeEmoji:truncationRect:measureOnly:renderedStringOut:drawUnderline:]): 2014-01-31 Ryosuke Niwa Remove inline member functions of FrameSelection that access m_selection https://bugs.webkit.org/show_bug.cgi?id=127986 Reviewed by Enrica Casucci. * WebCoreSupport/WebFrameIOS.mm: (-[WebFrame extendSelection:]): (-[WebFrame ensureRangedSelectionContainsInitialStartPoint:initialEndPoint:]): (-[WebFrame aggressivelyExpandSelectionToWordContainingCaretSelection]): (-[WebFrame expandSelectionToSentence]): (-[WebFrame setBaseWritingDirection:]): (-[WebFrame smartExtendRangedSelection:]): 2014-01-30 Andrei Bucur Remove the ACCELERATED_COMPOSITING flag https://bugs.webkit.org/show_bug.cgi?id=127833 Reviewed by Antti Koivisto. Remove the USE(ACCELERATED_COMPOSITING) conditionals from the code base and make AC mandatory. * WebCoreSupport/WebChromeClientIOS.h: * WebCoreSupport/WebChromeClientIOS.mm: (WebChromeClientIOS::attachRootGraphicsLayer): * WebView/WebUIKitDelegate.h: 2014-01-27 Joseph Pecoraro Unreviewed iOS build fix. FALLTHROUGHs for iOS. * Misc/WebNSStringDrawing.mm: (needsBidiLayout): 2014-01-27 Andy Estes Scrub WebKit API headers of WTF macros https://bugs.webkit.org/show_bug.cgi?id=127706 Reviewed by David Kilzer. * WebCoreSupport/WebMIMETypeRegistry.h: Changed PLATFORM(IOS) to TARGET_OS_IPHONE. 2014-01-15 Sam Weinig TextBreakIterator's should support Latin-1 for all iterator types (Part 3) https://bugs.webkit.org/show_bug.cgi?id=126856 Reviewed by Ryosuke Niwa. Change all the TextBreakIterator creation functions to take StringViews. Remove a few now unnecessary up-conversions to UTF-16 in the process. * Misc/WebNSStringDrawing.mm: 2014-01-16 Anders Carlsson Change all uses of FINAL to final now that all our compilers support it https://bugs.webkit.org/show_bug.cgi?id=127142 Reviewed by Benjamin Poulain. * WebCoreSupport/WebDiskImageCacheClientIOS.h: 2014-01-16 Peter Molnar Remove workaround for compilers not supporting explicit override control https://bugs.webkit.org/show_bug.cgi?id=127111 Reviewed by Anders Carlsson. Now all compilers support explicit override control, this workaround can be removed. * Misc/EmojiFallbackFontSelector.h: * Storage/WebSQLiteDatabaseTrackerClient.h: * WebCoreSupport/PopupMenuIOS.h: * WebCoreSupport/SearchPopupMenuIOS.h: * WebCoreSupport/WebChromeClientIOS.h: * WebCoreSupport/WebDiskImageCacheClientIOS.h: 2014-01-16 Andy Estes [iOS] Fix build issues with exported headers * Misc/WebNSStringExtrasIOS.h: Changed PLATFORM(IOS) to TARGET_OS_IPHONE. 2014-01-14 Simon Fraser Avoid PLATFORM() macros in exported headers. * WebView/WebPDFViewPlaceholder.h: 2014-01-14 Simon Fraser Clean up exports and headers for iOS. * Misc/WebNSStringDrawing.h: Don't use PLATFORM() macro in an exported header. * WebCoreSupport/WebFrameIOS.h: Ditto. * WebCoreSupport/WebSelectionRect.h: Ditto. 2014-01-14 Dean Jackson Remove .objc_class_name_WebInspectorXPCWrapper from export on iOS build. * WebKit.iOS.exp: 2014-01-14 Simon Fraser Fix WK1 iOS build: need implementations of these functions in WebInspectorClientIOS. * WebCoreSupport/WebInspectorClientIOS.mm: (WebInspectorClient::indicate): (WebInspectorClient::hideIndication): 2014-01-13 Simon Fraser More work towards getting iOS WK1 building. * WebCoreSupport/WebFrameIOS.mm: (-[WebFrame imageForNode:allowDownsampling:drawContentBehindTransparentNodes:]): Stub out this function, since it should use recently-refactored node snapshotting code. Covered by . 2014-01-12 Darin Adler Add type checking to isEqual methods https://bugs.webkit.org/show_bug.cgi?id=126862 Reviewed by Anders Carlsson. * WebCoreSupport/WebVisiblePosition.mm: (-[WebVisiblePosition isEqual:]): Add type checking on the argument. Add a FIXME about the lack of a hash method override. Simplified by removing the unneeded local variables. 2014-01-02 Andy Estes [iOS] Upstream remainder of minimal-ui viewport changes https://bugs.webkit.org/show_bug.cgi?id=126410 Reviewed by Sam Weinig. * WebCoreSupport/WebChromeClientIOS.mm: (dictionaryForViewportArguments): * WebKit.iOS.exp: 2013-12-31 Andy Estes [iOS] Upstream PLATFORM(IOS) changes to Source/WebKit/ https://bugs.webkit.org/show_bug.cgi?id=125746 Reviewed by David Kilzer. * WebCoreSupport/WebVisiblePosition.mm: (-[WebVisiblePosition positionAtStartOrEndOfWord]): Changed a comment to mention iOS rather than iPhone. 2013-12-27 Daniel Bates [iOS] Upstream WebCore/page changes https://bugs.webkit.org/show_bug.cgi?id=126180 Reviewed by Darin Adler. * WebCoreSupport/WebChromeClientIOS.mm: Substitute ENABLE(IOS_TOUCH_EVENTS) for ENABLE(TOUCH_EVENTS). 2013-12-04 Brian J. Burg Consolidate various frame snapshot capabilities. https://bugs.webkit.org/show_bug.cgi?id=124325 Reviewed by Darin Adler. * WebCoreSupport/WebFrameIOS.mm: use new header file. 2013-12-04 Andy Estes [iOS] Upstream build fixes in Source/WebKit/ios/ https://bugs.webkit.org/show_bug.cgi?id=125230 Reviewed by Sam Weinig. * DefaultDelegates/WebDefaultUIKitDelegate.m: (-[WebDefaultUIKitDelegate webViewDidReceiveMobileDocType:]): * Misc/WebNSStringDrawing.mm: (needsBidiLayout): (-[NSString __web_drawAtPoint:forWidth:withFont:ellipsis:letterSpacing:includeEmoji:measureOnly:renderedStringOut:drawUnderline:]): (-[NSString __web_drawInRect:withFont:ellipsis:alignment:letterSpacing:lineSpacing:includeEmoji:truncationRect:measureOnly:renderedStringOut:drawUnderline:]): * Misc/WebUIKitSupport.mm: (WebKitInitialize): * WebCoreSupport/WebChromeClientIOS.h: * WebCoreSupport/WebChromeClientIOS.mm: (WebChromeClientIOS::didReceiveMobileDocType): (WebChromeClientIOS::focusedElementChanged): * WebCoreSupport/WebFrameIOS.mm: (-[WebFrame clearSelection]): (-[WebFrame selectionState]): (-[WebFrame collapseSelection]): (-[WebFrame extendSelection:]): (-[WebFrame selectionRects]): (-[WebFrame setRangedSelectionWithExtentPoint:]): (-[WebFrame setRangedSelectionExtentPoint:baseIsStart:allowFlipping:]): (-[WebFrame setSelectionWithBasePoint:extentPoint:baseIsStart:allowFlipping:]): (-[WebFrame setSelectionWithFirstPoint:secondPoint:]): (-[WebFrame ensureRangedSelectionContainsInitialStartPoint:initialEndPoint:]): (-[WebFrame aggressivelyExpandSelectionToWordContainingCaretSelection]): (-[WebFrame expandSelectionToSentence]): (-[WebFrame setBaseWritingDirection:]): (-[WebFrame moveSelectionToStart]): (-[WebFrame moveSelectionToEnd]): (-[WebFrame moveSelectionToPoint:]): (-[WebFrame setSelectionGranularity:]): (-[WebFrame smartExtendRangedSelection:]): (-[WebFrame previousUnperturbedDictationResultBoundaryFromPosition:]): (-[WebFrame nextUnperturbedDictationResultBoundaryFromPosition:]): * WebCoreSupport/WebInspectorClientIOS.mm: (WebInspectorClient::WebInspectorClient): (WebInspectorClient::didSetSearchingForNode): (WebInspectorClient::setupRemoteConnection): (WebInspectorClient::teardownRemoteConnection): * WebCoreSupport/WebVisiblePosition.mm: (-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]): (-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]): (-[DOMHTMLInputElement startPosition]): (-[DOMHTMLInputElement endPosition]): (-[DOMHTMLTextAreaElement startPosition]): (-[DOMHTMLTextAreaElement endPosition]): * WebView/WebPDFViewIOS.mm: (+[WebPDFView shadowColor]): (+[WebPDFView backgroundColor]): (-[WebPDFView _checkPDFTitle]): * WebView/WebPDFViewPlaceholder.mm: (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]): * WebView/WebUIKitDelegate.h: 2013-12-03 Joseph Pecoraro Web Inspector: Push Remote Inspector debugging connection management into JavaScriptCore https://bugs.webkit.org/show_bug.cgi?id=124613 Reviewed by Timothy Hatcher. * WebCoreSupport/WebInspectorClientIOS.mm: (WebInspectorClient::WebInspectorClient): (WebInspectorClient::inspectorDestroyed): 2013-12-03 Ralph Thomas Typo: FixedPositionConstaint -> FixedPositionConstraint https://bugs.webkit.org/show_bug.cgi?id=125171 Reviewed by Simon Fraser. * WebCoreSupport/WebFixedPositionContent.mm: (-[WebFixedPositionContent scrollOrZoomChanged:]): 2013-11-18 Commit Queue Unreviewed, rolling out r159455. http://trac.webkit.org/changeset/159455 https://bugs.webkit.org/show_bug.cgi?id=124568 broke two api tests (see bug 124564) (Requested by thorton on #webkit). * WebCoreSupport/WebFrameIOS.mm: 2013-11-18 Brian J. Burg Consolidate various frame snapshot capabilities. https://bugs.webkit.org/show_bug.cgi?id=124325 Reviewed by Timothy Hatcher. * WebCoreSupport/WebFrameIOS.mm: use new header file. 2013-11-07 Joseph Pecoraro Remove a PLATFORM(IOS) from WebKit Private Header https://bugs.webkit.org/show_bug.cgi?id=124014 Reviewed by Timothy Hatcher. * WebKit.iOS.exp: 2013-10-29 Andy Estes [iOS] Upstream Source/WebKit/ios/ https://bugs.webkit.org/show_bug.cgi?id=123470 Reviewed by Sam Weinig. * DefaultDelegates/WebDefaultFormDelegate.h: Added. * DefaultDelegates/WebDefaultFormDelegate.m: Added. * DefaultDelegates/WebDefaultFrameLoadDelegate.h: Added. * DefaultDelegates/WebDefaultFrameLoadDelegate.m: Added. * DefaultDelegates/WebDefaultResourceLoadDelegate.h: Added. * DefaultDelegates/WebDefaultResourceLoadDelegate.m: Added. * DefaultDelegates/WebDefaultUIKitDelegate.h: Added. * DefaultDelegates/WebDefaultUIKitDelegate.m: Added. * Misc/EmojiFallbackFontSelector.cpp: Added. * Misc/EmojiFallbackFontSelector.h: Added. * Misc/MemoryMeasure.h: Added. * Misc/MemoryMeasure.mm: Added. * Misc/WebGeolocationCoreLocationProvider.h: Added. * Misc/WebGeolocationCoreLocationProvider.mm: Added. * Misc/WebGeolocationProviderIOS.h: Added. * Misc/WebGeolocationProviderIOS.mm: Added. * Misc/WebNSStringDrawing.h: Added. * Misc/WebNSStringDrawing.mm: Added. * Misc/WebNSStringExtrasIOS.h: Added. * Misc/WebNSStringExtrasIOS.m: Added. * Misc/WebNSStringExtrasIPhone.h: Added. * Misc/WebUIKitSupport.h: Added. * Misc/WebUIKitSupport.mm: Added. * Storage/WebSQLiteDatabaseTrackerClient.h: Added. * Storage/WebSQLiteDatabaseTrackerClient.mm: Added. * WebCoreSupport/PopupMenuIOS.h: Added. * WebCoreSupport/PopupMenuIOS.mm: Added. * WebCoreSupport/SearchPopupMenuIOS.cpp: Added. * WebCoreSupport/SearchPopupMenuIOS.h: Added. * WebCoreSupport/WebCaretChangeListener.h: Added. * WebCoreSupport/WebChromeClientIOS.h: Added. * WebCoreSupport/WebChromeClientIOS.mm: Added. * WebCoreSupport/WebFixedPositionContent.h: Added. * WebCoreSupport/WebFixedPositionContent.mm: Added. * WebCoreSupport/WebFixedPositionContentInternal.h: Added. * WebCoreSupport/WebFrameIOS.h: Added. * WebCoreSupport/WebFrameIOS.mm: Added. * WebCoreSupport/WebFrameIPhone.h: Added. * WebCoreSupport/WebGeolocation.mm: Added. * WebCoreSupport/WebGeolocationInternal.h: Added. * WebCoreSupport/WebGeolocationPrivate.h: Added. * WebCoreSupport/WebMIMETypeRegistry.h: Added. * WebCoreSupport/WebMIMETypeRegistry.mm: Added. * WebCoreSupport/WebSelectionRect.h: Added. * WebCoreSupport/WebSelectionRect.m: Added. * WebCoreSupport/WebVisiblePosition.h: Added. * WebCoreSupport/WebVisiblePosition.mm: Added. * WebCoreSupport/WebVisiblePositionInternal.h: Added. * WebKit.iOS.exp: Added. * WebView/WebFrameViewWAKCompatibility.m: Added. * WebView/WebMailDelegate.h: Added. * WebView/WebPDFViewIOS.h: Added. * WebView/WebPDFViewIOS.mm: Added. * WebView/WebPDFViewIPhone.h: Added. * WebView/WebPDFViewPlaceholder.h: Added. * WebView/WebPDFViewPlaceholder.mm: Added. * WebView/WebPlainWhiteView.h: Added. * WebView/WebPlainWhiteView.mm: Added. * WebView/WebUIKitDelegate.h: Added. 2013-10-25 Joseph Pecoraro Upstream ENABLE(REMOTE_INSPECTOR) and enable on iOS and Mac https://bugs.webkit.org/show_bug.cgi?id=123111 Reviewed by Timothy Hatcher. iOS does not have a local inspector, only remote. So give it a custom implementation separate from the WebKit/mac WebInspectorClient implementation which handles an attaching/detaching local inspector. * WebKit.xcodeproj/project.pbxproj: * ios/WebCoreSupport/WebInspectorClientIOS.mm: Added. (WebInspectorClient::WebInspectorClient): (WebInspectorClient::inspectorDestroyed): (WebInspectorClient::openInspectorFrontend): (WebInspectorClient::bringFrontendToFront): (WebInspectorClient::closeInspectorFrontend): (WebInspectorClient::didResizeMainFrame): (WebInspectorClient::highlight): (WebInspectorClient::hideHighlight): (WebInspectorClient::didSetSearchingForNode): (WebInspectorClient::sendMessageToFrontend): (WebInspectorClient::sendMessageToBackend): (WebInspectorClient::setupRemoteConnection): (WebInspectorClient::teardownRemoteConnection): (WebInspectorClient::hasLocalSession): (WebInspectorClient::canBeRemotelyInspected): (WebInspectorClient::inspectedWebView): (WebInspectorFrontendClient::WebInspectorFrontendClient): (WebInspectorFrontendClient::attachAvailabilityChanged): (WebInspectorFrontendClient::frontendLoaded): (WebInspectorFrontendClient::localizedStringsURL): (WebInspectorFrontendClient::bringToFront): (WebInspectorFrontendClient::closeWindow): (WebInspectorFrontendClient::disconnectFromBackend): (WebInspectorFrontendClient::attachWindow): (WebInspectorFrontendClient::detachWindow): (WebInspectorFrontendClient::setAttachedWindowHeight): (WebInspectorFrontendClient::setAttachedWindowWidth): (WebInspectorFrontendClient::setToolbarHeight): (WebInspectorFrontendClient::inspectedURLChanged): (WebInspectorFrontendClient::updateWindowTitle): (WebInspectorFrontendClient::save): (WebInspectorFrontendClient::append):