2020-05-07 Russell Epstein <repstein@apple.com> Cherry-pick r260832. rdar://problem/62978877 [Mac] Adopt kMTSupportNotification_ShouldPlayHDRVideoChanged notification https://bugs.webkit.org/show_bug.cgi?id=211028 Reviewed by Eric Carlson. Source/WebCore/PAL: Make MediaToolboxSoftLink fully exported from PAL. * pal/cf/CoreMediaSoftLink.cpp: * pal/cocoa/MediaToolboxSoftLink.cpp: * pal/cocoa/MediaToolboxSoftLink.h: Source/WebKit: Adopt a new notification which signals that the receiver should re-query for HDR support. * UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::webProcessPoolHighDynamicRangeDidChangeCallback): (WebKit::WebProcessPool::registerHighDynamicRangeChangeCallback): * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::registerHighDynamicRangeChangeCallback): (WebKit::WebProcessPool::initializeNewWebProcess): * UIProcess/WebProcessPool.h: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260832 268f45cc-cd09-0410-ab3c-d52691b4dbfc 2020-04-28 Jer Noble <jer.noble@apple.com> [Mac] Adopt kMTSupportNotification_ShouldPlayHDRVideoChanged notification https://bugs.webkit.org/show_bug.cgi?id=211028 Reviewed by Eric Carlson. Make MediaToolboxSoftLink fully exported from PAL. * pal/cf/CoreMediaSoftLink.cpp: * pal/cocoa/MediaToolboxSoftLink.cpp: * pal/cocoa/MediaToolboxSoftLink.h: 2020-04-07 Russell Epstein <repstein@apple.com> Cherry-pick r259388. rdar://problem/61269730 [iOS] Allow WebKit to use camera in multi-tasking mode https://bugs.webkit.org/show_bug.cgi?id=209904 Reviewed by Youenn Fablet. Source/WebCore: * platform/mediastream/mac/AVVideoCaptureSource.mm: (WebCore::AVVideoCaptureSource::setupSession): Source/WebCore/PAL: * pal/cocoa/AVFoundationSoftLink.h: * pal/cocoa/AVFoundationSoftLink.mm: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259388 268f45cc-cd09-0410-ab3c-d52691b4dbfc 2020-04-02 Eric Carlson <eric.carlson@apple.com> [iOS] Allow WebKit to use camera in multi-tasking mode https://bugs.webkit.org/show_bug.cgi?id=209904 Reviewed by Youenn Fablet. * pal/cocoa/AVFoundationSoftLink.h: * pal/cocoa/AVFoundationSoftLink.mm: 2020-02-17 Alan Coon <alancoon@apple.com> Cherry-pick r255881. rdar://problem/59447271 Adopt MTOverrideShouldPlayHDRVideo() https://bugs.webkit.org/show_bug.cgi?id=207275 <rdar://problem/58837093> Reviewed by Eric Carlson. Source/WebCore: * platform/PlatformScreen.h: * platform/mac/PlatformScreenMac.mm: (WebCore::setShouldOverrideScreenSupportsHighDynamicRange): Source/WebCore/PAL: * pal/cocoa/MediaToolboxSoftLink.cpp: * pal/cocoa/MediaToolboxSoftLink.h: Source/WebKit: The WebProcess sandbox can block access to the services necessary for MediaToolbox to determine whether the current display is capable of displaying HDR. Rather than opening up the sandbox, provide the information gathered by the UIProcess by way of MTOverrideShouldPlayHDRVideo(). * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::windowScreenDidChange): (WebKit::WebPage::displayID const): * WebProcess/WebPage/WebPage.h: * WebProcess/WebProcess.cpp: (WebKit::WebProcess::setScreenProperties): Deleted. * WebProcess/WebProcess.h: * WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::setScreenProperties): (WebKit::WebProcess::updatePageScreenProperties): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255881 268f45cc-cd09-0410-ab3c-d52691b4dbfc 2020-02-05 Jer Noble <jer.noble@apple.com> Adopt MTOverrideShouldPlayHDRVideo() https://bugs.webkit.org/show_bug.cgi?id=207275 <rdar://problem/58837093> Reviewed by Eric Carlson. * pal/cocoa/MediaToolboxSoftLink.cpp: * pal/cocoa/MediaToolboxSoftLink.h: 2020-02-14 Russell Epstein <repstein@apple.com> Cherry-pick r256320. rdar://problem/59447006 AX: Wrong includes for internal SDK https://bugs.webkit.org/show_bug.cgi?id=207554 Reviewed by Chris Dumez. * pal/spi/mac/HIServicesSPI.h: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256320 268f45cc-cd09-0410-ab3c-d52691b4dbfc 2020-02-11 Chris Fleizach <cfleizach@apple.com> AX: Wrong includes for internal SDK https://bugs.webkit.org/show_bug.cgi?id=207554 Reviewed by Chris Dumez. * pal/spi/mac/HIServicesSPI.h: 2020-02-13 Russell Epstein <repstein@apple.com> Revert r256407. rdar://problem/59299143 2020-02-11 Alan Coon <alancoon@apple.com> Cherry-pick r255881. rdar://problem/59299143 Adopt MTOverrideShouldPlayHDRVideo() https://bugs.webkit.org/show_bug.cgi?id=207275 <rdar://problem/58837093> Reviewed by Eric Carlson. Source/WebCore: * platform/PlatformScreen.h: * platform/mac/PlatformScreenMac.mm: (WebCore::setShouldOverrideScreenSupportsHighDynamicRange): Source/WebCore/PAL: * pal/cocoa/MediaToolboxSoftLink.cpp: * pal/cocoa/MediaToolboxSoftLink.h: Source/WebKit: The WebProcess sandbox can block access to the services necessary for MediaToolbox to determine whether the current display is capable of displaying HDR. Rather than opening up the sandbox, provide the information gathered by the UIProcess by way of MTOverrideShouldPlayHDRVideo(). * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::windowScreenDidChange): (WebKit::WebPage::displayID const): * WebProcess/WebPage/WebPage.h: * WebProcess/WebProcess.cpp: (WebKit::WebProcess::setScreenProperties): Deleted. * WebProcess/WebProcess.h: * WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::setScreenProperties): (WebKit::WebProcess::updatePageScreenProperties): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255881 268f45cc-cd09-0410-ab3c-d52691b4dbfc 2020-02-05 Jer Noble <jer.noble@apple.com> Adopt MTOverrideShouldPlayHDRVideo() https://bugs.webkit.org/show_bug.cgi?id=207275 <rdar://problem/58837093> Reviewed by Eric Carlson. * pal/cocoa/MediaToolboxSoftLink.cpp: * pal/cocoa/MediaToolboxSoftLink.h: 2020-02-04 Russell Epstein <repstein@apple.com> Cherry-pick r255461. rdar://problem/59153618 Add WKNavigationDelegate SPI to disable TLS 1.0 and 1.1 https://bugs.webkit.org/show_bug.cgi?id=206979 Reviewed by Brady Eidson. Source/WebCore/PAL: * pal/spi/cf/CFNetworkSPI.h: Source/WebKit: * NetworkProcess/NetworkCORSPreflightChecker.cpp: (WebKit::NetworkCORSPreflightChecker::didReceiveChallenge): * NetworkProcess/NetworkCORSPreflightChecker.h: * NetworkProcess/NetworkDataTask.h: * NetworkProcess/NetworkLoad.cpp: (WebKit::NetworkLoad::didReceiveChallenge): * NetworkProcess/NetworkLoad.h: * NetworkProcess/NetworkProcessCreationParameters.cpp: (WebKit::NetworkProcessCreationParameters::encode const): (WebKit::NetworkProcessCreationParameters::decode): * NetworkProcess/NetworkProcessCreationParameters.h: * NetworkProcess/NetworkSessionCreationParameters.cpp: (WebKit::NetworkSessionCreationParameters::encode const): (WebKit::NetworkSessionCreationParameters::decode): * NetworkProcess/NetworkSessionCreationParameters.h: * NetworkProcess/PingLoad.cpp: (WebKit::PingLoad::didReceiveChallenge): * NetworkProcess/PingLoad.h: * NetworkProcess/cocoa/NetworkDataTaskCocoa.h: * NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): (WebKit::NetworkDataTaskCocoa::didReceiveChallenge): (WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection): * NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa): * NetworkProcess/cocoa/NetworkSessionCocoa.h: * NetworkProcess/cocoa/NetworkSessionCocoa.mm: (processServerTrustEvaluation): (-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]): (WebKit::NetworkSessionCocoa::NetworkSessionCocoa): (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge): * Shared/Authentication/AuthenticationManager.cpp: (WebKit::AuthenticationManager::didReceiveAuthenticationChallenge): * Shared/Authentication/AuthenticationManager.h: * UIProcess/API/APINavigationClient.h: (API::NavigationClient::shouldAllowLegacyTLS): * UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h: * UIProcess/Cocoa/NavigationState.h: * UIProcess/Cocoa/NavigationState.mm: (WebKit::NavigationState::setNavigationDelegate): (WebKit::systemAllowsLegacyTLSFor): (WebKit::NavigationState::NavigationClient::shouldAllowLegacyTLS): * UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeNetworkProcess): * UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::didReceiveAuthenticationChallenge): * UIProcess/Network/NetworkProcessProxy.h: * UIProcess/Network/NetworkProcessProxy.messages.in: * UIProcess/WebPageProxy.cpp: * UIProcess/WebPageProxy.h: * UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::parameters): * UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h: Source/WebKitLegacy/mac: * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Tools: * MiniBrowser/mac/SettingsController.m: * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (-[TLSNavigationDelegate waitForDidFinishNavigation]): (-[TLSNavigationDelegate waitForDidFailProvisionalNavigation]): (-[TLSNavigationDelegate receivedShouldAllowLegacyTLS]): (-[TLSNavigationDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]): (-[TLSNavigationDelegate webView:didFinishNavigation:]): (-[TLSNavigationDelegate webView:didFailProvisionalNavigation:withError:]): (-[TLSNavigationDelegate _webView:authenticationChallenge:shouldAllowLegacyTLS:]): (TestWebKitAPI::TEST): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255461 268f45cc-cd09-0410-ab3c-d52691b4dbfc 2020-01-30 Alex Christensen <achristensen@webkit.org> Add WKNavigationDelegate SPI to disable TLS 1.0 and 1.1 https://bugs.webkit.org/show_bug.cgi?id=206979 Reviewed by Brady Eidson. * pal/spi/cf/CFNetworkSPI.h: 2020-02-03 Russell Epstein <repstein@apple.com> Cherry-pick r255532. rdar://problem/59098561 Add support for specifying background colors when setting marked text https://bugs.webkit.org/show_bug.cgi?id=207065 <rdar://problem/57876140> Reviewed by Tim Horton. Source/WebCore: Add support for rendering custom highlights (background colors) behind marked text in WebCore. To do this, we plumb a Vector of CompositionHighlights alongside the Vector of CompositionUnderlines to Editor. At paint time, we then consult this highlight data to determine which ranges of text in the composition should paint using custom background colors. Note that in the future, we should consider refactoring both composition underlines and highlights to use the MarkedText mechanism for decorating ranges of text instead. Test: editing/input/composition-highlights.html * Headers.cmake: * WebCore.xcodeproj/project.pbxproj: * editing/CompositionHighlight.h: Added. (WebCore::CompositionHighlight::CompositionHighlight): (WebCore::CompositionHighlight::encode const): (WebCore::CompositionHighlight::decode): Add CompositionHighlight, which represents a range in the composition that should be highlighted with a given background color. * editing/Editor.cpp: (WebCore::Editor::clear): (WebCore::Editor::setComposition): Add logic for clearing and updating m_customCompositionHighlights. * editing/Editor.h: (WebCore::Editor::compositionUsesCustomHighlights const): (WebCore::Editor::customCompositionHighlights const): * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintCompositionBackground): If custom composition highlights are given, use those when painting the composition background; otherwise, default to painting the entire composition range using `Color::compositionFill`. Source/WebCore/PAL: Add an SPI soft-linking declaration for NSMarkedClauseSegmentAttributeName. * pal/spi/cocoa/NSAttributedStringSPI.h: Source/WebKit: Implement -setAttributedMarkedText:selectedRange: on WKContentView, and have it extract highlight color information from the given attributed string. Plumb this through to the web process by serializing and deserializing `WebCore::CompositionHighlight`s. * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::setMarkedText): * UIProcess/WebPageProxy.cpp: * UIProcess/WebPageProxy.h: * UIProcess/ios/WKContentViewInteraction.mm: (compositionHighlights): For each marked text clause, grab the specified background color (defaulting to Color::compositionFill) and use it to create a list of CompositionHighlights. (-[WKContentView setAttributedMarkedText:selectedRange:]): (-[WKContentView setMarkedText:selectedRange:]): (-[WKContentView _setMarkedText:highlights:selectedRange:]): * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSetComposition): Add testing support for specifying highlight ranges when setting marked text. * WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: * WebProcess/WebCoreSupport/glib/WebEditorClientGLib.cpp: (WebKit::WebEditorClient::didDispatchInputMethodKeydown): * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setCompositionForTesting): (WebKit::WebPage::setCompositionAsync): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: Source/WebKitLegacy/mac: Adjust some call sites of Editor::setComposition(). * WebView/WebFrame.mm: (-[WebFrame setMarkedText:selectedRange:]): (-[WebFrame setMarkedText:forCandidates:]): * WebView/WebHTMLView.mm: (-[WebHTMLView setMarkedText:selectedRange:]): Source/WebKitLegacy/win: Adjust some call sites of Editor::setComposition(). * WebView.cpp: (WebView::onIMEComposition): (WebView::setCompositionForTesting): Tools: Add support in WebKitTestRunner for specifying a list of highlight ranges when setting marked text. This comes in the form of an additional argument to TextInputController::setMarkedText, which contains an array of objects, each describing one range (in the composition) to highlight. * DumpRenderTree/ios/TextInputControllerIOS.m: (+[TextInputController isSelectorExcludedFromWebScript:]): (+[TextInputController webScriptNameForSelector:]): (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:highlights:]): (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]): Deleted. * DumpRenderTree/mac/TextInputControllerMac.m: (+[TextInputController isSelectorExcludedFromWebScript:]): (+[TextInputController webScriptNameForSelector:]): (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:highlights:]): (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]): Deleted. * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl: * WebKitTestRunner/InjectedBundle/TextInputController.cpp: (WTR::arrayLength): (WTR::createCompositionHighlightData): Add logic to convert a given JSObject containing the composition highlight information into a WKArrayRef, which is then passed into WebKit via WKBundlePageSetComposition. (WTR::TextInputController::setMarkedText): * WebKitTestRunner/InjectedBundle/TextInputController.h: LayoutTests: Add a test to check that highlighting different parts of a composition range results in the same behavior as applying background colors using CSS. This test is currently only supported in WebKit2. * TestExpectations: * editing/input/composition-highlights-expected.html: Added. * editing/input/composition-highlights.html: Added. * platform/wk2/TestExpectations: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255532 268f45cc-cd09-0410-ab3c-d52691b4dbfc 2020-01-31 Wenson Hsieh <wenson_hsieh@apple.com> Add support for specifying background colors when setting marked text https://bugs.webkit.org/show_bug.cgi?id=207065 <rdar://problem/57876140> Reviewed by Tim Horton. Add an SPI soft-linking declaration for NSMarkedClauseSegmentAttributeName. * pal/spi/cocoa/NSAttributedStringSPI.h: 2020-01-15 Alan Coon <alancoon@apple.com> Cherry-pick r254187. rdar://problem/58605950 Implement css3-images image-orientation https://bugs.webkit.org/show_bug.cgi?id=89052 Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-01-07 Reviewed by Simon Fraser. LayoutTests/imported/w3c: * web-platform-tests/css/css-images/inheritance-expected.txt: * web-platform-tests/css/css-images/inheritance.html: This test is re-synced from upstream * web-platform-tests/css/css-images/parsing/image-orientation-computed-expected.txt: * web-platform-tests/css/css-images/parsing/image-orientation-valid-expected.txt: Source/JavaScriptCore: Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag. * Configurations/FeatureDefines.xcconfig: Source/WebCore: Implement the CSS image-orientation property for content images. The valid values are "from-image" or "none". The default value is "from-image". Specification: https://drafts.csswg.org/css-images-3/#the-image-orientation GitHub issue: https://github.com/w3c/csswg-drafts/issues/4164 Tests: fast/images/image-orientation-dynamic-from-image.html fast/images/image-orientation-dynamic-none.html fast/images/image-orientation-none.html * Configurations/FeatureDefines.xcconfig: * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::operator ImageOrientation const): Deleted. * css/CSSProperties.json: * css/CSSValueKeywords.in: * css/parser/CSSPropertyParser.cpp: (WebCore::consumeImageOrientation): (WebCore::CSSPropertyParser::parseSingleValue): * rendering/RenderElement.cpp: (WebCore::RenderElement::imageOrientation const): * rendering/RenderImage.cpp: (WebCore::RenderImage::styleDidChange): * rendering/style/RenderStyle.cpp: (WebCore::rareInheritedDataChangeRequiresLayout): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::setImageOrientation): (WebCore::RenderStyle::initialImageOrientation): (WebCore::RenderStyle::imageOrientation const): * rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator== const): * rendering/style/StyleRareInheritedData.h: * style/StyleBuilderConverter.h: (WebCore::Style::BuilderConverter::convertImageOrientation): Source/WebCore/PAL: Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag. * Configurations/FeatureDefines.xcconfig: Source/WebKit: Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag. * Configurations/FeatureDefines.xcconfig: Source/WebKitLegacy/mac: Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag. * Configurations/FeatureDefines.xcconfig: Source/WTF: Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag. * wtf/FeatureDefines.h: Tools: Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag. * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: LayoutTests: Test the css image-orientation property. * fast/images/image-orientation-dynamic-from-image-expected.html: Added. * fast/images/image-orientation-dynamic-from-image.html: Added. * fast/images/image-orientation-dynamic-none-expected.html: Added. * fast/images/image-orientation-dynamic-none.html: Added. * fast/images/image-orientation-none-expected.html: Added. * fast/images/image-orientation-none.html: Added. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254187 268f45cc-cd09-0410-ab3c-d52691b4dbfc 2020-01-07 Said Abou-Hallawa <sabouhallawa@apple.com> Implement css3-images image-orientation https://bugs.webkit.org/show_bug.cgi?id=89052 Reviewed by Simon Fraser. Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag. * Configurations/FeatureDefines.xcconfig: 2020-01-14 Alan Coon <alancoon@apple.com> Cherry-pick r254141. rdar://problem/58559202 Flaky API Test: TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS https://bugs.webkit.org/show_bug.cgi?id=194340 <rdar://problem/50507254> Reviewed by Eric Carlson. Workaround for AVFoundation crash for OS versions prior to platform fix. This crash occurrs infrequently while triggering KVO due to an internal @property change. Work around the crash by disabling KVO for that property at runtime, by injecting a new class method +automaticallyNotifiesObserversOfSuppressesVideoLayers immediately after soft linking the AVFoundation library. * pal/cocoa/AVFoundationSoftLink.mm: (PAL::justReturnsNO): (PAL::AVFoundationLibrary): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254141 268f45cc-cd09-0410-ab3c-d52691b4dbfc 2020-01-07 Jer Noble <jer.noble@apple.com> Flaky API Test: TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS https://bugs.webkit.org/show_bug.cgi?id=194340 <rdar://problem/50507254> Reviewed by Eric Carlson. Workaround for AVFoundation crash for OS versions prior to platform fix. This crash occurrs infrequently while triggering KVO due to an internal @property change. Work around the crash by disabling KVO for that property at runtime, by injecting a new class method +automaticallyNotifiesObserversOfSuppressesVideoLayers immediately after soft linking the AVFoundation library. * pal/cocoa/AVFoundationSoftLink.mm: (PAL::justReturnsNO): (PAL::AVFoundationLibrary): 2020-01-14 Alan Coon <alancoon@apple.com> Cherry-pick r254042. rdar://problem/58549102 Source/WebCore/PAL: DumpRenderTree doesn't always call updateRendering() when a test completes https://bugs.webkit.org/show_bug.cgi?id=205761 Reviewed by Darin Adler. Add -[CATransaction synchronize]. * pal/spi/cocoa/QuartzCoreSPI.h: Source/WebKit: DumpRenderTree doesn't always call updateRendering() when a test completes https://bugs.webkit.org/show_bug.cgi?id=205761 Reviewed by Darin Adler. Use the QuartzCore SPI header. * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: Source/WebKitLegacy/mac: Fix a souce of WebKit1 test flakiness https://bugs.webkit.org/show_bug.cgi?id=205761 Reviewed by Darin Adler. Some animation tests (and possibly many others) are flakey or broken in WK1 because there was no code to guarantee that Page::updateRendering() was called at notifyDone() time. WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers, and flushes a CATransaction. In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView, and just called [webView display] to make this happen. However, with layer backing, AppKit behavior changes, and WebCore changes that make more things happen with HTML event loop timing, this approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what WK2 is doing. * WebView/WebView.mm: (-[WebView _forceRepaintForTesting]): * WebView/WebViewPrivate.h: Tools: DumpRenderTree doesn't always call updateRendering() when a test completes https://bugs.webkit.org/show_bug.cgi?id=205761 Reviewed by Darin Adler. Some animation tests (and possibly many others) are flakey or broken in WK1 because there was no code to guarantee that Page::updateRendering() was called at notifyDone() time. WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers, and flushes a CATransaction. In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView, and just called [webView display] to make this happen. However, with layer backing, AppKit behavior changes, and WebCore changes that make more things happen with HTML event loop timing, this approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what WK2 is doing. * DumpRenderTree/mac/DumpRenderTree.mm: (updateDisplay): * DumpRenderTree/mac/PixelDumpSupportMac.mm: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254042 268f45cc-cd09-0410-ab3c-d52691b4dbfc 2020-01-05 Simon Fraser <simon.fraser@apple.com> DumpRenderTree doesn't always call updateRendering() when a test completes https://bugs.webkit.org/show_bug.cgi?id=205761 Reviewed by Darin Adler. Add -[CATransaction synchronize]. * pal/spi/cocoa/QuartzCoreSPI.h: 2020-01-13 Alan Coon <alancoon@apple.com> Cherry-pick r254257. rdar://problem/58530962 Don't softlink AVCapture classes on watchOS or tvOS https://bugs.webkit.org/show_bug.cgi?id=205974 <rdar://problem/45508044> Reviewed by Jon Lee. * pal/cocoa/AVFoundationSoftLink.h: * pal/cocoa/AVFoundationSoftLink.mm: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254257 268f45cc-cd09-0410-ab3c-d52691b4dbfc 2020-01-09 Eric Carlson <eric.carlson@apple.com> Don't softlink AVCapture classes on watchOS or tvOS https://bugs.webkit.org/show_bug.cgi?id=205974 <rdar://problem/45508044> Reviewed by Jon Lee. * pal/cocoa/AVFoundationSoftLink.h: * pal/cocoa/AVFoundationSoftLink.mm: 2019-12-20 Alex Christensen <achristensen@webkit.org> Allow a managed configuration to re-enable TLS 1.0 and 1.1 https://bugs.webkit.org/show_bug.cgi?id=205479 <rdar://problem/54493516> Reviewed by Geoffrey Garen. Manually verified using the managed configuration attached to rdar://problem/56727605 * PAL.xcodeproj/project.pbxproj: * pal/ios/ManagedConfigurationSoftLink.h: Added. * pal/ios/ManagedConfigurationSoftLink.mm: Added. * pal/spi/ios/ManagedConfigurationSPI.h: Copied from Source/WebKit/Platform/spi/ios/ManagedConfigurationSPI.h. 2019-12-19 Wenson Hsieh <wenson_hsieh@apple.com> pal/FileSizeFormatter.h declares fileSizeDescription in the top-level namespace https://bugs.webkit.org/show_bug.cgi?id=205453 Reviewed by Tim Horton. Move fileSizeDescription to the PAL namespace. * pal/FileSizeFormatter.cpp: (fileSizeDescription): Deleted. * pal/FileSizeFormatter.h: * pal/cocoa/FileSizeFormatterCocoa.mm: (fileSizeDescription): Deleted. 2019-12-18 Ben Nham <nham@apple.com> Add network loading signposts https://bugs.webkit.org/show_bug.cgi?id=204822 <rdar://problem/57608824> Reviewed by Alex Christensen. This adds os_signposts related to network loads to aid in debugging networking performance issues. Since URLs are logged in the signposts, this capability is only enabled on Apple internal builds when an environment variable is set. * PAL.xcodeproj/project.pbxproj: * pal/PlatformMac.cmake: * pal/spi/cocoa/OSVariantSPI.h: Added. 2019-12-05 Chris Dumez <cdumez@apple.com> [IPC] Fail PAL::SessionID decoding if the decoded integer is not a valid session ID https://bugs.webkit.org/show_bug.cgi?id=204917 <rdar://problem/53418119> Reviewed by Ryosuke Niwa. Fail PAL::SessionID IPC decoding if the decoded integer is not a valid session ID. This makes our IPC more robust to bad input and makes sure we don't try to lookup an invalid sessionID from a HashMap as a result of a bad IPC. * pal/SessionID.h: (PAL::SessionID::decode): 2019-12-04 Tim Horton <timothy_horton@apple.com> Introduce a GPU process https://bugs.webkit.org/show_bug.cgi?id=204343 Reviewed by Simon Fraser. * Configurations/FeatureDefines.xcconfig: 2019-12-03 Jer Noble <jer.noble@apple.com> Adopt AVContentKeyReportGroup https://bugs.webkit.org/show_bug.cgi?id=204765 Reviewed by Eric Carlson. * pal/cocoa/AVFoundationSoftLink.h: * pal/cocoa/AVFoundationSoftLink.mm: * pal/spi/mac/AVFoundationSPI.h: 2019-11-28 Fujii Hironori <Hironori.Fujii@sony.com> Remove ENABLE_KEYBOARD_CODE_ATTRIBUTE and ENABLE_KEYBOARD_KEY_ATTRIBUTE macros https://bugs.webkit.org/show_bug.cgi?id=204666 Reviewed by Ross Kirsling and Don Olmstead. * Configurations/FeatureDefines.xcconfig: 2019-11-25 Fujii Hironori <Hironori.Fujii@sony.com> Ran sort-Xcode-project-file. Unreviewed. * PAL.xcodeproj/project.pbxproj: 2019-11-21 Jer Noble <jer.noble@apple.com> Experimental support for HDR media query https://bugs.webkit.org/show_bug.cgi?id=204422 Reviewed by Eric Carlson. * PAL.xcodeproj/project.pbxproj: * pal/PlatformMac.cmake: * pal/cocoa/MediaToolboxSoftLink.cpp: Renamed from Source/WebCore/platform/cocoa/MediaToolboxSoftLink.h. * pal/cocoa/MediaToolboxSoftLink.h: Renamed from Source/WebCore/platform/cocoa/MediaToolboxSoftLink.cpp. 2019-11-15 Eric Carlson <eric.carlson@apple.com> Don't use AVCapture on watchOS and tvOS https://bugs.webkit.org/show_bug.cgi?id=204254 <rdar://problem/45508044> Reviewed by Youenn Fablet. * Configurations/FeatureDefines.xcconfig: 2019-11-15 Myles C. Maxfield <mmaxfield@apple.com> [Apple] Enable variation fonts on all Apple platforms https://bugs.webkit.org/show_bug.cgi?id=198100 Reviewed by Simon Fraser. * Configurations/FeatureDefines.xcconfig: 2019-11-06 Eric Liang <ericliang@apple.com> AX: WKWebView does not shift Accessibility Focus for Catalyst (203798) https://bugs.webkit.org/show_bug.cgi?id=203798 Reviewed by Chris Fleizach. Changed the path of NSAccessibilitySPI from Mac to Cocoa * PAL.xcodeproj/project.pbxproj: * pal/spi/cocoa/NSAccessibilitySPI.h: Renamed from Source/WebCore/PAL/pal/spi/mac/NSAccessibilitySPI.h. 2019-11-02 Devin Rousso <drousso@apple.com> Web Inspector: Add diagnostic logging for frontend feature usage https://bugs.webkit.org/show_bug.cgi?id=203579 <rdar://problem/56717410> Reviewed by Brian Burg. Original patch by Matt Baker <mattbaker@apple.com>. * Configurations/FeatureDefines.xcconfig: Add `ENABLE_INSPECTOR_TELEMETRY`, which is only enabled for macOS. 2019-10-31 Alex Christensen <achristensen@apple.com> Enable more features in Mac CMake build https://bugs.webkit.org/show_bug.cgi?id=203699 Rubber-stamped by Tim Horton. * pal/CMakeLists.txt: * pal/PlatformMac.cmake: 2019-10-30 Peng Liu <peng.liu6@apple.com> [Picture-in-Picture Web API] Enable the support for iOS https://bugs.webkit.org/show_bug.cgi?id=202618 Reviewed by Jer Noble. Enable the Picture-in-Picture API support for iOS (iPad only). * Configurations/FeatureDefines.xcconfig: 2019-10-26 Chris Lord <clord@igalia.com> Put OffscreenCanvas behind a build flag https://bugs.webkit.org/show_bug.cgi?id=203146 Reviewed by Ryosuke Niwa. * Configurations/FeatureDefines.xcconfig: 2019-10-25 Eric Carlson <eric.carlson@apple.com> Support for callbacks for manifest events https://bugs.webkit.org/show_bug.cgi?id=202101 <rdar://problem/54277362> Reviewed by Jer Noble. * pal/cocoa/AVFoundationSoftLink.h: * pal/cocoa/AVFoundationSoftLink.mm: 2019-10-25 Andy Estes <aestes@apple.com> [Quick Look] Move the QLPreviewConverter delegate into PreviewConverter and vend a C++ client interface https://bugs.webkit.org/show_bug.cgi?id=203396 Reviewed by Alex Christensen. * pal/spi/ios/QuickLookSPI.h: 2019-10-15 Peng Liu <peng.liu6@apple.com> [Picture-in-Picture Web API] Implement HTMLVideoElement.requestPictureInPicture() / Document.exitPictureInPicture() https://bugs.webkit.org/show_bug.cgi?id=201024 Reviewed by Eric Carlson. Add configurations for the Picture-in-Picture API. * Configurations/FeatureDefines.xcconfig: 2019-10-07 Alexey Proskuryakov <ap@apple.com> Build failure in WebHTMLView.mm with the public SDK (Xcode 11 and Mojave) https://bugs.webkit.org/show_bug.cgi?id=199705 Patch by Dan Bernstein and Kenneth Russell. Reviewed by Alexey Proskuryakov. * pal/spi/mac/NSViewSPI.h: Declare _subviews when we are not using the replacement SPI, but the SDK doesn't declare the ivar (because the SDK is too new). 2019-10-04 Alex Christensen <achristensen@webkit.org> Simplify sandbox enabling macros https://bugs.webkit.org/show_bug.cgi?id=202536 Reviewed by Brent Fulgham. * Configurations/FeatureDefines.xcconfig: 2019-10-01 Alex Christensen <achristensen@webkit.org> Progress towards a functioning CMake build on Mac https://bugs.webkit.org/show_bug.cgi?id=202443 Rubber-stamped by Tim Horton. * pal/PlatformMac.cmake: 2019-10-01 Alex Christensen <achristensen@webkit.org> Progress towards successful CMake build on Mac https://bugs.webkit.org/show_bug.cgi?id=202426 Rubber-stamped by Tim Horton. * pal/PlatformMac.cmake: 2019-10-01 Keith Rollin <krollin@apple.com> Remove some support for < iOS 13 https://bugs.webkit.org/show_bug.cgi?id=202386 <rdar://problem/55863017> Reviewed by Eric Carlson. Remove some support for iOS versions less than 13.0. Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have values >= 130000. This means that expressions like "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True. This removal is part of a series of patches effecting the removal of dead code for old versions of iOS. This particular pass involves changes in which Jer Noble was involved. These changes are isolated from other similar changes in order to facilitate the reviewing process. * pal/spi/cocoa/AVKitSPI.h: * pal/spi/mac/AVFoundationSPI.h: 2019-09-30 Alex Christensen <achristensen@webkit.org> Resurrect Mac CMake build https://bugs.webkit.org/show_bug.cgi?id=202384 Rubber-stamped by Tim Horton. * pal/PlatformMac.cmake: 2019-09-30 Alex Christensen <achristensen@webkit.org> Unify more WebKitLegacy sources https://bugs.webkit.org/show_bug.cgi?id=202390 Reviewed by Tim Horton. * pal/spi/mac/QuickLookMacSPI.h: 2019-09-27 Keith Rollin <krollin@apple.com> Coalesce or remove PLATFORM(MAC) || PLATFORM(IOS_FAMILY) https://bugs.webkit.org/show_bug.cgi?id=202119 <rdar://problem/55638792> Unreviewed, address post landing review comments for r248533 from Darin Adler. * pal/spi/cf/CFNetworkSPI.h: * pal/spi/cocoa/NEFilterSourceSPI.h: * pal/spi/mac/AVFoundationSPI.h: 2019-09-24 Keith Rollin <krollin@apple.com> Remove some support for < iOS 13 https://bugs.webkit.org/show_bug.cgi?id=201969 <rdar://problem/55505586> Reviewed by Jonathan Bedard. Remove some support for iOS versions less than 13.0. Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have values >= 130000. This means that expressions like "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True. This removal is part of a series of patches effecting the removal of dead code for old versions of iOS. This particular pass involves changes in which Jonathan Bedard was involved. These changes are isolated from other similar changes in order to facilitate the reviewing process. * pal/spi/cocoa/CoreTextSPI.h: * pal/spi/cocoa/QuartzCoreSPI.h: * pal/spi/ios/UIKitSPI.h: 2019-09-24 Keith Rollin <krollin@apple.com> Coalesce or remove PLATFORM(MAC) || PLATFORM(IOS_FAMILY) https://bugs.webkit.org/show_bug.cgi?id=202119 <rdar://problem/55638792> Reviewed by Alex Christensen. After refactoring and other code evolution, some platform checks have ended up looking like PLATFORM(MAC) || PLATFORM(IOS_FAMILY) (or vice-versa). These can be converted into the equivalent PLATFORM(COCOA). Where the instance occurs in a Cocoa-only file, the check can be removed altogether (along with any "#else" branches). * pal/spi/cf/CFNetworkSPI.h: * pal/spi/cocoa/NEFilterSourceSPI.h: * pal/spi/mac/AVFoundationSPI.h: 2019-09-20 Keith Rollin <krollin@apple.com> Remove some support for < iOS 13 https://bugs.webkit.org/show_bug.cgi?id=202027 <rdar://problem/55547109> Reviewed by Alex Christensen. Remove some support for iOS versions less than 13.0. Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have values >= 130000. This means that expressions like "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True. After version checks have been removed, there are some cases where the preprocessor conditional looks like "#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY)". These can be collapsed into "#if PLATFORM(COCOA)". This additional cleanup will be performed in a subsequent patch. This removal is part of a series of patches effecting the removal of dead code for old versions of iOS. This particular pass involves changes in which Joe Pecoraro was involved. These changes are isolated from other similar changes in order to facilitate the reviewing process. * pal/spi/cf/CFNetworkSPI.h: 2019-09-20 Keith Rollin <krollin@apple.com> Remove check of setSourceAppPid selector that's no longer needed https://bugs.webkit.org/show_bug.cgi?id=201971 <rdar://problem/55505761> Reviewed by Andy Estes. Bug 172152 introduced a check of the NEFilterSource selector setSourceAppPid in order to support OS's that didn't support it. All supported Cocoa platforms now support it, so the check can be removed. * pal/spi/cocoa/NEFilterSourceSPI.h: 2019-09-20 Keith Rollin <krollin@apple.com> Remove some support for < iOS 13 https://bugs.webkit.org/show_bug.cgi?id=201967 <rdar://problem/55504738> Reviewed by Andy Estes. Remove some support for iOS versions less than 13.0. Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have values >= 130000. This means that expressions like "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True. After version checks have been removed, there are some cases where the preprocessor conditional looks like "#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY)". These can be collapsed into "#if PLATFORM(COCOA)". This additional cleanup will be performed in a subsequent patch. This removal is part of a series of patches effecting the removal of dead code for old versions of iOS. This particular pass involves changes in which Andy Estes was involved. These changes are isolated from other similar changes in order to facilitate the reviewing process. * pal/spi/cocoa/NEFilterSourceSPI.h: 2019-09-20 Alex Christensen <achristensen@webkit.org> Remove functionality to disable TLS fallback https://bugs.webkit.org/show_bug.cgi?id=201998 Reviewed by Geoff Garen. * pal/spi/cf/CFNetworkSPI.h: 2019-09-18 Keith Rollin <krollin@apple.com> Remove alternate declaration of CCECCryptorImportKey https://bugs.webkit.org/show_bug.cgi?id=201903 <rdar://problem/55466589> Reviewed by Chris Dumez. In macOS 10.15 and iOS 13.0 SDKs, the keyPackage parameter of CCECCryptorImportKey() was changed from "void*" to "const void*". This change was accounted for in Bug 195754 by making the same change to the parallel declarations in CommonCryptoSPI.h. But since this header also needed to be used in macOS 10.14 contexts, the old declaration was also kept. But since this function is a "C" function, the types of parameters are not included in the function signature, and it doesn't really matter what parameter types are, so long as the right values are sent to the called function. This means that we don't need two versions of the function, one with a "const" parameter and one without. We only really need one. In this case, it makes sense to keep the more-restrictive one -- the with a "const void*" parameter. Therefore, remove the one taking just "void*". * pal/spi/cocoa/CommonCryptoSPI.h: 2019-09-18 Andy Estes <aestes@apple.com> [Apple Pay] Tell websites why a session was cancelled https://bugs.webkit.org/show_bug.cgi?id=201912 <rdar://problem/55469706> Reviewed by Brady Eidson. Soft-linked PKPassKitErrorDomain and included PassKit headers more judiciously. * pal/cocoa/PassKitSoftLink.h: * pal/cocoa/PassKitSoftLink.mm: * pal/spi/cocoa/PassKitSPI.h: 2019-09-17 Keith Rollin <krollin@apple.com> Remove some support for < iOS 12 https://bugs.webkit.org/show_bug.cgi?id=201851 <rdar://problem/55422044> Reviewed by Jiewen Tan and Alexey Proskuryakov. Remove some support for iOS versions less than 12.0. Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have values >= 120000. This means that expressions like "__IPHONE_OS_VERSION_MIN_REQUIRED < 101200" are always False and "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101200" are always True. This removal is part of a series of patches effecting such removal. * pal/spi/cocoa/IOSurfaceSPI.h: 2019-09-17 Jonathan Bedard <jbedard@apple.com> Follow-up: Provide a prototype for AR QuickLook to trigger processing in the originating page https://bugs.webkit.org/show_bug.cgi?id=201371 Unreviewed follow-up fix. * pal/spi/ios/SystemPreviewSPI.h: 2019-09-16 Dean Jackson <dino@apple.com> Provide a prototype for AR QuickLook to trigger processing in the originating page https://bugs.webkit.org/show_bug.cgi?id=201371 Hopefully fix the public iOS 13 build. * pal/spi/ios/SystemPreviewSPI.h: 2019-09-16 Dean Jackson <dino@apple.com> REGRESSION: iPad: Safari becomes unresponsive after context menu on 1-800-MY-APPLE phone number, tapping 'Add to Contacts' https://bugs.webkit.org/show_bug.cgi?id=201816 <rdar://55105827> Reviewed by Darin Adler. Expose kDataDetectorsSourceRectKey (and sort things while there). * pal/spi/ios/DataDetectorsUISPI.h: 2019-09-13 Youenn Fablet <youenn@apple.com> Use WebProcess processIdentifier to identify Service Worker connections https://bugs.webkit.org/show_bug.cgi?id=201459 Reviewed by Chris Dumez. * pal/SessionID.h: (PAL::SessionID::SessionID): 2019-09-12 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, rolling out r249801. Caused two servier worker layout tests to become flaky. Reverted changeset: "Use WebProcess processIdentifier to identify Service Worker connections" https://bugs.webkit.org/show_bug.cgi?id=201459 https://trac.webkit.org/changeset/249801 2019-09-12 Youenn Fablet <youenn@apple.com> Use WebProcess processIdentifier to identify Service Worker connections https://bugs.webkit.org/show_bug.cgi?id=201459 Reviewed by Chris Dumez. * pal/SessionID.h: (PAL::SessionID::SessionID): 2019-09-09 Alex Christensen <achristensen@webkit.org> Disable TLS 1.0 and 1.1 in WebSockets https://bugs.webkit.org/show_bug.cgi?id=201573 Reviewed by Youenn Fablet. * pal/spi/cf/CFNetworkSPI.h: 2019-08-30 Alex Christensen <achristensen@webkit.org> Remove HAVE_CFNETWORK_WITH_AUTO_ADDED_HTTP_HEADER_SUPPRESSION_SUPPORT conditional https://bugs.webkit.org/show_bug.cgi?id=201280 Reviewed by Youenn Fablet. * pal/spi/cf/CFNetworkSPI.h: 2019-08-29 Keith Rollin <krollin@apple.com> Remove HAVE_PASSKIT_GRANULAR_ERRORS conditional https://bugs.webkit.org/show_bug.cgi?id=201278 <rdar://problem/54821052> Reviewed by Alex Christensen. HAVE_PASSKIT_GRANULAR_ERRORS is always True, so remove the conditional tests, keeping the True branches and removing the False branches. * pal/cocoa/PassKitSoftLink.h: * pal/cocoa/PassKitSoftLink.mm: 2019-08-29 Keith Rollin <krollin@apple.com> Update .xcconfig symbols to reflect the current set of past and future product versions. https://bugs.webkit.org/show_bug.cgi?id=200720 <rdar://problem/54305032> Reviewed by Alex Christensen. Remove version symbols related to old OS's we no longer support, ensure that version symbols are defined for OS's we do support. * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: * Configurations/Version.xcconfig: 2019-08-29 Keith Rollin <krollin@apple.com> Remove CCBigNum fallback code https://bugs.webkit.org/show_bug.cgi?id=201250 <rdar://problem/54814330> Reviewed by Jiewen Tan. Bug 184637 added support for CCRSAGetCRTComponents, falling back to the older CCBigNum code if CCRSAGetCRTComponents was not available. We now only support OS's that have CCRSAGetCRTComponents so remove the fallback code. * pal/spi/cocoa/CommonCryptoSPI.h: 2019-08-29 Keith Rollin <krollin@apple.com> Remove support for macOS < 10.13 (part 3) https://bugs.webkit.org/show_bug.cgi?id=201224 <rdar://problem/54795934> Reviewed by Darin Adler. Remove symbols in WebKitTargetConditionals.xcconfig related to macOS 10.13, including WK_MACOS_1013 and WK_MACOS_BEFORE_1013, and suffixes like _MACOS_SINCE_1013. * Configurations/WebKitTargetConditionals.xcconfig: 2019-08-28 Keith Rollin <krollin@apple.com> Remove support for macOS < 10.13 (part 2) https://bugs.webkit.org/show_bug.cgi?id=201197 <rdar://problem/54759985> Reviewed by Darin Adler. Update conditionals that reference WK_MACOS_1013 and suffixes like _MACOS_SINCE_1013, assuming that we're always building on 10.13 or later and that these conditionals are always True or False. See Bug 200694 for earlier changes in this area. * Configurations/FeatureDefines.xcconfig: 2019-08-26 Jiewen Tan <jiewen_tan@apple.com> [WebAuthn] Support HID authenticators on iOS https://bugs.webkit.org/show_bug.cgi?id=201084 <rdar://problem/51908390> Reviewed by Youenn Fablet. * pal/spi/cocoa/IOKitSPI.h: Move IOHIDDevice.h and IOHIDManager.h to IOKitSPI.h given they are in iOS. 2019-08-22 Andy Estes <aestes@apple.com> [watchOS] Disable Content Filtering in the simulator build https://bugs.webkit.org/show_bug.cgi?id=201047 Reviewed by Tim Horton. * Configurations/FeatureDefines.xcconfig: 2019-08-22 Keith Rollin <krollin@apple.com> Remove support for tvOS < 13.0 https://bugs.webkit.org/show_bug.cgi?id=200963 <rdar://problem/54541355> Reviewed by Tim Horton. Update conditionals that reference __TV_OS_VERSION_MIN_REQUIRED and __TV_OS_VERSION_MAX_ALLOWED, assuming that they both have values >= 130000. This means that expressions like "__TV_OS_VERSION_MIN_REQUIRED < 130000" are always False and "__TV_OS_VERSION_MIN_REQUIRED >= 130000" are always True. * pal/spi/cocoa/NSKeyedArchiverSPI.h: * pal/spi/cocoa/NSProgressSPI.h: 2019-08-21 Keith Rollin <krollin@apple.com> Remove support for watchOS < 6.0 https://bugs.webkit.org/show_bug.cgi?id=200937 <rdar://problem/54524009> Reviewed by Darin Adler. Update conditionals that reference __WATCH_OS_VERSION_MIN_REQUIRED and __WATCH_OS_VERSION_MAX_ALLOWED, assuming that they both have values >= 60000. This means that expressions like "__WATCH_OS_VERSION_MIN_REQUIRED < 60000" are always False and "__WATCH_OS_VERSION_MIN_REQUIRED >= 60000" are always True. * pal/spi/cf/CFNetworkSPI.h: * pal/spi/cocoa/NSKeyedArchiverSPI.h: * pal/spi/cocoa/NSProgressSPI.h: 2019-08-19 Jer Noble <jer.noble@apple.com> [Cocoa] Adopt -preventDisplaySleepForVideoPlayback https://bugs.webkit.org/show_bug.cgi?id=200774 <rdar://problem/54321071> Reviewed by Eric Carlson. * pal/spi/mac/AVFoundationSPI.h: 2019-08-19 Youenn Fablet <youenn@apple.com> Remove SessionID::emptySessionID() https://bugs.webkit.org/show_bug.cgi?id=200811 Reviewed by Alex Christensen. Remove SessionID::emptySessionID and make it closer to a regular ObjectIdentifier. * pal/SessionID.cpp: * pal/SessionID.h: (PAL::SessionID::SessionID): (PAL::SessionID::isValid const): (PAL::SessionID::isEphemeral const): (PAL::SessionID::isHashTableDeletedValue const): (PAL::SessionID::toUInt64 const): (PAL::SessionID::operator== const): (PAL::SessionID::operator!= const): (PAL::SessionID::isolatedCopy const): (PAL::SessionID::operator bool const): (PAL::SessionID::isValidSessionIDValue): (PAL::SessionID::encode const): (PAL::SessionID::decode): (WTF::SessionIDHash::hash): (WTF::HashTraits<PAL::SessionID>::emptyValue): (WTF::HashTraits<PAL::SessionID>::constructDeletedValue): (WTF::HashTraits<PAL::SessionID>::isDeletedValue): 2019-08-18 Yusuke Suzuki <ysuzuki@apple.com> [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part https://bugs.webkit.org/show_bug.cgi?id=200620 Reviewed by Geoffrey Garen. * pal/crypto/openssl/CryptoDigestOpenSSL.cpp: (PAL::CryptoDigestContextImpl::create): * pal/system/ClockGeneric.cpp: (PAL::Clock::create): * pal/system/mac/ClockCM.mm: (Clock::create): 2019-08-14 Keith Rollin <krollin@apple.com> Remove support for macOS < 10.13 https://bugs.webkit.org/show_bug.cgi?id=200694 <rdar://problem/54278851> Reviewed by Youenn Fablet. Update conditionals that reference __MAC_OS_X_VERSION_MIN_REQUIRED and __MAC_OS_X_VERSION_MAX_ALLOWED, assuming that they both have values >= 101300. This means that expressions like "__MAC_OS_X_VERSION_MIN_REQUIRED < 101300" are always False and "__MAC_OS_X_VERSION_MIN_REQUIRED >= 101300" are always True. * pal/spi/cf/CFNetworkSPI.h: * pal/spi/cocoa/AVKitSPI.h: * pal/spi/cocoa/CommonCryptoSPI.h: * pal/spi/cocoa/IOSurfaceSPI.h: * pal/spi/cocoa/NEFilterSourceSPI.h: * pal/spi/cocoa/NSAttributedStringSPI.h: * pal/spi/cocoa/NSKeyedArchiverSPI.h: * pal/spi/cocoa/NSTouchBarSPI.h: * pal/spi/cocoa/PassKitSPI.h: * pal/spi/mac/AVFoundationSPI.h: 2019-08-14 Youenn Fablet <youenn@apple.com> Remove SessionID default constructor https://bugs.webkit.org/show_bug.cgi?id=200669 Reviewed by Alex Christensen. * pal/SessionID.h: 2019-08-14 Youenn Fablet <youenn@apple.com> Fail decoding an invalid SessionID https://bugs.webkit.org/show_bug.cgi?id=200663 Reviewed by Alex Christensen. * pal/SessionID.h: (PAL::SessionID::isValid const): (PAL::SessionID::isValidSessionIDValue): (PAL::SessionID::encode const): Add a release assert to catch bad sessionID senders. (PAL::SessionID::decode): Fail decoding if session ID is not a valid value. 2019-08-09 Tim Horton <timothy_horton@apple.com> Tapping buttons in Data Detectors lookup previews doesn't work https://bugs.webkit.org/show_bug.cgi?id=200579 <rdar://problem/54056519> Reviewed by Megan Gardner. * pal/spi/ios/DataDetectorsUISPI.h: 2019-08-07 Dean Jackson <dino@apple.com> Context menu on a universal link produces a blank preview https://bugs.webkit.org/show_bug.cgi?id=200485 <rdar://problem/53699620> Reviewed by Tim Horton. Use the umbrella #import. * pal/spi/cocoa/LaunchServicesSPI.h: 2019-08-06 Dean Jackson <dino@apple.com> Context menu on a universal link produces a blank preview https://bugs.webkit.org/show_bug.cgi?id=200485 <rdar://problem/53699620> Reviewed by Tim Horton. Define iTunesStoreURL from CoreServices. * pal/spi/cocoa/LaunchServicesSPI.h: 2019-08-07 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, rolling out r248330. Breaks internal builds. Reverted changeset: "Context menu on a universal link produces a blank preview" https://bugs.webkit.org/show_bug.cgi?id=200485 https://trac.webkit.org/changeset/248330 2019-08-07 Youenn Fablet <youenn@apple.com> ASSERT that a sessionID is valid when encoding it https://bugs.webkit.org/show_bug.cgi?id=199302 Reviewed by Darin Adler. ASSERT that a sessionID is valid at encoding/decoding time. * pal/SessionID.h: (PAL::SessionID::encode const): (PAL::SessionID::decode): 2019-08-06 Dean Jackson <dino@apple.com> Context menu on a universal link produces a blank preview https://bugs.webkit.org/show_bug.cgi?id=200485 <rdar://problem/53699620> Reviewed by Dean Jackson. Define iTunesStoreURL from CoreServices. * pal/spi/cocoa/LaunchServicesSPI.h: 2019-07-31 Youenn Fablet <youenn@apple.com> Use CTFontCreateForCharactersWithLanguageAndOption if available instead of CTFontCreateForCharactersWithLanguage https://bugs.webkit.org/show_bug.cgi?id=200241 <rdar://problem/53495386> Build fix for older MacOS for which CTFontFallbackOption is not defined. Unreviewed. * pal/spi/cocoa/CoreTextSPI.h: 2019-07-31 Youenn Fablet <youenn@apple.com> Use CTFontCreateForCharactersWithLanguageAndOption if available instead of CTFontCreateForCharactersWithLanguage https://bugs.webkit.org/show_bug.cgi?id=200241 Reviewed by Myles C. Maxfield. Add new SPI. * pal/spi/cocoa/CoreTextSPI.h: 2019-07-25 Brent Fulgham <bfulgham@apple.com> Use IWICBitmap (rather than ID2D1Bitmap) for NativeImagePtr on FTW https://bugs.webkit.org/show_bug.cgi?id=200093 Reviewed by Dean Jackson. * pal/PlatformFTW.cmake: 2019-07-24 Yusuke Suzuki <ysuzuki@apple.com> [bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not allocating too large VA https://bugs.webkit.org/show_bug.cgi?id=200103 Reviewed by Mark Lam. Move VMTag page memory investigation code from PAL to WTF to reuse it in TestWTF. * PAL.xcodeproj/project.pbxproj: * pal/PlatformMac.cmake: 2019-07-22 Simon Fraser <simon.fraser@apple.com> Make some constructors explicit https://bugs.webkit.org/show_bug.cgi?id=199981 Reviewed by Daniel Bates. Make explicit public constructors of objects that take POD or String& arguments, to reduce the changes of the compiler doing implicit conversions. * pal/system/cocoa/SleepDisablerCocoa.cpp: (PAL::SleepDisablerCocoa::SleepDisablerCocoa): * pal/system/cocoa/SleepDisablerCocoa.h: 2019-07-21 Myles C. Maxfield <mmaxfield@apple.com> [iOS] Fast and complex text codepaths disagree about how to lay out bopomofo with tone marks https://bugs.webkit.org/show_bug.cgi?id=199912 <rdar://problem/52182454> Reviewed by Simon Fraser. * pal/spi/cocoa/CoreTextSPI.h: 2019-07-17 Antoine Quint <graouts@apple.com> Disable Pointer Events prior to watchOS 6 https://bugs.webkit.org/show_bug.cgi?id=199890 <rdar://problem/53206113> Reviewed by Dean Jackson. * Configurations/FeatureDefines.xcconfig: 2019-07-11 Myles C. Maxfield <mmaxfield@apple.com> New York font erroneously gets synthetic bold https://bugs.webkit.org/show_bug.cgi?id=199653 <rdar://problem/51692592> Reviewed by Simon Fraser. * pal/spi/cocoa/CoreTextSPI.h: 2019-07-11 Jonathan Bedard <jbedard@apple.com> [iOS 13] Enable WebKit build https://bugs.webkit.org/show_bug.cgi?id=199481 <rdar://problem/52619048> Reviewed by Tim Horton. * pal/spi/cocoa/NSProgressSPI.h: We need the NSProgress SPI in public builds because NSProgress API is marked unavailable on iOS, watchOS and tvOS. * pal/spi/ios/CoreUISPI.h: Add CUIStyleEffectConfiguration.appearanceName SPI. * pal/spi/ios/DataDetectorsUISPI.h: Add UIContextMenuConfiguration.contextMenuConfigurationForURL SPI. * pal/spi/ios/SystemPreviewSPI.h: Add ARQuickLookWebKitItem.initWithPreviewItemProvider SPI. * pal/spi/ios/UIKitSPI.h: Add systemBrownColor, UIColor.tableCellDefaultSelectionTintColor should be marked nullable. * pal/spi/mac/AVFoundationSPI.h: Add AVOutputDevice.name SPI. 2019-07-10 Alex Christensen <achristensen@webkit.org> Allow CMake to build WebCore on Mac https://bugs.webkit.org/show_bug.cgi?id=198979 Reviewed by Don Olmstead. * pal/PlatformMac.cmake: 2019-07-08 Antoine Quint <graouts@apple.com> [Pointer Events] Enable only on the most recent version of the supported iOS family https://bugs.webkit.org/show_bug.cgi?id=199562 <rdar://problem/52766511> Reviewed by Dean Jackson. * Configurations/FeatureDefines.xcconfig: 2019-07-05 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, rolling out r247159. IndexedDB layout tests are failing the new assert. Reverted changeset: "ASSERT that a sessionID is valid when encoding it" https://bugs.webkit.org/show_bug.cgi?id=199302 https://trac.webkit.org/changeset/247159 2019-07-05 Youenn Fablet <youenn@apple.com> ASSERT that a sessionID is valid when encoding it https://bugs.webkit.org/show_bug.cgi?id=199302 Reviewed by Darin Adler. ASSERT that a sessionID is valid at encoding/decoding time. * pal/SessionID.h: (PAL::SessionID::encode const): (PAL::SessionID::decode): 2019-07-03 Jonathan Bedard <jbedard@apple.com> [Catalina] Enable WebKit build https://bugs.webkit.org/show_bug.cgi?id=199209 Reviewed by Darin Adler. * pal/spi/cf/CFNetworkSPI.h: Add new NSURLSessionConfiguration SPI. * pal/spi/mac/AVFoundationSPI.h: resourceConservationLevelWhilePaused should be defined after AVPlayerResourceConservationLevel. * pal/spi/mac/NSViewSPI.h: Add subviewsIvar. 2019-07-03 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, rolling out r246616. Caused http/tests/inspector/network/har/har-page.html to fail on Catalina. Reverted changeset: "Web Inspector: Network: replace CFNetwork SPI with new API where able" https://bugs.webkit.org/show_bug.cgi?id=198762 https://trac.webkit.org/changeset/246616 2019-06-28 Brent Fulgham <bfulgham@apple.com> [FTW] Build WebCore https://bugs.webkit.org/show_bug.cgi?id=199199 Reviewed by Don Olmstead. * pal/PlatformFTW.cmake: Added. 2019-06-28 Konstantin Tokarev <annulen@yandex.ru> Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733 https://bugs.webkit.org/show_bug.cgi?id=199317 Reviewed by Michael Catanzaro. While IconDatabase and all code using it was removed, ENABLE_ICONDATABASE still exists as build option and C++ macro. * Configurations/FeatureDefines.xcconfig: 2019-06-27 Beth Dakin <bdakin@apple.com> Upstream use of MACCATALYST https://bugs.webkit.org/show_bug.cgi?id=199245 rdar://problem/51687723 Reviewed by Tim Horton. * Configurations/Base.xcconfig: * Configurations/FeatureDefines.xcconfig: * Configurations/SDKVariant.xcconfig: * pal/spi/mac/AVFoundationSPI.h: 2019-06-27 Saam Barati <sbarati@apple.com> Make WEBGPU enabled only on Mojave and later. Rubber-stamped by Myles C. Maxfield. * Configurations/FeatureDefines.xcconfig: 2019-06-25 Alex Christensen <achristensen@webkit.org> Make HTTPCookieAcceptPolicy an enum class https://bugs.webkit.org/show_bug.cgi?id=199081 Reviewed by Michael Catanzaro * pal/spi/cf/CFNetworkSPI.h: 2019-06-19 Devin Rousso <drousso@apple.com> Web Inspector: Network: replace CFNetwork SPI with new API where able https://bugs.webkit.org/show_bug.cgi?id=198762 Reviewed by Timothy Hatcher. * pal/spi/cf/CFNetworkSPI.h: 2019-06-18 Dean Jackson <dino@apple.com> UIContextMenuInteraction implementation for WKContentView https://bugs.webkit.org/show_bug.cgi?id=198986 <rdar://problem/51875189> Reviewed by Andy Estes. Include + soft link DDContextMenuAction. * pal/spi/ios/DataDetectorsUISPI.h: 2019-06-18 Jiewen Tan <jiewen_tan@apple.com> Link to the new AppSSO private framework https://bugs.webkit.org/show_bug.cgi?id=198949 <rdar://problem/51281897> Reviewed by Brent Fulgham. * PAL.xcodeproj/project.pbxproj: * pal/cocoa/AppSSOSoftLink.h: * pal/cocoa/AppSSOSoftLink.mm: * pal/spi/cocoa/AppSSOSPI.h: Added. 2019-06-18 Truitt Savell <tsavell@apple.com> Unreviewed, rolling out r246534. Caused 45 webgpu/ tests to crash. Reverted changeset: "Link to the new AppSSO private framework" https://bugs.webkit.org/show_bug.cgi?id=198949 https://trac.webkit.org/changeset/246534 2019-06-18 Jiewen Tan <jiewen_tan@apple.com> Link to the new AppSSO private framework https://bugs.webkit.org/show_bug.cgi?id=198949 <rdar://problem/51281897> Reviewed by Brent Fulgham. * PAL.xcodeproj/project.pbxproj: * pal/cocoa/AppSSOSoftLink.h: * pal/cocoa/AppSSOSoftLink.mm: * pal/spi/cocoa/AppSSOSPI.h: Added. 2019-06-17 Jiewen Tan <jiewen_tan@apple.com> Move SOAuthorization from WebKitAdditions to WebKit https://bugs.webkit.org/show_bug.cgi?id=198874 <rdar://problem/47573431> Reviewed by Brent Fulgham. This patch moves AppSSOSoftLink from WebKitAdditions to WebKit, and introduces AuthKitSPI.h. * PAL.xcodeproj/project.pbxproj: * pal/cocoa/AppSSOSoftLink.h: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm. * pal/cocoa/AppSSOSoftLink.mm: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm. * pal/spi/cf/CFNetworkSPI.h: * pal/spi/cocoa/AuthKitSPI.h: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm. 2019-06-14 Jiewen Tan <jiewen_tan@apple.com> Disable AppSSO for web processes and plugin processes https://bugs.webkit.org/show_bug.cgi?id=198843 <rdar://problem/51642920> Reviewed by Sam Weinig. * pal/spi/cf/CFNetworkSPI.h: Adds a SPI to disable AppSSO for CFNetwork. 2019-06-12 Antoine Quint <graouts@apple.com> Show the web page URL when sharing an AR model https://bugs.webkit.org/show_bug.cgi?id=198812 <rdar://problem/48689498> Reviewed by Dean Jackson. * pal/spi/ios/SystemPreviewSPI.h: 2019-06-10 Sam Weinig <weinig@apple.com> Remove Dashboard support https://bugs.webkit.org/show_bug.cgi?id=198615 Reviewed by Ryosuke Niwa. * Configurations/FeatureDefines.xcconfig: 2019-06-10 Timothy Hatcher <timothy@apple.com> Integrate dark mode support for iOS. https://bugs.webkit.org/show_bug.cgi?id=198687 rdar://problem/51545643 Reviewed by Tim Horton. * Configurations/FeatureDefines.xcconfig: * pal/spi/ios/UIKitSPI.h: 2019-06-08 Andy Estes <aestes@apple.com> [Apple Pay] If we have a bound interface identifier, set it on new PKPaymentRequests https://bugs.webkit.org/show_bug.cgi?id=198690 <rdar://problem/48041803> Reviewed by Tim Horton. * pal/spi/cocoa/PassKitSPI.h: Included PKPaymentRequest_WebKit.h to declare some WebKit-specific PKPaymentRequest SPIs for internal SDKs, and re-declared these SPIs - now including the boundInterfaceIdentifier property - for public SDKs. 2019-06-05 Alex Christensen <achristensen@webkit.org> Progress towards resurrecting Mac CMake build https://bugs.webkit.org/show_bug.cgi?id=197132 Reviewed by Don Olmstead. * pal/PlatformMac.cmake: 2019-06-05 Wenson Hsieh <wenson_hsieh@apple.com> Upstream content mode support into open source from WebKitAdditions https://bugs.webkit.org/show_bug.cgi?id=198484 <rdar://problem/51355671> Reviewed by Andy Estes. Add some new constants to MobileGestaltSPI.h. * pal/spi/ios/MobileGestaltSPI.h: 2019-06-03 Don Olmstead <don.olmstead@sony.com> [CMake] Add WebKit::JavaScriptCore target https://bugs.webkit.org/show_bug.cgi?id=198403 Reviewed by Konstantin Tokarev. Use the WebKit::JavaScriptCore target. * pal/CMakeLists.txt: 2019-05-29 Don Olmstead <don.olmstead@sony.com> Remove ENABLE definitions from WebKit config files https://bugs.webkit.org/show_bug.cgi?id=197858 Reviewed by Simon Fraser. * Configurations/FeatureDefines.xcconfig: 2019-05-17 Don Olmstead <don.olmstead@sony.com> [CMake] Use builtin FindICU https://bugs.webkit.org/show_bug.cgi?id=197934 Reviewed by Michael Catanzaro. Remove uses of ICU_INCLUDE_DIRS and ICU_LIBRARIES. * pal/CMakeLists.txt: 2019-05-15 Simon Fraser <simon.fraser@apple.com> Make LOG_WITH_STREAM more efficient https://bugs.webkit.org/show_bug.cgi?id=197905 Reviewed by Alex Christensen. Make the LOG_WITH_STREAM macro check that the log channel is enabled before building the stream. * pal/LogMacros.h: 2019-05-10 Chris Dumez <cdumez@apple.com> Add WKWebViewConfiguration._canShowWhileLocked SPI https://bugs.webkit.org/show_bug.cgi?id=197777 <rdar://problem/50065100> Reviewed by Tim Horton. * pal/spi/cocoa/QuartzCoreSPI.h: 2019-05-09 Daniel Bates <dabates@apple.com> [iOS] Numpad comma key has incorrect keyIdentifier property https://bugs.webkit.org/show_bug.cgi?id=197753 <rdar://problem/50636274> Reviewed by Brent Fulgham. Expose enumerator for Numpad Comma. * pal/spi/cocoa/IOKitSPI.h: 2019-05-08 Alex Christensen <achristensen@webkit.org> Add SPI to set HSTS storage directory https://bugs.webkit.org/show_bug.cgi?id=197259 Reviewed by Brady Eidson. * pal/spi/cf/CFNetworkSPI.h: 2019-05-07 Eric Carlson <eric.carlson@apple.com> Define media buffering policy https://bugs.webkit.org/show_bug.cgi?id=196979 <rdar://problem/28383861> Reviewed by Jer Noble. * pal/spi/mac/AVFoundationSPI.h: 2019-05-04 Alex Christensen <achristensen@webkit.org> Revert r244953 and r244954 because they broke internal builds. https://bugs.webkit.org/show_bug.cgi?id=197534 * pal/spi/ios/UIKitSPI.h: (currentUserInterfaceIdiomIsPad): Deleted. 2019-05-04 Alex Christensen <achristensen@webkit.org> Fix internal build. https://bugs.webkit.org/show_bug.cgi?id=197534 * pal/spi/ios/UIKitSPI.h: 2019-05-04 Alex Christensen <achristensen@webkit.org> Merge the three UIKitSPI.h files into a single one in PAL https://bugs.webkit.org/show_bug.cgi?id=197534 Reviewed by Darin Adler. * pal/spi/ios/UIKitSPI.h: (currentUserInterfaceIdiomIsPad): 2019-05-03 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r244881. https://bugs.webkit.org/show_bug.cgi?id=197559 Breaks compilation of jsconly on linux, breaking compilation for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by guijemont on #webkit). Reverted changeset: "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES" https://bugs.webkit.org/show_bug.cgi?id=197174 https://trac.webkit.org/changeset/244881 2019-05-02 Don Olmstead <don.olmstead@sony.com> [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES https://bugs.webkit.org/show_bug.cgi?id=197174 Reviewed by Alex Christensen. Replace WEBKIT_MAKE_FORWARDING_HEADERS with WEBKIT_COPY_FILES. * pal/CMakeLists.txt: 2019-04-29 Alex Christensen <achristensen@webkit.org> <rdar://problem/50299396> Fix internal High Sierra build https://bugs.webkit.org/show_bug.cgi?id=197388 * Configurations/Base.xcconfig: 2019-04-26 Jessie Berlin <jberlin@webkit.org> Add new mac target numbers https://bugs.webkit.org/show_bug.cgi?id=197313 Reviewed by Alex Christensen. * Configurations/Version.xcconfig: * Configurations/WebKitTargetConditionals.xcconfig: 2019-04-26 Eric Carlson <eric.carlson@apple.com> Create AVFoundationSoftLink.{h,mm} to reduce duplicate code https://bugs.webkit.org/show_bug.cgi?id=197171 <rdar://problem/47454979> Reviewed by Youenn Fablet. * PAL.xcodeproj/project.pbxproj: * pal/cocoa/AVFoundationSoftLink.h: Added. * pal/cocoa/AVFoundationSoftLink.mm: Added. 2019-04-25 Timothy Hatcher <timothy@apple.com> Disable date and time inputs on iOSMac. https://bugs.webkit.org/show_bug.cgi?id=197287 rdar://problem/46794376 Reviewed by Wenson Hsieh. * Configurations/FeatureDefines.xcconfig: 2019-04-25 Alex Christensen <achristensen@webkit.org> Start using C++17 https://bugs.webkit.org/show_bug.cgi?id=197131 Reviewed by Darin Adler. * Configurations/Base.xcconfig: 2019-04-25 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r244627. https://bugs.webkit.org/show_bug.cgi?id=197282 Causing internal build failures (Requested by ShawnRoberts on #webkit). Reverted changeset: "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code" https://bugs.webkit.org/show_bug.cgi?id=197171 https://trac.webkit.org/changeset/244627 2019-04-24 Eric Carlson <eric.carlson@apple.com> Create AVFoundationSoftLink.{h,mm} to reduce duplicate code https://bugs.webkit.org/show_bug.cgi?id=197171 <rdar://problem/47454979> Reviewed by Youenn Fablet. * PAL.xcodeproj/project.pbxproj: * pal/cocoa/AVFoundationSoftLink.h: Added. * pal/cocoa/AVFoundationSoftLink.mm: Added. 2019-04-24 Tim Horton <timothy_horton@apple.com> Clean up WKActionSheetAssistant's use of LaunchServices https://bugs.webkit.org/show_bug.cgi?id=194645 <rdar://problem/47707952> Reviewed by Andy Estes. * pal/spi/cocoa/LaunchServicesSPI.h: 2019-04-23 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r244556. https://bugs.webkit.org/show_bug.cgi?id=197212 Causing build failures on multiple builders (Requested by ShawnRoberts on #webkit). Reverted changeset: "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code" https://bugs.webkit.org/show_bug.cgi?id=197171 https://trac.webkit.org/changeset/244556 2019-04-23 Eric Carlson <eric.carlson@apple.com> Create AVFoundationSoftLink.{h,mm} to reduce duplicate code https://bugs.webkit.org/show_bug.cgi?id=197171 <rdar://problem/47454979> Reviewed by Youenn Fablet. * PAL.xcodeproj/project.pbxproj: * pal/cocoa/AVFoundationSoftLink.h: Added. * pal/cocoa/AVFoundationSoftLink.mm: Added. 2019-04-15 Don Olmstead <don.olmstead@sony.com> [CMake] WebCore derived sources should only be referenced inside WebCore https://bugs.webkit.org/show_bug.cgi?id=196904 Reviewed by Konstantin Tokarev. Specify PAL_DERIVED_SOURCES_DIR as a private include directory. * pal/CMakeLists.txt: * pal/PlatformWin.cmake: 2019-04-12 Wenson Hsieh <wenson_hsieh@apple.com> [iOS] Software keyboard is shown too frequently on some websites https://bugs.webkit.org/show_bug.cgi?id=195856 <rdar://problem/49191395> Reviewed by Darin Adler. Declare new GraphicsServices SPI. * pal/spi/ios/GraphicsServicesSPI.h: 2019-04-10 Antoine Quint <graouts@apple.com> Enable Pointer Events on watchOS https://bugs.webkit.org/show_bug.cgi?id=196771 <rdar://problem/49040909> Reviewed by Dean Jackson. * Configurations/FeatureDefines.xcconfig: 2019-04-09 Don Olmstead <don.olmstead@sony.com> [CMake] Apple builds should use ICU_INCLUDE_DIRS https://bugs.webkit.org/show_bug.cgi?id=196720 Reviewed by Konstantin Tokarev. * pal/PlatformMac.cmake: 2019-04-08 Don Olmstead <don.olmstead@sony.com> [CMake][WinCairo] Separate copied headers into different directories https://bugs.webkit.org/show_bug.cgi?id=196655 Reviewed by Michael Catanzaro. * pal/CMakeLists.txt: 2019-04-08 Justin Fan <justin_fan@apple.com> [Web GPU] Fix Web GPU experimental feature on iOS https://bugs.webkit.org/show_bug.cgi?id=196632 Reviewed by Myles C. Maxfield. Add feature conditionals for iOS 11. Properly make Web GPU available on iOS 11+. * Configurations/FeatureDefines.xcconfig: * Configurations/WebKitTargetConditionals.xcconfig: 2019-04-03 Myles C. Maxfield <mmaxfield@apple.com> -apple-trailing-word is needed for browser detection https://bugs.webkit.org/show_bug.cgi?id=196575 Unreviewed. * Configurations/FeatureDefines.xcconfig: 2019-04-03 Ryosuke Niwa <rniwa@webkit.org> Avoid the use of WTF_EXTERN_C_BEGIN in NSMenuSPI.h https://bugs.webkit.org/show_bug.cgi?id=196566 Reviewed by Timothy Hatcher. * pal/spi/mac/NSMenuSPI.h: 2019-04-03 Alex Christensen <achristensen@webkit.org> Add SPI to disable legacy TLS fallback https://bugs.webkit.org/show_bug.cgi?id=196549 <rdar://44979744> Reviewed by Geoffrey Garen. * pal/spi/cf/CFNetworkSPI.h: 2019-04-03 Myles C. Maxfield <mmaxfield@apple.com> Remove support for -apple-trailing-word https://bugs.webkit.org/show_bug.cgi?id=196525 Reviewed by Zalan Bujtas. This CSS property is nonstandard and not used. * Configurations/FeatureDefines.xcconfig: 2019-03-31 Sam Weinig <weinig@apple.com> Remove more i386 specific configurations https://bugs.webkit.org/show_bug.cgi?id=196430 Reviewed by Alexey Proskuryakov. * Configurations/FeatureDefines.xcconfig: ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS. 2019-03-29 Myles C. Maxfield <mmaxfield@apple.com> Delete WebMetal implementation in favor of WebGPU https://bugs.webkit.org/show_bug.cgi?id=195418 Reviewed by Dean Jackson. * Configurations/FeatureDefines.xcconfig: 2019-03-29 Cathie Chen <cathiechen@igalia.com> Implement ResizeObserver. https://bugs.webkit.org/show_bug.cgi?id=157743 Reviewed by Simon Fraser. Add ENABLE_RESIZE_OBSERVER. * Configurations/FeatureDefines.xcconfig: 2019-03-25 Gyuyoung Kim <gyuyoung.kim@webkit.org> Remove NavigatorContentUtils in WebCore/Modules https://bugs.webkit.org/show_bug.cgi?id=196070 Reviewed by Alex Christensen. NavigatorContentUtils was to support the custom scheme spec [1]. However, in WebKit side, no port has supported the feature in WebKit layer after EFL port was removed. So there has been the only IDL implementation of the NavigatorContentUtils in WebCore. So we don't need to keep the implementation in WebCore anymore. [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers * Configurations/FeatureDefines.xcconfig: 2019-03-23 Andy Estes <aestes@apple.com> [Apple Pay] Stop calling PKPaymentAuthorizationViewController class methods on iOS https://bugs.webkit.org/show_bug.cgi?id=196163 <rdar://problem/48787564> Reviewed by Anders Carlsson. * pal/spi/cocoa/PassKitSPI.h: 2019-03-22 Keith Rollin <krollin@apple.com> Enable ThinLTO support in Production builds https://bugs.webkit.org/show_bug.cgi?id=190758 <rdar://problem/45413233> Reviewed by Daniel Bates. Enable building with Thin LTO in Production when using Xcode 10.2 or later. This change results in a 1.45% progression in PLT5. Full Production build times increase about 2-3%. Incremental build times are more severely affected, and so LTO is not enabled for local engineering builds. LTO is enabled only on macOS for now, until rdar://problem/49013399, which affects ARM builds, is fixed. Removed the conditionals that disabled LTO on 32-bit systems since we no longer build for those. To change the LTO setting when building locally: - If building with `make`, specify WK_LTO_MODE={none,thin,full} on the command line. - If building with `build-webkit`, specify --lto-mode={none,thin,full} on the command line. - If building with `build-root`, specify --lto={none,thin,full} on the command line. - If building with Xcode, create a LocalOverrides.xcconfig file at the top level of your repository directory (if needed) and define WK_LTO_MODE to full, thin, or none. * Configurations/Base.xcconfig: 2019-03-22 Timothy Hatcher <timothy@apple.com> Change macosx() to macos() in WK_API... and JSC_API... macros. https://bugs.webkit.org/show_bug.cgi?id=196106 Reviewed by Brian Burg. * pal/spi/cocoa/NSTouchBarSPI.h: 2019-03-20 Simon Fraser <simon.fraser@apple.com> Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH https://bugs.webkit.org/show_bug.cgi?id=196049 Reviewed by Tim Horton. This macro is about the -webkit-overflow-scrolling CSS property, not accelerated overflow scrolling in general, so rename it. * Configurations/FeatureDefines.xcconfig: 2019-03-19 Ross Kirsling <ross.kirsling@sony.com> Unreviewed adjustment to r242842 per Darin's request. * pal/win/LoggingWin.cpp: (PAL::logLevelString): 2019-03-14 Brent Fulgham <bfulgham@apple.com> Move CoreCrypto SPI declarations to an appropriate PAL/spi header https://bugs.webkit.org/show_bug.cgi?id=195754 <rdar://problem/48591957> Reviewed by Jiewen Tan. Move the forward declarations of various CoreCrypto SPI to an appropriate PAL/spi header. Update the const correctness of one function call to match new SDK declaration. No tests because there are no changes in behavior. * PAL.xcodeproj/project.pbxproj: * pal/spi/cocoa/CommonCryptoSPI.h: Copied from Source/WebCore/crypto/CommonCryptoUtilities.h. 2019-03-14 Shawn Roberts <sroberts@apple.com> Unreviewed, rolling out r242981. Causing internal build failures on watch/tv OS Reverted changeset: "Move CoreCrypto SPI declarations to an appropriate PAL/spi header" https://bugs.webkit.org/show_bug.cgi?id=195754 https://trac.webkit.org/changeset/242981 2019-03-14 Brent Fulgham <bfulgham@apple.com> Move CoreCrypto SPI declarations to an appropriate PAL/spi header https://bugs.webkit.org/show_bug.cgi?id=195754 <rdar://problem/48591957> Reviewed by Jiewen Tan. Move the forward declarations of various CoreCrypto SPI to an appropriate PAL/spi header. Update the const correctness of one function call to match new SDK declaration. No tests because there are no changes in behavior. * PAL.xcodeproj/project.pbxproj: * pal/spi/cocoa/CommonCryptoSPI.h: Copied from Source/WebCore/crypto/CommonCryptoUtilities.h. 2019-03-14 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, rolling out r242963. Breaks watchOS build. Reverted changeset: "Move CommonCrypto SPI declarations to an appropriate PAL/spi header" https://bugs.webkit.org/show_bug.cgi?id=195754 https://trac.webkit.org/changeset/242963 2019-03-14 Brent Fulgham <bfulgham@apple.com> Move CommonCrypto SPI declarations to an appropriate PAL/spi header https://bugs.webkit.org/show_bug.cgi?id=195754 <rdar://problem/48591957> Reviewed by Jiewen Tan. Move the forward declarations of various CommonCrypto SPI to an appropriate PAL/spi header. Update the const correctness of one function call to match new SDK declaration. No tests because there are no changes in behavior. * PAL.xcodeproj/project.pbxproj: * pal/spi/cocoa/CommonCryptoSPI.h: Copied from Source/WebCore/crypto/CommonCryptoUtilities.h. 2019-03-13 Keith Rollin <krollin@apple.com> Add support for new StagedFrameworks layout https://bugs.webkit.org/show_bug.cgi?id=195543 Reviewed by Alexey Proskuryakov. When creating the WebKit layout for out-of-band Safari/WebKit updates, use an optional path prefix when called for. * Configurations/PAL.xcconfig: 2019-03-12 Ross Kirsling <ross.kirsling@sony.com> [Win] Fix a slew of simple clang-cl warnings. https://bugs.webkit.org/show_bug.cgi?id=195652 Reviewed by Don Olmstead. * pal/win/LoggingWin.cpp: (PAL::logLevelString): -Wwritable-strings 2019-03-12 Timothy Hatcher <timothy@apple.com> Expose document attributes and body background color through HTMLConverter. https://bugs.webkit.org/show_bug.cgi?id=195636 rdar://problem/45055697 Reviewed by Tim Horton. * pal/spi/cocoa/NSAttributedStringSPI.h: (NSBackgroundColorDocumentAttribute): Added. 2019-03-12 Jennifer Moore <jennifer.moore@apple.com> Check whether to launch a default action instead of action sheet https://bugs.webkit.org/show_bug.cgi?id=195225 <rdar://problem/47715544> Reviewed by Daniel Bates. Add new SPI declarations. * pal/spi/ios/DataDetectorsUISPI.h: 2019-03-11 Ross Kirsling <ross.kirsling@sony.com> Add Optional to Forward.h. https://bugs.webkit.org/show_bug.cgi?id=195586 Reviewed by Darin Adler. * pal/crypto/tasn1/Utilities.cpp: * pal/crypto/tasn1/Utilities.h: Remove unnecessary includes from headers. 2019-03-11 Andy Estes <aestes@apple.com> [Apple Pay] Use PKPaymentAuthorizationController to present the Apple Pay UI remotely from the Networking service on iOS https://bugs.webkit.org/show_bug.cgi?id=195530 <rdar://problem/48747164> Reviewed by Alex Christensen. * pal/cocoa/PassKitSoftLink.h: Soft-linked PKPaymentAuthorizationController on iOS. * pal/cocoa/PassKitSoftLink.mm: Ditto. * pal/spi/cocoa/PassKitSPI.h: Declared PKPaymentAuthorizationControllerPrivateDelegate and related SPI. 2019-03-11 Alex Christensen <achristensen@webkit.org> Soft linking to Reveal framework should be optional https://bugs.webkit.org/show_bug.cgi?id=195576 <rdar://problem/46822452> Reviewed by Megan Gardner. * pal/spi/cocoa/RevealSPI.h: 2019-03-07 Andy Estes <aestes@apple.com> [Apple Pay] Untangle PKPaymentAuthorizationViewController from WebPaymentCoordinatorProxy https://bugs.webkit.org/show_bug.cgi?id=195349 <rdar://problem/48625510> Reviewed by Alex Christensen. Moved soft-linking of PKPaymentErrorDomain from WebPaymentCoordinatorProxy to here and used a more descriptive platform macro. * pal/cocoa/PassKitSoftLink.h: * pal/cocoa/PassKitSoftLink.mm: 2019-03-01 Conrad Shultz <conrad_shultz@apple.com> Improper use of PLATFORM(TVOS) in PAL https://bugs.webkit.org/show_bug.cgi?id=195215 Reviewed by Darin Adler. There are a couple stray uses of PLATFORM(TVOS) in PAL. The correct usage is PLATFORM(APPLETV). * pal/spi/cocoa/NSKeyedArchiverSPI.h: * pal/spi/cocoa/NSProgressSPI.h: 2019-03-03 Tim Horton <timothy_horton@apple.com> Remove some more unused 32-bit code https://bugs.webkit.org/show_bug.cgi?id=195255 Reviewed by Darin Adler. * PAL.xcodeproj/project.pbxproj: * pal/PlatformMac.cmake: * pal/spi/cocoa/IOKitSPI.h: * pal/spi/mac/QuickDrawSPI.h: Removed. 2019-03-01 Justin Fan <justin_fan@apple.com> [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit https://bugs.webkit.org/show_bug.cgi?id=195191 Rubber-stamped by Dean Jackson. Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken. * Configurations/FeatureDefines.xcconfig: 2019-02-28 Justin Fan <justin_fan@apple.com> [Web GPU] Enable Web GPU only on 64-bit https://bugs.webkit.org/show_bug.cgi?id=195139 Because Metal is only supported on 64 bit apps. Unreviewed build fix. * Configurations/FeatureDefines.xcconfig: 2019-02-27 Antoine Quint <graouts@apple.com> Support Pointer Events on macOS https://bugs.webkit.org/show_bug.cgi?id=195008 <rdar://problem/47454419> Reviewed by Dean Jackson. * Configurations/FeatureDefines.xcconfig: 2019-02-23 Keith Miller <keith_miller@apple.com> Add new mac target numbers https://bugs.webkit.org/show_bug.cgi?id=194955 Reviewed by Tim Horton. * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: 2019-02-20 Daniel Bates <dabates@apple.com> Attempt to fix the Apple Internal build following r241828 (https://trac.webkit.org/changeset/241828/webkit) Conditionally include a private header. * pal/spi/ios/UIKitSPI.h: 2019-02-20 Daniel Bates <dabates@apple.com> [iOS] Tweak UI for focus rings https://bugs.webkit.org/show_bug.cgi?id=194864 <rdar://problem/47831886> Reviewed by Brent Fulgham. Expose more SPI. * pal/ios/UIKitSoftLink.h: * pal/ios/UIKitSoftLink.mm: * pal/spi/ios/UIKitSPI.h: 2019-02-20 Timothy Hatcher <timothy@apple.com> RenderThemeIOS should use RenderTheme's color cache instead of its own. https://bugs.webkit.org/show_bug.cgi?id=194822 rdar://problem/48208296 Reviewed by Tim Horton. * pal/ios/UIKitSoftLink.h: * pal/ios/UIKitSoftLink.mm: * pal/spi/ios/UIKitSPI.h: 2019-02-16 Darin Adler <darin@apple.com> Continue reducing use of String::format, now focusing on hex: "%p", "%x", etc. https://bugs.webkit.org/show_bug.cgi?id=194752 Reviewed by Daniel Bates. * pal/FileSizeFormatter.cpp: (fileSizeDescription): Use makeString instead of String::format. 2019-02-18 Daniel Bates <dabates@apple.com> [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element https://bugs.webkit.org/show_bug.cgi?id=192824 <rdar://problem/47100332> Reviewed by Wenson Hsieh. Expose more enumerators. * pal/spi/cocoa/IOKitSPI.h: 2019-02-17 David Kilzer <ddkilzer@apple.com> Unreviewed, rolling out r241620. "Causes use-after-free crashes running layout tests with ASan and GuardMalloc." (Requested by ddkilzer on #webkit.) Reverted changeset: "[WTF] Add environment variable helpers" https://bugs.webkit.org/show_bug.cgi?id=192405 https://trac.webkit.org/changeset/241620 2019-02-15 Ross Kirsling <ross.kirsling@sony.com> [WTF] Add environment variable helpers https://bugs.webkit.org/show_bug.cgi?id=192405 Reviewed by Michael Catanzaro. * pal/unix/LoggingUnix.cpp: (PAL::logLevelString): * pal/win/LoggingWin.cpp: (PAL::logLevelString): Utilize WTF::Environment where possible. 2019-02-15 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r241559 and r241566. https://bugs.webkit.org/show_bug.cgi?id=194710 Causes layout test crashes under GuardMalloc (Requested by ryanhaddad on #webkit). Reverted changesets: "[WTF] Add environment variable helpers" https://bugs.webkit.org/show_bug.cgi?id=192405 https://trac.webkit.org/changeset/241559 "Unreviewed build fix for WinCairo Debug after r241559." https://trac.webkit.org/changeset/241566 2019-02-14 Ross Kirsling <ross.kirsling@sony.com> [WTF] Add environment variable helpers https://bugs.webkit.org/show_bug.cgi?id=192405 Reviewed by Michael Catanzaro. * pal/unix/LoggingUnix.cpp: (PAL::logLevelString): * pal/win/LoggingWin.cpp: (PAL::logLevelString): Utilize WTF::Environment where possible. 2019-02-12 Chris Fleizach <cfleizach@apple.com> AX: IsolatedTree: Implement more attributes https://bugs.webkit.org/show_bug.cgi?id=193911 <rdar://problem/47599217> Reviewed by Daniel Bates. * pal/spi/mac/HIServicesSPI.h: 2019-02-12 Andy Estes <aestes@apple.com> [iOSMac] Enable Parental Controls Content Filtering https://bugs.webkit.org/show_bug.cgi?id=194521 <rdar://39732376> Reviewed by Tim Horton. * Configurations/FeatureDefines.xcconfig: 2019-02-11 Jer Noble <jer.noble@apple.com> Unreviewed build fix; add a HAVE_CELESTIAL guard around the CelestialSPI.h contents. * pal/spi/ios/CelestialSPI.h: 2019-02-12 Michael Catanzaro <mcatanzaro@igalia.com> [WPE][GTK] Sleep disabler code should inhibit idle when a "System" sleep disabler is requested https://bugs.webkit.org/show_bug.cgi?id=194500 Reviewed by Carlos Garcia Campos. There are three things wrong with the comment at the top of SleepDisablerGLib's constructor: (1) Nowadays, GNOME suspends the computer automatically on inactivity, and we actually do want to prevent that. (2) Inhibiting idle does affect the autosuspend countdown. So the current code should prevent automatic suspend, just not manual suspend. (I think I stand by my comment that we do not want to inhibit normal suspend, since that would just be annoying.) (3) I don't know why I thought HTMLMediaElement::shouldDisableSleep was suspicious. Anyway, the behavior we want is to ignore the Type argument and just always inhibit idle. That is, treat type=System the same way we current treat type=Display. * pal/system/glib/SleepDisablerGLib.cpp: (PAL::SleepDisablerGLib::SleepDisablerGLib): 2019-02-11 Myles C. Maxfield <mmaxfield@apple.com> [Cocoa] Ask platform for generic font family mappings https://bugs.webkit.org/show_bug.cgi?id=187723 <rdar://problem/41892438> Reviewed by Brent Fulgham. * pal/spi/cocoa/CoreTextSPI.h: 2019-02-11 Jer Noble <jer.noble@apple.com> [Cocoa] Notify AVSystemController of our presenting PID before registering as a Now Playing app. https://bugs.webkit.org/show_bug.cgi?id=194504 Reviewed by Eric Carlson. * PAL.xcodeproj/project.pbxproj: * pal/spi/ios/CelestialSPI.h: Renamed from Source/WebKit/Platform/spi/ios/CelestialSPI.h. 2019-02-11 Truitt Savell <tsavell@apple.com> Unreviewed, rolling out r241229. Revision broke internal builds for watchOS. Reverted changeset: "[Cocoa] Ask platform for generic font family mappings" https://bugs.webkit.org/show_bug.cgi?id=187723 https://trac.webkit.org/changeset/241229 2019-02-08 Myles C. Maxfield <mmaxfield@apple.com> [Cocoa] Ask platform for generic font family mappings https://bugs.webkit.org/show_bug.cgi?id=187723 <rdar://problem/41892438> Reviewed by Brent Fulgham. * pal/spi/cocoa/CoreTextSPI.h: 2019-02-07 Chris Dumez <cdumez@apple.com> Mark more heap-allocated classes as fast allocated https://bugs.webkit.org/show_bug.cgi?id=194422 Reviewed by Ryosuke Niwa. * pal/crypto/openssl/CryptoDigestOpenSSL.cpp: * pal/system/Clock.h: 2019-02-05 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, rolling out r240742. Causes crashes on iOS simulator. Reverted changeset: "[iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element" https://bugs.webkit.org/show_bug.cgi?id=192824 https://trac.webkit.org/changeset/240742 2018-12-16 Darin Adler <darin@apple.com> Convert additional String::format clients to alternative approaches https://bugs.webkit.org/show_bug.cgi?id=192746 Reviewed by Alexey Proskuryakov. * pal/FileSizeFormatter.cpp: (fileSizeDescription): Use makeString and FormattedNumber. 2019-02-01 David Kilzer <ddkilzer@apple.com> Move soft-linking of TelephonyUtilities.framework out of TUCallSPI.h <https://webkit.org/b/193866> Reviewed by Alex Christensen. * PAL.xcodeproj/project.pbxproj: * pal/PlatformMac.cmake: - Update for rename of TUCallSPI.h to TelephonyUtilitiesSPI.h. * pal/spi/mac/TelephonyUtilitiesSPI.h: Rename from Source/WebCore/PAL/pal/spi/mac/TUCallSPI.h. - Remove soft-linking code from header. 2019-01-30 Daniel Bates <dabates@apple.com> [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element https://bugs.webkit.org/show_bug.cgi?id=192824 <rdar://problem/47100332> Reviewed by Wenson Hsieh. Expose more enumerators. * pal/spi/cocoa/IOKitSPI.h: 2019-01-28 Andy Estes <aestes@apple.com> [watchOS] Enable Parental Controls content filtering https://bugs.webkit.org/show_bug.cgi?id=193939 <rdar://problem/46641912> Reviewed by Ryosuke Niwa. * Configurations/FeatureDefines.xcconfig: 2019-01-27 Chris Fleizach <cfleizach@apple.com> AX: Introduce isolated accessibility tree https://bugs.webkit.org/show_bug.cgi?id=193348 <rdar://problem/47203295> Reviewed by Ryosuke Niwa. * Configurations/FeatureDefines.xcconfig: 2019-01-25 Alex Christensen <achristensen@webkit.org> Move logic from ChildProcess::setApplicationIsDaemon to NetworkProcess::initializeProcess https://bugs.webkit.org/show_bug.cgi?id=193844 Reviewed by Andy Estes. * pal/spi/mac/HIServicesSPI.h: 2019-01-25 David Kilzer <ddkilzer@apple.com> Move soft-linking of Lookup.framework out of LookupSPI.h <https://webkit.org/b/193815> Reviewed by Tim Horton. * PAL.xcodeproj/project.pbxproj: * pal/PlatformMac.cmake: - Add LookupSoftLink.{h,mm} files to the project. * pal/ios/UIKitSoftLink.h: * pal/ios/UIKitSoftLink.mm: - Change SOFT_LINK_VARIABLE_FOR_HEADER() to SOFT_LINK_CONSTANT_FOR_HEADER() for UIAccessibilityAnnouncementNotification constant. * pal/mac/LookupSoftLink.h: Copied from Source/WebCore/PAL/pal/spi/mac/LookupSPI.h. * pal/mac/LookupSoftLink.mm: Copied from Source/WebCore/PAL/pal/spi/mac/LookupSPI.h. - Migrate soft-linking from LookupSPI.h to here. * pal/spi/mac/LookupSPI.h: - Replace soft-linking of Lookup.framework with LookupSoftLink.h. 2019-01-24 Eric Carlson <eric.carlson@apple.com> [iOS] Silence MediaPlayer compile warnings https://bugs.webkit.org/show_bug.cgi?id=193780 <rdar://problem/47518428> Reviewed by Jer Noble. * pal/spi/ios/MediaPlayerSPI.h: 2019-01-24 Ross Kirsling <ross.kirsling@sony.com> Move FileSystem to WTF https://bugs.webkit.org/show_bug.cgi?id=193602 Reviewed by Yusuke Suzuki. * PAL.xcodeproj/project.pbxproj: * pal/PlatformMac.cmake: 2019-01-24 David Kilzer <ddkilzer@apple.com> Follow-up #2: Override the session configuration for cookieAcceptPolicy <https://bugs.webkit.org/show_bug.cgi?id=190925> <rdar://problem/45497382> * pal/spi/cf/CFNetworkSPI.h: Protect Objective-C code using defined(__OBJC__) macro. 2019-01-23 David Kilzer <ddkilzer@apple.com> Switch remaining CoreMedia soft-linking in WebKit over to CoreMediaSoftLink.{cpp,h} <https://webkit.org/b/193694> <rdar://problem/47464025> Reviewed by Tim Horton. * pal/cf/CoreMediaSoftLink.cpp: - Export kCMTimeZero soft-link. * pal/cf/CoreMediaSoftLink.h: - Update kCMTimeZero macro to use PAL namespace for use in WebKit.framework. 2019-01-22 David Kilzer <ddkilzer@apple.com> Switch remaining QuickLook soft-linking in WebCore, WebKit over to QuickLookSoftLink.{cpp,h} <https://webkit.org/b/193654> <rdar://problem/47430290> Reviewed by Alex Christensen. - Moves QuickLookSoftLink.{h,mm} to PAL. - Adds soft-link to 3 classes to consolidate QuickLook.framework soft-linking. - Updates existing source to work with above changes. * PAL.xcodeproj/project.pbxproj: - Add QuickLookSoftLink.{h,mm} due to move from WebCore. * pal/ios/QuickLookSoftLink.h: Renamed from Source/WebCore/platform/ios/QuickLookSoftLink.h. * pal/ios/QuickLookSoftLink.mm: Renamed from Source/WebCore/platform/ios/QuickLookSoftLink.mm. - Add 3 classes for soft-linking. - Change namespace from WebCore to PAL. 2019-01-21 David Kilzer <ddkilzer@apple.com> Sort PAL Xcode project file * PAL.xcodeproj/project.pbxproj: 2019-01-12 Dan Bernstein <mitz@apple.com> [Cocoa] Avoid importing directly from subumbrella frameworks https://bugs.webkit.org/show_bug.cgi?id=186016 <rdar://problem/40591038> Reviewed by Sam Weinig. * Configurations/PAL.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS. * pal/spi/cg/CoreGraphicsSPI.h: Import ApplicationServices.h instead of ColorSync.h when using SDKs earlier than 10.13. * pal/spi/mac/HIToolboxSPI.h: Import CarbonPriv.h instead of HIToolboxPriv.h. * pal/spi/mac/QuickLookMacSPI.h: Import Quartz.h instead of a QuickLookUI header. 2019-01-20 Antoine Quint <graouts@apple.com> Add a POINTER_EVENTS feature flag https://bugs.webkit.org/show_bug.cgi?id=193577 <rdar://problem/47408511> Unreviewed. Also enable Pointer Events for iosmac. * Configurations/FeatureDefines.xcconfig: 2019-01-19 Antoine Quint <graouts@apple.com> Add a POINTER_EVENTS feature flag https://bugs.webkit.org/show_bug.cgi?id=193577 Reviewed by Dean Jackson. * Configurations/FeatureDefines.xcconfig: 2019-01-18 David Kilzer <ddkilzer@apple.com> [PAL] Change Xcode folders to map to folders on disk Found by tidy-Xcode-project-file script (see Bug 188754). * PAL.xcodeproj/project.pbxproj: Update these folders: - pal/avfoundation - pal/crypto/commoncrypto - pal/ios 2019-01-18 David Kilzer <ddkilzer@apple.com> Follow-up: Override the session configuration for cookieAcceptPolicy <https://bugs.webkit.org/show_bug.cgi?id=190925> <rdar://problem/45497382> Discussed with John Wilander. * pal/spi/cf/CFNetworkSPI.h: Declare new SPI for the internal macOS 10.12 Sierra SDK since it will never appear in those headers. This fixes the build for trunk WebKit on Sierra. 2019-01-18 Tim Horton <timothy_horton@apple.com> Get rid of ADVANCED_SPELL_CHECKING https://bugs.webkit.org/show_bug.cgi?id=193592 Reviewed by Wenson Hsieh. * pal/spi/mac/NSSpellCheckerSPI.h: It's always true on macOS, and all but one use of it is already inside PLATFORM(MAC) 2019-01-18 Jer Noble <jer.noble@apple.com> SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds https://bugs.webkit.org/show_bug.cgi?id=189553 Reviewed by Tim Horton. * Configurations/Base.xcconfig: * Configurations/PAL.xcconfig: * Configurations/SDKVariant.xcconfig: Added. 2019-01-18 Daniel Bates <dabates@apple.com> CSS auto focus-ring outlines don't render on iOS https://bugs.webkit.org/show_bug.cgi?id=193583 <rdar://problem/6508697> Reviewed by Simon Fraser. Forward declare some IPI. * pal/spi/ios/UIKitSPI.h: 2019-01-18 David Kilzer <ddkilzer@apple.com> Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h} <https://webkit.org/b/193568> <rdar://problem/47381130> Reviewed by Alex Christensen. * pal/ios/UIKitSoftLink.h: * pal/ios/UIKitSoftLink.mm: - Add constants, classes and functions that were previously soft-linked in separate source files. - UIAccessibilityAnnouncementNotification is declared as a variable because this constant is not marked as `const` in UIKit. * pal/spi/ios/UIKitSPI.h: - Move SPI declarations from HTMLConverter.mm to here. 2019-01-17 Truitt Savell <tsavell@apple.com> Unreviewed, rolling out r240124. This commit broke an internal build. Reverted changeset: "SDK_VARIANT build destinations should be separate from non- SDK_VARIANT builds" https://bugs.webkit.org/show_bug.cgi?id=189553 https://trac.webkit.org/changeset/240124 2019-01-17 Tim Horton <timothy_horton@apple.com> Adopt NSTextCheckingSuppressInitialCapitalizationKey https://bugs.webkit.org/show_bug.cgi?id=193545 Reviewed by Dean Jackson. * pal/spi/mac/NSSpellCheckerSPI.h: 2019-01-17 Jer Noble <jer.noble@apple.com> SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds https://bugs.webkit.org/show_bug.cgi?id=189553 Reviewed by Tim Horton. * Configurations/Base.xcconfig: * Configurations/PAL.xcconfig: * Configurations/SDKVariant.xcconfig: Added. 2019-01-16 Tim Horton <timothy_horton@apple.com> Unreviewed build fix. * pal/spi/ios/UIKitSPI.h: I don't even. 2019-01-16 Megan Gardner <megan_gardner@apple.com> Build fix for iOSMac Reveal https://bugs.webkit.org/show_bug.cgi?id=193503 Unreviewed build fix. * pal/spi/ios/UIKitSPI.h: 2019-01-15 Megan Gardner <megan_gardner@apple.com> Add Reveal support in iOSMac https://bugs.webkit.org/show_bug.cgi?id=193408 <rdar://problem/47300699> Reviewed by Tim Horton. Add additional needed SPI. * pal/spi/cocoa/RevealSPI.h: 2019-01-15 Tim Horton <timothy_horton@apple.com> Cannot tab out of WKWebView on macOS https://bugs.webkit.org/show_bug.cgi?id=161448 <rdar://problem/28100085> Reviewed by Dean Jackson. * pal/spi/mac/NSViewSPI.h: * pal/spi/mac/NSWindowSPI.h: Move some SPI declarations in here from WebKitLegacy. 2019-01-14 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r239901, r239909, r239910, r239912, r239913, and r239914. https://bugs.webkit.org/show_bug.cgi?id=193407 These revisions caused an internal failure (Requested by Truitt on #webkit). Reverted changesets: "[Cocoa] Avoid importing directly from subumbrella frameworks" https://bugs.webkit.org/show_bug.cgi?id=186016 https://trac.webkit.org/changeset/239901 "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901." https://trac.webkit.org/changeset/239909 "Tried to fix the build." https://trac.webkit.org/changeset/239910 "Fixed iOS builds after r239910." https://trac.webkit.org/changeset/239912 "More build fixing." https://trac.webkit.org/changeset/239913 "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds." https://trac.webkit.org/changeset/239914 2019-01-14 Mark Lam <mark.lam@apple.com> Re-enable ability to build --cloop builds. https://bugs.webkit.org/show_bug.cgi?id=192955 <rdar://problem/46882363> Reviewed by Saam barati and Keith Miller. * Configurations/FeatureDefines.xcconfig: 2019-01-13 Dan Bernstein <mitz@apple.com> Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds. * pal/spi/mac/QuickDrawSPI.h: 2019-01-13 Dan Bernstein <mitz@apple.com> Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901. Patch by Keith Rollin. * pal/spi/cocoa/LaunchServicesSPI.h: * pal/spi/mac/HIServicesSPI.h: * pal/spi/mac/MetadataSPI.h: * pal/spi/mac/SpeechSynthesisSPI.h: 2019-01-12 Timothy Hatcher <timothy@apple.com> Have prefers-color-scheme: light always match on macOS versions before Mojave. https://bugs.webkit.org/show_bug.cgi?id=191655 rdar://problem/46074680 Reviewed by Megan Gardner. * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. 2019-01-12 Dan Bernstein <mitz@apple.com> [Cocoa] Avoid importing directly from subumbrella frameworks https://bugs.webkit.org/show_bug.cgi?id=186016 <rdar://problem/40591038> Reviewed by Sam Weinig. * Configurations/PAL.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS. * pal/spi/cg/CoreGraphicsSPI.h: Import ApplicationServices.h instead of ColorSync.h when using SDKs earlier than 10.13. * pal/spi/mac/HIToolboxSPI.h: Import CarbonPriv.h instead of HIToolboxPriv.h. * pal/spi/mac/QuickLookMacSPI.h: Import Quartz.h instead of a QuickLookUI header. 2019-01-11 John Wilander <wilander@apple.com> Compile out Web API Statistics Collection https://bugs.webkit.org/show_bug.cgi?id=193370 <rdar://problem/45388584> Reviewed by Brent Fulgham. * Configurations/FeatureDefines.xcconfig: Defined ENABLE_WEB_API_STATISTICS, off by default. 2019-01-11 Devin Rousso <drousso@apple.com> Fix style CFNetworkSPI style checker warnings from r239698 https://bugs.webkit.org/show_bug.cgi?id=193369 Reviewed by Joseph Pecoraro. * pal/spi/cf/CFNetworkSPI.h: 2019-01-10 John Wilander <wilander@apple.com> Override the session configuration for cookieAcceptPolicy https://bugs.webkit.org/show_bug.cgi?id=190925 <rdar://problem/45497382> Reviewed by Alexey Proskuryakov and Alex Christensen. * pal/spi/cf/CFNetworkSPI.h: Declaration of _overrideSessionCookieAcceptPolicy on NSHTTPCookieStorage. 2019-01-07 Devin Rousso <drousso@apple.com> Web Inspector: Network: show secure connection details per-request https://bugs.webkit.org/show_bug.cgi?id=191539 <rdar://problem/45979891> Reviewed by Joseph Pecoraro. * pal/spi/cf/CFNetworkSPI.h: 2019-01-04 Jer Noble <jer.noble@apple.com> Web Content process main thread blocked beneath ImageDecoderAVFObjC::readSamples for many seconds on imgur.com https://bugs.webkit.org/show_bug.cgi?id=191806 <rdar://problem/46151477> Reviewed by Dean Jackson. * pal/cf/CoreMediaSoftLink.cpp: * pal/cf/CoreMediaSoftLink.h: 2018-12-27 Alex Christensen <achristensen@webkit.org> Resurrect Mac CMake build https://bugs.webkit.org/show_bug.cgi?id=192658 Reviewed by Yusuke Suzuki. * pal/PlatformMac.cmake: 2018-12-21 Eric Carlson <eric.carlson@apple.com> 'ended' Event doesn't fire on MediaStreamTrack when a USB camera is unplugged https://bugs.webkit.org/show_bug.cgi?id=187896 <rdar://problem/42681445> Reviewed by Jer Noble. * pal/spi/cf/CoreAudioSPI.h: 2018-12-19 Chris Dumez <cdumez@apple.com> wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from https://bugs.webkit.org/show_bug.cgi?id=192728 <rdar://problem/46746779> Reviewed by Geoff Garen. * pal/*: 2018-12-17 Saam barati <sbarati@apple.com> Enable HTTP and HTTPS proxies on iOS and make it a property of the NSURLSession https://bugs.webkit.org/show_bug.cgi?id=192374 <rdar://problem/46506286> Reviewed by Alex Christensen. * pal/spi/cf/CFNetworkSPI.h: Remove the now-unused SPI declaration. 2018-12-17 Simon Fraser <simon.fraser@apple.com> Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled https://bugs.webkit.org/show_bug.cgi?id=192780 rdar://problem/43394387 Reviewed by Tim Horton. Add CGFontRenderingGetFontSmoothingDisabled(). * pal/spi/cg/CoreGraphicsSPI.h: 2018-12-17 Daniel Bates <dabates@apple.com> Implement UIScriptController::toggleCapsLock() for iOS https://bugs.webkit.org/show_bug.cgi?id=191815 Reviewed by Andy Estes. Add HID usage enumerator for the Caps Lock key. * pal/spi/cocoa/IOKitSPI.h: 2018-12-17 Matt Lewis <jlewis3@apple.com> Unreviewed, rolling out r239254. This broke the Windows 10 Debug build Reverted changeset: "Replace many uses of String::format with more type-safe alternatives" https://bugs.webkit.org/show_bug.cgi?id=192742 https://trac.webkit.org/changeset/239254 2018-12-15 Darin Adler <darin@apple.com> Use warning-ignoring macros more consistently and simply https://bugs.webkit.org/show_bug.cgi?id=192743 Reviewed by Mark Lam. * pal/spi/cocoa/AVKitSPI.h: Use IGNORE_WARNINGS_BEGIN instead of IGNORE_CLANG_WARNINGS_BEGIN; there is no special need to accomodate non-clang compilers here. 2018-12-15 Darin Adler <darin@apple.com> Replace many uses of String::format with more type-safe alternatives https://bugs.webkit.org/show_bug.cgi?id=192742 Reviewed by Mark Lam. * pal/FileSizeFormatter.cpp: (fileSizeDescription): Use makeString. 2018-12-11 Justin Michaud <justin_michaud@apple.com> Implement feature flag for CSS Typed OM https://bugs.webkit.org/show_bug.cgi?id=192610 Reviewed by Ryosuke Niwa. * Configurations/FeatureDefines.xcconfig: 2018-12-11 Andy Estes <aestes@apple.com> Introduce makeBlockPtr for lambdas https://bugs.webkit.org/show_bug.cgi?id=192594 Reviewed by Alex Christensen. Adopted makeBlockPtr. * pal/Logging.cpp: (PAL::registerNotifyCallback): 2018-12-10 Don Olmstead <don.olmstead@sony.com> Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig https://bugs.webkit.org/show_bug.cgi?id=192573 Reviewed by Simon Fraser. * Configurations/FeatureDefines.xcconfig: 2018-12-10 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r239023. https://bugs.webkit.org/show_bug.cgi?id=192571 Speculative rollout due to broken perf test (Requested by deanj on #webkit). Reverted changeset: "Enable HTTP and HTTPS proxies on iOS and make it a property of the NSURLSession" https://bugs.webkit.org/show_bug.cgi?id=192374 https://trac.webkit.org/changeset/239023 2018-12-10 Darin Adler <darin@apple.com> [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly https://bugs.webkit.org/show_bug.cgi?id=192533 rdar://problem/45732710 Reviewed by Anders Carlsson. * pal/spi/mac/HIServicesSPI.h: Added kMSHDoNotCreateSendRightOption. 2018-12-09 Saam barati <sbarati@apple.com> Enable HTTP and HTTPS proxies on iOS and make it a property of the NSURLSession https://bugs.webkit.org/show_bug.cgi?id=192374 <rdar://problem/46506286> Reviewed by Alex Christensen. * pal/spi/cf/CFNetworkSPI.h: Remove the now-unused SPI declaration. 2018-12-05 Don Olmstead <don.olmstead@sony.com> [PlayStation] Enable WebCore https://bugs.webkit.org/show_bug.cgi?id=192384 Reviewed by Brent Fulgham. Implements PAL for the PlayStation platform. * pal/PlatformPlayStation.cmake: Added. 2018-12-02 Zalan Bujtas <zalan@apple.com> Add a runtime feature flag for LayoutFormattingContext. https://bugs.webkit.org/show_bug.cgi?id=192280 Reviewed by Simon Fraser. * Configurations/FeatureDefines.xcconfig: 2018-12-01 Alexey Proskuryakov <ap@apple.com> Modernize version check for _suppressedAutoAddedHTTPHeaders https://bugs.webkit.org/show_bug.cgi?id=192175 Reviewed by Tim Horton. * pal/spi/cf/CFNetworkSPI.h: Curiously, it was forward declared twice, for no apparent reason. 2018-11-30 Don Olmstead <don.olmstead@sony.com> Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO https://bugs.webkit.org/show_bug.cgi?id=192197 Reviewed by Jiewen Tan. * Configurations/FeatureDefines.xcconfig: * pal/PlatformGTK.cmake: * pal/PlatformWPE.cmake: 2018-11-30 Alexey Proskuryakov <ap@apple.com> Move USE_CFNETWORK_IGNORE_HSTS to its proper place https://bugs.webkit.org/show_bug.cgi?id=192173 Reviewed by Tim Horton. * pal/spi/cf/CFNetworkSPI.h: 2018-11-29 David Quesada <david_quesada@apple.com> Add SPI to publish NSProgress on active downloads https://bugs.webkit.org/show_bug.cgi?id=192021 rdar://problem/44405661 Reviewed by Alex Christensen. Add an SPI header for NSProgress's publishing and unpublishing methods. In older SDKs, these methods are explicitly unavailable on platforms other than macOS, with underscore-prefixed versions available as SPI. In newer SDKs, the unprefixed versions are SPI and the prefixed versions are deprecated. * PAL.xcodeproj/project.pbxproj: * pal/spi/cocoa/NSProgressSPI.h: 2018-11-29 Megan Gardner <megan_gardner@apple.com> Move Lookup Code for better cross platform usage https://bugs.webkit.org/show_bug.cgi?id=191732 Reviewed by Alex Christensen. * pal/spi/mac/LookupSPI.h: * pal/spi/mac/RevealSPI.h: 2018-11-29 Eric Carlson <eric.carlson@apple.com> [iOS] Tell AirPlay picker when a file has video https://bugs.webkit.org/show_bug.cgi?id=192155 Reviewed by Jer Noble. * pal/spi/ios/MediaPlayerSPI.h: 2018-11-29 Alexey Proskuryakov <ap@apple.com> Modernize the check for kCFURLRequestContentDecoderSkipURLCheck existence https://bugs.webkit.org/show_bug.cgi?id=192041 Reviewed by Tim Horton. * pal/spi/cf/CFNetworkSPI.h: 2018-11-29 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, rolling out r238678. Breaks internal builds. Reverted changeset: "Move Lookup Code for better cross platform usage" https://bugs.webkit.org/show_bug.cgi?id=191732 https://trac.webkit.org/changeset/238678 2018-11-29 Megan Gardner <megan_gardner@apple.com> Move Lookup Code for better cross platform usage https://bugs.webkit.org/show_bug.cgi?id=191732 Reviewed by Alex Christensen. * pal/spi/mac/LookupSPI.h: * pal/spi/mac/RevealSPI.h: 2018-11-28 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r238653 and r238656. https://bugs.webkit.org/show_bug.cgi?id=192130 Breaks iOS build (Requested by smfr on #webkit). Reverted changesets: "Move Lookup Code for better cross platform usage" https://bugs.webkit.org/show_bug.cgi?id=191732 https://trac.webkit.org/changeset/238653 "Attempt to fix the iOS build by only including RevealSPI.h when it's needed." https://trac.webkit.org/changeset/238656 2018-11-15 Megan Gardner <megan_gardner@apple.com> Move Lookup Code for better cross platform usage https://bugs.webkit.org/show_bug.cgi?id=191732 Reviewed by Alex Christensen. * pal/spi/mac/LookupSPI.h: * pal/spi/mac/RevealSPI.h: 2018-11-28 Alexey Proskuryakov <ap@apple.com> Modernize version checks for same site cookie support https://bugs.webkit.org/show_bug.cgi?id=192054 Reviewed by Tim Horton. * pal/spi/cf/CFNetworkSPI.h: 2018-11-27 Mark Lam <mark.lam@apple.com> ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac. https://bugs.webkit.org/show_bug.cgi?id=192055 <rdar://problem/46288783> Reviewed by Saam Barati. * Configurations/FeatureDefines.xcconfig: 2018-11-27 Alexey Proskuryakov <ap@apple.com> Modernize the check for async _saveCookies existence https://bugs.webkit.org/show_bug.cgi?id=191987 Reviewed by Dean Jackson. * pal/spi/cf/CFNetworkSPI.h: Also removed a check around _socketStreamProperties, which exists everywhere. 2018-11-27 Jer Noble <jer.noble@apple.com> Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI https://bugs.webkit.org/show_bug.cgi?id=190951 <rdar://problem/45213065> Further follow-up build fix; add ASSUME_NONNULL macros to SPI declaration. * pal/spi/cocoa/AVKitSPI.h: 2018-11-27 Jer Noble <jer.noble@apple.com> Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI https://bugs.webkit.org/show_bug.cgi?id=190951 <rdar://problem/45213065> Follow-up build fix when building against older SDKs. * pal/spi/cocoa/AVKitSPI.h: 2018-11-26 Jer Noble <jer.noble@apple.com> Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI https://bugs.webkit.org/show_bug.cgi?id=190951 <rdar://problem/45213065> Reviewed by Alex Christensen. * pal/spi/cocoa/AVKitSPI.h: 2018-11-26 Andy Estes <aestes@apple.com> [Cocoa] Make it easier to encode NSObjects https://bugs.webkit.org/show_bug.cgi?id=191948 Reviewed by Dean Jackson. * pal/spi/cocoa/PassKitSPI.h: Declared some classes that secretly conform to NSSecureCoding. 2018-11-24 Andy Estes <aestes@apple.com> [Cocoa] SOFT_LINK_CLASS_FOR_{HEADER,SOURCE} should generate a more concise getter function https://bugs.webkit.org/show_bug.cgi?id=191899 Reviewed by Dean Jackson. * pal/cocoa/PassKitSoftLink.h: * pal/ios/UIKitSoftLink.h: 2018-11-23 Wenson Hsieh <wenson_hsieh@apple.com> Enable drag and drop support for iOSMac https://bugs.webkit.org/show_bug.cgi?id=191818 <rdar://problem/43907454> Reviewed by Dean Jackson. * Configurations/FeatureDefines.xcconfig: 2018-11-21 Wenson Hsieh <wenson_hsieh@apple.com> [Cocoa] [WebKit2] Add support for replacing find-in-page text matches https://bugs.webkit.org/show_bug.cgi?id=191786 <rdar://problem/45813871> Reviewed by Ryosuke Niwa. Add `-replaceMatches:withString:inSelectionOnly:resultCollector:`. * pal/spi/mac/NSTextFinderSPI.h: 2018-11-21 Andy Estes <aestes@apple.com> [Cocoa] Create a soft-linking file for PassKit https://bugs.webkit.org/show_bug.cgi?id=191875 <rdar://problem/46203215> Reviewed by Myles Maxfield. * PAL.xcodeproj/project.pbxproj: * pal/PlatformMac.cmake: * pal/cocoa/PassKitSoftLink.h: Added. * pal/cocoa/PassKitSoftLink.mm: Added. Used _WITH_EXPORT soft-linking macros in order to make the PAL soft-linking symbols visible to WebKit. * pal/spi/cocoa/PassKitSPI.h: 2018-11-17 Wenson Hsieh <wenson_hsieh@apple.com> [iOS] Remove all usages of UIItemProvider, UIItemProviderReading, and related classes https://bugs.webkit.org/show_bug.cgi?id=191819 Reviewed by Dan Bernstein. Replace UIItemProvider (and related classes) with NSItemProvider. * pal/spi/ios/UIKitSPI.h: 2018-11-16 Brent Fulgham <bfulgham@apple.com> [Win] Reduce the use of WKSI library calls: CFNetwork https://bugs.webkit.org/show_bug.cgi?id=191718 <rdar://problem/46108732> Reviewed by Alex Christensen. Add necessary declarations for CFNetwork SPI needed by the Apple Windows build. * pal/PlatformAppleWin.cmake: * pal/spi/cf/CFNetworkSPI.h: * pal/spi/cf/CFNetworkSPIWin.cpp: Added. 2018-11-16 Chris Dumez <cdumez@apple.com> [Mac] Regression: WebContent process's display name is no longer set https://bugs.webkit.org/show_bug.cgi?id=191722 <rdar://problem/45960550> Reviewed by Per Arne Vollan. * pal/spi/cocoa/LaunchServicesSPI.h: 2018-11-15 Brent Fulgham <bfulgham@apple.com> Additional Windows build fix after r238253. * pal/spi/cg/CoreGraphicsSPI.h: 2018-11-15 Brent Fulgham <bfulgham@apple.com> Unreviewed build fix after removing some WKSI calls on Windows. * pal/spi/cg/CoreGraphicsSPI.h: 2018-11-11 Daniel Bates <dabates@apple.com> [iOS] Draw caps lock indicator in password fields https://bugs.webkit.org/show_bug.cgi?id=190565 <rdar://problem/45262343> Reviewed by Dean Jackson. Forward declare some more SPI. * pal/spi/ios/GraphicsServicesSPI.h: * pal/spi/ios/UIKitSPI.h: 2018-11-09 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, rolling out r238047. Introduced layout test failures on iOS simulator. Reverted changeset: "[iOS] Draw caps lock indicator in password fields" https://bugs.webkit.org/show_bug.cgi?id=190565 https://trac.webkit.org/changeset/238047 2018-11-09 Daniel Bates <dabates@apple.com> [iOS] Draw caps lock indicator in password fields https://bugs.webkit.org/show_bug.cgi?id=190565 <rdar://problem/45262343> Reviewed by Dean Jackson. Forward declare some more SPI. * pal/spi/ios/GraphicsServicesSPI.h: * pal/spi/ios/UIKitSPI.h: 2018-11-08 Megan Gardner <megan_gardner@apple.com> Adopt Reveal Framework to replace Lookup https://bugs.webkit.org/show_bug.cgi?id=191097 <rdar://problem/45924508> Reviewed by Tim Horton. Add in reveal SPI so WebKit will continue to build without the internal SDK. * PAL.xcodeproj/project.pbxproj: * pal/spi/mac/RevealSPI.h: Added. 2018-11-06 Justin Fan <justin_fan@apple.com> [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain https://bugs.webkit.org/show_bug.cgi?id=191291 Reviewed by Myles Maxfield. Properly disable WEBGPU on all non-Metal platforms for now. * Configurations/FeatureDefines.xcconfig: 2018-11-02 Daniel Bates <dabates@apple.com> [iOS] Normalize character string based on key code https://bugs.webkit.org/show_bug.cgi?id=191120 Reviewed by Tim Horton. Remove forward declarations that are no longer needed now that we check key code. * pal/spi/ios/UIKitSPI.h: 2018-11-01 Said Abou-Hallawa <sabouhallawa@apple.com> [CG] Adopt CG SPI for non-even cornered rounded rects https://bugs.webkit.org/show_bug.cgi?id=190155 Reviewed by Simon Fraser. * pal/spi/cg/CoreGraphicsSPI.h: 2018-10-30 Alexey Proskuryakov <ap@apple.com> Clean up some obsolete MAX_ALLOWED macros https://bugs.webkit.org/show_bug.cgi?id=190916 Reviewed by Tim Horton. * pal/cf/CoreMediaSoftLink.cpp: * pal/cf/CoreMediaSoftLink.h: Behavior change here. The check didn't really make sense, pretty sure we would just crash when hitting this code path on iOS. * pal/spi/cf/CFNetworkSPI.h: * pal/spi/cocoa/PassKitSPI.h: * pal/spi/mac/AVFoundationSPI.h: 2018-10-29 Tim Horton <timothy_horton@apple.com> Modernize WebKit nibs and lprojs for localization's sake https://bugs.webkit.org/show_bug.cgi?id=190911 <rdar://problem/45349466> Reviewed by Dan Bernstein. * PAL.xcodeproj/project.pbxproj: English->en 2018-10-26 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r237458. https://bugs.webkit.org/show_bug.cgi?id=190973 broke internal iOS builds (Requested by zalan on #webkit). Reverted changeset: "Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI" https://bugs.webkit.org/show_bug.cgi?id=190951 https://trac.webkit.org/changeset/237458 2018-10-26 Timothy Hatcher <timothy@apple.com> Use dark appearance scrollbar when page background is dark or document supports dark mode. https://bugs.webkit.org/show_bug.cgi?id=190937 rdar://problem/41225839 Reviewed by Beth Dakin. * pal/spi/mac/NSScrollerImpSPI.h: Added effectiveAppearanceForScrollerImp:. 2018-10-26 Jer Noble <jer.noble@apple.com> Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI https://bugs.webkit.org/show_bug.cgi?id=190951 <rdar://problem/45213065> Reviewed by Alex Christensen. * pal/spi/cocoa/AVKitSPI.h: 2018-10-24 Alexey Proskuryakov <ap@apple.com> Clean up some obsolete macOS version guards https://bugs.webkit.org/show_bug.cgi?id=190887 Reviewed by Dan Bernstein. * pal/spi/mac/TUCallSPI.h: 2018-10-24 Megan Gardner <megan_gardner@apple.com> Turn on Conic Gradients https://bugs.webkit.org/show_bug.cgi?id=190810 Reviewed by Tim Horton. * Configurations/FeatureDefines.xcconfig: 2018-10-23 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, rolling out r237280. Causes fast/box-shadow/box-shadow-with-zero-radius.html to fail on iOS Simulator. Reverted changeset: "[CG] Adopt CG SPI for non-even cornered rounded rects" https://bugs.webkit.org/show_bug.cgi?id=190155 https://trac.webkit.org/changeset/237280 2018-10-18 Said Abou-Hallawa <sabouhallawa@apple.com> [CG] Adopt CG SPI for non-even cornered rounded rects https://bugs.webkit.org/show_bug.cgi?id=190155 Reviewed by Simon Fraser. * pal/spi/cg/CoreGraphicsSPI.h: 2018-10-18 Alexey Proskuryakov <ap@apple.com> Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY) https://bugs.webkit.org/show_bug.cgi?id=190729 Reviewed by Tim Horton. * pal/cf/CoreMediaSoftLink.cpp: * pal/cf/CoreMediaSoftLink.h: * pal/ios/UIKitSoftLink.h: * pal/ios/UIKitSoftLink.mm: * pal/spi/cf/CFNetworkSPI.h: * pal/spi/cocoa/AVKitSPI.h: * pal/spi/cocoa/CFNSURLConnectionSPI.h: * pal/spi/cocoa/CoreTextSPI.h: * pal/spi/cocoa/DataDetectorsCoreSPI.h: * pal/spi/cocoa/IOSurfaceSPI.h: * pal/spi/cocoa/LaunchServicesSPI.h: * pal/spi/cocoa/NEFilterSourceSPI.h: * pal/spi/cocoa/NSAttributedStringSPI.h: * pal/spi/cocoa/NSKeyedArchiverSPI.h: * pal/spi/cocoa/PassKitSPI.h: * pal/spi/cocoa/QuartzCoreSPI.h: * pal/spi/ios/DataDetectorsUISPI.h: * pal/spi/ios/GraphicsServicesSPI.h: * pal/spi/ios/MediaPlayerSPI.h: * pal/spi/ios/MobileGestaltSPI.h: * pal/spi/mac/AVFoundationSPI.h: * pal/system/mac/ClockCM.mm: (ClockCM::ClockCM): 2018-10-17 Wenson Hsieh <wenson_hsieh@apple.com> Enable the datalist element by default on iOS and macOS https://bugs.webkit.org/show_bug.cgi?id=190594 <rdar://problem/45281159> Reviewed by Ryosuke Niwa and Tim Horton. * Configurations/FeatureDefines.xcconfig: 2018-10-16 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, rolling out r237163. Introduced layout test failures on iOS Simulator. Reverted changeset: "[CG] Adopt CG SPI for non-even cornered rounded rects" https://bugs.webkit.org/show_bug.cgi?id=190155 https://trac.webkit.org/changeset/237163 2018-10-16 Justin Michaud <justin_michaud@apple.com> Implement feature flag and bindings for CSS Painting API https://bugs.webkit.org/show_bug.cgi?id=190237 Reviewed by Ryosuke Niwa. * Configurations/FeatureDefines.xcconfig: 2018-10-15 Justin Fan <justin_fan@apple.com> Add WebGPU 2018 feature flag and experimental feature flag https://bugs.webkit.org/show_bug.cgi?id=190509 Reviewed by Dean Jackson. Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature for the 2018 WebGPU prototype. * Configurations/FeatureDefines.xcconfig: 2018-10-15 Said Abou-Hallawa <sabouhallawa@apple.com> [CG] Adopt CG SPI for non-even cornered rounded rects https://bugs.webkit.org/show_bug.cgi?id=190155 Reviewed by Simon Fraser. * pal/spi/cg/CoreGraphicsSPI.h: 2018-10-15 Timothy Hatcher <timothy@apple.com> Add support for prefers-color-scheme media query https://bugs.webkit.org/show_bug.cgi?id=190499 rdar://problem/45212025 Reviewed by Dean Jackson. * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS. 2018-10-14 Yusuke Suzuki <yusukesuzuki@slowstart.org> [JSC] Remove Option::useAsyncIterator https://bugs.webkit.org/show_bug.cgi?id=190567 Reviewed by Saam Barati. * Configurations/FeatureDefines.xcconfig: 2018-10-08 Wenson Hsieh <wenson_hsieh@apple.com> [Cocoa] [WK2] Add support for text alignment and text lists in font attributes https://bugs.webkit.org/show_bug.cgi?id=190342 <rdar://problem/44767118> Reviewed by Tim Horton. * pal/ios/UIKitSoftLink.h: * pal/ios/UIKitSoftLink.mm: Add NSParagraphStyle and NSTextList to the UIKit soft link header. * pal/spi/cocoa/NSAttributedStringSPI.h: * pal/spi/ios/UIKitSPI.h: Add some SPI declarations for NSMutableParagraphStyle and NSTextList when building with a non-internal iOS SDK, and import <UIKit/NSParagraphStyle_Private.h> and <UIKit/NSTextList.h> when building with an internal iOS SDK. Additionally, define some internal UIFoundation string constants that denote NSTextList marker formats. These constants are API on macOS, but are neither exposed as API nor SPI on iOS. 2018-10-08 Justin Fan <justin_fan@apple.com> WebGPU: Rename old WebGPU prototype to WebMetal https://bugs.webkit.org/show_bug.cgi?id=190325 <rdar://problem/44990443> Reviewed by Dean Jackson. Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface. * Configurations/FeatureDefines.xcconfig: 2018-10-08 Aditya Keerthi <akeerthi@apple.com> Make <input type=color> a runtime enabled (on-by-default) feature https://bugs.webkit.org/show_bug.cgi?id=189162 Reviewed by Wenson Hsieh and Tim Horton. * Configurations/FeatureDefines.xcconfig: 2018-10-05 Jer Noble <jer.noble@apple.com> Unreviewed build fix: internal builds can't find AVVideoPerformanceMetrics. * pal/spi/mac/AVFoundationSPI.h: 2018-10-03 Jer Noble <jer.noble@apple.com> Add support for reporting "display composited video frames" through the VideoPlaybackQuality object. https://bugs.webkit.org/show_bug.cgi?id=190266 Reviewed by Eric Carlson. * pal/spi/mac/AVFoundationSPI.h: 2018-10-05 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, rolling out r236866. Breaks internal builds. Reverted changeset: "Add support for reporting "display composited video frames" through the VideoPlaybackQuality object." https://bugs.webkit.org/show_bug.cgi?id=190266 https://trac.webkit.org/changeset/236866 2018-10-04 Jer Noble <jer.noble@apple.com> Add support for reporting "display composited video frames" through the VideoPlaybackQuality object. https://bugs.webkit.org/show_bug.cgi?id=190266 Reviewed by Eric Carlson. * pal/spi/mac/AVFoundationSPI.h: 2018-10-04 Dan Bernstein <mitz@apple.com> PAL change for the WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10 https://bugs.webkit.org/show_bug.cgi?id=190250 Reviewed by Andy Estes. * pal/spi/mac/NSWindowSPI.h: Added a private API declaration. 2018-10-04 Dan Bernstein <mitz@apple.com> PAL part of [Xcode] Update some build settings as recommended by Xcode 10 https://bugs.webkit.org/show_bug.cgi?id=190250 Reviewed by Andy Estes. * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, and CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS. * PAL.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck. 2018-10-01 Dean Jackson <dino@apple.com> Remove CSS Animation Triggers https://bugs.webkit.org/show_bug.cgi?id=190175 <rdar://problem/44925626> Reviewed by Simon Fraser. * Configurations/FeatureDefines.xcconfig: 2018-10-01 Andy Estes <aestes@apple.com> [watchOS] Adopt NSURLSessionCompanionProxyPreference https://bugs.webkit.org/show_bug.cgi?id=190177 <rdar://problem/43402114> Reviewed by Wenson Hsieh. * pal/spi/cf/CFNetworkSPI.h: 2018-10-01 Daniel Bates <dabates@apple.com> [iOS] Special keys are misidentified in DOM keyboard events https://bugs.webkit.org/show_bug.cgi?id=189974 Reviewed by Wenson Hsieh. Forward declare or define more SPI. * pal/spi/cocoa/IOKitSPI.h: * pal/spi/ios/UIKitSPI.h: 2018-09-25 Jiewen Tan <jiewen_tan@apple.com> [WebAuthN] Make AuthenticatorManager https://bugs.webkit.org/show_bug.cgi?id=189279 <rdar://problem/44116792> Reviewed by Chris Dumez. It moves linking to DeviceIdentity.framework to WebKit. * PAL.xcodeproj/project.pbxproj: 2018-09-25 Wenson Hsieh <wenson_hsieh@apple.com> [iOS] Fix the open source iOS 12 build after r236445 https://bugs.webkit.org/show_bug.cgi?id=189953 Reviewed by Alex Christensen. Introduce a single UIKit soft-linking header in PAL. * PAL.xcodeproj/project.pbxproj: * pal/ios/UIKitSoftLink.h: Copied from Source/WebCore/platform/graphics/cocoa/ColorCocoa.mm. * pal/ios/UIKitSoftLink.mm: Copied from Source/WebCore/platform/graphics/cocoa/ColorCocoa.mm. 2018-09-24 Wenson Hsieh <wenson_hsieh@apple.com> Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic https://bugs.webkit.org/show_bug.cgi?id=189918 Work towards <rdar://problem/44648705> Reviewed by Tim Horton. Add `+_disambiguated_due_to_CIImage_colorWithCGColor:` as a UIColor SPI definition. Also, import `UIColor_Private.h` directly when the Apple internal SDK is used. * pal/spi/ios/UIKitSPI.h: 2018-09-21 Jer Noble <jer.noble@apple.com> Unreviewed Sierra Build Fix; ensure AVVideoPerformanceMetrics are defined on Sierra. * pal/spi/mac/AVFoundationSPI.h: 2018-09-21 Jer Noble <jer.noble@apple.com> Move AVVideoPerformanceMetrics into AVFoundationSPI.h https://bugs.webkit.org/show_bug.cgi?id=189842 Reviewed by Jon Lee. * pal/spi/mac/AVFoundationSPI.h: 2018-09-21 Jonathan Bedard <jbedard@apple.com> Bring up queues for iOS 12 (Build fix) https://bugs.webkit.org/show_bug.cgi?id=189683 Unreviewed build fix. * pal/spi/cocoa/QuartzCoreSPI.h: Declare setCornerRadius and continuousCorner. 2018-09-20 Daniel Bates <dabates@apple.com> Move IOKitSPI.h from TestRunnerShared to PAL https://bugs.webkit.org/show_bug.cgi?id=189804 Reviewed by Wenson Hsieh. Towards fixing <https://bugs.webkit.org/show_bug.cgi?id=189604> move the IOKit SPI forward declarations to PAL so that they can be shared by both WebKit, DumpRenderTree, and WebKitTestRunner. No functionality changed. So, no new tests. * PAL.xcodeproj/project.pbxproj: * pal/spi/cocoa/IOKitSPI.h: Renamed from Tools/TestRunnerShared/spi/IOKitSPI.h. 2018-09-14 Eric Carlson <eric.carlson@apple.com> Support arbitrary video resolution in getUserMedia API https://bugs.webkit.org/show_bug.cgi?id=178109 <rdar://problem/35083128> Reviewed by Youenn Fablet. * pal/cf/CoreMediaSoftLink.cpp: * pal/cf/CoreMediaSoftLink.h: 2018-09-12 Guillaume Emont <guijemont@igalia.com> Add IGNORE_WARNING_.* macros https://bugs.webkit.org/show_bug.cgi?id=188996 Reviewed by Michael Catanzaro. * pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp: (PAL::CryptoDigest::create): (PAL::CryptoDigest::addBytes): (PAL::CryptoDigest::computeHash): * pal/spi/cocoa/AVKitSPI.h: * pal/spi/cocoa/NSKeyedArchiverSPI.h: (insecurelyUnarchiveObjectFromData): * pal/spi/ios/MediaPlayerSPI.h: * pal/system/mac/PopupMenu.mm: (PAL::popUpMenu): * pal/system/mac/WebPanel.mm: (-[WebPanel init]): 2018-09-10 James Savage <james.savage@apple.com> Expose -apple-system-container-border color to internal web views. https://bugs.webkit.org/show_bug.cgi?id=189178. Reviewed by Timothy Hatcher. * pal/spi/cocoa/NSColorSPI.h: Declare SPI. 2018-09-06 Megan Gardner <megan_gardner@apple.com> Add Support for Conic Gradients https://bugs.webkit.org/show_bug.cgi?id=189329 <rdar://problem/21444701> Reviewed by Simon Fraser. Define the CG functionality for conic gradients. * pal/spi/cg/CoreGraphicsSPI.h: 2018-09-04 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, attempt to fix an internal build after r235585. * pal/spi/cf/CFNetworkSPI.h: 2018-09-01 Yoshiaki Jitsukawa <yoshiaki.jitsukawa@sony.com> [WinCairo] Add CryptoDigestOpenSSL https://bugs.webkit.org/show_bug.cgi?id=188978 Reviewed by Darin Adler. Add a CryptoDigest implementation with OpenSSL/LibreSSL and let the WinCairo port use it. * pal/PlatformAppleWin.cmake: Add CryptoDigestWin.cpp to PAL_SOURCES * pal/PlatformWin.cmake: Remove CryptoDigestWin.cpp from PAL_SOURCES * pal/PlatformWinCairo.cmake: Add CryptoDigestOpenSSL to PAL_SOURCES * pal/crypto/openssl/CryptoDigestOpenSSL.cpp: Added. (PAL::toSHA1Context): (PAL::toSHA224Context): (PAL::toSHA256Context): (PAL::toSHA384Context): (PAL::toSHA512Context): (PAL::CryptoDigest::CryptoDigest): (PAL::CryptoDigest::~CryptoDigest): (PAL::CryptoDigest::create): (PAL::CryptoDigest::addBytes): (PAL::CryptoDigest::computeHash): 2018-09-01 Darin Adler <darin@apple.com> [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently https://bugs.webkit.org/show_bug.cgi?id=189072 Reviewed by Dan Bernstein. * pal/spi/cf/CFNetworkSPI.h: Added a FIXME about USE(CFNETWORK_IGNORE_HSTS). Sorted Objective-C class interfaces alphabetically instead of having them relatively randomly ordered in the file. Reduced the platform #if statements since it's not critical to have these SPIs declared only where they are present, as long as they are used only when they are present. Moved some additional declarations into this file. * pal/spi/cocoa/NSURLDownloadSPI.h: Added more NSURLDownload methods. 2018-08-30 Don Olmstead <don.olmstead@sony.com> [CMake] Replace AVFoundationSupport.py using CMake https://bugs.webkit.org/show_bug.cgi?id=182891 Reviewed by Per Arne Vollan. Remove AVFoundationSupport.py file and its invocation. * AVFoundationSupport.py: Removed. * config.h: * pal/PlatformWin.cmake: 2018-08-29 Jer Noble <jer.noble@apple.com> Muted elements do not have their Now Playing status updated when unmuted. https://bugs.webkit.org/show_bug.cgi?id=189069 Reviewed by Eric Carlson. * pal/spi/mac/MediaRemoteSPI.h: 2018-08-27 Keith Rollin <krollin@apple.com> Unreviewed build fix -- disable LTO for production builds * Configurations/Base.xcconfig: 2018-08-27 Aditya Keerthi <akeerthi@apple.com> Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER https://bugs.webkit.org/show_bug.cgi?id=188931 Reviewed by Wenson Hsieh. * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER. 2018-08-27 Keith Rollin <krollin@apple.com> Build system support for LTO https://bugs.webkit.org/show_bug.cgi?id=187785 <rdar://problem/42353132> Reviewed by Dan Bernstein. Update Base.xcconfig and DebugRelease.xcconfig to optionally enable LTO. * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: 2018-08-26 Andy Estes <aestes@apple.com> [Apple Pay] Introduce new values for -apple-pay-button-type https://bugs.webkit.org/show_bug.cgi?id=188949 <rdar://problem/39992228> Reviewed by Anders Carlsson. * pal/spi/cocoa/PassKitSPI.h: 2018-08-23 Andy Estes <aestes@apple.com> [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave https://bugs.webkit.org/show_bug.cgi?id=188829 Reviewed by Tim Horton. * Configurations/FeatureDefines.xcconfig: 2018-08-21 Ryosuke Niwa <rniwa@webkit.org> Unreviewed macOS Mojave build fix after r235125. * pal/spi/cg/CoreGraphicsSPI.h: 2018-08-15 Ansh Shukla <ansh_shukla@apple.com> NSURLAuthenticationMethodOAuth challenges are surfaced to clients in -didReceiveAuthenticationChallenge as NSURLAuthenticationMethodDefault https://bugs.webkit.org/show_bug.cgi?id=186870 <rdar://problem/41314410> Reviewed by Alex Christensen. * pal/spi/cf/CFNetworkSPI.h: Declare OAuth string when not building against the internal SDK. 2018-08-15 Aditya Keerthi <akeerthi@apple.com> [Datalist] Add button to TextFieldInputs with a datalist https://bugs.webkit.org/show_bug.cgi?id=187741 Reviewed by Tim Horton. * pal/spi/cocoa/NSColorSPI.h: Added NSColorGetUserAccentColor(). 2018-08-15 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, rolling out r234870. The test introduced with this change is a flaky failure. Reverted changeset: "NSURLAuthenticationMethodOAuth challenges are surfaced to clients in -didReceiveAuthenticationChallenge as NSURLAuthenticationMethodDefault" https://bugs.webkit.org/show_bug.cgi?id=186870 https://trac.webkit.org/changeset/234870 2018-08-14 Ansh Shukla <ansh_shukla@apple.com> NSURLAuthenticationMethodOAuth challenges are surfaced to clients in -didReceiveAuthenticationChallenge as NSURLAuthenticationMethodDefault https://bugs.webkit.org/show_bug.cgi?id=186870 <rdar://problem/41314410> Reviewed by Alex Christensen. * pal/spi/cf/CFNetworkSPI.h: Declare OAuth string when not building against the internal SDK. 2018-08-07 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, suppress warnings to fix the build. * pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp: (PAL::CryptoDigest::create): (PAL::CryptoDigest::addBytes): (PAL::CryptoDigest::computeHash): 2018-08-07 Per Arne Vollan <pvollan@apple.com> [macOS] Scrollbars are not visible when using 3rd party mouse https://bugs.webkit.org/show_bug.cgi?id=188372 Reviewed by Simon Fraser. Added declaration of NSScrollerImpPair class method. This method updates all NSScrollerImpPairs with a new recommended scroller style. * pal/spi/mac/NSScrollerImpSPI.h: 2018-08-02 David Fenton <david_fenton@apple.com> Unreviewed, rolling out r234489. Caused 50+ crashes and 60+ API failures on iOS Reverted changeset: "[WTF] Rename String::format to String::deprecatedFormat" https://bugs.webkit.org/show_bug.cgi?id=188191 https://trac.webkit.org/changeset/234489 2018-08-01 Tomas Popela <tpopela@redhat.com> [WTF] Rename String::format to String::deprecatedFormat https://bugs.webkit.org/show_bug.cgi?id=188191 Reviewed by Darin Adler. It should be replaced with string concatenation. * pal/FileSizeFormatter.cpp: (fileSizeDescription): 2018-08-01 Tim Horton <timothy_horton@apple.com> Using the keyboard arrow keys to scroll a webpage is very slow, not smooth, takes too long https://bugs.webkit.org/show_bug.cgi?id=188239 <rdar://problem/22997654> Reviewed by Simon Fraser. * pal/spi/cocoa/QuartzCoreSPI.h: Add a piece of SPI. 2018-07-30 Sihui Liu <sihui_liu@apple.com> Add support for fetching and remove type _WKWebsiteDataTypeHSTSCache https://bugs.webkit.org/show_bug.cgi?id=187379 <rdar://problem/41879559> Reviewed by Geoffrey Garen. * pal/spi/cf/CFNetworkSPI.h: 2018-07-30 Devin Rousso <webkit@devinrousso.com> Add missing CoreGraphics SPI https://bugs.webkit.org/show_bug.cgi?id=188177 Reviewed by Joseph Pecoraro. * pal/spi/cg/CoreGraphicsSPI.h: 2018-07-26 Andy VanWagoner <andy@vanwagoner.family> [INTL] Remove INTL sub-feature compile flags https://bugs.webkit.org/show_bug.cgi?id=188081 Reviewed by Michael Catanzaro. * Configurations/FeatureDefines.xcconfig: 2018-07-26 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, rolling out r234281. Broke internal builds. Reverted changeset: "[Datalist] Add button to TextFieldInputs with a datalist" https://bugs.webkit.org/show_bug.cgi?id=187741 https://trac.webkit.org/changeset/234281 2018-07-26 Aditya Keerthi <akeerthi@apple.com> [Datalist] Add button to TextFieldInputs with a datalist https://bugs.webkit.org/show_bug.cgi?id=187741 Reviewed by Tim Horton. * pal/spi/cocoa/NSColorSPI.h: Added NSColorGetUserAccentColor(). 2018-07-26 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r234181 and r234189. https://bugs.webkit.org/show_bug.cgi?id=188075 These are not needed right now (Requested by thorton on #webkit). Reverted changesets: "Enable Web Content Filtering on watchOS" https://bugs.webkit.org/show_bug.cgi?id=187979 https://trac.webkit.org/changeset/234181 "HAVE(PARENTAL_CONTROLS) should be true on watchOS" https://bugs.webkit.org/show_bug.cgi?id=187985 https://trac.webkit.org/changeset/234189 2018-07-24 Tim Horton <timothy_horton@apple.com> Enable Web Content Filtering on watchOS https://bugs.webkit.org/show_bug.cgi?id=187979 <rdar://problem/42559346> Reviewed by Wenson Hsieh. * Configurations/FeatureDefines.xcconfig: 2018-07-24 Aditya Keerthi <akeerthi@apple.com> [Datalist][macOS] Display suggestions for input[type=color] https://bugs.webkit.org/show_bug.cgi?id=187794 Reviewed by Tim Horton. Added methods to enable customization of NSPopoverColorWell. * PAL.xcodeproj/project.pbxproj: * pal/spi/mac/NSColorWellSPI.h: Added. * pal/spi/mac/NSPopoverColorWellSPI.h: Added. * pal/spi/mac/NSPopoverSPI.h: 2018-07-23 Tim Horton <timothy_horton@apple.com> Creating and loading content in a WKWebView triggers Main Thread Checker warnings under ServicesController https://bugs.webkit.org/show_bug.cgi?id=186963 <rdar://problem/41393682> Reviewed by Timothy Hatcher. * pal/spi/mac/NSSharingServiceSPI.h: Add the new SPI. 2018-07-18 Per Arne Vollan <pvollan@apple.com> The WebContent process does not suspend when MiniBrowser is minimized. https://bugs.webkit.org/show_bug.cgi?id=187708 Reviewed by Chris Dumez. Add function for enabling App nap. * pal/spi/cf/CFUtilitiesSPI.h: 2018-07-18 Jer Noble <jer.noble@apple.com> PiP from Element Fullscreen should match AVKit's behavior https://bugs.webkit.org/show_bug.cgi?id=187623 Reviewed by Jon Lee. * pal/spi/mac/PIPSPI.h: 2018-07-14 Kocsen Chung <kocsen_chung@apple.com> Ensure WebKit stack is ad-hoc signed https://bugs.webkit.org/show_bug.cgi?id=187667 Reviewed by Alexey Proskuryakov. * Configurations/Base.xcconfig: 2018-07-04 Tim Horton <timothy_horton@apple.com> Introduce PLATFORM(IOSMAC) https://bugs.webkit.org/show_bug.cgi?id=187315 Reviewed by Dan Bernstein. * Configurations/Base.xcconfig: * Configurations/FeatureDefines.xcconfig: * pal/cf/CoreMediaSoftLink.cpp: * pal/cf/CoreMediaSoftLink.h: * pal/spi/mac/AVFoundationSPI.h: 2018-06-28 Jonathan Bedard <jbedard@apple.com> Build fix (2) after r233266 https://bugs.webkit.org/show_bug.cgi?id=187024 <rdar://problem/39759057> Unreviewed build fix. * pal/cf/CoreMediaSoftLink.cpp: Distinguish between IOS and MINIMAL_SIMULATOR. * pal/cf/CoreMediaSoftLink.h: Ditto. * pal/spi/cocoa/LaunchServicesSPI.h: LSApplicationProxy should be conditionalized on HAVE(APP_LINKS). 2018-06-27 Jonathan Bedard <jbedard@apple.com> Build fix after r233266 https://bugs.webkit.org/show_bug.cgi?id=187024 <rdar://problem/39759057> Unreviewed build fix. * pal/cf/CoreMediaSoftLink.cpp: Do not soft-link CMSampleBufferCallForEachSample for iOS 12 and up on iPhone device and simulator. * pal/cf/CoreMediaSoftLink.h: Ditto. 2018-06-27 Jonathan Bedard <jbedard@apple.com> Enable WebKit iOS 12 build https://bugs.webkit.org/show_bug.cgi?id=187024 <rdar://problem/39759057> Reviewed by David Kilzer. * pal/cf/CoreMediaSoftLink.cpp: Condition some CoreMedia functions on version. * pal/cf/CoreMediaSoftLink.h: Ditto. * pal/spi/cocoa/NSXPCConnectionSPI.h: Use XPCSPI.h instead of xpc.h. * pal/spi/ios/QuickLookSPI.h: QLItem adopts QLPreviewItem. * pal/spi/ios/SystemPreviewSPI.h: Fix compiler errors. 2018-06-26 Wenson Hsieh <wenson_hsieh@apple.com> [iPad apps on macOS] Unable to interact with video elements that have started playing https://bugs.webkit.org/show_bug.cgi?id=187073 <rdar://problem/40591107> Reviewed by Tim Horton. Define an SPI method on CALayer. See WebKit ChangeLog for more detail. * pal/spi/cocoa/QuartzCoreSPI.h: 2018-06-23 Yusuke Suzuki <utatane.tea@gmail.com> [WTF] Add user-defined literal for ASCIILiteral https://bugs.webkit.org/show_bug.cgi?id=186839 Reviewed by Darin Adler. * pal/unix/LoggingUnix.cpp: (PAL::logLevelString): 2018-06-22 Timothy Hatcher <timothy@apple.com> Corner of two scroll bars is white with dark mode enabled. https://bugs.webkit.org/show_bug.cgi?id=186819 rdar://problem/40434350 Reviewed by Tim Horton. * PAL.xcodeproj/project.pbxproj: * pal/spi/mac/CoreUISPI.h: Added. * pal/spi/mac/NSAppearanceSPI.h: Added. 2018-06-21 Ryan Haddad <ryanhaddad@apple.com> Unreviewed attempt to fix the build after r233052. * pal/spi/cocoa/AVKitSPI.h: 2018-06-21 Jer Noble <jer.noble@apple.com> [Fullscreen] Use secondary glyph style for fullscreen controls https://bugs.webkit.org/show_bug.cgi?id=186862 <rdar://problem/41212210> Reviewed by Tim Horton. * pal/spi/cocoa/AVKitSPI.h: 2018-06-15 Jonathan Bedard <jbedard@apple.com> Complex text handling should opt out of bounded text layout (follow-up fix) https://bugs.webkit.org/show_bug.cgi?id=186571 <rdar://problem/40801429> Reviewed by Zalan Bujtas. * pal/spi/cocoa/CoreTextSPI.h: Add declaration for OpenSource Mojave builds. 2018-06-14 Timothy Hatcher <timothy@apple.com> Expose more semantic system colors. https://bugs.webkit.org/show_bug.cgi?id=186609 rdar://problem/39287277 Reviewed by Tim Horton. * pal/spi/cocoa/NSColorSPI.h: Added findHighlightColor and placeholderTextColor. 2018-06-09 Dan Bernstein <mitz@apple.com> [Xcode] Clean up and modernize some build setting definitions https://bugs.webkit.org/show_bug.cgi?id=186463 Reviewed by Sam Weinig. * Configurations/Base.xcconfig: Removed definition for macOS 10.11. * Configurations/DebugRelease.xcconfig: Ditto. * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version. * Configurations/PAL.xcconfig: Removed WK_PRIVATE_FRAMEWORKS_DIR, because the private framework stubs aren’t used when linking PAL. * Configurations/Version.xcconfig: Removed definition for macOS 10.11. * Configurations/WebKitTargetConditionals.xcconfig: Ditto. 2018-06-09 Dan Bernstein <mitz@apple.com> Added missing file references to the Configuration group. * PAL.xcodeproj/project.pbxproj: 2018-06-08 Darin Adler <darin@apple.com> [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC https://bugs.webkit.org/show_bug.cgi?id=186436 Reviewed by Anders Carlsson. * PAL.xcodeproj/project.pbxproj: Removed FoundationSPI.h. * pal/PlatformMac.cmake: Ditto. * pal/spi/cocoa/FoundationSPI.h: Moved into WTF project. 2018-06-08 Wenson Hsieh <wenson_hsieh@apple.com> [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1) https://bugs.webkit.org/show_bug.cgi?id=186442 <rdar://problem/40879364> Reviewed by Tim Horton. * Configurations/FeatureDefines.xcconfig: 2018-06-08 Darin Adler <darin@apple.com> [Cocoa] Make more of our soft linking ARC-compatible https://bugs.webkit.org/show_bug.cgi?id=186437 Reviewed by Daniel Bates. * pal/spi/cocoa/DataDetectorsCoreSPI.h: Removed unused DDURLScheme. 2018-06-08 Jonathan Bedard <jbedard@apple.com> [Mojave] Enable build https://bugs.webkit.org/show_bug.cgi?id=186401 <rdar://problem/39759031> Reviewed by Dan Bernstein. * pal/spi/cg/CoreGraphicsSPI.h: Declare CGSShutdownServerConnections(). * pal/spi/cocoa/QuartzCoreSPI.h: Declare [CAContext setAllowsCGSConnections] in Mojave + builds. * pal/spi/mac/DataDetectorsSPI.h: Declare DDResultGetCFTypeID in Mojave+ builds. 2018-06-08 Brent Fulgham <bfulgham@apple.com> REGRESSION (r230930): Link drag image is very blurry https://bugs.webkit.org/show_bug.cgi?id=186435 <rdar://problem/40797202> Reviewed by Tim Horton. Add the necessary NSImage SPI to our SPI headers. * PAL.xcodeproj/project.pbxproj: * pal/spi/mac/NSImageSPI.h: Added. 2018-06-07 Chris Dumez <cdumez@apple.com> Add base class to get WeakPtrFactory member and avoid some boilerplate code https://bugs.webkit.org/show_bug.cgi?id=186407 Reviewed by Brent Fulgham. 186407_CanMakeWeakPtr * pal/system/mac/SystemSleepListenerMac.h: * pal/system/mac/SystemSleepListenerMac.mm: (PAL::SystemSleepListenerMac::SystemSleepListenerMac): 2018-06-06 Simon Fraser <simon.fraser@apple.com> Logging macros are sensitive to pal/Logging.h vs Logging.h include order https://bugs.webkit.org/show_bug.cgi?id=185893 Reviewed by Zalan Bujtas. Remove unused functionality from pal/Logging code until we need it. Primarily this removes the #define LOG_CHANNEL_PREFIX from pal/Logging.h, which caused include-order problems with unified sources. Future work should move shared logging code up to WTF (or into PAL). * PAL.xcodeproj/project.pbxproj: * pal/CMakeLists.txt: * pal/LogInitialization.h: Removed. * pal/Logging.cpp: (PAL::isLogChannelEnabled): Deleted. (PAL::setLogChannelToAccumulate): Deleted. (PAL::initializeLogChannelsIfNecessary): Deleted. * pal/Logging.h: * pal/cocoa/LoggingCocoa.mm: Removed. 2018-06-05 Brent Fulgham <bfulgham@apple.com> Adjust compile and runtime flags to match shippable state of features https://bugs.webkit.org/show_bug.cgi?id=186319 <rdar://problem/40352045> Reviewed by Maciej Stachowiak, Jon Lee, and others. * Configurations/DebugRelease.xcconfig: Update to match WebKit definition of WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for Cocoa builds. * Configurations/FeatureDefines.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR or ENABLE_INPUT_TYPE_COLOR_POPOVER. 2018-06-05 Brent Fulgham <bfulgham@apple.com> Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds https://bugs.webkit.org/show_bug.cgi?id=186286 <rdar://problem/40782992> Reviewed by Dan Bernstein. Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds) to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually change this flag when preparing for a production release. * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine whether experimental features should be enabled, and use it to properly define the feature flag. 2018-06-04 Dan Bernstein <mitz@apple.com> Made PAL build with the macOS Mojave SDK. * pal/cf/CoreMediaSoftLink.cpp: * pal/cf/CoreMediaSoftLink.h: 2018-06-04 Wenson Hsieh <wenson_hsieh@apple.com> [WebKit on watchOS] Remove all uses of the EXTRA_ZOOM_MODE compiler flag https://bugs.webkit.org/show_bug.cgi?id=186279 Reviewed by Tim Horton. Replaces uses of ENABLE(EXTRA_ZOOM_MODE) with PLATFORM(WATCHOS). * pal/cf/CoreMediaSoftLink.h: * pal/spi/cocoa/AVKitSPI.h: 2018-05-30 Andy Estes <aestes@apple.com> [Cocoa] Add an SPI to suppress connection termination errors from CFNetwork when network interfaces change https://bugs.webkit.org/show_bug.cgi?id=186107 <rdar://problem/39338957> Reviewed by Brady Eidson. * pal/spi/cf/CFNetworkSPI.h: Declared new SPI. 2018-05-27 Dan Bernstein <mitz@apple.com> Reverted the changes made for https://webkit.org/b/186016 They broke the USE(APPLE_INTERNAL_SDK) Sierra build. 2018-05-25 Chris Dumez <cdumez@apple.com> Drop support for NSURLCache in WebKit2 https://bugs.webkit.org/show_bug.cgi?id=185990 Reviewed by Geoffrey Garen. Drop support for NSURLCache in WebKit2 now that the WebKit network cache is stable. * pal/spi/cf/CFNetworkSPI.h: 2018-05-24 Jiewen Tan <jiewen_tan@apple.com> Adopt SecKeyProxy SPI in certificate based challenge response code https://bugs.webkit.org/show_bug.cgi?id=185848 <rdar://problem/34586181> Reviewed by Alex Christensen. Add SPIs to support SecKeyProxy and convert xpc_endpoint_t to NSXPCListenerEndpoint vice versa. * PAL.xcodeproj/project.pbxproj: * pal/spi/cocoa/NSXPCConnectionSPI.h: Added. * pal/spi/cocoa/SecKeyProxySPI.h: Added. 2018-05-24 Chris Dumez <cdumez@apple.com> Some of the work in initializeLogChannelsIfNecessary() is unnecessary for release builds https://bugs.webkit.org/show_bug.cgi?id=185951 Reviewed by Geoffrey Garen. Some of the work in initializeLogChannelsIfNecessary() is unnecessary for release builds and slows down launch time. In particular, it is unnecessary to read NSDefaults to figure out which logging channels should be enabled. * pal/cocoa/LoggingCocoa.mm: (PAL::logLevelString): * pal/unix/LoggingUnix.cpp: (PAL::logLevelString): * pal/win/LoggingWin.cpp: (PAL::logLevelString): 2018-05-22 Simon Fraser <simon.fraser@apple.com> Add notifyutil callbacks to dump the memory cache, and the list of live Pages and Documents https://bugs.webkit.org/show_bug.cgi?id=185853 Reviewed by Keith Miller. Compile registerNotifyCallback in release builds. * pal/Logging.cpp: (PAL::registerNotifyCallback): * pal/Logging.h: 2018-05-22 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, rolling out r232052. Breaks internal builds. Reverted changeset: "Use more C++17" https://bugs.webkit.org/show_bug.cgi?id=185176 https://trac.webkit.org/changeset/232052 2018-05-21 Yusuke Suzuki <utatane.tea@gmail.com> Use more C++17 https://bugs.webkit.org/show_bug.cgi?id=185176 Reviewed by JF Bastien. * Configurations/Base.xcconfig: 2018-05-21 Jer Noble <jer.noble@apple.com> Complete fix for enabling modern EME by default https://bugs.webkit.org/show_bug.cgi?id=185770 <rdar://problem/40368220> Reviewed by Eric Carlson. * Configurations/FeatureDefines.xcconfig: 2018-05-18 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r231982. https://bugs.webkit.org/show_bug.cgi?id=185793 Caused layout test failures (Requested by realdawei on #webkit). Reverted changeset: "Complete fix for enabling modern EME by default" https://bugs.webkit.org/show_bug.cgi?id=185770 https://trac.webkit.org/changeset/231982 2018-05-18 Jer Noble <jer.noble@apple.com> Complete fix for enabling modern EME by default https://bugs.webkit.org/show_bug.cgi?id=185770 <rdar://problem/40368220> Reviewed by Eric Carlson. * Configurations/FeatureDefines.xcconfig: 2018-05-16 Andy VanWagoner <andy@vanwagoner.family> Add support for Intl NumberFormat formatToParts https://bugs.webkit.org/show_bug.cgi?id=185375 Reviewed by Yusuke Suzuki. Add flag for NumberFormat formatToParts. * Configurations/FeatureDefines.xcconfig: 2018-05-15 Wenson Hsieh <wenson_hsieh@apple.com> PasteboardWebContent's dataInAttributedStringFormat fails to deserialize in the UI process when copying a selection https://bugs.webkit.org/show_bug.cgi?id=185667 <rdar://problem/40135132> Reviewed by Tim Horton. Fixes error logging emitted when copying a text selection due to the secure archiver on iOS being unable to handle NSAttributedString in the builds where the errors manifest. USE_SECURE_ARCHIVER_FOR_ATTRIBUTED_STRING is defined to be 1, despite not having the fix for <rdar://problem/31376830>. * pal/spi/cocoa/NSKeyedArchiverSPI.h: 2018-05-11 Dan Bernstein <mitz@apple.com> Follow-up build fix to r231721. * pal/cf/CoreMediaSoftLink.cpp: * pal/cf/CoreMediaSoftLink.h: Unify the conditions between the header and the implementation files, and have watchOS and tvOS keyed off iOS. 2018-05-11 Jer Noble <jer.noble@apple.com> Add CF_NOESCAPE decorators for tvOS and watchOS https://bugs.webkit.org/show_bug.cgi?id=185560 Reviewed by Dan Bernstein. * pal/cf/CoreMediaSoftLink.h: 2018-05-08 Sihui Liu <sihui_liu@apple.com> Adopt new async _savecookies SPI for keeping networking process active during flushing cookies https://bugs.webkit.org/show_bug.cgi?id=185261 <rdar://problem/37214391> Reviewed by Chris Dumez. * pal/spi/cf/CFNetworkSPI.h: 2018-05-08 Dean Jackson <dino@apple.com> Use thumbnails in System Previews https://bugs.webkit.org/show_bug.cgi?id=185397 <rdar://problem/40039376> Reviewed by Jon Lee. * PAL.xcodeproj/project.pbxproj: * pal/spi/ios/SystemPreviewSPI.h: New file holding the non-public parts of System Preview. 2018-05-04 Tim Horton <timothy_horton@apple.com> Shift to a lower-level framework for simplifying URLs https://bugs.webkit.org/show_bug.cgi?id=185334 Reviewed by Dan Bernstein. * PAL.xcodeproj/project.pbxproj: * pal/PlatformMac.cmake: * pal/spi/cocoa/URLFormattingSPI.h: Renamed from Source/WebCore/PAL/pal/spi/cocoa/LinkPresentationSPI.h. 2018-05-03 Eric Carlson <eric.carlson@apple.com> [iOS] Provide audio route information when invoking AirPlay picker https://bugs.webkit.org/show_bug.cgi?id=185199 <rdar://problem/39853103> Another attempt at an unreviewed build fix. * pal/spi/mac/AVFoundationSPI.h: 2018-05-02 Eric Carlson <eric.carlson@apple.com> [iOS] Provide audio route information when invoking AirPlay picker https://bugs.webkit.org/show_bug.cgi?id=185199 <rdar://problem/39853103> Unreviewed, another attempted build fix. * pal/spi/mac/AVFoundationSPI.h: 2018-05-02 Alex Christensen <achristensen@webkit.org> Add WKWebsiteDataStorePrivate._proxyConfiguration SPI https://bugs.webkit.org/show_bug.cgi?id=185179 Reviewed by Andy Estes. * pal/spi/cf/CFNetworkSPI.h: 2018-05-02 Eric Carlson <eric.carlson@apple.com> [iOS] Provide audio route information when invoking AirPlay picker https://bugs.webkit.org/show_bug.cgi?id=185199 <rdar://problem/39853103> Unreviewed build fix. * pal/spi/mac/AVFoundationSPI.h: 2018-05-02 Eric Carlson <eric.carlson@apple.com> [iOS] Provide audio route information when invoking AirPlay picker https://bugs.webkit.org/show_bug.cgi?id=185199 <rdar://problem/39853103> Reviewed by Jer Noble. * pal/spi/mac/AVFoundationSPI.h: Add additional AVAudioSession SPI. 2018-05-01 Jer Noble <jer.noble@apple.com> Protect against changes to CoreMedia function signatures https://bugs.webkit.org/show_bug.cgi?id=185167 Reviewed by Eric Carlson. * pal/cf/CoreMediaSoftLink.cpp: * pal/cf/CoreMediaSoftLink.h: 2018-05-01 Oleksandr Skachkov <gskachkov@gmail.com> WebAssembly: add support for stream APIs - JavaScript API https://bugs.webkit.org/show_bug.cgi?id=183442 Reviewed by Yusuke Suzuki and JF Bastien. Add WEBASSEMBLY_STREAMING_API feature flag * Configurations/FeatureDefines.xcconfig: 2018-04-26 Jer Noble <jer.noble@apple.com> WK_COCOA_TOUCH all the things. https://bugs.webkit.org/show_bug.cgi?id=185006 Reviewed by Tim Horton. * Configurations/PAL.xcconfig: 2018-04-26 Per Arne Vollan <pvollan@apple.com> Disable content filtering in minimal simulator mode https://bugs.webkit.org/show_bug.cgi?id=185027 <rdar://problem/39736091> Reviewed by Jer Noble. * Configurations/FeatureDefines.xcconfig: 2018-04-26 Andy VanWagoner <thetalecrafter@gmail.com> [INTL] Implement Intl.PluralRules https://bugs.webkit.org/show_bug.cgi?id=184312 Reviewed by JF Bastien. Added Intl.PluralRules feature flag. * Configurations/FeatureDefines.xcconfig: 2018-04-24 Jer Noble <jer.noble@apple.com> Don't add system framework paths to FRAMEWORK_SEARCH_PATHS https://bugs.webkit.org/show_bug.cgi?id=184786 Reviewed by Tim Horton. * Configurations/PAL.xcconfig: 2018-04-23 Daniel Bates <dabates@apple.com> Implement Same-Site cookies https://bugs.webkit.org/show_bug.cgi?id=159464 <rdar://problem/27196358> Reviewed by Brent Fulgham. Forward declare some SPI. * pal/spi/cf/CFNetworkSPI.h: 2018-04-23 Zalan Bujtas <zalan@apple.com> [LayoutFormattingContext] Initial commit. https://bugs.webkit.org/show_bug.cgi?id=184896 Reviewed by Antti Koivisto. * Configurations/FeatureDefines.xcconfig: 2018-04-23 Daniel Bates <dabates@apple.com> Implement Same-Site cookies https://bugs.webkit.org/show_bug.cgi?id=159464 <rdar://problem/27196358> Reviewed by Brent Fulgham. Forward declare some SPI. * pal/spi/cf/CFNetworkSPI.h: 2018-04-20 Tim Horton <timothy_horton@apple.com> Adjust geolocation feature flag https://bugs.webkit.org/show_bug.cgi?id=184856 Reviewed by Wenson Hsieh. * Configurations/FeatureDefines.xcconfig: 2018-04-18 Jer Noble <jer.noble@apple.com> Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds https://bugs.webkit.org/show_bug.cgi?id=184762 Reviewed by Dan Bernstein. * Configurations/CopyPALHeaders.xcconfig: * Configurations/PAL.xcconfig: 2018-04-19 David Kilzer <ddkilzer@apple.com> Enable Objective-C weak references <https://webkit.org/b/184789> <rdar://problem/39571716> Reviewed by Dan Bernstein. * Configurations/Base.xcconfig: (CLANG_ENABLE_OBJC_WEAK): Enable. 2018-04-17 Eric Carlson <eric.carlson@apple.com> [iOS] AirPlay device name is sometimes wrong https://bugs.webkit.org/show_bug.cgi?id=184543 <rdar://problem/39105498> Reviewed by Jer Noble. * pal/spi/mac/AVFoundationSPI.h: Declare more AVOutputContext SPI. 2018-04-16 Brent Fulgham <bfulgham@apple.com> [macOS] Don't establish unneeded Dock connections https://bugs.webkit.org/show_bug.cgi?id=184664 <rdar://problem/16863698> Reviewed by Simon Fraser. There is no reason for the WebContent or Plugin processes to interact with the Dock. We should tell AppKit that we don't want this connection, and to avoid creating such connections. * pal/spi/mac/NSApplicationSPI.h: Add Dock connection declaration. 2018-04-09 John Wilander <wilander@apple.com> Refactor Ignore HSTS code https://bugs.webkit.org/show_bug.cgi?id=184433 <rdar://problem/39298238> Reviewed by Darin Adler. This patch refactors our ignore HSTS code. The convenience functions are moved out of CFNetwork SPI in PAL, and into where they are used. It also switches from performSelector: calls to straight function calls, after checking that there is a responder. * pal/spi/cf/CFNetworkSPI.h: (schemeWasUpgradedDueToDynamicHSTS): Deleted. (setIgnoreHSTS): Deleted. (ignoreHSTS): Deleted. 2018-04-07 Timothy Hatcher <timothy@apple.com> Use the system's link color when system appearance is desired for a WebView. https://bugs.webkit.org/show_bug.cgi?id=184353 rdar://problem/9420053 Reviewed by Wenson Hsieh. * pal/spi/cocoa/NSColorSPI.h: Added linkColor. 2018-04-05 John Wilander <wilander@apple.com> Add necessary colon to CFNetwork selector https://bugs.webkit.org/show_bug.cgi?id=184335 <rdar://problem/39213124> Reviewed by Brent Fulgham. * pal/spi/cf/CFNetworkSPI.h: (setIgnoreHSTS): 2018-04-04 Per Arne Vollan <pvollan@apple.com> The layout test fast/canvas/canvas-blending-global-alpha.html is failing when the WebContent process does not have WindowServer access. https://bugs.webkit.org/show_bug.cgi?id=183752 Reviewed by Brent Fulgham. * pal/spi/cg/CoreGraphicsSPI.h: 2018-04-02 Eric Carlson <eric.carlson@apple.com> Define AVKit softlink macro https://bugs.webkit.org/show_bug.cgi?id=184241 Reviewed by Jer Noble. * pal/cf/CoreMediaSoftLink.h: 2018-03-23 Tim Horton <timothy_horton@apple.com> Fix the !HAVE(APP_LINKS) build https://bugs.webkit.org/show_bug.cgi?id=183974 Reviewed by Dan Bernstein. * pal/spi/cocoa/LaunchServicesSPI.h: This header is not very !HAVE(APP_LINKS) friendly. 2018-03-23 Tim Horton <timothy_horton@apple.com> Fix the build with no pasteboard https://bugs.webkit.org/show_bug.cgi?id=183973 Reviewed by Dan Bernstein. * Configurations/FeatureDefines.xcconfig: 2018-03-22 Tim Horton <timothy_horton@apple.com> Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebCore https://bugs.webkit.org/show_bug.cgi?id=183930 <rdar://problem/38782249> Reviewed by Dan Bernstein. * Configurations/Base.xcconfig: * Configurations/CopyPALHeaders.xcconfig: * Configurations/PAL.xcconfig: 2018-03-22 Tim Horton <timothy_horton@apple.com> Improve readability of WebCore's OTHER_LDFLAGS https://bugs.webkit.org/show_bug.cgi?id=183909 <rdar://problem/38760992> Reviewed by Dan Bernstein. * Configurations/Base.xcconfig: * Configurations/FeatureDefines.xcconfig: 2018-03-21 Brent Fulgham <bfulgham@apple.com> Remove temporary build fix now that underlying issue is resolved https://bugs.webkit.org/show_bug.cgi?id=183854 <rdar://problem/37198715> Reviewed by Eric Carlson. The build environment issues that forced us to disable this setting have been corrected, so this should be turned on for all builds. * pal/spi/cf/CFNetworkSPI.h: 2018-03-20 Tim Horton <timothy_horton@apple.com> Enable the minimal simulator feature flag when appropriate https://bugs.webkit.org/show_bug.cgi?id=183807 Reviewed by Dan Bernstein. * Configurations/FeatureDefines.xcconfig: 2018-03-20 Tim Horton <timothy_horton@apple.com> Add and adopt WK_PLATFORM_NAME and adjust default feature defines https://bugs.webkit.org/show_bug.cgi?id=183758 <rdar://problem/38017644> Reviewed by Dan Bernstein. * Configurations/FeatureDefines.xcconfig: 2018-03-19 Jiewen Tan <jiewen_tan@apple.com> Unreviewed, another quick fix for r229699 Restricts ENABLE_WEB_AUTHN to only macOS and iOS. * Configurations/FeatureDefines.xcconfig: 2018-03-19 Eric Carlson <eric.carlson@apple.com> [Extra zoom mode] Require fullscreen for video playback https://bugs.webkit.org/show_bug.cgi?id=183742 <rdar://problem/38235862> Reviewed by Jer Noble. * pal/spi/cocoa/AVKitSPI.h: 2018-03-19 Jiewen Tan <jiewen_tan@apple.com> Unreviewed, a quick fix for r229699 * pal/spi/cocoa/DeviceIdentitySPI.h: 2018-03-17 Jiewen Tan <jiewen_tan@apple.com> [WebAuthN] Implement authenticatorMakeCredential https://bugs.webkit.org/show_bug.cgi?id=183527 <rdar://problem/35275886> Reviewed by Brent Fulgham. * PAL.xcodeproj/project.pbxproj: * pal/spi/cocoa/DeviceIdentitySPI.h: Copied from Source/WebKit/UIProcess/CredentialManagement/WebCredentialsMessengerProxy.h. 2018-03-14 Tim Horton <timothy_horton@apple.com> Fix the build after r229567 * Configurations/FeatureDefines.xcconfig: 2018-03-13 Dean Jackson <dino@apple.com> Fix some build errors and cleanup QuickLookSPI.h https://bugs.webkit.org/show_bug.cgi?id=183599 Reviewed by Ryan Haddad. * pal/spi/ios/QuickLookSPI.h: 2018-03-12 Dean Jackson <dino@apple.com> Add a WKWebViewContentProvider for system previews https://bugs.webkit.org/show_bug.cgi?id=183582 <rdar://problem/38393569> Reviewed by Tim Horton. Add some QuickLook SPI. * pal/spi/ios/QuickLookSPI.h: 2018-03-12 Don Olmstead <don.olmstead@sony.com> [CMake][Win] Forwarding headers of WTF and PAL are copied twice in Visual Studio builds https://bugs.webkit.org/show_bug.cgi?id=183240 Reviewed by Alex Christensen. * pal/CMakeLists.txt: * pal/PlatformAppleWin.cmake: * pal/PlatformGTK.cmake: * pal/PlatformMac.cmake: * pal/PlatformWPE.cmake: * pal/PlatformWinCairo.cmake: 2018-03-12 Tim Horton <timothy_horton@apple.com> Stop using SDK conditionals to control feature definitions https://bugs.webkit.org/show_bug.cgi?id=183430 <rdar://problem/38251619> Reviewed by Dan Bernstein. * Configurations/FeatureDefines.xcconfig: * Configurations/WebKitTargetConditionals.xcconfig: Renamed. 2018-03-12 Yoav Weiss <yoav@yoav.ws> Runtime flag for link prefetch and remove link subresource. https://bugs.webkit.org/show_bug.cgi?id=183540 Reviewed by Chris Dumez. Remove the LINK_PREFETCH build time flag. * Configurations/FeatureDefines.xcconfig: 2018-03-12 Tim Horton <timothy_horton@apple.com> Use a different SPI header for some AudioToolbox enums https://bugs.webkit.org/show_bug.cgi?id=183574 <rdar://problem/38385889> Reviewed by Anders Carlsson. * PAL.xcodeproj/project.pbxproj: * pal/spi/cocoa/AudioToolboxSPI.h: Added. 2018-03-07 Tim Horton <timothy_horton@apple.com> Sort and separate FeatureDefines.xcconfig https://bugs.webkit.org/show_bug.cgi?id=183427 Reviewed by Dan Bernstein. * Configurations/FeatureDefines.xcconfig: Sort and split FeatureDefines into paragraphs (to make it easier to sort later). 2018-03-05 Yusuke Suzuki <utatane.tea@gmail.com> Fix std::make_unique / new[] using system malloc https://bugs.webkit.org/show_bug.cgi?id=182975 Reviewed by JF Bastien. Use Vector instead. * pal/win/LoggingWin.cpp: (PAL::logLevelString): 2018-03-04 Yusuke Suzuki <utatane.tea@gmail.com> [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively https://bugs.webkit.org/show_bug.cgi?id=183312 Reviewed by Mark Lam. Remove wtf/CurrentTime.h include pragma. * pal/system/ClockGeneric.cpp: 2018-03-04 Tim Horton <timothy_horton@apple.com> Make !ENABLE(DATA_DETECTION) iOS build actually succeed https://bugs.webkit.org/show_bug.cgi?id=183283 <rdar://problem/38062148> Reviewed by Sam Weinig. * Configurations/FeatureDefines.xcconfig: 2018-03-01 Yusuke Suzuki <utatane.tea@gmail.com> Remove monotonicallyIncreasingTime https://bugs.webkit.org/show_bug.cgi?id=182911 Reviewed by Michael Catanzaro. * pal/system/ClockGeneric.cpp: (PAL::ClockGeneric::currentTime const): (PAL::ClockGeneric::now const): * pal/system/ClockGeneric.h: 2018-02-27 Tim Horton <timothy_horton@apple.com> Stop using deprecated CADisplay SPI https://bugs.webkit.org/show_bug.cgi?id=183150 <rdar://problem/37918297> Reviewed by Simon Fraser. * pal/spi/cocoa/QuartzCoreSPI.h: Switch to the more modern way of getting the display name. 2018-02-27 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, rolling out r229055. Breaks internal builds. Reverted changeset: "Stop using deprecated CADisplay SPI" https://bugs.webkit.org/show_bug.cgi?id=183150 https://trac.webkit.org/changeset/229055 2018-02-27 Tim Horton <timothy_horton@apple.com> Stop using deprecated CADisplay SPI https://bugs.webkit.org/show_bug.cgi?id=183150 <rdar://problem/37918297> Reviewed by Simon Fraser. * pal/spi/cocoa/QuartzCoreSPI.h: Switch to the more modern way of getting the display name. 2018-02-20 Tim Horton <timothy_horton@apple.com> Introduce HAVE(IOSURFACE_ACCELERATOR) https://bugs.webkit.org/show_bug.cgi?id=182955 <rdar://problem/37699510> Reviewed by Sam Weinig. * pal/spi/cg/CoreGraphicsSPI.h: * pal/spi/cocoa/IOSurfaceSPI.h: * pal/spi/cocoa/QuartzCoreSPI.h: 2018-02-15 Tim Horton <timothy_horton@apple.com> Stop using EXCLUDED_SOURCE_FILE_NAMES for actual source files in WebCore https://bugs.webkit.org/show_bug.cgi?id=182822 Reviewed by Dan Bernstein. * Configurations/PAL.xcconfig: * pal/system/Sound.cpp: * pal/system/mac/SoundMac.mm: * pal/text/KillRing.cpp: * pal/text/mac/KillRingMac.mm: 2018-02-09 Don Olmstead <don.olmstead@sony.com> [CMake] Make PAL headers copies https://bugs.webkit.org/show_bug.cgi?id=182645 Reviewed by Alex Christensen. * pal/CMakeLists.txt: * pal/PlatformAppleWin.cmake: * pal/PlatformGTK.cmake: * pal/PlatformMac.cmake: * pal/PlatformWPE.cmake: * pal/PlatformWin.cmake: * pal/PlatformWinCairo.cmake: 2018-01-30 Myles C. Maxfield <mmaxfield@apple.com> A disallowed user-installed font may be used if its PostScript name is specified https://bugs.webkit.org/show_bug.cgi?id=180951 Reviewed by Brent Fulgham. * pal/spi/cocoa/CoreTextSPI.h: 2018-01-29 Jiewen Tan <jiewen_tan@apple.com> [WebAuthN] Add a compile-time feature flag https://bugs.webkit.org/show_bug.cgi?id=182211 <rdar://problem/36936365> Reviewed by Brent Fulgham. * Configurations/FeatureDefines.xcconfig: 2018-01-27 Dan Bernstein <mitz@apple.com> HaveInternalSDK includes should be "#include?" https://bugs.webkit.org/show_bug.cgi?id=179670 * Configurations/Base.xcconfig: 2018-01-24 Alex Christensen <achristensen@webkit.org> Fix Windows build after r227552 https://bugs.webkit.org/show_bug.cgi?id=182026 * pal/spi/cg/CoreGraphicsSPI.h: 2018-01-24 Alex Christensen <achristensen@webkit.org> Remove pre-Sierra-OS-specific code in WebCore https://bugs.webkit.org/show_bug.cgi?id=182026 Reviewed by Tim Horton. * pal/spi/cf/CFNetworkSPI.h: * pal/spi/cg/CoreGraphicsSPI.h: * pal/spi/cocoa/DataDetectorsCoreSPI.h: * pal/spi/cocoa/QuartzCoreSPI.h: * pal/spi/mac/AVFoundationSPI.h: * pal/spi/mac/NSMenuSPI.h: * pal/spi/mac/NSScrollingMomentumCalculatorSPI.h: * pal/spi/mac/PIPSPI.h: 2018-01-23 Dean Jackson <dino@apple.com> REGRESSION (r222961?): sRGB images shown in WebGL are over-saturated on a wide gamut monitor https://bugs.webkit.org/show_bug.cgi?id=182033 <rdar://problem/36377780> Reviewed by Antoine Quint. Expose an IOSurface colorspace property name, and a function to serialize a CGColorSpace. * pal/spi/cg/CoreGraphicsSPI.h: * pal/spi/cocoa/IOSurfaceSPI.h: 2018-01-23 Michael Catanzaro <mcatanzaro@igalia.com> [WPE][GTK] Sleep inhibitors do not work under Flatpak https://bugs.webkit.org/show_bug.cgi?id=180812 Reviewed by Carlos Garcia Campos. Ensure SleepDisablerGLib works even when running inside a Flatpak sandbox by using the Freedesktop inhibit portal D-Bus API. Unfortunately this has to be tested manually. * pal/system/glib/SleepDisablerGLib.cpp: (PAL::SleepDisablerGLib::SleepDisablerGLib): (PAL::SleepDisablerGLib::~SleepDisablerGLib): (PAL::SleepDisablerGLib::acquireInhibitor): (PAL::SleepDisablerGLib::acquireInhibitorViaScreenSaverProxy): (PAL::SleepDisablerGLib::acquireInhibitorViaInhibitPortalProxy): (PAL::SleepDisablerGLib::releaseInhibitor): (PAL::SleepDisablerGLib::releaseInhibitorViaScreenSaverProxy): (PAL::SleepDisablerGLib::releaseInhibitorViaInhibitPortalProxy): 2018-01-22 Myles C. Maxfield <mmaxfield@apple.com> [Cocoa] Support font collections https://bugs.webkit.org/show_bug.cgi?id=181826 <rdar://problem/36455137> Reviewed by Dean Jackson. * pal/spi/cocoa/CoreTextSPI.h: 2018-01-21 Wenson Hsieh <wenson_hsieh@apple.com> Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h https://bugs.webkit.org/show_bug.cgi?id=181918 Reviewed by Tim Horton. Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default). * Configurations/FeatureDefines.xcconfig: 2018-01-18 Dan Bernstein <mitz@apple.com> [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions https://bugs.webkit.org/show_bug.cgi?id=181803 Reviewed by Tim Horton. * Configurations/Base.xcconfig: Updated. * Configurations/DebugRelease.xcconfig: Ditto. * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers. * Configurations/Version.xcconfig: Updated. * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings useful for defining settings that depend on the target macOS version. 2018-01-17 John Wilander <wilander@apple.com> Resource Load Statistics: Block cookies for prevalent resources without user interaction https://bugs.webkit.org/show_bug.cgi?id=177394 <rdar://problem/34613960> Reviewed by Alex Christensen. * pal/spi/cf/CFNetworkSPI.h: Declaration of _initWithIdentifier() on NSHTTPCookieStorage. 2018-01-17 Matt Lewis <jlewis3@apple.com> Unreviewed, rolling out r227098. This broke the build. Reverted changeset: "Remove linked-on test for Snow Leopard" https://bugs.webkit.org/show_bug.cgi?id=181770 https://trac.webkit.org/changeset/227098 2018-01-17 Dean Jackson <dino@apple.com> Remove linked-on test for Snow Leopard https://bugs.webkit.org/show_bug.cgi?id=181770 Reviewed by Eric Carlson. No need for _CFExecutableLinkedOnOrAfter any more. * pal/spi/cf/CFUtilitiesSPI.h: 2018-01-17 Matt Lewis <jlewis3@apple.com> Unreviewed, rolling out r227076. This breaks internal builds Reverted changeset: "Resource Load Statistics: Block cookies for prevalent resources without user interaction" https://bugs.webkit.org/show_bug.cgi?id=177394 https://trac.webkit.org/changeset/227076 2018-01-17 John Wilander <wilander@apple.com> Resource Load Statistics: Block cookies for prevalent resources without user interaction https://bugs.webkit.org/show_bug.cgi?id=177394 <rdar://problem/34613960> Reviewed by Alex Christensen. * pal/spi/cf/CFNetworkSPI.h: Declaration of _initWithIdentifier() on NSHTTPCookieStorage. 2018-01-16 Michael Catanzaro <mcatanzaro@igalia.com> PAL should link to JavaScriptCore rather than WTF https://bugs.webkit.org/show_bug.cgi?id=181683 Reviewed by Konstantin Tokarev. Currently we are accidentally linking WTF into both libjavascriptcoregtk and libwebkit2gtk, which could in theory cause problems similar to bug #179914. There are only two possible solutions: - Ensure WTF always built as a shared library if JavaScriptCore is built as a shared library - Change PAL to link to JavaScriptCore instead of WTF The problem here is caused by layer hopping. It can never be a problem if each library only links to the next lowest-layered library. The downside is this allows PAL to use JavaScriptCore symbols, which is not super desirable. I came up with a hack yesterday for PAL to link to WTF usually, but link to JavaScriptCore instead if ${JavaScriptCore_LIBRARY_TYPE} MATCHES "SHARED" AND ${WTF_LIBRARY_TYPE} MATCHES "STATIC". But that is getting too complex and introduces more possibility for platform- dependent build failures. Better to just accept that PAL will depend on JavaScriptCore. Note: I'm not brave enough to update the XCode build. We can use that to enforce that no JavaScriptCore symbols actually get used, I guess.... * pal/CMakeLists.txt: 2018-01-15 Michael Catanzaro <mcatanzaro@igalia.com> Improve use of ExportMacros https://bugs.webkit.org/show_bug.cgi?id=181652 Reviewed by Konstantin Tokarev. Remove a comment. * pal/ExportMacros.h: 2018-01-11 Keith Miller <keith_miller@apple.com> Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION https://bugs.webkit.org/show_bug.cgi?id=181573 Reviewed by Simon Fraser. * Configurations/FeatureDefines.xcconfig: 2018-01-10 Per Arne Vollan <pvollan@apple.com> VoiceOver does not work when the WebContent process is using NSRunLoop. https://bugs.webkit.org/show_bug.cgi?id=181331 <rdar://problem/36408004> Reviewed by Brent Fulgham. Add NSApplication class method to initialize accessibility. * pal/spi/mac/NSApplicationSPI.h: 2018-01-05 Eric Carlson <eric.carlson@apple.com> [MediaStream] Add Mac screen capture source https://bugs.webkit.org/show_bug.cgi?id=181333 <rdar://problem/36323219> Reviewed by Dean Jackson. * pal/spi/cg/CoreGraphicsSPI.h: Declare some CGDisplayMode SPI. 2018-01-03 Ting-Wei Lan <lantw44@gmail.com> Replace hard-coded paths in shebangs with #!/usr/bin/env https://bugs.webkit.org/show_bug.cgi?id=181040 Reviewed by Alex Christensen. * AVFoundationSupport.py: 2018-01-03 Per Arne Vollan <pvollan@apple.com> [Win] WebKitLegacy compile error. https://bugs.webkit.org/show_bug.cgi?id=181257 rdar://problem/36273774 Reviewed by Alex Christensen. The include file 'pal/text/UnencodableHandling.h' is not found. Add folder to list of forwarding headers directories. * pal/PlatformWin.cmake: 2018-01-02 Brent Fulgham <bfulgham@apple.com> [macOS, iOS] Adopt new secure coding APIs in WebKit https://bugs.webkit.org/show_bug.cgi?id=181085 <rdar://problem/34837397> Reviewed by Tim Horton. Add a new helper function to allow WebKit code to use NSSecureCoding in more places when the underlying operating system supports it. * pal/spi/cocoa/NSKeyedArchiverSPI.h: (decodeObjectOfClassForKeyFromCoder): New wrapper method. 2017-12-21 Brent Fulgham <bfulgham@apple.com> Unreviewed test fix after r226224. <rdar://problem/36185975> Pasteboard data is more than a dictionary. We have to whitelist NSString and NSArray as well. Change method name to reflect that we take a whitelist of classes that are allowed to be unarchived in the call. * pal/spi/cocoa/NSKeyedArchiverSPI.h: (unarchivedObjectOfClassesFromData): (unarchivedObjectOfClassFromData): Deleted. 2017-12-21 Jeremy Jones <jeremyj@apple.com> Update FULLSCREEN_API feature defines. https://bugs.webkit.org/show_bug.cgi?id=181015 Reviewed by Tim Horton. Change enabled iphone sdk for FULLSCREEN_API. * Configurations/FeatureDefines.xcconfig: 2017-12-21 Brent Fulgham <bfulgham@apple.com> Adopt new secure coding APIs in WebCore https://bugs.webkit.org/show_bug.cgi?id=178484 <rdar://problem/34837193> Reviewed by Eric Carlson. Due to <rdar://problem/31376830 we cannot used SecureCoding on NSAttributedString in some cases. Add a macro for OS revisions that do not support secure coding, and use the standard unarchive operation for NSAttributedString in those cases. Rename 'insecurelyUnarchiveObjectOfClassFromData' to 'insecurelyUnarchiveObjectFromData', and move it earlier in the file so that it can be reused in 'unarchivedObjectOfClassFromData'. * pal/spi/cocoa/NSKeyedArchiverSPI.h: (insecurelyUnarchiveObjectFromData): Renamed from insecurelyUnarchiveObjectOfClassFromData. (unarchivedObjectOfClassFromData): Renamed from 'securelyUnarchiveObjectOfClassFromData' and modified to use 'insecurelyUnarchiveObjectFromData'. (securelyUnarchiveObjectOfClassFromData): Deleted. (insecurelyUnarchiveObjectOfClassFromData): Deleted. 2017-12-21 Jeremy Jones <jeremyj@apple.com> Element fullscreen interface should display the location https://bugs.webkit.org/show_bug.cgi?id=181006 rdar://problem/36143176 Reviewed by Simon Fraser. Add iOS availability check. * pal/spi/cocoa/LinkPresentationSPI.h: 2017-12-20 Daniel Bates <dabates@apple.com> Remove Alternative Presentation Button https://bugs.webkit.org/show_bug.cgi?id=180500 <rdar://problem/35891047> Reviewed by Simon Fraser. We no longer need the alternative presentation button. * Configurations/FeatureDefines.xcconfig: 2017-12-20 Andy Estes <aestes@apple.com> [Apple Pay] Tell PassKit whether Apple Pay JS or Payment Request was used to start an Apple Pay session https://bugs.webkit.org/show_bug.cgi?id=181001 <rdar://problem/35479106> Reviewed by Tim Horton. * pal/spi/cocoa/PassKitSPI.h: 2017-12-19 Andy Estes <aestes@apple.com> [Apple Pay] Stop maintaining a list of payment networks https://bugs.webkit.org/show_bug.cgi?id=180965 <rdar://problem/34696560> Reviewed by Tim Horton. * pal/spi/cocoa/PassKitSPI.h: Defined +[PKPaymentRequest availableNetworks]. 2017-12-14 David Kilzer <ddkilzer@apple.com> Fix 32-bit build: Enable -Wstrict-prototypes for WebKit <https://webkit.org/b/180757> <rdar://problem/36024132> * pal/spi/mac/QuickDrawSPI.h: (NewRgn): Add 'void' to C function declaration. (PenNormal): Ditto. 2017-12-14 David Kilzer <ddkilzer@apple.com> Enable -Wstrict-prototypes for WebKit <https://webkit.org/b/180757> <rdar://problem/36024132> Rubber-stamped by Joseph Pecoraro. * Configurations/Base.xcconfig: (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES. 2017-12-11 Joseph Pecoraro <pecoraro@apple.com> Unreviewed build fix after r225766. * pal/spi/mac/AVFoundationSPI.h: Conform AVStreamDataParser to the AVContentKeyRecipient protocol if available. 2017-12-11 David Quesada <david_quesada@apple.com> Turn on ENABLE_APPLICATION_MANIFEST https://bugs.webkit.org/show_bug.cgi?id=180562 rdar://problem/35924737 Reviewed by Geoffrey Garen. * Configurations/FeatureDefines.xcconfig: 2017-12-08 Konstantin Tokarev <annulen@yandex.ru> [python] Replace print operator with print() function for python3 compatibility https://bugs.webkit.org/show_bug.cgi?id=180592 Reviewed by Michael Catanzaro. * AVFoundationSupport.py: 2017-12-08 Eric Carlson <eric.carlson@apple.com> Move Logger from PAL to WTF so it can be used outside of WebCore https://bugs.webkit.org/show_bug.cgi?id=180561 Reviewed by Alex Christensen. * PAL.xcodeproj/project.pbxproj: * pal/Logger.h: Removed. * pal/LoggerHelper.h: Removed. 2017-12-07 Myles C. Maxfield <mmaxfield@apple.com> [Cocoa] Add SPI to disallow user-installed fonts https://bugs.webkit.org/show_bug.cgi?id=180062 <rdar://problem/35042408> Reviewed by Simon Fraser. * pal/spi/cocoa/CoreTextSPI.h: 2017-12-02 Darin Adler <darin@apple.com> Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp https://bugs.webkit.org/show_bug.cgi?id=180009 Reviewed by Alex Christensen. * PAL.xcodeproj/project.pbxproj: Added UnencodableHandling.h. * pal/text/UnencodableHandling.h: Moved the UnencodableHandling enumeration here from TextCodec.h and changed it to an enum class. 2017-12-04 David Quesada <david_quesada@apple.com> Add a class for parsing application manifests https://bugs.webkit.org/show_bug.cgi?id=177973 rdar://problem/34747949 Reviewed by Geoffrey Garen. * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag. 2017-12-04 Zan Dobersek <zdobersek@igalia.com> Unreviewed WPE build fix. * pal/PlatformWPE.cmake: Use GLIB_INCLUDE_DIRS for building the PAL library. 2017-12-04 Michael Catanzaro <mcatanzaro@igalia.com> [WPE][GTK] Implement PAL::SleepDisabler https://bugs.webkit.org/show_bug.cgi?id=178485 Reviewed by Carlos Garcia Campos. * pal/PlatformGTK.cmake: * pal/PlatformWPE.cmake: * pal/system/SleepDisabler.cpp: * pal/system/glib/SleepDisablerGLib.cpp: Added. (PAL::SleepDisabler::create): (PAL::SleepDisablerGLib::SleepDisablerGLib): (PAL::SleepDisablerGLib::~SleepDisablerGLib): (PAL::SleepDisablerGLib::acquireInhibitor): (PAL::SleepDisablerGLib::releaseInhibitor): * pal/system/glib/SleepDisablerGLib.h: Added. 2017-11-30 Stephan Szabo <stephan.szabo@sony.com> Make LegacyCustomProtocolManager optional for network process https://bugs.webkit.org/show_bug.cgi?id=176230 Reviewed by Alex Christensen. * Configurations/FeatureDefines.xcconfig: 2017-11-29 Brent Fulgham <bfulgham@apple.com> Part 2: Adopt updated NSKeyed[Un]Archiver API when available https://bugs.webkit.org/show_bug.cgi?id=180127 <rdar://problem/35710738> Reviewed by Simon Fraser. The API that accepts a user-allocated NSMutableData is deprecated. Switch (for macOS 10.12 and newer) to the modern API. Use the original API for macOS builds prior to 10.12. * pal/spi/cocoa/NSKeyedArchiverSPI.h: (secureArchiver): Added. (secureArchiverFromMutableData): Deleted. 2017-11-29 Alex Christensen <achristensen@webkit.org> Fix Mac CMake build. * pal/PlatformMac.cmake: 2017-11-28 Brent Fulgham <bfulgham@apple.com> Adopt updated NSKeyed[Un]Archiver API when available https://bugs.webkit.org/show_bug.cgi?id=180127 <rdar://problem/35710738> Reviewed by Alex Christensen. Add new convenience methods (and SPI headers) so we can adopt new NSKeyedArchiver API that uses secure coding by default. * PAL.xcodeproj/project.pbxproj: * pal/spi/cocoa/NSKeyedArchiverSPI.h: Added. (securelyArchivedDataWithRootObject): New convenience method. (securelyUnarchiveRootObjectOfClassFromData): Ditto. (secureArchiverFromMutableData): Ditto. (secureUnarchiverFromData): Ditto. 2017-11-28 Tim Horton <timothy_horton@apple.com> REGRESSION (High Sierra): Layout Test fast/multicol/newmulticol/spanner2.html is a flaky image failure on WK1 https://bugs.webkit.org/show_bug.cgi?id=177826 <rdar://problem/34876498> Reviewed by Alexey Proskuryakov. * pal/spi/cg/CoreGraphicsSPI.h: 2017-11-27 Tim Horton <timothy_horton@apple.com> One too many zeroes in macOS version number in FeatureDefines https://bugs.webkit.org/show_bug.cgi?id=180011 Reviewed by Dan Bernstein. * Configurations/FeatureDefines.xcconfig: 2017-11-19 Tim Horton <timothy_horton@apple.com> Remove unused TOUCH_ICON_LOADING feature flag https://bugs.webkit.org/show_bug.cgi?id=179873 Reviewed by Simon Fraser. * Configurations/FeatureDefines.xcconfig: 2017-11-19 Tim Horton <timothy_horton@apple.com> Remove unused LEGACY_VENDOR_PREFIXES feature flag https://bugs.webkit.org/show_bug.cgi?id=179872 Reviewed by Darin Adler. * Configurations/FeatureDefines.xcconfig: 2017-11-16 Daniel Bates <dabates@apple.com> Add feature define for alternative presentation button element https://bugs.webkit.org/show_bug.cgi?id=179692 Part of <rdar://problem/34917108> Reviewed by Andy Estes. Only enabled on Cocoa platforms by default. * Configurations/FeatureDefines.xcconfig: 2017-11-14 Daniel Bates <dabates@apple.com> Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files for feature defines Following r195498 and r201917 the Visual Studio property files for feature defines have moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops. Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these files. * Configurations/FeatureDefines.xcconfig: 2017-11-08 Keith Miller <keith_miller@apple.com> Async iteration should only fetch the next method once and add feature flag https://bugs.webkit.org/show_bug.cgi?id=179451 Reviewed by Geoffrey Garen. Add feature flag for Async iteration. * Configurations/FeatureDefines.xcconfig: 2017-11-10 John Wilander <wilander@apple.com> Ignore HSTS for partitioned, cross-origin subresource requests https://bugs.webkit.org/show_bug.cgi?id=178993 <rdar://problem/34962462> Reviewed by Brent Fulgham. * pal/spi/cf/CFNetworkSPI.h: Added - (BOOL)_schemeWasUpgradedDueToDynamicHSTS - (BOOL)_preventHSTSStorage - (BOOL)_ignoreHSTS - (void)_setPreventHSTSStorage:(BOOL)preventHSTSStorage - (void)_setIgnoreHSTS:(BOOL)ignoreHSTS 2017-11-09 Dan Bernstein <mitz@apple.com> [Xcode] An extra copy of FileSizeFormatter.h is installed in /usr/local/include https://bugs.webkit.org/show_bug.cgi?id=179525 Reviewed by Wenson Hsieh. * PAL.xcodeproj/project.pbxproj: Demoted FileSizeFormatter.h to a project header in the PAL target. The Copy PAL Headers target takes care of installing this header under /usr/local/include/pal. 2017-11-09 Chris Dumez <cdumez@apple.com> Unreviewed, rolling out r224661. Broke build on several internal Mac/iOS bots Reverted changeset: "Ignore HSTS for partitioned, cross-origin subresource requests" https://bugs.webkit.org/show_bug.cgi?id=178993 https://trac.webkit.org/changeset/224661 2017-11-09 John Wilander <wilander@apple.com> Ignore HSTS for partitioned, cross-origin subresource requests https://bugs.webkit.org/show_bug.cgi?id=178993 <rdar://problem/34962462> Reviewed by Brent Fulgham. * pal/spi/cf/CFNetworkSPI.h: Added - (BOOL)_schemeWasUpgradedDueToDynamicHSTS - (BOOL)_preventHSTSStorage - (BOOL)_ignoreHSTS - (void)_setPreventHSTSStorage:(BOOL)preventHSTSStorage - (void)_setIgnoreHSTS:(BOOL)ignoreHSTS 2017-11-08 Jeremy Jones <jeremyj@apple.com> HTMLMediaElement should not use element fullscreen on iOS https://bugs.webkit.org/show_bug.cgi?id=179418 rdar://problem/35409277 Reviewed by Eric Carlson. Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not. * Configurations/FeatureDefines.xcconfig: 2017-11-06 Said Abou-Hallawa <sabouhallawa@apple.com> [CG] Adopt CGContextDrawPathDirect() https://bugs.webkit.org/show_bug.cgi?id=179339 <rdar://problem/26283575> Reviewed by Simon Fraser. Add CGContextDrawPathDirect() as a new CoreGraphics SPI. * pal/spi/cg/CoreGraphicsSPI.h: 2017-11-02 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, rolling out r224353. Breaks internal builds. Reverted changeset: "Ignore HSTS for partitioned, cross-origin subresource requests" https://bugs.webkit.org/show_bug.cgi?id=178993 https://trac.webkit.org/changeset/224353 2017-11-02 John Wilander <wilander@apple.com> Ignore HSTS for partitioned, cross-origin subresource requests https://bugs.webkit.org/show_bug.cgi?id=178993 <rdar://problem/34962462> Reviewed by Brent Fulgham and Alex Christensen. * pal/spi/cf/CFNetworkSPI.h: Added - (BOOL)_schemeWasUpgradedDueToDynamicHSTS - (BOOL)_preventHSTSStorage - (BOOL)_ignoreHSTS - (void)_setPreventHSTSStorage:(BOOL)preventHSTSStorage - (void)_setIgnoreHSTS:(BOOL)ignoreHSTS 2017-11-02 Frederic Wang <fwang@igalia.com> Add references to bug 179167 in FIXME comments https://bugs.webkit.org/show_bug.cgi?id=179168 Reviewed by Daniel Bates. * Configurations/FeatureDefines.xcconfig: 2017-11-01 Jeremy Jones <jeremyj@apple.com> Implement WKFullscreenWindowController for iOS. https://bugs.webkit.org/show_bug.cgi?id=178924 rdar://problem/34697120 Reviewed by Simon Fraser. Enable ENABLE_FULLSCREEN_API for iOS; * Configurations/FeatureDefines.xcconfig: 2017-11-01 Daniel Bates <dabates@apple.com> XMLHttpRequest should not sniff content encoding https://bugs.webkit.org/show_bug.cgi?id=175597 <rdar://problem/34912624> Reviewed by Alex Christensen. Forward declare CFNetwork SPI. * pal/spi/cf/CFNetworkSPI.h: 2017-10-31 Tim Horton <timothy_horton@apple.com> Clean up some drag and drop feature flags https://bugs.webkit.org/show_bug.cgi?id=179082 Reviewed by Simon Fraser. * Configurations/FeatureDefines.xcconfig: 2017-10-31 Tim Horton <timothy_horton@apple.com> Fix up some content filtering feature flags https://bugs.webkit.org/show_bug.cgi?id=179079 Reviewed by Simon Fraser. * Configurations/FeatureDefines.xcconfig: 2017-10-31 Wenson Hsieh <wenson_hsieh@apple.com> [Attachment Support] Implement WKWebView SPI for inserting attachment elements https://bugs.webkit.org/show_bug.cgi?id=179013 <rdar://problem/35249668> Reviewed by Tim Horton. Add a PAL library function to convert a file size to a human-readable string. On Cocoa platforms, this is a wrapper around NSLocalizedFileSizeDescription; otherwise, we fall back to a naive platform-agnostic implementation in FileSizeFormatter.cpp. * PAL.xcodeproj/project.pbxproj: * pal/CMakeLists.txt: * pal/FileSizeFormatter.cpp: Added. (fileSizeDescription): * pal/FileSizeFormatter.h: Added. * pal/cocoa/FileSizeFormatterCocoa.mm: Added. (fileSizeDescription): * pal/spi/cocoa/NSFileSizeFormatterSPI.h: Added. 2017-10-27 Keith Miller <keith_miller@apple.com> Move iOS specific sources to unified sources https://bugs.webkit.org/show_bug.cgi?id=178915 Rubber-stamped by Tim Horton. * pal/spi/cocoa/QuartzCoreSPI.h: Add missing pragma once. 2017-10-26 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, rolling out r223908. Causes LayoutTest crashes with newer SDKs. Reverted changeset: "Adopt new secure coding APIs" https://bugs.webkit.org/show_bug.cgi?id=178484 https://trac.webkit.org/changeset/223908 2017-10-24 Eric Carlson <eric.carlson@apple.com> Web Inspector: Enable WebKit logging configuration and display https://bugs.webkit.org/show_bug.cgi?id=177027 <rdar://problem/33964767> Reviewed by Joseph Pecoraro. * pal/Logger.h: (PAL::Logger::willLog const): Always return true for Always and Error so those messages are always logged to the system. (PAL::Logger::log): Always log Always and Error to the system, but pay strict attention to level and channel state for logging to observers so logging only shows up in the inspector when explicitly enabled by the user. 2017-10-24 Brent Fulgham <bfulgham@apple.com> Adopt new secure coding APIs https://bugs.webkit.org/show_bug.cgi?id=178484 <rdar://problem/34837193> Reviewed by Tim Horton. Add new convenience methods (and SPI headers) so we can adopt new NSKeyedArchiver API that uses secure coding by default. * PAL.xcodeproj/project.pbxproj: * pal/spi/cocoa/NSKeyedArchiverSPI.h: Added. (securelyArchivedDataWithRootObject): New convenience method. (securelyUnarchiveRootObjectOfClassFromData): Ditto. (secureArchiverFromMutableData): Ditto. (secureUnarchiverFromData): Ditto. 2017-10-24 Matt Lewis <jlewis3@apple.com> Unreviewed, rolling out r223889. This caused multiple crashes on all platforms Reverted changeset: "Adopt new secure coding APIs" https://bugs.webkit.org/show_bug.cgi?id=178484 https://trac.webkit.org/changeset/223889 2017-10-24 Brent Fulgham <bfulgham@apple.com> Adopt new secure coding APIs https://bugs.webkit.org/show_bug.cgi?id=178484 <rdar://problem/34837193> Reviewed by Tim Horton. Add new convenience methods (and SPI headers) so we can adopt new NSKeyedArchiver API that uses secure coding by default. * PAL.xcodeproj/project.pbxproj: * pal/spi/cocoa/NSKeyedArchiverSPI.h: Added. (securelyArchivedDataWithRootObject): New convenience method. (securelyUnarchiveRootObjectOfClassFromData): Ditto. (secureArchiverFromMutableData): Ditto. (secureUnarchiverFromData): Ditto. 2017-10-20 Alex Christensen <achristensen@webkit.org> Expose _boundInterfaceIdentifier and _allowsCellularAccess to WKWebsiteDataStorePrivate https://bugs.webkit.org/show_bug.cgi?id=178418 <rdar://problem/29599569> Reviewed by Tim Horton. * pal/spi/cf/CFNetworkSPI.h: 2017-10-20 Antoine Quint <graouts@apple.com> [Web Animations] Provide basic timeline and animation interfaces https://bugs.webkit.org/show_bug.cgi?id=178526 Reviewed by Dean Jackson. Remove the WEB_ANIMATIONS compile-time flag. * Configurations/FeatureDefines.xcconfig: 2017-10-19 Daniel Bates <dabates@apple.com> Use "= default" to denote default constructor or destructor https://bugs.webkit.org/show_bug.cgi?id=178528 Rubber-stamped by Andy Estes. * pal/Logger.h: (PAL::Logger::Observer::~Observer): Deleted. * pal/crypto/gcrypt/CryptoDigestGCrypt.cpp: * pal/system/SleepDisabler.cpp: * pal/system/SystemSleepListener.h: 2017-10-17 Keith Miller <keith_miller@apple.com> Change WebCore sources to work with unified source builds https://bugs.webkit.org/show_bug.cgi?id=178229 Rubber stamped by Tim Horton. Move soft linking code from WebCore to PAL. * Configurations/FeatureDefines.xcconfig: * pal/cf/CoreMediaSoftLink.cpp: * pal/cf/CoreMediaSoftLink.h: * pal/spi/cocoa/NSAttributedStringSPI.h: 2017-10-13 Adrian Perez de Castro <aperez@igalia.com> [WPE][GTK] Provide an implementation of PAL::logLevelString() https://bugs.webkit.org/show_bug.cgi?id=178263 Reviewed by Carlos Alberto Lopez Perez. Provide an implementation of PAL::logLevelString() which picks the value from the WEBCORE_DEBUG environment variable. Logging of notImplemented() calls is always enabled, which is the same behavior as in WebCore::logLevelString(). * pal/PlatformGTK.cmake: Add LoggingUnix.cpp to the list of sources. * pal/PlatformWPE.cmake: Add LoggingUnix.cpp to the list of sources. * pal/unix/LoggingUnix.cpp: Added. (PAL::logLevelString): 2017-10-13 Jer Noble <jer.noble@apple.com> Unreviewed build fix; add definitions for IOSurface methods missing on some platforms. * pal/spi/cocoa/IOSurfaceSPI.h: 2017-10-12 Myles C. Maxfield <mmaxfield@apple.com> [Win] Build fix after r223206 https://bugs.webkit.org/show_bug.cgi?id=171523 Unreviewed. * pal/PlatformWin.cmake: * pal/win/LoggingWin.cpp: Added. (PAL::logLevelString): 2017-10-11 Myles C. Maxfield <mmaxfield@apple.com> Allow PAL to log messages https://bugs.webkit.org/show_bug.cgi?id=171523 Reviewed by Alex Christensen. * PAL.xcodeproj/project.pbxproj: * pal/CMakeLists.txt: * pal/LogInitialization.h: Copied from Source/WebCore/platform/LogMacros.h. * pal/LogMacros.h: Copied from Source/WebCore/platform/LogMacros.h. * pal/Logging.cpp: Copied from Source/WebCore/platform/Logging.cpp. (PAL::isLogChannelEnabled): (PAL::setLogChannelToAccumulate): (PAL::initializeLogChannelsIfNecessary): (PAL::registerNotifyCallback): * pal/Logging.h: Copied from Source/WebCore/platform/LogMacros.h. * pal/PlatformMac.cmake: * pal/cocoa/LoggingCocoa.mm: Renamed from Source/WebCore/platform/LogMacros.h. (PAL::logLevelString): 2017-10-06 Chris Dumez <cdumez@apple.com> [Beacon][Cocoa] Beacon requests with BufferSource payload should not have a Content-Type HTTP header https://bugs.webkit.org/show_bug.cgi?id=178027 <rdar://problem/34748470> Reviewed by Youenn Fablet. Add new CFNetwork SPI. * pal/spi/cf/CFNetworkSPI.h: 2017-10-05 Dean Jackson <dino@apple.com> Lots of missing frames in YouTube360 when fullscreen on MacBook https://bugs.webkit.org/show_bug.cgi?id=177903 <rdar://problem/33273300> Reviewed by Sam Weinig. Add reloadValueForKeyPath to replace setContentsChanged on CALayer. * pal/spi/cocoa/QuartzCoreSPI.h: 2017-10-05 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r222951 and r222952. https://bugs.webkit.org/show_bug.cgi?id=177992 "Broke the iOS build and introduced a webgl LayoutTest failure." (Requested by ryanhaddad on #webkit). Reverted changesets: "Lots of missing frames in YouTube360 when fullscreen on MacBook" https://bugs.webkit.org/show_bug.cgi?id=177903 http://trac.webkit.org/changeset/222951 "Lots of missing frames in YouTube360 when fullscreen on MacBook" https://bugs.webkit.org/show_bug.cgi?id=177903 http://trac.webkit.org/changeset/222952 2017-10-05 Dean Jackson <dino@apple.com> Lots of missing frames in YouTube360 when fullscreen on MacBook https://bugs.webkit.org/show_bug.cgi?id=177903 <rdar://problem/33273300> Reviewed by Sam Weinig. Add reloadValueForKeyPath to replace setContentsChanged on CALayer. * pal/spi/cocoa/QuartzCoreSPI.h: 2017-10-05 Jer Noble <jer.noble@apple.com> [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting https://bugs.webkit.org/show_bug.cgi?id=177261 Reviewed by Eric Carlson. * Configurations/FeatureDefines.xcconfig: 2017-09-28 Ross Kirsling <ross.kirsling@sony.com> [PAL] Move HysteresisActivity into PAL https://bugs.webkit.org/show_bug.cgi?id=177516 Reviewed by Alex Christensen. * PAL.xcodeproj/project.pbxproj: * pal/HysteresisActivity.h: Renamed from Source/WebCore/platform/HysteresisActivity.h. 2017-09-28 Chris Dumez <cdumez@apple.com> Add support for <link rel=preconnect> https://bugs.webkit.org/show_bug.cgi?id=177474 <rdar://problem/33141380> Reviewed by Alex Christensen. Add new CFNetwork SPI for preconnecting. * pal/spi/cf/CFNetworkSPI.h: 2017-09-27 Tim Horton <timothy_horton@apple.com> Try to fix the Mac CMake build * pal/PlatformMac.cmake: 2017-09-26 Don Olmstead <don.olmstead@sony.com> [PAL][CMake] Include ICU directories https://bugs.webkit.org/show_bug.cgi?id=177504 Reviewed by Myles C. Maxfield. * pal/CMakeLists.txt: 2017-09-26 Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> [PAL] Move Clock into PAL https://bugs.webkit.org/show_bug.cgi?id=174342 Reviewed by Myles C. Maxfield. * PAL.xcodeproj/project.pbxproj: * pal/PlatformGTK.cmake: * pal/PlatformWin.cmake: * pal/system/Clock.h: Renamed from Source/WebCore/platform/Clock.h. * pal/system/ClockGeneric.cpp: Renamed from Source/WebCore/platform/ClockGeneric.cpp. (PAL::Clock::create): * pal/system/ClockGeneric.h: Renamed from Source/WebCore/platform/ClockGeneric.h. * pal/system/mac/ClockCM.h: Renamed from Source/WebCore/platform/mac/PlatformClockCM.h. * pal/system/mac/ClockCM.mm: Renamed from Source/WebCore/platform/mac/PlatformClockCM.mm. (Clock::create): (ClockCM::ClockCM): (ClockCM::initializeWithTimingSource): (ClockCM::setCurrentTime): (ClockCM::currentTime const): (ClockCM::setCurrentMediaTime): (ClockCM::currentMediaTime const): (ClockCM::setPlayRate): (ClockCM::start): (ClockCM::stop): * pal/cf/CoreMediaSoftLink.cpp: * pal/cf/CoreMediaSoftLink.h: Add requrired functions. 2017-09-26 Zan Dobersek <zdobersek@igalia.com> [GCrypt] Only report libgcrypt errors when logging is enabled https://bugs.webkit.org/show_bug.cgi?id=177360 Reviewed by Xabier Rodriguez-Calvar. * pal/crypto/gcrypt/Utilities.h: (PAL::GCrypt::logError): Only print out the libgcrypt error on stderr when logging is enabled at build-time, avoiding unnecessary output in non-debugging use cases. 2017-09-25 Timothy Horton <timothy_horton@apple.com> Make progress on getting Mac CMake building again https://bugs.webkit.org/show_bug.cgi?id=177443 Unreviewed, just "fixing" the build. * pal/PlatformMac.cmake: Add some missing files and include paths. 2017-09-22 Zalan Bujtas <zalan@apple.com> WeakPtrFactory should populate m_ref lazily. https://bugs.webkit.org/show_bug.cgi?id=177375 Reviewed by Geoffrey Garen. * pal/system/mac/SystemSleepListenerMac.mm: (PAL::SystemSleepListenerMac::SystemSleepListenerMac): 2017-09-21 Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> [PAL] Move MediaTimeAVFoundation into PAL https://bugs.webkit.org/show_bug.cgi?id=177222 Reviewed by Myles C. Maxfield. * config.h: Include PALHeaderDetection.h. Define AVFOUNDATION-releavant definitions. * pal/PlatformWin.cmake: Add PAL dereived sources directory to include paths. * PAL.xcodeproj/project.pbxproj: * pal/CMakeLists.txt: * pal/PlatformAppleWin.cmake: * pal/avfoundation/MediaTimeAVFoundation.cpp: Renamed from Source/WebCore/platform/graphics/avfoundation/MediaTimeAVFoundation.cpp. * pal/avfoundation/MediaTimeAVFoundation.h: Renamed from Source/WebCore/platform/graphics/avfoundation/MediaTimeAVFoundation.h. * pal/cf/CoreMediaSoftLink.cpp: Added. * pal/cf/CoreMediaSoftLink.h: Added. 2017-09-20 Antti Koivisto <antti@apple.com> Remove DOM and styling support for CSS Regions https://bugs.webkit.org/show_bug.cgi?id=177221 Reviewed by Andreas Kling. * Configurations/FeatureDefines.xcconfig: 2017-09-18 Andy Estes <aestes@apple.com> [Mac] Upstream miscellaneous WebKitSystemInterface functions https://bugs.webkit.org/show_bug.cgi?id=177029 Reviewed by Alex Christensen. * PAL.xcodeproj/project.pbxproj: * pal/PlatformMac.cmake: * pal/spi/cf/CFUtilitiesSPI.h: * pal/spi/cocoa/LaunchServicesSPI.h: Renamed from Source/WebCore/PAL/pal/spi/ios/LaunchServicesSPI.h. * pal/spi/mac/HIServicesSPI.h: * pal/spi/mac/NSCellSPI.h: Copied from Source/WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h. * pal/spi/mac/NSMenuSPI.h: * pal/spi/mac/NSScrollViewSPI.h: Copied from Source/WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h. * pal/spi/mac/NSScrollerImpSPI.h: * pal/system/cf/DefaultSearchProvider.cpp: Copied from Source/WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h. (PAL::defaultSearchProviderDisplayName): * pal/system/cf/DefaultSearchProvider.h: Copied from Source/WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h. * pal/system/mac/PopupMenu.h: Copied from Source/WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h. * pal/system/mac/PopupMenu.mm: Added. (PAL::popUpMenu): 2017-09-18 Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> [Win][PAL] Move WebCoreHeaderDetection.h to PAL https://bugs.webkit.org/show_bug.cgi?id=176990 Reviewed by Alex Christensen. * AVFoundationSupport.py: Renamed from Source/WebCore/AVFoundationSupport.py. (lookFor): (fileContains): * pal/PlatformWin.cmake: Add a custom target PAL_PreBuild to generate PALHeaderDetection.h 2017-09-15 Tim Horton <timothy_horton@apple.com> Fix the macOS CMake build https://bugs.webkit.org/show_bug.cgi?id=177015 Reviewed by Andy Estes. * pal/PlatformMac.cmake: Add WebPanel. 2017-09-15 Andy Estes <aestes@apple.com> [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions https://bugs.webkit.org/show_bug.cgi?id=176953 Reviewed by Eric Carlson. * pal/spi/mac/AVFoundationSPI.h: * pal/spi/mac/MediaRemoteSPI.h: 2017-09-15 Eric Carlson <eric.carlson@apple.com> Switch text tracks to release logging https://bugs.webkit.org/show_bug.cgi?id=176809 <rdar://problem/34397605> Reviewed by Jer Noble. * pal/Logger.h: (PAL::LogArgument::toString): (PAL::Logger::willLog const): 2017-09-14 Dan Bernstein <mitz@apple.com> Fixed building with the Apple internal macOS 10.12 SDK. * pal/spi/cocoa/PassKitSPI.h: Avoid redefining types that are defined in the SDK. 2017-09-14 Andy Estes <aestes@apple.com> [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions https://bugs.webkit.org/show_bug.cgi?id=176931 Reviewed by Joseph Pecoraro. * PAL.xcodeproj/project.pbxproj: * pal/spi/mac/SpeechSynthesisSPI.h: Added. 2017-09-13 Andy Estes <aestes@apple.com> [CF] Upstream CFNetwork-related WebKitSystemInterface functions https://bugs.webkit.org/show_bug.cgi?id=176729 Reviewed by Alex Christensen. * pal/spi/cf/CFNetworkSPI.h: 2017-09-12 Myles C. Maxfield <mmaxfield@apple.com> Unskip fast/text/system-font-synthetic-italic.html https://bugs.webkit.org/show_bug.cgi?id=175944 Reviewed by Jon Lee. * pal/spi/cocoa/CoreTextSPI.h: 2017-09-12 Eric Carlson <eric.carlson@apple.com> Switch MediaPlayerPrivateAVFoundation to release logging https://bugs.webkit.org/show_bug.cgi?id=176621 <rdar://problem/34335311> Reviewed by Jer Noble. * pal/Logger.h: (PAL::LogArgument::toString): * pal/LoggerHelper.h: 2017-09-11 Andy Estes <aestes@apple.com> [Mac] Upstream QTKit-related WebKitSystemInterface functions https://bugs.webkit.org/show_bug.cgi?id=176472 Reviewed by Eric Carlson. * pal/spi/mac/QTKitSPI.h: 2017-09-08 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r221773. https://bugs.webkit.org/show_bug.cgi?id=176614 This caused build failures. (Requested by mlewis13 on #webkit). Reverted changeset: "[Mac] Upstream QTKit-related WebKitSystemInterface functions" https://bugs.webkit.org/show_bug.cgi?id=176472 http://trac.webkit.org/changeset/221773 2017-09-07 Andy Estes <aestes@apple.com> [Mac] Upstream QTKit-related WebKitSystemInterface functions https://bugs.webkit.org/show_bug.cgi?id=176472 Reviewed by Eric Carlson. * pal/spi/mac/QTKitSPI.h: 2017-09-07 Wenson Hsieh <wenson_hsieh@apple.com> [Mac] Stop importing NSFunctionBar_Private.h in NSTouchBarSPI.h on the macOS 10.13+ SDK https://bugs.webkit.org/show_bug.cgi?id=176521 <rdar://problem/34296289> Reviewed by Andy Estes. We don't need to import NSFunctionBar_Private.h when building against the macOS 10.13 SDK, or later. Guard this header import with an SDK version check. * pal/spi/cocoa/NSTouchBarSPI.h: 2017-09-06 Eric Carlson <eric.carlson@apple.com> Require LoggingHelper overrides to provide identifier https://bugs.webkit.org/show_bug.cgi?id=176477 Reviewed by Jer Noble. * pal/Logger.h: (PAL::Logger::LogSiteIdentifier::LogSiteIdentifier): (PAL::LogArgument<Logger::LogSiteIdentifier>::toString): (PAL::Logger::notice const): Deleted. (PAL::Logger::MethodAndPointer::MethodAndPointer): Deleted. (PAL::LogArgument<Logger::MethodAndPointer>::toString): Deleted. * pal/LoggerHelper.h: 2017-09-04 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r221494 and r221500. https://bugs.webkit.org/show_bug.cgi?id=176258 This caused the windows build to fail. (Requested by mlewis13 on #webkit). Reverted changesets: "Switch HTMLMediaElement to release logging" https://bugs.webkit.org/show_bug.cgi?id=176065 http://trac.webkit.org/changeset/221494 "Switch HTMLMediaElement to release logging" https://bugs.webkit.org/show_bug.cgi?id=176065 http://trac.webkit.org/changeset/221500 2017-09-03 Zan Dobersek <zdobersek@igalia.com> [GTK] Libgcrypt warning: missing initialization - please fix the application https://bugs.webkit.org/show_bug.cgi?id=171230 Reviewed by Michael Catanzaro. Add the Initialization.h header, containing the single initialize() static function that initializes the libgcrypt library. This header only includes the default libgcrypt header, and nothing else. It's not added to the existing Utilities.h header because that one pulls in other unnecessary headers that for instance use the new() operator, but that collides with the implementation files that define WebKit process entrypoints and intentionally don't include the config.h that brings in FastMalloc to properly define the new() and delete() operators, resulting in compilation errors due to the new and delete operators being defined to warning strings in always-included WebKit2Prefix.h. * pal/crypto/gcrypt/Initialization.h: Copied from Source/WebKit/WebProcess/EntryPoint/unix/WebProcessMain.cpp. (PAL::GCrypt::initialize): 2017-09-03 Dan Bernstein <mitz@apple.com> [Cocoa] Tidy up PassKitSPI.h https://bugs.webkit.org/show_bug.cgi?id=176323 Reviewed by Darin Adler. * pal/spi/cocoa/PassKitSPI.h: Moved the declarations of requiredShippingContactFields and requiredBillingContactFields to where other PKPaymentRequest properties are declared, and changed the guard to relate to the SDK version. Replaced use of __has_include with checking for the version of the Apple internal SDK in which the typedefs first appeared. 2017-09-03 Dan Bernstein <mitz@apple.com> [Cocoa] Remove use of __has_include in CoreAudioSPI.h https://bugs.webkit.org/show_bug.cgi?id=176320 Reviewed by Tim Horton. * pal/spi/cf/CoreAudioSPI.h: AudioHardwarePriv.h is available in all Apple internal SDKs and only in Apple internal SDKs. AudioHardwareBase.h is available only in the macOS SDK, where it is included by AudioHardware.h. 2017-09-03 Tim Horton <timothy_horton@apple.com> Fix some style issues in the Remote Layer Tree code https://bugs.webkit.org/show_bug.cgi?id=176298 Reviewed by Dan Bernstein. * pal/spi/cocoa/QuartzCoreSPI.h: 2017-09-03 Sam Weinig <sam@webkit.org> Remove CanvasProxy https://bugs.webkit.org/show_bug.cgi?id=176288 Reviewed by Yusuke Suzuki. CanvasProxy does not appear to be in any current HTML spec and was disabled and unimplemented in our tree. Time to get rid of it. * Configurations/FeatureDefines.xcconfig: 2017-09-02 Andy Estes <aestes@apple.com> [CA] Upstream QuartzCore-related WebKitSystemInterface functions https://bugs.webkit.org/show_bug.cgi?id=176270 Reviewed by Tim Horton. * pal/spi/cocoa/QuartzCoreSPI.h: 2017-09-01 Andy Estes <aestes@apple.com> Try again to fix the Internal iOS Simulator build after r221485. * pal/spi/cg/CoreGraphicsSPI.h: 2017-09-01 Andy Estes <aestes@apple.com> Try to fix the Internal iOS Simulator build after r221485. * pal/spi/cg/CoreGraphicsSPI.h: 2017-09-01 Andy Estes <aestes@apple.com> [CG] Upstream CoreGraphics-related WebKitSystemInterface functions https://bugs.webkit.org/show_bug.cgi?id=176200 Reviewed by Tim Horton. * PAL.xcodeproj/project.pbxproj: * pal/spi/cg/CoreGraphicsSPI.h: * pal/spi/mac/HIServicesSPI.h: * pal/spi/mac/NSGraphicsSPI.h: Copied from Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h. 2017-08-31 Andy Estes <aestes@apple.com> [Mac] Upstream AppKit-related WebKitSystemInterface functions https://bugs.webkit.org/show_bug.cgi?id=176175 Reviewed by Brady Eidson. * PAL.xcodeproj/project.pbxproj: * pal/spi/mac/HIToolboxSPI.h: * pal/spi/mac/NSResponderSPI.h: Copied from Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h. * pal/spi/mac/NSWindowSPI.h: * pal/system/mac/WebPanel.h: Copied from Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h. * pal/system/mac/WebPanel.mm: Copied from Source/WebCore/PAL/pal/spi/mac/HIToolboxSPI.h. (-[WebPanel init]): 2017-08-31 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, rolling out r221445. This change broke Sierra Release builds. Reverted changeset: "Switch HTMLMediaElement to release logging" https://bugs.webkit.org/show_bug.cgi?id=176065 http://trac.webkit.org/changeset/221445 2017-08-30 Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> [PAL] Fix "None" suffix in PAL https://bugs.webkit.org/show_bug.cgi?id=176014 Reviewed by Ryosuke Niwa. * Configurations/PAL.xcconfig: * PAL.xcodeproj/project.pbxproj: * pal/PlatformGTK.cmake: * pal/PlatformWPE.cmake: * pal/PlatformWin.cmake: * pal/system/Sound.cpp: Renamed from Source/WebCore/PAL/pal/system/SoundNone.cpp. * pal/text/KillRing.cpp: Renamed from Source/WebCore/PAL/pal/text/KillRingNone.cpp. 2017-08-30 Eric Carlson <eric.carlson@apple.com> Add Logger observer and helper class https://bugs.webkit.org/show_bug.cgi?id=176106 Reviewed by Andy Estes. * pal/Logger.h: (PAL::LogArgument::toString): Add new variants. (PAL::Logger::Observer::~Observer): (PAL::Logger::logAlways const): Constify. (PAL::Logger::error const): Ditto. (PAL::Logger::warning const): Ditto. (PAL::Logger::notice const): Ditto. (PAL::Logger::info const): Ditto. (PAL::Logger::debug const): Ditto. (PAL::Logger::willLog const): Ditto. (PAL::Logger::MethodAndPointer::MethodAndPointer): Add class name, make object pointer const. (PAL::Logger::addObserver): New. (PAL::Logger::removeObserver): New. (PAL::Logger::Logger): (PAL::Logger::log): (PAL::Logger::observers): (PAL::LogHelper::willLog const): (PAL::LogArgument<Logger::MethodAndPointer>::toString): 2017-08-30 Andy Estes <aestes@apple.com> [Mac] Upstream Accessibility-related WebKitSystemInterface functions https://bugs.webkit.org/show_bug.cgi?id=176093 Reviewed by Eric Carlson. * PAL.xcodeproj/project.pbxproj: * pal/spi/mac/HIServicesSPI.h: Added. * pal/spi/mac/NSAccessibilitySPI.h: 2017-08-30 Andy Estes <aestes@apple.com> [Mac] Upstream Carbon-related WebKitSystemInterface functions https://bugs.webkit.org/show_bug.cgi?id=176087 Reviewed by Alex Christensen. * PAL.xcodeproj/project.pbxproj: * pal/spi/cocoa/FoundationSPI.h: Copied from Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h. * pal/spi/mac/HIToolboxSPI.h: Copied from Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h. * pal/spi/mac/NSEventSPI.h: * pal/spi/mac/NSWindowSPI.h: * pal/spi/mac/QuickDrawSPI.h: Added. 2017-08-29 Andy Estes <aestes@apple.com> [Xcode] Fix up file and group paths in PAL.xcodeproj https://bugs.webkit.org/show_bug.cgi?id=176073 Reviewed by Alex Christensen. * PAL.xcodeproj/project.pbxproj: 2017-08-29 Andy Estes <aestes@apple.com> [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface https://bugs.webkit.org/show_bug.cgi?id=176046 Reviewed by Alex Christensen. * PAL.xcodeproj/project.pbxproj: * pal/spi/mac/MetadataSPI.h: Added. 2017-08-28 Eric Carlson <eric.carlson@apple.com> Logger should use makeString instead of String::format https://bugs.webkit.org/show_bug.cgi?id=176035 Reviewed by Jer Noble. * pal/Logger.h: (PAL::LogArgument::toString): (PAL::Logger::logAlways): (PAL::Logger::error): (PAL::Logger::warning): (PAL::Logger::notice): (PAL::Logger::info): (PAL::Logger::debug): (PAL::Logger::MethodAndPointer::MethodAndPointer): (PAL::Logger::log): (PAL::LogArgument<Logger::MethodAndPointer>::toString): 2017-08-28 Andy Estes <aestes@apple.com> [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions https://bugs.webkit.org/show_bug.cgi?id=176032 Reviewed by Alex Christensen. * pal/spi/cf/CFNetworkSPI.h: 2017-08-25 Eric Carlson <eric.carlson@apple.com> Add Logger::logAlways https://bugs.webkit.org/show_bug.cgi?id=175996 Reviewed by Jer Noble. * PAL.xcodeproj/project.pbxproj: * pal/Logger.h: (PAL::Logger::willLog const): (PAL::Logger::willLog const): (PAL::Logger::logAlways): Added. (PAL::Logger::error const): Add missing WTF_ATTRIBUTE_PRINTF. (PAL::Logger::warning const): Ditto. (PAL::Logger::notice const): Ditto. (PAL::Logger::info const): Ditto. (PAL::Logger::debug const): Use String::formatWithArguments. 2017-08-25 Jonathan Bedard <jbedard@apple.com> Fix build breakage with Public iOS 11 SDK https://bugs.webkit.org/show_bug.cgi?id=175960 <rdar://problem/34069264> Reviewed by Wenson Hsieh. * pal/spi/ios/UIKitSPI.h: Use NSItemProvider definition of preferredPresentationSize instead of re-declaring it. 2017-08-23 Eric Carlson <eric.carlson@apple.com> Platform code should be able to safely log in release builds https://bugs.webkit.org/show_bug.cgi?id=175854 <rdar://problem/34022930> Reviewed by Jer Noble. * PAL.xcodeproj/project.pbxproj: * pal/Logger.h: Added. (PAL::Logger::create): (PAL::Logger::error const): (PAL::Logger::warning const): (PAL::Logger::notice const): (PAL::Logger::info const): (PAL::Logger::debug const): (PAL::Logger::willLog const): (PAL::Logger::enabled const): (PAL::Logger::setEnabled): (PAL::Logger::Logger): (PAL::Logger::log): 2017-08-21 Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> [PAL] Move spi/mac directory into PAL https://bugs.webkit.org/show_bug.cgi?id=175649 Reviewed by Myles C. Maxfield. * PAL.xcodeproj/project.pbxproj: * pal/spi/mac/AVFoundationSPI.h: Renamed from Source/WebCore/platform/spi/mac/AVFoundationSPI.h. * pal/spi/mac/DataDetectorsSPI.h: Renamed from Source/WebCore/platform/spi/mac/DataDetectorsSPI.h. * pal/spi/mac/LookupSPI.h: Renamed from Source/WebCore/platform/spi/mac/LookupSPI.h. * pal/spi/mac/MediaRemoteSPI.h: Renamed from Source/WebCore/platform/spi/mac/MediaRemoteSPI.h. * pal/spi/mac/NSAccessibilitySPI.h: Renamed from Source/WebCore/platform/spi/mac/NSAccessibilitySPI.h. * pal/spi/mac/NSApplicationSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSApplicationSPI.h. * pal/spi/mac/NSEventSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSEventSPI.h. * pal/spi/mac/NSFontSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSFontSPI.h. * pal/spi/mac/NSImmediateActionGestureRecognizerSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h. * pal/spi/mac/NSMenuSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSMenuSPI.h. * pal/spi/mac/NSPasteboardSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSPasteboardSPI.h. * pal/spi/mac/NSPopoverSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSPopoverSPI.h. * pal/spi/mac/NSScrollerImpSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSScrollerImpSPI.h. * pal/spi/mac/NSScrollingInputFilterSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSScrollingInputFilterSPI.h. * pal/spi/mac/NSScrollingMomentumCalculatorSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSScrollingMomentumCalculatorSPI.h. * pal/spi/mac/NSSharingServicePickerSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSSharingServicePickerSPI.h. * pal/spi/mac/NSSharingServiceSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSSharingServiceSPI.h. * pal/spi/mac/NSSpellCheckerSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSSpellCheckerSPI.h. * pal/spi/mac/NSTextFinderSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSTextFinderSPI.h. * pal/spi/mac/NSViewSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSViewSPI.h. * pal/spi/mac/NSWindowSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSWindowSPI.h. * pal/spi/mac/PIPSPI.h: Renamed from Source/WebCore/platform/spi/mac/PIPSPI.h. * pal/spi/mac/QTKitSPI.h: Renamed from Source/WebCore/platform/spi/mac/QTKitSPI.h. * pal/spi/mac/QuickLookMacSPI.h: Renamed from Source/WebCore/platform/spi/mac/QuickLookMacSPI.h. * pal/spi/mac/TUCallSPI.h: Renamed from Source/WebCore/platform/spi/mac/TUCallSPI.h. 2017-08-17 Don Olmstead <don.olmstead@sony.com> [PAL] Relocate SessionID to root https://bugs.webkit.org/show_bug.cgi?id=175684 Reviewed by Alex Christensen. * PAL.xcodeproj/project.pbxproj: * pal/CMakeLists.txt: * pal/SessionID.cpp: Renamed from Source/WebCore/PAL/pal/identifier/SessionID.cpp. * pal/SessionID.h: Renamed from Source/WebCore/PAL/pal/identifier/SessionID.h. 2017-08-17 Andreas Kling <akling@apple.com> Disable CSS regions at compile time https://bugs.webkit.org/show_bug.cgi?id=175630 Reviewed by Antti Koivisto. * Configurations/FeatureDefines.xcconfig: 2017-08-17 Wenson Hsieh <wenson_hsieh@apple.com> [iOS] Respect type fidelities when copying image elements to the pasteboard https://bugs.webkit.org/show_bug.cgi?id=175638 <rdar://problem/26556043> Reviewed by Ryosuke Niwa. Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize. * pal/spi/ios/UIKitSPI.h: 2017-08-17 Don Olmstead <don.olmstead@sony.com> [PAL] Move SessionID into PAL https://bugs.webkit.org/show_bug.cgi?id=174192 Reviewed by Antti Koivisto. * PAL.xcodeproj/project.pbxproj: * pal/CMakeLists.txt: * pal/identifier/SessionID.cpp: Renamed from Source/WebCore/page/SessionID.cpp. * pal/identifier/SessionID.h: Renamed from Source/WebCore/page/SessionID.h. (WTF::SessionIDHash::hash): (WTF::SessionIDHash::equal): (WTF::HashTraits<PAL::SessionID>::emptyValue): (WTF::HashTraits<PAL::SessionID>::constructDeletedValue): (WTF::HashTraits<PAL::SessionID>::isDeletedValue): 2017-08-16 Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> [PAL] Move spi/ios and spi/win directories into PAL https://bugs.webkit.org/show_bug.cgi?id=175171 Reviewed by Antti Koivisto. * PAL.xcodeproj/project.pbxproj: * pal/spi/ios/CoreUISPI.h: Renamed from Source/WebCore/platform/spi/ios/CoreUISPI.h. * pal/spi/ios/DataDetectorsUISPI.h: Renamed from Source/WebCore/platform/spi/ios/DataDetectorsUISPI.h. * pal/spi/ios/GraphicsServicesSPI.h: Renamed from Source/WebCore/platform/spi/ios/GraphicsServicesSPI.h. * pal/spi/ios/LaunchServicesSPI.h: Renamed from Source/WebCore/platform/spi/ios/LaunchServicesSPI.h. * pal/spi/ios/MediaPlayerSPI.h: Renamed from Source/WebCore/platform/spi/ios/MediaPlayerSPI.h. * pal/spi/ios/MobileGestaltSPI.h: Renamed from Source/WebCore/platform/spi/ios/MobileGestaltSPI.h. * pal/spi/ios/OpenGLESSPI.h: Renamed from Source/WebCore/platform/spi/ios/OpenGLESSPI.h. * pal/spi/ios/QuickLookSPI.h: Renamed from Source/WebCore/platform/spi/ios/QuickLookSPI.h. * pal/spi/ios/SQLite3SPI.h: Renamed from Source/WebCore/platform/spi/ios/SQLite3SPI.h. * pal/spi/ios/UIKitSPI.h: Renamed from Source/WebCore/platform/spi/ios/UIKitSPI.h. * pal/spi/win/CoreTextSPIWin.h: Renamed from Source/WebCore/platform/spi/win/CoreTextSPIWin.h. 2017-08-16 Andy Estes <aestes@apple.com> [Payment Request] Add an ENABLE flag and an experimental feature preference https://bugs.webkit.org/show_bug.cgi?id=175622 Reviewed by Tim Horton. * Configurations/FeatureDefines.xcconfig: 2017-08-15 Don Olmstead <don.olmstead@sony.com> [PAL] Move Sleep classes into PAL https://bugs.webkit.org/show_bug.cgi?id=175456 Reviewed by Ryosuke Niwa. * PAL.xcodeproj/project.pbxproj: * pal/CMakeLists.txt: * pal/PlatformMac.cmake: * pal/system/SleepDisabler.cpp: Renamed from Source/WebCore/platform/SleepDisabler.cpp. * pal/system/SleepDisabler.h: Renamed from Source/WebCore/platform/SleepDisabler.h. * pal/system/SystemSleepListener.cpp: Renamed from Source/WebCore/platform/SystemSleepListener.cpp. * pal/system/SystemSleepListener.h: Renamed from Source/WebCore/platform/SystemSleepListener.h. * pal/system/cocoa/SleepDisablerCocoa.cpp: Renamed from Source/WebCore/platform/cocoa/SleepDisablerCocoa.cpp. * pal/system/cocoa/SleepDisablerCocoa.h: Renamed from Source/WebCore/platform/cocoa/SleepDisablerCocoa.h. * pal/system/mac/SystemSleepListenerMac.h: Renamed from Source/WebCore/platform/mac/SystemSleepListenerMac.h. * pal/system/mac/SystemSleepListenerMac.mm: Renamed from Source/WebCore/platform/mac/SystemSleepListenerMac.mm. 2017-08-14 Simon Fraser <simon.fraser@apple.com> Remove Proximity Events and related code https://bugs.webkit.org/show_bug.cgi?id=175545 Reviewed by Daniel Bates. No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS) and other related code. * Configurations/FeatureDefines.xcconfig: 2017-08-14 Simon Fraser <simon.fraser@apple.com> Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere https://bugs.webkit.org/show_bug.cgi?id=175504 Reviewed by Sam Weinig. * Configurations/FeatureDefines.xcconfig: 2017-08-14 Simon Fraser <simon.fraser@apple.com> Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code https://bugs.webkit.org/show_bug.cgi?id=175557 Reviewed by Jon Lee. No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it. * Configurations/FeatureDefines.xcconfig: 2017-08-11 Ryosuke Niwa <rniwa@webkit.org> Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation https://bugs.webkit.org/show_bug.cgi?id=175474 <rdar://problem/33844628> Reviewed by Wenson Hsieh. * Configurations/FeatureDefines.xcconfig: 2017-08-10 Michael Catanzaro <mcatanzaro@igalia.com> Remove ENABLE_GAMEPAD_DEPRECATED https://bugs.webkit.org/show_bug.cgi?id=175361 Reviewed by Carlos Garcia Campos. * Configurations/FeatureDefines.xcconfig: 2017-08-09 Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> [PAL] Move spi/cocoa and spi/cg directories into PAL https://bugs.webkit.org/show_bug.cgi?id=175175 Reviewed by Myles C. Maxfield. * PAL.xcodeproj/project.pbxproj: * pal/PlatformAppleWin.cmake: * pal/spi/cg/CoreGraphicsSPI.h: Renamed from Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h. (CGFloatMin): * pal/spi/cg/ImageIOSPI.h: Renamed from Source/WebCore/platform/spi/cg/ImageIOSPI.h. * pal/spi/cocoa/AVKitSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/AVKitSPI.h. (-[AVTouchBarPlaybackControlsControlling NS_ENUM]): * pal/spi/cocoa/CFNSURLConnectionSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/CFNSURLConnectionSPI.h. * pal/spi/cocoa/CoreTextSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/CoreTextSPI.h. * pal/spi/cocoa/DataDetectorsCoreSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/DataDetectorsCoreSPI.h. * pal/spi/cocoa/IOPMLibSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOPMLibSPI.h. * pal/spi/cocoa/IOPSLibSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOPSLibSPI.h. * pal/spi/cocoa/IOReturnSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOReturnSPI.h. * pal/spi/cocoa/IOSurfaceSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOSurfaceSPI.h. * pal/spi/cocoa/IOTypesSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOTypesSPI.h. * pal/spi/cocoa/LinkPresentationSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/LinkPresentationSPI.h. * pal/spi/cocoa/MachVMSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/MachVMSPI.h. * pal/spi/cocoa/NEFilterSourceSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NEFilterSourceSPI.h. * pal/spi/cocoa/NSAttributedStringSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSAttributedStringSPI.h. * pal/spi/cocoa/NSButtonCellSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSButtonCellSPI.h. * pal/spi/cocoa/NSCalendarDateSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSCalendarDateSPI.h. * pal/spi/cocoa/NSColorSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSColorSPI.h. * pal/spi/cocoa/NSExtensionSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSExtensionSPI.h. * pal/spi/cocoa/NSFileManagerSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSFileManagerSPI.h. * pal/spi/cocoa/NSStringSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSStringSPI.h. * pal/spi/cocoa/NSTouchBarSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSTouchBarSPI.h. * pal/spi/cocoa/NSURLConnectionSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSURLConnectionSPI.h. * pal/spi/cocoa/NSURLDownloadSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSURLDownloadSPI.h. * pal/spi/cocoa/NSURLFileTypeMappingsSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSURLFileTypeMappingsSPI.h. * pal/spi/cocoa/PassKitSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/PassKitSPI.h. (NS_ERROR_ENUM): * pal/spi/cocoa/QuartzCoreSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h. * pal/spi/cocoa/ServersSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/ServersSPI.h. * pal/spi/cocoa/WebFilterEvaluatorSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/WebFilterEvaluatorSPI.h. * pal/spi/cocoa/pthreadSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/pthreadSPI.h. 2017-08-09 Wenson Hsieh <wenson_hsieh@apple.com> [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default https://bugs.webkit.org/show_bug.cgi?id=175392 <rdar://problem/33783207> Reviewed by Tim Horton and Megan Gardner. Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10). * Configurations/FeatureDefines.xcconfig: 2017-08-07 Brian Burg <bburg@apple.com> Remove CANVAS_PATH compilation guard https://bugs.webkit.org/show_bug.cgi?id=175207 Reviewed by Sam Weinig. * Configurations/FeatureDefines.xcconfig: 2017-08-04 Matt Lewis <jlewis3@apple.com> Unreviewed, rolling out r220271. Rolling out due to Layout Test failing on iOS Simulator. Reverted changeset: "Remove STREAMS_API compilation guard" https://bugs.webkit.org/show_bug.cgi?id=175165 http://trac.webkit.org/changeset/220271 2017-08-04 Youenn Fablet <youenn@apple.com> Remove STREAMS_API compilation guard https://bugs.webkit.org/show_bug.cgi?id=175165 Reviewed by Darin Adler. * Configurations/FeatureDefines.xcconfig: 2017-08-03 Brian Burg <bburg@apple.com> Remove ENABLE(WEB_SOCKET) guards https://bugs.webkit.org/show_bug.cgi?id=167044 Reviewed by Joseph Pecoraro. * Configurations/FeatureDefines.xcconfig: 2017-08-03 Yoshiaki Jitsukawa <jitsu@rd.scei.sony.co.jp> [PAL] Move spi/cf directory into PAL https://bugs.webkit.org/show_bug.cgi?id=175057 Reviewed by Antti Koivisto. * PAL.xcodeproj/project.pbxproj: * pal/spi/cf/CFLocaleSPI.h: Renamed from Source/WebCore/platform/spi/cf/CFLocaleSPI.h. * pal/spi/cf/CFNetworkConnectionCacheSPI.h: Renamed from Source/WebCore/platform/spi/cf/CFNetworkConnectionCacheSPI.h. * pal/spi/cf/CFNetworkSPI.h: Renamed from Source/WebCore/platform/spi/cf/CFNetworkSPI.h. * pal/spi/cf/CFUtilitiesSPI.h: Renamed from Source/WebCore/platform/spi/cf/CFUtilitiesSPI.h. * pal/spi/cf/CoreAudioSPI.h: Renamed from Source/WebCore/platform/spi/cf/CoreAudioSPI.h. * pal/spi/cf/CoreMediaSPI.h: Renamed from Source/WebCore/platform/spi/cf/CoreMediaSPI.h. 2017-08-03 Youenn Fablet <youenn@apple.com> Remove FETCH_API compilation guard https://bugs.webkit.org/show_bug.cgi?id=175154 Reviewed by Chris Dumez. * Configurations/FeatureDefines.xcconfig: 2017-08-03 Brady Eidson <beidson@apple.com> Add SW IDLs and stub out basic functionality. https://bugs.webkit.org/show_bug.cgi?id=175115 Reviewed by Chris Dumez. * Configurations/FeatureDefines.xcconfig: 2017-08-03 Yoshiaki Jitsukawa <jitsu@rd.scei.sony.co.jp> [WebCore] Sort Xcode project files https://bugs.webkit.org/show_bug.cgi?id=175121 Reviewed by Antti Koivisto. * PAL.xcodeproj/project.pbxproj: 2017-08-01 Yoshiaki Jitsukawa <jitsu@rd.scei.sony.co.jp> [PAL][Win] Copy forwarding headers https://bugs.webkit.org/show_bug.cgi?id=175012 Reviewed by Myles C. Maxfield. * pal/PlatformAppleWin.cmake: Added. * pal/PlatformWin.cmake: * pal/PlatformWinCairo.cmake: Added. 2017-07-26 Brian Burg <bburg@apple.com> Remove WEB_TIMING feature flag https://bugs.webkit.org/show_bug.cgi?id=174795 Reviewed by Alex Christensen. * Configurations/FeatureDefines.xcconfig: 2017-07-24 Carlos Alberto Lopez Perez <clopez@igalia.com> [CMake] libtasn1 should not be required when not enabling subtle_crypto https://bugs.webkit.org/show_bug.cgi?id=174785 Reviewed by Žan Doberšek. * pal/PlatformGTK.cmake: * pal/PlatformWPE.cmake: 2017-07-18 Andy Estes <aestes@apple.com> [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS https://bugs.webkit.org/show_bug.cgi?id=174631 Reviewed by Tim Horton. * Configurations/Base.xcconfig: 2017-07-18 Andy Estes <aestes@apple.com> [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION https://bugs.webkit.org/show_bug.cgi?id=174631 Reviewed by Sam Weinig. * Configurations/Base.xcconfig: 2017-07-18 Andy Estes <aestes@apple.com> [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION https://bugs.webkit.org/show_bug.cgi?id=174631 Reviewed by Dan Bernstein. * Configurations/Base.xcconfig: 2017-07-18 Andy Estes <aestes@apple.com> [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING https://bugs.webkit.org/show_bug.cgi?id=174631 Reviewed by Darin Adler. * Configurations/Base.xcconfig: 2017-07-17 Konstantin Tokarev <annulen@yandex.ru> [CMake] Create targets before WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS is called https://bugs.webkit.org/show_bug.cgi?id=174557 Reviewed by Michael Catanzaro. No new tests needed. * pal/CMakeLists.txt: 2017-07-13 Per Arne Vollan <pvollan@apple.com> [Win] Build error when building WebCore from WebCore.proj project file. https://bugs.webkit.org/show_bug.cgi?id=174462 Reviewed by Brent Fulgham. Add required include directory to list of include directories. * pal/CMakeLists.txt: * pal/PlatformWin.cmake: 2017-07-12 Matt Lewis <jlewis3@apple.com> Unreviewed, rolling out r219401. This revision rolled out the previous patch, but after talking with reviewer, a rebaseline is what was needed.Rolling back in before rebaseline. Reverted changeset: "Unreviewed, rolling out r219379." https://bugs.webkit.org/show_bug.cgi?id=174400 http://trac.webkit.org/changeset/219401 2017-07-12 Matt Lewis <jlewis3@apple.com> Unreviewed, rolling out r219379. This revision caused a consistent failure in the test fast/dom/Window/property-access-on-cached-window-after-frame- removed.html. Reverted changeset: "Remove NAVIGATOR_HWCONCURRENCY" https://bugs.webkit.org/show_bug.cgi?id=174400 http://trac.webkit.org/changeset/219379 2017-07-11 Per Arne Vollan <pvollan@apple.com> [Win] Build error when building WebKit.dll from WebKit.proj project file. https://bugs.webkit.org/show_bug.cgi?id=174410 Reviewed by Brent Fulgham. Copy required header files to forwarding headers folder. * pal/PlatformWin.cmake: 2017-07-11 Dean Jackson <dino@apple.com> Remove NAVIGATOR_HWCONCURRENCY https://bugs.webkit.org/show_bug.cgi?id=174400 Reviewed by Sam Weinig. * Configurations/FeatureDefines.xcconfig: 2017-07-11 Dean Jackson <dino@apple.com> Rolling out r219372. * Configurations/FeatureDefines.xcconfig: 2017-07-11 Dean Jackson <dino@apple.com> Remove NAVIGATOR_HWCONCURRENCY https://bugs.webkit.org/show_bug.cgi?id=174400 Reviewed by Sam Weinig. * Configurations/FeatureDefines.xcconfig: 2017-07-11 Per Arne Vollan <pvollan@apple.com> [Win] Build error when building WebCore from WebCore.proj project file. https://bugs.webkit.org/show_bug.cgi?id=174330 Reviewed by Brent Fulgham. CMAKE_BINARY_DIR is needed in the include list in order to find 'cmakeconfig.h'. * pal/CMakeLists.txt: 2017-07-03 Brian Burg <bburg@apple.com> Web Replay: remove some unused code https://bugs.webkit.org/show_bug.cgi?id=173903 Rubber-stamped by Joseph Pecoraro. * Configurations/FeatureDefines.xcconfig: 2017-07-08 Yusuke Suzuki <utatane.tea@gmail.com> Drop NOSNIFF compile flag https://bugs.webkit.org/show_bug.cgi?id=174289 Reviewed by Michael Catanzaro. * Configurations/FeatureDefines.xcconfig: 2017-07-06 Don Olmstead <don.olmstead@sony.com> [PAL] Move KillRing into PAL https://bugs.webkit.org/show_bug.cgi?id=173900 Reviewed by Myles C. Maxfield. No new tests. No change in functionality. * Configurations/PAL.xcconfig: * PAL.xcodeproj/project.pbxproj: * pal/CMakeLists.txt: * pal/PlatformGTK.cmake: * pal/PlatformMac.cmake: * pal/PlatformWPE.cmake: * pal/PlatformWin.cmake: * pal/text/KillRing.h: Renamed from Source/WebCore/platform/KillRing.h. * pal/text/KillRingNone.cpp: Renamed from Source/WebCore/platform/KillRingNone.cpp. * pal/text/mac/KillRingMac.mm: Renamed from Source/WebCore/platform/mac/KillRingMac.mm. 2017-07-05 Jonathan Bedard <jbedard@apple.com> Add WebKitPrivateFrameworkStubs for iOS 11 https://bugs.webkit.org/show_bug.cgi?id=173988 Reviewed by David Kilzer. * Configurations/PAL.xcconfig: iphoneos and iphonesimulator should use the same directory for private framework stubs. 2017-07-03 Sam Weinig <sam@webkit.org> [WebIDL] Remove more unnecessary uses of the preprocessor in idl files https://bugs.webkit.org/show_bug.cgi?id=174083 Reviewed by Alex Christensen. * Configurations/FeatureDefines.xcconfig: Add ENABLE_NAVIGATOR_STANDALONE. 2017-07-03 Andy Estes <aestes@apple.com> [Xcode] Add an experimental setting to build with ccache https://bugs.webkit.org/show_bug.cgi?id=173875 Reviewed by Tim Horton. * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig. 2017-07-03 Zan Dobersek <zdobersek@igalia.com> [GCrypt] Implement CryptoKeyEC SPKI exports https://bugs.webkit.org/show_bug.cgi?id=173646 Reviewed by Jiewen Tan. No new tests -- covered by existing Web Crypto tests. Add three new libtasn1 utility functions. createStructure() is a simple wrapper around asn1_create_element(), creating a new ASN.1 structure for the specified definition that's listed in WebCrypto.asn. The existing decodeStructure() is modified to use this new addition. encodedData() retrieves the ASN.1-encoded data of the specified element that's located in the passed-in asn1_node. This is used when retrieving SPKI or PKCS#8 data from filled-out ASN.1 structures. writeElement() writes the provided data to the given asn1_node object under the specified element, using the given size. True is returned if this operation was successful. * pal/crypto/tasn1/Utilities.cpp: (PAL::TASN1::createStructure): (PAL::TASN1::decodeStructure): (PAL::TASN1::encodedData): (PAL::TASN1::writeElement): * pal/crypto/tasn1/Utilities.h: 2017-07-01 Dan Bernstein <mitz@apple.com> [iOS] Remove code only needed when building for iOS 9.x https://bugs.webkit.org/show_bug.cgi?id=174068 Reviewed by Tim Horton. * Configurations/FeatureDefines.xcconfig: 2017-07-01 Dan Bernstein <mitz@apple.com> [macOS] Remove code only needed when building for OS X Yosemite https://bugs.webkit.org/show_bug.cgi?id=174067 Reviewed by Tim Horton. * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: * Configurations/FeatureDefines.xcconfig: * Configurations/Version.xcconfig: 2017-06-29 Jer Noble <jer.noble@apple.com> Make Legacy EME API controlled by RuntimeEnabled setting. https://bugs.webkit.org/show_bug.cgi?id=173994 Reviewed by Sam Weinig. * Configurations/FeatureDefines.xcconfig: 2017-06-30 Ross Kirsling <ross.kirsling@sony.com> [PAL] Move Sound into PAL https://bugs.webkit.org/show_bug.cgi?id=173999 Reviewed by Alex Christensen. * Configurations/PAL.xcconfig: * PAL.xcodeproj/project.pbxproj: * pal/CMakeLists.txt: * pal/PlatformGTK.cmake: * pal/PlatformMac.cmake: * pal/PlatformWPE.cmake: * pal/PlatformWin.cmake: * pal/system/Sound.h: Renamed from Source/WebCore/platform/ios/SoundIOS.mm. * pal/system/SoundNone.cpp: Renamed from Source/WebCore/platform/wpe/SoundWPE.cpp. (PAL::systemBeep): * pal/system/gtk/SoundGtk.cpp: Renamed from Source/WebCore/platform/gtk/SoundGtk.cpp. * pal/system/mac/SoundMac.mm: Renamed from Source/WebCore/platform/mac/SoundMac.mm. * pal/system/win/SoundWin.cpp: Renamed from Source/WebCore/platform/win/SoundWin.cpp. 2017-06-28 Jonathan Bedard <jbedard@apple.com> Build fix for PAL https://bugs.webkit.org/show_bug.cgi?id=173896 Reviewed by Dan Bernstein. Remove the workaround build fix in r218863. * PAL.xcodeproj/project.pbxproj: We should be using PROJECT_DIR instead of SRCROOT when in a nested Xcode project. 2017-06-27 Jonathan Bedard <jbedard@apple.com> Build fix for PAL https://bugs.webkit.org/show_bug.cgi?id=173896 Reviewed by Myles C. Maxfield. * PAL.xcodeproj/project.pbxproj: Ensure that the SRCROOT is WebCore/PAL and not just WebCore. 2017-06-27 Don Olmstead <don.olmstead@sony.com> [PAL] Add symbol export macros for PAL https://bugs.webkit.org/show_bug.cgi?id=171519 Reviewed by Konstantin Tokarev. No new tests. No change in behavior. * Configurations/CopyPALHeaders.xcconfig: Added. * PAL.xcodeproj/project.pbxproj: * config.h: * pal/ExportMacros.h: Copied from Source/WebCore/platform/PlatformExportMacros.h. * pal/PlatformWin.cmake: * pal/crypto/CryptoDigest.h: 2017-06-20 Zan Dobersek <zdobersek@igalia.com> [GCrypt] Implement CryptoKeyEC SPKI imports https://bugs.webkit.org/show_bug.cgi?id=172927 Reviewed by Jiewen Tan, Michael Catanzaro and Carlos Garcia Campos. Add a file that provides utility functions for operating with libtasn1 APIs. The precomputed ASN.1 declarations, generated from the WebCrypto.asn file with the asn1Parser tool, are used to enable construction of ASN.1 structures that are then used to decode the SPKI or PKCS#8 data through the decodeStructure() function. Raw data of each element in that structure can be retrieved throug the elementData() function. The Structure class is added as a wrapper for asn1_node objects that are used as decoding targets, simplifying lifetime management of these objects. * pal/PlatformGTK.cmake: * pal/PlatformWPE.cmake: * pal/crypto/tasn1/Utilities.cpp: Added. (PAL::TASN1::asn1Definitions): (PAL::TASN1::decodeStructure): (PAL::TASN1::elementData): * pal/crypto/tasn1/Utilities.h: Added. (PAL::TASN1::Structure::~Structure): (PAL::TASN1::Structure::operator&): (PAL::TASN1::Structure::operator asn1_node): * pal/crypto/tasn1/WebCrypto.asn: Added. 2017-06-20 Myles C. Maxfield <mmaxfield@apple.com> Disable font variations on macOS Sierra and iOS 10 https://bugs.webkit.org/show_bug.cgi?id=173618 <rdar://problem/32879164> Reviewed by Jon Lee. * Configurations/FeatureDefines.xcconfig: 2017-06-19 Zan Dobersek <zdobersek@igalia.com> Unreviewed build fix after r218484. * pal/crypto/gcrypt/Utilities.h: Drop the GCrypt prefix from the GCryptCipherOperation type definition, since it's already nested in the PAL::GCrypt namespace. 2017-06-19 Zan Dobersek <zdobersek@igalia.com> [GCrypt] AES_CTR support https://bugs.webkit.org/show_bug.cgi?id=171420 Reviewed by Michael Catanzaro. * pal/crypto/gcrypt/Utilities.h: Add a GCryptCipherOperation type alias that can be used for the gcry_cipher_decrypt or gcry_cipher_encrypt function pointers. 2017-06-16 Wenson Hsieh <wenson_hsieh@apple.com> [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit https://bugs.webkit.org/show_bug.cgi?id=173366 <rdar://problem/32767014> Reviewed by Tim Horton. Introduce ENABLE_DATA_INTERACTION and ENABLE_DRAG_SUPPORT to FeatureDefines.xcconfig. * Configurations/FeatureDefines.xcconfig: 2017-06-10 Dan Bernstein <mitz@apple.com> Reverted r218056 because it made the IDE reindex constantly. * Configurations/DebugRelease.xcconfig: 2017-06-10 Dan Bernstein <mitz@apple.com> [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE https://bugs.webkit.org/show_bug.cgi?id=173223 Reviewed by Sam Weinig. The rebuilds were happening due to a difference in the compiler options that the IDE and xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and specify an appropriate path in CLANG_INDEX_STORE_PATH. * Configurations/DebugRelease.xcconfig: 2017-06-01 Andy Estes <aestes@apple.com> REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake https://bugs.webkit.org/show_bug.cgi?id=172828 Reviewed by Beth Dakin. * Configurations/FeatureDefines.xcconfig: 2017-05-31 Andy Estes <aestes@apple.com> Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number https://bugs.webkit.org/show_bug.cgi?id=172366 Reviewed by Daniel Bates. * Configurations/FeatureDefines.xcconfig: 2017-05-30 Alex Christensen <achristensen@webkit.org> Update libwebrtc configuration https://bugs.webkit.org/show_bug.cgi?id=172727 Reviewed by Geoffrey Garen. * Configurations/FeatureDefines.xcconfig: 2017-05-28 Dan Bernstein <mitz@apple.com> [Xcode] ALWAYS_SEARCH_USER_PATHS is set to YES https://bugs.webkit.org/show_bug.cgi?id=172691 Reviewed by Tim Horton. * Configurations/Base.xcconfig: Set ALWAYS_SEARCH_USER_PATHS to NO. 2017-05-23 Myles C. Maxfield <mmaxfield@apple.com> Remove dead ENABLE(FONT_LOAD_EVENTS) code https://bugs.webkit.org/show_bug.cgi?id=172517 Rubber-stamped by Simon Fraser. No new tests because there is no behavior change. * Configurations/FeatureDefines.xcconfig: 2017-05-18 Andy Estes <aestes@apple.com> ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier https://bugs.webkit.org/show_bug.cgi?id=172305 Reviewed by Anders Carlsson. * Configurations/FeatureDefines.xcconfig: 2017-05-09 Sam Weinig <sam@webkit.org> Remove support for legacy Notifications https://bugs.webkit.org/show_bug.cgi?id=171487 Reviewed by Jon Lee. * Configurations/FeatureDefines.xcconfig: Remove definition of ENABLE_LEGACY_NOTIFICATIONS. 2017-05-09 Zan Dobersek <zdobersek@igalia.com> Upstream the WPE port https://bugs.webkit.org/show_bug.cgi?id=171110 Reviewed by Alex Christensen. * pal/PlatformWPE.cmake: Added. 2017-05-04 Commit Queue <commit-queue@webkit.org> Unreviewed, rolling out r216206. https://bugs.webkit.org/show_bug.cgi?id=171714 Multiple LayoutTests crashing in Document::page() (Requested by ap on #webkit). Reverted changeset: "Remove support for legacy Notifications" https://bugs.webkit.org/show_bug.cgi?id=171487 http://trac.webkit.org/changeset/216206 2017-05-04 Don Olmstead <don.olmstead@am.sony.com> [Win] Remove redundant macros that are set in the CMake config https://bugs.webkit.org/show_bug.cgi?id=171571 Reviewed by Brent Fulgham. No new tests. No change in behavior. * config.h: 2017-05-04 Sam Weinig <sam@webkit.org> Remove support for legacy Notifications https://bugs.webkit.org/show_bug.cgi?id=171487 Reviewed by Jon Lee. * Configurations/FeatureDefines.xcconfig: Remove definition of ENABLE_LEGACY_NOTIFICATIONS. 2017-05-02 Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> Make "PAL/pal" and "PAL/pal/crypto" directories private https://bugs.webkit.org/show_bug.cgi?id=171524 Reviewed by Myles C. Maxfield. Make the "PAL/pal" and "PAL/pal/crypto" directories private to force WebCore sources to include PAL headers in "#include <pal/***.h>" style. * pal/CMakeLists.txt: 2017-05-01 Zan Dobersek <zdobersek@igalia.com> [GCrypt] ECDH bit derivation support https://bugs.webkit.org/show_bug.cgi?id=171070 Reviewed by Michael Catanzaro. Add PAL::GCrypt::HandleDeleter specialization for the gcry_mpi_point_t type. * pal/crypto/gcrypt/Handle.h: (PAL::GCrypt::HandleDeleter<gcry_mpi_point_t>::operator()): 2017-04-25 Daniel Bates <dabates@apple.com> [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header https://bugs.webkit.org/show_bug.cgi?id=136452 <rdar://problem/23412620> Reviewed by Brent Fulgham. Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms. * Configurations/FeatureDefines.xcconfig: 2017-04-19 Youenn Fablet <youenn@apple.com> [Mac] Allow customizing H264 encoder https://bugs.webkit.org/show_bug.cgi?id=170829 Reviewed by Alex Christensen. * Configurations/FeatureDefines.xcconfig: 2017-04-17 Youenn Fablet <youenn@apple.com> Disable outdated WritableStream API https://bugs.webkit.org/show_bug.cgi?id=170749 <rdar://problem/31446233> Reviewed by Alex Christensen. * Configurations/FeatureDefines.xcconfig: 2017-04-14 Mark Lam <mark.lam@apple.com> Update architectures in xcconfig files. https://bugs.webkit.org/show_bug.cgi?id=170867 <rdar://problem/31628104> Reviewed by Joseph Pecoraro. No new tests needed. Only updating xcconfig files. * Configurations/Base.xcconfig: * Configurations/FeatureDefines.xcconfig: 2017-04-12 Dan Bernstein <mitz@apple.com> [Mac] Future-proof .xcconfig files https://bugs.webkit.org/show_bug.cgi?id=170802 Reviewed by Tim Horton. * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: * Configurations/FeatureDefines.xcconfig: * Configurations/Version.xcconfig: 2017-04-11 Dean Jackson <dino@apple.com> Disable outdated WritableStream API https://bugs.webkit.org/show_bug.cgi?id=170749 <rdar://problem/31446233> Reviewed by Tim Horton. The API we implement is no longer accurate. Disable it until we are compatible with the new specification * Configurations/FeatureDefines.xcconfig: 2017-04-10 Alex Christensen <achristensen@webkit.org> Revert r215217 https://bugs.webkit.org/show_bug.cgi?id=170703 * Configurations/FeatureDefines.xcconfig: 2017-04-10 Alex Christensen <achristensen@webkit.org> Continue enabling WebRTC https://bugs.webkit.org/show_bug.cgi?id=170703 Reviewed by Youenn Fablet. * Configurations/FeatureDefines.xcconfig: 2017-04-08 Youenn Fablet <youenn@apple.com> WebRTC tests gardening https://bugs.webkit.org/show_bug.cgi?id=170508 Reviewed by Eric Carlson. * Configurations/FeatureDefines.xcconfig: 2017-04-07 Zan Dobersek <zdobersek@igalia.com> [GCrypt] Implement raw and JWK imports and exports for EC keys https://bugs.webkit.org/show_bug.cgi?id=170546 Reviewed by Michael Catanzaro. Add HandleDeleter specizalizations for gcry_ctx_t and gcry_mpi_t types. * pal/crypto/gcrypt/Handle.h: (PAL::GCrypt::HandleDeleter<gcry_ctx_t>::operator()): (PAL::GCrypt::HandleDeleter<gcry_mpi_t>::operator()): 2017-04-06 Ryan Haddad <ryanhaddad@apple.com> Unreviewed, rolling out r215046. This change broke internal builds. Reverted changeset: "WebRTC tests gardening" https://bugs.webkit.org/show_bug.cgi?id=170508 http://trac.webkit.org/changeset/215046 2017-04-06 Youenn Fablet <youenn@apple.com> WebRTC tests gardening https://bugs.webkit.org/show_bug.cgi?id=170508 Reviewed by Eric Carlson. * Configurations/FeatureDefines.xcconfig: 2017-04-03 Michael Catanzaro <mcatanzaro@igalia.com> Unreviewed, attempt to fix build with libgcrypt < 1.7.0 * pal/crypto/gcrypt/Utilities.h: 2017-04-03 Zan Dobersek <zdobersek@igalia.com> [GCrypt] Implement CryptoKeyEC::keySizeInBits(), ::platformGeneratePair() https://bugs.webkit.org/show_bug.cgi?id=170345 Reviewed by Michael Catanzaro. * pal/crypto/gcrypt/Handle.h: (PAL::GCrypt::HandleDeleter<gcry_sexp_t>::operator()): Add a HandleDeleter specialization for the gcry_sexp_t type. 2017-04-03 Zan Dobersek <zdobersek@igalia.com> [GCrypt] Implement AES_GCM support https://bugs.webkit.org/show_bug.cgi?id=170271 Reviewed by Michael Catanzaro. * pal/crypto/gcrypt/Handle.h: (PAL::GCrypt::HandleDeleter<gcry_cipher_hd_t>::operator()): Specialize the HandleDeleter<> template for the gcry_cipher_hd_t type. 2017-03-30 Zan Dobersek <zdobersek@igalia.com> [GCrypt] Add the Utilities.h header https://bugs.webkit.org/show_bug.cgi?id=170269 Reviewed by Michael Catanzaro. Add a libgcrypt-specific Utilities.h header under PAL. It will contain common functions that are shared throughout the code that leverages libgcrypt. * pal/crypto/gcrypt/Utilities.h: Added. (PAL::GCrypt::logError): Use WTFLogAlways() to report the passed-in libgcrypt error. (PAL::GCrypt::aesAlgorithmForKeySize): Return a GCRY_CIPHER_AES{128,192,256} value that matches up with the passed-in key size. 2017-03-29 Zan Dobersek <zdobersek@igalia.com> [GCrypt] Add a Handle<> class to help with GCrypt object lifetime control https://bugs.webkit.org/show_bug.cgi?id=170238 Reviewed by Michael Catanzaro. Add a GCrypt-specific Handle<> template class, inside the GCrypt namespace. Objects of this class should be used as 'smart handles', cleaning up upon destruction the GCrypt object that's represented by the handle they manage. This mimics the std::unique_ptr<> idea, but is narrowly focused towards how such handles are used in the libgcrypt API. A GCrypt::Handle<> object can be consturcted from an existing handle or with the default null value. It can be cleared upon request via clear(), and the managed handle can be released via release(). The address of the managed handle can be retrieved through the address-of operator. An implicit conversion operator is also added. This allows frictionless use of GCrypt::Handle<> objects with existing libgcrypt APIs. The negation operator is implemented to support testing the nullness of the managed handle. The raw handle value is also retrieveable through the handle() method. The copy and move constructors and assignment operators are deleted. They are not at the moment required anywhere in the work-in-progress implementation of subtle crypto functionality. As with other resource management classes, upon destruction, the GCrypt::Handle<> object destroys the resource it manages. This is done through objects of the HandleDeleter<> template class. Specializations of this class have to implement the call operator that properly releases the resource. Because the operator is deleted by default, a compilation error will be thrown when deleting a resource of some type for which the proper HandleDeleter specialization isn't provided. std::unique_ptr<> could be used, but it could also be mis-used. I find a mini-class with an interface that's specific to libgcrypt API interactions to be preferrable to a std::unique_ptr<> with a custom deleter. * pal/crypto/gcrypt/Handle.h: Added. (PAL::GCrypt::Handle::Handle): (PAL::GCrypt::Handle::~Handle): (PAL::GCrypt::Handle::clear): (PAL::GCrypt::Handle::release): (PAL::GCrypt::Handle::operator&): (PAL::GCrypt::Handle::handle): (PAL::GCrypt::Handle::operator T): (PAL::GCrypt::Handle::operator!): (PAL::GCrypt::HandleDeleter<gcry_mac_hd_t>::operator()): 2017-03-29 Zan Dobersek <zdobersek@igalia.com> [GnuTLS] Remove unused CryptoDigestGnuTLS, CryptoAlgorithmHMACGnuTLS implementation files https://bugs.webkit.org/show_bug.cgi?id=170231 Reviewed by Michael Catanzaro. * pal/crypto/gnutls/CryptoDigestGnuTLS.cpp: Removed. The GCrypt counterpart is already in use, and this file wasn't even being built. 2017-03-17 Michael Saboff <msaboff@apple.com> Use USE_INTERNAL_SDK to compute ENABLE_FAST_JIT_PERMISSIONS instead of HAVE_INTERNAL_SDK https://bugs.webkit.org/show_bug.cgi?id=169817 Reviewed by Filip Pizlo. * Configurations/FeatureDefines.xcconfig: 2017-03-15 Dean Jackson <dino@apple.com> Sort Xcode project files https://bugs.webkit.org/show_bug.cgi?id=169669 Reviewed by Antoine Quint. * PAL.xcodeproj/project.pbxproj: 2017-03-10 Alex Christensen <achristensen@webkit.org> Fix watch and tv builds after r213294 https://bugs.webkit.org/show_bug.cgi?id=169508 Reviewed by Dan Bernstein. * Configurations/FeatureDefines.xcconfig: 2017-03-09 Anders Carlsson <andersca@apple.com> Add delegate support to WebCore https://bugs.webkit.org/show_bug.cgi?id=169427 Part of rdar://problem/28880714. Reviewed by Geoffrey Garen. * Configurations/FeatureDefines.xcconfig: Add feature define. 2017-03-07 Dean Jackson <dino@apple.com> Some platforms won't be able to create a GPUDevice https://bugs.webkit.org/show_bug.cgi?id=169314 <rdar://problems/30907521> Reviewed by Jon Lee. Disable WEB_GPU on the iOS Simulator. * Configurations/FeatureDefines.xcconfig: 2017-03-06 Michael Saboff <msaboff@apple.com> Take advantage of fast permissions switching of JIT memory for devices that support it https://bugs.webkit.org/show_bug.cgi?id=169155 Reviewed by Saam Barati. Updated the Xcode config files to match what is in the JavaScriptCore ones. * Configurations/FeatureDefines.xcconfig: 2017-03-03 Dean Jackson <dino@apple.com> Add WebGPU compile flag and experimental feature flag https://bugs.webkit.org/show_bug.cgi?id=169161 <rdar://problem/30846689> Reviewed by Tim Horton. Add ENABLE_WEBGPU, an experimental feature flag, a RuntimeEnabledFeature, and an InternalSetting. * Configurations/FeatureDefines.xcconfig: 2017-03-02 Alex Christensen <achristensen@webkit.org> Continue enabling WebRTC https://bugs.webkit.org/show_bug.cgi?id=169056 Reviewed by Jon Lee. * Configurations/FeatureDefines.xcconfig: 2017-03-01 Alex Christensen <achristensen@webkit.org> Unreviewed, rolling out r213259. Broke an internal build Reverted changeset: "Continue enabling WebRTC" https://bugs.webkit.org/show_bug.cgi?id=169056 http://trac.webkit.org/changeset/213259 2017-03-01 Alex Christensen <achristensen@webkit.org> Continue enabling WebRTC https://bugs.webkit.org/show_bug.cgi?id=169056 Reviewed by Jon Lee. * Configurations/FeatureDefines.xcconfig: 2017-02-27 Alex Christensen <achristensen@webkit.org> Begin enabling WebRTC on 64-bit https://bugs.webkit.org/show_bug.cgi?id=168915 Reviewed by Eric Carlson. * Configurations/FeatureDefines.xcconfig: 2017-02-27 Alex Christensen <achristensen@webkit.org> [libwebrtc] Enable WebRTC in some Production Builds https://bugs.webkit.org/show_bug.cgi?id=168858 * Configurations/FeatureDefines.xcconfig: 2017-02-21 Youenn Fablet <youenn@apple.com> [WebRTC][Mac] Activate libwebrtc https://bugs.webkit.org/show_bug.cgi?id=167293 Reviewed by Alex Christensen. * Configurations/FeatureDefines.xcconfig: 2017-02-20 Manuel Rego Casasnovas <rego@igalia.com> [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT https://bugs.webkit.org/show_bug.cgi?id=167693 Reviewed by Sergio Villar Senin. * Configurations/FeatureDefines.xcconfig: 2017-02-16 Anders Carlsson <andersca@apple.com> Begin removing EFL code from WebCore. Rubber-stamped by Alex Christensen. * pal/PlatformEfl.cmake: Removed. 2017-01-28 Dan Bernstein <mitz@apple.com> [Xcode] Clean up PAL and WebCore’s build settings a little https://bugs.webkit.org/show_bug.cgi?id=167292 Reviewed by Sam Weinig. * ChangeLog: Created this file. * Configurations/Base.xcconfig: Simplified the definition of GCC_WARN_64_TO_32_BIT_CONVERSION, removed the unused build setting PREBINDING, removed a duplicate definition of GCC_GENERATE_DEBUGGING_SYMBOLS, and removed definitions specific to OS X versions that are no longer supported. * Configurations/DebugRelease.xcconfig: Removed definitions specific to OS X versions that are no longer supported. * Configurations/PAL.xcconfig: Removed header search paths that do not exist or do not make sense. Simplified the definitions of INSTALL_PATH and SKIP_INSTALL. Removed the unusued build settings PRODUCT_BUNDLE_IDENTIFIER and WK_PREFIXED_IPHONEOS_DEPLOYMENT_TARGET. Removed the redundant definition of EXECUTABLE_PREFIX. * PAL.xcodeproj/project.pbxproj: Sorted the Configurations group.