ChangeLog-2010-05-24 [plain text]
2010-05-18 Jaime Yap <jaimeyap@google.com>
Reviewed by Pavel Feldman.
Removes public callLocation API and utility context from ScriptCallStack.
Adds ability to grab the top 5 JavaScript stack frames for each timeline
record using new fast V8 stack trace API.
https://bugs.webkit.org/show_bug.cgi?id=37502
* bindings/js/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::stackTrace):
* bindings/js/ScriptCallStack.h:
* bindings/v8/ScriptArray.h:
(WebCore::ScriptArray::ScriptArray):
* bindings/v8/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::callLocation):
(WebCore::ScriptCallStack::stackTrace):
* bindings/v8/ScriptCallStack.h:
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createGenericRecord):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
2010-05-24 Anders Carlsson <andersca@apple.com>
Try to fix build.
* plugins/npapi.cpp:
(NPN_ReloadPlugins):
2010-05-24 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Get rid of PlugInInfoStore.
https://bugs.webkit.org/show_bug.cgi?id=39608
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/android/TemporaryLinkStubs.cpp:
* plugins/PluginInfoStore.cpp: Removed.
* plugins/PluginInfoStore.h: Removed.
* plugins/npapi.cpp:
2010-05-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r60068.
http://trac.webkit.org/changeset/60068
https://bugs.webkit.org/show_bug.cgi?id=39600
"Causes fast/repaint/search-field-cancel to fail." (Requested
by jparent on #webkit).
* rendering/RenderObject.h:
(WebCore::objectIsRelayoutBoundary):
2010-05-24 Jeremy Orlow <jorlow@chromium.org>
Unreviewed. Checked in merge error. :-(
* CMakeLists.txt:
2010-05-24 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
Geolocation causes DOMWindow to leak if position requests are in progress when the page is navigated away
https://bugs.webkit.org/show_bug.cgi?id=39288
Test: fast/dom/Geolocation/ongoing-request-leak.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading): Stop all Geolocation instances. This call is made after the unload event has fired, so no new Geolocation activity is possible.
* page/Geolocation.cpp:
(WebCore::Geolocation::stop): Removes all ongoing requests and stops the service.
(WebCore::Geolocation::disconnectFrame): Removed calls to stopUpdating() and stopTimers(), as this will already have been done in stop();
* page/Geolocation.h: Added stop() method.
2010-05-24 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Textarea shouldn't grow when you type.
https://bugs.webkit.org/show_bug.cgi?id=32077
<textarea> with percent-specified, height-related properties did
cause partial-layout rooted from the renderer, that resulted
different box height between full-layout and partial-layout. This
is because calcHeight() assumes that the layout calculation of the
RenderBlock's parent is ongoing. But this assumption is violated
when the RenderBlock is root of the layout calculation.
So we prevent such <textarea>'s RenderObjects from being layout
root.
Test: fast/forms/textarea-percentage-dimensions.html
* rendering/RenderObject.h:
(WebCore::objectIsRelayoutBoundary):
2010-05-20 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Alexey Proskuryakov.
Add DOMStringList idl, needed for IndexedDB and for HTML5 drag & drop
https://bugs.webkit.org/show_bug.cgi?id=39429
IndexedDB depends on DOMStringList.
http://dev.w3.org/2006/webapi/WebSimpleDB/#idl-def-IDBDatabase
It's currently specced here:
http://www.w3.org/TR/DOM-Level-3-Core/core.html#DOMStringList
Existing tests cover the constructor. IndexedDB will also use this
soon (and thus add test coverage).
* Android.mk:
* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/CodeGeneratorJS.pm:
* dom/DOMStringList.h: Added.
(WebCore::DOMStringList::create):
(WebCore::DOMStringList::length):
(WebCore::DOMStringList::item):
(WebCore::DOMStringList::isEmpty):
(WebCore::DOMStringList::clear):
(WebCore::DOMStringList::append):
(WebCore::DOMStringList::DOMStringList):
* dom/DOMStringList.idl: Added.
* page/DOMWIndow.idl: Re-enabled constructor
2010-05-23 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Alexey Proskuryakov.
0x5C of EUC-JP is not Yen Sign but U+005C
https://bugs.webkit.org/show_bug.cgi?id=24906
Tests: editing/selection/find-yensign-and-backslash-with-japanese-fonts.html
fast/text/backslash-to-yen-sign-dynamic.html
fast/text/backslash-to-yen-sign.html
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreCommon.vsprops:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/Font.cpp:
(WebCore::Font::Font):
(WebCore::Font::operator=):
* platform/graphics/Font.h:
(WebCore::Font::needsTranscoding):
* platform/text/CharacterNames.h:
* platform/text/transcoder/FontTranscoder.cpp: Added.
(WebCore::FontTranscoder::FontTranscoder):
(WebCore::FontTranscoder::converterType):
(WebCore::FontTranscoder::convert):
(WebCore::FontTranscoder::needsTranscoding):
(WebCore::fontTranscoder):
* platform/text/transcoder/FontTranscoder.h: Added.
(WebCore::FontTranscoder::):
* rendering/RenderText.cpp:
(WebCore::RenderText::updateNeedsTranscoding):
(WebCore::RenderText::styleDidChange):
(WebCore::RenderText::setTextInternal):
2010-05-23 MORITA Hajime <morrita@google.com>
Unreviewed, rolling out r60060.
http://trac.webkit.org/changeset/60060
https://bugs.webkit.org/show_bug.cgi?id=32077
breaks chromium test
* rendering/RenderObject.h:
(WebCore::objectIsRelayoutBoundary):
2010-05-23 Justin Schuh <jschuh@chromium.org>
Reviewed by Shinichiro Hamaji.
Style cleanup for r56288
https://bugs.webkit.org/show_bug.cgi?id=39554
Cleaning up style from a previous patch. No tests needed because no
logic is changed.
* svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::build):
2010-05-23 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Textarea shouldn't grow when you type.
https://bugs.webkit.org/show_bug.cgi?id=32077
<textarea> with percent-specified, height-related properties did
cause partial-layout rooted from the renderer, that resulted
different box height between full-layout and partial-layout. This
is because calcHeight() assumes that the layout calculation of the
RenderBlock's parent is ongoing. But this assumption is violated
when the RenderBlock is root of the layout calculation.
So we prevent such <textarea>'s RenderObjects from being layout
root.
Test: fast/forms/textarea-percentage-dimensions.html
* rendering/RenderObject.h:
(WebCore::objectIsRelayoutBoundary):
2010-05-23 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=39575
Make JS DOMObject inherit from JSObjectWithGlobalObject instead of JSObject
- Changes JSDOMWindowShell to inherit from JSObject instead of
DOMObject since it doesn't ever go into any DOMObject tables.
In a separate change, we may want to make this inherit from
JSObjectWithGlobalObject since JSDOMWindowShell does store a
global object pointer.
- Change DOMObject to inherit from JSObjectWithGlobalObject
instead of JSObject. In this change I am keeping around
DOMObjectWithGlobalPointer, which now just uses the capabilities
of JSObjectWithGlobalObject instead of implementing them
itself. DOMObjectWithGlobalPointer will go away in a subsequent
patch.
* bindings/js/JSDOMBinding.h:
(WebCore::DOMObjectWithGlobalPointer::globalObject):
(WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSDOMWrapper.h:
(WebCore::DOMObject::DOMObject):
2010-05-23 Eric Seidel <eric@webkit.org>
Unreviewed, just being a copy/paste monkey. Oook, eeek.
Add new HTML5TreeBuilder class to hold the tree builder section of the HTML5 parsing spec
https://bugs.webkit.org/show_bug.cgi?id=39572
Add HTML5TreeBuilder.* to each of WebKit's 85,324 build systems.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
2010-05-23 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add new HTML5TreeBuilder class to hold the tree builder section of the HTML5 parsing spec
https://bugs.webkit.org/show_bug.cgi?id=39572
We've been working on the tokenization (lexing) section of the HTML5
spec until now and leaning on the old HTMLParser for tree building.
We need to start writing more of the tree building sections of the spec,
but to do that we need a place to put the new code.
This patch moves our old-to-new conversion hacks out of HTML5Tokenizer
(our Tokenizer.h implementation) and into HTML5TreeBuilder.
Follow-up patches will add new HTML5 tree building code to this file
and will allow us to switch between old and new parser/treebuilder
implementations.
No change in behavior, thus no new tests.
* WebCore.xcodeproj/project.pbxproj:
* html/HTML5Tokenizer.cpp:
(WebCore::HTML5Tokenizer::HTML5Tokenizer):
(WebCore::HTML5Tokenizer::write):
- Call the new HTML5TreeBuilder code.
* html/HTML5Tokenizer.h:
* html/HTML5TreeBuilder.cpp: Added.
* html/HTML5TreeBuilder.h: Added.
2010-05-23 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=39574
Complete the merge of NamedMappedAttrMap into NamedNodeMap.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):
* dom/Element.cpp:
(WebCore::Element::createAttributeMap):
* dom/NamedMappedAttrMap.cpp: Removed.
* dom/NamedMappedAttrMap.h: Removed.
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::setClass):
(WebCore::NamedNodeMap::declCount):
(WebCore::NamedNodeMap::mapsEquivalent):
(WebCore::NamedNodeMap::mappedMapsEquivalent):
* dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::create):
(WebCore::NamedNodeMap::clearClass):
(WebCore::NamedNodeMap::classNames):
(WebCore::NamedNodeMap::hasMappedAttributes):
(WebCore::NamedNodeMap::declRemoved):
(WebCore::NamedNodeMap::declAdded):
(WebCore::NamedNodeMap::NamedNodeMap):
* dom/StyledElement.h:
(WebCore::StyledElement::mappedAttributes):
* html/HTML5Token.h:
* html/HTML5Tokenizer.cpp:
(WebCore::convertToOldStyle):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setInputType):
* html/HTMLParser.cpp:
(WebCore::HTMLParser::handleIsindex):
* html/HTMLTokenizer.cpp:
(WebCore::Token::addAttribute):
(WebCore::HTMLTokenizer::processToken):
* html/HTMLTokenizer.h:
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::createContainingTable):
(WebCore::HTMLViewSourceDocument::addSpanWithClassName):
(WebCore::HTMLViewSourceDocument::addLine):
(WebCore::HTMLViewSourceDocument::addLink):
2010-05-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Teach HTML5 parser how to lex comments correctly
https://bugs.webkit.org/show_bug.cgi?id=39537
Implement the non-bogus comment states for the lexer. There's more
work to do in some of these states (e.g., to handle doctype tokens and
bogus comments), but I'm trying to keep the patches small.
Tests: comments01.dat
* html/HTML5Lexer.cpp:
(WebCore::HTML5Lexer::nextToken):
* html/HTML5Lexer.h:
* html/HTML5Token.h:
(WebCore::HTML5Token::beginComment):
(WebCore::HTML5Token::appendToComment):
(WebCore::HTML5Token::data):
* html/HTML5Tokenizer.cpp:
(WebCore::convertToOldStyle):
* platform/text/SegmentedString.h:
(WebCore::SegmentedString::):
(WebCore::SegmentedString::peek):
- Occationally, the HTML5 parsing algorithm looks ahead in the
input stream. The implementation here is incomplete, but its
enough to run the current HTML5 parsing tests. I'll eventually
need to implement the slow case here.
2010-05-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make the html5lib parser tests run using the HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=39533
Turns out we're just one small tweak away from running the html5lib
tests. After this patch lands, we should be able to introduce tests
for every change to the HTML5 parser.
Test: html5lib/webkit-runner.html
* html/HTML5Lexer.cpp:
(WebCore::HTML5Lexer::nextToken):
2010-05-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make HTML5 parser parse <script>alert("<hi>");</script>
https://bugs.webkit.org/show_bug.cgi?id=39525
More progress towards getting the html5lib test harness running. We
need to parse script data in the ScriptDataState. The spec says the
parser should set the lexer's state to ScriptDataState, but we want to
keep using the existing parser for a while so I've added some temporary
logic to HTML5Tokenizer to set the state in the lexer.
To get this case running, I needed to flesh out a bunch of the
ScriptDataState logic. There's a bunch more to do, but this is a
start.
I'm not 100% happy with this patch, but it lets us execute a simplified
version of the test harness up to the point where it starts running the
first test.
* html/HTML5Lexer.cpp:
(WebCore::HTML5Lexer::nextToken):
(WebCore::HTML5Lexer::isAppropriateEndTag):
(WebCore::HTML5Lexer::emitCurrentTagToken):
* html/HTML5Lexer.h:
(WebCore::HTML5Lexer::setState):
* html/HTML5Token.h:
(WebCore::HTML5Token::beginEndTag):
(WebCore::HTML5Token::appendToCharacter):
(WebCore::HTML5Token::name):
* html/HTML5Tokenizer.cpp:
(WebCore::HTML5Tokenizer::write):
2010-05-23 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Limit the number of tiles created for large tiled layers
https://bugs.webkit.org/show_bug.cgi?id=39522
I added an algorithm to limit the number of tiles created to 512.
It tried to limit them in only one dimension and if that's not
possible it limits them in both dimensions according to the
ratio of width to height. This has the effect of rendering
tiles starting from the upper-left, which is often the part
that is visible. So it both prevents crashing and tried to do
the best job it can of displaying what the author intended.
The test LayoutTests/compositing/geometry/huge-layers.html was
crashing before this fix. Now it works correctly.
* platform/graphics/win/WebTiledLayer.cpp:
(WebCore::WebTiledLayer::WebTiledLayer):
(WebCore::WebTiledLayer::setBounds):
(WebCore::WebTiledLayer::constrainedSize):
(WebCore::WebTiledLayer::updateTiles):
* platform/graphics/win/WebTiledLayer.h:
2010-05-23 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Using Accelerated Composing the rocket back animation on http://www.the-art-of-web.com/css/css-animation/ works differently as when not using AC.
https://bugs.webkit.org/show_bug.cgi?id=39513
The value of GraphicsLayer->transform() needs to be changed during the animation, regardless of m_fillsForward.
m_fillsForward should only apply at the end of the animation. Based on previous patch by Kenneth Christiansen.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::TransformAnimationQt::applyFrame):
(WebCore::OpacityAnimationQt::applyFrame):
2010-05-23 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Eric Seidel.
[Qt] GraphicsLayerQt: Coding style and comment fixes.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::MaskEffectQt::MaskEffectQt):
(WebCore::MaskEffectQt::draw):
(WebCore::GraphicsLayerQtImpl::ContentData::ContentData):
(WebCore::GraphicsLayerQtImpl::State::State):
(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::~GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::rootLayer):
(WebCore::GraphicsLayerQtImpl::recache):
(WebCore::GraphicsLayerQtImpl::updateTransform):
(WebCore::GraphicsLayerQtImpl::opaqueArea):
(WebCore::GraphicsLayerQtImpl::flushChanges):
(WebCore::GraphicsLayerQtImpl::notifyAnimationStarted):
(WebCore::GraphicsLayerQt::setNeedsDisplayInRect):
(WebCore::GraphicsLayerQt::setContentsToImage):
(WebCore::applyTimingFunction):
(WebCore::AnimationQtBase::updateState):
(WebCore::AnimationQt::AnimationQt):
(WebCore::AnimationQt::updateCurrentTime):
(WebCore::TransformAnimationQt::applyFrame):
(WebCore::TransformAnimationQt::updateState):
(WebCore::OpacityAnimationQt::OpacityAnimationQt):
(WebCore::OpacityAnimationQt::applyFrame):
(WebCore::GraphicsLayerQt::addAnimation):
(WebCore::GraphicsLayerQt::removeAnimationsForProperty):
(WebCore::GraphicsLayerQt::removeAnimationsForKeyframes):
(WebCore::GraphicsLayerQt::pauseAnimation):
(WebCore::GraphicsLayerQt::suspendAnimations):
(WebCore::GraphicsLayerQt::resumeAnimations):
* platform/graphics/qt/GraphicsLayerQt.h:
2010-05-23 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Adler.
Remove custom binding for Attr.value
https://bugs.webkit.org/show_bug.cgi?id=39499
Custom bindings are no longer needed because origin checks were moved
out of the bindings by: http://trac.webkit.org/changeset/59866
* Android.v8bindings.mk:
* WebCore.gypi:
* bindings/js/JSAttrCustom.cpp:
* bindings/v8/custom/V8AttrCustom.cpp: Removed.
* dom/Attr.idl:
2010-05-23 Grace Kloba <klobag@gmail.com>
Reviewed by Nate Chapin.
Match the call of scheduleLocationChange() to its correct signature.
Fixes <http://webkit.org/b/39452>
The call of scheduleLocationChange() in generic and v8 bindings assuming the
fourth parameter is "usergesture". But it is actually the fifth parameter.
No new features. No new tests.
* bindings/generic/BindingDOMWindow.h:
(WebCore::::createWindow):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openCallback):
2010-05-23 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Reduce copy/paste code in HTMLParser using some template functions
https://bugs.webkit.org/show_bug.cgi?id=39471
No functional changes, thus no tests.
* html/HTMLParser.cpp:
(WebCore::addTags):
- New function which takes a set an an array of QualifiedNames
and adds the localName().impl() to the set for each QualifiedName.
(WebCore::isTablePart):
(WebCore::isScopingTag):
(WebCore::mapTagToFunc):
(WebCore::mapTagsToFunc):
- New functions which take QualifiedNames and a function and map from the
localName().impl() to the function.
(WebCore::HTMLParser::getNode):
(WebCore::HTMLParser::isHeadingTag):
(WebCore::HTMLParser::isResidualStyleTag):
(WebCore::HTMLParser::isAffectedByResidualStyle):
2010-05-22 Julie Parent <jparent@chromium.org>
Reviewed by Adam Barth.
REGRESSION: xssAuditor tests failing in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=39560
Follow up to r0014. Make if statement in V8 bindings match the one from jsc version.
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::evaluate):
2010-05-22 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
REGRESSION(r59977): platform/mac/fast/AppleScript/001.html failure
https://bugs.webkit.org/show_bug.cgi?id=39531
Revert r59977 and r59943. These changes caused some exceptions to no longer be
reported in the inspector; I can't tell what they were originally trying to fix
so I am not sure how to fix them other than by reverting.
Covered by existing test platform/mac/fast/AppleScript/001.html, and
also added fast/dom/nested-script-exceptions.html to demonstrate the wider
consequences of the original change.
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::evaluateInWorld):
* bindings/js/ScriptController.h:
2010-05-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add DragData
https://bugs.webkit.org/show_bug.cgi?id=39469
As BREW MP does not support dragging, add dummy implementation of DragData.
* platform/DragData.h:
* platform/brew/DragDataBrew.cpp: Added.
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::containsColor):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::asPlainText):
(WebCore::DragData::asColor):
(WebCore::DragData::createClipboard):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
(WebCore::DragData::asFilenames):
(WebCore::DragData::containsFiles):
2010-05-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add dummy Icon
https://bugs.webkit.org/show_bug.cgi?id=39468
Add dummy implementation of Icon.
* platform/graphics/brew/IconBrew.cpp: Added.
(WebCore::Icon::~Icon):
(WebCore::Icon::createIconForFiles):
(WebCore::Icon::paint):
2010-05-22 Justin Schuh <jschuh@chromium.org>
Reviewed by Nate Chapin.
Remove and simplify custom bindings for Node
https://bugs.webkit.org/show_bug.cgi?id=39467
Custom bindings for nodeValue and textContent are no longer needed,
and child manipulators are simplified because origin checks were moved
out of the bindings by: http://trac.webkit.org/changeset/59866
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::insertBefore):
(WebCore::JSNode::replaceChild):
(WebCore::JSNode::removeChild):
(WebCore::JSNode::appendChild):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):
* dom/Node.idl:
2010-05-22 Justin Schuh <jschuh@chromium.org>
Reviewed by Nate Chapin.
Remove custom bindings for NamedNodeMap.setNamedItem and .setNamedItemNS
https://bugs.webkit.org/show_bug.cgi?id=39462
Custom bindings are no longer needed because origin checks were moved
out of the bindings by: http://trac.webkit.org/changeset/59866
Behavior isn't changed and is covered by existing tests.
* bindings/js/JSNamedNodeMapCustom.cpp:
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
* dom/NamedNodeMap.idl:
2010-05-22 Daniel Bates <dbates@rim.com>
No review, rolling out 60017.
http://trac.webkit.org/changeset/60017
https://bugs.webkit.org/show_bug.cgi?id=39339
Rolling out since this broke the build on the Windows and Qt bots.
Need to look into this some more.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/ScriptControllerBase.h: Removed.
* bindings/js/ScriptController.h:
(WebCore::):
* bindings/v8/ScriptController.h:
(WebCore::):
2010-05-22 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Move enum ReasonForCallingCanExecuteScripts to header ScriptControllerBase.h
https://bugs.webkit.org/show_bug.cgi?id=39339
Moved the enum ReasonForCallingCanExecuteScripts and ShouldAllowXSS, which
was defined in both the JSC and V8 ScriptController.h file, into a shared
file called ScriptControllerBase.h.
No functionality was changed, so no new tests.
* GNUmakefile.am: Added file bindings/ScriptControllerBase.h.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/ScriptControllerBase.h: Added.
(WebCore::):
* bindings/js/ScriptController.h: #include ScriptControllerBase.h
* bindings/v8/ScriptController.h: Ditto.
2010-05-22 Yong Li <yoli@rim.com>
Reviewed by Darin Adler.
Fix a crash when XHTMLMP is enabled. The frame pointer in Document
ctor can be null.
https://bugs.webkit.org/show_bug.cgi?id=39448
No new tests because it is obvious and it must be reproduced with
XHTMLMP enabled.
* dom/Document.cpp:
(WebCore::Document::Document):
2010-05-22 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
REGRESSION (r56295): Can't create a new wave on Google Wave
https://bugs.webkit.org/show_bug.cgi?id=39249
Instead of just using the source code portion of a JavaScript URL to
detect an XSS attack, we now include the JavaScript URL schema. This
reduces the chance of a false positive by providing additional context.
Test: http/tests/security/xssAuditor/javascript-link-safe.html
* WebCore.base.exp: Updated exported symbols as necessary.
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeScript): Added parameter shouldAllowXSS.
(WebCore::ScriptController::executeIfJavaScriptURL): Ditto.
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld): Ditto.
(WebCore::ScriptController::evaluate): Ditto.
(WebCore::ScriptController::executeScriptInWorld): Ditto.
* bindings/js/ScriptController.h: Added enum ShouldAllowXSS.
(WebCore::):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::evaluate): Added parameter shouldAllowXSS.
* bindings/v8/ScriptController.h: Added enum ShouldAllowXSS.
(WebCore::):
2010-05-22 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Eric Seidel.
Document RenderObject::m_hasOverflowClip.
https://bugs.webkit.org/show_bug.cgi?id=39425
No new functionality, so no new tests.
* rendering/RenderObject.h:
2010-05-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add DragController
https://bugs.webkit.org/show_bug.cgi?id=39400
Add DragController for BREW MP.
* page/brew/DragControllerBrew.cpp: Added.
(WebCore::DragController::isCopyKeyDown):
(WebCore::DragController::dragOperation):
(WebCore::DragController::maxDragImageSize):
(WebCore::DragController::cleanupAfterSystemDrag):
2010-05-22 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Eric Seidel.
[EFL] Build fix (update source code lists).
http://webkit.org/b/39235
* CMakeLists.txt:
2010-05-22 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] webkit_web_view_drag_end should call EventHandler::dragSourceEndedAt
https://bugs.webkit.org/show_bug.cgi?id=39465
Added a helper function for converting a GDK action bitmask into a DragOperation bitmask.
No new tests as behavior has not changed.
* platform/gtk/ClipboardUtilitiesGtk.cpp:
(WebCore::gdkDragActionToDragOperation): Added.
* platform/gtk/ClipboardUtilitiesGtk.h:
2010-05-22 Patrick Gansterer <paroga@paroga.com>
Reviewed by Eric Seidel.
[Qt] Cleanup SharedBuffer::createWithContentsOfFile
https://bugs.webkit.org/show_bug.cgi?id=38917
* platform/qt/SharedBufferQt.cpp:
(WebCore::SharedBuffer::createWithContentsOfFile):
2010-05-22 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] WebKit/gtk/WebCoreSupport/DragClientGtk::startDrag should use the Clipboard::sourceOperation
https://bugs.webkit.org/show_bug.cgi?id=39459
Add ClipboardUtilitiesGtk, a container for GTK+/WebCore clipboard utility functions.
Initially add a function which converts a WebCore::DragOperation to a bitmask of
GdkDragActions.
No new tests, because behavior has not changed.
* GNUmakefile.am:
* platform/gtk/ClipboardUtilitiesGtk.cpp: Added.
(WebCore::dragOperationToGdkDragActions): Added.
* platform/gtk/ClipboardUtilitiesGtk.h: Added.
2010-05-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Parse attributes with HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=39520
This patch lets the HTML5 lexer parse attributes, as in
<div attr="foo"></div>. This patch is on the critical path to running
the html5lib tests.
* html/HTML5Lexer.cpp:
(WebCore::HTML5Lexer::nextToken):
* html/HTML5Lexer.h:
* html/HTML5Token.h:
(WebCore::HTML5Token::beginStartTag):
(WebCore::HTML5Token::beginEndTag):
(WebCore::HTML5Token::addNewAttribute):
(WebCore::HTML5Token::appendToAttributeName):
(WebCore::HTML5Token::appendToAttributeValue):
(WebCore::HTML5Token::attributes):
* html/HTML5Tokenizer.cpp:
(WebCore::convertToOldStyle):
2010-05-21 Mark Rowe <mrowe@apple.com>
60,000!
* ChangeLog: Point out revision 60,000.
2010-05-21 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
Preparation for support of column-span, which will be implemented using continuations. When a block splits an inline, a
continuation chain is created of the form inline -> anonymous block -> inline. The middle block is always anonymous. When a column-span
splits the blocks in a multi-column block, it will create a similar chain: block -> anonymous block -> block. Enclosing split elements
directly connect to their continuations, so their chains will look like inline -> inline or block -> block.
This patch changes the member variable in RenderBlock, m_inlineContinuation, to simply be m_continuation and loosens up the type on it
to RenderBoxModelObject. This reflects the fact that the continuation of the block can now be another block and isn't always simply an inline.
Some renames have been done for cleanup:
isInlineContinuation -> isInlineElementContinuation to emphasize that this is a split non-anonymous element.
inlineContinuation -> inlineElementContinuation, again to emphasize that the inline is not anonymous.
Some new methods have been added:
isBlockElementContinuation - just like isInlineElementContinuation but for split block elements.
blockElementContinuation - just like inlineElementContinuation but for split block elements.
virtualContinuation - A way to just walk an entire continuation chain of mixed types (blocks and inlines) using their common base class.
isAnonymousBlockContinuation - A method for asking if a RenderBlock is an anonymous block in the continuation chain (the guy in the middle).
Code that was specific to the anonymous blocks in a continuation chain has been patched to ask isAnonymousBlockContinuation, so that it won't
incorrectly apply to non-anonymous blocks in the future. Where possible, code that really didn't care about being an inline vs. a block has
been broadened so that it will work with block continuations as well.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::lastChildConsideringContinuation):
(WebCore::startOfContinuations):
(WebCore::endOfContinuations):
(WebCore::childBeforeConsideringContinuations):
(WebCore::firstChildIsInlineContinuation):
(WebCore::AccessibilityRenderObject::nextSibling):
(WebCore::AccessibilityRenderObject::anchorElement):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
(WebCore::InlineFlowBox::paint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::destroy):
(WebCore::RenderBlock::removeLeftoverAnonymousBlock):
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::inlineElementContinuation):
(WebCore::RenderBlock::blockElementContinuation):
(WebCore::RenderBlock::addContinuationWithOutline):
(WebCore::RenderBlock::absoluteRects):
(WebCore::RenderBlock::absoluteQuads):
(WebCore::RenderBlock::rectWithOutlineForRepaint):
(WebCore::RenderBlock::hoverAncestor):
(WebCore::RenderBlock::updateDragState):
(WebCore::RenderBlock::outlineStyleForRepaint):
(WebCore::RenderBlock::updateHitTestResult):
(WebCore::RenderBlock::addFocusRingRects):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::continuation):
(WebCore::RenderBlock::setContinuation):
(WebCore::RenderBlock::virtualContinuation):
(WebCore::RenderBlock::isAnonymousBlockContinuation):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::inlineElementContinuation):
(WebCore::RenderInline::styleDidChange):
(WebCore::nextContinuation):
(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::positionForPoint):
(WebCore::RenderInline::updateHitTestResult):
* rendering/RenderInline.h:
(WebCore::RenderInline::setContinuation):
(WebCore::RenderInline::virtualContinuation):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::getTextDecorationColors):
* rendering/RenderObject.h:
(WebCore::RenderObject::isElementContinuation):
(WebCore::RenderObject::isInlineElementContinuation):
(WebCore::RenderObject::isBlockElementContinuation):
(WebCore::RenderObject::virtualContinuation):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
* rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::moveBlockChildren):
2010-05-21 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Teach WebKit2 to build in the Production configuration.
* Configurations/WebCore.xcconfig: Pass -allowable_client to the linker in all configurations.
2010-05-21 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Implement tiled compositing layers on Windows
https://bugs.webkit.org/show_bug.cgi?id=39461
This adds a tiling implementation similar (from a GraphicsLayer standpoint)
to the one for Mac. But where Mac uses the existing CATiledLayer, I've had
to implement one. If a layer is greater then 2k x 2k, I split it into an
array of 512 x 512 tiles. These tiles are positioned in the correct place
for the TiledLayer's content. When setNeedsDisplay is called on the TiledLayer
the tiles' setNeedDisplay methods are called. Each tile clips and positions the
CGContext appropriately and then renders the layer.
I also got rid of all frame()/setFrame() API to reduce the number of calls to
override for tiling.
Much optimization is possible. Most significantly right now all tiles are
rendered whether visible or not. We need to only render tiles that are
currently visible.
Tests: compositing/huge-layer-add-remove-child.html
compositing/huge-layer-resize.html
compositing/huge-layer-with-layer-children-resize.html
compositing/huge-layer-with-layer-children.html
compositing/huge-layer.html
* WebCore.vcproj/WebCore.vcproj:
* platform/graphics/win/GraphicsLayerCACF.cpp: Added tiling code similar to GraphicsLayerCA
(WebCore::GraphicsLayerCACF::requiresTiledLayer):
(WebCore::GraphicsLayerCACF::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCACF::updateLayerSize):
(WebCore::GraphicsLayerCACF::updateLayerDrawsContent):
* platform/graphics/win/GraphicsLayerCACF.h:
* platform/graphics/win/WKCACFLayer.cpp: Made some methods virtual so WebTiledLayer can override.
Also added sublayer setting and manipulation methods needed for tiling
(WebCore::WKCACFLayer::addSublayer):
(WebCore::WKCACFLayer::internalInsertSublayer):
(WebCore::WKCACFLayer::insertSublayerAboveLayer):
(WebCore::WKCACFLayer::insertSublayerBelowLayer):
(WebCore::WKCACFLayer::replaceSublayer):
(WebCore::WKCACFLayer::internalSublayerCount):
(WebCore::WKCACFLayer::adoptSublayers):
(WebCore::WKCACFLayer::internalSublayerAtIndex):
(WebCore::WKCACFLayer::internalIndexOfSublayer):
(WebCore::WKCACFLayer::internalRemoveAllSublayers):
(WebCore::WKCACFLayer::internalSetSublayers):
(WebCore::WKCACFLayer::internalSetNeedsDisplay):
(WebCore::WKCACFLayer::printLayer):
* platform/graphics/win/WKCACFLayer.h:
(WebCore::WKCACFLayer::setNeedsDisplay):
(WebCore::WKCACFLayer::removeAllSublayers):
(WebCore::WKCACFLayer::setSublayers):
(WebCore::WKCACFLayer::insertSublayer):
(WebCore::WKCACFLayer::sublayerCount):
* platform/graphics/win/WKCACFLayerRenderer.cpp: Fix a crash exposed when tiling code is active
(WebCore::WKCACFLayerRenderer::createRenderer):
(WebCore::WKCACFLayerRenderer::destroyRenderer):
(WebCore::WKCACFLayerRenderer::resize):
* platform/graphics/win/WebLayer.cpp: Added. Split this out from GraphicsLayerCACF so it could be subclassed by WebTiledLayer
(WebCore::WebLayer::internalSetNeedsDisplay):
(WebCore::WebLayer::drawInContext):
* platform/graphics/win/WebLayer.h: Added.
(WebCore::WebLayer::create):
(WebCore::WebLayer::WebLayer):
* platform/graphics/win/WebTiledLayer.cpp: Added. Where all the tile construction and rendering is done
(WebCore::WebTiledLayer::tileDisplayCallback):
(WebCore::WebTiledLayer::create):
(WebCore::WebTiledLayer::WebTiledLayer):
(WebCore::WebTiledLayer::~WebTiledLayer):
(WebCore::WebTiledLayer::setBounds):
(WebCore::WebTiledLayer::internalSetNeedsDisplay):
(WebCore::WebTiledLayer::internalSublayerCount):
(WebCore::WebTiledLayer::internalRemoveAllSublayers):
(WebCore::WebTiledLayer::internalSetSublayers):
(WebCore::WebTiledLayer::internalInsertSublayer):
(WebCore::WebTiledLayer::internalSublayerAtIndex):
(WebCore::WebTiledLayer::internalIndexOfSublayer):
(WebCore::WebTiledLayer::addTile):
(WebCore::WebTiledLayer::removeTile):
(WebCore::WebTiledLayer::tileAtIndex):
(WebCore::WebTiledLayer::tileCount):
(WebCore::WebTiledLayer::updateTiles):
(WebCore::WebTiledLayer::drawTile):
* platform/graphics/win/WebTiledLayer.h: Added.
2010-05-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Fixed a typo in my last commit: Reset m_inEvaluateInWorld to
wasInEvaluateInWorld, rather than false, to avoid stomping the old value
when it's true.
https://bugs.webkit.org/show_bug.cgi?id=39518
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
2010-05-21 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=39516, back end support for column-span property.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::columnSpan):
(WebCore::InheritedFlags::setColumnSpan):
(WebCore::InheritedFlags::initialColumnSpan):
* rendering/style/StyleMultiColData.cpp:
(WebCore::StyleMultiColData::StyleMultiColData):
(WebCore::StyleMultiColData::operator==):
* rendering/style/StyleMultiColData.h:
2010-05-21 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
Disable full-screen video on Windows
https://bugs.webkit.org/show_bug.cgi?id=39506
rdar://problem/8012516
Disable full-screen video through MediaPlayerPrivateVisualContext since
we no longer use GWorlds and QuickTime's built in full-screen support.
Media layout tests updated with new expected results.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::supportsFullscreen):
2010-05-21 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Avoid creating huge tiled layers with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=39515
Constrain the size of huge composited layers, to avoid bad behavior. We only
need to do this if we detect that we need a tiled layer, since we'll make tiled
layers for elements over a certain size that need to draw already.
Constrain the size by attempting to shrink the longer dimension first.
Test: compositing/geometry/huge-layer.html
* platform/graphics/mac/GraphicsLayerCA.h:
* platform/graphics/mac/GraphicsLayerCA.mm:
(WebCore::GraphicsLayerCA::updateLayerPosition):
(WebCore::GraphicsLayerCA::updateLayerSize):
(WebCore::GraphicsLayerCA::constrainedSize):
2010-05-21 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=39420, :visited not working with background-color.
Make the RenderStyle color accessors private. This forces callers to use visitedDependentColor
instead (or to make the decision to become friends of the RenderStyle class in order to get access
to the real style information).
Modified history/self-is-visited.html to also test background colors.
* WebCore.base.exp:
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(AXAttributeStringSetStyle):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
* css/CSSComputedStyleDeclaration.h:
* css/SVGCSSStyleSelector.cpp:
(WebCore::colorFromSVGColorCSSValue):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::editingStyleAtPosition):
(WebCore::prepareEditingStyleToApplyAt):
(WebCore::removeStylesAddedByNode):
(WebCore::fontColorChangesComputedStyle):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
* editing/ApplyStyleCommand.h:
(WebCore::):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs):
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
* editing/DeleteButtonController.cpp:
(WebCore::isDeletableElement):
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::saveTypingStyleState):
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion):
* editing/RemoveFormatCommand.cpp:
(WebCore::RemoveFormatCommand::doApply):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::handleStyleSpansBeforeInsertion):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):
(WebCore::ReplaceSelectionCommand::doApply):
* editing/SelectionController.cpp:
(WebCore::SelectionController::paintCaret):
* editing/markup.cpp:
(WebCore::createMarkup):
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::ensurePropertyMap):
* page/animation/AnimationBase.h:
* page/mac/FrameMac.mm:
(WebCore::Frame::fontAttributesForSelectionStart):
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::paintSelection):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::paintRootBoxDecorations):
(WebCore::RenderBox::paintBoxDecorationsWithSize):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::rendererBackgroundColor):
* rendering/RenderLayerBacking.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemStyle):
(WebCore::RenderMenuList::itemBackgroundColor):
(WebCore::RenderMenuList::menuStyle):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::selectionBackgroundColor):
(WebCore::RenderObject::selectionForegroundColor):
* rendering/RenderSVGResource.cpp:
(WebCore::RenderSVGResource::adjustColorForPseudoRules):
(WebCore::RenderSVGResource::fillPaintingResource):
(WebCore::RenderSVGResource::strokePaintingResource):
* rendering/RenderSVGResource.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paintBoxDecorations):
* rendering/RenderTable.h:
(WebCore::RenderTable::bgColor):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::adjustInnerTextStyle):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::menuStyle):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isControlStyled):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuListButton):
* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::write):
* rendering/RenderTreeAsText.h:
* rendering/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintSelection):
* rendering/SVGRenderTreeAsText.cpp:
(WebCore::writeRenderSVGTextBox):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):
* rendering/style/RenderStyle.h:
(WebCore::):
(WebCore::InheritedFlags::hasBackground):
(WebCore::InheritedFlags::borderLeftStyle):
(WebCore::InheritedFlags::borderRightStyle):
(WebCore::InheritedFlags::borderTopStyle):
(WebCore::InheritedFlags::borderBottomStyle):
(WebCore::InheritedFlags::textShadow):
(WebCore::InheritedFlags::textStrokeWidth):
(WebCore::InheritedFlags::hasNormalColumnGap):
(WebCore::InheritedFlags::borderLeftColor):
(WebCore::InheritedFlags::borderRightColor):
(WebCore::InheritedFlags::borderTopColor):
(WebCore::InheritedFlags::borderBottomColor):
(WebCore::InheritedFlags::backgroundColor):
(WebCore::InheritedFlags::color):
(WebCore::InheritedFlags::columnRuleColor):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::textFillColor):
(WebCore::InheritedFlags::textStrokeColor):
* svg/SVGAnimationElement.cpp:
(WebCore::adjustForCurrentColor):
2010-05-21 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/8009118> Crash in WebCore::toAlphabetic()
while running MangleMe
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=39508
The math was slightly off here, and we wound up trying to access an
array at index -1 in some cases. We need to decrement numberShadow
rather than subtracting one from the result of the modulo
operation.
* rendering/RenderListMarker.cpp:
(WebCore::toAlphabeticOrNumeric):
2010-05-21 Oliver Hunt <oliver@apple.com>
Qt buildfix #2
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertQVariantToValue):
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
2010-05-21 Oliver Hunt <oliver@apple.com>
Qt buildfix #1
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObject::QtRuntimeObject):
(JSC::Bindings::QtInstance::newRuntimeObject):
(JSC::Bindings::QtInstance::getMethod):
* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):
(JSC::Bindings::QtPixmapInstance::getMethod):
(JSC::Bindings::QtPixmapInstance::createRuntimeObject):
2010-05-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Fixed failure seen on buildbot (due to flaky test).
Don't report an exception in a nested script evaluation -- just pass the
exception on to our caller. Our caller can decide to report the exception,
if it fully propagates -- but we don't want to report an exception that's
going to get caught.
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::evaluateInWorld):
* bindings/js/ScriptController.h:
2010-05-21 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
All callable objects should have a global object reference
https://bugs.webkit.org/show_bug.cgi?id=39495
Update the bindings generator to give prototype objects a
global object. Update all the manually written JSObject
subclasses to pass a global object.
* ForwardingHeaders/runtime/JSObjectWithGlobalObject.h: Added.
* WebCore.PluginHostProcess.exp:
* bindings/js/JSDOMBinding.cpp:
(WebCore::objectToStringFunctionGetter):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::nonCachingStaticFunctionGetter):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::setWindow):
* bindings/js/JSHistoryCustom.cpp:
(WebCore::nonCachingStaticBackFunctionGetter):
(WebCore::nonCachingStaticForwardFunctionGetter):
(WebCore::nonCachingStaticGoFunctionGetter):
* bindings/js/JSLocationCustom.cpp:
(WebCore::nonCachingStaticReplaceFunctionGetter):
(WebCore::nonCachingStaticReloadFunctionGetter):
(WebCore::nonCachingStaticAssignFunctionGetter):
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::initScript):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/c/CRuntimeObject.cpp:
(JSC::Bindings::CRuntimeObject::CRuntimeObject):
* bridge/c/CRuntimeObject.h:
* bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::newRuntimeObject):
(JSC::Bindings::CRuntimeMethod::CRuntimeMethod):
(JSC::Bindings::CInstance::getMethod):
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::newRuntimeObject):
(JavaRuntimeMethod::JavaRuntimeMethod):
(JavaInstance::getMethod):
* bridge/jni/jsc/JavaRuntimeObject.cpp:
(JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):
* bridge/jni/jsc/JavaRuntimeObject.h:
* bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::newRuntimeObject):
* bridge/objc/ObjCRuntimeObject.h:
* bridge/objc/ObjCRuntimeObject.mm:
(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
* bridge/objc/objc_class.mm:
(JSC::Bindings::ObjcClass::fallbackObject):
* bridge/objc/objc_instance.mm:
(ObjcInstance::newRuntimeObject):
(ObjCRuntimeMethod::ObjCRuntimeMethod):
(ObjcInstance::getMethod):
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::RuntimeMethod):
* bridge/runtime_method.h:
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::RuntimeObject):
* bridge/runtime_object.h:
2010-05-21 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Add DeviceOrientation and DeviceOrientationClient
https://bugs.webkit.org/show_bug.cgi?id=39479
The page owns a DeviceOrientation object, which has a pointer to a
DeviceOrientationClient object provided by the embedder. The
DeviceOrientation object forwards requests to start listening to
orientation to the client, and when updates are available, fires a
DeviceOrientationEvent on the window object.
No new tests are possible at this time as the implementation is
incomplete. Future patches will add LayoutTestController methods
to provide mock orientation events to test this.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.base.exp:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj
* WebCore.xcodeproj/project.pbxproj:
* dom/DeviceOrientation.cpp: Added.
(WebCore::DeviceOrientation::DeviceOrientation):
(WebCore::DeviceOrientation::onDeviceOrientationChange):
* dom/DeviceOrientation.h: Added.
* dom/DeviceOrientationClient.h: Added.
(WebCore::DeviceOrientationClient::~DeviceOrientationClient):
* page/Page.cpp:
(WebCore::Page::Page):
* page/Page.h:
(WebCore::Page::deviceOrientation):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
2010-05-21 Tasuku Suzuki <tasuku.suzuki@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix compilation with QT_NO_GRAPHICSEFFECT
https://bugs.webkit.org/show_bug.cgi?id=38324
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::flushChanges):
2010-05-21 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Darin Fisher.
Fix the HistoryController::pushState.
It should be possible to call the pushState method from
the first page in a window.
history.pushState doesn't work for the first page in a window.
https://bugs.webkit.org/show_bug.cgi?id=39418
* loader/HistoryController.cpp:
(WebCore::HistoryController::pushState):
2010-05-21 Victoria Kirst <vrk@google.com>
Reviewed by David Levin.
[chromium] Fix slider status when buffering
https://bugs.webkit.org/show_bug.cgi?id=39370
Adjusts the buffering bar to be aligned with the slider thumb.
No new tests. (Covered by existing layout tests.)
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaSlider):
Added logic to align the buffering bar with the thumb. Half of the
thumb image is transparent, so the buffer bar is adjusted to fill in
this gap.
2010-05-21 Jesus Sanchez-Palencia <jesus@webkit.org>
Reviewed by Eric Seidel.
Extra processesArguments() calls in Document::processViewport
https://bugs.webkit.org/show_bug.cgi?id=39358
The viewport arguments are only needed when there is a frame->page(),
therefore we don't need to always call processArguments().
* dom/Document.cpp:
(WebCore::Document::processViewport):
2010-05-17 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GStreamer] video painting support on mac port
https://bugs.webkit.org/show_bug.cgi?id=39206
ImageGStreamer support for mac port. A CG Image is created using
the GstBuffer data. It can then be painted by the gstreamer player.
* platform/graphics/gstreamer/ImageGStreamer.h:
* platform/graphics/gstreamer/ImageGStreamerCG.mm: Added.
(ImageGStreamer::createImage):
(ImageGStreamer::ImageGStreamer):
(ImageGStreamer::~ImageGStreamer):
2010-05-21 Robin Cao <robin.cao@torchmobile.com.cn>
Reviewed by Eric Seidel.
animateTransform does not work on gradientTransform
https://bugs.webkit.org/show_bug.cgi?id=38115
Tests: svg/animations/animate-gradient-transform.html
* svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::hasValidTarget): Check if the target element is gradient.
(WebCore::transformListFor): Ditto.
(WebCore::SVGAnimateTransformElement::resetToBaseValue): Ditto.
(WebCore::SVGAnimateTransformElement::applyResultsToTarget): Ditto.
2010-05-21 Young Han Lee <joybro@company100.net>
Reviewed by Eric Seidel.
Fix guard around DatabaseSync
https://bugs.webkit.org/show_bug.cgi?id=38897
* storage/DatabaseSync.cpp:
2010-05-21 Simon Hausmann <simon.hausmann@nokia.com>
[Qt] Prospective Qt/Mac build fix
My cpp is paranoid and doesn't like #if Q_WS_MAC:
error: #if with no expression
* page/qt/EventHandlerQt.cpp:
2010-05-21 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Eric Seidel.
[EFL] Update Localized Strings. Remove markers from strings
since we are not using them and they are only polluting output.
https://bugs.webkit.org/show_bug.cgi?id=39371
No new tests required.
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::contextMenuItemTagOpenLinkInNewWindow):
(WebCore::contextMenuItemTagDownloadLinkToDisk):
(WebCore::contextMenuItemTagCopyLinkToClipboard):
(WebCore::contextMenuItemTagOpenImageInNewWindow):
(WebCore::contextMenuItemTagDownloadImageToDisk):
(WebCore::contextMenuItemTagCopyImageToClipboard):
(WebCore::contextMenuItemTagOpenFrameInNewWindow):
(WebCore::contextMenuItemTagSelectAll):
(WebCore::contextMenuItemTagUnicode):
(WebCore::contextMenuItemTagInputMethods):
(WebCore::contextMenuItemTagGoBack):
(WebCore::contextMenuItemTagGoForward):
(WebCore::contextMenuItemTagReload):
(WebCore::contextMenuItemTagIgnoreSpelling):
(WebCore::contextMenuItemTagLearnSpelling):
(WebCore::contextMenuItemTagSearchWeb):
(WebCore::contextMenuItemTagLookUpInDictionary):
(WebCore::contextMenuItemTagOpenLink):
(WebCore::contextMenuItemTagIgnoreGrammar):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagCheckSpelling):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagFontMenu):
(WebCore::contextMenuItemTagOutline):
(WebCore::contextMenuItemTagInspectElement):
(WebCore::searchMenuClearRecentSearchesText):
(WebCore::missingPluginText): Add missing message.
(WebCore::multipleFileUploadText):
(WebCore::crashedPluginText):
2010-05-21 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Eric Seidel.
[EF] Fix support for focus ring.
https://bugs.webkit.org/show_bug.cgi?id=39387
No new tests required.
* html/HTMLAnchorElement.cpp: Add EFL to #ifdef
(WebCore::HTMLAnchorElement::isMouseFocusable):
2010-05-21 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add missing localized string symbols.
https://bugs.webkit.org/show_bug.cgi?id=39394
Add missingPluginText and crashedPluginText.
* platform/brew/LocalizedStringsBrew.cpp:
(WebCore::missingPluginText):
(WebCore::crashedPluginText):
2010-05-21 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
Calls to CallJNIMethodIDA() in JavaInstance::invokeMethod() are required on Android
https://bugs.webkit.org/show_bug.cgi?id=39426
This code path has always been used by Android, but was guarded with
BUILDING_ON_TIGER in http://trac.webkit.org/changeset/55054, thus
breaking the Android build.
No new tests, build fix only.
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
2010-05-20 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
escape link text when copying or dragging links on win or chromium
https://bugs.webkit.org/show_bug.cgi?id=39413
* editing/markup.cpp:
(WebCore::urlToMarkup):
* editing/markup.h:
* platform/chromium/ClipboardUtilitiesChromium.cpp:
* platform/chromium/ClipboardUtilitiesChromium.h:
* platform/win/ClipboardUtilitiesWin.cpp:
* platform/win/ClipboardUtilitiesWin.h:
2010-05-18 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GStreamer] PlatformMedia support
https://bugs.webkit.org/show_bug.cgi?id=39300
Basic support for PlatformMedia in the gst player. The
PlatformMedia object contains a GStreamerGWorld object. That
object is empty for now. XOverlay features will be added later
on for easy review sake.
* GNUmakefile.am:
* platform/graphics/MediaPlayer.h:
(WebCore::PlatformMedia::):
* platform/graphics/gstreamer/GStreamerGWorld.cpp: Added.
(WebCore::GStreamerGWorld::createGWorld):
(WebCore::GStreamerGWorld::GStreamerGWorld):
(WebCore::GStreamerGWorld::~GStreamerGWorld):
* platform/graphics/gstreamer/GStreamerGWorld.h: Added.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::platformMedia):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2010-05-20 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add dummy SSLKeyGenerator
https://bugs.webkit.org/show_bug.cgi?id=39403
Add dummy implementation of SSLKeyGenerator.
* platform/brew/SSLKeyGeneratorBrew.cpp: Added.
(WebCore::WebCore::getSupportedKeySizes):
(WebCore::WebCore::signedPublicKeyAndChallengeString):
2010-05-20 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Dan Bernstein.
<rdar://problem/7848154> Remove the dependency on Foundation's private __COCOA_FORMAL_PROTOCOLS_2__ define.
* platform/mac/EmptyProtocolDefinitions.h:
2010-05-20 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add Editor
https://bugs.webkit.org/show_bug.cgi?id=39404
Implement Editor::newGeneralClipboard.
* editing/brew/EditorBrew.cpp: Added.
(WebCore::Editor::newGeneralClipboard):
2010-05-20 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adam Roben.
Avoid flushing CA layers when a layout is pending
https://bugs.webkit.org/show_bug.cgi?id=39463
<rdar://problem/7999463>
Avoid rendering the compositing layers to the screen if there's a layout pending,
since the layer tree not in a state that should be presented to the user.
This fixes flashes in some types of content that dynamically add and remove layers.
Do this by adding a WKCACFLayerRendererClient for WKCACFLayerRenderer, which it can
call through to ask whether now is a good time to render. If not, it schedules
another render soon.
* platform/graphics/win/WKCACFLayerRenderer.h:
(WebCore::WKCACFLayerRendererClient::~WKCACFLayerRendererClient):
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable):
(WebCore::WKCACFLayerRenderer::create):
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::render):
2010-05-20 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Don't include CoreFoundation.h when building for BREW MP
https://bugs.webkit.org/show_bug.cgi?id=39405
Add !defined(BUILDING_BREWMP__) guard for CoreFoundation.h.
* WebCorePrefix.h:
2010-05-20 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add ScrollTheme
https://bugs.webkit.org/show_bug.cgi?id=39406
As BREW MP always uses frame flattening, there is no need to render scorllbars.
Use the default scrollbar theme with thickness 0.
* platform/brew/ScrollbarThemeBrew.cpp: Added.
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeBrew::~ScrollbarThemeBrew):
* platform/brew/ScrollbarThemeBrew.h: Added.
2010-05-20 Jon Honeycutt <jhoneycutt@apple.com>
REGRESSION(r53637): DivX plug-in fails to start until window is resized
https://bugs.webkit.org/show_bug.cgi?id=39457
<rdar://problem/8006102>
Before r53637, we called Widget::move() (which caused us to call
NPP_SetWindow) before painting a plug-in. r53637 removed the call to
Widget::move(), and we end up never calling NPP_SetWindow for plug-ins
with the "DeferFirstSetWindowCall" quirk, including the DivX plug-in.
Reviewed by Simon Fraser.
* manual-tests/divx-plugin-fails-to-draw.html: Added.
* plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
Initialize new member to false.
* plugins/PluginView.h:
Added new member.
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paint):
Call setNPWindowRect() before painting to ensure that NPP_SetWindow gets
called.
(WebCore::PluginView::setNPWindowRect):
Set m_haveCalledSetWindow.
2010-05-20 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket handshake incompatible change in draft-hixie-thewebsocketprotocol-76
https://bugs.webkit.org/show_bug.cgi?id=35572
WebSocket opening handshake is changed. New protocol draft could be found at http://www.whatwg.org/specs/web-socket-protocol/
It requires https://bugs.webkit.org/show_bug.cgi?id=38034 to pass websocket tests.
* websockets/WebSocketHandshake.cpp:
(WebCore::extractResponseCode):
add lineLength parameter to return length of status line.
(WebCore::hostName): Added.
(WebCore::generateSecWebSocketKey): Added.
(WebCore::generateKey3): Added.
(WebCore::setChallengeNumber): Added.
(WebCore::generateChallengeResponseExpected): Added.
(WebCore::WebSocketHandshake::WebSocketHandshake):
generate challenge response key and expected data.
(WebCore::WebSocketHandshake::clientLocation):
use hostName.
(WebCore::WebSocketHandshake::clientHandshakeMessage):
changed for draft 76 spec.
(WebCore::WebSocketHandshake::clientHandshakeRequest):
(WebCore::WebSocketHandshake::readServerHandshake):
changed for draft 76 spec.
m_mode is managed in this method.
(WebCore::WebSocketHandshake::readHTTPHeaders):
change error log messages.
(WebCore::WebSocketHandshake::processHeaders):
chagned for draft 76 spec.
(WebCore::WebSocketHandshake::checkResponseHeaders):
return boolean whether response header is ok or not and not change m_mode in it.
* websockets/WebSocketHandshake.h:
2010-05-20 Adam Roben <aroben@apple.com>
Stop leaking all CACFContexts
Fixes <http://webkit.org/b/39466> <rdar://problem/8007141>.
Reviewed by Simon Fraser.
* platform/graphics/win/WKCACFContextFlusher.cpp:
(WebCore::WKCACFContextFlusher::addContext): Only retain the context
when we first add it to the m_contexts set. Otherwise we'll retain the
same context multiple times, causing it to leak.
2010-05-20 Young Han Lee <joybro@company100.net>
Reviewed by Darin Adler.
Create filenameFromString for all ports except GTK and EFL.
https://bugs.webkit.org/show_bug.cgi?id=39348
* platform/FileSystem.cpp: Added.
(WebCore::filenameFromString):
* platform/FileSystem.h:
2010-05-20 Young Han Lee <joybro@company100.net>
Reviewed by Darin Adler.
Port SharedBuffer to POSIX.
https://bugs.webkit.org/show_bug.cgi?id=39283
* platform/posix/SharedBufferPOSIX.cpp: Added.
(WebCore::SharedBuffer::createWithContentsOfFile):
2010-05-20 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
https://bugs.webkit.org/show_bug.cgi?id=39077
* platform/graphics/mac/GraphicsContext3DMac.cpp:
(WebCore::GraphicsContext3D::renderbufferStorage): Mapping the enums.
2010-05-20 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
<rdar://problem/8007953> Textarea using custom font appears blank
Test: fast/css/font-face-in-shadow-DOM.html
When a remote font is loaded, CSSFontSelector forces a style recalc, which replaces all
RenderSyles that have FontFallbackLists referencing the placeholder font with fresh
RenderStyles. However, it does not descend into shadow DOM trees, so those may end up with
styles that still reference the placeholder font.
The fix is to add RenderObject::requiresForcedStyleRecalcPropagation() and have it return
true from renderers that maintain shadow DOM trees or otherwise keep their own RenderStyles.
* dom/Element.cpp:
(WebCore::Element::recalcStyle): Check if forced style recalc needs to propagated.
* rendering/RenderButton.h:
(WebCore::RenderButton::requiresForcedStyleRecalcPropagation):
* rendering/RenderDataGrid.h:
(WebCore::RenderDataGrid::requiresForcedStyleRecalcPropagation):
* rendering/RenderFileUploadControl.h:
(WebCore::RenderFileUploadControl::requiresForcedStyleRecalcPropagation):
* rendering/RenderListItem.h:
(WebCore::RenderListItem::requiresForcedStyleRecalcPropagation):
* rendering/RenderMedia.h:
(WebCore::RenderMedia::requiresForcedStyleRecalcPropagation):
* rendering/RenderMenuList.h:
(WebCore::RenderMenuList::RenderMenuList::requiresForcedStyleRecalcPropagation):
* rendering/RenderObject.h:
(WebCore::RenderObject::requiresForcedStyleRecalcPropagation):
* rendering/RenderProgress.h:
(WebCore::RenderProgress::requiresForcedStyleRecalcPropagation):
* rendering/RenderSlider.h:
(WebCore::RenderSlider::requiresForcedStyleRecalcPropagation):
* rendering/RenderTextControl.h:
(WebCore::RenderTextControl::requiresForcedStyleRecalcPropagation):
2010-05-20 Jer Noble <jer.noble@apple.com>
No review; build fix only.
When WTF_USE_ACCELERATED_COMPOSITING is turned off, MediaPlayerPrivateQuickTimeVisualContext.cpp
must include CoreGraphics/CGContext.h.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
2010-05-20 Jer Noble <jer.noble@apple.com>
Reviewed by Sam Weinig.
Video elements show no video on Windows machines that do not support accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=39446
rdar://problem/7999794
Implement the paint() method in MediaPlayerPrivateQuickTimeVisualContext. The visual context should
be set up in load() and torn down in the destructor (as opposed to setUpVideoRendering and
tearDownVideoRendering, which won't get called in a non-accelerated compositing case).
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::~MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::load):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::paint):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::visualContextTimerFired):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpVideoRendering):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::tearDownVideoRendering):
2010-05-20 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Added a method to check if the security origin can access
password manager.
https://bugs.webkit.org/show_bug.cgi?id=38916
* page/SecurityOrigin.h:
(WebCore::SecurityOrigin::canAccessPasswordManager):
2010-05-20 Darin Adler <darin@apple.com>
Reviewed by Eric Seidel.
Fix warnings seen on the buildbots today
https://bugs.webkit.org/show_bug.cgi?id=39368
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::pruneUnretainedIcons): Use the type "long long" for
things being printed with "%lli". There is no guaranteed that int64_t is the
same thing as long long.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent): Added parentheses as suggested
by warnings in newer versions of GCC.
* platform/ContextMenu.cpp: Fix #if around the functions to match the #if
around the call sites to avoid unused function warning.
* platform/graphics/gtk/ImageGtk.cpp:
(WebCore::Image::loadPlatformResource): Use NULL to end a variable argument list
rather than 0. This is a case where the WebKit "use 0 instead of NULL" guideline
is incorrect and won't work properly.
* platform/win/SystemTimeWin.cpp:
(WebCore::userIdleTime): Removed unnecessary initialization of LASTINPUTINFO.
* platform/win/WebCoreInstanceHandle.h: Added property svn:eol-style.
Made functions inline instead of static. It's not correct to have functions with
internal linkage in a header file. Marking them inline makes more sense.
* plugins/win/PluginMessageThrottlerWin.cpp:
(WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin): Reordered the
initializers to match the order of the data members from the class definition.
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paintIntoTransformedContext): Initialized all the fields
of WINDOWPOS. I know this goes against the traditions of Windows programming,
but it's correct and silences the warning. Also removed the unneeded separate
code path for non-WinCE platforms that translates only the corner of the window
rectangle; the WinCE version is correct for normal Windows as well. Not sure
why this wasn't caught when the code was originally checked in.
2010-05-20 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Moving frame.src checks out of the bindings
https://bugs.webkit.org/show_bug.cgi?id=37815
Moved JavaScript frame.src checks out of bindings and into
HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
so ExecState is available inside core DOM. Updated affected bindings
(except for GObject, which will need to be updated to avoid origin
failures inside native code).
* Android.jscbindings.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
* bindings/js/JSMainThreadExecState.cpp: Added.
* bindings/js/JSMainThreadExecState.h: Added.
(WebCore::JSMainThreadExecState::currentState):
(WebCore::JSMainThreadExecState::call):
(WebCore::JSMainThreadExecState::evaluate):
(WebCore::JSMainThreadExecState::JSMainThreadExecState):
(WebCore::JSMainThreadExecState::~JSMainThreadExecState):
(WebCore::JSMainThreadNullState::JSMainThreadNullState):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::executeFunctionInContext):
(WebCore::ScheduledAction::execute):
* bindings/js/ScheduledAction.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::canAccessFromCurrentOrigin):
* bindings/js/ScriptController.h:
* bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
* bindings/objc/ObjCEventListener.mm:
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/test/ObjC/DOMTestCallback.mm:
(-[DOMTestCallback callbackWithClass1Param:]):
(-[DOMTestCallback callbackWithClass2Param:strArg:]):
(-[DOMTestCallback callbackWithNonBoolReturnType:]):
(-[DOMTestCallback customCallback:class6Param:]):
* bindings/scripts/test/ObjC/DOMTestInterface.mm:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj readOnlyIntAttr]):
(-[DOMTestObj readOnlyStringAttr]):
(-[DOMTestObj readOnlyTestObjAttr]):
(-[DOMTestObj intAttr]):
(-[DOMTestObj setIntAttr:]):
(-[DOMTestObj longLongAttr]):
(-[DOMTestObj setLongLongAttr:]):
(-[DOMTestObj unsignedLongLongAttr]):
(-[DOMTestObj setUnsignedLongLongAttr:]):
(-[DOMTestObj stringAttr]):
(-[DOMTestObj setStringAttr:]):
(-[DOMTestObj testObjAttr]):
(-[DOMTestObj setTestObjAttr:]):
(-[DOMTestObj attrWithException]):
(-[DOMTestObj setAttrWithException:]):
(-[DOMTestObj attrWithSetterException]):
(-[DOMTestObj setAttrWithSetterException:]):
(-[DOMTestObj attrWithGetterException]):
(-[DOMTestObj setAttrWithGetterException:]):
(-[DOMTestObj customAttr]):
(-[DOMTestObj setCustomAttr:]):
(-[DOMTestObj scriptStringAttr]):
(-[DOMTestObj voidMethod]):
(-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj intMethod]):
(-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj objMethod]):
(-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj methodThatRequiresAllArgs:objArg:]):
(-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]):
(-[DOMTestObj serializedValue:]):
(-[DOMTestObj methodWithException]):
(-[DOMTestObj customMethod]):
(-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj customArgsAndException:]):
(-[DOMTestObj addEventListener:listener:useCapture:]):
(-[DOMTestObj removeEventListener:listener:useCapture:]):
(-[DOMTestObj withDynamicFrame]):
(-[DOMTestObj withDynamicFrameAndArg:]):
(-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
(-[DOMTestObj withDynamicFrameAndUserGesture:]):
(-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
(-[DOMTestObj withScriptStateVoid]):
(-[DOMTestObj withScriptStateObj]):
(-[DOMTestObj withScriptStateVoidException]):
(-[DOMTestObj withScriptStateObjException]):
(-[DOMTestObj methodWithOptionalArg:]):
(-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
(-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::canAccessFromCurrentOrigin):
* bindings/v8/ScriptController.h:
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::isURLAllowed):
2010-05-20 Adam Roben <aroben@apple.com>
Fix an HRGN leak in WKCACFLayerRenderer
Fixes <http://webkit.org/b/39312> <rdar://problem/7998728> REGRESSION
(r53686-r55990): Graphics corruption when watching video (affects
youtube.com)
Reviewed by Darin Adler.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::getDirtyRects): Use an OwnPtr to hold the HRGN we allocate.
That way we don't have to remember to destroy it (as we were
forgetting to do) when we bail out of this function early.
2010-05-20 Darin Fisher <darin@chromium.org>
Reviewed by Nate Chapin.
[chromium] Provide a way to catch exceptions thrown while interacting
with a NPObject via WebBindings methods.
https://bugs.webkit.org/show_bug.cgi?id=39378
This change also includes a small bit of cleanup in V8NPObject and
friends. I moved code into the WebCore namespace where appropriate.
In _NPN_Invoke, I also moved the call to _NPN_Evaluate outside of the
context scope. I did this to avoid having nested ExceptionCatcher
objects, which is not strictly necessary, but it seemed cleaner.
_NPN_Evaluate already takes care of creating a context scope.
* bindings/v8/NPV8Object.cpp:
(WebCore::v8ObjectToNPObject):
(WebCore::npCreateV8ScriptObject):
(_NPN_Invoke):
(_NPN_InvokeDefault):
(_NPN_Evaluate):
(_NPN_EvaluateHelper):
(_NPN_GetProperty):
(_NPN_SetProperty):
(_NPN_RemoveProperty):
(_NPN_HasProperty):
(_NPN_HasMethod):
(_NPN_SetException):
(_NPN_Enumerate):
(_NPN_Construct):
* bindings/v8/NPV8Object.h:
* bindings/v8/V8NPObject.cpp:
* bindings/v8/V8NPObject.h:
* bindings/v8/V8NPUtils.cpp:
(WebCore::convertV8ObjectToNPVariant):
(WebCore::pushExceptionHandler):
(WebCore::popExceptionHandler):
(WebCore::ExceptionCatcher::ExceptionCatcher):
(WebCore::ExceptionCatcher::~ExceptionCatcher):
* bindings/v8/V8NPUtils.h:
* bindings/v8/npruntime.cpp:
2010-05-20 Marcus Bulach <bulach@chromium.org>
Reviewed by Steve Block.
Ensure timers are stopped on Geolocation::disconnectFrame()
https://bugs.webkit.org/show_bug.cgi?id=39388
fast/dom/Geolocation/notimer-after-unload.html, plus it should be possible to re-enable Gtk LayoutTests.
* page/Geolocation.cpp:
(WebCore::Geolocation::disconnectFrame):
2010-05-20 James Robinson <jamesr@chromium.org>
Reviewed by Eric Seidel.
Ensures styles are up-to-date before determining selection
https://bugs.webkit.org/show_bug.cgi?id=39389
This adds a call to document::updateStyleIfNeeded() to
Frame::notifyRendererOfSelectionChange(). Without this call, if there
is a pending style update that will detach part of the DOM and the
the selection is within that part of the DOM when
notifyRendererOfSeletionChange is called, the rootEditableElement
algorithm ends up walking through detached parts of the render tree.
Test: editing/selection/focus-and-display-none.html
* page/Frame.cpp:
(WebCore::Frame::notifyRendererOfSelectionChange):
2010-05-20 Adam Roben <aroben@apple.com>
Remove code that fetched, but did nothing useful with, a CFDictionary
in MediaPlayerPrivateQuickTimeVisualContext
I also removed the code in QTPixelBuffer that vended the dictionary.
Fixes <http://webkit.org/b/39435> <rdar://problem/8009278>
QTPixelBuffer passes CFDictionaries across the DLL boundary, which can
lead to crashes
Reviewed by Darin Adler.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage):
Deleted code that fetched the attachments dictionary, which was never
used other than to pass it to CFRetain/CFRelease, which could be
enough to cause a crash due to incompatible copies of
CoreFoundation.dll.
* platform/graphics/win/QTMovieVisualContext.h: Added a now-needed
forward declaration.
* platform/graphics/win/QTPixelBuffer.cpp:
* platform/graphics/win/QTPixelBuffer.h:
Removed the now-unused attachments function.
2010-05-20 Adam Roben <aroben@apple.com>
Fix a CFData leak in MediaPlayerPrivateQuickTimeVisualContext
Fixes <http://webkit.org/b/39432> <rdar://problem/8008992>
Reviewed by Ada Chan
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::QTCFDictionaryCreateWithDataCallback): Use a RetainPtr to
hold the CFData we allocate so it will get released when this function
is exited. Also pass kCFAllocatorNull as the bytes deallocator to
CFDataCreateWithBytesNoCopy so that CF doesn't try to deallocate the
bytes we pass to it.
2010-05-20 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
Rename GenericTask* to CrossThreadTask* in CrossThreadTask.h.
https://bugs.webkit.org/show_bug.cgi?id=39437
* dom/CrossThreadTask.h:
(WebCore::):
(WebCore::CrossThreadTask1::create):
(WebCore::CrossThreadTask1::CrossThreadTask1):
(WebCore::CrossThreadTask2::create):
(WebCore::CrossThreadTask2::CrossThreadTask2):
(WebCore::CrossThreadTask3::create):
(WebCore::CrossThreadTask3::CrossThreadTask3):
(WebCore::CrossThreadTask4::create):
(WebCore::CrossThreadTask4::CrossThreadTask4):
(WebCore::CrossThreadTask5::create):
(WebCore::CrossThreadTask5::CrossThreadTask5):
(WebCore::CrossThreadTask6::create):
(WebCore::CrossThreadTask6::CrossThreadTask6):
(WebCore::CrossThreadTask7::create):
(WebCore::CrossThreadTask7::CrossThreadTask7):
(WebCore::CrossThreadTask8::create):
(WebCore::CrossThreadTask8::CrossThreadTask8):
(WebCore::createCallbackTask):
2010-05-20 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
Rename GenericWorkerTask.h to CrossThreadTask.h and move it to dom directory.
https://bugs.webkit.org/show_bug.cgi?id=39135
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/CrossThreadTask.h: Renamed from WebCore/workers/GenericWorkerTask.h.
* html/FileStreamProxy.cpp:
* loader/WorkerThreadableLoader.cpp:
* websockets/WorkerThreadableWebSocketChannel.cpp:
* workers/DefaultSharedWorkerRepository.cpp:
* workers/WorkerMessagingProxy.cpp:
* workers/WorkerScriptLoader.cpp:
2010-05-20 Adele Peterson <adele@apple.com>
Reviewed by Mark Rowe.
Remove the Safari welcome page site-specific quirk, since its no longer needed.
* css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::cssRules):
2010-05-20 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Provide bindings for DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=39210
Tests: fast/dom/DeviceOrientation/window-property.html
fast/dom/Window/window-properties-on-device-orientation.html
Adds bindings for DeviceOrientation as defined in
http://dev.w3.org/geo/api/spec-source-orientation.html
This is guarded by ENABLE(DEVICE_ORIENTATION) which is currently disabled on
all platforms but Android.
* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* Android.mk:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
* dom/DeviceOrientationEvent.cpp: Added.
(WebCore::DeviceOrientationEvent::DeviceOrientationEvent):
(WebCore::DeviceOrientationEvent::initDeviceOrientationEvent):
* dom/DeviceOrientationEvent.h: Added.
(WebCore::DeviceOrientationEvent::create):
(WebCore::DeviceOrientationEvent::alpha):
(WebCore::DeviceOrientationEvent::beta):
(WebCore::DeviceOrientationEvent::gamma):
(WebCore::DeviceOrientationEvent::isDeviceOrientationEvent):
* dom/DeviceOrientationEvent.idl: Added.
* dom/Event.cpp:
(WebCore::Event::isDeviceOrientationEvent):
* dom/Event.h:
* dom/EventNames.h:
* page/DOMWindow.h:
* page/DOMWindow.idl:
2010-05-20 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Rubberstamped by Antti Koivisto.
Use 0.15 as text drag delay when Q_WS_MAC is defined, which is
consistent with the Mac OS X platform.
* page/qt/EventHandlerQt.cpp:
2010-05-19 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Fix painting when using clipToImageBuffer()
When we apply the transform of the parent painter to the painter of
the transparency layer, we adopt its coordinate system, thus offset
should not be in page coordinates, but in the coordinate system of
the parent painter.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::TransparencyLayer::TransparencyLayer):
2010-05-20 Adam Langley <agl@chromium.org>
Reviewed by David Levin.
[chromium] Avoid crash when msttcorefonts aren't provided
https://bugs.webkit.org/show_bug.cgi?id=39015
http://code.google.com/p/chromium/issues/detail?id=43831
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::createFontPlatformData):
2010-05-20 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Dirk Schulze.
Fix a crash caused by feLigthing::apply()
https://bugs.webkit.org/show_bug.cgi?id=39004
Make FELighting::apply() similar to other filters' applies
to avoid an assertion fail in putUnmultipliedImageData(),
when effectDrawingRect has negative location (x or y is less than 0).
Test: svg/filters/feLighting-crash.svg
* svg/graphics/filters/SVGFELighting.cpp:
(WebCore::FELighting::apply):
2010-05-20 Chris Jerdonek <cjerdonek@webkit.org>
Reviewed by Eric Seidel.
Modified FrameLoader::urlSelected() to accept a KURL instead of a
ResourceRequest.
https://bugs.webkit.org/show_bug.cgi?id=39320
Since ResourceRequest has non-explicit single-parameter constructors for
String and KURL, urlSelected() previously accepted any of String, KURL,
and ResourceRequest. This revision changes urlSelected() to accept only
a KURL to make the API tighter and easier to refactor.
No new functionality, so no new tests.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::urlSelected):
- Changed the public overload to accept a KURL instead of a ResourceRequest.
* loader/FrameLoader.h:
- Changed the public overload to accept a KURL instead of a ResourceRequest.
* wml/WMLAElement.cpp:
(WebCore::WMLAElement::defaultEventHandler):
- Updated the call to urlSelected().
2010-05-20 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
2x execCommand ReadAV@NULL
https://bugs.webkit.org/show_bug.cgi?id=35791
In applyBlockStyle(), a node which is referred from
nextParagraphStart sometimes removed from the document and goes
orphan, and that causes an assertion failed. This is because
moveParagraphs() replaces the node with a new one with some new
styles applied. So we re-compute nextParagraphStart in that case.
Test: editing/execCommand/35791.html
* dom/Position.h:
(WebCore::Position::isOrphan):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyBlockStyle):
* editing/VisiblePosition.h:
(WebCore::VisiblePosition::isOrphan):
2010-05-20 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
PluginView contains JSC-specific code
https://bugs.webkit.org/show_bug.cgi?id=38907
Build fix only, no new tests.
* plugins/PluginView.cpp:
(WebCore::PluginView::start):
(WebCore::PluginView::stop):
(WebCore::PluginView::performRequest):
* plugins/PluginView.h:
2010-05-17 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
[GStreamer] enable gst support if USE_GSTREAMER macro is defined
https://bugs.webkit.org/show_bug.cgi?id=39205
Include gstreamer private player in the build when the
USE_GSTREAMER macro is enabled.
* platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines):
2010-05-19 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Darin Fisher.
Implementing hardware accelerated compositing of layers for Chromium.
Completely removed the existing software compositing path to replace
it with code implemented using OpenGL.
https://bugs.webkit.org/show_bug.cgi?id=38783
Tests: Covered by existing compositing tests.
* WebCore.gyp/WebCore.gyp:
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::updateLayerDrawsContent):
(WebCore::GraphicsLayerChromium::updateContentsRect):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::~LayerChromium):
(WebCore::LayerChromium::updateGraphicsContext):
(WebCore::LayerChromium::drawsContentUpdated):
(WebCore::LayerChromium::updateContents):
(WebCore::LayerChromium::setContents):
(WebCore::LayerChromium::setBackingStoreSize):
(WebCore::LayerChromium::setBounds):
(WebCore::LayerChromium::setNeedsDisplay):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::contentsDirty):
(WebCore::LayerChromium::drawsContent):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::):
(WebCore::checkGLError):
(WebCore::loadShader):
(WebCore::loadShaderProgram):
(WebCore::toGLMatrix):
(WebCore::orthoMatrix):
(WebCore::createLayerTexture):
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::~LayerRendererChromium):
(WebCore::LayerRendererChromium::drawTexturedQuad):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::getTextureId):
(WebCore::LayerRendererChromium::assignTextureForLayer):
(WebCore::LayerRendererChromium::freeLayerTexture):
(WebCore::LayerRendererChromium::drawDebugBorder):
(WebCore::LayerRendererChromium::isLayerVisible):
(WebCore::LayerRendererChromium::compositeLayersRecursive):
(WebCore::LayerRendererChromium::makeContextCurrent):
(WebCore::LayerRendererChromium::initGL):
(WebCore::LayerRendererChromium::bindCommonAttribLocation):
(WebCore::LayerRendererChromium::initializeSharedGLObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::):
2010-05-19 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Timothy Hatcher.
Maintain focus on help screen while it's active.
https://bugs.webkit.org/show_bug.cgi?id=39237
* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen):
(WebInspector.HelpScreen.prototype.show):
(WebInspector.HelpScreen.prototype._hide):
(WebInspector.HelpScreen.prototype._onBlur):
2010-05-19 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Crash fix in the HistoryController.
The problem was casued by a documented feature of the QWebFrame::setHtml().
The method doesn't affect a browsing history (doesn't create a HistoryItem instance), so
m_currentItem and m_previousItem are not set.
A null check was added.
[Qt] The QWebPage crashes on history.pushState().
https://bugs.webkit.org/show_bug.cgi?id=38840
* loader/HistoryController.cpp:
(WebCore::HistoryController::pushState):
(WebCore::HistoryController::replaceState):
2010-05-19 Darin Fisher <darin@chromium.org>
Revert r59790 due to failing Chromium npruntime tests.
* bindings/v8/NPV8Object.cpp:
(v8ObjectToNPObject):
(npCreateV8ScriptObject):
(_NPN_Invoke):
(_NPN_InvokeDefault):
(_NPN_Evaluate):
(_NPN_EvaluateHelper):
(_NPN_GetProperty):
(_NPN_SetProperty):
(_NPN_RemoveProperty):
(_NPN_HasProperty):
(_NPN_HasMethod):
(_NPN_SetException):
(_NPN_Enumerate):
(_NPN_Construct):
* bindings/v8/NPV8Object.h:
* bindings/v8/V8NPObject.cpp:
(forgetV8ObjectForNPObject):
* bindings/v8/V8NPObject.h:
* bindings/v8/V8NPUtils.cpp:
(convertV8ObjectToNPVariant):
(getStringIdentifier):
* bindings/v8/V8NPUtils.h:
* bindings/v8/npruntime.cpp:
2010-05-19 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Sam Weinig.
JSFunctions are no longer a subclass of InternalFunction.
* bindings/js/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::ScriptCallStack):
(WebCore::ScriptCallStack::initialize):
* bindings/js/ScriptCallStack.h:
2010-05-19 Jian Li <jianli@chromium.org>
Reviewed by Alexey Proskuryakov.
Refactor text encoding detection logic in FileReader.
https://bugs.webkit.org/show_bug.cgi?id=39131
Changed FileReader::convertToText to call TextResourceDecoder::decode to
detect the encoding from BOM and decode the text. Though the File API
spec says that the supplied encoding should be used if it is valid, we
choose to ignore this requirement in order to be consistent with how
WebKit decodes the web content: always has the BOM override the provided
encoding.
* html/FileReader.cpp:
(WebCore::FileReader::convertToText):
* html/FileReader.h:
2010-05-19 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Check that the node is a text node before doing a static cast
to a Text class pointer.
https://bugs.webkit.org/show_bug.cgi?id=38626
Test: fast/text/text-transform-nontext-node-crash.xhtml
* rendering/RenderText.cpp:
(WebCore::RenderText::originalText):
* rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::originalText):
(WebCore::RenderTextFragment::previousCharacter):
2010-05-19 Yaar Schnitman <yaar@chromium.org>
Reviewed by Eric Seidel.
Fixed warnings by JSC overloads changes. Also updated the binding reference files for JSC.
https://bugs.webkit.org/show_bug.cgi?id=39390
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::):
2010-05-19 Darin Fisher <darin@chromium.org>
Reviewed by Nate Chapin.
[chromium] Provide a way to catch exceptions thrown while interacting
with a NPObject via WebBindings methods.
https://bugs.webkit.org/show_bug.cgi?id=39378
This change also includes a small bit of cleanup in V8NPObject and
friends. I moved code into the WebCore namespace where appropriate.
In _NPN_Invoke, I also moved the call to _NPN_Evaluate outside of the
context scope. I did this to avoid having nested ExceptionCatcher
objects, which is not strictly necessary, but it seemed cleaner.
_NPN_Evaluate already takes care of creating a context scope.
* bindings/v8/NPV8Object.cpp:
(WebCore::v8ObjectToNPObject):
(WebCore::npCreateV8ScriptObject):
(_NPN_Invoke):
(_NPN_InvokeDefault):
(_NPN_Evaluate):
(_NPN_EvaluateHelper):
(_NPN_GetProperty):
(_NPN_SetProperty):
(_NPN_RemoveProperty):
(_NPN_HasProperty):
(_NPN_HasMethod):
(_NPN_SetException):
(_NPN_Enumerate):
(_NPN_Construct):
* bindings/v8/NPV8Object.h:
* bindings/v8/V8NPObject.cpp:
* bindings/v8/V8NPObject.h:
* bindings/v8/V8NPUtils.cpp:
(WebCore::convertV8ObjectToNPVariant):
(WebCore::pushExceptionHandler):
(WebCore::popExceptionHandler):
(WebCore::ExceptionCatcher::~ExceptionCatcher):
* bindings/v8/V8NPUtils.h:
* bindings/v8/npruntime.cpp:
2010-05-19 Yaar Schnitman <yaar@chromium.org>
Unreviewed, rolling out r59769.
http://trac.webkit.org/changeset/59769
https://bugs.webkit.org/show_bug.cgi?id=37815
Broke GTK again
* Android.jscbindings.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
* bindings/js/JSMainThreadExecState.cpp: Removed.
* bindings/js/JSMainThreadExecState.h: Removed.
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::executeFunctionInContext):
(WebCore::ScheduledAction::execute):
* bindings/js/ScheduledAction.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
* bindings/js/ScriptController.h:
* bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
* bindings/objc/ObjCEventListener.mm:
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/test/ObjC/DOMTestCallback.mm:
(-[DOMTestCallback callbackWithClass1Param:]):
(-[DOMTestCallback callbackWithClass2Param:strArg:]):
(-[DOMTestCallback callbackWithNonBoolReturnType:]):
(-[DOMTestCallback customCallback:class6Param:]):
* bindings/scripts/test/ObjC/DOMTestInterface.mm:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj readOnlyIntAttr]):
(-[DOMTestObj readOnlyStringAttr]):
(-[DOMTestObj readOnlyTestObjAttr]):
(-[DOMTestObj intAttr]):
(-[DOMTestObj setIntAttr:]):
(-[DOMTestObj longLongAttr]):
(-[DOMTestObj setLongLongAttr:]):
(-[DOMTestObj unsignedLongLongAttr]):
(-[DOMTestObj setUnsignedLongLongAttr:]):
(-[DOMTestObj stringAttr]):
(-[DOMTestObj setStringAttr:]):
(-[DOMTestObj testObjAttr]):
(-[DOMTestObj setTestObjAttr:]):
(-[DOMTestObj attrWithException]):
(-[DOMTestObj setAttrWithException:]):
(-[DOMTestObj attrWithSetterException]):
(-[DOMTestObj setAttrWithSetterException:]):
(-[DOMTestObj attrWithGetterException]):
(-[DOMTestObj setAttrWithGetterException:]):
(-[DOMTestObj customAttr]):
(-[DOMTestObj setCustomAttr:]):
(-[DOMTestObj scriptStringAttr]):
(-[DOMTestObj voidMethod]):
(-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj intMethod]):
(-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj objMethod]):
(-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj methodThatRequiresAllArgs:objArg:]):
(-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]):
(-[DOMTestObj serializedValue:]):
(-[DOMTestObj methodWithException]):
(-[DOMTestObj customMethod]):
(-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj customArgsAndException:]):
(-[DOMTestObj addEventListener:listener:useCapture:]):
(-[DOMTestObj removeEventListener:listener:useCapture:]):
(-[DOMTestObj withDynamicFrame]):
(-[DOMTestObj withDynamicFrameAndArg:]):
(-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
(-[DOMTestObj withDynamicFrameAndUserGesture:]):
(-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
(-[DOMTestObj withScriptStateVoid]):
(-[DOMTestObj withScriptStateObj]):
(-[DOMTestObj withScriptStateVoidException]):
(-[DOMTestObj withScriptStateObjException]):
(-[DOMTestObj methodWithOptionalArg:]):
(-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
(-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
* bindings/v8/ScriptController.cpp:
* bindings/v8/ScriptController.h:
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::isURLAllowed):
2010-05-19 Dirk Pranke <dpranke@chromium.org>
Try again to roll out r58675.
* notifications/Notification.h:
* notifications/Notification.idl:
2010-05-19 Enrica Casucci <enrica@apple.com>
Reviewed by Dave Hyatt.
REGRESSION (r59385) crash destroying inline renderers
https://bugs.webkit.org/show_bug.cgi?id=39143
<rdar://problem/8003662>
The goal of r59385 was to make sure that the layout of block after all its children had been removed produced the identical result
as the one of a newly created empty block. In order to do so, we had to make sure that the m_inlineChildren flag was reset to true when
the block had no children (as it is upon creation).
I discovered that, by doing that for anonymous blocks it leads removeChild to conclude that the anonymous children can be removed,
without considering that the anonymous block could be part of a continuation chain. For this reason, when RenderInline::destroy()
tries to remove the continuations we are effectively deleting a renderer that had been deleted already.
Test: fast/inline-block/anonymous-block-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock): resetting the flag m_inlineChildren only for non anonymous blocks otherwise we incurr in
a double deletion of the renderer that causes the crash.
2010-05-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r59782.
http://trac.webkit.org/changeset/59782
https://bugs.webkit.org/show_bug.cgi?id=39379
broke DRT build (Requested by dpranke on #webkit).
* notifications/Notification.h:
(WebCore::Notification::dir):
(WebCore::Notification::setDir):
(WebCore::Notification::replaceId):
(WebCore::Notification::setReplaceId):
* notifications/Notification.idl:
2010-05-18 David Hyatt <hyatt@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=21049, opacity and position:relative fail in multi-column layouts.
Make layers split painting across columns just as normal flow content does. This is actually very
challenging, since intermediate multicol layers can exist between a child that has to be split and
its enclosing stacking context.
In order to properly paginate layers, a bit is set on all pagination roots, i.e., layers that will get
split and thus split any descendant layers that they are also responsible for painting. For a paginated
root, we walk up the layer hierarchy and collect all intermediate multicol blocks between the child
and the enclosing stacking context.
We then recur from the outside in, applying clipping and translation as we break up the layer into strips.
Composited layers remain unsplittable and have a hacked offset still in order to be placed in the right
column.
Painting and hit testing of columns has been simplified in all of the functions to use the x position of
the column rect instead of trying to increment an x offset by adding in widths and column gaps. This
makes those functions directionality-independent (and the LTR/RTL code paths are now the same).
Fix repainting of columns as well to make sure rects are split across columns only after relative position
and transforms have been applied.
Added fast/multicol/layers-split-across-columns.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::adjustForColumns):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updatePagination):
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::paintPaginatedChildLayer):
(WebCore::RenderLayer::paintChildLayerIntoColumns):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::hitTestPaginatedChildLayer):
(WebCore::RenderLayer::hitTestChildLayerColumns):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::):
(WebCore::RenderLayer::isPaginated):
2010-05-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Attempt to revert r58765 to see if it was causing a performance
regression.
https://bugs.webkit.org/show_bug.cgi?id=39328
* notifications/Notification.h:
* notifications/Notification.idl:
2010-05-19 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Kevin Ollivier.
[wx] Ensure m_nsFont is initialized properly, and tweak fallback font handling
to handle more cases.
https://bugs.webkit.org/show_bug.cgi?id=39365
* platform/graphics/wx/FontCacheWx.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/wx/FontPlatformDataWx.cpp:
(WebCore::FontPlatformData::FontPlatformData):
2010-05-19 Marcus Bulach <bulach@chromium.org>
Reviewed by Eric Seidel.
Fixes Windows Qt Release post r59772.
https://bugs.webkit.org/show_bug.cgi?id=39369
* platform/GeolocationService.cpp:
2010-05-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add support for handling basic <script> tags in the HTML5 Parser
https://bugs.webkit.org/show_bug.cgi?id=39350
WebKit currently executes scripts from HTMLTokenizer in one giagantic
hack. HTML 5 requires that we execute scripts from the tree-builders/parser.
It will take me a while to re-factor enough of HTMLTokenizer to be able to
move the script execution logic without breaking things. In the interest
of allowing Adam to continue improving the HTML 5 lexer I've added this
very basic (and very incomplete) <script> support to the HTML 5 parser code
path so the he can run the HTML5 parser test suite.
<script> support is tested by most of the layout tests.
* dom/ScriptElement.cpp:
(WebCore::useHTML5Parser):
(WebCore::ScriptElement::finishParsingChildren):
2010-05-19 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Move member variables from NamedMappedAttrMap to its base class NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=39367
<rdar://problem/8003304>
This lets us get rid of the vtable pointer in NamedNodeMap which saves 8 bytes, and also allows us to
fit the m_mappedAttributeCount unsigned int in the RefCounted padding (in 64-bit).
The net result is that we shrink the NamedMappedAttrMap size by 16 bytes, while keeping the size of NamedNodeMap the same.
* dom/Element.cpp:
(WebCore::Element::createAttributeMap):
* dom/Element.h:
* dom/NamedMappedAttrMap.cpp:
* dom/NamedMappedAttrMap.h:
(WebCore::NamedMappedAttrMap::NamedMappedAttrMap):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::clearAttributes):
* dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::NamedNodeMap):
* dom/Node.cpp:
(WebCore::Node::dumpStatistics):
* dom/StyledElement.cpp:
* dom/StyledElement.h:
2010-05-19 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Use ASSERT_UNUSED instead of UNUSED_PARAM.
* dom/Attribute.cpp:
(WebCore::Attribute::unbindAttr):
2010-05-19 Sam Weinig <sam@webkit.org>
Rubber-stamped by Anders Carlsson.
Complete the merge of MappedAttribute and Attribute.
Files elided for brevity.
2010-05-19 Marcus Bulach <bulach@chromium.org>
Reviewed by Steve Block.
[chromium] Adds supports for layout tests using GeolocationServiceMock.
https://bugs.webkit.org/show_bug.cgi?id=39081
Allows injection of GeolocationServiceMock factory.
Tests: existing fast/dom/Geolocation/*
* platform/GeolocationService.cpp:
(WebCore::GeolocationService::useMock):
(WebCore::GeolocationService::useMockFactory):
* platform/GeolocationService.h:
* platform/chromium/GeolocationServiceChromium.cpp:
(WebCore::GeolocationServiceChromium::GeolocationServiceChromium):
2010-05-19 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Moving frame.src checks out of the bindings
https://bugs.webkit.org/show_bug.cgi?id=37815
Moved JavaScript frame.src checks out of bindings and into
HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
so ExecState is available inside core DOM. Updated affected bindings
(except for GObject, which will need to be updated to avoid origin
failures inside native code).
* Android.jscbindings.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
* bindings/js/JSMainThreadExecState.cpp: Added.
* bindings/js/JSMainThreadExecState.h: Added.
(WebCore::JSMainThreadExecState::currentState):
(WebCore::JSMainThreadExecState::call):
(WebCore::JSMainThreadExecState::evaluate):
(WebCore::JSMainThreadExecState::JSMainThreadExecState):
(WebCore::JSMainThreadExecState::~JSMainThreadExecState):
(WebCore::JSMainThreadNullState::JSMainThreadNullState):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::executeFunctionInContext):
(WebCore::ScheduledAction::execute):
* bindings/js/ScheduledAction.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::canAccessFromCurrentOrigin):
* bindings/js/ScriptController.h:
* bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
* bindings/objc/ObjCEventListener.mm:
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/test/ObjC/DOMTestCallback.mm:
(-[DOMTestCallback callbackWithClass1Param:]):
(-[DOMTestCallback callbackWithClass2Param:strArg:]):
(-[DOMTestCallback callbackWithNonBoolReturnType:]):
(-[DOMTestCallback customCallback:class6Param:]):
* bindings/scripts/test/ObjC/DOMTestInterface.mm:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj readOnlyIntAttr]):
(-[DOMTestObj readOnlyStringAttr]):
(-[DOMTestObj readOnlyTestObjAttr]):
(-[DOMTestObj intAttr]):
(-[DOMTestObj setIntAttr:]):
(-[DOMTestObj longLongAttr]):
(-[DOMTestObj setLongLongAttr:]):
(-[DOMTestObj unsignedLongLongAttr]):
(-[DOMTestObj setUnsignedLongLongAttr:]):
(-[DOMTestObj stringAttr]):
(-[DOMTestObj setStringAttr:]):
(-[DOMTestObj testObjAttr]):
(-[DOMTestObj setTestObjAttr:]):
(-[DOMTestObj attrWithException]):
(-[DOMTestObj setAttrWithException:]):
(-[DOMTestObj attrWithSetterException]):
(-[DOMTestObj setAttrWithSetterException:]):
(-[DOMTestObj attrWithGetterException]):
(-[DOMTestObj setAttrWithGetterException:]):
(-[DOMTestObj customAttr]):
(-[DOMTestObj setCustomAttr:]):
(-[DOMTestObj scriptStringAttr]):
(-[DOMTestObj voidMethod]):
(-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj intMethod]):
(-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj objMethod]):
(-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj methodThatRequiresAllArgs:objArg:]):
(-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]):
(-[DOMTestObj serializedValue:]):
(-[DOMTestObj methodWithException]):
(-[DOMTestObj customMethod]):
(-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj customArgsAndException:]):
(-[DOMTestObj addEventListener:listener:useCapture:]):
(-[DOMTestObj removeEventListener:listener:useCapture:]):
(-[DOMTestObj withDynamicFrame]):
(-[DOMTestObj withDynamicFrameAndArg:]):
(-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
(-[DOMTestObj withDynamicFrameAndUserGesture:]):
(-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
(-[DOMTestObj withScriptStateVoid]):
(-[DOMTestObj withScriptStateObj]):
(-[DOMTestObj withScriptStateVoidException]):
(-[DOMTestObj withScriptStateObjException]):
(-[DOMTestObj methodWithOptionalArg:]):
(-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
(-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::canAccessFromCurrentOrigin):
* bindings/v8/ScriptController.h:
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::isURLAllowed):
2010-05-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Darin Adler.
CanvasRenderingContext2D's property getters that return colors should
serialize them in accordance with the HTML5 spec (4.8.11.1.4)
Setters should ignore invalid colors.
Also, shadowColor should initially be transparent black (4.8.11.1.6)
https://bugs.webkit.org/show_bug.cgi?id=38845
Refactored CanvasStyle to store an RGBA32 instead of RGBA components and/or the color string.
Spec links:
http://www.whatwg.org/specs/web-apps/current-work/#serialization-of-a-color
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-shadowcolor
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::shadowColor):
(WebCore::CanvasRenderingContext2D::setShadowColor):
(WebCore::CanvasRenderingContext2D::setShadow):
(WebCore::CanvasRenderingContext2D::clearShadow):
(WebCore::CanvasRenderingContext2D::applyShadow):
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::CanvasStyle):
(WebCore::CanvasStyle::create):
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):
* html/canvas/CanvasStyle.h:
(WebCore::CanvasStyle::create):
(WebCore::CanvasStyle::color):
(WebCore::CanvasStyle::):
(WebCore::CanvasStyle::CMYKAValues::CMYKAValues):
* platform/graphics/Color.cpp:
(WebCore::Color::serialized):
* platform/graphics/Color.h:
2010-05-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] REGRESSION: CoolClock isn't rendered properly
https://bugs.webkit.org/show_bug.cgi?id=38526
CanvasRenderingContext2D's arc() should connect to the previous point
with a straight line (HTML5 spec 4.8.11.1.8), but if the path is empty
to begin with, we don't want a line back to (0,0)
This also fixes the rendering artifact discussed in bug 36226.
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arc
Test: fast/canvas/canvas-arc-connecting-line.html
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::addArc):
2010-05-19 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Jeremy Orlow.
Fix whitespace for the bug 38906
https://bugs.webkit.org/show_bug.cgi?id=39351
No new tests required (no code change).
* css/CSSParser.cpp:
(WebCore::CSSParser::~CSSParser):
(WebCore::CSSParser::setupParser):
(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSelector):
(WebCore::unitFromString):
(WebCore::CSSParser::checkForOrphanedUnits):
(WebCore::CSSParser::parseWCSSInputProperty):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseShorthand):
(WebCore::CSSParser::parse4Values):
(WebCore::CSSParser::parseAttr):
(WebCore::CSSParser::parseFillPositionXY):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseShape):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseFontFamily):
(WebCore::CSSParser::parseFontFaceSrc):
(WebCore::parseInt):
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::parseShadow):
(WebCore::CSSParser::parseReflect):
(WebCore::BorderImageParseContext::commitNumber):
(WebCore::BorderImageParseContext::commitBorderImage):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseCounter):
(WebCore::parseGradientPoint):
(WebCore::parseGradientColorStop):
(WebCore::CSSParser::parseGradient):
(WebCore::CSSParser::parseCanvas):
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::parsePerspectiveOrigin):
(WebCore::CSSParser::text):
(WebCore::CSSParser::createRuleList):
(WebCore::CSSParser::createVariablesRule):
(WebCore::CSSParser::parseVariable):
(WebCore::CSSParser::parsePropertyWithResolvedVariables):
(WebCore::CSSParser::checkForVariables):
(WebCore::CSSParser::createKeyframeRule):
* css/CSSParser.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::setFrontend):
(WebCore::InspectorController::show):
(WebCore::InspectorController::unbindAllResources):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::scriptImported):
(WebCore::InspectorController::getCurrentUserInitiatedProfileName):
(WebCore::InspectorController::removeBreakpoint):
(WebCore::drawOutlinedQuad):
(WebCore::InspectorController::stopTiming):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
(WebCore::InspectorDOMAgent::getStyles):
(WebCore::InspectorDOMAgent::applyStyleText):
2010-05-19 Steve Block <steveblock@google.com>
Reviewed by Nate Chapin.
V8 code generator does not add ENABLE guards around attribute getters and setters
https://bugs.webkit.org/show_bug.cgi?id=39222
No new tests, build fix only.
* bindings/scripts/CodeGeneratorV8.pm:
2010-05-19 Jeremy Orlow <jorlow@chromium.org>
Unreviewed build fix for Chromium.
* storage/IndexedDatabaseImpl.cpp:
2010-05-17 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Hook Chromium's WebIndexedDatabaseImpl up to IndexedDatabaseImpl
https://bugs.webkit.org/show_bug.cgi?id=39216
All of these functions are supposed to be passing around the origin since
the caller of IndexedDatabaseImpl might not be able to pass in a Frame*
object. I tried to fix this in an ealier patch, but obviously messed up.
Also change passing security origin strings to passing SecurityOrigin
objects.
No behavior change because Chromium was emulating the old behavior before
even though the code wasn't properly hooked up.
* storage/IndexedDatabase.h:
* storage/IndexedDatabaseImpl.cpp:
(WebCore::IndexedDatabaseImpl::open):
* storage/IndexedDatabaseImpl.h:
* storage/IndexedDatabaseRequest.cpp:
(WebCore::IndexedDatabaseRequest::open):
2010-05-19 Ben Murdoch <benm@google.com>
Reviewed by Darin Adler.
Touch events are marked DontEnum in DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=39118
Touch events are the only attribute event listeners on the
window object that are marked DontEnum. For consistency allow
them to be enumerated.
* page/DOMWindow.idl: Remove DontEnum from touchcancel, touchend,
touchstart and touchmove attributes.
2010-05-19 Simon Hausmann <simon.hausmann@nokia.com>
[Qt] Fix build warning
NamedAttrMap.h has been renamed to NamedNodeMap.h
* WebCore.pro:
2010-05-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add an HTML parsing benchmark
https://bugs.webkit.org/show_bug.cgi?id=39338
This benchmark parses the HTML5 specification 10 times and
reports how long it takes. It does this 21 times, discarding
the first warm-up run, and then prints the average time and
standard deviation.
Sharking the benchmark correctly shows over 60% of the time spent under HTMLTokenizer::write().
The numbers from the benchmark are rather consistent. On my
Mac Book Pro, I consistently see standard deviations < 2% of total time.
* benchmarks/parser/html-parser.html: Added.
* benchmarks/parser/resources/html5.html: Added.
2010-05-18 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
Make CSS Parser properly handle only-for-pages pseudo-classes.
A new Match category, PagePseudoClass, is introduced to distinguish
only-for-pages pseudo-classes from others. A new symbol, pseudo_page,
is introduced to handle them separately.
https://bugs.webkit.org/show_bug.cgi?id=38731
* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::createMarginAtRule):
* css/CSSParser.h:
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
(WebCore::CSSSelector::selectorText):
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
2010-05-19 Adam Barth <abarth@webkit.org>
Reviewed by David Hyatt.
Change the API of nextToken to distinguish between emitting a token and just running out of input
https://bugs.webkit.org/show_bug.cgi?id=39349
I'm not sure there's a functional difference with this patch yet, but
as discussed with Eric, we need this to handle attributes.
* html/HTML5Lexer.cpp:
(WebCore::HTML5Lexer::reset):
(WebCore::HTML5Lexer::nextToken):
* html/HTML5Lexer.h:
* html/HTML5Token.h:
(WebCore::HTML5Token::HTML5Token):
(WebCore::HTML5Token::clear):
(WebCore::HTML5Token::beginStartTag):
(WebCore::HTML5Token::beginEndTag):
(WebCore::HTML5Token::beginCharacter):
* html/HTML5Tokenizer.cpp:
(WebCore::HTML5Tokenizer::write):
2010-05-18 Eric Seidel <eric@webkit.org>
Reviewed by Maciej Stachowiak.
Refactor HTMLTokenizer::write to make it more readable and split out the lexer bits from flow control bits
https://bugs.webkit.org/show_bug.cgi?id=39318
No functional changes, only moving code into smaller functions.
This code is already covered by numerous layout tests.
HTML parsing benchmark shows this to be a wash.
* dom/Tokenizer.h:
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::advance):
- New funtion to encapulate code which will move into HTMLLexer eventually.
- Use ALWAYS_INLINE to make sure compilers inline this large
function (otherwise this patch is a regression).
(WebCore::HTMLTokenizer::willWriteHTML):
- New function to handle calling any pre-write delegates.
(WebCore::HTMLTokenizer::didWriteHTML):
- New function to handle calling any post-write delegates.
(WebCore::HTMLTokenizer::write):
- Call the new functions.
* html/HTMLTokenizer.h:
2010-05-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make the HTML5 parser correctly parse <div>Hello</div>
https://bugs.webkit.org/show_bug.cgi?id=39345
Again, this patch is covered by a large number of LayoutTests.
* html/HTML5Lexer.cpp:
(WebCore::HTML5Lexer::HTML5Lexer):
(WebCore::HTML5Lexer::reset):
(WebCore::HTML5Lexer::nextToken):
(WebCore::HTML5Lexer::emitCommentToken):
(WebCore::HTML5Lexer::emitCharacter):
(WebCore::HTML5Lexer::emitCurrentTagToken):
* html/HTML5Lexer.h:
* html/HTML5Token.h:
(WebCore::HTML5Token::beginCharacter):
(WebCore::HTML5Token::appendToCharacter):
(WebCore::HTML5Token::characters):
* html/HTML5Tokenizer.cpp:
(WebCore::convertToOldStyle):
2010-05-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make the HTML5 parser actually parse <div></div>
https://bugs.webkit.org/show_bug.cgi?id=39342
This patch is covered by every LayoutTest. Yes. All of them. :)
* html/HTML5Lexer.cpp:
(WebCore::toLowerCase):
(WebCore::HTML5Lexer::HTML5Lexer):
(WebCore::HTML5Lexer::nextToken):
(WebCore::HTML5Lexer::emitCharacter):
* html/HTML5Lexer.h:
* html/HTML5Token.h:
(WebCore::HTML5Token::HTML5Token):
(WebCore::HTML5Token::beginStartTag):
(WebCore::HTML5Token::beginEndTag):
(WebCore::HTML5Token::appendToName):
(WebCore::HTML5Token::type):
(WebCore::HTML5Token::name):
(WebCore::HTML5Token::selfClosing):
(WebCore::HTML5Token::attrs):
* html/HTML5Tokenizer.cpp:
(WebCore::convertToOldStyle):
(WebCore::HTML5Tokenizer::write):
2010-05-18 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
REGRESSION: crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting in an empty li
https://bugs.webkit.org/show_bug.cgi?id=38232
Test: editing/execCommand/crash-indenting-list-item.html
* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::tryIndentingAsListItem):
(WebCore::IndentOutdentCommand::indentIntoBlockquote):
2010-05-18 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
':optional' pseudo selector should not be applied to <keygen> and <progress>
https://bugs.webkit.org/show_bug.cgi?id=39292
Test: fast/css/pseudo-required-optional-unapplied.html
* html/HTMLKeygenElement.h:
(WebCore::HTMLKeygenElement::isOptionalFormControl):
Add isOptionalFormControl() returning false.
HTMLKeygenElement inherits HTMLSelectElement, which should return true
for isOptionalFormControl(). However, <keygen> is not :optional
according to the standard.
* html/HTMLProgressElement.h:
Remove isOptionalFormControl().
2010-05-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement the DOCTYPE states for the HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=39335
* html/HTML5Lexer.cpp:
(WebCore::HTML5Lexer::nextToken):
(WebCore::emitCurrentDoctypeToken):
* html/HTML5Lexer.h:
2010-05-18 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] ignore IME events if the keydown event was prevented
https://bugs.webkit.org/show_bug.cgi?id=37692
A manual test to verify the IME behavior since the existing methods of
textInputController test at a lower level than the fix.
* manual-tests/ime-keydown-preventdefault.html: Added.
2010-05-18 Sam Weinig <sam@webkit.org>
Fix the build for platforms that don't always include UnusedParam.h
* dom/Attribute.cpp:
2010-05-18 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
[Chromium] Windows: Determinate progress bar should have glossy overlay
https://bugs.webkit.org/show_bug.cgi?id=39269
- Moved animation code from RenderThemeChromiumWin to chromium tree
because it should be behind the theme implementation, which lives
in chromium tree.
- Passed current time to the bridge, which will be used to compute
the state of the theme animation.
No new tests, animation effect can be confirmed only manually.
* platform/chromium/ChromiumBridge.h:
* rendering/RenderProgress.h:
(WebCore::RenderProgress::animationStartTime): Added.
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::RenderThemeChromiumWin::animationDurationForProgressBar):
(WebCore::RenderThemeChromiumWin::paintProgressBar):
2010-05-18 Sam Weinig <sam@webkit.org>
Fix release build.
* dom/Attribute.cpp:
(WebCore::Attribute::unbindAttr):
2010-05-18 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Move Attr pointer from Attribute to a global HashMap.
https://bugs.webkit.org/show_bug.cgi?id=39337
<rdar://problem/8001168>
Shaves another word off of Attribute.
* dom/Attr.cpp:
(WebCore::Attr::Attr):
(WebCore::Attr::~Attr):
* dom/Attribute.cpp:
(WebCore::attributeAttrMap):
(WebCore::Attribute::attr):
(WebCore::Attribute::createAttrIfNeeded):
(WebCore::Attribute::bindAttr):
(WebCore::Attribute::unbindAttr):
* dom/Attribute.h:
(WebCore::Attribute::Attribute):
2010-05-18 Jakob Petsovits <jpetsovits@rim.com>
Unreviewed, forgot to svn add source file in r59619.
http://trac.webkit.org/changeset/59619
* platform/image-decoders/openvg: Added.
* platform/image-decoders/openvg/ImageDecoderOpenVG.cpp: Added.
(WebCore::RGBA32Buffer::asNewNativeImage):
2010-05-18 Yaar Schnitman <yaar@chromium.org>
Unreviewed, rolling out r59693.
http://trac.webkit.org/changeset/59693
https://bugs.webkit.org/show_bug.cgi?id=37815
Broke GTK Release
* Android.jscbindings.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
* bindings/js/JSMainThreadExecState.cpp: Removed.
* bindings/js/JSMainThreadExecState.h: Removed.
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::executeFunctionInContext):
(WebCore::ScheduledAction::execute):
* bindings/js/ScheduledAction.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
* bindings/js/ScriptController.h:
* bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
* bindings/objc/ObjCEventListener.mm:
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/test/ObjC/DOMTestCallback.mm:
(-[DOMTestCallback callbackWithClass1Param:]):
(-[DOMTestCallback callbackWithClass2Param:strArg:]):
(-[DOMTestCallback callbackWithNonBoolReturnType:]):
(-[DOMTestCallback customCallback:class6Param:]):
* bindings/scripts/test/ObjC/DOMTestInterface.mm:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj readOnlyIntAttr]):
(-[DOMTestObj readOnlyStringAttr]):
(-[DOMTestObj readOnlyTestObjAttr]):
(-[DOMTestObj intAttr]):
(-[DOMTestObj setIntAttr:]):
(-[DOMTestObj longLongAttr]):
(-[DOMTestObj setLongLongAttr:]):
(-[DOMTestObj unsignedLongLongAttr]):
(-[DOMTestObj setUnsignedLongLongAttr:]):
(-[DOMTestObj stringAttr]):
(-[DOMTestObj setStringAttr:]):
(-[DOMTestObj testObjAttr]):
(-[DOMTestObj setTestObjAttr:]):
(-[DOMTestObj attrWithException]):
(-[DOMTestObj setAttrWithException:]):
(-[DOMTestObj attrWithSetterException]):
(-[DOMTestObj setAttrWithSetterException:]):
(-[DOMTestObj attrWithGetterException]):
(-[DOMTestObj setAttrWithGetterException:]):
(-[DOMTestObj customAttr]):
(-[DOMTestObj setCustomAttr:]):
(-[DOMTestObj scriptStringAttr]):
(-[DOMTestObj voidMethod]):
(-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj intMethod]):
(-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj objMethod]):
(-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj methodThatRequiresAllArgs:objArg:]):
(-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]):
(-[DOMTestObj serializedValue:]):
(-[DOMTestObj methodWithException]):
(-[DOMTestObj customMethod]):
(-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj customArgsAndException:]):
(-[DOMTestObj addEventListener:listener:useCapture:]):
(-[DOMTestObj removeEventListener:listener:useCapture:]):
(-[DOMTestObj withDynamicFrame]):
(-[DOMTestObj withDynamicFrameAndArg:]):
(-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
(-[DOMTestObj withDynamicFrameAndUserGesture:]):
(-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
(-[DOMTestObj withScriptStateVoid]):
(-[DOMTestObj withScriptStateObj]):
(-[DOMTestObj withScriptStateVoidException]):
(-[DOMTestObj withScriptStateObjException]):
(-[DOMTestObj methodWithOptionalArg:]):
(-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
(-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
* bindings/v8/ScriptController.cpp:
* bindings/v8/ScriptController.h:
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::isURLAllowed):
2010-05-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement comment states for HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=39334
* html/HTML5Lexer.cpp:
(WebCore::HTML5Lexer::nextToken):
2010-05-18 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Move all member variables from MappedAttribute to Attribute.
https://bugs.webkit.org/show_bug.cgi?id=39336
<rdar://problem/8000853>
This saves one word because we no longer have any virtual member functions in Attribute, and
thus no vtable pointer.
I plan to remove MappedAttribute altogether in a subsequent commit.
* Android.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForElement):
* dom/Attribute.cpp:
(WebCore::Attribute::clone):
* dom/Attribute.h:
(WebCore::Attribute::create):
(WebCore::Attribute::style):
(WebCore::Attribute::decl):
(WebCore::Attribute::setDecl):
(WebCore::Attribute::isMappedAttribute):
(WebCore::Attribute::Attribute):
* dom/MappedAttribute.cpp: Removed.
* dom/MappedAttribute.h:
(WebCore::MappedAttribute::create):
(WebCore::MappedAttribute::MappedAttribute):
(WebCore::toMappedAttribute):
* dom/NamedMappedAttrMap.cpp:
(WebCore::NamedMappedAttrMap::declCount):
(WebCore::NamedMappedAttrMap::mapsEquivalent):
* dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):
* svg/SVGSVGElement.cpp:
(WebCore::updateCSSForAttribute):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::getPresentationAttribute):
2010-05-18 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=24943
Command-B and Command-I do not generate keydown events in contentEditable regions.
* manual-tests/style-keypress-events.html: Added.
2010-05-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add more state to the HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=39333
This code is just transliteration from the spec.
* html/HTML5Lexer.cpp:
(WebCore::HTML5Lexer::HTML5Lexer):
(WebCore::HTML5Lexer::nextToken):
* html/HTML5Lexer.h:
2010-05-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement two more lexer states
https://bugs.webkit.org/show_bug.cgi?id=39298
No tests because Eric is still working on wiring up the lexer to the
test harness.
* html/HTML5Lexer.cpp:
(WebCore::HTML5Lexer::nextToken):
(WebCore::HTML5Lexer::emitParseError):
(WebCore::HTML5Lexer::emitCurrentTagToken):
* html/HTML5Lexer.h:
2010-05-18 Brady Eidson <beidson@apple.com>
Reviewed by Maciej Stachowiak.
Repro crash with many Google image search results
<rdar://problem/7685669> and https://bugs.webkit.org/show_bug.cgi?id=39323
When an iframe has a plugin resource as its src, that case bypassed the plugin sandboxing checks and continued to load
the data for the plugin resource. It handed that data off to a nonexistent Widget, causing a null deref and the crash.
By replacing PluginDocuments in sandboxes iframes with a new "SinkDocument" that just acts as a data sink, we prevent the
crash and also prevent actually loading the plugin binaries.
I filed https://bugs.webkit.org/show_bug.cgi?id=39330 to follow up and let us cancel the load as soon as we know we should.
Test: fast/loader/sandboxed-plugin-crash.html
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin): If the created document is a PluginDocument and the plugin sandbox flag is set,
replace it with a SinkDocument.
* loader/PluginDocument.h:
(WebCore::PluginDocument::isPluginDocument): Make public (it was already public at the Document.h level).
Add a simple document/tokenizer pair that simply presents a blank HTML document and acts as a data sink for whatever
data is handed to it:
* loader/SinkDocument.cpp: Added.
(WebCore::SinkTokenizer::SinkTokenizer):
(WebCore::SinkTokenizer::write):
(WebCore::SinkTokenizer::isWaitingForScripts):
(WebCore::SinkTokenizer::wantsRawData):
(WebCore::SinkTokenizer::writeRawData):
(WebCore::SinkTokenizer::stopParsing):
(WebCore::SinkTokenizer::finish):
(WebCore::SinkDocument::SinkDocument):
(WebCore::SinkDocument::createTokenizer):
* loader/SinkDocument.h: Added.
(WebCore::SinkDocument::create):
2010-05-18 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=39321
Reduce the size of ListHashSets used by Document
<rdar://problem/7999388>
Reduce Membuster peak memory usage by ~450K by reducing the pool sizes
of the ListHashSets used by Document.
* dom/Document.cpp:
(WebCore::Document::addStyleSheetCandidateNode):
(WebCore::Document::recalcStyleSelector):
* dom/Document.h:
2010-05-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
Rubberstamped by Simon Hausmann.
Return null when creating an ImageBuffer failed, due to for
instance a nulled pixmap.
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::ImageBuffer):
2010-05-18 Jian Li <jianli@chromium.org>
Reviewed by Dmitry Titov.
Fix bug 39285: fast/files/file-reader.html is timing out on all mac bots.
https://bugs.webkit.org/show_bug.cgi?id=39285
The timeout is caused by 59659 that changed the GC timer to 0 and thus
triggered a bug in FileReader code. The fix is to add more states so
that hasPendingActivity() can do the check correctly.
* html/FileReader.cpp:
(WebCore::FileReader::FileReader):
(WebCore::FileReader::hasPendingActivity):
(WebCore::FileReader::readInternal):
(WebCore::FileReader::terminate):
(WebCore::FileReader::didStart):
(WebCore::FileReader::didGetSize):
(WebCore::FileReader::didRead):
(WebCore::FileReader::didFinish):
(WebCore::FileReader::didFail):
(WebCore::FileReader::readyState):
(WebCore::FileReader::result):
* html/FileReader.h:
(WebCore::FileReader::):
2010-05-18 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Clean up GraphicsLayer naming code
https://bugs.webkit.org/show_bug.cgi?id=39316
Move code that generates a name for the GraphicsLayer (used in debug builds only) into
a new nameForLayer() method. Use it when naming the foreground layer.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createGraphicsLayer):
(WebCore::RenderLayerBacking::updateForegroundLayer):
(WebCore::RenderLayerBacking::nameForLayer):
* rendering/RenderLayerBacking.h:
2010-05-18 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Moving frame.src checks out of the bindings
https://bugs.webkit.org/show_bug.cgi?id=37815
Moved JavaScript frame.src checks out of bindings and into
HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
so ExecState is available inside core DOM. Updated affected bindings
(except for GObject, which will need to be updated to avoid origin
failures inside native code).
* Android.jscbindings.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
* bindings/js/JSMainThreadExecState.cpp: Added.
* bindings/js/JSMainThreadExecState.h: Added.
(WebCore::JSMainThreadExecState::currentState):
(WebCore::JSMainThreadExecState::call):
(WebCore::JSMainThreadExecState::evaluate):
(WebCore::JSMainThreadExecState::JSMainThreadExecState):
(WebCore::JSMainThreadExecState::~JSMainThreadExecState):
(WebCore::JSMainThreadNullState::JSMainThreadNullState):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::executeFunctionInContext):
(WebCore::ScheduledAction::execute):
* bindings/js/ScheduledAction.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::canAccessFromCurrentOrigin):
* bindings/js/ScriptController.h:
* bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
* bindings/objc/ObjCEventListener.mm:
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/test/ObjC/DOMTestCallback.mm:
(-[DOMTestCallback callbackWithClass1Param:]):
(-[DOMTestCallback callbackWithClass2Param:strArg:]):
(-[DOMTestCallback callbackWithNonBoolReturnType:]):
(-[DOMTestCallback customCallback:class6Param:]):
* bindings/scripts/test/ObjC/DOMTestInterface.mm:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj readOnlyIntAttr]):
(-[DOMTestObj readOnlyStringAttr]):
(-[DOMTestObj readOnlyTestObjAttr]):
(-[DOMTestObj intAttr]):
(-[DOMTestObj setIntAttr:]):
(-[DOMTestObj longLongAttr]):
(-[DOMTestObj setLongLongAttr:]):
(-[DOMTestObj unsignedLongLongAttr]):
(-[DOMTestObj setUnsignedLongLongAttr:]):
(-[DOMTestObj stringAttr]):
(-[DOMTestObj setStringAttr:]):
(-[DOMTestObj testObjAttr]):
(-[DOMTestObj setTestObjAttr:]):
(-[DOMTestObj attrWithException]):
(-[DOMTestObj setAttrWithException:]):
(-[DOMTestObj attrWithSetterException]):
(-[DOMTestObj setAttrWithSetterException:]):
(-[DOMTestObj attrWithGetterException]):
(-[DOMTestObj setAttrWithGetterException:]):
(-[DOMTestObj customAttr]):
(-[DOMTestObj setCustomAttr:]):
(-[DOMTestObj scriptStringAttr]):
(-[DOMTestObj voidMethod]):
(-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj intMethod]):
(-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj objMethod]):
(-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj methodThatRequiresAllArgs:objArg:]):
(-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]):
(-[DOMTestObj serializedValue:]):
(-[DOMTestObj methodWithException]):
(-[DOMTestObj customMethod]):
(-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj customArgsAndException:]):
(-[DOMTestObj addEventListener:listener:useCapture:]):
(-[DOMTestObj removeEventListener:listener:useCapture:]):
(-[DOMTestObj withDynamicFrame]):
(-[DOMTestObj withDynamicFrameAndArg:]):
(-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
(-[DOMTestObj withDynamicFrameAndUserGesture:]):
(-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
(-[DOMTestObj withScriptStateVoid]):
(-[DOMTestObj withScriptStateObj]):
(-[DOMTestObj withScriptStateVoidException]):
(-[DOMTestObj withScriptStateObjException]):
(-[DOMTestObj methodWithOptionalArg:]):
(-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
(-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::canAccessFromCurrentOrigin):
* bindings/v8/ScriptController.h:
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::isURLAllowed):
2010-05-18 Drew Wilson <atwilson@chromium.org>
Unreviewed: Speculative build fix for Chromium win.
* platform/graphics/skia/SkiaFontWin.cpp: Properly set inlineCapacity.
2010-05-18 Drew Wilson <atwilson@chromium.org>
Unreviewed fix for Chromium build break.
* platform/graphics/skia/SkiaFontWin.cpp: Now set inlineCapacity param.
2010-05-18 Daniel Cheng <dcheng@chromium.org>
Reviewed by Darin Adler, Jian Li.
DragData::asURL() shouldn't do file validity checks
https://bugs.webkit.org/show_bug.cgi?id=38711
There's no point to trying to make sure the file is valid in
DragData::asURL(). It's better to ask for forgiveness than to ask for
permission, since asking for permission is prone to race conditions
and results in unnecessary I/O. Consumers of this function either:
- need to verify the file exists themselves (e.g. the loader)
- don't care about file validity (rich text drag-and-drop)
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
2010-05-18 Timothy Hatcher <timothy@apple.com>
Fix a handful of various localization issues in the Web Inspector.
* Localize strings that where not localized.
* Make WebInspector.UIString work without bind.
* Always pass WebInspector.UIString to Number.secondsToString and Number.bytesToString.
* Never pass a variable to WebInspector.UIString, since that prevents auto-generation.
* Use an ellipsis instead of three periods.
https://webkit.org/b/39303
rdar://problem/7997101
Reviewed by Adam Roben.
* English.lproj/localizedStrings.js:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
* inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype.contentTabSelected):
* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
(WebInspector.ProfileDataGridNode.prototype.get data):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourceTimeCalculator.prototype.formatValue):
(WebInspector.ResourceTransferTimeCalculator.prototype.formatValue):
(WebInspector.ResourceTransferDurationCalculator.prototype.formatValue):
(WebInspector.ResourceTransferSizeCalculator.prototype.formatValue):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._registerShortcuts):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._contextMenu):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewCalculator):
(WebInspector.TimelineOverviewCalculator.prototype.formatValue):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelineCalculator):
(WebInspector.TimelineCalculator.prototype.formatValue):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendTextRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendElementRow):
* inspector/front-end/inspector.js:
(WebInspector.loaded):
(WebInspector.setRecordingProfile):
(WebInspector.UIString):
2010-05-18 Sam Weinig <sam@webkit.org>
Another attempt to fix the build.
* css/CSSCursorImageValue.cpp:
2010-05-18 Adam Roben <aroben@apple.com>
Make accelerated compositing work on machines that don't support
hardware vertex processing
Fixes <http://webkit.org/b/39299> <rdar://problem/7997692> Accelerated
compositing on Windows doesn't work on machines that don't support
hardware vertex processing, but should
Reviewed by Eric Carlson.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::createRenderer): Query the device
capabilities to decide whether to request hardware or software vertex
processing.
2010-05-18 Adam Roben <aroben@apple.com>
Make WKCACFLayerRenderer robust against temporary failure of
Direct3DCreate9 and IDirect3D9::CreateDevice
For a short time after waking from sleep, Direct3DCreate9() will
return an IDirect3D9 for which IDirect3D9::CreateDevice will always
fail. Also during this time period, IDirect3D9::CreateDevice
will fail even for non-bad IDirect3D9s. (It will later start
succeeding.) WKCACFLayerRenderer now works around this behavior by
detecting when it might be in this situation and calling these
functions again later.
Fixes <http://webkit.org/b/39297> <rdar://problem/7997431> WebView
doesn't repaint until page reloads when page using hardware
acceleration loads just after waking from sleep
Reviewed by John Sullivan.
* manual-tests/crash-and-no-repaint-after-wake-from-sleep.html:
Renamed from WebCore/manual-tests/crash-after-wake-from-sleep.html.
Modified to also include instructions for reproducing this bug.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Replaced
m_triedToCreateD3DRenderer with m_mightBeAbleToCreateDeviceLater. The
new member is initialized to true, since we haven't even tried to
create a device once yet.
(WebCore::WKCACFLayerRenderer::createRenderer): If we already have a
D3D device, or we don't have one and are sure that we won't be able to
create one later, just return the previously-created device, if any.
We assume that we won't be able to create a device later if this
function fails, unless the function fails due to CreateDevice failing.
As noted above, CreateDevice will sometimes temporarily fail and then
later start working again. When CreateDevice fails, we also assume
that we might have a bad IDirect3D9, so we get rid of the one we have
so a new (and hopefully non-bad) one will be allocated later.
(WebCore::WKCACFLayerRenderer::destroyRenderer): Reset
m_mightBeAbleToCreateDeviceLater to true, since we no longer have a
device.
(WebCore::WKCACFLayerRenderer::paint): Before trying to paint, try to
create our D3D device and renderer. If this fails, we bail out, but if
we think we might be able to create a device later we schedule another
paint (via renderSoon()) so that we'll try again soon.
* platform/graphics/win/WKCACFLayerRenderer.h: Replaced
m_triedToCreateD3DRenderer with m_mightBeAbleToCreateDeviceLater.
2010-05-18 Adam Roben <aroben@apple.com>
Fix a crash when a page that uses accelerated compositing loads soon
after the computer wakes from sleep
The set-up:
For a short time after waking from sleep, IDirect3D9::CreateDevice
will fail. This caused WKCACFLayerRenderer::createRenderer to fail,
and meant that WKCACFLayerRenderer never allocated a root layer.
WebView wouldn't notice that createRenderer failed, and would go ahead
and try to use the root layer anyway, resulting in a crash.
The fix:
We now allocate the root layer (and all the other members of
WKCACFLayerRenderer that aren't dependent on having an
IDirect3DDevice9) in WKCACFLayerRenderer's constructor. This way the
layers will always be present, even when creating the D3D device
fails.
There are two remaining problems:
1) This results in slightly more memory usage in the case where
CreateDevice fails.
2) Once we get into this bad state, the WebView doesn't repaint
until we navigate somewhere else.
(2) is covered by
<http://webkit.org/b/39297>/<rdar://problem/7997431>. We'll fix it by
retrying CreateDevice later in hopes that it will succeed after more
time has passed. This will in turn fix (1). (We should never end up in
a case where CreateDevice fails forever because we already did some
preliminary checks in acceleratedCompositingAvailable().)
Fixes <http://webkit.org/b/39295> <rdar://problem/7971319> Crash
(preceded by assertion) in WKCACFLayerRenderer::setNeedsDisplay when
computer wakes from sleep on particular page
Reviewed by John Sullivan.
* manual-tests/crash-after-wake-from-sleep.html: Added. This
is the Poster Circle demo from webkit.org/blog, but modified to
automatically reload every 5 seconds and with instructions to put the
computer to sleep and wake it up again.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Moved code to
initialize m_context, m_renderContext, and m_*Layer here...
(WebCore::WKCACFLayerRenderer::createRenderer): ...from here.
2010-05-18 Adam Roben <aroben@apple.com>
Remove an unused member variable from WKCACFLayerRenderer
Rubber-stamped by Ada Chan.
* platform/graphics/win/WKCACFLayerRenderer.h: Removed m_viewLayer,
which is unused.
2010-05-18 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Allocate the m_preloads list hash set dynamically and free it when done.
https://bugs.webkit.org/show_bug.cgi?id=39309
<rdar://problem/7998495>
This saves about 6000 bytes on a fully loaded document.
* loader/DocLoader.cpp:
(WebCore::DocLoader::requestPreload):
(WebCore::DocLoader::clearPreloads):
* loader/DocLoader.h:
2010-05-18 Anders Carlsson <andersca@apple.com>
Revert unintended indentation and unnecessary nested name specifier.
* rendering/RenderBlock.cpp:
(WebCore::clipOutPositionedObjects):
(WebCore::RenderBlock::insertPositionedObject):
2010-05-18 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add an inlineCapacity template parameter to ListHashSet and use it to shrink the positioned object list hash set.
https://bugs.webkit.org/show_bug.cgi?id=39304
<rdar://problem/7998366>
Set the inlineCapacity for the positionedObjects ListHashSet to 4 instead of 256. Since a RenderBlock usually has
few positioned objects, this saves memory.
* WebCore.base.exp:
* rendering/RenderBlock.cpp:
(WebCore::clipOutPositionedObjects):
(WebCore::RenderBlock::insertPositionedObject):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::positionedObjects):
2010-05-17 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=39258
Remove NamedAttrMap residual gunk
Replace NamedAttrMap.h/cpp with NamedNodeMap.h/cpp which was the class
it contained.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/v8/custom/V8NamedNodesCollection.cpp:
* dom/NamedAttrMap.cpp: Removed.
* dom/NamedAttrMap.h: Removed.
* dom/NamedNodeMap.cpp: Copied from dom/NamedAttrMap.cpp.
* dom/NamedNodeMap.h: Replaced with dom/NamedAttrMap.h.
* editing/ReplaceNodeWithSpanCommand.cpp:
* platform/chromium/ClipboardChromium.cpp:
2010-05-18 Brady Eidson <beidson@apple.com>
Reviewed by Eric Carlson.
<rdar://problem/7993468> REGRESSION (r58586): Audio doesn't play on first click of play button at NPR.org
NPR swallows the first mouse click on the play button, calls load() on the element, then waits for the
canplay event to come in before calling play itself.
After the site specific hack added in r58586, we disallowed play() from within the canplay event handler.
By tracking whether a load() was triggered by a user gesture, we can differentiate between the original
canplay event that we meant to ignore and the one resulting from the first mouse click which we want to honor.
No new tests. (Currently no way to test such site specific hack behavior)
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::load): Set the m_loadInitiatedByUserGesture flag
(WebCore::HTMLMediaElement::play): Only apply the site specific hack if the load wasn't initiated by a user gesture.
* html/HTMLMediaElement.h:
2010-05-18 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Dirk Schulze.
[OpenVG] Fix stupid build errors from the OpenVG Path commit
https://bugs.webkit.org/show_bug.cgi?id=39228
* platform/graphics/openvg/PainterOpenVG.cpp:
(WebCore::PainterOpenVG::clipPath):
* platform/graphics/openvg/PathOpenVG.cpp:
(WebCore::Path::transform):
2010-05-18 Chris Jerdonek <cjerdonek@webkit.org>
Reviewed by Darin Adler.
Refactored FrameLoader::isDocumentSandboxed() from a private member function
to a static, non-member, non-friend function.
https://bugs.webkit.org/show_bug.cgi?id=39157
Making this function non-private lets us make FrameLoader::createWindow()
a non-member function in a subsequent patch. We also made it non-member
rather than member to increase encapsulation and limit the number of
public functions with access to private FrameLoader data.
No new functionality, so no new tests.
* loader/FrameLoader.cpp:
(WebCore::isDocumentSandboxed):
- Moved this function from a private member function of FrameLoader
to a static, non-member, non-friend function.
(WebCore::FrameLoader::createWindow):
- Updated the call to isDocumentSandboxed().
(WebCore::FrameLoader::submitForm):
- Updated the call to isDocumentSandboxed().
(WebCore::FrameLoader::requestObject):
- Updated the call to isDocumentSandboxed().
(WebCore::FrameLoader::shouldAllowNavigation):
- Updated the call to isDocumentSandboxed().
* loader/FrameLoader.h:
- Removed isDocumentSandboxed() and added a FIXME to move
createWindow() out of the FrameLoader class.
2010-05-08 Robert Hogan <robert@roberthogan.net>
Reviewed by Simon Hausmann.
[Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html
and http/tests/xmlhttprequest/cross-origin-authorization.html
QHttpNetworkRequest adds Authorization and Cookie headers to XHRs
without knowing if this is valid behaviour or not. In order to allow
Qt to decide whether Cookie/Authorization headers should be added
to an XHR QtWebKit needs to use an attribute added to QNetworkRequest.
These new attributes are: QNetworkRequest::CookieLoadControlAttribute,
QNetworkRequest::CookieSaveControlAttribute,and
QNetworkRequest::AuthenticationReuseControlAttribute.
QtWebKit will set QNetworkRequest::AuthenticationReuseControlAttribute to false
unless withCredentials is set to true in the XHR.
QtWebkit will set CookieLoad/SaveControlAttribute to false unless withCredentials
is set to true in the XHR.
Qt will pass the values onto QHttpNetworkRequest and this will permit
the Qt network access processing to decide whether or not to add either
or both of the Cookie/Authorisation headers, and whether to save cookies
returned from such requests. By default the attribute
will always be true so unless QtWebKit sets it to false normal
header processing is unaffected.
The Qt part of these changes was merged at: http://gitorious.org/qt/qt/merge_requests/592
https://bugs.webkit.org/show_bug.cgi?id=32967
* platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):
2010-05-18 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implementing clipToImageBuffer for Qt port.
https://bugs.webkit.org/show_bug.cgi?id=24289
The implementation combines pixmap layers and destinationIn
composition mode.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::TransparencyLayer::TransparencyLayer):
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::inTransparencyLayer):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
(WebCore::GraphicsContext::clipToImageBuffer):
2010-05-18 Eric Seidel <eric@webkit.org>
Unreviewed build fix.
Make it possible to enable the new HTML5Tokenizer for testing
https://bugs.webkit.org/show_bug.cgi?id=39275
* WebCore.gypi:
- Fix HTMLLexer.* -> HTML5Lexer.*
* WebCore.vcproj/WebCore.vcproj:
- Add HTML5Lexer and HTML5Tokenizer to project.
2010-05-18 Eric Seidel <eric@webkit.org>
Unreviewed build fix.
Make it possible to enable the new HTML5Tokenizer for testing
https://bugs.webkit.org/show_bug.cgi?id=39275
* dom/NamedAttrMap.cpp:
(WebCore::NamedNodeMap::setNamedItemNS):
- Move this to the .cpp file so as to avoid needing to include "Node.h" in the header.
* dom/NamedAttrMap.h:
* html/HTML5Token.h:
- Remove #include "String.h" which was wrong. Adam meant "PlatformString.h"
- Remove unneeded #include "Node.h", it was only needed because
NamedAttrMap.h was incorrectly depending on Node.h but not
including it. It didn't actually need Node.h except for one
inlined method setNamedItemNS, so I moved setNamedItemNS into
the .cpp to get rid of the Node.h requirement.
2010-05-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make it possible to enable the new HTML5Tokenizer for testing
https://bugs.webkit.org/show_bug.cgi?id=39275
I added html5ParserEnabled to Settings so that we can enable/disable
the HTML5 parser for testing.
I also ripped out a bunch of dead code from HTML5Lexer.
I had to add HTML5Lexer/HTML5Tokenizer to all build systems so that
the build wouldn't fail now that we reference these classes from HTMLDocument.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* html/HTML5Lexer.cpp:
(WebCore::HTML5Lexer::reset):
(WebCore::isWhitespace):
(WebCore::HTML5Lexer::nextToken):
* html/HTML5Lexer.h:
* html/HTML5Tokenizer.cpp: Added.
(WebCore::HTML5Tokenizer::HTML5Tokenizer):
(WebCore::HTML5Tokenizer::~HTML5Tokenizer):
(WebCore::HTML5Tokenizer::begin):
(WebCore::HTML5Tokenizer::write):
(WebCore::HTML5Tokenizer::end):
(WebCore::HTML5Tokenizer::finish):
(WebCore::HTML5Tokenizer::isWaitingForScripts):
* html/HTML5Tokenizer.h: Added.
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::createTokenizer):
* html/HTMLTokenizer.h:
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::createTokenizer):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setHTML5ParserEnabled):
(WebCore::Settings::html5ParserEnabled):
2010-05-18 Maciej Stachowiak <mjs@apple.com>
Not reviewed, build fix.
Attempt to fix build for v8 bindings (untested).
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::clearWindowShell):
* bindings/v8/ScriptController.h:
2010-05-17 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
GC more promptly when navigating to a new inner window, but not at all when it went in the page cache
https://bugs.webkit.org/show_bug.cgi?id=39254
<rdar://problem/7996370>
~1% PLT speedup
~4% iBench HTML speedup
* bindings/js/GCController.cpp:
(WebCore::GCController::garbageCollectSoon): Change back to a 0 delay timer instead of
0.5 second.
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::clearWindowShell): Add a new boolean parameter. Don't
garbageColectSoon if the page is going into the page cache.
* bindings/js/ScriptController.h: Prototype change for above.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::clear): Indicate when the page is going into the page cache.
2010-05-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add an HTML5Token
https://bugs.webkit.org/show_bug.cgi?id=39274
The token object is an ugly fake union, but I'm sure sure there's a
better way... Eric needs this to provide output for the test harness.
* WebCore.xcodeproj/project.pbxproj:
* html/HTML5Lexer.cpp:
(WebCore::HTML5Lexer::HTML5Lexer):
(WebCore::HTML5Lexer::write):
(WebCore::HTML5Lexer::emitCharacter):
* html/HTML5Lexer.h:
* html/HTML5Token.h: Added.
(WebCore::HTML5Token::):
(WebCore::HTML5Token::HTML5Token):
(WebCore::HTML5Token::setToCharacter):
2010-05-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement ScriptData states for HTML5Lexer
https://bugs.webkit.org/show_bug.cgi?id=39273
This patch implements more of the lexer states according to the HTML5
specification. Currently, this code is compiled by not tested. We're
working on bringing up a test harness in parallel with transliterating
the spec into code.
* html/HTML5Lexer.cpp:
(WebCore::HTML5Lexer::tokenize):
(WebCore::HTML5Lexer::temporaryBufferIs):
* html/HTML5Lexer.h:
(WebCore::HTML5Lexer::):
2010-05-17 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Rename HTML5Tokenzier to HTML5Lexer so that we can add a new HTML5Tokenizer which implements Tokenizer
https://bugs.webkit.org/show_bug.cgi?id=39272
Strictly a rename, no functionality change.
* WebCore.xcodeproj/project.pbxproj:
* html/HTML5Lexer.cpp: Added.
* html/HTML5Lexer.h: Added.
* html/HTML5Tokenizer.cpp: Removed.
* html/HTML5Tokenizer.h: Removed.
2010-05-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r59652.
http://trac.webkit.org/changeset/59652
https://bugs.webkit.org/show_bug.cgi?id=39268
file-input-files-access test is broken on Mac (Requested by
dcheng on #webkit).
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
2010-05-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement RAWTEXT tokenizer states
https://bugs.webkit.org/show_bug.cgi?id=39267
More tokenizer states. There's a bunch of functionality notImplemented
that we'll come back to.
* html/HTML5Tokenizer.cpp:
(WebCore::HTML5Tokenizer::tokenize):
* html/HTML5Tokenizer.h:
2010-05-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement more parser states in HTML5Tokenizer
https://bugs.webkit.org/show_bug.cgi?id=39265
This patch implements some easy states. I'll come back and do the
harder states later.
* html/HTML5Tokenizer.cpp:
(WebCore::HTML5Tokenizer::tokenize):
(WebCore::HTML5Tokenizer::emitParseError):
* html/HTML5Tokenizer.h:
2010-05-17 Daniel Cheng <dcheng@chromium.org>
Reviewed by Darin Adler.
DragData::asURL() shouldn't do file validity checks
https://bugs.webkit.org/show_bug.cgi?id=38711
There's no point to trying to make sure the file is valid in
DragData::asURL(). It's better to ask for forgiveness than to ask for
permission, since asking for permission is prone to race conditions
and results in unnecessary I/O. Consumers of this function either:
- need to verify the file exists themselves (e.g. the loader)
- don't care about file validity (rich text drag-and-drop)
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
2010-05-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update states in HTML5Tokenizer to match HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=39264
I've also implemented the DataState. More states to follow.
* html/HTML5Tokenizer.cpp:
(WebCore::HTML5Tokenizer::reset):
(WebCore::HTML5Tokenizer::tokenize):
* html/HTML5Tokenizer.h:
(WebCore::HTML5Tokenizer::):
2010-05-17 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
':valid' CSS selector should not be applied to some form controls
https://bugs.webkit.org/show_bug.cgi?id=39162
* html/HTMLElement.cpp:
(WebCore::inlineTagList): Always includes progressTag. This change is
needed in a case of no ENABLE_PROGRESS_TAG. Without this change and
ENABLE_PROGRESS_TAG, <progress> tags disappear.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::recalcWillValidate):
Return false for SUBMIT and IMAGE.
* html/HTMLProgressElement.h:
(WebCore::HTMLProgressElement::recalcWillValidate):
Return false. This change is needed in a case of ENABLE_PROGRESS_TAG.
2010-05-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove load-related code from HTML5Tokenizer
https://bugs.webkit.org/show_bug.cgi?id=39263
This code is related to reloading resources and not to tokenizing. In
the PreloadScanner, these concerns are coupled, but we want to decouple
them.
* html/HTML5Tokenizer.cpp:
(WebCore::HTML5Tokenizer::HTML5Tokenizer):
(WebCore::HTML5Tokenizer::~HTML5Tokenizer):
(WebCore::HTML5Tokenizer::begin):
(WebCore::HTML5Tokenizer::end):
(WebCore::HTML5Tokenizer::reset):
(WebCore::HTML5Tokenizer::write):
(WebCore::HTML5Tokenizer::consumeEntity):
(WebCore::HTML5Tokenizer::tokenize):
(WebCore::HTML5Tokenizer::processAttribute):
(WebCore::HTML5Tokenizer::emitCharacter):
(WebCore::HTML5Tokenizer::emitTag):
* html/HTML5Tokenizer.h:
2010-05-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add HTML5Tokenizer to the build system on Mac
https://bugs.webkit.org/show_bug.cgi?id=39262
This file will be easier to work with if we're actually compiling it.
Hopefully we'll get this wired into the PreloadScanner soon. Once we
start actually calling the code, we'll add it to the build system on
other platforms.
* WebCore.xcodeproj/project.pbxproj:
2010-05-17 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Copy PreloadScanner.* to HTML5Tokenizer.* to start work on the new HTML5 Tokenizer
https://bugs.webkit.org/show_bug.cgi?id=39261
* html/HTML5Tokenizer.cpp: Rename PreloadScanner to HTML5Tokenizer.
* html/HTML5Tokenizer.h: ditto.
2010-05-17 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Copy PreloadScanner.* to HTML5Tokenizer.* to start work on the new HTML5 Tokenizer
https://bugs.webkit.org/show_bug.cgi?id=39261
This time copy the cpp from the right file.
* html/HTML5Tokenizer.cpp: Copied from WebCore/html/PreloadScanner.cpp.
2010-05-17 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Copy PreloadScanner.* to HTML5Tokenizer.* to start work on the new HTML5 Tokenizer
https://bugs.webkit.org/show_bug.cgi?id=39261
* html/HTML5Tokenizer.cpp: Copied from WebCore/html/PreloadScanner.h.
* html/HTML5Tokenizer.h: Copied from WebCore/html/PreloadScanner.h.
2010-05-17 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
[Chromium] Windows: Speed of indeterminate progress bar should be constant
https://bugs.webkit.org/show_bug.cgi?id=39211
No new tests, animation effect can be confirmed only manually.
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::RenderThemeChromiumWin::animationDurationForProgressBar):
(WebCore::RenderThemeChromiumWin::paintProgressBar):
2010-05-17 Drew Wilson <atwilson@chromium.org>
Unreviewed build fix for Qt and Chromium.
https://bugs.webkit.org/show_bug.cgi?id=39147
* page/Frame.h: Now includes CSSMutableStyleDeclaration.h.
2010-05-17 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Remove unused member member from Document
https://bugs.webkit.org/show_bug.cgi?id=39251
Remove m_associatedHistoryItems from Document; it is never used.
* dom/Document.h:
2010-05-17 Darin Adler <darin@apple.com>
Fix Qt build.
* page/Frame.cpp:
(WebCore::Frame::setTypingStyle): Move back to make non-inline.
* page/Frame.h: Removed inline version of setTypingStyle.
2010-05-14 Darin Adler <darin@apple.com>
Reviewed by Brady Eidson.
Frame has many trivial member functions that should be inlined
https://bugs.webkit.org/show_bug.cgi?id=39147
* WebCore.base.exp: Export the functions that are now inlined.
* page/Frame.cpp:
(WebCore::Frame::removeEditingStyleFromBodyElement):
Removed the body of this function.
* page/Frame.h:
(WebCore::Frame::init): Moved here from .cpp.
(WebCore::Frame::loader): Ditto.
(WebCore::Frame::redirectScheduler): Ditto.
(WebCore::Frame::view): Ditto.
(WebCore::Frame::script): Ditto.
(WebCore::Frame::document): Ditto.
(WebCore::Frame::selection): Ditto.
(WebCore::Frame::editor): Ditto.
(WebCore::Frame::animation): Ditto.
(WebCore::Frame::mark): Ditto.
(WebCore::Frame::setMark): Ditto.
(WebCore::Frame::zoomFactor): Ditto.
(WebCore::Frame::jsStatusBarText): Ditto.
(WebCore::Frame::jsDefaultStatusBarText): Ditto.
(WebCore::Frame::needsReapplyStyles): Ditto.
(WebCore::Frame::typingStyle): Ditto.
(WebCore::Frame::setTypingStyle): Ditto.
(WebCore::Frame::clearTypingStyle): Ditto.
(WebCore::Frame::ownerElement): Ditto.
(WebCore::Frame::isDisconnected): Ditto.
(WebCore::Frame::setIsDisconnected): Ditto.
(WebCore::Frame::excludeFromTextSearch): Ditto.
(WebCore::Frame::setExcludeFromTextSearch): Ditto.
(WebCore::Frame::inViewSourceMode): Ditto.
(WebCore::Frame::setInViewSourceMode): Ditto.
(WebCore::Frame::markedTextMatchesAreHighlighted): Ditto.
(WebCore::Frame::tree): Ditto.
(WebCore::Frame::page): Ditto.
(WebCore::Frame::detachFromPage): Ditto.
(WebCore::Frame::eventHandler): Ditto.
(WebCore::Frame::shouldClose): Ditto.
2010-05-17 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=39247
<rdar://problem/7994707>
Move rarely used data members to the rare structures, thus saving memory.
Move rarely used member variables from StyleInheritedData and StyleVisualData to
StyleRareInheritedData and StyleRareNonInheritedData, namely:
indent, cursorData, m_effectiveZoom, widows and orphans move from StyleInheritedData to StyleRareInheritedData.
m_counterIncrement and m_counterReset move from StyleVisualData to StyleRareNonInheritedData.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
(WebCore::RenderStyle::addCursor):
(WebCore::RenderStyle::setCursorList):
(WebCore::RenderStyle::clearCursorList):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::textIndent):
(WebCore::InheritedFlags::effectiveZoom):
(WebCore::InheritedFlags::counterIncrement):
(WebCore::InheritedFlags::counterReset):
(WebCore::InheritedFlags::cursors):
(WebCore::InheritedFlags::widows):
(WebCore::InheritedFlags::orphans):
(WebCore::InheritedFlags::setTextIndent):
(WebCore::InheritedFlags::setEffectiveZoom):
(WebCore::InheritedFlags::setCounterIncrement):
(WebCore::InheritedFlags::setCounterReset):
(WebCore::InheritedFlags::setWidows):
(WebCore::InheritedFlags::setOrphans):
* rendering/style/StyleInheritedData.cpp:
(WebCore::StyleInheritedData::StyleInheritedData):
(WebCore::StyleInheritedData::operator==):
* rendering/style/StyleInheritedData.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::cursorDataEquivalent):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:
* rendering/style/StyleVisualData.cpp:
(WebCore::StyleVisualData::StyleVisualData):
* rendering/style/StyleVisualData.h:
(WebCore::StyleVisualData::operator==):
2010-05-17 Robert Hogan <robert@webkit.org>
Rubber-stamped by Eric Seidel.
Fix --no-svg build.
I have no idea where the SVG-dependent include of this file is hidden, but
it is probably better to include it explicitly anyway like V8WorkerContextCustom.cpp.
* bindings/js/JSWorkerContextCustom.cpp:
2010-05-17 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=39231
Fix failures in the RTL portion of fast/multicol/layers-in-multicol.html. Make sure block children of RTL blocks are positioned using
the reduced column width instead of the total content width.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::determineHorizontalPosition):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestContents):
(WebCore::RenderBlock::adjustForColumns):
2010-05-17 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by George Staikos.
[OpenVG] Add support for decoding and drawing images
https://bugs.webkit.org/show_bug.cgi?id=36072
OpenVG has a maximum image size (how large is
specific to the OpenVG implementation), so this
requires us to store them as separate image tiles.
Image decoding and initial drawing code by
Adam Treat <atreat@rim.com>. Image decoder
downsampling support by Yong Li <yoli@rim.com>.
* platform/graphics/ImageSource.h:
* platform/graphics/openvg/ImageOpenVG.cpp: Added.
(WebCore::FrameData::clear):
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::BitmapImage::initPlatformData):
(WebCore::BitmapImage::invalidatePlatformData):
(WebCore::adjustSourceRectForDownSampling):
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
(WebCore::Image::loadPlatformResource):
* platform/graphics/openvg/PainterOpenVG.cpp:
(WebCore::PainterOpenVG::drawImage):
(WebCore::PainterOpenVG::asNewNativeImage):
* platform/graphics/openvg/PainterOpenVG.h:
* platform/graphics/openvg/TiledImageOpenVG.cpp: Added.
(WebCore::TiledImageOpenVG::TiledImageOpenVG):
(WebCore::TiledImageOpenVG::operator=):
(WebCore::TiledImageOpenVG::~TiledImageOpenVG):
(WebCore::TiledImageOpenVG::numTiles):
(WebCore::TiledImageOpenVG::numColumns):
(WebCore::TiledImageOpenVG::numRows):
(WebCore::TiledImageOpenVG::setTile):
(WebCore::TiledImageOpenVG::tilesInRect):
(WebCore::TiledImageOpenVG::tile):
(WebCore::TiledImageOpenVG::tileRect):
(WebCore::TiledImageOpenVG::detachTiles):
(WebCore::TiledImageOpenVG::destroyTiles):
* platform/graphics/openvg/TiledImageOpenVG.h: Added.
(WebCore::TiledImageOpenVG::size):
(WebCore::TiledImageOpenVG::maxTileSize):
* platform/graphics/openvg/VGUtils.cpp:
(WebCore::VGUtils::bytesForImage):
(WebCore::VGUtils::bytesForImageScanline):
(WebCore::VGUtils::imageFormatBitsPerPixel):
(WebCore::VGUtils::endianAwareImageFormat):
* platform/graphics/openvg/VGUtils.h:
* platform/image-decoders/openvg/ImageDecoderOpenVG.cpp: Added.
(WebCore::RGBA32Buffer::asNewNativeImage):
2010-05-17 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Adler.
Fix JSC's generation of 'Optional' arguments. When a single 'Optional' extended attribute precedes multiple method arguments, all of these arguments are optional as a group (either all or non must be specified). This fix, which makes JSC compliant with V8 and with the Web IDL specs, is pretty harmless, since Optional is currently not being used anywhere in JSC, but it blocks further work on overloads.
https://bugs.webkit.org/show_bug.cgi?id=39227
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
2010-05-16 Sam Weinig <sam@webkit.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=39192
Remove unused PERFECT_HASH code CodeGeneratorJS.
* bindings/scripts/CodeGeneratorJS.pm:
2010-05-17 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Jeremy Orlow.
Remove debug code that was introduced to help narrow down the
source of a crash.
https://bugs.webkit.org/show_bug.cgi?id=36426
No change in behavior, so no new tests.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::finishedLoadingDocument):
2010-05-17 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Bring CanvasRenderingContext2D's createImageData() in line with HTML5 spec
Added createImageData(ImageData) which returns a new ImageData with the same size as the one passed.
Changed createImageData(width, height) to use the absolute values of width and height.
https://bugs.webkit.org/show_bug.cgi?id=39189
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createimagedata
Test: fast/canvas/canvas-createImageData.html
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::JSCanvasRenderingContext2D::createImageData):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createImageData):
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/CanvasRenderingContext2D.idl:
2010-05-17 Antti Koivisto <koivisto@iki.fi>
This was missing from previous commit.
* platform/qt/QWebPageClient.h:
(QWebPageClient::graphicsItemVisibleRect):
2010-05-17 Antti Koivisto <koivisto@iki.fi>
Reviewed by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=39218
[Qt] Tiled backing store tiles sometimes flicker when exiting a zoom animation
Tiles sometimes flicker when exiting a zoom animation. This happens as a result
of the visible rectangle being momentarily out of sync.
Instead of updating the visible rect by explicitly setting it, pull it through
the client and recompute in the WebKit level.
* page/ChromeClient.h:
(WebCore::ChromeClient::visibleRectForTiledBackingStore):
* page/Frame.cpp:
(WebCore::Frame::tiledBackingStoreVisibleRect):
* page/Frame.h:
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::checkVisibleRectChanged):
(WebCore::TiledBackingStore::createTiles):
* platform/graphics/TiledBackingStore.h:
* platform/graphics/TiledBackingStoreClient.h:
2010-05-15 Adam Roben <aroben@apple.com>
Periodically try to reset a lost IDirect3DDevice9 until we succeed
This is how MSDN says we must respond to a lost device (see
<http://msdn.microsoft.com/en-us/library/bb174714(v=VS.85).aspx>).
Only testable by a manual test, unfortunately.
Fixes <rdar://problem/7986906> <http://webkit.org/b/39139> Pages that
use hardware acceleration don't repaint after waking computer from
sleep
Reviewed by John Sullivan.
* manual-tests/no-repaint-after-wake-from-sleep.html: Added. This is
the Poster Circle demo from webkit.org/blog, but with instructions for
putting the computer to sleep and waking it up again.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Initialize new
member that tells us whether we need to try to reset the device before
rendering.
(WebCore::WKCACFLayerRenderer::resize): Changed to tell resetDevice
the reason why the device needs to be reset (which is because the
window's size has changed).
(WebCore::WKCACFLayerRenderer::render): Before we do anything else,
check if we need to reset the device before rendering. If we do, try
to reset it. If that fails, bail out and set a timer to try again
later. If we discover that the device is lost when calling
IDirect3DDevice9::Present and resetting the device fails, bail out and
set a timer to try again later.
(WebCore::WKCACFLayerRenderer::resetDevice): Changed to return a
boolean indicating whether resetting succeeded or not. Added a
ResetReason parameter so callers can specify whey the device needs to
be reset. Before trying to do anything, we call
IDirect3DDevice9::TestCooperativeLevel to find out whether the device
can be reset currently. If it can't, we set a flag to tell ourselves
that the device must be reset before we next render, and indicate to
the caller that the reset failed. If we thought the device was lost
but it turns out not to be, we don't have to do anything and can tell
the caller that the reset succeeded. Otherwise we go ahead and reset
the device as before, and indicate to the caller that the reset
succeeded.
* platform/graphics/win/WKCACFLayerRenderer.h: Changed resetDevice to
return a boolean and take a ResetReason parameter. Added a comment
about when and why this function should be called. And added
m_mustResetLostDeviceBeforeRendering.
2010-05-15 Adam Roben <aroben@apple.com>
Call CARenderOGLPurge whenever we call IDirect3DDevice9::Reset
MSDN says that all resoures allocated with D3DPOOL_DEFAULT must be
destroyed before calling IDirect3DDevice9::Reset. The only way to
guarantee this with Core Animation is to call CARenderOGLPurge.
Unfortunately this isn't testable at the moment, as we don't use any
features of Core Animation (e.g., mask layers) that actually make this
required. But it seems like a good idea to fix the code now so that
if/when we do start using those features we won't run into problems.
Fixes <http://webkit.org/b/39159> WKCACFLayerRenderer::resetDevice
might fail due to failing to destroy all D3DPOOL_DEFAULT resources
Reviewed by John Sullivan.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::render): Moved the call to
CARenderOGLPurge from here...
(WebCore::WKCACFLayerRenderer::resetDevice): ...to here, so that it
will be called whenever we reset the device (e.g., when resizing the
window).
2010-05-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Build fix. Remove bashism from build system.
* GNUmakefile.am:
2010-05-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r59483.
http://trac.webkit.org/changeset/59483
https://bugs.webkit.org/show_bug.cgi?id=39215
"page_cycler_intl1 regression on Linux" (Requested by yurys on
#webkit).
* platform/chromium/ChromiumBridge.h:
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getFontDataForCharacters):
2010-05-17 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Laszlo Gombos.
REGRESSION(59563): [Qt] JSValue QtClass::fallbackObject can be optimized
Patch declared a variable index, which shadowed an earlier declared
variable.
* bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):
2010-05-14 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IDBRequest is not a proper ActiveDomObject
https://bugs.webkit.org/show_bug.cgi?id=39001
Add IDBRequest interface to the IsActiveDomType
routine of the CodeGeneratorV8.pm.
Rename IDBRequest::m_stopped to m_suspended and reset
the flag when resume() is called.
No new tests, Indexed Database isn't yet testable.
* bindings/scripts/CodeGeneratorV8.pm:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::suspend):
(WebCore::IDBRequest::resume):
(WebCore::IDBRequest::timerFired):
(WebCore::IDBRequest::onEventCommon):
* storage/IDBRequest.h:
2010-05-17 Xan Lopez <xlopez@igalia.com>
Do not include the indexed database headers if the feature is not
enabled. Should fix the build in GTK+.
* bindings/js/JSEventCustom.cpp:
2010-05-17 Xan Lopez <xlopez@igalia.com>
Try to fix GTK+ build.
* GNUmakefile.am:
2010-05-14 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Finish up IndexedDB events
https://bugs.webkit.org/show_bug.cgi?id=39117
Implement the indexed database event interfaces as proposed by Mozilla.
Refactor the run time type detection code that was in IDBRequest into its own
class named IDBAny. Use this new class within the new event classes and
IDBResults.
Test: storage/indexeddb/basics.html
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
* bindings/js/JSIDBAnyCustom.cpp: Added.
(WebCore::toJS):
* bindings/js/JSIDBRequestCustom.cpp: Removed.
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8IDBAnyCustom.cpp: Added.
(WebCore::toV8):
* bindings/v8/custom/V8IDBRequestCustom.cpp: Removed.
* dom/Event.cpp:
(WebCore::Event::isIDBErrorEvent):
(WebCore::Event::isIDBSuccessEvent):
* dom/Event.h:
* storage/IDBAny.cpp: Added.
(WebCore::IDBAny::create):
(WebCore::IDBAny::IDBAny):
(WebCore::IDBAny::~IDBAny):
(WebCore::IDBAny::idbDatabaseRequest):
(WebCore::IDBAny::indexedDatabaseRequest):
(WebCore::IDBAny::serializedScriptValue):
(WebCore::IDBAny::set):
* storage/IDBAny.h: Added.
(WebCore::IDBAny::):
(WebCore::IDBAny::type):
* storage/IDBAny.idl: Added.
* storage/IDBErrorEvent.cpp: Added.
(WebCore::IDBErrorEvent::create):
(WebCore::IDBErrorEvent::IDBErrorEvent):
(WebCore::IDBErrorEvent::~IDBErrorEvent):
* storage/IDBErrorEvent.h: Added.
(WebCore::IDBErrorEvent::code):
(WebCore::IDBErrorEvent::message):
(WebCore::IDBErrorEvent::isIDBErrorEvent):
* storage/IDBErrorEvent.idl: Added.
* storage/IDBEvent.cpp: Added.
(WebCore::IDBEvent::IDBEvent):
(WebCore::IDBEvent::~IDBEvent):
(WebCore::IDBEvent::source):
* storage/IDBEvent.h: Added.
* storage/IDBEvent.idl: Added.
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::timerFired):
(WebCore::IDBRequest::onEventCommon):
* storage/IDBRequest.h:
(WebCore::IDBRequest::create):
(WebCore::IDBRequest::result):
* storage/IDBRequest.idl:
* storage/IDBSuccessEvent.cpp: Added.
(WebCore::IDBSuccessEvent::create):
(WebCore::IDBSuccessEvent::IDBSuccessEvent):
(WebCore::IDBSuccessEvent::~IDBSuccessEvent):
(WebCore::IDBSuccessEvent::result):
* storage/IDBSuccessEvent.h: Added.
(WebCore::IDBSuccessEvent::isIDBSuccessEvent):
* storage/IDBSuccessEvent.idl: Added.
* storage/IndexedDatabaseImpl.cpp:
(WebCore::IndexedDatabaseImpl::open):
* storage/IndexedDatabaseRequest.cpp:
(WebCore::IndexedDatabaseRequest::IndexedDatabaseRequest):
(WebCore::IndexedDatabaseRequest::open):
* storage/IndexedDatabaseRequest.h:
2010-05-16 Chris Jerdonek <cjerdonek@webkit.org>
Unreviewed.
Removed the stray equals sign from the reviewer's name in the
"Reviewed by" line of the ChangeLog entry for r59596:
http://trac.webkit.org/changeset/59596
2010-05-16 Chris Jerdonek <cjerdonek@webkit.org>
Reviewed by Adam Barth.
Refactored FrameLoader::changeLocation() and urlSelected() to share more code.
https://bugs.webkit.org/show_bug.cgi?id=38827
No change in behavior, so no new tests.
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
- Changed a parameter from boolean to the ShouldReplaceDocumentIfJavaScriptURL enum.
* bindings/js/ScriptController.h:
- Changed a parameter from boolean to the ShouldReplaceDocumentIfJavaScriptURL enum.
* bindings/v8/ScriptController.h:
- Changed a parameter from boolean to the ShouldReplaceDocumentIfJavaScriptURL enum.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::changeLocation):
- Changed to call the new private overload of urlSelected().
(WebCore::FrameLoader::urlSelected):
- Added a private overload of urlSelected().
- Changed the public urlSelected() to call the private overload.
(WebCore::FrameLoader::submitForm):
* loader/FrameLoader.h:
- Added a private overload of urlSelected().
* loader/FrameLoaderTypes.h:
- Added a ShouldReplaceDocumentIfJavaScriptURL enum.
2010-05-16 Daniel Bates <dbates@rim.com>
Reviewed by David Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=39196
Rollout changeset 59274 <http://trac.webkit.org/changeset/59274>.
Prepared on behalf of David Hyatt.
"Not worth the memory use." Just roll this out.
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* editing/visible_units.cpp:
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::selectionRect):
(WebCore::EllipsisBox::paintSelection):
(WebCore::EllipsisBox::nodeAtPoint):
* rendering/EllipsisBox.h:
(WebCore::EllipsisBox::EllipsisBox):
(WebCore::EllipsisBox::height):
* rendering/InlineBox.cpp:
(WebCore::InlineBox::height):
(WebCore::InlineBox::adjustPosition):
(WebCore::InlineBox::canAccommodateEllipsis):
* rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::isInlineBox):
(WebCore::InlineBox::hasVirtualHeight):
(WebCore::InlineBox::setHasVirtualHeight):
(WebCore::InlineBox::virtualHeight):
(WebCore::InlineBox::setWidth):
(WebCore::InlineBox::width):
(WebCore::InlineBox::setX):
(WebCore::InlineBox::x):
(WebCore::InlineBox::setY):
(WebCore::InlineBox::y):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesVertically):
(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::paintTextDecorations):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::visibleOverflowRect):
(WebCore::InlineFlowBox::topLayoutOverflow):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::leftLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::topVisualOverflow):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::leftVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):
(WebCore::InlineFlowBox::visualOverflowRect):
(WebCore::InlineFlowBox::setHorizontalOverflowPositions):
(WebCore::InlineFlowBox::setVerticalOverflowPositions):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::setSpaceAdd):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeVerticalPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::createInlineFlowBox):
* rendering/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::createTextBox):
* rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::createRootInlineBox):
* rendering/RenderText.cpp:
(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::firstRunX):
(WebCore::RenderText::firstRunY):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeTextRun):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::placeEllipsis):
(WebCore::RootInlineBox::addHighlightOverflow):
(WebCore::RootInlineBox::closestLeafChildForXPos):
* rendering/SVGInlineFlowBox.h:
(WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
(WebCore::SVGInlineFlowBox::virtualHeight):
(WebCore::SVGInlineFlowBox::setHeight):
* rendering/SVGInlineTextBox.h:
(WebCore::SVGInlineTextBox::virtualHeight):
(WebCore::SVGInlineTextBox::setHeight):
(WebCore::SVGInlineTextBox::selectionTop):
(WebCore::SVGInlineTextBox::selectionHeight):
* rendering/SVGRootInlineBox.h:
(WebCore::SVGRootInlineBox::SVGRootInlineBox):
(WebCore::SVGRootInlineBox::virtualHeight):
(WebCore::SVGRootInlineBox::setHeight):
* rendering/TrailingFloatsRootInlineBox.h: Added.
(WebCore::TrailingFloatsRootInlineBox::TrailingFloatsRootInlineBox):
(WebCore::TrailingFloatsRootInlineBox::virtualHeight):
2010-05-13 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
REGRESSION: Crash by pasting to a textarea with white-space:nowrap
https://bugs.webkit.org/show_bug.cgi?id=38992
Test: editing/pasteboard/paste-plaintext-nowrap.html
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::highestVisuallyEquivalentDivBelowRoot):
(WebCore::InsertParagraphSeparatorCommand::doApply):
2010-05-16 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=39194
Fix all of the multi-column painting and hit testing functions to properly account for RTL directionality.
Added fast/multicol/column-count-with-rules.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::adjustRectForColumns):
2010-05-16 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
Fix SVG test failures after r59588.
Updated SVG InlineBox virtual method overrides to match HTML ones. Removed
SVGInlineFlowBox::verticallyAlignBoxes() since InlineFlowBox no longer declares
verticallyAlignBoxes().
* rendering/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::placeBoxesHorizontally):
* rendering/SVGInlineFlowBox.h:
* rendering/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::placeBoxesHorizontally):
(WebCore::SVGRootInlineBox::verticallyAlignBoxes):
* rendering/SVGRootInlineBox.h:
2010-05-16 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
Move transient glyph overflow and fallback font data from a global to the stack
https://bugs.webkit.org/show_bug.cgi?id=39050
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesHorizontally): Added a GlyphOverflowAndFallbackFontsMap
parameter. Read glyph overflow from the map.
(WebCore::InlineFlowBox::computeLogicalBoxHeights): Added a GlyphOverflowAndFallbackFontsMap
parameter. Read fallback fonts from the map.
(WebCore::InlineFlowBox::computeVerticalOverflow): Added a GlyphOverflowAndFallbackFontsMap
parameter. Read glyph overflow from the map.
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp: Removed setFallbackFonts(), fallbackFonts(), setGlyphOverflow(),
and glyphOverflow(). Removed s_glyphOverflowAndFallbackFontsMap.
* rendering/InlineTextBox.h:
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeHorizontalPositionsForLine): Added a GlyphOverflowAndFallbackFontsMap
parameter. Write fallback fonts and glyph overflow into the map.
(WebCore::RenderBlock::computeVerticalPositionsForLine): Added a GlyphOverflowAndFallbackFontsMap
parameter. Pass it down to verticallyAlignBoxes().
(WebCore::RenderBlock::layoutInlineChildren): Create a GlyphOverflowAndFallbackFontsMap on the
stack and pass it down to computeHorizontalPositionsForLine(), computeVerticalPositionsForLine(),
and verticallyAlignBoxes().
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticallyAlignBoxes): Added a GlyphOverflowAndFallbackFontsMap parameter.
Pass it down to computeLogicalBoxHeights() and computeVerticalOverflow().
* rendering/RootInlineBox.h:
* rendering/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::layoutInlineBoxes): Updated.
2010-05-12 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
Spellcheck disabling does not disable context menu
https://bugs.webkit.org/show_bug.cgi?id=25639
Test: editing/spelling/context-menu-suggestions.html
* platform/ContextMenu.cpp:
(WebCore::ContextMenu::populate):
2010-05-16 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=39190
Shave a word off of GlyphPageTreeNode
<rdar://problem/7990428>
* platform/graphics/GlyphPageTreeNode.h:
(WebCore::GlyphPageTreeNode::GlyphPageTreeNode):
2010-05-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Properly handle invalid arguments to CanvasRenderingContext2D's getImageData() and putImageData().
Both should throw NOT_SUPPORTED_ERR when called with nonfinite arguments.
getImageData() should throw INDEX_SIZE_ERR if either width or height is 0.
https://bugs.webkit.org/show_bug.cgi?id=39175
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation
Test: fast/canvas/canvas-getImageData-invalid.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createImageData):
(WebCore::CanvasRenderingContext2D::getImageData):
(WebCore::CanvasRenderingContext2D::putImageData):
2010-05-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Canvas's toDataURL() should be case insensitive wrt the mimeType argument.
https://bugs.webkit.org/show_bug.cgi?id=39153
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl
Test: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html
* dom/CanvasSurface.cpp:
(WebCore::CanvasSurface::toDataURL):
2010-05-16 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson.
Shrink SimpleFontData
https://bugs.webkit.org/show_bug.cgi?id=39179
Change SimpleFontData to have a pointer to the m_glyphToBoundsMap,
and to allocate this lazily. This reduces the size of the class from
5632 to 1536 bytes.
* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::boundsForGlyph):
2010-05-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Maciej Stachowiak.
Reduce the size of CachedResource
https://bugs.webkit.org/show_bug.cgi?id=39171
Make protected data members of CachedResource private, to allow for
easier rearrangement, and hide the fact that enums are in bitfields.
Rearrange the data members of CachedResource to save 32 bytes per instance
in 64-bit. Also modernized the constructor code.
* loader/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::didAddClient):
(WebCore::CachedCSSStyleSheet::data):
(WebCore::CachedCSSStyleSheet::checkNotify):
(WebCore::CachedCSSStyleSheet::error):
* loader/CachedFont.cpp:
(WebCore::CachedFont::load):
(WebCore::CachedFont::didAddClient):
(WebCore::CachedFont::data):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::ensureSVGFontData):
(WebCore::CachedFont::checkNotify):
(WebCore::CachedFont::error):
* loader/CachedImage.cpp:
(WebCore::CachedImage::CachedImage):
(WebCore::CachedImage::load):
(WebCore::CachedImage::didAddClient):
(WebCore::CachedImage::allClientsRemoved):
(WebCore::CachedImage::image):
(WebCore::CachedImage::data):
(WebCore::CachedImage::error):
(WebCore::CachedImage::checkNotify):
(WebCore::CachedImage::destroyDecodedData):
* loader/CachedImage.h:
(WebCore::CachedImage::stillNeedsLoad):
* loader/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
* loader/CachedResource.h:
(WebCore::CachedResource::type):
(WebCore::CachedResource::preloadResult):
(WebCore::CachedResource::status):
(WebCore::CachedResource::setStatus):
(WebCore::CachedResource::isLoaded):
(WebCore::CachedResource::isLoading):
(WebCore::CachedResource::setErrorOccurred):
* loader/CachedScript.cpp:
(WebCore::CachedScript::didAddClient):
(WebCore::CachedScript::data):
(WebCore::CachedScript::checkNotify):
(WebCore::CachedScript::error):
* loader/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::didAddClient):
(WebCore::CachedXSLStyleSheet::data):
(WebCore::CachedXSLStyleSheet::checkNotify):
(WebCore::CachedXSLStyleSheet::error):
2010-05-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r59574.
http://trac.webkit.org/changeset/59574
https://bugs.webkit.org/show_bug.cgi?id=39176
Supposedly broke cr-win, but the errors seems somewhat
unrelated (Requested by abarth on #webkit).
* platform/network/chromium/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::setSecurityInfo):
(WebCore::ResourceResponse::isContentFiltered):
(WebCore::ResourceResponse::setIsContentFiltered):
(WebCore::ResourceResponse::setAppCacheID):
(WebCore::ResourceResponse::setAppCacheManifestURL):
(WebCore::ResourceResponse::setWasFetchedViaSPDY):
(WebCore::ResourceResponse::setIsMultipartPayload):
(WebCore::ResourceResponse::setResponseTime):
2010-05-16 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
Scalar types allocated on the heap due to misuse of DEFINE_STATIC_LOCAL
https://bugs.webkit.org/show_bug.cgi?id=39086
Use global variables directly.
* bindings/v8/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::createUtilityContext):
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::shouldUseATSUIAPI):
2010-05-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Canvas's getContext() must return null when called with an invalid/unsupported parameter.
(HTML5 spec 4.8.11): http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-canvas-getcontext
https://bugs.webkit.org/show_bug.cgi?id=39150
Test: fast/canvas/canvas-getContext-invalid.html
* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
2010-05-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r59565.
http://trac.webkit.org/changeset/59565
https://bugs.webkit.org/show_bug.cgi?id=39173
Broke GTK (Requested by abarth on #webkit).
* dom/CanvasSurface.cpp:
(WebCore::CanvasSurface::toDataURL):
2010-05-15 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Canvas's toDataURL() should be case insensitive wrt the mimeType argument.
https://bugs.webkit.org/show_bug.cgi?id=39153
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl
Test: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html
* dom/CanvasSurface.cpp:
(WebCore::CanvasSurface::toDataURL):
2010-05-15 Anders Bakken <agbakken@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
QObject::objectName() returns a QString and QtField::name()
creates a temporary QByteArray object and returns constData() from it.
This is not safe.
This patch changes the signature of the function to return a
QByteArray instead of const char *.
https://bugs.webkit.org/show_bug.cgi?id=39010
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::getPropertyNames):
(JSC::Bindings::QtField::name):
* bridge/qt/qt_runtime.h:
2010-05-15 Anders Bakken <agbakken@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
Don't unnecessarily copy data when searching for methods in QtClass.
[Qt] JSValue QtClass::fallbackObject can be optimized
https://bugs.webkit.org/show_bug.cgi?id=37684
* bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):
2010-05-15 Anders Bakken <agbakken@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
Identifier::ascii() is not threadsafe and shouldn't be used for
converting to and from QString/QByteArray.
https://bugs.webkit.org/show_bug.cgi?id=39009
* bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):
(JSC::Bindings::QtClass::fieldNamed):
2010-05-15 Chang Shu <chang.shu@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Based on the spec and Philip Taylor's test suite, createImageData() should throw
an INDEX_SIZE_ERR exception if either the sw or sh arguments are zero.
The link to the spec:
http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.imageData.getcreate.zero
https://bugs.webkit.org/show_bug.cgi?id=39166
The complete test suite is in the process of checking in.
https://bugs.webkit.org/show_bug.cgi?id=20553
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createImageData):
2010-05-15 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
XMLHttpRequest.getResponseHeader doesn't need to be custom
https://bugs.webkit.org/show_bug.cgi?id=39125
I don't see any reason this method needs to be custom. No new tests
because there's no behavior change.
* bindings/js/JSXMLHttpRequestCustom.cpp:
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
* xml/XMLHttpRequest.idl:
2010-05-15 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
XMLHttpRequest.setRequestHeader shouldn't be custom
https://bugs.webkit.org/show_bug.cgi?id=39124
I don't see any reason why this method needs to be custom. No tests
because no behavior change.
* bindings/js/JSXMLHttpRequestCustom.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_method_that_requires_all_args):
(webkit_dom_test_obj_method_that_requires_all_args_and_throws):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj methodThatRequiresAllArgs:objArg:]):
(-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::methodThatRequiresAllArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::ConfigureV8TestObjTemplate):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
* xml/XMLHttpRequest.idl:
2010-05-14 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=39048
<rdar://problem/7978384> REGRESSION (r55802): XML errors on Google maps ("Entity 'nbsp' not
defined") with JavaScript disabled
Google Maps goes into mobile mode if JavaScript is disabled for some reason, and sends XHTML
content with XHTML Mobile DOCTYPE. We want to handle it whether XHTMLMP is enabled or not.
Test: fast/doctypes/xhtml-with-xhtmlmp-doctype.xhtml
* dom/XMLTokenizerLibxml2.cpp: (WebCore::externalSubsetHandler): Restore pre-55802 behavior
for builds that don't have XHTMLMP enabled. Given that r55802 negated the condition without
breaking XHTMLMP, this line is actually always needed.
2010-05-15 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Darin Fisher.
Fixing LayerChromium hierarchy updates where due to mixed ownership
handling, sublayer updates didn't always properly update parent-to-child
and child-to-parent pointers in sync.
https://bugs.webkit.org/show_bug.cgi?id=39138
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::~LayerChromium):
(WebCore::LayerChromium::setNeedsCommit): Typo fix.
(WebCore::LayerChromium::insertSublayer):
(WebCore::LayerChromium::removeFromSuperlayer):
(WebCore::LayerChromium::removeSublayer):
(WebCore::LayerChromium::replaceSublayer):
(WebCore::LayerChromium::removeAllSublayers):
(WebCore::LayerChromium::setSublayers):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setSuperlayer):
2010-05-15 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Timothy Hatcher.
Got rid of absolute positioning in favor of flex boxes where possible.
Added shadow for help window.
Changed window style names to more comprehensible.
https://bugs.webkit.org/show_bug.cgi?id=39120
* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen):
* inspector/front-end/helpScreen.css:
(.help-window-outer):
(body.attached .help-window-outer):
(.help-window-main):
(body.attached .help-window-main):
(.help-window-caption):
(body.attached .help-window-caption):
(.help-window-title):
(.help-scrollable):
(.help-close-button):
(body.platform-mac .help-close-button):
(body:not(.platform-mac) .help-close-button):
2010-05-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r59549.
http://trac.webkit.org/changeset/59549
https://bugs.webkit.org/show_bug.cgi?id=39167
Broke Chromium build (Requested by abarth on #webkit).
* bindings/scripts/CodeGeneratorV8.pm:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::suspend):
(WebCore::IDBRequest::resume):
(WebCore::IDBRequest::timerFired):
(WebCore::IDBRequest::onEventCommon):
* storage/IDBRequest.h:
2010-05-15 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Darin Fisher.
Adding code path for composited layers (LayerChromium) containing only
an Image element.
https://bugs.webkit.org/show_bug.cgi?id=39142
No new tests, covered under the existing tests for composited layers.
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::updateContentsImage):
* platform/graphics/chromium/GraphicsLayerChromium.h:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setContents):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::contents):
2010-05-15 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IDBRequest is not a proper ActiveDomObject
https://bugs.webkit.org/show_bug.cgi?id=39001
Add IDBRequest interface to the IsActiveDomType
routine of the CodeGeneratorV8.pm.
Rename IDBRequest::m_stopped to m_suspended and reset
the flag when resume() is called.
No new tests, Indexed Database isn't yet testable.
* bindings/scripts/CodeGeneratorV8.pm:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::suspend):
(WebCore::IDBRequest::resume):
(WebCore::IDBRequest::timerFired):
(WebCore::IDBRequest::onEventCommon):
* storage/IDBRequest.h:
2010-05-15 Andrei Bucur <abucur@adobe.com>
Reviewed by Gustavo Noronha Silva.
Functions using the cairo_pattern_t object returned by
Pattern::createPlatformPattern sould destroy it after the painting
operation. Failing to do so causes memory leaks.
Test: No test was added because the patch adds no new functionality.
It just completes the normal life cycle of a cairo_pattern_t object.
* platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::setPlatformFill):
(WebCore::setPlatformStroke):
2010-05-15 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kent Tamura.
Initial support for HTMLMeterElement
https://bugs.webkit.org/show_bug.cgi?id=38140
This patch adds support for HTMLMeterElement, including default rendering
of the meter element. That is because some platforms do not have a native gauge.
The feature is turned on only for the Qt platform.
Tests: fast/dom/HTMLMeterElement/meter-element.html
fast/dom/HTMLMeterElement/set-meter-properties.html
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* css/html.css:
(meter):
(meter::-webkit-meter):
* html/HTMLAttributeNames.in:
* html/HTMLElement.cpp:
(WebCore::inlineTagList):
* html/HTMLElementsAllInOne.cpp:
* html/HTMLMeterElement.cpp: Added.
(WebCore::HTMLMeterElement::HTMLMeterElement):
(WebCore::HTMLMeterElement::create):
(WebCore::HTMLMeterElement::createRenderer):
(WebCore::HTMLMeterElement::formControlType):
(WebCore::HTMLMeterElement::parseMappedAttribute):
(WebCore::HTMLMeterElement::min):
(WebCore::HTMLMeterElement::setMin):
(WebCore::HTMLMeterElement::max):
(WebCore::HTMLMeterElement::setMax):
(WebCore::HTMLMeterElement::value):
(WebCore::HTMLMeterElement::setValue):
(WebCore::HTMLMeterElement::low):
(WebCore::HTMLMeterElement::setLow):
(WebCore::HTMLMeterElement::high):
(WebCore::HTMLMeterElement::setHigh):
(WebCore::HTMLMeterElement::optimum):
(WebCore::HTMLMeterElement::setOptimum):
* html/HTMLMeterElement.h: Added.
(WebCore::HTMLMeterElement::recalcWillValidate):
* html/HTMLMeterElement.idl: Added.
* html/HTMLTagNames.in:
* page/DOMWindow.idl:
* platform/ThemeTypes.h:
* rendering/RenderMeter.cpp: Added.
(WebCore::RenderMeter::RenderMeter):
(WebCore::RenderMeter::layout):
(WebCore::RenderMeter::updateFromElement):
* rendering/RenderMeter.h: Added.
(WebCore::RenderMeter::renderName):
(WebCore::RenderMeter::isMeter):
(WebCore::toRenderMeter):
* rendering/RenderObject.h:
(WebCore::RenderObject::isMeter):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore::RenderTheme::adjustMeterStyle):
(WebCore::RenderTheme::paintMeter):
* rendering/RenderTheme.h:
2010-05-15 Eric Uhrhane <ericu@chromium.org>
Reviewed by Dmitry Titov.
Add bindings for async DB API in Workers.
https://bugs.webkit.org/show_bug.cgi?id=34992
Tests: storage/change-version-handle-reuse-worker.html
storage/execute-sql-args-worker.html
* bindings/js/JSWorkerContextCustom.cpp: Add openDatabase binding.
(WebCore::JSWorkerContext::openDatabase):
* bindings/v8/custom/V8WorkerContextCustom.cpp: Add openDatabase stub; Chromium will need work both in V8 and in the browser process before we can turn this on there.
(WebCore::V8WorkerContext::openDatabaseCallback):
Add NoStaticTables flags to all objects now shared with workers.
* storage/Database.idl:
* storage/SQLError.idl:
* storage/SQLResultSet.idl:
* storage/SQLResultSetRowList.idl:
* storage/SQLTransaction.idl:
* workers/WorkerContext.h: Add databaseExceededQuota.
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::databaseExceededQuota): Add stub implementation for testing; you just get 5MB for now.
(WebCore::WorkerContext::openDatabase): Remove invalid assertion.
Add the IDL for the call to openDatabase.
* workers/WorkerContext.idl:
2010-05-15 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Adam Treat.
[EFL] Add build system for the EFL port.
http://webkit.org/b/37945
* CMakeLists.txt: Added.
* CMakeListsEfl.txt: Added.
* config.h: Add conditional to look for cmakeconfig.h.
2010-05-15 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Clipboard.setData doesn't need to be custom
https://bugs.webkit.org/show_bug.cgi?id=39133
The implementation of the custom binding for this function was a bit
different than its declaration in the IDL file. I've updated the IDL
to match the implementation, but we probably should check whether our
behavior is correct with respect to the specification.
No tests because I've maintained our current behavior.
* bindings/js/JSClipboardCustom.cpp:
* bindings/v8/custom/V8ClipboardCustom.cpp:
* dom/Clipboard.idl:
2010-05-15 Yaar Schnitman <yaar@chromium.org>
Reviewed by Adam Barth.
V8 overload support ported to JSC. Unforking of overloaded declarations in WebGL & Canvas will be done in subsequent patches.
https://bugs.webkit.org/show_bug.cgi?id=38920
Note that JSTestCallback.cpp/h include minor irrelevant changes too since somebody forgot to update them after changing the JS generator.
* bindings/scripts/CodeGenerator.pm:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::JSTestCallback):
(WebCore::JSTestCallback::~JSTestCallback):
* bindings/scripts/test/JS/JSTestCallback.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::testObjPrototypeFunctionOverloadedMethod):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/TestObj.idl:
2010-05-15 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=30500
[Gtk] Find a way for WebKit to "announce" itself so that ATs can readily distinguish it from true Gtk/Gail
The "announcement" is now made in the form of an object attribute
associated with the AtkObject.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_get_attributes):
2010-05-15 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Show a console message when X-Frame-Options blocks a load
https://bugs.webkit.org/show_bug.cgi?id=39087
The blank page confuses people when X-Frame-Options blocks a load. The
console message should at least give them a hint as to what's going on.
* dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
2010-05-15 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Geoffrey Garen.
WebInspector: JSC Should provide heap size info for Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=38420
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/ScriptGCEvent.cpp: Added.
(WebCore::ScriptGCEvent::getHeapSize):
* bindings/js/ScriptGCEvent.h:
2010-05-15 Dave Tapuska <dtapuska@rim.com>
Reviewed by Darin Adler.
Fix alignment faults on ARMv5TE architectures.
In debug mode the RenderAreaDebugHeader was 12 bytes which
caused an alignment failure for RenderObjects because they
would start on a 4 byte boundary. Align the RenderArenaDebugHeader
using the ARENA_ALIGN macro.
In NDEBUG mode the RenderArena objects come from a pool which
has 4 byte alignment. Allow the alignment to be based on the
AllocAlignmentInteger. This define will be activated for ARMv5TE.
https://bugs.webkit.org/show_bug.cgi?id=19946
2010-05-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
XMLHttpRequest.overrideMimeType doesn't need to be custom
https://bugs.webkit.org/show_bug.cgi?id=39127
I don't see any reason why this method should be custom. No tests
because no behavior change.
* bindings/js/JSXMLHttpRequestCustom.cpp:
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
* xml/XMLHttpRequest.idl:
2010-05-14 Adele Peterson <adele@apple.com>
Reviewed by Dave Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=39095
<rdar://problem/7984158> REGRESSION (r53085): Infinite recursion in Position::getInlineBoxAndOffset when changing writing direction to right-to-left
Test: editing/selection/applystyle-to-inline-inside-block.html
* dom/Position.cpp: (WebCore::Position::getInlineBoxAndOffset): Now that this function correctly goes in and out of editable areas by calling
downstreamIgnoringEditingBoundaries and upstreamIgnoringEditingBoundaries for blocks (added in r58665), we no longer need a special case to
jump out to the parent when we hit an inline (which was added in r53085 when this issue was introduced).
2010-05-14 Brian Weinstein <bweinstein@apple.com>
Reviewed by Mark Rowe.
Hopefully a last fix for the build. Call -mkdir instead of mkdir, so we don't bail if the mkdir call fails. Additionally,
use the %Env% syntax instead of $(Env), which is what we need if we are referring to Windows environment variables instead
of nmake variables.
* WebCore.vcproj/WebCore.make:
2010-05-14 Stephanie Lewis <slewis@apple.com>
Rubber-stamped by Mark Rowe.
Update order files.
* WebCore.order:
2010-05-14 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=39137
Make RenderLayers position properly inside multicolumn layout.
(1) Create RenderLayers when column properties are specified. This allows descendant layers to easily
know they are inside a multicolumn layout when positioning.
(2) Patch updateLayerPosition to offset the layer into the first column that contains the layer. Splitting
of a layer across columns still does not work, but the layer will now at least appear in the first column in
which it occurs.
(3) Fix pagination bugs caused by the fact that visual overflow doesn't propagate up the line box tree when layers
are involved. Make sure to use lineTop and lineBottom in this case (it's not perfect, but it gets most cases
working properly). With this change elements like <video> will paginate properly and not get split across pages.
(4) Make column repainting and layer positioning work with RTL columns by fixing adjustForColumns to
account for RTL.
(5) Fix RTL pagination by making sure the column pagination rects are the content width of the whole block and not just
the width of one column.
Added fast/multicol/layers-in-multicol.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustForColumns):
* rendering/RenderBox.h:
(WebCore::RenderBox::locationOffset):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::requiresLayer):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint):
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
* rendering/RenderView.h:
(WebCore::RenderView::requiresLayer):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::specifiesColumns):
2010-05-14 Leon Clarke <leonclarke@google.com>
Reviewed by Steve Block.
Refactor signature of tokenizeRelAttribute and the variables it refers to so that new features don't keep changing the signature, and make m_disabledState into an enum.
https://bugs.webkit.org/show_bug.cgi?id=38900
No new tests. Refactoring only.
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::setDisabledState):
(WebCore::HTMLLinkElement::parseMappedAttribute):
(WebCore::HTMLLinkElement::tokenizeRelAttribute):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::addSubresourceAttributeURLs):
* html/HTMLLinkElement.h:
(WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
(WebCore::HTMLLinkElement::isAlternate):
(WebCore::HTMLLinkElement::isDisabled):
(WebCore::HTMLLinkElement::isEnabledViaScript):
(WebCore::HTMLLinkElement::isIcon):
(WebCore::HTMLLinkElement::):
* html/PreloadScanner.cpp:
(WebCore::PreloadScanner::processAttribute):
2010-05-14 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsLayer caches directly composited images
https://bugs.webkit.org/show_bug.cgi?id=38444
Directly-composited images and solid fills shouldn't be cached, as that cache
is never used (see GraphicsLayerQtImpl::paint). Cache is only relevant for HTML content,
but we were missing that test.
The fix makes sure we only cache HTML content.
No new tests: this is a minor optimization.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::flushChanges):
2010-05-14 Brian Weinstein <bweinstein@apple.com>
Reviewed by Mark Rowe.
Build fix. Had the environment variables wrong for source and destination of the copy operation
that was added.
* WebCore.vcproj/WebCore.make:
2010-05-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove custom bindings for HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=38344
Fix a bug in the TestObj.idl file and update expected results. This
was originally part of a larger change reviewed by Eric, but I'm
landing it separately to help me understand the more interesting bits
of the patch clearly.
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_get_attr_with_setter_exception):
(webkit_dom_test_obj_set_attr_with_setter_exception):
(webkit_dom_test_obj_set_attr_with_getter_exception):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjAttrWithSetterException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjAttrWithGetterException):
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj attrWithSetterException]):
(-[DOMTestObj setAttrWithSetterException:]):
(-[DOMTestObj setAttrWithGetterException:]):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter):
(WebCore::TestObjInternal::attrWithSetterExceptionAttrSetter):
(WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter):
2010-05-14 Kenneth Russell <kbr@google.com>
Reviewed by Darin Adler.
Rename WebGLArray types to TypedArray types
https://bugs.webkit.org/show_bug.cgi?id=39091
Extended functionality of do-webcore-rename script and used it to
rename the WebGLArray types to the TypedArray naming convention.
The only source files which were touched by hand, and which are
being manually reviewed, are:
WebCore/page/DOMWindow.idl
WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
These only needed to be touched to update the aliases between the
WebGLArray and TypedArray names introduced in bug 39036. (It was
not feasible to have do-webcore-rename handle this as it would
introduce circular renamings.) These aliases will be removed in
roughly a month once existing WebGL content has been updated.
No new tests; covered under existing WebGL tests. Updated
constructed-objects-prototypes and prototype-inheritance-2 tests.
Ran all layout tests in Safari and all WebGL tests in Chromium.
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSArrayBufferConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLArrayBufferConstructor.cpp.
(WebCore::):
(WebCore::JSArrayBufferConstructor::JSArrayBufferConstructor):
(WebCore::constructCanvasArrayBuffer):
(WebCore::JSArrayBufferConstructor::getConstructData):
* bindings/js/JSArrayBufferConstructor.h: Copied from WebCore/bindings/js/JSWebGLArrayBufferConstructor.h.
(WebCore::construct):
* bindings/js/JSArrayBufferViewCustom.cpp: Copied from WebCore/bindings/js/JSWebGLArrayCustom.cpp.
(WebCore::toJS):
(WebCore::JSArrayBufferView::slice):
* bindings/js/JSArrayBufferViewHelper.h: Copied from WebCore/bindings/js/JSWebGLArrayHelper.h.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::arrayBuffer):
(WebCore::JSDOMWindow::int8Array):
(WebCore::JSDOMWindow::uint8Array):
(WebCore::JSDOMWindow::int32Array):
(WebCore::JSDOMWindow::uint32Array):
(WebCore::JSDOMWindow::int16Array):
(WebCore::JSDOMWindow::uint16Array):
(WebCore::JSDOMWindow::floatArray):
(WebCore::JSDOMWindow::webGLArrayBuffer):
(WebCore::JSDOMWindow::webGLByteArray):
(WebCore::JSDOMWindow::webGLUnsignedByteArray):
(WebCore::JSDOMWindow::webGLIntArray):
(WebCore::JSDOMWindow::webGLUnsignedIntArray):
(WebCore::JSDOMWindow::webGLShortArray):
(WebCore::JSDOMWindow::webGLUnsignedShortArray):
(WebCore::JSDOMWindow::webGLFloatArray):
* bindings/js/JSFloatArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLFloatArrayConstructor.cpp.
(WebCore::):
(WebCore::JSFloatArrayConstructor::JSFloatArrayConstructor):
(WebCore::constructCanvasFloatArray):
(WebCore::JSFloatArrayConstructor::getConstructData):
* bindings/js/JSFloatArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLFloatArrayConstructor.h.
* bindings/js/JSFloatArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLFloatArrayCustom.cpp.
(WebCore::JSFloatArray::indexSetter):
(WebCore::toJS):
(WebCore::JSFloatArray::set):
* bindings/js/JSInt16ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLShortArrayConstructor.cpp.
(WebCore::):
(WebCore::JSInt16ArrayConstructor::JSInt16ArrayConstructor):
(WebCore::constructCanvasShortArray):
(WebCore::JSInt16ArrayConstructor::getConstructData):
* bindings/js/JSInt16ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLShortArrayConstructor.h.
* bindings/js/JSInt16ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLShortArrayCustom.cpp.
(WebCore::JSInt16Array::indexSetter):
(WebCore::toJS):
(WebCore::JSInt16Array::set):
* bindings/js/JSInt32ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLIntArrayConstructor.cpp.
(WebCore::):
(WebCore::JSInt32ArrayConstructor::JSInt32ArrayConstructor):
(WebCore::constructCanvasIntArray):
(WebCore::JSInt32ArrayConstructor::getConstructData):
* bindings/js/JSInt32ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLIntArrayConstructor.h.
* bindings/js/JSInt32ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLIntArrayCustom.cpp.
(WebCore::JSInt32Array::indexSetter):
(WebCore::toJS):
(WebCore::JSInt32Array::set):
* bindings/js/JSInt8ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLByteArrayConstructor.cpp.
(WebCore::):
(WebCore::JSInt8ArrayConstructor::JSInt8ArrayConstructor):
(WebCore::constructCanvasByteArray):
(WebCore::JSInt8ArrayConstructor::getConstructData):
* bindings/js/JSInt8ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLByteArrayConstructor.h.
* bindings/js/JSInt8ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLByteArrayCustom.cpp.
(WebCore::JSInt8Array::indexSetter):
(WebCore::toJS):
(WebCore::JSInt8Array::set):
* bindings/js/JSUint16ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedShortArrayConstructor.cpp.
(WebCore::):
(WebCore::JSUint16ArrayConstructor::JSUint16ArrayConstructor):
(WebCore::constructCanvasUnsignedShortArray):
(WebCore::JSUint16ArrayConstructor::getConstructData):
* bindings/js/JSUint16ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLUnsignedShortArrayConstructor.h.
* bindings/js/JSUint16ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedShortArrayCustom.cpp.
(WebCore::JSUint16Array::indexSetter):
(WebCore::toJS):
(WebCore::JSUint16Array::set):
* bindings/js/JSUint32ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedIntArrayConstructor.cpp.
(WebCore::):
(WebCore::JSUint32ArrayConstructor::JSUint32ArrayConstructor):
(WebCore::constructCanvasUnsignedIntArray):
(WebCore::JSUint32ArrayConstructor::getConstructData):
* bindings/js/JSUint32ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLUnsignedIntArrayConstructor.h.
* bindings/js/JSUint32ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedIntArrayCustom.cpp.
(WebCore::JSUint32Array::indexSetter):
(WebCore::toJS):
(WebCore::JSUint32Array::set):
* bindings/js/JSUint8ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedByteArrayConstructor.cpp.
(WebCore::):
(WebCore::JSUint8ArrayConstructor::JSUint8ArrayConstructor):
(WebCore::constructCanvasUnsignedByteArray):
(WebCore::JSUint8ArrayConstructor::getConstructData):
* bindings/js/JSUint8ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLUnsignedByteArrayConstructor.h.
* bindings/js/JSUint8ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedByteArrayCustom.cpp.
(WebCore::JSUint8Array::indexSetter):
(WebCore::toJS):
(WebCore::JSUint8Array::set):
* bindings/js/JSWebGLArrayBufferConstructor.cpp: Removed.
* bindings/js/JSWebGLArrayBufferConstructor.h: Removed.
* bindings/js/JSWebGLArrayCustom.cpp: Removed.
* bindings/js/JSWebGLArrayHelper.h: Removed.
* bindings/js/JSWebGLByteArrayConstructor.cpp: Removed.
* bindings/js/JSWebGLByteArrayConstructor.h: Removed.
* bindings/js/JSWebGLByteArrayCustom.cpp: Removed.
* bindings/js/JSWebGLFloatArrayConstructor.cpp: Removed.
* bindings/js/JSWebGLFloatArrayConstructor.h: Removed.
* bindings/js/JSWebGLFloatArrayCustom.cpp: Removed.
* bindings/js/JSWebGLIntArrayConstructor.cpp: Removed.
* bindings/js/JSWebGLIntArrayConstructor.h: Removed.
* bindings/js/JSWebGLIntArrayCustom.cpp: Removed.
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::bufferData):
(WebCore::JSWebGLRenderingContext::bufferSubData):
(WebCore::JSWebGLRenderingContext::texImage2D):
(WebCore::JSWebGLRenderingContext::texSubImage2D):
(WebCore::dataFunctionf):
(WebCore::dataFunctioni):
(WebCore::dataFunctionMatrix):
* bindings/js/JSWebGLShortArrayConstructor.cpp: Removed.
* bindings/js/JSWebGLShortArrayConstructor.h: Removed.
* bindings/js/JSWebGLShortArrayCustom.cpp: Removed.
* bindings/js/JSWebGLUnsignedByteArrayConstructor.cpp: Removed.
* bindings/js/JSWebGLUnsignedByteArrayConstructor.h: Removed.
* bindings/js/JSWebGLUnsignedByteArrayCustom.cpp: Removed.
* bindings/js/JSWebGLUnsignedIntArrayConstructor.cpp: Removed.
* bindings/js/JSWebGLUnsignedIntArrayConstructor.h: Removed.
* bindings/js/JSWebGLUnsignedIntArrayCustom.cpp: Removed.
* bindings/js/JSWebGLUnsignedShortArrayConstructor.cpp: Removed.
* bindings/js/JSWebGLUnsignedShortArrayConstructor.h: Removed.
* bindings/js/JSWebGLUnsignedShortArrayCustom.cpp: Removed.
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/custom/V8ArrayBufferCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLArrayBufferCustom.cpp.
(WebCore::V8ArrayBuffer::constructorCallback):
* bindings/v8/custom/V8ArrayBufferViewCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLArrayCustom.cpp.
(WebCore::toV8):
(WebCore::V8ArrayBufferView::sliceCallback):
* bindings/v8/custom/V8ArrayBufferViewCustom.h: Copied from WebCore/bindings/v8/custom/V8WebGLArrayCustom.h.
(WebCore::constructWebGLArray):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::WebGLArrayBufferAccessorGetter):
(WebCore::V8DOMWindow::WebGLByteArrayAccessorGetter):
(WebCore::V8DOMWindow::WebGLUnsignedByteArrayAccessorGetter):
(WebCore::V8DOMWindow::WebGLShortArrayAccessorGetter):
(WebCore::V8DOMWindow::WebGLUnsignedShortArrayAccessorGetter):
(WebCore::V8DOMWindow::WebGLIntArrayAccessorGetter):
(WebCore::V8DOMWindow::WebGLUnsignedIntArrayAccessorGetter):
(WebCore::V8DOMWindow::WebGLFloatArrayAccessorGetter):
* bindings/v8/custom/V8FloatArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLFloatArrayCustom.cpp.
(WebCore::V8FloatArray::constructorCallback):
(WebCore::V8FloatArray::setCallback):
(WebCore::toV8):
* bindings/v8/custom/V8Int16ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLShortArrayCustom.cpp.
(WebCore::V8Int16Array::constructorCallback):
(WebCore::V8Int16Array::setCallback):
(WebCore::toV8):
* bindings/v8/custom/V8Int32ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLIntArrayCustom.cpp.
(WebCore::V8Int32Array::constructorCallback):
(WebCore::V8Int32Array::setCallback):
(WebCore::toV8):
* bindings/v8/custom/V8Int8ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLByteArrayCustom.cpp.
(WebCore::V8Int8Array::constructorCallback):
(WebCore::V8Int8Array::setCallback):
(WebCore::toV8):
* bindings/v8/custom/V8Uint16ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp.
(WebCore::V8Uint16Array::constructorCallback):
(WebCore::V8Uint16Array::setCallback):
(WebCore::toV8):
* bindings/v8/custom/V8Uint32ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp.
(WebCore::V8Uint32Array::constructorCallback):
(WebCore::V8Uint32Array::setCallback):
(WebCore::toV8):
* bindings/v8/custom/V8Uint8ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp.
(WebCore::V8Uint8Array::constructorCallback):
(WebCore::V8Uint8Array::setCallback):
(WebCore::toV8):
* bindings/v8/custom/V8WebGLArrayBufferCustom.cpp: Removed.
* bindings/v8/custom/V8WebGLArrayCustom.cpp: Removed.
* bindings/v8/custom/V8WebGLArrayCustom.h: Removed.
* bindings/v8/custom/V8WebGLByteArrayCustom.cpp: Removed.
* bindings/v8/custom/V8WebGLFloatArrayCustom.cpp: Removed.
* bindings/v8/custom/V8WebGLIntArrayCustom.cpp: Removed.
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):
* bindings/v8/custom/V8WebGLShortArrayCustom.cpp: Removed.
* bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp: Removed.
* bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp: Removed.
* bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp: Removed.
* html/canvas/ArrayBuffer.cpp: Copied from WebCore/html/canvas/WebGLArrayBuffer.cpp.
(WebCore::ArrayBuffer::create):
(WebCore::ArrayBuffer::ArrayBuffer):
(WebCore::ArrayBuffer::data):
(WebCore::ArrayBuffer::byteLength):
(WebCore::ArrayBuffer::~ArrayBuffer):
(WebCore::ArrayBuffer::tryAllocate):
* html/canvas/ArrayBuffer.h: Copied from WebCore/html/canvas/WebGLArrayBuffer.h.
* html/canvas/ArrayBuffer.idl: Copied from WebCore/html/canvas/WebGLArrayBuffer.idl.
* html/canvas/ArrayBufferView.cpp: Copied from WebCore/html/canvas/WebGLArray.cpp.
(WebCore::ArrayBufferView::ArrayBufferView):
(WebCore::ArrayBufferView::~ArrayBufferView):
(WebCore::ArrayBufferView::setImpl):
(WebCore::ArrayBufferView::calculateOffsetAndLength):
* html/canvas/ArrayBufferView.h: Copied from WebCore/html/canvas/WebGLArray.h.
(WebCore::ArrayBufferView::buffer):
(WebCore::ArrayBufferView::verifySubRange):
(WebCore::ArrayBufferView::clampOffsetAndNumElements):
* html/canvas/ArrayBufferView.idl: Copied from WebCore/html/canvas/WebGLArray.idl.
* html/canvas/FloatArray.cpp: Copied from WebCore/html/canvas/WebGLFloatArray.cpp.
(WebCore::FloatArray::create):
(WebCore::FloatArray::FloatArray):
(WebCore::FloatArray::slice):
* html/canvas/FloatArray.h: Copied from WebCore/html/canvas/WebGLFloatArray.h.
(WebCore::FloatArray::set):
(WebCore::FloatArray::item):
* html/canvas/FloatArray.idl: Copied from WebCore/html/canvas/WebGLFloatArray.idl.
* html/canvas/Int16Array.cpp: Copied from WebCore/html/canvas/WebGLShortArray.cpp.
(WebCore::Int16Array::create):
(WebCore::Int16Array::Int16Array):
(WebCore::Int16Array::slice):
* html/canvas/Int16Array.h: Copied from WebCore/html/canvas/WebGLShortArray.h.
* html/canvas/Int16Array.idl: Copied from WebCore/html/canvas/WebGLShortArray.idl.
* html/canvas/Int32Array.cpp: Copied from WebCore/html/canvas/WebGLIntArray.cpp.
(WebCore::Int32Array::create):
(WebCore::Int32Array::Int32Array):
(WebCore::Int32Array::slice):
* html/canvas/Int32Array.h: Copied from WebCore/html/canvas/WebGLIntArray.h.
* html/canvas/Int32Array.idl: Copied from WebCore/html/canvas/WebGLIntArray.idl.
* html/canvas/Int8Array.cpp: Copied from WebCore/html/canvas/WebGLByteArray.cpp.
(WebCore::Int8Array::create):
(WebCore::Int8Array::Int8Array):
(WebCore::Int8Array::slice):
* html/canvas/Int8Array.h: Copied from WebCore/html/canvas/WebGLByteArray.h.
* html/canvas/Int8Array.idl: Copied from WebCore/html/canvas/WebGLByteArray.idl.
* html/canvas/IntegralTypedArrayBase.h: Copied from WebCore/html/canvas/WebGLIntegralTypedArrayBase.h.
(WebCore::IntegralTypedArrayBase::set):
(WebCore::IntegralTypedArrayBase::item):
(WebCore::IntegralTypedArrayBase::IntegralTypedArrayBase):
* html/canvas/TypedArrayBase.h: Copied from WebCore/html/canvas/WebGLTypedArrayBase.h.
(WebCore::TypedArrayBase::set):
(WebCore::TypedArrayBase::TypedArrayBase):
(WebCore::TypedArrayBase::create):
* html/canvas/Uint16Array.cpp: Copied from WebCore/html/canvas/WebGLUnsignedShortArray.cpp.
(WebCore::Uint16Array::create):
(WebCore::Uint16Array::Uint16Array):
(WebCore::Uint16Array::slice):
* html/canvas/Uint16Array.h: Copied from WebCore/html/canvas/WebGLUnsignedShortArray.h.
* html/canvas/Uint16Array.idl: Copied from WebCore/html/canvas/WebGLUnsignedShortArray.idl.
* html/canvas/Uint32Array.cpp: Copied from WebCore/html/canvas/WebGLUnsignedIntArray.cpp.
(WebCore::Uint32Array::create):
(WebCore::Uint32Array::Uint32Array):
(WebCore::Uint32Array::slice):
* html/canvas/Uint32Array.h: Copied from WebCore/html/canvas/WebGLUnsignedIntArray.h.
* html/canvas/Uint32Array.idl: Copied from WebCore/html/canvas/WebGLUnsignedIntArray.idl.
* html/canvas/Uint8Array.cpp: Copied from WebCore/html/canvas/WebGLUnsignedByteArray.cpp.
(WebCore::Uint8Array::create):
(WebCore::Uint8Array::Uint8Array):
(WebCore::Uint8Array::slice):
* html/canvas/Uint8Array.h: Copied from WebCore/html/canvas/WebGLUnsignedByteArray.h.
* html/canvas/Uint8Array.idl: Copied from WebCore/html/canvas/WebGLUnsignedByteArray.idl.
* html/canvas/WebGLArray.cpp: Removed.
* html/canvas/WebGLArray.h: Removed.
* html/canvas/WebGLArray.idl: Removed.
* html/canvas/WebGLArrayBuffer.cpp: Removed.
* html/canvas/WebGLArrayBuffer.h: Removed.
* html/canvas/WebGLArrayBuffer.idl: Removed.
* html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::associateBufferData):
(WebCore::WebGLBuffer::associateBufferSubData):
* html/canvas/WebGLBuffer.h:
(WebCore::WebGLBuffer::elementArrayBuffer):
* html/canvas/WebGLByteArray.cpp: Removed.
* html/canvas/WebGLByteArray.h: Removed.
* html/canvas/WebGLByteArray.idl: Removed.
* html/canvas/WebGLFloatArray.cpp: Removed.
* html/canvas/WebGLFloatArray.h: Removed.
* html/canvas/WebGLFloatArray.idl: Removed.
* html/canvas/WebGLGetInfo.cpp:
(WebCore::WebGLGetInfo::WebGLGetInfo):
(WebCore::WebGLGetInfo::getWebGLFloatArray):
(WebCore::WebGLGetInfo::getWebGLIntArray):
(WebCore::WebGLGetInfo::getWebGLUnsignedByteArray):
* html/canvas/WebGLGetInfo.h:
* html/canvas/WebGLIntArray.cpp: Removed.
* html/canvas/WebGLIntArray.h: Removed.
* html/canvas/WebGLIntArray.idl: Removed.
* html/canvas/WebGLIntegralTypedArrayBase.h: Removed.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
(WebCore::WebGLRenderingContext::getUniform):
(WebCore::WebGLRenderingContext::getVertexAttrib):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::uniform1fv):
(WebCore::WebGLRenderingContext::uniform1iv):
(WebCore::WebGLRenderingContext::uniform2fv):
(WebCore::WebGLRenderingContext::uniform2iv):
(WebCore::WebGLRenderingContext::uniform3fv):
(WebCore::WebGLRenderingContext::uniform3iv):
(WebCore::WebGLRenderingContext::uniform4fv):
(WebCore::WebGLRenderingContext::uniform4iv):
(WebCore::WebGLRenderingContext::uniformMatrix2fv):
(WebCore::WebGLRenderingContext::uniformMatrix3fv):
(WebCore::WebGLRenderingContext::uniformMatrix4fv):
(WebCore::WebGLRenderingContext::vertexAttrib1fv):
(WebCore::WebGLRenderingContext::vertexAttrib2fv):
(WebCore::WebGLRenderingContext::vertexAttrib3fv):
(WebCore::WebGLRenderingContext::vertexAttrib4fv):
(WebCore::WebGLRenderingContext::getWebGLFloatArrayParameter):
(WebCore::WebGLRenderingContext::getWebGLIntArrayParameter):
(WebCore::WebGLRenderingContext::getWebGLUnsignedByteArrayParameter):
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebGLRenderingContext.idl:
* html/canvas/WebGLShortArray.cpp: Removed.
* html/canvas/WebGLShortArray.h: Removed.
* html/canvas/WebGLShortArray.idl: Removed.
* html/canvas/WebGLTypedArrayBase.h: Removed.
* html/canvas/WebGLUnsignedByteArray.cpp: Removed.
* html/canvas/WebGLUnsignedByteArray.h: Removed.
* html/canvas/WebGLUnsignedByteArray.idl: Removed.
* html/canvas/WebGLUnsignedIntArray.cpp: Removed.
* html/canvas/WebGLUnsignedIntArray.h: Removed.
* html/canvas/WebGLUnsignedIntArray.idl: Removed.
* html/canvas/WebGLUnsignedShortArray.cpp: Removed.
* html/canvas/WebGLUnsignedShortArray.h: Removed.
* html/canvas/WebGLUnsignedShortArray.idl: Removed.
* page/DOMWindow.idl:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/mac/GraphicsContext3DMac.cpp:
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::bufferSubData):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::bufferSubData):
2010-05-14 Steve Falkenburg <sfalken@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/7985864> Connection properties dictionary should use standard callbacks for keys, values
https://bugs.webkit.org/show_bug.cgi?id=39132
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::createConnectionProperties):
2010-05-14 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Move the m_width(Length) and m_columns(RenderTable::ColumnStruct)
vector out-of-bounds check out of the ASSERT into the main code.
https://bugs.webkit.org/show_bug.cgi?id=38261
Test: fast/table/fixed-table-layout-large-colspan-crash.html
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
2010-05-14 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r59489.
http://trac.webkit.org/changeset/59489
https://bugs.webkit.org/show_bug.cgi?id=37815
abarth broke the known universe and then some.
* Android.jscbindings.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::executeFunctionInContext):
(WebCore::ScheduledAction::execute):
* bindings/js/ScheduledAction.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
* bindings/js/ScriptController.h:
* bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
* bindings/objc/ObjCEventListener.mm:
(WebCore::ObjCEventListener::handleEvent):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/test/ObjC/DOMTestCallback.mm:
(-[DOMTestCallback callbackWithClass1Param:]):
(-[DOMTestCallback callbackWithClass2Param:strArg:]):
(-[DOMTestCallback callbackWithNonBoolReturnType:]):
(-[DOMTestCallback customCallback:class6Param:]):
* bindings/scripts/test/ObjC/DOMTestInterface.mm:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj readOnlyIntAttr]):
(-[DOMTestObj readOnlyStringAttr]):
(-[DOMTestObj readOnlyTestObjAttr]):
(-[DOMTestObj intAttr]):
(-[DOMTestObj setIntAttr:]):
(-[DOMTestObj longLongAttr]):
(-[DOMTestObj setLongLongAttr:]):
(-[DOMTestObj unsignedLongLongAttr]):
(-[DOMTestObj setUnsignedLongLongAttr:]):
(-[DOMTestObj stringAttr]):
(-[DOMTestObj setStringAttr:]):
(-[DOMTestObj testObjAttr]):
(-[DOMTestObj setTestObjAttr:]):
(-[DOMTestObj attrWithException]):
(-[DOMTestObj setAttrWithException:]):
(-[DOMTestObj attrWithSetterException]):
(-[DOMTestObj setAttrWithSetterException:]):
(-[DOMTestObj attrWithGetterException]):
(-[DOMTestObj setAttrWithGetterException:]):
(-[DOMTestObj customAttr]):
(-[DOMTestObj setCustomAttr:]):
(-[DOMTestObj scriptStringAttr]):
(-[DOMTestObj voidMethod]):
(-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj intMethod]):
(-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj objMethod]):
(-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj serializedValue:]):
(-[DOMTestObj methodWithException]):
(-[DOMTestObj customMethod]):
(-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj customArgsAndException:]):
(-[DOMTestObj addEventListener:listener:useCapture:]):
(-[DOMTestObj removeEventListener:listener:useCapture:]):
(-[DOMTestObj withDynamicFrame]):
(-[DOMTestObj withDynamicFrameAndArg:]):
(-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
(-[DOMTestObj withDynamicFrameAndUserGesture:]):
(-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
(-[DOMTestObj withScriptStateVoid]):
(-[DOMTestObj withScriptStateObj]):
(-[DOMTestObj withScriptStateVoidException]):
(-[DOMTestObj withScriptStateObjException]):
(-[DOMTestObj methodWithOptionalArg:]):
(-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
(-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
* bindings/v8/ScriptController.cpp:
* bindings/v8/ScriptController.h:
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::isURLAllowed):
2010-05-14 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Moving frame.src checks out of the bindings
https://bugs.webkit.org/show_bug.cgi?id=37815
Moved JavaScript frame.src checks out of bindings and into
HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
so ExecState is available inside core DOM. Updated affected bindings
(except for GObject, which will need to be updated to avoid origin
failures inside native code).
* Android.jscbindings.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::executeFunctionInContext):
(WebCore::ScheduledAction::execute):
* bindings/js/ScheduledAction.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::canAccessFromCurrentOrigin):
* bindings/js/ScriptController.h:
* bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
* bindings/objc/ObjCEventListener.mm:
(WebCore::ObjCEventListener::handleEvent):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/test/ObjC/DOMTestCallback.mm:
(-[DOMTestCallback callbackWithClass1Param:]):
(-[DOMTestCallback callbackWithClass2Param:strArg:]):
(-[DOMTestCallback callbackWithNonBoolReturnType:]):
(-[DOMTestCallback customCallback:class6Param:]):
* bindings/scripts/test/ObjC/DOMTestInterface.mm:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj readOnlyIntAttr]):
(-[DOMTestObj readOnlyStringAttr]):
(-[DOMTestObj readOnlyTestObjAttr]):
(-[DOMTestObj intAttr]):
(-[DOMTestObj setIntAttr:]):
(-[DOMTestObj longLongAttr]):
(-[DOMTestObj setLongLongAttr:]):
(-[DOMTestObj unsignedLongLongAttr]):
(-[DOMTestObj setUnsignedLongLongAttr:]):
(-[DOMTestObj stringAttr]):
(-[DOMTestObj setStringAttr:]):
(-[DOMTestObj testObjAttr]):
(-[DOMTestObj setTestObjAttr:]):
(-[DOMTestObj attrWithException]):
(-[DOMTestObj setAttrWithException:]):
(-[DOMTestObj attrWithSetterException]):
(-[DOMTestObj setAttrWithSetterException:]):
(-[DOMTestObj attrWithGetterException]):
(-[DOMTestObj setAttrWithGetterException:]):
(-[DOMTestObj customAttr]):
(-[DOMTestObj setCustomAttr:]):
(-[DOMTestObj scriptStringAttr]):
(-[DOMTestObj voidMethod]):
(-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj intMethod]):
(-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj objMethod]):
(-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj serializedValue:]):
(-[DOMTestObj methodWithException]):
(-[DOMTestObj customMethod]):
(-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj customArgsAndException:]):
(-[DOMTestObj addEventListener:listener:useCapture:]):
(-[DOMTestObj removeEventListener:listener:useCapture:]):
(-[DOMTestObj withDynamicFrame]):
(-[DOMTestObj withDynamicFrameAndArg:]):
(-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
(-[DOMTestObj withDynamicFrameAndUserGesture:]):
(-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
(-[DOMTestObj withScriptStateVoid]):
(-[DOMTestObj withScriptStateObj]):
(-[DOMTestObj withScriptStateVoidException]):
(-[DOMTestObj withScriptStateObjException]):
(-[DOMTestObj methodWithOptionalArg:]):
(-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
(-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::canAccessFromCurrentOrigin):
* bindings/v8/ScriptController.h:
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::isURLAllowed):
2010-05-14 Sergey Ulanov <sergeyu@chromium.org>
Reviewed by Dmitry Titov and Brett Wilson.
Adding resized image caching for Skia.
https://bugs.webkit.org/show_bug.cgi?id=39085
Tests: HTML5 video on YouTube.
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::Image::drawPattern): Use bitmap->resizedBitmap() to cache resized image when possible.
2010-05-14 Alexey Proskuryakov <ap@apple.com>
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=39008
<rdar://problem/7976142> REGRESSION (r58950): Webkit crashes on clicking back button when in Hotmail
Test: fast/parser/tokenizer-close-during-document-write.html
* dom/Document.cpp: (WebCore::Document::write): Check that the tokenizer is still around
after calling write(). It can become null (as it happens in regression test), and I don't
see any guarantee that it would never be replaced with a different one (but I can't make a
test for that).
2010-05-14 Jian Li <jianli@chromium.org>
Rubber-stamped by Dmitry Titov.
Fix the code indentation inside a namespace to be consistent with the
style guide.
* workers/GenericWorkerTask.h:
2010-05-14 Jian Li <jianli@chromium.org>
Reviewed by Dmitry Titov.
Remove the ENABLE(WORKERS) guard from GenericWorkerTask.h and rename
all occurrences of GenericWorkerTask* to GenericTask* in this file.
https://bugs.webkit.org/show_bug.cgi?id=39129
I will have another patch to rename the file and move it to the right
place.
* workers/GenericWorkerTask.h:
(WebCore::):
(WebCore::GenericTask1::create):
(WebCore::GenericTask1::GenericTask1):
(WebCore::GenericTask2::create):
(WebCore::GenericTask2::GenericTask2):
(WebCore::GenericTask3::create):
(WebCore::GenericTask3::GenericTask3):
(WebCore::GenericTask4::create):
(WebCore::GenericTask4::GenericTask4):
(WebCore::GenericTask5::create):
(WebCore::GenericTask5::GenericTask5):
(WebCore::GenericTask6::create):
(WebCore::GenericTask6::GenericTask6):
(WebCore::GenericTask7::create):
(WebCore::GenericTask7::GenericTask7):
(WebCore::GenericTask8::create):
(WebCore::GenericTask8::GenericTask8):
(WebCore::createCallbackTask):
2010-05-14 Evan Martin <evan@chromium.org>
Reviewed by David Levin.
[chromium] don't call fontconfig twice in complex text path
https://bugs.webkit.org/show_bug.cgi?id=38701
Previously getFontDataForCharacters would call fontconfig once to
resolve a font name, then pass that name to getCachedFontPlatformData
to load the font. This would be two trips through fontconfig (including
IPCs). With this change, we completely load the font in the first pass.
This patch is actually the same code as in r58341, which was reverted
because of a performance problem; a performance improvement has now
been committed, and with that change in place this change improves
the Chromium intl2 page cycler performance by another 5%.
See also https://bugs.webkit.org/show_bug.cgi?id=37904 .
Test: fast/text/international/bold-bengali.html
(Was checked in as part of the first attempt at this change, continues
to pass after this change.)
* platform/chromium/ChromiumBridge.h:
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getFontDataForCharacters):
2010-05-14 Young Han Lee <joybro@company100.net>
Reviewed by Darin Adler.
Don't include RetainPtr.h unless PLATFORM(CF) is set.
The RetainPtr is only used for CF platform in this class.
https://bugs.webkit.org/show_bug.cgi?id=39043
No new tests, there is no new functionality.
* platform/network/curl/ResourceHandleManager.cpp:
2010-05-14 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Build fix, we need to copy over the files in $(WebKitOutputDir)/include/JavaScriptCore/private before
WebCore builds. This is because we are building a couple WTF files in WebCore and JavaScriptCore.
* WebCore.vcproj/WebCore.make:
2010-05-14 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed. Attempt to fix chromium's memory bot error.
More :visited link optimizations to reduce memory usage
https://bugs.webkit.org/show_bug.cgi?id=39084
The original change (r59386) adds check for m_element in initElement.
As don't initialize m_element in the constructor of CSSStyleSelector,
valgrind complains.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
2010-05-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Darin Adler.
CSSParser::parseColor() shouldn't alter 'color' unless passed a valid color string.
https://bugs.webkit.org/show_bug.cgi?id=39031
* css/CSSParser.cpp:
(WebCore::CSSParser::parseColor):
* editing/ApplyStyleCommand.cpp:
(WebCore::StyleChange::extractTextStyles): Don't depend on old behavior.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setShadow): Remove dead code.
2010-05-14 Jens Alfke <snej@chromium.org>
Reviewed by John Sullivan.
Don't clear yellow autofill highlight from text fields until the user edits them.
https://bugs.webkit.org/show_bug.cgi?id=39032
No new tests (Couldn't find any autofill tests. The flag doesn't seem to be exposed to JS.)
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::handleFocusEvent): Don't clear the autofilled flag.
(WebCore::HTMLInputElement::setValueFromRenderer): Clear the autofilled flag.
2010-05-14 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Must implement OpenGL ES 2.0 semantics for NPOT textures
https://bugs.webkit.org/show_bug.cgi?id=33805
Test: fast/canvas/webgl/texture-npot.html
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::WebGLRenderingContext): Create black 1x1 textures.
(WebCore::WebGLRenderingContext::bindTexture): Set texture dimensionality.
(WebCore::WebGLRenderingContext::copyTexImage2D): Error check, set texture size.
(WebCore::WebGLRenderingContext::drawArrays): Bind to black textures if needed.
(WebCore::WebGLRenderingContext::drawElements): Bind to black textures if needed.
(WebCore::WebGLRenderingContext::generateMipmap): Error check.
(WebCore::WebGLRenderingContext::texImage2DBase): Error check, set texture size.
(WebCore::WebGLRenderingContext::texParameterf): Set texture parameter.
(WebCore::WebGLRenderingContext::texParameteri): Ditto.
(WebCore::WebGLRenderingContext::handleNPOTTextures): Bind to black textures if needed before draw, and bind back to original textures after draw.
* html/canvas/WebGLRenderingContext.h: Add black 1x1 textures.
* html/canvas/WebGLTexture.cpp: Add support to track NPOT textures.
(WebCore::WebGLTexture::createBlackTexture1x1): Create a black 1x1 texture.
(WebCore::WebGLTexture::WebGLTexture): Initialize parameters and states.
(WebCore::WebGLTexture::setDimensionality): Set dimensionality.
(WebCore::WebGLTexture::setParameteri): Set parameter.
(WebCore::WebGLTexture::setParameterf): Ditto.
(WebCore::WebGLTexture::setSize): Set level 0 texture size.
(WebCore::WebGLTexture::isNPOT): Whether the texture is NPOT.
(WebCore::WebGLTexture::updateNPOTStates): Calculate NPOT and NeedToUseBlackTexture states.
* html/canvas/WebGLTexture.h: Add support to track NPOT textures.
(WebCore::WebGLTexture::isNPOT):
(WebCore::WebGLTexture::needToUseBlackTexture):
2010-05-14 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add help on keyboard shortcuts (take 2).
https://bugs.webkit.org/show_bug.cgi?id=38667
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane):
(WebInspector.CallStackSidebarPane.prototype._placardSelected):
(WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype._registerShortcuts):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._registerShortcuts):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._keyDown):
* inspector/front-end/HelpScreen.js: Added.
* inspector/front-end/KeyboardShortcut.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor):
(WebInspector.ScriptsPanel.prototype._registerShortcuts):
* inspector/front-end/ShortcutsHelp.js: Added.
* inspector/front-end/SidebarPane.js:
(WebInspector.SidebarPane.prototype._onTitleKeyDown):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.removeSection):
(WebInspector.StylesSidebarPane.prototype.registerShortcuts):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._handleKeyDown):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/helpScreen.css: Added.
2010-05-14 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Fisher.
[chromium] Update chromium port to send/receive cached metadata
https://bugs.webkit.org/show_bug.cgi?id=38665
No new tests because no new functionality.
* platform/chromium/ChromiumBridge.h:
* platform/network/chromium/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::responseTime):
(WebCore::ResourceResponse::setResponseTime):
2010-05-14 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Chromium-specific fix to prevent zombie infobars.
https://bugs.webkit.org/show_bug.cgi?id=38948
* bindings/v8/ScriptController.cpp
(WebCore::ScriptController::processingUserGesture):
Require a more definite "no" signal.
* loader/RedirectScheduler.cpp:
(WebCore::ScheduledFormSubmission::fire):
Use a very strong yes / no signal; no need for "possible" here.
* dom/UserGestureIndicator.h:
* dom/UserGestureIndicator.cpp:
Adapt to tri-state: definitely yes; definitely no; not sure.
2010-05-14 Aaron Kennedy <tffeeb@gmail.com>
Reviewed by Simon Hausmann.
[Qt] JavaScript unable to invoke methods declared in QML
https://bugs.webkit.org/show_bug.cgi?id=38949
JavaScript code executed by webkit cannot call into QML declared
methods, as it does not check for dynamic meta objects.
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::stringValue): Use QMetaObject::metacall.
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::call): Ditto.
2010-05-14 Ben Murdoch <benm@google.com>
Reviewed by Darin Fisher.
Touch events are disabled by default when using V8.
https://bugs.webkit.org/show_bug.cgi?id=38990
Touch events are protected by a compile time guard, so it's safe to
assume that the runtime flag should be enabled by default when this
guard is present.
No new tests, build fix for Android.
* bindings/generic/RuntimeEnabledFeatures.cpp: enable touch events by default.
2010-05-14 George Wright <gwright@rim.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=38909
Update JSDataGridColumnListCustom.cpp to call identifierToAtomicString()
on the property name.
* bindings/js/JSDataGridColumnListCustom.cpp:
(WebCore::JSDataGridColumnList::canGetItemsForName):
(WebCore::JSDataGridColumnList::nameGetter):
2010-05-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Darin Adler.
Ignore invalid values for various CanvasRenderingContext2D properties
(lineWidth, miterLimit, shadowOffsetX, shadowOffsetY and shadowBlur)
https://bugs.webkit.org/show_bug.cgi?id=38841
Test: fast/canvas/canvas-invalid-values.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setLineWidth):
(WebCore::CanvasRenderingContext2D::setMiterLimit):
(WebCore::CanvasRenderingContext2D::setShadowOffsetX):
(WebCore::CanvasRenderingContext2D::setShadowOffsetY):
(WebCore::CanvasRenderingContext2D::setShadowBlur):
2010-05-13 Timothy Hatcher <timothy@apple.com>
Expose WebCore::reportException and WebCore::toJSDOMWindow symbols.
Reviewed by Sam Weinig.
* WebCore.base.exp: Expose reportException and toJSDOMWindow.
2010-05-13 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Timothy Hatcher.
Web Inspector: Clearing Breakpoints Too Often
https://bugs.webkit.org/show_bug.cgi?id=39094
Minor resets should preserve both workers and breakpoints.
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.reset):
2010-05-13 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
iframes in compositing layers don't redraw correctly on scrolling
https://bugs.webkit.org/show_bug.cgi?id=39096
When an iframe ends up in a compositing layer (that is painting to its backing store), we need
to turn off blitting on scrolling. RenderView::paintBoxDecorations() already has code to do this
for transformed frames, so do the same thing when the frame is enclosed in a compositing layer.
Test: compositing/iframes/iframe-copy-on-scroll.html
* rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):
2010-05-13 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt.
Fix scrolling in composited iframes
https://bugs.webkit.org/show_bug.cgi?id=39088
<rdar://problem/7980099>
When propagating compositing out of iframes, we have to update the position of the iframe content
layers on scrolling.
Test: compositing/iframes/scrolling-iframe.html
* page/FrameView.cpp:
(WebCore::FrameView::scrollPositionChanged): Call updateContentLayerScrollPosition() when scrolling.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Renamed setRootPlatformLayerClippingBox() to updateContentLayerOffset().
* rendering/RenderLayerCompositor.h:
* rendering/RenderLayerCompositor.cpp: Rename m_clippingLayer to m_clipLayer to go better with m_scrollLayer.
(WebCore::RenderLayerCompositor::updateContentLayerOffset): Renamed from setRootPlatformLayerClippingBox().
Set the size of the clipping layer from the FrameView now, so that scrollbars are not clipped out.
Update the scroll layer position too.
(WebCore::RenderLayerCompositor::updateContentLayerScrollPosition): Set the position of the scroll layer
when the ScrollView is scrolled.
(WebCore::RenderLayerCompositor::rootPlatformLayer): m_clippingLayer rename.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): m_clippingLayer rename. Also create m_scrollLayer at
the same time as the clip layer, and clean it up as necessary.
(WebCore::RenderLayerCompositor::destroyRootPlatformLayer): m_clippingLayer rename, and clean up the m_scrollLayer too.
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): m_clippingLayer rename
2010-05-13 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Follow up to:
Fix for https://bugs.webkit.org/show_bug.cgi?id=38221
Memory issues due to the changes in 36556 (increased CSSPrimitiveValue size).
Part of <rdar://problem/7921275>
Fix failing tests on Leopard.
Initialize m_hasCachedCSSText in CSSPrimitiveValue::init methods.
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cssText): Add extra assertion.
2010-05-13 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Can't submit a form with <input type=checkbox required>
https://bugs.webkit.org/show_bug.cgi?id=39065
Test: fast/forms/interactive-validation-required-checkbox.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setChecked):
Update the validity cache when a checkbox state is changed.
2010-05-13 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Alias WebGLArray type names to TypedArray type names
https://bugs.webkit.org/show_bug.cgi?id=39036
Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all layout tests (including WebGL) in Safari, and WebGL tests in
Chromium.
Test: revised array-unit-tests.html to test both type names.
Revised global prototype and constructor tests to ignore new types.
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::arrayBufferEnabled):
(WebCore::RuntimeEnabledFeatures::int8ArrayEnabled):
(WebCore::RuntimeEnabledFeatures::uint8ArrayEnabled):
(WebCore::RuntimeEnabledFeatures::int16ArrayEnabled):
(WebCore::RuntimeEnabledFeatures::uint16ArrayEnabled):
(WebCore::RuntimeEnabledFeatures::int32ArrayEnabled):
(WebCore::RuntimeEnabledFeatures::uint32ArrayEnabled):
(WebCore::RuntimeEnabledFeatures::floatArrayEnabled):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::arrayBuffer):
(WebCore::JSDOMWindow::int8Array):
(WebCore::JSDOMWindow::uint8Array):
(WebCore::JSDOMWindow::int32Array):
(WebCore::JSDOMWindow::uint32Array):
(WebCore::JSDOMWindow::int16Array):
(WebCore::JSDOMWindow::uint16Array):
(WebCore::JSDOMWindow::floatArray):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::ArrayBufferAccessorGetter):
(WebCore::V8DOMWindow::Int8ArrayAccessorGetter):
(WebCore::V8DOMWindow::Uint8ArrayAccessorGetter):
(WebCore::V8DOMWindow::Int16ArrayAccessorGetter):
(WebCore::V8DOMWindow::Uint16ArrayAccessorGetter):
(WebCore::V8DOMWindow::Int32ArrayAccessorGetter):
(WebCore::V8DOMWindow::Uint32ArrayAccessorGetter):
(WebCore::V8DOMWindow::FloatArrayAccessorGetter):
* page/DOMWindow.idl:
2010-05-13 David Hyatt <hyatt@apple.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=39084
Improve :visited style resolution to reduce its memory footprint and to make some speed adjustments and
simplifications.
(1) Tie the caching of link state on CSSStyleSelector to the element. Just clear out the element when
style resolution finishes for the unvisited case to avoid caching across external calls. The internal
calls share the cache just fine by doing this.
(2) Delete the RenderStyle if the link is unvisited. This shouldn't take long enough to make us vulnerable
to timing attacks, and it makes sure the overall footprint stays the way it used to be for unvisited links.
(3) Limit the set of properties that can be applied to :visited links to only the colors it supports. This
stops images from being loadable from :visited rules.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::init):
(WebCore::CSSStyleSelector::SelectorChecker::determineLinkState):
(WebCore::CSSStyleSelector::initElement):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::isValidVisitedLinkProperty):
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSStyleSelector.h:
* rendering/style/RenderStyle.cpp:
(WebCore::colorIncludingFallback):
2010-05-13 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=38221
Memory issues due to the changes in 36556 (increased CSSPrimitiveValue size).
Part of <rdar://problem/7921275>
- Use an external cache to speedup cssText for CSSPrimitiveValue instead
of an extra member variable.
* css/CSSPrimitiveValue.cpp:
(WebCore::cssTextCache):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::cssText):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2010-05-13 Enrica Casucci <enrica@apple.com>
Reviewed by Dave Hyatt.
Adding block elements to a block and removing them changes the height of the element.
https://bugs.webkit.org/show_bug.cgi?id=38874
The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.
Test: editing/deleting/delete-block-contents-004.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock): resetting m_childrenInline flag to true when layout a block with no children.
2010-05-13 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
Repro crash at www.sears.com (infinite recursion in beforeunload handler)
<rdar://problem/7965182> and https://bugs.webkit.org/show_bug.cgi?id=38928
Test: fast/loader/recursive-before-unload-crash.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldClose): Copied from Frame, with the pageDismissal flag set.
* loader/FrameLoader.h:
* page/Frame.cpp:
(WebCore::Frame::shouldClose): Forward to the new FrameLoader::shouldClose().
* page/Frame.h:
(WebCore::Frame::existingDOMWindow):
2010-05-13 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r59376.
http://trac.webkit.org/changeset/59376
https://bugs.webkit.org/show_bug.cgi?id=39080
Broke window prototype tests (Requested by jamesr on #webkit).
* bindings/generic/RuntimeEnabledFeatures.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::webGLFloatArray):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* page/DOMWindow.idl:
2010-05-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: A disabled style property cannot be deleted.
https://bugs.webkit.org/show_bug.cgi?id=39057
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::applyStyleText):
2010-05-12 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Alias WebGLArray type names to TypedArray type names
https://bugs.webkit.org/show_bug.cgi?id=39036
Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all WebGL layout tests in Safari and Chromium.
Test: revised array-unit-tests.html to test both type names.
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::arrayBufferEnabled):
(WebCore::RuntimeEnabledFeatures::int8ArrayEnabled):
(WebCore::RuntimeEnabledFeatures::uint8ArrayEnabled):
(WebCore::RuntimeEnabledFeatures::int16ArrayEnabled):
(WebCore::RuntimeEnabledFeatures::uint16ArrayEnabled):
(WebCore::RuntimeEnabledFeatures::int32ArrayEnabled):
(WebCore::RuntimeEnabledFeatures::uint32ArrayEnabled):
(WebCore::RuntimeEnabledFeatures::floatArrayEnabled):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::arrayBuffer):
(WebCore::JSDOMWindow::int8Array):
(WebCore::JSDOMWindow::uint8Array):
(WebCore::JSDOMWindow::int32Array):
(WebCore::JSDOMWindow::uint32Array):
(WebCore::JSDOMWindow::int16Array):
(WebCore::JSDOMWindow::uint16Array):
(WebCore::JSDOMWindow::floatArray):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::ArrayBufferAccessorGetter):
(WebCore::V8DOMWindow::Int8ArrayAccessorGetter):
(WebCore::V8DOMWindow::Uint8ArrayAccessorGetter):
(WebCore::V8DOMWindow::Int16ArrayAccessorGetter):
(WebCore::V8DOMWindow::Uint16ArrayAccessorGetter):
(WebCore::V8DOMWindow::Int32ArrayAccessorGetter):
(WebCore::V8DOMWindow::Uint32ArrayAccessorGetter):
(WebCore::V8DOMWindow::FloatArrayAccessorGetter):
* page/DOMWindow.idl:
2010-05-13 Brady Eidson <beidson@apple.com>
Reviewed by John Sullivan.
Part of <rdar://problem/7965182> and https://bugs.webkit.org/show_bug.cgi?id=38928
No new tests. (No change in behavior)
m_unloadEventBeingDispatched was already overloaded to include both unload and pagehide events.
In general, these are "page dismissal" events, and might also include beforeunload, so let's rename
the flag!
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::pageHidden):
* loader/FrameLoader.h:
2010-05-13 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Pavel Feldman.
Web Inspector: Event Markers should be hidden in Resource's "Size" Graph
https://bugs.webkit.org/show_bug.cgi?id=39074
Added Show / Hide event dividers functionality to the timeline grid,
and included delegation functions in AbstractTimelinePanel.
* inspector/front-end/AbstractTimelinePanel.js: delegate to the inner grid
(WebInspector.AbstractTimelinePanel.prototype.hideEventDividers):
(WebInspector.AbstractTimelinePanel.prototype.showEventDividers):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.populateSidebar): save a reference to the size graph item to know when its selected
(WebInspector.ResourcesPanel.prototype._graphSelected): if the size graph is selected hide the dividers, otherwise show them
* inspector/front-end/TimelineGrid.js:
(WebInspector.TimelineGrid.prototype.hideEventDividers): set the container to display: none
(WebInspector.TimelineGrid.prototype.showEventDividers): set the container to display: block
2010-05-13 Chang Shu <chang.shu@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Based on the spec and Philip Taylor's test suite, strokeStyle and fillStyle attributes
must initially have the string value #000000.
The link to the spec:
http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.colours.default
https://bugs.webkit.org/show_bug.cgi?id=39068
The complete test suite is in the process of checking in.
https://bugs.webkit.org/show_bug.cgi?id=20553
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
2010-05-13 Yury Semikhatsky <yurys@chromium.org>
Unreviewed, rolling out r59360.
http://trac.webkit.org/changeset/59360
https://bugs.webkit.org/show_bug.cgi?id=38667
It broke Chromium Win build
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane):
(WebInspector.CallStackSidebarPane.prototype._placardSelected):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._keyDown):
* inspector/front-end/HelpScreen.js: Removed.
* inspector/front-end/KeyboardShortcut.js:
(WebInspector.KeyboardShortcut._makeKeyFromCodeAndModifiers):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor):
* inspector/front-end/ShortcutsHelp.js: Removed.
* inspector/front-end/SidebarPane.js:
(WebInspector.SidebarPane.prototype._onTitleKeyDown):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.removeSection):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._handleKeyDown):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/helpScreen.css: Removed.
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.loaded):
(WebInspector.documentKeyDown):
(WebInspector._searchKeyDown):
(WebInspector.startEditing.keyDownEventListener):
(WebInspector.startEditing):
* inspector/front-end/utilities.js:
2010-05-13 Antti Koivisto <koivisto@iki.fi>
Reviewed by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=39063
[Qt] Tiled backing store checker pattern does not paint correctly when scaling factor is not 1
Use the dirty rect that has been adjusted for scaling instead of the original one.
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::paint):
2010-05-13 Chang Shu <chang.shu@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Based on Philip Taylor's test suite, resetting the canvas
state resets the current path.
https://bugs.webkit.org/show_bug.cgi?id=38934
The complete test suite is in the process of checking in.
https://bugs.webkit.org/show_bug.cgi?id=20553
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::reset):
2010-05-13 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Added help screen with keyboard shortcuts.
https://bugs.webkit.org/show_bug.cgi?id=38667
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane):
(WebInspector.CallStackSidebarPane.prototype._placardSelected):
(WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype._registerShortcuts):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._registerShortcuts):
* inspector/front-end/HelpScreen.js: Added.
* inspector/front-end/KeyboardShortcut.js:
(WebInspector.KeyboardShortcut.makeDescriptor):
(WebInspector.KeyboardShortcut.shortcutToString):
(WebInspector.KeyboardShortcut._modifiersToString):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor):
(WebInspector.ScriptsPanel.prototype._registerShortcuts):
* inspector/front-end/ShortcutsHelp.js: Added.
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.removeSection):
(WebInspector.StylesSidebarPane.prototype.registerShortcuts):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/helpScreen.css: Added.
2010-05-13 Yoshiki Hayashi <yhayashi@google.com>
Reviewed by Darin Adler.
Fix a bug in handleRunInChild where only the first child run-in block
is inserted because removeChildNode clears next sibling.
https://bugs.webkit.org/show_bug.cgi?id=25047
Test: fast/css/run-in-children.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::handleRunInChild):
2010-05-13 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
In case there is no expose event we render the theme in a pixmap
and copy it to the cairo context. This is slow but it is used just
in case we are printing nowadays.
[GTK] Theme does not render when printing
https://bugs.webkit.org/show_bug.cgi?id=38896
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::paintMozillaGtkWidget):
2010-05-12 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Fix Bug 35014 - Modifying UA rules from page JS crashes
Added a NULL check.
https://bugs.webkit.org/show_bug.cgi?id=35014
Test: fast/css/modify-ua-rules-from-javascript.html
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
2010-05-12 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Adam Barth.
Add the parent class for Database and DatabaseSync.
https://bugs.webkit.org/show_bug.cgi?id=39041
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* storage/AbstractDatabase.cpp: Added.
* storage/AbstractDatabase.h: Added.
2010-05-12 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsLayer: depth-test causes flicker in certain situations
This patch removes the simplistic 2D depth test as it leads to flickering side effects.
https://bugs.webkit.org/show_bug.cgi?id=38370
Tested by http://webkit.org/blog-files/3d-transforms/morphing-cubes.html
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::updateTransform):
2010-05-12 Simon Fraser <simon.fraser@apple.com>
Reviewed by Mark Rowe.
Fix layer dump to avoid spurious platform differences
https://bugs.webkit.org/show_bug.cgi?id=39045
Only dump the children transform on layers that are not the root layer.
The children transform on the root layer is used on Leopard to implement
geometry flipping, so avoid this supurious difference in test output.
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties):
2010-05-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r59270.
http://trac.webkit.org/changeset/59270
https://bugs.webkit.org/show_bug.cgi?id=39044
Caused a crash on some pages - bug 39042 (Requested by smfr on
#webkit).
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
2010-05-12 Simon Fraser <simon.fraser@apple.com>
Reviewed by David Hyatt.
Composited plug-ins can cause missed painting
https://bugs.webkit.org/show_bug.cgi?id=39033
<rdar://problem/7972478>
Fixed missed painting (and assertions in debug builds) related to compositing
propagating out of iframes that contain plug-ins.
When an iframe enters or leaves compositing mode, RenderLayerCompositor uses
setNeedsStyleRecalc(SyntheticStyleChange) to trigger the parent document to re-evaluate
whether the iframe itself should be composited. However, for iframes containing plug-ins,
this can happen at inappropriate times. For example, when a browser tab is brought frontmost,
plug-ins are instantiated for the first time (via -viewDidMoveToWindow), which triggers a
setNeedsStyleRecalc() on the object element. Soon after, the -viewWillDraw machinery
does layout from the top down. During layout of the iframe, the iframe enters compositing mode,
and does a setNeedsStyleRecalc() on the iframe element in its parent document. This leaves the
FrameView as needsLayout(), so the FrameView::paintContents() asserts and bails.
The fix is to avoid doing a setNeedsStyleRecalc() on the root while inside a recalcStyle on
the iframe. We do this by switching the iframe into compositing mode eagerly as soon as we know
the plug-in needs it.
A secondary fix is to ensure that if a document has composited iframes, when that document becomes
composited, we connect compositing layers between the iframes and the parent document.
Tests: compositing/iframes/connect-compositing-iframe-delayed.html
compositing/iframes/iframe-src-change.html
* WebCore.base.exp: Export FrameView::enterCompositingMode()
* page/FrameView.h: New method, enterCompositingMode(), that we can call from WebKit plug-in code.
* page/FrameView.cpp:
(WebCore::FrameView::enterCompositingMode):
* rendering/RenderLayerCompositor.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::enableCompositingMode): When we switch into compositing mode, we
force a style recaclc on any iframes to get them into compositing layers, so they can hook up
with their content layers if necessary.
(WebCore::RenderLayerCompositor::didMoveOnscreen): Only call attachRootPlatformLayer() if we really need to.
(WebCore::RenderLayerCompositor::willMoveOffscreen): Only call detachRootPlatformLayer() if we really need to.
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): Whitespace.
(WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange): Fetch iframe elements, and send a
synthetic style recalc on them.
2010-05-12 Anders Carlsson <andersca@apple.com>
Reviewed by Simon Fraser.
Shrink the size of FillLayer by moving a member variable.
https://bugs.webkit.org/show_bug.cgi?id=39035
* rendering/style/FillLayer.cpp:
(WebCore::FillLayer::FillLayer):
* rendering/style/FillLayer.h:
2010-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
A bunch of nice micro-optimizations for ~1% speedup on PLT.
- Add fastGetAttribute. The same as getAttribute except can only be
called when it is known not to be style attribute or one of the SVG
animatable attributes.
- Inline some functions from Font.
- Return the same string from deprecatedParseURL if there is nothing
to strip.
- Use a member variable instead of a virtual function to determine
whether a ScheduledNavigation is a location change.
* WebCore.base.exp:
* css/CSSHelper.cpp:
(WebCore::deprecatedParseURL):
* css/CSSStyleSelector.cpp:
(WebCore::linkAttribute):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
* dom/Element.cpp:
(WebCore::Element::getAttribute):
* dom/Element.h:
(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::formControlName):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::value):
* loader/RedirectScheduler.cpp:
(WebCore::ScheduledNavigation::ScheduledNavigation):
(WebCore::ScheduledNavigation::isLocationChange):
(WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
(WebCore::ScheduledRedirect::ScheduledRedirect):
(WebCore::ScheduledLocationChange::ScheduledLocationChange):
(WebCore::ScheduledRefresh::ScheduledRefresh):
(WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation):
(WebCore::ScheduledFormSubmission::ScheduledFormSubmission):
(WebCore::RedirectScheduler::locationChangePending):
* platform/graphics/Font.cpp:
* platform/graphics/Font.h:
(WebCore::Font::~Font):
(WebCore::Font::primaryFont):
(WebCore::Font::fontDataAt):
(WebCore::Font::fontDataForCharacters):
(WebCore::Font::isFixedPitch):
(WebCore::Font::fontSelector):
* platform/graphics/FontFallbackList.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageMap):
2010-05-12 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Make InlineBoxes use an IntRect for dimensions, and eliminate the dynamic computation of height() every time.
* WebCore.xcodeproj/project.pbxproj:
* editing/visible_units.cpp:
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::selectionRect):
(WebCore::EllipsisBox::paintSelection):
(WebCore::EllipsisBox::nodeAtPoint):
* rendering/EllipsisBox.h:
(WebCore::EllipsisBox::EllipsisBox):
* rendering/InlineBox.cpp:
(WebCore::InlineBox::adjustPosition):
(WebCore::InlineBox::canAccommodateEllipsis):
* rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::isSVGRootInlineBox):
(WebCore::InlineBox::x):
(WebCore::InlineBox::y):
(WebCore::InlineBox::width):
(WebCore::InlineBox::height):
(WebCore::InlineBox::bottom):
(WebCore::InlineBox::right):
(WebCore::InlineBox::setX):
(WebCore::InlineBox::setY):
(WebCore::InlineBox::setWidth):
(WebCore::InlineBox::setHeight):
(WebCore::InlineBox::location):
(WebCore::InlineBox::size):
(WebCore::InlineBox::setLocation):
(WebCore::InlineBox::setSize):
(WebCore::InlineBox::move):
(WebCore::InlineBox::frameRect):
(WebCore::InlineBox::setFrameRect):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesVertically):
(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::paintTextDecorations):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::visibleOverflowRect):
(WebCore::InlineFlowBox::topLayoutOverflow):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::leftLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::topVisualOverflow):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::leftVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):
(WebCore::InlineFlowBox::visualOverflowRect):
(WebCore::InlineFlowBox::setHorizontalOverflowPositions):
(WebCore::InlineFlowBox::setVerticalOverflowPositions):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::setSpaceAdd):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeVerticalPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::createInlineFlowBox):
* rendering/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::createTextBox):
* rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::createRootInlineBox):
* rendering/RenderText.cpp:
(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::firstRunX):
(WebCore::RenderText::firstRunY):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeTextRun):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::placeEllipsis):
(WebCore::RootInlineBox::addHighlightOverflow):
(WebCore::RootInlineBox::closestLeafChildForXPos):
* rendering/SVGInlineFlowBox.h:
(WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
* rendering/SVGInlineTextBox.h:
(WebCore::SVGInlineTextBox::selectionTop):
(WebCore::SVGInlineTextBox::selectionHeight):
* rendering/SVGRootInlineBox.h:
(WebCore::SVGRootInlineBox::SVGRootInlineBox):
(WebCore::SVGRootInlineBox::isSVGRootInlineBox):
* rendering/TrailingFloatsRootInlineBox.h: Removed.
2010-05-12 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Removing the unnecessary dirfd parameter.
https://bugs.webkit.org/show_bug.cgi?id=38869
* platform/chromium/ChromiumBridge.h:
* platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
2010-05-12 Enrica Casucci <enrica@apple.com>
Reviewed by Dave Hyatt.
Adding block elements to a block and removing them changes the height of the element.
https://bugs.webkit.org/show_bug.cgi?id=38874
The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.
Test: editing/deleting/delete-block-contents-004.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild): m_childrenInline was set to true only when the Renderer is created
and never reset to true when all the block elements contained are removed.
2010-05-11 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Do not check if a database needs to be vacuumed after a read-only transaction.
https://bugs.webkit.org/show_bug.cgi?id=38972
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::postflightAndCommit):
2010-05-12 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Detect debug mode consistently
https://bugs.webkit.org/show_bug.cgi?id=38863
No new tests as there is no new functionality.
* WebCore.pro:
2010-05-12 James Robinson <jamesr@chromium.org>
Patch by Dan Bernstein.
Reviewed by David Hyatt.
Fix marking the layout root's parent as needing layout
https://bugs.webkit.org/show_bug.cgi?id=37760
If an element gets marked as needing layout due to the recalcStyle()
call in FrameView::layout(), the m_layoutSchedulingEnabled flag will
be set to false. It's possible at this point that a parent of the
existing FrameView::m_layoutRoot will be marked as needing layout.
This patch updates FrameView::scheduleRelayoutOfSubtree to account
for this case.
Manual test only due to subtle timing issues.
* manual-tests/layoutroot_detach.xml: Added.
* page/FrameView.cpp:
(WebCore::FrameView::scheduleRelayoutOfSubtree):
2010-05-12 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r59245.
http://trac.webkit.org/changeset/59245
https://bugs.webkit.org/show_bug.cgi?id=38874
Broke at least one test on multiple platforms
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
2010-05-12 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=38752
Strange behaviour after js insertion into a page pointing directly to an object (image, swf, etc)
Test: fast/images/extra-image-in-image-document.html
* loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement): Reset setAutoLoadImages
after manually feeding an image - there may be more coming.
2010-05-12 yael aharon <yael.aharon@nokia.com>
Reviewed by Dan Bernstein.
HTMLLabelElement::control() should return HTMLFormControlElement, not HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=38991
No new tests since no new functionality was introduced.
* html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::control):
* html/HTMLLabelElement.h:
2010-05-12 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=38891
First-letter had a number of bugs that were exposed by my attempt to optimize the setting of styles when updating first-letter.
The code that drills down to find the first-letter child stopped if it hit an element that didn't need layout. This means it could
return random incorrect results (and cause the first-letter object to not be found).
In addition when the first-letter was floated/positioned, the text child was not correctly returned, but the container itself was
returned instead.
Finally, the updating code was leaving the box that wrapped the first letter text with a stale style. The old code happened to work because
it made new styles for the text elements instead of using the enclosing box style. The regression was caused by my change to make the
text children simply share style with their parent (thus making the bug that the parent had the wrong style become more prominent).
No new tests, since there's a timing component to reproducing the issue.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
2010-05-12 Enrica Casucci <enrica@apple.com>
Reviewed by Dave Hyatt.
Adding block elements to a block and removing them changes the height of the element.
https://bugs.webkit.org/show_bug.cgi?id=38874
The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.
Test: editing/deleting/delete-block-contents-004.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild): m_childrenInline was set to true only when the Renderer is created
and never reset to true when all the block elements contained are removed.
2010-05-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: disabling style property on container breaks styles inspection for given node.
https://bugs.webkit.org/show_bug.cgi?id=39005
Tests: inspector/styles-disable-inherited.html
inspector/styles-disable-then-enable.html
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._containsInherited):
(WebInspector.StylesSidebarPane.prototype._arrayContainsInheritedProperty):
2010-05-12 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
HTML Entity Escape the contents of a textarea node when accessed
via the innerHTML and outerHTML node properties.
https://bugs.webkit.org/show_bug.cgi?id=38922
Test: fast/innerHTML/innerHTML-special-elements.html
* editing/markup.cpp:
(WebCore::appendStartMarkup):
2010-05-12 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=38871 REGRESSION:
Crash clicking background NPR tab after few minutes of sitting idle
-and corresponding-
<rdar://problem/7941504>
Move m_mediaCanStartListeners HashSet to Document away from Page.
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::addMediaCanStartListener):
(WebCore::Document::removeMediaCanStartListener):
(WebCore::Document::takeAnyMediaCanStartListener):
* dom/Document.h:
* page/Page.cpp:
(WebCore::Page::takeAnyMediaCanStartListener):
* page/Page.h:
(WebCore::Page::canStartMedia):
2010-05-11 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Sometimes ResourceRequest records aren't connected to the initiator.
https://bugs.webkit.org/show_bug.cgi?id=38925
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
* inspector/InspectorTimelineAgent.h:
(WebCore::):
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createScheduleResourceRequestData):
* inspector/TimelineRecordFactory.h:
* inspector/front-end/TimelineAgent.js:
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._findParentRecord):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
* loader/loader.cpp:
(WebCore::Loader::load):
2010-05-12 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
placeholder text should be stripped from line breaks
https://bugs.webkit.org/show_bug.cgi?id=36291
According to http://dev.w3.org/html5/spec/forms.html#attr-input-placeholder ,
we need to remove CR and LF from the placeholder attribute values.
Introduce HTMLTextFormControlElement::strippedPlaceholder(), which
returns stripped value, and replace getAttribute(placeholderAttr) with it.
Test: fast/forms/placeholder-stripped.html
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::strippedPlaceholder):
(WebCore::HTMLTextFormControlElement::isPlaceholderEmpty):
(WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
Use strippedPlaceholder().
* html/HTMLFormControlElement.h:
* platform/text/CharacterNames.h: Add carriageReturn.
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::updateFromElement):
Use strippedPlaceholder().
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::updateFromElement):
Use strippedPlaceholder().
2010-05-10 Rodrigo Belem <rodrigo.belem@openbossa.org>
Reviewed by Kenneth Christiansen , Simon Hausmann and Gustavo Noronha.
[Qt, Gtk] Allows build-webkit script to receive an install prefix as parameter
https://bugs.webkit.org/show_bug.cgi?id=26224
This patch adds the ability, in the QtWebkit build system, to change
the installation path.
* WebCore.pro:
2010-05-12 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Bug 38689: #34005 will break fullscreen video playback
https://bugs.webkit.org/show_bug.cgi?id=38689
The PlatformMedia struct now contains a type field indicating which type
it contains. The struct now contains a union of all possible return types,
allowing the type of media returned by MediaPlayerPrivate instances to be
determined at runtime.
* platform/graphics/MediaPlayer.h:
(WebCore::PlatformMedia::):
(WebCore::):
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivate::platformMedia):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::platformMedia):
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
(WebCore::MediaPlayerPrivate::platformMedia):
2010-05-12 Young Han Lee <joybro@company100.net>
Reviewed by Darin Adler.
Add missing ENABLE(SVG) guards.
https://bugs.webkit.org/show_bug.cgi?id=38892
* rendering/RenderSVGResourceClipper.cpp:
* rendering/RenderSVGResourceMarker.cpp:
* rendering/RenderSVGResourceMasker.cpp:
2010-05-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: align sidebar checkboxes on windows.
https://bugs.webkit.org/show_bug.cgi?id=38986
* inspector/front-end/StylesSidebarPane.js:
* inspector/front-end/inspector.css:
(.sidebar-pane-subtitle):
(body.platform-windows .sidebar-pane-subtitle):
2010-05-10 yael aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Support control attribute of HTMLLabelElement
https://bugs.webkit.org/show_bug.cgi?id=38688
Added support for the control attribute of HTMLLabelElement and changed the logic of determining
which control is associated with the label to conform to HTML5 spec.
Added a manual test for testing the logic of selecting the control to get focused, activated or hovered
when the label gets focused, activated or is hovered.
Test: fast/dom/HTMLLabelElement/click-label.html
Test: fast/dom/HTMLLabelElement/focus-label.html
Test: fast/dom/HTMLLabelElement/label-control.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::labelForElement):
(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::isLabelable):
* html/HTMLFormControlElement.h:
* html/HTMLLabelElement.cpp:
(WebCore::nodeAsLabelableFormControl):
(WebCore::HTMLLabelElement::control):
(WebCore::HTMLLabelElement::setActive):
(WebCore::HTMLLabelElement::setHovered):
(WebCore::HTMLLabelElement::defaultEventHandler):
(WebCore::HTMLLabelElement::focus):
(WebCore::HTMLLabelElement::accessKeyAction):
* html/HTMLLabelElement.h:
* html/HTMLLabelElement.idl:
* manual-tests/dom/form-control-for-label.html: Added.
2010-05-12 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Android's writeToFile() is buggy
https://bugs.webkit.org/show_bug.cgi?id=38908
No new tests, build fix only.
* platform/android/FileSystemAndroid.cpp: Remove Android's version of writeToFile().
* platform/posix/FileSystemPOSIX.cpp: Use POSIX version of writeToFile() on Android.
(WebCore::writeToFile):
2010-05-10 Philippe Normand <pnormand@igalia.com>
Reviewed by David Levin.
[GStreamer] incoherent #ifdef in GOwnPtrGStreamer.h
https://bugs.webkit.org/show_bug.cgi?id=38839
Fixed #ifdef/curly braces coherence.
* platform/graphics/gstreamer/GOwnPtrGStreamer.cpp:
(WTF::GstElement):
2010-05-10 Philippe Normand <pnormand@igalia.com>
Reviewed by Dirk Schulze.
[GStreamer] un-needed cairo.h include
https://bugs.webkit.org/show_bug.cgi?id=38837
Cairo not used in the sink anymore. So it's not needed to include
the header.
* platform/graphics/gstreamer/VideoSinkGStreamer.h:
2010-05-12 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Nikolas Zimmermann.
Build fix for Windows and Chromium builds.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* svg/graphics/filters/SVGFELighting.cpp:
(WebCore::FELighting::LightingData::upLeftPixelValue):
(WebCore::FELighting::LightingData::upPixelValue):
(WebCore::FELighting::LightingData::upRightPixelValue):
(WebCore::FELighting::LightingData::leftPixelValue):
(WebCore::FELighting::LightingData::centerPixelValue):
(WebCore::FELighting::LightingData::rightPixelValue):
(WebCore::FELighting::LightingData::downLeftPixelValue):
(WebCore::FELighting::LightingData::downPixelValue):
(WebCore::FELighting::LightingData::downRightPixelValue):
(WebCore::FELighting::setPixel):
2010-05-12 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Nikolas Zimmermann.
Implementing SVG filters: feDiffuseLighting and feSpecularLighting
https://bugs.webkit.org/show_bug.cgi?id=32197
https://bugs.webkit.org/show_bug.cgi?id=32199
The patch implements the SVG filters feDiffuseLighting and
feSpecularLighting including the impementation of their possible
light sources according to the Scalable Vector Graphics (SVG)
1.1 Specification. Only two features are missing: supporting images
with height or width set to 1, and kernelUnitLength other than (1,1).
Since the two lighting filters have a similar body, a common base
class called FELighting is introduced, and contains the code for
both filters. The implementation employs single precision floating
point arithmetic (fixed precision integer arithmetic seemed too difficult).
Indentation is removed of the modified header files in svg/graphics/filters
* GNUmakefile.am:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/FloatPoint3D.cpp:
* platform/graphics/FloatPoint3D.h:
(WebCore::FloatPoint3D::FloatPoint3D): constructors changed to inline
(WebCore::operator*): dot product
* svg/SVGFESpotLightElement.cpp:
(WebCore::SVGFESpotLightElement::lightSource):
* svg/graphics/filters/SVGDistantLightSource.h:
(WebCore::DistantLightSource::create):
(WebCore::DistantLightSource::azimuth):
(WebCore::DistantLightSource::elevation):
(WebCore::DistantLightSource::DistantLightSource):
* svg/graphics/filters/SVGFEDiffuseLighting.cpp:
(WebCore::FEDiffuseLighting::FEDiffuseLighting):
(WebCore::FEDiffuseLighting::create):
* svg/graphics/filters/SVGFEDiffuseLighting.h:
* svg/graphics/filters/SVGFELighting.cpp: Added.
(WebCore::FELighting::FELighting):
(WebCore::FELighting::LightingData::upLeftPixelValue):
(WebCore::FELighting::LightingData::upPixelValue):
(WebCore::FELighting::LightingData::upRightPixelValue):
(WebCore::FELighting::LightingData::leftPixelValue):
(WebCore::FELighting::LightingData::centerPixelValue):
(WebCore::FELighting::LightingData::rightPixelValue):
(WebCore::FELighting::LightingData::downLeftPixelValue):
(WebCore::FELighting::LightingData::downPixelValue):
(WebCore::FELighting::LightingData::downRightPixelValue):
(WebCore::FELighting::setPixel):
(WebCore::FELighting::drawLighting):
(WebCore::FELighting::apply):
* svg/graphics/filters/SVGFELighting.h: Added.
(WebCore::FELighting::uniteChildEffectSubregions):
(WebCore::FELighting::):
* svg/graphics/filters/SVGFESpecularLighting.cpp:
(WebCore::FESpecularLighting::FESpecularLighting):
(WebCore::FESpecularLighting::create):
* svg/graphics/filters/SVGFESpecularLighting.h:
* svg/graphics/filters/SVGLightSource.cpp:
(WebCore::PointLightSource::initPaintingData):
(WebCore::PointLightSource::updatePaintingData):
(WebCore::SpotLightSource::initPaintingData):
(WebCore::SpotLightSource::updatePaintingData):
(WebCore::DistantLightSource::initPaintingData):
(WebCore::DistantLightSource::updatePaintingData):
* svg/graphics/filters/SVGLightSource.h:
(WebCore::):
(WebCore::LightSource::LightSource):
(WebCore::LightSource::~LightSource):
(WebCore::LightSource::type):
* svg/graphics/filters/SVGPointLightSource.h:
(WebCore::PointLightSource::create):
(WebCore::PointLightSource::position):
(WebCore::PointLightSource::PointLightSource):
* svg/graphics/filters/SVGSpotLightSource.h:
(WebCore::SpotLightSource::create):
(WebCore::SpotLightSource::position):
(WebCore::SpotLightSource::direction):
(WebCore::SpotLightSource::specularExponent):
(WebCore::SpotLightSource::limitingConeAngle):
(WebCore::SpotLightSource::SpotLightSource):
2010-05-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Nikolas Zimmermann.
Add missing AM_V_GEN directives to generation rules so that they
remain silent when requested.
* GNUmakefile.am:
2010-05-12 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Jeremy Orlow.
[EFL] It does not make sense to use ScrollbarEfl::ScrollbarEfl, so
use ScrollbarEfl (GCC 4.5 seems to be pickier about this). Revision 59030
fixed cases for RenderThemeEfl, but missed this for ScrollbarEfl.
http://webkit.org/b/38904
No new tests required.
* platform/efl/ScrollbarEfl.cpp:
(scrollbarEflEdjeMessage):
2010-05-12 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
[Chromium] Support HTML5 <progress> element on Windows.
https://bugs.webkit.org/show_bug.cgi?id=37308
Extended ChromiumBridge to handle progress bar painting,
and added delegations to it.
No new tests. Test cases should be shared with existing ones for
progress element. Expectaions will be added after PROGRESS_TAG is
enabled on Chromium tree.
* platform/chromium/ChromiumBridge.h:
* rendering/RenderProgress.cpp:
(WebCore::RenderProgress::animationProgress):
(WebCore::RenderProgress::isDeterminate):
* rendering/RenderProgress.h:
(WebCore::RenderProgress::position):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::RenderThemeChromiumWin::animationRepeatIntervalForProgressBar):
(WebCore::RenderThemeChromiumWin::animationDurationForProgressBar):
(WebCore::RenderThemeChromiumWin::adjustProgressBarStyle):
(WebCore::RenderThemeChromiumWin::paintProgressBar):
* rendering/RenderThemeChromiumWin.h:
2010-05-12 Marcus Bulach <bulach@chromium.org>
Reviewed by Steve Block.
Removes Geolocation::setPosition and uses positionChanged() to capture lastPosition().
This brings CLIENT_BASED_GEOLOCATION more inline with the non-client based.
https://bugs.webkit.org/show_bug.cgi?id=38195
* page/Geolocation.cpp:
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::positionChangedInternal):
(WebCore::Geolocation::positionChanged):
(WebCore::Geolocation::geolocationServicePositionChanged):
* page/Geolocation.h:
* page/GeolocationController.cpp:
(WebCore::GeolocationController::positionChanged):
(WebCore::GeolocationController::lastPosition):
* page/GeolocationController.h:
2010-05-12 Marcus Bulach <bulach@chromium.org>
Reviewed by Steve Block.
Attaches the geolocation bridge later on startUpdating().
This prevents a page requesting permission when it has just accessed navigator.geolocation (without calling navigator.geolocation.getCurrentPosition/watchPosition).
Note: when Geolocation::haveSuitableCachedPosition(), WebGeolocationServiceBridgeImpl::startUpdating() is not called,
so we attach the bridge if needed at requestGeolocationPermissionForFrame().
https://bugs.webkit.org/show_bug.cgi?id=38323
http://crbug.com/42789
* platform/chromium/GeolocationServiceChromium.h:
2010-05-12 Robin Qiu <robin.qiu@torchmobile.com.cn>
Reviewed by Dirk Schulze.
Fix a bug in SVGPathSegList::getPathSegAtLength().
This bug is just a misktake: almost all of the code is OK, but the
parameter is not used at all, therefore, this function always returns
"1".
And make a modification to return the last path segment if the distance
exceeds the actual path length.
https://bugs.webkit.org/show_bug.cgi?id=37515
Test: svg/dom/svgpath-getPathSegAtLength.html
* svg/SVGPathSegList.cpp:
(WebCore::SVGPathSegList::getPathSegAtLength):
2010-05-11 David Hyatt <hyatt@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=38976, fast/css/pseudo-cache-stale.html has incorrect results.
Make sure to trigger a relayout of any objects whose first-line styles change dynamically.
* dom/Element.cpp:
(WebCore::Element::pseudoStyleCacheIsInvalid):
2010-05-11 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Timothy Hatcher.
Web Inspector: Shorthand Properties Getting Deleted When Editing
https://bugs.webkit.org/show_bug.cgi?id=38958
* inspector/front-end/DOMAgent.js:
(WebInspector.CSSStyleDeclaration.prototype.styleTextWithShorthands): was getting regular values instead of shorthand values
2010-05-11 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
[chromium] Remove subframe scrollbar routing (r58937)
https://bugs.webkit.org/show_bug.cgi?id=38894
* page/chromium/EventHandlerChromium.cpp:
(WebCore::EventHandler::passMousePressEventToSubframe):
2010-05-11 Simon Fraser <simon.fraser@apple.com>
Reviewed by Maciej Stachowiak.
Body not redrawn, and filled with garbage on some composited pages
https://bugs.webkit.org/show_bug.cgi?id=38951
<rdar://problem/7891548>
When the root layer becomes composited (for example, because a negative z-index
descendant in its stacking context becomes composited), then it has to be made
large enough to fill the viewport, because the page background draws into it.
Test: compositing/geometry/composited-html-size.html
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
2010-05-11 Anders Carlsson <andersca@apple.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=38961
Move some member variables around to reduce class sizes.
If a class inherits (directly or indirectly) from FastAllocBase, we don't want the first member variable
of that class to also inherit (directly or indirectly) from FastAllocBase as this will add padding to the class
and thus increasing its size.
* css/CSSParserValues.h:
* css/CSSSelector.h:
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::RareData::RareData):
* platform/graphics/FontCache.cpp:
(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
2010-05-11 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Adam Barth.
Adding a function needed by the V8 code generator to turn on/off
the binding for WorkerContext::openDatabaseSync().
https://bugs.webkit.org/show_bug.cgi?id=38960
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::openDatabaseSyncEnabled):
* bindings/generic/RuntimeEnabledFeatures.h:
2010-05-11 MORITA Hajime <morrita@google.com>
Reviewed by Dirk Schulze.
CSS SVG font doesn't recognize URL without element reference
https://bugs.webkit.org/show_bug.cgi?id=37144
CachedFont::getSVGFontById() did assume that element reference (ID) is given.
So fixed to handle an empty or missing element reference. In which case,
the first font element is returned if available.
Test: svg/custom/svg-fonts-with-no-element-reference.html
* loader/CachedFont.cpp:
(WebCore::CachedFont::getSVGFontById):
2010-05-11 Jer Noble <jer.noble@apple.com>
No Review.
Fix the Windows Debug Build: the correct VCProj variable to use when linking against
JavaScriptCore is $(WebKitDLLConfigSuffix), not $(WebKitConfigSuffix), which expands
to an empty string rather than "_debug".
* WebCore.vcproj/QTMovieWin.vcproj:
2010-05-11 Jer Noble <jer.noble@apple.com>
19 media tests are crashing on Windows Release
https://bugs.webkit.org/show_bug.cgi?id=38950
rdar://problem/7971658
Reviewed by Darin Adler.
Link against JavaScriptCore.lib instead of WTF.lib, so the free and malloc used by
QTMovieWin is always the free and malloc in JavaScriptCore.dll.
* WebCore.vcproj/QTMovieWin.vcproj:
2010-05-11 Darin Adler <darin@apple.com>
Reviewed by Beth Dakin.
Another refactoring patch in preparation for a fix to
https://bugs.webkit.org/show_bug.cgi?id=38871
REGRESSION: Crash clicking background NPR tab after few minutes of sitting idle
* dom/Document.cpp:
(WebCore::Document::addMediaCanStartListener): Added.
(WebCore::Document::removeMediaCanStartListener): Added.
* dom/Document.h: Added add/removeMediaCanStartListener.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement): Call removeMediaCanStartListener
on the document instead of the page.
(WebCore::HTMLMediaElement::willMoveToNewOwnerDocument): Call
removeMediaCanStartListener on the current document.
(WebCore::HTMLMediaElement::didMoveToNewOwnerDocument): Call
addMediaCanStartListener on the new document.
(WebCore::HTMLMediaElement::loadInternal): Call addMediaCanStartListener
on the document instead of the page.
* plugins/PluginView.cpp:
(WebCore::PluginView::startOrAddToUnstartedList): Call addMediaCanStartListener
on the document instead of the page.
(WebCore::PluginView::~PluginView): Call removeMediaCanStartListener
on the document instead of the page, and do it in line instead of calling
a function.
* plugins/PluginView.h: Removed unused removeFromUnstartedListIfNecessary.
2010-05-11 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg and Jon Honeycutt.
Patch by Gavin Barraclough.
REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>
Add the WTF strings into the WebCore vcproj, from their copied location in $(WebKitOutputDir).
No new tests because no change in behavior.
* WebCore.vcproj/WebCore.vcproj:
2010-05-11 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Small re-factoring patch in preparation for fixing https://
bugs.webkit.org/show_bug.cgi?id=38871 REGRESSION: Crash clicking
background NPR tab after few minutes of sitting idle
* page/Page.cpp:
(WebCore::Page::takeAnyMediaCanStartListener):
(WebCore::Page::setCanStartMedia):
* page/Page.h:
2010-05-11 Alexey Proskuryakov <ap@apple.com>
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=37989
Safari (still) doesn't always send basic credentials preemptively
Test: http/tests/xmlhttprequest/basic-auth-default.html
After fetching credentials from WebCore storage, put them back right away. This will add
default credentials for the directory, since this may be the first time we learn about its
associated protection space.
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]):
2010-05-11 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Kevin Ollivier.
[wx] Create an NSFont on Mac builds that do not have built-in methods to do so.
https://bugs.webkit.org/show_bug.cgi?id=38931
* platform/graphics/wx/FontPlatformData.h:
(WebCore::FontPlatformData::nsFont):
* platform/graphics/wx/FontPlatformDataWxMac.mm:
(DegToRad):
(OSXCreateNSFont):
(WebCore::FontPlatformData::cacheNSFont):
* platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::platformWidthForGlyph):
2010-05-11 Avi Drissman <avi@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Pipe RTL info into WebPopupMenuInfo
https://bugs.webkit.org/show_bug.cgi?id=38749
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupContainer::menuStyle):
* platform/chromium/PopupMenuChromium.h:
2010-05-11 Mark Rowe <mrowe@apple.com>
Fix the world.
In r59162 a change was made to WebCore's FeatureDefines.xcconfig that enabled FILE_READER and FILE_WRITER.
The author and reviewer of that patch ignored the carefully-worded warning at the top of that file asking
that changes to the file be kept in sync across JavaScriptCore, WebCore and WebKit, as well as being kept
in sync with build-webkit. This led to WebCore and WebKit having different views of Document's vtable
and results in crashes in Safari shortly after launch when virtual function calls resulted in the wrong
function in WebCore being called.
We fix this by bringing the FeatureDefines.xcconfig files in to sync. Based on the ChangeLog message and
other changes in r59162 it appears that enabling FILE_WRITER was unintentional so that particular change
has been reverted.
* Configurations/FeatureDefines.xcconfig:
2010-05-11 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r58520): Implicit submission on forms with button type="submit" no longer works
https://bugs.webkit.org/show_bug.cgi?id=38913
* Widened the check for a successful submit button to include all HTMLFormControlElements.
* Clarified implicit submission code by:
- introducing HTMLFormControlElement::canTriggerImplicitSubmission flag,
- getting rid of static casting and checking for tag names.
* html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::canTriggerImplicitSubmission): Added.
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submitImplicitly): Renamed parameters for clarity, refactored code
to use canTriggerImplicitSubmission.
* html/HTMLFormElement.h: Renamed parameter for clarity.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler): Used canTriggerImplicitSubmission()
instead of isTextField() for clarity.
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::canTriggerImplicitSubmission): Added.
* html/HTMLIsIndexElement.h:
(WebCore::HTMLIsIndexElement::canTriggerImplicitSubmission): Added.
2010-05-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r59171.
http://trac.webkit.org/changeset/59171
https://bugs.webkit.org/show_bug.cgi?id=38933
"Broke the world" (Requested by bweinstein on #webkit).
* WebCore.vcproj/WebCore.vcproj:
2010-05-11 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg.
Patch by Gavin Barraclough.
REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>
Add the WTF strings into the WebCore vcproj, from their copied location in $(WebKitOutputDir).
No new tests because no change in behavior.
* WebCore.vcproj/WebCore.vcproj:
2010-05-11 Jian Li <jianli@chromium.org>
Unreviewed. Fix compiling erron on snow leopard.
* html/FileThreadTask.h:
(WebCore::createFileThreadTask):
2010-05-11 Jian Li <jianli@chromium.org>
Reviewed by Dmitry Titov.
Expose FileReader interface.
https://bugs.webkit.org/show_bug.cgi?id=38609
Test: fast/files/file-reader.html
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
* html/FileError.idl:
* html/FileReader.idl: Added.
* page/DOMWindow.idl:
2010-05-11 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[gtk] critical warning in soup_message_set_first_party() when cancelling a navigation
https://bugs.webkit.org/show_bug.cgi?id=38653
Check if willSendRequest cancelled the request before setting the
first party for the cookies in the message, otherwise we'll get a
critical warning.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::restartedCallback):
2010-05-11 Jer Noble <jer.noble@apple.com>
Reviewed by Adele Peterson.
REGRESSION (r59001): 11 media tests are failing on Windows (38847)
rdar://problem/7962997
https://bugs.webkit.org/show_bug.cgi?id=38847
QTMovieWin was too much refactored; the cacheMovieScale() function should have
been left in QTMovie (instead of being moved into QTMovieGWorld). This fixes the
video-size-intrinsic-scale test.
QTMovieTask::updateTaskTimer() was ignoring the maxInterval parameter unless
QTGetTimeUntilNextTask() returned an error, which caused the next timer to be
scheduled for extremely far in the future, breaking some of the layout tests.
QTMovieTask::fireTaskClients() now makes a local copy of the task list before
calling clients, in case one of them removes themselves from the task list and
invalidates our iterating pointer.
* platform/graphics/win/QTMovie.cpp:
(QTMoviePrivate::task):
(QTMoviePrivate::createMovieController):
(QTMoviePrivate::cacheMovieScale):
* platform/graphics/win/QTMovieGWorld.cpp:
(QTMovieGWorldPrivate::movieLoadStateChanged):
* platform/graphics/win/QTMovieTask.cpp:
(QTMovieTask::updateTaskTimer):
(QTMovieTask::fireTaskClients):
2010-05-11 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
Port SharedBuffer to WinCE.
https://bugs.webkit.org/show_bug.cgi?id=37222
Use only functions which are available on Win32 and WinCE.
* platform/win/SharedBufferWin.cpp:
(WebCore::SharedBuffer::createWithContentsOfFile):
2010-05-11 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] fast/text/find-hidden-text.html
https://bugs.webkit.org/show_bug.cgi?id=32922
Use the real page step for populating the QStyleOption otherwhise
the size can be negative, which can break the QStyle used.
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::styleOptionSlider):
2010-05-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: make styles rendering more user-friendly.
https://bugs.webkit.org/show_bug.cgi?id=36747
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._update):
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
(WebInspector.ComputedStyleSidebarPane):
(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype.collapse):
(WebInspector.StylePropertiesSection.prototype.startEditingSelector):
* inspector/front-end/inspector.css:
(#elements-content):
(#elements-sidebar):
(.styles-sidebar-separator):
(.styles-section):
(.styles-section .header):
(.styles-section .header .title):
(.styles-section .header .subtitle):
(.styles-section .header .subtitle a):
(.styles-section .properties):
(.styles-section.no-affect .properties li):
(.styles-section.no-affect .properties li.editing):
(.styles-section.expanded .properties):
(.styles-section .properties li):
(.styles-section .properties li.parent):
(.styles-section .properties ol):
(.styles-section .properties ol.expanded):
(.styles-section .properties li.parent::before):
(.styles-section .properties li.parent.expanded::before):
(.styles-section .properties li .info):
(.styles-section:hover .properties .enabled-button):
(.styles-section .properties li.disabled .enabled-button):
(.styles-section .properties .enabled-button):
(.styles-section .properties .overloaded, .styles-section .properties .disabled):
(.styles-section.computed-style .properties .disabled):
(.styles-section .properties .implicit, .styles-section .properties .inherited):
(.styles-section .properties .inherited):
(.styles-section.show-inherited .properties .inherited):
2010-05-11 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Move buildLayoutInformationForTextBox() from SVGRootInlineBox in SVGInlineTextBox where it belongs
https://bugs.webkit.org/show_bug.cgi?id=38799
Cleanup SVGRootInlineBox/SVGInlineTextBox. Move buildLayoutInformationForTextBox to SVGInlineTextBox.
Move lots of helper methods into new SVGTextLayoutUtilities class. Adapted all callsites.
Fixed bug in kerning handling, hkern was applyable to vertical text as well. Covered by two new tests.
Tests: svg/text/text-hkern-on-vertical-text.svg
svg/text/text-vkern-on-horizontal-text.svg
* Android.mk: Add SVGTextLayoutUtilities.cpp/h to build.
* GNUmakefile.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* rendering/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::calculateGlyphWidth): Use textRenderer()->characters() instead of textRenderer()->text()->characters() as shortcut.
(WebCore::SVGInlineTextBox::svgCharacterHitsPosition): Fix style issue, no else if after a return branch.
(WebCore::SVGInlineTextBox::paintSelection): Use !color.alpha() instead of color.alpha() == 0.
(WebCore::SVGInlineTextBox::buildLayoutInformation): Moved from SVGRootInlineBox::buildLayoutInformationForTextBox.
* rendering/SVGInlineTextBox.h: Fix indention.
(WebCore::SVGInlineTextBox::selectionTop): Inlined.
(WebCore::SVGInlineTextBox::selectionHeight): Inlined.
* rendering/SVGRenderTreeAsText.cpp: Include SVGTextLayoutUtilities.h
* rendering/SVGRootInlineBox.cpp: Move almost all static text layout helper functions in SVGTextLayoutUtilities
(WebCore::calculateTextLengthCorrectionForTextChunk): Fixed style issue in long if conditions spanning multiple lines.
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Use different topLeftPositionOfCharacterRange() taking start/end iterators.
(WebCore::SVGRootInlineBox::buildLayoutInformation): Use the moved SVGInlineTextBox::buildLayoutInformation() method.
(WebCore::SVGRootInlineBox::buildTextChunks): Fixed small style issue, remove unneeded parenthesis.
(WebCore::SVGRootInlineBox::layoutTextChunks): Fix style issue in debugging code.
* rendering/SVGRootInlineBox.h: Rename 'LastGlyphInfo' to 'SVGLastGlyphInfo' and move to SVGTextLayoutUtilities.
(WebCore::SVGRootInlineBox::svgTextChunks): Inlined for speed.
* rendering/SVGTextLayoutUtilities.cpp: Added.
(WebCore::isVerticalWritingMode):
(WebCore::dominantBaselineToShift):
(WebCore::alignmentBaselineToShift):
(WebCore::glyphOrientationToAngle):
(WebCore::glyphOrientationIsMultiplyOf180Degrees):
(WebCore::applyGlyphAdvanceAndShiftRespectingOrientation):
(WebCore::topLeftPositionOfCharacterRange):
(WebCore::cummulatedWidthOfInlineBoxCharacterRange):
(WebCore::cummulatedHeightOfInlineBoxCharacterRange):
(WebCore::svgTextRunForInlineTextBox):
(WebCore::calculateCSSKerning):
(WebCore::applySVGKerning):
* rendering/SVGTextLayoutUtilities.h: Added.
(WebCore::):
(WebCore::SVGTextPaintInfo::SVGTextPaintInfo):
(WebCore::SVGLastGlyphInfo::SVGLastGlyphInfo):
2010-05-11 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Dirk Schulze.
RenderSVGImage::imageChanged should invalidate the SVG filter cache
https://bugs.webkit.org/show_bug.cgi?id=38838
Test: svg/filters/filteredImage.svg
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::imageChanged):
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Fix asserting GTK build.
r59137 changed the behavior of RenderObject::repaintUsingContainer(). I mistakenly
thought that non-compositing builds would always pass a 0 repaintContainer, but
actually the RenderView is passed in this case. So use this to repaint if
ACCELERATED_COMPOSITING is turned off.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Fix warning on Windows about unreachable code.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame):
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
RenderObject::repaintUsingContainer() incorrectly did a view-based
repaint if the repaint container was the RenderView. Instead, we need
to check to see if the RenderView's layer is composited, and, if so,
whether it's painting into the window or not. This can occur when iframes
are composited.
The bug is timing-sensitive, involving compositing in iframes, and I was not able to
concoct a good testcase.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Changes to allow compositing layers for iframes to switch between being hosted
by the iframe's layer-backed NSView, and parented in the GraphicsLayer tree of the
enclosing document.
Tests: compositing/iframes/connect-compositing-iframe.html
compositing/iframes/connect-compositing-iframe2.html
compositing/iframes/connect-compositing-iframe3.html
* page/FrameView.h:
* page/FrameView.cpp:
(WebCore::FrameView::hasCompositedContent): New convenience method.
(WebCore::FrameView::setIsOverlapped): If we're composited, poke the owner document in case it
wants to re-evaluate compositing decisions.
(WebCore::FrameView::isOverlapped): Just expose the existing flag.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::isSelfPaintingLayer):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): If this is an iframe, we need
to ensure that the layers for the iframe content are hooked up.
(WebCore::RenderLayerBacking::updateDrawsContent): When an iframe toggles between different
attachments, the 'drawsContent' behavior of its root layer changes, so needs to be updated.
* rendering/RenderLayerCompositor.h:
(WebCore::RenderLayerCompositor::updateCompositingLayers): Call destroyRootPlatformLayer()
instead of detachRootPlatformLayer() and manually zeroing out the OwnPtrs.
(WebCore::RenderLayerCompositor::updateBacking): If a RenderIFrame changes compositing mode,
we need to ensure that its content compositor attachment is updated.
(WebCore::RenderLayerCompositor::repaintOnCompositingChange): The existing code had a bug
that caused repaints for RenderViews (which have no parent) to bail. We only want to bail
for non-RenderViews that are not attached.
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Factored the iframe-connecting
code into a new method, parentIFrameContentLayers().
(WebCore::RenderLayerCompositor::parentIFrameContentLayers): New method to share the code that hooks
up the iframe's compositing layers to the parent.
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Add logic to propagate
compositing out of iframes on Mac in two situations: 1) when the FrameView is overlapped, and 2)
if the parent document is already composited.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Clean up the logic here to better deal
with dynamic changes of the attachment type.
(WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Clean up and null out the clipping layer here.
(WebCore::RenderLayerCompositor::attachRootPlatformLayer): Call rootLayerAttachmentChanged().
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): Ditto. Also unparent the clipping and platform layers.
(WebCore::RenderLayerCompositor::updateRootLayerAttachment): Call ensureRootPlatformLayer() to re-evaluate
the layer attachment.
(WebCore::RenderLayerCompositor::rootLayerAttachmentChanged): We need to update the drawsContent() status
of the RenderView's layer's backing, because it changes depending on the attachment.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint): Do overlap testing if the frameView can do fast repaints (as before),
but also now when the frameView has composited content.
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Rename the static shouldPropagateCompositingToIFrameParent() to shouldPropagateCompositingToEnclosingIFrame(),
to pave the way for runtime switches in the propagation behavior. We have to make sure we call it on
the correct RenderLayerCompositor (that belonging to the iframe's content document).
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintingGoesToWindow): Now that we know the root layer attachment, we
can simplify this method.
* rendering/RenderLayerCompositor.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::enableCompositingMode): No need for the setNeedsStyleRecalc()
here, because the ensureRootPlatformLayer() or destroyRootPlatformLayer() will have already done it.
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Use the root layer attachment to determine
whether to parent the iframe's layers.
(WebCore::RenderLayerCompositor::didMoveOnscreen): Method name change.
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Name change.
(WebCore::RenderLayerCompositor::requiresCompositingForIFrame): We need to consult the iframe contents
document's compositor to ask whether propagation is appropriate.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Name change.
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Use an enum for the type of root layer attachment on a RenderLayerCompositor, so we can
determine if the attachment is via the ChromeClient, via an enclosing iframe, or unattached.
* rendering/RenderLayerCompositor.h: New RootLayerAttachment enum.
(WebCore::RenderLayerCompositor::rootLayerAttachment): getter for the current attachment.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor): Init m_rootLayerAttachment.
(WebCore::RenderLayerCompositor::~RenderLayerCompositor): Assert that is unattached.
(WebCore::RenderLayerCompositor::updateCompositingLayers): Call destroyRootPlatformLayer instead of willMoveOffscreen,
when there are no layers left. Also clear out the clipping layer.
(WebCore::RenderLayerCompositor::didMoveOnscreen): Call attachRootPlatformLayer.
(WebCore::RenderLayerCompositor::willMoveOffscreen): Call ensureRootPlatformLayer with the appropriate attachment.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Only create the m_rootPlatformLayer if we don't have one
already, but be sure to always set the root layer geometry orientation. Also only create the
m_clippingLayer if we need to.
(WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Call detachRootPlatformLayer().
(WebCore::RenderLayerCompositor::attachRootPlatformLayer): Code moved from didMoveOnscreen, but switching on
attachment.
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): Code moved from willMoveOffscreen, but switching on
attachment.
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Clean up the geometry logic when propagating compositing out of iframes.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition): Geometry on m_rootPlatformLayer no longer
needs to be special when there's a clipping layer.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Don't set the clipping layer to have
flipped geometry ever, and only set the root layer to have flipped geometry if it is not
being hosted in an iframe. Also no need to set a custom anchor point on the clipping layer.
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Clean up some methods related to composited iframes. No behavioral changes.
* rendering/RenderLayerBacking.h: Move innerRenderLayerCompositor() to be a static method:
RenderLayerCompositor::iframeContentsCompositor().
* rendering/RenderLayerBacking.cpp: Remove innerRenderLayerCompositor().
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Call iframeContentsCompositor().
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::enableCompositingMode): Call enclosingIFrameElement()
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): iframeContentsCompositor() is now a static method in this class.
Also check that the iframe contents are in compositing mode (slightly clearer than relying on rootPlatformLayer() returning
null).
(WebCore::RenderLayerCompositor::iframeContentsCompositor): Moved from RenderLayerBacking.
(WebCore::RenderLayerCompositor::didMoveOnscreen): Use enclosingIFrameElement() method.
(WebCore::RenderLayerCompositor::willMoveOffscreen): Ditto.
(WebCore::RenderLayerCompositor::enclosingIFrameElement): New method.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Call enclosingIFrameElement().
* rendering/RenderLayerCompositor.h: New method, iframeContentsCompositor().
2010-05-10 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Brady Eidson.
Cleaning up and fixing the existing JSC DB bindings.
https://bugs.webkit.org/show_bug.cgi?id=34994
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::openDatabase):
* bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::changeVersion):
(WebCore::createTransaction):
(WebCore::JSDatabase::transaction):
(WebCore::JSDatabase::readTransaction):
* bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
2010-05-10 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket needs to suspend/resume as Active DOM object.
https://bugs.webkit.org/show_bug.cgi?id=38171
Implement suspend()/resume() in WebSocket and WebSocketChannel.
While WebSocketChannel is suspended, it only adds received data in m_buffer
or record the handle was closed, and report no event to WebSocket.
When resumed, it will process buffer or handle closing.
Since suspend/resume would be called while processing JavaScript event handler (e.g. before/after alert()), WebSocketChannel method that would fire an event need to be reentrant.
So, WebSocketChannel::processBuffer() call WebSocket to fire an event at most once and skips buffer before the calling,
so that next call of processBuffer() would process the next frame.
* websockets/ThreadableWebSocketChannel.h:
* websockets/ThreadableWebSocketChannelClientWrapper.h:
(WebCore::ThreadableWebSocketChannelClientWrapper::didConnect):
Mark channel is opened, and process pending events if not suspended.
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
Push message back in pending queue, and process pending events if not suspended.
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
Mark channel is closed, and process pending events if not suspended.
(WebCore::ThreadableWebSocketChannelClientWrapper::suspend):
Mark suspended.
(WebCore::ThreadableWebSocketChannelClientWrapper::resume):
Unmark suspended, and process pending events.
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingEvents):
* websockets/WebSocket.cpp:
(WebCore::WebSocket::canSuspend):
(WebCore::WebSocket::suspend):
(WebCore::WebSocket::resume):
(WebCore::WebSocket::didClose):
* websockets/WebSocket.h:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::bufferedAmount):
(WebCore::WebSocketChannel::close):
(WebCore::WebSocketChannel::suspend):
(WebCore::WebSocketChannel::resume):
When resumed, it will process buffer and
handle closing if handle was already closed while suspended.
(WebCore::WebSocketChannel::didClose):
If suspended, record unhandled bufferedAmount and set m_closed true, so that closing will be processed when resumed.
(WebCore::WebSocketChannel::didReceiveData):
Add received data in buffer and process buffer while it is not suspended.
(WebCore::WebSocketChannel::processBuffer):
Process handshake header or one frame message.
Return true if there are more data to be processed.
Return false otherwise (e.g. incomplete handshake header or incomplete frame).
* websockets/WebSocketChannel.h:
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::suspend):
(WebCore::WorkerThreadableWebSocketChannel::resume):
(WebCore::WorkerThreadableWebSocketChannel::Peer::suspend):
(WebCore::WorkerThreadableWebSocketChannel::Peer::resume):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSuspend):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadResume):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
* websockets/WorkerThreadableWebSocketChannel.h:
2010-05-07 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Brady Eidson.
Implement the JSC bindings for the sync DB API.
https://bugs.webkit.org/show_bug.cgi?id=34994
* bindings/js/JSDatabaseSyncCustom.cpp:
(WebCore::JSDatabaseSync::changeVersion):
(WebCore::createTransaction):
* bindings/js/JSSQLTransactionSyncCustom.cpp:
(WebCore::JSSQLTransactionSync::executeSql):
2010-05-10 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=36566
The animation-fill-mode property was missing from
a few places where the animation shorthand is set up.
Test: animations/animation-shorthand-removed.html
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::getPropertyValue): Make sure
animation-fill-mode is included in the animation shorthand
* css/CSSPropertyLonghand.cpp:
(WebCore::initShorthandMap):
2010-05-10 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=38583
<rdar://problem/7948784> Crash in Element::normalizeAttributes.
Test: fast/dom/Element/normalize-crash.html
* dom/Element.cpp:
(WebCore::Element::normalizeAttributes): Copy attributes to a vector
before iterating.
* dom/NamedAttrMap.cpp:
(WebCore::NamedNodeMap::copyAttributesToVector): Added.
* dom/NamedAttrMap.h:
2010-05-10 Jian Li <jianli@chromium.org>
Reviewed by Adam Barth.
[V8] Fix V8 code generator script to generate the correct code for
converting ScriptString.
https://bugs.webkit.org/show_bug.cgi?id=38873
Updated the bindings test result. Note that the result is also updated
to reflect other script generator changes not introduced by this patch.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::JSTestCallback):
(WebCore::JSTestCallback::~JSTestCallback):
* bindings/scripts/test/JS/JSTestCallback.h:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::scriptStringAttrAttrGetter):
2010-05-10 Mark Rowe <mrowe@apple.com>
Fix the 32-bit WebKit2 build.
* WebCore.base.exp:
2010-05-07 Jon Honeycutt <jhoneycutt@apple.com>
Crash closing window containing Flash plug-in
https://bugs.webkit.org/show_bug.cgi?id=38797
<rdar://problem/7935266>
Reviewed by Eric Seidel.
Test: plugins/geturlnotify-during-document-teardown.html
* plugins/PluginView.cpp:
(WebCore::PluginView::load):
Null check the DocumentLoader; it's possible for this to be null while
the Document is being torn down and before the plug-in is destroyed.
2010-05-10 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
Based on a patch by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=28697
<rdar://problem/7946578> WebKit crash on WebCore::Node::nodeIndex()
It's not OK to call ContainerNode::willRemoveChild() in a loop, because Range code assumes
that it can adjust start and end position to any node except for the one being removed -
so these notifications cannot be batched.
Test: fast/dom/Range/remove-all-children-crash.html
* dom/ContainerNode.cpp:
(WebCore::willRemoveChild): Removed unused ExceptionCode.
(WebCore::willRemoveChildren): New function, used in removeChildren() case.
(WebCore::ContainerNode::removeChild): ExceptionCode return was always 0, don't bother with it.
(WebCore::ContainerNode::removeChildren): Call willRemoveChildrenFromNode.
(WebCore::dispatchChildRemovalEvents): Moved some logic out into willRemoveChildrenFromNode
and willRemoveChild.
* dom/Document.cpp:
(WebCore::Document::nodeChildrenWillBeRemoved): New function, used in removeChildren() case.
* dom/Document.h:
(WebCore::Document::nodeChildrenWillBeRemoved): New function, used in removeChildren() case.
* dom/Range.h:
* dom/Range.cpp:
(WebCore::boundaryNodeChildrenWillBeRemoved): New function, used in removeChildren() case.
(WebCore::Range::nodeChildrenWillBeRemoved): Ditto.
2010-05-10 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Adam Barth.
Implement the V8 bindings for the sync DB API.
https://bugs.webkit.org.show_bug.cgi?id=34994
* bindings/v8/custom/V8DatabaseSyncCustom.cpp:
(WebCore::V8DatabaseSync::changeVersionCallback):
(WebCore::createTransaction):
* bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContextCustom::openDatabaseSyncCallback):
2010-05-10 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Adam Barth.
Clean up and fix the existing V8 DB bindings.
https://bugs.webkit.org/show_bug.cgi?id=34994
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
* bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::V8Database::changeVersionCallback):
(WebCore::createTransaction):
* bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
2010-05-10 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix for wx 2.8 after complex text changes.
* platform/graphics/wx/FontPlatformDataWxMac.mm:
(WebCore::FontPlatformData::nsFont):
* platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::platformWidthForGlyph):
2010-05-10 John Gregg <johnnyg@google.com>
[chromium] Try to fix the chromium build after r59085 by
including MathExtras.h before using isnan().
https://bugs.webkit.org/show_bug.cgi?id=38860
* html/canvas/WebGLIntegralTypedArrayBase.h:
2010-05-10 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix for wx trunk after complex text changes.
* platform/graphics/wx/FontPlatformDataWx.cpp:
(WebCore::FontPlatformData::FontPlatformData):
2010-05-10 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Provide mechanism to cache metadata for a resource
https://bugs.webkit.org/show_bug.cgi?id=37874
No new tests because no new functionality.
* WebCore.gypi:
* loader/CachedMetadata.h: Added.
(WebCore::CachedMetadata::create):
(WebCore::CachedMetadata::deserialize):
(WebCore::CachedMetadata::serialize):
(WebCore::CachedMetadata::~CachedMetadata):
(WebCore::CachedMetadata::dataTypeID):
(WebCore::CachedMetadata::data):
(WebCore::CachedMetadata::size):
(WebCore::CachedMetadata::readUnsigned):
(WebCore::CachedMetadata::appendUnsigned):
(WebCore::CachedMetadata::CachedMetadata):
* loader/CachedResource.cpp:
(WebCore::CachedResource::setSerializedCachedMetadata):
(WebCore::CachedResource::setCachedMetadata):
(WebCore::CachedResource::cachedMetadata):
* loader/CachedResource.h:
* loader/ResourceLoader.h:
(WebCore::ResourceLoader::didReceiveCachedMetadata):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveCachedMetadata):
* loader/SubresourceLoader.h:
* loader/SubresourceLoaderClient.h:
(WebCore::SubresourceLoaderClient::didReceiveCachedMetadata):
* loader/loader.cpp:
(WebCore::Loader::Host::didReceiveCachedMetadata):
* loader/loader.h:
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::cacheMetadata):
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::didReceiveCachedMetadata):
2010-05-09 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Refactor WebGLArray types to share more code
https://bugs.webkit.org/show_bug.cgi?id=37712
Refactored WebGLArray types for maximal code sharing. Added
WebGLTypedArrayBase and WebGLIntegralTypedArrayBase template
superclasses. Changed overridden virtuals to have minimal
visibility (private instead of public). Fixed const correctness of
a few methods. There are no changes to the public APIs of the
WebGLArray classes; the JavaScript bindings are unchanged.
No new tests; existing tests cover this functionality. Ran all
WebGL layout tests in Safari and Chromium on Mac OS X.
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* html/canvas/WebGLArray.h:
(WebCore::WebGLArray::buffer):
(WebCore::WebGLArray::baseAddress):
(WebCore::WebGLArray::byteOffset):
* html/canvas/WebGLByteArray.cpp:
(WebCore::WebGLByteArray::create):
(WebCore::WebGLByteArray::WebGLByteArray):
(WebCore::WebGLByteArray::slice):
* html/canvas/WebGLByteArray.h:
(WebCore::WebGLByteArray::isByteArray):
* html/canvas/WebGLFloatArray.cpp:
(WebCore::WebGLFloatArray::create):
(WebCore::WebGLFloatArray::WebGLFloatArray):
(WebCore::WebGLFloatArray::slice):
* html/canvas/WebGLFloatArray.h:
(WebCore::WebGLFloatArray::set):
(WebCore::WebGLFloatArray::item):
(WebCore::WebGLFloatArray::isFloatArray):
* html/canvas/WebGLIntArray.cpp:
(WebCore::WebGLIntArray::create):
(WebCore::WebGLIntArray::WebGLIntArray):
(WebCore::WebGLIntArray::slice):
* html/canvas/WebGLIntArray.h:
(WebCore::WebGLIntArray::isIntArray):
* html/canvas/WebGLIntegralTypedArrayBase.h: Added.
(WebCore::WebGLIntegralTypedArrayBase::set):
(WebCore::WebGLIntegralTypedArrayBase::item):
(WebCore::WebGLIntegralTypedArrayBase::WebGLIntegralTypedArrayBase):
* html/canvas/WebGLShortArray.cpp:
(WebCore::WebGLShortArray::create):
(WebCore::WebGLShortArray::WebGLShortArray):
(WebCore::WebGLShortArray::slice):
* html/canvas/WebGLShortArray.h:
(WebCore::WebGLShortArray::isShortArray):
* html/canvas/WebGLTypedArrayBase.h: Added.
(WebCore::WebGLTypedArrayBase::data):
(WebCore::WebGLTypedArrayBase::set):
(WebCore::WebGLTypedArrayBase::length):
(WebCore::WebGLTypedArrayBase::WebGLTypedArrayBase):
(WebCore::WebGLTypedArrayBase::create):
(WebCore::WebGLTypedArrayBase::sliceImpl):
(WebCore::WebGLTypedArrayBase::byteLength):
* html/canvas/WebGLUnsignedByteArray.cpp:
(WebCore::WebGLUnsignedByteArray::create):
(WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray):
(WebCore::WebGLUnsignedByteArray::slice):
* html/canvas/WebGLUnsignedByteArray.h:
(WebCore::WebGLUnsignedByteArray::isUnsignedByteArray):
* html/canvas/WebGLUnsignedIntArray.cpp:
(WebCore::WebGLUnsignedIntArray::create):
(WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray):
(WebCore::WebGLUnsignedIntArray::slice):
* html/canvas/WebGLUnsignedIntArray.h:
(WebCore::WebGLUnsignedIntArray::isUnsignedIntArray):
* html/canvas/WebGLUnsignedShortArray.cpp:
(WebCore::WebGLUnsignedShortArray::create):
(WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray):
(WebCore::WebGLUnsignedShortArray::slice):
* html/canvas/WebGLUnsignedShortArray.h:
(WebCore::WebGLUnsignedShortArray::isUnsignedShortArray):
2010-05-10 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Refactor WebGLArray types to share more code
https://bugs.webkit.org/show_bug.cgi?id=37712
Refactored WebGLArray types for maximal code sharing. Added
WebGLTypedArrayBase and WebGLIntegralTypedArrayBase template
superclasses. Changed overridden virtuals to have minimal
visibility (private instead of public). Fixed const correctness of
a few methods. There are no changes to the public APIs of the
WebGLArray classes; the JavaScript bindings are unchanged.
No new tests; existing tests cover this functionality. Ran all
WebGL layout tests in Safari and Chromium on Mac OS X.
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* html/canvas/WebGLArray.h:
(WebCore::WebGLArray::buffer):
(WebCore::WebGLArray::baseAddress):
(WebCore::WebGLArray::byteOffset):
* html/canvas/WebGLByteArray.cpp:
(WebCore::WebGLByteArray::create):
(WebCore::WebGLByteArray::WebGLByteArray):
(WebCore::WebGLByteArray::slice):
* html/canvas/WebGLByteArray.h:
(WebCore::WebGLByteArray::isByteArray):
* html/canvas/WebGLFloatArray.cpp:
(WebCore::WebGLFloatArray::create):
(WebCore::WebGLFloatArray::WebGLFloatArray):
(WebCore::WebGLFloatArray::slice):
* html/canvas/WebGLFloatArray.h:
(WebCore::WebGLFloatArray::set):
(WebCore::WebGLFloatArray::item):
(WebCore::WebGLFloatArray::isFloatArray):
* html/canvas/WebGLIntArray.cpp:
(WebCore::WebGLIntArray::create):
(WebCore::WebGLIntArray::WebGLIntArray):
(WebCore::WebGLIntArray::slice):
* html/canvas/WebGLIntArray.h:
(WebCore::WebGLIntArray::isIntArray):
* html/canvas/WebGLIntegralTypedArrayBase.h: Added.
(WebCore::WebGLIntegralTypedArrayBase::set):
(WebCore::WebGLIntegralTypedArrayBase::item):
(WebCore::WebGLIntegralTypedArrayBase::WebGLIntegralTypedArrayBase):
* html/canvas/WebGLShortArray.cpp:
(WebCore::WebGLShortArray::create):
(WebCore::WebGLShortArray::WebGLShortArray):
(WebCore::WebGLShortArray::slice):
* html/canvas/WebGLShortArray.h:
(WebCore::WebGLShortArray::isShortArray):
* html/canvas/WebGLTypedArrayBase.h: Added.
(WebCore::WebGLTypedArrayBase::data):
(WebCore::WebGLTypedArrayBase::set):
(WebCore::WebGLTypedArrayBase::length):
(WebCore::WebGLTypedArrayBase::WebGLTypedArrayBase):
(WebCore::WebGLTypedArrayBase::create):
(WebCore::WebGLTypedArrayBase::sliceImpl):
(WebCore::WebGLTypedArrayBase::byteLength):
* html/canvas/WebGLUnsignedByteArray.cpp:
(WebCore::WebGLUnsignedByteArray::create):
(WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray):
(WebCore::WebGLUnsignedByteArray::slice):
* html/canvas/WebGLUnsignedByteArray.h:
(WebCore::WebGLUnsignedByteArray::isUnsignedByteArray):
* html/canvas/WebGLUnsignedIntArray.cpp:
(WebCore::WebGLUnsignedIntArray::create):
(WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray):
(WebCore::WebGLUnsignedIntArray::slice):
* html/canvas/WebGLUnsignedIntArray.h:
(WebCore::WebGLUnsignedIntArray::isUnsignedIntArray):
* html/canvas/WebGLUnsignedShortArray.cpp:
(WebCore::WebGLUnsignedShortArray::create):
(WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray):
(WebCore::WebGLUnsignedShortArray::slice):
* html/canvas/WebGLUnsignedShortArray.h:
(WebCore::WebGLUnsignedShortArray::isUnsignedShortArray):
2010-05-10 Brent Fulgham <bfulgham@webkit.org>
Build fix, not reviewed.
Correct post-build copy command for WinCairo port to make sure
cairo headers are available for WebKit.dll build.
* WebCore.vcproj/WebCore.vcproj:
2010-05-10 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Further optimization for SVG's repaintRect calculation
https://bugs.webkit.org/show_bug.cgi?id=38820
This is a further optimization to get smaller repaintRects on SVG objects
in combination with masker or clipper resources.
Masker takes the unite of all stroke boundaries of it's childs.
Both, clipper and masker, store this union to avoid multiple calls of the childs
and the unite calculations now.
The unite rect can be transformed to any targets objectBoundingBox, if the content
unit of the resource is set to objectBoundingBoxMode.
This speeds up the use of resources with multiple target objects.
No behavior changes, the smaller repaintRects cause updates for DRT results.
* rendering/RenderSVGResource.h:
* rendering/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::invalidateClients):
(WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect):
(WebCore::RenderSVGResourceClipper::resourceBoundingBox):
* rendering/RenderSVGResourceClipper.h:
* rendering/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::resourceBoundingBox):
* rendering/RenderSVGResourceFilter.h:
* rendering/RenderSVGResourceGradient.h:
(WebCore::RenderSVGResourceGradient::resourceBoundingBox):
* rendering/RenderSVGResourceMarker.h:
(WebCore::RenderSVGResourceMarker::resourceBoundingBox):
* rendering/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::invalidateClients):
(WebCore::RenderSVGResourceMasker::createMaskImage):
(WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect):
(WebCore::RenderSVGResourceMasker::resourceBoundingBox):
* rendering/RenderSVGResourceMasker.h:
* rendering/RenderSVGResourcePattern.h:
(WebCore::RenderSVGResourcePattern::resourceBoundingBox):
* rendering/RenderSVGResourceSolidColor.h:
(WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):
2010-05-11 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Cosmetic changes.
1) Inner Function Call event of Timer Fire should be merged into parent even if it is not the only child.
2) Standard tooltips for resource links are clashing with Popover.
3) Recalculate Style caller info are duplicating in Details Popover (Caller and Details rows).
https://bugs.webkit.org/show_bug.cgi?id=38732
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
* inspector/front-end/inspector.js:
(WebInspector.linkifyURLAsNode):
2010-05-10 Csaba Osztrogonác <ossy@webkit.org>
Rubber-stamped by Simon Hausmann.
[Qt] Roll-out r59020 and r59021, because the Qt part of these changes
haven't been landed in Qt trunk yet. Should be rolled-in again after the merge.
https://bugs.webkit.org/show_bug.cgi?id=32967
* platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):
2010-05-10 Markus Goetz <Markus.Goetz@nokia.com>
Reviewed by Simon Hausmann.
Qt after 4.6.3 has its integrated DNS cache. Therefore some
code is not necessary anymore.
https://bugs.webkit.org/show_bug.cgi?id=38834
* platform/network/qt/DnsPrefetchHelper.h:
(WebCore::DnsPrefetchHelper::lookup):
(WebCore::DnsPrefetchHelper::lookedUp):
2010-05-10 Chris Jerdonek <cjerdonek@webkit.org>
Reviewed by Darin Adler.
Asserted that Node::setDocument() is not being used to change
the document of a node.
https://bugs.webkit.org/show_bug.cgi?id=38821
* dom/Node.cpp:
(WebCore::Node::setDocument):
Added an ASSERT at the beginning of the function.
* dom/Node.h:
Documented that Node::setDocument() should not be used to change the
document of a node until after the node has been removed from its
prior document.
2010-05-10 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683
All SVG Filter effects get dumped now. The structure of the DRT output
changed. The last effect is shown first, followed by the previous effects.
No changed behaior, so no new test added.
* platform/graphics/filters/FEBlend.cpp:
(WebCore::operator<<):
(WebCore::FEBlend::externalRepresentation):
* platform/graphics/filters/FEBlend.h:
* platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::operator<<):
(WebCore::FEColorMatrix::externalRepresentation):
* platform/graphics/filters/FEColorMatrix.h:
* platform/graphics/filters/FEComponentTransfer.cpp:
(WebCore::operator<<):
(WebCore::FEComponentTransfer::externalRepresentation):
* platform/graphics/filters/FEComponentTransfer.h:
* platform/graphics/filters/FEComposite.cpp:
(WebCore::operator<<):
(WebCore::FEComposite::externalRepresentation):
* platform/graphics/filters/FEComposite.h:
(WebCore::):
(WebCore::FEComposite::uniteChildEffectSubregions):
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::externalRepresentation):
* platform/graphics/filters/FEGaussianBlur.h:
(WebCore::FEGaussianBlur::uniteChildEffectSubregions):
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::externalRepresentation):
* platform/graphics/filters/FilterEffect.h:
* platform/graphics/filters/SourceAlpha.cpp:
(WebCore::SourceAlpha::externalRepresentation):
* platform/graphics/filters/SourceAlpha.h:
* platform/graphics/filters/SourceGraphic.cpp:
(WebCore::SourceGraphic::externalRepresentation):
* platform/graphics/filters/SourceGraphic.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::writeIndent):
* rendering/RenderTreeAsText.h:
* rendering/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGResourceContainer):
* svg/graphics/filters/SVGFEConvolveMatrix.cpp:
(WebCore::operator<<):
(WebCore::FEConvolveMatrix::externalRepresentation):
* svg/graphics/filters/SVGFEConvolveMatrix.h:
* svg/graphics/filters/SVGFEDiffuseLighting.cpp:
(WebCore::FEDiffuseLighting::externalRepresentation):
* svg/graphics/filters/SVGFEDiffuseLighting.h:
* svg/graphics/filters/SVGFEDisplacementMap.cpp:
(WebCore::operator<<):
(WebCore::FEDisplacementMap::externalRepresentation):
* svg/graphics/filters/SVGFEDisplacementMap.h:
* svg/graphics/filters/SVGFEFlood.cpp:
(WebCore::FEFlood::externalRepresentation):
* svg/graphics/filters/SVGFEFlood.h:
* svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::externalRepresentation):
* svg/graphics/filters/SVGFEImage.h:
* svg/graphics/filters/SVGFEMerge.cpp:
(WebCore::FEMerge::externalRepresentation):
* svg/graphics/filters/SVGFEMerge.h:
* svg/graphics/filters/SVGFEMorphology.cpp:
(WebCore::operator<<):
(WebCore::FEMorphology::externalRepresentation):
* svg/graphics/filters/SVGFEMorphology.h:
* svg/graphics/filters/SVGFEOffset.cpp:
(WebCore::FEOffset::externalRepresentation):
* svg/graphics/filters/SVGFEOffset.h:
* svg/graphics/filters/SVGFESpecularLighting.cpp:
(WebCore::FESpecularLighting::externalRepresentation):
* svg/graphics/filters/SVGFESpecularLighting.h:
* svg/graphics/filters/SVGFETile.cpp:
(WebCore::FETile::externalRepresentation):
* svg/graphics/filters/SVGFETile.h:
* svg/graphics/filters/SVGFETurbulence.cpp:
(WebCore::operator<<):
(WebCore::FETurbulence::externalRepresentation):
* svg/graphics/filters/SVGFETurbulence.h:
2010-05-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Change IndexedDB to use events instead of callbacks
https://bugs.webkit.org/show_bug.cgi?id=38594
Switch IndexedDB over to an event based model to match what
Mozilla (and probably MS?) are doing. This also gets rid of
a lot of template mess at the expense of a little extra boiler
plate code (for each type that IDBResult.result could be).
This change also introduces JSC bindings that match the level of
functionality the V8 bindings have.
Still not testable, but that shoudl change shortly.
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSEventCustom.cpp:
* bindings/js/JSIDBRequestCustom.cpp: Added.
(WebCore::JSIDBRequest::result):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
* bindings/v8/custom/V8CustomIDBCallbacks.h: Removed.
* bindings/v8/custom/V8IDBRequestCustom.cpp: Added.
(WebCore::V8IDBRequest::resultAccessorGetter):
* bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: Removed.
* dom/EventTarget.cpp:
(WebCore::EventTarget::toIDBRequest):
* dom/EventTarget.h:
* storage/IDBCallbacks.h:
* storage/IDBDatabaseRequest.h:
(WebCore::IDBDatabaseRequest::createObjectStore):
* storage/IDBRequest.cpp: Added.
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::~IDBRequest):
(WebCore::IDBRequest::idbDatabaseResult):
(WebCore::IDBRequest::serializedScriptValueResult):
(WebCore::IDBRequest::onError):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::scriptExecutionContext):
(WebCore::IDBRequest::stop):
(WebCore::IDBRequest::suspend):
(WebCore::IDBRequest::resume):
(WebCore::IDBRequest::eventTargetData):
(WebCore::IDBRequest::ensureEventTargetData):
(WebCore::IDBRequest::timerFired):
(WebCore::IDBRequest::onEventCommon):
* storage/IDBRequest.h: Added.
(WebCore::IDBRequest::create):
(WebCore::IDBRequest::):
(WebCore::IDBRequest::resultType):
(WebCore::IDBRequest::readyState):
(WebCore::IDBRequest::error):
(WebCore::IDBRequest::toIDBRequest):
(WebCore::IDBRequest::refEventTarget):
(WebCore::IDBRequest::derefEventTarget):
* storage/IDBRequest.idl: Added.
* storage/IndexedDatabase.h:
* storage/IndexedDatabaseImpl.cpp:
(WebCore::IndexedDatabaseImpl::open):
* storage/IndexedDatabaseImpl.h:
* storage/IndexedDatabaseRequest.cpp:
(WebCore::IndexedDatabaseRequest::open):
* storage/IndexedDatabaseRequest.h:
* storage/IndexedDatabaseRequest.idl:
2010-05-10 Ilya Tikhonovsky <loislo@chromium.org>
Not reviewed: rollback the commit r59062
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
* inspector/front-end/inspector.js:
(WebInspector.linkifyURLAsNode):
2010-05-10 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Cosmetic changes.
1) Inner Function Call event of Timer Fire should be merged into parent even if it is not the only child.
2) Standard tooltips for resource links are clashing with Popover.
3) Recalculate Style caller info are duplicating in Details Popover (Caller and Details rows).
https://bugs.webkit.org/show_bug.cgi?id=38732
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
* inspector/front-end/inspector.js:
(WebInspector.linkifyURLAsNode):
2010-05-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: If some record is not in visible area then it's expand element also is not
visible even if it has children in visible area.
https://bugs.webkit.org/show_bug.cgi?id=38643
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._refreshRecords):
2010-05-07 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=38557
r58526 introduced a ~30% regression on Dromaeo JS lib
This fix does two things.
- Don't use QualifiedName as the key to a HashMap, use a
RefPtr<QualifiedNameImpl> instead. We should remove the HashTraits for
QualifiedName and that will happen in a follow up patch.
- Only mark cached NodeLists on Documents instead of all Nodes. This is
okay since the marking of NodeLists is an optimization to keep NodeList
wrappers alive and is not mandated by any spec.
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::markChildren):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::markChildren):
* dom/Node.cpp:
(WebCore::Node::removeCachedTagNodeList):
(WebCore::Node::getElementsByTagNameNS):
* dom/NodeRareData.h:
2010-05-08 Antonio Gomes <tonikitoo@webkit.org>
Unreviewed attempt to fix Windows build.
* page/SpatialNavigation.h:
(WebCore::fudgeFactor):
2010-05-03 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Kenneth Christiansen.
Spatial Navigation: create a getter for the "fudgeFactor"
https://bugs.webkit.org/show_bug.cgi?id=38488
A couple of places in the Spatial Navigation code make use of a "fudge factor"
to improve precision by working around outline focus metrics and such. Patch adds
a helper method for unify getter operations of this value, instead of having it
declared locally in the various methods it is used.
No behaviour change.
* page/SpatialNavigation.cpp:
(WebCore::scrollIntoView):
(WebCore::deflateIfOverlapped):
* page/SpatialNavigation.h:
(WebCore::fudgeFactor):
2010-05-08 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Darin Adler.
Change the npapi.h header guards to match the npapi-headers repository
copy.
https://bugs.webkit.org/show_bug.cgi?id=38666
* bridge/npapi.h:
2010-05-08 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Darin Fisher.
Resolve most of the whitespace/comment/order differences in npapi.h
and npruntime.h relative to the npapi-headers repository versions.
No changes to the substance of the code.
https://bugs.webkit.org/show_bug.cgi?id=38666
* bridge/npapi.h:
(_NPPrint::):
(_NPCocoaEvent::):
* bridge/npruntime.h:
2010-05-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
Fix guard around IndexedDatabase
https://bugs.webkit.org/show_bug.cgi?id=38710
No new tests, there is no new functionality.
* page/PageGroup.h:
2010-05-08 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] Platform plugin
https://bugs.webkit.org/show_bug.cgi?id=38438
Select popups delegate private API. To provide select popup delegates
a plugin that implements QWebKitPlatformPlugin must be found
in QCoreApplication::libraryPaths.
* WebCore.pro:
2010-05-08 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
[EFL] It does not make sense to use RenderThemeEfl::RenderThemeEfl, so
use RenderThemeEfl (GCC 4.5 seems to be pickier about this).
http://webkit.org/b/38770
* platform/efl/RenderThemeEfl.cpp:
(WebCore::renderThemeEflColorClassSelectionActive):
(WebCore::renderThemeEflColorClassSelectionInactive):
(WebCore::renderThemeEflColorClassFocusRing):
(WebCore::renderThemeEflColorClassButtonText):
(WebCore::renderThemeEflColorClassComboText):
(WebCore::renderThemeEflColorClassEntryText):
(WebCore::renderThemeEflColorClassSearchText):
(WebCore::RenderThemeEfl::adjustCheckboxStyle):
(WebCore::RenderThemeEfl::adjustRadioStyle):
(WebCore::RenderThemeEfl::adjustButtonStyle):
(WebCore::RenderThemeEfl::adjustMenuListStyle):
(WebCore::RenderThemeEfl::adjustTextFieldStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldStyle):
2010-05-08 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
ResourceHandleSoup should depend only on GLib, not on GTK+.
http://webkit.org/b/38763
* platform/network/soup/ResourceHandleSoup.cpp: Include glib.h
instead of gtk/gtk.h.
2010-05-08 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r59023.
http://trac.webkit.org/changeset/59023
https://bugs.webkit.org/show_bug.cgi?id=37874
Caused Chromium Windows build to fail to link.
* WebCore.gypi:
* loader/CachedMetadata.h: Removed.
* loader/CachedResource.cpp:
* loader/CachedResource.h:
* loader/ResourceLoader.h:
* loader/SubresourceLoader.cpp:
* loader/SubresourceLoader.h:
* loader/SubresourceLoaderClient.h:
* loader/loader.cpp:
* loader/loader.h:
* platform/network/ResourceHandle.cpp:
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
2010-05-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Autocompletion in console is not usable because it is not add to the entered text the common prefix of suggestions.
As example if you entered $0.getE then getElementByClassName will be suggested as gray text.
If you press tab then getElementByClassName be suggested again and lementByClassName becomes selected as black text with selection background.
Really after pressing the TAB the next suggestion should be selected (getElementByTagName) and only flexible part of suggestions should be selected.
In this case it should be TagName because getElementBy is the common part for all getE prefix suggestions.
https://bugs.webkit.org/show_bug.cgi?id=38753
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._completionsReady):
2010-05-08 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Fisher.
Provide mechanism to store cached metadata on a CachedResource.
https://bugs.webkit.org/show_bug.cgi?id=37874
No new tests because no new functionality.
* WebCore.gypi:
* loader/CachedMetadata.h: Added.
(WebCore::CachedMetadata::~CachedMetadata):
(WebCore::CachedMetadata::data):
(WebCore::CachedMetadata::size):
(WebCore::CachedMetadata::create):
(WebCore::CachedMetadata::deserialize):
(WebCore::CachedMetadata::serialize):
(WebCore::CachedMetadata::dataTypeID):
(WebCore::CachedMetadata::readUnsigned):
(WebCore::CachedMetadata::appendUnsigned):
(WebCore::CachedMetadata::CachedMetadata):
* loader/CachedResource.cpp:
(WebCore::CachedResource::setSerializedCachedMetadata):
(WebCore::CachedResource::setCachedMetadata):
(WebCore::CachedResource::cachedMetadata):
* loader/CachedResource.h:
* loader/ResourceLoader.h:
(WebCore::ResourceLoader::didReceiveCachedMetadata):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveCachedMetadata):
* loader/SubresourceLoader.h:
* loader/SubresourceLoaderClient.h:
(WebCore::SubresourceLoaderClient::didReceiveCachedMetadata):
* loader/loader.cpp:
(WebCore::Loader::Host::didReceiveCachedMetadata):
* loader/loader.h:
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::cacheMetadata):
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::didReceiveCachedMetadata):
2010-05-08 Michael Nordman <michaeln@google.com>
Reviewed by Dmitry Titov.
Have WorkerScriptLoader provide access to the ResourceResponse for the loaded script
through the WorkerScriptLoaderClient interface.
https://bugs.webkit.org/show_bug.cgi?id=38605
No new tests. There are no script visible changes.
* workers/WorkerScriptLoader.cpp: Call the client with the response.
(WebCore::WorkerScriptLoader::didReceiveResponse):
* workers/WorkerScriptLoaderClient.h: Define a new method to receive the response.
(WebCore::WorkerScriptLoaderClient::didReceiveResponse):
2010-05-08 Robert Hogan <robert@roberthogan.net>
Reviewed by Simon Hausmann.
[Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html
and http/tests/xmlhttprequest/cross-origin-authorization.html
QHttpNetworkRequest adds Authorization and Cookie headers to XHRs
without knowing if this is valid behaviour or not. In order to allow
Qt to decide whether Cookie/Authorization headers should be added
to an XHR QtWebKit needs to use an attribute added to QNetworkRequest.
These new attributes are: QNetworkRequest::CookieLoadControlAttribute,
QNetworkRequest::CookieSaveControlAttribute,and
QNetworkRequest::AuthenticationReuseControlAttribute.
QtWebKit will set QNetworkRequest::AuthenticationReuseControlAttribute to false
unless withCredentials is set to true in the XHR.
QtWebkit will set CookieLoad/SaveControlAttribute to false unless withCredentials
is set to true in the XHR.
Qt will pass the values onto QHttpNetworkRequest and this will permit
the Qt network access processing to decide whether or not to add either
or both of the Cookie/Authorisation headers, and whether to save cookies
returned from such requests. By default the attribute
will always be true so unless QtWebKit sets it to false normal
header processing is unaffected.
The Qt part of these changes was merged at: http://gitorious.org/qt/qt/merge_requests/592
https://bugs.webkit.org/show_bug.cgi?id=32967
* platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):
2010-05-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInsector: Record expand UI element should be extracted from TimelineRecordGraphRow as separate class for future reuse.
https://bugs.webkit.org/show_bug.cgi?id=38726
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelineRecordGraphRow):
(WebInspector.TimelineRecordGraphRow.prototype.update):
(WebInspector.TimelineExpandableElement):
(WebInspector.TimelineExpandableElement.prototype._update):
(WebInspector.TimelineExpandableElement.prototype._dispose):
2010-05-05 Robert Hogan <robert@webkit.org>
Reviewed by Alexey Proskuryakov.
[Qt] Fix encoding of status message in Plugin API
https://bugs.webkit.org/show_bug.cgi?id=35144
Spotted by Alexey Proskuryakov.
* plugins/PluginView.cpp:
(WebCore::PluginView::status):
2010-05-08 Dirk Schulze <krit@webkit.org>
Unreviewed win build fix.
JS bindings were missing in DerivedSources.cpp
* DerivedSources.cpp:
2010-05-08 Dirk Schulze <krit@webkit.org>
Uneviewed fix of Win bot
Added JS bindings to Win build system.
* WebCore.vcproj/WebCore.vcproj:
2010-05-08 Dirk Schulze <krit@webkit.org>
Unreviewed try to fix Win bot.
SVGFont's VKern implementation missing
https://bugs.webkit.org/show_bug.cgi?id=38663
* bindings/scripts/CodeGeneratorJS.pm:
2010-05-08 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGFont's VKern implementation missing
https://bugs.webkit.org/show_bug.cgi?id=38663
Implementation of vkern, needed by SVGFont. Also added DOM and JS bindings
for vkern and hkern. Made some clean-up in SVGParserUtilities and SVGFontElement.
SVGHKernElement and SVGVKernElement share most of the code now.
Test: svg/text/text-vkern.svg
* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* Android.mk:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* page/DOMWindow.idl:
* rendering/SVGRootInlineBox.cpp:
(WebCore::applySVGKerning):
(WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
* svg/SVGAllInOne.cpp:
* svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::invalidateGlyphCache):
(WebCore::SVGFontElement::ensureGlyphCache):
(WebCore::matches):
(WebCore::kerningForPairOfStringsAndGlyphs):
(WebCore::SVGFontElement::horizontalKerningForPairOfStringsAndGlyphs):
(WebCore::SVGFontElement::verticalKerningForPairOfStringsAndGlyphs):
* svg/SVGFontElement.h:
(WebCore::SVGKerningPair::SVGKerningPair):
(WebCore::SVGFontElement::rendererIsNeeded):
* svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::buildHorizontalKerningPair):
* svg/SVGHKernElement.h:
* svg/SVGParserUtilities.cpp:
(WebCore::parseGlyphName):
(WebCore::parseKerningUnicodeString):
* svg/SVGParserUtilities.h:
* svg/SVGVKernElement.cpp: Added.
(WebCore::SVGVKernElement::SVGVKernElement):
(WebCore::SVGVKernElement::~SVGVKernElement):
(WebCore::SVGVKernElement::insertedIntoDocument):
(WebCore::SVGVKernElement::removedFromDocument):
(WebCore::SVGVKernElement::buildVerticalKerningPair):
* svg/SVGVKernElement.h: Added.
(WebCore::SVGVKernElement::rendererIsNeeded):
* svg/SVGVKernElement.idl: Added.
* svg/svgtags.in:
2010-05-08 Jer Noble <jer.noble@apple.com>
Unreviewed, just fixing windows build.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h: Add #if USE(ACCELERATED_COMPOSITING) guards around GraphicsLayer areas of the code. Include GraphicsLayer.h directly.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: As above.
* platform/graphics/win/QTMovieVisualContext.cpp: Remove the #include of d3d9types.h.
2010-05-08 Eric Seidel <eric@webkit.org>
Unreviewed, just reverting commit.
REGRESSION(59000): r59000 contained all sorts of changes it should not have, needs revert.
https://bugs.webkit.org/show_bug.cgi?id=38798
Test: fast/js/global-resolve-through-eval.html
* bindings/js/JSCallbackData.h:
(WebCore::JSCallbackData::JSCallbackData):
(WebCore::JSCallbackData::~JSCallbackData):
(WebCore::DeleteCallbackDataTask::create):
(WebCore::DeleteCallbackDataTask::performTask):
(WebCore::DeleteCallbackDataTask::isCleanupTask):
(WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):
* bindings/js/JSCustomVoidCallback.cpp:
(WebCore::JSCustomVoidCallback::JSCustomVoidCallback):
(WebCore::JSCustomVoidCallback::~JSCustomVoidCallback):
* bindings/js/JSCustomVoidCallback.h:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::):
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownFinishTask::performTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):
2010-05-07 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Dirk Schulze
Fixed the inverse function of f(x) = ((x + 0.055) / 1.055) ^ 2.4
https://bugs.webkit.org/show_bug.cgi?id=38735
It is ((x ^ (1 / 2.4)) * 1.055) - 0.055
Chromium pixel tests cover the issue.
* platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::transformColorSpace):
2010-05-04 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson
Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
<https://bugs.webkit.org/show_bug.cgi?id=34005>
<rdar://problem/7569713>
The original functionality of QTMovieWin has been split between QTMovieGWorld,
and a new class: QTMovie. QTMovie contains all the "controller" parts (changing
the rate, seeking, etc) while QTMovieGWorld retains all the drawing code. QTMovieGWorld
now takes a QTMovie, and as such QTMovie is now retainable. QTMovieGWorld registers
itself as a client of QTMovie, so that it can receive load-state notifications,
and thus QTMovie must now support multiple clients. Movie tasking timer support
has been moved into its own class (QTMovieTask) and will be addressed in a future
patch. Most of the functions listed below only changed so much as their class name changed.
* platform/graphics/win/QTMovie.cpp: Copied from WebCore/platform/graphics/win/QTMovieWin.cpp.
(QTMoviePrivate::QTMoviePrivate):
(QTMoviePrivate::~QTMoviePrivate):
(QTMoviePrivate::startTask):
(QTMoviePrivate::endTask):
(QTMoviePrivate::task):
(QTMoviePrivate::createMovieController):
(QTMovie::QTMovie):
(QTMovie::~QTMovie):
(QTMovie::addClient):
(QTMovie::removeClient):
(QTMovie::play):
(QTMovie::pause):
(QTMovie::rate):
(QTMovie::setRate):
(QTMovie::duration):
(QTMovie::currentTime):
(QTMovie::setCurrentTime):
(QTMovie::setVolume):
(QTMovie::setPreservesPitch):
(QTMovie::dataSize):
(QTMovie::maxTimeLoaded):
(QTMovie::loadState):
(QTMovie::getNaturalSize):
(QTMovie::load):
(QTMovie::disableUnsupportedTracks):
(QTMovie::isDisabled):
(QTMovie::setDisabled):
(QTMovie::hasVideo):
(QTMovie::hasAudio):
(QTMovie::hasClosedCaptions):
(QTMovie::setClosedCaptionsVisible):
(QTMovie::countSupportedTypes):
(QTMovie::getSupportedType):
(QTMovie::initializeQuickTime):
(QTMovie::getMovieHandle):
* platform/graphics/win/QTMovie.h: Copied from WebCore/platform/graphics/win/QTMovieWin.h.
* platform/graphics/win/QTMovieGWorld.cpp: Copied from WebCore/platform/graphics/win/QTMovieWin.cpp.
(QTMovieGWorldPrivate::QTMovieGWorldPrivate):
(QTMovieGWorldPrivate::~QTMovieGWorldPrivate):
(QTMovieGWorldPrivate::cacheMovieScale):
(movieDrawingCompleteProc):
(QTMovieGWorldPrivate::registerDrawingCallback):
(QTMovieGWorldPrivate::unregisterDrawingCallback):
(QTMovieGWorldPrivate::drawingComplete):
(QTMovieGWorldPrivate::updateGWorld):
(QTMovieGWorldPrivate::createGWorld):
(QTMovieGWorldPrivate::clearGWorld):
(QTMovieGWorldPrivate::setSize):
(QTMovieGWorldPrivate::updateMovieSize):
(QTMovieGWorldPrivate::deleteGWorld):
(QTMovieGWorldPrivate::movieEnded):
(QTMovieGWorldPrivate::movieLoadStateChanged):
(QTMovieGWorldPrivate::movieTimeChanged):
(QTMovieGWorld::QTMovieGWorld):
(QTMovieGWorld::~QTMovieGWorld):
(QTMovieGWorld::setSize):
(QTMovieGWorld::setVisible):
(QTMovieGWorld::getCurrentFrameInfo):
(QTMovieGWorld::paint):
(QTMovieGWorld::setDisabled):
(QTMovieGWorld::isDisabled):
(QTMovieGWorld::fullscreenWndProc):
(QTMovieGWorld::enterFullscreen):
(QTMovieGWorld::exitFullscreen):
(QTMovieGWorld::setMovie):
(QTMovieGWorld::movie):
* platform/graphics/win/QTMovieGWorld.h: Copied from WebCore/platform/graphics/win/QTMovieWin.h.
* platform/graphics/win/QTMovieTask.cpp: Added.
(QTMovieTask::QTMovieTask):
(QTMovieTask::~QTMovieTask):
(QTMovieTask::sharedTask):
(QTMovieTask::updateTaskTimer):
(QTMovieTask::fireTaskClients):
(QTMovieTask::addTaskClient):
(QTMovieTask::removeTaskClient):
(QTMovieTask::setTaskTimerFuncs):
* platform/graphics/win/QTMovieTask.h: Added.
2010-05-04 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson
Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
<https://bugs.webkit.org/show_bug.cgi?id=34005>
<rdar://problem/7569713>
MediaPlayerPrivateQuickTimeVisualContext has been added as a
supported MediaPlayer implementation. MediaPlayerPrivateQuickTimeWin
has been left as a fallback MediaPlayer implementation for those media
types which do not support visual contexts (currently, none).
* platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines):
2010-05-04 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak
Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
<https://bugs.webkit.org/show_bug.cgi?id=34005>
<rdar://problem/7569713>
MediaPlayerPrivateTaskTimer has been broken out from MediaPlayerPrivateQuickTimeWin::TaskTimer
so that multiple clients can share its implementation. It works with the new
QTMovieTaskTimer to provide timer support to QTMovieTaskTimer clients.
* platform/graphics/win/MediaPlayerPrivateTaskTimer.cpp: Added.
(WebCore::MediaPlayerPrivateTaskTimer::initialize):
(WebCore::MediaPlayerPrivateTaskTimer::setDelay):
(WebCore::MediaPlayerPrivateTaskTimer::stopTaskTimer):
(WebCore::MediaPlayerPrivateTaskTimer::fired):
* platform/graphics/win/MediaPlayerPrivateTaskTimer.h: Added.
2010-05-04 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson
Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
<https://bugs.webkit.org/show_bug.cgi?id=34005>
<rdar://problem/7569713>
MediaPlayerPrivateQuickTimeVisualContext is a new MediaPlayerPrivate implementation
which uses QTMovieVisualContext instead of QTMovieWin to render video frames. Much
like MediaPlayerPrivateQuickTimeWin, MPPQTVisualContext breaks out QTMovie and
QTMovieVisualContext, and uses the newly shared MediaPlayerPrivateTaskTimer. It also
uses aggregation (in the form of friend classes) instead of multiple inheritence
to implement its various client callbacks, so as not to expose its own clients to
the QTMovie classes.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: Copied from WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h: Copied from WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h.
2010-05-04 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak
Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
<https://bugs.webkit.org/show_bug.cgi?id=34005>
<rdar://problem/7569713>
MediaPlayerPrivateQuickTimeWin has been modified to support the new bifurcated
QTMovie/QTMovieWin classes. It's private TaskTimer class has been broken out
into a new top-level class (MediaPlayerPrivateTaskTimer) which will be addressed
in a future patch.
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::paused):
(WebCore::MediaPlayerPrivate::setSize):
(WebCore::MediaPlayerPrivate::setVisible):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::mimeTypeCache):
(WebCore::MediaPlayerPrivate::isAvailable):
(WebCore::MediaPlayerPrivate::movieEnded):
(WebCore::MediaPlayerPrivate::movieLoadStateChanged):
(WebCore::MediaPlayerPrivate::movieTimeChanged):
(WebCore::MediaPlayerPrivate::movieNewImageAvailable):
(WebCore::MediaPlayerPrivate::paintContents):
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
2010-05-04 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson
Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
<https://bugs.webkit.org/show_bug.cgi?id=34005>
<rdar://problem/7569713>
QTCFDictionary defines functions which help serialize and unserialize
CFDictionaries. This is necessary because QuickTime links against a
non-debug CoreFoundation in our debug build, and passing non-debug
CFDictionaries to a debug CF will cause a crash.
QTMovieTask is a new class containing the tasking functionality broken
out from QTMovieWin. This is necessary now that the tasking
functionality is needed in multiple files/classes.
QTPixelBuffer is a C++ wrapper for CVPixelBuffers, necessary because
like the CF case above, QuickTime has its own implementation of CoreVideo
and its CV types cannot be used with the AAS version of CoreVideo.
QTMovieVisualContext is the new drawing implementation, parallel to
QTMovieWin. It currently uses a software rendering path, but can be
extended in the future to support hardware rendering.
* platform/graphics/win/QTCFDictionary.cpp: Added.
* platform/graphics/win/QTCFDictionary.h: Added.
* platform/graphics/win/QTMovieTask.cpp: Added.
* platform/graphics/win/QTMovieTask.h: Added.
* platform/graphics/win/QTMovieVisualContext.cpp: Added.
* platform/graphics/win/QTMovieVisualContext.h: Added.
* platform/graphics/win/QTPixelBuffer.cpp: Added.
* platform/graphics/win/QTPixelBuffer.h: Added.
2010-05-07 Eric Uhrhane <ericu@chromium.org>
Reviewed by Dmitry Titov.
JSCallbackData is deleted on the Main thread, not the Context thread.
https://bugs.webkit.org/show_bug.cgi?id=38623
No new tests; you'll only see a problem after the worker-access-to-DB
code goes in. Without this fix, the GTK bots assert, but it's
timing-sensitive and not truly platform-specific.
* bindings/js/JSCallbackData.h:
(WebCore::JSCallbackData::JSCallbackData):
(WebCore::JSCallbackData::~JSCallbackData):
Store the allocating thread, then assert that we're on it at deletion.
(WebCore::DeleteCallbackDataTask):
This is the task that can get posted to the context thread for cleanup.
* bindings/js/JSCustomVoidCallback.cpp:
* bindings/js/JSCustomVoidCallback.h:
This callback isn't autogenerated, so we have to do the cleanup manually.
* bindings/scripts/CodeGeneratorJS.pm:
Add the proper cleanup to all autogenerated callbacks.
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownFinishTask::performTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):
WorkerContext::clearScript can't be called until the posted deletion tasks have completed; move the call from shutdown start to shutdown finish.
2010-05-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix JSC binding generation to match webkit style
https://bugs.webkit.org/show_bug.cgi?id=38173
Add spaces around "|" to match webkit style.
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/test/JS/JSTestObj.cpp:
2010-05-07 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Brady Eidson.
Adding the IDL files for the sync DB API and the stubs for the JS and V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=34994
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDatabaseSyncCustom.cpp: Added.
(WebCore::JSDatabaseSync::changeVersion):
(WebCore::createTransaction):
(WebCore::JSDatabaseSync::transaction):
(WebCore::JSDatabaseSync::readTransaction):
* bindings/js/JSSQLTransactionSyncCustom.cpp: Added.
(WebCore::JSSQLTransactionSync::executeSql):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::openDatabaseSync):
* bindings/v8/custom/V8BindingMacros.h: Added.
* bindings/v8/custom/V8DatabaseSyncCustom.cpp: Added.
(WebCore::V8DatabaseSync::changeVersionCallback):
(WebCore::createTransaction):
(WebCore::V8DatabaseSync::transactionCallback):
(WebCore::V8DatabaseSync::readTransactionCallback):
* bindings/v8/custom/V8SQLTransactionSyncCustom.cpp: Added.
(WebCore::V8SQLTransactionSync::executeSqlCallback):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContext::openDatabaseSyncCallback):
* storage/Database.idl:
* storage/DatabaseCallback.h:
* storage/DatabaseCallback.idl:
* storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::transaction):
* storage/DatabaseSync.h:
* storage/DatabaseSync.idl: Added.
* storage/SQLError.idl:
* storage/SQLResultSet.idl:
* storage/SQLResultSetRowList.idl:
* storage/SQLTransaction.idl:
* storage/SQLTransactionSync.idl: Added.
* storage/SQLTransactionSyncCallback.h:
* storage/SQLTransactionSyncCallback.idl: Added.
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::openDatabaseSync):
* workers/WorkerContext.h:
* workers/WorkerContext.idl:
2010-05-07 Beth Dakin <bdakin@apple.com>
Reviewed by Simon Fraser.
Fix for <rdar://problem/7956972> REGRESSION: Can't focus and type
in GMail due to bad repainting
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=38782
This patch reverts back to pre-r58797 behavior when
shouldPropagateCompositingToIFrameParent() is false.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintingGoesToWindow):
2010-05-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r58963.
http://trac.webkit.org/changeset/58963
https://bugs.webkit.org/show_bug.cgi?id=38773
Broke Chromium layout tests. (Requested by dcheng on #webkit).
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
2010-05-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
https://bugs.webkit.org/show_bug.cgi?id=38769
ClipboardGtk should write the URL label in the text portion of the DataObject
No tests as this code path is currently unused in the GTK+ port.
* platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::writeURL): Write the label to the text portion of the DataObject, instead of the URL.
2010-05-07 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
RenderSVGResourceClipper assigns a temporary mutated RenderStyle but does not correctly preserve the old style
https://bugs.webkit.org/show_bug.cgi?id=38767
Fix small logic error leading to a problem in RenderSVGResourceClipper. It assigns a new temporary RenderStyle
to the target object, but fails to reset it correctly to the old style. Fixes all svg/clip-path errors on the windows bots.
* rendering/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::createClipData):
2010-05-07 Daniel Cheng <dcheng@chromium.org>
Reviewed by Jian Li.
[chromium] DragDataChromium::asURL() shouldn't do file validity checks
https://bugs.webkit.org/show_bug.cgi?id=38711
The renderer is sandboxed in Chromium, so these calls will give us no
meaningful information. The loader will do the right thing if we pass
it a file URL that points to an invalid file.
No new tests.
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
2010-05-07 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Fix debug-only render tree output to show object addresses in hex.
* rendering/RenderTreeAsText.cpp:
(WebCore::writeRenderObject):
(WebCore::write):
2010-05-07 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=38546
Node.focus() fails to move focus from subframe properly
Test: fast/frames/take-focus-from-iframe.html
* html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setFocus): Don't clear
focus if this frame doesn't have it. This can happen if page's and HTMLFrameElement's ideas
of focused frame get out of sync temporarily.
2010-05-07 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
svg/custom/use-instanceRoot-as-event-target.xhtml crashes randomly
https://bugs.webkit.org/show_bug.cgi?id=37798
When creating JSEventListeners through attributes (onclick, etc..) or add/removeEventListener
calls on a SVGElementInstance, do NOT pass the element instance itself as JS wrapper object
but the correspondingElement(). SVGElementInstance redirects all event listener registrations
to the correspondingElement(), as they share an event listener list, per SVG spec. The old
code was very dangerous, leading to random assertions, when garbage collection teared down
the JSSVGElementInstance and event listeners fired, whose listeners were registered with
it, but residing in the correspondingElement() event listener list.
Removes the need for CustomToJS code for JSSVGElementInstance, which was wrong anyways. We hoped
to keep the event listeers alive by just creating a js wrapper of the correspondingElement(), that
could only work as long as garbage collection didn't tear it down, just luck. Also remove the
CustomPushEventHandlerScope marker, as it is only used for JSLazyEventListeners and only works
for JSNode derived objects, it was a no-op for SVGElementInstance, thus removed it.
Should fix all random crashes/assertions seen with svg/custom/use-instanceRoot-as-event-target.xhtml
See bug report for a detailed crash analysis.
* bindings/js/JSSVGElementInstanceCustom.cpp: Remove custom toJS()/pushEventHandlerScope() handling, not necessary anymore.
(WebCore::JSSVGElementInstance::markChildren):
* bindings/scripts/CodeGeneratorJS.pm: For JSSVGElementInstance pass the correspondingElement() as JS wrapper object, not itself.
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::invalidateAllInstancesOfElement): Be sure to trigger a style update here, so dirty shadow trees for <use> get rebuild. Otherwhise DOM may be out-of-sync.
(WebCore::SVGElementInstance::eventTargetData): Add ASSERT_NOT_REACHED(), all event listener calls are forwarded to the correspondingElement().
(WebCore::SVGElementInstance::ensureEventTargetData): Ditto.
* svg/SVGElementInstance.idl: Remove CustomToJS, CustomPushEventHandlerScope markers.
2010-05-06 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
WebCore::WebGLUnsignedIntArrayInternal::getCallback ReadAV@Arbitrary (deef89ee3d0345edebeaf13cf974c47c)
https://bugs.webkit.org/show_bug.cgi?id=38039
Web IDL now allows indexed getters and setters to be unnamed. Per
discussion in WebGL working group and recent update to spec,
removed the buggy get() and single-element set() methods from the
JavaScript bindings to the WebGL array types. Refactored set()
implementation in JSC bindings to share more code and modified V8
binding to look more like it. Added unit tests for indexed getter
with out-of-range indices and verifying removal of get and
single-element set methods. Updated existing WebGL array tests.
Tests: fast/canvas/webgl/array-get-and-set-method-removal.html
fast/canvas/webgl/array-get-out-of-bounds.html
* bindings/js/JSWebGLArrayHelper.h:
(WebCore::setWebGLArrayHelper):
* bindings/js/JSWebGLByteArrayCustom.cpp:
(WebCore::JSWebGLByteArray::set):
* bindings/js/JSWebGLFloatArrayCustom.cpp:
(WebCore::JSWebGLFloatArray::set):
* bindings/js/JSWebGLIntArrayCustom.cpp:
(WebCore::JSWebGLIntArray::set):
* bindings/js/JSWebGLShortArrayCustom.cpp:
(WebCore::JSWebGLShortArray::set):
* bindings/js/JSWebGLUnsignedByteArrayCustom.cpp:
(WebCore::JSWebGLUnsignedByteArray::set):
* bindings/js/JSWebGLUnsignedIntArrayCustom.cpp:
(WebCore::JSWebGLUnsignedIntArray::set):
* bindings/js/JSWebGLUnsignedShortArrayCustom.cpp:
(WebCore::JSWebGLUnsignedShortArray::set):
* bindings/v8/custom/V8WebGLArrayCustom.h:
(WebCore::setWebGLArrayHelper):
* bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
(WebCore::V8WebGLByteArray::setCallback):
* bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
(WebCore::V8WebGLFloatArray::setCallback):
* bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
(WebCore::V8WebGLIntArray::setCallback):
* bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
(WebCore::V8WebGLShortArray::setCallback):
* bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
(WebCore::V8WebGLUnsignedByteArray::setCallback):
* bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
(WebCore::V8WebGLUnsignedIntArray::setCallback):
* bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
(WebCore::V8WebGLUnsignedShortArray::setCallback):
* html/canvas/WebGLByteArray.h:
* html/canvas/WebGLByteArray.idl:
* html/canvas/WebGLFloatArray.h:
* html/canvas/WebGLFloatArray.idl:
* html/canvas/WebGLIntArray.h:
* html/canvas/WebGLIntArray.idl:
* html/canvas/WebGLShortArray.h:
* html/canvas/WebGLShortArray.idl:
* html/canvas/WebGLUnsignedByteArray.h:
* html/canvas/WebGLUnsignedByteArray.idl:
* html/canvas/WebGLUnsignedIntArray.h:
* html/canvas/WebGLUnsignedIntArray.idl:
* html/canvas/WebGLUnsignedShortArray.h:
* html/canvas/WebGLUnsignedShortArray.idl:
2010-05-07 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium dev tools tests fix.
Add a more strict check prior to accessing constructor property in
Web Inspector frontend.
* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor):
2010-05-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: On Linux/Windows panel history is
traversed while iterating over words in text prompt.
https://bugs.webkit.org/show_bug.cgi?id=38740
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt):
* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
2010-05-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: come up with InjectedScript._className that works for both JSC and V8.
https://bugs.webkit.org/show_bug.cgi?id=38755
* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor):
2010-05-07 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Adam Barth.
document.write is not synchronous after page load
https://bugs.webkit.org/show_bug.cgi?id=38146
If there are no pending scripts, a document.write call should be
synchronous. This matches other browsers and the HTML5 spec. Forcing
the tokenizer to be synchronous in Document::write does not affect
external scripts written by the write call. This should only change
behavior of document.write after the page is done loading.
Difficult to test reliably due to HTMLTokenizing relying on processing time.
I made a manual test because the test requires processing very large strings
synchronously and therefore can take some time.
Test: WebCore/manual-tests/dom/document-write-synchronous-after-page-load.html
* dom/Document.cpp:
(WebCore::SynchronousHTMLTokenizerGuard::SynchronousHTMLTokenizerGuard): if the provided tokenizer is an HTMLTokenizer make it synchronous
(WebCore::SynchronousHTMLTokenizerGuard::~SynchronousHTMLTokenizerGuard): if the provided tokenizer was an HTMLTokenizer return its synchronous state
(WebCore::Document::write): temporarily set the tokenizer to synchronous during document.write
* dom/Tokenizer.h:
(WebCore::Tokenizer::asHTMLTokenizer): default implementation returns 0, to be overridden by HTMLTokenizer
* html/HTMLTokenizer.h: allow access to to the force synchronous state
(WebCore::HTMLTokenizer::forceSynchronous): accessor
(WebCore::HTMLTokenizer::asHTMLTokenizer): override the default to return itself
* manual-tests/dom/document-write-synchronous-after-page-load.html: Added.
2010-05-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix rendering of -webkit-user-select: none
-webkit-user-select: none is implemented by filling
the area with an invalid default-constructed Color.
In most ports passing an invalid color down to the
graphics backend seems to produce transparent fills.
In Qt the behavior of painting with an invalid QColor
is undefined, and in practice it results in painting
black opaque areas.
One way to fix this would be to use Qt::transparent
when converting an undefined Color to a QColor, but
Qt does not have short circuits for fully transparent
painting, and we actually end up in slow code paths
due to the transparency. So, we're better of doing the
short circuit in WebKit.
https://bugs.webkit.org/show_bug.cgi?id=38523
* platform/graphics/qt/GraphicsContextQt.cpp:
2010-05-07 Ben Murdoch <benm@google.com>
Reviewed by Darin Adler.
Potential crash in EventHandler::handleTouchEvent
https://bugs.webkit.org/show_bug.cgi?id=38646
Fix a ref counting bug that can cause a crash if the m_originatingouchPointTargets
hashmap holds the last ref to an EventTarget when the user lifts their finger.
This is very hard to reproduce in a consistent way and clearly a
simple logic error in the code, therefore no new tests.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): Don't let the RefPtr we get back from
the hasmap go out of scope so soon as it could delete the wrapped ptr if the
hashmap held the last ref (and we use the raw ptr that the RefPtr
wraps later in the WebCore::Touch constructor).
2010-05-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Kenneth Rohde Christiansen.
[GTK] Fails to build on GTK+ < 2.14
https://bugs.webkit.org/show_bug.cgi?id=38746
Build fix only. Do basically the same as gtk_adjustment_configure
would do if we are bellow GTK+ 2.14.
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::AdjustmentConfigure):
2010-05-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Crash with MgOpenModerna font, with non-UTF-8 character
https://bugs.webkit.org/show_bug.cgi?id=37795
NULL-check the font platform data, for now, to avoid the crash.
Could not yet figure out a way to get a test written that does not
involve adding the font to the tree, but there are doubts about
licensing.
* platform/graphics/cairo/FontCacheCairo.cpp:
(WebCore::FontCache::getFontDataForCharacters):
2010-05-07 MORITA Hajime <morrita@google.com>
Reviewed by Eric Seidel.
[Chromium] RenderThemeChromiumMac.mm should share the code with RenderThemeMac.mm
https://bugs.webkit.org/show_bug.cgi?id=37204
Made RenderThemeChromiumMac subclass of RenderThemeMac, instead of RenderTheme.
Added some method to RenderThemeMac for overriding on RenderThemeChromiumMac.
No new tests; Should have no behavioural change.
* WebCore.gyp/WebCore.gyp:
* rendering/RenderThemeChromiumMac.h:
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
(WebCore::RenderThemeChromiumMac::documentViewFor):
(WebCore::RenderThemeChromiumMac::adjustMediaSliderThumbSize):
(WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb):
* rendering/RenderThemeMac.h:
(WebCore::RenderThemeMac::updateActiveState): Added for overriding
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::usesTestModeFocusRingColor): Added for overriding
(WebCore::RenderThemeMac::documentViewFor): Added for overriding
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::paintSliderThumb):
(WebCore::RenderThemeMac::paintSearchField):
(WebCore::RenderThemeMac::setSearchCellState):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
(WebCore::RenderThemeMac::adjustSliderThumbSize):
(WebCore::RenderThemeMac::adjustMediaSliderThumbSize): Added for overriding
(WebCore::RenderThemeMac::extraMediaControlsStyleSheet):
2010-05-06 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
JavaScriptCore/wtf/RandomNumber.h should provide using WTF::*
https://bugs.webkit.org/show_bug.cgi?id=38719
* platform/graphics/wince/FontCustomPlatformData.cpp:
(WebCore::createUniqueFontName):
Remove WTF:: prefix from randomNumber()
* platform/network/FormDataBuilder.cpp:
(WebCore::FormDataBuilder::generateUniqueBoundaryString):
Ditto.
2010-04-27 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
[chromium] clicking a scrollbar in an iframe shouldn't lose the selection
https://bugs.webkit.org/show_bug.cgi?id=38189
Test: fast/events/mousedown-in-subframe-scrollbar.html
* page/chromium/EventHandlerChromium.cpp:
(WebCore::EventHandler::passMousePressEventToSubframe): If clicking on
a scrollbar, pass the event directly to the scrollbar. This matches
mac which passes the event to the NSScroller.
2010-05-06 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Compositing layers that are clipped out by an overflow:scroll parent fail to get created on reveal
https://bugs.webkit.org/show_bug.cgi?id=38712
When compositing layer creation is testing layer overlap, we need to re-run the
algorithm when an overflow:scroll element scrolls, to create new layers for revealed
elements.
Test: compositing/layer-creation/overflow-scroll-overlap.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset): First, move the compositing updates
until after the call to updateWidgetPositions(), so that this order is similar
to what we done when a FrameView scrolls. This change has no known side effects.
Second, if compositingConsultsOverlap() is true, we need to actually do a
compositing layer update to compute whether revealed/hidden layers should
be created/destroyed.
2010-05-06 Maciej Stachowiak <mjs@apple.com>
Not reviewed, build fix.
Try again - with quotes this time. *facepalm*
* dom/Notation.cpp:
2010-05-06 Maciej Stachowiak <mjs@apple.com>
Not reviewed, build fix.
Speculative fix for Qt and Gtk.
* dom/Notation.cpp:
2010-05-06 Maciej Stachowiak <mjs@apple.com>
Not reviewed, build fix.
Fix an assert that I failed to update in my earlier change.
* dom/CharacterData.h:
(WebCore::CharacterData::CharacterData):
2010-05-06 Alexey Proskuryakov <ap@apple.com>
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=38697
REGRESSION (r58299): Replying on reddit.com no longer works
* css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Don't recognize :first,
:left and :right. The aren't allowed in all contexts, and properly implementing them is out
of scope for this regression fix.
2010-05-06 Jian Li <jianli@chromium.org>
Reviewed by Adam Barth.
Improve code generator scripts to support converting ScriptString.
https://bugs.webkit.org/show_bug.cgi?id=38699
Change both JSC and V8 generators to introduce "ConvertScriptString"
attribute to allow converting from ScriptString. Also updated the
bindings test result.
These changes are necessary in order to avoid adding custom binding codes
when we add the FileReader interface.
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_get_script_string_attr):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::):
(WebCore::jsTestObjScriptStringAttr):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj scriptStringAttr]):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::scriptStringAttrAttrGetter):
(WebCore::):
2010-05-06 Jian Li <jianli@chromium.org>
Reviewed by Adam Barth.
Improve code generator scripts to pass additional ScriptExecutionContext
argument to the constructor.
https://bugs.webkit.org/show_bug.cgi?id=38687
Change both JSC and V8 generators to introduce "CallWith=ScriptExecutionContext"
attribute to allow passing the additional ScriptExecutionContext argument to
the constructor. Also add another test IDL file to test interface-level
features.
These changes are necessary in order to avoid adding custom binding codes
when we add the FileReader interface.
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Added.
* bindings/scripts/test/GObject/WebKitDOMTestInterface.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h: Added.
* bindings/scripts/test/JS/JSTestInterface.cpp: Added.
* bindings/scripts/test/JS/JSTestInterface.h: Added.
* bindings/scripts/test/ObjC/DOMTestInterface.h: Added.
* bindings/scripts/test/ObjC/DOMTestInterface.mm: Added.
* bindings/scripts/test/ObjC/DOMTestInterfaceInternal.h: Added.
* bindings/scripts/test/TestInterface.idl: Added.
* bindings/scripts/test/V8/V8TestInterface.cpp: Added.
* bindings/scripts/test/V8/V8TestInterface.h: Added.
* bindings/v8/V8Proxy.h:
(WebCore::V8Proxy::constructDOMObjectWithScriptExecutionContext):
2010-05-06 Maciej Stachowiak <mjs@apple.com>
Build fix, not reviewed.
Speculative Windows and Debug build fixes for the last change.
* dom/Node.h:
(WebCore::Node::inDocument):
(WebCore::Node::setFlag):
2010-05-06 James Robinson <jamesr@chromium.org>
Reviewed by Eric Seidel.
Fix warnings emitted by gcc 4.4.1 on linux in chromium-specific platform graphics files.
https://bugs.webkit.org/show_bug.cgi?id=38158
Fixes:
- replace NULL with 0
- remove unusued locals
- add parens around ambiguous looking compound predicates like (a || b && c)
This also adds a check for x >= 0 to FontLinux.cpp's in this statement:
if (x < walker.width())
This is more documentation than anything else since walker.width() returns
an unsigned the current behavior is that x is promoted to unsigned and as
long as x + walker.width() is less than 2^31 all negative values of x
end up wrapping around and not being < walker.width(). This behavior is
tested by fast/text/international/khmer-selection.html
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::adjustTextRenderMode):
(WebCore::TextRunWalker::TextRunWalker):
(WebCore::TextRunWalker::length):
(WebCore::TextRunWalker::width):
(WebCore::TextRunWalker::getTextRun):
(WebCore::TextRunWalker::getNormalizedTextRun):
(WebCore::Font::offsetForPositionForComplexText):
* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::setupPaint):
* platform/graphics/chromium/HarfbuzzSkia.cpp:
(WebCore::getOutlinePoint):
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::getImageData):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::isCoordinateSkiaSafe):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):
2010-05-06 Ada Chan <adachan@apple.com>
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=38695
Check the result from widget() for NULL before accessing it.
* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::calcHeight):
(WebCore::RenderIFrame::calcWidth):
2010-05-06 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
further fixes towards REGRESSION (r57292): 1% PLT regression from visited link information leak fix
https://bugs.webkit.org/show_bug.cgi?id=38682
<rdar://problem/7859794>
Looks like a 1-2% speedup on PLT.
- Reorder CSS properties.
- Remove short circuit tag check in matchRulesForList which costs more than it saves.
- Inline initForStyleResolve.
- Optimize applyDeclarations to avoid switch and take fewer branches in the inner loop.
- Change the way Node handles flags - replace bitfield with a uint32_t and explicit masking,
to make it cheaper to initialize the bits and give faster access.
- Added new Node flags to check for isStyledElement, isHTMLElement, isSVGElement, isComment,
and devirtualize those methods.
- Inline constructors for Node, Element, Text, CharacterData, StyledElement, etc since
they are very simple and lots of nodes get constructed.
* css/CSSPropertyNames.in: Move a few of the properties up front so we can check for them
with < instead of switch statements
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchRulesForList): Remove unnecessary preflight check
for tag match before checking selector. This check very rarely short circuits anything,
since most rules with a tag end up in the appropriate tag bucket. So doing the check
cost more time than the time saved.
(WebCore::CSSStyleSelector::initForStyleResolve): Inline. Create RenderStyle in a better way.
(WebCore::CSSStyleSelector::applyDeclarations): Get rid of switch statement and use <= to
check for the high priority properties. Convert to template to avoid checking "applyFirst"
each time through the loop.
(WebCore::CSSStyleSelector::styleForElement): Adjust for new applyDeclarations() signature.
(WebCore::CSSStyleSelector::keyframeStylesForAnimation): ditto
(WebCore::CSSStyleSelector::pseudoStyleForElement): ditto
* css/CSSStyleSelector.h: Adjust for new applyDeclarations() signature.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle): Inline constructor.
* rendering/style/RenderStyle.h: Make constructor private so it can be inline.
* dom/Node.h:
(WebCore::): See high-level description of changes above. Redid the
way boolean flags work.
(WebCore::Node::isElementNode):
(WebCore::Node::isContainerNode):
(WebCore::Node::isTextNode):
(WebCore::Node::isHTMLElement):
(WebCore::Node::isSVGElement):
(WebCore::Node::isStyledElement):
(WebCore::Node::isCommentNode):
(WebCore::Node::hasID):
(WebCore::Node::hasClass):
(WebCore::Node::active):
(WebCore::Node::inActiveChain):
(WebCore::Node::inDetach):
(WebCore::Node::hovered):
(WebCore::Node::attached):
(WebCore::Node::setAttached):
(WebCore::Node::needsStyleRecalc):
(WebCore::Node::styleChangeType):
(WebCore::Node::childNeedsStyleRecalc):
(WebCore::Node::isLink):
(WebCore::Node::setHasID):
(WebCore::Node::setHasClass):
(WebCore::Node::setChildNeedsStyleRecalc):
(WebCore::Node::clearChildNeedsStyleRecalc):
(WebCore::Node::setInDocument):
(WebCore::Node::clearInDocument):
(WebCore::Node::setInActiveChain):
(WebCore::Node::clearInActiveChain):
(WebCore::Node::setIsLink):
(WebCore::Node::clearIsLink):
(WebCore::Node::setActive):
(WebCore::Node::setHovered):
(WebCore::Node::inDocument):
(WebCore::Node::):
(WebCore::Node::getFlag):
(WebCore::Node::setFlag):
(WebCore::Node::clearFlag):
(WebCore::Node::hasRareData):
(WebCore::Node::isParsingChildrenFinished):
(WebCore::Node::setIsParsingChildrenFinished):
(WebCore::Node::clearIsParsingChildrenFinished):
(WebCore::Node::isStyleAttributeValid):
(WebCore::Node::setIsStyleAttributeValid):
(WebCore::Node::clearIsStyleAttributeValid):
(WebCore::Node::isSynchronizingStyleAttribute):
(WebCore::Node::setIsSynchronizingStyleAttribute):
(WebCore::Node::clearIsSynchronizingStyleAttribute):
(WebCore::Node::areSVGAttributesValid):
(WebCore::Node::setAreSVGAttributesValid):
(WebCore::Node::clearAreSVGAttributesValid):
(WebCore::Node::isSynchronizingSVGAttributes):
(WebCore::Node::setIsSynchronizingSVGAttributes):
(WebCore::Node::clearIsSynchronizingSVGAttributes):
(WebCore::Node::hasRareSVGData):
(WebCore::Node::setHasRareSVGData):
(WebCore::Node::clearHasRareSVGData):
(WebCore::Node::initialRefCount):
* dom/Node.cpp:
(WebCore::Node::trackForDebugging): Adjusted for changes in
flag handling.
(WebCore::Node::ensureRareData): ditto
(WebCore::Node::setStyleChange): ditto
(WebCore::Node::setNeedsStyleRecalc): ditto
(WebCore::Node::lazyAttach): ditto
(WebCore::Node::attach): ditto
(WebCore::Node::detach): ditto
(WebCore::Node::insertedIntoDocument): ditto
(WebCore::Node::removedFromDocument): ditto
* dom/CharacterData.cpp:
* dom/CharacterData.h:
(WebCore::CharacterData::CharacterData): Inline the constructor (moved from .cpp)
* dom/Comment.cpp:
(WebCore::Comment::Comment): Tell the base class that we're a comment.
* dom/Comment.h: Remove isCommentNode override.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::detach): Adjusted for changes in flag
handling.
(WebCore::ContainerNode::removedFromDocument): ditto
* dom/Document.cpp:
(WebCore::Document::Document): Adjusted for changes in flag handling.
(WebCore::Document::recalcStyle): ditto
(WebCore::Document::setFocusedNode): ditto
* dom/Document.h:
(WebCore::Node::Node): Inline the Node constructor - goes here
because it uses Document.
* dom/DocumentFragment.cpp: include Document.h due to above change
* dom/EditingText.cpp: ditto
* dom/EntityReference.cpp: ditto
* dom/Element.cpp:
(WebCore::Element::getAttribute): Adjusted for changes in flag
handling.
(WebCore::Element::setAttribute): ditto
(WebCore::Element::hasAttributes): ditto
(WebCore::Element::recalcStyle): ditto
(WebCore::Element::finishParsingChildren): ditto
* dom/Element.h:
(WebCore::Element::Element): Inline (moved from .cpp)
(WebCore::Element::isFinishedParsingChildren):
(WebCore::Element::beginParsingChildren):
(WebCore::Element::attributes): Adjusted for changes in flag
handling.
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute): Adjust for
changes to flag handling.
(WebCore::StyledElement::mapToEntry): ditto
(WebCore::StyledElement::parseMappedAttribute): ditto
(WebCore::StyledElement::copyNonAttributeProperties): ditto
* dom/StyledElement.h:
(WebCore::StyledElement::StyledElement): Inline (moved from.cpp)
(WebCore::StyledElement::invalidateStyleAttribute): Adjust for
changes in flag handling.
* dom/Text.h:
(WebCore::Text::Text): Inline (moved from .cpp)
* dom/Text.cpp:
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::HTMLAnchorElement): Adjust for changes in
flag handling.
(WebCore::HTMLAnchorElement::parseMappedAttribute): ditto
* html/HTMLElement.cpp:
(WebCore::HTMLElement::create): Tell base class we're an HTML element.
* html/HTMLElement.h: ditto above; remove isHTMLElement override.
* html/HTMLFormControlElement.h: Tell base class we're an HTML element.
* html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): ditto
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::HTMLProgressElement): ditto
* mathml/MathMLElement.cpp:
(WebCore::MathMLElement::MathMLElement): Tell base class we're a styled
element.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
Adjust for changes in flag handling.
(WebCore::MediaControlElement::MediaControlElement): ditto
(WebCore::MediaControlInputElement::MediaControlInputElement): ditto
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::updateFromElement): ditto
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateHoverActiveState): ditto
* rendering/RenderProgress.cpp:
(WebCore::RenderProgress::updateValuePartState): ditto
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::updateFromElement): ditto
* rendering/SVGShadowTreeElements.cpp:
(WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): ditto
* rendering/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::attachInnerElement): ditto
* svg/SVGAnimatedProperty.h:
(WebCore::SVGAnimatedPropertyTearOff::setBaseVal): ditto
(WebCore::SVGAnimatedPropertyTearOff::setAnimVal): ditto
* svg/SVGElement.cpp:
(WebCore::SVGElement::SVGElement): Tell base class we're
an svg element.
(WebCore::SVGElement::ensureRareSVGData): Adjust for flag handling
changes.
(WebCore::SVGElement::updateAnimatedSVGAttribute): ditto
* svg/SVGElement.h:
(WebCore::SVGElement::invalidateSVGAttributes): ditto
* svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::svgAttributeChanged): ditto
* wml/WMLAnchorElement.cpp:
(WebCore::WMLAnchorElement::WMLAnchorElement): ditto
* wml/WMLElement.cpp:
(WebCore::WMLElement::WMLElement): Tell base class we're a styled
element.
2010-05-06 Adam Barth <abarth@webkit.org>
Unreviewed. Fix indent. Sorry, my OCD was acting up.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):
2010-05-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: store selected Headers / Content tab on explicit switch and/or explicit navigate only.
https://bugs.webkit.org/show_bug.cgi?id=38660
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceView):
(WebInspector.ResourceView.prototype._selectHeadersTab):
(WebInspector.ResourceView.prototype.selectContentTab):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.showResource):
2010-05-06 Luiz Agostini <luiz.agostini@openbossa.org>
Rubber-stamped by Simon Hausmann.
[Qt] use QT_MOBILE_THEME in Symbian
https://bugs.webkit.org/show_bug.cgi?id=38440
Putting QT_MOBILE_THEME into use for Symbian.
* WebCore.pro:
2010-05-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed, build fix WinCE for QtWebKit.
[Qt] Compilation with Plugins disabled is broken
https://bugs.webkit.org/show_bug.cgi?id=31407
Rename platform/qt/TemporaryLinkStubs.cpp to avoid name collition on
Windows.
Thanks for Ismail "cartman" Donmez for help.
No new tests, as there is no new functionality.
* WebCore.gypi:
* WebCore.pro:
* platform/qt/TemporaryLinkStubs.cpp: Removed.
* platform/qt/TemporaryLinkStubsQt.cpp: Copied from WebCore/platform/qt/TemporaryLinkStubs.cpp.
2010-05-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] REGRESSION: Loading of external CSS and JS files over network fails in some cases
https://bugs.webkit.org/show_bug.cgi?id=36755
Enable the direct connection between QtNetwork and QtWebKit only for Qt versions
greater than 4.6.2, due to a bug in Qt that's been fixed after 4.6.2.
* platform/network/qt/QNetworkReplyHandler.cpp:
2010-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Rework where we get page step and line step from, so we do not
depend on scrollbars existing. Caught by API test I forgot to run.
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::setGtkAdjustments):
2010-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Adjustment resetting uses wrong values, and misses page_size and steps
https://bugs.webkit.org/show_bug.cgi?id=38657
Fix resetting adjustment values. In the page cache case, we were
confusing page_size and upper, leading to stray scrollbars
sometimes.
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::setGtkAdjustments):
2010-05-06 Darin Adler <darin@apple.com>
Reviewed by Beth Dakin.
Page::setCanStartMedia does not properly handle the case where a media listener is removed
https://bugs.webkit.org/show_bug.cgi?id=38602
We can't find any real case where this causes a crash at this time, but
we want to harden the code anyway. Thus there are no new regression tests.
* page/Page.cpp:
(WebCore::Page::removeMediaCanStartListener): Removed incorrect assertion.
(WebCore::Page::setCanStartMedia): Change algorithm so we notify listeners
one at a time and don't notify any listener that has already been removed
from the set.
2010-05-05 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
shift+click on an existing selection doesn't work right
https://bugs.webkit.org/show_bug.cgi?id=36542
NSTextView behavior is to move the end of the selection
closest to the shift-click. Win/Linux behavior is to always
move the focus end of the selection.
Test: editing/selection/shift-click.html
* page/EventHandler.cpp:
(WebCore::textDistance):
(WebCore::EventHandler::handleMousePressEventSingleClick):
2010-05-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: implement panels history traversal on Cmd+Left/Right.
https://bugs.webkit.org/show_bug.cgi?id=38649
* inspector/front-end/inspector.js:
(WebInspector.set currentPanel):
(WebInspector.loaded):
(WebInspector.documentKeyDown):
(WebInspector.PanelHistory):
(WebInspector.PanelHistory.prototype.canGoBack):
(WebInspector.PanelHistory.prototype.goBack):
(WebInspector.PanelHistory.prototype.canGoForward):
(WebInspector.PanelHistory.prototype.goForward):
(WebInspector.PanelHistory.prototype.setPanel):
2010-05-03 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
[chromium] use glyphDataForCharacter so we hit the glyphdata cache
https://bugs.webkit.org/show_bug.cgi?id=38500
Calling fontDataForCharacters() while rendering text is expensive.
Examining the relevant Mac code in WebKit revealed that calling the
similarly-named glyphDataForCharacters() results in caching the font
data on a per-glyph basis.
Since we now choose a font based on the first character in a run, we
need to be careful that all the glyphs within the run use the same font.
This is also similar to the WebKit Mac code. We need to remove all of
the script run bits eventually and this is a step in that direction.
Tests: fast/text/international/danda-space.html spacing changes slightly
(now matches Firefox better) and fast/text/international/thai-baht-space.html
now picks the correct (serif) font for the digits.
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::TextRunWalker::nextScriptRun):
(WebCore::TextRunWalker::setupFontForScriptRun):
2010-05-06 Martin Robinson <mrobinson@webkit.org>
Reviewed by Gustavo Noronha Silva.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Convert dragging portion of drag-and-drop to use DataObjectGtk.
No new tests, because functionality has not changed.
* page/gtk/EventHandlerGtk.cpp:
(WebCore::EventHandler::createDraggingClipboard): Pass the DataObjectGtk as a parameter here.
* platform/gtk/ClipboardGtk.h:
(WebCore::ClipboardGtk::create): Take the DataObject as a parameter instead of creating it here.
(WebCore::ClipboardGtk::helper): Added.
(WebCore::ClipboardGtk::dataObject): Added.
* platform/gtk/PasteboardHelper.h: Make targetListForDataObject a public method.
2010-05-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Do not show content tab for resources
not supporting content preview.
https://bugs.webkit.org/show_bug.cgi?id=38635
* English.lproj/localizedStrings.js:
* inspector/front-end/FontView.js:
(WebInspector.FontView.prototype.hasContentTab):
* inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype.hasContentTab):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceView):
(WebInspector.ResourceView.prototype._selectTab):
(WebInspector.ResourceView.prototype.hasContentTab):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView.prototype.hasContentTab):
2010-05-06 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Kenneth Christiansen.
Spatial Navigation: adapt the logic of {deep}findFocusableNodeInDirection to do traversal starting from Node* not Document*
https://bugs.webkit.org/show_bug.cgi?id=37803
Instead of receiving a Document pointer as incoming parameter, patch modifies
findFocusableNodeInDirection and deepFindFocusableNodeInDirection methods to
receive a Node pointer as start for content traversal.
This way we can make good use of deepFindFocusableNodeInDirection to traverse
other scrollable container like scrollable div's, and not only frames or iframes.
Patch also makes use of 'while' instead of 'for' to loop control, that gives move
flexibility to the incremental step: e.g. if a scrollable div was processed, the incremental
step in the loop does not have to do node->traverseNextNode() but node->traverseNextSibling().
No behavior change. It is a preparation for supporting scrollable containers in Spatial
Navigation.
* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusDirectionally):
(WebCore::FocusController::findFocusableNodeInDirection):
(WebCore::FocusController::deepFindFocusableNodeInDirection):
* page/FocusController.h:
2010-05-06 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed WinCE buildfix after r58842.
Preprocessor doesn't understand "true", changed to "1"
* platform/graphics/MediaPlayer.cpp:
2010-05-06 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Temporarily disable 'console.profiles' until we can distinguish
functions from different frames
https://bugs.webkit.org/show_bug.cgi?id=38638
* bindings/v8/custom/V8ConsoleCustom.cpp:
(WebCore::V8Console::profilesAccessorGetter):
2010-05-06 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
https://bugs.webkit.org/show_bug.cgi?id=38544
No new tests, build fix only.
* DerivedSources.make:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::ScriptController):
* bindings/js/ScriptController.h:
* bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::createScriptInstanceForWidget):
* bridge/jni/JNIBridge.cpp:
* bridge/jni/JNIBridge.h:
* bridge/jni/JNIUtility.cpp:
* bridge/jni/JNIUtility.h:
* bridge/jni/jni_jsobject.h:
* bridge/jni/jni_jsobject.mm:
* bridge/jni/jni_objc.mm:
* bridge/jni/jsc/JNIBridgeJSC.cpp:
* bridge/jni/jsc/JNIBridgeJSC.h:
* bridge/jni/jsc/JNIUtilityPrivate.cpp:
* bridge/jni/jsc/JNIUtilityPrivate.h:
* bridge/jni/jsc/JavaClassJSC.cpp:
* bridge/jni/jsc/JavaClassJSC.h:
* bridge/jni/jsc/JavaInstanceJSC.cpp:
* bridge/jni/jsc/JavaInstanceJSC.h:
* loader/FrameLoaderClient.h:
2010-05-05 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Fixed the gobject introspection compilation with the new DOM
bindings, we needed to add DOM objects.
* GNUmakefile.am:
2010-05-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
drop support for sessionStorage in sandbox iframes
https://bugs.webkit.org/show_bug.cgi?id=38151
This patch causes us to throw a security exception when a sandboxed
iframe attempts to access sessionStorage, matching our behavior for
localStorage. The letter of the spec asks us to create a separate
storage area for each unique origin. We might want to do that in a
future patch, but throwing a security error seems like a safe move now.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* page/SecurityOrigin.h:
(WebCore::SecurityOrigin::canAccessSessionStorage):
* storage/StorageEventDispatcher.cpp:
(WebCore::StorageEventDispatcher::dispatch):
2010-05-06 Andy Estes <aestes@apple.com>
Reviewed by Maciej Stachowiak.
Allow forms submitting to target="_blank" to open popups if the submission
originated from a user gesture.
https://bugs.webkit.org/show_bug.cgi?id=37335
<rdar://problem/7884980>
Test: fast/events/popup-allowed-from-gesture-initiated-form-submit.html
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::processingUserGesture): If no DOM event is
being processed, consult UserGestureIndicator to determine return value.
* bindings/js/ScriptController.h: Moved the logic of processingUserGestureEvent()
into processingUserGesture().
2010-05-06 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Eric Seidel.
[GTK] Refactor GenerateProperties in CodeGenerationGObject.pm
https://bugs.webkit.org/show_bug.cgi?id=38577
Thinko caught while refactoring, $custom variable was not
initialized.
* bindings/scripts/CodeGeneratorGObject.pm:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
2010-05-06 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Eric Seidel.
[GTK] Refactor GenerateProperties in CodeGenerationGObject.pm
https://bugs.webkit.org/show_bug.cgi?id=38577
Refactor GenerateProperty out of GenerateProperties. This is in
preparation for EventListeren attributes, which won't generate
normal GObject properties.
* bindings/scripts/CodeGeneratorGObject.pm:
2010-05-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: follow up to linkify event listeners.
https://bugs.webkit.org/show_bug.cgi?id=38257
* bindings/js/ScriptEventListener.cpp:
(WebCore::eventListenerHandlerLocation):
* bindings/v8/ScriptEventListener.cpp:
(WebCore::eventListenerHandlerLocation):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.linkifyNodeReference):
* inspector/front-end/EventListenersSidebarPane.js:
2010-05-05 Charles Wei <charles.wei@torchmobile.com.cn>
Reviewed by George Staikos
https://bugs.webkit.org/show_bug.cgi?id=37848
This patch adds WCSS -wap-input-format and -wap-input-required support to WebKit
Tests: fast/wcss/wap-input-format.xhtml
fast/wcss/wap-input-required.xhtml
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseWCSSInputProperty):
* css/CSSParser.h:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/WCSSPropertyNames.in:
* dom/InputElement.cpp:
(WebCore::InputElement::sanitizeValue):
(WebCore::InputElement::handleBeforeTextInsertedEvent):
(WebCore::InputElementData::InputElementData):
(WebCore::formatCodes):
(WebCore::cursorPositionToMaskIndex):
(WebCore::InputElement::isConformToInputMask):
(WebCore::InputElement::validateInputMask):
* dom/InputElement.h:
(WebCore::InputElementData::inputFormatMask):
(WebCore::InputElementData::setInputFormatMask):
(WebCore::InputElementData::maxInputCharsAllowed):
(WebCore::InputElementData::setMaxInputCharsAllowed):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setWapInputFormat):
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::data):
* wml/WMLInputElement.h:
(WebCore::WMLInputElement::data):
2010-05-05 MORITA Hajime <morrita@google.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=38150
Refactoring: webkitEditableContentChangedEvent should be handled by the owner of appropriate the renderer.
Moved a part of code chunk in HTMLFormControlElementWithState::defaultEventHandler()
which accesses the renderer from foreign node,
to TextControlInnerTextElement::defaultEventHandler() which owns the renderer.
No new tests. No behavioral change.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElementWithState::defaultEventHandler):
* html/HTMLFormControlElement.h:
* html/HTMLInputElement.h:
* html/HTMLTextAreaElement.h:
* rendering/TextControlInnerElements.cpp:
(WebCore::TextControlInnerTextElement::defaultEventHandler):
2010-05-05 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Timothy Hatcher.
Web Inspector: Line Numbers should be Aligned with the Source Code Line
https://bugs.webkit.org/show_bug.cgi?id=38593
If there is a message bubble, such as an error message, in a source view
the line number should be in line with the source code line, not centered
between the source and bubble.
* inspector/front-end/textViewer.css:
(.webkit-line-number): added vertical-align: top
2010-05-05 Dan Bernstein <mitz@apple.com>
Fix the decelerated compositing build.
* page/FrameView.cpp:
(WebCore::FrameView::isEnclosedInCompositingLayer):
* page/FrameView.h:
2010-05-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler.
Bug 38604 - workers-gc2 crashing on Qt
This appears to be due to a couple of issues.
(1) When the atomic string table is deleted it does not clear the 'inTable' bit
on AtomicStrings - it implicitly assumes that all AtomicStrings have already
been deleted at this point (otherwise they will crash in their destructor when
they try to remove themselves from the atomic string table).
(2) We don't fix the ordering in which WTF::WTFThreadData and
WebCore::ThreadGlobalData are destructed.
We should make sure that ThreadGlobalData is cleaned up before worker threads
terminate and WTF::WTFThreadData is destroyed, and we should clear the inTable
bit of members on atomic string table destruction.
WTF changes (fix issue 2, above) - clean up the thread data on worker termination.
* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::~ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):
* platform/ThreadGlobalData.h:
* workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
2010-05-05 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7932072> Iframes in composited layers don’t repaint correctly (affects Yahoo! Mail with Flash Player 10.1)
https://bugs.webkit.org/show_bug.cgi?id=38427
Test: compositing/iframes/iframe-in-composited-layer.html
* WebCore.base.exp: Export FrameView::isEnclosedInCompositingLayer().
* page/FrameView.cpp:
(WebCore::FrameView::isEnclosedInCompositingLayer): Added this predicate.
* page/FrameView.h:
2010-05-05 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Got composited iframes showing up on Mac again
https://bugs.webkit.org/show_bug.cgi?id=38565
This was broken by http://trac.webkit.org/changeset/58798. That
change connected iframes through the parent document to the root
of the layer tree. That is correct for Windows, but not for Mac.
So the places where the linkage is made were wrapped in
shouldPropagateCompositingToIFrameParent() calls, which is
always false for Mac.
Test: compositing/iframes/composited-iframe-alignment.html
* rendering/RenderLayerCompositor.cpp:Avoid doing composited iframe linkage on Mac
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::didMoveOnscreen):
(WebCore::RenderLayerCompositor::willMoveOffscreen):
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
2010-05-05 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=38260
<rdar://problem/7917548> Fix whitespace removing in deprecatedParseURL().
Broken all the way since r4 (yes, that's a revision number).
Test: http/tests/security/xss-DENIED-javascript-with-spaces.html
* css/CSSHelper.cpp: (WebCore::deprecatedParseURL): Fixed loop conditions for remaining length.
2010-05-05 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
Many AXUnknown showing up in the hierarchy
https://bugs.webkit.org/show_bug.cgi?id=38607
The RenderTableSection should not be an accessible element.
Test: platform/mac/accessibility/parent-of-table-row-is-table.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
2010-05-05 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Simon Hausmann.
[Qt]Disable Qt Multimedia backend for HTML 5 Audio and Video elements
Fall back to the Phonon backend until the release situation has been cleared up.
https://bugs.webkit.org/show_bug.cgi?id=38612
Buildfix for QT_VERSION >= 0x040700 after r58810.
* platform/graphics/MediaPlayer.cpp:
2010-05-05 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
XMLHttpRequestUpload events do not fire when sending a raw file or FormData object.
https://bugs.webkit.org/show_bug.cgi?id=37771
Test: http/tests/local/formdata/upload-events.html
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
2010-05-05 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Qt port should use its own QUuid class to create UUID string.
https://bugs.webkit.org/show_bug.cgi?id=38581
* platform/UUID.cpp:
(WebCore::createCanonicalUUIDString): Added PLATFORM(QT) case.
2010-05-05 Alexey Proskuryakov <ap@apple.com>
Roll out r58830 for breaking tests.
Was: https://bugs.webkit.org/show_bug.cgi?id=38546
Node.focus() fails to move focus from subframe properly
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::setFocus):
2010-05-05 Jian Li <jianli@chromium.org>
Reviewed by Adam Barth.
Implement FileReader class.
https://bugs.webkit.org/show_bug.cgi?id=38157
This patch only contains the implementation of FileReader class as defined
in the File API spec: http://www.w3.org/TR/file-upload/#dfn-filereader.
New test will be added when a IDL is exposed and the FILE_READER is turned
on.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/EventNames.h:
* dom/EventTarget.cpp:
(WebCore::EventTarget::toFileReader):
* dom/EventTarget.h:
* html/FileError.h:
(WebCore::FileError::FileError):
* html/FileReader.cpp: Added.
* html/FileReader.h: Added.
* html/FileStream.cpp:
(WebCore::FileStream::FileStream):
(WebCore::FileStream::openForRead):
(WebCore::FileStream::close):
(WebCore::FileStream::read):
* html/FileStream.h:
2010-05-05 Steve Falkenburg <sfalken@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION(r57969) Image decoder is repeatedly destroyed/created in CoreGraphics-based Windows WebKit
https://bugs.webkit.org/show_bug.cgi?id=38595
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::setData):
2010-05-05 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=38546
Node.focus() fails to move focus from subframe properly
Test: fast/frames/take-focus-from-iframe.html
* html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setFocus): Don't clear
focus if this frame doesn't have it. This can happen if page's and HTMLFrameElement's ideas
of focused frame get out of sync temporarily.
2010-05-05 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=26824
<rdar://problem/7018610> EventHandler can operate on a wrong frame if focus changes during
keyboard event dispatch.
EventHandler object is tied to a frame, so it's wrong for it to continue processing a keyboard
event if focused frame changes between keydown and keypress.
* manual-tests/focus-change-between-key-events.html: Added.
* page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Bail out early if focused frame
changes while dispatching keydown. Also made similar changes for Windows to maintain matching
behavior, even though EventHandler was re-entered anyway due to WM_KEYDOWN and WM_CHAR being
separate events.
2010-05-05 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
MediaError.h is missing PassRefPtr.h include
https://bugs.webkit.org/show_bug.cgi?id=38575
No new tests, build fix only.
* html/MediaError.h:
2010-05-05 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Audits panel: Resource counters get reset when switching panels while reloading page
https://bugs.webkit.org/show_bug.cgi?id=38579
* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView.prototype.updateResourceTrackingState):
(WebInspector.AuditLauncherView.prototype._updateResourceProgress):
2010-05-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: Doubleclick on line number should not trigger source editing.
https://bugs.webkit.org/show_bug.cgi?id=38588
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._handleDoubleClick):
2010-05-05 Martin Robinson <mrobinson@webkit.org>
Reviewed by Gustavo Noronha.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Add support in the PasteboardHelper for images, in preparation for drag-and-drop data.
No new tests as functionality has not changed.
* platform/gtk/PasteboardHelper.cpp:
(WebCore::PasteboardHelper::fillSelectionData): Add support for images here.
(WebCore::PasteboardHelper::targetListForDataObject): Add support for images here.
2010-05-05 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Darin Fisher.
Add a "focused" parameter to Widget::setFocus, and updates Document
so that Widget is informed of focus loss as well as focus gain.
Changes all existing setFocus implementations so that they ignore
the 'false' case, so no behavior is changed until individual
platforms are updated to handle the new case (if they want to).
https://bugs.webkit.org/show_bug.cgi?id=37961
* dom/Document.cpp:
(WebCore::Document::setFocusedNode):
* platform/Widget.h:
* platform/android/WidgetAndroid.cpp:
(WebCore::Widget::setFocus):
* platform/chromium/WidgetChromium.cpp:
(WebCore::Widget::setFocus):
* platform/efl/WidgetEfl.cpp:
(WebCore::Widget::setFocus):
* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::setFocus):
* platform/haiku/WidgetHaiku.cpp:
(WebCore::Widget::setFocus):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::setFocus):
* platform/qt/WidgetQt.cpp:
(WebCore::Widget::setFocus):
* platform/win/WidgetWin.cpp:
(WebCore::Widget::setFocus):
* platform/wx/WidgetWx.cpp:
(WebCore::Widget::setFocus):
* plugins/PluginView.h:
* plugins/PluginViewNone.cpp:
(WebCore::PluginView::setFocus):
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::setFocus):
* plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::setFocus):
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::setFocus):
* plugins/symbian/PluginViewSymbian.cpp:
(WebCore::PluginView::setFocus):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::setFocus):
2010-05-05 Steve Block <steveblock@google.com>
Reviewed by Pavel Feldman.
Move V8 ScriptDebugServer::topStackFrame() to ScriptCallStack
https://bugs.webkit.org/show_bug.cgi?id=38531
ScriptCallStack::create() uses ScriptDebugServer::topStackFrame(), but ScriptDebugServer
is guarded with ENABLE(JAVASCRIPT_DEBUGGER). This prevents ScriptCallStack from being
built on platforms that do not define ENABLE(JAVASCRIPT_DEBUGGER).
No new tests, build fix only.
* bindings/v8/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::callLocation):
(WebCore::ScriptCallStack::createUtilityContext): Helper for topStackFrame, moved from ScriptDebugServer
(WebCore::ScriptCallStack::topStackFrame): Moved from ScriptDebugServer
* bindings/v8/ScriptCallStack.h:
(WebCore::ScriptCallStack::utilityContext): Helper for topStackFrame, moved from ScriptDebugServer
* bindings/v8/ScriptDebugServer.cpp:
* bindings/v8/ScriptDebugServer.h:
2010-05-05 Csaba Osztrogonác <ossy@webkit.org>
Rubber-stamped by Simon Hausmann.
[Qt] REGRESSION(r56869): WinCE build is broken
https://bugs.webkit.org/show_bug.cgi?id=36929
* WebCore.pro: LIBS += -lOle32 added.
2010-05-05 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Disable Qt Multimedia backend for HTML 5 Audio and Video elements
Fall back to the Phonon backend until the release situation has been cleared up.
* WebCore.pro:
2010-05-05 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Clickable links to resources should be used as 'details' part for the all suitable kinds of records.
https://bugs.webkit.org/show_bug.cgi?id=38542
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelineRecordListRow):
(WebInspector.TimelineRecordListRow.prototype.update):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.PopupContentHelper):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._createCell):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendTextRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendElementRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
2010-05-05 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Add missing files generated by "run-bindings-test", after the DOMTestCallback.idl addition.
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: Added.
(WebKit::kit):
(webkit_dom_test_callback_callback_with_class1param):
(webkit_dom_test_callback_callback_with_class2param):
(webkit_dom_test_callback_callback_with_non_bool_return_type):
(WebKit::wrapTestCallback):
(WebKit::core):
(webkit_dom_test_callback_finalize):
(webkit_dom_test_callback_set_property):
(webkit_dom_test_callback_get_property):
(webkit_dom_test_callback_class_init):
(webkit_dom_test_callback_init):
* bindings/scripts/test/GObject/WebKitDOMTestCallback.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h: Added.
* bindings/scripts/test/ObjC/DOMTestCallback.h: Added.
* bindings/scripts/test/ObjC/DOMTestCallback.mm: Added.
(-[DOMTestCallback dealloc]):
(-[DOMTestCallback finalize]):
(-[DOMTestCallback callbackWithClass1Param:]):
(-[DOMTestCallback callbackWithClass2Param:strArg:]):
(-[DOMTestCallback callbackWithNonBoolReturnType:]):
(-[DOMTestCallback customCallback:class6Param:]):
(core):
(kit):
* bindings/scripts/test/ObjC/DOMTestCallbackInternal.h: Added.
2010-05-05 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Pavel Feldman.
Web Inspector: FontView needs Cleanup
https://bugs.webkit.org/show_bug.cgi?id=38567
FontView was missing some of the newer practices for initialization
that other Resource Views had. Also its width calculations could
result in a single character wrapping. This is general cleanup.
* inspector/front-end/FontView.js:
(WebInspector.FontView): move initialization into contentTabSelected
(WebInspector.FontView.prototype.contentTabSelected): handle initialization like other Resource Views
(WebInspector.FontView.prototype.updateFontPreviewSize): use a narrower width to prevent text from widowing
2010-05-05 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG hit testing is *way* too slow
https://bugs.webkit.org/show_bug.cgi?id=19312
Use the cached stroke and fill boundaries in RenderPath as a heuristik to
speed up SVG's hit testing.
No new tests added.
* rendering/RenderPath.cpp:
(WebCore::RenderPath::fillContains):
(WebCore::RenderPath::strokeContains):
2010-05-04 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Adam Barth.
Auto-generate all Database callbacks.
https://bugs.webkit.org/show_bug.cgi?id=38503
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSCustomSQLStatementCallback.cpp: Removed.
* bindings/js/JSCustomSQLStatementCallback.h: Removed.
* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSSQLStatementErrorCallback::handleEvent):
* bindings/js/JSCustomSQLStatementErrorCallback.h: Removed.
* bindings/js/JSCustomSQLTransactionCallback.cpp: Removed.
* bindings/js/JSCustomSQLTransactionCallback.h: Removed.
* bindings/js/JSCustomSQLTransactionErrorCallback.cpp: Removed.
* bindings/js/JSCustomSQLTransactionErrorCallback.h: Removed.
* bindings/js/JSDatabaseCallback.cpp: Removed.
* bindings/js/JSDatabaseCallback.h: Removed.
* bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::changeVersion):
(WebCore::createTransaction):
* bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/test/JS/JSTestCallback.cpp:
* bindings/v8/custom/V8CustomSQLStatementCallback.cpp: Removed.
* bindings/v8/custom/V8CustomSQLStatementCallback.h: Removed.
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8SQLStatementErrorCallback::handleEvent):
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.h: Removed.
* bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: Removed.
* bindings/v8/custom/V8CustomSQLTransactionCallback.h: Removed.
* bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: Removed.
* bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Removed.
* bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
* bindings/v8/custom/V8DatabaseCallback.h: Removed.
* bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::V8Database::changeVersionCallback):
(WebCore::createTransaction):
* bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
* storage/DatabaseCallback.h:
* storage/DatabaseCallback.idl: Added.
* storage/SQLStatement.cpp:
(WebCore::SQLStatement::performCallback):
* storage/SQLStatementCallback.h:
* storage/SQLStatementCallback.idl: Added.
* storage/SQLStatementErrorCallback.idl: Added.
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverTransactionCallback):
* storage/SQLTransactionCallback.h:
* storage/SQLTransactionCallback.idl: Added.
* storage/SQLTransactionErrorCallback.h:
* storage/SQLTransactionErrorCallback.idl: Added.
2010-05-04 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Made composited iframes work on Windows
https://bugs.webkit.org/show_bug.cgi?id=32446
This completes the work in http://trac.webkit.org/changeset/57919
to create compositing layers in the parent document when an iframe has
a compositing layer. The parent document has a layer for the iframe
element and builds a layer tree to the page root. The layer tree for the
iframe document is then parented to the iframe element's GraphicsLayer.
The RenderLayerCompositor for the iframe document (which owns the
root of the layer tree) now has a clippingLayer which is the
parent of the layer tree root so it can be clipped to the parent
iframe's bounds, taking into account borders, padding, etc. in
the parent iframe element.
I also got rid of a no longer used function: RenderLayerCompositor::parentInRootLayer
Test: compositing/iframes/composited-parent-iframe.html
* rendering/RenderLayerBacking.cpp:Make calls to RenderLayerCompositor to set the clipping bounds for iframe content
* rendering/RenderLayerCompositor.cpp:Hook the iframe content to the parent iframe element
* rendering/RenderLayerCompositor.h:
2010-05-03 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=38497
<rdar://problem/7759438> Make sure that http URLs always have a host in SecurityOrigin
This is a hardening fix, and behavior really depends on what an underlying networking layer
does. So, no test.
* page/SecurityOrigin.cpp:
(WebCore::schemeRequiresAuthority): List schemes that need an authority for successful loading.
(WebCore::SecurityOrigin::SecurityOrigin): Never let e.g. http origins with empty authorities
have the same security origin.
2010-05-04 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
getFramebufferAttachmentParameter should return the original WebGLTexture/WebGLRenderbuffer instead of creating new ones sharing names.
https://bugs.webkit.org/show_bug.cgi?id=38236
* html/canvas/CanvasObject.h: Add type check functions.
(WebCore::CanvasObject::isBuffer):
(WebCore::CanvasObject::isFramebuffer):
(WebCore::CanvasObject::isProgram):
(WebCore::CanvasObject::isRenderbuffer):
(WebCore::CanvasObject::isShader):
(WebCore::CanvasObject::isTexture):
* html/canvas/WebGLBuffer.h: Add type check functions.
(WebCore::WebGLBuffer::isBuffer):
* html/canvas/WebGLFramebuffer.h: Add type check functions.
(WebCore::WebGLFramebuffer::isFramebuffer):
* html/canvas/WebGLProgram.h: Add type check functions.
(WebCore::WebGLProgram::isProgram):
* html/canvas/WebGLRenderbuffer.cpp: remove constructor using existing name.
* html/canvas/WebGLRenderbuffer.h: Add type check functions; remove constructor using existing name.
(WebCore::WebGLRenderbuffer::isRenderbuffer):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Return original Texture/Renderbuffer instead of creating new ones.
(WebCore::WebGLRenderingContext::findTexture): Find a WebGLTexture using a name.
(WebCore::WebGLRenderingContext::findRenderbuffer): Find a WebGLRenderbuffer using a name.
* html/canvas/WebGLRenderingContext.h: Add find* functions.
* html/canvas/WebGLShader.h: Add type check functions.
(WebCore::WebGLShader::isShader):
* html/canvas/WebGLTexture.cpp: remove constructor using existing name.
* html/canvas/WebGLTexture.h: Add type check functions; remove constructor using existing name.
(WebCore::WebGLTexture::isTexture):
2010-05-04 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] QT_MOBILE_THEME compile time flag
https://bugs.webkit.org/show_bug.cgi?id=38439
Replacing preprocessor conditional used in RenderThemeQt from Q_WS_MAEMO_5 to
USE(QT_MOBILE_THEME).
* WebCore.pro:
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::qStyle):
(WebCore::RenderThemeQt::extraDefaultStyleSheet):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
* platform/qt/RenderThemeQt.h:
2010-05-04 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Dan Bernstein.
SVG fonts trigger GlyphPage::fill with null font
https://bugs.webkit.org/show_bug.cgi?id=38530
SVG fonts do not use the glyph page cache. This change detects when
attempting to fill a GlyphPage with an SVG font and indicates that
the glyphs were not available.
* platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::fill): helper method which handles attempts to fill a GlyphPage with SVG or non-SVG fonts
(WebCore::GlyphPageTreeNode::initializePage): use the helper where appropriate
2010-05-04 Kent Tamura <tkent@chromium.org>
Reviewed by David Levin (and unofficially by Enrica Casucci).
REGRESSION(r54368): Text drag-and-drop from input/textarea doesn't work
if the text is like a URL
https://bugs.webkit.org/show_bug.cgi?id=38374
Since r54368, documentFragmentFromDragData() creates an <a> element
with no anchor text for URL-like text dragged from input/textarea
element. If such text is dropped to input/textarea element, the text
is not inserted.
To fix this problem, use the original text or the URL as an anchor
text.
Test: editing/pasteboard/drag-drop-url-text.html
* page/DragController.cpp:
(WebCore::documentFragmentFromDragData):
2010-05-04 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
JavaInstanceJSC.cpp and JNIUtilityPrivate.cpp need to include jni_jsobject.h for jlong_to_pt() and ptr_to_jlong()
https://bugs.webkit.org/show_bug.cgi?id=38525
No new tests, build fix only.
* bridge/jni/jni_jsobject.h: Guard Mac-specific code with PLATFORM(MAC)
* bridge/jni/jsc/JNIUtilityPrivate.cpp: Include jni_jsobject.h
* bridge/jni/jsc/JavaInstanceJSC.cpp: Include jni_jsobject.h
2010-05-04 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
New FileSystemPOSIX functions cause linker errors on Android
https://bugs.webkit.org/show_bug.cgi?id=38521
No new tests, build fix only.
* platform/android/FileSystemAndroid.cpp: Remove closeFile, which is provided in FileSystemPOSIX.cpp
* platform/posix/FileSystemPOSIX.cpp: Guard writeToFile with !PLATFORM(ANDROID)
2010-05-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: restore main and sidebar scroller positions
when switching between panels.
https://bugs.webkit.org/show_bug.cgi?id=38522
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.elementsToRestoreScrollPositionsFor):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.show):
(WebInspector.Panel.prototype.hide):
(WebInspector.Panel.prototype.elementsToRestoreScrollPositionsFor):
(WebInspector.Panel.prototype._storeScrollPositions):
(WebInspector.Panel.prototype._restoreScrollPositions):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.elementsToRestoreScrollPositionsFor):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor):
2010-05-04 Steven Lai <steven_lai@asia.apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=37900
<rdar://problem/7806164> cloneNode() does not preserve z-index with more than six digits
Tests: fast/dom/HTMLInputElement/clone-input-checked.html
fast/dom/clone-node-z-index.html
* dom/Element.cpp: undid the order change of calling copyNonAttributeProperties() before setAttributes()
(WebCore::Element::cloneElementWithoutChildren): uncheck the previous radio button in the same radio button group only when the checked radio box is appended to the dom tree
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateCheckedRadioButtons):
(WebCore::HTMLInputElement::attach):
(WebCore::HTMLInputElement::setChecked):
* html/HTMLInputElement.h:
2010-04-29 John Gregg <johnnyg@google.com>
Reviewed by Dmitry Titov.
notifications should have dir and replaceId attributes.
Note that tests are only enabled in Chromium, skipped elsewhere
since notifications aren't implemented.
https://bugs.webkit.org/show_bug.cgi?id=38336
Tests: fast/notifications/notifications-replace.html
fast/notifications/notifications-rtl.html
* notifications/Notification.h:
(WebCore::Notification::dir):
(WebCore::Notification::setDir):
(WebCore::Notification::replaceId):
(WebCore::Notification::setReplaceId):
* notifications/Notification.idl:
2010-05-04 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Fixed error defining the float/double minimum in the object
properties, the smallest value of a float/double is
-G_MAXDOUBLE/-G_MAXFLOAT.
* bindings/scripts/CodeGeneratorGObject.pm:
2010-05-03 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Dan Bernstein.
REGRESSION: Text clipped in absolutely positioned search inputs
https://bugs.webkit.org/show_bug.cgi?id=38468
Previously I incorrectly added x() and y() to the tx and ty positioning.
This clips a search input like a text input, respecting the vertically
centered text.
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout): only the Y changes, so change setLocation to setY
(WebCore::RenderTextControlSingleLine::controlClipRect):
2010-05-04 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: REGRESSION: Up/Down, PgUp/PgDown keys do not change numeric style properties
https://bugs.webkit.org/show_bug.cgi?id=38516
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
2010-05-04 Ben Murdoch <benm@google.com>
Reviewed by Simon Hausmann.
Crash in handleTouchEvent: using dangling node ptrs in hashmap
https://bugs.webkit.org/show_bug.cgi?id=38514
When navigating away from a page, if you have your finger still
pressed and then lift it on the new page we see a crash if the
node got deleted as we still have a dangling pointer in the
m_originatingTouchPointTargets hashmap and try to use it as the
receiver to dispatch a touchend event.
Test: fast/events/touch/touch-stale-node-crash.html
* page/EventHandler.cpp:
(WebCore::EventHandler::clear): Clear the hashmap of touch targets.
2010-05-04 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Pavel Feldman.
Web Inspector: Drawer Misbehaving when Docking / Undocking in Console Panel
https://bugs.webkit.org/show_bug.cgi?id=38510
* inspector/front-end/inspector.js:
(WebInspector.set attached): resize the drawer after docking/undocking
2010-05-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed, build fix for Symbian.
[Symbian] Build fix after r58598.
Use C99 integer types for the Symbian plugin
implementation.
No new tests, as there is no new functionality.
* plugins/symbian/PluginPackageSymbian.cpp:
(WebCore::PluginPackage::NPVersion):
* plugins/symbian/PluginViewSymbian.cpp:
(WebCore::PluginView::handlePostReadFile):
2010-05-04 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Split SVGCharacterLayoutInfo in smaller pieces
https://bugs.webkit.org/show_bug.cgi?id=38513
Split SVGCharacterLayoutInfo into SVGCharacterLayoutInfo/SVGCharacterData and SVGTextChunkLayoutInfo.
This is a preparation for more work in the text area.
* Android.mk: Add SVGCharacterData.(cpp|h) and SVGTextChunkLayoutInfo.h to build.
* GNUmakefile.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* rendering/SVGCharacterData.cpp: Copied from rendering/SVGCharacterLayoutInfo.cpp.
* rendering/SVGCharacterData.h: Copied from rendering/SVGCharacterLayoutInfo.h.
(WebCore::SVGChar::SVGChar):
* rendering/SVGCharacterLayoutInfo.cpp:
(WebCore::SVGCharacterLayoutInfo::isInitialLayout): Introduced new helper function to share code between addLayoutInformation/addStackContent.
(WebCore::SVGCharacterLayoutInfo::addLayoutInformation): Use new helper function.
(WebCore::SVGCharacterLayoutInfo::addStackContent): Ditto
* rendering/SVGCharacterLayoutInfo.h:
* rendering/SVGRootInlineBox.h: Include new files.
* rendering/SVGTextChunkLayoutInfo.h: Copied from rendering/SVGCharacterLayoutInfo.h.
2010-05-04 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590
Use helper functions from CodeGenerator.pm to figure out whether a
type is "fundamental" or not (basically whether it's anything
other than a string or a non-pointer type).
* bindings/scripts/CodeGeneratorGObject.pm:
2010-04-30 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: REGRESSION: Disabled style properties are absent in Styles sidebar after WebInspector is re-opened
https://bugs.webkit.org/show_bug.cgi?id=38255
Moved stylesheet-related mappings into a separate object stored
in InspectorController rather than InspectorDOMAgent (which gets reset
on every frontend [dis]connect).
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorCSSStore.cpp: Added.
(WebCore::InspectorCSSStore::InspectorCSSStore):
(WebCore::InspectorCSSStore::~InspectorCSSStore):
(WebCore::InspectorCSSStore::reset):
* inspector/InspectorCSSStore.h: Added.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::setFrontend):
(WebCore::InspectorController::didCommitLoad):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::applyStyleText):
(WebCore::InspectorDOMAgent::setStyleText):
(WebCore::InspectorDOMAgent::setStyleProperty):
(WebCore::InspectorDOMAgent::toggleStyleEnabled):
(WebCore::InspectorDOMAgent::setRuleSelector):
(WebCore::InspectorDOMAgent::addRule):
(WebCore::InspectorDOMAgent::bindStyle):
(WebCore::InspectorDOMAgent::bindRule):
(WebCore::InspectorDOMAgent::buildObjectForStyle):
(WebCore::InspectorDOMAgent::buildObjectForRule):
* inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
(WebCore::InspectorDOMAgent::cssStore):
2010-05-04 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Display "Recording..." item when recording an user-initiated CPU profile.
https://bugs.webkit.org/show_bug.cgi?id=38043
* English.lproj/localizedStrings.js:
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype.removeProfileHeader):
(WebInspector.ProfilesPanel.prototype.showProfile):
* inspector/front-end/inspector.js:
(WebInspector.setRecordingProfile):
2010-05-04 Tucker Jay <jay.tucker@nokia.com>
Reviewed by Holger Freyther.
Animated GIF images does not animate 10x as expected by default.
https://bugs.webkit.org/show_bug.cgi?id=36818
Added test case to existing manual test to test the
fixed functionality.
* manual-tests/qt/qt-10loop-anim.gif: Added.
* manual-tests/qt/qt-gif-test.html:
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::repetitionCount):
2010-05-04 Dirk Schulze <krit@webkit.org>
Unreviewed sort of XCodes project file.
* WebCore.xcodeproj/project.pbxproj:
2010-05-03 Steven Lai <steven_lai@asia.apple.com>
Reviewed by Brady Eidson.
Reverted hashchange() event back to async.
(This change does not update HashChangeEvent to its new proposed interface)
https://bugs.webkit.org/show_bug.cgi?id=36201
rdar://problem/7780794
rdar://problem/7761278 (partial fix)
Tests: fast/loader/hashchange-event-async.html
* dom/Document.cpp: reverted hashchange() event back to async
(WebCore::Document::enqueueHashchangeEvent):
2010-05-03 Holger Hans Peter Freyther <zecke@selfish.org>
Rubber-stamped by Xan Lopez.
[Cairo,WX] Stop leaking a FontPlatformData.
https://bugs.webkit.org/show_bug.cgi?id=37500
Stephan Aßmus pointed out that the pango font backend
is leaking memory and fixed it. The WX font backend
and the Cairo/Fontconfig backend have the same snippet
of code and are leaking memory as well. This commit is
fixing that.
* platform/graphics/cairo/SimpleFontDataCairo.cpp:
(WebCore::SimpleFontData::smallCapsFontData):
* platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::smallCapsFontData):
2010-05-03 James Robinson <jamesr@chromium.org>
Reviewed by Eric Seidel.
Clean up a few compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=38073
* html/TextMetrics.h:
(WebCore::TextMetrics::width):
* rendering/style/StyleRareInheritedData.h:
* rendering/style/StyleRareNonInheritedData.h:
2010-05-02 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Adam Barth.
Add the ability to auto-generate callbacks to all code generators.
https://bugs.webkit.org/show_bug.cgi?id=38414
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/JS/JSTestCallback.cpp: Added.
(WebCore::JSTestCallback::JSTestCallback):
(WebCore::JSTestCallback::~JSTestCallback):
(WebCore::JSTestCallback::callbackWithClass1Param):
(WebCore::JSTestCallback::callbackWithClass2Param):
* bindings/scripts/test/JS/JSTestCallback.h: Added.
(WebCore::JSTestCallback::create):
* bindings/scripts/test/V8/JSTestCallback.cpp: Added.
(WebCore::V8TestCallback::V8TestCallback):
(WebCore::V8TestCallback::~V8TestCallback):
(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):
* bindings/scripts/test/V8/V8TestCallback.h: Added.
(WebCore::V8TestCallback::create):
* bindings/scripts/test/TestCallback.idl: Added.
2010-05-03 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Kevin Ollivier.
[wx] Build and use Mac's ComplexTextController to support complex text in wx.
https://bugs.webkit.org/show_bug.cgi?id=38482
* platform/graphics/FloatSize.h:
* platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::advanceAt):
(WebCore::GlyphBuffer::add):
* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::getNSFont):
* platform/graphics/mac/ComplexTextController.cpp:
* platform/graphics/mac/ComplexTextController.h:
* platform/graphics/wx/FontCacheWx.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/wx/FontPlatformData.h:
(toCTFontRef):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::allowsLigatures):
* platform/graphics/wx/FontPlatformDataWx.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::cgFont):
* platform/graphics/wx/FontPlatformDataWxMac.mm: Added.
(WebCore::FontPlatformData::nsFont):
(WebCore::FontPlatformData::cacheNSFont):
* platform/graphics/wx/FontWx.cpp:
(WebCore::Font::canReturnFallbackFontsForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
* platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::containsCharacters):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/wx/wxcode/fontprops.h:
* platform/wx/wxcode/mac/carbon/fontprops.mm:
(wxFontContainsCharacters):
(GetTextExtent):
* platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
(WebCore::drawTextWithSpacing):
* platform/wx/wxcode/win/fontprops.cpp:
(wxFontContainsCharacters):
* wscript:
2010-05-03 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751
Test: editing/execCommand/clipboard-access.html
* WebCore.base.exp:
* editing/EditorCommand.cpp:
(WebCore::supportedCopyCut):
(WebCore::supportedPaste):
(WebCore::createCommandMap):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setJavaScriptCanAccessClipboard):
* page/Settings.h:
(WebCore::Settings::javaScriptCanAccessClipboard):
2010-05-03 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=38285
<rdar://problem/7903453> REGRESSION: Javascript command window.open does not work in empty tab
Cannot be tested, because new windows created in DRT always have an opener, and thus inherit
its security origin. Only new windows and tabs created by browser chrome had this problem.
* loader/FrameLoader.cpp: (WebCore::FrameLoader::init): Moved updateSandboxFlags() call to
the beginning, so that an initial document would get correct flags.
2010-05-03 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Darin Adler.
WebGL compile issue.
Added ExceptionCode.h to JSWebGLArrayBufferConstructor.cpp, for some reason it was missing.
https://bugs.webkit.org/show_bug.cgi?id=38453
No new tests: compile fix.
* bindings/js/JSWebGLArrayBufferConstructor.cpp:
2010-05-03 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r58685.
http://trac.webkit.org/changeset/58685
https://bugs.webkit.org/show_bug.cgi?id=38461
Broke a test on Gtk
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::updateStates):
2010-05-03 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Use HTML5 number parsing in HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=38434
Use parseToDoubleForNumberType instead of toDouble.
Throw an exception when the number is NaN or Infinity.
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::value):
(WebCore::HTMLProgressElement::setValue):
(WebCore::HTMLProgressElement::max):
(WebCore::HTMLProgressElement::setMax):
* html/HTMLProgressElement.h:
* html/HTMLProgressElement.idl:
2010-05-03 Jens Alfke <snej@chromium.org>
Reviewed by Darin Fisher.
[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=38397
No tests (functionality is exposed only through native WebKit API.)
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::prepareSubmit): Call frame loader's dispatchWillSendSubmitEvent
* loader/EmptyClients.h:
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::dispatchWillSendSubmitEvent): New empty method
2010-05-03 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GStreamer] forgotten call to durationChanged in updateStates()
https://bugs.webkit.org/show_bug.cgi?id=38461
Notify MediaPlayer if duration is known after playback started.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::updateStates):
2010-05-03 Ryuan Choi <ryuan.choi@gmail.com>
Reviewed by Darin Adler.
fixing build break due to clearWatch() when Geolocation feature is
disabled.
https://bugs.webkit.org/show_bug.cgi?id=38091
no test because this is a build fix only
* page/Geolocation.cpp:
(WebCore::Geolocation::clearWatch):
2010-05-03 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Holger Freyther.
[Gtk] Fix leaking the FontPlatformData instance used to create the the
small caps font data.
https://bugs.webkit.org/show_bug.cgi?id=37500
No new tests needed.
* platform/graphics/gtk/SimpleFontDataPango.cpp:
(WebCore::SimpleFontData::smallCapsFontData):
- Use a stack allocated FontPlatformData instead of a heap allocated
one that is never freed.
2010-05-03 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Simon Hausmann.
[Qt] GraphicsLayer: support webGL
https://bugs.webkit.org/show_bug.cgi?id=35388
Added support GraphicsContext3D to GraphicsLayer.
Added paint method to GraphicsContext3D for Qt platform that
uses drawTexture() when QGLWidget is used as viewport of
QGraphicsWebView.
Fine-tuned texture and handling and image to texture conversion to
work also when drawTexture() blitting is used.
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3D::beginPaint):
(WebCore::GraphicsContext3D::paint):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::getImageData):
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::):
(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::paint):
(WebCore::GraphicsLayerQtImpl::flushChanges):
(WebCore::GraphicsLayerQt::setContentsToGraphicsContext3D):
(WebCore::GraphicsLayerQt::setGraphicsContext3DNeedsDisplay):
* platform/graphics/qt/GraphicsLayerQt.h:
2010-05-03 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Simon Hausmann.
[Qt] Fix qtlibraryinfix not to contain space
List catenation with += adds whitespace cutting the infix
from the final target.
* WebCore.pro:
2010-05-03 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix rendering of <button> elements on Mac OS X
The <button> element has ButtonPart appearance, not PushButton part,
so we have to include ButtonPart when we decide if we should draw the
button as raised on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=38458
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::initializeCommonQStyleOptions):
2010-04-30 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
[GStreamer] endless loop after playback ended
https://bugs.webkit.org/show_bug.cgi?id=38384
At playback end ensure duration() will return a valid duration if
we managed to calculate it based on current position.
Test: media/video-duration-known-after-eos.html
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::didEnd):
2010-05-03 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
[Qt] Fix build break on Mac OS X
* plugins/mac/PluginPackageMac.cpp: Use correct type
* WebCore.pro: Remove duplicate symbol, we now have a Qt implementation
2010-05-03 Thomas Zander <t.zander@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix library infix usage when compiling inside of Qt
Don't apply the infix when building inside Qt, as that's done through the
inclusion of qbase.pri.
* WebCore.pro:
2010-05-02 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
Another case of <rdar://problem/7552959> REGRESSION: Infinite recursion in Position::getInlineBoxAndOffset()
https://bugs.webkit.org/show_bug.cgi?id=38445
Test: editing/selection/mixed-editability-11.html
* dom/Position.cpp:
(WebCore::downstreamIgnoringEditingBoundaries): Added. Returns the furthest visually equivalent
position downstream, crossing any editability boundaries.
(WebCore::upstreamIgnoringEditingBoundaries): Similarly for upstream.
(WebCore::Position::getInlineBoxAndOffset): Changed the logic for finding an inline box for positions
whose node is a block flow. Instead of traversing the DOM, advance downstream or upstream as far as
possible, crossing any editability boudaries. Infinite recursion is avoided by advancing all the way
and checking that the new position is different from the starting position. Also replaced the specific
test for buttons with the generic and more comprehensive canHaveChildrenForEditing().
2010-05-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix compilation with QT_NO_BEARERMANAGEMENT
https://bugs.webkit.org/show_bug.cgi?id=38324
* platform/network/NetworkStateNotifier.h:
* platform/network/qt/NetworkStateNotifierQt.cpp:
2010-04-29 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Simon Hausmann.
[Qt] QtWebKit versioning added
https://bugs.webkit.org/show_bug.cgi?id=37207
QtWebkit releases separated from Qt release cycle.
* WebCore.pro:
2010-05-02 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Timothy Hatcher.
Web Inspector: Old Style trimWhitespace() should be trim()
https://bugs.webkit.org/show_bug.cgi?id=38441
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
2010-05-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix compilation with QT_NO_LINEEDIT
https://bugs.webkit.org/show_bug.cgi?id=38324
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::~RenderThemeQt):
(WebCore::RenderThemeQt::findFrameLineWidth):
2010-05-02 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: Touch inspector controller to kick windows tests.
* inspector/InspectorController.cpp:
2010-05-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: IMG nodes are being added to the DOM tree late, sometimes hiding the revealed element.
https://bugs.webkit.org/show_bug.cgi?id=38432
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._onmousemove):
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
(WebInspector.ElementsTreeElement.prototype.updateTitle):
(WebInspector.ElementsTreeElement.prototype._attributeHTML):
():
2010-05-02 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG hkern implementation incomplete
https://bugs.webkit.org/show_bug.cgi?id=38407
Test: svg/text/text-hkern.svg
The current SVG hkern implementation is incomplete and partly wrong. We pass the ACID3 test
by accident.
The new implementation supports all glyph and unicode combinations that are allowed by the Spec
and fixes various of bugs. The parser moved from SVGFontElement to the general parsing code in
SVGParserUtilities.
Some clean-up makes the code more readable and reuseable for the upcoming vkern implementation.
hkern support for text on path is missing and will be added by a following patch.
Unicode strings of hkern elements are just parsed once and not on every glyph again anymore.
* rendering/SVGRootInlineBox.cpp:
(WebCore::calculateCSSKerning):
(WebCore::applySVGKerning):
(WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
* svg/SVGFontElement.cpp:
(WebCore::stringMatchesUnicodeRange):
(WebCore::stringMatchesGlyphName):
(WebCore::matches):
(WebCore::SVGFontElement::getHorizontalKerningPairForStringsAndGlyphs):
* svg/SVGFontElement.h:
* svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::buildHorizontalKerningPair):
* svg/SVGHKernElement.h:
* svg/SVGParserUtilities.cpp:
(WebCore::parseGlyphName):
(WebCore::parseUnicodeRange):
(WebCore::parseKerningUnicodeString):
* svg/SVGParserUtilities.h:
2010-05-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: debugger shortcuts are processed twice if source frame has focus.
https://bugs.webkit.org/show_bug.cgi?id=38431
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype._createViewerIfNeeded):
2010-05-02 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Eric Seidel.
[Qt] Build error in GraphicsContext3DQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=38382
Removed duplicate implementation of isGLES2Compliant from
GraphicsContext3DQt.cpp. Removed deprecated API stuff for
texImage2D/texSubImage2D.
* platform/graphics/qt/GraphicsContext3DQt.cpp:
2010-05-02 Garret Kelly <gdk@chromium.org>
Reviewed by David Levin.
Make the Touch RuntimeEnabledFeature disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=38392
* bindings/generic/RuntimeEnabledFeatures.cpp: Disable the Touch feature by default.
2010-05-02 Michael Nordman <michaeln@google.com>
Reviewed by Dmitry Titov.
Define two new ResourceRequestBase TargetTypes for worker and shared worker
main resources. Use the new target types where appropiate. Add logic to marshal
the target type specified by requests initiated on a background worker thread.
https://bugs.webkit.org/show_bug.cgi?id=38295
No new tests. This doesn't have script visible artifacts.
* platform/network/ResourceRequestBase.cpp: marshal the values
(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::copyData):
* platform/network/ResourceRequestBase.h: define the types
(WebCore::ResourceRequestBase::):
* workers/DefaultSharedWorkerRepository.cpp: use TargetIsSharedWorker
(WebCore::SharedWorkerScriptLoader::load):
* workers/Worker.cpp: use TargetIsWorker
(WebCore::Worker::Worker):
* workers/WorkerContext.cpp: use TargetIsScript for importScripts
(WebCore::WorkerContext::importScripts):
* workers/WorkerScriptLoader.cpp: add a data member for the target type
(WebCore::WorkerScriptLoader::WorkerScriptLoader):
(WebCore::WorkerScriptLoader::createResourceRequest):
* workers/WorkerScriptLoader.h:
2010-05-02 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Adele Peterson.
Webkit doesn't compile with 3D-canvas enabled and video disabled
https://bugs.webkit.org/show_bug.cgi?id=38297
Added a #ifdef ENABLE(VIDEO) to WebGL code
No new tests: compile fix.
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::texImage2D):
(WebCore::JSWebGLRenderingContext::texSubImage2D):
2010-05-01 Evan Stade <estade@chromium.org>
Reviewed by David Levin.
[chromium] Skia needs to fade DragImages
https://bugs.webkit.org/show_bug.cgi?id=38008
tested by DragImageTest
* platform/chromium/DragImageChromiumSkia.cpp:
(WebCore::dissolveDragImageToFraction):implement
(WebCore::createDragImageFromImage):deep copy instead of shallow
2010-05-01 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
REGRESSION (r58273): Visited links do not change color immediately when Cmd-clicked
https://bugs.webkit.org/show_bug.cgi?id=38422
<rdar://problem/7921778>
Tests:
manual-tests/visited-link-new-window.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initElement): Only cache the visited link state
when invoked as part of a helper call to styleForElement or pseudoStyleForElement,
to avoid caching the visited link state beyond the scope of a single style lookup.
(WebCore::CSSStyleSelector::styleForElement): Adjust for above change.
(WebCore::CSSStyleSelector::pseudoStyleForElement): Adjust for above change.
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::styleForElement): Change so "visited link helper mode"
can't accidentally be called from outside CSSStyleSelector itself.
(WebCore::CSSStyleSelector::pseudoStyleForElement): ditto
* manual-tests/visited-link-new-window.html: Added. I could not figure out any way
to make an automated test that supports visited link coloring.
2010-05-01 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Move number parsing code out of HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=38203
The numebr parsing code follows HTML5 parsing rules and should be available outside of HTMLInputElement.
No new tests as no new functionality was introduced.
* html/HTMLInputElement.cpp:
* html/HTMLInputElement.h:
* html/HTMLParser.cpp:
(WebCore::serializeForNumberType):
(WebCore::parseToDoubleForNumberType):
* html/HTMLParser.h:
* html/StepRange.cpp:
(WebCore::StepRange::clampValue):
(WebCore::StepRange::valueFromElement):
* html/ValidityState.cpp:
(WebCore::ValidityState::typeMismatch):
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::setValueForPosition):
2010-05-01 Xan Lopez <xlopez@igalia.com>
Reviewed by Oliver Hunt.
[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590
Unify more logic to skip functions into SkipFunction, and
whitelist the two [Custom] methods in HTMLCollection.idl.
* bindings/scripts/CodeGeneratorGObject.pm:
2010-05-01 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Add smart paste support
https://bugs.webkit.org/show_bug.cgi?id=38136
* WebCore.pro:
* editing/qt/SmartReplaceQt.cpp: Added.
(WebCore::isCharacterSmartReplaceExempt):
* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::canSmartReplace):
2010-04-30 Yoshiki Hayashi <yhayashi@google.com>
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=38249
Fixes an issue where border height and padding height are ignored when computing vertically shrinking flexbox's height.
Test: fast/flexbox/child-flexing.html
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::allowedChildFlex):
2010-04-30 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Add layoutTestController.setPrinting()
https://bugs.webkit.org/show_bug.cgi?id=37203
Use the renderer's width insteead of screen's width as the width of
a screen depends on machines.
* rendering/RenderTreeAsText.cpp:
(WebCore::externalRepresentation):
2010-04-30 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Timothy Hatcher.
Web Inspector: Missing INSPECTOR Guard in Console::lastWMLErrorMessage
https://bugs.webkit.org/show_bug.cgi?id=38366
Console::lastWMLErrorMessage is only available if WML is enabled, however
its implementation only makes sense as long as INSPECTOR is enabled
as well. So this adds the ENABLE(INSPECTOR) guard in the function. A
browser without ENABLE(INSPECTOR) will always get an empty result.
* page/Console.cpp:
2010-04-28 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Oliver Hunt.
REGRESSION(r58313): Regression evident in pixel tests: the search icon is always clipped at the bottom.
https://bugs.webkit.org/show_bug.cgi?id=38253
Test: fast/css/input-search-padding.html
An <input type="search"> contains an inner block, which is explicitly
centered in RenderTextControlSingleLine based on the height of the element.
However, the clipping rect was not using the set location, and instead
calculated off of the top border and padding alone. This also vertically
centers the Caps Lock indicator.
* rendering/RenderTextControl.cpp: moved controlClipRect implementation to RenderTextControlSingleLine
* rendering/RenderTextControl.h: allow a subclass implementation of controlClipRect, removed redundant hasControlClip implementation, and moved controlClipRect
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::paint): vertically center the Caps Lock indicator
(WebCore::RenderTextControlSingleLine::controlClipRect): use the set location of the anonymous inner block instead
* rendering/RenderTextControlSingleLine.h: allow for an implementation of controlClipRect for <input type="search">
2010-04-30 Jon Honeycutt <jhoneycutt@apple.com>
Caret may fail to blink if a focus handler brings up a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=38372
Reviewed by Darin Adler.
* manual-tests/onfocus-alert-blinking-caret.html: Added.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
Moved the call to setCaretBlinkingSuspended() from here...
(WebCore::EventHandler::handleMousePressEvent):
... to here. This makes us suspend caret blinking before dispatching the
mouse down event. If dispatching the mouse down event allows the message
loop to run, we want mouse up events received in that message loop to be
able to resume caret blinking.
(WebCore::EventHandler::lostMouseCapture):
We've lost mouse capture and won't be notified of mouse up events;
resume caret blinking.
* page/EventHandler.h:
Declare lostMouseCapture().
2010-04-30 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, build fix.
[Chromium] Added a simple IdentifierRep struct and removed dependency on
IdentifierRep.h.
* bindings/v8/V8NPObject.cpp: Added simple IdentifierRep struct.
2010-04-30 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, build fix.
[Chromium] Remove bridge/ from include paths.
* WebCore.gyp/WebCore.gyp: Removed bridge/ from include path.
2010-04-30 Abhishek Arya <inferno@chromium.org>
Reviewed by David Kilzer.
Convert m_documentUnderMouse, m_dragInitiator to RefPtr.
Eliminated unused m_dragInitiator accessor to prevent dereferencing.
https://bugs.webkit.org/show_bug.cgi?id=37618
Test: editing/pasteboard/drag-drop-iframe-refresh-crash.html
* page/DragController.cpp:
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):
* page/DragController.h:
(WebCore::DragController::draggingImageURL):
(WebCore::DragController::documentUnderMouse):
2010-04-29 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Calls FrameView::scrollPositionChanged whenever a ScrollView is scrolled
https://bugs.webkit.org/show_bug.cgi?id=38286
When a ScrollView's scroll position is changed, we have to call
FrameView::scrollPositionChanged to generate repaint invalidation for
fixed position elements. This ends up getting called indirectly when
the ScrollView has a platformWidget through the port layer
(see WebHTMLView.mm's _frameOrBoundsChanged method for how the mac
port does it) but not when there is no platformWidget.
This is tested by the fast/repaint/fixed-* tests when run in pixel
mode.
Test: fast/repaint/fixed-move-after-keyboard-scroll.html
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::valueChanged):
* platform/ScrollView.h:
(WebCore::ScrollView::scrollPositionChanged):
2010-04-30 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Use C99 integer types in more places.
* manual-tests/NPN_Invoke/main.c:
(NPP_New):
(NPP_NewStream):
(NPP_WriteReady):
(NPP_Write):
(NPP_HandleEvent):
(functionPointerForTVector):
* plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::handlePostReadFile):
2010-04-30 Darin Adler <darin@apple.com>
Reviewed by Oliver Hunt.
Remove unused scrollRectIntoViewRecursively function
https://bugs.webkit.org/show_bug.cgi?id=38403
* page/Chrome.cpp:
(WebCore::Chrome::scrollRectIntoView): Moved comment here that was previously
in the scrollRectIntoViewRecursively function.
* platform/ScrollView.cpp: Get rid scrollRectIntoViewRecursively.
* platform/ScrollView.h: Ditto. Fix comment that refers to the two functions.
Also correct all uses of the term "method" to use the C++ term "function" and
got rid of double spaces after periods.
2010-04-30 Anders Carlsson <andersca@apple.com>
Another Qt build fix.
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::platformGetValueStatic):
2010-04-30 Anders Carlsson <andersca@apple.com>
Add back TRUE, FALSE and NULL macros. They were not meant to be removed!
* bridge/npapi.h:
2010-04-30 Anders Carlsson <andersca@apple.com>
Try to fix the Qt build this time.
* plugins/qt/PluginPackageQt.cpp:
(WebCore::staticPluginQuirkRequiresGtkToolKit_NPN_GetValue):
(WebCore::PluginPackage::NPVersion):
2010-04-30 Anders Carlsson <andersca@apple.com>
Yet another build fix.
* plugins/gtk/PluginPackageGtk.cpp:
(WebCore::PluginPackage::NPVersion):
2010-04-30 Anders Carlsson <andersca@apple.com>
Fix build.
* bridge/npapi.h:
2010-04-30 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
[chromium] Add WebFileSystem interface and hook up with all FileSystem methods.
https://bugs.webkit.org/show_bug.cgi?id=38228
* platform/chromium/ChromiumBridge.h:
* platform/chromium/FileSystemChromium.cpp:
(WebCore::openFile):
(WebCore::closeFile):
(WebCore::seekFile):
(WebCore::truncateFile):
(WebCore::readFromFile):
(WebCore::writeToFile):
2010-04-30 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Final part of
https://bugs.webkit.org/show_bug.cgi?id=20784
move npapi.h to C99 integer types
* bridge/npapi.h:
Remove the old types.
2010-04-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r58569.
http://trac.webkit.org/changeset/58569
https://bugs.webkit.org/show_bug.cgi?id=38399
This broke the GTK bots due to bad GC behavior (Requested by
ericu on #webkit).
* bindings/js/JSWorkerContextCustom.cpp:
* bindings/v8/custom/V8WorkerContextCustom.cpp:
* storage/Database.idl:
* storage/SQLError.idl:
* storage/SQLResultSet.idl:
* storage/SQLResultSetRowList.idl:
* storage/SQLTransaction.idl:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::openDatabase):
* workers/WorkerContext.h:
(WebCore::WorkerContext::databaseExceededQuota):
* workers/WorkerContext.idl:
2010-04-30 Anders Carlsson <andersca@apple.com>
Fix GTK+ build.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::handlePostReadFile):
(WebCore::PluginView::platformGetValueStatic):
2010-04-30 Anders Carlsson <andersca@apple.com>
Fix Qt build.
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::handlePostReadFile):
(WebCore::PluginView::platformGetValue):
2010-04-30 Anders Carlsson <andersca@apple.com>
Reviewed by Timothy Hatcher.
Next step towards fixing
https://bugs.webkit.org/show_bug.cgi?id=20784
move npapi.h to C99 integer types
Use the C99 types everywhere. The "old" types are still around but will be removed
in a subsequent commit.
* bridge/npapi.h:
(_NPCocoaEvent::):
* plugins/PluginPackage.h:
* plugins/PluginStream.cpp:
(WebCore::PluginStream::deliverData):
* plugins/PluginStream.h:
* plugins/PluginView.cpp:
(WebCore::PluginView::postURLNotify):
(WebCore::PluginView::postURL):
(WebCore::PluginView::write):
(WebCore::PluginView::handlePost):
* plugins/PluginView.h:
* plugins/PluginViewNone.cpp:
(WebCore::PluginView::handlePostReadFile):
* plugins/npapi.cpp:
(NPN_MemAlloc):
(NPN_MemFlush):
(NPN_PostURLNotify):
(NPN_PostURL):
(NPN_Write):
* plugins/npfunctions.h:
* plugins/win/PluginPackageWin.cpp:
(WebCore::PluginPackage::NPVersion):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::handlePostReadFile):
2010-04-30 Peter Kasting <pkasting@google.com>
Reviewed by David Levin.
Make all image decoders set the "failed" bit if an image could not be
completely decoded, but no more data is coming. The ICO and BMP
decoders already did this.
https://bugs.webkit.org/show_bug.cgi?id=35411
"Failed" does not cause the image to not be displayed, it simply causes
us to not bother to try to decode again if future requests are made, and
for some decoders, lets the decoder clean up some of its temporary
objects.
No layout tests because this does not change the visible output of decoding in any way.
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::frameComplete): Return whether the frame could be marked as complete.
(WebCore::GIFImageDecoder::decode): Fail if read() needs more data (and thus returns false) and no more is coming.
* platform/image-decoders/gif/GIFImageDecoder.h:
* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::do_lzw): Instead of returning true for buffer underrun and false for failure, return false for both and set the failure flag on failure.
(GIFImageReader::read): Ditto.
* platform/image-decoders/gif/GIFImageReader.h:
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::):
(WebCore::JPEGImageReader::decode): See do_lzw() comment above.
(WebCore::JPEGImageDecoder::decode): Fail if decode() needs more data (and thus returns false) and no more is coming.
* platform/image-decoders/jpeg/JPEGImageDecoder.h:
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageReader::decode): Return true for decode success, false for buffer underrun or decode failure, and set the failure flag on decode failure.
(WebCore::PNGImageDecoder::decode): See JPEGImageDecoder::decode() comment above.
* platform/image-decoders/png/PNGImageDecoder.h:
2010-04-30 Brady Eidson <beidson@apple.com>
Reviewed by Eric Carlson.
<rdar://problem/7902467> - Audio plays upon loading of npr.org but shouldn't
No new tests. (Currently no way to test such site specific hack behavior)
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::asyncEventTimerFired): If the event to be dispatched is the canplay
event, wrap the dispatch with m_dispatchingCanPlayEvent set.
(WebCore::HTMLMediaElement::play): If m_dispatchingCanPlayEvent is true and the site is npr.org,
don't perform the play().
* html/HTMLMediaElement.h: Add m_dispatchingCanPlayEvent member.
2010-04-30 Dan Bernstein <mitz@apple.com>
Reviewed by Adele Peterson.
Part of <rdar://problem/6649734> Text repainting does not account for glyphs which draw outside the typographic bounds of the font
https://bugs.webkit.org/show_bug.cgi?id=6274
Account for glyph overflow of characters in the range U+1E00..U+2000, but without sending them
through the complex text code path. Instead, introduce a variant of the fast path that tracks
glyph overflow.
* platform/graphics/Font.cpp:
(WebCore::Font::drawText): Use codePath().
(WebCore::Font::floatWidth): Use codePath(). Pass the GlyphOverflow pointer through to
floatWidthForSimpleText() if the code path is SimpleWithGlyphOverflow.
(WebCore::Font::selectionRectForText): Use codePath().
(WebCore::Font::offsetForPosition): Ditto.
* platform/graphics/Font.h: Replaced canUseGlyphCache() with codePath(). Added a GlyphOverflow
parameter to floatWidthForSimpleText().
* platform/graphics/FontFastPath.cpp:
Removed ROMAN_AND_GREEK_DIACRITICS_CAN_USE_GLYPH_CACHE.
(WebCore::Font::codePath): Renamed canUseGlyphCache() to this. Where it used to return false,
it now returns Complex. Where it used to return true, it now returns Simple, except for
the range U+1E00..U+2000, where it now returns SimpleWithGlyphOverflow.
(WebCore::Font::floatWidthForSimpleText): Added a GlyphOverflow parameter. If not 0, have the
width iterator account for glyph bounds, then update the GlyphOverflow accordingly.
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator): Added boolean parameter telling the width iterator
whether to account for glyph bounds. Initialize m_accountForGlyphBounds accordingly. Initialize
m_maxGlyphBoundingBoxY, m_minGlyphBoundingBoxY, m_firstGlyphOverflow and m_lastGlyphOverflow.
(WebCore::WidthIterator::advance): If accounting for glyph bounds, update the above member variables.
* platform/graphics/WidthIterator.h:
(WebCore::WidthIterator::maxGlyphBoundingBoxY): Added this accessor.
(WebCore::WidthIterator::minGlyphBoundingBoxY): Ditto.
(WebCore::WidthIterator::firstGlyphOverflow): Ditto.
(WebCore::WidthIterator::lastGlyphOverflow): Ditto.
2010-04-30 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Reversed the order of the CSSMatrix.multiply method
https://bugs.webkit.org/show_bug.cgi?id=38337
Test: transforms/svg-vs-css.xhtml
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::multiply):
* platform/graphics/transforms/TransformationMatrix.cpp:
2010-04-30 Kevin Ollivier <kevino@theolliviers.com>
Unreviewed. Attempt to fix the Chromium Mac build after the last commit.
* WebCore.gypi:
2010-04-30 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Dan Bernstein.
Allow other ports to compile ATSUI and CoreText functions in SimpleFontData for Mac.
https://bugs.webkit.org/show_bug.cgi?id=38334
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/mac/SimpleFontDataATSUI.mm: Copied from WebCore/platform/graphics/mac/SimpleFontDataMac.mm.
* platform/graphics/mac/SimpleFontDataCoreText.cpp: Copied from WebCore/platform/graphics/mac/SimpleFontDataMac.mm.
* platform/graphics/mac/SimpleFontDataMac.mm:
2010-04-30 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Simon Fraser.
SHOULD NEVER BE REACHED assertion loading forbes.com
https://bugs.webkit.org/show_bug.cgi?id=38272
Ignore page media related pseudo classes.
Test: printing/pseudo-class-outside-page.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
2010-04-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed, build fix.
Fix compiler warning "suggest parentheses around"
No new tests as there is no new functionality.
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateFromAndToValues):
2010-04-30 Kent Tamura <tkent@chromium.org>
Unreviewed. Regression fix.
Revert a part of r58564 to be compatible with prior behavior
https://bugs.webkit.org/show_bug.cgi?id=38383
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::forwardEvent):
r58564 made a region check for the cancel button stricter, but it
made some tests failing on Chromium. So, relax the check again.
2010-04-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Change StorageEvent.uri to StorageEvent.url to match the spec
https://bugs.webkit.org/show_bug.cgi?id=38331
As I mentioned in http://www.mail-archive.com/public-webapps@w3.org/msg08495.html
WebKit is the only one who places the document's URL in a 'uri' property
rather than a 'url' property. Even though we've shipped several versions of
browsers with the old name, we probably should change this to comply with the
spec.
This stuff is covered by existing tests.
* storage/StorageEvent.cpp:
(WebCore::StorageEvent::create):
(WebCore::StorageEvent::StorageEvent):
(WebCore::StorageEvent::initStorageEvent):
* storage/StorageEvent.h:
(WebCore::StorageEvent::url):
* storage/StorageEvent.idl:
2010-04-30 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
REGRESSION: RenderPath does not handle repaints correctly anymore if bounds changed
https://bugs.webkit.org/show_bug.cgi?id=38385
The last SVG performance patch broke repainting if bounds of a RenderPath get smaller.
It would only repaint the smaller part, not the original larger bounds.
Remove all lazy calculation of the repaint rects, instead calculate object/strokeBoundingBox and repaintRectInLocalCoordinates
once in layout - after LayoutRepainter grabbed the initial bounds, before calling repaintAfterLayout(). We can now inline
all these functions, and save a lot of m_path.isEmpty() checks, which are expensive. No need to store a seperated markerBoundingBox(),
combine with strokeBoundingBox() -> save one FloatRect per RenderPath. Move strokeBoundingBox() from SVGRenderBase to RenderObject,
right next to objectBoundingBox() - to save unnecessary toSVGRenderBase() calls. Completly remove this method.
Overall this is a regression fix, a performance improvement and saves memory. Something for everyone.
Tests: svg/custom/repaint-stroke-width-changes.svg
* rendering/RenderObject.cpp: Added strokeBoundingBox() here, to avoid the toSVGRenderBase() dance.
(WebCore::RenderObject::strokeBoundingBox):
* rendering/RenderObject.h: Ditto.
* rendering/RenderPath.cpp:
(WebCore::RenderPath::RenderPath):
(WebCore::RenderPath::layout): Fix regression, do repainting correctly, by recalculating the boundaries, if needed, instead of nulling them.
(WebCore::RenderPath::paint): Cache SVGRenderStyle in local variable, remove no longer valid FIXME.
(WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Return a FloatRect, to avoid having to store the marker bounding box seperated.
(WebCore::RenderPath::styleWillChange): Mark boundaries as dirty.
(WebCore::RenderPath::updateCachedBoundaries): New function to (re-)calculate all cached boundaries, only called from layout().
* rendering/RenderPath.h: Rename cached rect variables to have more sensible names.
(WebCore::RenderPath::objectBoundingBox): Inlined, just returns the cached value - no more lazy creation. Huge speedup as this is hot code.
(WebCore::RenderPath::strokeBoundingBox): Ditto.
(WebCore::RenderPath::repaintRectInLocalCoordinates): Ditto.
* rendering/RenderSVGBlock.h: Remove toSVGRenderBase() method.
* rendering/RenderSVGImage.h: Ditto.
* rendering/RenderSVGInline.cpp: No need to call toSVGRenderBase() just to get the strokeBoundingBox(). Unifies code to retrieve bounding boxes.
(WebCore::RenderSVGInline::strokeBoundingBox):
* rendering/RenderSVGInline.h: Remove toSVGRenderBase() method.
* rendering/RenderSVGModelObject.h: Ditto.
* rendering/RenderSVGResourceFilter.cpp: No need to call toSVGRenderBase() anymore, just grab the strokeBoundingBox() from the RenderObject.
(WebCore::RenderSVGResourceFilter::applyResource):
* rendering/RenderSVGText.h: Remove toSVGRenderBase() method.
* rendering/SVGRenderSupport.h: Ditto. Remove markerBoundingBox() method, now combined with strokeBoundingBox().
(WebCore::SVGRenderBase::strokeBoundingBox):
* rendering/SVGRootInlineBox.h: Remove toSVGRenderBase() method.
* rendering/style/SVGRenderStyle.h: Add hasMarkers() helper method, to avoid doing unnecessary work in RenderPath.
(WebCore::SVGRenderStyle::hasMarkers):
2010-04-30 Eric Uhrhane <ericu@chromium.org>
Reviewed by Dmitry Titov.
Add bindings for async DB API in Workers.
https://bugs.webkit.org/show_bug.cgi?id=34992
Tests: storage/change-version-handle-reuse-worker.html
storage/execute-sql-args-worker.html
* bindings/js/JSWorkerContextCustom.cpp: Add openDatabase binding.
(WebCore::JSWorkerContext::openDatabase):
* bindings/v8/custom/V8WorkerContextCustom.cpp: Add openDatabase stub; Chromium will need work both in V8 and in the browser process before we can turn this on there.
(WebCore::V8WorkerContext::openDatabaseCallback):
Add NoStaticTables flags to all objects now shared with workers.
* storage/Database.idl:
* storage/SQLError.idl:
* storage/SQLResultSet.idl:
* storage/SQLResultSetRowList.idl:
* storage/SQLTransaction.idl:
* workers/WorkerContext.h: Add databaseExceededQuota.
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::databaseExceededQuota): Add stub implementation for testing; you just get 5MB for now.
(WebCore::WorkerContext::openDatabase): Remove invalid assertion.
Add the IDL for the call to openDatabase.
* workers/WorkerContext.idl:
2010-04-30 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Unnecessary PrintContext::end() calls
https://bugs.webkit.org/show_bug.cgi?id=38247
Refactoring only, so no new tests.
* page/PrintContext.cpp:
(WebCore::PrintContext::pageNumberForElement):
(WebCore::PrintContext::numberOfPages):
2010-04-30 Kent Tamura <tkent@chromium.org>
Reviewed by Adele Peterson.
Implement interactive behavior of spin buttons.
https://bugs.webkit.org/show_bug.cgi?id=35686
Introduce SpinButtonElement. It is a shadow element class for
spin buttons. If the upper side of the element is clicked, calls
HTMLInputElement::stepUpFromRenderer(1). If the lower button is
clicked, calls HTMLInputElement::stepUpFromRenderer(-1).
SpinButtonElement tracks the mouse pointer position, and
RenderTheme sets ControlStates::SpinUpState if the pointer is on
the upper side.
Test: platform/mac/fast/forms/input-number-click.html
* dom/Element.h:
(WebCore::Element::isSpinButtonElement):
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
Remove an assertion. lastEditablePositionBeforePositionInRoot() can
return null in a case that m_end is at a shadow element (a spin button)
and baseRoot is another shadow element (inner text block) in the same
node (an INPUT element).
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::stepUpFromRenderer):
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::hasSpinButton):
Add types supporting step attribute except RANGE.
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::nodeAtPoint):
(WebCore::RenderTextControlSingleLine::forwardEvent):
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
* rendering/RenderTextControlSingleLine.h:
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::controlStatesForRenderer):
(WebCore::RenderTheme::isSpinUpButtonPartPressed):
(WebCore::RenderTheme::isSpinUpButtonPartHovered):
* rendering/RenderTheme.h:
* rendering/TextControlInnerElements.cpp:
(WebCore::SpinButtonElement::SpinButtonElement):
(WebCore::SpinButtonElement::defaultEventHandler):
* rendering/TextControlInnerElements.h:
(WebCore::SpinButtonElement::isSpinButtonElement):
(WebCore::SpinButtonElement::isEnabledFormControl):
(WebCore::SpinButtonElement::onUpButton):
2010-04-30 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enable DOMWindow constructor for HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=38333
Add ENABLE_PROGRESS_TAG to FEATURES_DEFINES_JAVASCRIPT.
* WebCore.pri:
2010-04-30 Kent Tamura <tkent@chromium.org>
Reviewed by Adele Peterson.
Mac implementation of outer-spin-button appearance, and anonymous
element generation for <input type=number>.
https://bugs.webkit.org/show_bug.cgi?id=32813
The implementation uses NSStepperCell. Like the other Mac
controls, it has only three candidates for sizes.
The editable block of an input element is shrunk, and the
anonymous block for a spin button is put on the right of the
editable block.
Tests: platform/mac/fast/forms/input-appearance-spinbutton-size.html
platform/mac/fast/forms/input-appearance-spinbutton.html
* dom/Element.cpp:
(WebCore::Element::pseudoStyleCacheIsInvalid):
* dom/InputElement.h:
(WebCore::InputElement::hasSpinButton):
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::hasSpinButton): Return true for NUMBER type.
* platform/mac/ThemeMac.mm:
(WebCore::sizeFromNSControlSize): Split the main part of sizeFromFont()
to this in order to use stepperControlSizeForFont() instead of
controlSizeForFont().
(WebCore::sizeFromFont): Just calls sizeFromNSControlSize() with
sizeFromFont(). No behavior changes.
(WebCore::stepperSizes): Returns sizes for mini, small, and regular.
(WebCore::stepperControlSizeForFont):
Dedicated version of controlSizeForFont().
(WebCore::stepper): Returns NSStepperCell object with specified settings.
(WebCore::paintStepper):
(WebCore::ThemeMac::controlSize): Support for OuterSpinButton.
(WebCore::ThemeMac::minimumControlSize): ditto.
(WebCore::ThemeMac::inflateControlPaintRect): ditto.
(WebCore::ThemeMac::paint): ditto.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations):
Move the content to paintBoxDecorationsWithSize().
(WebCore::RenderBox::paintBoxDecorationsWithSize):
* rendering/RenderBox.h: Declare paintBoxDecorationsWithSize().
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::paintBoxDecorations):
Call paintBoxDecorationsWithSize() with smaller width by decorationWidthRight().
(WebCore::RenderTextControlSingleLine::addFocusRingRects):
Add a rectangle of which width is smaller by decorationWidthRight().
(WebCore::RenderTextControlSingleLine::layout):
Adjust m_outerSpinButton position.
(WebCore::RenderTextControlSingleLine::styleDidChange):
(WebCore::RenderTextControlSingleLine::textBlockWidth):
(WebCore::RenderTextControlSingleLine::decorationWidthRight):
(WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight):
(WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
Creates an element for m_outerSpinButton if it is needed.
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
(WebCore::RenderTextControlSingleLine::createOuterSpinButtonStyle):
* rendering/RenderTextControlSingleLine.h: Declare new methods and m_outerSpinButton.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustRepaintRect): Support for OuterSpinButton.
2010-04-29 Adam Barth <abarth@webkit.org>
Unreviewed. Update JSC CodeGenerator baseline. Not sure how I missed
this one earlier.
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
2010-04-29 Justin Garcia <justin.garcia@apple.com>
Reviewed by Adele Peterson.
Need to updateLayout after typing commands too
https://bugs.webkit.org/show_bug.cgi?id=38352
Replaced !m_parent checks in EditCommand.cpp by the more descriptive isTopLevelCommand().
Move the post editing operation updateLayout() call to {un,re}appliedEditing so that text insertions,
which don't go through EditCommand::{un,re}apply() can benefit from it too. No test case possible
since most platforms have a layout performed as a side effect of post operation selection code.
* editing/EditCommand.cpp:
(WebCore::EditCommand::apply):
(WebCore::EditCommand::unapply):
(WebCore::EditCommand::reapply):
* editing/EditCommand.h:
(WebCore::EditCommand::isTopLevelCommand):
* editing/Editor.cpp:
(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):
2010-04-29 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7918086> REGRESSION (r57820): Controller is not displayed in window when opening a MP3 file in browser window
https://bugs.webkit.org/show_bug.cgi?id=38350
Tests: media/audio-only-video-intrinsic-size.html
media/media-document-audio-size.html
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::RenderVideo): Until metadata is available, ignore the natural size
reported by the player.
(WebCore::RenderVideo::videoSizeChanged): Respect a natural size of zero if reported by the
player, except in standalone media documents.
2010-04-29 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
First part of
https://bugs.webkit.org/show_bug.cgi?id=20784
move npapi.h to C99 integer types.
Add nptypes.h to the build.
* WebCore.xcodeproj/project.pbxproj:
* bridge/npapi.h:
* bridge/npruntime.h:
* bridge/nptypes.h: Added.
2010-04-29 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Adam Barth.
Update GObject bindings test results. We are actually moving
backwards here, but we'll update them again when we figure out
what broke.
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
2010-04-29 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fix for https://bugs.webkit.org/show_bug.cgi?id=38277
MiniBrowser: -[WebCoreFlippedView currentEditor]: unrecognized selector
* platform/mac/ThemeMac.mm:
(-[WebCoreFlippedView currentEditor]): Added currentEditor nil implementation.
2010-04-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CodeGeneratorJS.pm should be consistent about castedThis versus castedThisObj
https://bugs.webkit.org/show_bug.cgi?id=38338
Currently CodeGeneratorJS.pm uses castThis for methods and
castedThisObj for attributes. This inconsistency makes it difficult to
factor common code genereration code into methods shared by both kinds
of bindings. This match aligns the names so that a future patch (e.g.,
in https://bugs.webkit.org/show_bug.cgi?id=38313) can reduce copy/paste
code.
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjIntAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjTestObjAttr):
(WebCore::setJSTestObjAttrWithException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::jsTestObjPrototypeFunctionVoidMethod):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethod):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethod):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithException):
(WebCore::jsTestObjPrototypeFunctionCustomMethod):
(WebCore::jsTestObjPrototypeFunctionCustomMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrame):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObj):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
2010-04-29 Gustavo Noronha Silva <gustavo.noronhaollabora.co.uk>
Reviewed by Xan Lopez.
[GTK] pointerCursor should use the default cursor set for the window, not GDK_LEFT_PTR
https://bugs.webkit.org/show_bug.cgi?id=36963
Use the default cursor instead of hard-coding left pointer.
* platform/gtk/CursorGtk.cpp:
(WebCore::Cursor::Cursor):
(WebCore::pointerCursor):
2010-04-29 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: If Timeline panel is in recording mode and is not visible and has received
new events then these events do not appear in the panel when the panel becomes visible.
Timeline popup may appear in the upper left window corner when you switch to another panel.
https://bugs.webkit.org/show_bug.cgi?id=38322
* inspector/front-end/Popover.js:
(WebInspector.PopoverHelper.prototype._mouseMove.doHide):
(WebInspector.PopoverHelper.prototype._mouseMove):
(WebInspector.PopoverHelper.prototype.hidePopup):
(WebInspector.PopoverHelper.prototype._hidePopup):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.show):
(WebInspector.TimelinePanel.prototype._scheduleRefresh):
(WebInspector.TimelinePanel.prototype._refresh):
2010-04-29 Anton Muhin <antonm@chromium.org>
Reviewed by Darin Adler.
Let's cache nodelists instead of DynamicNodeList::Caches
https://bugs.webkit.org/show_bug.cgi?id=33696
Test: fast/dom/Element/node-list-identity.html
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::markChildren): Mark all cached node lists as well
* dom/ClassNodeList.cpp:
(WebCore::ClassNodeList::ClassNodeList): Don't need DynamicNodeList::Caches argument any more
(WebCore::ClassNodeList::~ClassNodeList): Remove from the cache
* dom/ClassNodeList.h: Added a field with original class names to be used as a key for removal from the cache
(WebCore::ClassNodeList::create): Don't need DynamicNodeList::Caches argument any more
* dom/NameNodeList.cpp:
(WebCore::NameNodeList::NameNodeList): Don't need DynamicNodeList::Caches argument any more
(WebCore::NameNodeList::~NameNodeList): Remove from the cache
* dom/NameNodeList.h:
(WebCore::NameNodeList::create): Don't need DynamicNodeList::Caches argument any more
* dom/Node.cpp:
(WebCore::Node::removeCachedClassNodeList): Remove ClassNodeList from the cache
(WebCore::Node::removeCachedNameNodeList): Remove NameNodeList from the cache
(WebCore::Node::removeCachedTagNodeList): Remove TagNodeList from the cache
(WebCore::Node::getElementsByTagNameNS): Switch to caching node lists themselves, not the data
(WebCore::Node::getElementsByName): Switch to caching node lists themselves, not the data
(WebCore::Node::getElementsByClassName): Switch to caching node lists themselves, not the data
(WebCore::NodeListsNodeData::invalidateCaches): Switch to caching node lists themselves, not the data
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes): Switch to caching node lists themselves, not the data
(WebCore::NodeListsNodeData::isEmpty): Switch to caching node lists themselves, not the data
(WebCore::markNodeLists): Helper to mark all the node lists in the cache
(WebCore::Node::markCachedNodeListsSlow): Mark all the cached node lists if any could be present
* dom/Node.h:
(WebCore::Node::markCachedNodeLists): Fast-path marking of cached node lists---bails out if there is no rare data
* dom/NodeRareData.h: Changed type of caches to hold raw pointers to node lists, not RefPtr's to data
* dom/TagNodeList.cpp:
(WebCore::TagNodeList::TagNodeList): Don't need DynamicNodeList::Caches argument any more
(WebCore::TagNodeList::~TagNodeList): Remove from the cache
* dom/TagNodeList.h:
(WebCore::TagNodeList::create): Don't need DynamicNodeList::Caches argument any more
2010-04-29 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
[Chromium] Update ScriptProfileNode to retrieve execution time in milliseconds.
https://bugs.webkit.org/show_bug.cgi?id=38330
* bindings/v8/ScriptProfileNode.cpp:
(WebCore::ScriptProfileNode::totalTime):
(WebCore::ScriptProfileNode::selfTime):
2010-04-28 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
A form without a submit button unexpectedly performs its action when Return is pressed
https://bugs.webkit.org/show_bug.cgi?id=9756
Implemented implicit form submission algorithm as defined in HTML5 spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#implicit-submission,
falling back to match IE's behavior in the edge cases.
The underlying rules are:
* If the form has no enabled submit buttons, submit if Enter/Return is pressed on the only single-line text field.
* Otherwise, submit form using first enabled submit button if Enter/Return is pressed on a field
that's not a textarea or a select.
Test: fast/forms/implicit-submission.html
* dom/SelectElement.cpp:
(WebCore::SelectElement::menuListDefaultEventHandler): Ripped out implicit submission for select elements.
(WebCore::SelectElement::listBoxDefaultEventHandler): Ditto.
(WebCore::SelectElement::defaultEventHandler): Ditto.
* dom/SelectElement.h: Ditto.
(WebCore::HTMLFormElement::submitImplicitly): Renamed submitClick to submitImplicitly to better match HTML5 spec
language, changed the logic to match the rules above.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler): Reamed clickDefaultButton to implicitSubmission to better match
HTML5 spec language, made radio element to trigger implicit submission.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::defaultEventHandler): Removed passing of form() as parameter, because it's no longer
necessary.
2010-04-29 Paweł Hajdan, Jr. <phajdan.jr@chromium.org>
Reviewed by Jeremy Orlow.
Fix building with libpng-1.4.
https://bugs.webkit.org/show_bug.cgi?id=33287
No new tests (no behavior change).
Original patch by John Bowler <jbowler@acm.org>
* platform/image-encoders/skia/PNGImageEncoder.cpp:
(WebCore::PNGImageEncoder::encode):
2010-04-29 Adam Langley <agl@chromium.org>
Reviewed by David Levin.
This patch adds support for WOFF in Chromium. Since Chromium
already transcodes all OpenType files for security reasons we
are adding WOFF support into the transcoder.
https://bugs.webkit.org/show_bug.cgi?id=38217
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::isSupportedFormat):
Recognise "woff" as a font-face format value (guarded by
ENABLE(OPENTYPE_SANITIZER) at this point)
* platform/graphics/opentype/OpenTypeSanitizer.cpp:
(WebCore::OpenTypeSanitizer::sanitize):
Change so that the transcoded font can be larger than the original.
(WOFF files are compressed, so the transcoded TTF is typically
larger.)
2010-04-29 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Updates to the Qt build to enable building MathML support.
* WebCore.pri:
* WebCore.pro:
2010-04-29 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590
Do not generate unneeded boilerplate in {get,set}_property methods
when there are no properties to generate code for. This gets rid
of lots of compiler warnings.
* bindings/scripts/CodeGeneratorGObject.pm:
2010-04-29 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Speed up text layouting
https://bugs.webkit.org/show_bug.cgi?id=31719
Use QFontMetrics::width() for the text width calculation instead
of QTextLayout. This avoids expensive bearing calculations and the
line breaking code.
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::floatWidthForComplexText):
2010-04-29 Kwang Yul Seo <skyul@company100.net>
Reviewed by Simon Hausmann.
[WINCE] Export g_stackBase with JS_EXPORTDATA
https://bugs.webkit.org/show_bug.cgi?id=37437
Declare g_stackBase with JS_EXPORTDATA as it is imported from JavaScriptCore.
* platform/wince/SharedTimerWince.cpp:
2010-04-29 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Remove custom bindings for PopStateEvent.initPopStateEvent
https://bugs.webkit.org/show_bug.cgi?id=38311
Our code generation of SerializedScriptValue was slightly buggy, but
it's easy to fix. Notice that the conversion to an atomic string is
handled by the C++ type system and doesn't require logic in the code
generator.
* bindings/js/JSPopStateEventCustom.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_serialized_value):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj serializedValue:]):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::serializedValueCallback):
(WebCore::ConfigureV8TestObjTemplate):
* bindings/v8/custom/V8PopStateEventCustom.cpp:
* dom/PopStateEvent.idl:
2010-04-29 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix a bug that selection drag-and-drop doesn't work for input/textarea.
https://bugs.webkit.org/show_bug.cgi?id=38175
The code supposed the selected region was in the destination text
field. It is not true in a case of drag-and-drop.
Test: editing/pasteboard/drag-drop-input-textarea.html
* dom/InputElement.cpp:
(WebCore::InputElement::handleBeforeTextInsertedEvent):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
2010-04-29 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Remove custom bindings for NodeFilter.acceptNode
https://bugs.webkit.org/show_bug.cgi?id=38309
This "custom" code was just an instance of the CallWith=ScriptState
pattern. Also, it looks like V8 just had a garbage implemenation that
did nothing.
* WebCore.gypi:
* bindings/js/JSNodeFilterCustom.cpp:
* bindings/v8/custom/V8NodeFilterCustom.cpp: Removed.
* dom/NodeFilter.idl:
2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] QtWebkit doesn't link with 3D canvas
https://bugs.webkit.org/show_bug.cgi?id=38299
Added implementation for GraphicsContext3D::isGLES2Compliant, which returns the correct value based on a Qt #define.
No new tests: build fix
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::isGLES2Compliant):
2010-04-29 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] REGRESSION(r57638): tst_qwebframe::objectDeleted() fails
https://bugs.webkit.org/show_bug.cgi?id=38316
Accessing properties of a deleted objects doesn't throw an exception
anymore.
Continue to expose the QObject class wrapper for objects that
previously existed but don't exist anymore. QtClass is safe to
use with a deleted QObject.
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::getClass): Return null only if m_class
doesn't exist yet and there's no m_object.
2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Simon Hausmann.
Reverse animations don't work in some use cases
https://bugs.webkit.org/show_bug.cgi?id=38075
This was due to a code path special-casing reverse animations, that became obselete when we aligned our animation code
with the CA implementation. That special case code path is now a bug - and this patch removes it.
http://staff.washington.edu/fmf/2009/03/25/iphone-3d-css-transformations/ now runs the reverse
animation correctly.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::TransformAnimationQt::applyFrame):
2010-04-29 Jan Hanssen <jhanssen@codeaurora.org>
Reviewed by Adam Barth.
HTMLOptionElement::ownerSelectElement() needs to consider keygen elements
https://bugs.webkit.org/show_bug.cgi?id=26016
Patch written by Grace Kloba <klobag@gmail.com>, test fixed by me.
Test: fast/dom/HTMLKeygenElement/keygen-option-select.html
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::ownerSelectElement):
Make HTMLOptionElement::ownerSelectElement() consider the keygen element in addition to the current select element.
2010-04-29 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Reviewed by Eric Seidel.
Add EFL-specific code to Widget.h and move the empty
frameRectsChanged() definition to Widget.cpp, since the EFL port
needs to override that.
http://webkit.org/b/36317
No new tests required.
* WebCore.base.exp:
* platform/Widget.cpp:
(WebCore::Widget::frameRectsChanged):
* platform/Widget.h:
2010-04-29 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Simon Hausmann.
[Qt] GraphicsContext3DQt.cpp does not implement isGLES2Compliant()
https://bugs.webkit.org/show_bug.cgi?id=38216
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::isGLES2Compliant):
2010-04-29 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Remove the unnecessary texImage2D function with Image as input in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=38235
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::texImage2D): Add extractImageData; add a common entry point for texImage2D with image input.
(WebCore::WebGLRenderingContext::texImage2DBase): Add this function as the common entry point for texImage2D.
(WebCore::WebGLRenderingContext::texSubImage2D): Add extractImageData; add a common entry point for texSubImage2D with image input.
(WebCore::WebGLRenderingContext::texSubImage2DBase): Add this function as the common entry point for texSubImage2D.
* html/canvas/WebGLRenderingContext.h: Add tex*Image{Base/Image} function declaration.
* platform/graphics/GraphicsContext3D.h: Remove tex*Image declaration with Image input.
* platform/graphics/mac/GraphicsContext3DMac.cpp: Remove tex*Image implementation with Image input.
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::texSubImage2D):
2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Simon Hausmann.
[Qt] GraphicsLayer: flicker when starting an animation before the previous one ended.
https://bugs.webkit.org/show_bug.cgi?id=38076
This was due to the cude in the removeAnimations functions, which called deleteLater() without stopping the
animation synchronously. The delay between the call to that function and the actual call to the animation's destructor
is when the flicker occured. We fix this by calling stop() synchronously, and making sure that the value is reverted
upon stop (updateState) and not upon the object's destruction.
http://staff.washington.edu/fmf/2009/03/25/iphone-3d-css-transformations/ now doesn't flicker when
the animation is toggled frequently.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::TransformAnimationQt::~TransformAnimationQt):
(WebCore::TransformAnimationQt::applyFrame):
(WebCore::TransformAnimationQt::updateState):
(WebCore::OpacityAnimationQt::~OpacityAnimationQt):
(WebCore::OpacityAnimationQt::updateState):
(WebCore::GraphicsLayerQt::removeAnimationsForProperty):
(WebCore::GraphicsLayerQt::removeAnimationsForKeyframes):
2010-04-28 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Simon Fraser.
Media queries empty values
https://bugs.webkit.org/show_bug.cgi?id=38116
Adding isValid() method to MediaQueryExp to make it possible to differentiate
between queries with empty values and queries with invalid values.
Test: fast/media/media-query-invalid-value.html
* css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::eval):
* css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::MediaQueryExp):
* css/MediaQueryExp.h:
(WebCore::MediaQueryExp::isValid):
2010-04-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Allow editing script resources when resource tracking is enabled.
https://bugs.webkit.org/show_bug.cgi?id=38269
* inspector/front-end/ScriptView.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.canEditScripts):
(WebInspector.ScriptsPanel.prototype.editScriptSource):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.get textModel):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView):
(WebInspector.SourceView.prototype._addBreakpoint):
(WebInspector.SourceView.prototype._editLine):
(WebInspector.SourceView.prototype._editLineComplete):
(WebInspector.SourceView.prototype._sourceIDForLine):
2010-04-25 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Darin Adler.
Clicking a scrollbar blurs the currently focused element
https://bugs.webkit.org/show_bug.cgi?id=16809
WebKit ports that do not use native (platform) widgets for rendering the scrollbars
are currently mismatching a common behaviour of other browser vendors (including
Firefox and Opera): clicking on a frame scrollbar *should not* steal focus from content.
WebKit browsers based ports that do use WebCore for handling scrollbars, like QtWebKit for
instance, can observe the opposite behaviour.
Patch fixes this behaviour by checking if current MouseDown event targets a frame scrollbar.
If that is the case, it bails out and do not change focus behavior at all.
It is important to note that the given way this is implemented by this patch, non-frame
scrollbars (e.g. a vertical scrollbar of an overflowed textareas or divs) will keep working
in the same way as it works currently.
Tests: scrollbars/scrollbar-click-does-not-blur-content.html
scrollbars/scrollbar-iframe-click-does-not-blur-content.html
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchMouseEvent):
2010-04-28 Dan Bernstein <mitz@apple.com>
Rubber-stamped by Maciej Stachowiak.
Try to fix test failures seen on the Leopard build bot after r58467
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::platformGlyphInit): Initialize m_zeroWidthSpaceGlyph before
calling widthForGlyph(), as the latter uses the former.
2010-04-28 Martin Robinson <mrobinson@webkit.org>
Reviewed by Gustavo Noronha.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Make ClipboardGtk a "live" DataTransfer object, able to modify
the clipboard when setData(...) is called.
* platform/gtk/ClipboardGtk.cpp:
(WebCore::Editor::newGeneralClipboard): Pass the GtkClipboard into the factory method.
(WebCore::ClipboardGtk::ClipboardGtk): Create two separate constructors, one for DnD data and one for clipboard data.
(WebCore::dataObjectTypeFromHTMLClipboardType): Added.
(WebCore::ClipboardGtk::clearData): Clear the member DataObject, optionally write the clipboard.
(WebCore::ClipboardGtk::clearAllData): Ditto.
(WebCore::joinURIList): Added.
(WebCore::ClipboardGtk::getData): Get the data from the clipboard, if possible.
(WebCore::ClipboardGtk::setData): Write data to the DataObject and maybe the clipboard.
(WebCore::ClipboardGtk::types): Read the clipboard/DataObject to find applicable types.
(WebCore::ClipboardGtk::files): Read the clipboard/DataObject to find the files.
(WebCore::ClipboardGtk::writeURL): Write to the DataObject and maybe the clipboard.
(WebCore::ClipboardGtk::writeRange): Ditto.
(WebCore::ClipboardGtk::writePlainText): Ditto.
(WebCore::ClipboardGtk::hasData): Query the clipboard/DataObject.
* platform/gtk/ClipboardGtk.h:
(WebCore::ClipboardGtk::create): Added one factory for pasteboard-backed DataObjects and one for DnD-backed objects.
* platform/gtk/DataObjectGtk.cpp:
(WebCore::replaceNonBreakingSpaceWithSpace): Added this helper function to clean from plain text.
(WebCore::DataObjectGtk::markup): Actually return the range if it's set.
(WebCore::DataObjectGtk::setText): Clean from plain text.
(WebCore::DataObjectGtk::clearText): Added.
(WebCore::DataObjectGtk::clearMarkup): Added.
* platform/gtk/DataObjectGtk.h:
(WebCore::DataObjectGtk::clearURIList): Added.
(WebCore::DataObjectGtk::clearImage): Added.
* platform/gtk/PasteboardHelper.cpp:
(WebCore::PasteboardHelper::initializeTargetList): Added target ID's for URI list and Netscape URL targets.
(WebCore::urisToKURLVector): Added.
(WebCore::PasteboardHelper::getClipboardContents): Added.
(WebCore::PasteboardHelper::fillSelectionData): Added logic for URI lists and Netscape URLs.
(WebCore::PasteboardHelper::targetListForDataObject): Ditto.
* platform/gtk/PasteboardHelper.h: Added default argument to writeClipboardContents and new method.
2010-04-28 Martin Robinson <mrobinson@webkit.org>
Reviewed by Gustavo Noronha.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Use the length of the UTF-8 markup data in bytes when filling GtkSelectionData.
No new tests, because pasteboard DataTransfer tests will be enabled
with the completion of the GTK+ DataTransfer object.
* platform/gtk/PasteboardGtk.cpp:
(WebCore::clipboard_get_contents_cb): Use strlen here instead of g_utf8_strlen.
2010-04-28 Dan Bernstein <mitz@apple.com>
Reviewed by Adele Peterson.
More of <rdar://problem/7855777> REGRESSION: Memory usage increase caused by storing glyph bounds in GlyphMetricsMap
https://bugs.webkit.org/show_bug.cgi?id=37936
Assigning zero width and empty bounds to the ZERO WIDTH SPACE glyph often allocates a width map
page and a bounds map page for the glyph, each of which pages contains 255 unused entries. Save
this space by not storing the zero width and empty bounds in the metrics maps.
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData): Initialize m_zeroWidthSpaceGlyph.
(WebCore::SimpleFontData::platformGlyphInit): Set m_zeroWidthSpaceGlyph. Don’t create entries
for the ZERO WIDTH SPACE glyph in the width map and in the bounds map.
* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::boundsForGlyph): Return empty bounds for the ZERO WIDTH SPACE glyph
without consulting the bounds map.
(WebCore::SimpleFontData::widthForGlyph): Return zero for the ZERO WIDTH SPACE glyph without
consulting the width map.
2010-04-28 Mark Rowe <mrowe@apple.com>
Reviewed by Adele Peterson.
<rdar://problem/7847573> Safari welcome page logs JavaScript exception during page load
The Safari welcome page runs afoul of the same-origin restriction on access to stylesheet rules
that was added to address <https://bugs.webkit.org/show_bug.cgi?id=20527>. To work around this we're
adding a temporary site-specific quirk that relaxes this restriction for the particular cross-origin
access that occurs on the Safari welcome page.
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::cssRules):
2010-04-28 Mike Thole <mthole@apple.com>
Reviewed by Mark Rowe.
Add separate exports file for symbols dependent on WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK.
* DerivedSources.make: Updated for WebCore.ProtectionSpaceAuthCallback.exp.
* WebCore.ProtectionSpaceAuthCallback.exp: Added.
* WebCore.xcodeproj/project.pbxproj:
2010-04-28 Evan Martin <evan@chromium.org>
Reviewed by David Levin.
[chromium] revert getFontDataForCharacters change in r58341
https://bugs.webkit.org/show_bug.cgi?id=38288
It caused a performance regression.
* platform/chromium/ChromiumBridge.h:
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getFontDataForCharacters):
2010-04-28 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r58441.
http://trac.webkit.org/changeset/58441
https://bugs.webkit.org/show_bug.cgi?id=37618
Broke 3 test on Qt.
* page/DragController.cpp:
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):
* page/DragController.h:
(WebCore::DragController::setDragInitiator):
(WebCore::DragController::dragInitiator):
(WebCore::DragController::documentUnderMouse):
2010-04-28 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
Remove some obsolete scrolling code
https://bugs.webkit.org/show_bug.cgi?id=38293
* page/Chrome.cpp:
(WebCore::Chrome::scrollRectIntoView): Removed ScrollView* argument.
* page/Chrome.h: Made scrollRectIntoView non-virtual, and removed ScrollView* argument.
* page/FrameView.cpp: Removed scrollRectIntoViewRecursively.
* page/FrameView.h: Removed scrollRectIntoViewRecursively and made
setScrollPosition non-virtual, since there is no class derived from
this class, and ScrollView's setScrollPosition is non-virtual.
* platform/HostWindow.h: Removed scrollRectIntoView.
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollRectIntoViewRecursively): Updated comment
since I was able to do most of the tasks listed here.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible): Removed 0 passed for
ScrollView* argument to Chrome::scrollRectIntoView.
2010-04-28 Mike Thole <mthole@apple.com>
Reviewed by David Kilzer.
Add canAuthenticateAgainstProtectionSpace() to frame loader so that a protection space
can be inspected before attempting to authenticate against it
https://bugs.webkit.org/show_bug.cgi?id=38271
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::canAuthenticateAgainstProtectionSpace): Added.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::canAuthenticateAgainstProtectionSpace): Added.
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace): Added.
* loader/ResourceLoader.h:
(WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace): Added.
* platform/network/ProtectionSpace.h:
(WebCore::):
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::canAuthenticateAgainstProtectionSpace): Added.
* platform/network/mac/AuthenticationMac.mm:
(WebCore::mac):
Add cases for case ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested and
ProtectionSpaceAuthenticationSchemeClientCertificateRequested. Guarded with the
#if USE(PROTECTION_SPACE_AUTH_CALLBACK) as the new NSURLProtectionSpace constants don't
exist prior to Mac OS X 10.6.
(WebCore::core): Ditto.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace): Added.
(-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): Added.
2010-04-28 Abhishek Arya <inferno@chromium.org>
Reviewed by Eric Seidel.
Convert m_documentUnderMouse, m_dragInitiator to RefPtr.
Eliminated unused m_dragInitiator accessor to prevent dereferencing.
https://bugs.webkit.org/show_bug.cgi?id=37618
Test: editing/pasteboard/drag-drop-iframe-refresh-crash.html
* page/DragController.cpp:
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):
* page/DragController.h:
(WebCore::DragController::draggingImageURL):
(WebCore::DragController::documentUnderMouse):
2010-04-28 Dumitru Daniliuc <dumi@chromium.org>
Unreviewed, fixing a build problem introduced by the previous patch.
* storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::openDatabaseSync):
2010-04-23 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Jeremy Orlow.
Adding some required classes for the sync WebSQLDatabases API.
https://bugs.webkit.org/show_bug.cgi?id=34994
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* storage/DatabaseSync.cpp: Added.
(WebCore::DatabaseSync::databaseInfoTableName):
(WebCore::DatabaseSync::setIsAvailable):
(WebCore::DatabaseSync::isAvailable):
(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::DatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::version):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::transaction):
* storage/DatabaseSync.h: Added.
(WebCore::DatabaseSync::databaseDebugName):
* storage/SQLTransactionSync.cpp: Added.
(WebCore::SQLTransactionSync::create):
(WebCore::SQLTransactionSync::SQLTransactionSync):
(WebCore::SQLTransactionSync::~SQLTransactionSync):
(WebCore::SQLTransactionSync::executeSQL):
* storage/SQLTransactionSync.h: Added.
(WebCore::SQLTransactionSync::database):
(WebCore::SQLTransactionSync::isReadOnly):
* storage/SQLTransactionSyncCallback.h: Added.
(WebCore::SQLTransactionSyncCallback::~SQLTransactionSyncCallback):
2010-04-28 İsmail Dönmez <ismail@namtrac.org>
Reviewed by Simon Hausmann.
Fix compilation with QT_NO_CURSOR defined.
* platform/qt/QWebPageClient.h:
(QWebPageClient::resetCursor):
(QWebPageClient::setCursor):
2010-04-28 Abhishek Arya <inferno@chromium.org>
Reviewed by Alexey Proskuryakov.
Added a check to make sure that resources from a different https origin are not cached.
https://bugs.webkit.org/show_bug.cgi?id=33456
Test: http/tests/appcache/different-https-origin-resource-main.html
* loader/appcache/ManifestParser.cpp:
(WebCore::parseManifest):
2010-04-28 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Only set -allowable_client WebKit2 for engineering builds on SnowLeopard
and later.
* Configurations/WebCore.xcconfig:
2010-04-28 Darin Adler <darin@apple.com>
Reviewed by Adele Peterson.
REGRESSION: Autoscroll does not work in Mail messages
https://bugs.webkit.org/show_bug.cgi?id=38267
rdar://problem/7559799
Still haven't figured out a good way to test this with DumpRenderTree
or with Safari. Testing has to be done with Mail for now.
The machinery to make autoscrolling work on Mac OS X when a WebView is embedded in another
view had gotten broken in multiple ways. For some reason, a combination of bugs made it
partly work until around r48064. This brings it back.
There were three problems:
1) Code in EventHandler decided there was nothing to scroll, so didn't start
the autoscroll timer.
2) The wrong rectangle was passed to Chrome::scrollRectIntoView.
3) The Mac WebKit implementation of ChromeClient::scrollRectIntoView did incorrect
coordinate conversion.
I verified that none of these have any effect on regression tests, or behavior in
web browsers, or behavior on platforms other than Mac.
* page/EventHandler.cpp:
(WebCore::canAutoscroll): Added. Returns true for boxes that can scroll directly
and for the top level box of the top frame.
(WebCore::EventHandler::handleMouseDraggedEvent): Use canAutoscroll.
(WebCore::EventHandler::updateAutoscrollRenderer): Ditto.
* page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor): Fixed comment.
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollRectIntoViewRecursively): Put ASSERT_NOT_REACHED into this
now-unused function along with some comments about removing some obsolete code.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible): Removed call to scrollRectIntoViewRecursively
since from the WebKit point of view this is the topmost scroll view anyway. Instead call
setScrollPosition. Moved the code to call Chrome::scrollRectIntoView here since it needs
to use a different rectangle anyway.
2010-04-21 Ojan Vafai <ojan@chromium.org>
Reviewed by Adele Peterson.
http://trac.webkit.org/changeset/57215 caused perf/memory regressions
https://bugs.webkit.org/show_bug.cgi?id=37292
#if out the canUseGlyphCache Changes from r57215 as they caused a
8% perf regression on Chromium's international page load tests so that
the perf regression can be fixed properly without being left in the tree.
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::canUseGlyphCache):
2010-04-28 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/7474349>
Add a synchronous display mechanism for WKCACFLayerRenderer.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::setRootContentsAndDisplay): This is
just like setRootContents(), but it calls paint() instead of
renderSoon().
* platform/graphics/win/WKCACFLayerRenderer.h:
2010-04-28 Dmitry Titov <dimich@chromium.org>
Reviewed by Geoffrey Garen.
REGRESSION: fast/workers/wrapper-map-gc.html crashes on Snow Leopard Release Bot
https://bugs.webkit.org/show_bug.cgi?id=37554
The flaky fast/workers/wrapper-map-gc.html will stop being flaky.
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
check if JS execution was terminated, as in cases of Worker.terminate() or WorkerGlobalScope.close().
* bindings/js/JSWorkerContextBase.cpp:
(WebCore::toJS): ASSERT the value of workerContextWrapper, it should never be 0.
* bindings/js/WorkerScriptController.h:
(WebCore::WorkerScriptController::workerContextWrapper): remove returning 0 if JS execution was forbidden.
(WebCore::WorkerScriptController::isExecutionForbidden):
* bindings/v8/WorkerScriptController.h:
(WebCore::WorkerScriptController::isExecutionForbidden):
Add ScriptExecutionContext::isJSExecutionTerminated(), it is always 'false' for Document
and 'true' for WorkerContext when script is terminated.
* dom/ScriptExecutionContext.h:
* dom/Document.h:
(WebCore::Document::isJSExecutionTerminated):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::isJSExecutionTerminated):
* workers/WorkerContext.h:
2010-04-28 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: Multiple Main Resource Content Loaded marks appear in Resource panel.
https://bugs.webkit.org/show_bug.cgi?id=38270
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):
2010-04-28 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: Timeline: We can have precise urls in the EvaluateScript records.
https://bugs.webkit.org/show_bug.cgi?id=38264
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
2010-04-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Linkify node and function in the event listeners panel.
https://bugs.webkit.org/show_bug.cgi?id=38251
* bindings/js/ScriptEventListener.cpp:
(WebCore::eventListenerHandlerBody):
(WebCore::eventListenerHandlerLocation):
* bindings/js/ScriptEventListener.h:
* bindings/v8/ScriptEventListener.cpp:
(WebCore::eventListenerHandlerBody):
(WebCore::eventListenerHandlerLocation):
* bindings/v8/ScriptEventListener.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.linkifyNodeReference):
(WebInspector.ElementsPanel.prototype.linkifyNodeReference.preventDefault):
* inspector/front-end/EventListenersSidebarPane.js:
(WebInspector.EventListenersSidebarPane.prototype.update.callback):
(WebInspector.EventListenersSidebarPane.prototype.update):
():
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
* inspector/front-end/inspector.css:
(.node-link):
2010-04-28 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Alexey Proskuryakov.
[XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR
https://bugs.webkit.org/show_bug.cgi?id=37781
<rdar://problem/7905150>
Tests: http/tests/xmlhttprequest/access-control-preflight-credential-async.html
http/tests/xmlhttprequest/access-control-preflight-credential-sync.html
Rolling the patch in as I could not reproduce Qt results locally.
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Now we remove the
credential from the request here to avoid forgetting to do so in the different code path.
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Just add the
"Origin" header.
(WebCore::DocumentThreadableLoader::loadRequest): Check here the the credential have
been removed so that we don't leak them. Also tweaked a comment to make it clear that
the URL check has issue when credential is involved.
2010-04-28 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsLayer: preserves-3d and backface visibility
https://bugs.webkit.org/show_bug.cgi?id=35312
Implement preserves-3d by maintaining the 3D transformation heirarchy inside GraphicsLayerQt, and extrapolating
the relative QTransform. When the extrapolation fails (un-invertible matrix) we ignore the transformation change.
WebKitSite/blog-files/3d-transforms test now work with Qt.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::updateTransform):
(WebCore::GraphicsLayerQtImpl::opaqueArea):
(WebCore::GraphicsLayerQtImpl::boundingRect):
(WebCore::GraphicsLayerQtImpl::paint):
(WebCore::GraphicsLayerQtImpl::flushChanges):
2010-04-28 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: View frame selector for Timeline overview panel is redesigned a bit.
Now it is possible to adjust view frame by resizer bars and by click-n-drag in overview pane.
https://bugs.webkit.org/show_bug.cgi?id=38251
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.reset):
(WebInspector.TimelineOverviewPane.prototype._dragWindow):
(WebInspector.TimelineOverviewPane.prototype._windowSelectorDragging):
(WebInspector.TimelineOverviewPane.prototype._endWindowSelectorDragging):
(WebInspector.TimelineOverviewPane.prototype._resizeWindowLeft):
(WebInspector.TimelineOverviewPane.prototype._resizeWindowRight):
(WebInspector.TimelineOverviewPane.prototype._setWindowPosition):
(WebInspector.TimelinePanel.WindowSelector):
(WebInspector.TimelinePanel.WindowSelector.prototype._createSelectorElement):
(WebInspector.TimelinePanel.WindowSelector.prototype._close):
(WebInspector.TimelinePanel.WindowSelector.prototype._updatePosition):
* inspector/front-end/inspector.css:
(#timeline-overview-grid):
(.timeline-window-selector):
(#timeline-overview-window):
(.timeline-overview-dividers-background):
(.timeline-overview-window-rulers):
(.timeline-window-resizer):
2010-04-28 Marcus Bulach <bulach@chromium.org>
Reviewed by Jeremy Orlow.
Reverts 58340 (https://bugs.webkit.org/show_bug.cgi?id=38158) due to regression on fast/text/international/khmer-selection.html
https://bugs.webkit.org/show_bug.cgi?id=38254
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::adjustTextRenderMode):
(WebCore::TextRunWalker::getTextRun):
(WebCore::TextRunWalker::getNormalizedTextRun):
(WebCore::TextRunWalker::setGlyphXPositions):
(WebCore::glyphIndexForXPositionInScriptRun):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::setupPaint):
* platform/graphics/chromium/HarfbuzzSkia.cpp:
(WebCore::getOutlinePoint):
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::getImageData):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::isCoordinateSkiaSafe):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):
2010-04-28 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Log error message to inspector console if a resource fails to load.
Disable checking of mime-type consistency for failed resources.
https://bugs.webkit.org/show_bug.cgi?id=37215
Test: http/tests/inspector/console-resource-errors.html
* inspector/InspectorController.cpp:
(WebCore::InspectorController::didReceiveResponse):
(WebCore::InspectorController::didFailLoading):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
2010-04-28 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Support pause on exceptions in v8 implementation of ScriptDebugServer.
https://bugs.webkit.org/show_bug.cgi?id=38205
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::addListener):
(WebCore::ScriptDebugServer::pauseOnExceptionsState):
(WebCore::ScriptDebugServer::setPauseOnExceptionsState):
(WebCore::ScriptDebugServer::currentCallFrame):
(WebCore::ScriptDebugServer::handleV8DebugMessage):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
* bindings/v8/ScriptDebugServer.h:
2010-04-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r58313.
http://trac.webkit.org/changeset/58313
https://bugs.webkit.org/show_bug.cgi?id=38253
Regression evident in pixel tests: the search icon is always
clipped at the bottom. (Requested by jorlow on #webkit).
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::controlClipRect):
* rendering/RenderTextControl.h:
(WebCore::RenderTextControl::hasControlClip):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::paint):
* rendering/RenderTextControlSingleLine.h:
2010-04-28 Justin McPherson <justin.mcpherson@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix detection of Qt 4.7's multimedia libraries
QtMultimedia has been split into an additional media services library, which
we're using. mediaservices depends on multimedia.
* WebCore.pro:
2010-04-28 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed attempt to fix the chromium build.
Add layoutTestController.setPrinting()
https://bugs.webkit.org/show_bug.cgi?id=37203
* rendering/RenderTreeAsText.cpp:
2010-04-27 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler and Eric Seidel.
Add layoutTestController.setPrinting()
https://bugs.webkit.org/show_bug.cgi?id=37203
Added RenderAsTextPrintingMode as a behavior of externalRepresentation.
Now ~PrintContext() calls end() automatically.
* page/PrintContext.cpp:
(WebCore::PrintContext::~PrintContext):
* rendering/RenderTreeAsText.cpp:
(WebCore::externalRepresentation):
* rendering/RenderTreeAsText.h:
(WebCore::):
2010-04-27 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
Enhance CSS parser for Paged Media (Iteration 4)
Implement page property parsing as specified at http://dev.w3.org/csswg/css3-page/#using-named-pages.
https://bugs.webkit.org/show_bug.cgi?id=35853
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parsePage):
* css/CSSParser.h:
2010-04-27 Yuzo Fujishima <yuzo@google.com>
Reviewed by Dimitri Glazkov.
Enhance CSS parser for Paged Media (Iteration 3)
Implement size parameter parsing for Paged Media.
https://bugs.webkit.org/show_bug.cgi?id=35851
I believe size property hasn't been used so far because (1) it hasn't been properly parsed and
(2) a comment in CSSComputedStyleDeclaration::getPropertyCSSValue says so.
Changing the way of parsing it should not cause any regressions -- no existing tests fail because of this change.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSize):
(WebCore::CSSParser::parseSizeParameter):
* css/CSSParser.h:
(WebCore::CSSParser::):
* css/CSSValueKeywords.in:
2010-04-27 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
Enhance CSS parser for Paged Media (Iteration 2)
Parse and hold paged media rules in CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=35782
Test: printing/page-rule-css-text.html
* css/CSSGrammar.y:
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::CSSPageRule):
(WebCore::CSSPageRule::selectorText):
* css/CSSPageRule.h:
(WebCore::CSSPageRule::create):
(WebCore::CSSPageRule::isPageRule):
* css/CSSParser.cpp:
(WebCore::CSSParser::createPageRule):
* css/CSSStyleRule.h:
* css/CSSStyleSelector.cpp:
(WebCore::CSSRuleSet::getPageRules):
(WebCore::CSSRuleSet::CSSRuleSet):
(WebCore::CSSRuleSet::~CSSRuleSet):
(WebCore::CSSRuleSet::addPageRule):
(WebCore::CSSRuleSet::addRulesFromSheet):
* css/CSSStyleSelector.h:
* css/StyleBase.h:
(WebCore::StyleBase::isPageRule):
2010-04-27 Daniel Bates <dbates@rim.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=37686
Fixes an issue where the canvas method strokeRect will stroke a
rectangle whose dimensions are 0 when lineWidth > 1.
As per the definition of strokeRect in the HTML Canvas 2D Context
spec. <http://www.w3.org/TR/2dcontext/#dom-context-2d-strokerect>,
this method should have no effect when both the height and width
are zero.
Tests: fast/canvas/canvas-clearRect.html
fast/canvas/canvas-fillRect.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::validateRectForCanvas): Return false if height, width == 0.
2010-04-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove obsolete custom bindings file
https://bugs.webkit.org/show_bug.cgi?id=38223
We don't need these files anymore because they are empty.
* Android.jscbindings.mk:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSAbstractWorkerCustom.cpp: Removed.
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDocumentFragmentCustom.cpp: Removed.
* bindings/js/JSEventSourceCustom.cpp: Removed.
2010-04-27 Daniel Cheng <dcheng@chromium.org>
Reviewed by Jian Li.
[Chromium] Filter out URLs with a file scheme from text/uri-list when dragging.
https://bugs.webkit.org/show_bug.cgi?id=38227
Unfortunately, the simple fix of not populating the drag data with file URLs doesn't work
since the default drop handling uses the drag data URL to navigate to dropped files/URLs.
For now, we hack around the problem in the Chromium platform, but the proper long term
solution is to change DragController::performDrag to check dragData::asFilenames().
No new tests.
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::types):
2010-04-27 Simon Fraser <simon.fraser@apple.com>
Reviewed by the inimitable Dan Bernstein.
SVG as background image renders incorrectly after zooming
https://bugs.webkit.org/show_bug.cgi?id=38215
When doing a partial redraw of an SVGImage used as a CSS background
image, we're limited to drawing the entire Frame, clipped to the dirty rect.
Because of this, we need to fix up the CTM so that the origin is at the
top left of the unclipped image, rather than the top left of the
portion being redrawn.
Test: fast/images/svg-background-partial-redraw.html
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::draw):
2010-04-27 Yuzo Fujishima <yuzo@google.com>
Reviewed by David Hyatt.
Retry of: Enhance CSS parser for Paged Media (Iteration 1)
In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
The contents of the methods should be implemented by other changes.
https://bugs.webkit.org/show_bug.cgi?id=35329
Test: fast/css/parsing-page-rule.html
* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::clearProperties):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createMarginAtRule):
(WebCore::CSSParser::startDeclarationsForMarginBox):
(WebCore::CSSParser::endDeclarationsForMarginBox):
* css/CSSParser.h:
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/tokenizer.flex:
2010-04-27 Julien Chaffraix <jchaffraix@webkit.org>
Unreviewed, rolling out my changes as it rendered the Qt bot unreliable.
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::loadRequest):
2010-04-27 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Alexey Proskuryakov.
[XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR
https://bugs.webkit.org/show_bug.cgi?id=37781
<rdar://problem/7905150>
Tests: http/tests/xmlhttprequest/access-control-preflight-credential-async.html
http/tests/xmlhttprequest/access-control-preflight-credential-sync.html
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Now we remove the
credential from the request here to avoid forgetting to do so in the different code path.
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Just add the
"Origin" header.
(WebCore::DocumentThreadableLoader::loadRequest): Check here the the credential have
been removed so that we don't leak them. Also tweaked a comment to make it clear that
the URL check has issue when credential is involved.
2010-04-27 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Fix for https://bugs.webkit.org/show_bug.cgi?id=38238
Allow both WebKit and WebKit2 to link to the same WebCore.framework
* Configurations/WebCore.xcconfig: Use -allowable_client WebKit2 to add
WebKit2 to the list of frameworks that can link directly to WebCore. It
is not necessary for it to be an umbrella since we don't need to reexport
any symbols.
2010-04-27 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by David Levin.
Turn on AUTO_VACUUM = INCREMENTAL for all HTML5 databases.
https://bugs.webkit.org/show_bug.cgi?id=38191
Vacuum all databases when the number of free pages is at least 10%
of the number of total pages. Also, add a guard against a bug that
was fixed in SQLite only starting with version 3.6.16.
* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::maximumSize):
(WebCore::SQLiteDatabase::freeSpaceSize):
(WebCore::SQLiteDatabase::totalSize):
(WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
(WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):
* platform/sql/SQLiteDatabase.h:
(WebCore::SQLiteDatabase::):
* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
(WebCore::SQLiteStatement::step):
* storage/Database.cpp:
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::incrementalVacuumIfNeeded):
* storage/Database.h:
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::postflightAndCommit):
2010-04-27 Garret Kelly <gdk@chromium.org>
Reviewed by Darin Fisher.
Turn all of the touch event handlers into RuntimeEnabledFeatures, and
modify the createEvent methond on Document so that it won't create a
TouchEvent if the feature is disabled.
https://bugs.webkit.org/show_bug.cgi?id=37485
* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::touchEnabled):
(WebCore::RuntimeEnabledFeatures::setTouchEnabled):
(WebCore::RuntimeEnabledFeatures::ontouchstartEnabled):
(WebCore::RuntimeEnabledFeatures::ontouchmoveEnabled):
(WebCore::RuntimeEnabledFeatures::ontouchendEnabled):
(WebCore::RuntimeEnabledFeatures::ontouchcancelEnabled):
* dom/Document.cpp:
(WebCore::Document::createEvent):
* dom/Document.idl:
* dom/Element.idl:
* page/DOMWindow.idl:
2010-04-27 Jens Alfke <snej@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Add some notifications and an accessor to WebKit API
https://bugs.webkit.org/show_bug.cgi?id=37625
* dom/Node.cpp:
(WebCore::Node::hasNonEmptyBoundingBox): New method.
* dom/Node.h:
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isKeyboardFocusable): Moved part of method into new Node method
2010-04-27 Jochen Eisinger <jochen@chromium.org>
Reviewed by Shinichiro Hamaji.
Fix gyp build on Mac OS X with enable_svg=0.
https://bugs.webkit.org/show_bug.cgi?id=38192
* WebCore.gyp/WebCore.gyp: Only generate SVG symbols if enable_svg!=0.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add missing unimplemented CSS properties to switch statement.
2010-04-27 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Jian Li.
[V8] Handle OR ('|') conditional in action_derivedsourcesallinone.py
https://bugs.webkit.org/show_bug.cgi?id=38207
No new tests.
* WebCore.gyp/scripts/action_derivedsourcesallinone.py:
2010-04-27 François Sausset <sausset@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
Implementation of the MathML mroot & msqrt elements.
https://bugs.webkit.org/show_bug.cgi?id=37044
Test: mathml/presentation/roots.xhtml
* WebCore.xcodeproj/project.pbxproj:
* css/mathml.css:
(mroot):
(mroot > * + *):
(mroot > * + mrow, mroot > * + mfenced):
* mathml/MathMLInlineContainerElement.cpp:
(WebCore::MathMLInlineContainerElement::createRenderer):
* mathml/RenderMathMLRoot.cpp: Added.
(WebCore::RenderMathMLRoot::RenderMathMLRoot):
(WebCore::RenderMathMLRoot::addChild):
(WebCore::RenderMathMLRoot::paint):
(WebCore::RenderMathMLRoot::layout):
* mathml/RenderMathMLRoot.h: Added.
* mathml/RenderMathMLSquareRoot.cpp: Added.
(WebCore::RenderMathMLSquareRoot::RenderMathMLSquareRoot):
(WebCore::RenderMathMLSquareRoot::paint):
(WebCore::RenderMathMLSquareRoot::layout):
* mathml/RenderMathMLSquareRoot.h: Added.
2010-04-27 Darin Adler <darin@apple.com>
Reviewed by Maciej Stachowiak.
I noticed an unused forwarding header.
* ForwardingHeaders/runtime/PropertyMap.h: Removed.
2010-04-27 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Fix gcc 4.4.1 warnings on Linux in the chromium V8 bindings code.
https://bugs.webkit.org/show_bug.cgi?id=38153
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::callFunction):
2010-04-27 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r58318.
http://trac.webkit.org/changeset/58318
https://bugs.webkit.org/show_bug.cgi?id=37215
Broke test on Tiger. Might just need updated results,
unclear.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::didReceiveResponse):
(WebCore::InspectorController::didFailLoading):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
2010-04-27 Evan Martin <evan@chromium.org>
Reviewed by David Levin.
[chromium] bold bengali text not rendered properly on Linux
https://bugs.webkit.org/show_bug.cgi?id=37904
We must let Skia do font fallback, rather than picking a font name
then handing that to Skia. For example, if we have Bengali text and
choose FreeSans + fake bold, and then later reuse the name, Skia will
helpfully use FreeSansBold (which doesn't cover Bengali).
Test: fast/text/international/bold-bengali.html
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getFontDataForCharacters):
2010-04-27 James Robinson <jamesr@chromium.org>
Reviewed by Darin Adler.
Fix warnings emitted by gcc 4.4.1 on linux in chromium-specific platform graphics files.
https://bugs.webkit.org/show_bug.cgi?id=38158
Most of the issues are signed/unsigned mismatches, but there are a few unusued variables
and functions mixed in.
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::adjustTextRenderMode):
(WebCore::TextRunWalker::getTextRun):
(WebCore::TextRunWalker::getNormalizedTextRun):
(WebCore::TextRunWalker::setGlyphXPositions):
(WebCore::glyphIndexForXPositionInScriptRun):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::setupPaint):
* platform/graphics/chromium/HarfbuzzSkia.cpp:
(WebCore::getOutlinePoint):
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::getImageData):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::isCoordinateSkiaSafe):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):
2010-04-27 Jian Li <jianli@chromium.org>
Reviewed by Darin Adler.
Sending a package file using FormData crashes WebKit on Mac.
https://bugs.webkit.org/show_bug.cgi?id=37882
Can't add a layout test because DRT does not support generating the file name.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::navigateToDifferentDocument):
* platform/network/FormData.cpp:
(WebCore::FormData::appendDOMFormData):
* platform/network/FormData.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
2010-04-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove custom NodeIterator bindings
https://bugs.webkit.org/show_bug.cgi?id=38188
Another example of CallWith=ScriptState. This case shows us the right
way to handle the interaction with exception codes.
In my previous patch, I put the exception code handling after the
ScriptState exception handling. It turns out this was a mistake
(although a harmless one at the time because no IDL caused us to
generate that code). Now that we're generating both kinds of exception
handling, we need to generate them in the right order.
* WebCore.gypi:
* bindings/js/JSNodeIteratorCustom.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_with_script_state_void_exception):
(webkit_dom_test_obj_with_script_state_obj_exception):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj withScriptStateVoidException]):
(-[DOMTestObj withScriptStateObjException]):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::withScriptStateVoidCallback):
(WebCore::TestObjInternal::withScriptStateObjCallback):
(WebCore::TestObjInternal::withScriptStateVoidExceptionCallback):
(WebCore::TestObjInternal::withScriptStateObjExceptionCallback):
(WebCore::):
* bindings/v8/custom/V8NodeIteratorCustom.cpp: Removed.
* dom/NodeIterator.idl:
2010-04-27 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Remove copy/paste addEventListener "custom" bindings via code generation
https://bugs.webkit.org/show_bug.cgi?id=38210
It's somewhat lame to special case addEventListener and
removeEventListener in the code generator, but it saves a large amount
of boilerplate "custom" bindings code.
Idea shamelessly stolen from the V8 code generator.
This patch points to some good refactoring opportunities in
CodeGeneratorJS.pm, but I'm going to hold off on those for a future
patch. By generating test coverage for the code generator, we make
these future refactorings easier.
* bindings/js/JSAbstractWorkerCustom.cpp:
* bindings/js/JSDOMApplicationCacheCustom.cpp:
* bindings/js/JSDesktopNotificationsCustom.cpp:
* bindings/js/JSEventSourceCustom.cpp:
* bindings/js/JSMessagePortCustom.cpp:
* bindings/js/JSNodeCustom.cpp:
* bindings/js/JSSVGElementInstanceCustom.cpp:
* bindings/js/JSWebSocketCustom.cpp:
* bindings/js/JSWorkerContextCustom.cpp:
* bindings/js/JSXMLHttpRequestCustom.cpp:
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj addEventListener:listener:useCapture:]):
(-[DOMTestObj removeEventListener:listener:useCapture:]):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::addEventListenerCallback):
(WebCore::TestObjInternal::removeEventListenerCallback):
(WebCore::):
* dom/MessagePort.idl:
* dom/Node.idl:
* loader/appcache/DOMApplicationCache.idl:
* notifications/Notification.idl:
* page/EventSource.idl:
* svg/SVGElementInstance.idl:
* websockets/WebSocket.idl:
* workers/AbstractWorker.idl:
* workers/WorkerContext.idl:
* xml/XMLHttpRequest.idl:
* xml/XMLHttpRequestUpload.idl:
2010-04-27 Sam Weinig <sam@webkit.org>
Rubber-stamped by Beth Dakin.
Remove now unnecessary EXPERIMENTAL_SINGLE_VIEW_MODE #define.
* page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clearDragState):
* page/EventHandler.h:
* page/mac/DragControllerMac.mm:
* page/mac/EventHandlerMac.mm:
* platform/mac/PopupMenuMac.mm:
2010-04-27 Ben Murdoch <benm@google.com>
Reviewed by Simon Hausmann.
The TouchStationary state of WebCore::PlatformTouchPoint is not handled inside the touch event handler.
https://bugs.webkit.org/show_bug.cgi?id=37609
No new tests required, only updating documentation.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): Improve the documentation for handling
the TouchStationary state as a result of discussions in bug 37609.
2010-04-27 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler, Maciej Stachowiak.
REGRESSION (r57919): Some pages opened in background tabs don't render the first time you activate their tab
https://bugs.webkit.org/show_bug.cgi?id=38183
Rather than sprinkle PLATFORM #ifdefs around, add a new method,
RenderLayerCompositor::shouldPropagateCompositingToIFrameParent(), that indicates whether
an iframe with composited content should trigger compositing mode in the enclosing document
(a behavior that differs between platforms).
Use this new method to determine whether to trigger a style recalc in the parent document
when an iframe becomes composited.
Move the code formerly in RenderView::compositingStateChanged() into RenderLayerCompositor().
* manual-tests/compositing/accel-comp-iframe-tab-repaint.html: Added.
* manual-tests/compositing/resources/flash-frame.html: Added.
* manual-tests/compositing/resources/tab-repaint-part-2.html: Added.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::enableCompositingMode):
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToIFrameParent):
(WebCore::RenderLayerCompositor::requiresCompositingForIFrame):
* rendering/RenderLayerCompositor.h:
* rendering/RenderView.cpp:
* rendering/RenderView.h:
2010-04-27 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Log error message to inspector console if a resource fails to load.
Disable checking of mime-type consistency for failed resources.
https://bugs.webkit.org/show_bug.cgi?id=37215
Test: http/tests/inspector/console-resource-errors.html
* inspector/InspectorController.cpp:
(WebCore::InspectorController::didReceiveResponse):
(WebCore::InspectorController::didFailLoading):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
2010-04-27 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Nate Chapin.
[V8] Fix XHR memory leak in GC controller.
https://bugs.webkit.org/show_bug.cgi?id=38202
http://trac.webkit.org/changeset/55798 simplified processing of
active DOM objects but introduced a subtle bug in garbage
collection of XHRs. ActiveDOMObject is not a direct base class of
XHR and so upcasting changes pointer identity and breaks DOM
maps. This leads to forever live persistent handles to XHR that
had pending activity while V8 GC happened.
* bindings/v8/V8GCController.cpp:
(WebCore::GCEpilogueVisitor::visitDOMWrapper):
2010-04-27 Adam Barth <abarth@webkit.org>
Unreviewed. Regenerate reference bindings code generator output.
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::withScriptStateVoidCallback):
(WebCore::TestObjInternal::withScriptStateObjCallback):
2010-04-27 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Dan Bernstein.
<input type="search"> with uneven padding causes text clipping
https://bugs.webkit.org/show_bug.cgi?id=38160
Test: fast/css/input-search-padding.html
An <input type="search"> contains an inner block, which is explicitly
centered in RenderTextControlSingleLine based on the height of the element.
However, the clipping rect was not using the set location, and instead
calculated off of the top border and padding alone. This also vertically
centers the Caps Lock indicator.
* rendering/RenderTextControl.cpp: moved controlClipRect implementation to RenderTextControlSingleLine
* rendering/RenderTextControl.h: allow a subclass implementation of controlClipRect, removed redundant hasControlClip implementation, and moved controlClipRect
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::paint): vertically center the Caps Lock indicator
(WebCore::RenderTextControlSingleLine::controlClipRect): use the set location of the anonymous inner block instead
* rendering/RenderTextControlSingleLine.h: allow for an implementation of controlClipRect for <input type="search">
2010-04-27 Thomas Zander <t.zander@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix linking on Symbian on Linux using the Makefile based mkspec.
Disable thumb mode due to library size limitations, just like it's done
for the sbs/sbsv2 based build system.
* WebCore.pro:
2010-04-21 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Make sure WebKit is not compiled using C++0x.
https://bugs.webkit.org/show_bug.cgi?id=37867
As the rest of Qt compiles in the C++0x mode, people might start
compiling it in this mode. WebKit don't support this yet.
Patch by Thiago Macieira <thiago.macieira@nokia.com>
* WebCore.pro:
2010-04-27 Jeremy Orlow <jorlow@chromium.org>
Unreviewed build fix.
Revert 58274 and 58269 (WebSQLDatabase changes)
https://bugs.webkit.org/show_bug.cgi?id=38191
Chromium bots are hitting ASSERTS when running layout tests.
* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::maximumSize):
(WebCore::SQLiteDatabase::freeSpaceSize):
* platform/sql/SQLiteDatabase.h:
* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
* storage/Database.cpp:
(WebCore::Database::performOpenAndVerify):
* storage/Database.h:
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::postflightAndCommit):
2010-04-27 Yuzo Fujishima <yuzo@google.com>
Unreviewed, fix build breakage by reverting r58299.
* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::clearProperties):
* css/CSSParser.h:
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/tokenizer.flex:
2010-04-27 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
WebCore::CSSSelector::RareData::parseNth doesn't check whether the search for '-' in the argument was successful.
This results in incorrect parsing.
For example, '3n' is parsed as if it were '3n-3'. The code has been working OK just accidentally.
https://bugs.webkit.org/show_bug.cgi?id=37787
No new tests are added because the original behavior is accidentally OK.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::RareData::parseNth):
2010-04-27 Yuzo Fujishima <yuzo@google.com>
Reviewed by David Hyatt.
Enhance CSS parser for Paged Media (Iteration 1)
In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
The contents of the methods should be implemented by other changes.
https://bugs.webkit.org/show_bug.cgi?id=35329
Test: fast/css/parsing-page-rule.html
* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::clearProperties):
(WebCore::CSSParser::lex):
(WebCore::CSSParser::text):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createMarginAtRule):
(WebCore::CSSParser::startDeclarationsForMarginBox):
(WebCore::CSSParser::endDeclarationsForMarginBox):
* css/CSSParser.h:
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/tokenizer.flex:
2010-04-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove custom bindings for TreeWalker
https://bugs.webkit.org/show_bug.cgi?id=38182
This custom code is just CallWith=ScriptState.
* WebCore.gypi:
* bindings/js/JSTreeWalkerCustom.cpp:
(WebCore::JSTreeWalker::markChildren):
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/TestObj.idl:
* bindings/v8/custom/V8TreeWalkerCustom.cpp: Removed.
* dom/TreeWalker.idl:
2010-04-27 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move code out of GenerateImplementation to make it more smaller
https://bugs.webkit.org/show_bug.cgi?id=38176
* bindings/scripts/CodeGeneratorJS.pm:
- Move some code into a new GenerateAttributesHashTable method.
2010-04-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add CallWith=DynamicFrame to CodeGenerator
https://bugs.webkit.org/show_bug.cgi?id=38174
I've only used this in one instance, but this is infrastructure that I
think will help remove a bunch of custom bindings code. Also, added a
few tests of tricky argument cases.
* bindings/js/JSHTMLFormElementCustom.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_with_dynamic_frame):
(webkit_dom_test_obj_with_dynamic_frame_and_arg):
(webkit_dom_test_obj_with_dynamic_frame_and_optional_arg):
(webkit_dom_test_obj_with_dynamic_frame_and_user_gesture):
(webkit_dom_test_obj_with_dynamic_frame_and_user_gesture_asad):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrame):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj withDynamicFrame]):
(-[DOMTestObj withDynamicFrameAndArg:]):
(-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
(-[DOMTestObj withDynamicFrameAndUserGesture:]):
(-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::withDynamicFrameCallback):
(WebCore::TestObjInternal::withDynamicFrameAndArgCallback):
(WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback):
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback):
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback):
(WebCore::):
* bindings/v8/custom/V8HTMLFormElementCustom.cpp:
* html/HTMLFormElement.idl:
2010-04-26 Adam Barth <abarth@webkit.org>
Unreviewed. Update comment to better reflect reality.
* bindings/scripts/test/TestObj.idl:
2010-04-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add ObjC and GObject to run-bindings-test
https://bugs.webkit.org/show_bug.cgi?id=38168
Added expected results.
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Added.
(WebKit::kit):
(webkit_dom_test_obj_void_method):
(webkit_dom_test_obj_void_method_with_args):
(webkit_dom_test_obj_int_method):
(webkit_dom_test_obj_int_method_with_args):
(webkit_dom_test_obj_obj_method):
(webkit_dom_test_obj_obj_method_with_args):
(webkit_dom_test_obj_method_with_exception):
(webkit_dom_test_obj_method_with_optional_arg):
(webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg):
(webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args):
(webkit_dom_test_obj_get_read_only_int_attr):
(webkit_dom_test_obj_get_read_only_string_attr):
(webkit_dom_test_obj_get_read_only_test_obj_attr):
(webkit_dom_test_obj_get_int_attr):
(webkit_dom_test_obj_set_int_attr):
(webkit_dom_test_obj_get_string_attr):
(webkit_dom_test_obj_set_string_attr):
(webkit_dom_test_obj_get_test_obj_attr):
(webkit_dom_test_obj_set_test_obj_attr):
(webkit_dom_test_obj_get_attr_with_exception):
(webkit_dom_test_obj_set_attr_with_exception):
(webkit_dom_test_obj_get_attr_with_setter_exception):
(webkit_dom_test_obj_set_attr_with_setter_exception):
(webkit_dom_test_obj_get_attr_with_getter_exception):
(webkit_dom_test_obj_set_attr_with_getter_exception):
(WebKit::wrapTestObj):
(WebKit::core):
(webkit_dom_test_obj_finalize):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h: Added.
* bindings/scripts/test/ObjC/DOMTestObj.h: Added.
* bindings/scripts/test/ObjC/DOMTestObj.mm: Added.
(-[DOMTestObj dealloc]):
(-[DOMTestObj finalize]):
(-[DOMTestObj readOnlyIntAttr]):
(-[DOMTestObj readOnlyStringAttr]):
(-[DOMTestObj readOnlyTestObjAttr]):
(-[DOMTestObj intAttr]):
(-[DOMTestObj setIntAttr:]):
(-[DOMTestObj stringAttr]):
(-[DOMTestObj setStringAttr:]):
(-[DOMTestObj testObjAttr]):
(-[DOMTestObj setTestObjAttr:]):
(-[DOMTestObj attrWithException]):
(-[DOMTestObj setAttrWithException:]):
(-[DOMTestObj attrWithSetterException]):
(-[DOMTestObj setAttrWithSetterException:]):
(-[DOMTestObj attrWithGetterException]):
(-[DOMTestObj setAttrWithGetterException:]):
(-[DOMTestObj customAttr]):
(-[DOMTestObj setCustomAttr:]):
(-[DOMTestObj voidMethod]):
(-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj intMethod]):
(-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj objMethod]):
(-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj methodWithException]):
(-[DOMTestObj customMethod]):
(-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj methodWithOptionalArg:]):
(-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
(-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
(core):
(kit):
* bindings/scripts/test/ObjC/DOMTestObjInternal.h: Added.
2010-04-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add testing infrastructure for JSC bindings generator
https://bugs.webkit.org/show_bug.cgi?id=38167
This required moving the test files around a bit more.
* bindings/scripts/test/JS/JSTestObj.cpp: Added.
(WebCore::):
(WebCore::JSTestObjConstructor::JSTestObjConstructor):
(WebCore::JSTestObjConstructor::classInfo):
(WebCore::JSTestObjConstructor::createStructure):
(WebCore::JSTestObjConstructor::getOwnPropertySlot):
(WebCore::JSTestObjConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestObjPrototype::self):
(WebCore::JSTestObjPrototype::getOwnPropertySlot):
(WebCore::JSTestObjPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestObj::JSTestObj):
(WebCore::JSTestObj::~JSTestObj):
(WebCore::JSTestObj::createPrototype):
(WebCore::JSTestObj::getOwnPropertySlot):
(WebCore::JSTestObj::getOwnPropertyDescriptor):
(WebCore::jsTestObjReadOnlyIntAttr):
(WebCore::jsTestObjReadOnlyStringAttr):
(WebCore::jsTestObjReadOnlyTestObjAttr):
(WebCore::jsTestObjIntAttr):
(WebCore::jsTestObjStringAttr):
(WebCore::jsTestObjTestObjAttr):
(WebCore::jsTestObjAttrWithException):
(WebCore::jsTestObjAttrWithSetterException):
(WebCore::jsTestObjAttrWithGetterException):
(WebCore::jsTestObjCustomAttr):
(WebCore::jsTestObjConstructor):
(WebCore::JSTestObj::put):
(WebCore::setJSTestObjIntAttr):
(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjTestObjAttr):
(WebCore::setJSTestObjAttrWithException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::setJSTestObjCustomAttr):
(WebCore::JSTestObj::getConstructor):
(WebCore::jsTestObjPrototypeFunctionVoidMethod):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethod):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethod):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithException):
(WebCore::jsTestObjPrototypeFunctionCustomMethod):
(WebCore::jsTestObjPrototypeFunctionCustomMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::toJS):
(WebCore::toTestObj):
* bindings/scripts/test/JS/JSTestObj.h: Added.
(WebCore::JSTestObj::classInfo):
(WebCore::JSTestObj::createStructure):
(WebCore::JSTestObj::impl):
(WebCore::JSTestObjPrototype::classInfo):
(WebCore::JSTestObjPrototype::createStructure):
(WebCore::JSTestObjPrototype::JSTestObjPrototype):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp: Renamed from WebCore/bindings/scripts/test/V8TestObj.cpp.
(WebCore::):
(WebCore::TestObjInternal::V8_USE):
(WebCore::TestObjInternal::readOnlyIntAttrAttrGetter):
(WebCore::TestObjInternal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjInternal::intAttrAttrGetter):
(WebCore::TestObjInternal::intAttrAttrSetter):
(WebCore::TestObjInternal::stringAttrAttrGetter):
(WebCore::TestObjInternal::stringAttrAttrSetter):
(WebCore::TestObjInternal::testObjAttrAttrGetter):
(WebCore::TestObjInternal::testObjAttrAttrSetter):
(WebCore::TestObjInternal::attrWithExceptionAttrGetter):
(WebCore::TestObjInternal::attrWithExceptionAttrSetter):
(WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter):
(WebCore::TestObjInternal::attrWithSetterExceptionAttrSetter):
(WebCore::TestObjInternal::attrWithGetterExceptionAttrGetter):
(WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter):
(WebCore::TestObjInternal::voidMethodCallback):
(WebCore::TestObjInternal::voidMethodWithArgsCallback):
(WebCore::TestObjInternal::intMethodCallback):
(WebCore::TestObjInternal::intMethodWithArgsCallback):
(WebCore::TestObjInternal::objMethodCallback):
(WebCore::TestObjInternal::objMethodWithArgsCallback):
(WebCore::TestObjInternal::methodWithExceptionCallback):
(WebCore::TestObjInternal::methodWithOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::TestObjInternal::overloadedMethod2Callback):
(WebCore::TestObjInternal::overloadedMethod3Callback):
(WebCore::TestObjInternal::overloadedMethod4Callback):
(WebCore::TestObjInternal::overloadedMethodCallback):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetRawTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::toNative):
(WebCore::V8TestObj::HasInstance):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):
(WebCore::V8TestObj::derefObject):
* bindings/scripts/test/V8/V8TestObj.h: Renamed from WebCore/bindings/scripts/test/V8TestObj.h.
2010-04-26 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Need to support more efficient dispatch of lightweight builtins
https://bugs.webkit.org/show_bug.cgi?id=38155
Update bindings generation to include new thunk generator field
in the property map hash tables.
* bindings/scripts/CodeGeneratorJS.pm:
2010-04-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move bindings test directory into the scripts directory
https://bugs.webkit.org/show_bug.cgi?id=38161
This test is really of the bindings scripts not of the bindings
themselves. By moving the files into the scripts directory, we'll be
able to test JSC as well.
* bindings/scripts/test/TestObj.idl: Renamed from WebCore/bindings/v8/test/TestObj.idl.
* bindings/scripts/test/V8TestObj.cpp: Renamed from WebCore/bindings/v8/test/V8TestObj.cpp.
(WebCore::):
(WebCore::TestObjInternal::V8_USE):
(WebCore::TestObjInternal::readOnlyIntAttrAttrGetter):
(WebCore::TestObjInternal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjInternal::intAttrAttrGetter):
(WebCore::TestObjInternal::intAttrAttrSetter):
(WebCore::TestObjInternal::stringAttrAttrGetter):
(WebCore::TestObjInternal::stringAttrAttrSetter):
(WebCore::TestObjInternal::testObjAttrAttrGetter):
(WebCore::TestObjInternal::testObjAttrAttrSetter):
(WebCore::TestObjInternal::attrWithExceptionAttrGetter):
(WebCore::TestObjInternal::attrWithExceptionAttrSetter):
(WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter):
(WebCore::TestObjInternal::attrWithSetterExceptionAttrSetter):
(WebCore::TestObjInternal::attrWithGetterExceptionAttrGetter):
(WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter):
(WebCore::TestObjInternal::voidMethodCallback):
(WebCore::TestObjInternal::voidMethodWithArgsCallback):
(WebCore::TestObjInternal::intMethodCallback):
(WebCore::TestObjInternal::intMethodWithArgsCallback):
(WebCore::TestObjInternal::objMethodCallback):
(WebCore::TestObjInternal::objMethodWithArgsCallback):
(WebCore::TestObjInternal::methodWithExceptionCallback):
(WebCore::TestObjInternal::methodWithOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::TestObjInternal::overloadedMethod2Callback):
(WebCore::TestObjInternal::overloadedMethod3Callback):
(WebCore::TestObjInternal::overloadedMethod4Callback):
(WebCore::TestObjInternal::overloadedMethodCallback):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetRawTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::toNative):
(WebCore::V8TestObj::HasInstance):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):
(WebCore::V8TestObj::derefObject):
* bindings/scripts/test/V8TestObj.h: Renamed from WebCore/bindings/v8/test/V8TestObj.h.
2010-04-26 Daniel Cheng <dcheng@chromium.org>
Reviewed by Jian Li.
[chromium] Fix ChromiumDataObject::setURL to not populate its internal URL list with empty URLs.
https://bugs.webkit.org/show_bug.cgi?id=38159
No new tests.
* platform/chromium/ChromiumDataObject.h:
(WebCore::ChromiumDataObject::setURL):
2010-04-26 Daniel Cheng <dcheng@chromium.org>
Reviewed by Jian Li.
[Chromium] Don't make file paths available in text/uri-list when dragging files.
https://bugs.webkit.org/show_bug.cgi?id=25882
Test will be checked in with WebCore/platform/mac fix.
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::types):
2010-04-26 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
REGRESSION (r57292): 1.5% page load speed regression from visited link information leak fix
https://bugs.webkit.org/show_bug.cgi?id=38131
I did a number of separate optimizations which speed up style
resolution enough to more than make up for the regression. This
measures as a total PLT speedup of somewhere between 1.5% and
3.7%.
Optimizations done:
- Cache determineLinkState results, to avoid the need to repeatedly compute
the visited link hash for the same element. This directly addresses much
of the slowdown, since all elements get their style computed twice now.
- Added a fast way to get the length of a CSSMutableStyleDeclaration, and use
in CSSStyleSelector::matchRulesForList, since it was hot there.
- Hoist some loop invariant code that's not detected by the compiler out of the
main loop in matchRulesForList
- inline CSSStyleSelector::initElement and locateSharedStyle,
since there is only one call site in each case
- Inline the common non-line fast case of determineLinkState, and split the rest into
out-of-line determineLinkStateSlowCase.
- Added inline versions of the functions called by
visitedLinkHash (the version called by determineLinkState).
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::length): Implemented in terms of new
inline nonvirtual mutableLength().
* css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::mutableLength): Added new nonvirtual
inline way to get the length if you know you have a mutable style decl.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::init): Clear cached link state.
(WebCore::CSSStyleSelector::matchRulesForList): hoist some code out of the main
loop and get style decl length more efficiently.
(WebCore::CSSStyleSelector::initElement): inline (only one call site)
(WebCore::CSSStyleSelector::SelectorChecker::determineLinkState): Inline fast
case, call slow case.
(WebCore::CSSStyleSelector::SelectorChecker::determineLinkStateSlowCase): Split
most of the above function into this slow case helper.
(WebCore::CSSStyleSelector::canShareStyleWithElement): Use the cache-enabled
way to get the current link state.
(WebCore::CSSStyleSelector::locateSharedStyle): inline
(WebCore::CSSStyleSelector::styleForElement): Use the cache-enabled way
to get the current link state.
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::currentElementLinkState): inline way to
get link state for the current element; manages the cache
* platform/LinkHash.cpp:
(WebCore::visitedLinkHashInline): inline version of below function
(WebCore::visitedLinkHash): call the inline version
(WebCore::visitedURLInline): inline version of below function
(WebCore::visitedURL): call the inline version
(WebCore::visitedURL): call inline versions of above two functions
2010-04-26 Sam Weinig <sam@webkit.org>
Reviewed by Alexey Proskuryakov.
Remove last use of WEB_THREAD.
* platform/mac/WebCoreObjCExtras.mm:
(WebCoreObjCScheduleDeallocateOnMainThread): This can always use
isMainThread().
2010-04-26 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Turn on AUTO_VACUUM = INCREMENTAL for all HTML5 databases, and
vacuum all databases when the number of free pages is at least 10%
of the number of total pages. Also, adding a guard against a bug
that was fixed in SQLite only starting with version 3.6.16.
https://bugs.webkit.org/show_bug.cgi?id=36251
* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::totalSize):
(WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
(WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):
* platform/sql/SQLiteDatabase.h:
* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
* storage/Database.cpp:
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::incrementalVacuumIfNeeded):
* storage/Database.h:
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::postflightAndCommit):
2010-04-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/7766413>
Fixed a crash seen when using the JavaScriptCore API with WebKit.
No layout test because DumpRenderTree doesn't use the JavaScriptCore API
in this way.
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener): Don't assign 0 to a WeakGCPtr.
JavaScriptCore no longer allows this.
* bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::setWrapper): No need to initialize a WeakGCPtr
to 0, or ASSERT a non-0 value before assigning to a WeakGCPtr -- both are
default behaviors.
2010-04-25 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Fix for https://bugs.webkit.org/show_bug.cgi?id=38097
Disentangle initializing the main thread from initializing threading
* WebCore.xcodeproj/project.pbxproj: Sort files.
* accessibility/mac/AccessibilityObjectWrapper.mm: Remove unnessary
+initialize method. The AccessibilityObjectWrapper has no data members
that need to be derefed, so it does not need to be finalized on the main
thread.
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::initializeThreading): Add call to initializeMainThread.
* bindings/objc/WebScriptObject.mm:
(+[WebScriptObject initialize]): Add call to initializeMainThreadToProcessMainThread.
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::initializeThreading): Add call to initializeMainThread.
* platform/mac/SharedBufferMac.mm:
(+[WebCoreSharedBufferData initialize]): Add call to initializeMainThreadToProcessMainThread.
2010-04-26 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=38128
Don't add empty credential to CredentialStorage.
An empty credential is currently regarded as a invalid login because it means a missing value in
protectionSpaceToCredentialMap. This change makes it consistent with current WebCore's behavior
by ignoring empty credentials.
No new tests added since this only affects credential entered by user from credential dialog,
which is not testable in DRT.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::receivedCredential):
2010-04-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Clean-up WebCore.pro after now that JavaScriptCore is built separately
https://bugs.webkit.org/show_bug.cgi?id=38123
HAVE_STDINT_H, and HAVE_PTHREAD_NP_H no longer needs to be defined
for QtWebKit as JavaScriptCore is built separately. These defines are only
used by JavaScriptCore and for JavaScriptCore these are already
properly defined in JavaScriptCore/config.h.
No new tests, no new functionality.
* WebCore.pro:
2010-04-26 Roman Gershman <romange@google.com>
Reviewed by Adam Barth.
[Chromium] Font size in suggestions popup menu should be correlated with the font size of its text field.
The following manual test checks for desired behavior.
https://bugs.webkit.org/show_bug.cgi?id=37977
* manual-tests/chromium/suggestions-popup-font-change.html: Added.
2010-04-26 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
View modes names in CSSValueKeywords.in
https://bugs.webkit.org/show_bug.cgi?id=38125
View mode names has changed in previous patch but CSSValueKeywords.in file was
not updated.
* css/CSSValueKeywords.in:
2010-04-26 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix compilation with RVCT 4
https://bugs.webkit.org/show_bug.cgi?id=37727
Swap extern and declspec to fix visibility of symbol imported from QtGui.
* page/qt/EventHandlerQt.cpp:
2010-04-26 Ruben Van Boxem <vanboxem.ruben@gmail.com>
Reviewed by Adam Roben.
Fixes for Win64 compilation under gcc (mingw-w64)
* WebCore/bridge/npapi.h: for win64 compatibility, mirroring mozilla-central, see Mozilla bug 560298
* WebCore/platform/Arena.h: uword is used to cast from pointers here. unsigned long is 32-bit on Windows (but 64-bit on mac), and too small to hold a pointer. uintptr_t is 32-bit on 32-bit systems (mac, linux and windows) and 64-bit on all 64-bit systems
* WebCore/platform/graphics/transforms/TransformationMatrix.h: let mingw-w64/w32 use MSVC codepath
* WebCore/platform/text/TextStream.cpp: let mingw-w64 use MSVC codepath
* WebCore/platform/text/TextStream.h: let mingw-w64 use MSVC codepath
* WebCore/plugins/PluginView.cpp: fix pointer casts on WIN64 and let mingw-w64 use MSVC codepath
* WebCore/plugins/win/PluginViewWin.cpp: fix pointer casts on WIN64
2010-04-26 Markus Goetz <Markus.Goetz@nokia.com>
Reviewed by Simon Hausmann.
[Qt] HTTP pipelining efficiency increase
https://bugs.webkit.org/show_bug.cgi?id=38062
Increase number of network requests that are fed into
QNetworkAccessManager.
* platform/network/qt/ResourceRequestQt.cpp:
(WebCore::initializeMaximumHTTPConnectionCountPerHost):
2010-04-26 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: undefined shows up on inspector.
https://bugs.webkit.org/show_bug.cgi?id=38120
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.hide):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.set visible):
2010-04-26 Bruno Schmidt <bruno.schmidt@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Exposing an QVariantMap containing QObjectStar to Javascript
causes Segmentation Fault
https://bugs.webkit.org/show_bug.cgi?id=34729
If an QVariantMap containing QObjectStar is added to the to QtWebkit
Javascript, it's use causes Segmentation Fault.
It happens because, in the case QMetaType::QVariantMap, the "root"
object that is inside of a PassRefPtr is passed recursively inside a
loop to recover the content of the map, but the PassRefPtr semantics
prohibit its use inside a loop, so the "root" object mus be passed
using the method "PassRefPtr::get" in order to keep the current
reference.
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue): change to root.get()
2010-04-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Render clip in summary bar using "arc", not "quadraticCurveTo".
https://bugs.webkit.org/show_bug.cgi?id=38107
* inspector/front-end/SummaryBar.js:
(WebInspector.SummaryBar.prototype._drawSummaryGraph.drawPill):
(WebInspector.SummaryBar.prototype._drawSummaryGraph):
2010-04-26 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Fix compilation against Qt 4.7
Some QtMultimedia things have been moved into QtMediaServices
https://bugs.webkit.org/show_bug.cgi?id=38111
* WebCore.pro:
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::totalBytes):
2010-04-26 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Dirk Schulze.
Call setStrokeStyle in applyStrokeStyleToContext
https://bugs.webkit.org/show_bug.cgi?id=37849
Not all platforms set the stroke style to solid if they
get an empty line dash array. Some just ignore the operation.
* rendering/SVGRenderSupport.cpp:
(WebCore::applyStrokeStyleToContext):
2010-04-23 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Aggregated stats of time spent in children records should be visible
in the popup panel of parent record. Crash in pushGCEventRecord also was fixed.
https://bugs.webkit.org/show_bug.cgi?id=37820
* English.lproj/localizedStrings.js:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::pushGCEventRecords):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._createRootRecord):
(WebInspector.TimelinePanel.prototype._showPopover):
(WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
(WebInspector.TimelineRecordGraphRow):
(WebInspector.TimelineRecordGraphRow.prototype.update):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.FormattedRecord.prototype._calculateAggregatedStats):
* inspector/front-end/inspector.css:
(.timeline-graph-bar.with-children):
(.timeline-graph-bar.cpu):
(.timeline-aggregated-category):
(.timeline-loading):
(.timeline-scripting):
(.timeline-rendering):
(.popover .timeline-aggregated-category.timeline-loading):
(.timeline-details-title):
2010-04-25 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
WebKit crashes with deeply nested divs
https://bugs.webkit.org/show_bug.cgi?id=18282
The HTML parser caps a tree depth by MAX_DOM_TREE_DEPTH defined in
TreeDepthLimit.h. This is performance-efficient, but does not work for
DOM operations such as Node.appendChild().
Test: fast/parser/element-nesting-cap.html
* dom/Node.h:
* dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::pushCurrentNode):
* html/HTMLParser.cpp:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/TreeDepthLimit.h:
Added. Define MAX_DOM_TREE_DEPTH. The default value is 5000.
* dom/XMLTokenizer.cpp: Use maxDOMTreeDepth.
(WebCore::XMLTokenizer::pushCurrentNode):
* html/HTMLParser.cpp:
Introduce m_treeDepth, which counts the depth of the tree.
Unlike m_blocksInStack, it contains the number of non-block nodes.
(WebCore::HTMLParser::HTMLParser):
(WebCore::HTMLParser::reset):
(WebCore::HTMLParser::limitDepth):
Renamed from limitBlockDepth. Add check for m_nodeDepth.
(WebCore::HTMLParser::insertNodeAfterLimitDepth):
Renamed from insertNodeAfterLimitBlockDepth.
(WebCore::HTMLParser::parseToken):
(WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
(WebCore::HTMLParser::pushBlock):
(WebCore::HTMLParser::popOneBlockCommon):
(WebCore::HTMLParser::freeBlock):
* html/HTMLParser.h:
2010-04-25 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Adam Barth.
Get context properly when event handler was created on
the main world.
https://bugs.webkit.org/show_bug.cgi?id=37947
Test: http/tests/security/isolatedWorld/dispatchEvent.html
* bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::adjustedContext):
2010-04-25 yael aharon <yael.aharon@nokia.com>
Reviewed by Adele Peterson.
Allow styling of HTMLProgressElement.
https://bugs.webkit.org/show_bug.cgi?id=37901
Added a new pseudo element to represent the value portion of the progress element.
Web developers can style this pseudo element separate from the rest of the progress element.
Test: fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
* css/CSSValueKeywords.in:
* platform/ThemeTypes.h:
* rendering/RenderProgress.cpp:
(WebCore::ProgressValueElement::isShadowNode):
(WebCore::ProgressValueElement::shadowParentNode):
(WebCore::ProgressValueElement::ProgressValueElement):
(WebCore::RenderProgress::RenderProgress):
(WebCore::RenderProgress::~RenderProgress):
(WebCore::RenderProgress::layout):
(WebCore::RenderProgress::styleDidChange):
(WebCore::RenderProgress::updateFromElement):
(WebCore::RenderProgress::updateValuePartState):
(WebCore::RenderProgress::createStyleForValuePart):
(WebCore::RenderProgress::updateAnimationState):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isControlStyled):
* rendering/RenderProgress.h:
* rendering/style/RenderStyleConstants.h:
2010-04-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Don't propagate compositing out of iframes on Mac
https://bugs.webkit.org/show_bug.cgi?id=38072
Propagating compositing out of iframes caused too many regressions on Mac,
so only do it for other platforms that may need to hook compositing layers
together across iframe boundaries.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForIFrame):
2010-04-24 Anton Muhin <antonm@chromium.org>
Reviewed by Darin Adler.
Allow to construct HashTraits<WebCore::QualifiedName>::constructDeletedValue
Former implementation attempted to use AtomicString(HashTableDeletedValue)
however those values cannot be used that way: one cannot construct
QualifiedNameImpl out of such AtomicString as we'll try to lookup this string
in the table, for example.
https://bugs.webkit.org/show_bug.cgi?id=37722
* dom/QualifiedName.cpp:
(WebCore::QualifiedName::deref): check that hash table deleted values never derefed
* dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedName): add a constructor to create hash table deleted values
(WebCore::QualifiedName::isHashTableDeletedValue): add a check if given instance is hash table deleted value
(WTF::):
2010-04-24 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Alexey Proskuryakov.
protocolHostAndPortEquals host check makes a wrong assumption
https://bugs.webkit.org/show_bug.cgi?id=37777
The host check assumed that both host started at the same position. This is true
if both URL are the same but sometimes one has credential and the other does not.
In this case, the method would compare invalid positions.
Test: http/tests/appcache/credential-url.html
* platform/KURL.cpp:
(WebCore::protocolHostAndPortAreEqual):
* platform/KURLGoogle.cpp:
(WebCore::protocolHostAndPortAreEqual):
Fix the host check to take both URL's credential into account.
2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix linkage on several bots (no idea, why it worked in a from-scratch rebuild on Leopard on my machine!) -> include NodeRenderStyle.h
Having to include NodeRenderStyle.h just to pull in the renderStyle() is a crazy concept, but I see what it tries to avoid (including RenderObject.h in Node.h)
* rendering/SVGRenderSupport.cpp:
2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix release builds, wrap resourceMode assertion in NDEBUG blocks, use UNUSED_PARAM() otherwhise.
* rendering/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyResource):
* rendering/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):
* rendering/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
SVGPaintServer needs to be converted to the new RenderSVGResource* system
https://bugs.webkit.org/show_bug.cgi?id=37986
Huge speedup for SVG painting using paint servers (gradient/patterns). Cache underlying
WebCore::Gradient/Pattern datastructures, do not rebuild them on every painting. This marks
the finish of the SVGResource -> RenderSVGResource transition.
Outline of same key changes:
- RenderSVGResource is an abstract base class now, and the previous class is now named RenderSVGResourceContainer
All resources except RenderSVGResourceSolidColor now inherit from RenderSVGResourceContainer, as they are all
associated with a SVG*Element class. RenderSVGResourceSolidColor inherits from RenderSVGResource, and is not
associated with any SVG*Element class. RenderSVGResourceSolidColor is not a render tree object, despite its name.
The reason for that is consistency with all other painting resources.
- RenderSVGResourceSolidColor does not live in the render tree, and exists only as static object, which is shared
and always used when filling/stroking with solid colors - just like the old SVGPaintServerSolid.
- RenderSVGResourceGradient/RenderSVGResourcePattern now store the underlying WebCore::Gradient/Pattern object
instead of rebuilding it everytime we're asked to paint -> this is the main difference with the old concept, leading
to much faster speed.
- SVGResource has vanished. All resources (clipper/filter/marker/masker/gradient/pattern) now share the same codepaths
to handle updates and client invalidation - which is a huge benefit, and makes the code easier to understand.
* Android.mk: Remove svg/graphics/SVGResource*, svg/graphics/SVGPaintServer.h from build.
* GNUmakefile.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* platform/graphics/Gradient.cpp: Add addColorStop() method taking a ColorStop const-reference.
(WebCore::Gradient::addColorStop):
* platform/graphics/Gradient.h: Ditto.
* platform/graphics/TextRun.h: Rename SVGPaintServer to RenderSVGResource
(WebCore::TextRun::TextRun):
(WebCore::TextRun::activePaintingResource): Renamed from activePaintServer.
(WebCore::TextRun::setActivePaintingResource): Renamed from setActivePaintServer.
* platform/graphics/win/GraphicsContextWin.cpp: Remove references to SVGResourceImage, which was removed a long time ago.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::toRenderSVGResourceContainer): Renamed from toRenderSVGResource().
* rendering/RenderObject.h:
(WebCore::RenderObject::isSVGGradientStop): Added.
(WebCore::RenderObject::isSVGResourceContainer): Renamed from isSVGResource().
* rendering/RenderPath.cpp: Utilize RenderSVGResource::fill/strokePaintingResource to request paint servers, instead of SVGPaintServer.
(WebCore::RenderPath::fillContains): Adapt to new concept.
(WebCore::RenderPath::strokeContains): Ditto.
(WebCore::fillAndStrokePath): Ditto.
(WebCore::RenderPath::paint): Ditto.
* rendering/RenderSVGGradientStop.cpp:
(WebCore::RenderSVGGradientStop::styleDidChange): Ditto.
* rendering/RenderSVGGradientStop.h: Fixed indention.
* rendering/RenderSVGResource.cpp: Refactored old SVGPaintServer code to request fill/stroke painting resources, splitted up in several methods to aid readability.
(WebCore::registerPendingResource):
(WebCore::adjustColorForPseudoRules):
(WebCore::RenderSVGResource::fillPaintingResource):
(WebCore::RenderSVGResource::strokePaintingResource):
(WebCore::RenderSVGResource::sharedSolidPaintingResource):
(WebCore::RenderSVGResource::markForLayoutAndResourceInvalidation):
* rendering/RenderSVGResource.h: Make RenderSVGResource an abstract base class, see above for the reasoning.
(WebCore::RenderSVGResource::RenderSVGResource):
(WebCore::RenderSVGResource::~RenderSVGResource):
(WebCore::RenderSVGResource::postApplyResource):
* rendering/RenderSVGResourceClipper.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource.
(WebCore::RenderSVGResourceClipper::RenderSVGResourceClipper):
(WebCore::RenderSVGResourceClipper::invalidateClient):
(WebCore::RenderSVGResourceClipper::applyResource): Adapt to signature changes (add RenderStyle* and resource mode parameters)
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
* rendering/RenderSVGResourceClipper.h:
* rendering/RenderSVGResourceContainer.h: Added. Renamed from RenderSVGResource. Now inherits from RenderSVGHiddenContainer and RenderSVGResource.
(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::~RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::idChanged):
(WebCore::RenderSVGResourceContainer::isSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::drawsContents):
(WebCore::RenderSVGResourceContainer::toRenderSVGResourceContainer):
(WebCore::getRenderSVGResourceContainerById):
(WebCore::getRenderSVGResourceById):
* rendering/RenderSVGResourceFilter.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource.
(WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter):
(WebCore::RenderSVGResourceFilter::invalidateClient):
(WebCore::RenderSVGResourceFilter::applyResource): Adapt to signature changes (add RenderStyle* and resource mode parameters)
(WebCore::RenderSVGResourceFilter::postApplyResource):
* rendering/RenderSVGResourceFilter.h:
* rendering/RenderSVGResourceGradient.cpp: Moved from SVGPaintServerGradient, cleaned up and refactored.
(WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient):
(WebCore::RenderSVGResourceGradient::~RenderSVGResourceGradient):
(WebCore::RenderSVGResourceGradient::invalidateClients):
(WebCore::RenderSVGResourceGradient::invalidateClient):
(WebCore::createMaskAndSwapContextForTextGradient):
(WebCore::clipToTextMask):
(WebCore::RenderSVGResourceGradient::applyResource):
* rendering/RenderSVGResourceGradient.h:
(WebCore::RenderSVGResourceGradient::resourceBoundingBox):
* rendering/RenderSVGResourceLinearGradient.cpp: Moved from SVGPaintServerLinearGradient, cleaned up and refactored.
(WebCore::RenderSVGResourceLinearGradient::RenderSVGResourceLinearGradient):
(WebCore::RenderSVGResourceLinearGradient::~RenderSVGResourceLinearGradient):
(WebCore::RenderSVGResourceLinearGradient::buildGradient):
* rendering/RenderSVGResourceLinearGradient.h:
(WebCore::RenderSVGResourceLinearGradient::renderName):
(WebCore::RenderSVGResourceLinearGradient::resourceType):
* rendering/RenderSVGResourceMarker.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource.
(WebCore::RenderSVGResourceMarker::RenderSVGResourceMarker):
(WebCore::RenderSVGResourceMarker::invalidateClient):
* rendering/RenderSVGResourceMarker.h:
(WebCore::RenderSVGResourceMarker::applyResource):
* rendering/RenderSVGResourceMasker.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource.
(WebCore::RenderSVGResourceMasker::RenderSVGResourceMasker):
(WebCore::RenderSVGResourceMasker::invalidateClient):
(WebCore::RenderSVGResourceMasker::applyResource):
* rendering/RenderSVGResourceMasker.h:
(WebCore::MaskerData::MaskerData):
* rendering/RenderSVGResourcePattern.cpp: Moved from SVGPaintServerPattern, cleaned up and refactored.
(WebCore::RenderSVGResourcePattern::RenderSVGResourcePattern):
(WebCore::RenderSVGResourcePattern::~RenderSVGResourcePattern):
(WebCore::RenderSVGResourcePattern::invalidateClients):
(WebCore::RenderSVGResourcePattern::invalidateClient):
(WebCore::RenderSVGResourcePattern::applyResource):
(WebCore::RenderSVGResourcePattern::postApplyResource):
(WebCore::calculatePatternBoundaries):
(WebCore::RenderSVGResourcePattern::calculatePatternBoundariesIncludingOverflow):
(WebCore::RenderSVGResourcePattern::createTileImage):
(WebCore::RenderSVGResourcePattern::buildPattern):
* rendering/RenderSVGResourcePattern.h:
(WebCore::RenderSVGResourcePattern::renderName):
(WebCore::RenderSVGResourcePattern::resourceBoundingBox):
(WebCore::RenderSVGResourcePattern::resourceType):
* rendering/RenderSVGResourceRadialGradient.cpp: Moved from SVGPaintServerRadialGradient, cleaned up and refactored.
(WebCore::RenderSVGResourceRadialGradient::RenderSVGResourceRadialGradient):
(WebCore::RenderSVGResourceRadialGradient::~RenderSVGResourceRadialGradient):
(WebCore::RenderSVGResourceRadialGradient::buildGradient):
* rendering/RenderSVGResourceRadialGradient.h:
(WebCore::RenderSVGResourceRadialGradient::renderName):
(WebCore::RenderSVGResourceRadialGradient::resourceType):
* rendering/RenderSVGResourceSolidColor.cpp: Moved from SVGPaintServerSolid, cleaned up and refactored.
(WebCore::RenderSVGResourceSolidColor::RenderSVGResourceSolidColor):
(WebCore::RenderSVGResourceSolidColor::~RenderSVGResourceSolidColor):
(WebCore::RenderSVGResourceSolidColor::applyResource):
(WebCore::RenderSVGResourceSolidColor::postApplyResource):
* rendering/RenderSVGResourceSolidColor.h:
(WebCore::RenderSVGResourceSolidColor::invalidateClients):
(WebCore::RenderSVGResourceSolidColor::invalidateClient):
(WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):
(WebCore::RenderSVGResourceSolidColor::resourceType):
(WebCore::RenderSVGResourceSolidColor::color):
(WebCore::RenderSVGResourceSolidColor::setColor):
* rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::paint): Early exit if painting is disabled.
* rendering/RenderTreeAsText.cpp:
(WebCore::write): Add RenderSVGGradientStop dumping.
(WebCore::externalRepresentation): Remove SVGResource dumping.
* rendering/SVGInlineTextBox.cpp: Adapt to SVGPaintServer changes (paint server request).
(WebCore::SVGInlineTextBox::paintCharacters):
(WebCore::SVGInlineTextBox::paintDecoration):
* rendering/SVGInlineTextBox.h: Ditto.
(WebCore::SVGTextPaintInfo::SVGTextPaintInfo):
* rendering/SVGRenderSupport.cpp: Ditto.
(WebCore::SVGRenderBase::prepareToRenderSVGContent):
(WebCore::SVGRenderBase::finishRenderSVGContent):
(WebCore::invalidatePaintingResource):
(WebCore::deregisterFromResources):
(WebCore::dashArrayFromRenderingStyle): Moved here from SVGPaintServer.
(WebCore::applyStrokeStyleToContext): Ditto.
* rendering/SVGRenderSupport.h:
* rendering/SVGRenderTreeAsText.cpp: Add new gradient/pattern dumping code. Stops are now properly dumped as well!
(WebCore::operator<<):
(WebCore::writeSVGPaintingResource):
(WebCore::writeStyle):
(WebCore::boundingBoxModeString):
(WebCore::writeCommonGradientProperties):
(WebCore::writeSVGResourceContainer):
(WebCore::writeSVGGradientStop):
* rendering/SVGRenderTreeAsText.h:
* rendering/SVGRootInlineBox.cpp: Adapt to SVGPaintServer changes (paint server request).
(WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker):
(WebCore::SVGRootInlineBoxPaintWalker::~SVGRootInlineBoxPaintWalker):
(WebCore::SVGRootInlineBoxPaintWalker::teardownFillPaintServer):
(WebCore::SVGRootInlineBoxPaintWalker::teardownStrokePaintServer):
(WebCore::SVGRootInlineBoxPaintWalker::setupBackground):
(WebCore::SVGRootInlineBoxPaintWalker::setupFill):
(WebCore::SVGRootInlineBoxPaintWalker::setupFillSelection):
(WebCore::SVGRootInlineBoxPaintWalker::setupStroke):
(WebCore::SVGRootInlineBoxPaintWalker::setupStrokeSelection):
(WebCore::SVGRootInlineBoxPaintWalker::setupForeground):
(WebCore::SVGRootInlineBoxPaintWalker::activePaintingResource):
(WebCore::SVGRootInlineBoxPaintWalker::paintChunk):
* svg/GradientAttributes.h: Remove SVGGradientStop, use Gradient::ColorStop vector. Cleanup.
(WebCore::GradientAttributes::stops):
(WebCore::GradientAttributes::setStops):
* svg/LinearGradientAttributes.h: Move ENABLE(SVG) guard to correct location.
* svg/PatternAttributes.h: Add missing includes and class forwards.
* svg/RadialGradientAttributes.h: Move ENABLE(SVG) guard to correct location.
* svg/SVGClipPathElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients().
(WebCore::SVGClipPathElement::svgAttributeChanged):
(WebCore::SVGClipPathElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
* svg/SVGClipPathElement.h:
* svg/SVGDocumentExtensions.cpp: Change HashMaps to hash AtomicStrings instead of Strings. Rename RenderSVGResource to RenderSVGResourceContainer.
(WebCore::SVGDocumentExtensions::addResource):
(WebCore::SVGDocumentExtensions::removeResource):
(WebCore::SVGDocumentExtensions::resourceById):
(WebCore::SVGDocumentExtensions::addPendingResource):
* svg/SVGDocumentExtensions.h:
* svg/SVGElement.cpp:
(WebCore::SVGElement::insertedIntoDocument): Remove reference to SVGResource::invalidateClients(), handled differently now.
(WebCore::SVGElement::updateAnimatedSVGAttribute): Change assertion, that is incorrect now.
* svg/SVGElement.h: Make updateAnimatedSVGAttribute() public.
* svg/SVGFont.cpp: Adapt to SVGPaintServer changes (paint server request).
(WebCore::Font::drawTextUsingSVGFont):
* svg/SVGGElement.cpp: If style()->display() is NONE, create a RenderSVGHiddenContainer, removing hacks in SVGStopElement for pservers-grad-19-b.svg (yes, SVG is crazy.)
(WebCore::SVGGElement::createRenderer):
* svg/SVGGElement.h: Remove childrenChanged() method which _always_ called renderer->setNeedsLayout(true), which is completly wrong and unnecessary.
(WebCore::SVGGElement::rendererIsNeeded): Always return true.
* svg/SVGGradientElement.cpp: Adapt to new RenderSVGResourceGradient code.
(WebCore::SVGGradientElement::svgAttributeChanged):
(WebCore::SVGGradientElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
(WebCore::SVGGradientElement::buildStops):
* svg/SVGGradientElement.h:
* svg/SVGLinearGradientElement.cpp: Adapt to new RenderSVGResourceLinearGradient code.
(WebCore::SVGLinearGradientElement::svgAttributeChanged):
(WebCore::SVGLinearGradientElement::createRenderer):
(WebCore::SVGLinearGradientElement::collectGradientProperties):
(WebCore::SVGLinearGradientElement::calculateStartEndPoints):
* svg/SVGLinearGradientElement.h:
* svg/SVGMarkerElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients().
(WebCore::SVGMarkerElement::svgAttributeChanged):
(WebCore::SVGMarkerElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
(WebCore::SVGMarkerElement::setOrientToAuto):
(WebCore::SVGMarkerElement::setOrientToAngle):
* svg/SVGMaskElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients().
(WebCore::SVGMaskElement::svgAttributeChanged):
(WebCore::SVGMaskElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
* svg/SVGPatternElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients().
(WebCore::SVGPatternElement::svgAttributeChanged):
(WebCore::SVGPatternElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
(WebCore::SVGPatternElement::createRenderer):
* svg/SVGPatternElement.h:
* svg/SVGPolyElement.h: Remove unneded rendererIsNeeded() override.
* svg/SVGRadialGradientElement.cpp: Adapt to new RenderSVGResourceRadialGradient code.
(WebCore::SVGRadialGradientElement::svgAttributeChanged):
(WebCore::SVGRadialGradientElement::createRenderer):
(WebCore::SVGRadialGradientElement::collectGradientProperties):
(WebCore::SVGRadialGradientElement::calculateFocalCenterPointsAndRadius):
* svg/SVGRadialGradientElement.h:
* svg/SVGStopElement.cpp: Clean up code, moved stop color calculation from SVGGradientElement to here, where it belongs.
(WebCore::SVGStopElement::parseMappedAttribute):
(WebCore::SVGStopElement::stopColorIncludingOpacity):
* svg/SVGStopElement.h:
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::~SVGStyledElement):
(WebCore::SVGStyledElement::svgAttributeChanged): Only invalidateResourcesInAncestorChain()/deregisterFromResources() when we're not parsing.
(WebCore::SVGStyledElement::invalidateResourcesInAncestorChain): Early exit if we find a parent resources, there is no resource nesting.
(WebCore::SVGStyledElement::invalidateResourceClients): Renamed from invalidateCanvasResources()
(WebCore::SVGStyledElement::childrenChanged): Only invalidate SVGElementInstances when !changedByParser is set.
* svg/SVGStyledElement.h: Remove canvasResource() logic, remove detach() method.
* svg/SVGTextPathElement.h:
* svg/graphics/SVGPaintServer.h: Removed.
* svg/graphics/SVGResource.cpp: Removed.
* svg/graphics/SVGResource.h: Removed.
2010-04-23 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Fisher.
Add isGLES2Compliant to GraphicsContext3D: make the method const.
https://bugs.webkit.org/show_bug.cgi?id=37872
* platform/graphics/GraphicsContext3D.h: Make isGLES2Compliant() const.
* platform/graphics/mac/GraphicsContext3DMac.cpp: Ditto.
(WebCore::GraphicsContext3D::isGLES2Compliant):
2010-04-23 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] LayoutTests/fast/canvas/pointInPath.html passed, actually it failed
https://bugs.webkit.org/show_bug.cgi?id=37276
QPainterPath::contains doesn't count the point on the bound.
* platform/graphics/qt/PathQt.cpp:
(WebCore::isPointOnPathBorder):
(WebCore::Path::contains):
2010-04-23 Sam Weinig <sam@webkit.org>
Reviewed by David Levin.
Fix for https://bugs.webkit.org/show_bug.cgi?id=38060
Split up Threading.h
Add necessary forwarding headers.
* ForwardingHeaders/wtf/Atomics.h: Added.
* ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
* ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
2010-04-23 Rafael Weinstein <rafaelw@grafaelw.sfo.corp.google.com>
Reviewed by Darin Fisher.
This patch adds a vector of additionalFeatures to WindowFeatures
and populates it with any feature strings that evaluate to "yes"
and aren't directly observed in WindowFeatures. This allows
clients to capture experimental window features.
https://bugs.webkit.org/show_bug.cgi?id=38013
* page/WindowFeatures.cpp:
(WebCore::WindowFeatures::setWindowFeature):
* page/WindowFeatures.h:
2010-04-23 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7898436> :after content is duplicated
Test: fast/css-generated-content/after-duplicated-after-split.html
* rendering/RenderInline.cpp:
(WebCore::RenderInline::splitInlines): Pass the correct owner of the child list.
2010-04-23 Adele Peterson <adele@apple.com>
Fixing the Tiger build for real.
* platform/graphics/mac/SimpleFontDataMac.mm:
2010-04-23 Adele Peterson <adele@apple.com>
Fixing the Tiger build.
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformBoundsForGlyph):
2010-04-23 Jian Li <jianli@chromium.org>
Reviewed by Dmitry Titov.
Add FileError for File API.
https://bugs.webkit.org/show_bug.cgi?id=37840
The test will be added when implementing FileReader and FilerWriter.
* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/ExceptionCode.h:
(WebCore::):
* html/FileError.h: Added.
* html/FileError.idl: Added.
* page/DOMWindow.idl:
2010-04-23 Jian Li <jianli@chromium.org>
Reviewed by Adam Barth.
Improve code generator scripts to handle OR ('|') condition in the
extended attributes.
https://bugs.webkit.org/show_bug.cgi?id=37998
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/IDLStructure.pm:
2010-04-23 Adele Peterson <adele@apple.com>
Reviewed by Dan Bernstein.
Fix for <rdar://problem/7855777> REGRESSION: Memory usage increase caused by storing glyph bounds in GlyphMetricsMap
https://bugs.webkit.org/show_bug.cgi?id=37936
This change breaks the GlyphMetricsMap into two maps - one for width and one for bounds, so that we don't store
a FloatRect for the glyph bounds unless we need to.
Covered by existing tests. This should not cause any change in functionality.
Updated for removal of GlyphMetricsMap.cpp
* Android.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Made GlyphMetricsMap a template, so it can be used for separate width and bounds maps.
* platform/graphics/GlyphMetricsMap.cpp: Removed.
* platform/graphics/GlyphMetricsMap.h:
(WebCore::GlyphMetricsMap::metricsForGlyph):
(WebCore::GlyphMetricsMap::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::metricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForIndex):
(WebCore::::unknownMetrics):
(WebCore::::locatePageSlowCase):
* platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::adjustGlyphsAndAdvances):
Call boundsForGlyph instead of metricsForGlyph.
* platform/graphics/win/UniscribeController.cpp: (WebCore::UniscribeController::shapeAndPlaceItem):
ditto.
* platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::platformGlyphInit):
Call setMetricsForGlyph for both glyph maps.
Break getters and setters for metricsForGlyph into widthForGlyph and boundsForGlyph, maintaining present behavior.
* platform/graphics/SimpleFontData.h:
(WebCore::):
(WebCore::SimpleFontData::boundsForGlyph):
(WebCore::SimpleFontData::widthForGlyph):
* platform/graphics/cairo/SimpleFontDataCairo.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/chromium/SimpleFontDataLinux.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/gtk/SimpleFontDataPango.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/win/SimpleFontDataCairoWin.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
* platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::boundsForGDIGlyph):
(WebCore::SimpleFontData::widthForGDIGlyph):
* platform/graphics/wince/SimpleFontDataWince.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
* platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
2010-04-23 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein and Darin Adler
Fix issue "caret does not paint after type in characters in right
aligned div or after delete all characters in RTL div or
0px right padding RTL textarea"
https://bugs.webkit.org/show_bug.cgi?id=25319
Test: editing/inserting/caret-position.html
* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
2010-04-23 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [Performance] GraphicsLayer: constructing the layers takes too long
https://bugs.webkit.org/show_bug.cgi?id=36365
The issue came from using QGraphicsView's cache as is. The problem is that
several code-paths require re-rendering of the item, but not re-rendering
of the web content into the cache.
The way to solve it is by having GraphicsLayerQt manage the cache directly
via QPixmapCache, instead of using QGraphicsItem cache modes.
FPS measurement shows significant improvement (20FPS before, 40FPS after)
on several use-cases, including blog-files/leaves on a desktop environment.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::recache):
(WebCore::GraphicsLayerQtImpl::paint):
(WebCore::GraphicsLayerQtImpl::flushChanges):
2010-04-23 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
Avoid marking symbols as dllexport in chromium win builds
https://bugs.webkit.org/show_bug.cgi?id=38058
No new tests.
* config.h:
2010-04-23 MORITA Hajime <morrita@google.com>
Reviewed by Nikolas Zimmermann.
https://bugs.webkit.org/show_bug.cgi?id=37187
SVG <use href="foo"> is interpreted as <use href="#foo">
getTarget() did return url parameter as is if doesn't have
fragment identifier. So fixed to return empty string in such case
because we need to distinguish "yyy.html" from "xxx.svg#yyy.html".
Test: svg/custom/broken-internal-references.svg
* svg/SVGElement.cpp:
(WebCore::SVGElement::insertedIntoDocument):
* svg/SVGURIReference.cpp:
(WebCore::SVGURIReference::getTarget):
2010-04-23 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
ASSERT(willBeComposited == needsToBeComposited(layer)); on gmail.com
https://bugs.webkit.org/show_bug.cgi?id=38066
When a layer goes into compositing mode because it has a negative z-index child that is going
into compositing mode, then set willBeComposited to true. Also add another assertion to catch
any other cases where the state of willBeComposited is mismanaged.
Test: compositing/composited-negative-zindex-child.html
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
2010-04-23 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
When webkitAnimationEnd event fires, on-screen rendering should show the last frame of animation
https://bugs.webkit.org/show_bug.cgi?id=37955
After r37484, animation and transition end events were fired on a timer, after the animation/transition
ended. This opened up one event loop cycle in which the non-animating state of the element was visible
before the event fired, resulting in flashes in content that reset style from the event handler.
Fix by firing these events in the same event cycle as the animation end, once all animations
have been updated. This also required moving the place that start animations are fixed until
a later state in the state machine, so that animations have their start time set at the point
the event is fired (to avoid an assertion when using the freeze API in DRT).
Not testable, since the flash is very transitory and cannot be captured in a pixel test.
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::updateStateMachine): Move the firing of 'start' events into the state
where the start time is known.
* page/animation/AnimationControllerPrivate.h:
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired): Call the new fireEventsAndUpdateStyle()
method.
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle): New method to share code that used to be in
updateStyleIfNeededDispatcherFired().
(WebCore::AnimationControllerPrivate::animationTimerFired): Call fireEventsAndUpdateStyle() once we've
processed all animations.
2010-04-23 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
CompositeAnimation::updateKeyframeAnimations() can make a KeyframeAnimation for animation "none"
https://bugs.webkit.org/show_bug.cgi?id=38017
Check to see if the animation name is "none", and don't fire off a keyframe animation in
that case.
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateKeyframeAnimations):
2010-04-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Disable Netscape plugin support for minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=38026
No new tests, as there is no new functionality.
* WebCore.pri:
2010-04-23 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Need borderAndPadding(Width|Height)
https://bugs.webkit.org/show_bug.cgi?id=38046
Refactoring only, so no new tests.
* rendering/InlineBox.cpp:
(WebCore::InlineBox::height):
* rendering/RenderApplet.cpp:
(WebCore::RenderApplet::createWidgetIfNecessary):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::isSelfCollapsingBlock):
(WebCore::RenderBlock::calcPrefWidths):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calcBorderBoxWidth):
(WebCore::RenderBox::calcBorderBoxHeight):
(WebCore::RenderBox::calcContentBoxWidth):
(WebCore::RenderBox::calcContentBoxHeight):
(WebCore::RenderBox::calcWidth):
(WebCore::RenderBox::calcHeight):
(WebCore::RenderBox::calcPercentageHeight):
(WebCore::RenderBox::calcReplacedHeightUsing):
(WebCore::RenderBox::availableHeightUsing):
(WebCore::RenderBox::calcAbsoluteHorizontal):
(WebCore::RenderBox::calcAbsoluteVertical):
(WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
(WebCore::RenderBox::calcAbsoluteVerticalReplaced):
(WebCore::RenderBox::positionForPoint):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::borderAndPaddingHeight):
(WebCore::RenderBoxModelObject::borderAndPaddingWidth):
* rendering/RenderDataGrid.cpp:
(WebCore::RenderDataGrid::calcPrefWidths):
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::calcPrefWidths):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::calcPrefWidths):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::calcPrefWidths):
(WebCore::RenderFlexibleBox::allowedChildFlex):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::calcPrefWidths):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::calcPrefWidths):
(WebCore::RenderListBox::calcHeight):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::calcPrefWidths):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::calcPrefWidths):
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::calcPrefWidths):
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::calcPrefWidths):
(WebCore::RenderSlider::layout):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleOrColWidth):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::textBlockHeight):
(WebCore::RenderTextControl::textBlockWidth):
(WebCore::RenderTextControl::calcHeight):
(WebCore::RenderTextControl::calcPrefWidths):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::updateWidgetPosition):
2010-04-23 David Kilzer <ddkilzer@apple.com>
Size mismatch between format string and argument in dumpTextEncodingNameMap()
Reviewed by Darin Adler.
See Bug 38030 and r58157.
* platform/text/TextEncodingRegistry.cpp:
(WebCore::dumpTextEncodingNameMap): Assigned
textEncodingNameMap->size() to an unsigned variable before using
it in the fprintf() statement.
2010-04-23 David Kilzer <ddkilzer@apple.com>
BUILD FIX: Attempt to fix Windows build after Bug 36187 landed in r58168
* DerivedSources.cpp: Changed include of JSMedia.cpp to
JSStyleMedia.cpp.
2010-04-23 David Kilzer <ddkilzer@apple.com>
BUILD FIX: Fix Mac build after Bug 36187 landed in r58168
* WebCore.xcodeproj/project.pbxproj: Renamed DOMMedia.h,
DOMMedia.mm, DOMMediaInternal.h to DOMStyleMedia.h,
DOMStyleMedia.mm, DOMStyleMediaInternal.h.
2010-04-23 Kenneth Rohde Christiansen <kenneth@webkit.org>
Unreviewed build fix.
Change Media to StyleMedia
* DerivedSources.make:
2010-04-23 Xan Lopez <xlopez@igalia.com>
Try to fix the GTK+ bots.
* GNUmakefile.am:
2010-04-22 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Laszlo Gombos.
Rename window.media to window.styleMedia
https://bugs.webkit.org/show_bug.cgi?id=36187
Rename the interface Media to StyleMedia as required by the
new CSSOM View spec.
* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/Media.cpp: Removed.
* css/Media.h: Removed.
* css/Media.idl: Removed.
* css/StyleMedia.cpp: Added.
(WebCore::StyleMedia::StyleMedia):
(WebCore::StyleMedia::type):
(WebCore::StyleMedia::matchMedium):
* css/StyleMedia.h: Added.
(WebCore::StyleMedia::create):
(WebCore::StyleMedia::disconnectFrame):
* css/StyleMedia.idl: Added.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::styleMedia):
* page/DOMWindow.h:
(WebCore::DOMWindow::optionalMedia):
* page/DOMWindow.idl:
2010-04-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: provide JSC implementation for scopeType method on
call frame and use same jsvascript code for JSC and v8 when collecting
scope chain data.
https://bugs.webkit.org/show_bug.cgi?id=37663
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::currentCallFrame):
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::scopeType):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::currentCallFrameCallback):
* inspector/InjectedScriptHost.idl:
* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor.):
2010-04-23 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Audits (Image Dimensions): full image URLs are prefixed with the hosting page name
https://bugs.webkit.org/show_bug.cgi?id=37988
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
2010-04-23 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: Flaky Inspector tests.
https://bugs.webkit.org/show_bug.cgi?id=36217
* inspector/InspectorController.cpp:
(WebCore::InspectorController::didCommitLoad):
2010-04-23 Yaar Schnitman <yaar@chromium.org>
Reviewed by Adam Barth.
Auto-generate WebGLRenderingContext overloads in V8
https://bugs.webkit.org/show_bug.cgi?id=37818
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
* html/canvas/WebGLRenderingContext.cpp: Added missing overloads for the following:.
(WebCore::WebGLRenderingContext::texImage2D)
(WebCore::WebGLRenderingContext::texSubImage2D)
* html/canvas/WebGLRenderingContext.h: Added missing overloads.
* html/canvas/WebGLRenderingContext.idl: IDL definition of overloads.
2010-04-23 Jeff Schiller <codedread@gmail.com>
Reviewed by Nikolas Zimmermann.
Display tooltips when hovering over SVG elements, Bug 16854
https://bugs.webkit.org/show_bug.cgi?id=16854
Manual test added for verifying tooltips.
* manual-tests/svg-tooltip.svg: Added.
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::title): xlink:title takes precedence, otherwise SVGStyledElement::title() is used
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::title): checks for a shadow parent and uses that title, otherwise uses the content's title
* svg/SVGStyledElement.h: add title() method declaration
2010-04-23 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/38032> No need to content sniff 304 responses
<rdar://problem/7891726>
Reviewed by Brady Eidson.
* platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
No need to adjust the MIME type on 304 responses since they're
only used to determine if the resource needs to be refetched.
2010-04-23 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/38030> Add WebCore::dumpTextEncodingNameMap() to dump text encoding map on debug builds
Reviewed by Alexey Proskuryakov.
* platform/text/TextEncodingRegistry.cpp:
(WebCore::dumpTextEncodingNameMap): Added.
* platform/text/TextEncodingRegistry.h:
(WebCore::dumpTextEncodingNameMap): Added declaration.
2010-04-22 Tony Chang <tony@chromium.org>
Reviewed by Dan Bernstein.
Crash in WebCore::TextIterator::handleTextNode() encountered in Google rich-text products
https://bugs.webkit.org/show_bug.cgi?id=37950
Test: editing/text-iterator/rtl-selection-crash.html
* editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextNode):
2010-04-22 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein and Beth Dakin.
Links around blocks (e.g. divs) results in too many VoiceOver call outs
https://bugs.webkit.org/show_bug.cgi?id=37079
<rdar://problem/7234118>
The basic change is to modify the AccessibilityRenderObject tree
traversal methods to account for inline continuations in the
render tree and make the accessibility tree look as if
continuations didn't exist - the same as if CSS blocks could just
sit in CSS inlines. This is slightly tricky code but creates a
much saner accessibility tree.
Tests: accessibility/image-link-inline-cont.html
accessibility/image-link.html
accessibility/inline-continuations.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::isInlineWithContinuation): Helper function for traversal functions to use in accounting for continuations.
(WebCore::firstChildInContinuation): ditto
(WebCore::firstChildConsideringContinuation): ditto
(WebCore::lastChildConsideringContinuation): ditto
(WebCore::startOfContinuations): ditto
(WebCore::endOfContinuations): ditto
(WebCore::childBeforeConsideringContinuations): ditto
(WebCore::firstChildIsInlineContinuation): ditto
(WebCore::lastChildHasContinuation): ditto
(WebCore::AccessibilityRenderObject::firstChild): Account for inline continuations.
(WebCore::AccessibilityRenderObject::lastChild): ditto
(WebCore::AccessibilityRenderObject::previousSibling): Account for inline continuations
and their anonymous block parents.
(WebCore::AccessibilityRenderObject::nextSibling): ditto
(WebCore::AccessibilityRenderObject::parentObjectIfExists): Account for inline continuations.
(WebCore::AccessibilityRenderObject::parentObject): Account for inline continuations.
* rendering/RenderInline.h: Make RenderInline::inlineContinuation public.
2010-04-22 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
REGRESSION: TextIterator may use freed memory
https://bugs.webkit.org/show_bug.cgi?id=37973
Added TextIterator::m_text to hold the returned String.
No new tests because there are no behavior change, but
copy-backslash-with-euc.html on chromium-win should test this.
* editing/TextIterator.cpp:
(WebCore::TextIterator::emitText):
* editing/TextIterator.h:
2010-04-22 Michael Forney <mforney@mforney.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=37761
Only include JSDatabase.h and JSDatabaseCallback.h when database is
enabled. This partially fixes building with --disable-database.
* bindings/js/JSDOMWindowCustom.cpp: Add a check for database around
database-related headers.
2010-04-22 Ray Rischpater <Raymond.Rischpater@Nokia.com>
Reviewed by Darin Adler.
In HTMLInputElement.cpp, shouldUseInputMethod does not return true for
some text input types (TELEPHONE, NUMBER, URL, and EMAIL). Addressed
this by changing shouldUseInputMethod to use internal methods to
check that the field is a text field that isn't a password field.
No new tests.
Fixes <https://bugs.webkit.org/show_bug.cgi?id=37719>
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::shouldUseInputMethod):
2010-04-22 Yaar Schnitman <yaar@chromium.org>
Reviewed by Adam Barth.
Integrate v8 testing utility with webkit tests
https://bugs.webkit.org/show_bug.cgi?id=37731
* bindings/v8/test/run_tests.py: Removed.
2010-04-22 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Fisher.
Add isGLES2Compliant to GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=37872
* html/canvas/WebGLRenderingContext.cpp: Add isGLES2Compliant().
(WebCore::WebGLRenderingContext::isGLES2Compliant):
* html/canvas/WebGLRenderingContext.h: Ditto.
* platform/graphics/GraphicsContext3D.h: Ditto.
* platform/graphics/mac/GraphicsContext3DMac.cpp: Ditto.
(WebCore::GraphicsContext3D::isGLES2Compliant):
2010-04-22 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Adam Barth.
MD5 is required for WebSocket new protocol implementation
https://bugs.webkit.org/show_bug.cgi?id=37913
* ForwardingHeaders/wtf/MD5.h: Added.
2010-04-22 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=38012
REGRESSION: Ctrl- and Option- shortcuts get wrong keyCode on non-QWERTY keyboard
* platform/mac/KeyEventMac.mm: (WebCore::windowsKeyCodeForKeyEvent): Also look at unmodified
characters, to avoid falling through to virtual key code lookup for Roman characters.
2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Darin Adler.
Fix the MSVC 64bit build.
https://bugs.webkit.org/show_bug.cgi?id=37980
* platform/text/TextStream.cpp:
* platform/text/TextStream.h:
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::platformStart):
2010-04-22 Dave Moore <davemoore@chromium.org>
Reviewed by Dimitri Glazkov.
Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
https://bugs.webkit.org/show_bug.cgi?id=33812
Test: fast/dom/icon-url-property.html
* dom/Document.cpp:
(WebCore::Document::setIconURL):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setIconURL):
* loader/DocumentLoader.h:
(WebCore::DocumentLoader::iconURL):
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::setIconURL):
(WebCore::FrameLoader::didChangeIcons):
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
2010-04-22 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590
Extend the bindings to cover most of Document.idl
* GNUmakefile.am:
* bindings/gobject/WebKitDOMBinding.cpp:
(WebKit::createWrapper):
(WebKit::kit):
* bindings/gobject/WebKitDOMBinding.h:
* bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Added.
(WebKit::createAnchorWrapper):
(WebKit::createAppletWrapper):
(WebKit::createAreaWrapper):
(WebKit::createBaseWrapper):
(WebKit::createBaseFontWrapper):
(WebKit::createBlockquoteWrapper):
(WebKit::createBodyWrapper):
(WebKit::createBRWrapper):
(WebKit::createButtonWrapper):
(WebKit::createCanvasWrapper):
(WebKit::createTableCaptionWrapper):
(WebKit::createTableColWrapper):
(WebKit::createModWrapper):
(WebKit::createDirectoryWrapper):
(WebKit::createDivWrapper):
(WebKit::createDListWrapper):
(WebKit::createEmbedWrapper):
(WebKit::createFieldSetWrapper):
(WebKit::createFontWrapper):
(WebKit::createFormWrapper):
(WebKit::createFrameWrapper):
(WebKit::createFrameSetWrapper):
(WebKit::createHeadingWrapper):
(WebKit::createHeadWrapper):
(WebKit::createHRWrapper):
(WebKit::createHtmlWrapper):
(WebKit::createIFrameWrapper):
(WebKit::createImageWrapper):
(WebKit::createInputWrapper):
(WebKit::createIsIndexWrapper):
(WebKit::createLabelWrapper):
(WebKit::createLegendWrapper):
(WebKit::createLIWrapper):
(WebKit::createLinkWrapper):
(WebKit::createMapWrapper):
(WebKit::createMarqueeWrapper):
(WebKit::createMenuWrapper):
(WebKit::createMetaWrapper):
(WebKit::createObjectWrapper):
(WebKit::createOListWrapper):
(WebKit::createOptGroupWrapper):
(WebKit::createOptionWrapper):
(WebKit::createParagraphWrapper):
(WebKit::createParamWrapper):
(WebKit::createPreWrapper):
(WebKit::createQuoteWrapper):
(WebKit::createScriptWrapper):
(WebKit::createSelectWrapper):
(WebKit::createStyleWrapper):
(WebKit::createTableWrapper):
(WebKit::createTableSectionWrapper):
(WebKit::createTableCellWrapper):
(WebKit::createTextAreaWrapper):
(WebKit::createTitleWrapper):
(WebKit::createTableRowWrapper):
(WebKit::createUListWrapper):
(WebKit::createHTMLElementWrapper):
* bindings/gobject/WebKitHTMLElementWrapperFactory.h: Added.
* bindings/scripts/CodeGeneratorGObject.pm:
* dom/Node.idl:
2010-04-22 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Do not pause movie when readyState drops below HAVE_FUTURE_DATA
https://bugs.webkit.org/show_bug.cgi?id=37991
<rdar://problem/7893937>
No new tests, we don't have infrastructure in DRT to test with streamed
movies.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_readyStateMaximum.
(WebCore::HTMLMediaElement::prepareForLoad): Reset m_readyStateMaximum.
(WebCore::HTMLMediaElement::setReadyState): Maintain m_readyStateMaximum.
(WebCore::HTMLMediaElement::potentiallyPlaying): Also return true if the readyState was
previously >= HAVE_FUTURE_DATA.
* html/HTMLMediaElement.h:
2010-04-22 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Regression: framebufferRenderbuffer crashes with null renderBuffer
https://bugs.webkit.org/show_bug.cgi?id=37963
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::framebufferRenderbuffer): Dealing with null renderbuffer input.
2010-04-22 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Emulate GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE for glGet
https://bugs.webkit.org/show_bug.cgi?id=37281
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::WebGLRenderingContext): Remove error check because two enums are supported now.
(WebCore::WebGLRenderingContext::getParameter): Add two enums.
(WebCore::WebGLRenderingContext::readPixels): Fix a tiny bug.
* platform/graphics/mac/GraphicsContext3DMac.cpp:
(WebCore::GraphicsContext3D::getIntegerv): Emulate two enums.
2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[GTK] Mute/unmute button on <video> elements are backwards
https://bugs.webkit.org/show_bug.cgi?id=33967
Fix mute/unmute buttons icons-action relation and explain why their
variable names and corresponding icons seem to be misleading but are
actually right. Original patch by Mike Hommey.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::initMediaStyling):
2010-04-22 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Reviewed by Eric Seidel.
Fix build if NPAPI support is disabled
https://bugs.webkit.org/show_bug.cgi?id=36621
No new tests, this is a build fix.
Re-submit r58043 with fix for EFL.
* plugins/PluginViewNone.cpp:
2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449
Implement ATK_ROLE_COMBO_BOX.
* accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(atkRole):
2010-04-22 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
SVGPaintServer needs to be converted to the new RenderSVGResource* system
https://bugs.webkit.org/show_bug.cgi?id=37986
No functional changes, just move the SVGPaintServer* classes from svg/graphics/ to rendering/, the new location for the RenderSVGResource* classes.
This is a preparation for the real patch which follows soon.
* Android.mk: Rename files and move to the right location.
* GNUmakefile.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* rendering/RenderSVGResource.cpp: Copied from svg/graphics/SVGPaintServer.cpp.
* rendering/RenderSVGResourceGradient.cpp: Copied from svg/graphics/SVGPaintServerGradient.cpp.
* rendering/RenderSVGResourceGradient.h: Copied from svg/graphics/SVGPaintServerGradient.h.
* rendering/RenderSVGResourceLinearGradient.cpp: Copied from svg/graphics/SVGPaintServerLinearGradient.cpp.
* rendering/RenderSVGResourceLinearGradient.h: Copied from svg/graphics/SVGPaintServerLinearGradient.h.
* rendering/RenderSVGResourcePattern.cpp: Copied from svg/graphics/SVGPaintServerPattern.cpp.
* rendering/RenderSVGResourcePattern.h: Copied from svg/graphics/SVGPaintServerPattern.h.
* rendering/RenderSVGResourceRadialGradient.cpp: Copied from svg/graphics/SVGPaintServerRadialGradient.cpp.
* rendering/RenderSVGResourceRadialGradient.h: Copied from svg/graphics/SVGPaintServerRadialGradient.h.
* rendering/RenderSVGResourceSolidColor.cpp: Copied from svg/graphics/SVGPaintServerSolid.cpp.
* rendering/RenderSVGResourceSolidColor.h: Copied from svg/graphics/SVGPaintServerSolid.h.
* rendering/SVGRenderTreeAsText.cpp: Change include file names.
* svg/SVGFont.cpp: Ditto.
* svg/SVGGradientElement.cpp: Ditto.
* svg/SVGGradientElement.h: Ditto.
* svg/SVGLinearGradientElement.cpp: Ditto.
* svg/SVGPatternElement.cpp: Ditto.
* svg/SVGPatternElement.h: Ditto.
* svg/SVGRadialGradientElement.cpp: Ditto.
* svg/graphics/SVGPaintServer.cpp: Removed.
* svg/graphics/SVGPaintServerGradient.cpp: Removed.
* svg/graphics/SVGPaintServerGradient.h: Removed.
* svg/graphics/SVGPaintServerLinearGradient.cpp: Removed.
* svg/graphics/SVGPaintServerLinearGradient.h: Removed.
* svg/graphics/SVGPaintServerPattern.cpp: Removed.
* svg/graphics/SVGPaintServerPattern.h: Removed.
* svg/graphics/SVGPaintServerRadialGradient.cpp: Removed.
* svg/graphics/SVGPaintServerRadialGradient.h: Removed.
* svg/graphics/SVGPaintServerSolid.cpp: Removed.
* svg/graphics/SVGPaintServerSolid.h: Removed.
* svg/graphics/SVGResourceListener.h: Removed.
2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Hide the OpenGL and QtMultimedia dependencies from syncqt.
This prevents the dependent headers from being included by
qt/include/QtWebKit/QtWebKit
* WebCore.pro:
2010-04-22 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Reviewed by Adam Roben.
EFL does not support PluginDatabase yet.
http://webkit.org/b/37854
No behavior changes, so no new tests were added.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::defaultObjectContentType):
2010-04-22 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Timeline scrolling speed is slow if it has more than 1k timeline marks.
https://bugs.webkit.org/show_bug.cgi?id=37924
* inspector/front-end/TimelineGrid.js:
(WebInspector.TimelineGrid.prototype.updateDividers):
(WebInspector.TimelineGrid.prototype.addEventDividers):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype.updateEventDividers):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._refresh):
2010-04-22 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Fraser.
Rename window.media to window.styleMedia
https://bugs.webkit.org/show_bug.cgi?id=36187
It has been defined that the AbstractView media extension
defined in the CSSOM View spec should be renamed to styleMedia.
This patch does that and updates the current layout tests
making use of it.
* page/AbstractView.idl:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::styleMedia):
* page/DOMWindow.h:
* page/DOMWindow.idl:
2010-04-22 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Do not pass empty handle into SetHiddenValue which would crash.
https://bugs.webkit.org/show_bug.cgi?id=37801
* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::handleEvent): add couple of asserts to check for unexpected paths
(WebCore::V8AbstractEventListener::invokeEventHandler): bail out of jsEvent is empty handle
2010-04-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by David Levin.
[Haiku] Implement ImageBuffer support
https://bugs.webkit.org/show_bug.cgi?id=35288
Covered by existing tests.
Complete implementation of ImageBuffer for Haiku. Uses StillImage
class to export a WebCore::Image and associated GraphicsContext
to perform arbitrary drawing in the offscreen BBitmap buffer.
* platform/graphics/haiku/ImageBufferData.h:
* platform/graphics/haiku/ImageBufferHaiku.cpp,
(WebCore::ImageBufferData::ImageBufferData),
(WebCore::ImageBufferData::~ImageBufferData),
(WebCore::ImageBuffer::ImageBuffer),
(WebCore::ImageBuffer::~ImageBuffer),
(WebCore::ImageBuffer::context),
(WebCore::ImageBuffer::image):
Implementation uses offscreen BBitmap and BView, wraps StillImage
around those to provide WebCore::Image interface.
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::convertFromData):
Method just performs BGRA <-> RGBA conversion.
(WebCore::convertFromInternalData):
Method just performs BGRA <-> RGBA conversion and handles
pre-multiplying the color values if requested.
(WebCore::convertToInternalData):
Method just performs BGRA <-> RGBA conversion and handles
de.multiplying the color values if requested.
(WebCore::getImageData):
Common code for the next two methods.
(WebCore::ImageBuffer::getUnmultipliedImageData),
(WebCore::ImageBuffer::getPremultipliedImageData):
Implemented.
(WebCore::putImageData):
Common code for the next two methods.
(WebCore::ImageBuffer::putUnmultipliedImageData),
(WebCore::ImageBuffer::putPremultipliedImageData):
Implemented.
(WebCore::ImageBuffer::toDataURL):
Uses Haiku "Translation Kit" to convert image data to data
of the requested mime type.
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed, rolling out r58069.
http://trac.webkit.org/changeset/58069
https://bugs.webkit.org/show_bug.cgi?id=27751
Broke compile on Windows.
* WebCore.base.exp:
* editing/EditorCommand.cpp:
(WebCore::supportedPaste):
(WebCore::createCommandMap):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
2010-04-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751
Test: editing/execCommand/clipboard-access.html
* WebCore.base.exp:
* editing/EditorCommand.cpp:
(WebCore::supportedCopyCut):
(WebCore::supportedPaste):
(WebCore::createCommandMap):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setJavaScriptCanAccessClipboard):
* page/Settings.h:
(WebCore::Settings::javaScriptCanAccessClipboard):
2010-04-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by David Levin.
[Haiku] Improve SimpleFontDataHaiku
https://bugs.webkit.org/show_bug.cgi?id=37411
Covered by existing tests.
* platform/graphics/haiku/SimpleFontDataHaiku.cpp:
- Cleaned up includes
- Removed prototype "charUnicodeToUTF8HACK"
(WebCore::SimpleFontData::platformInit):
- Use const BFont pointer
(WebCore::SimpleFontData::smallCapsFontData):
- "fontPlatformData" was leaked. It is only
used as the key for the font cache lookup.
(WebCore::SimpleFontData::platformMetricsForGlyph):
- Use existing WebCore encoding infrastructure
instead of adding a hack for Haiku.
2010-04-21 Steve Block <steveblock@google.com>
Reviewed by Kenneth Rohde Christiansen.
Replace Geolocation::suspend()/resume() which are required by Android.
https://bugs.webkit.org/show_bug.cgi?id=37942
These methods were removed in Bug 36255.
Build fix only, no new tests.
* page/Geolocation.cpp:
(WebCore::Geolocation::suspend):
(WebCore::Geolocation::resume):
* page/Geolocation.h:
2010-04-21 Ray Rischpater <Raymond.Rischpater@Nokia.com>
In HTMLInputElement.cpp there are numerous style
violations.
This patch includes style changes to fix existing style
deviations in this file.
Rubber stamped by Darin Adler.
Fixes <https://bugs.webkit.org/show_bug.cgi?id=37881>
* html/HTMLInputElement.cpp:
2010-04-21 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Reviewed by Adam Roben.
Add missing EFL WebCore file.
http://webkit.org/b/37854
No behavior changes, so no new tests were added.
* bindings/js/ScriptControllerEfl.cpp: Added.
(WebCore::ScriptController::createScriptInstanceForWidget):
2010-04-21 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Printing Core Animation-based plug-ins is broken
https://bugs.webkit.org/show_bug.cgi?id=37967
When we do a "flattening" paint because of printing, we need to stash
the flattening flag in the FrameView's m_paintBehavior, because
WebBaseNetscapePluginView needs to find it there to decide whether
to grab a bitmap for printing, for CA plug-ins.
* page/FrameView.cpp:
(WebCore::FrameView::paintContents):
2010-04-21 François Sausset <sausset@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
Fix to take into account a change made in "StringImpl".
https://bugs.webkit.org/show_bug.cgi?id=37763
* mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::updateFromElement):
2010-04-21 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
Create a template for creating reference-counted Windows GDI handles.
Refactor RefCountedHFONT to use this template.
https://bugs.webkit.org/show_bug.cgi?id=37952
No change in behavior.
* WebCore.vcproj/WebCore.vcproj: Add RefCountedHFONT.h
* platform/graphics/cairo/FontPlatformData.h:
(WebCore::FontPlatformData::hfont): Refactor to return m_hfont->handle() instead of m_hfont->hfont().
* platform/graphics/cg/FontPlatformData.h:
(WebCore::FontPlatformData::hfont): Same.
* platform/graphics/win/FontPlatformDataCGWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Instantiate m_hfont with a RefCountedGDIHandle<HFONT>.
* platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Same.
* platform/graphics/win/RefCountedGDIHandle.h: Added. Interface is identical to RefCountedHFONT with exception of renaming hfont() to handle().
(WebCore::RefCountedGDIHandle::create):
(WebCore::RefCountedGDIHandle::createDeleted):
(WebCore::RefCountedGDIHandle::~RefCountedGDIHandle):
(WebCore::RefCountedGDIHandle::handle): Return the GDI handle.
(WebCore::RefCountedGDIHandle::hash):
(WebCore::RefCountedGDIHandle::RefCountedGDIHandle):
* platform/graphics/win/RefCountedHFONT.h: Removed.
2010-04-21 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
Fix build if NPAPI support is disabled
https://bugs.webkit.org/show_bug.cgi?id=36621
No new tests, this is a build fix.
Re-submit r56585 with fix for Chromium.
* plugins/PluginView.cpp: Guard getValueStatic() with
NETSCAPE_PLUGIN_API
(WebCore::PluginView::getValue):
* plugins/PluginView.h: Guard getValue() with NETSCAPE_PLUGIN_API
* plugins/PluginViewNone.cpp: Guard platformGetValue() and
platformGetValueStatic with NETSCAPE_PLUGIN_API;
Guard privateBrowsingStateChanged() and setJavaScriptPaused() with
PLATFORM(MAC) or PLATFORM(CHROMIUM)
2010-04-21 David Yonge-Mallo <davinci@chromium.org>
Reviewed by Dan Bernstein.
ZWNJ - Display non-printing, invisible character
https://bugs.webkit.org/show_bug.cgi?id=16131
Fix the (non)display of glyphs for ZWJ and ZWNJ in simple font code path.
Tests: fast/text/format-control.html
fast/text/zero-width-characters.html
* platform/graphics/Font.h:
(WebCore::Font::operator!=):
(WebCore::Font::treatAsZeroWidthSpace): treat ZWNJ and ZWJ as ZWSP.
* platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage): added ZWNJ and ZWJ.
* platform/text/CharacterNames.h: added ZWNJ and ZWJ.
2010-04-21 Charles Wei <charles.wei@torchmobile.com.cn>
Reviewed by George Staikos.
Fix webkit build problem when xhtmlmp enabled, which is introduced by revision 57927, for
bug fix of 37175 , which seperates DocumentWriter from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37915
No new tests since this only fixes the build problem.
* dom/Document.cpp:
(WebCore::Document::isXHTMLMPDocument):
2010-04-21 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Call sites of TextIterator constructor are difficult to read
https://bugs.webkit.org/show_bug.cgi?id=37909
Now we use enum parameters instead of boolean parameters and
boolean version of constructors are eliminated.
This change also changes the names of boolean members so they are
now third person singular.
No new tests because this is just a refactoring.
* WebCore.base.exp:
* editing/TextIterator.cpp:
(WebCore::TextIterator::TextIterator):
(WebCore::TextIterator::advance):
(WebCore::TextIterator::handleReplacedElement):
(WebCore::TextIterator::shouldRepresentNodeOffsetZero):
(WebCore::TextIterator::shouldEmitSpaceBeforeAndAfterNode):
(WebCore::TextIterator::handleNonTextNode):
(WebCore::TextIterator::exitNode):
(WebCore::TextIterator::emitCharacter):
(WebCore::TextIterator::emitText):
(WebCore::CharacterIterator::CharacterIterator):
(WebCore::TextIterator::rangeLength):
(WebCore::TextIterator::rangeFromLocationAndLength):
(WebCore::findPlainText):
* editing/TextIterator.h:
(WebCore::):
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::appendTrailingWhitespace):
* editing/visible_units.cpp:
(WebCore::nextBoundary):
2010-04-21 Jesus Sanchez-Palencia <jesus@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Add PageClientQt files.
[Qt] PageClientQt specific implementation for QWidget
https://bugs.webkit.org/show_bug.cgi?id=37858
* WebCore.pro:
2010-04-21 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449
Implement ATK_ROLE_SEPARATOR.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
* accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
2010-04-21 David Leong <david.leong@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Symbian apps crash on exit due to a bad qObject_cast.
https://bugs.webkit.org/show_bug.cgi?id=37303
Added check for NULL to avoid the crash. Reworked to fix memory leak
* plugins/symbian/PluginViewSymbian.cpp:
(WebCore::PluginView::platformDestroy):
2009-04-21 Chris Fleizach <cfleizach@apple.com>
Reviewed by Alexey Proskuryakov.
aria-liveregion-notifications.html fails on leopard release bot
https://bugs.webkit.org/show_bug.cgi?id=37112
Change the method that DRT uses to monitor AX notifications so that its robust
by just sending out NSNotification that can be listened to by anyone, instead
of keeping a static function pointer around.
This change is aimed to avoid flakiness seen in DRT when the notification handlers
are not being called at the appropriate time.
Tests: platform/mac/accessibility/aria-liveregions-addedelement.html
platform/mac/accessibility/aria-liveregions-changedalt.html
platform/mac/accessibility/aria-liveregions-changedtext.html
platform/mac/accessibility/aria-liveregions-removedelement.html
* accessibility/mac/AccessibilityObjectWrapper.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilitySetShouldRepostNotifications:]):
(-[AccessibilityObjectWrapper accessibilityPostedNotification:]):
2010-04-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Leopard build fix).
Remove old exports.
* WebCore.base.exp:
2010-04-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler.
Bug 37949 - Do no copy strings into a shared buffer when converting UStrings to Strings
UString and String now have the same internal representation; Just re-wrap the internal impl.
* bindings/js/JSDOMBinding.cpp:
(WebCore::jsStringSlowCase):
* bindings/js/JSDOMBinding.h:
(WebCore::ustringToString):
(WebCore::stringToUString):
(WebCore::identifierToString):
(WebCore::ustringToAtomicString):
(WebCore::identifierToAtomicString):
2010-04-21 Mark Rowe <mrowe@apple.com>
Reviewed by Eric Carlson.
<rdar://problem/7313430> Many crashes in Safari inside Flip4Mac below -[NSAlert didEndAlert:returnCode:contextInfo:]
A manual test case is required here as the Flip4Mac plug-in displays an alert, and some manual tweaking of the plug-in's
preference file on disk is often required to reproduce the bug.
* manual-tests/plugins/flip4mac-update-alert-over-navigation.html: Added.
2010-04-21 Mark Rowe <mrowe@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/7856151> REGRESSION: NPP_Destroy is not called when page navigates when plug-in is displaying modal dialog
This is a manual test case as I was not able to construct an automated test that reproduced the same issue without displaying
a modal dialog on-screen.
* manual-tests/plugins/timeout-dialog-displayed-over-navigation.html: Added.
* manual-tests/plugins/timeout-dialog-displayed-over-navigation.swf: Added.
2010-04-21 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Fix for https://bugs.webkit.org/show_bug.cgi?id=37937
Wean JavaScriptCore off calls to isMainThread()
No change in behavior.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonJSGlobalData):
Explicitly set a large stack type for the common JSGlobalData and
set the currently running thread as the exclusive thread for its
execution.
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::WorkerScriptController):
Explicitly set a small stack type for the workers JSGlobalData.
2010-04-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Qt build fix).
* WebCore.gypi:
* WebCore.pro:
* platform/text/qt/StringQt.cpp: Removed.
2010-04-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt, Darin Adler.
Bug 37906 - Remove JSC::UStringImpl; unify with StringImpl.
Add include for StringHash.h.
* WebCore.xcodeproj/project.pbxproj:
* bridge/c/c_class.cpp:
2010-04-21 Alexey Proskuryakov <ap@apple.com>
Tiger build fix.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::createNSURLConnection): Fixed a typo, named an argument.
(WebCore::ResourceHandle::start): Moved shouldUseCredentialStorage out of #if, since it's
now passed to createNSURLConneciton() on all platforms (and then ignored on Tiger).
2010-04-21 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Roben.
Windows build fix.
* platform/network/cf/ResourceHandleCFNet.cpp: Declare CFURLConnectionCreateWithProperties
for now, as it's mistakenly missing from WebKitSupportLibrary headers.
2010-04-21 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r57292): Safari/Win and Chromium/Win no longer pass the acid3 test.
https://bugs.webkit.org/show_bug.cgi?id=37902
The issue is due to MSVC creating enums as signed. The fix is to store the value
as unsigned.
Test: http://acid3.acidtests.org/
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags): Changed type of _insideLink to unsigned.
2010-04-21 Alexey Proskuryakov <ap@apple.com>
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=37933
<rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
Test: http/tests/xmlhttprequest/cross-origin-authorization-with-embedder.html
This improves integration between ResourceHandle and Apple networking libraries.
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::createConnectionProperties): A new helper for creating connection properties dictionary.
(WebCore::ResourceHandle::start): Pass connection properties.
(WebCore::WebCoreSynchronousLoader::load): Ditto.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::createNSURLConnection): Factor out OS version dependent code for creating
NSURLConnection. Tell NSURLConnection about credential policy upfront.
(WebCore::ResourceHandle::start): Use the new function.
(+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Ditto.
2010-04-21 Xiaomei Ji <xji@chromium.org>
Reviewed by Dimitri Glazkov
This patch fixes [chromium] RTL <select> dropdown box expands to right
instead of left.
https://bugs.webkit.org/show_bug.cgi?id=37232
No automatic test is possible.
* manual-tests/select_dropdown_box_alignment.html: Added.
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupContainer::layout): Adjust the x-axis of dropdown box
for RTL.
2010-04-21 anton muhin <antonm@google.com>
Reviewed by Adam Barth.
[v8] Bail out if fetching of Object.prototype fails.
https://bugs.webkit.org/show_bug.cgi?id=37661
If for any reason we failed to fetch Object.prototype, context cannot
be properly initialized and we bail out.
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded): bail out if installHiddenObjectPrototype failed
(WebCore::V8DOMWindowShell::installHiddenObjectPrototype): bail out if failed to fetch Object.prototype
* bindings/v8/V8DOMWindowShell.h: return false if installHiddenObjectPrototype failed
2010-04-21 Timothy Hatcher <timothy@apple.com>
Make UserContentURLPattern correctly check for subdomains and the URL
has the same suffix as the pattern. Also improve the parsing of the host.
https://bugs.webkit.org/show_bug.cgi?id=37357
Reviewed by Darin Adler.
* page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse): Simplify the subdomain pattern parsing to
simply check for "*" only or a "*." prefix and then do a substring.
(WebCore::UserContentURLPattern::matchesHost): Check that the host has a "." in the
position before the suffix to ensure it a subdomain and not just a suffix match.
2010-04-21 Xan Lopez <xlopez@igalia.com>
Try to fix compilation on GTK+ debug bots.
* bindings/gobject/WebKitDOMBinding.cpp:
(WebKit::createWrapper):
2010-04-21 Jakub Wieczorek <jwieczorek@webkit.org>
Reviewed by Darin Adler.
List item markers are not always updated after changes in the DOM.
https://bugs.webkit.org/show_bug.cgi?id=37060
In particular, they would not be updated when adding/removing an item
that is not a direct child of the list element.
Tests: fast/lists/ol-nested-items-dynamic-insert.html
fast/lists/ol-nested-items-dynamic-remove.html
fast/lists/ol-nested-items.html
fast/lists/ol-nested-list-dynamic-insert.html
fast/lists/ol-nested-list-dynamic-remove.html
fast/lists/ol-nested-list.html
* rendering/RenderListItem.cpp:
(WebCore::updateListMarkerNumbers): Change it to traverse the whole subtree of a list, not only siblings of an item.
* rendering/RenderListItem.h:
* rendering/RenderObject.cpp: Move the updateListMarkerNumbers function to RenderListItem.cpp.
(WebCore::RenderObject::addChild): Move the code updating list markers to RenderObjectChildList for consistency.
* rendering/RenderObjectChildList.cpp: Move the updateListMarkerNumbers function to RenderListItem.cpp.
(WebCore::RenderObjectChildList::removeChildNode): Pass the actual node being removed, not the next sibling.
(WebCore::RenderObjectChildList::appendChildNode): Pass the actual node being added, not the next sibling.
(WebCore::RenderObjectChildList::insertChildNode): Pass the actual node being added, not the next sibling.
* rendering/RenderTreeAsText.cpp:
(WebCore::markerTextForListItem):
2010-04-21 Xan Lopez <xlopez@igalia.com>
Reviewed by Adam Barth.
[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590
Initial version of the GObject DOM bindings.
Only bindings for Node.idl and a few of its dependencies are
provided, without public API to access them at the
moment. References to the Document interfaces and to
EventListeners in Node.idl are ignored for GObject to make the
initial patch as small as possible, but will be enabled in a
follow-up patch.
* GNUmakefile.am:
* bindings/gobject/ConvertToUTF8String.cpp: Added.
(convertToUTF8String):
* bindings/gobject/ConvertToUTF8String.h: Added.
* bindings/gobject/WebKitDOMBinding.cpp: Added.
(WebKit::domObjects):
(WebKit::DOMObjectCache::get):
(WebKit::DOMObjectCache::put):
(WebKit::DOMObjectCache::forget):
(WebKit::createWrapper):
(WebKit::kit):
* bindings/gobject/WebKitDOMBinding.h: Added.
* bindings/gobject/WebKitDOMObject.cpp: Added.
(webkit_dom_object_init):
(webkit_dom_object_class_init):
* bindings/gobject/WebKitDOMObject.h: Added.
* bindings/scripts/CodeGeneratorGObject.pm: Added.
* bindings/scripts/gobject-generate-headers.pl: Added.
* dom/Node.idl:
2010-04-21 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Reviewed by Xan Lopez.
Wrong header being included in FontPlatformDataCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=37829
No behavior changes, so no new tests were added.
* platform/graphics/cairo/FontPlatformDataCairo.cpp:
2010-04-21 Adam Roben <aroben@apple.com>
Fix leaks of FilterData/SVGFilterBuilder in RenderSVGResourceFilter
Fixes <http://webkit.org/b/37922>.
Reviewed by Dave Hyatt.
* rendering/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource): Use an OwnPtr to
hold the heap-allocated FilterData object, so that we won't leak it
when we bail out of this function on error.
2010-04-21 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] startAnimation() is not needed to preceede nativeImageForCurrentFrame()
https://bugs.webkit.org/show_bug.cgi?id=37844
nativeImageForCurrentFrame() resets the m_decoder parameter under Qt,
which is required by startAnimation() to detect frame and repetition counts.
Hence, Image::drawTiled cannot start animations under Qt:
<html><body background="animated.gif"></body></html> does not work
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
2010-04-21 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Simon Fraser.
Update of fixed elements is not made correctly when the page has been scrolled
https://bugs.webkit.org/show_bug.cgi?id=36783
When a fixed element was updated, the old geometry was not repainted correctly
because the repaint rect was cached during the layout and not updated when
scrolling.
The rect is now updated while scrolling so the region updated correspond to the
region of the element on the screen.
The method RenderLayer::updateRepaintRectsAfterScroll() updates
the repaint rect of all fixed tree after scroll.
Tests: fast/repaint/fixed-child-move-after-scroll.html
fast/repaint/fixed-child-of-fixed-move-after-scroll.html
fast/repaint/fixed-child-of-transformed-move-after-scroll.html
fast/repaint/fixed-move-after-scroll.html
* page/FrameView.cpp:
(WebCore::FrameView::scrollPositionChanged):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateRepaintRectsAfterScroll):
* rendering/RenderLayer.h:
2010-04-21 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Reviewed by Adam Roben.
Update EFL port to match recent API changes.
http://webkit.org/b/37853
No behavior changes, so no new tests were added.
* platform/efl/FileSystemEfl.cpp:
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::missingPluginText):
(WebCore::crashedPluginText):
* platform/efl/MIMETypeRegistryEfl.cpp:
(WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
* platform/graphics/efl/ImageEfl.cpp:
2010-04-21 Avi Drissman <avi@chromium.org>
Reviewed by Simon Fraser.
JPG images fail to print in Chromium
https://bugs.webkit.org/show_bug.cgi?id=37796
Image sources of JPG data with final=false fail to draw into PDF contexts even if later updated (<rdar://problem/7874035>). Therefore, destroy and re-create the image source when the final data arrives.
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::setData):
2010-04-21 Marcus Bulach <bulach@chromium.org>
Reviewed by Nate Chapin.
EventSource needs to be marked as an ActiveDomType.
https://bugs.webkit.org/show_bug.cgi?id=37857
Existing layout tests (fast/eventsource and http/tests/eventsource/) should pass when compiling with eventsource enabled.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/custom/V8EventSourceConstructor.cpp:
(WebCore::V8EventSource::constructorCallback):
2010-04-21 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Reviewed by Nikolas Zimmermann.
Add missing includes to platform/posix/FileSystemPOSIX.cpp
https://bugs.webkit.org/show_bug.cgi?id=37861
No behavior changes, so no new tests were added.
* platform/posix/FileSystemPOSIX.cpp:
2010-04-21 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Simon Fraser.
[Qt] Fix or remove the runtime flag for accelerated compositing.
This adds a way for a chrome client to disallow layers from becoming composited,
even if the settings enable accelerated compositing. This is necessary for platforms
where different views can be applied with the same settings to the same page.
We enable an API through ChromeClient to ask the chrome-client whether or not
it can render composited layers, which is taken into account when the compositor
decides whether or not to start compositing.
https://bugs.webkit.org/show_bug.cgi?id=37313
Pages under LayoutTests/compositing now work under QWebView, even when
QWebSettings::AcceleratedCompositingEnabled is on.
* page/ChromeClient.h:
(WebCore::ChromeClient::allowsAcceleratedCompositing):
* platform/qt/QWebPageClient.h:
(QWebPageClient::allowsAcceleratedCompositing):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::canBeComposited):
2010-04-21 Ryosuke Niwa <rniwa@webkit.org>
No review. Spurious whitespace was removed from project file.
* WebCore.xcodeproj/project.pbxproj:
2010-04-20 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
[Qt] Build fix: warning on L933 of CompositeEditCommand.cpp
https://bugs.webkit.org/show_bug.cgi?id=37912
Replaced the ternary operator by an if statement because GCC was confused by the use of
ternary operator and producing warnings on Qt builds.
* WebCore.xcodeproj/project.pbxproj:
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs):
2010-04-20 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Justin Garcia.
Nested <ul>s are mishandled when converted to <ol> using execCommand('insertorderedlist')
https://bugs.webkit.org/show_bug.cgi?id=19539
Fixes a bug where two consecutive lists are not merged if they have been converted
from ordered/unordered lists inside another list.
The bug was caused by InsertListCommand::doApply where it did not merge a newly inserted
list element and its neighbors. This patch adds code to doApply so that after inserting
the list element, it updates previousList and nextList to the outermost list elements around
insertionPos under the same enclosing list. Because the next and the previous list elements
are not necessarily visually next to the newly inserted element before moveParagraph moves
the paragraph into the new list element, doApply merges lists after moveParagraph is called.
Test: editing/execCommand/insert-lists-inside-another-list.html
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply): Modified as described above
* editing/htmlediting.cpp:
(WebCore::outermostEnclosingList): Added rootNode. Returns the outermost list element,
which is a descendent of rootNode.
* editing/htmlediting.h:
2010-04-20 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=37776
<rdar://problem/7877716> REGRESSION: When using dvorak, keydown/keyup reports qwerty keyCodes
* platform/cocoa/KeyEventCocoa.mm: (WebCore::windowsKeyCodeForCharCode): Re-added mapping
for Roman letters and punctuation.
* platform/mac/KeyEventMac.mm: (WebCore::windowsKeyCodeForKeyEvent): Improved approximation
of IE behavior. Keyboard layouts that change location of Roman letters (like AZERTY or Dvorak)
also switch their keycodes. Also, restored Safari 4 behavior for punctuation. It's difficult
to match Windows for punctuation exactly, because keyboard layouts make arbitrary changes
to their keycodes.
2010-04-20 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler and Alexey Proskuryakov.
A backslash in EUC-JP becomes to a yen sign when it is copied
https://bugs.webkit.org/show_bug.cgi?id=36419
Tests: editing/execCommand/transpose-backslash-with-euc.html
editing/pasteboard/copy-backslash-with-euc.html
* editing/Editor.cpp: Remove an unnecessary displayStringModifiedByEncoding calls.
(WebCore::Editor::addToKillRing):
* editing/TextIterator.cpp: TextIterator can use RenderText::textWithoutTranscoding and now plainText() uses this version
(WebCore::TextIterator::TextIterator):
(WebCore::TextIterator::init):
(WebCore::TextIterator::emitText):
(WebCore::plainTextToMallocAllocatedBuffer):
* editing/TextIterator.h:
(WebCore::):
* platform/mac/PasteboardMac.mm: Remove an unnecessary displayStringModifiedByEncoding call.
(WebCore::Pasteboard::writeSelection):
* platform/text/TextEncoding.h: Make backslashAsCurrencySymbol public.
* rendering/RenderText.cpp: Add RenderText::textWithoutTranscoding
(WebCore::RenderText::RenderText):
(WebCore::RenderText::updateNeedsTranscoding):
(WebCore::RenderText::styleDidChange):
(WebCore::isInlineFlowOrEmptyText):
(WebCore::RenderText::previousCharacter):
(WebCore::RenderText::setTextInternal):
(WebCore::RenderText::textWithoutTranscoding):
(WebCore::RenderText::transformText):
* rendering/RenderText.h:
* rendering/RenderTextControl.cpp: Remove an unnecessary displayStringModifiedByEncoding call.
(WebCore::RenderTextControl::setInnerTextValue):
(WebCore::RenderTextControl::finishText):
* rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::previousCharacter):
* rendering/RenderTextFragment.h:
2010-04-20 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=37367
Fix style violations in code generated by CodeGeneratorV8.pm.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/test/V8TestObj.cpp:
* bindings/v8/test/V8TestObj.h:
2010-04-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57924.
http://trac.webkit.org/changeset/57924
https://bugs.webkit.org/show_bug.cgi?id=37898
It broke 3-4 test on all bot (Requested by Ossy on #webkit).
* page/AbstractView.idl:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::media):
* page/DOMWindow.h:
* page/DOMWindow.idl:
2010-04-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 37895 - Share common code from UStringImplBase with StringImpl
Add forwarding header.
* ForwardingHeaders/wtf/text/StringImplBase.h: Added.
2010-04-20 Adam Barth <abarth@webkit.org>
Unreviewed build fix fro Chromium.
* loader/DocumentWriter.cpp:
2010-04-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Support live edit while on a breakpoint, preserve breakpoints when adding new lines.
https://bugs.webkit.org/show_bug.cgi?id=37820
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.editScriptLine.mycallback):
(WebInspector.ScriptsPanel.prototype.editScriptLine):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._handleDoubleClick):
(WebInspector.TextViewer.prototype._cancelEditingLine):
2010-04-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175
This patch separates the begin/write/end cycle of decoding network
bytes and putting them into a document from the rest of the loading
machinery. The code and state required to write bytes into a document
doesn't interact very much with the rest of the loading machinery.
No tests because there is no behavior change (hopefully!).
* Android.mk:
* GNUmakefile.am:
* WebCore.base.exp:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
* dom/Document.cpp:
(WebCore::Document::close):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet):
* dom/ScriptElement.cpp:
(WebCore::ScriptElementData::scriptCharset):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
* loader/DocLoader.cpp:
(WebCore::DocLoader::requestPreload):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
* loader/DocumentWriter.cpp: Added.
* loader/DocumentWriter.h: Added.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::init):
(WebCore::FrameLoader::clear):
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::setURL):
(WebCore::FrameLoader::didBeginDocument):
(WebCore::FrameLoader::didEndDocument):
(WebCore::FrameLoader::willSetEncoding):
(WebCore::FrameLoader::addData):
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::finishedLoadingDocument):
(WebCore::FrameLoader::addExtraFieldsToRequest):
* loader/FrameLoader.h:
(WebCore::FrameLoader::writer):
(WebCore::FrameLoader::isDisplayingInitialEmptyDocument):
* loader/MediaDocument.cpp:
(WebCore::MediaDocument::replaceMediaElementTimerFired):
* loader/PluginDocument.cpp:
(WebCore::PluginTokenizer::createDocumentStructure):
* platform/network/FormDataBuilder.cpp:
(WebCore::FormDataBuilder::dataEncoding):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
2010-04-20 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Fraser.
Rename window.media to window.styleMedia
https://bugs.webkit.org/show_bug.cgi?id=36187
It has been defined that the AbstractView media extension
defined in the CSSOM View spec should be renamed to styleMedia.
This patch does that and updates the current layout tests
making use of it.
* page/AbstractView.idl:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::styleMedia):
* page/DOMWindow.h:
* page/DOMWindow.idl:
2010-04-20 Timothy Hatcher <timothy@apple.com>
Fix matching of "file:///*" patterns by not trying to compare the host. The host is
irrelevant for file URLs.
Also fix comparisons to be case insensitive.
https://bugs.webkit.org/show_bug.cgi?id=37889
Reviewed by Dave Hyatt.
* page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse): Use equalIgnoringCase when comparing for "file" schemes.
(WebCore::UserContentURLPattern::matches): Use equalIgnoringCase when comparing schemes. Only call
matchesHost if the scheme isn't "file".
(WebCore::UserContentURLPattern::matchesHost): Call equalIgnoringCase when comparing hosts. The endsWith
was already doing a case-insensitive compare, so existing tests worked though this path.
2010-04-20 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Invalid cast due to <video> inside <foreignObject> inside <svg> inside <img>
https://bugs.webkit.org/show_bug.cgi?id=37331
Added a setting to enable/disable media per-page and have the SVGImage
disable media for its dummy page. Also found and fixed a related bad
cast in the V8 bindings (JSC had a custom wrapper for this already).
Tests: media/svg-as-image-with-media-blocked.html
* dom/make_names.pl: Added media enabled check and V8 cast wrapper
* page/Settings.cpp: Added m_isMediaEnabled (defaults to true)
(WebCore::Settings::Settings):
(WebCore::Settings::setMediaEnabled):
* page/Settings.h:
(WebCore::Settings::isMediaEnabled):
* svg/graphics/SVGImage.cpp: Disables media in dummy page
(WebCore::SVGImage::dataChanged):
2010-04-19 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Simon Fraser.
Spatial Navigation: at @updateFocusCandidateIfCloser make an assignment shortcut when FocusCandidate is null
https://bugs.webkit.org/show_bug.cgi?id=37802
In updateFocusCandidateIfCloser method, we do all bail out checks in the begining of
the method body. If after those bail out checks, no "best FocusCandidate" has been taken
yet (i.e. focusCandidate.isNull() == true), we can safely take the current candidate,
and exit earlier.
No behavior change, it is just a safe assignment shortcut.
* page/FocusController.cpp:
(WebCore::updateFocusCandidateIfCloser):
2010-04-20 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Hook compositing layers together across iframes
https://bugs.webkit.org/show_bug.cgi?id=37878
First step: if an iframe's document goes into compositing mode, also throw the parent
document into compositing mode (all the way up to the root). This is required both
to preserve layering (since parent document content can obscure iframe content),
and so that we can eventually hook the layer trees together.
Test: compositing/iframes/composited-iframe.html
* rendering/RenderIFrame.h:
* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::requiresLayer): In order to make an iframe composited, it also has to have
a RenderLayer, so must return |true| from requiresLayer().
(WebCore::RenderIFrame::requiresAcceleratedCompositing): Returns true if the content document
is in compositing mode.
(WebCore::RenderIFrame::isRenderIFrame): Required so that RenderLayerCompositor can check
if a renderer is an iframe.
(WebCore::toRenderIFrame): Required so that RenderLayerCompositor can cast to a RenderIFrame.
* rendering/RenderLayerCompositor.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::enableCompositingMode): Call out to the RenderView when
the compositing mode changes, so that the parent document can update its compositing status.
(WebCore::RenderLayerCompositor::requiresCompositingLayer): Call requiresCompositingForIFrame().
(WebCore::RenderLayerCompositor::requiresCompositingForIFrame): Check to see if the iframe
wants to be composited.
* rendering/RenderObject.h:
(WebCore::RenderObject::isRenderIFrame): Base class returns false.
* rendering/RenderView.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::compositingStateChanged): New method that allows an iframe to notify
its parent document that a recalcStyle is required, to update compositing state.
2010-04-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix).
Speculative tiger build fix.
* WebCore.NPAPI.exp:
* WebCore.PluginHostProcess.exp:
* WebCore.base.exp:
2010-04-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add basic script editing capabilities to the front-end.
https://bugs.webkit.org/show_bug.cgi?id=37875
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
* inspector/front-end/ScriptView.js:
(WebInspector.ScriptView):
(WebInspector.ScriptView.prototype._editLine):
(WebInspector.ScriptView.prototype._editLineComplete):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
(WebInspector.ScriptsPanel.prototype.canEditScripts):
(WebInspector.ScriptsPanel.prototype.editScriptLine):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.updateContent):
(WebInspector.SourceFrame.prototype._createViewerIfNeeded):
* inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter):
(WebInspector.TextEditorHighlighter.prototype.reset):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.prototype.copyRange):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer):
(WebInspector.TextViewer.prototype.set editCallback):
(WebInspector.TextViewer.prototype._buildChunks):
(WebInspector.TextViewer.prototype._handleKeyDown):
(WebInspector.TextViewer.prototype._handleDoubleClick):
(WebInspector.TextViewer.prototype._commitEditingLine):
(WebInspector.TextViewer.prototype._cancelEditingLine):
* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
(WebInspector.log.logMessage):
(WebInspector.log):
(WebInspector.isEditingAnyField):
(WebInspector.startEditing.cleanUpAfterEditing):
2010-04-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Add forwarding header.
* ForwardingHeaders/runtime/RopeImpl.h: Added.
2010-04-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 37828 - Move WebCore's String classes to WTF
Move these classes up to WTF so they are available to all clients of WTF (in
particular JSC).
As a first patch, making the most minimal change possible, since this patch
could easily grow rather large since we'll have to change every class forward
declaration ( e.g. every "namespace WebCore { class String; }" much change to
"namespace WTF { class String; }").
Moving the files, but leaving the classes logically in the WebCore namespace -
which is technically a layering violation - I'll come back and fix this up in a
subsequent patch.
* Android.mk:
* ForwardingHeaders/wtf/StaticConstructors.h: Added.
* ForwardingHeaders/wtf/text/AtomicString.h: Added.
* ForwardingHeaders/wtf/text/AtomicStringImpl.h: Added.
* ForwardingHeaders/wtf/text/StringBuffer.h: Added.
* ForwardingHeaders/wtf/text/StringHash.h: Added.
* ForwardingHeaders/wtf/text/StringImpl.h: Added.
* ForwardingHeaders/wtf/text/WTFString.h: Added.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/MediaFeatureNames.cpp:
* dom/QualifiedName.cpp:
* dom/make_names.pl:
* platform/StaticConstructors.h: Removed.
* platform/text/AtomicString.cpp: Removed.
* platform/text/AtomicString.h:
* platform/text/AtomicStringImpl.h:
* platform/text/PlatformString.h:
* platform/text/String.cpp:
* platform/text/StringHash.h:
* platform/text/StringImpl.cpp: Removed.
* platform/text/StringImpl.h:
2010-04-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504
Change PassRefPtr<FileChooser> parameter of chooseIconForFiles()
to FileChooser*. Though an implementation of chooseIconForFiles()
might have ownership of the FileChooser instance, we don't need to
use PassRefPtr<> in this case.
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::chooseIconForFiles):
* page/Chrome.cpp:
(WebCore::Chrome::chooseIconForFiles):
* page/Chrome.h:
* page/ChromeClient.h:
2010-04-20 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449
Implement ATK_ROLE_FORM.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_get_role):
2010-04-20 Martin Robinson <mrobinson@webkit.org>
Reviewed by Gustavo Noronha Silva.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Move most of the PasteboardHelper logic into WebCore. This helps
prepare for WebKit2 and leads to a clearer separation of concerns
between the WebKit and WebCore layers.
No new tests as functionality has not changed.
* GNUmakefile.am: Add PastboardHelper.cpp to list of sources.
* platform/Pasteboard.h: Added a getter for the PasteboardHelper and made the member private.
* platform/gtk/PasteboardGtk.cpp: Update PasteboardHelper method calls to use new naming.
(WebCore::clipboard_get_contents_cb): Ditto.
(WebCore::Pasteboard::helper): Added, member is now private.
(WebCore::Pasteboard::writeURL): Ditto.
(WebCore::Pasteboard::documentFragment): Update to reflect method renaming.
(WebCore::Pasteboard::plainText): Ditto.
* platform/gtk/PasteboardHelper.cpp: Added.
(WebCore::PasteboardHelper::PasteboardHelper): Added.
(WebCore::PasteboardHelper::~PasteboardHelper): Added.
(WebCore::PasteboardHelper::initializeTargetList): Added, originally from WebKit.
(WebCore::widgetFromFrame): Added helper function.
(WebCore::PasteboardHelper::getCurrentClipboard): Added, originally from WebKit.
(WebCore::PasteboardHelper::getClipboard): Ditto.
(WebCore::PasteboardHelper::getPrimarySelectionClipboard): Ditto.
(WebCore::PasteboardHelper::targetList): Ditto.
(WebCore::PasteboardHelper::fillSelectionData): Ditto.
(WebCore::PasteboardHelper::targetListForDataObject): Ditto.
(WebCore::getClipboardContentsCallback): Ditto.
(WebCore::clearClipboardContentsCallback): Ditto.
(WebCore::PasteboardHelper::writeClipboardContents): Ditto.
* platform/gtk/PasteboardHelper.h: Moved methods from WebKit to WebCore.
2010-04-20 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson.
backgroundColor is oddly indented in layer tree dump
https://bugs.webkit.org/show_bug.cgi?id=37885
The writeIndent() was mistakenly outside the LayerTreeAsTextDebug clause, causing indents
to be written twice.
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties):
2010-04-20 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dimitri Glazkov.
Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
https://bugs.webkit.org/show_bug.cgi?id=37741
RenderPartObject is a useless intermediate class between RenderPart and
RenderEmbeddedObject, and we can now remove it. Its only method, viewCleared(),
applies to objects and embeds when the content is a FrameView, so can move
to RenderEmbeddedObject.
* Android.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
(WebCore::RenderEmbeddedObject::requiresLayer):
(WebCore::RenderEmbeddedObject::paint):
(WebCore::RenderEmbeddedObject::viewCleared):
* rendering/RenderEmbeddedObject.h:
* rendering/RenderFrameBase.h:
* rendering/RenderPart.cpp:
(WebCore::RenderPart::RenderPart):
* rendering/RenderPart.h:
* rendering/RenderPartObject.cpp: Removed.
* rendering/RenderPartObject.h: Removed.
2010-04-20 Robin Cao <robin.webkit@gmail.com>
Reviewed by Dirk Schulze.
SVG no AnimateColor for stroke or fill if they are set to none on target.
https://bugs.webkit.org/show_bug.cgi?id=36718
SVGAnimateElement::resetToBaseValue reset 'm_propertyType' in the process of animation.
This will cause problems when attributes 'fill' and 'stroke' have the value 'none', because in this case
the property type determined by base value may be different from the one determined by 'fromTo' values.
No new tests. The test suite in svg/animation is not working for target element with attribute 'fill' set to 'none'.
Now animateColor on target element with attributes 'fill' and 'stroke' set to 'none' is possible.
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateFromAndToValues):
(WebCore::SVGAnimateElement::resetToBaseValue):
2010-04-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57892.
http://trac.webkit.org/changeset/57892
https://bugs.webkit.org/show_bug.cgi?id=37864
Caused an assertion in Mac builds (Requested by smfr on
#webkit).
* WebCore.xcodeproj/project.pbxproj:
* editing/Editor.cpp:
(WebCore::Editor::insideVisibleArea):
* page/Frame.cpp:
(WebCore::Frame::ownerRenderer):
* page/Frame.h:
* page/FrameView.cpp:
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::clear):
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::createScrollbar):
* rendering/RenderFrameBase.h:
* rendering/RenderObject.h:
2010-04-20 Jakub Wieczorek <jwieczorek@webkit.org>
Reviewed by Darin Adler.
RenderListItem: change enclosingList() to only traverse the render tree.
https://bugs.webkit.org/show_bug.cgi?id=37319
This makes the function safe to use for items with nodes that are detached from
the DOM tree and simplifies the code quite a bit.
Covered by existing tests.
* rendering/RenderListItem.cpp:
(WebCore::enclosingList):
(WebCore::previousListItem):
(WebCore::RenderListItem::explicitValueChanged):
2010-04-20 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
https://bugs.webkit.org/show_bug.cgi?id=37741
Make Frame::ownerRenderer() return a RenderFrameBase* rather than a
RenderPart*, and add the necessary toRenderFrameBase() and isRenderFrameBase().
* WebCore.xcodeproj/project.pbxproj:
* editing/Editor.cpp:
(WebCore::Editor::insideVisibleArea):
* page/Frame.cpp:
(WebCore::Frame::ownerRenderer):
* page/Frame.h:
* page/FrameView.cpp:
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::clear):
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::createScrollbar):
* rendering/RenderFrameBase.h:
(WebCore::RenderFrameBase::isRenderFrameBase):
(WebCore::toRenderFrameBase):
* rendering/RenderObject.h:
(WebCore::RenderObject::isRenderFrameBase):
2010-04-20 Jay Civelli <jcivelli@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Pressing tab now closes the select popup as it should.
https://bugs.webkit.org/show_bug.cgi?id=37721
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupListBox::handleKeyEvent):
2010-04-20 Yaar Schnitman <yaar@chromium.org>
Reviewed by Nate Chapin.
Null value should be legit value for wrapped types. This requires some cleanup in canvas which was missing built-in null argument checks;
https://bugs.webkit.org/show_bug.cgi?id=37810
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::JSCanvasRenderingContext2D::drawImage): Passes ec to drawImage(3) too
* bindings/scripts/CodeGeneratorV8.pm: A null value is now legit value for wrapped types.
* bindings/v8/test/V8TestObj.cpp:
(WebCore::TestObjInternal::overloadedMethodCallback):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage): Added null checks.
(WebCore::CanvasRenderingContext2D::createPattern): Added null checks.
* html/canvas/CanvasRenderingContext2D.h: Added needed raises "DOMException".
* html/canvas/CanvasRenderingContext2D.idl: Added needed raises "DOMException".
2010-04-20 Evan Stade <estade@chromium.org>
Reviewed by David Levin.
[chromium] crash when dragging images
https://bugs.webkit.org/show_bug.cgi?id=37715
NULL check the return value of nativeImageForCurrentFrame(),
and NULL check Image just for good measure.
Tested by new DragImageTest unit test.
* platform/chromium/DragImageChromiumSkia.cpp:
(WebCore::createDragImageFromImage):
2010-04-20 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGResourceFilter needs to be moved to under Renderers
https://bugs.webkit.org/show_bug.cgi?id=35320
This patch adds a renderer for SVGFilterElement. SVGFilterElement is now independent
from the SVGResources.
A clean-up solves the dependencies between SVGFilterElement, the filter primitives
and SVGResources. This shall make the filter code more readable and better maintable.
The Filter primitives get dumped now, as long as they have externalRepresentation
implemented.
No behavior changes, so no new tests were added.
* Android.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderPath.cpp:
(WebCore::RenderPath::paint):
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::selfWillPaint):
(WebCore::RenderSVGContainer::paint):
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
* rendering/RenderSVGResource.h:
(WebCore::):
(WebCore::RenderSVGResource::postApplyResource):
* rendering/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyResource):
* rendering/RenderSVGResourceClipper.h:
* rendering/RenderSVGResourceFilter.cpp: Added.
(WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter):
(WebCore::RenderSVGResourceFilter::~RenderSVGResourceFilter):
(WebCore::RenderSVGResourceFilter::invalidateClients):
(WebCore::RenderSVGResourceFilter::invalidateClient):
(WebCore::RenderSVGResourceFilter::buildPrimitives):
(WebCore::RenderSVGResourceFilter::fitsInMaximumImageSize):
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):
(WebCore::RenderSVGResourceFilter::resourceBoundingBox):
* rendering/RenderSVGResourceFilter.h: Added.
(WebCore::FilterData::FilterData):
(WebCore::RenderSVGResourceFilter::renderName):
(WebCore::RenderSVGResourceFilter::filterUnits):
(WebCore::RenderSVGResourceFilter::primitiveUnits):
(WebCore::RenderSVGResourceFilter::resourceType):
* rendering/RenderSVGResourceMarker.h:
(WebCore::RenderSVGResourceMarker::applyResource):
* rendering/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
* rendering/RenderSVGResourceMasker.h:
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::selfWillPaint):
(WebCore::RenderSVGRoot::paint):
* rendering/RenderSVGText.cpp:
* rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent):
(WebCore::SVGRenderBase::finishRenderSVGContent):
(WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
(WebCore::deregisterFromResources):
* rendering/SVGRenderSupport.h:
* rendering/SVGRenderTreeAsText.cpp:
(WebCore::writeStyle):
(WebCore::writeSVGResource):
(WebCore::writeResources):
(WebCore::writeRenderResources):
* rendering/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker):
(WebCore::SVGRootInlineBox::paint):
* svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::build):
* svg/SVGFEBlendElement.h:
* svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::build):
* svg/SVGFEColorMatrixElement.h:
* svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::build):
* svg/SVGFEComponentTransferElement.h:
* svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::build):
* svg/SVGFECompositeElement.h:
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::build):
* svg/SVGFEDiffuseLightingElement.h:
* svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::build):
* svg/SVGFEDisplacementMapElement.h:
* svg/SVGFEFloodElement.cpp:
(WebCore::SVGFEFloodElement::build):
* svg/SVGFEFloodElement.h:
* svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::build):
* svg/SVGFEGaussianBlurElement.h:
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::build):
* svg/SVGFEImageElement.h:
* svg/SVGFEMergeElement.cpp:
(WebCore::SVGFEMergeElement::build):
* svg/SVGFEMergeElement.h:
* svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::build):
* svg/SVGFEMorphologyElement.h:
* svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::build):
* svg/SVGFEOffsetElement.h:
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::build):
* svg/SVGFESpecularLightingElement.h:
* svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::build):
* svg/SVGFETileElement.h:
* svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::build):
* svg/SVGFETurbulenceElement.h:
(WebCore::):
* svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::createRenderer):
* svg/SVGFilterElement.h:
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
* svg/SVGFilterPrimitiveStandardAttributes.h:
(WebCore::SVGFilterPrimitiveStandardAttributes::isFilterEffect):
(WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::invalidateResources):
* svg/graphics/SVGResource.cpp:
* svg/graphics/SVGResource.h:
(WebCore::):
(WebCore::SVGResource::isPaintServer):
* svg/graphics/SVGResourceFilter.cpp: Removed.
* svg/graphics/SVGResourceFilter.h: Removed.
* svg/graphics/filters/SVGFEDisplacementMap.cpp:
(WebCore::FEDisplacementMap::externalRepresentation):
* svg/graphics/filters/SVGFilterBuilder.h:
(WebCore::SVGFilterBuilder::namedEffects):
2010-04-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57880.
http://trac.webkit.org/changeset/57880
https://bugs.webkit.org/show_bug.cgi?id=37846
Broke several bots, FEDisplacmentMap dumps includes pointers,
no one noticed. Dirk will upload a new patch later. (Requested
by WildFox on #webkit).
* Android.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderPath.cpp:
(WebCore::RenderPath::paint):
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::selfWillPaint):
(WebCore::RenderSVGContainer::paint):
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
* rendering/RenderSVGResource.h:
(WebCore::):
* rendering/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyResource):
* rendering/RenderSVGResourceClipper.h:
* rendering/RenderSVGResourceFilter.cpp: Removed.
* rendering/RenderSVGResourceFilter.h: Removed.
* rendering/RenderSVGResourceMarker.h:
(WebCore::RenderSVGResourceMarker::applyResource):
* rendering/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
* rendering/RenderSVGResourceMasker.h:
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::selfWillPaint):
(WebCore::RenderSVGRoot::paint):
* rendering/RenderSVGText.cpp:
* rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent):
(WebCore::SVGRenderBase::finishRenderSVGContent):
(WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
(WebCore::deregisterFromResources):
* rendering/SVGRenderSupport.h:
* rendering/SVGRenderTreeAsText.cpp:
(WebCore::writeStyle):
(WebCore::writeSVGResource):
(WebCore::writeResources):
(WebCore::writeRenderResources):
* rendering/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker):
(WebCore::SVGRootInlineBox::paint):
* svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::build):
* svg/SVGFEBlendElement.h:
* svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::build):
* svg/SVGFEColorMatrixElement.h:
* svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::build):
* svg/SVGFEComponentTransferElement.h:
* svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::build):
* svg/SVGFECompositeElement.h:
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::build):
* svg/SVGFEDiffuseLightingElement.h:
* svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::build):
* svg/SVGFEDisplacementMapElement.h:
* svg/SVGFEFloodElement.cpp:
(WebCore::SVGFEFloodElement::build):
* svg/SVGFEFloodElement.h:
* svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::build):
* svg/SVGFEGaussianBlurElement.h:
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::build):
* svg/SVGFEImageElement.h:
* svg/SVGFEMergeElement.cpp:
(WebCore::SVGFEMergeElement::build):
* svg/SVGFEMergeElement.h:
* svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::build):
* svg/SVGFEMorphologyElement.h:
* svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::build):
* svg/SVGFEOffsetElement.h:
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::build):
* svg/SVGFESpecularLightingElement.h:
* svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::build):
* svg/SVGFETileElement.h:
* svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::build):
* svg/SVGFETurbulenceElement.h:
(WebCore::):
* svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::buildFilter):
(WebCore::SVGFilterElement::canvasResource):
* svg/SVGFilterElement.h:
(WebCore::SVGFilterElement::rendererIsNeeded):
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
* svg/SVGFilterPrimitiveStandardAttributes.h:
(WebCore::SVGFilterPrimitiveStandardAttributes::isFilterEffect):
(WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::invalidateResources):
* svg/graphics/SVGResource.cpp:
* svg/graphics/SVGResource.h:
(WebCore::):
(WebCore::SVGResource::isFilter):
* svg/graphics/SVGResourceFilter.cpp: Added.
(WebCore::SVGResourceFilter::SVGResourceFilter):
(WebCore::SVGResourceFilter::~SVGResourceFilter):
(WebCore::SVGResourceFilter::filterBoundingBox):
(WebCore::shouldProcessFilter):
(WebCore::SVGResourceFilter::addFilterEffect):
(WebCore::SVGResourceFilter::fitsInMaximumImageSize):
(WebCore::SVGResourceFilter::prepareFilter):
(WebCore::SVGResourceFilter::applyFilter):
(WebCore::SVGResourceFilter::externalRepresentation):
(WebCore::getFilterById):
* svg/graphics/SVGResourceFilter.h: Added.
(WebCore::SVGResourceFilter::create):
(WebCore::SVGResourceFilter::resourceType):
(WebCore::SVGResourceFilter::setFilterResolution):
(WebCore::SVGResourceFilter::setHasFilterResolution):
(WebCore::SVGResourceFilter::filterBoundingBoxMode):
(WebCore::SVGResourceFilter::setFilterBoundingBoxMode):
(WebCore::SVGResourceFilter::effectBoundingBoxMode):
(WebCore::SVGResourceFilter::setEffectBoundingBoxMode):
(WebCore::SVGResourceFilter::filterRect):
(WebCore::SVGResourceFilter::setFilterRect):
(WebCore::SVGResourceFilter::scaleX):
(WebCore::SVGResourceFilter::scaleY):
(WebCore::SVGResourceFilter::setFilterBoundingBox):
(WebCore::SVGResourceFilter::builder):
* svg/graphics/filters/SVGFilterBuilder.h:
2010-04-20 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGResourceFilter needs to be moved to under Renderers
https://bugs.webkit.org/show_bug.cgi?id=35320
This patch adds a renderer for SVGFilterElement. SVGFilterElement is now independent
from the SVGResources.
A clean-up solves the dependencies between SVGFilterElement, the filter primitives
and SVGResources. This shall make the filter code more readable and better maintable.
The Filter primitives get dumped now, as long as they have externalRepresentation
implemented.
No behavior changes, so no new tests were added.
* Android.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderPath.cpp:
(WebCore::RenderPath::paint):
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::selfWillPaint):
(WebCore::RenderSVGContainer::paint):
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
* rendering/RenderSVGResource.h:
(WebCore::):
* rendering/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyResource):
* rendering/RenderSVGResourceClipper.h:
* rendering/RenderSVGResourceFilter.cpp: Added.
(WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter):
(WebCore::RenderSVGResourceFilter::~RenderSVGResourceFilter):
(WebCore::RenderSVGResourceFilter::invalidateClients):
(WebCore::RenderSVGResourceFilter::invalidateClient):
(WebCore::RenderSVGResourceFilter::buildPrimitives):
(WebCore::RenderSVGResourceFilter::fitsInMaximumImageSize):
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):
(WebCore::RenderSVGResourceFilter::resourceBoundingBox):
* rendering/RenderSVGResourceFilter.h: Added.
(WebCore::FilterData::FilterData):
(WebCore::RenderSVGResourceFilter::renderName):
(WebCore::RenderSVGResourceFilter::filterUnits):
(WebCore::RenderSVGResourceFilter::primitiveUnits):
(WebCore::RenderSVGResourceFilter::resourceType):
* rendering/RenderSVGResourceMarker.h:
(WebCore::RenderSVGResourceMarker::applyResource):
* rendering/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
* rendering/RenderSVGResourceMasker.h:
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::selfWillPaint):
(WebCore::RenderSVGRoot::paint):
* rendering/RenderSVGText.cpp:
* rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent):
(WebCore::SVGRenderBase::finishRenderSVGContent):
(WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
(WebCore::deregisterFromResources):
* rendering/SVGRenderSupport.h:
* rendering/SVGRenderTreeAsText.cpp:
(WebCore::writeStyle):
(WebCore::writeSVGResource):
(WebCore::writeResources):
(WebCore::writeRenderResources):
* rendering/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker):
(WebCore::SVGRootInlineBox::paint):
* svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::build):
* svg/SVGFEBlendElement.h:
* svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::build):
* svg/SVGFEColorMatrixElement.h:
* svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::build):
* svg/SVGFEComponentTransferElement.h:
* svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::build):
* svg/SVGFECompositeElement.h:
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::build):
* svg/SVGFEDiffuseLightingElement.h:
* svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::build):
* svg/SVGFEDisplacementMapElement.h:
* svg/SVGFEFloodElement.cpp:
(WebCore::SVGFEFloodElement::build):
* svg/SVGFEFloodElement.h:
* svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::build):
* svg/SVGFEGaussianBlurElement.h:
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::build):
* svg/SVGFEImageElement.h:
* svg/SVGFEMergeElement.cpp:
(WebCore::SVGFEMergeElement::build):
* svg/SVGFEMergeElement.h:
* svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::build):
* svg/SVGFEMorphologyElement.h:
* svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::build):
* svg/SVGFEOffsetElement.h:
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::build):
* svg/SVGFESpecularLightingElement.h:
* svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::build):
* svg/SVGFETileElement.h:
* svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::build):
* svg/SVGFETurbulenceElement.h:
(WebCore::):
* svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::createRenderer):
* svg/SVGFilterElement.h:
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
* svg/SVGFilterPrimitiveStandardAttributes.h:
(WebCore::SVGFilterPrimitiveStandardAttributes::isFilterEffect):
(WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::invalidateResources):
* svg/graphics/SVGResource.cpp:
* svg/graphics/SVGResource.h:
(WebCore::):
(WebCore::SVGResource::isPaintServer):
* svg/graphics/SVGResourceFilter.cpp: Removed.
* svg/graphics/SVGResourceFilter.h: Removed.
* svg/graphics/filters/SVGFilterBuilder.h:
(WebCore::SVGFilterBuilder::namedEffects):
2010-04-20 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Maciej Stachowiak (relanding r57829).
Added missing JS_EXPORTDATA
* ForwardingHeaders/wtf/WTFThreadData.h: Copied from WebCore/ForwardingHeaders/wtf/WTFThreadData.h.
* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):
* platform/ThreadGlobalData.h:
(WebCore::ThreadGlobalData::eventNames):
* platform/text/AtomicString.cpp:
(WebCore::AtomicStringTable::create):
(WebCore::AtomicStringTable::table):
(WebCore::AtomicStringTable::destroy):
(WebCore::stringTable):
2010-04-20 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Antti Koivisto.
[Qt] GraphicsLayer: support fill-modes
https://bugs.webkit.org/show_bug.cgi?id=36216
Implement the CSS-animation "fill mode" concept in GraphicsLayerQt. The concept
enables a key-frame animation to go to the animation's starting point before the delay,
and/or to stay at the animation's ending point after its ended, without reverting to the default
value.
We do that by manually setting the value to keyframe-0 before the delay if fill-mode is backwards/both,
and manually modifying the default value to the animated value as we animate, with fill-mode forwards/both.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::AnimationQtBase::AnimationQtBase):
(WebCore::TransformAnimationQt::~TransformAnimationQt):
(WebCore::TransformAnimationQt::applyFrame):
(WebCore::GraphicsLayerQt::addAnimation):
2010-04-19 Leandro Pereira <leandro@profusion.mobi>
Reviewed by David Hyatt.
Add missing dummy implementations in PluginPackageNone and PluginViewNone.
http://webkit.org/b/37478
* plugins/PluginPackageNone.cpp:
(WebCore::PluginPackage::NPVersion): Add dummy implementation.
* plugins/PluginViewNone.cpp:
(WebCore::PluginView::handleFocusInEvent): Add dummy implementation.
(WebCore::PluginView::handleFocusOutEvent): Add dummy implementation.
2010-04-19 Simon Fraser <simon.fraser@apple.com>
Reviewed by Geoff Garen.
Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
https://bugs.webkit.org/show_bug.cgi?id=37741
Move m_hasFallbackContent from RenderPart to RenderEmbeddedObject,
since it's only used for <object> fallback.
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
* rendering/RenderEmbeddedObject.h:
(WebCore::RenderEmbeddedObject::hasFallbackContent):
* rendering/RenderPart.cpp:
(WebCore::RenderPart::RenderPart):
* rendering/RenderPart.h:
2010-04-19 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
https://bugs.webkit.org/show_bug.cgi?id=37741
Add a new renderer for iframes, named RenderIFrame. Add a new shared base class
between this and RenderFrame, called RenderFrameBase (following the existing HTMLFrameElementBase),
and move code from RenderPart and RenderPartObject into these new classes.
There should be no functionality difference with this change, so no new tests.
Fixing up renderer names in the layout tests will be done in a later pass.
Fix build systems to include the new files.
* Android.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::createRenderer):
* rendering/RenderEmbeddedObject.h:
* rendering/RenderFrame.cpp:
(WebCore::RenderFrame::RenderFrame):
* rendering/RenderFrame.h:
* rendering/RenderFrameBase.cpp: Added.
(WebCore::RenderFrameBase::RenderFrameBase):
(WebCore::RenderFrameBase::layoutWithFlattening):
* rendering/RenderFrameBase.h: Added.
* rendering/RenderIFrame.cpp: Added.
(WebCore::RenderIFrame::RenderIFrame):
(WebCore::RenderIFrame::calcHeight):
(WebCore::RenderIFrame::calcWidth):
(WebCore::RenderIFrame::flattenFrame):
(WebCore::RenderIFrame::layout):
* rendering/RenderIFrame.h: Added.
(WebCore::RenderIFrame::renderName):
* rendering/RenderPart.cpp:
* rendering/RenderPart.h:
* rendering/RenderPartObject.cpp:
* rendering/RenderPartObject.h:
2010-04-19 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Geoffrey Garen.
Bindings clean-up.
https://bugs.webkit.org/show_bug.cgi?id=37833
Move some WebSQLDatabases logic out of the bindings into
DOMWindow.cpp where it should be.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::openDatabase):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::openDatabase):
2010-04-19 Kevin Ollivier <kevino@theolliviers.com>
Fix the Mac builders for now by restoring the keepAlive function.
* plugins/PluginViewNone.cpp:
(WebCore::PluginView::keepAlive):
2010-04-19 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix, remove a method that has been moved to PluginView.cpp.
* plugins/PluginViewNone.cpp:
2010-04-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (rolling out r57829).
This broke windows.
* ForwardingHeaders/wtf/WTFThreadData.h: Removed.
* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):
* platform/ThreadGlobalData.h:
(WebCore::ThreadGlobalData::atomicStringTable):
* platform/text/AtomicString.cpp:
(WebCore::stringTable):
2010-04-19 Mark Rowe <mrowe@apple.com>
Build fix.
* platform/graphics/mac/GraphicsContext3DMac.cpp:
2010-04-19 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
AX: aria-haspopup needs to be exposed
https://bugs.webkit.org/show_bug.cgi?id=37808
Test: platform/mac/accessibility/element-haspopup.html
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::ariaHasPopup):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaHasPopup):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
* accessibility/AccessibilityRenderObject.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
2010-04-19 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Fix a crash when rendering <select> elements with WebKit2.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuList):
Set the current NSGraphicsContext before calling out to AppKit, otherwise the current graphics context
could point to a CGContext whose memory has been freed.
2010-04-08 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Manipulating document fragment members while adding it to tree may result in loss of tree integrity.
https://bugs.webkit.org/show_bug.cgi?id=36031
Changes the logic of appending/inserting document fragment to first stashing all of its children
to a vector, then processing the vector. This avoids ghastliness that would be caused by mutation
events mucking with the document fragment while it's being appended/inserted.
Test: fast/dom/Node/fragment-mutation.html
* dom/ContainerNode.cpp:
(WebCore::targetNodes): Added method to populate a vector of nodes (targets) to be used in
inserting/appending operation.
(WebCore::ContainerNode::insertBefore): Changed to use vector-based iteration.
(WebCore::ContainerNode::appendChild): Ditto.
* dom/Node.cpp:
(WebCore::Node::checkReplaceChild): Cleaned up comments.
(WebCore::Node::checkAddChild): Ditto.
2010-04-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Fix regression introduced in r57820.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadNextSourceChild): Create a new MediaPlayer instead of
just setting a URL on the one used for the previous <source> element. This restores
the behavior prior to the changes for https://bugs.webkit.org/show_bug.cgi?id=37728.
2010-04-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=37745
Move string uniquing tables to (new) WTFThreadData class.
Remove AtomicString's dependency on ThreadGlobalData so that we can move
WebCore's string classes up to WTF.
* ForwardingHeaders/wtf/WTFThreadData.h: Added.
* platform/ThreadGlobalData.cpp: Remove m_atomicStringTable, all wtfThreadData() to ensure threadsafely initialized.
(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):
* platform/ThreadGlobalData.h: Remove m_atomicStringTable.
(WebCore::ThreadGlobalData::eventNames):
* platform/text/AtomicString.cpp:
(WebCore::AtomicStringTable::create):
(WebCore::AtomicStringTable::table):
(WebCore::AtomicStringTable::destroy):
(WebCore::stringTable): Access the AtomicStringTable on wtfThreadData() rather then threadGlobalData().
2010-04-19 Ada Chan <adachan@apple.com>
Build fix: wrap Settings::setLocalStorageQuota() and Settings::setSessionStorageQuota()
in #if ENABLE(DOM_STORAGE).
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
2010-04-19 Dave Moore <davemoore@chromium.org>
Reviewed by Dimitri Glazkov.
Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
https://bugs.webkit.org/show_bug.cgi?id=33812
Test: fast/dom/icon-url-property.html
* dom/Document.cpp:
(WebCore::Document::setIconURL):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setIconURL):
* loader/DocumentLoader.h:
(WebCore::DocumentLoader::iconURL):
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::setIconURL):
(WebCore::FrameLoader::didChangeIcons):
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
2010-04-19 Ada Chan <adachan@apple.com>
Reviewed by Jeremy Orlow.
https://bugs.webkit.org/show_bug.cgi?id=37717
Allow clients concerned with memory consumption to set a quota on session storage
since the memory used won't be released until the Page is destroyed.
The default is noQuota, which matches the current behavior.
* WebCore.base.exp: Export Settings::setSessionStorageQuota().
* page/Page.cpp:
(WebCore::Page::sessionStorage):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setSessionStorageQuota):
* page/Settings.h:
(WebCore::Settings::sessionStorageQuota):
* storage/StorageNamespace.cpp:
(WebCore::StorageNamespace::sessionStorageNamespace):
* storage/StorageNamespace.h:
* storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::sessionStorageNamespace):
* storage/StorageNamespaceImpl.h:
2010-04-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Setting media element 'src' attribute should trigger immediate load
https://bugs.webkit.org/show_bug.cgi?id=37728
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::attributeChanged): Schedule load every time 'src' attribute
changes unless it is missing.
(WebCore::HTMLMediaElement::prepareForLoad): Include steps 3 to 6 from loadInternal.
(WebCore::HTMLMediaElement::loadInternal): Steps 3 to 6 are now in prepareForLoad.
(WebCore::HTMLMediaElement::loadResource): MediaPlayer is now allocated in prepareForLoad
so the previously loading file, if any, is cancelled there.
2010-04-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix compilation against namespaced Qt.
* platform/graphics/GraphicsLayer.h:
* platform/graphics/Tile.h:
* platform/graphics/qt/MediaPlayerPrivateQt.h:
* platform/network/qt/NetworkStateNotifierPrivate.h:
2010-04-19 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Destroy SharedTimerQt before destruction of QCoreApplication.
To avoid unsafe situations caused by running WebCore code (through firing timers) when destruction of QCoreApplication
has been started, we should explicitly destroy the SharedTimerQt instance on application exit.
We can achieve that through installing a self-destroying slot for the QCoreApplication::aboutToQuit() signal
into the SharedTimerQt instance.
https://bugs.webkit.org/show_bug.cgi?id=36832
No functional change so no new tests.
* platform/qt/SharedTimerQt.cpp:
(WebCore::SharedTimerQt::SharedTimerQt):
(WebCore::SharedTimerQt::destroy):
(WebCore::SharedTimerQt::inst):
2010-04-19 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
Make the fix for <rdar://problem/7873647> from r57759 more robust.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateHoverActiveState): Use RefPtrs for the Nodes.
2010-04-19 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Chromium build fix.
* bindings/v8/JavaScriptCallFrame.h:
2010-04-19 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: implement JavaScriptCallFrame that works for v8.
Implementing this binding for v8 allows to make evaluations on
call frames and protects access to the debugger context from
inspected context.
https://bugs.webkit.org/show_bug.cgi?id=37755
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::scopeType):
* bindings/v8/JavaScriptCallFrame.cpp: Added.
(WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
(WebCore::JavaScriptCallFrame::~JavaScriptCallFrame):
(WebCore::JavaScriptCallFrame::caller):
(WebCore::JavaScriptCallFrame::sourceID):
(WebCore::JavaScriptCallFrame::line):
(WebCore::JavaScriptCallFrame::functionName):
(WebCore::JavaScriptCallFrame::scopeChain):
(WebCore::JavaScriptCallFrame::scopeType):
(WebCore::JavaScriptCallFrame::thisObject):
(WebCore::JavaScriptCallFrame::evaluate):
* bindings/v8/JavaScriptCallFrame.h: Added.
(WebCore::JavaScriptCallFrame::create):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::currentCallFrame):
* bindings/v8/ScriptDebugServer.h:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::currentCallFrameCallback):
* bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp: Added.
(WebCore::V8JavaScriptCallFrame::evaluateCallback):
(WebCore::V8JavaScriptCallFrame::scopeChainAccessorGetter):
(WebCore::V8JavaScriptCallFrame::scopeTypeCallback):
(WebCore::V8JavaScriptCallFrame::thisObjectAccessorGetter):
(WebCore::V8JavaScriptCallFrame::typeAccessorGetter):
* inspector/JavaScriptCallFrame.idl:
* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor.):
2010-04-19 Jessie Berlin <jberlin@webkit.org>
Rubber Stamped by Adam Roben
Chromium Release Build Fix.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
In the case where the DATALIST is not enabled, fall through to NOPSEUDO instead of omitting PseudoInputListButton entirely from the switch.
2010-04-19 Jessie Berlin <jberlin@webkit.org>
Reviewed by Dave Hyatt.
First steps towards fixing bug 24021 - pseudo-element styles not accessible / retrievable via DOM methods.
https://bugs.webkit.org/show_bug.cgi?id=24021
Allows access to the computed styles for the pseudo-elements through the second argument to getComputedStyle.
This approach does not provide the correct values for 'length' properties and does not work for the ':selection' pseudo-element and will instead return results similiar to those returned by Firefox. This approach also requires waiting until at least one iteration of a hardware accelerated composited animation to return the correct values for the "opacity" and "transform" properties of a pseudo-element associated with the element being animated.
Those values need to be retrieved from the renderer for the pseudo-element as opposed to the cached RenderStyle for the element on which the pseudo-element is defined, which is further complicated by the fact that not all elements have renderers.
Test: fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html
* WebCore.base.exp:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::CSSComputedStyleDeclaration):
Parse the and store the pseudo-element specifier from the string provided by the user.
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
Get the computed style for the pseudo-element if it has been specified.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Get the computed style for the pseudo-element if it has been specified, with a FIXME noting that the values returned for the "opacity" and "transform" properties of a pseudo-element associated with an element being animated and using hardware accelerated compositing will not be correct until after the first iteration of the animation.
(WebCore::CSSComputedStyleDeclaration::length):
Get the computed style for the pseudo-element if it has been specified.
(WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
Ditto.
* css/CSSComputedStyleDeclaration.h:
(WebCore::computedStyle):
Take into consideration the pseudo-element.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
Return the PseudoId that corresponds to the given PseudoType. If there is no corresponding PseudoId, returns NOPSEUDO.
(WebCore::nameToPseudoTypeMap):
Create and return the mapping between string names and PseudoTypes.
(WebCore::CSSSelector::parsePseudoType):
Parse and the given string into a PseudoType.
(WebCore::CSSSelector::extractPseudoType):
Refactored to use parsePseudoType.
* css/CSSSelector.h:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
Refactored to use pseudoId.
* dom/Element.cpp:
(WebCore::Element::computedStyle):
If the pseudo-element is specified, then return the cached RenderStyle for that PseudoId. Added a FIXME to find the actual renders of the pseudo-elements instead of just the cached RenderStyle of the RenderStyle for the associated element.
* dom/Element.h:
(WebCore::Element::virtualComputedStyle):
Because Element::computedStyle is used so often, don't make it virtual. Instead, provide a virtualComputedStyle method in the Node.h class andmake computedStyle non-virtual. That way the Element version and the Node version of computedStyle will have the same name and look the same at the call site, but the Element version will be more efficient.
* dom/Node.h:
(WebCore::Node::computedStyle):
Ditto.
* dom/Node.cpp:
(WebCore::Node::virtualComputedStyle):
Get the computed style for the pseudo-element if it has been specified.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::getComputedStyle):
Ditto.
2010-04-18 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix JavaScriptCore's include path for WinCE builds
https://bugs.webkit.org/show_bug.cgi?id=36751
* WebCore.pro:
2010-04-17 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=37720
<rdar://problem/7873752> HTMLFrameSetElement-window-eventListener-attributes.html sometimes
crashes on SnowLeopard Release
Tests:
* fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html:
* fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html:
* bindings/scripts/CodeGeneratorJS.pm: Use global object as a wrapper for window event
listeners set via document.body. The body wrapper can go away if nothing else references it.
* html/HTMLBodyElement.idl: Override listeners that exist on Element with custom implementations,
because we need to use window object as a wrapper, not the element. Marked all window event
listeners as such for code generator.
* html/HTMLFrameSetElement.idl: Ditto.
2010-04-17 Juan C. Montemayor <jmonte03@cs.tufts.edu>
Reviewed by Joseph Pecoraro.
Databases pane doesn't recognize table creation/deletion
https://bugs.webkit.org/show_bug.cgi?id=20219
* inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView.prototype._queryFinished):
2010-04-17 Yaar Schnitman <yaar@chromium.org>
Reviewed by Adam Barth.
Auto-generate V8 bindings for canvas.* overloads
https://bugs.webkit.org/show_bug.cgi?id=37453
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Deleted custom code that is now auto-generated.
* bindings/scripts/CodeGeneratorV8.pm: Not generating custom signatures for overloaded methods and accepting Object as a string input.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage): Added missing 9-arguments overloads for drawImage.
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/CanvasRenderingContext2D.idl: Overloaded methods defined (V8 only).
2010-04-17 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move JavaScriptCallFrame.{h,cpp} to WebCore/bindings/js
https://bugs.webkit.org/show_bug.cgi?id=37740
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JavaScriptCallFrame.cpp: Renamed from WebCore/inspector/JavaScriptCallFrame.cpp.
(WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
(WebCore::JavaScriptCallFrame::caller):
(WebCore::JavaScriptCallFrame::scopeChain):
(WebCore::JavaScriptCallFrame::dynamicGlobalObject):
(WebCore::JavaScriptCallFrame::functionName):
(WebCore::JavaScriptCallFrame::type):
(WebCore::JavaScriptCallFrame::thisObject):
(WebCore::JavaScriptCallFrame::evaluate):
* bindings/js/JavaScriptCallFrame.h: Renamed from WebCore/inspector/JavaScriptCallFrame.h.
(WebCore::JavaScriptCallFrame::create):
(WebCore::JavaScriptCallFrame::invalidate):
(WebCore::JavaScriptCallFrame::isValid):
(WebCore::JavaScriptCallFrame::sourceID):
(WebCore::JavaScriptCallFrame::line):
(WebCore::JavaScriptCallFrame::update):
* inspector/InjectedScriptHost.h:
* inspector/InspectorController.h:
2010-04-17 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Dimitri Glazkov.
Adding definition of GLES2Context class.
https://bugs.webkit.org/show_bug.cgi?id=37541
No new functionality implemented yet, no tests.
* WebCore.gypi: Added GLES2Context.h
* platform/chromium/GLES2Context.h: Added.
2010-04-17 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Crash while handling SVG font in the wrong namespace imported with @font-face
https://bugs.webkit.org/show_bug.cgi?id=18862
Test: fast/invalid/invalidSVGFont.html
* loader/CachedFont.cpp:
(WebCore::CachedFont::getSVGFontById): Make sure we really get an SVGFontElement by using
getElementsByNameNS: the element factory chooses which element to create based on both
localName and namespace.
2010-04-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57770.
http://trac.webkit.org/changeset/57770
https://bugs.webkit.org/show_bug.cgi?id=37746
8 test cases crashed (Requested by Ossy on #webkit).
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::AnimationQtBase::AnimationQtBase):
(WebCore::TransformAnimationQt::~TransformAnimationQt):
(WebCore::TransformAnimationQt::applyFrame):
(WebCore::OpacityAnimationQt::applyFrame):
(WebCore::GraphicsLayerQt::addAnimation):
2010-04-16 Daniel Bates <dbates@rim.com>
Reviewed by Adam Treat.
https://bugs.webkit.org/show_bug.cgi?id=36312
Adds support for the viewport meta tag. The code is largely derived in whole
or in part from the WebCore-528.15 source published as part of the iPhone 3.1.3
source code <http://www.opensource.apple.com/source/WebCore/WebCore-528.15/>.
* Android.mk: Added file ViewportArguments.cpp.
* GNUmakefile.am: Added files ViewportArguments.cpp and ViewportArguments.h.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* dom/Document.cpp:
(WebCore::isSeparator): Added.
(WebCore::Document::processArguments): Added.
(WebCore::Document::processViewport): Added.
* dom/Document.h:
* dom/ViewportArguments.cpp: Added.
(WebCore::setViewportFeature):
(WebCore::viewportErrorMessageTemplate):
(WebCore::viewportErrorMessageLevel):
(WebCore::reportViewportWarning):
* dom/ViewportArguments.h: Added.
(WebCore::):
(WebCore::ViewportArguments::):
(WebCore::ViewportArguments::ViewportArguments):
(WebCore::ViewportArguments::hasCustomArgument):
* html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::process): Modified to call Document::processViewport.
* page/ChromeClient.h:
(WebCore::ChromeClient::didReceiveViewportArguments): Added.
2010-04-16 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Antti Koivisto.
[Qt] GraphicsLayer: support fill-modes
https://bugs.webkit.org/show_bug.cgi?id=36216
Implement the CSS-animation "fill mode" concept in GraphicsLayerQt. The concept
enables a key-frame animation to go to the animation's starting point before the delay,
and/or to stay at the animation's ending point after its ended, without reverting to the default
value.
We do that by manually setting the value to keyframe-0 before the delay if fill-mode is backwards/both,
and manually modifying the default value to the animated value as we animate, with fill-mode forwards/both.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::AnimationQtBase::AnimationQtBase):
(WebCore::TransformAnimationQt::~TransformAnimationQt):
(WebCore::TransformAnimationQt::applyFrame):
(WebCore::GraphicsLayerQt::addAnimation):
2010-04-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (arm build fix).
* bindings/js/JSDesktopNotificationsCustom.cpp:
(WebCore::JSNotification::addEventListener):
(WebCore::JSNotification::removeEventListener):
2010-04-16 Dmitry Titov <dimich@chromium.org>
Reviewed by Yury Semikhatsky.
[v8] In Workers, script errors right after close() are not delivered to the Worker.onerror.
https://bugs.webkit.org/show_bug.cgi?id=37691
Existing worker-close.html will now work in Chromium.
* bindings/v8/V8Utilities.cpp:
(WebCore::getScriptExecutionContext): Stop using proxy() to just retrieve WorkerContext which should be always available.
* bindings/v8/WorkerContextExecutionProxy.h: removed workerContext() accessor which moved to WorkerScriptController.
* bindings/v8/WorkerScriptController.h:
(WebCore::WorkerScriptController::workerContext): Added, to be able to pull WorkerContext out from the controller.
2010-04-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=37735
Remove JSC specific code from WebCore::AtomicString
Add generic constructor/add/find methods that take a UChar* & length, along
with a known existing hash for the string.
This removes the remaining JSC specific code from platform/text.
* bindings/js/JSAbstractWorkerCustom.cpp:
(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):
* bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
* bindings/js/JSDOMBinding.cpp:
(WebCore::ustringToAtomicString):
(WebCore::identifierToAtomicString):
(WebCore::findAtomicString):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::childFrameGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):
* bindings/js/JSElementCustom.cpp:
(WebCore::JSElement::setAttribute):
(WebCore::JSElement::setAttributeNS):
* bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):
* bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::JSHTMLAllCollection::canGetItemsForName):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::JSHTMLCollection::canGetItemsForName):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::canGetItemsForName):
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::canGetItemsForName):
(WebCore::JSHTMLFormElement::nameGetter):
* bindings/js/JSHTMLFrameSetElementCustom.cpp:
(WebCore::JSHTMLFrameSetElement::canGetItemsForName):
(WebCore::JSHTMLFrameSetElement::nameGetter):
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::initMessageEvent):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
* bindings/js/JSMimeTypeArrayCustom.cpp:
(WebCore::JSMimeTypeArray::canGetItemsForName):
(WebCore::JSMimeTypeArray::nameGetter):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
* bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeList::canGetItemsForName):
(WebCore::JSNodeList::nameGetter):
* bindings/js/JSPluginArrayCustom.cpp:
(WebCore::JSPluginArray::canGetItemsForName):
(WebCore::JSPluginArray::nameGetter):
* bindings/js/JSPluginCustom.cpp:
(WebCore::JSPlugin::canGetItemsForName):
(WebCore::JSPlugin::nameGetter):
* bindings/js/JSPopStateEventCustom.cpp:
(WebCore::JSPopStateEvent::initPopStateEvent):
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::setRequestHeader):
(WebCore::JSXMLHttpRequest::getResponseHeader):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):
* platform/text/AtomicString.cpp:
(WebCore::AtomicString::add):
(WebCore::AtomicString::find):
* platform/text/AtomicString.h:
(WebCore::AtomicString::AtomicString):
2010-04-16 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket crash when it receives bad header.
https://bugs.webkit.org/show_bug.cgi?id=37682
If name or value is not valid UTF-8, nameStr or valueStr would be
null string, so crashed in headers->add(nameStr, valueStr).
Check both nameStr and valueStr are not null string.
Otherwise handshake will fail.
Test: websocket/tests/bad-handshake-crash.html
* websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::readHTTPHeaders): check nameStr and valueStr are not null string.
2010-04-16 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7873647> Crash when updating hover state
Test: fast/dynamic/hover-style-recalc-crash.html
Updating the hover state of an element caused the document to need style
recalc, and then updating the hover state of a link caused style recalc,
which changed the render tree while updateHoverActiveState() was iterating
over it, leading to a crash.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateHoverActiveState): Collect the nodes to be
updated into vectors, then update their active and hover states.
2010-04-16 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Alexey Proskuryakov.
Make Safari correctly allocate 5MB of DB storage to all new
origins.
https://bugs.webkit.org/show_bug.cgi?id=36671
Eric fixed the same problem in
DatabaseTracker::fullPathForDatabaseNoLock() in r57128, but forgot
to fix it in DatabaseTracker::detailsForNameAndOrigin() too.
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::detailsForNameAndOrigin):
2010-04-16 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Jian Li.
Implement FileStreamProxy that calls FileStream methods on FileThread for FileAPI
https://bugs.webkit.org/show_bug.cgi?id=37218
No new tests; tests will be added when we add upper layer implementations.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/FileStream.cpp:
(WebCore::FileStream::stop):
* html/FileStream.h:
* html/FileStreamClient.h:
(WebCore::FileStreamClient::didStop):
* html/FileStreamProxy.cpp: Added
* html/FileStreamProxy.h: Added
* html/FileThreadTask.h: Added
2010-04-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).
Remove ustring() method, and constructor passed a UString.
* WebCore.base.exp:
* bindings/js/JSDOMBinding.cpp:
(WebCore::stringimplToUString):
(WebCore::jsStringSlowCase):
(WebCore::ustringToString):
(WebCore::stringToUString):
(WebCore::identifierToString):
* bindings/js/JSDOMBinding.h:
(WebCore::jsString):
* platform/text/AtomicString.cpp:
(WebCore::AtomicString::operator UString):
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::create):
* platform/text/StringImpl.h:
2010-04-16 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Simon Hausmann.
[Qt] WebGL is not visible when QGLWidget viewport is used
https://bugs.webkit.org/show_bug.cgi?id=37070
Added HostWindow parameter to the constructor of GraphicsContext3D.
Shared OpenGL context is initialized with parent QGLWidget.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::create):
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/mac/GraphicsContext3DMac.cpp:
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::getOwnerGLWidget):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
2010-04-16 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Simon Hausmann.
[Qt] WebKit compilation fails with --3d-canvas
https://bugs.webkit.org/show_bug.cgi?id=37699
API for readPixels() has been changed.
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::readPixels):
2010-04-16 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Antti Koivisto.
[Qt]QtLauncher crash on page with CSS 3D transform
https://bugs.webkit.org/show_bug.cgi?id=36859
Added a neccessary null-pointer check, lack of which created the crash circumstances.
Tested by http://css-vfx.googlecode.com/svn/trunk/snowstack/snowstack.html
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::flushChanges):
2010-04-16 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Make sure to update the current graphics context when calling out to AppKit.
* platform/mac/ThemeMac.mm:
(WebCore::paintCheckbox):
(WebCore::paintRadio):
2010-04-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig & Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=37675
Remove casts/constructors to/from JSC::UString type from WebCore::String
WebCore's strings should not know about JSC::UString, this should be abstracted
away in the bindings. Add explicit conversion methods rather than relying on
overloaded cast operators / constructors being implicitly called.
This patch only changes the class String, once this has landed StringImpl, and
hopefully AtomicString too, should follow suit.
This patch adds:
WebCore::identifierToString
WebCore::ustringToString
WebCore::stringToUString
- to JSDOMBindings.h, and updates code to call these methods.
* WebCore.base.exp:
* WebCore.order:
* bindings/js/CachedScriptSourceProvider.h:
(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
* bindings/js/JSAudioConstructor.cpp:
(WebCore::constructAudio):
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::nameGetter):
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::toHTMLCanvasStyle):
(WebCore::JSCanvasRenderingContext2D::setFillColor):
(WebCore::JSCanvasRenderingContext2D::setStrokeColor):
(WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
(WebCore::JSCanvasRenderingContext2D::setShadow):
(WebCore::JSCanvasRenderingContext2D::fillText):
(WebCore::JSCanvasRenderingContext2D::strokeText):
* bindings/js/JSClipboardCustom.cpp:
(WebCore::JSClipboard::types):
(WebCore::JSClipboard::clearData):
(WebCore::JSClipboard::getData):
(WebCore::JSClipboard::setData):
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
* bindings/js/JSDOMBinding.cpp:
(WebCore::identifierToString):
(WebCore::ustringToString):
(WebCore::stringToUString):
(WebCore::valueToStringWithNullCheck):
(WebCore::valueToStringWithUndefinedOrNullCheck):
(WebCore::reportException):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMFormDataCustom.cpp:
(WebCore::JSDOMFormData::append):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::setLocation):
(WebCore::JSDOMWindow::openDatabase):
* bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::changeVersion):
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::setLocation):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSEventSourceConstructor.cpp:
(WebCore::constructEventSource):
* bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::callHTMLAllCollection):
* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::callHTMLCollection):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
(WebCore::documentWrite):
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
* bindings/js/JSInspectorFrontendHostCustom.cpp:
(WebCore::JSInspectorFrontendHost::showContextMenu):
* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction):
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::setHref):
(WebCore::JSLocation::setProtocol):
(WebCore::JSLocation::setHost):
(WebCore::JSLocation::setHostname):
(WebCore::JSLocation::setPathname):
(WebCore::JSLocation::setSearch):
(WebCore::JSLocation::setHash):
(WebCore::JSLocation::replace):
(WebCore::JSLocation::assign):
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::initMessageEvent):
* bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::canGetItemsForName):
(WebCore::JSNamedNodeMap::nameGetter):
* bindings/js/JSOptionConstructor.cpp:
(WebCore::constructHTMLOptionElement):
* bindings/js/JSSQLResultSetRowListCustom.cpp:
(WebCore::JSSQLResultSetRowList::item):
* bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
* bindings/js/JSSharedWorkerConstructor.cpp:
(WebCore::constructSharedWorker):
* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::canGetItemsForName):
(WebCore::JSStorage::nameGetter):
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):
(WebCore::JSStorage::putDelegate):
* bindings/js/JSStyleSheetListCustom.cpp:
(WebCore::JSStyleSheetList::canGetItemsForName):
(WebCore::JSStyleSheetList::nameGetter):
* bindings/js/JSWebKitCSSMatrixConstructor.cpp:
(WebCore::constructWebKitCSSMatrix):
* bindings/js/JSWebSocketConstructor.cpp:
(WebCore::constructWebSocket):
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::send):
* bindings/js/JSWorkerConstructor.cpp:
(WebCore::constructWorker):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::importScripts):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::open):
(WebCore::JSXMLHttpRequest::setRequestHeader):
(WebCore::JSXMLHttpRequest::send):
(WebCore::JSXMLHttpRequest::overrideMimeType):
* bindings/js/JSXSLTProcessorCustom.cpp:
(WebCore::JSXSLTProcessor::setParameter):
(WebCore::JSXSLTProcessor::getParameter):
(WebCore::JSXSLTProcessor::removeParameter):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
* bindings/js/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::ScriptCallFrame):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::dispatchFailedToParseSource):
(WebCore::ScriptDebugServer::sourceParsed):
* bindings/js/ScriptEventListener.cpp:
(WebCore::getEventListenerHandlerBody):
* bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::appendArgument):
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):
* bindings/js/ScriptObject.cpp:
(WebCore::ScriptObject::set):
* bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):
* bindings/js/ScriptString.h:
(WebCore::ScriptString::operator String):
(WebCore::ScriptString::ustring):
(WebCore::ScriptString::operator+=):
* bindings/js/ScriptValue.cpp:
(WebCore::ScriptValue::getString):
* bindings/js/ScriptValue.h:
(WebCore::ScriptValue::toString):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedObject::set):
(WebCore::SerializingTreeWalker::convertIfTerminal):
(WebCore::DeserializingTreeWalker::putProperty):
* bindings/js/StringSourceProvider.h:
(WebCore::StringSourceProvider::StringSourceProvider):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject valueForKey:]):
(-[WebScriptObject removeWebScriptKey:]):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/IdentifierRep.cpp:
(WebCore::IdentifierRep::get):
* bridge/c/c_utility.cpp:
(JSC::Bindings::identifierFromNPIdentifier):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::scriptImported):
(WebCore::InspectorController::addProfileFinishedMessageToConsole):
(WebCore::InspectorController::createProfileHeader):
* inspector/InspectorResource.cpp:
(WebCore::InspectorResource::sourceString):
* inspector/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::functionName):
* platform/KURL.h:
(WebCore::KURL::operator const String&):
* platform/text/AtomicString.cpp:
(WebCore::AtomicString::operator UString):
* platform/text/AtomicString.h:
* platform/text/PlatformString.h:
* platform/text/String.cpp:
2010-04-16 Anders Carlsson <andersca@apple.com>
Reviewed by David Hyatt.
Always pass a view to the AppKit drawing functions.
https://bugs.webkit.org/show_bug.cgi?id=37724
* platform/mac/ThemeMac.mm:
(WebCore::paintCheckbox):
(WebCore::paintRadio):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::paintSliderThumb):
(WebCore::RenderThemeMac::paintSearchField):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
2010-04-16 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=37718
Safari crashes with certain JavaScript charCode events in EventHandler::needsKeyboardEventDisambiguationQuirks
Test: fast/events/recorded-keydown-event.html
* dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::charCode): Check if the view (window) is
frameless.
2010-04-16 Jian Li <jianli@chromium.org>
Reviewed by Dmitry Titov.
Update FormDataList to fix style violations in old code.
https://bugs.webkit.org/show_bug.cgi?id=37689
* html/FormDataList.h:
(WebCore::FormDataList::appendData):
(WebCore::FormDataList::appendBlob):
2010-04-16 Anders Carlsson <andersca@apple.com>
Fix WebKit2 build.
* WebCore.base.exp:
2010-04-16 Jay Civelli <jcivelli@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Fix Mac build.
https://bugs.webkit.org/show_bug.cgi?id=37436
* platform/chromium/PopupMenuChromium.h:
2010-04-16 Jay Civelli <jcivelli@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Select popups would assert when destroyed.
https://bugs.webkit.org/show_bug.cgi?id=37436
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupContainer::PopupContainer):
(WebCore::PopupContainer::showPopup):
(WebCore::PopupContainer::notifyPopupHidden):
* platform/chromium/PopupMenuChromium.h:
2010-04-16 Antonio Gomes <tonikitoo@webkit.org>
Unreviewed QtWebKit (with Qt 4.7) build fix.
Bug 37683 moved code from FontQt.cpp to FontPlatformDataQt.cpp but did not
renamed the variable used.
* platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
2010-04-16 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Make GraphicsLayerQt always use ItemCoordinateCache, and remove ItemUsesExtendedStyleOption.
This aligns our implementation with the Safari implementation - layers are always uploaded
to textures in item units, and WebCore is responsible for the heuristics.
[Qt] GraphicsLayer: performance optimizations
https://bugs.webkit.org/show_bug.cgi?id=35393
No new tests. Still no FPS benchmarks available (on any platform)
but animations are noticably better.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::paint):
(WebCore::GraphicsLayerQtImpl::flushChanges):
(WebCore::TransformAnimationQt::updateState):
2010-04-16 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] WebCore::Font::font() causes a QFont detach
https://bugs.webkit.org/show_bug.cgi?id=37683
Moved the setStyleStrategy call to FontPlatformData
to avoid the detach.
Thanks to Holger for spotting this.
* platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::font):
2010-04-15 Matt Perry <mpcomplete@chromium.org>
Reviewed by Adam Barth.
Remove the check for the main frame's scheme when deciding which
v8 extensions to add to a script context. Instead, Chromium will
handle that check elsewhere to allow finer-grained control over
what APIs we expose to web pages.
https://bugs.webkit.org/show_bug.cgi?id=37681
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::createNewContext):
2010-04-15 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Antti Koivisto.
No default selection for <select multiple> menu lists.
https://bugs.webkit.org/show_bug.cgi?id=37530
Manual test: manual-tests/no-listbox-rendering.html
For menu lists, if the selection is not indicated by the html file, the first <option> will be
selected after loading the page or reseting the form. On the other hand listboxes may have no
element selected after loading the page or reseting the form.
When NO_LISTBOX_RENDERING is enabled listboxes becomes menu lists. Those <select multiple>
that did not have selected elements, now being menu lists, will have the first <option>
selected. That is the behavior difference that this patch corrects.
When NO_LISTBOX_RENDERING is enabled usesMenuList() always returns true then usesMenuList() cannot
be used to decide about initial selection of the elements. This patch replaces (usesMenuLists())
by (!multiple && size <= 1) where initial selection is considered.
* dom/SelectElement.cpp:
(WebCore::SelectElement::recalcListItems):
(WebCore::SelectElement::reset):
* manual-tests/no-listbox-rendering.html: Added.
2010-04-15 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Index validation code validates too many vertex attributes
https://bugs.webkit.org/show_bug.cgi?id=31892
* html/canvas/WebGLProgram.cpp:
(WebCore::WebGLProgram::cacheActiveAttribLocations): Cache active attribute locations for a program at linkProgram time.
(WebCore::WebGLProgram::getActiveAttribLocation): Get the cached attribute location.
(WebCore::WebGLProgram::numActiveAttribLocations): Get the number of cached attribute locations.
* html/canvas/WebGLProgram.h: Add attribute locations member.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateRenderingState): Add logic not to validate those attributes that do not belong to the current program.
(WebCore::WebGLRenderingContext::linkProgram): Call cacheActiveAttribLocations().
2010-04-16 Adam Roben <aroben@apple.com>
Don't assert when soft-linked libraries can't be found
In some situations (e.g., when using SOFT_LINK_OPTIONAL), we expect soft-link libraries not
to be able to be found in all cases. So we shouldn't assert that they're always found.
Reviewed by Sam Weinig.
* platform/win/SoftLinking.h:
(SOFT_LINK): Don't assert when LoadLibrary fails.
2010-04-15 Dmitry Titov <dimich@chromium.org>
Unreviewed, rolling out r57688.
http://trac.webkit.org/changeset/57688
https://bugs.webkit.org/show_bug.cgi?id=34992
Makes fast/workers/dedicated-worker-lifecycle.html crashing on all GTK bots
* bindings/js/JSWorkerContextCustom.cpp:
* bindings/v8/custom/V8WorkerContextCustom.cpp:
* storage/Database.idl:
* storage/SQLError.idl:
* storage/SQLResultSet.idl:
* storage/SQLResultSetRowList.idl:
* storage/SQLTransaction.idl:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::openDatabase):
* workers/WorkerContext.h:
(WebCore::WorkerContext::databaseExceededQuota):
* workers/WorkerContext.idl:
2010-04-15 Yury Semikhatsky <yurys@google.com>
Reviewed by Pavel Feldman.
Support basic debugging capabilities including step in/over/out in v8
implementation of ScriptDebugServer.
https://bugs.webkit.org/show_bug.cgi?id=37604
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::setDebuggerScriptSource):
(WebCore::ScriptDebugServer::addListener):
(WebCore::ScriptDebugServer::removeListener):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::setBreakpointsActivated):
(WebCore::ScriptDebugServer::continueProgram):
(WebCore::ScriptDebugServer::stepIntoStatement):
(WebCore::ScriptDebugServer::stepOverStatement):
(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::currentCallFrameState):
(WebCore::ScriptDebugServer::currentCallFrameV8):
(WebCore::ScriptDebugServer::onV8DebugMessage):
(WebCore::ScriptDebugServer::onV8DebugHostDispatch):
(WebCore::ScriptDebugServer::handleV8DebugHostDispatch):
(WebCore::ScriptDebugServer::handleV8DebugMessage):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):
(WebCore::ScriptDebugServer::didResume):
* bindings/v8/ScriptDebugServer.h:
(WebCore::ScriptDebugServer::pauseOnExceptionsState):
(WebCore::ScriptDebugServer::setPauseOnExceptionsState):
(WebCore::ScriptDebugServer::setMessageLoopDispatchHandler):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
(WebCore::V8InjectedScriptHost::currentCallFrameCallback):
(WebCore::V8InjectedScriptHost::isActivationCallback):
* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor):
(injectedScriptConstructor.):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
2010-04-15 Jian Li <jianli@chromium.org>
Reviewed by Dmitry Titov.
Support using FormData to send a sliced file via XHR.
https://bugs.webkit.org/show_bug.cgi?id=36678
Tests: http/tests/local/formdata/send-form-data-with-sliced-file.html
* html/Blob.h:
(WebCore::Blob::isFile):
* html/DOMFormData.cpp:
(WebCore::DOMFormData::append):
* html/File.h:
(WebCore::File::isFile):
* html/FormDataList.h:
(WebCore::FormDataList::appendBlob):
(WebCore::FormDataList::Item::Item):
(WebCore::FormDataList::Item::blob):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::appendFormData):
* platform/network/FormData.cpp:
(WebCore::FormData::appendDOMFormData):
* platform/network/mac/FormDataStreamMac.mm:
(WebCore::closeCurrentStream):
2010-04-15 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Must enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization
https://bugs.webkit.org/show_bug.cgi?id=37178
Test: fast/canvas/webgl/point-size.html
* platform/graphics/mac/GraphicsContext3DMac.cpp: Enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization.
(WebCore::GraphicsContext3D::GraphicsContext3D):
2010-04-15 Eric Uhrhane <ericu@chromium.org>
Reviewed by Dmitry Titov.
Add bindings for async DB API in Workers.
https://bugs.webkit.org/show_bug.cgi?id=34992
Tests: storage/change-version-handle-reuse-worker.html
storage/execute-sql-args-worker.html
* bindings/js/JSWorkerContextCustom.cpp: Add openDatabase binding.
(WebCore::JSWorkerContext::openDatabase):
* bindings/v8/custom/V8WorkerContextCustom.cpp: Add openDatabase stub; Chromium will need work both in V8 and in the browser process before we can turn this on there.
(WebCore::V8WorkerContext::openDatabaseCallback):
Add NoStaticTables flags to all objects now shared with workers.
* storage/Database.idl:
* storage/SQLError.idl:
* storage/SQLResultSet.idl:
* storage/SQLResultSetRowList.idl:
* storage/SQLTransaction.idl:
* workers/WorkerContext.h: Add databaseExceededQuota.
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::databaseExceededQuota): Add stub implementation for testing; you just get 5MB for now.
(WebCore::WorkerContext::openDatabase): Remove invalid assertion.
Add the IDL for the call to openDatabase.
* workers/WorkerContext.idl:
2010-04-15 Nicolas Weber <thakis@chromium.org>
Reviewed by Dimitri Glazkov.
Fix drag image thumbnails for indexed images.
https://bugs.webkit.org/show_bug.cgi?id=37621
* platform/chromium/DragImageChromiumMac.cpp:
(WebCore::scaleDragImage): Always use RGB color space.
(WebCore::dissolveDragImageToFraction): Always use RGB color space.
2010-04-15 Adam Roben <aroben@apple.com>
Expose UserContentURLPattern as WebKit SPI
Fixes <http://webkit.org/b/37354>.
Reviewed by Tim Hatcher.
* WebCore.base.exp: Export UserContentURLPattern::parse, and sorted
the file.
* WebCore.xcodeproj/project.pbxproj: Marked UserContentURLPattern.h as
"Private".
* page/UserContentURLPattern.h:
(WebCore::UserContentURLPattern::UserContentURLPattern): Added a
default constructor.
(WebCore::UserContentURLPattern::isValid): Added this getter.
2010-04-15 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
AXHelp is being appended from ancestors incorrectly
https://bugs.webkit.org/show_bug.cgi?id=37659
Test: platform/mac/accessibility/unexpected-help-text.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::helpText):
2010-04-15 David Hyatt <hyatt@apple.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=37669, REGRESSION: visited styles don't work right when only the visited path specifies
a pseudoelement.
Rework the pseudo cache on RenderStyles to support nesting, i.e., a pseudo hanging off a pseudo. The existing model gets
confused by this concept, since it relies on a singly linked list of chained pseudo styles (instead of a Vector owned by a primary
style). I changed the style cache to be a Vector instead.
Reworked both styleForElement and pseudoStyleForElement to resolve visited styles first, since in the pseudoStyleForElement case
you need to do this in order to know to allocate an unvisited pseudo style even if one shouldn't normally exist.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
* dom/Element.cpp:
(WebCore::Element::pseudoStyleCacheIsInvalid):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getCachedPseudoStyle):
(WebCore::RenderStyle::addCachedPseudoStyle):
* rendering/style/RenderStyle.h:
(WebCore::):
(WebCore::InheritedFlags::cachedPseudoStyles):
2010-04-15 Albert J. Wong <ajwong@chromium.org>
Unreviewed, rolling out r57660.
http://trac.webkit.org/changeset/57660
https://bugs.webkit.org/show_bug.cgi?id=37604
Broke a large number of inspector layout tests in chromium.
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
* bindings/v8/ScriptDebugServer.cpp:
* bindings/v8/ScriptDebugServer.h:
(WebCore::ScriptDebugServer::addListener):
(WebCore::ScriptDebugServer::removeListener):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::setBreakpointsActivated):
(WebCore::ScriptDebugServer::pauseOnExceptionsState):
(WebCore::ScriptDebugServer::setPauseOnExceptionsState):
(WebCore::ScriptDebugServer::continueProgram):
(WebCore::ScriptDebugServer::stepIntoStatement):
(WebCore::ScriptDebugServer::stepOverStatement):
(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::currentCallFrameState):
(WebCore::ScriptDebugServer::ScriptDebugServer):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
(WebCore::V8InjectedScriptHost::currentCallFrameCallback):
(WebCore::V8InjectedScriptHost::isActivationCallback):
* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
2010-04-14 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
DatabaseTracker refactoring: remove the dependency on
OriginQuotaManager from DatabaseTracker.h
https://bugs.webkit.org/show_bug.cgi?id=31482
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::DatabaseTracker):
(WebCore::DatabaseTracker::~DatabaseTracker):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::hasEntryForOrigin):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::usageForOriginNoLock):
(WebCore::DatabaseTracker::usageForOrigin):
(WebCore::DatabaseTracker::quotaForOrigin):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):
* storage/DatabaseTracker.h:
* storage/SQLTransactionClient.cpp:
(WebCore::SQLTransactionClient::didExecuteStatement):
2010-04-15 Zhenyao Mo <zmo@google.com>
Reviewed by Adam Barth.
Several tests in fast/canvas/webgl/ failed randomly on Leopard Commit Bot
This fixes an uninitialized variable bug and restores a glFinish call that used to be present.
https://bugs.webkit.org/show_bug.cgi?id=36908
* platform/graphics/mac/GraphicsContext3DMac.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D): Initialize width/height to 0/0.
(WebCore::GraphicsContext3D::prepareTexture): Restore glFinish() in every path.
2010-04-14 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Simon Fraser.
Spatial Navigation: make hasOffscreenRect() to earlier return 'true' if absoluteClippedOverflowRect() gives an empty rect
https://bugs.webkit.org/show_bug.cgi?id=37635
absoluteClippedOverflowRect method of RenderObject does return an empty IntRect for offscreen nodes.
So hasOffscreenRect method (SpatialNavigation.cpp) can safily bail out earlier in such cases.
* page/SpatialNavigation.cpp:
(WebCore::hasOffscreenRect):
2010-04-14 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Simon Fraser.
Spatial Navigation: remove unnecessery assignment in updateFocusCandidateIfCloser method
https://bugs.webkit.org/show_bug.cgi?id=37634
This assignment line is not longer needed after r57061, bug that refactored all
assignment logic to happen lines below in the method.
* page/FocusController.cpp:
(WebCore::updateFocusCandidateIfCloser):
2010-04-15 Yury Semikhatsky <yurys@google.com>
Reviewed by Pavel Feldman.
Support basic debugging capabilities including step in/over/out in v8
implementation of ScriptDebugServer.
https://bugs.webkit.org/show_bug.cgi?id=37604
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::setDebuggerScriptSource):
(WebCore::ScriptDebugServer::addListener):
(WebCore::ScriptDebugServer::removeListener):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::setBreakpointsActivated):
(WebCore::ScriptDebugServer::continueProgram):
(WebCore::ScriptDebugServer::stepIntoStatement):
(WebCore::ScriptDebugServer::stepOverStatement):
(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::currentCallFrameState):
(WebCore::ScriptDebugServer::currentCallFrameV8):
(WebCore::ScriptDebugServer::onV8DebugMessage):
(WebCore::ScriptDebugServer::onV8DebugHostDispatch):
(WebCore::ScriptDebugServer::handleV8DebugHostDispatch):
(WebCore::ScriptDebugServer::handleV8DebugMessage):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):
(WebCore::ScriptDebugServer::didResume):
* bindings/v8/ScriptDebugServer.h:
(WebCore::ScriptDebugServer::pauseOnExceptionsState):
(WebCore::ScriptDebugServer::setPauseOnExceptionsState):
(WebCore::ScriptDebugServer::setMessageLoopDispatchHandler):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
(WebCore::V8InjectedScriptHost::currentCallFrameCallback):
(WebCore::V8InjectedScriptHost::isActivationCallback):
* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor):
(injectedScriptConstructor.):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
2010-04-15 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Beth Dakin.
RenderSVGResource <-> id mapping should be cached
https://bugs.webkit.org/show_bug.cgi?id=37575
Test: svg/custom/clip-path-id-changes.svg
* rendering/RenderSVGResource.h:
(WebCore::RenderSVGResource::RenderSVGResource):
(WebCore::RenderSVGResource::~RenderSVGResource):
(WebCore::RenderSVGResource::idChanged):
(WebCore::getRenderSVGResourceById):
* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::addResource):
(WebCore::SVGDocumentExtensions::removeResource):
(WebCore::SVGDocumentExtensions::resourceById):
* svg/SVGDocumentExtensions.h:
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::svgAttributeChanged):
2010-04-15 Justin Schuh <jschuh@chromium.org>
Reviewed by Dimitri Glazkov.
LayoutTest breakage in V8 bindings after r57627
https://bugs.webkit.org/show_bug.cgi?id=37660
Fixes breakage of the following tests due to an error in V8 bindings for
NamedNodeMap:
hc_namednodemapinuseattributeerr.html
hc_namednodemapsetnameditemreturnvalue.html
hc_namednodemapwrongdocumenterr.html
hc_namednodemapinvalidtype1.html
NamedNodeMap-setNamedItem-crash.html
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::V8NamedNodeMap::setNamedItemNSCallback):
(WebCore::V8NamedNodeMap::setNamedItemCallback):
2010-04-15 David Hyatt <hyatt@apple.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=37567, :first-letter inside a :visited link is wrong color. Make sure
that the pseudo style caching allows visited link styles to hang off other pseudo styles.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getCachedPseudoStyle):
2010-04-15 Ben Murdoch <benm@google.com>
Unreviewed, rolling out r57652.
http://trac.webkit.org/changeset/57652
https://bugs.webkit.org/show_bug.cgi?id=37609
Caused a build break on Chromium Mac and Layout Test fail on
Qt
* platform/PlatformTouchPoint.h:
(WebCore::PlatformTouchPoint::):
* platform/qt/PlatformTouchPointQt.cpp:
(WebCore::PlatformTouchPoint::PlatformTouchPoint):
2010-04-15 Yaar Schnitman <yaar@chromium.org>
Reviewed by Nate Chapin.
Overloads auto-generation in V8
https://bugs.webkit.org/show_bug.cgi?id=37373
This will be used by XHR.send/open, Canvas.*, WebGL.* methods that are currently custom. When more than a single overload exists for a method, the correct overload is chosen based on the total number of arguments passed as well as the values passed to non-primitive arguments.
Overload dispatch order depends on the order the functions are defined in the IDL. Overloads must be specified from the most precise (overloads with wrapper type arguments) to the least precise (overloads with only primitive type arguments).
* bindings/scripts/CodeGeneratorV8.pm: Identify and output overloads callbacks and dispatch code.
* bindings/v8/test/TestObj.idl: Overloads sample.
* bindings/v8/test/V8TestObj.cpp: Output change.
2010-04-15 Ben Murdoch <benm@google.com>
Reviewed by Kenneth Rohde Christiansen.
The TouchStationary state of WebCore::PlatformTouchPoint
is not handled inside the touch event handler.
https://bugs.webkit.org/show_bug.cgi?id=37609
After discussions at the WebKit contributors meeting, we decided
that this is a currently unused state without a good future use
case in the Touch API and thus decided to remove it. This patch
actions that decision.
As the TouchStationary state is not handled in the EventHandler,
there is no change in functionality so no new tests are required.
* platform/PlatformTouchPoint.h:
(WebCore::PlatformTouchPoint::): Remove TouchStationary.
* platform/qt/PlatformTouchPointQt.cpp:
(WebCore::PlatformTouchPoint::PlatformTouchPoint): Remove TouchStationary.
2010-04-15 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Use a lower-overhead mechanism for plug-in message throttling
https://bugs.webkit.org/show_bug.cgi?id=37642
<rdar://problem/7418285> Very high CPU usage idling in gmail under Windows 7 (plug-in related)
GMail has an instance of Flash that loads on the main mail page.
This Flash content sends us a constant stream of WM_USER+1 messsages.
There was already code in PluginMessageThrottlerWin to queue and process these
excess WM_USER+1 messages from Flash. Unfortunately, there were a couple of
problems with this code:
- The timer used to process the excess messages had a very low timeout (1ms).
Chrome uses a value of 5ms for this delay, and doesn't use excess CPU here,
while still maintaining good Flash frame rate.
- The overhead involved in generating a constant stream of 5ms timers still swamped
the CPU, resulting in continued high CPU utilization.
To fix this, I changed the throttling code to:
- Process a queued WM_USER+1 message directly if none has been processed in 5ms.
This allows us to avoid the overhead of a timer.
- Process remaining delayed WM_USER+1 messages on a 16ms timer.
This reduces our CPU utilization idling in GMail from ~20% to ~2-3% on my system.
I also verified the frame rate for Flash content wasn't reduced with this change.
* plugins/win/PluginMessageThrottlerWin.cpp:
(WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin): Initialize m_lastMessageTime.
(WebCore::PluginMessageThrottlerWin::appendMessage): Process a queued message directly if >5ms have passed.
(WebCore::PluginMessageThrottlerWin::processQueuedMessage): Split out from messageThrottleTimerFired.
(WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired): Call through to processQueuedMessage.
* plugins/win/PluginMessageThrottlerWin.h: Add processQueuedMessage, m_lastMessageTime.
2010-04-15 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
LEAK: in ThreadableWebSocketChannel::create()
https://bugs.webkit.org/show_bug.cgi?id=37584
No new tests because this change just fixes a leak.
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
* websockets/WorkerThreadableWebSocketChannel.h:
(WebCore::WorkerThreadableWebSocketChannel::Bridge::create):
2010-04-15 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Eric Seidel.
Duplicated patches related to wml were pushed to trunk. So, one of
the patches should be reverted.
https://bugs.webkit.org/show_bug.cgi?id=37542
* wml/WMLOptionElement.h:
* wml/WMLSelectElement.h:
2010-04-15 Bruno Schmidt <bruno.schmidt@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Null QObjects properties cause Segmentation Fault
https://bugs.webkit.org/show_bug.cgi?id=34730
QObjects exported to the QWebkit javascript with properties that are
a null "QObject*" cause Segmentation Fault.
If an QObject is added to the javascript context and it contains
properties of the type QObject* with NULL value, calling the property
causes Segmentation Fault.
So now the code below properly checks for null pointers:
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::getClass): may return NULL
(JSC::Bindings::QtInstance::getMethod): may return jsNull()
(JSC::Bindings::QtInstance::stringValue): may return jsNull()
(JSC::Bindings::QtInstance::booleanValue): may return false
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue): May return jsNull on QObjectStar
2010-04-14 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Repaint of fixed, transformed element is broken
https://bugs.webkit.org/show_bug.cgi?id=37637
RenderBox::computeRectForRepaint() failed to set the 'fixed' flag correctly
for elements that had both fixed position and a transform. If the element has
a transform, 'fixed' should only remain true if the element itself is fixed
position.
Also cache style()->position() in a local variable for performance.
Test: fast/repaint/fixed-tranformed.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):
2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Changing view mode names due to specification changes
https://bugs.webkit.org/show_bug.cgi?id=37615
test: fast/media/media-feature-wgt-view-mode.html
specification: http://dev.w3.org/2006/waf/widgets-vmmf/
* css/MediaQueryEvaluator.cpp:
(WebCore::view_modeMediaFeatureEval):
* page/ChromeClient.h:
(WebCore::ChromeClient::isWindowed):
(WebCore::ChromeClient::isMaximized):
(WebCore::ChromeClient::isMinimized):
2010-04-14 Adam Barth <abarth@webkit.org>
Unreviewed attempt to fix Qt build.
* bindings/js/JSNodeCustom.cpp:
2010-04-14 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Javascript URL can be set as iframe.src via multiple DOM aliases
https://bugs.webkit.org/show_bug.cgi?id=37031
Moved frame/iframe checks from Attr to Node on inherited members.
Node child manipulation methods now return NOT_SUPPORTED_ERR if used
on a frame/iframe src attribute.
NamedNodeMap set methods now perform frame/iframe src checks.
Moved allowSettingSrcToJavascriptURL stati