2005-08-23 David Harrison Reviewed by Darin. REGRESSION: Blank content at http://www.the-leaky-cauldron.org/ with Denver and TOT Test cases added: * layout-tests/fast/parser/comments-expected.txt: Added. * layout-tests/fast/parser/comments.html: Added. * khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseComment): When non-space follows comment end, ignore that comment end. 2005-08-23 Justin Garcia Reviewed by mjs Temporary workaround for gcc-5216+ bug 4213314. Don't use NSMake* convenience methods inside KWQ_BLOCK_EXCEPTIONS. * kwq/KWQKConfigBase.mm: (KConfig::readEntry): * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): * kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines): * kwq/KWQPainter.mm: (QPainter::drawTiledPixmap): * kwq/KWQScrollView.mm: (QScrollView::resizeContents): (QScrollView::contentsToViewport): (QScrollView::viewportToContents): (QScrollView::setContentsPosRecursive): (QScrollView::ensureVisible): (QScrollView::ensureRectVisibleCentered): 2005-08-22 John Sullivan Reviewed by Beth Dakin. - fixed Several 32-byte leaks after choosing pop-up menu at dzone198.apple.com Test cases added: none, doesn't affect layout. I did execute run-layout-tests to verify that there were no surprises though. * khtml/ecma/xmlhttprequest.h: use SharedPtr for onReadyStateChangeListener and onLoadListener * khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): use notNull() instead of testing SharedPtrs against 0 (KJS::XMLHttpRequest::putValueProperty): use reset() to set values of SharedPtrs; eliminate ref()s that had no deref()s (KJS::XMLHttpRequest::mark): use notNull() instead of testing SharedPtrs against 0 (KJS::XMLHttpRequest::XMLHttpRequest): don't initialize SharedPtrs (KJS::XMLHttpRequest::changeState): use notNull() instead of testing SharedPtrs against 0 2005-08-22 David Harrison Reviewed by Justin. Denver Regression: stickies widget crashed on 8F15 when pasting text Test cases added: None. Problem triggered by simple paste, which lots of the editing tests already do, but also required particular memory layout/cleanup state, which is not specifiable in our tests. * khtml/editing/markup.cpp: (khtml::createFragmentFromText): Ref the new paragraph element right away, rather than allocating more memory first. 2005-08-22 Eric Seidel Fix by Tobias Lidskog Reviewed by eseidel. * kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::inputImage): null check (KCanvasFEBlendQuartz::getCIFilter): ditto (KCanvasFEColorMatrixQuartz::getCIFilter): ditto (KCanvasFEMergeQuartz::getCIFilter): ditto Added NULL checks to avoid throwing Obj-C exceptions from CoreImage either when rendering bad SVGs or in cases where we do not yet implement a certain SVG filter element. http://bugs.webkit.org/show_bug.cgi?id=4554 2005-08-22 Eric Seidel Reviewed by darin. * ksvg2/impl/SVGScriptElementImpl.cpp: (SVGScriptElementImpl::executeScript): Added necessary Interpreter::lock()/unlock() calls to prevent assertion failure when loading SVGs with JavaScript. http://bugs.webkit.org/show_bug.cgi?id=4580 2005-08-22 Eric Seidel Reviewed by darin. * WebCore.xcodeproj/project.pbxproj: Applied Darin's nmedit workaround/build-speedup to WebCore+SVG. http://bugs.webkit.org/show_bug.cgi?id=4577 2005-08-22 Eric Seidel Fix by Tobias Lidskog Reviewed by eseidel. * kcanvas/device/KRenderingPaintServerSolid.cpp: * kcanvas/device/KRenderingPaintServerSolid.h: * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerSolidQuartz::draw): * svg-tests/W3C-SVG-1.1/animate-elem-22-b-expected.png: * svg-tests/W3C-SVG-1.1/masking-opacity-01-b-expected.png: Group opacity was doubly-applied. This patch fixes that. http://bugs.webkit.org/show_bug.cgi?id=4463 2005-08-22 Eric Seidel Fix by Tobias Lidskog Reviewed by eseidel. * kcanvas/device/quartz/QuartzSupport.mm: (CGPathToCFStringApplierFunction): Fixed output for curves. * svg-tests/W3C-SVG-1.1/Resources/filters-example-01-f-expected.txt: * svg-tests/W3C-SVG-1.1/Resources/paths-data-01-f-expected.txt: * svg-tests/W3C-SVG-1.1/Resources/paths-data-02-f-expected.txt: * svg-tests/W3C-SVG-1.1/Resources/paths-data-03-f-expected.txt: * svg-tests/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.txt: * svg-tests/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.txt: * svg-tests/W3C-SVG-1.1/animate-elem-06-t-expected.txt: * svg-tests/W3C-SVG-1.1/animate-elem-07-t-expected.txt: * svg-tests/W3C-SVG-1.1/animate-elem-08-t-expected.txt: * svg-tests/W3C-SVG-1.1/animate-elem-28-t-expected.txt: * svg-tests/W3C-SVG-1.1/filters-example-01-b-expected.txt: * svg-tests/W3C-SVG-1.1/filters-morph-01-f-expected.txt: * svg-tests/W3C-SVG-1.1/fonts-elem-01-t-expected.txt: * svg-tests/W3C-SVG-1.1/fonts-elem-02-t-expected.txt: * svg-tests/W3C-SVG-1.1/fonts-elem-03-b-expected.txt: * svg-tests/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: * svg-tests/W3C-SVG-1.1/metadata-example-01-b-expected.txt: * svg-tests/W3C-SVG-1.1/paths-data-01-t-expected.txt: * svg-tests/W3C-SVG-1.1/paths-data-02-t-expected.txt: * svg-tests/W3C-SVG-1.1/paths-data-03-f-expected.txt: * svg-tests/W3C-SVG-1.1/shapes-rect-01-t-expected.txt: * svg-tests/W3C-SVG-1.1/text-path-01-b-expected.txt: Fixed output for curves and updated tests accordingly. http://bugs.webkit.org/show_bug.cgi?id=4553 2005-08-22 Eric Seidel Fix by Tobias Lidskog Reviewed by eseidel. * kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::prepareFilter): * kcanvas/device/quartz/KRenderingDeviceQuartz.h: * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceQuartz::filtersEnabled): (KRenderingDeviceQuartz::setFiltersEnabled): (KRenderingDeviceQuartz::hardwareRenderingEnabled): (KRenderingDeviceQuartz::setHardwareRenderingEnabled): Added ability to disable hardware rendering (for testing). http://bugs.webkit.org/show_bug.cgi?id=4550 2005-08-20 Darin Adler * khtml/xml/xml_namespace_table.cpp: Removed this file that's been obsolete and unused for a while. * khtml/xml/xml_namespace_table.h: Ditto. 2005-08-19 Anders Carlsson Reviewed by Darin. Landed by David Harrison. - fixed http://bugs.webkit.org/show_bug.cgi?id=4475