=== WebCore-125.8.10 === 2004-10-07 Adele Amchan Reviewed by Darin. Some of this was rolled from HEAD, and some is a new bug fix that we'll do on TOT separately. - fixed REGRESSION (Navy): Safari no longer works with Wachovia online banking after logging in - fixed REGRESSION (Navy): onload handler doesn't run on page with meta refresh (0 duration) (clone for SUPanNavy) The fix for made it so we stopped tokenizing once an immediate redirect was pending. For the Wachovia bug, there was a failing history.go call in the ; even though it did not cause any navigation, it prevented the rest of the page from being loaded. Now we check to see if the requested history navigation is possible, and if it's not then we continue processing the rest of the page as normal. Another problem caused by the same fix is that redirects were preventing tokenizing in the same way. This is incorrect; the reason the JavaScript-triggered loads prevent tokenizing is that they take place "right away" in other browsers, but that is not true of redirect. We fixed this by using a separate call for redirect and not preventing tokenizing when that's in effect. * khtml/khtml_part.h: Removed userGesture parameter from scheduleRedirection. Renamed isImmediateRedirectPending to isScheduledLocationChangePending. Added scheduleLocationChange. * khtml/khtml_part.cpp: (KHTMLPart::openURL): Updated for new constant name. (KHTMLPart::scheduleRedirection): Removed now-unneeded userGesture parameter, and removed code that does the special case for redirection during load; a refresh can never be one of those special redirects during a load because it redirects the frame itself, not another frame. Also tightened up the logic by always stopping the redirect timer even if we aren't restarting it. (KHTMLPart::scheduleLocationChange): Added. Like scheduleRedirection, but with a different constant so we can tell it apart and always a delay of 0. The "redirection during load" case was moved in here and renamed to locationChangeScheduledDuringLoad. (KHTMLPart::isScheduledLocationChangePending): Renamed from isImmediateRedirectPending. This now returns true only for location changes and history navigation, not redirects. (KHTMLPart::scheduleHistoryNavigation): Added a check of canGoBackOrForward across bridge so we don't set up a history navigation that will just fail later. This fixes the Wachovia bug. Also tightened up logic to do the stop() outside the if as above, and got rid of a silly timer delay computation that always resulted in 0. * khtml/khtmlpart_p.h: Added a new value to the RedirectionScheduled enum for scheduleLocationChange and also renamed one of the existing values. * khtml/html/htmltokenizer.cpp: (HTMLTokenizer::write): Changed to use isScheduledLocationChangePending instead of isImmediateRedirectPending, because we do want to continue tokenizing if it's actually a redirect. * khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::putValue): Changed to call the new scheduleLocationChange instead of calling scheduleRedirection with delay of 0. * khtml/ecma/kjs_window.cpp: (Window::put): Ditto. (WindowFunc::tryCall): Ditto. (Location::put): Ditto. (LocationFunc::tryCall): Ditto. * kwq/KWQKHTMLPart.h: Added canGoBackOrForward. * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canGoBackOrForward): Added. Calls across bridge to do the real work. * kwq/WebCoreBridge.h: Added canGoBackOrForward. === WebCore-125.8.9 === 2004-09-20 Vicki Murley - rolled in the fix for 3801256 2004-09-03 Darin Adler Reviewed by Chris. - fixed filename with non-ASCII name for should be sent in the page's encoding * khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData): Encode filename using the codec rather than doing the &# dance. It turns out that Mozilla only does the &# thing under certain circumstances that are not important. Always encoding the filename is almost certainly better behavior, and will fix many serious problems for Japanese and Korean users and websites. 2004-09-14 Vicki Murley - roll the fix for 3710123 in 2004-09-13 Darin Adler Reviewed by Maciej. - fixed Loading iframe that replaces content in the parent document crashes Safari (Oracle Portal) This is a more complete fix, but it requires the previous attempt at a fix for this same bug below, because this is only the "don't destroy the KHTMLPart" portion; other fixes are still needed to survive shutdown of the part. * khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::interpreter): Call the new keepAlive method. This is called whenever we're about to use an interpreter to run some JavaScript, and it's JavaScript that might destroy the part, hence the interpreter. * khtml/khtml_part.h: Added keepAlive() and slotEndLifeSupport() member functions. * khtml/khtmlpart_p.h: Added m_lifeSupportTimer. * khtml/khtml_part.cpp: (KHTMLPart::init): Connects m_lifeSupportTimer to slotEndLifeSupport. (KHTMLPart::write): Removed old attempt to work around this issue. (KHTMLPart::end): Ditto. (KHTMLPart::keepAlive): Added. References the part, then sets up a one-shot timer. (KHTMLPart::slotEndLifeSupport): Added. Stops the timer and then removes the reference from the part, possibly destroying it. * kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Added the new slot to the list of slots. (KWQSlot::call): Ditto. 2004-09-14 Vicki Murley - roll the fix for back in === WebCore-125.8.8 === 2004-09-13 Vicki Murley - roll the fix for off the branch, since we won't be including this in SUPanNavy 2004-09-13 Vicki Murley - fix merge errors from * khtml/html/htmltokenizer.cpp: (HTMLTokenizer::write): * khtml/khtml_part.cpp: (KHTMLPart::isImmediateRedirectPending): 2004-09-10 Vicki Murley - merge these changes for SUPanNavy, 2004-08-13 Maciej Stachowiak Reviewed by Darin. - fixed Pop up windows not showing up within SAP's BW Module (changing location.href on new window created by window.open) (actually the previous fix for this bug was mostly correct, but this additional change is needed to avoid the regression in REGRESSION: website rejects Safari 125.9 as "need to upgrade to IE 6", but didn't reject 125.8 So if merging for a software update, make sure to include both this and the previous fix. * khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::write): When there is an immediate reidrect pending, make sure to stop tokenizing, because we need to make sure no further script tags are processed beyond the one that triggered the redirect. * khtml/khtml_part.cpp: (KHTMLPart::isImmediateRedirectPending): New method to allow checking if a redirect is pending. * khtml/khtml_part.h: 2004-06-18 John Sullivan Reviewed by Darin - fixed Pop up windows not showing up within SAP's BW Module (changing location.href on new window created by window.open) * khtml/khtml_part.cpp: (KHTMLPart::scheduleRedirection): allow new redirect to win if delay <= current delay, not just < 2004-09-10 Vicki Murley - code changes by Darin, reviewed by Vicki Fix build breakage on the branch caused by bad merging for controls on page at http://help.sap.com don't work properly (clone for SUPanNavy) * khtml/ecma/kjs_dom.lut.h: (KJS::): * khtml/ecma/kjs_window.cpp: (Window::Window): (BarInfo::BarInfo): 2004-09-08 Vicki Murley - check in regenerated file khtml/ecma/kjs_window.lut.h, for 3772916 * khtml/ecma/kjs_window.lut.h: (KJS::): 2004-09-08 Vicki Murley - merge this fix from HEAD for SUPanNavy, 2004-08-10 Darin Adler Reviewed by Trey. - fixed Loading iframe that replaces content in the parent document crashes Safari I fixed three problems: 1) script interpreter destroyed while it was interpreting scripts, caused random havoc 2) code trying to get to view after view was detached from part, caused nil-deref 3) signals sent to parent after child was no longer in the parent's frames list, caused nil-deref Now the test page works fine. Hope the real sites do too. * khtml/khtml_part.h: Add connectChild and disconnectChild helper functions (private). * khtml/khtml_part.cpp: (KHTMLPart::clear): Call disconnectChild on each frame as we detach it (see below). (KHTMLPart::end): Ref the part at the start, and deref the part at the end, of this function. Otherwise, we can end up destroying the part, and hence the interpreter, inside a script that the interpreter itself is running. (KHTMLPart::slotFinishedParsing): Add another check for a nil m_view, after the call to checkCompleted. (KHTMLPart::checkCompleted): Remove bogus if statement with empty body. (KHTMLPart::processObjectRequest): Call disconnectChild to disconnect the child <-> parent signals of the old child that the new one is replacing, and connectChild to connect the signals (nicer factoring). (KHTMLPart::slotChildCompleted): Fixed up a confusing boolean if/expression to be simpler. Not related to the bug fix, but an earlier version of the fix had changes in this function. (KHTMLPart::connectChild): Added. Connects the appropriate signals for a child frame. (KHTMLPart::disconnectChild): Added. Disconnects the same signals that connectChild connects. * kwq/KWQKHTMLPart.mm: (KHTMLPart::frameDetached): Added a call to disconnectChild before removing the child from the frames list. 2004-09-08 Vicki Murley - A few follow up changes necessary to really fix the colgroup crash, . I've included the original ChangeLog comments below. I did not merge the changes in render_block.cpp to eliminate redundant setPos -500000 calls, since those weren't necessary for this fix. * khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): * khtml/rendering/render_block.cpp: (khtml::RenderBlock::addChildToFlow): 2004-09-01 David Hyatt Fix for 3769409, a regression from 10.3.4 to 10.3.5 involving s in malformed HTML. Reviewed by mjs * khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): 2004-09-01 David Hyatt Fix for the crasher. Make sure adding to an anonymous box just returns immediately. Also eliminate all the redundant setPos -500000 calls, since we don't need those at all. Reviewed by john * khtml/rendering/render_block.cpp: (khtml::RenderBlock::addChildToFlow): 2004-09-08 Vicki Murley - merge this fix from HEAD for SUPanNavy, 2004-08-26 David Hyatt Fix for 3777172, crash from nested colgroup. Don't allow nested table sections or col groups. Reviewed by darin * khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): 2004-09-07 Vicki Murley - merge this fix from HEAD for SUPanNavy, 2004-08-25 Kevin Decker Reviewed by John and Maciej. - Fixes SAP bug Personalize link at the top gives an error in the pop-up window. * khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Passes a referrer to KHTMLPart::begin() 2004-09-07 Vicki Murley - merge this change from HEAD for SUPanNavy, 2004-08-12 Maciej Stachowiak Reviewed by Richard. URLs with backslashes instead of slashes work on WinIE; should work on Safari (SAP) tag containing backslash is breaking images with absolute URLs * kwq/KWQKURL.mm: (substituteBackslashes): Helper method (KURL::KURL): If the URL contains any backslashes, substitute all that appear before the query or fragment. 2004-09-07 Vicki Murley - merge this fix from HEAD for SUPanNavy, 2004-07-28 Maciej Stachowiak Reviewed by Trey. controls on page at http://help.sap.com don't work properly To fix this I implemented the various JavaScript BarInfo properties in JavaScript. * khtml/ecma/kjs_window.cpp: (Window::Window): (Window::locationbar): (Window::menubar): (Window::personalbar): (Window::statusbar): (Window::toolbar): (Window::scrollbars): (Window::mark): (Window::get): (SelectionFunc::tryCall): (BarInfo::BarInfo): (BarInfo::~BarInfo): (BarInfo::get): (BarInfo::put): * khtml/ecma/kjs_window.h: (KJS::Window::): (KJS::BarInfo::): (KJS::BarInfo::part): (KJS::BarInfo::classInfo): * khtml/ecma/kjs_window.lut.h: (KJS::): * kwq/KWQKHTMLPart.h: * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::locationbarVisible): (KWQKHTMLPart::menubarVisible): (KWQKHTMLPart::personalbarVisible): (KWQKHTMLPart::scrollbarsVisible): (KWQKHTMLPart::statusbarVisible): (KWQKHTMLPart::toolbarVisible): === WebCore-125.8.7 === versioning for Security Update, SUPanXpress. SUPanXpress needs the fix for 3752542 too. === WebCore-125.8.6 === 2004-08-05 Vicki Murley - merge this fix from HEAD for SUPanMoccasin 2004-08-05 David Hyatt Fix for 3752542, stack overflow that crashes Safari at www.dr.dk. This bug is a regression caused by a fix that attempted to repair behavior to make it behave like Panther. This fix was incorrect, and in addition even our behavior on Panther was incorrect. The patch that fixes this bug also makes handling work when s are contained inside a , a , a , or various table section tags (, , ). The is pulled out and inserted just before the relevant ancestor table section. This behavior matches other browsers. Reviewed by mjs * khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): === WebCore-125.8.5 === new versioning for the SUPanXpress, WebCore-125.8.5. The change for 3534851 has to be backed out of the Security Update too. === WebCore-125.8.4 === versioning for SUPanMoccasin, WebCore-125.8.4 2004-08-05 Vicki Murley - roll out this chang for SUPanMoccasin, since it causes 3751025 2004-06-18 John Sullivan Reviewed by Darin - fixed Pop up windows not showing up within SAP's BW Module (changing location.href on new window created by window.open) * khtml/khtml_part.cpp: (KHTMLPart::scheduleRedirection): allow new redirect to win if delay <= current delay, not just < === WebCore-125.8.3 === versioning for SUPanXpress, WebCore-125.8.3 === WebCore-125.8.2 === versioning for SUPanMoccasin, WebCore-125.8.2 2004-07-29 Maciej Stachowiak Rolled in the change below from HEAD to fix this SU bug: *SUPanMoccasin* Seed: WebKit: Table's caption broken 2004-07-29 Maciej Stachowiak Reviewed by Darin. Seed: WebKit: Table's caption broken * khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): When a caption appears in an illegal place in a table, pop blocks until we hit a place where it's allowed. === WebCore-125.8.1 === 2004-07-23 Vicki Murley - roll this change back to the branch for the Security Update 2004-07-09 Chris Blumenberg Allowed my change for 3715785 to compile on Jaguar. Reviewed by kocienda. * kwq/WebCoreBridge.h: * kwq/WebCoreBridge.mm: (-[WebCoreBridge domain]): new, allows access to the domain without using the DOM API which doesn't exist on Jaguar === WebCore-125.8 === 2004-07-17 Vicki Murley Roll this Security Update change out for the next SUPanMoccasin submission. Security Update changes can't be included in Software Updates. 2004-07-09 Chris Blumenberg Allowed my change for 3715785 to compile on Jaguar. Reviewed by kocienda. * kwq/WebCoreBridge.h: * kwq/WebCoreBridge.mm: (-[WebCoreBridge domain]): new, allows access to the domain without using the DOM API which doesn't exist on Jaguar 2004-07-16 Adele Amchan Reviewed by vicki. - merge these changes from HEAD for SUPanMoccasin, 3730021 2004-07-06 Ken Kocienda Reviewed by me * khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::addChild): Added a better comment in the code I just checked in a few minutes ago. 2004-07-06 Ken Kocienda Reviewed by Hyatt Fix for this bug: assertion failure in AppendNodeCommandImpl::doApply due to non-0 exception code trying to insert a DIV markup string The solution was to revert to the code that was rolled out, and removing the child checks from NodeImpl::checkAddChild. However, this time, I added code very similar to this check into the code that runs while HTML is being parsed to build up tables. This code relies on child-add failure to ensure the proper construction of well-formed tables (as gross as that sounds), so the check needs to be retained there. No other code seems to be so affected. Layout tests are unchanged by this patch. * khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::addChild): * khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkAddChild): 2004-07-16 Adele Amchan Reviewed by vicki. - merge this change from HEAD for SUPanMoccasin, 3730017 2004-07-14 David Hyatt Fix for 3595073, setting innerHTML on a should work. Reviewed by rjw * khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment): === WebCore-125.7.1 === 2004-07-09 Vicki Murley - merge this fix from HEAD so that July Security Update will compile on Jaguar 2004-07-09 Chris Blumenberg Allowed my change for 3715785 to compile on Jaguar. Reviewed by kocienda. * kwq/WebCoreBridge.h: * kwq/WebCoreBridge.mm: (-[WebCoreBridge domain]): new, allows access to the domain without using the DOM API which doesn't exist on Jaguar === WebCore-125.7 === 2004-06-24 Vicki Murley - fix a build error that cropped up from the merge for the radio button fix, 3673762 * khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::parseAttribute): (HTMLInputElementImpl::reset): 2004-06-24 Vicki Murley - merge this change from HEAD for SUPanMoccasin, 3704509 2004-06-02 David Hyatt Fix for 3673931, negative margins on objects that dodge floats not handled correctly. Reviewed by darin * khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren): 2004-06-24 Vicki Murley - merge this change from HEAD for SUPanMoccasin, 3703230 2004-06-18 John Sullivan Reviewed by Darin - fixed Pop up windows not showing up within SAP's BW Module (changing location.href on new window created by window.open) * khtml/khtml_part.cpp: (KHTMLPart::scheduleRedirection): allow new redirect to win if delay <= current delay, not just < 2004-06-24 Vicki Murley - merge this change from HEAD for SUPanMoccasin, 3673762 2004-05-20 Darin Adler Reviewed by Maciej. - fixed : (multiple radio buttons checked when arriving at sites (poll at www.1170kfaq.com, many others)) * khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::parseHTMLAttribute): Use setChecked to set the default value if we are still in "use default checked" mode. That way, other radio buttons will be unchecked properly and the proper changed methods will be dispatched. (HTMLInputElementImpl::reset): Ditto. * khtml/html/html_formimpl.h: (DOM::HTMLInputElementImpl::checked): Changed to just return m_checked. The m_useDefaultChecked flag is now only really looked at when you parse a checked attribute; that's because m_checked and m_defaultChecked are kept equal as long as m_useDefaultChecked is true. === WebCore-125.6.8 === 2004-05-20 Maciej Stachowiak Even more Epiphhany changes. 2004-05-19 David Hyatt Implement support for notification posting to accessibility clients for layouts and loads. * khtml/khtmlview.cpp: (KHTMLView::layout): khtml/xml/dom_docimpl.cpp: (DocumentImpl::close): * kwq/KWQAccObjectCache.h: (KWQAccObjectCache::enableAccessibility): (KWQAccObjectCache::accessibilityEnabled): * kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::accObject): (KWQAccObjectCache::setAccObject): (KWQAccObjectCache::removeAccObject): (KWQAccObjectCache::detach): (KWQAccObjectCache::childrenChanged): (KWQAccObjectCache::postNotification): * kwq/WebCoreBridge.mm: (-[WebCoreBridge accessibilityTree]): 2004-05-19 Maciej Stachowiak Merged more Epiphany changes. 2004-05-18 David Hyatt Add two new attributes for accessibility that can be polled by the screen reader. AXLayoutCount indicates the number of layouts that have occurred, and AXLoaded indicates whether or not a page has finished loading. * khtml/khtmlview.cpp: (KHTMLViewPrivate::reset): (KHTMLView::layoutCount): (KHTMLView::layout): * khtml/khtmlview.h: * kwq/KWQAccObject.mm: (-[KWQAccObject roleDescription]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]): 2004-05-18 David Hyatt Fix crash when retrieving the AXHelp text. * kwq/KWQAccObject.mm: (-[KWQAccObject helpText]): === WebCore-125.6.7 === 2004-05-16 Maciej Stachowiak More build breakage in last change, needed to merge this unrelated change from HEAD. * khtml/rendering/render_list.h: (khtml::RenderListMarker::text): === WebCore-125.6.6 === 2004-05-14 Maciej Stachowiak Fix build bustage in last change, merge did not work in older tree. * khtml/rendering/render_image.cpp: (RenderImage::imageMap): === WebCore-125.6.5 === 2004-05-14 Maciej Stachowiak Merge Dave's changes for Epiphany. 2004-04-29 David Hyatt Expose summary on tables. Reviewed by darin * kwq/KWQAccObject.mm: (-[KWQAccObject helpText]): 2004-04-29 David Hyatt Implement image maps for accessibility. Reviewed by darin * khtml/html/html_imageimpl.cpp: (HTMLAreaElementImpl::getRect): * khtml/html/html_imageimpl.h: * khtml/rendering/render_image.cpp: (RenderImage::imageMap): (RenderImage::nodeAtPoint): * khtml/rendering/render_image.h: * kwq/KWQAccObject.h: * kwq/KWQAccObject.mm: (-[KWQAccObject initWithRenderer:]): (-[KWQAccObject anchorElement]): (-[KWQAccObject parentObject]): (-[KWQAccObject parentObjectUnignored]): (-[KWQAccObject addChildrenToArray:]): (-[KWQAccObject role]): (-[KWQAccObject helpText]): (-[KWQAccObject value]): (-[KWQAccObject title]): (-[KWQAccObject position]): (-[KWQAccObject size]): (-[KWQAccObject accessibilityIsIgnored]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]): * kwq/KWQRegion.mm: (QRegion::boundingRect): 2004-04-29 David Hyatt 1. Change the role of links from AXButton to AXLink. 2. Add support for list markers using a new role, AXListMarker. Reviewed by kocienda * khtml/rendering/render_list.h: (khtml::RenderListMarker::text): * kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject value]): (-[KWQAccObject accessibilityIsIgnored]): === WebCore-125.6.4 === 2004-04-27 Vicki Murley - merge fix for : innerText problem makes FedEx tracking page (and others) so slow it's effectively a hang (clone for SU) from HEAD 2004-04-25 Maciej Stachowiak Reviewed by Darin. : Fedex tracking page so slow it seems like a hang (site change?) : "ATI Developer site so slow it seems like a hang" : "Reproducible hang in JavaScript at www.tfl.gov.uk" : "Safari was consuming > 100% CPU on dual-G5 Mac, sample shows JavaScript" : "www.whatis.com search for "pivot table" leads to JavaScript hang" * khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getValueProperty): The "text" property for anchors should be innerText, not innerHTML. * khtml/html/html_elementimpl.cpp: (HTMLElementImpl::innerText): Make sure not to include all the text after an element if it has no children. === WebCore-125.6.3 === 2004-04-20 Vicki Murley - fixed : (REGRESSION (10.3.3-7H40): some tables rendering incorrectly) by merging more of the zeldman change (3609695) and fixing HRs * khtml/css/html4.css: margins on HRs should be smaller, to match other browsers * khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren): * khtml/rendering/render_table.cpp: (RenderTableCell::paint): === WebCore-125~6~2 === 2004-04-16 Vicki Murley - buildit complained about missing CFBundleName. Add InfoPlist.strings back to the build, with only a CFBundleName (no version or copyright string) * English.lproj/InfoPlist.strings: Added. * WebCore.pbproj/project.pbxproj: 2004-04-16 Vicki Murley - roll out the change to WebCoreViewFactory.h. This isn't a part of the onscroll follow-up for 3612968 * kwq/WebCoreViewFactory.h: 2004-04-16 Vicki Murley Reviewed by kocienda. Make this change on the branch for SUPanLavender, at Amy Rapport's request 2004-03-03 Darin Adler Reviewed by Vicki. * English.lproj/InfoPlist.strings: Removed. No need to localize the version and copyright string, and that's all that was in here. * WebCore.pbproj/project.pbxproj: Removed InfoPlist.strings from build. === WebCore-125.6 === 2004-04-16 Vicki Murley - follow-up fix for 3612968 (clone of 3487207). Implement onscroll at the document level. 2004-03-25 David Hyatt Implement the rest of the search field. Make it work with form submission. Implement onscroll at the document level. Reviewed by darin * kwq/KWQKHTMLPart.h: * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendScrollEvent): * kwq/WebCoreBridge.h: * kwq/WebCoreBridge.mm: (-[WebCoreBridge sendScrollEvent]): * kwq/WebCoreViewFactory.h: 2004-04-15 Vicki Murley - merge the rest of the fix for the zeldman bug (3609695) from HEAD * khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::lowestPosition): (khtml::RenderBlock::rightmostPosition): (khtml::RenderBlock::leftmostPosition): 2004-04-15 Vicki Murley Fix mismatched_CFBundleShortVersionStrings verification failure * English.lproj/InfoPlist.strings: 2004-04-14 Vicki Murley - fix build errors, update a few more files for 3612968 * khtml/rendering/render_table.cpp: remove a stray curly bracket (from merging) that was breaking the build * kwq/KWQKURL.mm: (KURL::KURL): remove a wayward break statement that was breaking the build * khtml/misc/htmlattrs.c: (hash_attr): (findAttr): * khtml/misc/htmlattrs.h: * kwq/KWQValueList.h: (QValueList::insert): (QValueList::fromLast): * kwq/KWQValueListImpl.h: * kwq/KWQValueListImpl.mm: (KWQValueListImpl::clear): (KWQValueListImpl::insert): (KWQValueListImpl::fromLast): 2004-04-14 Vicki Murley - merge fix for 3612968 from HEAD 2004-03-23 David Hyatt Fix for 3487207, implement onscroll DOM event for elements with overflow:auto/scroll/hidden. This does not handle firing onscroll on the window when the document scrolls, nor does it handle firing onscroll on textareas. These are two separate bugs. This patch finishes stubbing out the onscroll event and adds support for it to the DOM. It also supports the firing of the event when overflow blocks scroll. Reviewed by darin * khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): (DOMNode::putValue): * khtml/ecma/kjs_dom.h: (KJS::DOMNode::): * khtml/ecma/kjs_window.cpp: (Window::get): (Window::put): * khtml/ecma/kjs_window.h: (KJS::Window::): * khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute): * khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute): * khtml/misc/htmlattrs.in: * khtml/rendering/render_layer.cpp: (RenderLayer::scrollToOffset): 2004-04-14 Vicki Murley - merge fix for 3609690 from HEAD 2004-02-11 David Hyatt Fix for 3556037, regression where display:block generated content didn't work. Reviewed by kocienda * khtml/rendering/render_block.cpp: (khtml::RenderBlock::setStyle): (khtml::RenderBlock::addChildToFlow): (khtml::RenderBlock::removeChild): (khtml::RenderBlock::renderName): * khtml/rendering/render_container.cpp: (RenderContainer::insertChildNode): (RenderContainer::removeLeftoverAnonymousBoxes): * khtml/rendering/render_inline.cpp: (RenderInline::splitFlow): (RenderInline::renderName): * khtml/rendering/render_list.cpp: (RenderListItem::updateMarkerLocation): * khtml/rendering/render_object.h: (khtml::RenderObject::isAnonymousBlock): 2004-04-14 Vicki Murley - merge fix for 3609686 from HEAD 2004-02-23 David Hyatt Fix for 3549772, hangs on border collapsing. Reviewed by darin * khtml/rendering/render_object.cpp: (RenderObject::collectBorders): * khtml/rendering/render_object.h: * khtml/rendering/render_table.cpp: (RenderTable::paint): (compareBorders): (RenderTableCell::paint): (addBorderStyle): (RenderTableCell::collectBorders): * khtml/rendering/render_table.h: 2004-04-13 Vicki Murley - merged WebCore part of the fix for 3609723 from HEAD 2004-03-23 David Hyatt Fix for 3513627, HTML mail prints upside down occasionally. Change printing so that it never resizes the WebHTMLView when formatting for printing. When computing page rects, instead of using the view's bounds, use the root layer's width instead. Reviewed by darin * khtml/khtmlview.cpp: (KHTMLView::layout): * kwq/WebCoreBridge.h: * kwq/WebCoreBridge.mm: (-[WebCoreBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]): 2004-04-13 Vicki Murley - merge fix for 3609695 from HEAD 2004-02-11 David Hyatt Fix for 3556702, margin collapsing gets disabled when images spill out of the containing block. Reviewed by kocienda * khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren): 2004-04-13 Vicki Murley - merged fix for 3609640 from HEAD. To fix this properly, we need code changes from both 3552346 and 3571356. 2004-02-27 Maciej Stachowiak Reviewed by Dave. - fixed : REGRESSION: Crash in isPointInsideSelection clicking on link in Apple web directory frame * khtml/khtml_part.cpp: (KHTMLPart::isPointInsideSelection): Don't crash if innerNode is NULL, as this can happen mousing over a frame that's in the process of loading and currently empty. Since such a frame obviously can't be inside the selection, this seems like a good enough fix. 2004-02-20 Maciej Stachowiak Reviewed by Darin. : REGRESSION 100-125: nil-dereference in KHTMLPart::isPointInsideSelection (progz.ru, many other sites) * khtml/rendering/render_layer.cpp: (RenderLayer::nodeAtPointForLayer): To cover the case of positioned generated content, make sure to find an element if we don't have one yet when we get to the layer level. 2004-04-13 Vicki Murley - merge fix for 3609604 from HEAD 2004-02-17 Maciej Stachowiak Reviewed by Darin. : REGRESSION (100-114): Return doesn't work in Japanese input method for some HomePage fields * kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyDown:]): Don't send events through DOM when there is marked text. (-[KWQTextAreaTextView keyUp:]): Ditto. * kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]): Ditto. (-[KWQSecureTextField textView:shouldHandleEvent:]): Ditto. * khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::defaultEventHandler): No need to check for marked text on "return" any more, because we won't send key events through the DOM at all when there is marked text. * kwq/KWQLineEdit.h: * kwq/KWQLineEdit.mm: Removed haveMarkedText method, no longer used by anything. 2004-04-13 Vicki Murley - merge fix for 3612956 from HEAD 2004-03-30 Darin Adler Reviewed by Dave. - fixed : REGRESSION: onfocus handler not working at weather.com * khtml/ecma/kjs_binding.cpp: (UString::string): Turn a null UString into a null DOMString, but a non-null empty UString into a non-null empty DOMString. (UString::qstring): Ditto, for QString. (Identifier::string): Ditto, for Identifier. (Identifier::qstring): Ditto. 2004-04-13 Vicki Murley - merge WebCore part of fix for 3612925 from HEAD 2004-03-24 Darin Adler Reviewed by John. - fixed : REGRESSION: When the subject of mailto is 2 byte Safari failed to send mail address and subject to Mail.app * kwq/KWQKURL.mm: (KURL::findHostnamesInMailToURL): Update to handle hostnames that end just before a '?' since a '?' ends the entire part of the URL that can contain hostnames. Also change the logic so that the '?' will successfully end the search. 2004-04-13 Vicki Murley - merge fix for 3609635 from HEAD 2004-02-15 Darin Adler Reviewed by Dave. - fixed 3548533: crash in XMLHttpRequest::slotData using Orkut's rating system * khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::~XMLHttpRequest): Delete the QObject side, which has a side effect of disconnecting the signals which seem to be firing after the request is gone. There may be another way of addressing the crash by correcting some other problem with killing the job, but this demonstrably works and fixes a storage leak. 2004-04-13 Vicki Murley - merge fix for 3600904 from HEAD 2004-03-08 Darin Adler Reviewed by Maciej. - fixed : REGRESSION (100-125): cannot upload file if path contains non-ASCII characters * kwq/KWQKURL.mm: Remove Colon constant so we can fit in 8 bits again. (KURL::KURL): Rewrite so we don't need isSchemeCharOrColon. === WebCore-125.5 === 2004-03-11 Maciej Stachowiak Merge yet another fix for Epiphany. 2004-03-10 David Hyatt Fix for 3584646, AxWebArea should encompass all children (its AxSize should). Reviewed by mjs * khtml/rendering/render_canvas.cpp: (RenderCanvas::absoluteRects): * khtml/rendering/render_canvas.h: === WebCore-125.4 === 2004-03-10 Maciej Stachowiak Fix branch so it builds. * khtml/ecma/kjs_html.h: 2004-03-09 Maciej Stachowiak Merged the following changes from HEAD for Epiphany: 2004-03-09 David Hyatt Make the AXLinkUIElements attribute always return an array (never return nil). * kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeValue:]): 2004-03-09 David Hyatt (1) Change root element in a document to have a role of AXWebArea. (2) Add support for AXURL to links and children of links. (3) Add support for AXLinkUIElements to the AXWebArea Reviewed by john * khtml/dom/html_misc.h: * kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]): === WebCore-125.3 === 2004-03-04 Maciej Stachowiak Bump versions. * English.lproj/InfoPlist.strings: * kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityIsIgnored]): Fix to build on branch. 2004-03-03 Maciej Stachowiak Merge the following fix for Epiphany: 2004-03-03 David Hyatt Speed up access to the children arrays of accessibility objects by caching mutable arrays of children and nulling them out only when the children change. Reviewed by john * khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode): * kwq/KWQAccObject.h: * kwq/KWQAccObject.mm: (-[KWQAccObject detach]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject childrenChanged]): (-[KWQAccObject clearChildren]): * kwq/KWQAccObjectCache.h: * kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::childrenChanged): 2004-03-03 Maciej Stachowiak Actually merge the two changes below, they didn't actually get in last time. * kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject accessibilityIsIgnored]): === WebCore-125.1 === 2004-01-30 Maciej Stachowiak Merge the following changes from TOT for the Epiphany submission. 2004-01-28 David Hyatt Fix for 3537694, make blocks for parents of inline children be axobjects. Reviewed by kocienda * kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject accessibilityIsIgnored]): 2004-01-30 David Hyatt Fix for 3522497,
s should not get AXObjects created. Reviewed by mjs * kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityIsIgnored]): === Safari-125 === 2004-01-19 Maciej Stachowiak Reviewed by John, Ken, Dave. : Safari allows upload of arbitrary local files w/o user's knowledge or permission * khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::value): Don't fall back to the value attribute for file inputs, since that way malicious HTML could force the user to upload files unexpectedly. 2004-01-18 David Hyatt Fix for 3532569, bugzilla patch viewer doesn't work. My previous fix for 3531983 caused moves to happen when they should not have, due to childX and childY not being implemented at all on KWQScrollView. Reviewed by darin * kwq/KWQScrollView.mm: (QScrollView::childX): (QScrollView::childY): === Safari-124 === 2004-01-16 David Hyatt Fix for 3531983, fixed positioning not working for widgets. Make sure to move widgets at paint time if necessary. Reviewed by darin * khtml/rendering/render_replaced.cpp: (RenderWidget::paintObject): 2004-01-15 David Hyatt Fix for 3530734, many java applets don't show up. Go ahead and just use the width/height from the style system as the initial size when the width/height are fixed. Reviewed by rjw * khtml/rendering/render_applet.cpp: (RenderApplet::createWidgetIfNecessary): 2004-01-15 Richard Williamson Fixed 3529426. Exclude pages that contain Java applets from the page cache. The means applets get the normal stop/destroy messages that they expect when a user leaves a page. Reviewed by John. * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canCachePage): 2004-01-15 Vicki Murley Reviewed by Darin. * WebCore.pbproj/project.pbxproj: Update copyright date to 2004. 2004-01-15 Darin Adler Reviewed by Ken. - fixed 3529943: REGRESSION (119-120): nil-deref in KHTMLPart::javaEnabled when hitting back button * khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance): Add missing nil check that the other call to javaEnabled has. === Safari-122 === 2004-01-14 David Hyatt Fix for 3527819, marquee makes page layout too wide. Make sure marquees have a minimum width of 0. Reviewed by john * khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcMinMaxWidth): (khtml::RenderBlock::calcInlineMinMaxWidth): 2004-01-13 David Hyatt Fix for 3527707, crash on w3c css page. Make sure height isn't allowed to be negative when computing positioned elements' heights. Also bulletproof the crash in case there are other negative height code paths. Reviewed by john * khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::getAbsoluteRepaintRectIncludingFloats): * khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteVertical): 2004-01-13 Maciej Stachowiak Reviewed by Darin. : REGRESSION (119-120): Peoplesoft menus do not work * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollToAnchor): Right before calling checkCompleted(), set m_bComplete to false, so it can get set right back to true if we're actually done loading and fire all the right signals. 2004-01-13 David Hyatt Fix for 3526710, applets need to have the correct initial size after a layout has been done, since our Java applets can't yet resize. Reviewed by john * khtml/rendering/render_applet.cpp: (RenderApplet::createWidgetIfNecessary): (RenderApplet::layout): (RenderEmptyApplet::layout): === Safari-121 === 2004-01-11 Darin Adler - fixed Dave's check-in so it compiles; I assume he forgot to land one source file * khtml/khtmlview.h: Add RenderPart to the friends of KHTMLView. 2004-01-11 David Hyatt Fix for frame repainting bugs (3510669, 3515442). This is a narrower fix than the previous attempt. Reviewed by darin * khtml/rendering/render_frames.cpp: (RenderPart::updateWidgetPositions): * khtml/rendering/render_frames.h: * khtml/rendering/render_replaced.cpp: (RenderWidget::updateWidgetPositions): 2004-01-10 Darin Adler Reviewed by John. - fixed 3525468: REGRESSION (114-115): HOMEPAGE: after hitting textarea limit, backspace key is ignored * kwq/KWQEvent.mm: (keyIdentifierForKeyEvent): Treat 7F as 08; matches other browsers. (QKeyEvent::QKeyEvent): Ditto. 2004-01-09 David Hyatt Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's use of a separate needsLayout boolean. Reviewed by darin * kwq/WebCoreBridge.h: * kwq/WebCoreBridge.mm: (-[WebCoreBridge setNeedsLayout]): 2004-01-08 David Hyatt Fix for 3524118, floats don't repaint when moved. Reviewed by darin * khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionNewFloats): 2004-01-08 David Hyatt Fix for 3519003, crash in mail because and don't allow the same children as
    and
      . Reviewed by darin * khtml/html/dtd.cpp: (DOM::checkChild): 2004-01-08 John Sullivan - fixed : REGRESSSION (119-120): Double click to select text in form broken Reviewed by Dave and Darin. * khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): Don't blur the focused node if that's the one you clicked on. 2004-01-07 Richard Williamson Fixed 3517550. Named array lookup of applet failed, i.e.: var appletobj = document.applets['myapplet'] Reviewed by Chris. * khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::getNamedItems): === Safari-120 === 2004-01-06 David Hyatt Possible fix for table bugs 3510005 and 3492945, repainting glitches that occurred when table cells moved. Fix for 33522497, empty AXElements appear in AXBrowser. Reviewed by darin * khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows): (RenderTableCell::setWidth): * khtml/rendering/render_table.h: * kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityIsIgnored]): 2004-01-06 John Sullivan - fixed : REGRESSION (118): button click does not take focus away from