=== WebCore-125.6.4 === 2004-04-27 Vicki Murley - merge fix for : innerText problem makes FedEx tracking page (and others) so slow it's effectively a hang (clone for SU) from HEAD 2004-04-25 Maciej Stachowiak Reviewed by Darin. : Fedex tracking page so slow it seems like a hang (site change?) : "ATI Developer site so slow it seems like a hang" : "Reproducible hang in JavaScript at www.tfl.gov.uk" : "Safari was consuming > 100% CPU on dual-G5 Mac, sample shows JavaScript" : "www.whatis.com search for "pivot table" leads to JavaScript hang" * khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getValueProperty): The "text" property for anchors should be innerText, not innerHTML. * khtml/html/html_elementimpl.cpp: (HTMLElementImpl::innerText): Make sure not to include all the text after an element if it has no children. === WebCore-125.6.3 === 2004-04-20 Vicki Murley - fixed : (REGRESSION (10.3.3-7H40): some tables rendering incorrectly) by merging more of the zeldman change (3609695) and fixing HRs * khtml/css/html4.css: margins on HRs should be smaller, to match other browsers * khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren): * khtml/rendering/render_table.cpp: (RenderTableCell::paint): === WebCore-125~6~2 === 2004-04-16 Vicki Murley - buildit complained about missing CFBundleName. Add InfoPlist.strings back to the build, with only a CFBundleName (no version or copyright string) * English.lproj/InfoPlist.strings: Added. * WebCore.pbproj/project.pbxproj: 2004-04-16 Vicki Murley - roll out the change to WebCoreViewFactory.h. This isn't a part of the onscroll follow-up for 3612968 * kwq/WebCoreViewFactory.h: 2004-04-16 Vicki Murley Reviewed by kocienda. Make this change on the branch for SUPanLavender, at Amy Rapport's request 2004-03-03 Darin Adler Reviewed by Vicki. * English.lproj/InfoPlist.strings: Removed. No need to localize the version and copyright string, and that's all that was in here. * WebCore.pbproj/project.pbxproj: Removed InfoPlist.strings from build. === WebCore-125.6 === 2004-04-16 Vicki Murley - follow-up fix for 3612968 (clone of 3487207). Implement onscroll at the document level. 2004-03-25 David Hyatt Implement the rest of the search field. Make it work with form submission. Implement onscroll at the document level. Reviewed by darin * kwq/KWQKHTMLPart.h: * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendScrollEvent): * kwq/WebCoreBridge.h: * kwq/WebCoreBridge.mm: (-[WebCoreBridge sendScrollEvent]): * kwq/WebCoreViewFactory.h: 2004-04-15 Vicki Murley - merge the rest of the fix for the zeldman bug (3609695) from HEAD * khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::lowestPosition): (khtml::RenderBlock::rightmostPosition): (khtml::RenderBlock::leftmostPosition): 2004-04-15 Vicki Murley Fix mismatched_CFBundleShortVersionStrings verification failure * English.lproj/InfoPlist.strings: 2004-04-14 Vicki Murley - fix build errors, update a few more files for 3612968 * khtml/rendering/render_table.cpp: remove a stray curly bracket (from merging) that was breaking the build * kwq/KWQKURL.mm: (KURL::KURL): remove a wayward break statement that was breaking the build * khtml/misc/htmlattrs.c: (hash_attr): (findAttr): * khtml/misc/htmlattrs.h: * kwq/KWQValueList.h: (QValueList::insert): (QValueList::fromLast): * kwq/KWQValueListImpl.h: * kwq/KWQValueListImpl.mm: (KWQValueListImpl::clear): (KWQValueListImpl::insert): (KWQValueListImpl::fromLast): 2004-04-14 Vicki Murley - merge fix for 3612968 from HEAD 2004-03-23 David Hyatt Fix for 3487207, implement onscroll DOM event for elements with overflow:auto/scroll/hidden. This does not handle firing onscroll on the window when the document scrolls, nor does it handle firing onscroll on textareas. These are two separate bugs. This patch finishes stubbing out the onscroll event and adds support for it to the DOM. It also supports the firing of the event when overflow blocks scroll. Reviewed by darin * khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): (DOMNode::putValue): * khtml/ecma/kjs_dom.h: (KJS::DOMNode::): * khtml/ecma/kjs_window.cpp: (Window::get): (Window::put): * khtml/ecma/kjs_window.h: (KJS::Window::): * khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute): * khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute): * khtml/misc/htmlattrs.in: * khtml/rendering/render_layer.cpp: (RenderLayer::scrollToOffset): 2004-04-14 Vicki Murley - merge fix for 3609690 from HEAD 2004-02-11 David Hyatt Fix for 3556037, regression where display:block generated content didn't work. Reviewed by kocienda * khtml/rendering/render_block.cpp: (khtml::RenderBlock::setStyle): (khtml::RenderBlock::addChildToFlow): (khtml::RenderBlock::removeChild): (khtml::RenderBlock::renderName): * khtml/rendering/render_container.cpp: (RenderContainer::insertChildNode): (RenderContainer::removeLeftoverAnonymousBoxes): * khtml/rendering/render_inline.cpp: (RenderInline::splitFlow): (RenderInline::renderName): * khtml/rendering/render_list.cpp: (RenderListItem::updateMarkerLocation): * khtml/rendering/render_object.h: (khtml::RenderObject::isAnonymousBlock): 2004-04-14 Vicki Murley - merge fix for 3609686 from HEAD 2004-02-23 David Hyatt Fix for 3549772, hangs on border collapsing. Reviewed by darin * khtml/rendering/render_object.cpp: (RenderObject::collectBorders): * khtml/rendering/render_object.h: * khtml/rendering/render_table.cpp: (RenderTable::paint): (compareBorders): (RenderTableCell::paint): (addBorderStyle): (RenderTableCell::collectBorders): * khtml/rendering/render_table.h: 2004-04-13 Vicki Murley - merged WebCore part of the fix for 3609723 from HEAD 2004-03-23 David Hyatt Fix for 3513627, HTML mail prints upside down occasionally. Change printing so that it never resizes the WebHTMLView when formatting for printing. When computing page rects, instead of using the view's bounds, use the root layer's width instead. Reviewed by darin * khtml/khtmlview.cpp: (KHTMLView::layout): * kwq/WebCoreBridge.h: * kwq/WebCoreBridge.mm: (-[WebCoreBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]): 2004-04-13 Vicki Murley - merge fix for 3609695 from HEAD 2004-02-11 David Hyatt Fix for 3556702, margin collapsing gets disabled when images spill out of the containing block. Reviewed by kocienda * khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren): 2004-04-13 Vicki Murley - merged fix for 3609640 from HEAD. To fix this properly, we need code changes from both 3552346 and 3571356. 2004-02-27 Maciej Stachowiak Reviewed by Dave. - fixed : REGRESSION: Crash in isPointInsideSelection clicking on link in Apple web directory frame * khtml/khtml_part.cpp: (KHTMLPart::isPointInsideSelection): Don't crash if innerNode is NULL, as this can happen mousing over a frame that's in the process of loading and currently empty. Since such a frame obviously can't be inside the selection, this seems like a good enough fix. 2004-02-20 Maciej Stachowiak Reviewed by Darin. : REGRESSION 100-125: nil-dereference in KHTMLPart::isPointInsideSelection (progz.ru, many other sites) * khtml/rendering/render_layer.cpp: (RenderLayer::nodeAtPointForLayer): To cover the case of positioned generated content, make sure to find an element if we don't have one yet when we get to the layer level. 2004-04-13 Vicki Murley - merge fix for 3609604 from HEAD 2004-02-17 Maciej Stachowiak Reviewed by Darin. : REGRESSION (100-114): Return doesn't work in Japanese input method for some HomePage fields * kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyDown:]): Don't send events through DOM when there is marked text. (-[KWQTextAreaTextView keyUp:]): Ditto. * kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]): Ditto. (-[KWQSecureTextField textView:shouldHandleEvent:]): Ditto. * khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::defaultEventHandler): No need to check for marked text on "return" any more, because we won't send key events through the DOM at all when there is marked text. * kwq/KWQLineEdit.h: * kwq/KWQLineEdit.mm: Removed haveMarkedText method, no longer used by anything. 2004-04-13 Vicki Murley - merge fix for 3612956 from HEAD 2004-03-30 Darin Adler Reviewed by Dave. - fixed : REGRESSION: onfocus handler not working at weather.com * khtml/ecma/kjs_binding.cpp: (UString::string): Turn a null UString into a null DOMString, but a non-null empty UString into a non-null empty DOMString. (UString::qstring): Ditto, for QString. (Identifier::string): Ditto, for Identifier. (Identifier::qstring): Ditto. 2004-04-13 Vicki Murley - merge WebCore part of fix for 3612925 from HEAD 2004-03-24 Darin Adler Reviewed by John. - fixed : REGRESSION: When the subject of mailto is 2 byte Safari failed to send mail address and subject to Mail.app * kwq/KWQKURL.mm: (KURL::findHostnamesInMailToURL): Update to handle hostnames that end just before a '?' since a '?' ends the entire part of the URL that can contain hostnames. Also change the logic so that the '?' will successfully end the search. 2004-04-13 Vicki Murley - merge fix for 3609635 from HEAD 2004-02-15 Darin Adler Reviewed by Dave. - fixed 3548533: crash in XMLHttpRequest::slotData using Orkut's rating system * khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::~XMLHttpRequest): Delete the QObject side, which has a side effect of disconnecting the signals which seem to be firing after the request is gone. There may be another way of addressing the crash by correcting some other problem with killing the job, but this demonstrably works and fixes a storage leak. 2004-04-13 Vicki Murley - merge fix for 3600904 from HEAD 2004-03-08 Darin Adler Reviewed by Maciej. - fixed : REGRESSION (100-125): cannot upload file if path contains non-ASCII characters * kwq/KWQKURL.mm: Remove Colon constant so we can fit in 8 bits again. (KURL::KURL): Rewrite so we don't need isSchemeCharOrColon. === WebCore-125.5 === 2004-03-11 Maciej Stachowiak Merge yet another fix for Epiphany. 2004-03-10 David Hyatt Fix for 3584646, AxWebArea should encompass all children (its AxSize should). Reviewed by mjs * khtml/rendering/render_canvas.cpp: (RenderCanvas::absoluteRects): * khtml/rendering/render_canvas.h: === WebCore-125.4 === 2004-03-10 Maciej Stachowiak Fix branch so it builds. * khtml/ecma/kjs_html.h: 2004-03-09 Maciej Stachowiak Merged the following changes from HEAD for Epiphany: 2004-03-09 David Hyatt Make the AXLinkUIElements attribute always return an array (never return nil). * kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeValue:]): 2004-03-09 David Hyatt (1) Change root element in a document to have a role of AXWebArea. (2) Add support for AXURL to links and children of links. (3) Add support for AXLinkUIElements to the AXWebArea Reviewed by john * khtml/dom/html_misc.h: * kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]): === WebCore-125.3 === 2004-03-04 Maciej Stachowiak Bump versions. * English.lproj/InfoPlist.strings: * kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityIsIgnored]): Fix to build on branch. 2004-03-03 Maciej Stachowiak Merge the following fix for Epiphany: 2004-03-03 David Hyatt Speed up access to the children arrays of accessibility objects by caching mutable arrays of children and nulling them out only when the children change. Reviewed by john * khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode): * kwq/KWQAccObject.h: * kwq/KWQAccObject.mm: (-[KWQAccObject detach]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject childrenChanged]): (-[KWQAccObject clearChildren]): * kwq/KWQAccObjectCache.h: * kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::childrenChanged): 2004-03-03 Maciej Stachowiak Actually merge the two changes below, they didn't actually get in last time. * kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject accessibilityIsIgnored]): === WebCore-125.1 === 2004-01-30 Maciej Stachowiak Merge the following changes from TOT for the Epiphany submission. 2004-01-28 David Hyatt Fix for 3537694, make blocks for parents of inline children be axobjects. Reviewed by kocienda * kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject accessibilityIsIgnored]): 2004-01-30 David Hyatt Fix for 3522497,
s should not get AXObjects created. Reviewed by mjs * kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityIsIgnored]): === Safari-125 === 2004-01-19 Maciej Stachowiak Reviewed by John, Ken, Dave. : Safari allows upload of arbitrary local files w/o user's knowledge or permission * khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::value): Don't fall back to the value attribute for file inputs, since that way malicious HTML could force the user to upload files unexpectedly. 2004-01-18 David Hyatt Fix for 3532569, bugzilla patch viewer doesn't work. My previous fix for 3531983 caused moves to happen when they should not have, due to childX and childY not being implemented at all on KWQScrollView. Reviewed by darin * kwq/KWQScrollView.mm: (QScrollView::childX): (QScrollView::childY): === Safari-124 === 2004-01-16 David Hyatt Fix for 3531983, fixed positioning not working for widgets. Make sure to move widgets at paint time if necessary. Reviewed by darin * khtml/rendering/render_replaced.cpp: (RenderWidget::paintObject): 2004-01-15 David Hyatt Fix for 3530734, many java applets don't show up. Go ahead and just use the width/height from the style system as the initial size when the width/height are fixed. Reviewed by rjw * khtml/rendering/render_applet.cpp: (RenderApplet::createWidgetIfNecessary): 2004-01-15 Richard Williamson Fixed 3529426. Exclude pages that contain Java applets from the page cache. The means applets get the normal stop/destroy messages that they expect when a user leaves a page. Reviewed by John. * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canCachePage): 2004-01-15 Vicki Murley Reviewed by Darin. * WebCore.pbproj/project.pbxproj: Update copyright date to 2004. 2004-01-15 Darin Adler Reviewed by Ken. - fixed 3529943: REGRESSION (119-120): nil-deref in KHTMLPart::javaEnabled when hitting back button * khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance): Add missing nil check that the other call to javaEnabled has. === Safari-122 === 2004-01-14 David Hyatt Fix for 3527819, marquee makes page layout too wide. Make sure marquees have a minimum width of 0. Reviewed by john * khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcMinMaxWidth): (khtml::RenderBlock::calcInlineMinMaxWidth): 2004-01-13 David Hyatt Fix for 3527707, crash on w3c css page. Make sure height isn't allowed to be negative when computing positioned elements' heights. Also bulletproof the crash in case there are other negative height code paths. Reviewed by john * khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::getAbsoluteRepaintRectIncludingFloats): * khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteVertical): 2004-01-13 Maciej Stachowiak Reviewed by Darin. : REGRESSION (119-120): Peoplesoft menus do not work * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollToAnchor): Right before calling checkCompleted(), set m_bComplete to false, so it can get set right back to true if we're actually done loading and fire all the right signals. 2004-01-13 David Hyatt Fix for 3526710, applets need to have the correct initial size after a layout has been done, since our Java applets can't yet resize. Reviewed by john * khtml/rendering/render_applet.cpp: (RenderApplet::createWidgetIfNecessary): (RenderApplet::layout): (RenderEmptyApplet::layout): === Safari-121 === 2004-01-11 Darin Adler - fixed Dave's check-in so it compiles; I assume he forgot to land one source file * khtml/khtmlview.h: Add RenderPart to the friends of KHTMLView. 2004-01-11 David Hyatt Fix for frame repainting bugs (3510669, 3515442). This is a narrower fix than the previous attempt. Reviewed by darin * khtml/rendering/render_frames.cpp: (RenderPart::updateWidgetPositions): * khtml/rendering/render_frames.h: * khtml/rendering/render_replaced.cpp: (RenderWidget::updateWidgetPositions): 2004-01-10 Darin Adler Reviewed by John. - fixed 3525468: REGRESSION (114-115): HOMEPAGE: after hitting textarea limit, backspace key is ignored * kwq/KWQEvent.mm: (keyIdentifierForKeyEvent): Treat 7F as 08; matches other browsers. (QKeyEvent::QKeyEvent): Ditto. 2004-01-09 David Hyatt Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's use of a separate needsLayout boolean. Reviewed by darin * kwq/WebCoreBridge.h: * kwq/WebCoreBridge.mm: (-[WebCoreBridge setNeedsLayout]): 2004-01-08 David Hyatt Fix for 3524118, floats don't repaint when moved. Reviewed by darin * khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionNewFloats): 2004-01-08 David Hyatt Fix for 3519003, crash in mail because and don't allow the same children as
    and
      . Reviewed by darin * khtml/html/dtd.cpp: (DOM::checkChild): 2004-01-08 John Sullivan - fixed : REGRESSSION (119-120): Double click to select text in form broken Reviewed by Dave and Darin. * khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): Don't blur the focused node if that's the one you clicked on. 2004-01-07 Richard Williamson Fixed 3517550. Named array lookup of applet failed, i.e.: var appletobj = document.applets['myapplet'] Reviewed by Chris. * khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::getNamedItems): === Safari-120 === 2004-01-06 David Hyatt Possible fix for table bugs 3510005 and 3492945, repainting glitches that occurred when table cells moved. Fix for 33522497, empty AXElements appear in AXBrowser. Reviewed by darin * khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows): (RenderTableCell::setWidth): * khtml/rendering/render_table.h: * kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityIsIgnored]): 2004-01-06 John Sullivan - fixed : REGRESSION (118): button click does not take focus away from