2010-05-30 Mark Rowe Merge r59912. 2010-05-20 Simon Fraser Build fix, no review. Fix the non-accelerated-compositing Windows build with some #if USE(ACCELERATED_COMPOSITING) loving. * WebView.cpp: * WebView.h: 2010-05-30 Mark Rowe Merge r59910. 2010-05-20 Simon Fraser Reviewed by Adam Roben. Avoid flushing CA layers when a layout is pending https://bugs.webkit.org/show_bug.cgi?id=39463 Avoid rendering the compositing layers to the screen if there's a layout pending, since the layer tree not in a state that should be presented to the user. This fixes flashes in some types of content that dynamically add and remove layers. Have the WebView implement WKCACFLayerRendererClient so that the WKCACFLayerRenderer can ask whether it's a good time to render. If the FrameView has a layout pending, say no. * WebView.h: * WebView.cpp: (WebView::setAcceleratedCompositing): (WebView::shouldRender): 2010-05-25 Mark Rowe Merge r60190. 2010-05-22 Jer Noble Reviewed by Adam Roben. Full screen doesn't work for video elements https://bugs.webkit.org/show_bug.cgi?id=39557 rdar://problem/8011813 Modified FullscreenVideoController to work with MediaPlayerPrivateFullscreenWindow. The FullscreenVideoController is now MediaPlayerPrivate agnostic.. * FullscreenVideoController.cpp: (FullscreenVideoController::LayoutClient::LayoutClient): New helper class which implements WKCACFLayerLayoutClient. (FullscreenVideoController::LayoutClient::layoutSublayersOfLayer): (FullscreenVideoController::FullscreenVideoController): (FullscreenVideoController::~FullscreenVideoController): (FullscreenVideoController::enterFullscreen): (FullscreenVideoController::exitFullscreen): (FullscreenVideoController::fullscreenClientWndProc): Handle WM_KEYDOWN. (FullscreenVideoController::createHUDWindow): (FullscreenVideoController::hudWndProc): Handle WM_KEYDOWN. (FullscreenVideoController::onChar): (FullscreenVideoController::onKeyDown): New function: handles the VK_ESCAPE case more reliably than WM_CHAR. * FullscreenVideoController.h: * WebView.h: (WebView::viewWindow): Added a simple viewWindow() accessor. 2010-05-25 Mark Rowe Merge r60150. 2010-05-25 Ada Chan Reviewed by Steve Falkenburg. https://bugs.webkit.org/show_bug.cgi?id=39651 Make m_closeWindowTimer a SuspendableTimer, so it is properly suspended when page loading is deferred. * WebView.cpp: (WebView::WebView): m_closeWindowTimer is now a pointer to a SuspendableTimer. (WindowCloseTimer::create): (WindowCloseTimer::WindowCloseTimer): (WindowCloseTimer::contextDestroyed): Make sure we delete the WindowCloseTimer in the end. (WindowCloseTimer::fired): (WebView::closeWindowSoon): (WebView::closeWindowTimerFired): (WebView::notifyPreferencesChanged): Can just check for the existence m_closeWindowTimer, since we only create it when we need to start the timer. * WebView.h: 2010-05-25 Mark Rowe Merge r60168. 2010-05-25 Brady Eidson Reviewed by Darin Adler. Database origins aren't populated at launch (missing db in prefs sheet, possible other symptoms) and https://bugs.webkit.org/show_bug.cgi?id=39486 * WebDatabaseManager.cpp: (WebKitInitializeWebDatabasesIfNecessary): Call initializeTracker() instead of trying to set the path on an already created tracker that already has its origins populated. * WebDatabaseManager.h: * WebView.cpp: (WebView::initWithFrame): Call a renamed method instead. 2010-05-14 Mark Rowe Merge r59434. 2010-05-13 Brian Weinstein Reviewed by Tim Hatcher. Allow reporting exceptions that occur when using JavaScriptCore APIs to the Web Inspector. * Interfaces/IWebViewPrivate.idl: Add a reportException function off of IWebViewPrivate. * Interfaces/WebKit.idl: Touch WebKit.idl to make sure Interfaces rebuild. * WebView.cpp: (WebView::reportException): Make sure the function was called with a context from a WebView, and call WebCore::reportException. * WebView.h: 2010-05-13 Mark Rowe Merge r59232. 2010-05-12 Jer Noble Reviewed by Darin Adler. Bug 38689: #34005 will break fullscreen video playback https://bugs.webkit.org/show_bug.cgi?id=38689 Use the new definition of PlatformMedia to check the actual type returned by MediaPlayer. * FullscreenVideoController.cpp: (FullscreenVideoController::movie): 2010-05-12 Mark Rowe Merge r59175. 2010-05-11 Alice Liu Reviewed by Steve Falkenburg. https://bugs.webkit.org/show_bug.cgi?id=38937 W7 window preview paints content at the wrong location * WebFrame.cpp: (WebFrame::paintDocumentRectToContext): Revert r58895 (WebFrame::paintDocumentRectToContextAtPoint): Added * Interfaces/IWebFramePrivate.idl: Added paintDocumentRectToContextAtPoint * Interfaces/IWebViewPrivate.idl: ditto * Interfaces/WebKit.idl: touch to rebuild * WebFrame.h: ditto * WebView.cpp: ditto (WebView::paintDocumentRectToContextAtPoint): ditto * WebView.h: ditto 2010-05-12 Mark Rowe Merge r59001. 2010-05-07 Jer Noble Reviewed by Adele Peterson. Safari pegs CPU and drops tons of frames using HTML5 Vimeo player https://bugs.webkit.org/show_bug.cgi?id=34005 QTMovieWin is now QTMovieGWorld. * FullscreenVideoController.cpp: (FullscreenVideoController::movie): * FullscreenVideoController.h: 2010-05-06 Adam Roben Bail out of WebView::paint when there's nothing to paint Fixes REGRESSION (r58067): Crash in WebView::paint when Web Inspector is docked and window is resized so small that WebView disappears When the WebView is 0-sized, ensureBackingStore() bails out without creating a bitmap, leaving m_backingStoreBitmap null. Before r58067, m_backingStoreBitmap was an HBITMAP, so we were happily passing along a null HBITMAP to various Windows APIs. These calls would fail but not crash. r58067 changed m_backingStoreBitmap to a RefCountedHBITMAP, and dereferencing a null RefCountedHBITMAP* of course crashes. Reviewed by Steve Falkenburg. * WebView.cpp: (WebView::paint): Bail if the rect to paint is empty. 2010-05-06 Steve Falkenburg Reviewed by Adam Roben. WebFrame::paintDocumentRectToContext paints content at the wrong location https://bugs.webkit.org/show_bug.cgi?id=38651 * WebFrame.cpp: (WebFrame::paintDocumentRectToContext): 2010-05-05 Stuart Morgan Reviewed by Darin Fisher. Update setFocus for the new boolean argument; no behavioral change. https://bugs.webkit.org/show_bug.cgi?id=37961 * WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::setFocus): * WebCoreSupport/EmbeddedWidget.h: 2010-05-03 Abhishek Arya Reviewed by Adam Barth. Add support for controlling clipboard access from javascript. Clipboard access from javascript is disabled by default. https://bugs.webkit.org/show_bug.cgi?id=27751 * Interfaces/IWebPreferencesPrivate.idl: * WebPreferenceKeysPrivate.h: * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::javaScriptCanAccessClipboard): (WebPreferences::setJavaScriptCanAccessClipboard): * WebPreferences.h: * WebView.cpp: (WebView::notifyPreferencesChanged): 2010-05-03 Jens Alfke Reviewed by Darin Fisher. [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient https://bugs.webkit.org/show_bug.cgi?id=38397 No tests (functionality is exposed only through native WebKit API.) * WebFrame.h: 2010-04-30 Jon Honeycutt Caret may fail to blink if a focus handler brings up a modal dialog https://bugs.webkit.org/show_bug.cgi?id=38372 Reviewed by Darin Adler. * WebView.cpp: (WebView::handleMouseEvent): If the message is WM_CANCELMODE, which indicates that we our capturing of mouse events has been cancelled, tell the EventHandler. It's possible to re-enter this function if handling a mouse event allows the message loop to run; moved up the call to setMouseActivated(), so that if we do re-enter this function, the later mouse event will not be considered as activating the window. (WebView::WebViewWndProc): Handle WM_CANCELMODE by calling handleMouseEvent(). 2010-04-29 Anders Carlsson Reviewed by Dan Bernstein. First part of https://bugs.webkit.org/show_bug.cgi?id=20784 move npapi.h to C99 integer types. * WebKit.vcproj/WebKit.vcproj: 2010-04-28 Beth Dakin Reviewed by Darin Adler. Fix for Add a synchronous display mechanism for WKCACFLayerRenderer. * Interfaces/IWebViewPrivate.idl: * Interfaces/WebKit.idl: * WebView.cpp: (WebView::WebView): (WebView::updateRootLayerContents): (WebView::nextDisplayIsSynchronous): * WebView.h: 2010-04-28 Steve Falkenburg Reviewed by Maciej Stachowiak. WebView drawing code may access null backing store dirty region https://bugs.webkit.org/show_bug.cgi?id=38245 REGRESSION (r58067): All loaded pages fail to display after running iBench HTML test (intermittent) * WebView.cpp: (WebView::updateBackingStore): Add null check for m_backingStoreDirtyRegion. 2010-04-27 Jon Honeycutt Hitting the "delete" key goes back twice Reviewed by Maciej Stachowiak. * WebView.cpp: (WebView::keyDown): Return true if we navigated back or forward from the key event to prevent the event from being propagated further. 2010-04-25 Sam Weinig Reviewed by Maciej Stachowiak. Fix for https://bugs.webkit.org/show_bug.cgi?id=38097 Disentangle initializing the main thread from initializing threading * WebKitClassFactory.cpp: (WebKitClassFactory::WebKitClassFactory): Add call to initializeMainThread. * WebView.cpp: (WebView::WebView): Ditto. 2010-04-25 Yury Semikhatsky Reviewed by Pavel Feldman. Web Inspector: inspector client shouldn't check if it can be opened docked if it is already in that state. https://bugs.webkit.org/show_bug.cgi?id=37946 * WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::WebInspectorFrontendClient): (WebInspectorFrontendClient::showWindowWithoutNotifications): * WebCoreSupport/WebInspectorClient.h: 2010-04-24 Steve Falkenburg Reviewed by Sam Weinig. Typo in Geolocation code causes crashes when updates are stopped https://bugs.webkit.org/show_bug.cgi?id=38089 Crash closing geolocation tab after allowing to use geolocation * WebCoreSupport/WebGeolocationControllerClient.cpp: (WebGeolocationControllerClient::stopUpdating): Call unregister instead of register. 2010-04-23 Andy Estes Rubber stamped by Steve Falkenburg. Roll out http://trac.webkit.org/changeset/55385. * Interfaces/IWebUIDelegatePrivate.idl: * Interfaces/WebKit.idl: * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): 2010-04-22 Dave Moore Reviewed by Dimitri Glazkov. Added notification when the favicons for a page are changed from a script. The Document object will notify the frame loader, which will notify the client. Implementations of FrameLoaderClient will have to add one method; dispatchDidChangeIcons(). https://bugs.webkit.org/show_bug.cgi?id=33812 * Interfaces/IWebFrameLoadDelegatePrivate2.idl: * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidChangeIcons): * WebCoreSupport/WebFrameLoaderClient.h: * WebFrame.cpp: (WebFrame::didChangeIcons): * WebFrame.h: 2010-04-22 Adam Barth Unreviewed, rolling out r58069. http://trac.webkit.org/changeset/58069 https://bugs.webkit.org/show_bug.cgi?id=27751 Broke compile on Windows. * Interfaces/IWebPreferencesPrivate.idl: * WebPreferenceKeysPrivate.h: * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): * WebPreferences.h: * WebView.cpp: (WebView::notifyPreferencesChanged): 2010-04-22 Abhishek Arya Reviewed by Adam Barth. Add support for controlling clipboard access from javascript. Clipboard access from javascript is disabled by default. https://bugs.webkit.org/show_bug.cgi?id=27751 * Interfaces/IWebPreferencesPrivate.idl: * WebPreferenceKeysPrivate.h: * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::javaScriptCanAccessClipboard): (WebPreferences::setJavaScriptCanAccessClipboard): * WebPreferences.h: * WebView.cpp: (WebView::notifyPreferencesChanged): 2010-04-21 Andy Estes Reviewed by Maciej Stachowiak. Reference count WebView's backing store bitmap to prevent deleteBackingStore() from freeing the bitmap while it is still being referenced by Core Animation. https://bugs.webkit.org/show_bug.cgi?id=37954 * WebView.cpp: (WebView::ensureBackingStore): (WebView::addToDirtyRegion): (WebView::scrollBackingStore): (WebView::updateBackingStore): (WebView::paint): (WebView::backingStore): (releaseBackingStoreCallback): deref m_backingStoreBitmap once Core Animation has dropeed its reference to the memory. (WebView::updateRootLayerContents): ref m_backingStoreBitmap before passing the memory to Core Animation to prevent deleteBackingStore() from freeing it while it is still referenced by CA. * WebView.h: Make m_backingStoreBitmap a RefCountedGDIHandle, and make m_backingStoreDirtyRegion a RefCountedGDIHandle. 2010-04-20 Adam Barth Reviewed by Eric Seidel. Factor DocumentWriter out of FrameLoader https://bugs.webkit.org/show_bug.cgi?id=37175 Update these callsites because the method moved to DocumentWriter. * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::receivedData): 2010-04-20 Kent Tamura Reviewed by Darin Adler. Change a parameter type of chooseIconForFiles() https://bugs.webkit.org/show_bug.cgi?id=37504 * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::chooseIconForFiles): * WebCoreSupport/WebChromeClient.h: 2010-04-16 Gavin Barraclough Reviewed by NOBODY (Windows build fix). * WebFrame.cpp: (WebFrame::stringByEvaluatingJavaScriptInScriptWorld): * WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString): 2010-04-16 Adam Roben Make it possible for clients to instantiate a WebUserContentURLPattern Reviewed by Tim Hatcher. * ForEachCoClass.h: Added WebUserContentURLPattern to the FOR_EACH_COCLASS macro, which lists all our instantiatable classes. * WebKitClassFactory.cpp: Added a now-required #include. 2010-04-15 Adam Roben Expose UserContentURLPattern as WebKit SPI Fixes . Reviewed by Tim Hatcher. * Interfaces/IWebUserContentURLPattern.idl: Added. * Interfaces/WebKit.idl: Added WebUserContentURLPattern. * WebKit.vcproj/Interfaces.vcproj: Added IWebUserContentURLPattern. * WebKit.vcproj/WebKit.vcproj: Added WebUserContentURLPattern. * WebUserContentURLPattern.cpp: Added. (WebUserContentURLPattern::WebUserContentURLPattern): (WebUserContentURLPattern::~WebUserContentURLPattern): (WebUserContentURLPattern::createInstance): (WebUserContentURLPattern::AddRef): (WebUserContentURLPattern::Release): (WebUserContentURLPattern::QueryInterface): Standard COM implementations. (WebUserContentURLPattern::parse): Parse the string into a UserContentURLPattern and store it. (WebUserContentURLPattern::isValid): (WebUserContentURLPattern::scheme): (WebUserContentURLPattern::host): (WebUserContentURLPattern::matchesSubdomains): Call through to UserContentURLPattern. * WebUserContentURLPattern.h: Added. 2010-04-14 Adam Roben Expose DOMWrapperWorld::unregisterWorld as WebKit SPI on Windows Fixes . Reviewed by Steve Falkenburg. * Interfaces/IWebScriptWorld.idl: Added unregisterWorld. * Interfaces/WebKit.idl: Touched to force a build. * WebScriptWorld.cpp: (WebScriptWorld::unregisterWorld): * WebScriptWorld.h: Added. Just calls through to DOMWrapperWorld::unregisterWorld. 2010-04-12 Timothy Hatcher SecurityOrigin needs a way to remove individual OriginAccessEntries https://bugs.webkit.org/show_bug.cgi?id=37449 Reviewed by Dave Hyatt. * Interfaces/IWebViewPrivate.idl: * WebView.cpp: (WebView::removeOriginAccessWhitelistEntry): Call SecurityOrigin::removeOriginAccessWhitelistEntry. * WebView.h: Added removeOriginAccessWhitelistEntry. 2010-04-13 Timothy Hatcher Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry. And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists. SecurityOrigin needs a way to remove individual OriginAccessEntries https://bugs.webkit.org/show_bug.cgi?id=37449 Reviewed by Dave Hyatt. * Interfaces/IWebViewPrivate.idl: * WebView.cpp: (WebView::addOriginAccessWhitelistEntry): (WebView::resetOriginAccessWhitelists): * WebView.h: 2010-04-11 Sheriff Bot Unreviewed, rolling out r57468. http://trac.webkit.org/changeset/57468 https://bugs.webkit.org/show_bug.cgi?id=37433 Broke the world... Must have applied the patch wrong (Requested by abarth on #webkit). * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::receivedData): 2010-04-11 Adam Barth Reviewed by Eric Seidel. Factor DocumentWriter out of FrameLoader https://bugs.webkit.org/show_bug.cgi?id=37175 Update these callsites because the method moved to DocumentWriter. * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::receivedData): 2010-04-09 Adam Roben Windows Debug/Release build fix after r57244 * WebKit.vcproj/WebKit.vcproj: Don't delay-load QuartzCore.dll or QuartzCoreInterface.dll in any configurations. r57244 made this change only for Debug_Internal. 2010-04-08 Steve Falkenburg Reviewed by Darin Adler. WebView::isLoading should null check m_mainFrame https://bugs.webkit.org/show_bug.cgi?id=37294 * WebView.cpp: (WebView::isLoading): 2010-04-07 Chris Marrin Reviewed by Steve Falkenburg. Remove QuartzCoreInterface from the build No longer needed since QuartzCore.dll is now included in the latest Safari release (4.0.5). * WebKit.vcproj/WebKit.vcproj:Removed delay load for QuartzCore and QuartzCoreInterface 2010-04-07 Andrey Kosyakov Reviewed by Yury Semikhatsky. Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest() https://bugs.webkit.org/show_bug.cgi?id=36949 * WebCoreSupport/WebFrameLoaderClient.cpp: * WebCoreSupport/WebFrameLoaderClient.h: 2010-04-05 Peter Nelson Reviewed by Eric Seidel. Fixed style errors in DOMCoreClasses.h to bring it up to scratch for https://bugs.webkit.org/show_bug.cgi?id=34979. * DOMCoreClasses.h: (DOMObject::throwException): (DOMObject::callWebScriptMethod): (DOMObject::evaluateWebScript): (DOMObject::removeWebScriptKey): (DOMObject::stringRepresentation): (DOMObject::webScriptValueAtIndex): (DOMObject::setWebScriptValueAtIndex): (DOMObject::setException): (DOMNodeList::throwException): (DOMNodeList::callWebScriptMethod): (DOMNodeList::evaluateWebScript): (DOMNodeList::removeWebScriptKey): (DOMNodeList::stringRepresentation): (DOMNodeList::webScriptValueAtIndex): (DOMNodeList::setWebScriptValueAtIndex): (DOMNodeList::setException): (DOMDocument::throwException): (DOMDocument::callWebScriptMethod): (DOMDocument::evaluateWebScript): (DOMDocument::removeWebScriptKey): (DOMDocument::stringRepresentation): (DOMDocument::webScriptValueAtIndex): (DOMDocument::setWebScriptValueAtIndex): (DOMDocument::setException): (DOMDocument::nodeName): (DOMDocument::nodeValue): (DOMDocument::setNodeValue): (DOMDocument::nodeType): (DOMDocument::parentNode): (DOMDocument::childNodes): (DOMDocument::firstChild): (DOMDocument::lastChild): (DOMDocument::previousSibling): (DOMDocument::nextSibling): (DOMDocument::attributes): (DOMDocument::ownerDocument): (DOMDocument::insertBefore): (DOMDocument::replaceChild): (DOMDocument::removeChild): (DOMDocument::appendChild): (DOMDocument::hasChildNodes): (DOMDocument::cloneNode): (DOMDocument::isSupported): (DOMDocument::namespaceURI): (DOMDocument::prefix): (DOMDocument::setPrefix): (DOMDocument::localName): (DOMDocument::hasAttributes): (DOMDocument::isSameNode): (DOMDocument::isEqualNode): (DOMDocument::textContent): (DOMDocument::setTextContent): (DOMElement::throwException): (DOMElement::callWebScriptMethod): (DOMElement::evaluateWebScript): (DOMElement::removeWebScriptKey): (DOMElement::stringRepresentation): (DOMElement::webScriptValueAtIndex): (DOMElement::setWebScriptValueAtIndex): (DOMElement::setException): (DOMElement::nodeName): (DOMElement::nodeValue): (DOMElement::setNodeValue): (DOMElement::nodeType): (DOMElement::parentNode): (DOMElement::childNodes): (DOMElement::firstChild): (DOMElement::lastChild): (DOMElement::previousSibling): (DOMElement::nextSibling): (DOMElement::attributes): (DOMElement::ownerDocument): (DOMElement::insertBefore): (DOMElement::replaceChild): (DOMElement::removeChild): (DOMElement::appendChild): (DOMElement::hasChildNodes): (DOMElement::cloneNode): (DOMElement::isSupported): (DOMElement::namespaceURI): (DOMElement::prefix): (DOMElement::setPrefix): (DOMElement::localName): (DOMElement::hasAttributes): (DOMElement::isSameNode): (DOMElement::isEqualNode): (DOMElement::textContent): (DOMElement::setTextContent): 2010-04-05 Alexey Proskuryakov Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=37111 Draw replacement text when plug-in host crashes * WebCoreLocalizedStrings.cpp: (WebCore::crashedPluginText): Added a stub string for plug-in failure. 2010-04-02 Rafael Weinstein Reviewed by Adam Barth. Clean up unused calls after changes to checkPermission and requestPermission argument lists. * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::requestPermission): * WebCoreSupport/WebDesktopNotificationsDelegate.h: 2010-04-01 Chris Marrin Reviewed by Simon Fraser. Added layerTreeAsText function to DRT (for Mac) https://bugs.webkit.org/show_bug.cgi?id=36782 This is the WebKit side for Windows. It plumbs the call from WebCore to DRT. * Interfaces/IWebFramePrivate.idl: * WebFrame.cpp:WebKit (Windows) side of plumbing (WebFrame::layerTreeAsText): * WebFrame.h: 2010-03-31 Marcus Bulach Reviewed by Jeremy Orlow. Adds Geolocation param for cancelGeolocationPermissionRequestForFrame. https://bugs.webkit.org/show_bug.cgi?id=35031 * WebCoreSupport/WebChromeClient.h: (WebChromeClient::cancelGeolocationPermissionRequestForFrame): 2010-03-30 Gavin Barraclough Rubber stamped by Sam Weinig. https://bugs.webkit.org/show_bug.cgi?id=36866 Move CString to WTF * WebDownload.cpp: * WebDownloadCFNet.cpp: * WebDownloadCurl.cpp: * WebHistoryItem.cpp: * WebLocalizableStrings.cpp: * WebMutableURLRequest.cpp: * WebPreferences.cpp: (WebPreferences::migrateWebKitPreferencesToCFPreferences): * WebView.cpp: 2010-03-30 Adam Roben Windows build fix * Interfaces/WebKit.idl: Touched this to force a build. 2010-03-29 Steve Falkenburg Reviewed by Adele Peterson. Default value of accelerated compositing should be false for Windows https://bugs.webkit.org/show_bug.cgi?id=36805 * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): 2010-03-29 Rafael Weinstein Reviewed by Adam Barth. Change NotificationPresenter::checkPermission() to take the source frames full KURL, rather than its SecurityOrigin. This will aid chromium in having more fine grained permissions to control notification spam. * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::checkPermission): * WebCoreSupport/WebDesktopNotificationsDelegate.h: 2010-03-26 Kenneth Rohde Christiansen Reviewed by Antti Koivisto. Change method name due to it dealing with both flattening of frame sets and inner frames. * Interfaces/IWebPreferencesPrivate.idl: * WebPreferenceKeysPrivate.h: * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::isFrameFlatteningEnabled): (WebPreferences::setFrameFlatteningEnabled): * WebPreferences.h: * WebView.cpp: (WebView::notifyPreferencesChanged): 2010-03-24 Jon Honeycutt Missing plug-ins should be represented by text only, instead of lego block https://bugs.webkit.org/show_bug.cgi?id=36583 Reviewed by Dan Bernstein. * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Return 0 if we failed to initialize the plug-in, which causes the new "missing plug-in" text to draw. 2010-03-24 Kent Tamura Reviewed by Darin Adler. Make Icon::createIconForFiles() optional. https://bugs.webkit.org/show_bug.cgi?id=35072 - Rename iconForFiles() to chooseIconForFiles(). - Call Icon::createIconForFiles() from chooseIconForFiles(). * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::chooseIconForFiles): * WebCoreSupport/WebChromeClient.h: 2010-03-22 Darin Adler * WebCoreLocalizedStrings.cpp: (WebCore::missingPluginText): Fixed localization helper text to match the same string from Mac WebKit. 2010-03-22 Kevin Decker Reviewed by John Sullivan. https://bugs.webkit.org/show_bug.cgi?id=36328 * WebCoreLocalizedStrings.cpp: (WebCore::missingPluginText): Added. 2010-03-17 Enrica Casucci Reviewed by Darin Adler. Missing support for showing compositing layers borders and repaint count on Windows. * Interfaces/IWebPreferencesPrivate.idl: * WebPreferenceKeysPrivate.h: * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::showDebugBorders): (WebPreferences::setShowDebugBorders): (WebPreferences::showRepaintCounter): (WebPreferences::setShowRepaintCounter): * WebPreferences.h: * WebView.cpp: (WebView::notifyPreferencesChanged): 2010-03-16 Yury Semikhatsky Reviewed by Pavel Feldman. Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost. Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder https://bugs.webkit.org/show_bug.cgi?id=35036 * WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::WebInspectorClient): (WebInspectorClient::~WebInspectorClient): (WebInspectorClient::openInspectorFrontend): (WebInspectorClient::highlight): (WebInspectorClient::hideHighlight): (WebInspectorClient::updateHighlight): (WebInspectorFrontendClient::WebInspectorFrontendClient): (WebInspectorFrontendClient::~WebInspectorFrontendClient): (WebInspectorFrontendClient::frontendLoaded): (WebInspectorFrontendClient::localizedStringsURL): (WebInspectorFrontendClient::hiddenPanels): (WebInspectorFrontendClient::bringToFront): (WebInspectorFrontendClient::closeWindow): (WebInspectorFrontendClient::attachWindow): (WebInspectorFrontendClient::detachWindow): (WebInspectorFrontendClient::setAttachedWindowHeight): (WebInspectorFrontendClient::inspectedURLChanged): (WebInspectorFrontendClient::closeWindowWithoutNotifications): (WebInspectorFrontendClient::showWindowWithoutNotifications): (WebInspectorFrontendClient::destroyInspectorView): (WebInspectorFrontendClient::updateWindowTitle): (WebInspectorFrontendClient::onGetMinMaxInfo): (WebInspectorFrontendClient::onSize): (WebInspectorFrontendClient::onClose): (WebInspectorFrontendClient::onSetFocus): (WebInspectorFrontendClient::onWebViewWindowPosChanging): (WebInspectorWndProc): (WebInspectorFrontendClient::windowReceivedMessage): * WebCoreSupport/WebInspectorClient.h: (WebInspectorClient::frontendClosing): * WebInspector.cpp: (WebInspector::attach): (WebInspector::detach): 2010-03-14 Dan Bernstein Reviewed by Darin Adler. WebKit part of removing support for legacy versions of Core Graphics * WebKitClassFactory.cpp: (WebKitClassFactory::WebKitClassFactory): Removed call to populateFontDatabase(). * WebKitGraphics.cpp: (makeFont): Ditto. * WebTextRenderer.cpp: (WebTextRenderer::registerPrivateFont): Removed call to wkAddFontsAtPath(). 2010-03-12 Enrica Casucci Fixed broken build on Windows. Added contditional compilation for accelerated compositing. * WebView.cpp: (WebView::deleteBackingStore): (WebView::addToDirtyRegion): (WebView::updateBackingStore): 2010-03-12 Beth Dakin Reviewed by Simon Fraser. Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen API naming is inconsistent -and corresponding- This patch changes all occurrences of "fullScreen" to the more popular "fullscreen." * FullscreenVideoController.cpp: (FullscreenVideoController::onMouseDown): (FullscreenVideoController::onMouseMove): (FullscreenVideoController::onMouseUp): * FullscreenVideoController.h: (FullscreenVideoController::fullscreenToHUDCoordinates): 2010-03-12 Beth Dakin Reviewed by Adam Roben. Fix for https://bugs.webkit.org/show_bug.cgi?id=33739 Fullscreen video HUD stays on top when switching to another window (e.g. via Alt-Tab) -and corresponding- The HUD was always on top because it had the WS_EX_TOPMOST style. So I removed the style and made m_videoWindow the owner of m_hudWindow. This keeps m_hudWindow on top only when m_videoWindow is the focused window. * FullscreenVideoController.cpp: (FullscreenVideoController::exitFullscreen): ASSERT that movie()->exitFullscreen() also destroyed the hud. (FullscreenVideoController::createHUDWindow): 2010-03-12 Enrica Casucci Reviewed by Simon Fraser. Content of 3D tests appears at the bottom right corner sometimes. See detailed comments in WebCore/ChangeLog. * WebView.cpp: (WebView::deleteBackingStore): Reset the dirty flag when deleting the backing store. (WebView::addToDirtyRegion): Set the dirty flag when adding dirty rectangles to the backing store dirty region. (WebView::updateBackingStore): Reset the dirty flag after painting into the backing store. (WebView::setAcceleratedCompositing): Removed unnecessary call to updateRootLayerContents. (WebView::updateRootLayerContents): Changed the way we pass parameters to setScrollFrame. We are passing width and height of the view content together with the offset for the scrolling. It was confusing to pass it all as a rectangle, when it is not a rectangle. 2010-03-11 Aaron Boodman Kill WebDocument::applicationID() (part 1). Modify interface to WebCore::NotificationPresenter::checkPermission() and remove implementation of WebDocument::applicationID(). Breaking API changes will be in a subsequent change. https://bugs.webkit.org/show_bug.cgi?id=35846 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::checkPermission): * WebCoreSupport/WebDesktopNotificationsDelegate.h: 2010-03-11 Anders Carlsson Reviewed by David Hyatt. Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents. * WebCoreSupport/WebChromeClient.cpp: * WebCoreSupport/WebChromeClient.h: 2010-03-10 Eric Uhrhane Reviewed by David Levin. The build fix for my patch on bug #35763 wasn't quite right--it removed the call entirely, instead of replacing it with the new API. This adds the call to Database::setIsAvailable. https://bugs.webkit.org/show_bug.cgi?id=35763 * WebView.cpp: Added a call to Database::setIsAvailable where change 55667 removed the old Settings API call . (WebView::notifyPreferencesChanged): 2010-03-10 John Sullivan Reviewed by Tim Hatcher. input type other than text won't work with autofill * WebFrame.cpp: (WebFrame::elementDoesAutoComplete): Return true for any text field that's not a password, rather than only for TEXT type. 2010-03-09 Brady Eidson Reviewed by Tim Hatcher. REGRESSION: WebInspector docking busted on Windows and https://bugs.webkit.org/show_bug.cgi?id=35953 * WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::attachWindow): Use the InspectorController:: copy of the should attach settings key. (WebInspectorClient::detachWindow): Ditto. (WebInspectorClient::showWindowWithoutNotifications): Ditto. 2010-03-09 John Sullivan Fixed localized string key collision. update-webkit-localized-strings now runs without errors. Reviewed by Adam Roben. * WebCoreLocalizedStrings.cpp: (WebCore::AXMenuListPopupActionVerb): Used LPCTSTR_UI_STRING_KEY for the 2nd use of "press". 2010-03-08 Adam Treat Unreviewed build fix for Windows. * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::invalidateContents): 2010-03-02 Adam Treat Reviewed by Dave Hyatt. Adapt the win port to the refactoring of repaint methods. https://bugs.webkit.org/show_bug.cgi?id=34214 * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::invalidateContents): (WebChromeClient::invalidateWindow): (WebChromeClient::invalidateContentsAndWindow): (WebChromeClient::invalidateContentsForSlowScroll): * WebCoreSupport/WebChromeClient.h: 2010-03-08 Daniel Bates Unreviewed, build fix. Attempt to fix the Windows builds by applying the corresponding change made in bug #35763 . * WebView.cpp: Removed call to settings->setDatabasesEnabled since this setting no longer exists following changeset 55666 . (WebView::notifyPreferencesChanged): 2010-03-07 Mark Rowe Windows build fix. * WebKitPrefix.h: Include CoreFoundation/CoreFoundation.h from the Windows prefix header since some WebCore headers rely on the types declared within being available via the prefix header. 2010-03-05 Chris Marrin Reviewed by Simon Fraser. Got rid of platformLayer use in WebView. https://bugs.webkit.org/show_bug.cgi?id=35798 WKCACFLayer no longer depends on GraphicsLayer, so I got rid of that dependency on WebView. Now WebChromeClient casts platformLayer to WKCACFLayer which will always be the case on Windows. * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::attachRootGraphicsLayer): * WebView.cpp: (WebView::setRootChildLayer): * WebView.h: 2010-03-04 Beth Dakin Reviewed by Anders Carlsson. WebCore::Page::setInstanceHandle() is now just WebCore::setInstanceHandle() * WebKitDLL.cpp: (DllMain): 2010-03-03 Alice Liu Reviewed by Jon Honeycutt. Add a way to get an iframe's content frame * DOMCoreClasses.cpp: (DOMElement::createInstance): Added case for DOMHTMLIFrameElement * DOMHTMLClasses.cpp: Adding the few DOMHTMLIFrameElement functions definitions that have distinct implementations (all others just call parent implementation) (DOMHTMLIFrameElement::QueryInterface): (DOMHTMLIFrameElement::contentFrame): * DOMHTMLClasses.h: Most of these function declarations have definitions that just call the parent implementation (DOMHTMLIFrameElement::DOMHTMLIFrameElement): (DOMHTMLIFrameElement::AddRef): (DOMHTMLIFrameElement::Release): (DOMHTMLIFrameElement::throwException): (DOMHTMLIFrameElement::callWebScriptMethod): (DOMHTMLIFrameElement::evaluateWebScript): (DOMHTMLIFrameElement::removeWebScriptKey): (DOMHTMLIFrameElement::stringRepresentation): (DOMHTMLIFrameElement::webScriptValueAtIndex): (DOMHTMLIFrameElement::setWebScriptValueAtIndex): (DOMHTMLIFrameElement::setException): (DOMHTMLIFrameElement::nodeName): (DOMHTMLIFrameElement::nodeValue): (DOMHTMLIFrameElement::setNodeValue): (DOMHTMLIFrameElement::nodeType): (DOMHTMLIFrameElement::parentNode): (DOMHTMLIFrameElement::childNodes): (DOMHTMLIFrameElement::firstChild): (DOMHTMLIFrameElement::lastChild): (DOMHTMLIFrameElement::previousSibling): (DOMHTMLIFrameElement::nextSibling): (DOMHTMLIFrameElement::attributes): (DOMHTMLIFrameElement::ownerDocument): (DOMHTMLIFrameElement::insertBefore): (DOMHTMLIFrameElement::replaceChild): (DOMHTMLIFrameElement::removeChild): (DOMHTMLIFrameElement::appendChild): (DOMHTMLIFrameElement::hasChildNodes): (DOMHTMLIFrameElement::cloneNode): (DOMHTMLIFrameElement::normalize): (DOMHTMLIFrameElement::isSupported): (DOMHTMLIFrameElement::namespaceURI): (DOMHTMLIFrameElement::prefix): (DOMHTMLIFrameElement::setPrefix): (DOMHTMLIFrameElement::localName): (DOMHTMLIFrameElement::hasAttributes): (DOMHTMLIFrameElement::isSameNode): (DOMHTMLIFrameElement::isEqualNode): (DOMHTMLIFrameElement::textContent): (DOMHTMLIFrameElement::setTextContent): (DOMHTMLIFrameElement::tagName): (DOMHTMLIFrameElement::getAttribute): (DOMHTMLIFrameElement::setAttribute): (DOMHTMLIFrameElement::removeAttribute): (DOMHTMLIFrameElement::getAttributeNode): (DOMHTMLIFrameElement::setAttributeNode): (DOMHTMLIFrameElement::removeAttributeNode): (DOMHTMLIFrameElement::getElementsByTagName): (DOMHTMLIFrameElement::getAttributeNS): (DOMHTMLIFrameElement::setAttributeNS): (DOMHTMLIFrameElement::removeAttributeNS): (DOMHTMLIFrameElement::getAttributeNodeNS): (DOMHTMLIFrameElement::setAttributeNodeNS): (DOMHTMLIFrameElement::getElementsByTagNameNS): (DOMHTMLIFrameElement::hasAttribute): (DOMHTMLIFrameElement::hasAttributeNS): (DOMHTMLIFrameElement::focus): (DOMHTMLIFrameElement::blur): (DOMHTMLIFrameElement::idName): (DOMHTMLIFrameElement::setIdName): (DOMHTMLIFrameElement::title): (DOMHTMLIFrameElement::setTitle): (DOMHTMLIFrameElement::lang): (DOMHTMLIFrameElement::setLang): (DOMHTMLIFrameElement::dir): (DOMHTMLIFrameElement::setDir): (DOMHTMLIFrameElement::className): (DOMHTMLIFrameElement::setClassName): (DOMHTMLIFrameElement::innerHTML): (DOMHTMLIFrameElement::setInnerHTML): (DOMHTMLIFrameElement::innerText): (DOMHTMLIFrameElement::setInnerText): * Interfaces/DOMHTML.idl: Added IDOMHTMLIFrameElement interface 2010-03-03 Chris Marrin Reviewed by Simon Fraser. Export acceleratedCompositing flag in IWebPreferences. https://bugs.webkit.org/show_bug.cgi?id=35610 * Interfaces/IWebPreferences.idl: 2010-03-02 Beth Dakin Reviewed by Darin Adler and Adam Roben. Tiny WebKit portion of fix for WebKit crashes on systems that don't support CoreAnimation setHostWindow() no longer calls createRenderer(), so now that has to be called manually. * WebView.cpp: (WebView::setAcceleratedCompositing): 2010-03-02 Adam Roben Add IWebViewPrivate::registerURLSchemeAsSecure Fixes Expose SecurityOrigin::registerURLSchemeAsSecure as WebKit SPI Reviewed by Tim Hatcher. * Interfaces/WebKit.idl: Touched to force a build. * Interfaces/IWebViewPrivate.idl: * WebView.cpp: (WebView::registerURLSchemeAsSecure): * WebView.h: Added. Calls through to SecurityOrigin::registerURLSchemeAsSecure. 2010-03-01 Jon Honeycutt Remove Windows line endings from some files. Rubber-stamped by Alice Liu. * Interfaces/IWebEmbeddedView.idl: * WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::create): (EmbeddedWidget::~EmbeddedWidget): (EmbeddedWidget::createWindow): (EmbeddedWidget::invalidateRect): (EmbeddedWidget::setFrameRect): (EmbeddedWidget::frameRectsChanged): (EmbeddedWidget::setFocus): (EmbeddedWidget::show): (EmbeddedWidget::hide): (EmbeddedWidget::windowClipRect): (EmbeddedWidget::setParent): (EmbeddedWidget::attachToWindow): (EmbeddedWidget::detachFromWindow): (EmbeddedWidget::didReceiveResponse): (EmbeddedWidget::didReceiveData): (EmbeddedWidget::didFinishLoading): (EmbeddedWidget::didFail): * WebCoreSupport/EmbeddedWidget.h: (EmbeddedWidget::EmbeddedWidget): 2010-03-01 Jon Honeycutt Some WebKit DOMNode API is unimplemented. https://bugs.webkit.org/show_bug.cgi?id=35554 Reviewed by Alice Liu. * DOMCoreClasses.cpp: (DOMNode::nextSibling): Create a DOMNode to wrap m_node's next sibling, and assign it to the out param 'result'. (DOMNode::insertBefore): Query for the DOMNode for newChild, and return early if we fail. Query refChild for DOMNode. Call insertBefore(), passing the newChild's WebCore node and refChild's WebCore node (if refChild is non-null). If we successfully insert the child, fill the result out param with newChild, ref it, and return S_OK. Otherwise, return E_FAIL. (DOMNode::removeChild): Query oldChild for DOMNode. If we fail, return E_FAIL. Call removeChild(), passing the node's WebCore node. If this fails, return E_FAIL. Otherwise, fill the result out param with oldChild, ref it, and return S_OK. 2010-03-01 Jakob Petsovits Reviewed by Adam Barth. Adapt to the new ZoomMode enum. https://bugs.webkit.org/show_bug.cgi?id=35347 * WebFrame.cpp: (WebFrame::setTextSizeMultiplier): * WebView.cpp: (WebView::setZoomMultiplier): (WebView::zoomMultiplier): (WebView::canMakeTextLarger): (WebView::makeTextLarger): (WebView::canMakeTextSmaller): (WebView::makeTextSmaller): (WebView::notifyPreferencesChanged): 2010-02-26 Jon Honeycutt IWebUIDelegatePrivate::embeddedViewWithArguments is passed wrong arguments Reviewed by Adam Roben. * Interfaces/IWebUIDelegatePrivate.idl: Update copyright strings. Added a new key for the plug-in source URL. * Interfaces/WebKit.idl: Update copyright strings. * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Pass the URL of the plug-in as the source URL. Pass the document's base URI for the base URL. 2010-02-23 Brady Eidson Reviewed by Tim Hatcher and Pavel Feldman. Regression (r55107) - WebInspector docking is busted. https://bugs.webkit.org/show_bug.cgi?id=35274 * WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::showWindowWithoutNotifications): Swap the order of the "should attach?" check to get the expected behavior. 2010-02-23 Steve Block Reviewed by Darin Adler. Adds ChromeClient::cancelGeolocationPermissionRequestForFrame https://bugs.webkit.org/show_bug.cgi?id=34962 This method is required so that a Geolocation object can cancel an asynchronous permission request. This allows the chrome client to cancel any UI it is showing for the permission request. * WebCoreSupport/WebChromeClient.h: (WebChromeClient::cancelGeolocationPermissionRequestForFrame): 2010-02-22 Steve Falkenburg Reviewed by Darin Adler. WebKit on Windows should pick up system setting changes without requiring explicit API calls https://bugs.webkit.org/show_bug.cgi?id=35269 * WebKit.vcproj/WebKit.def: Removed WebKitSystemParameterChanged. * WebKit.vcproj/WebKit_debug.def: Removed WebKitSystemParameterChanged. * WebKitGraphics.cpp: Removed WebKitSystemParameterChanged. * WebKitGraphics.h: Removed WebKitSystemParameterChanged. * WebView.cpp: (systemParameterChanged): Call through to wkSystemFontSmoothingChanged for font changes. (WebView::windowReceivedMessage): Pick up WM_SETTINGCHANGE from windowReceivedMessage. 2010-02-22 Brady Eidson Reviewed by Tim Hatcher. Disable WebView docking to views that are too small. and https://bugs.webkit.org/show_bug.cgi?id=35254 * WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::showWindowWithoutNotifications): No matter the preference, don't open the inspector window attached if WebCore says it shouldn't be attached. 2010-02-17 Steve Falkenburg Reviewed by Dan Bernstein. WebKit on Windows needs a mechanism to listen for WM_SETTINGCHANGED messages https://bugs.webkit.org/show_bug.cgi?id=35076 * WebKit.vcproj/WebKit.def: Added WebKitSystemParameterChanged. * WebKit.vcproj/WebKit_debug.def: Added WebKitSystemParameterChanged. * WebKitGraphics.cpp: (WebKitSystemParameterChanged): Call through to wkSystemFontSmoothingChanged for font smoothing changes. * WebKitGraphics.h: Added WebKitSystemParameterChanged. 2010-02-17 Dmitry Titov Reviewed by David Levin, Darin Fisher, Simon Hausmann. When a live iframe element is moved between pages, it still depends on the old page. https://bugs.webkit.org/show_bug.cgi?id=34382 * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::didTransferChildFrameToNewDocument): Added empty implementation of a new virtual method. * WebCoreSupport/WebFrameLoaderClient.h: 2010-02-17 Kent Tamura Reviewed by Eric Seidel. Introduces new Icon loading interface in order to support asynchronous loading. https://bugs.webkit.org/show_bug.cgi?id=32054 Add an empty implementation of ChromeClient::iconForFiles(). * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::iconForFiles): * WebCoreSupport/WebChromeClient.h: 2010-02-17 Shinichiro Hamaji Unreviewed. Touch WebKit.idl to fix the build. [Win] Implement test functions for printing https://bugs.webkit.org/show_bug.cgi?id=34570 * Interfaces/WebKit.idl: 2010-02-17 Shinichiro Hamaji Reviewed by Eric Seidel. [Win] Implement test functions for printing https://bugs.webkit.org/show_bug.cgi?id=34570 * Interfaces/IWebFramePrivate.idl: * WebFrame.cpp: (WebFrame::pageNumberForElementById): (WebFrame::numberOfPages): * WebFrame.h: 2010-02-16 Darin Adler Reviewed by Sam Weinig. Generalize delayed plug-in start for background tabs for use for other media https://bugs.webkit.org/show_bug.cgi?id=34981 * WebView.cpp: (WebView::setCanStartPlugins): Change to call setCanStartMedia. In a later patch we can change the of the public function in the IDL file too, but for now this should be enough. 2010-02-15 Adam Roben Add IWebFramePrivate::visibleContentRect Fixes Add API to get a WebFrame's visible content rect Reviewed by Jon Honeycutt. * Interfaces/IWebFramePrivate.idl: Added visibleContentRect. * Interfaces/WebKit.idl: Touched to force a build. * WebFrame.cpp: (WebFrame::visibleContentRect): * WebFrame.h: Added. Calls through to FrameView::visibleContentRect. 2010-02-12 Brian Weinstein Reviewed by Adam Roben. onmouseout fired when moving over tooltip on Windows https://bugs.webkit.org/show_bug.cgi?id=16794 . Add WS_EX_TRANSPARENT to out tooltip HWND so it isn't subject to hit testing, and when you mouse over the tooltip, it doesn't send a mouseout to the web content. * WebView.cpp: (WebView::initializeToolTipWindow): Add WS_EX_TRANSPARENT. 2010-02-10 Jesus Sanchez-Palencia Reviewed by Kenneth Rohde Christiansen. Support frameset flattening https://bugs.webkit.org/show_bug.cgi?id=32717 Add support for enabling/disabling FrameSet Flattening on the Windows port. * Interfaces/IWebPreferencesPrivate.idl: * WebPreferenceKeysPrivate.h: * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::isFrameSetFlatteningEnabled): (WebPreferences::setFrameSetFlatteningEnabled): * WebPreferences.h: * WebView.cpp: (WebView::notifyPreferencesChanged): 2010-02-10 Adam Roben Remove unnecessary #include of shfolder.h shfolder.h has been deprecated in newer versions of the Windows SDK. Fixes WebPreferences.cpp fails to compile under VS2010 RC due to #include of shfolder.h. Reviewed by Darin Adler. * WebPreferences.cpp: Removed #include. 2010-02-08 Charlie Reis Reviewed by Darin Adler. onbeforeunload not called at window close + frame or iframe focused https://bugs.webkit.org/show_bug.cgi?id=27481 Chromium and WebKit on Windows will now fire beforeunload handlers even if an inner frame is focused. Layout tests aren't able to test this bug, since it requires closing the actual browser window, not calling window.close(). Instead, test with WebCore/manual-tests/onbeforeunload-focused-iframe.html. * WebView.cpp: (WebView::shouldClose): 2010-02-08 Brent Fulgham Reviewed by Adam Roben. Include header position in World Transform used for plugin positioning. https://bugs.webkit.org/show_bug.cgi?id=34709 * WebFrame.cpp: (WebFrame::spoolPage): Correct WinCairo plugin print positioning to account for header size. Existing code ignored this, causing plugins to overlay other elements. 2010-02-04 Alice Liu Reviewed by Jon Honeycutt. https://bugs.webkit.org/show_bug.cgi?id=34612 " MSAA: accSelect returns error codes for most elements that arent listbox or menupopup related" * AccessibleBase.cpp: (AccessibleBase::accSelect): - Stop sending E_INVALIDARG for elements that request TAKE_SELECTION that aren't beneath listboxes or menupopups. This was too restrictive since any element can be selectable. - Correct the misinterpretation of MSDN's stipulation of situations involving adding, removing, and extending selection on single-select elements 2010-02-04 Brent Fulgham Reviewed by Adam Roben. Properly handle margin settings when printing Plugins in WinCairo. https://bugs.webkit.org/show_bug.cgi?id=34613 * WebFrame.cpp: (WebFrame::spoolPage): Adjust the GraphicsContext passed to the paintContents method so that the World Transform is properly positioned to account for margin settings at the time that PluginViewWin.cpp processes the drawing operations. 2010-02-04 Brent Fulgham Reviewed by Adam Roben. Properly handle margin settings in WinCairo. https://bugs.webkit.org/show_bug.cgi?id=34545 * WebFrame.cpp: (scaleFactor): Require the margin information as an input parameter, and use them when computing the scaling factor. (WebFrame::drawHeader): Pass margin size to scaleFactor. (WebFrame::drawFooter): Pass margin size to scaleFactor. (WebFrame::spoolPage): 1. Pass margin size to scaleFactor. 2. Recognize that the return value of printerMarginRect is already in device units, and therefore scale it so that the Cairo drawing is correct. 3. Remove scaling call for margins in GDI code, as it is already in scaled units. 2010-02-03 Brian Weinstein Reviewed by Steve Falkenburg. Scroll does not work with IBM Thinkpad. When initializing the WebView, add two scrollbar Windows inside of our WebView, to allow it to receive WM_VSCROLL and WM_HSCROLL events. (similar to what Firefox did in: . Only do this if the user has installed some kind of Trackpoint driver, using an algorithm like . Also, add code to handle WM_HSCROLL and WM_VSCROLL messages to scroll the WebView. * WebView.cpp: (WebView::verticalScroll): Handle the WM_VSCROLL messages, and scroll up and down by lines or pages. (WebView::horizontalScroll): Handle the WM_HSCROLL messages, and scroll left or right by lines or pages. (WebView::WebViewWndProc): Add cases for WM_VSCROLL and WM_HSCROLL. (WebView::initWithFrame): Call shouldInitializeTrackPointHack, and if we should, create vertical and horizontal scrollbars to receive WM_VSCROLL and WM_HSCROLL messages. (WebView::shouldInitializeTrackPointHack): Check if there is a registry key for the some kind of IBM Trackpoint driver. * WebView.h: 2010-02-02 Steve Falkenburg Reviewed by Darin Adler. Copyright year updating for Windows version resources should be automatic https://bugs.webkit.org/show_bug.cgi?id=34503 * WebKit.vcproj/WebKit.rc: 2010-02-02 Adam Roben Stop copying WebCore's IDL files from SRCROOT to OBJROOT WebKit doesn't use these anymore (as of r52921). Part of Bug 34496: Clean up WebCore's IDL/script copying Reviewed by Steve Falkenburg. * WebKit.vcproj/WebKit.make: 2010-01-29 Gavin Barraclough Reviewed by Sam Weinig + Oliver Hunt. Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds Pass processeing user gensture flag to media play/pause methods. * FullscreenVideoController.cpp: (FullscreenVideoController::play): (FullscreenVideoController::pause): 2010-01-29 Brian Weinstein Reviewed by Adam Roben. Drag and Drop: Windows uses "stop" sign as cursor when dragging https://bugs.webkit.org/show_bug.cgi?id=34305 Add a preference in WebKit (that defaults to false), for whether or not we should show the custom cursors during drag and drop. However, this is currently only used on Windows, and only used to hide the "drop not allowed" icon inside the WebView is the preference is set to true. This will be off by default, so no change in behavior. * Interfaces/IWebPreferencesPrivate.idl: Added new functions. * Interfaces/WebKit.idl: Touched to force Interfaces build. * WebDropSource.cpp: (WebDropSource::GiveFeedback): Implementation of conditional showing cursor logic. * WebPreferenceKeysPrivate.h: Added new preference key. * WebPreferences.cpp: Added new functions. (WebPreferences::setCustomDragCursorsEnabled): (WebPreferences::customDragCursorsEnabled): * WebPreferences.h: Added new functions. 2010-01-28 Jon Honeycutt MSAA: Crash when posting a notification for a detached object https://bugs.webkit.org/show_bug.cgi?id=34309 Reviewed by Darin Adler. * AccessibleBase.cpp: (AccessibleBase::QueryService): If an unrecognized service ID is passed, return early. Otherwise, return the result of QueryInterface. (AccessibleBase::QueryInterface): Add static_casts. Check for new UUIDs. (AccessibleBase::isSameObject): Query the object for AccessibleBase. Return whether the pointers or the wrapped objects match. * AccessibleBase.h: Give the class a UUID so we can query for it in isSameObject(). Inherit from IAccessibleComparable; inherit from IServiceProvider so clients can use QueryService to query for a custom interface. * Interfaces/AccessibleComparable.idl: Added. Declares a function that can be called to compare to accessible objects. * Interfaces/WebKit.idl: Include the new IDL. * WebKit.vcproj/Interfaces.vcproj: Add the new IDL to the project. 2010-01-27 Aaron Boodman Expand NotificationCenter::checkPermission() interface. It now passes the full URL instead of just the origin. https://bugs.webkit.org/show_bug.cgi?id=34238 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::checkPermission): * WebCoreSupport/WebDesktopNotificationsDelegate.h: 2010-01-27 Adam Roben Make it possible to instantiate WebSerializedJSValue using WebKitCreateInstance Reviewed by Dave Hyatt. * ForEachCoClass.h: * WebKitClassFactory.cpp: Added WebSerializedJSValue. 2010-01-26 Steve Falkenburg Reviewed by Oliver Hunt. Windows build references non-existent include paths https://bugs.webkit.org/show_bug.cgi?id=34175 * WebKit.vcproj/WebKit.vcproj: 2010-01-25 Steve Falkenburg Reviewed by Simon Fraser. A WebGeolocationControllerClient is leaked for every WebView https://bugs.webkit.org/show_bug.cgi?id=34145 * WebCoreSupport/WebGeolocationControllerClient.cpp: (WebGeolocationControllerClient::geolocationDestroyed): Added. * WebCoreSupport/WebGeolocationControllerClient.h: 2010-01-23 Dan Bernstein Reviewed by Maciej Stachowiak. svg/custom/text-zoom.xhtml fails on Windows https://bugs.webkit.org/show_bug.cgi?id=34006 * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Added WebKitZoomsTextOnlyPreferenceKey with a default value of true. 2010-01-20 Steve Falkenburg Reviewed by Sam Weinig. Add missing implementation for WebGeolocationPosition::initWithTimestamp. * WebGeolocationPosition.cpp: (WebGeolocationPosition::initWithTimestamp): Implemented. 2010-01-20 Jon Honeycutt MSAA: accSelect() is not implemented https://bugs.webkit.org/show_bug.cgi?id=33918 Reviewed by Darin Adler. * AccessibleBase.cpp: (AccessibleBase::accSelect): If there is an invalid combination of state flags, return early. If the caller passed the "take focus" flag, focus the object. If the "take selection" flag was passed, check whether the parent object is an AccessibilityListBox; if so, call the object's setSelectedChildren() function. If the parent is an AccessibilityMenuListPopup, call the child object's setSelected() function. Otherwise, if the parent is some other, unsupported object, return early. If the selection flags include "add", "remove", or "extend" selection, and the parent object is not multi-selectable, return early. Otherwise, set or unset the child's selected flag based on the passed flag. 2010-01-20 Steve Falkenburg Reviewed by Darin Adler and Adam Roben. Feature defines are difficult to maintain on Windows builds https://bugs.webkit.org/show_bug.cgi?id=33883 FeatureDefines.vsprops are now maintained in a way similar to Configurations/FeatureDefines.xcconfig, with the added advantage of having a single FeatureDefines file across all projects. * WebKit.vcproj/Interfaces.vcproj: Add FeatureDefines.vsprops inherited property sheet. * WebKit.vcproj/WebKit.sln: Set up Cairo configuration for WebCoreGenerated. * WebKit.vcproj/WebKit.vcproj: Remove ENABLE_ preprocessor definitions. Add FeatureDefines.vsprops inherited property sheet. * WebKit.vcproj/WebKitGUID.vcproj: Add FeatureDefines.vsprops inherited property sheet. 2010-01-17 Jon Honeycutt MSAA: The child